RE: Dynamic Configuration
The following excerpt from The complete log4j manual should help you understand the observed behavior. Reloading configuration files: Reloading of a configuration file or reconfiguration of log4j from a different con-figuration file is allowed. It is also thread-safe. Contrary to expected behavior, dur-ing reconfiguration, log4j configurators do not reset the existing configuration. The rationale behind this somewhat unexpected behavior is to allow incremental changes to the configuration. Reconfiguration has obviously some effect on the existing configuration. In particular, all appenders of any logger explicitly mentioned in the new configuration will be closed and removed from the logger. However, loggers which are not mentioned in the new configuration remain untouched. All the more, appenders attached to such loggers remain attached after reconfiguration. For example, if an appender is attached to multiple loggers, it is possible for the appender to be closed during the reconfiguration but remain attached to a logger not mentioned in the second configuration file. If after reconfiguration you try to log to this closed appender, log4j will warn you about trying to log to a closed appender. At 11:26 AM 12/12/2003 +1100, you wrote: Problem 2: You mentioned that you get those messages as well sometimes, do you know why? It is possible that there might be some synchronization problem at the point of the call to a specific appender's close() method, and during the close, some logs try and come through to be appended. What type of Appender are you using (FileAppender? Daily*Appender?), and what version of log4j are you using? (the latest is log4j 1.2.8) cheers, Paul Smith -- Ceki Gülcü For log4j documentation consider The complete log4j manual ISBN: 2970036908 http://www.qos.ch/shop/products/clm_t.jsp - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Dynamic Configuration
Anyone? I'm really lost here ... TIA -Original Message- From: Shimi Avizmil Sent: Thursday, 11 December 2003 3:29 PM To: '[EMAIL PROTECTED]' Subject: Dynamic Configuration Hi all, I spent few hours going through the past messages, but I couldn't find an answer to my problems. Problem 1: I have few ejbs under weblogic that get the log throught getClass().getName() and keep a copy locally. (Not static) My first problem is that the log messages are appearing under incorrect class name, i.e. 14:39:11,701 [main] INFO ejbA - I'm ejb B Why is that? problem 2: I wrote a swing gui that you can load a new properties file remotely to my app on the weblogic server and it calls PropertyConfigurator.configure(props) with the new properties. After I do that I get a lot of ERRORS: trying to append to a closed appender... Why does that happen? is that because I cache the logger reference in stead of fetching it every time? should I make it static? if I'll make it static, will it effect the gc from collecting it? Thanks for the help. Cheers Shimi - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Dynamic Configuration
Problem 1: I think we'll need to see the code where you initialise the logger, and where you do the actual logging. Storing a local reference to the logger is fine, and the recommended practice. If you make it static, even better, I am not sure why you would want the GC to collect it. Problem 2: I have seen this message myself and might be due to some code logging at the same time as the new properties are being applied. If the configuration effectively changes an appenders configuration, log4j must stop/close the old appender before creating a new instance with the new config. Paul On Fri, 2003-12-12 at 10:34, Shimi Avizmil wrote: Anyone? I'm really lost here ... TIA -Original Message- From: Shimi Avizmil Sent: Thursday, 11 December 2003 3:29 PM To: '[EMAIL PROTECTED]' Subject:Dynamic Configuration Hi all, I spent few hours going through the past messages, but I couldn't find an answer to my problems. Problem 1: I have few ejbs under weblogic that get the log throught getClass().getName() and keep a copy locally. (Not static) My first problem is that the log messages are appearing under incorrect class name, i.e. 14:39:11,701 [main] INFO ejbA - I'm ejb B Why is that? problem 2: I wrote a swing gui that you can load a new properties file remotely to my app on the weblogic server and it calls PropertyConfigurator.configure(props) with the new properties. After I do that I get a lot of ERRORS: trying to append to a closed appender... Why does that happen? is that because I cache the logger reference in stead of fetching it every time? should I make it static? if I'll make it static, will it effect the gc from collecting it? Thanks for the help. Cheers Shimi - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Dynamic Configuration
First of all thanks for the reply ! Problem 1: private Log log = MySystem.getLog(getClass().getName()); I'm not talking about gc the logger, I'm talking about a case where if I have an object that has a static logger reference, and this object is not used anymore, will this object get gced? I don't think so...if it won't, I don't think it's a good practice to keep a static reference. Any idea, why it is logging under other class name? has anyone seen this before? Problem 1: I'm still not clear about this one. I saw in one of the archive messages that changing the appenders is not supported, is this true? Thanks Shimi -Original Message- From: Paul Smith [mailto:[EMAIL PROTECTED] Sent: Friday, 12 December 2003 10:43 AM To: Log4J Users List Subject: RE: Dynamic Configuration Problem 1: I think we'll need to see the code where you initialise the logger, and where you do the actual logging. Storing a local reference to the logger is fine, and the recommended practice. If you make it static, even better, I am not sure why you would want the GC to collect it. Problem 2: I have seen this message myself and might be due to some code logging at the same time as the new properties are being applied. If the configuration effectively changes an appenders configuration, log4j must stop/close the old appender before creating a new instance with the new config. Paul On Fri, 2003-12-12 at 10:34, Shimi Avizmil wrote: Anyone? I'm really lost here ... TIA -Original Message- From: Shimi Avizmil Sent: Thursday, 11 December 2003 3:29 PM To: '[EMAIL PROTECTED]' Subject:Dynamic Configuration Hi all, I spent few hours going through the past messages, but I couldn't find an answer to my problems. Problem 1: I have few ejbs under weblogic that get the log throught getClass().getName() and keep a copy locally. (Not static) My first problem is that the log messages are appearing under incorrect class name, i.e. 14:39:11,701 [main] INFO ejbA - I'm ejb B Why is that? problem 2: I wrote a swing gui that you can load a new properties file remotely to my app on the weblogic server and it calls PropertyConfigurator.configure(props) with the new properties. After I do that I get a lot of ERRORS: trying to append to a closed appender... Why does that happen? is that because I cache the logger reference in stead of fetching it every time? should I make it static? if I'll make it static, will it effect the gc from collecting it? Thanks for the help. Cheers Shimi - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Dynamic Configuration
On Fri, 2003-12-12 at 10:59, Shimi Avizmil wrote: First of all thanks for the reply ! Problem 1: private Log log = MySystem.getLog(getClass().getName()); I'm not talking about gc the logger, I'm talking about a case where if I have an object that has a static logger reference, and this object is not used anymore, will this object get gced? I don't think so...if it won't, I don't think it's a good practice to keep a static reference. When you have: private static final Logger LOG = Logger.getLogger(TheClass.class); The LOG instance is kept with the _class_ and not with the instance of the class, and hence will have no bearing on the GC'ing of the instance(s). Each instance does not hold onto refs of static vars, but has access to them when needed via it's Class instance. I'm still not clear about this one. I saw in one of the archive messages that changing the appenders is not supported, is this true? I tweak the appenders of our App through a property file all the time, and it dynamically closes, creates a new appender and configures it without a server restart. I do this a lot. It's not a problem. Paul - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Dynamic Configuration
Problem 1: thanks for that Paul, makes sense. I'll give it a go and see if it fixes the problem. Problem 2: You mentioned that you get those messages as well sometimes, do you know why? -Original Message- From: Paul Smith [mailto:[EMAIL PROTECTED] Sent: Friday, 12 December 2003 11:11 AM To: Log4J Users List Subject: RE: Dynamic Configuration On Fri, 2003-12-12 at 10:59, Shimi Avizmil wrote: First of all thanks for the reply ! Problem 1: private Log log = MySystem.getLog(getClass().getName()); I'm not talking about gc the logger, I'm talking about a case where if I have an object that has a static logger reference, and this object is not used anymore, will this object get gced? I don't think so...if it won't, I don't think it's a good practice to keep a static reference. When you have: private static final Logger LOG = Logger.getLogger(TheClass.class); The LOG instance is kept with the _class_ and not with the instance of the class, and hence will have no bearing on the GC'ing of the instance(s). Each instance does not hold onto refs of static vars, but has access to them when needed via it's Class instance. I'm still not clear about this one. I saw in one of the archive messages that changing the appenders is not supported, is this true? I tweak the appenders of our App through a property file all the time, and it dynamically closes, creates a new appender and configures it without a server restart. I do this a lot. It's not a problem. Paul - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Dynamic Configuration
Problem 2: You mentioned that you get those messages as well sometimes, do you know why? It is possible that there might be some synchronization problem at the point of the call to a specific appender's close() method, and during the close, some logs try and come through to be appended. What type of Appender are you using (FileAppender? Daily*Appender?), and what version of log4j are you using? (the latest is log4j 1.2.8) cheers, Paul Smith - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Dynamic Configuration
-Original Message- From: Paul Smith [mailto:[EMAIL PROTECTED] Sent: Friday, 12 December 2003 11:27 AM To: Log4J Users List Subject: RE: Dynamic Configuration Problem 2: You mentioned that you get those messages as well sometimes, do you know why? It is possible that there might be some synchronization problem at the point of the call to a specific appender's close() method, and during the close, some logs try and come through to be appended. [SHIMI] so how do you get around it? What type of Appender are you using (FileAppender? Daily*Appender?), and what version of log4j are you using? (the latest is log4j 1.2.8) [SHIMI]DailyFileApp and consoleApp.. cheers, Paul Smith - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Dynamic Configuration
what exactly do you mean by dynamic configuration? Changing of log levels or something more? Nigel -- Nigel Byrnes E-Commerce, Direct Line 0845 878 2922 [EMAIL PROTECTED] e.comTo: [EMAIL PROTECTED] cc: 18/09/2003 14:25 Subject: Dynamic Configuration Please respond to Log4J Users List I am new to the list and if the following question has been answered before - please point me to it. I did search the archives though and did not find a comprehensive response to this. Unfortunately i need the information urgently - kind of a last minute change of scope for the project. Any help will be appreciated... What is better - using MBeans or configureAndWatch ? I am using log4j in a web application running on WebLogic 8.1. Reading weblogic documentation, it seems like deamon threads are discouraged. http://e-docs.bea.com/wls/docs81/programming/topics.html#1062897 How robust is the JMX Implementation in log4j ? Any examples / best practices around the use of log4J MBeans ? Shuchi Direct Line Group Services Limited, registered in England no.3001989, registered office 3 Edridge Road, Croydon, Surrey, CR9 1AG. The following are also members of the Direct Line group of companies: Direct Line Insurance plc, a member of the General Insurance Standards Council and Direct Line Life Insurance Company Limited and Direct Line Unit Trusts Limited, both regulated by the Financial Services Authority. Loans, Mortgages, Credit Cards and Savings provided by Direct Line Financial Services Limited, registered in England number 2372702, registered office 3 Edridge Road, Croydon, Surrey, CR9 1AG. All are members of The Royal Bank of Scotland Group. This e-mail is intended for the addressee only and may contain confidential, proprietary or legally privileged information. If you are not the intended recipient of this e-mail, you should notify us immediately and delete it. You should not copy, print, distribute, disclose or use any part of it. We reserve the right to monitor and record all electronic communications through our networks. We cannot accept any liability for viruses transmitted via this e-mail once it has left our networks. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Dynamic Configuration
Primarily changing log level. But the ability to modify appender properties (log filename/destination) and also change appenders is on the cards for the next iteration for the project. Shuchi [EMAIL PROTECTED] [EMAIL PROTECTED] 09/18/2003 09:46 AM Please respond to Log4J Users List To: Log4J Users List [EMAIL PROTECTED] cc: Subject: Re: Dynamic Configuration what exactly do you mean by dynamic configuration? Changing of log levels or something more? Nigel -- Nigel Byrnes E-Commerce, Direct Line 0845 878 2922 [EMAIL PROTECTED] e.comTo: [EMAIL PROTECTED] cc: 18/09/2003 14:25 Subject: Dynamic Configuration Please respond to Log4J Users List I am new to the list and if the following question has been answered before - please point me to it. I did search the archives though and did not find a comprehensive response to this. Unfortunately i need the information urgently - kind of a last minute change of scope for the project. Any help will be appreciated... What is better - using MBeans or configureAndWatch ? I am using log4j in a web application running on WebLogic 8.1. Reading weblogic documentation, it seems like deamon threads are discouraged. http://e-docs.bea.com/wls/docs81/programming/topics.html#1062897 How robust is the JMX Implementation in log4j ? Any examples / best practices around the use of log4J MBeans ? Shuchi Direct Line Group Services Limited, registered in England no.3001989, registered office 3 Edridge Road, Croydon, Surrey, CR9 1AG. The following are also members of the Direct Line group of companies: Direct Line Insurance plc, a member of the General Insurance Standards Council and Direct Line Life Insurance Company Limited and Direct Line Unit Trusts Limited, both regulated by the Financial Services Authority. Loans, Mortgages, Credit Cards and Savings provided by Direct Line Financial Services Limited, registered in England number 2372702, registered office 3 Edridge Road, Croydon, Surrey, CR9 1AG. All are members of The Royal Bank of Scotland Group. This e-mail is intended for the addressee only and may contain confidential, proprietary or legally privileged information. If you are not the intended recipient of this e-mail, you should notify us immediately and delete it. You should not copy, print, distribute, disclose or use any part of it. We reserve the right to monitor and record all electronic communications through our networks. We cannot accept any liability for viruses transmitted via this e-mail once it has left our networks. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Dynamic Configuration
in the jakarta-log4j-sandbox cvs module, the ConfigurationServlet will allow you to change log levels at runtime. Changing Appender properties is something that is not currently supported. Depending on your requirements, I'd recommend writing custom Appenders and/or Filters which can be chained together to meet most needs. Nigel -- Nigel Byrnes E-Commerce, Direct Line 0845 878 2922 [EMAIL PROTECTED] e.comTo: Log4J Users List [EMAIL PROTECTED] cc: 18/09/2003 14:52 Subject: Re: Dynamic Configuration Please respond to Log4J Users List Primarily changing log level. But the ability to modify appender properties (log filename/destination) and also change appenders is on the cards for the next iteration for the project. Shuchi [EMAIL PROTECTED] Nigel.Byrnes @directline. To: Log4J Users List com [EMAIL PROTECTED] rg cc: 09/18/2003 Subject: Re: Dynamic 09:46 AM Configuration Please respond to Log4J Users List what exactly do you mean by dynamic configuration? Changing of log levels or something more? Nigel -- Nigel Byrnes E-Commerce, Direct Line 0845 878 2922 [EMAIL PROTECTED] e.com To: [EMAIL PROTECTED] cc: 18/09/2003 14:25 Subject: Dynamic Configuration Please respond to Log4J Users List I am new to the list and if the following question has been answered before - please point me to it. I did search the archives though and did not find a comprehensive response to this. Unfortunately i need the information urgently - kind of a last minute change of scope for the project. Any help will be appreciated... What is better - using MBeans or configureAndWatch ? I am using log4j in a web application running on WebLogic 8.1. Reading weblogic documentation, it seems like deamon threads are discouraged. http://e-docs.bea.com/wls/docs81/programming/topics.html#1062897 How robust is the JMX Implementation in log4j ? Any examples / best practices around the use of log4J MBeans ? Shuchi Direct Line Group Services Limited, registered in England no.3001989, registered office 3 Edridge Road, Croydon, Surrey, CR9 1AG. The following are also members of the Direct Line group of companies: Direct Line Insurance plc, a member of the General Insurance Standards Council and Direct Line Life Insurance Company Limited and Direct Line Unit Trusts Limited, both regulated by the Financial Services Authority. Loans, Mortgages, Credit Cards and Savings provided by Direct Line Financial Services Limited, registered in England number 2372702, registered office 3 Edridge Road, Croydon, Surrey, CR9 1AG. All are members of The Royal Bank of Scotland Group. This e-mail is intended for the addressee only and may contain confidential, proprietary or legally privileged information. If you are not the intended recipient of this e-mail, you should notify us immediately and delete it. You should not copy, print, distribute, disclose or use any part of it. We reserve the right to monitor and record all electronic communications through our networks. We cannot accept any liability for viruses transmitted via this e-mail once it has left our networks
Re: Dynamic Configuration
Although the Configuration servlet does seem to handle levels, there are a couple of issues. First of all, the solution works well for a single application instance BUT does not work for a cluster deployment. Secondly, it adds another console for the operations staff to use. We want to steer away from multiple mgmt consoles for a single application. Using configureAndWatch would eliminate the above issues - we could push the file out to multiple servers using cfengine or another similar tool. But BEA does not recommend using deamon threads and configureAndWatch is just that. Having said all that - it seems like MBeans may be a more viable option. Can anyone provide sample code on how to use log4J MBeans ? The javadocs dont tell much. Thanks a bunch Shuchi [EMAIL PROTECTED] [EMAIL PROTECTED] 09/18/2003 09:58 AM Please respond to Log4J Users List To: Log4J Users List [EMAIL PROTECTED] cc: Subject: Re: Dynamic Configuration in the jakarta-log4j-sandbox cvs module, the ConfigurationServlet will allow you to change log levels at runtime. Changing Appender properties is something that is not currently supported. Depending on your requirements, I'd recommend writing custom Appenders and/or Filters which can be chained together to meet most needs. Nigel -- Nigel Byrnes E-Commerce, Direct Line 0845 878 2922 [EMAIL PROTECTED] e.comTo: Log4J Users List [EMAIL PROTECTED] cc: 18/09/2003 14:52 Subject: Re: Dynamic Configuration Please respond to Log4J Users List Primarily changing log level. But the ability to modify appender properties (log filename/destination) and also change appenders is on the cards for the next iteration for the project. Shuchi [EMAIL PROTECTED] Nigel.Byrnes @directline. To: Log4J Users List com [EMAIL PROTECTED] rg cc: 09/18/2003 Subject: Re: Dynamic 09:46 AM Configuration Please respond to Log4J Users List what exactly do you mean by dynamic configuration? Changing of log levels or something more? Nigel -- Nigel Byrnes E-Commerce, Direct Line 0845 878 2922 [EMAIL PROTECTED] e.com To: [EMAIL PROTECTED] cc: 18/09/2003 14:25 Subject: Dynamic Configuration Please respond to Log4J Users List I am new to the list and if the following question has been answered before - please point me to it. I did search the archives though and did not find a comprehensive response to this. Unfortunately i need the information urgently - kind of a last minute change of scope for the project. Any help will be appreciated... What is better - using MBeans or configureAndWatch ? I am using log4j in a web application running on WebLogic 8.1. Reading weblogic documentation, it seems like deamon threads are discouraged. http://e-docs.bea.com/wls/docs81/programming/topics.html#1062897 How robust is the JMX Implementation in log4j ? Any examples / best practices around the use of log4J MBeans ? Shuchi Direct Line Group Services Limited, registered in England no.3001989, registered office 3 Edridge Road, Croydon, Surrey, CR9 1AG. The following are also members of the Direct Line group of companies: Direct Line Insurance
RE: Dynamic Configuration
I havent worked with the Log4J MBeans yet but I would think they are to be used the same way that you would use custom MBeans in Weblogic. Register them using Startup class. Use HTMLAdaptor/CM4jView/WLShell to view and manage the operations/properties of the MBean. Let us know how it goes. Madhu -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, September 18, 2003 1:39 PM To: Log4J Users List Subject: Re: Dynamic Configuration Although the Configuration servlet does seem to handle levels, there are a couple of issues. First of all, the solution works well for a single application instance BUT does not work for a cluster deployment. Secondly, it adds another console for the operations staff to use. We want to steer away from multiple mgmt consoles for a single application. Using configureAndWatch would eliminate the above issues - we could push the file out to multiple servers using cfengine or another similar tool. But BEA does not recommend using deamon threads and configureAndWatch is just that. Having said all that - it seems like MBeans may be a more viable option. Can anyone provide sample code on how to use log4J MBeans ? The javadocs dont tell much. Thanks a bunch Shuchi Inactive hide details for [EMAIL PROTECTED]@directline.com [EMAIL PROTECTED] 09/18/2003 09:58 AM Please respond to Log4J Users List To: Log4J Users List [EMAIL PROTECTED] cc: Subject: Re: Dynamic Configuration in the jakarta-log4j-sandbox cvs module, the ConfigurationServlet will allow you to change log levels at runtime. Changing Appender properties is something that is not currently supported. Depending on your requirements, I'd recommend writing custom Appenders and/or Filters which can be chained together to meet most needs. Nigel -- Nigel Byrnes E-Commerce, Direct Line 0845 878 2922 [EMAIL PROTECTED] e.com To: Log4J Users List [EMAIL PROTECTED] cc: 18/09/2003 14:52 Subject: Re: Dynamic Configuration Please respond to Log4J Users List Primarily changing log level. But the ability to modify appender properties (log filename/destination) and also change appenders is on the cards for the next iteration for the project. Shuchi [EMAIL PROTECTED] Nigel.Byrnes @directline. To: Log4J Users List com [EMAIL PROTECTED] rg cc: 09/18/2003 Subject: Re: Dynamic 09:46 AM Configuration Please respond to Log4J Users List what exactly do you mean by dynamic configuration? Changing of log levels or something more? Nigel -- Nigel Byrnes E-Commerce, Direct Line 0845 878 2922 [EMAIL PROTECTED] e.com To: [EMAIL PROTECTED] cc: 18/09/2003 14:25 Subject: Dynamic Configuration Please respond to Log4J Users List I am new to the list and if the following question has been answered before - please point me to it. I did search the archives though and did not find a comprehensive response to this. Unfortunately i need the information urgently - kind of a last minute change of scope for the project. Any help will be appreciated... What is better - using MBeans or configureAndWatch ? I am using log4j in a web application running on WebLogic 8.1. Reading weblogic documentation, it seems like deamon threads are discouraged. http://e-docs.bea.com/wls/docs81/programming/topics.html#1062897 http://e-docs.bea.com/wls/docs81/programming/topics.html#1062897 How robust is the JMX Implementation in log4j ? Any examples / best practices around the use of log4J MBeans ? Shuchi Direct Line Group Services Limited, registered in England no.3001989, registered office 3 Edridge Road, Croydon, Surrey, CR9 1AG. The following are also members of the Direct Line group of companies: Direct Line Insurance plc, a member of the General Insurance Standards Council and Direct Line Life Insurance Company Limited and Direct Line Unit Trusts Limited, both regulated by the Financial Services Authority. Loans, Mortgages, Credit Cards and Savings provided by Direct Line Financial Services Limited, registered in England number 2372702, registered office 3 Edridge Road, Croydon, Surrey, CR9 1AG. All are members of The Royal Bank of Scotland Group. This e-mail is intended for the addressee only and may contain confidential, proprietary or legally privileged information. If you are not the intended recipient of this e-mail, you should notify us immediately and delete it. You should not copy, print, distribute, disclose or use any part of it. We reserve the right to monitor and record all electronic communications through our networks. We cannot accept any liability for viruses transmitted via this e-mail once it has left our networks. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Direct Line Group Services Limited, registered in England no.3001989, registered office 3 Edridge Road, Croydon, Surrey, CR9
