[jira] [Comment Edited] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not
[ https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375927#comment-15375927 ] Charles Lowell edited comment on LOG4NET-467 at 7/13/16 10:39 PM: -- I've attached the contents of my pull request (#16) as a patch. was (Author: chlowe): Patch containing GitHub Pull Request #16 > Is .NET Core, will be supported in the near future, or not > -- > > Key: LOG4NET-467 > URL: https://issues.apache.org/jira/browse/LOG4NET-467 > Project: Log4net > Issue Type: New Feature > Components: Core >Affects Versions: 1.2.13 >Reporter: san kan > Labels: features > Attachments: LOG4NET-467.patch > > > As you know, ms is moving heavily toward .Net core: > https://github.com/dotnet/core > so, is there a road map for making a version that supports it? > and i noticed that log4net, has not been updated for 2 years. > so is it maintained, or being forgotten? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not
[ https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles Lowell updated LOG4NET-467: --- Attachment: LOG4NET-467.patch Patch containing GitHub Pull Request #16 > Is .NET Core, will be supported in the near future, or not > -- > > Key: LOG4NET-467 > URL: https://issues.apache.org/jira/browse/LOG4NET-467 > Project: Log4net > Issue Type: New Feature > Components: Core >Affects Versions: 1.2.13 >Reporter: san kan > Labels: features > Attachments: LOG4NET-467.patch > > > As you know, ms is moving heavily toward .Net core: > https://github.com/dotnet/core > so, is there a road map for making a version that supports it? > and i noticed that log4net, has not been updated for 2 years. > so is it maintained, or being forgotten? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not
[
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375230#comment-15375230
]
ASF GitHub Bot commented on LOG4NET-467:
Github user chlowell commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r70652017
--- Diff: src/Util/ReadOnlyPropertiesDictionary.cs ---
@@ -215,8 +216,13 @@ public virtual void GetObjectData(SerializationInfo
info, StreamingContext conte
string entryKey = entry.Key as string;
object entryValue = entry.Value;
- // If value is serializable then we add it to
the list
- if (entryKey != null && entryValue != null &&
entryValue.GetType().IsSerializable)
+// If value is serializable then we add it to the list
+#if NETSTANDARD1_3
+ bool isSerializable =
entryValue.GetType().GetTypeInfo().IsSerializable;
+#else
+bool isSerializable = entryValue.GetType().IsSerializable;
+#endif
+if (entryKey != null && entryValue != null &&
isSerializable)
{
--- End diff --
The original code mixes tabs and spaces freely. I tried to remain
consistent with that to limit whitespace noise in the diff. I'll normalize the
lines you've called out; thanks for the attention to detail.
> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
> Issue Type: New Feature
> Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
> Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] log4net pull request #16: (LOG4NET-467) .NET Core support
Github user chlowell commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r70652017
--- Diff: src/Util/ReadOnlyPropertiesDictionary.cs ---
@@ -215,8 +216,13 @@ public virtual void GetObjectData(SerializationInfo
info, StreamingContext conte
string entryKey = entry.Key as string;
object entryValue = entry.Value;
- // If value is serializable then we add it to
the list
- if (entryKey != null && entryValue != null &&
entryValue.GetType().IsSerializable)
+// If value is serializable then we add it to the list
+#if NETSTANDARD1_3
+ bool isSerializable =
entryValue.GetType().GetTypeInfo().IsSerializable;
+#else
+bool isSerializable = entryValue.GetType().IsSerializable;
+#endif
+if (entryKey != null && entryValue != null &&
isSerializable)
{
--- End diff --
The original code mixes tabs and spaces freely. I tried to remain
consistent with that to limit whitespace noise in the diff. I'll normalize the
lines you've called out; thanks for the attention to detail.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] log4net issue #16: (LOG4NET-467) .NET Core support
Github user jasonwilliams200OK commented on the issue: https://github.com/apache/log4net/pull/16 > @arkadiuszwojcik the goal of this PR is to make log4net portable across .NET Core platforms. Implementing those abstractions could be useful, but doing so wouldn't enable consuming log4net on additional platforms. I agree and I think that can be a separate repo / package, something like log4net.Extensions.Logging. However, having this Extensions package first hand from original vendor (Apache) is vital on multiple accounts. --- Separately, can this PR get some prio love from the reviews please? All the providers listed here: https://github.com/aspnet/Logging#providers, are not as popular as log4net and we (folks running stuff on dotnet core) hoping to get our hands on apache/log4net bits. @chlowell, could you please prepare a SVN patch for the reviewers? We can always have subsequent PRs to refine stuff. If you are aiming to add CI setup for .NET Core TxM as part of this PR, feel free to grab Travis/AppVeyor bits from https://github.com/autofac/Autofac.Extras.Moq/pull/6/files. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not
[ https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375066#comment-15375066 ] ASF GitHub Bot commented on LOG4NET-467: Github user jasonwilliams200OK commented on the issue: https://github.com/apache/log4net/pull/16 > @arkadiuszwojcik the goal of this PR is to make log4net portable across .NET Core platforms. Implementing those abstractions could be useful, but doing so wouldn't enable consuming log4net on additional platforms. I agree and I think that can be a separate repo / package, something like log4net.Extensions.Logging. However, having this Extensions package first hand from original vendor (Apache) is vital on multiple accounts. --- Separately, can this PR get some prio love from the reviews please? All the providers listed here: https://github.com/aspnet/Logging#providers, are not as popular as log4net and we (folks running stuff on dotnet core) hoping to get our hands on apache/log4net bits. @chlowell, could you please prepare a SVN patch for the reviewers? We can always have subsequent PRs to refine stuff. If you are aiming to add CI setup for .NET Core TxM as part of this PR, feel free to grab Travis/AppVeyor bits from https://github.com/autofac/Autofac.Extras.Moq/pull/6/files. > Is .NET Core, will be supported in the near future, or not > -- > > Key: LOG4NET-467 > URL: https://issues.apache.org/jira/browse/LOG4NET-467 > Project: Log4net > Issue Type: New Feature > Components: Core >Affects Versions: 1.2.13 >Reporter: san kan > Labels: features > > As you know, ms is moving heavily toward .Net core: > https://github.com/dotnet/core > so, is there a road map for making a version that supports it? > and i noticed that log4net, has not been updated for 2 years. > so is it maintained, or being forgotten? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] log4net issue #16: (LOG4NET-467) .NET Core support
Github user stuartd commented on the issue: https://github.com/apache/log4net/pull/16 [ToUpperInvariant](http://stackoverflow.com/questions/2801508/what-is-wrong-with-tolowerinvariant) is preferable --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not
[ https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375022#comment-15375022 ] ASF GitHub Bot commented on LOG4NET-467: Github user stuartd commented on the issue: https://github.com/apache/log4net/pull/16 [ToUpperInvariant](http://stackoverflow.com/questions/2801508/what-is-wrong-with-tolowerinvariant) is preferable > Is .NET Core, will be supported in the near future, or not > -- > > Key: LOG4NET-467 > URL: https://issues.apache.org/jira/browse/LOG4NET-467 > Project: Log4net > Issue Type: New Feature > Components: Core >Affects Versions: 1.2.13 >Reporter: san kan > Labels: features > > As you know, ms is moving heavily toward .Net core: > https://github.com/dotnet/core > so, is there a road map for making a version that supports it? > and i noticed that log4net, has not been updated for 2 years. > so is it maintained, or being forgotten? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not
[
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374973#comment-15374973
]
ASF GitHub Bot commented on LOG4NET-467:
Github user niemyjski commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r70623307
--- Diff: src/Util/PatternStringConverters/NewLinePatternConverter.cs ---
@@ -72,6 +75,16 @@ internal sealed class NewLinePatternConverter :
LiteralPatternConverter, IOption
///
public void ActivateOptions()
{
+#if NETSTANDARD1_3
+ if
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "DOS",
CompareOptions.IgnoreCase) == 0)
+ {
+ Option = "\r\n";
+ }
+ else if
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "UNIX",
CompareOptions.IgnoreCase) == 0)
--- End diff --
ToLowerInvariant()
> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
> Issue Type: New Feature
> Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
> Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] log4net pull request #16: (LOG4NET-467) .NET Core support
Github user niemyjski commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r70623307
--- Diff: src/Util/PatternStringConverters/NewLinePatternConverter.cs ---
@@ -72,6 +75,16 @@ internal sealed class NewLinePatternConverter :
LiteralPatternConverter, IOption
///
public void ActivateOptions()
{
+#if NETSTANDARD1_3
+ if
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "DOS",
CompareOptions.IgnoreCase) == 0)
+ {
+ Option = "\r\n";
+ }
+ else if
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "UNIX",
CompareOptions.IgnoreCase) == 0)
--- End diff --
ToLowerInvariant()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not
[
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374800#comment-15374800
]
ASF GitHub Bot commented on LOG4NET-467:
Github user jasonwilliams200OK commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r70601430
--- Diff: src/Util/PatternStringConverters/NewLinePatternConverter.cs ---
@@ -72,6 +75,16 @@ internal sealed class NewLinePatternConverter :
LiteralPatternConverter, IOption
///
public void ActivateOptions()
{
+#if NETSTANDARD1_3
+ if
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "DOS",
CompareOptions.IgnoreCase) == 0)
+ {
+ Option = "\r\n";
+ }
+ else if
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "UNIX",
CompareOptions.IgnoreCase) == 0)
--- End diff --
Should we just ToLower(), compare with `==` and get rid of the
preprocessors for all Compare()-like code?
> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
> Issue Type: New Feature
> Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
> Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] log4net pull request #16: (LOG4NET-467) .NET Core support
Github user jasonwilliams200OK commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r70601430
--- Diff: src/Util/PatternStringConverters/NewLinePatternConverter.cs ---
@@ -72,6 +75,16 @@ internal sealed class NewLinePatternConverter :
LiteralPatternConverter, IOption
///
public void ActivateOptions()
{
+#if NETSTANDARD1_3
+ if
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "DOS",
CompareOptions.IgnoreCase) == 0)
+ {
+ Option = "\r\n";
+ }
+ else if
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "UNIX",
CompareOptions.IgnoreCase) == 0)
--- End diff --
Should we just ToLower(), compare with `==` and get rid of the
preprocessors for all Compare()-like code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not
[
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374796#comment-15374796
]
ASF GitHub Bot commented on LOG4NET-467:
Github user jasonwilliams200OK commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r70601024
--- Diff: src/Util/ReadOnlyPropertiesDictionary.cs ---
@@ -215,8 +216,13 @@ public virtual void GetObjectData(SerializationInfo
info, StreamingContext conte
string entryKey = entry.Key as string;
object entryValue = entry.Value;
- // If value is serializable then we add it to
the list
- if (entryKey != null && entryValue != null &&
entryValue.GetType().IsSerializable)
+// If value is serializable then we add it to the list
+#if NETSTANDARD1_3
+ bool isSerializable =
entryValue.GetType().GetTypeInfo().IsSerializable;
+#else
+bool isSerializable = entryValue.GetType().IsSerializable;
+#endif
+if (entryKey != null && entryValue != null &&
isSerializable)
{
--- End diff --
nit: indentation under `#if` `#else` and that of `if (entryKey` is off
> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
> Issue Type: New Feature
> Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
> Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] log4net pull request #16: (LOG4NET-467) .NET Core support
Github user jasonwilliams200OK commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r70601024
--- Diff: src/Util/ReadOnlyPropertiesDictionary.cs ---
@@ -215,8 +216,13 @@ public virtual void GetObjectData(SerializationInfo
info, StreamingContext conte
string entryKey = entry.Key as string;
object entryValue = entry.Value;
- // If value is serializable then we add it to
the list
- if (entryKey != null && entryValue != null &&
entryValue.GetType().IsSerializable)
+// If value is serializable then we add it to the list
+#if NETSTANDARD1_3
+ bool isSerializable =
entryValue.GetType().GetTypeInfo().IsSerializable;
+#else
+bool isSerializable = entryValue.GetType().IsSerializable;
+#endif
+if (entryKey != null && entryValue != null &&
isSerializable)
{
--- End diff --
nit: indentation under `#if` `#else` and that of `if (entryKey` is off
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not
[
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374791#comment-15374791
]
ASF GitHub Bot commented on LOG4NET-467:
Github user jasonwilliams200OK commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r70600785
--- Diff: tests/src/Utils.cs ---
@@ -105,7 +114,28 @@ private static Type[] GetTypesArray(object[] args)
internal static void RemovePropertyFromAllContexts() {
GlobalContext.Properties.Remove(PROPERTY_KEY);
ThreadContext.Properties.Remove(PROPERTY_KEY);
+#if !(NETCF || NETSTANDARD1_3)
LogicalThreadContext.Properties.Remove(PROPERTY_KEY);
+#endif
}
- }
+
+// Wrappers because repository/logger retrieval APIs require an
Assembly argument on NETSTANDARD1_3
+internal static ILog GetLogger(string name)
+{
+#if NETSTANDARD1_3
+return
LogManager.GetLogger(typeof(Utils).GetTypeInfo().Assembly, name);
+#else
+ return LogManager.GetLogger(name);
+#endif
+}
+
+internal static ILoggerRepository GetRepository()
+{
+#if NETSTANDARD1_3
+return
LogManager.GetRepository(typeof(Utils).GetTypeInfo().Assembly);
+#else
+ return LogManager.GetRepository();
+#endif
--- End diff --
nit: indentation of either one of two return statements is off
> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
> Issue Type: New Feature
> Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
> Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not
[
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374790#comment-15374790
]
ASF GitHub Bot commented on LOG4NET-467:
Github user jasonwilliams200OK commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r70600774
--- Diff: tests/src/Utils.cs ---
@@ -105,7 +114,28 @@ private static Type[] GetTypesArray(object[] args)
internal static void RemovePropertyFromAllContexts() {
GlobalContext.Properties.Remove(PROPERTY_KEY);
ThreadContext.Properties.Remove(PROPERTY_KEY);
+#if !(NETCF || NETSTANDARD1_3)
LogicalThreadContext.Properties.Remove(PROPERTY_KEY);
+#endif
}
- }
+
+// Wrappers because repository/logger retrieval APIs require an
Assembly argument on NETSTANDARD1_3
+internal static ILog GetLogger(string name)
+{
+#if NETSTANDARD1_3
+return
LogManager.GetLogger(typeof(Utils).GetTypeInfo().Assembly, name);
+#else
+ return LogManager.GetLogger(name);
+#endif
--- End diff --
nit: indentation of either one of two return statements is off
> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
> Issue Type: New Feature
> Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
> Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] log4net pull request #16: (LOG4NET-467) .NET Core support
Github user jasonwilliams200OK commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r70600785
--- Diff: tests/src/Utils.cs ---
@@ -105,7 +114,28 @@ private static Type[] GetTypesArray(object[] args)
internal static void RemovePropertyFromAllContexts() {
GlobalContext.Properties.Remove(PROPERTY_KEY);
ThreadContext.Properties.Remove(PROPERTY_KEY);
+#if !(NETCF || NETSTANDARD1_3)
LogicalThreadContext.Properties.Remove(PROPERTY_KEY);
+#endif
}
- }
+
+// Wrappers because repository/logger retrieval APIs require an
Assembly argument on NETSTANDARD1_3
+internal static ILog GetLogger(string name)
+{
+#if NETSTANDARD1_3
+return
LogManager.GetLogger(typeof(Utils).GetTypeInfo().Assembly, name);
+#else
+ return LogManager.GetLogger(name);
+#endif
+}
+
+internal static ILoggerRepository GetRepository()
+{
+#if NETSTANDARD1_3
+return
LogManager.GetRepository(typeof(Utils).GetTypeInfo().Assembly);
+#else
+ return LogManager.GetRepository();
+#endif
--- End diff --
nit: indentation of either one of two return statements is off
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] log4net pull request #16: (LOG4NET-467) .NET Core support
Github user jasonwilliams200OK commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r70600774
--- Diff: tests/src/Utils.cs ---
@@ -105,7 +114,28 @@ private static Type[] GetTypesArray(object[] args)
internal static void RemovePropertyFromAllContexts() {
GlobalContext.Properties.Remove(PROPERTY_KEY);
ThreadContext.Properties.Remove(PROPERTY_KEY);
+#if !(NETCF || NETSTANDARD1_3)
LogicalThreadContext.Properties.Remove(PROPERTY_KEY);
+#endif
}
- }
+
+// Wrappers because repository/logger retrieval APIs require an
Assembly argument on NETSTANDARD1_3
+internal static ILog GetLogger(string name)
+{
+#if NETSTANDARD1_3
+return
LogManager.GetLogger(typeof(Utils).GetTypeInfo().Assembly, name);
+#else
+ return LogManager.GetLogger(name);
+#endif
--- End diff --
nit: indentation of either one of two return statements is off
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not
[ https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374783#comment-15374783 ] ASF GitHub Bot commented on LOG4NET-467: Github user jasonwilliams200OK commented on a diff in the pull request: https://github.com/apache/log4net/pull/16#discussion_r70599902 --- Diff: src/Appender/AppenderCollection.cs --- @@ -26,7 +26,10 @@ namespace log4net.Appender /// A strongly-typed collection of objects. /// /// Nicko Cadell - public class AppenderCollection : ICollection, IList, IEnumerable, ICloneable + public class AppenderCollection : ICollection, IList, IEnumerable +#if !NETSTANDARD1_3 + , ICloneable --- End diff -- Note that ICloneable is coming back. https://github.com/dotnet/corefx/pull/9970 If the new contract doesn't support NETSTANDARD1_3, and we do want to support this TxM, then the best way in the future would be to also add `NETSTANDARD1_` in the project.json which exposes IColeable interface on public surface area. > Is .NET Core, will be supported in the near future, or not > -- > > Key: LOG4NET-467 > URL: https://issues.apache.org/jira/browse/LOG4NET-467 > Project: Log4net > Issue Type: New Feature > Components: Core >Affects Versions: 1.2.13 >Reporter: san kan > Labels: features > > As you know, ms is moving heavily toward .Net core: > https://github.com/dotnet/core > so, is there a road map for making a version that supports it? > and i noticed that log4net, has not been updated for 2 years. > so is it maintained, or being forgotten? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] log4net pull request #16: (LOG4NET-467) .NET Core support
Github user jasonwilliams200OK commented on a diff in the pull request: https://github.com/apache/log4net/pull/16#discussion_r70599902 --- Diff: src/Appender/AppenderCollection.cs --- @@ -26,7 +26,10 @@ namespace log4net.Appender /// A strongly-typed collection of objects. /// /// Nicko Cadell - public class AppenderCollection : ICollection, IList, IEnumerable, ICloneable + public class AppenderCollection : ICollection, IList, IEnumerable +#if !NETSTANDARD1_3 + , ICloneable --- End diff -- Note that ICloneable is coming back. https://github.com/dotnet/corefx/pull/9970 If the new contract doesn't support NETSTANDARD1_3, and we do want to support this TxM, then the best way in the future would be to also add `NETSTANDARD1_` in the project.json which exposes IColeable interface on public surface area. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
