[GitHub] log4net issue #30: Misc. fixes for netstandard

[bodewig]

Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/30
  
No, NAnt seems to compile against 4.0's libraries where `Stream.ReadAsync` 
hasn't been defined.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Jenkins build is back to normal : log4net-trunk-build #112

[Apache Jenkins Server]

See 

[GitHub] log4net pull request #30: Misc. fixes for netstandard

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/log4net/pull/30


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] log4net issue #30: Misc. fixes for netstandard

[jasonwilliams200OK]

Github user jasonwilliams200OK commented on the issue:

https://github.com/apache/log4net/pull/30
  
I have rebased it against trunk. To review without whitespace diff, here is 
the proper diff link: https://github.com/apache/log4net/pull/30/files?w=1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: log4net-trunk-build #111

[Apache Jenkins Server]

See 

Changes:

[bodewig] update svn ignores

--
[...truncated 788 lines...]
AUexamples\net\2.0\Repository\SimpleApp\vb\src\AssemblyInfo.vb
AUexamples\net\2.0\Repository\SimpleApp\vb\src\EntryPoint.vb
AUexamples\net\2.0\Repository\SimpleApp\vb\src\App.config
AUexamples\net\2.0\Repository\SimpleApp\vb\src\SimpleApp.exe.log4net
AUexamples\net\2.0\Repository\SimpleApp\vb\src\SimpleApp.vbproj
AUexamples\net\2.0\Repository\SimpleApp\vb\nant.build
AUexamples\net\2.0\Repository\SimpleApp\nant.build
A examples\net\2.0\Repository\SharedModule
AUexamples\net\2.0\Repository\SharedModule\nant.config
A examples\net\2.0\Repository\SharedModule\cs
A examples\net\2.0\Repository\SharedModule\cs\src
AUexamples\net\2.0\Repository\SharedModule\cs\src\AssemblyInfo.cs
AUexamples\net\2.0\Repository\SharedModule\cs\src\SharedModule.csproj
AUexamples\net\2.0\Repository\SharedModule\cs\src\Math.cs
AUexamples\net\2.0\Repository\SharedModule\cs\nant.build
AUexamples\net\2.0\Repository\SharedModule\cs\nant.config
A examples\net\2.0\Repository\SharedModule\vb
A examples\net\2.0\Repository\SharedModule\vb\src
AUexamples\net\2.0\Repository\SharedModule\vb\src\Math.vb
AUexamples\net\2.0\Repository\SharedModule\vb\src\AssemblyInfo.vb
AUexamples\net\2.0\Repository\SharedModule\vb\src\SharedModule.vbproj
AUexamples\net\2.0\Repository\SharedModule\vb\nant.build
AUexamples\net\2.0\Repository\SharedModule\vb\nant.config
AUexamples\net\2.0\Repository\SharedModule\nant.build
AUexamples\net\2.0\Repository\nant.build
A examples\net\2.0\Repository\SimpleModule
A examples\net\2.0\Repository\SimpleModule\vb
A examples\net\2.0\Repository\SimpleModule\vb\src
AUexamples\net\2.0\Repository\SimpleModule\vb\src\Math.vb
AUexamples\net\2.0\Repository\SimpleModule\vb\src\SimpleModule.vbproj
AUexamples\net\2.0\Repository\SimpleModule\vb\src\AssemblyInfo.vb
AU
examples\net\2.0\Repository\SimpleModule\vb\src\SimpleModule.dll.log4net
AUexamples\net\2.0\Repository\SimpleModule\vb\nant.build
AUexamples\net\2.0\Repository\SimpleModule\vb\nant.config
AUexamples\net\2.0\Repository\SimpleModule\nant.build
AUexamples\net\2.0\Repository\SimpleModule\nant.config
A examples\net\2.0\Repository\SimpleModule\cs
AUexamples\net\2.0\Repository\SimpleModule\cs\nant.config
A examples\net\2.0\Repository\SimpleModule\cs\src
AUexamples\net\2.0\Repository\SimpleModule\cs\src\Math.cs
AUexamples\net\2.0\Repository\SimpleModule\cs\src\SimpleModule.csproj
AUexamples\net\2.0\Repository\SimpleModule\cs\src\AssemblyInfo.cs
AU
examples\net\2.0\Repository\SimpleModule\cs\src\SimpleModule.dll.log4net
AUexamples\net\2.0\Repository\SimpleModule\cs\nant.build
AUexamples\net\nant.config
A examples\mono
AUexamples\mono\nant.config
A examples\mono\1.0
AUexamples\mono\1.0\nant.build
A examples\mono\1.0\Repository
AUexamples\mono\1.0\Repository\nant.config
A examples\mono\1.0\Repository\SimpleApp
AUexamples\mono\1.0\Repository\SimpleApp\nant.build
AUexamples\mono\1.0\Repository\SimpleApp\nant.config
A examples\mono\1.0\Repository\SimpleApp\cs
AUexamples\mono\1.0\Repository\SimpleApp\cs\nant.config
A examples\mono\1.0\Repository\SimpleApp\cs\src
AUexamples\mono\1.0\Repository\SimpleApp\cs\src\AssemblyInfo.cs
AUexamples\mono\1.0\Repository\SimpleApp\cs\src\EntryPoint.cs
AUexamples\mono\1.0\Repository\SimpleApp\cs\src\App.config
AUexamples\mono\1.0\Repository\SimpleApp\cs\src\SimpleApp.exe.log4net
AUexamples\mono\1.0\Repository\SimpleApp\cs\nant.build
A examples\mono\1.0\Repository\SharedModule
AUexamples\mono\1.0\Repository\SharedModule\nant.build
AUexamples\mono\1.0\Repository\SharedModule\nant.config
A examples\mono\1.0\Repository\SharedModule\cs
A examples\mono\1.0\Repository\SharedModule\cs\src
AUexamples\mono\1.0\Repository\SharedModule\cs\src\Math.cs
AUexamples\mono\1.0\Repository\SharedModule\cs\src\AssemblyInfo.cs
AUexamples\mono\1.0\Repository\SharedModule\cs\nant.build
AUexamples\mono\1.0\Repository\SharedModule\cs\nant.config
AUexamples\mono\1.0\Repository\nant.build
A examples\mono\1.0\Repository\SimpleModule
AUexamples\mono\1.0\Repository\SimpleModule\nant.build
AUexamples\mono\1.0\Repository\SimpleModule\nant.config
A examples\mono\1.0\Repository\SimpleModule\cs
AUexamples\mono\1.0\Repository\SimpleModule\cs\nant.config
A examples\mono\1.0\Repository\SimpleModule\cs\src
AU  

Build failed in Jenkins: log4net-trunk-build #110

[Apache Jenkins Server]

See 

Changes:

[bodewig] apply missed patch of #16

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on windows1 (Windows) in workspace 

Updating https://svn.apache.org/repos/asf/logging/log4net/trunk at revision 
'2016-08-13T17:25:08.773 +0100'
C src\Appender\FileAppender.cs
At revision 1756281

Executing command: cmd.exe /C ""F:\jenkins\tools\nant-0.92\bin\NAnt.exe 
-buildfile:log4net.build && exit %%ERRORLEVEL%%""
[log4net-trunk-build] $ cmd.exe /C '"F:\jenkins\tools\nant-0.92\bin\NAnt.exe 
-buildfile:log4net.build && exit %%ERRORLEVEL%%"'
NAnt 0.92 (Build 0.92.4543.0; release; 6/9/2012)
Copyright (C) 2001-2012 Gerry Shaw
http://nant.sourceforge.net

Buildfile: 
file:///f:/hudson/hudson-slave/workspace/log4net-trunk-build/log4net.build
Target framework: Microsoft .NET Framework 4.0
Target(s) specified: compile-all 


check-current-build-config:


set-build-configuration:


set-debug-build-configuration:


check-current-build-config:


set-build-configuration-flags:


check-current-build-config:


set-framework-configuration:


check-bin-dir:


check-doc-dir:


check-sdkdoc-dir:


check-sdkdoc-debug:


check-current-build-config:


check-build-debug:


check-build-defines:


set-net-4.0-runtime-configuration:


generate-assembly-description:

[sleep] Sleeping for 500 milliseconds.
   [delete] Deleting file 

   [delete] Deleting file 

  [asminfo] Generated file 
'

compile-all:

 [echo] Compiling all build configurations for all runtime configurations.

set-debug-build-configuration:


check-current-build-config:


set-build-configuration-flags:


compile-build:

 [echo] Compiling all framework versions for the debug build configuration.
 [echo] The .NET Framework 1.0 is not available. Build skipped.
 [echo] The .NET Framework 1.1 is not available. Build skipped.

check-bin-dir:


check-doc-dir:


check-sdkdoc-dir:


check-sdkdoc-debug:


check-current-build-config:


check-build-debug:


check-build-defines:


set-net-2.0-runtime-configuration:

 [property] Target framework changed to "Microsoft .NET Framework 2.0".

check-log4net-basedir:


check-current-bin-dir:


clean-current-bin-dir:

 [echo] Cleaning the bin/net/2.0/debug binaries directory.
   [delete] Deleting directory 
'
[mkdir] Creating directory 
'

compile-net-2.0:

  [csc] Compiling 225 files to 
'
  [csc] 
:
 error CS0116: A namespace does not directly contain members such as fields or 
methods
  [csc] 
:
 error CS0116: A namespace does not directly contain members such as fields or 
methods
  [csc] 
:
 error CS0116: A namespace does not directly contain members such as fields or 
methods
  [csc] 
:
 error CS0101: The namespace 'log4net.Appender' already contains a definition 
for 'FileAppender'
  [csc] 
:
 (Location of symbol related to previous error)
  [csc] 
:
 error CS0102: The type 'log4net.Appender.FileAppender' already contains a 
definition for 'LockingStream'
  [csc] 
:
 (Location of symbol related to previous error)
  [csc] 
:
 error CS0102: The type 'log4net.Appender.FileAppender.LockingStream' already 
contains a definition for 'LockStateException'
  [csc] 
:
 (Location of symbol related to previous error)
  [csc] 
:
 error CS0102: The type 'log4net.Appender.FileAppender' already contains a 
definition for 'LockingModelBase'
  [csc] 

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419986#comment-15419986
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/16
  
I've just diffed chlowell:log4net-core-pcl against my svn working copy of 
trunk and it looks as if there have been changes after the PR which makes 
identifying misses more difficult. I'll apply #30 and then we can all go from 
there.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 1.2.16
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] log4net issue #16: (LOG4NET-467) .NET Core support

[bodewig]

Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/16
  
I've just diffed chlowell:log4net-core-pcl against my svn working copy of 
trunk and it looks as if there have been changes after the PR which makes 
identifying misses more difficult. I'll apply #30 and then we can all go from 
there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] log4net issue #30: Misc. fixes for netstandard

[bodewig]

Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/30
  
by fixing `FileAppender` I'm now causing a merge conflict here, sorry.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] log4net issue #16: (LOG4NET-467) .NET Core support

[bodewig]

Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/16
  
@jasonwilliams200OK, thanks, but too late, I went off fixing it myself 
before I saw you comment. :-)

I'll diff my svn tree against a checkout of @chlowell's original branch to 
verify whether I missed more patch failures. It's pretty strange as I don't 
recall seeing any "hunk failed" messages.

BTW, this is the test result on Linux (Ubuntu 16.04, but I don't think it 
matters):

```
Errors and Failures
1) Failed : 
log4net.Tests.Appender.RollingFileAppenderTest.TestExclusiveLockLocks
  Log contents is not what is expected
  String lengths are both 38. Strings differ at index 0.
  Expected: "This is a message\nThis is a message 2\n"
  But was:  "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0This is a message 2\n"
  ---^
at log4net.Tests.Appender.RollingFileAppenderTest.AssertFileEquals(String 
filename, String contents) in 
/devel/ASF/log4net/trunk/tests/src/Appender/RollingFileAppenderTest.cs:line 1470
at log4net.Tests.Appender.RollingFileAppenderTest.TestExclusiveLockLocks() 
in /devel/ASF/log4net/trunk/tests/src/Appender/RollingFileAppenderTest.cs:line 
1570
Run Settings
WorkDirectory: /devel/ASF/log4net/trunk/netstandard
Test Run Summary
  Overall result: Failed
  Test Count: 145, Passed: 136, Failed: 1, Inconclusive: 0, Skipped: 8
Failed Tests - Failures: 1, Errors: 0, Invalid: 0
Skipped Tests - Ignored: 8, Explicit: 0, Other: 0
  Start time: 2016-08-13 16:05:11Z
End time: 2016-08-13 16:05:14Z
Duration: 2,964 seconds
Results saved as /devel/ASF/log4net/trunk/netstandard/TestResult.xml
SUMMARY: Total: 1 targets, Passed: 0, Failed: 1.
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419983#comment-15419983
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/16
  
@jasonwilliams200OK, thanks, but too late, I went off fixing it myself 
before I saw you comment. :-)

I'll diff my svn tree against a checkout of @chlowell's original branch to 
verify whether I missed more patch failures. It's pretty strange as I don't 
recall seeing any "hunk failed" messages.

BTW, this is the test result on Linux (Ubuntu 16.04, but I don't think it 
matters):

```
Errors and Failures
1) Failed : 
log4net.Tests.Appender.RollingFileAppenderTest.TestExclusiveLockLocks
  Log contents is not what is expected
  String lengths are both 38. Strings differ at index 0.
  Expected: "This is a message\nThis is a message 2\n"
  But was:  "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0This is a message 2\n"
  ---^
at log4net.Tests.Appender.RollingFileAppenderTest.AssertFileEquals(String 
filename, String contents) in 
/devel/ASF/log4net/trunk/tests/src/Appender/RollingFileAppenderTest.cs:line 1470
at log4net.Tests.Appender.RollingFileAppenderTest.TestExclusiveLockLocks() 
in /devel/ASF/log4net/trunk/tests/src/Appender/RollingFileAppenderTest.cs:line 
1570
Run Settings
WorkDirectory: /devel/ASF/log4net/trunk/netstandard
Test Run Summary
  Overall result: Failed
  Test Count: 145, Passed: 136, Failed: 1, Inconclusive: 0, Skipped: 8
Failed Tests - Failures: 1, Errors: 0, Invalid: 0
Skipped Tests - Ignored: 8, Explicit: 0, Other: 0
  Start time: 2016-08-13 16:05:11Z
End time: 2016-08-13 16:05:14Z
Duration: 2,964 seconds
Results saved as /devel/ASF/log4net/trunk/netstandard/TestResult.xml
SUMMARY: Total: 1 targets, Passed: 0, Failed: 1.
```


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 1.2.16
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419972#comment-15419972
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/16
  
I've installed the Linux version, this is what happens for me:

```
Compiling log4net for .NETStandard,Version=v1.3
/usr/share/dotnet/dotnet compile-csc 
@/devel/ASF/log4net/trunk/netstandard/log4net/obj/Debug/netstandard1.3/dotnet-compile.rsp
 returned Exit Code 1
/devel/ASF/log4net/trunk/src/Appender/FileAppender.cs(164,33): error 
CS0115: 'FileAppender.LockingStream.BeginRead(byte[], int, int, AsyncCallback, 
object)': no suitable method found to override
/devel/ASF/log4net/trunk/src/Appender/FileAppender.cs(175,33): error 
CS0115: 'FileAppender.LockingStream.BeginWrite(byte[], int, int, AsyncCallback, 
object)': no suitable method found to override
/devel/ASF/log4net/trunk/src/Appender/FileAppender.cs(183,25): error 
CS0115: 'FileAppender.LockingStream.Close()': no suitable method found to 
override
/devel/ASF/log4net/trunk/src/Appender/FileAppender.cs(188,24): error 
CS0115: 'FileAppender.LockingStream.EndRead(IAsyncResult)': no suitable method 
found to override
/devel/ASF/log4net/trunk/src/Appender/FileAppender.cs(193,25): error 
CS0115: 'FileAppender.LockingStream.EndWrite(IAsyncResult)': no suitable method 
found to override

Compilation failed.
0 Warning(s)
5 Error(s)
```

I'll double check whether I've missed some changes to `FileAppender`.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 1.2.16
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419973#comment-15419973
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user jasonwilliams200OK commented on the issue:

https://github.com/apache/log4net/pull/16
  
@bodewig, #30 fixed exactly this issue. Can you try with my branch?


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 1.2.16
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] log4net issue #16: (LOG4NET-467) .NET Core support

[jasonwilliams200OK]

Github user jasonwilliams200OK commented on the issue:

https://github.com/apache/log4net/pull/16
  
@bodewig, #30 fixed exactly this issue. Can you try with my branch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] log4net issue #16: (LOG4NET-467) .NET Core support

[bodewig]

Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/16
  
I've installed the Linux version, this is what happens for me:

```
Compiling log4net for .NETStandard,Version=v1.3
/usr/share/dotnet/dotnet compile-csc 
@/devel/ASF/log4net/trunk/netstandard/log4net/obj/Debug/netstandard1.3/dotnet-compile.rsp
 returned Exit Code 1
/devel/ASF/log4net/trunk/src/Appender/FileAppender.cs(164,33): error 
CS0115: 'FileAppender.LockingStream.BeginRead(byte[], int, int, AsyncCallback, 
object)': no suitable method found to override
/devel/ASF/log4net/trunk/src/Appender/FileAppender.cs(175,33): error 
CS0115: 'FileAppender.LockingStream.BeginWrite(byte[], int, int, AsyncCallback, 
object)': no suitable method found to override
/devel/ASF/log4net/trunk/src/Appender/FileAppender.cs(183,25): error 
CS0115: 'FileAppender.LockingStream.Close()': no suitable method found to 
override
/devel/ASF/log4net/trunk/src/Appender/FileAppender.cs(188,24): error 
CS0115: 'FileAppender.LockingStream.EndRead(IAsyncResult)': no suitable method 
found to override
/devel/ASF/log4net/trunk/src/Appender/FileAppender.cs(193,25): error 
CS0115: 'FileAppender.LockingStream.EndWrite(IAsyncResult)': no suitable method 
found to override

Compilation failed.
0 Warning(s)
5 Error(s)
```

I'll double check whether I've missed some changes to `FileAppender`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419970#comment-15419970
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user jasonwilliams200OK commented on the issue:

https://github.com/apache/log4net/pull/16
  
Fixed the build breakage and feedback in #30.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 1.2.16
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] log4net issue #16: (LOG4NET-467) .NET Core support

[jasonwilliams200OK]

Github user jasonwilliams200OK commented on the issue:

https://github.com/apache/log4net/pull/16
  
Fixed the build breakage and feedback in #30.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] log4net pull request #30: Misc. fixes for netstandard

[jasonwilliams200OK]

GitHub user jasonwilliams200OK opened a pull request:

https://github.com/apache/log4net/pull/30

Misc. fixes for netstandard

This PR:
- fix the failing build by providing `[Read/Write]Async` overloads for 
net45 and netstandard TFMs in FileAppender. This was a miss in #16 as 
netstandard doesn't have Begin/End Read/Write methods.

- covers some minor code feedback given at 
https://github.com/apache/log4net/pull/16 and code cleanup.

---

FYI: to build the project with .NET CLI on various platforms (downloadable 
from https://dot.net/core), run the following sequence of commands:

```sh
git clone https://github.com/apache/log4net --recursive
cd log4net/netstandard

dotnet restore

dotnet test log4net.tests# this will build log4net.tests,
 # it's dependency log4net and run tests; all 
in one command!
```

I have tested on macOS and Windows and the test result is consistent:

> Test Count: 145, Passed: 107, Failed: 30, Inconclusive: 0, Skipped: 8

/cc @bodewig

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jasonwilliams200OK/log4net trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/log4net/pull/30.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #30


commit f6e66d0c0ae67e533ed1ed09e2218e1aa26514d0
Author: Peter Jas 
Date:   2016-08-13T14:43:25Z

Misc. fixes for netstandard




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4NET-415) RemoteSyslogAppender may block for ARP resolution + Improvement Strict RFC3164

[Stefan Bodewig (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419927#comment-15419927
 ] 

Stefan Bodewig commented on LOG4NET-415:


Sorry, got side-tracked for far too long, again. It would be good if you could 
either re-create a patch or provide a PR against the current trunk - when you 
created the patch the current trunk used to be the 1.2.x branch.

> RemoteSyslogAppender may block for ARP resolution + Improvement Strict RFC3164
> --
>
> Key: LOG4NET-415
> URL: https://issues.apache.org/jira/browse/LOG4NET-415
> Project: Log4net
>  Issue Type: Bug
>  Components: Appenders
>Affects Versions: 1.2.13
> Environment: Any Windows environment
>Reporter: Jose Luis Pedrosa
>  Labels: RemoteSyslogAppender
> Attachments: LOG4NET-415.patch, MessageLostTest.cs, 
> MessageLostTest.cs, MessageLostTestAsync.cs, RemoteSyslogNonBlockingV3.patch, 
> RemoteSyslogNonBlockingv2.patch
>
>
> Sending UDP packages may block for some time in specific circumstances:
> 1) Next hop in network level 3 can't be resolved by ARP.
> 2) Datagram size exceeds FastSendDatagramThreshold configured size.
> When sending packets bigger than FastSendDatagramThreshold, the OS waits 
> until the packet is actually sent, if the If the syslog (or the next hop to 
> reach the syslog) is in the same VLAN/Subnet the OS tries to resolve by ARP 
> the Ip of the configured syslog, this may take up to 3 seconds, slowing down 
> the whole application, which in some cases can lead to outages (timeouts, DB 
> locks...).
> Also the fact that each carriage return generates the headers of the packet 
> again, that can lead to a significant overhead in some scenarios, for 
> instance when loggign HTTP requests to a remote syslog, every header will go 
> in a different message. Also some logging may require characters that are now 
> skipped in patch:  https://issues.apache.org/jira/browse/LOG4NET-370
> I'm adding a patch that
> 1) Moves the use of UDPClient to Non blocking sockets, which eliminates the 
> blocking. 
> 2) Adds a configuration field to decide if you want Strict RFC Behaviour or 
> not (with default Strict).
> Please your feedback, thanks in advance
> Jose Luis



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-472) Contribution of BurstFilter

[Stefan Bodewig (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419925#comment-15419925
 ] 

Stefan Bodewig commented on LOG4NET-472:


[~AlbinSunnanbo] could you re-target your changes to the current trunk (which 
used to be the 1.2.x branch)?

sorry for the delay.

> Contribution of BurstFilter
> ---
>
> Key: LOG4NET-472
> URL: https://issues.apache.org/jira/browse/LOG4NET-472
> Project: Log4net
>  Issue Type: New Feature
>  Components: Other
>Affects Versions: 1.2.13
>Reporter: Albin Sunnanbo
>Priority: Minor
>
> Hi
> I wrote a BurstFilter implementation for Log4net a while ago, trying to mimic 
> the API of BurstFilter for Log4j 
> https://logging.apache.org/log4j/2.0/log4j-core/apidocs/org/apache/logging/log4j/core/filter/BurstFilter.html
> I have published my source code on our company GitHub account: 
> https://github.com/KentorIT/Log4NetExtensions
> But I would of course be happy to contribute the extension back to the main 
> project on apache.org.
> Would a contribution be accepted and in such case how would you like the 
> contribution served? As a diff in this Jira issue?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-466) "LockRecursionException: A read lock may not be acquired with the write lock held in this mode." exception

[Stefan Bodewig (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419923#comment-15419923
 ] 

Stefan Bodewig commented on LOG4NET-466:


does it still happen with 1.2.14 or 1.2.15? LOG4NET-443 has been fixed in 
1.2.14.

> "LockRecursionException: A read lock may not be acquired with the write lock 
> held in this mode." exception
> --
>
> Key: LOG4NET-466
> URL: https://issues.apache.org/jira/browse/LOG4NET-466
> Project: Log4net
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.2.13
> Environment: Windows 7 x64 / .NET 4.5.2
>Reporter: Andrei Faber
>
> I'm getting this exception when trying to call ILog.Error() method (the 
> logger used is RollingFileAppender):
> log4net:ERROR Exception while logging
> System.Threading.LockRecursionException: A read lock may not be acquired with 
> the write lock held in this mode.
>at 
> System.Threading.ReaderWriterLockSlim.TryEnterReadLockCore(TimeoutTracker 
> timeout)
>at System.Threading.ReaderWriterLockSlim.TryEnterReadLock(TimeoutTracker 
> timeout)
>at System.Threading.ReaderWriterLockSlim.EnterReadLock()
>at log4net.Util.ReaderWriterLock.AcquireReaderLock()
>at log4net.Repository.Hierarchy.Logger.CallAppenders(LoggingEvent 
> loggingEvent)
>at log4net.Repository.Hierarchy.Logger.ForcedLog(Type 
> callerStackBoundaryDeclaringType, Level level, Object message, Exception 
> exception)
>at log4net.Repository.Hierarchy.Logger.Log(Type 
> callerStackBoundaryDeclaringType, Level level, Object message, Exception 
> exception)
> Any ideas why it might be happening?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] log4net pull request #26: Remove an unused variable

[jasonwilliams200OK]

Github user jasonwilliams200OK closed the pull request at:

https://github.com/apache/log4net/pull/26


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] log4net issue #26: Remove an unused variable

[jasonwilliams200OK]

Github user jasonwilliams200OK commented on the issue:

https://github.com/apache/log4net/pull/26
  
Ops, it was actually the one in the following method: 
https://github.com/apache/log4net/blob/6308def/tests/src/Appender/RollingFileAppenderTest.cs#L1711
 which was unused. But now that has been fixed in the current trunk: 
https://github.com/apache/log4net/blob/cb7802b/tests/src/Appender/RollingFileAppenderTest.cs#L1721.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[Stefan Bodewig (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Bodewig resolved LOG4NET-467.

   Resolution: Fixed
Fix Version/s: 1.2.16

> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 1.2.16
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LOG4NET-511) API to flush appenders

[Stefan Bodewig (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LOG4NET-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Bodewig updated LOG4NET-511:
---
Fix Version/s: (was: 1.2.16)

> API to flush appenders
> --
>
> Key: LOG4NET-511
> URL: https://issues.apache.org/jira/browse/LOG4NET-511
> Project: Log4net
>  Issue Type: Wish
>  Components: Appenders, Core
>Affects Versions: 1.2.15
> Environment: NA
>Reporter: Joe
>Priority: Minor
>
> I would like to see an API that flushes any appenders that have buffered 
> data. E.g. a method LogManager.Flush().  An application might call such a 
> method at regular intervals, e.g. on a Timer.
> A naive implementation with the current log4net would iterate through 
> appenders, looking for those that support flushing, and call the appender's 
> flush method, e.g.:
> foreach (IAppender appender in 
>  LogManager.GetRepository().GetAppenders())
> {
> BufferingAppenderSkeleton bas = appender 
> as BufferingAppenderSkeleton;  
> if (bas != null) bas.Flush();
> }
> But (a) I'm not sure this is thread-safe and (b) there are potentially other 
> appenders that may want to be able to flush data (e.g. a TextWriterAppender 
> with ImmediateFlush = false).
> The request consists of:
> - Add an interface, IFlushableAppender or equivalent, with a single method 
> Flush().
> - Implement this interface in all relevant appenders 
> (BufferingAppenderSkeleton, TextWriterAppender, ...)
> - Add a thread-safe static Flush() method to LogManager.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-518) Filters don't work when use multiple.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419916#comment-15419916
 ] 

ASF GitHub Bot commented on LOG4NET-518:


Github user asfgit closed the pull request at:

https://github.com/apache/log4net/pull/27


> Filters don't work when use multiple.
> -
>
> Key: LOG4NET-518
> URL: https://issues.apache.org/jira/browse/LOG4NET-518
> Project: Log4net
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 1.2.15
>Reporter: huiqiang yan
>Assignee: Dominik Psenner
>
> I have an application managed multiple AppDomains, and my master application 
> can get messages from all appDomain, then log them separately.
> I create appenders from each appDomains and use the 'domain name’ and 'log 
> level' to discriminate。
> RollingFileAppender appender = new RollingFileAppender();
> appender.AddFilter(new LevelRangeFilter
> {
> LevelMin = Level.Info,
> LevelMax = Level.Info,
> AcceptOnMatch = false,
> Next = new LoggerMatchFilter
> {
> LoggerToMatch = name,
> AcceptOnMatch = true
> }
> });
> when name doesn't match, the If statement in filter LoggerMatchFilter file at 
> line 140 ,I think it means match or doesn't match, it should be deny in else 
> statement.
> AcceptOnMatch only use when the match is passed ,it means if should return 
> Accept when matched,and when it is false then return Neutral.
> Not only LoggerMatchFilter has this problem, others too. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] log4net pull request #27: fixed issue LOG4NET-518.

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/log4net/pull/27


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] log4net issue #28: Removed the event properties information from LoggingEven...

[bodewig]

Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/28
  
and break existing code and patterns that need those properties, doesn't it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4NET-518) Filters don't work when use multiple.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419914#comment-15419914
 ] 

ASF GitHub Bot commented on LOG4NET-518:


Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/27
  
has been rejected by Dominik Psenner in 
https://issues.apache.org/jira/browse/LOG4NET-518


> Filters don't work when use multiple.
> -
>
> Key: LOG4NET-518
> URL: https://issues.apache.org/jira/browse/LOG4NET-518
> Project: Log4net
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 1.2.15
>Reporter: huiqiang yan
>Assignee: Dominik Psenner
>
> I have an application managed multiple AppDomains, and my master application 
> can get messages from all appDomain, then log them separately.
> I create appenders from each appDomains and use the 'domain name’ and 'log 
> level' to discriminate。
> RollingFileAppender appender = new RollingFileAppender();
> appender.AddFilter(new LevelRangeFilter
> {
> LevelMin = Level.Info,
> LevelMax = Level.Info,
> AcceptOnMatch = false,
> Next = new LoggerMatchFilter
> {
> LoggerToMatch = name,
> AcceptOnMatch = true
> }
> });
> when name doesn't match, the If statement in filter LoggerMatchFilter file at 
> line 140 ,I think it means match or doesn't match, it should be deny in else 
> statement.
> AcceptOnMatch only use when the match is passed ,it means if should return 
> Accept when matched,and when it is false then return Neutral.
> Not only LoggerMatchFilter has this problem, others too. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] log4net issue #27: fixed issue LOG4NET-518.

[bodewig]

Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/27
  
has been rejected by Dominik Psenner in 
https://issues.apache.org/jira/browse/LOG4NET-518


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] log4net issue #26: Remove an unused variable

[bodewig]

Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/26
  
hmm, the variable *is* used five lines later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] log4net pull request #20: Adding NDC.PushFormat() support.

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/log4net/pull/20


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] log4net issue #20: Adding NDC.PushFormat() support.

[bodewig]

Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/20
  
many thanks, merged, will be part of log4net 1.2.16.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419912#comment-15419912
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user jasonwilliams200OK commented on the issue:

https://github.com/apache/log4net/pull/16
  
Thanks a lot @bodewig! I am definitely willing to participate. I will test 
out the master and try to incorporate the feedback in subsequent PR pronto 
(before you start cutting the release :stuck_out_tongue_winking_eye:). I have 
subscribed to log4net-dev mailing list.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] log4net issue #16: (LOG4NET-467) .NET Core support

[jasonwilliams200OK]

Github user jasonwilliams200OK commented on the issue:

https://github.com/apache/log4net/pull/16
  
Thanks a lot @bodewig! I am definitely willing to participate. I will test 
out the master and try to incorporate the feedback in subsequent PR pronto 
(before you start cutting the release :stuck_out_tongue_winking_eye:). I have 
subscribed to log4net-dev mailing list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419910#comment-15419910
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/16
  
Many thanks for your persistence.

I have applied the patch as is as it didn't break anything of the existing 
build. But I haven't even tried to build the .NET Core part itself - I'll do so 
later, and try to figure out how to cut releases that contain the .NET Core 
assembly as well as the current process is centered around NAnt.

I'd like to invite anybody interested in keeping log4net moving to join the 
log4net-dev mailing list and lend a hand. We are severely understaffed and can 
use any help.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] log4net issue #16: (LOG4NET-467) .NET Core support

[bodewig]

Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/16
  
Many thanks for your persistence.

I have applied the patch as is as it didn't break anything of the existing 
build. But I haven't even tried to build the .NET Core part itself - I'll do so 
later, and try to figure out how to cut releases that contain the .NET Core 
assembly as well as the current process is centered around NAnt.

I'd like to invite anybody interested in keeping log4net moving to join the 
log4net-dev mailing list and lend a hand. We are severely understaffed and can 
use any help.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419908#comment-15419908
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user asfgit closed the pull request at:

https://github.com/apache/log4net/pull/16


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] log4net pull request #16: (LOG4NET-467) .NET Core support

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/log4net/pull/16


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[Stefan Bodewig (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419880#comment-15419880
 ] 

Stefan Bodewig commented on LOG4NET-467:


[~jasonwilliams200ok] the real problem here is lack of time. Neither 
[~nachbarslumpi] nor myself are able to devote as much time to log4net as would 
be necessary and despite all our efforts to find additional folks who'd stick 
around for longer than a single pull request, this just never happened.

Unfortunately the PR doesn't use NAnt - because it isn't possible at all, I 
guess, as NAnt seems to be stuck in a situation similar to ours. This also 
means the release process which is incredibly cumbersome anyway will now 
require to switch build tools. Figuring out how to do that is going to cost 
time. Same goes for updating the documentation.

Don't get me wrong, I really appreciate the effort being made, I'm just not 
able to keep up.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[Peter Jas (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419850#comment-15419850
 ] 

Peter Jas commented on LOG4NET-467:
---

[~bodewig], [~nachbarslumpi],

Could you please spare sometime here? This proposal is opened for over an year 
now. .NET Core has been RTM'd for a dozen of operating systems. For most part, 
it is working out quite well for masses.

If this patch is passing all tests, working for us locally, on Travis / 
AppVeyor / Jenkins CIS' and everywhere we need log4net, is there still a reason 
not to accept this patch? This patch is mostly using preprocessor directives, 
making a very little alteration for the existing code paths and mainly adding 
support for an additional/new/trendy framework.

PLEASE note that this is an open source community which is showing interest 
here.. A beta release for .NET Core support would be a good gesture from Apache 
to it's consumers. If something breaks in beta, community members will send 
patches to help themselves (DIY model of OSS). If this is still NOT going to 
happen for some subtle reasons, please do tell and close the PR, so we know the 
maintainers' stance.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419846#comment-15419846
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user jasonwilliams200OK commented on a diff in the pull request:

https://github.com/apache/log4net/pull/16#discussion_r74683879
  
--- Diff: src/Util/PatternStringConverters/NewLinePatternConverter.cs ---
@@ -72,6 +75,16 @@ internal sealed class NewLinePatternConverter : 
LiteralPatternConverter, IOption
/// 
public void ActivateOptions()
{
+#if NETSTANDARD1_3
+   if 
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "DOS", 
CompareOptions.IgnoreCase) == 0)
+   {
+   Option = "\r\n";
+   }
+   else if 
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "UNIX", 
CompareOptions.IgnoreCase) == 0)
--- End diff --

@chlowell, do you think it's a good idea to instead of dogfooding 
`string.Compare(strA, strB, InvariantCulture) == 0` pattern with `CultureInfo` 
comparer, use common denominator `strA.ToUpperInvariant() == 
strB.ToUpperInvariant()` and remove the preprocessor all over the place as part 
of this PR? IMO, this will clean up quite a bit. If you want, I can send a PR 
to your `log4net-core-pcl` branch, then you would just need to update the JIRA 
patch. :)


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] log4net pull request #16: (LOG4NET-467) .NET Core support

[jasonwilliams200OK]

Github user jasonwilliams200OK commented on a diff in the pull request:

https://github.com/apache/log4net/pull/16#discussion_r74683879
  
--- Diff: src/Util/PatternStringConverters/NewLinePatternConverter.cs ---
@@ -72,6 +75,16 @@ internal sealed class NewLinePatternConverter : 
LiteralPatternConverter, IOption
/// 
public void ActivateOptions()
{
+#if NETSTANDARD1_3
+   if 
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "DOS", 
CompareOptions.IgnoreCase) == 0)
+   {
+   Option = "\r\n";
+   }
+   else if 
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "UNIX", 
CompareOptions.IgnoreCase) == 0)
--- End diff --

@chlowell, do you think it's a good idea to instead of dogfooding 
`string.Compare(strA, strB, InvariantCulture) == 0` pattern with `CultureInfo` 
comparer, use common denominator `strA.ToUpperInvariant() == 
strB.ToUpperInvariant()` and remove the preprocessor all over the place as part 
of this PR? IMO, this will clean up quite a bit. If you want, I can send a PR 
to your `log4net-core-pcl` branch, then you would just need to update the JIRA 
patch. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---