Assertion on 2.1git in instant preview
Several LyX math parser warnings are fixed at 1a96a9cf Two warnings remain that might be serious. Attached is an MWE that can be used to reproduce an assertion. I can reproduce on Ubuntu 13.04 on both branch and trunk if I have instant preview enabled and place the cursor at the end of the word "produit" and move right with the right arrow five times. (or, click just to the left of the \circ and go right once). Can anyone reproduce? Any ideas? Scott mwe.20.lyx Description: Binary data
Re: [LyX/master] ia.po: updates from Giovanni
On Fri, Sep 6, 2013 at 8:49 PM, Uwe Stöhr wrote: > commit 5435701af19ea8745153f0498428be903d96756e > Author: Uwe Stöhr > Date: Sat Sep 7 02:49:27 2013 +0200 > > ia.po: updates from Giovanni I am getting errors when building using CMake and -DLYX_CPACK=ON: /home/scott/lyxbuilds/master/CMakeBuild/po/ia.po:22751: number of format specifications in 'msgid' and 'msgstr' does not match /home/scott/lyxbuilds/master/CMakeBuild/po/ia.po:25989: format specifications in 'msgid' and 'msgstr' for argument 1 are not the same /usr/bin/msgfmt: found 2 fatal errors Scott
Re: Lyx2.1.0beta2 issues ?
Pavel Sanda wrote: > Vincent van Ravesteijn wrote: > > Please reply if you know about any issues so that I won't be able to > > overlook them. > > #8783 #8830 is another build problem we have. Patch included there but I wonder it signals we miss some other code as well. Pavel
back from vacation
Dear clooeagues, sorry for my silence. I am now back but will not have much time until the German election September 22. I try to commit the docs stuff I received and also the po-files. Anything I need to know, deadlines etc.? many thanks and regards Uwe
Re: back from vacation
On Fri, Sep 6, 2013 at 4:50 PM, Uwe Stöhr wrote: > Dear clooeagues, > > sorry for my silence. I am now back but will not have much time until the > German election September 22. > I try to commit the docs stuff I received and also the po-files. > > Anything I need to know, deadlines etc.? > > many thanks and regards > Uwe Hi Uwe, Welcome back! I hope you had a nice vacation. So you are running for president? Will you push for any LyX-related legislation? :) Some things that come to mind: - With permission, I implemented the short-term solution to #8643 by moving many templates to examples. I'm not happy about this since I think many users will be surprised/confused, but I do think it was the right thing to do for now. - Pavel just posted a patch (email title: "Statusbar on fullscreen") and would like a tester for Windows. - Koji sent me Japanese docs that I committed on both 2.0.x and 2.1git. - There are some documentation-related tickets you might want to take a look at: #8519, #8811, #8793 Scott
Statusbar on fullscreen
Hi,
it seems we forbid ui-toggle statusbar in fullscreen mode for no good reason.
Please can someone on windows and mac test for me that the following patch
does not break fullscreen statusbar absence?
For testing simply switch to fullscreen and try to use menu via shortcut
and observe whether it looks as expected, namely statusbar does not appear
or flicker on the screen.
It should not, but I have very little idea what would be another reason to
include these two lines of code otherwise (Abdel?).
Pavel
diff --git a/src/frontends/qt4/GuiView.cpp b/src/frontends/qt4/GuiView.cpp
index 006c7e8..8acc94a 100644
--- a/src/frontends/qt4/GuiView.cpp
+++ b/src/frontends/qt4/GuiView.cpp
@@ -3801,8 +3801,6 @@ void GuiView::dispatch(FuncRequest const & cmd,
DispatchResult & dr)
if (isFullScreen()) {
if (menuBar()->isVisible() && lyxrc.full_screen_menubar)
menuBar()->hide();
- if (statusBar()->isVisible())
- statusBar()->hide();
}
}
Re: Reviews of commits
Le 06/09/13 13:07, Hashini Senaratne a écrit : I tried both of the above patches that you have sent me. But nothing was able to solve the problem I mentioned. (When entering Math inset from right edge, row slides unexpectedly to the left most position.) However bellow code solved the above mentioned problem. I'll try to have a look at this problem. I am sure that is no way a good solution. We agree :) Drawing everything twice does not sound good. I am not sure where the draw method is called twice when we are sliding rows, in the code given by you. Could you please help? The place where I draw twice (to try to have cursor position right is in checkCursorLeftEdge: + // Force the recomputation of inset positions + bool const drawing = pi.pain.isDrawingEnabled(); + pi.pain.setDrawingEnabled(false); + // No need to care about vertical position. + RowPainter rp(pi, bv.buffer().text(), cur.bottom().pit(), row, bidi, 0, 0); + rp.paintOnlyInsets(); + pi.pain.setDrawingEnabled(drawing); Is this what you were looking for? JMarc
Re: cmake build: man pages
Am Sonntag, 1. September 2013 um 19:37:26, schrieb Kornel Benko > > If there are concerns about stabilitiy, and if it doesn't fix a bug, I > > will need to ask you to postpone. > > No concerns at all. > > > Vincent I committed it now. Kornel signature.asc Description: This is a digitally signed message part.
Re: LyX + Qt5 + CMake + XCode - attached files (1/1)
> > Is this for branch 2.0.x or for master? Indeed it seems that the Qt5 > porting missed the Q_WS_xx defines, that need to be reevaluated one by one. > Vincent, what is your take on this? > > I indeed read that the Q_WS_* defines were replaced, but at the same time, it still seemed to work so I assumed that magic helped us here. I will investigate further. Vincent
Re: Lyx2.1.0beta2 issues ?
On Fri, Sep 6, 2013 at 11:16 AM, Jean-Marc Lasgouttes wrote: > 06/09/2013 07:53, Pavel Sanda: > > Vincent van Ravesteijn wrote: >> >>> Please reply if you know about any issues so that I won't be able to >>> overlook them. >>> >> >> #8783 >> > > Here is a patch for this one. OK? > > JMarc > Are you asking me? This is too much autotools for me to say something wise about it. All I can do is to ask people to test. If no-one reports a problem, it will be ok. Vincent
Re: Reviews of commits
Hello Jean-Marc,
> > Unfortunately, this code exists to avoid painting too much stuff, so we
> > have to cope with it. We cannot afford to repaint the whole screen every
> > time the user moves the cursor, it can be really horrible, especially on
> > Mac OS X. I will try to post a patch tomorrow illustrating the way I
> > propose to tackle the problem.
>
> Here is a tentative patch. However it does not work since it seems that
> BufferView::draw does not get called when using home/end...
I tried both of the above patches that you have sent me. But nothing was
able to solve the problem I mentioned. (When entering Math inset from right
edge, row slides unexpectedly to the left most position.) However bellow
code solved the above mentioned problem.
@@ -2874,24 +2921,26 @@ void BufferView::draw(frontend::Painter & pain)
// because of the single backing pixmap.
case FullScreenUpdate:
- // The whole screen, including insets, will be refreshed.
- pi.full_repaint = true;
+ for(int i=0;i<2;i++){
+ // The whole screen, including insets, will be refreshed
+ pi.full_repaint = true;
- // Clear background.
- pain.fillRectangle(0, 0, width_, height_,
- pi.backgroundColor(&buffer_.inset()));
+ // Clear background.
+ pain.fillRectangle(0, 0, width_, height_,
+ pi.backgroundColor(&buffer_.inset()));
- // Draw everything.
- tm.draw(pi, 0, y);
+ // Draw everything.
+ tm.draw(pi, 0, y);
- // and possibly grey out below
- pair lastpm = tm.last();
- int const y2 = lastpm.second->position() + lastpm.second->descen
+ // and possibly grey out below
+ pair lastpm = tm.las
+ int const y2 = lastpm.second->position() + lastpm.second
- if (y2 < height_) {
- Color color = buffer().isInternal()
- ? Color_background : Color_bottomarea;
- pain.fillRectangle(0, y2, width_, height_ - y2, color);
+ if (y2 < height_) {
+ Color color = buffer().isInternal()
+ ? Color_background : Color_bottomarea;
+ pain.fillRectangle(0, y2, width_, height_ - y2,
+ }
}
break;
}
I am sure that is no way a good solution.
I am not sure where the draw method is called twice when we are sliding
rows, in the code given by you. Could you please help?
> Attachment
(0001-Move-code-that-updates-cursor-row-left-edge-to-Buffe.patch):
text/x-patch, 4095 bytes
Thank you
Hashini
Re: Lyx2.1.0beta2 issues ?
28/08/2013 22:45, Vincent van Ravesteijn: Hi all, I think it's time to start thinking about what is needed before we can release beta2. Please reply if you know about any issues so that I won't be able to overlook them. I would like to merge the branch features/kill-tex2lyx-define. It solves cleanly the problem with automake subdirs and is a long awaited cleanup IMO. The branch consists of small self-contained commits and is easy to review IMO. JMarc
Re: Lyx2.1.0beta2 issues ?
06/09/2013 07:53, Pavel Sanda:
Vincent van Ravesteijn wrote:
Please reply if you know about any issues so that I won't be able to
overlook them.
#8783
Here is a patch for this one. OK?
JMarc
>From d2a2cb11e0015f05da56dbe5d6e607d53d17 Mon Sep 17 00:00:00 2001
From: Jean-Marc Lasgouttes
Date: Fri, 6 Sep 2013 11:12:09 +0200
Subject: [PATCH] Fix compilation on Solaris 11.1 (bug #8783)
Make sure that the configure script only checks features using the C++ compiler.
Also get rid of our last C files, since they are not compiled nor distributed anyway.
---
configure.ac | 11 ++-
src/support/atexit.c | 18 --
src/support/strerror.c | 24
3 files changed, 6 insertions(+), 47 deletions(-)
delete mode 100644 src/support/atexit.c
delete mode 100644 src/support/strerror.c
diff --git a/configure.ac b/configure.ac
index b85c4c1..75e74ac 100644
--- a/configure.ac
+++ b/configure.ac
@@ -61,11 +61,9 @@ done
AM_PATH_PYTHON(2.4.0,, :)
AC_PROG_RANLIB
-### we need to know the byte order for unicode conversions
-AC_C_BIGENDIAN
-
### Check for a C++ compiler
LYX_PROG_CXX
+AC_LANG(C++)
### Objective-C compiler
AC_PROG_OBJC
@@ -97,6 +95,9 @@ AC_CHECK_LIB(gdi32, main)
LYX_USE_INCLUDED_BOOST
LYX_USE_INCLUDED_MYTHES
+### we need to know the byte order for unicode conversions
+AC_C_BIGENDIAN
+
# Needed for our char_type
AC_CHECK_SIZEOF(wchar_t)
@@ -181,7 +182,7 @@ AC_FUNC_SELECT_ARGTYPES
LYX_CHECK_SPELL_ENGINES
lyx_client_subdir=true
-AC_LANG_PUSH(C)
+dnl AC_LANG_PUSH(C)
dnl LIBS already contains some X extra libs that may interfere.
save_LIBS="$LIBS"
LIBS=
@@ -194,7 +195,7 @@ AC_CHECK_FUNCS(fcntl,
AC_SUBST(SOCKET_LIBS,$LIBS)
LIBS="$save_LIBS"
AM_CONDITIONAL(BUILD_CLIENT_SUBDIR, $lyx_client_subdir)
-AC_LANG_POP(C)
+dnl AC_LANG_POP(C)
lyx_win_res=false;
case ${host} in
diff --git a/src/support/atexit.c b/src/support/atexit.c
deleted file mode 100644
index 4331809..000
--- a/src/support/atexit.c
+++ /dev/null
@@ -1,18 +0,0 @@
-/**
- * \file atexit.c
- * Wrapper to implement ANSI C's atexit using SunOS's on_exit.
- *
- * This function is in the public domain. --Mike Stump.
- */
-
-#include
-
-#ifndef NEED_on_exit
-int atexit(void (*f)())
-{
- /* If the system doesn't provide a definition for atexit, use on_exit
- if the system provides that. */
- on_exit (f, 0);
- return 0;
-}
-#endif
diff --git a/src/support/strerror.c b/src/support/strerror.c
deleted file mode 100644
index b678dda..000
--- a/src/support/strerror.c
+++ /dev/null
@@ -1,24 +0,0 @@
-/*
- * provides strerror()
- * author Stephan Witt
- */
-
-#include
-
-/* $Id: strerror.c,v 1.3 2000/08/04 13:12:30 lasgouttes Exp $ */
-
-#if !defined(lint) && !defined(WITH_WARNINGS)
-static char vcid[] = "$Id: strerror.c,v 1.3 2000/08/04 13:12:30 lasgouttes Exp $";
-#endif /* lint */
-
-extern int sys_nerr ;
-extern char * sys_errlist [] ;
-
-char * strerror (int errnum)
-{
- static char * errtext = "unknown errno" ;
-
- if ( errnum < sys_nerr )
- return sys_errlist [errnum] ;
- return errtext ;
-}
--
1.7.0.4
