Re: 2 compilation questions

[Jean-Marc Lasgouttes]

Indeed libintl is not used anymore since 2.1.

Jmarc

Le 8 décembre 2015 02:18:57 GMT+01:00, "Uwe Stöhr"  a écrit :
>- we store our frontends files in a folder named qt4. Should we split
>it 
>up to qt5 and qt4 to address specific changes? If not we can rename the
>
>folder to just "qt", right?
>
>- I could now compile the dependencies with MSVC. Thus also libintl.
>But 
>in CMake I cannot see that libintl is actually used. Is this correct
>and 
>we can get rid of it?
>
>thanks and regards
>Uwe

Re: [LyX/master] Explain why we do not update the local layout

[Kornel Benko]

Am Dienstag, 8. Dezember 2015 um 07:39:50, schrieb Scott Kostyshak 

> + The root reason for this is that we do support converting layouts to older

The root reason for this is that we do *not* support converting layouts to older

> + layout formats, as we do for the .lyx file format.

A typo?

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: [LyX/master] Fix inputenc for some templates.

[Guenter Milde]

On 2015-11-21, Scott Kostyshak wrote:
> On Sat, Nov 21, 2015 at 11:09:09PM +0100, Günter Milde wrote:
>> commit 8482b2169bf9c58cac988a59e15ffa7656121427
>> Author: Günter Milde 
>> Date:   Sat Nov 21 23:06:24 2015 +0100

>> Fix inputenc for some templates.

>> Some templates had the inputenc setting "default" (meaning use the
>> language default encoding, (not TeX's default which is 7-bit
>> ASCII) but don't load inputenc, leave handling of non-ASCII
>> characters to the author).

> Günter do you have suggestions for tooltips (the explanatory text that
> comes up after hovering the mouse over something for a couple of
> seconds) for the radio buttons "Language default" and "Other"?

Until #9883 (inputenc setting variable mixes 3 settings) is solved, I propose:

* Change the heading from "Encoding" to "LaTeX input encoding"

* Tooltip for "Language default"

Use LyX's language default encodings in the LaTeX file 
(maybe more than one).

* Tooltip for "Other"

Select the encoding of the LaTeX file. 
(The entry "Language Default (no inputenc)" should only be used 
 if compilation fails otherwise.)
 
  It would be best, if the several entries in the "Other" drop-down list
  could have individual tooltips, but I am afraid this is not possible...
  
Günter   

use FindCXX11Compiler.cmake also for MSVC

[Kornel Benko]

Looking into cmake internal handling of MSVC, maybe this patch should
1.) Unify use of find_package(CXX11Compiler)
2.) Allow using C++11 features for MSVC
3.) using std_regex for MSVC

I cannot test, since I don't have MSVC.
In _my_ implementation of cmake modules (cmake 3.4) the MSVC_VERSION is defined 
for MSVC.

Kornel


signature.asc
Description: This is a digitally signed message part.
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 5840ad0..d0061c9 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -260,21 +260,26 @@ if(UNIX OR MINGW)
 			set(LYX_USE_STD_REGEX 1)
 		endif()
 	endif()
-	if (LYX_ENABLE_CXX11)
-		find_package(CXX11Compiler)
-		if(NOT CXX11COMPILER_FOUND)
-			message(FATAL_ERROR "A C++11 compatible compiler is required.")
-		endif()
-		set(LYX_GCC11_MODE "${CXX11_FLAG}")
-	endif()
 else()
 	set(LYX_USE_STD_REGEX 0)
-#	if(MSVC10)
-#		set(LYX_USE_STD_REGEX 1) #TODO should we use it in ECMAScript mode?
-#	endif()
+if (LYX_ENABLE_CXX11)
+  if(MSVC)
+	if(MSVC_VERSION GREATER 1599)
+  # MSVC10 and newer
+	  set(LYX_USE_STD_REGEX 1)
+	endif()
+  endif()
+endif()
+endif()
+
+if (LYX_ENABLE_CXX11)
+  find_package(CXX11Compiler)
+  if(NOT CXX11COMPILER_FOUND)
+message(FATAL_ERROR "A C++11 compatible compiler is required.")
+  endif()
+  set(LYX_GCC11_MODE "${CXX11_FLAG}")
 endif()
 
-
 set(VERSION_INFO "CMake Build")
 
 # Try to get some informations from configure.ac
diff --git a/development/cmake/modules/FindCXX11Compiler.cmake b/development/cmake/modules/FindCXX11Compiler.cmake
index 7d09f8f..822c074 100644
--- a/development/cmake/modules/FindCXX11Compiler.cmake
+++ b/development/cmake/modules/FindCXX11Compiler.cmake
@@ -34,7 +34,12 @@
 INCLUDE(CheckCXXSourceCompiles)
 INCLUDE(FindPackageHandleStandardArgs)
 
-if (CMAKE_CXX_COMPILER_ID MATCHES "^[cC]lang$")
+if (MSVC)
+  if(MSVC_VERSION GREATER 1799)
+# Microsoft Visual Studio 2013 and newer, e.g. MSVC12 and MSVC14
+set(CXX11_FLAG_CANDIDATES "empty")
+  endif()
+elsif (CMAKE_CXX_COMPILER_ID MATCHES "^[cC]lang$")
   set(CXX11_FLAG_CANDIDATES "--std=c++11 -Wno-deprecated-register")
 else()
   if (CYGWIN)
@@ -83,7 +88,12 @@ int main() {
 # check c compiler
 set(SAFE_CMAKE_REQUIRED_QUIET ${CMAKE_REQUIRED_QUIET})
 set(CMAKE_REQUIRED_QUIET ON)
-FOREACH(FLAG ${CXX11_FLAG_CANDIDATES})
+FOREACH(FLAG1 ${CXX11_FLAG_CANDIDATES})
+  if(FLAG1 STREQUAL "empty")
+set(FLAG "")
+  else()
+set(FLAG ${FLAG1})
+  endif()
   SET(SAFE_CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS}")
   SET(CMAKE_REQUIRED_FLAGS "${FLAG}")
   UNSET(CXX11_FLAG_DETECTED CACHE)

Re: Loading open files from last session

[Jean-Marc Lasgouttes]

Le 07/12/2015 00:16, Andrew Parsloe a écrit :

Under Tools > Preferences > Look &  Feel > Document Handling, the first
check box of the initial three, "Restore windows layouts and
geometries", doesn't work as far as split view windows are concerned.
(surely included under "layouts and geometries"?). This is true of 2.2
alpha2 and 2.1.4 on Windows 7.

A current project requires about 8 documents open at once, split into
two groups, one viewed in the left pane, the other the right. When
launched LyX opens all the documents (the third check box is set) and
remembers cursor positions (the second check box is set) but doesn't
split the view (the first check box is set but ineffective).


It is a missing feature AFAICS. Please open a ticket.

JMarc

Re: [LyX/master] Spanish Tutorial.lyx: preamble code proposed by Günther

[Guenter Milde]

On 2015-12-06, Kornel Benko wrote:
> Am Sonntag, 6. Dezember 2015 um 05:25:35, schrieb Uwe Stöhr
> 
>> Am 04.12.2015 um 09:58 schrieb Guenter Milde:

...

>> For the compilation with system fonts we should do nothing since we 
>> cannot know the system status of the user. If someones desperately needs 
>> to view a doc file with his own fonts, it is his duty to select fonts 
>> that will work.

> We are speaking about tests IMHO, not some user's font selection.
> We are not testing with arbitrary system fonts. 
> If the system font is specified in lyx, we use it.
> Else we select (for most languages) the font which should be good for
> that language, and is free to download.

IMO, since it is now possible to store both TeX- and system-fonts in the lyx
file, we can set working system fonts in the files that ship with LyX.
(The "use non-TeX fonts" setting should stay at False.)

+1 If the default system font (Latin Modern) does not provide all
   characters used in the document, setting suitable non-TeX fonts in the
   document is an indication for this fact.
   The user no longer has to find out that just selecting "use non-TeX
   fonts" leads to compilation errors.

+1 tests are easier to reproduce "by hand"

+1 the test machinery becomes a bit simpler: no need to store suitable fonts
   in some test-script, no need for on-the-fly replacement of fonts.

-0 For the intended output format (pdflatex), this setting is not
   required. However, it will not affect default export.
   
Uwe, would you agree that we store non-TeX fonts in the documentation files
whereever Latin Modern OTF fonts fail (Greek, Russian, CJK, ...)?

Günter

Re: #8796: theorems-named module incompatible with some theorem numbering modules

[Paul A. Rubin]

Thanks. I've been getting ticket updates from the issue tracker. Not 
sure what your "little problem" was, but ignorance is usually bliss. :-)


Paul

On 12/06/2015 11:44 PM, LyX Ticket Tracker wrote:

#8796: theorems-named module incompatible with some theorem numbering modules
+
  Reporter:  prubin  |   Owner:  rgheck
  Type:  defect  |  Status:  fixedinmaster
  Priority:  normal  |   Milestone:  2.2.0
Component:  layout  | Version:  2.0.6
  Severity:  normal  |  Resolution:
  Keywords:  fileformat  |
+
Changes (by skostysh):

  * cc: rubin@… (added)


Comment:

  Replying to [comment:26 rgheck]:
  > FYI, it looks as if Paul Rubin's username got lost when we had our
  little problem

  CC'ing him directly then so that he knows that the issue will be fixed for
  2.2.0.

Re: Loading open files from last session

[Guillaume Munch]

Le 07/12/2015 16:05, Guillaume Munch a écrit :

Le 07/12/2015 15:52, Jean-Marc Lasgouttes a écrit :

It is a missing feature AFAICS. Please open a ticket.



That's  and


I meant 

Re: [LyX/master] Fix a debug comment

[Scott Kostyshak]

On Mon, Dec 07, 2015 at 03:51:32PM +0100, Jean-Marc Lasgouttes wrote:
> Le 07/12/2015 08:02, Scott Kostyshak a écrit :
> >commit acadb4d6083bc5dcf85d98041fbf6e717fc818ec
> >Author: Scott Kostyshak 
> >Date:   Mon Dec 7 02:02:04 2015 -0500
> >
> > Fix a debug comment
> >-//lyxerr << "drawing '" << char_ << "' font: " << pi.base.fontname << 
> >endl;
> >+//lyxerr << "drawing '" << char_ << "' font: " << pi.base.fontname << 
> >std::endl;
> 
> Actually, most .cpp files do not need this std:: because they contain the
> line
>   using namspace cpp;
> 
> Almost one fifth of them specify specify this directive, though:

Are you suggesting we add the directive? In any case, I did not realize
all of the debug comments in the file were like that. I should not have
changed one and instead should have changed them all. Or as perhaps you
are suggesting I should have changed none and then add the directive?
For some reason I thought we were trying to get rid of the directive.

Scott


signature.asc
Description: PGP signature

Re: Loading open files from last session

[Guillaume Munch]

Le 07/12/2015 15:52, Jean-Marc Lasgouttes a écrit :

Le 07/12/2015 00:16, Andrew Parsloe a écrit :

Under Tools > Preferences > Look &  Feel > Document Handling, the first
check box of the initial three, "Restore windows layouts and
geometries", doesn't work as far as split view windows are concerned.
(surely included under "layouts and geometries"?). This is true of 2.2
alpha2 and 2.1.4 on Windows 7.

A current project requires about 8 documents open at once, split into
two groups, one viewed in the left pane, the other the right. When
launched LyX opens all the documents (the third check box is set) and
remembers cursor positions (the second check box is set) but doesn't
split the view (the first check box is set but ineffective).


It is a missing feature AFAICS. Please open a ticket.



That's  and 
, don't hesitate to subscribe to them.

Re: [LyX/master] ctest export test documentation update

[Kornel Benko]

Am Montag, 7. Dezember 2015 um 17:58:16, schrieb Günter Milde 
> commit 6df72ef648b38ff858f24b6d10b3d1326f4cb0ca
> Author: Günter Milde 
> Date:   Mon Dec 7 17:56:43 2015 +0100
> 
> ctest export test documentation update
> 
> diff --git a/lib/doc/Development.lyx b/lib/doc/Development.lyx

Nice, thanks for the description.

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: We now include both png and svgz?

[Georg Baum]

Scott Kostyshak wrote:

> From what I understand, there is support for the change. I think Georg's
> main concern was that on some systems it might not work, but Enrico
> seems confident that it will work even on less commonly used systems and
> even for 4.8.x.

This is fine with me as well, I had no concern, I only wanted to point to 
the contradiction.


Georg

Re: We now include both png and svgz?

[Scott Kostyshak]

On Mon, Dec 07, 2015 at 08:43:03PM +0100, Georg Baum wrote:
> Scott Kostyshak wrote:
> 
> > From what I understand, there is support for the change. I think Georg's
> > main concern was that on some systems it might not work, but Enrico
> > seems confident that it will work even on less commonly used systems and
> > even for 4.8.x.
> 
> This is fine with me as well, I had no concern, I only wanted to point to 
> the contradiction.

Yes I'm glad you did. I think it is the right thing to do and also is
something that is best done in a major release. Hopefully there will not
be an issue.

Scott


signature.asc
Description: PGP signature

Re: Loading open files from last session

[Andrew Parsloe]

On 8/12/2015 5:06 a.m., Guillaume Munch wrote:

Le 07/12/2015 16:05, Guillaume Munch a écrit :

Le 07/12/2015 15:52, Jean-Marc Lasgouttes a écrit :

It is a missing feature AFAICS. Please open a ticket.



That's  and


I meant 
I did search on trac (looking for 'split view'), thinking it likely this 
had come up before. Thanks for pointing this out to me.


Andrew

---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

Re: Should we release 2.2.0 with Qt 5.5.1?

[Georg Baum]

Uwe Stöhr wrote:

> Am 06.12.2015 um 12:32 schrieb Georg Baum:
> 
>>> Good news: I am able to compile LyX 2.2.0alpha2 with Qt 5.5.1 using MSVC
>>> 2013 (32bit).
>>
>> Did you recompile the dependencies iconv, hunspell and zlib with MSVC
>> 2013?
> 
> Of course not. I don't know how to do this and who did this in the past.

OK, this is a problem. It is not possible to mix code compiled with 
different MSVC versions. I have first hand experience with that (forgot to 
recompile a library after upgrading MSVC), this leads to hard to find 
runtime bugs that you really do not want to debug (can easily suck away 
hours or even days for debugging). If my experience is not convincing 
enough, read this: http://siomsystems.com/mixing-visual-studio-versions/ 
(caution: very long, very technical, but a good read for anybody who is 
interested in the details).

BTW, to check whether different MSVC versions were used for any .exe, use 
dependency walker: If it finds more than one MSVCRXXX.DLL or MSVCPXXX.DLL, 
where XXX is e.g. 100 for MSVC 2010 or 120 for MSVC 2013 (120 is no typo), 
then you are in trouble.

> So since I cannot compile iconv and friends with MSVC 2013, I cannot
> release a LyX 2.2 version?

There are only two options: Either you recompile all dependencies (including 
qt btw, if no binary package compiled with MSVC 2013 is offered) with MSVC 
2013, or you need to compile LyX with MSVC 2010. If you cannot recompile the 
dependencies with MSVC 2013, and cannot find somebody else to do it, you 
have to stick to MSVC 2010.

> For now I only found one crash bug:
> http://www.lyx.org/trac/ticket/9892
> nothing more. Do you think that it is caused by iconv and friends?

Honestly I have no idea. But since it is clear that mixing MSVC versions can 
cause such bugs, it is a waste of time to investigate this issue as long as 
we do not have a clean build which uses only one MSVC version.


Georg

Re: using std_regex on Windows leads to 135 compilation errors

[Georg Baum]

Uwe Stöhr wrote:

> Now i erased everything again, applied your patches and get e.g. for
> support.lib:
> 
> support.lib(_allinone_const.obj) : error LNK2019: unresolved external
> symbol "private: class boost::basic_regex boost::regex_traits > &
> __thiscall boost::basic_regex boost::w32_regex_traits > >::do_assign(char const *,char const
> *,unsigned int)" (?do_assign@?$basic_regex@DU?$regex_traits@DV
> ?$w32_regex_traits@D@boost@@@boost@@@boost@@AAEAAV12@PBD0I@Z) referenced
> in function "public: __thiscall boost::basic_regex boost::regex_traits
>  >::basic_regex boost::w32_regex_traits > >,class
> std::allocator >(class std::basic_string std::char_traits,class std::allocator > const &,unsigned
> int)"
> (??$?0U?$char_traits@D@std@@V?$allocator@D@1@@?$basic_regex@DU?
$regex_traits@DV?$w32_regex_t
> raits@D@boost@@@boost@@@boost@@QAE@ABV?$basic_string@DU?
$char_traits@D@std@@V?$
> allocator@D@2@@std@@I@Z)
> [D:\LyXGit\Master\compile-2013\src\tests\check_Length.
> vcxproj]
> 
> 
> I don't know anything about linking but to me it seems that boost regex
> is still used somewhere.

Yes, that is correct. Unfortunately I am now out of ideas. Neither the 
source code nor the cmake files contain any direct reference to 
boost::regex, this is all controlled by the setup switches. I cannot imagine 
how this can happen if you start from an empty build directory (without 
cmake caches), and give the -DLYX_ENABLE_CXX11=ON command line argument to 
cmake in build.bat.


Georg

Re: CMake problem when compiling with Qt 5.5 and MSVC 2013

[Georg Baum]

Uwe Stöhr wrote:

> When I compile LyX 2.2git with Qt5.5 and MSVC 2013 in install mode this
> command is executed:
> 
> msbuild INSTALL.vcxproj /p:Configuration=Release
> 
> But this leads now to these errors:
> 
> "D:\LyXGit\Master\compile-2013\INSTALL.vcxproj" (Standardziel) (1) ->
> (PostBuildEvent Ziel) ->
>C:\Program Files
> (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5):
> error MSB3073: Der Befehl "setlocal\r
> [D:\LyXGit\Master\compile-2013\INSTALL.vcxproj]
> C:\Program Files
> (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5):
> error MSB3073: "C:\Program Files (x86)\CMake\bin\cmake.exe"
> -DBUILD_TYPE=Release -P cmake_install.cmake\r
> [D:\LyXGit\Master\compile-2013\INSTALL.vcxproj]
> C:\Program Files
> (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5):
> error MSB3073: if %errorlevel% neq 0 goto :cmEnd\r
> [D:\LyXGit\Master\compile-2013\INSTALL.vcxproj]
> C:\Program Files
> (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5):
> error MSB3073: :cmEnd\r [D:\LyXGit\Master\compile-2013\INSTALL.vcxproj]
> C:\Program Files
> (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5):
> error MSB3073: endlocal & call :cmErrorLevel %errorlevel% & goto :cmDone\r
> [D:\LyXGit\Master\compile-2013\INSTALL.vcxproj]
> C:\Program Files
> (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5):
> error MSB3073: :cmErrorLevel\r
> [D:\LyXGit\Master\compile-2013\INSTALL.vcxproj] C:\Program Files
> (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5):
> error MSB3073: exit /b %1\r
> [D:\LyXGit\Master\compile-2013\INSTALL.vcxproj] C:\Program Files
> (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5):
> error MSB3073: :cmDone\r [D:\LyXGit\Master\compile-2013\INSTALL.vcxproj]
> C:\Program Files
> (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5):
> error MSB3073: if %errorlevel% neq 0 goto :VCEnd\r
> [D:\LyXGit\Master\compile-2013\INSTALL.vcxproj]
> C:\Program Files
> (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5):
> error MSB3073: :VCEnd" wurde mit dem Code 1 beendet.
> [D:\LyXGit\Master\compile-2013\INSTALL.vcxproj]

Did you set the USED_STUDIO variable in build.bat to "Visual Studio 12 2013" 
(either directly or by calling build.bat with a second command line 
argument? If not, then this could be the reason. MSVC can read project files 
from older versions in general, but the messy .vcxproj files that cmake 
creates may contain version specific stuff that breaks backward 
compatibility.

If you did not set this variable, then please clean everything before 
running cmake again, otherwise you could get a mixture of old and new 
versions.

Another possibily might be that our cmake setup contains version specific 
install code somehwere, but I still have a very hard time understanding 
CMakeLists.txt files, so I don't know if that is the case.


Georg

Re: [LyX/master] Fix a debug comment

[Georg Baum]

Scott Kostyshak wrote:

> Are you suggesting we add the directive? In any case, I did not realize
> all of the debug comments in the file were like that. I should not have
> changed one and instead should have changed them all. Or as perhaps you
> are suggesting I should have changed none and then add the directive?
> For some reason I thought we were trying to get rid of the directive.

This is a subject for endless flame wars. I personally do not like "using 
namespace std" at all, but others do like it very much, so I try to stay 
away from discussions about this subject.


Georg

Re: Latest changes in manuals

[Georg Baum]

Uwe Stöhr wrote:

> Am 06.12.2015 um 13:52 schrieb Georg Baum:
> 
>> 
http://www.lyx.org/trac/changeset/d879599cec4902a1a3ea7aa7a8d7d24815701036/lyxgit
>>> or
>>>
>> 
http://www.lyx.org/trac/changeset/42536a561606290ebdb90c46badbb451487f5293/lyxgit
>>
>> None of these did change a path.
> 
> they did:
> 
> -\origin /systemlyxdir/doc/
> +\origin unavailable

OK, this is a misunderstanding, I should havbe been more precide: I meant 
paths to included files (images or child docs).

>> - Do not change the paths in general if the files can be found using the
>> relative paths. Has the additional benefit that this is also the wanted
>> behaviour if I copy a whole directory of LyX files (including referenced
>> graphics) to a new location. Disadvantage would be that the machinery
>> does now depend on the presence of external files, and it is not
>> guaranteed that the file that is found is the correct one.
> 
> I would prefer that but don#t know enough about the background of such a
> change.

Technically it is easy to do. The question is whether we want it.

>>> That is not true. I know why this doesn't work. That is why the
>>> installer exists: you need to specify the PATH variable linking to Perl
>>> (e.g for texindy), Python (for our scripts), ImageMagick which needs
>>> also Ghostscript, rsvg and/or Inkscape.
>>
>> If this is the only issue then you can run LyX from within MSVC easily:
>> You can specify environment variables for debugging in MSVC, so you can
>> set the correct PATH once in MSVC and then save a lot of time by not
>> requiring installation for each tiny source change. I don't know by heart
>> how to do it, but I can look it up if you want.
> 
> Well, nobody can tell me how to do this.

Then you did not ask the right people. The first hit for the search "msvc 
debug environment variable" is this: 
http://stackoverflow.com/questions/100543/how-do-i-set-specific-environment-variables-when-debugging-in-visual-studio

The screen shot is from MSVC 2008, but I can confirm that this does still 
work the same in MSVC 2010.


Georg

[patch] Do not pretend that MSVC 12 can use dependencies compiled with MSVC 10

[Georg Baum]

First, for those who don't know, something about MSVC versions (it is easy 
to get confused there):

MSVC 8: Microsoft Visual Studio 2005
MSVC 9: Microsoft Visual Studio 2008
MSVC 10: Microsoft Visual Studio 2010 Don't be mislead by the nice fit!
MSVC 11: Microsoft Visual Studio 2012 From here on we are "one off"!
MSVC 12: Microsoft Visual Studio 2013
MSVC 14: Microsoft Visual Studio 2015

Peter added a workaround for mixing code compiled by MSVC 12 and MSVC 10 
some time ago:
http://www.lyx.org/trac/changeset/6b4c3036/lyxgit/ According to 
https://msdn.microsoft.com/en-us/library/7sf3txa8.aspx the /vd2 option is 
only needed if one wants to violate the C++ standard (using dynamic_cast on 
an object being constrcuted does not work in standard conforming compilers).

I'd like to get rid of this for two reasons:

1) Mixing different MSVC versions is a bad idea as explained in the other 
thread, so we should not help people to shoot themselves in the foot.

2) We cannot use dynamic_cast on not fully constrcuted objects anyway, since 
we support other compilers besides MSVC.

OK to go in?


Georgdiff --git a/CMakeLists.txt b/CMakeLists.txt
index 5840ad0..5fb1218 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -229,10 +229,6 @@ if(LYX_DEPENDENCIES_DOWNLOAD)
 		endif()
 	endforeach()
 	set(GNUWIN32_DIR ${LYX_DEPENDENCIES_DIR}/deps20)
-if(MSVC12)
-# handle error in msvc12 when linking against msvc10 libs
-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /vd2")
-endif()
 endif()
 
 

Re: [LyX/master] Fix a debug comment

[Jean-Marc Lasgouttes]

I do not really care actually. I was maybe trying to start a flame war without 
knowing it :)

JMarc

Le 7 décembre 2015 21:14:51 GMT+01:00, Georg Baum 
 a écrit :
>Scott Kostyshak wrote:
>
>> Are you suggesting we add the directive? In any case, I did not
>realize
>> all of the debug comments in the file were like that. I should not
>have
>> changed one and instead should have changed them all. Or as perhaps
>you
>> are suggesting I should have changed none and then add the directive?
>> For some reason I thought we were trying to get rid of the directive.
>
>This is a subject for endless flame wars. I personally do not like
>"using 
>namespace std" at all, but others do like it very much, so I try to
>stay 
>away from discussions about this subject.
>
>
>Georg

compilation error with Re: We now include both png and svgz?

[Uwe Stöhr]

Am 07.12.2015 um 19:48 schrieb Enrico Forestieri:


Done at db363ab1.


Now I get a compilation error:

  Generating qrc_Resources.cpp
  RCC: Error in 
'D:/LyXGit/Master/compile-2013/src/frontends/qt4/Resources.qrc' : Cannot 
find file 'D:/LyXGit/Master/lib/images/all-changes-accept.png'


maybe you removed to much?

thanks and regards
uwe

Re: Should we release 2.2.0 with Qt 5.5.1?

[Uwe Stöhr]

Am 07.12.2015 um 20:58 schrieb Georg Baum:


So since I cannot compile iconv and friends with MSVC 2013, I cannot
release a LyX 2.2 version?


There are only two options: Either you recompile all dependencies (including
qt btw, if no binary package compiled with MSVC 2013 is offered)


Then LyX for Windows is dead. The developers of libraries such as 
libiconv do not provide Windows builds. I nevertheless gave it a try and 
found this:

https://github.com/winlibs/libiconv

Nice and I can even compile iconv.dll with this and MSVC 2013 but when I 
use the created iconv.lib and iconv.h in the dependencies I get 
compilation errors with LyX:


  D:/LyXGit/Master/src/support/docstream.cpp(280): error C2664: 'size_t 
libiconv(libiconv_t,char **,size_t *,char **,size_t *)' : cannot convert 
argument 2 from 'const char **' to 'char **' 
[D:\LyXGit\Master\compile-2013\src\support\support.vcxproj]
  D:/LyXGit/Master/src/support/unicode.cpp(145): error C2664: 'size_t 
libiconv(libiconv_t,char **,size_t *,char **,size_t *)' : cannot convert 
argument 2 from 'const char **' to 'char **' 
[D:\LyXGit\Master\compile-2013\src\support\support.vcxproj]


Of course I can change unicode.cpp and docstream.cpp but then you will 
get compilation problems, right?


regards Uwe

Re: Should we release 2.2.0 with Qt 5.5.1?

[Georg Baum]

Uwe Stöhr wrote:

> Am 07.12.2015 um 20:58 schrieb Georg Baum:
> 
>>> So since I cannot compile iconv and friends with MSVC 2013, I cannot
>>> release a LyX 2.2 version?
>>
>> There are only two options: Either you recompile all dependencies
>> (including qt btw, if no binary package compiled with MSVC 2013 is
>> offered)
> 
> Then LyX for Windows is dead.

Not at all. But maybe I should stop trying to help with MSVC and use the 
time to study cross-compilation with mingw, the ROI is probably much better 
for this alternative.

> Nice and I can even compile iconv.dll with this and MSVC 2013 but when I
> use the created iconv.lib and iconv.h in the dependencies I get
> compilation errors with LyX:
> 
>D:/LyXGit/Master/src/support/docstream.cpp(280): error C2664: 'size_t
> libiconv(libiconv_t,char **,size_t *,char **,size_t *)' : cannot convert
> argument 2 from 'const char **' to 'char **'
> [D:\LyXGit\Master\compile-2013\src\support\support.vcxproj]
>D:/LyXGit/Master/src/support/unicode.cpp(145): error C2664: 'size_t
> libiconv(libiconv_t,char **,size_t *,char **,size_t *)' : cannot convert
> argument 2 from 'const char **' to 'char **'
> [D:\LyXGit\Master\compile-2013\src\support\support.vcxproj]
> 
> Of course I can change unicode.cpp and docstream.cpp but then you will
> get compilation problems, right?

The determination of the macro ICONV_CONST would need to be adjusted in 
cmake. The cpp files are fine as they are.


Georg

Re: compilation error with Re: We now include both png and svgz?

[Kornel Benko]

Am Montag, 7. Dezember 2015 um 22:10:35, schrieb Uwe Stöhr 
> Am 07.12.2015 um 19:48 schrieb Enrico Forestieri:
> 
> > Done at db363ab1.
> 
> Now I get a compilation error:
> 
>Generating qrc_Resources.cpp
>RCC: Error in 
> 'D:/LyXGit/Master/compile-2013/src/frontends/qt4/Resources.qrc' : Cannot 
> find file 'D:/LyXGit/Master/lib/images/all-changes-accept.png'

I know this one. It is the old Resources.qrc having still the old references, 
you have to remove it first.
It is only rebuild if it does not exist.

Dependencies don't help here unfortunately.

> maybe you removed to much?
> 
> thanks and regards
> uwe

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: compilation error with Re: We now include both png and svgz?

[Kornel Benko]

Am Montag, 7. Dezember 2015 um 22:38:48, schrieb Kornel Benko 
> Am Montag, 7. Dezember 2015 um 22:10:35, schrieb Uwe Stöhr 
> > Am 07.12.2015 um 19:48 schrieb Enrico Forestieri:
> > 
> > > Done at db363ab1.
> > 
> > Now I get a compilation error:
> > 
> >Generating qrc_Resources.cpp
> >RCC: Error in 
> > 'D:/LyXGit/Master/compile-2013/src/frontends/qt4/Resources.qrc' : Cannot 
> > find file 'D:/LyXGit/Master/lib/images/all-changes-accept.png'
> 
> I know this one. It is the old Resources.qrc having still the old references, 
> you have to remove it first.
> It is only rebuild if it does not exist.
> 
> Dependencies don't help here unfortunately.

That is not enough, you have also remove the object files.
The complete list (in the build-dir) is (linux, but windows should be simmilar)

src/frontends/qt4/Resources.qrc
src/frontends/qt4/qrc_Resources.cpp
src/frontends/qt4/CMakeFiles/frontend_qt.dir/qrc_Resources.cpp.o

and than reconfigure.

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: Should we release 2.2.0 with Qt 5.5.1?

[Uwe Stöhr]

Am 07.12.2015 um 22:26 schrieb Georg Baum:

>> Then LyX for Windows is dead.


Not at all. But maybe I should stop trying to help with MSVC and use the
time to study cross-compilation with mingw, the ROI is probably much better
for this alternative.


Why don't you install Windows and use MSVC? I mean Windows hast the vast 
majority of the market share and this applies also for our users. That's 
why I don't understand why I am the only one on Windows.
MSVC is for free and a Windows license is cheap. We have even enough 
funding to buy some Windows licenses from the money people spent the LyX 
project.
So money is no problem, disk space is also no problem, then there 
shouldn't be a problem for anyone here to compile LyX on Windows.


I don't want to sound rude, I just desperately need another developer on 
Windows. I am close to quit LyX because I don't know compiler things and 
I don't have enough spare time to learn this. When I go who can then 
provide a native Windows build of LyX?



Of course I can change unicode.cpp and docstream.cpp but then you will
get compilation problems, right?


The determination of the macro ICONV_CONST would need to be adjusted in
cmake. The cpp files are fine as they are.


How would such a patch look like?

thanks and regards
Uwe

p.s. I was able to compile zlib with MSVC 2013

I am now trying out this:
https://github.com/kahrl/gettext-msvc

Re: Should we release 2.2.0 with Qt 5.5.1?

[Uwe Stöhr]

Am 07.12.2015 um 23:07 schrieb Uwe Stöhr:

> I am now trying out this:
> https://github.com/kahrl/gettext-msvc

this worked fine. So I have now compiled all libraries with MSVC 2013.
The remaining issue is now:


The determination of the macro ICONV_CONST would need to be adjusted in
cmake. The cpp files are fine as they are.


How would such a patch look like?


many thanks and regards
Uwe

Re: compilation error with Re: We now include both png and svgz?

[Uwe Stöhr]

Am 07.12.2015 um 22:53 schrieb Kornel Benko:


That is not enough, you have also remove the object files



many thanks! Now the error is gone.

best regards
Uwe

Re: CMake problem when compiling with Qt 5.5 and MSVC 2013

[Uwe Stöhr]

Am 07.12.2015 um 21:12 schrieb Georg Baum:


When I compile LyX 2.2git with Qt5.5 and MSVC 2013 in install mode this
command is executed:

msbuild INSTALL.vcxproj /p:Configuration=Release

But this leads now to these errors:


Did you set the USED_STUDIO variable in build.bat to "Visual Studio 12 2013"


Yes, I did.


Another possibily might be that our cmake setup contains version specific
install code somehwere, but I still have a very hard time understanding
CMakeLists.txt files, so I don't know if that is the case.


that might be. For now it seems that the bug has gone but I don't know 
why. I will report back if it reappears.


thanks and regards
Uwe

Re: We now include both png and svgz?

[Enrico Forestieri]

On Sun, Dec 06, 2015 at 09:12:11PM -0500, Scott Kostyshak wrote:
> On Sun, Dec 06, 2015 at 03:08:47PM +0100, Enrico Forestieri wrote:
> > On Sun, Dec 06, 2015 at 11:52:14AM +0100, Georg Baum wrote:
> > 
> > > Jean-Marc Lasgouttes wrote:
> > > 
> > > > Le 06/12/15 00:02, Scott Kostyshak a écrit :
> > > >> There was an issue on Windows that came from not including a .dll. Now
> > > >> that the issue has been fixed, we should decide if we would like to
> > > >> consider removing the .pngs. If we would like to remove the .pngs for
> > > >> 2.2.0 I think we should definitely do this for beta1. Conversely, if we
> > > >> remove the .pngs for beta, I think it would still be OK to add them 
> > > >> back
> > > >> for the final release if we discover problems, as JMarc proposed [1].
> > > > 
> > > > I think we should remove them.
> > > 
> > > Me too. As I wrote in the bug report, the current state does not make 
> > > sense. 
> > > If we do not remove the .pngs for some reason, then we need to change the 
> > > search algorithm to use .png them if loading .svg fails.
> > 
> > The attached script and patch get rid of the unneeded pngs.
> 
> From what I understand, there is support for the change. I think Georg's
> main concern was that on some systems it might not work, but Enrico
> seems confident that it will work even on less commonly used systems and
> even for 4.8.x.
> 
> Enrico, I would say commit. Thanks for the patch.

Done at db363ab1.

-- 
Enrico

Re: #8796: theorems-named module incompatible with some theorem numbering modules

[Richard Heck]

On 12/07/2015 10:08 AM, Paul A. Rubin wrote:
> Thanks. I've been getting ticket updates from the issue tracker. Not
> sure what your "little problem" was, but ignorance is usually bliss. :-)

All user names got deleted a few months ago. As in: ALL.

Does the solution I committed look right to you?

Richard

Re: [LyX/master] build5.bat: a script to compile with Qt5 on Windows

[Uwe Stöhr]

Am 08.12.2015 um 01:34 schrieb Kornel Benko:


The script lacks the cmake parameter '-DLYX_USE_QT=QT5'. Since the default is 
QT4, the compilation is without QT5.


Thanks Kornel. However, when I start the compilation I see that QT5 is 
detected because I configured CMake with QT5.


BTW. I need to compile iconv without const but the attached patch does 
not help me. What do i miss?


thanks and regards
Uwe
 development/cmake/configCompiler.h.cmake  | 2 +-
 development/cmake/configCompiler.h.msvc   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/development/cmake/configCompiler.h.cmake 
b/development/cmake/configCompiler.h.cmake
index 858cfc9..c46daa7 100644
--- a/development/cmake/configCompiler.h.cmake
+++ b/development/cmake/configCompiler.h.cmake
@@ -59,7 +59,7 @@
 #define HAVE_ALLOCA
 #endif
 
-#cmakedefine HAVE_ICONV_CONST 1
+#cmakedefine HAVE_ICONV_CONST 0
 #ifdef HAVE_ICONV_CONST
 #define ICONV_CONST const
 #else
diff --git a/development/cmake/configCompiler.h.msvc 
b/development/cmake/configCompiler.h.msvc
index d978be1..38bb350 100644
--- a/development/cmake/configCompiler.h.msvc
+++ b/development/cmake/configCompiler.h.msvc
@@ -105,7 +105,7 @@
 #endif
 
 
-#define HAVE_ICONV_CONST 1
+#define HAVE_ICONV_CONST 0
 #ifdef HAVE_ICONV_CONST
 #define ICONV_CONST const
 #else

Re: using std_regex on Windows leads to 135 compilation errors

[Uwe Stöhr]

Am 07.12.2015 um 21:03 schrieb Georg Baum:


Yes, that is correct. Unfortunately I am now out of ideas.


I found now the problem:

LYX_USE_CXX11

is never set.

I can test this by uncommenting this in line 15 of regex.h then the 
comilation works.


I applied Kornel's patch for FindCXX11Compiler.cmake and I have there

set(LYX_USE_CXX11 1)
set(CXX11_FLAG "")

But this has obviously no effect.

Kornel, what can i do here?

thanks and regards
Uwe

Re: [LyX/master] build5.bat: a script to compile with Qt5 on Windows

[Uwe Stöhr]

Am 08.12.2015 um 01:59 schrieb Kornel Benko:


Maybe you have more than 1 iconv.h?


I had only one, but the one from the MSVC2010 build. Now it compiles!

Many thanks and best regards
Uwe

2 compilation questions

[Uwe Stöhr]

- we store our frontends files in a folder named qt4. Should we split it 
up to qt5 and qt4 to address specific changes? If not we can rename the 
folder to just "qt", right?


- I could now compile the dependencies with MSVC. Thus also libintl. But 
in CMake I cannot see that libintl is actually used. Is this correct and 
we can get rid of it?


thanks and regards
Uwe

Re: using std_regex on Windows leads to 135 compilation errors

[Kornel Benko]

Am Dienstag, 8. Dezember 2015 um 02:09:55, schrieb Uwe Stöhr 
> Am 08.12.2015 um 02:07 schrieb Uwe Stöhr:
> 
> > I applied Kornel's patch for FindCXX11Compiler.cmake and I have there
> >
> > set(LYX_USE_CXX11 1)
> > set(CXX11_FLAG "")
> 
> Of course I uncommented the IF for MSVC 2010 since I use MSVC 2013. So
> set(LYX_USE_CXX11 1)
> should always be executed but apparently it is not.
> 
> regards Uwe

I think, that my patch may have been wrong.
If you look at the lines below, you see the foreach(), there the value is 
apparently set to "".
So the correct patch should be

if (MSVC10) # or whatever
set(LYX_USE_CXX11 1)
set(CXX11_FLAG "")
else()
foreach( 

endforeach()
endif()



Kornel

signature.asc
Description: This is a digitally signed message part.

Re: [LyX/master] Spanish Tutorial.lyx: preamble code proposed by Günther

[Uwe Stöhr]

Am 07.12.2015 um 15:57 schrieb Guenter Milde:


Uwe, would you agree that we store non-TeX fonts in the documentation files
wherever Latin Modern OTF fonts fail (Greek, Russian, CJK, ...)?


Yes. Please go ahead.

After this change the doc files will be frozen to give the translators a 
chance to do their work or do you see other issues to resolve first?


thanks and regards
Uwe

Re: using std_regex on Windows leads to 135 compilation errors

[Uwe Stöhr]

Am 08.12.2015 um 02:30 schrieb Kornel Benko:


We have to set also CXX11COMPILER_FOUND

set(LYX_USE_CXX11 1)
set(CXX11_FLAG "")
set(CXX11COMPILER_FOUND 1)


This doesn't solve the problem.

defined(LYX_USE_CXX11)

is still false in regex.h

regards Uwe

Re: [LyX/master] build5.bat: a script to compile with Qt5 on Windows

[Kornel Benko]

Am Dienstag, 8. Dezember 2015 um 01:24:04, schrieb Uwe Stöhr 

> commit 01e029202845d01c8f779a43d30193e4549dab53
> Author: Uwe Stöhr 
> Date:   Tue Dec 8 01:23:54 2015 +0100
> 
> build5.bat: a script to compile with Qt5 on Windows
> 
> This script shows how i compile. If we figured out every corner cases 
> with it it should become the standard build script for Windows

The script lacks the cmake parameter '-DLYX_USE_QT=QT5'. Since the default is 
QT4, the compilation is without QT5.

Kornel



signature.asc
Description: This is a digitally signed message part.

Re: [LyX/master] build5.bat: a script to compile with Qt5 on Windows

[Kornel Benko]

Am Dienstag, 8. Dezember 2015 um 01:43:10, schrieb Uwe Stöhr 
> Am 08.12.2015 um 01:34 schrieb Kornel Benko:
> 
> > The script lacks the cmake parameter '-DLYX_USE_QT=QT5'. Since the default 
> > is QT4, the compilation is without QT5.
> 
> Thanks Kornel. However, when I start the compilation I see that QT5 is 
> detected because I configured CMake with QT5.
> 
> BTW. I need to compile iconv without const but the attached patch does 
> not help me. What do i miss?

Because it is wrong. It is a template for for an entry in configCompiler.h in 
the build directory.

You have to first detect the value, which is done at ConfigureChecks.cmake:94.
We try here to compile a snippet, and if it is OK, then we set HAVE_ICONV_CONST 
to 1.

This will create "#define HAVE_ICONV_CONST 1" in configCompiler.h.

Now the question is, why this snippet compiles?

Maybe you have more than 1 iconv.h? One which lyx uses, and one which is used 
by the sources for iconv lib?

> thanks and regards
> Uwe

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: using std_regex on Windows leads to 135 compilation errors

[Uwe Stöhr]

Am 08.12.2015 um 02:07 schrieb Uwe Stöhr:


I applied Kornel's patch for FindCXX11Compiler.cmake and I have there

set(LYX_USE_CXX11 1)
set(CXX11_FLAG "")


Of course I uncommented the IF for MSVC 2010 since I use MSVC 2013. So
set(LYX_USE_CXX11 1)
should always be executed but apparently it is not.

regards Uwe

Re: using std_regex on Windows leads to 135 compilation errors

[Kornel Benko]

Am Dienstag, 8. Dezember 2015 um 02:20:25, schrieb Kornel Benko 
> Am Dienstag, 8. Dezember 2015 um 02:09:55, schrieb Uwe Stöhr 
> 
> > Am 08.12.2015 um 02:07 schrieb Uwe Stöhr:
> > 
> > > I applied Kornel's patch for FindCXX11Compiler.cmake and I have there
> > >
> > > set(LYX_USE_CXX11 1)
> > > set(CXX11_FLAG "")
> > 
> > Of course I uncommented the IF for MSVC 2010 since I use MSVC 2013. So
> > set(LYX_USE_CXX11 1)
> > should always be executed but apparently it is not.
> > 
> > regards Uwe
> 
> I think, that my patch may have been wrong.
> If you look at the lines below, you see the foreach(), there the value is 
> apparently set to "".
> So the correct patch should be
> 
> if (MSVC10)   # or whatever
>   set(LYX_USE_CXX11 1)
>   set(CXX11_FLAG "")
> else()
>   foreach( 
>   
>   endforeach()
> endif()
> 
Forget it.
We have to set also CXX11COMPILER_FOUND

set(LYX_USE_CXX11 1)
set(CXX11_FLAG "")
set(CXX11COMPILER_FOUND 1)

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: using std_regex on Windows leads to 135 compilation errors

[Kornel Benko]

Am Dienstag, 8. Dezember 2015 um 02:38:10, schrieb Uwe Stöhr 
> Am 08.12.2015 um 02:30 schrieb Kornel Benko:
>
> > We have to set also CXX11COMPILER_FOUND
> >
> > set(LYX_USE_CXX11 1)
> > set(CXX11_FLAG "")
> > set(CXX11COMPILER_FOUND 1)
>
> This doesn't solve the problem.
>
> defined(LYX_USE_CXX11)
>
> is still false in regex.h
>
> regards Uwe

Try this patch.

Kornel

signature.asc
Description: This is a digitally signed message part.
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 5840ad0..3286c4e 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -269,9 +269,13 @@ if(UNIX OR MINGW)
 	endif()
 else()
 	set(LYX_USE_STD_REGEX 0)
-#	if(MSVC10)
-#		set(LYX_USE_STD_REGEX 1) #TODO should we use it in ECMAScript mode?
-#	endif()
+	if(WIN32)
+		if (LYX_ENABLE_CXX11)
+			set(LYX_USE_STD_REGEX 1) #TODO should we use it in ECMAScript mode?
+			set(LYX_USE_CXX11 1)
+			set(CXX11_FLAG "")
+		endif()
+	endif()
 endif()
 
 

Re: 2 compilation questions

[Kornel Benko]

Am Dienstag, 8. Dezember 2015 um 02:18:57, schrieb Uwe Stöhr 
> - we store our frontends files in a folder named qt4. Should we split it 
> up to qt5 and qt4 to address specific changes? If not we can rename the 
> folder to just "qt", right?
> 
> - I could now compile the dependencies with MSVC. Thus also libintl. But 
> in CMake I cannot see that libintl is actually used. Is this correct and 
> we can get rid of it?
> 
> thanks and regards
> Uwe

Yes, I think we do not use libintl any more.

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: Should we release 2.2.0 with Qt 5.5.1?

[Pavel Sanda]

Uwe Stöhr wrote:
> I don't want to sound rude, I just desperately need another developer on 
> Windows. I am close to quit LyX because I don't know compiler things and I 
> don't have enough spare time to learn this. When I go who can then provide 
> a native Windows build of LyX?

Uwe, there is no point why you should burn out because of this. If Windows
users have very little spirit to contribute back, you simply announce the stop
for a few months or work just on manuals, which is your biggest strength
anyway and let new volunteers appear. If they won't, then Win platform perhaps
does not deserve LyX, but I am pretty sure they will appear.

It's just matter of rising frustration level of people on your platform, 
they have zero motivation if you try to do everything on your own.

Pavel