Re: dash documentation patch

2017-09-01 Thread Enrico Forestieri
On Thu, Aug 31, 2017 at 08:53:41PM +, Guenter Milde wrote:
> On 2017-08-31, Enrico Forestieri wrote:
> > On Wed, Aug 30, 2017 at 11:06:25PM +0200, Guenter Milde wrote:
> 
> >> +* Since version 2.2, -- and --- in the LyX source are output as -{}- and
> >> +  -{}-{}- to prevent conversion to en- and em-dashes by TeX.
> >> +  Occurences in pre-2.2 documents are converted to literal Unicode dashes.
> >> +  In some cases this leads to different line breaks, as:
> >> +  + there is an optional line break after hyphens (also -- and ---) but 
> >> not
> >> +after literal dashes, and
> >> +  + hyphenation is suppressed in words following hyphens but allowed after
> >> +literal dashes.
> 
> > I think the above does not belong to the release notes for 2.3. It
> > would have been appropriate for the 2.2 release notes. IMO, this has to
> > go in the docs.
> 
> Description of past behaviour is IMO not out of place in a section called
> "!!Caveats when upgrading from earlier versions to 2.3.x".

It is out of place because this is not illustrating something introduced
in the current release but in past releases.

> >> +  It is no longer possible to differentiate dashes with/without optional
> >> +  line break using --- and -- vs. literal dashes. Either convert one sort 
> >> to
> >> +  ERT or insert optional line break characters.
> 
> > This is true since 2.2, so this does not belong to the release notes for
> > 2.3 and is better explained in the docs.
> 
> This also one of the caveats then upgrading from earlier versions (which are
> not limited to upgrading from 2.2).

See above. Release notes should be used to illustrate current changes, not
changes occurred in past releases.

-- 
Enrico


Re: #10723: Spaces ending LabelStrings in layout files are eaten by LyX

2017-09-01 Thread Kornel Benko
Am Freitag, 1. September 2017 um 18:21:06, schrieb Jean-Pierre Chrétien 

> Le 01/09/2017 à 17:38, Jean-Pierre Chrétien a écrit :
> 
> > 
> > 
> > [...]
> 
> > cd ../../newmaster/po && /usr/bin/msgmerge --update  --lang=it it.po 
> > lyx-2.3.0dev.pot
> > ...
> >  
> > terminé.
> > it.po:33529: AVERTISSEMENT : un message à traduire ne doit pas contenir de 
> > séquence d'échappement « \f »
> > it.po:33529: AVERTISSEMENT : un message à traduire ne doit pas contenir de 
> > séquence d'échappement « \f »
> > cd ../../newmaster/po && rm -f it.gmo && /usr/bin/msgfmt -c --statistics 
> > --verbose -o it.gmo it.po
> > it.po : 7212 messages traduits.
> > [...]
> > 
> > 
> > Could that come from the fact that, being in 2.3.x with an existing 
> > compilation 
> > in dir buildmaster, I ran in newmaster (my current git clone)
> > 
> > $ git checkout master
> > $ cd ../buildmaster
> > $ make
> > 
> > without erasing the contents of buildmaster or rerunning
> > ../newmaster/configure --with-version-suffix --enable-qt5
> > before make?
> > 
> > I will recompile from scratch to be sure.
> > 
> 
> Done, I still get these messages (I have only kept those from it.po above, 
> but 
> they appear also from fi.po).
> 
> BTW, the translation is e.g.:
>   it.po:33529: WARNING : a message to be translated cannot contain escape 
> sequence  "\f"
> 
> I guess "\f" is an invisble character like "\r" or "\n"?
> 
> Could this come from Jean-Marc's patch?
> 

More like having (literally) \f in the po-file, correct would have been to have 
\\f like for instance
at line 33522
#~ "* linenos,fontsize=\footnotesize,lang=fortran\n"
should be
#~ "* linenos,fontsize=\\footnotesize,lang=fortran\n"

Kornel

signature.asc
Description: This is a digitally signed message part.


Re: #10723: Spaces ending LabelStrings in layout files are eaten by LyX

2017-09-01 Thread Jean-Pierre Chrétien

Le 01/09/2017 à 17:38, Jean-Pierre Chrétien a écrit :




[...]


cd ../../newmaster/po && /usr/bin/msgmerge --update  --lang=it it.po 
lyx-2.3.0dev.pot
... 
terminé.
it.po:33529: AVERTISSEMENT : un message à traduire ne doit pas contenir de 
séquence d'échappement « \f »
it.po:33529: AVERTISSEMENT : un message à traduire ne doit pas contenir de 
séquence d'échappement « \f »
cd ../../newmaster/po && rm -f it.gmo && /usr/bin/msgfmt -c --statistics 
--verbose -o it.gmo it.po

it.po : 7212 messages traduits.
[...]


Could that come from the fact that, being in 2.3.x with an existing compilation 
in dir buildmaster, I ran in newmaster (my current git clone)


$ git checkout master
$ cd ../buildmaster
$ make

without erasing the contents of buildmaster or rerunning
../newmaster/configure --with-version-suffix --enable-qt5
before make?

I will recompile from scratch to be sure.



Done, I still get these messages (I have only kept those from it.po above, but 
they appear also from fi.po).


BTW, the translation is e.g.:
 it.po:33529: WARNING : a message to be translated cannot contain escape 
sequence  "\f"


I guess "\f" is an invisble character like "\r" or "\n"?

Could this come from Jean-Marc's patch?

--
Jean-Pierre






Re: #10723: Spaces ending LabelStrings in layout files are eaten by LyX

2017-09-01 Thread Jean-Pierre Chrétien

Le 01/09/2017 à 17:11, LyX Ticket Tracker a écrit :

#10723: Spaces ending LabelStrings in layout files are eaten by LyX
+---
  Reporter:  JPChretien  |   Owner:  rgheck
  Type:  defect  |  Status:  new
  Priority:  normal  |   Milestone:  2.3.0
Component:  layout  | Version:  2.3.0dev
  Severity:  minor   |  Resolution:
  Keywords:  |
+---

Comment (by rgheck):

  I would think you could commit to master now, and to 2.3.x when JMarc
  commits his patch there.



Ok, but would someone cherry-pick it for me?
I will be away from my desktop from Sept 3rd to Sept 23rd.

I have still a small concern. When compiling master, I saw these:


[...]
cd ../../newmaster/po && /usr/bin/msgmerge --update  --lang=fi fi.po 
lyx-2.3.0dev.pot
... 
terminé.
fi.po:10897: AVERTISSEMENT : un message à traduire ne doit pas contenir de 
séquence d'échappement « \a »
fi.po:16591: AVERTISSEMENT : un message à traduire ne doit pas contenir de 
séquence d'échappement « \a »
fi.po:16599: AVERTISSEMENT : un message à traduire ne doit pas contenir de 
séquence d'échappement « \a »
fi.po:16603: AVERTISSEMENT : un message à traduire ne doit pas contenir de 
séquence d'échappement « \a »
cd ../../newmaster/po && rm -f fi.gmo && /usr/bin/msgfmt -c --statistics 
--verbose -o fi.gmo fi.po
fi.po : 5035 messages traduits, 790 traductions approximatives, 1387 messages 
non traduits.

[...]
cd ../../newmaster/po && /usr/bin/msgmerge --update  --lang=it it.po 
lyx-2.3.0dev.pot
... 
terminé.
it.po:33529: AVERTISSEMENT : un message à traduire ne doit pas contenir de 
séquence d'échappement « \f »
it.po:33529: AVERTISSEMENT : un message à traduire ne doit pas contenir de 
séquence d'échappement « \f »
cd ../../newmaster/po && rm -f it.gmo && /usr/bin/msgfmt -c --statistics 
--verbose -o it.gmo it.po

it.po : 7212 messages traduits.
[...]


Could that come from the fact that, being in 2.3.x with an existing compilation 
in dir buildmaster, I ran in newmaster (my current git clone)


$ git checkout master
$ cd ../buildmaster
$ make

without erasing the contents of buildmaster or rerunning
../newmaster/configure --with-version-suffix --enable-qt5
before make?

I will recompile from scratch to be sure.

--
Jean-Pierre