Re: [LyX/master] Allow compiling with Qt6

2021-03-15 Thread Scott Kostyshak
On Mon, Mar 15, 2021 at 05:33:49PM +0100, Enrico Forestieri wrote:
> commit 635a7d77ddc94c63d52494dc4d68a930faccf45f
> Author: Enrico Forestieri 
> Date:   Mon Mar 15 17:09:09 2021 +0100
> 
> Allow compiling with Qt6
> 
> This commit allows compiling LyX with Qt6 when using autotools.
> For a successful compilation the following 2 conditions must be met.
> 
> 1) The Qt6 qmake has to come first in PATH, so that the command
>"qmake -v | grep -o 'Qt version .'" returns "Qt version 6".
> 2) The --enable-qt6 switch has to be passed to the configure command.
> 
> If --enable-qt6 is used but Qt6 is not found, Qt5 is tried as a fallback.
> If also Qt5 is not found, configuring for Qt4 is attempted.
> If --enable-qt6 is not used, then things go as usual. This means that Qt5
> is tried first and then Qt4, unless --disable-qt5 is used, in which case
> Qt4 is directly attempted. This means that existing scripts should
> continue working unmodified.
> 
> LyX should compile with Qt6 on windows and linux, and possibly also on
> mac, but I could not test that. However, it is not guaranteed that it
> works as it should. In particular I am not sure that I got right the
> conversion from QRegExp to QRegularExpression. For sure, the syntax
> highlighting seems to not work right. Someone in the know should take
> a look at that. I am able to load documents and compile them but some
> thourough testing is needed. However, when compiling for Qt5 or Qt4,
> I tried to make sure that the functionality is preserved.
> ---

Are there still QRegExp that need to be changed? I got an error from
src/support/qstring_helpers.cpp.

Also, why use

  #include 

in CategorizedCombo.cpp, but not other places?

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: lyx master crashed when converting text to note

2021-03-15 Thread V K


Message: 1
Date: Mon, 15 Mar 2021 14:05:13 +0100
From: Kornel Benko 
To: lyx-devel@lists.lyx.org
Subject: Re: lyx master crashed when converting text to note
Message-ID: <20210315140513.08a8be1b@admin1-desktop>
Content-Type: text/plain; charset="utf-8"

Am Mon, 15 Mar 2021 12:14:05 +0100
schrieb Jean-Marc Lasgouttes :

> Le 15/03/2021 ? 11:56, Pavel Sanda a ?crit?:
> > On Sun, Mar 14, 2021 at 09:41:48PM +0100, Jean-Marc Lasgouttes wrote:  
> >> Le 14/03/2021 ?? 21:14, Pavel Sanda a ?crit?:  
>  Thanks for tracking this. I'll have look next week.  
> >>> Should I create ticket in trac?  
> >>
> >> Yes please. I have tried to reproduced using you recipe, but it seems that 
> >> I
> >> do not understand it. I cannot yet get the crash.  
> > 
> > I see, created ticket #12204.
> > Note, that one unwritten part of recipy seems to be that the lyx window 
> > needs
> > to be small enough, that once you select from  to the end of document 
> > (via
> > ctrl+shift+end) the the intial part === is not visible anymore in the 
> > window.  
> 
> Thanks. Indeed, I may have been missing the missing part :)
> 
> JMarc
> 

I was not able to reproduce. Even with the new recipe.

    Kornel



I reported this bug. I can't reproduce it when selecting from === to the end 
either, but selecting text (without author and title lines) from beginning to 
=== (including it) crashes Lyx. There is no crash when selecting from === to 
beginning of the text.
I compiled master yesterday.

Valdemaras
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Lyx master crashes opening outline pane

2021-03-15 Thread V K








On Monday, March 15, 2021, 12:59:32 PM GMT+2, Pavel Sanda  
wrote: 





On Fri, Mar 12, 2021 at 05:07:10PM +, V K wrote:

> Hello.
> 
> Lyx master crashes when opening outline pane (with Alt+ shortcuts or menus). 
> Error message:


Can not reproduce.
Do you need specific document opened to make this crash happen?




I updated master and it opens fine now, so bug disappeared.

Thank you.

Valdemaras
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Command line argument "-dbg all" does not seem to work

2021-03-15 Thread Pavel Sanda
On Mon, Mar 15, 2021 at 05:37:37PM +, José Abílio Matos wrote:
> On Monday, March 15, 2021 2:39:47 PM WET Pavel Sanda wrote:
> > I had the same thought, this issue happens for me regularly.
> > 
> > Pavel
> 
> It happens to me as well. :-)

So who is gonna write the patch? :) P
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: lyx master crashed when converting text to note

2021-03-15 Thread Pavel Sanda
On Mon, Mar 15, 2021 at 05:29:27PM +, V K wrote:
> I reported this bug. I can't reproduce it when selecting from === to the end 
> either

For the record, I can still reproduce the  -> end version of the crash...
I think the window geometry (or rather particular line breaking and visible
range) is what matters here.

P
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Command line argument "-dbg all" does not seem to work

2021-03-15 Thread José Abílio Matos
On Monday, March 15, 2021 2:39:47 PM WET Pavel Sanda wrote:
> I had the same thought, this issue happens for me regularly.
> 
> Pavel

It happens to me as well. :-)
-- 
José Abílio


-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Allow compiling with Qt6

2021-03-15 Thread Richard Kimberly Heck

On 3/15/21 1:13 PM, Pavel Sanda wrote:

On Mon, Mar 15, 2021 at 05:57:38PM +0100, Kornel Benko wrote:

Am Mon, 15 Mar 2021 17:33:49 +0100 (CET)
schrieb Enrico Forestieri :


commit 635a7d77ddc94c63d52494dc4d68a930faccf45f
Author: Enrico Forestieri 
Date:   Mon Mar 15 17:09:09 2021 +0100

 Allow compiling with Qt6

I had the impression we wanted to postpone compilation with Qt6 to after 2.4?

If the transition is that simple as this patch I think we should accept it now.
I am pretty sure ppl will try to adapt 2.4 to qt6 later on, so this is more 
safer anyway.


Yes, most of it is pretty straightforward syntax changes.

Riki


--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Allow compiling with Qt6

2021-03-15 Thread Pavel Sanda
On Mon, Mar 15, 2021 at 05:57:38PM +0100, Kornel Benko wrote:
> Am Mon, 15 Mar 2021 17:33:49 +0100 (CET)
> schrieb Enrico Forestieri :
> 
> > commit 635a7d77ddc94c63d52494dc4d68a930faccf45f
> > Author: Enrico Forestieri 
> > Date:   Mon Mar 15 17:09:09 2021 +0100
> > 
> > Allow compiling with Qt6
> 
> I had the impression we wanted to postpone compilation with Qt6 to after 2.4?

If the transition is that simple as this patch I think we should accept it now.
I am pretty sure ppl will try to adapt 2.4 to qt6 later on, so this is more 
safer anyway.

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Allow compiling with Qt6

2021-03-15 Thread Kornel Benko
Am Mon, 15 Mar 2021 17:33:49 +0100 (CET)
schrieb Enrico Forestieri :

> commit 635a7d77ddc94c63d52494dc4d68a930faccf45f
> Author: Enrico Forestieri 
> Date:   Mon Mar 15 17:09:09 2021 +0100
> 
> Allow compiling with Qt6

I had the impression we wanted to postpone compilation with Qt6 to after 2.4?

Kornel


pgpiQe0BfrUu_.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Command line argument "-dbg all" does not seem to work

2021-03-15 Thread Pavel Sanda
On Mon, Mar 15, 2021 at 10:24:04AM -0400, Scott Kostyshak wrote:
> On Sun, Mar 14, 2021 at 08:11:58AM +0100, Yu Jin wrote:
> > Am Mo., 8. März 2021 um 19:39 Uhr schrieb Yu Jin :
> > 
> > > Ignatz mentioned in ticket 11998 that "-dbg all" only returns 1 info line
> > > and not more (no debug info actually, only the 1 info line that dbg level
> > > is set to all). I have tested it independently from the patch I provided 
> > > in
> > > that ticket and could reproduce. Any ideas?
> > >
> > 
> > Solved, was meant to be "-dbg any", not "-dbg all".
> 
> It might be nice to make "all" a synonym of "any".

I had the same thought, this issue happens for me regularly.

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Yet another deprecation fix (this is the last one I am aware of)

2021-03-15 Thread Scott Kostyshak
On Sun, Mar 14, 2021 at 08:51:41AM +0100, Jürgen Spitzmüller wrote:
> Am Samstag, dem 13.03.2021 um 16:16 -0500 schrieb Scott Kostyshak:
> > Thanks for the work on backporting. I'll bump the email where I
> > proposed backporting the relevant Qt commits. I'm not sure what
> > remains. I can take a look at 27ba830b8ef51 and anything else at some
> > point next week.
> 
> I think the one mentioned above was all that's left. I took the liberty
> to backport the others.

Sounds good, thanks. I'll look at 27ba830b8ef51 this week.

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Command line argument "-dbg all" does not seem to work

2021-03-15 Thread Scott Kostyshak
On Sun, Mar 14, 2021 at 08:11:58AM +0100, Yu Jin wrote:
> Am Mo., 8. März 2021 um 19:39 Uhr schrieb Yu Jin :
> 
> > Ignatz mentioned in ticket 11998 that "-dbg all" only returns 1 info line
> > and not more (no debug info actually, only the 1 info line that dbg level
> > is set to all). I have tested it independently from the patch I provided in
> > that ticket and could reproduce. Any ideas?
> >
> 
> Solved, was meant to be "-dbg any", not "-dbg all".

It might be nice to make "all" a synonym of "any".

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: lyx master crashed when converting text to note

2021-03-15 Thread Kornel Benko
Am Mon, 15 Mar 2021 12:14:05 +0100
schrieb Jean-Marc Lasgouttes :

> Le 15/03/2021 à 11:56, Pavel Sanda a écrit :
> > On Sun, Mar 14, 2021 at 09:41:48PM +0100, Jean-Marc Lasgouttes wrote:  
> >> Le 14/03/2021 ?? 21:14, Pavel Sanda a écrit :  
>  Thanks for tracking this. I'll have look next week.  
> >>> Should I create ticket in trac?  
> >>
> >> Yes please. I have tried to reproduced using you recipe, but it seems that 
> >> I
> >> do not understand it. I cannot yet get the crash.  
> > 
> > I see, created ticket #12204.
> > Note, that one unwritten part of recipy seems to be that the lyx window 
> > needs
> > to be small enough, that once you select from  to the end of document 
> > (via
> > ctrl+shift+end) the the intial part === is not visible anymore in the 
> > window.  
> 
> Thanks. Indeed, I may have been missing the missing part :)
> 
> JMarc
> 

I was not able to reproduce. Even with the new recipe.

Kornel


pgpYg6P7I4gra.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: lyx master crashed when converting text to note

2021-03-15 Thread Jean-Marc Lasgouttes

Le 15/03/2021 à 11:56, Pavel Sanda a écrit :

On Sun, Mar 14, 2021 at 09:41:48PM +0100, Jean-Marc Lasgouttes wrote:

Le 14/03/2021 ?? 21:14, Pavel Sanda a écrit :

Thanks for tracking this. I'll have look next week.

Should I create ticket in trac?


Yes please. I have tried to reproduced using you recipe, but it seems that I
do not understand it. I cannot yet get the crash.


I see, created ticket #12204.
Note, that one unwritten part of recipy seems to be that the lyx window needs
to be small enough, that once you select from  to the end of document (via 
ctrl+shift+end)
the the intial part === is not visible anymore in the window.


Thanks. Indeed, I may have been missing the missing part :)

JMarc

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: lyx master crashed when converting text to note

2021-03-15 Thread Pavel Sanda
On Sun, Mar 14, 2021 at 09:41:48PM +0100, Jean-Marc Lasgouttes wrote:
> Le 14/03/2021 ?? 21:14, Pavel Sanda a écrit :
> >>Thanks for tracking this. I'll have look next week.
> >Should I create ticket in trac?
> 
> Yes please. I have tried to reproduced using you recipe, but it seems that I
> do not understand it. I cannot yet get the crash.

I see, created ticket #12204.
Note, that one unwritten part of recipy seems to be that the lyx window needs
to be small enough, that once you select from  to the end of document (via 
ctrl+shift+end)
the the intial part === is not visible anymore in the window.

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel