Re: [LyX/master] Fix compilation problem
On 1/4/23 22:09, Richard Kimberly Heck wrote:
commit 04025d0259cb556daf54bb74a01b9f9a615dcb77
Author: Richard Kimberly Heck
Date: Wed Jan 4 23:04:02 2023 -0500
Fix compilation problem
---
src/mathed/InsetMathDecoration.cpp |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/mathed/InsetMathDecoration.cpp
b/src/mathed/InsetMathDecoration.cpp
index 616d1f3..e0a5d85 100644
--- a/src/mathed/InsetMathDecoration.cpp
+++ b/src/mathed/InsetMathDecoration.cpp
@@ -188,7 +188,7 @@ void InsetMathDecoration::infoize(odocstream & os) const
namespace {
struct Attributes {
Attributes() : over(false) {}
- Attributes(bool o, string_view entity)
+ Attributes(bool o, string const & entity)
The point of string_view is to avoid a copy here. Even with the use of
const &, a copy has to be made of the original constant string, a const
char *. Would it be OK to use instead:
+ Attributes(bool o, const char * entity)
?? I think so, but I avoid C-style strings whenever I can, out of paranoia.
Riki
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Compilation failure with c++11 (string_view)
On 1/4/23 21:39, Scott Kostyshak wrote: On Tue, Jan 03, 2023 at 10:30:27AM +0100, Jean-Marc Lasgouttes wrote: With master, I cannot compile in c++11 mode: ../../master/src/mathed/InsetMathDecoration.cpp:191:22: error: ‘string_view’ has not been declared 191 | Attributes(bool o, string_view entity) | ^~~ Indeed, std::string_view is a c++17 thing. CC'ing Thibaut (I think this was introduced at bc73a857). I've fixed it. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Revert doc update for Additional.lyx so maitenance work can continue.
On Wed, Jan 04, 2023 at 10:06:13PM +0100, Pavel Sanda wrote: > On Fri, Dec 30, 2022 at 09:27:32AM +0100, Jürgen Spitzmüller wrote: > > Am Donnerstag, dem 29.12.2022 um 15:25 -0500 schrieb Scott Kostyshak: > > > Sounds good. I can do that. Should I do that now or wait (i.e., would > > > this change disrupt the ongoing work)? > > > > It's probably better to wait until John is done. > > Scott, this is the right time for your fix... Thanks, fixes in at 3c8a5d4d^..cb27aaa8. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Compilation failure with c++11 (string_view)
On Tue, Jan 03, 2023 at 10:30:27AM +0100, Jean-Marc Lasgouttes wrote: > With master, I cannot compile in c++11 mode: > > ../../master/src/mathed/InsetMathDecoration.cpp:191:22: error: ‘string_view’ > has not been declared > 191 | Attributes(bool o, string_view entity) > | ^~~ > > Indeed, std::string_view is a c++17 thing. CC'ing Thibaut (I think this was introduced at bc73a857). Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: macOS python issue
On 1/4/23 06:53, Stephan Witt wrote: Am 03.01.2023 um 10:36 schrieb Stephan Witt : Am 03.01.2023 um 10:29 schrieb Pavel Sanda : On Tue, Jan 03, 2023 at 10:20:22AM +0100, Stephan Witt wrote: Now I???ve reduced the image sizes to reduce the screen clutter. Do you think it is ok? Looks fine to me. What might be good to put at the begining some (textual) examples how missing python displays itself (can't convert older lyx files, can't reconfigure, can't load images, etc...) so users can associate these problems with python missing. Ok, I’ll make it. The real solutions though is IMHO to detect python presence and issues warning for installation… Yes, that I’ll try to do - I have some ideas now. Hi all, finally - although late in the game - I came up with a proposal to solve the problem with missing python on macOS. It’s described here: https://www.lyx.org/trac/ticket/12523 and in more depth here: https://wiki.lyx.org/Mac/Mac Please see the attached patch. You may wonder why there is no mac specific code. I think it’s not needed as the problem isn’t specific to the OS or platform. It is very unlikely to happen on Linux systems as most of them has package managers and if the dependencies are correct there is no problem like that. Yes, that seems right. This could happen on other platforms. Probably the message text of the new Alert box should be reworded. It seems fine, though I wonder if we could possibly point people towards a solution? If the solution looks right I’d like to see it in 2.3.8 too. Definitely. I'd even be willing to re-release 2.3.7, for Mac at least, with this patch. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
LyX 2.3.7
Binaries and tarballs have been uploaded to FTP. I'll do the actual release after giving the mirrors a day to sync. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Revert doc update for Additional.lyx so maitenance work can continue.
On Fri, Dec 30, 2022 at 09:27:32AM +0100, Jürgen Spitzmüller wrote: > Am Donnerstag, dem 29.12.2022 um 15:25 -0500 schrieb Scott Kostyshak: > > Sounds good. I can do that. Should I do that now or wait (i.e., would > > this change disrupt the ongoing work)? > > It's probably better to wait until John is done. Scott, this is the right time for your fix... Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Patch to delete the iopart, kluwer and svjog layouts and edit Makefile.am as the relevant cls files have not been available for several years
On Wed, Jan 04, 2023 at 12:12:39PM +, John Robert Hudson wrote: > From 673a7b1786ecaea775d10ad9751a8630ab844b10 Mon Sep 17 00:00:00 2001 > From: John R Hudson > Date: Wed, 4 Jan 2023 12:08:23 + > Subject: [PATCH] Delete iopart, kluwer and svjog layouts as the relevant cls > files have not been available for several years and edit Makefile.am to > reflect this change Thanks John. I am not going to apply this patch, because removing the layout might break the old documents. In the long term we might want some attic or flag so we don't offer these layouts for a new documents. But this needs more work to be done. For now I will at least put this list into layouts directory so we do not lose your valueable exploration of deprecated .cls packages. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: 2.3.7 Tarballs Available
On Wed, Jan 04, 2023 at 01:34:11PM -0500, Richard Kimberly Heck wrote: > >I???ve built the binaries for Mac and put them here: > > > >https://my.hidrive.com/share/qr1.dh8gbw > > > >* build on BigSur for Intel and Apple chips (minimum macOS 10.14 with Qt > >5.15.7). > >+ LyX-2.3.7+qt5-x86_64-arm64-cocoa.dmg > >+ LyX-2.3.7+qt5-x86_64-arm64-cocoa.dmg.sig > > > >* build on Mojave for Intel chips (minimum macOS 10.12 with Qt 5.12.9). > >+ LyX-2.3.7+qt5-x86_64-cocoa.dmg > >+ LyX-2.3.7+qt5-x86_64-cocoa.dmg.sig > > Got them, thanks. > > Apparently, your key has expired. If you update from the right keyserver I see new expiration set to 2024: gpg --refresh-keys --keyserver hkps://keyserver.ubuntu.com Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: 2.3.7 Tarballs Available
On 1/3/23 03:05, Stephan Witt wrote: Am 02.01.2023 um 00:53 schrieb Richard Kimberly Heck : Here: http://ftp.lyx.org/pub/lyx/devel/lyx-2.3/ Note that I've named these files as 2.3.7-1, but did not do that in configure.ac, since we did not release anything yet. Please build binaries. I’ve built the binaries for Mac and put them here: https://my.hidrive.com/share/qr1.dh8gbw * build on BigSur for Intel and Apple chips (minimum macOS 10.14 with Qt 5.15.7). + LyX-2.3.7+qt5-x86_64-arm64-cocoa.dmg + LyX-2.3.7+qt5-x86_64-arm64-cocoa.dmg.sig * build on Mojave for Intel chips (minimum macOS 10.12 with Qt 5.12.9). + LyX-2.3.7+qt5-x86_64-cocoa.dmg + LyX-2.3.7+qt5-x86_64-cocoa.dmg.sig Got them, thanks. Apparently, your key has expired. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Patch to delete the iopart, kluwer and svjog layouts and edit Makefile.am as the relevant cls files have not been available for several years
From 673a7b1786ecaea775d10ad9751a8630ab844b10 Mon Sep 17 00:00:00 2001
From: John R Hudson
Date: Wed, 4 Jan 2023 12:08:23 +
Subject: [PATCH] Delete iopart, kluwer and svjog layouts as the relevant cls
files have not been available for several years and edit Makefile.am to
reflect this change
---
lib/Makefile.am | 3 -
lib/layouts/iopart.layout | 366 -
lib/layouts/kluwer.layout | 419 --
lib/layouts/svjog.layout | 175
4 files changed, 963 deletions(-)
delete mode 100644 lib/layouts/iopart.layout
delete mode 100644 lib/layouts/kluwer.layout
delete mode 100644 lib/layouts/svjog.layout
diff --git a/lib/Makefile.am b/lib/Makefile.am
index c8e1de..bca72c79e5 100644
--- a/lib/Makefile.am
+++ b/lib/Makefile.am
@@ -2542,7 +2542,6 @@ dist_layouts_DATA =\
layouts/ijmpc.layout \
layouts/ijmpd.layout \
layouts/initials.module \
- layouts/iopart.layout \
layouts/isprs.layout \
layouts/iucr.layout \
layouts/jarticle.layout \
@@ -2553,7 +2552,6 @@ dist_layouts_DATA =\
layouts/jsarticle.layout \
layouts/jsbook.layout \
layouts/jss.layout \
- layouts/kluwer.layout \
layouts/knitr.module \
layouts/landscape.module \
layouts/latex8.layout \
@@ -2634,7 +2632,6 @@ dist_layouts_DATA =\
layouts/svcommon.inc \
layouts/svglobal.layout \
layouts/svglobal3.layout \
- layouts/svjog.layout \
layouts/svmono.layout \
layouts/svmult.layout \
layouts/svprobth.layout \
diff --git a/lib/layouts/iopart.layout b/lib/layouts/iopart.layout
deleted file mode 100644
index bfcd86eac5..00
--- a/lib/layouts/iopart.layout
+++ /dev/null
@@ -1,366 +0,0 @@
-#% Do not delete the line below; configure depends on this
-# \DeclareLaTeXClass[iopart,amsmath.sty,amssymb.sty,iopams.sty,setstack.sty]{Institute of Physics (IOP)}
-# \DeclareCategory{Articles}
-# IOP article textclass definition file.
-# Author: Uwe Stöhr (uwesto...@web.de)
-
-Format 99
-
-Columns 1
-Sides 1
-SecNumDepth 3
-TocDepth 3
-DefaultStyle Standard
-
-ClassOptions
- FontSize 10|12
-end
-
-Preamble
- \usepackage{iopams}
- \usepackage{setstack}
-EndPreamble
-
-# This is just to show how to declare the default font.
-# The defaults are exactly those shown here.
-DefaultFont
- Family Roman
- Series Medium
- Shape Up
- Size Normal
- Color None
-EndFont
-
-
-Style Standard
- Category MainText
- Margin Static
- LatexType Paragraph
- LatexName dummy
- ParIndent MM
- ParSkip 0.4
- Align Block
- AlignPossible Block, Left, Right, Center
- LabelType No_Label
- DocBookTag para
-End
-
-
-Input stdcounters.inc
-Input stdfloats.inc
-Input stdlists.inc
-Input stdsections.inc
-Input stdstarsections.inc
-Input stdlayouts.inc
-
-NoStyle Chapter
-NoCounter chapter
-NoStyle Chapter*
-
-Style Title
- Margin Static
- LatexType Command
- LatexName title
- Category FrontMatter
- InTitle 1
- Argument 1
- LabelString "Short Title|S"
- Tooltip "Short title that will appear in header line"
- InsertCotext 1
- EndArgument
- ParSkip 0.4
- ItemSep 0
- TopSep 0
- BottomSep 1
- ParSep 1
- Align Center
- LabelType No_Label
- Font
- Size Largest
- EndFont
- HTMLTitle true
- DocBookTag title
- DocBookTagType paragraph
- DocBookInInfo maybe
-End
-
-
-Style Review
- CopyStyle Title
- LatexName review
-End
-
-
-Style Topical
- CopyStyle Title
- LatexName topical
-End
-
-
-Style Comment
- CopyStyle Title
- LatexName comment
-End
-
-
-Style Note
- CopyStyle Title
- LatexName note
-End
-
-
-Style Paper
- CopyStyle Title
- LatexName paper
-End
-
-
-Style Prelim
- CopyStyle Title
- LatexName prelim
-End
-
-
-Style Rapid
- CopyStyle Title
- LatexName rapid
-End
-
-
-Style Letter
- CopyStyle Title
- ResetArgs 1
- LatexName letter
-End
-
-
-Style Author
- Margin Static
- LatexType Command
- LatexName author
- Category FrontMatter
- InTitle 1
- LabelSep xxx
- ParSkip 0.4
- TopSep 1.3
- BottomSep 0.7
- ParSep 0.7
- Align Center
- LabelType No_Label
- Font
- Size Large
- EndFont
- DocBookTagpersonname
- DocBookTagTypeparagraph
- DocBookWrapperTag author
- DocBookWrapperTagType inline
- DocBookInInfo always
-End
-
-
-Style Address
- Margin Static
- LatexType Command
- LatexName address
- Category FrontMatter
- InTitle 1
- ParSkip 0.4
- Align Center
- LabelType No_Label
- Font
- Shape Italic
- EndFont
- DocBookTagaddress
- DocBookTagTypeparagraph
- DocBookWrapperTag author
- DocBookWrapperTagType inline
- DocBookWrapperMergeWithPrevioustrue
- DocBookInInfo always
-End
-
-
-Style Email
- CopyStyle Address
- LatexName ead
- BottomSep 0.5
- Font
- Shape Up
- EndFont
- DocBookTagemail
- DocBookTagTypeparagraph
- DocBookWrapperTag author
- DocBookWrapperTagType inline
- DocBookWrapperMergeWithPrevioustrue
- DocBookInInfo always
-End
-
-
-Style Abstract
- Margin Static
- LatexType Environment
- LatexName abstract
- Category
Re: macOS python issue
Am 03.01.2023 um 10:36 schrieb Stephan Witt : > Am 03.01.2023 um 10:29 schrieb Pavel Sanda : >> >> On Tue, Jan 03, 2023 at 10:20:22AM +0100, Stephan Witt wrote: >>> Now I???ve reduced the image sizes to reduce the screen clutter. >>> >>> Do you think it is ok? >> >> Looks fine to me. >> >> What might be good to put at the begining some (textual) examples how >> missing python >> displays itself (can't convert older lyx files, can't reconfigure, can't >> load images, etc...) >> so users can associate these problems with python missing. > > Ok, I’ll make it. > >> The real solutions though is IMHO to detect python presence and issues >> warning for installation… > > Yes, that I’ll try to do - I have some ideas now. Hi all, finally - although late in the game - I came up with a proposal to solve the problem with missing python on macOS. It’s described here: https://www.lyx.org/trac/ticket/12523 and in more depth here: https://wiki.lyx.org/Mac/Mac Please see the attached patch. You may wonder why there is no mac specific code. I think it’s not needed as the problem isn’t specific to the OS or platform. It is very unlikely to happen on Linux systems as most of them has package managers and if the dependencies are correct there is no problem like that. Probably the message text of the new Alert box should be reworded. If the solution looks right I’d like to see it in 2.3.8 too. Stephan macos-python.patch Description: Binary data -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
