Re: [wip][patch] use qmake with autoconf for qt5 too
On Fri, Jun 14, 2024 at 08:09:00PM +0200, Jean-Marc Lasgouttes wrote: This seems to work, although for some reason it does not add x11extras here. Actually, x11extras is detected but you forgot about HAVE_QT5_X11_EXTRAS. Applying the attached patch on top of yours does the trick. -- Enrico Index: ./config/qt.m4 === --- ./config/qt.m4.old 2024-06-15 22:02:20.167253884 +0200 +++ ./config/qt.m4 2024-06-15 22:39:52.334177611 +0200 @@ -459,6 +459,11 @@ if test -n "$QT_MISSING"; then AC_MSG_ERROR([Qt$qt_major module(s) $QT_MISSING not found.]) fi + QT5_X11_EXTRAS=`cd $lyx_test_qt_dir; make -s -f $lyx_test_qt_mak DEFINES | grep QT_X11EXTRAS_LIB` + if test -n "$QT5_X11_EXTRAS"; then + AC_DEFINE(HAVE_QT5_X11_EXTRAS, 1, + [Define if you have the Qt5X11Extras module]) + fi AC_MSG_RESULT($QTLIB_VERSION) AC_SUBST(QT_INCLUDES) AC_SUBST(QT_LDFLAGS) -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/2.4.1-devel] Fix bug #13028.
On 6/14/24 16:53, Pavel Sanda wrote: 2) I think we are only half-way done with deafult of pasting. Ctrl+V is not joining lines anymore (appreciated!) but middle-button pasting still joins them. Shouldn't this be consistent? If you have ideas about how to do it...please do. I'm not well informed about these different pasting options. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Prevent division by zero
On 6/15/24 08:52, Jürgen Spitzmüller wrote: Am Samstag, dem 15.06.2024 um 12:50 + schrieb Juergen Spitzmueller: commit 0fc8ee5ace22c11175cb93f5b6f7310cc4d646c1 Author: Juergen Spitzmueller Date: Sat Jun 15 14:48:37 2024 +0200 Prevent division by zero Fixes crash reported at https://marc.info/?l=lyx-users=171842978728676 Candidate for 2.4.1. Cherry picked, thanks. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [wip][patch] use qmake with autoconf for qt5 too
On Sat, Jun 15, 2024 at 01:23:52PM +0200, Enrico Forestieri wrote: On Fri, Jun 14, 2024 at 08:09:00PM +0200, Jean-Marc Lasgouttes wrote: Could you people have a go at it before I push it? I tried it with native Windows and Cygwin with GDI backend instead of X11. In both cases it detected the winextras module and added appropriate includes and libraries. However, while in the native case I could paste graphics in EMF format, I was not able to do it in the Cygwin case. After investigating, it turned out that the previous method was taking into account the DEFINES and PRL_EXPORT_DEFINES variables present in the platform's qmake.conf file, in the mkspecs directory, while the qmake method does not. After moving those definitions into CPPFLAGS and passing them to configure, the Cygwin build also worked fine. I wonder if this change might somehow compromise other configurations as well. You know, if it works... ;) Digging further it turns out that only PRL_EXPORT_DEFINES was taken into account for producing pkgconfig files. The definitions in DEFINES are only meant for building Qt and it is not appropriate exporting them. So, all in all, it seems that only who relies on PRL_EXPORT_DEFINES would be affected. Given that I am not sure I am not the only one (actually, I am pretty sure I am the only one, as grep in mkspecs returns nothing ;), the change does not seem to be harmful... -- Enrico -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Prevent division by zero
Am Samstag, dem 15.06.2024 um 12:50 + schrieb Juergen Spitzmueller: > commit 0fc8ee5ace22c11175cb93f5b6f7310cc4d646c1 > Author: Juergen Spitzmueller > Date: Sat Jun 15 14:48:37 2024 +0200 > > Prevent division by zero > > Fixes crash reported at > https://marc.info/?l=lyx-users=171842978728676 Candidate for 2.4.1. -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Show full inset context-menu when clicking on text part of collapsible (#10370)
Am Freitag, dem 14.06.2024 um 21:58 +0200 schrieb Pavel Sanda: > This patch add possibility to dissolve the caption inset of the > float. > > It's not particularly nice, because the menu entry is on the top > above all > editing options and would feel more natural next to "Split inset" > entry - > one could add it as an optitem there, but this will probably make it > redundant > in many other places. > Opinion? I would add the item to context-edit and remove it from the insets that derive from InsetText. -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [wip][patch] use qmake with autoconf for qt5 too
On Fri, Jun 14, 2024 at 08:09:00PM +0200, Jean-Marc Lasgouttes wrote: Could you people have a go at it before I push it? I tried it with native Windows and Cygwin with GDI backend instead of X11. In both cases it detected the winextras module and added appropriate includes and libraries. However, while in the native case I could paste graphics in EMF format, I was not able to do it in the Cygwin case. After investigating, it turned out that the previous method was taking into account the DEFINES and PRL_EXPORT_DEFINES variables present in the platform's qmake.conf file, in the mkspecs directory, while the qmake method does not. After moving those definitions into CPPFLAGS and passing them to configure, the Cygwin build also worked fine. I wonder if this change might somehow compromise other configurations as well. You know, if it works... ;) -- Enrico -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Existential doubt: Python line size
On Fri, 2024-06-14 at 18:26 -0400, Richard Kimberly Heck wrote: > Same. There are times when code gets so deeply indented that even 100 > becomes restrictive. > > Riki I agree, so I set that for python code, and tools that use pyproject.toml, to 96. -- José Abílio -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/2.4.1-devel] Update doc info for quote-insert
On Sat, Jun 15, 2024 at 10:06:55AM +0200, Kornel Benko wrote: > I had the impression that 2.4.1-devel branch is dead. Should this not go to > 2.4.x branch > instead? Oops, was on a wrong branch indeed. P -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/2.4.1-devel] Update doc info for quote-insert
Am Fri, 14 Jun 2024 20:18:42 + schrieb Pavel Sanda : > commit b8a22a3667b20aee663ff897e1d24761dc9e1f30 > Author: Richard Kimberly Heck > Date: Tue Apr 2 12:46:36 2024 -0400 > > Update doc info for quote-insert > --- > src/LyXAction.cpp | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > I had the impression that 2.4.1-devel branch is dead. Should this not go to 2.4.x branch instead? Kornel pgpcvujIMcTh6.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
