Re: [LyX/master] Fix the way the top and bottom selection are drawn
On 2022-01-27 15:52, Jean-Marc Lasgouttes wrote: Le 27/01/2022 à 14:59, Daniel a écrit : I guess in Scott's after.png the selection looks a bit confusing (as in unexpected because other applications don't highlight that way). Isn't there another way to select the "Chapter" label? Do you have examples of applications that show labels on top of layouts? What we do now is that there is a 'tight' selection (inside the paragraph) and when the selection is over several paragraphs, the space between the paragraphs is painter too. What would you expect exactly? The previous behavior was ugly. Now one sees clearly when the selection is over two paragraphs. I could also decide to _never_ fill the gaps between paragraphs, but it will not be nice IMO. Selection inside the paragraph was not very pleasant either. See also how the selection was over the document bottom margin. JMarc Indeed many applications seem to just *never* fill the gaps. I guess it indicates the selection where the cursor can be and hence where editing can happen. So that would be one option. But at least LibreOffice fills the gaps. They also have a border around selections. I don't know whether these two are somehow related. Sure, keep the "LibreOffice style" selections. I haven't used it much but apparently it survived the scrutiny of LibreOffice users and developers. So that is good. Daniel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Fix the way the top and bottom selection are drawn
On Thu, Jan 27, 2022 at 03:52:14PM +0100, Jean-Marc Lasgouttes wrote: > > Le 27/01/2022 à 14:59, Daniel a écrit : > > I guess in Scott's after.png the selection looks a bit confusing (as in > > unexpected because other applications don't highlight that way). Isn't > > there another way to select the "Chapter" label? > > Do you have examples of applications that show labels on top of layouts? > > What we do now is that there is a 'tight' selection (inside the paragraph) > and when the selection is over several paragraphs, the space between the > paragraphs is painter too. > > What would you expect exactly? The previous behavior was ugly. Now one sees > clearly when the selection is over two paragraphs. I could also decide to > _never_ fill the gaps between paragraphs, but it will not be nice IMO. > > Selection inside the paragraph was not very pleasant either. See also how > the selection was over the document bottom margin. I remember thinking your change was nice and I tested it at the time. I agree that the fix is really nice for the situation that you took a screenshot of. I did not expect the behavior I saw in the itemize, but if I understand correctly you're saying that the new behavior contains information. I think I could get used to it; it just looked weird to me when I first saw it. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Fix the way the top and bottom selection are drawn
Le 27/01/2022 à 14:59, Daniel a écrit : I guess in Scott's after.png the selection looks a bit confusing (as in unexpected because other applications don't highlight that way). Isn't there another way to select the "Chapter" label? Do you have examples of applications that show labels on top of layouts? What we do now is that there is a 'tight' selection (inside the paragraph) and when the selection is over several paragraphs, the space between the paragraphs is painter too. What would you expect exactly? The previous behavior was ugly. Now one sees clearly when the selection is over two paragraphs. I could also decide to _never_ fill the gaps between paragraphs, but it will not be nice IMO. Selection inside the paragraph was not very pleasant either. See also how the selection was over the document bottom margin. JMarc-- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Fix the way the top and bottom selection are drawn
On 27/01/2022 14:34, Jean-Marc Lasgouttes wrote: Le 27/01/2022 à 14:06, Scott Kostyshak a écrit : On Tue, Dec 07, 2021 at 05:50:09PM +0100, Jean-Marc Lasgouttes wrote: commit 2fd8b6fc2a402c00e78f71d7d6ad986270283a3e Author: Jean-Marc Lasgouttes Date: Tue Dec 7 18:15:01 2021 +0100 Fix the way the top and bottom selection are drawn When a selection extends on more than a row, the space between the two rows should always be painted in full. Otherwise, with layouts like Chapter, the "Chapter" label may seem selected in part. --- I think this changed behavior in the attached example. See the before/after screenshots as well. Yes, it did. It is done to avoid a situation as in attachment. Do you have issues with it? JMarc I guess in Scott's after.png the selection looks a bit confusing (as in unexpected because other applications don't highlight that way). Isn't there another way to select the "Chapter" label? Daniel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Fix the way the top and bottom selection are drawn
Le 27/01/2022 à 14:06, Scott Kostyshak a écrit : On Tue, Dec 07, 2021 at 05:50:09PM +0100, Jean-Marc Lasgouttes wrote: commit 2fd8b6fc2a402c00e78f71d7d6ad986270283a3e Author: Jean-Marc Lasgouttes Date: Tue Dec 7 18:15:01 2021 +0100 Fix the way the top and bottom selection are drawn When a selection extends on more than a row, the space between the two rows should always be painted in full. Otherwise, with layouts like Chapter, the "Chapter" label may seem selected in part. --- I think this changed behavior in the attached example. See the before/after screenshots as well. Yes, it did. It is done to avoid a situation as in attachment. Do you have issues with it? JMarc-- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Fix the way the top and bottom selection are drawn
On Tue, Dec 07, 2021 at 05:50:09PM +0100, Jean-Marc Lasgouttes wrote: > commit 2fd8b6fc2a402c00e78f71d7d6ad986270283a3e > Author: Jean-Marc Lasgouttes > Date: Tue Dec 7 18:15:01 2021 +0100 > > Fix the way the top and bottom selection are drawn > > When a selection extends on more than a row, the space between the two > rows should always be painted in full. Otherwise, with layouts like > Chapter, the "Chapter" label may seem selected in part. > --- I think this changed behavior in the attached example. See the before/after screenshots as well. Scott example.23.lyx Description: application/lyx signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
