Re: [enhancement] add *.xlsx to external data material dialog (table) and file handler

2016-09-08 Thread Georg Baum
Richard Heck wrote:

> On 09/06/2016 06:10 PM, Georg Baum wrote:
>> Richard Heck wrote:
>>
>>> On 09/05/2016 04:56 PM, Georg Baum wrote:
 I think he meant the missing .xlsx extension in the external material
 file dialog. I added this in master at df8e0ed9e0c37ab7.
>>> Fine for stable too.
>> I need 646d47ae9393bc for stable too, otherwise I only see one filter
>> "All files".
> 
> That is fine with me.

Thanks, both changes are in.


Georg



RE: [enhancement] add *.xlsx to external data material dialog (table) and file handler

2016-09-07 Thread Jannick
From: Helge Hafting [mailto:helge.haft...@ntnu.no] 
Sent: Monday, September 5, 2016 3:07 PM

Den 05. sep. 2016 00:53, skrev Jannick:
> Currently lyx deals with *.xls files only, while the Excel world 
> rather turns around .xlsx files. It would be great if lyx could be 
> extended including the file handler where ssconvert appears to 
> faithfully extract data from *.xlsx files.
>
> I am not subscribed to the devel list, so please copy me in if you 
> need any more information on this from my side.
>
LyX already support .xlsx, so I am not sure what you are asking for here?

I created a LyX document, inserted a file (external material). I selected
spreadsheet, and typed in "testfile.xlsx". This worked fine, the PDF
contained the spreadsheet. Anything "ssconvert" supports should indeed work.
I don't know if ssconvert handles all xlsx files, but it certainly handled
my testfile well.

I tested with LyX 2.2.1, but this sould work for most earlier versions too -
as there haven't been much changes since the excel support went in.
Conversion is handled by ssconvert, so anything ssconvert handles should
work, (unless the spreadsheet is wider than the page).

Do you have an xlsx file that ssconvert handles, but LyX does not? If so,
please send me such a file so I can look into it.

Helge Hafting

_

Thanks. What I am suggesting is an enhancement of lyx' ssconvert interface
(i.e. for external material/tables), namely:

1 - adding *.xlsx to the file filter of the file selection dialog window (to
avoid manual entering the file name - as you suggested - and not to be
cluttered with all files in the specific folder after selecting the file
filter *.* provided as second option in the file selection dialog window)

2 - add *.xlsx in the default file handler configuration which does not
appear to exist in the default configuration (in lyx 2.1.5 (on Win10) there
is only one explicitly saying that it deals with *.xls). 

Regards,
J. 



Re: [enhancement] add *.xlsx to external data material dialog (table) and file handler

2016-09-06 Thread Richard Heck
On 09/06/2016 06:10 PM, Georg Baum wrote:
> Richard Heck wrote:
>
>> On 09/05/2016 04:56 PM, Georg Baum wrote:
>>> I think he meant the missing .xlsx extension in the external material
>>> file dialog. I added this in master at df8e0ed9e0c37ab7.
>> Fine for stable too.
> I need 646d47ae9393bc for stable too, otherwise I only see one filter "All 
> files". 

That is fine with me.

> Does anybody understand the old code? 

No.

Richard



Re: [enhancement] add *.xlsx to external data material dialog (table) and file handler

2016-09-06 Thread Georg Baum
Richard Heck wrote:

> On 09/05/2016 04:56 PM, Georg Baum wrote:
>> I think he meant the missing .xlsx extension in the external material
>> file dialog. I added this in master at df8e0ed9e0c37ab7.
> 
> Fine for stable too.

I need 646d47ae9393bc for stable too, otherwise I only see one filter "All 
files". Does anybody understand the old code? Does anybody see the same 
problem with current branch (no file browse dialog of an external inset has 
a specific filter)?


Georg



Re: [enhancement] add *.xlsx to external data material dialog (table) and file handler

2016-09-05 Thread Richard Heck
On 09/05/2016 04:56 PM, Georg Baum wrote:
> Helge Hafting wrote:
>
>> Den 05. sep. 2016 00:53, skrev Jannick:
>>> Currently lyx deals with *.xls files only, while the Excel world rather
>>> turns around .xlsx files. It would be great if lyx could be extended
>>> including the file handler where ssconvert appears to faithfully extract
>>> data from *.xlsx files.
>>>
>>> I am not subscribed to the devel list, so please copy me in if you need
>>> any more information on this from my side.
>>>
>> LyX already support .xlsx, so I am not sure what you are asking for here?
> I think he meant the missing .xlsx extension in the external material file 
> dialog. I added this in master at df8e0ed9e0c37ab7.

Fine for stable too.

rh



Re: [enhancement] add *.xlsx to external data material dialog (table) and file handler

2016-09-05 Thread Georg Baum
Helge Hafting wrote:

> Den 05. sep. 2016 00:53, skrev Jannick:
>> Currently lyx deals with *.xls files only, while the Excel world rather
>> turns around .xlsx files. It would be great if lyx could be extended
>> including the file handler where ssconvert appears to faithfully extract
>> data from *.xlsx files.
>>
>> I am not subscribed to the devel list, so please copy me in if you need
>> any more information on this from my side.
>>
> LyX already support .xlsx, so I am not sure what you are asking for here?

I think he meant the missing .xlsx extension in the external material file 
dialog. I added this in master at df8e0ed9e0c37ab7.


Georg




Re: [enhancement] add *.xlsx to external data material dialog (table) and file handler

2016-09-05 Thread Helge Hafting



Den 05. sep. 2016 00:53, skrev Jannick:

Currently lyx deals with *.xls files only, while the Excel world rather
turns around .xlsx files. It would be great if lyx could be extended
including the file handler where ssconvert appears to faithfully extract
data from *.xlsx files.

I am not subscribed to the devel list, so please copy me in if you need any
more information on this from my side.


LyX already support .xlsx, so I am not sure what you are asking for here?

I created a LyX document, inserted a file (external material). I 
selected spreadsheet, and typed in "testfile.xlsx". This worked fine, 
the PDF contained the spreadsheet. Anything "ssconvert" supports should 
indeed work. I don't know if ssconvert handles all xlsx files, but it 
certainly handled my testfile well.


I tested with LyX 2.2.1, but this sould work for most earlier versions 
too - as there haven't been much changes since the excel support went 
in. Conversion is handled by ssconvert, so anything ssconvert handles 
should work, (unless the spreadsheet is wider than the page).


Do you have an xlsx file that ssconvert handles, but LyX does not? If 
so, please send me such a file so I can look into it.


Helge Hafting


[enhancement] add *.xlsx to external data material dialog (table) and file handler

2016-09-04 Thread Jannick
Currently lyx deals with *.xls files only, while the Excel world rather
turns around .xlsx files. It would be great if lyx could be extended
including the file handler where ssconvert appears to faithfully extract
data from *.xlsx files. 

I am not subscribed to the devel list, so please copy me in if you need any
more information on this from my side.

Many thanks,
J.