Re: [LyX/master] ctests: log a fixed LaTeX package issue (noweb)

2021-06-21 Thread Scott Kostyshak
On Mon, Jun 21, 2021 at 08:59:39AM +0200, Kornel Benko wrote:
> Am Sun, 20 Jun 2021 14:04:50 -0400
> schrieb Scott Kostyshak :
> 
> > On Sun, Jun 20, 2021 at 09:38:27AM +0200, Kornel Benko wrote:
> > > Am Sun, 20 Jun 2021 05:54:24 +0200 (CEST)
> > > schrieb Scott Kostyshak :
> > >   
> > > > commit 37bce91a8be2273dd43d73088f97f87a4052af9b
> > > > Author: Scott Kostyshak 
> > > > Date:   Sun Jun 20 00:05:42 2021 -0400
> > > > 
> > > > ctests: log a fixed LaTeX package issue (noweb)
> > > > ---
> > > >  development/autotests/ctests-costs-benefits.txt |6 ++
> > > >  1 files changed, 6 insertions(+), 0 deletions(-)
> > > > 
> > > > diff --git a/development/autotests/ctests-costs-benefits.txt
> > > > b/development/autotests/ctests-costs-benefits.txt index 
> > > > 4f5be6f..c7b2e3c 100644
> > > > --- a/development/autotests/ctests-costs-benefits.txt
> > > > +++ b/development/autotests/ctests-costs-benefits.txt
> > > > @@ -48,3 +48,9 @@ Fix: 39a9e370
> > > >  
> > > >  Report :
> > > > https://www.mail-archive.com/search?l=mid=20210528001413.56phju7dvfn4dexs%40tallinn
> > > > Fix: ffa6a724 +
> > > > +
> > > > +Examples where upstream (e.g., LaTeX packages) bugs were fixed (more 
> > > > quickly)
> > > > +because of ctests:
> > > > +
> > > > +Fix: https://github.com/nrnrnr/noweb/pull/12#event-4892099481  
> > > 
> > > What about the "-dALLOWPSTRANSPARENCY" flag for ps2pdf?
> > > This is first detected by ctest too, if I recall correctly.  
> > 
> > Good idea, I agree. We should also add that the issue was subsequently
> > reported here:
> > https://www.lyx.org/trac/ticket/12303
> > Knowing the time between when the ctests help detect something and when
> > we would have discovered the issue from a different source (i.e., if
> > there were no ctest coverage) is one way to evaluate how helpful the
> > ctests are in an objective way. In this case, we only discovered the
> > issue a couple of weeks before it was reported.
> > 
> > Feel free to add that information to the file or I can add it tomorrow.
> 
> Yes please. (You are way better to formulate)

Done at 2dd9e1a3.

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] ctests: log a fixed LaTeX package issue (noweb)

2021-06-21 Thread Kornel Benko
Am Sun, 20 Jun 2021 14:04:50 -0400
schrieb Scott Kostyshak :

> On Sun, Jun 20, 2021 at 09:38:27AM +0200, Kornel Benko wrote:
> > Am Sun, 20 Jun 2021 05:54:24 +0200 (CEST)
> > schrieb Scott Kostyshak :
> >   
> > > commit 37bce91a8be2273dd43d73088f97f87a4052af9b
> > > Author: Scott Kostyshak 
> > > Date:   Sun Jun 20 00:05:42 2021 -0400
> > > 
> > > ctests: log a fixed LaTeX package issue (noweb)
> > > ---
> > >  development/autotests/ctests-costs-benefits.txt |6 ++
> > >  1 files changed, 6 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/development/autotests/ctests-costs-benefits.txt
> > > b/development/autotests/ctests-costs-benefits.txt index 4f5be6f..c7b2e3c 
> > > 100644
> > > --- a/development/autotests/ctests-costs-benefits.txt
> > > +++ b/development/autotests/ctests-costs-benefits.txt
> > > @@ -48,3 +48,9 @@ Fix: 39a9e370
> > >  
> > >  Report :
> > > https://www.mail-archive.com/search?l=mid=20210528001413.56phju7dvfn4dexs%40tallinn
> > > Fix: ffa6a724 +
> > > +
> > > +Examples where upstream (e.g., LaTeX packages) bugs were fixed (more 
> > > quickly)
> > > +because of ctests:
> > > +
> > > +Fix: https://github.com/nrnrnr/noweb/pull/12#event-4892099481  
> > 
> > What about the "-dALLOWPSTRANSPARENCY" flag for ps2pdf?
> > This is first detected by ctest too, if I recall correctly.  
> 
> Good idea, I agree. We should also add that the issue was subsequently
> reported here:
> https://www.lyx.org/trac/ticket/12303
> Knowing the time between when the ctests help detect something and when
> we would have discovered the issue from a different source (i.e., if
> there were no ctest coverage) is one way to evaluate how helpful the
> ctests are in an objective way. In this case, we only discovered the
> issue a couple of weeks before it was reported.
> 
> Feel free to add that information to the file or I can add it tomorrow.

Yes please. (You are way better to formulate)

> Scott

Kornel


pgp9uM1OVk_cf.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] ctests: log a fixed LaTeX package issue (noweb)

2021-06-20 Thread Scott Kostyshak
On Sun, Jun 20, 2021 at 09:38:27AM +0200, Kornel Benko wrote:
> Am Sun, 20 Jun 2021 05:54:24 +0200 (CEST)
> schrieb Scott Kostyshak :
> 
> > commit 37bce91a8be2273dd43d73088f97f87a4052af9b
> > Author: Scott Kostyshak 
> > Date:   Sun Jun 20 00:05:42 2021 -0400
> > 
> > ctests: log a fixed LaTeX package issue (noweb)
> > ---
> >  development/autotests/ctests-costs-benefits.txt |6 ++
> >  1 files changed, 6 insertions(+), 0 deletions(-)
> > 
> > diff --git a/development/autotests/ctests-costs-benefits.txt
> > b/development/autotests/ctests-costs-benefits.txt index 4f5be6f..c7b2e3c 
> > 100644
> > --- a/development/autotests/ctests-costs-benefits.txt
> > +++ b/development/autotests/ctests-costs-benefits.txt
> > @@ -48,3 +48,9 @@ Fix: 39a9e370
> >  
> >  Report :
> > https://www.mail-archive.com/search?l=mid=20210528001413.56phju7dvfn4dexs%40tallinn
> > Fix: ffa6a724 +
> > +
> > +Examples where upstream (e.g., LaTeX packages) bugs were fixed (more 
> > quickly)
> > +because of ctests:
> > +
> > +Fix: https://github.com/nrnrnr/noweb/pull/12#event-4892099481
> 
> What about the "-dALLOWPSTRANSPARENCY" flag for ps2pdf?
> This is first detected by ctest too, if I recall correctly.

Good idea, I agree. We should also add that the issue was subsequently
reported here:
https://www.lyx.org/trac/ticket/12303
Knowing the time between when the ctests help detect something and when
we would have discovered the issue from a different source (i.e., if
there were no ctest coverage) is one way to evaluate how helpful the
ctests are in an objective way. In this case, we only discovered the
issue a couple of weeks before it was reported.

Feel free to add that information to the file or I can add it tomorrow.

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] ctests: log a fixed LaTeX package issue (noweb)

2021-06-20 Thread Kornel Benko
Am Sun, 20 Jun 2021 05:54:24 +0200 (CEST)
schrieb Scott Kostyshak :

> commit 37bce91a8be2273dd43d73088f97f87a4052af9b
> Author: Scott Kostyshak 
> Date:   Sun Jun 20 00:05:42 2021 -0400
> 
> ctests: log a fixed LaTeX package issue (noweb)
> ---
>  development/autotests/ctests-costs-benefits.txt |6 ++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/development/autotests/ctests-costs-benefits.txt
> b/development/autotests/ctests-costs-benefits.txt index 4f5be6f..c7b2e3c 
> 100644
> --- a/development/autotests/ctests-costs-benefits.txt
> +++ b/development/autotests/ctests-costs-benefits.txt
> @@ -48,3 +48,9 @@ Fix: 39a9e370
>  
>  Report :
> https://www.mail-archive.com/search?l=mid=20210528001413.56phju7dvfn4dexs%40tallinn
> Fix: ffa6a724 +
> +
> +Examples where upstream (e.g., LaTeX packages) bugs were fixed (more quickly)
> +because of ctests:
> +
> +Fix: https://github.com/nrnrnr/noweb/pull/12#event-4892099481

What about the "-dALLOWPSTRANSPARENCY" flag for ps2pdf?
This is first detected by ctest too, if I recall correctly.

Kornel


pgpBtsR9nlrTp.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel