Re: Put OS information in Help > About > Version ?

2022-12-06 Thread Scott Kostyshak
On Tue, Dec 06, 2022 at 10:19:18PM +0100, Stephan Witt wrote:
> Am 06.12.2022 um 22:12 schrieb Pavel Sanda :
> > 
> > On Tue, Dec 06, 2022 at 12:25:53PM -0500, Scott Kostyshak wrote:
> >> For a macOS user, can we tell whether they are on Ventura or not?
> > 
> > I???ll try QSysInfo::productVersion() ???
>  
>  This will show up like that:
>  
>  
>  
>  With Ventura it should be: 13.0
> >>> 
> >>> This would be the patch w/o I18N ???
> >> 
> >> Tested and works well here! I would say commit (unless someone else 
> >> disagrees).
> >> 
> >> For me, the version showed up as "22.04". I actually expected my kernel
> >> version to show up.
> > 
> > I guess that's  what QSysInfo::kernelType() is for.
> > Anyway quickly checking members of QSysInfo you might actually
> > want to use QSysInfo::prettyProductName().
> 
> Indeed. This prints "macOS Mojave (10.14)“ here.

Ah yes, that is nice! Thanks, Stephan and Pavel.

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Put OS information in Help > About > Version ?

2022-12-06 Thread Stephan Witt
Am 06.12.2022 um 22:12 schrieb Pavel Sanda :
> 
> On Tue, Dec 06, 2022 at 12:25:53PM -0500, Scott Kostyshak wrote:
>> For a macOS user, can we tell whether they are on Ventura or not?
> 
> I???ll try QSysInfo::productVersion() ???
 
 This will show up like that:
 
 
 
 With Ventura it should be: 13.0
>>> 
>>> This would be the patch w/o I18N ???
>> 
>> Tested and works well here! I would say commit (unless someone else 
>> disagrees).
>> 
>> For me, the version showed up as "22.04". I actually expected my kernel
>> version to show up.
> 
> I guess that's  what QSysInfo::kernelType() is for.
> Anyway quickly checking members of QSysInfo you might actually
> want to use QSysInfo::prettyProductName().

Indeed. This prints "macOS Mojave (10.14)“ here.

Stephan
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Put OS information in Help > About > Version ?

2022-12-06 Thread Pavel Sanda
On Tue, Dec 06, 2022 at 12:25:53PM -0500, Scott Kostyshak wrote:
> > >>> For a macOS user, can we tell whether they are on Ventura or not?
> > >> 
> > >> I???ll try QSysInfo::productVersion() ???
> > > 
> > > This will show up like that:
> > > 
> > > 
> > > 
> > > With Ventura it should be: 13.0
> > 
> > This would be the patch w/o I18N ???
> 
> Tested and works well here! I would say commit (unless someone else 
> disagrees).
> 
> For me, the version showed up as "22.04". I actually expected my kernel
> version to show up.

I guess that's  what QSysInfo::kernelType() is for.
Anyway quickly checking members of QSysInfo you might actually
want to use QSysInfo::prettyProductName().

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Put OS information in Help > About > Version ?

2022-12-06 Thread Scott Kostyshak
On Tue, Dec 06, 2022 at 06:11:40PM +0100, Stephan Witt wrote:
> Am 06.12.2022 um 18:08 schrieb Stephan Witt :
> > 
> > Am 06.12.2022 um 17:15 schrieb Stephan Witt :
> >> 
> >> Am 06.12.2022 um 16:34 schrieb Scott Kostyshak :
> >>> 
> >>> On Sun, Dec 04, 2022 at 10:13:11PM +0100, Jean-Marc Lasgouttes wrote:
>  Le 04/12/2022 à 21:41, Scott Kostyshak a écrit :
> > When collecting information, it might be nice to have OS information.
> > That way, the user only has to go to Help > About and click on "Copy
> > Version Info" and all important information is copied; rather than
> > having to ask them to separately state it.
> > 
> > Is it OK if I add OS information? I'm not sure when I will get around to
> > actually doing it but since it came up now I thought I would ask.
>  
>  Note that in the About LyX dialog, we have platform which gives the GUI
>  information. What else would you like?
> >>> 
> >>> For a macOS user, can we tell whether they are on Ventura or not?
> >> 
> >> I’ll try QSysInfo::productVersion() …
> > 
> > This will show up like that:
> > 
> > 
> > 
> > With Ventura it should be: 13.0
> 
> This would be the patch w/o I18N …

Tested and works well here! I would say commit (unless someone else disagrees).

For me, the version showed up as "22.04". I actually expected my kernel
version to show up. This is a bit strange, since it doesn't say "Ubuntu"
anywhere, but I think in many cases the distribution could be inferred
from the number anyway. And in any case, I think this will be most
useful for macOS and Windows.

Thanks!
Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Put OS information in Help > About > Version ?

2022-12-06 Thread Stephan Witt
Am 06.12.2022 um 18:08 schrieb Stephan Witt :
> 
> Am 06.12.2022 um 17:15 schrieb Stephan Witt :
>> 
>> Am 06.12.2022 um 16:34 schrieb Scott Kostyshak :
>>> 
>>> On Sun, Dec 04, 2022 at 10:13:11PM +0100, Jean-Marc Lasgouttes wrote:
 Le 04/12/2022 à 21:41, Scott Kostyshak a écrit :
> When collecting information, it might be nice to have OS information.
> That way, the user only has to go to Help > About and click on "Copy
> Version Info" and all important information is copied; rather than
> having to ask them to separately state it.
> 
> Is it OK if I add OS information? I'm not sure when I will get around to
> actually doing it but since it came up now I thought I would ask.
 
 Note that in the About LyX dialog, we have platform which gives the GUI
 information. What else would you like?
>>> 
>>> For a macOS user, can we tell whether they are on Ventura or not?
>> 
>> I’ll try QSysInfo::productVersion() …
> 
> This will show up like that:
> 
> 
> 
> With Ventura it should be: 13.0

This would be the patch w/o I18N …

Stephan



GuiAbout.patch
Description: Binary data
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Put OS information in Help > About > Version ?

2022-12-06 Thread Stephan Witt
Am 06.12.2022 um 17:15 schrieb Stephan Witt :
> 
> Am 06.12.2022 um 16:34 schrieb Scott Kostyshak :
>> 
>> On Sun, Dec 04, 2022 at 10:13:11PM +0100, Jean-Marc Lasgouttes wrote:
>>> Le 04/12/2022 à 21:41, Scott Kostyshak a écrit :
 When collecting information, it might be nice to have OS information.
 That way, the user only has to go to Help > About and click on "Copy
 Version Info" and all important information is copied; rather than
 having to ask them to separately state it.
 
 Is it OK if I add OS information? I'm not sure when I will get around to
 actually doing it but since it came up now I thought I would ask.
>>> 
>>> Note that in the About LyX dialog, we have platform which gives the GUI
>>> information. What else would you like?
>> 
>> For a macOS user, can we tell whether they are on Ventura or not?
> 
> I’ll try QSysInfo::productVersion() …

This will show up like that:



With Ventura it should be: 13.0

Stephan-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Put OS information in Help > About > Version ?

2022-12-06 Thread Stephan Witt
Am 06.12.2022 um 16:34 schrieb Scott Kostyshak :
> 
> On Sun, Dec 04, 2022 at 10:13:11PM +0100, Jean-Marc Lasgouttes wrote:
>> Le 04/12/2022 à 21:41, Scott Kostyshak a écrit :
>>> When collecting information, it might be nice to have OS information.
>>> That way, the user only has to go to Help > About and click on "Copy
>>> Version Info" and all important information is copied; rather than
>>> having to ask them to separately state it.
>>> 
>>> Is it OK if I add OS information? I'm not sure when I will get around to
>>> actually doing it but since it came up now I thought I would ask.
>> 
>> Note that in the About LyX dialog, we have platform which gives the GUI
>> information. What else would you like?
> 
> For a macOS user, can we tell whether they are on Ventura or not?

I’ll try QSysInfo::productVersion() …

Stephan
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Put OS information in Help > About > Version ?

2022-12-06 Thread Scott Kostyshak
On Sun, Dec 04, 2022 at 10:13:11PM +0100, Jean-Marc Lasgouttes wrote:
> Le 04/12/2022 à 21:41, Scott Kostyshak a écrit :
> > When collecting information, it might be nice to have OS information.
> > That way, the user only has to go to Help > About and click on "Copy
> > Version Info" and all important information is copied; rather than
> > having to ask them to separately state it.
> > 
> > Is it OK if I add OS information? I'm not sure when I will get around to
> > actually doing it but since it came up now I thought I would ask.
> 
> Note that in the About LyX dialog, we have platform which gives the GUI
> information. What else would you like?

For a macOS user, can we tell whether they are on Ventura or not?

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Put OS information in Help > About > Version ?

2022-12-04 Thread Jean-Marc Lasgouttes

Le 04/12/2022 à 21:41, Scott Kostyshak a écrit :

When collecting information, it might be nice to have OS information.
That way, the user only has to go to Help > About and click on "Copy
Version Info" and all important information is copied; rather than
having to ask them to separately state it.

Is it OK if I add OS information? I'm not sure when I will get around to
actually doing it but since it came up now I thought I would ask.


Note that in the About LyX dialog, we have platform which gives the GUI 
information. What else would you like?


JMarc

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel