Re: Text selection does not work as expected
Am Do., 10. Sept. 2020 um 20:13 Uhr schrieb Scott Kostyshak < skost...@lyx.org>: > On Thu, Sep 10, 2020 at 08:00:04PM +0200, Yu Jin wrote: > > Am Do., 9. Juli 2020 um 10:12 Uhr schrieb Daniel : > > > > > On 2020-07-09 09:39, Yu Jin wrote: > > > > Am Mi., 8. Juli 2020 um 23:31 Uhr schrieb Scott Kostyshak > > > > mailto:skost...@lyx.org>>: > > > > > > > > On Wed, Jul 08, 2020 at 07:22:45PM +0200, Yu Jin wrote: > > > > > > > > > Here we go, patch attached. I decided to put Qt version check > > > 5.10.1, > > > > > because I have tested it on LyX 2.3.1, which was shipped with > Qt > > > > 5.10.1 and > > > > > the bug was not there yet. > > > > > > > > Your patch is perfect, Eugene. Thanks! Please commit. > > > > > > > > One minor typo: "wuickly" should be "quickly". > > > > > > > > Thanks for your Qt bug report. I know it takes time to make a > minimal > > > > example and post it. It looks like they're taking a look and > already > > > > it's good to know that it can't be reproduced on macOS. > > > > > > > > > > > > Ok done, I will keep an eye on it on the Qt bugtracker and will send > an > > > > Email once it has been fixed. > > > > Thanks for the report, Daniel. > > > > > > > > Eugene > > > > > > Thanks. And thank you both for following up on it! > > > > > > > Qt 5.15.1 is released today, I have compiled master using that version > > while the fixing commit was reverted. As expected, the text selection is > > behaving as expected. Means the bug is fixed. I have attached a patch for > > review. > > Looks good. I suggest you push. > > > Another possibility would ofc be to revert the original commit > > (06969f9d). > > I have a slight preference for you to push the patch. I think that we go > through those version guards and remove them after LyX requires a > minimum Qt version with the fix. That is, once we require at least Qt > 5.15.1 as a version, then we can remove this specific instance of the > guards. We won't require 5.15.1 for a long time (I hope!). If you have a > preference to revert the original commit though, we should discuss it. > Nah, was just listing the possibilities. What you wrote makes sense, I agree, I just didn't think about that. > Nice work getting a Qt bug fixed! > Thank you, I guess. -- Eugene -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Text selection does not work as expected
On Thu, Sep 10, 2020 at 08:00:04PM +0200, Yu Jin wrote: > Am Do., 9. Juli 2020 um 10:12 Uhr schrieb Daniel : > > > On 2020-07-09 09:39, Yu Jin wrote: > > > Am Mi., 8. Juli 2020 um 23:31 Uhr schrieb Scott Kostyshak > > > mailto:skost...@lyx.org>>: > > > > > > On Wed, Jul 08, 2020 at 07:22:45PM +0200, Yu Jin wrote: > > > > > > > Here we go, patch attached. I decided to put Qt version check > > 5.10.1, > > > > because I have tested it on LyX 2.3.1, which was shipped with Qt > > > 5.10.1 and > > > > the bug was not there yet. > > > > > > Your patch is perfect, Eugene. Thanks! Please commit. > > > > > > One minor typo: "wuickly" should be "quickly". > > > > > > Thanks for your Qt bug report. I know it takes time to make a minimal > > > example and post it. It looks like they're taking a look and already > > > it's good to know that it can't be reproduced on macOS. > > > > > > > > > Ok done, I will keep an eye on it on the Qt bugtracker and will send an > > > Email once it has been fixed. > > > Thanks for the report, Daniel. > > > > > > Eugene > > > > Thanks. And thank you both for following up on it! > > > > Qt 5.15.1 is released today, I have compiled master using that version > while the fixing commit was reverted. As expected, the text selection is > behaving as expected. Means the bug is fixed. I have attached a patch for > review. Looks good. I suggest you push. > Another possibility would ofc be to revert the original commit > (06969f9d). I have a slight preference for you to push the patch. I think that we go through those version guards and remove them after LyX requires a minimum Qt version with the fix. That is, once we require at least Qt 5.15.1 as a version, then we can remove this specific instance of the guards. We won't require 5.15.1 for a long time (I hope!). If you have a preference to revert the original commit though, we should discuss it. Nice work getting a Qt bug fixed! Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Text selection does not work as expected
Am Do., 9. Juli 2020 um 10:12 Uhr schrieb Daniel : > On 2020-07-09 09:39, Yu Jin wrote: > > Am Mi., 8. Juli 2020 um 23:31 Uhr schrieb Scott Kostyshak > > mailto:skost...@lyx.org>>: > > > > On Wed, Jul 08, 2020 at 07:22:45PM +0200, Yu Jin wrote: > > > > > Here we go, patch attached. I decided to put Qt version check > 5.10.1, > > > because I have tested it on LyX 2.3.1, which was shipped with Qt > > 5.10.1 and > > > the bug was not there yet. > > > > Your patch is perfect, Eugene. Thanks! Please commit. > > > > One minor typo: "wuickly" should be "quickly". > > > > Thanks for your Qt bug report. I know it takes time to make a minimal > > example and post it. It looks like they're taking a look and already > > it's good to know that it can't be reproduced on macOS. > > > > > > Ok done, I will keep an eye on it on the Qt bugtracker and will send an > > Email once it has been fixed. > > Thanks for the report, Daniel. > > > > Eugene > > Thanks. And thank you both for following up on it! > Qt 5.15.1 is released today, I have compiled master using that version while the fixing commit was reverted. As expected, the text selection is behaving as expected. Means the bug is fixed. I have attached a patch for review. Another possibility would ofc be to revert the original commit (06969f9d). -- Eugene file.diff Description: Binary data -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Text selection does not work as expected
On 2020-07-09 09:39, Yu Jin wrote: Am Mi., 8. Juli 2020 um 23:31 Uhr schrieb Scott Kostyshak mailto:skost...@lyx.org>>: On Wed, Jul 08, 2020 at 07:22:45PM +0200, Yu Jin wrote: > Here we go, patch attached. I decided to put Qt version check 5.10.1, > because I have tested it on LyX 2.3.1, which was shipped with Qt 5.10.1 and > the bug was not there yet. Your patch is perfect, Eugene. Thanks! Please commit. One minor typo: "wuickly" should be "quickly". Thanks for your Qt bug report. I know it takes time to make a minimal example and post it. It looks like they're taking a look and already it's good to know that it can't be reproduced on macOS. Ok done, I will keep an eye on it on the Qt bugtracker and will send an Email once it has been fixed. Thanks for the report, Daniel. Eugene Thanks. And thank you both for following up on it! Daniel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Text selection does not work as expected
Am Mi., 8. Juli 2020 um 23:31 Uhr schrieb Scott Kostyshak : > On Wed, Jul 08, 2020 at 07:22:45PM +0200, Yu Jin wrote: > > > Here we go, patch attached. I decided to put Qt version check 5.10.1, > > because I have tested it on LyX 2.3.1, which was shipped with Qt 5.10.1 > and > > the bug was not there yet. > > Your patch is perfect, Eugene. Thanks! Please commit. > > One minor typo: "wuickly" should be "quickly". > > Thanks for your Qt bug report. I know it takes time to make a minimal > example and post it. It looks like they're taking a look and already > it's good to know that it can't be reproduced on macOS. > Ok done, I will keep an eye on it on the Qt bugtracker and will send an Email once it has been fixed. Thanks for the report, Daniel. Eugene -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Text selection does not work as expected
On Wed, Jul 08, 2020 at 07:22:45PM +0200, Yu Jin wrote: > Here we go, patch attached. I decided to put Qt version check 5.10.1, > because I have tested it on LyX 2.3.1, which was shipped with Qt 5.10.1 and > the bug was not there yet. Your patch is perfect, Eugene. Thanks! Please commit. One minor typo: "wuickly" should be "quickly". Thanks for your Qt bug report. I know it takes time to make a minimal example and post it. It looks like they're taking a look and already it's good to know that it can't be reproduced on macOS. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Text selection does not work as expected
Am Sa., 4. Juli 2020 um 22:02 Uhr schrieb Scott Kostyshak : > On Sat, Jul 04, 2020 at 07:50:18PM +0200, Yu Jin wrote: > > Am Sa., 4. Juli 2020 um 17:16 Uhr schrieb Scott Kostyshak < > skost...@lyx.org > > >: > > > > > > > > Thanks for looking into this, Eugene. Just to make sure I understand, > > > you think this is a Qt bug, right? I don't know anything about this > > > > > > > It looks like a Qt bug indeed, I have reported it on Qt bugtracker. > > Great, thanks for doing that. I suggest to put the URL to the Qt bug > report when you commit. > > > But to > > clarify, the bug occurs only on touchpads (not on Windows 10 in general). > > I have tested an older LyX version on my notebook, 2.3.1 (with Qt 5.10.1) > > -> no bug. The newer LyX versions, which come with Qt 5.12.5 and also my > > latest betainstaller, where I used Qt 5.15.0, do have that bug, therefore > > it seems like a Qt bug. > > > > > > > stuff, so hopefully a different LyX developer takes a look. Don't spend > > > time making a new patch based on my comments (wait for another LyX dev > > > first), but if you do get a +1 to commit, it would be nice to mark > > > exactly what parts of the code are in there because of a workaround for > > > a Qt bug, and how to test that the bug is no longer relevant (e.g., "to > > > test if this workaround is still needed, try to select a word by > > > double-clicking in LyX on Windows 10. For more information, see the > > > following ML thread..."). > > > > > > Taking a step back, what changed that triggered this bug? I'm guessing > > > that it is because we compiled LyX 2.3.5 with a newer Qt version. Is > that > > > correct? Is it worth compiling 2.3.4 on your machine to double-check > that > > > you *can* reproduce the bug (since using a newer Qt version)? What Qt > > > version was 2.3.4 compiled with? I personally would support putting the > > > added lines in preprocessor guards but I don't know how other LyX > > > developers feel about that. Here is the flavor of preprocessor checking > > > that I think is easiest: > > > > > > > I have compiled master with Qt 5.15.0 on my machine, resulting in the bug > > occuring. Compiling master with Qt 5.9.9 (I could not download 5.10.1, to > > match what is used in the LyX version I have tried above, for some > reason) > > didn't produce the bug. > > Thanks for those checks. > > > > #if (QT_VERSION < QT_VERSION_CHECK(5, 0, 0)) > > >// code here... > > > #endif > > > > > > I see and understand now that workarounds for Qt bugs are not easy to > > handle. Also I can't predict when or if the bug will be fixed in Qt. So > > what is attached is what I can provide for now, maybe other developers > have > > more experience or better ideas? > > So something like the following could work (but I haven't tested): > > #if (QT_VERSION > QT_VERSION_CHECK(5, 9, 9)) >// we do not see the bug with 5.9.9 and do see it with 5.15.0 >// Qt bug report: >... > #endif > > > Btw do we have some kind of tracker for > > this kind of issues? > > I think in trac we have (or at least had) a keyword "qtbug". But we were > never too careful about using it. > > If no one else responds within a couple of days, if you make a patch > with the Qt version guards, I think I would feel comfortable taking a > closer look and would likely give a +1. > Here we go, patch attached. I decided to put Qt version check 5.10.1, because I have tested it on LyX 2.3.1, which was shipped with Qt 5.10.1 and the bug was not there yet. Eugene MouseMoveEvent.diff Description: Binary data -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Text selection does not work as expected
On Sat, Jul 04, 2020 at 07:50:18PM +0200, Yu Jin wrote: > Am Sa., 4. Juli 2020 um 17:16 Uhr schrieb Scott Kostyshak >: > > > > > Thanks for looking into this, Eugene. Just to make sure I understand, > > you think this is a Qt bug, right? I don't know anything about this > > > > It looks like a Qt bug indeed, I have reported it on Qt bugtracker. Great, thanks for doing that. I suggest to put the URL to the Qt bug report when you commit. > But to > clarify, the bug occurs only on touchpads (not on Windows 10 in general). > I have tested an older LyX version on my notebook, 2.3.1 (with Qt 5.10.1) > -> no bug. The newer LyX versions, which come with Qt 5.12.5 and also my > latest betainstaller, where I used Qt 5.15.0, do have that bug, therefore > it seems like a Qt bug. > > > > stuff, so hopefully a different LyX developer takes a look. Don't spend > > time making a new patch based on my comments (wait for another LyX dev > > first), but if you do get a +1 to commit, it would be nice to mark > > exactly what parts of the code are in there because of a workaround for > > a Qt bug, and how to test that the bug is no longer relevant (e.g., "to > > test if this workaround is still needed, try to select a word by > > double-clicking in LyX on Windows 10. For more information, see the > > following ML thread..."). > > > > Taking a step back, what changed that triggered this bug? I'm guessing > > that it is because we compiled LyX 2.3.5 with a newer Qt version. Is that > > correct? Is it worth compiling 2.3.4 on your machine to double-check that > > you *can* reproduce the bug (since using a newer Qt version)? What Qt > > version was 2.3.4 compiled with? I personally would support putting the > > added lines in preprocessor guards but I don't know how other LyX > > developers feel about that. Here is the flavor of preprocessor checking > > that I think is easiest: > > > > I have compiled master with Qt 5.15.0 on my machine, resulting in the bug > occuring. Compiling master with Qt 5.9.9 (I could not download 5.10.1, to > match what is used in the LyX version I have tried above, for some reason) > didn't produce the bug. Thanks for those checks. > > #if (QT_VERSION < QT_VERSION_CHECK(5, 0, 0)) > >// code here... > > #endif > > > I see and understand now that workarounds for Qt bugs are not easy to > handle. Also I can't predict when or if the bug will be fixed in Qt. So > what is attached is what I can provide for now, maybe other developers have > more experience or better ideas? So something like the following could work (but I haven't tested): #if (QT_VERSION > QT_VERSION_CHECK(5, 9, 9)) // we do not see the bug with 5.9.9 and do see it with 5.15.0 // Qt bug report: ... #endif > Btw do we have some kind of tracker for > this kind of issues? I think in trac we have (or at least had) a keyword "qtbug". But we were never too careful about using it. If no one else responds within a couple of days, if you make a patch with the Qt version guards, I think I would feel comfortable taking a closer look and would likely give a +1. Thanks, Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Text selection does not work as expected
Am Sa., 4. Juli 2020 um 17:16 Uhr schrieb Scott Kostyshak : > > Thanks for looking into this, Eugene. Just to make sure I understand, > you think this is a Qt bug, right? I don't know anything about this > It looks like a Qt bug indeed, I have reported it on Qt bugtracker. But to clarify, the bug occurs only on touchpads (not on Windows 10 in general). I have tested an older LyX version on my notebook, 2.3.1 (with Qt 5.10.1) -> no bug. The newer LyX versions, which come with Qt 5.12.5 and also my latest betainstaller, where I used Qt 5.15.0, do have that bug, therefore it seems like a Qt bug. > stuff, so hopefully a different LyX developer takes a look. Don't spend > time making a new patch based on my comments (wait for another LyX dev > first), but if you do get a +1 to commit, it would be nice to mark > exactly what parts of the code are in there because of a workaround for > a Qt bug, and how to test that the bug is no longer relevant (e.g., "to > test if this workaround is still needed, try to select a word by > double-clicking in LyX on Windows 10. For more information, see the > following ML thread..."). > > Taking a step back, what changed that triggered this bug? I'm guessing > that it is because we compiled LyX 2.3.5 with a newer Qt version. Is that > correct? Is it worth compiling 2.3.4 on your machine to double-check that > you *can* reproduce the bug (since using a newer Qt version)? What Qt > version was 2.3.4 compiled with? I personally would support putting the > added lines in preprocessor guards but I don't know how other LyX > developers feel about that. Here is the flavor of preprocessor checking > that I think is easiest: > I have compiled master with Qt 5.15.0 on my machine, resulting in the bug occuring. Compiling master with Qt 5.9.9 (I could not download 5.10.1, to match what is used in the LyX version I have tried above, for some reason) didn't produce the bug. > > #if (QT_VERSION < QT_VERSION_CHECK(5, 0, 0)) >// code here... > #endif I see and understand now that workarounds for Qt bugs are not easy to handle. Also I can't predict when or if the bug will be fixed in Qt. So what is attached is what I can provide for now, maybe other developers have more experience or better ideas? Btw do we have some kind of tracker for this kind of issues? Eugene MouseMoveEvent.diff Description: Binary data -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Text selection does not work as expected
On Sat, Jul 04, 2020 at 12:27:04PM +0200, Yu Jin wrote: > Am Fr., 3. Juli 2020 um 17:09 Uhr schrieb Yu Jin : > > > Am Fr., 3. Juli 2020 um 11:12 Uhr schrieb Daniel : > > > >> On 2/7/20 16:27, Jean-Marc Lasgouttes wrote: > >> > Le 02/07/2020 à 15:43, Daniel a écrit : > >> >> When I double (triple) click on text, instead of the word (line), only > >> >> the word (line) left to the cursor is selected. I don't remember > >> >> seeing this before. Can someone reproduce? > >> > > >> > I cannot reproduce. Master or 2.3? > >> > > >> > JMarc > >> > >> I see. So, here is some more info and testing: > >> > >> LyX Version 2.3.5.2 > >> (25 June 2020) > >> Qt Version (run-time): 5.12.5 > >> Qt Version (compile-time): 5.12.5 > >> > >> Windows 10 1909. > >> > >> I noticed that the selection works fine when I use an external mouse > >> instead of the intrernal trackpad (Surface Pro). The problem is > >> restricted to LyX's work area. No other program I tested exhibits the > >> problem, including Scribus (Qt 5.9.7). > >> > >> I attached a screen recording just to make sure we talk about the same > >> thing. (Unfortunately, the mouse cursor and clicks are not recorded.) > >> > > > > I can reproduce on my notebook, also with master and Qt 5.15.0. I will > > investigate. > > > > Looks like GuiWorkArea::mouseMoveEvent(QMouseEvent*) is called falsely, I > get status messages like these when I do a double tap on the touchpad: > > Cursor.cpp (781): Cursor::dispatch: cmd: action: 206 [] arg: '' x: 102 y: > 69 > > insets\InsetText.cpp (293): InsetText::doDispatch(): cmd: action: 206 [] > arg: '' x: 102 y: 69 > Text3.cpp (631): Text::dispatch: cmd: action: 206 [] arg: '' x: 102 y: 69 > Cursor.cpp (781): Cursor::dispatch: cmd: action: 208 [] arg: '' x: 102 y: > 69 > > insets\InsetText.cpp (293): InsetText::doDispatch(): cmd: action: 208 [] > arg: '' x: 102 y: 69 > Text3.cpp (631): Text::dispatch: cmd: action: 208 [] arg: '' x: 102 y: 69 > Cursor.cpp (781): Cursor::dispatch: cmd: action: 209 [] arg: '' x: 102 y: > 69 > > insets\InsetText.cpp (293): InsetText::doDispatch(): cmd: action: 209 [] > arg: '' x: 102 y: 69 > Text3.cpp (631): Text::dispatch: cmd: action: 209 [] arg: '' x: 102 y: 69 > Cursor.cpp (781): Cursor::dispatch: cmd: action: 207 [] arg: '' x: 102 y: > 69 > > insets\InsetText.cpp (293): InsetText::doDispatch(): cmd: action: 207 [] > arg: '' x: 102 y: 69 > Text3.cpp (631): Text::dispatch: cmd: action: 207 [] arg: '' x: 102 y: 69 > Cursor.cpp (781): Cursor::dispatch: cmd: action: 208 [] arg: '' x: 102 y: > 69 > > insets\InsetText.cpp (293): InsetText::doDispatch(): cmd: action: 208 [] > arg: '' x: 102 y: 69 > Text3.cpp (631): Text::dispatch: cmd: action: 208 [] arg: '' x: 102 y: 69 > > the position of cursor does not change, but the MouseMoveEvent is called > anyway, which is "action: 207" above. I don't think it's LyX's fault though. > Well there are many possible solutions, I went for the easiest one, patch > attached, is it ok for commit? Thanks for looking into this, Eugene. Just to make sure I understand, you think this is a Qt bug, right? I don't know anything about this stuff, so hopefully a different LyX developer takes a look. Don't spend time making a new patch based on my comments (wait for another LyX dev first), but if you do get a +1 to commit, it would be nice to mark exactly what parts of the code are in there because of a workaround for a Qt bug, and how to test that the bug is no longer relevant (e.g., "to test if this workaround is still needed, try to select a word by double-clicking in LyX on Windows 10. For more information, see the following ML thread..."). Taking a step back, what changed that triggered this bug? I'm guessing that it is because we compiled LyX 2.3.5 with a newer Qt version. Is that correct? Is it worth compiling 2.3.4 on your machine to double-check that you *can* reproduce the bug (since using a newer Qt version)? What Qt version was 2.3.4 compiled with? I personally would support putting the added lines in preprocessor guards but I don't know how other LyX developers feel about that. Here is the flavor of preprocessor checking that I think is easiest: #if (QT_VERSION < QT_VERSION_CHECK(5, 0, 0)) // code here... #endif Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Text selection does not work as expected
Am Fr., 3. Juli 2020 um 17:09 Uhr schrieb Yu Jin : > Am Fr., 3. Juli 2020 um 11:12 Uhr schrieb Daniel : > >> On 2/7/20 16:27, Jean-Marc Lasgouttes wrote: >> > Le 02/07/2020 à 15:43, Daniel a écrit : >> >> When I double (triple) click on text, instead of the word (line), only >> >> the word (line) left to the cursor is selected. I don't remember >> >> seeing this before. Can someone reproduce? >> > >> > I cannot reproduce. Master or 2.3? >> > >> > JMarc >> >> I see. So, here is some more info and testing: >> >> LyX Version 2.3.5.2 >> (25 June 2020) >> Qt Version (run-time): 5.12.5 >> Qt Version (compile-time): 5.12.5 >> >> Windows 10 1909. >> >> I noticed that the selection works fine when I use an external mouse >> instead of the intrernal trackpad (Surface Pro). The problem is >> restricted to LyX's work area. No other program I tested exhibits the >> problem, including Scribus (Qt 5.9.7). >> >> I attached a screen recording just to make sure we talk about the same >> thing. (Unfortunately, the mouse cursor and clicks are not recorded.) >> > > I can reproduce on my notebook, also with master and Qt 5.15.0. I will > investigate. > Looks like GuiWorkArea::mouseMoveEvent(QMouseEvent*) is called falsely, I get status messages like these when I do a double tap on the touchpad: Cursor.cpp (781): Cursor::dispatch: cmd: action: 206 [] arg: '' x: 102 y: 69 insets\InsetText.cpp (293): InsetText::doDispatch(): cmd: action: 206 [] arg: '' x: 102 y: 69 Text3.cpp (631): Text::dispatch: cmd: action: 206 [] arg: '' x: 102 y: 69 Cursor.cpp (781): Cursor::dispatch: cmd: action: 208 [] arg: '' x: 102 y: 69 insets\InsetText.cpp (293): InsetText::doDispatch(): cmd: action: 208 [] arg: '' x: 102 y: 69 Text3.cpp (631): Text::dispatch: cmd: action: 208 [] arg: '' x: 102 y: 69 Cursor.cpp (781): Cursor::dispatch: cmd: action: 209 [] arg: '' x: 102 y: 69 insets\InsetText.cpp (293): InsetText::doDispatch(): cmd: action: 209 [] arg: '' x: 102 y: 69 Text3.cpp (631): Text::dispatch: cmd: action: 209 [] arg: '' x: 102 y: 69 Cursor.cpp (781): Cursor::dispatch: cmd: action: 207 [] arg: '' x: 102 y: 69 insets\InsetText.cpp (293): InsetText::doDispatch(): cmd: action: 207 [] arg: '' x: 102 y: 69 Text3.cpp (631): Text::dispatch: cmd: action: 207 [] arg: '' x: 102 y: 69 Cursor.cpp (781): Cursor::dispatch: cmd: action: 208 [] arg: '' x: 102 y: 69 insets\InsetText.cpp (293): InsetText::doDispatch(): cmd: action: 208 [] arg: '' x: 102 y: 69 Text3.cpp (631): Text::dispatch: cmd: action: 208 [] arg: '' x: 102 y: 69 the position of cursor does not change, but the MouseMoveEvent is called anyway, which is "action: 207" above. I don't think it's LyX's fault though. Well there are many possible solutions, I went for the easiest one, patch attached, is it ok for commit? > Eugene > mouseMoveEvent.diff Description: Binary data -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Text selection does not work as expected
Am Fr., 3. Juli 2020 um 11:12 Uhr schrieb Daniel : > On 2/7/20 16:27, Jean-Marc Lasgouttes wrote: > > Le 02/07/2020 à 15:43, Daniel a écrit : > >> When I double (triple) click on text, instead of the word (line), only > >> the word (line) left to the cursor is selected. I don't remember > >> seeing this before. Can someone reproduce? > > > > I cannot reproduce. Master or 2.3? > > > > JMarc > > I see. So, here is some more info and testing: > > LyX Version 2.3.5.2 > (25 June 2020) > Qt Version (run-time): 5.12.5 > Qt Version (compile-time): 5.12.5 > > Windows 10 1909. > > I noticed that the selection works fine when I use an external mouse > instead of the intrernal trackpad (Surface Pro). The problem is > restricted to LyX's work area. No other program I tested exhibits the > problem, including Scribus (Qt 5.9.7). > > I attached a screen recording just to make sure we talk about the same > thing. (Unfortunately, the mouse cursor and clicks are not recorded.) > I can reproduce on my notebook, also with master and Qt 5.15.0. I will investigate. Eugene -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Text selection does not work as expected
On 2/7/20 16:27, Jean-Marc Lasgouttes wrote: Le 02/07/2020 à 15:43, Daniel a écrit : When I double (triple) click on text, instead of the word (line), only the word (line) left to the cursor is selected. I don't remember seeing this before. Can someone reproduce? I cannot reproduce. Master or 2.3? JMarc I see. So, here is some more info and testing: LyX Version 2.3.5.2 (25 June 2020) Qt Version (run-time): 5.12.5 Qt Version (compile-time): 5.12.5 Windows 10 1909. I noticed that the selection works fine when I use an external mouse instead of the intrernal trackpad (Surface Pro). The problem is restricted to LyX's work area. No other program I tested exhibits the problem, including Scribus (Qt 5.9.7). I attached a screen recording just to make sure we talk about the same thing. (Unfortunately, the mouse cursor and clicks are not recorded.) Daniel 2020-07-03_10-57-25.mp4 Description: video/mp4 -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Text selection does not work as expected
Le 02/07/2020 à 15:43, Daniel a écrit : When I double (triple) click on text, instead of the word (line), only the word (line) left to the cursor is selected. I don't remember seeing this before. Can someone reproduce? I cannot reproduce. Master or 2.3? JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
