Re: Weird Selection Bug

[Jean-Marc Lasgouttes]

Le 06/09/2016 à 10:33, Helge Hafting a écrit :



Den 05. sep. 2016 14:59, skrev Jean-Marc Lasgouttes:

Le 05/09/2016 à 14:56, Helge Hafting a écrit :

After some git trouble*, I compiled & tested. Selection still works as
expected with linux & qt5. Selection still goes from the text cursor
position to the mouse click position - not from the position of "the
previous mouseclick" to the current mouseclick.


So it is OK now, right?

Yes, it is ok now. For me, it was ok before too - I see no change. I can
only guess that the described problem depends on an OS or a library
version that I never used.


OK, thnaks.

JMarc

Re: Weird Selection Bug

[Helge Hafting]

Den 05. sep. 2016 14:59, skrev Jean-Marc Lasgouttes:

Le 05/09/2016 à 14:56, Helge Hafting a écrit :

After some git trouble*, I compiled & tested. Selection still works as
expected with linux & qt5. Selection still goes from the text cursor
position to the mouse click position - not from the position of "the
previous mouseclick" to the current mouseclick.


So it is OK now, right?
Yes, it is ok now. For me, it was ok before too - I see no change. I can 
only guess that the described problem depends on an OS or a library 
version that I never used.


Helge Hafting

Re: Weird Selection Bug

[Jean-Marc Lasgouttes]

Le 05/09/2016 à 14:56, Helge Hafting a écrit :

After some git trouble*, I compiled & tested. Selection still works as
expected with linux & qt5. Selection still goes from the text cursor
position to the mouse click position - not from the position of "the
previous mouseclick" to the current mouseclick.


So it is OK now, right?

JMarc

Re: Weird Selection Bug

[Helge Hafting]

Den 31. aug. 2016 16:33, skrev Jean-Marc Lasgouttes:

Le 31/08/2016 à 11:51, Helge Hafting a écrit :

Den 23. aug. 2016 12:14, skrev Jean-Marc Lasgouttes:

Are you sure? I do not see that.

I now look at a light blue highlighted selection that goes from the
second line to the third. The first line mentioned is not an endpoint -
it is forgotten by LyX, and usually by me too.


In the meantime, the bug has been fixed in branch and master. If you 
have access to that, please confirm that it works as it should.



After some git trouble*, I compiled & tested. Selection still works as 
expected with linux & qt5. Selection still goes from the text cursor 
position to the mouse click position - not from the position of "the 
previous mouseclick" to the current mouseclick.




* I had an old clone of LyX, where I once tested some patches. "git 
pull" then refused, telling me I needed to "commit my changes" first. 
But I did not want to commit random experiments into LyX, so I did 
obviously not commit anything. Various variants of "git --reset" and 
"git merge --abort" did not persuade git to _drop all changes and just 
get me the current master_.  So I gave up and deleted the entire tree 
and cloned from scratch. A big waste of bandwith, but faster than 
figuring out  the right git command. :-(


Helge Hafting

Re: Weird Selection Bug

[Jean-Marc Lasgouttes]

Le 31/08/2016 à 11:51, Helge Hafting a écrit :

Den 23. aug. 2016 12:14, skrev Jean-Marc Lasgouttes:

Are you sure? I do not see that.

I now look at a light blue highlighted selection that goes from the
second line to the third. The first line mentioned is not an endpoint -
it is forgotten by LyX, and usually by me too.


In the meantime, the bug has been fixed in branch and master. If you 
have access to that, please confirm that it works as it should.


JMarc

Re: Weird Selection Bug

[Helge Hafting]

Den 23. aug. 2016 12:14, skrev Jean-Marc Lasgouttes:

Le 23/08/2016 à 11:25, Helge Hafting a écrit :

No!  Fortunately, LyX 2.2 on linux behave the way I expect: When I
shift-click somewhere, I get a selection from the current text cursor
point to the shift-click point.  No matter how the text cursor got 
there.


Are you sure? I do not see that.

Could it be an OS specific or library version specific issue then?

I use LyX 2.2.1, as distributed by arch linux. (64-bit.) Keyboard moves 
the selection start. (QT 5.7)
I also tested LyX 2.1.2 as distributed by debian. Keyboard still moves 
the selection start. (QT 4.8.6)


When I select, I usually drag with the mouse or use shift+arrow keys. So 
there may have been versions with strange behaviours I never noticed.  
But in the two versions above, I get what I expect:

1. I type 10 lines of garbage text
2. click on one particular line
3. arrow down (or up or sideways) to some second line
4. shift+click on a third line
I now look at a light blue highlighted selection that goes from the 
second line to the third. The first line mentioned is not an endpoint - 
it is forgotten by LyX, and usually by me too.


Helge Hafting

Re: Weird Selection Bug

[Jean-Marc Lasgouttes]

Le 23/08/2016 à 18:27, Richard Heck a écrit :

If it works, I can backport it, of course.


Works here. Fine to backport.


Done, thanks.

JMarc

Re: Weird Selection Bug

[Richard Heck]

On 08/23/2016 09:54 AM, Jean-Marc Lasgouttes wrote:
> Le 23/08/2016 à 12:23, Jean-Marc Lasgouttes a écrit :
>> Le 23/08/2016 à 12:14, Jean-Marc Lasgouttes a écrit :
>>> This is indeed a bug. The selection anchor is not reset when moving the
>>> cursor with the keyboard. It should be reset just before honoring the
>>> Shift-Click, but I am not sure how to do that.
>>
>> I think it is fixed in master now. Please test.
>
> I it works, I can backport it, of course.

Works here. Fine to backport.

Richard

Re: Weird Selection Bug

[Jean-Marc Lasgouttes]

Le 23/08/2016 à 12:23, Jean-Marc Lasgouttes a écrit :

Le 23/08/2016 à 12:14, Jean-Marc Lasgouttes a écrit :

This is indeed a bug. The selection anchor is not reset when moving the
cursor with the keyboard. It should be reset just before honoring the
Shift-Click, but I am not sure how to do that.


I think it is fixed in master now. Please test.


I it works, I can backport it, of course.

JMarc

Re: Weird Selection Bug

[Jean-Marc Lasgouttes]

Le 23/08/2016 à 12:14, Jean-Marc Lasgouttes a écrit :

This is indeed a bug. The selection anchor is not reset when moving the
cursor with the keyboard. It should be reset just before honoring the
Shift-Click, but I am not sure how to do that.


I think it is fixed in master now. Please test.

JMarc

Re: Weird Selection Bug

[Jean-Marc Lasgouttes]

Le 23/08/2016 à 11:25, Helge Hafting a écrit :

No!  Fortunately, LyX 2.2 on linux behave the way I expect: When I
shift-click somewhere, I get a selection from the current text cursor
point to the shift-click point.  No matter how the text cursor got there.


Are you sure? I do not see that.


Seriously, people move the cursor around by mouse and by keyboard. When
they need to select, they surely don't consider *how* the cursor was
moved?


This is indeed a bug. The selection anchor is not reset when moving the 
cursor with the keyboard. It should be reset just before honoring the 
Shift-Click, but I am not sure how to do that.


JMarc

Re: Weird Selection Bug

[Helge Hafting]

Den 02. aug. 2016 08:11, skrev Kornel Benko:

Am Dienstag, 2. August 2016 um 01:24:38, schrieb Scott Kostyshak 


On Mon, Aug 01, 2016 at 11:50:52AM -0400, Richard Heck wrote:

Click somewhere with the mouse. Now move the cursor with the keyboard.
Then shift-click to select. The selection will begin (or end) where you
had previously clicked with the mouse, not where you had moved the
cursor with the keyboard.

I can reproduce with Qt 4 and Qt 5 and back to LyX 2.1.0.

Scott

I can reproduce too, but I think, it is the correct behaviour. Using the 
up/down keys which
resets the selection start does not feel right IMHO.


No!  Fortunately, LyX 2.2 on linux behave the way I expect: When I 
shift-click somewhere, I get a selection from the current text cursor 
point to the shift-click point.  No matter how the text cursor got there.


Seriously, people move the cursor around by mouse and by keyboard. When 
they need to select, they surely don't consider *how* the cursor was 
moved? LyX place no marker at "the last click location", having a 
selection go from there seems weird. Also consider that the "last click" 
may be far away - I can type for many minutes without using the mouse at 
all. My hands are at the keyboard when I write text, so cursor movements 
are mostly done with arrow keys and pageup/down. Some people uses the 
mouse more - but that is individual, and depending on whether you type 
new stuff or just move around touching up.


Now, the mouse is fine for making selections. but if they cursor already 
is correctly placed at one end, I see no need to click the same location 
so the "location of the last click" also is in the same place. The 
location of the last click may have scrolled off screen, it may have 
been cut, erased or moved around . . .


Other GUI sw (thunderbird etc.) that moves the cursor when clicking, 
also uses the cursor position regardless of how the cursor got there. 
xterm is the only I have seen that cares about "the location of last 
click", but xterm does not position the cursor upon mouse clicks and so 
is very different.


Helge Hafting

Re: Weird Selection Bug

[Guillaume Munch]

Le 02/08/2016 à 07:39, Stephan Witt a écrit :


OTOH starting the selection at the current cursor position after moving the 
input focus
with keyboard is the way it works on Mac - with LyX and with other text editors.



+1, not just on Mac

Re: Weird Selection Bug

[Stephan Witt]

Am 02.08.2016 um 08:11 schrieb Kornel Benko :
> 
> Am Dienstag, 2. August 2016 um 01:24:38, schrieb Scott Kostyshak 
> 
>> On Mon, Aug 01, 2016 at 11:50:52AM -0400, Richard Heck wrote:
>>> Click somewhere with the mouse. Now move the cursor with the keyboard.
>>> Then shift-click to select. The selection will begin (or end) where you
>>> had previously clicked with the mouse, not where you had moved the
>>> cursor with the keyboard.
>> 
>> I can reproduce with Qt 4 and Qt 5 and back to LyX 2.1.0.
>> 
>> Scott
> 
> I can reproduce too, but I think, it is the correct behaviour. Using the 
> up/down keys which
> resets the selection start does not feel right IMHO.

OTOH starting the selection at the current cursor position after moving the 
input focus
with keyboard is the way it works on Mac - with LyX and with other text editors.

Stephan

Re: Weird Selection Bug

[Kornel Benko]

Am Dienstag, 2. August 2016 um 01:24:38, schrieb Scott Kostyshak 

> On Mon, Aug 01, 2016 at 11:50:52AM -0400, Richard Heck wrote:
> > Click somewhere with the mouse. Now move the cursor with the keyboard.
> > Then shift-click to select. The selection will begin (or end) where you
> > had previously clicked with the mouse, not where you had moved the
> > cursor with the keyboard.
> 
> I can reproduce with Qt 4 and Qt 5 and back to LyX 2.1.0.
> 
> Scott

I can reproduce too, but I think, it is the correct behaviour. Using the 
up/down keys which
resets the selection start does not feel right IMHO.

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: Weird Selection Bug

[Scott Kostyshak]

On Mon, Aug 01, 2016 at 11:50:52AM -0400, Richard Heck wrote:
> Click somewhere with the mouse. Now move the cursor with the keyboard.
> Then shift-click to select. The selection will begin (or end) where you
> had previously clicked with the mouse, not where you had moved the
> cursor with the keyboard.

I can reproduce with Qt 4 and Qt 5 and back to LyX 2.1.0.

Scott


signature.asc
Description: PGP signature