Re: scrunched radio buttons on message pane

[Jean-Marc Lasgouttes]

Le 17 juin 2016 19:40:55 GMT+02:00, Scott Kostyshak  a écrit 
: 
>> I do not remember what Uwe proposed, but we might want to get rid of
>the
>> radio buttons and instead add a 'Select all' and a 'unselect all'
>buttons
>> disposed vertically so that the UI is
>> 
>> [X] checkbox1   [select all]
>> 
>>  (mesage list on the right)
>> [X] checkbox1   [unselect all]
>> 
>> JMarc
>
>Would the message list then use checkboxes also, or would we keep the
>yes/no toggle?


I would that this decision is independent from the rest. Check boxes might be 
better indeed.

JMarc 

Re: scrunched radio buttons on message pane

[Scott Kostyshak]

On Fri, Jun 17, 2016 at 06:00:30PM +0200, Jean-Marc Lasgouttes wrote:
> Le 17/06/2016 à 17:50, Pavel Sanda a écrit :
> > I am sorry to react so late, but you this patch ruins long term effort to
> > make this pane as thin as possible when needed. I got that trimmed radio
> > buttons are not nice (I dont see them on my setup, but OK), but the effort
> > to make both tab names to appear fully make the pane big and we(/me?)
> > fought against that for a long time. There is even bug in trac about that
> > and long term flow of semi-successful patches to solve it. Recently
> > IIRC Uwe figured out way how to solve it in more elegant way.
> 
> I do not remember what Uwe proposed, but we might want to get rid of the
> radio buttons and instead add a 'Select all' and a 'unselect all' buttons
> disposed vertically so that the UI is
> 
> [X] checkbox1   [select all]
> 
>  (mesage list on the right)
> [X] checkbox1   [unselect all]
> 
> JMarc

Would the message list then use checkboxes also, or would we keep the
yes/no toggle?

Scott


signature.asc
Description: PGP signature

Re: scrunched radio buttons on message pane

[Scott Kostyshak]

On Fri, Jun 17, 2016 at 08:50:53AM -0700, Pavel Sanda wrote:
> Scott Kostyshak wrote:
> > The patch solves two issues:
> > 
> > 1. gets rid of the issue with the radio buttons that I posted about.
> > 
> > 2. makes room for both the "Outline" and "Settings" tab names to show,
> > so there is no clipping and the arrows are not needed (did other people
> > see this issue as well or just me?).
> ...
> > The disadvantage of the patch is that the minimum size required is now
> > larger than before. Perhaps some people not as bothered as I was by the
> 
> I am sorry to react so late, but you this patch ruins long term effort to
> make this pane as thin as possible when needed. I got that trimmed radio
> buttons are not nice (I dont see them on my setup, but OK), but the effort
> to make both tab names to appear fully make the pane big and we(/me?)
> fought against that for a long time. There is even bug in trac about that
> and long term flow of semi-successful patches to solve it. Recently
> IIRC Uwe figured out way how to solve it in more elegant way.
> 
> Now the major point of this panel is to look at its output and not its
> preference setting and, to me, the impossibility to shrink the pane
> size to something decent while debugging sucks much more than the cosmetic
> issues described in its preferences.
> I would quite prefer that if you don't touch the minimum room for outline
> and output tabs. If you need to fix those radio button for fex pixels that
> should be fine though.

Thanks for the detailed explanation. I understand why you are against
the increase so I won't proceed.

Scott


signature.asc
Description: PGP signature

Re: scrunched radio buttons on message pane

[Jean-Marc Lasgouttes]

Le 17/06/2016 à 17:50, Pavel Sanda a écrit :

I am sorry to react so late, but you this patch ruins long term effort to
make this pane as thin as possible when needed. I got that trimmed radio
buttons are not nice (I dont see them on my setup, but OK), but the effort
to make both tab names to appear fully make the pane big and we(/me?)
fought against that for a long time. There is even bug in trac about that
and long term flow of semi-successful patches to solve it. Recently
IIRC Uwe figured out way how to solve it in more elegant way.


I do not remember what Uwe proposed, but we might want to get rid of the 
radio buttons and instead add a 'Select all' and a 'unselect all' 
buttons disposed vertically so that the UI is


[X] checkbox1   [select all]

 (mesage list on the right)
[X] checkbox1   [unselect all]

JMarc

Re: scrunched radio buttons on message pane

[Pavel Sanda]

Scott Kostyshak wrote:
> The patch solves two issues:
> 
> 1. gets rid of the issue with the radio buttons that I posted about.
> 
> 2. makes room for both the "Outline" and "Settings" tab names to show,
> so there is no clipping and the arrows are not needed (did other people
> see this issue as well or just me?).
...
> The disadvantage of the patch is that the minimum size required is now
> larger than before. Perhaps some people not as bothered as I was by the

I am sorry to react so late, but you this patch ruins long term effort to
make this pane as thin as possible when needed. I got that trimmed radio
buttons are not nice (I dont see them on my setup, but OK), but the effort
to make both tab names to appear fully make the pane big and we(/me?)
fought against that for a long time. There is even bug in trac about that
and long term flow of semi-successful patches to solve it. Recently
IIRC Uwe figured out way how to solve it in more elegant way.

Now the major point of this panel is to look at its output and not its
preference setting and, to me, the impossibility to shrink the pane
size to something decent while debugging sucks much more than the cosmetic
issues described in its preferences.
I would quite prefer that if you don't touch the minimum room for outline
and output tabs. If you need to fix those radio button for fex pixels that
should be fine though.

Pavel

Re: scrunched radio buttons on message pane

[Scott Kostyshak]

On Tue, Jun 14, 2016 at 09:39:25PM -0400, Scott Kostyshak wrote:
> On Tue, Jun 14, 2016 at 06:19:27PM +, Paul A. Rubin wrote:
> > Scott Kostyshak  lyx.org> writes:
> > 
> > > 
> > > Does anyone else see that the radio buttons are cut-off on the message
> > > pane?
> > > 
> > 
> > FWIW, they're find with LyX 2.2.0 /Qt 4.8.6 on Linux Mint Rebecca.
> > 
> > Paul
> 
> I forgot to mention: when testing you should try to make the height of
> the messages pane as small as possible. Does it allow you to go "too"
> small?
> 
> Attached is a patch. I've tested docking it, undocking it, and resizing
> it in weird ways. I link below to before/after screenshots with Qt 4 and
> Qt 5 and two different systems (both Ubuntu though):
> 
> https://www.dropbox.com/s/rysu6whqg8h87z5/qt4_15_after.png?dl=0
> https://www.dropbox.com/s/bambj1hlkxwdhrm/qt4_15_before.png?dl=0
> https://www.dropbox.com/s/xtiryrxhoq7ht02/qt5_13_after.png?dl=0
> https://www.dropbox.com/s/sxjwrno7xe347a5/qt5_13_before.png?dl=0
> https://www.dropbox.com/s/o85jugavc62fk7l/qt5_15_after.png?dl=0
> https://www.dropbox.com/s/7zfbgfatvvssh55/qt5_15_before.png?dl=0
> 
> I've tested with Arabic, French, and German.
> 
> The patch solves two issues:
> 
> 1. gets rid of the issue with the radio buttons that I posted about.
> 
> 2. makes room for both the "Outline" and "Settings" tab names to show,
> so there is no clipping and the arrows are not needed (did other people
> see this issue as well or just me?).
> 
> The second issue that is solved is partly by luck, and that is good.
> That is to say, the vertical size is not determined based on the tab
> names. Thus the bad news is that the little arrows that annoy me could
> come back (i.e. this change is not robust). The good news is that we do
> not have to be worried that there are translations with long names for
> the tab names that would make the vertical size extremely large.
> 
> The disadvantage of the patch is that the minimum size required is now
> larger than before. Perhaps some people not as bothered as I was by the
> two issues I mention above prefer to have the smaller vertical size. I
> attempted to make it so that the widget containing the list of debug
> levels (named "outTE") was not important in determining the size (there
> is a scrollbar anyway), but I failed to figure this out. I did my
> testing on a 13-inch screen and the increase did not bother me at all so
> I don't expect others to mind it, but I bring this up just in case.
>  
> As for the patch itself, I don't know much about ui files so I am
> proposing it mostly based on the "it works for me" principle. From what
> I understand, many editors of the ui files before me have used the same
> principle. My approach was to remove some numbers that seemed arbitrary
> to me.
> 
> Any objection?

Stefan and Uwe, if you feel like testing the patch on win/mac, let me
know what you think. It is supposed to be a minor patch, so if you are
busy don't worry about it. I am just always hesitant with cross-platform
differences of Qt widgets.

Scott

> Scott

> From 3c19a922d384b6544434bfdd74a4f44538853326 Mon Sep 17 00:00:00 2001
> From: Scott Kostyshak 
> Date: Tue, 14 Jun 2016 16:42:25 -0400
> Subject: [PATCH] Fix two UI issues in the messages pane
> 
> 1. sets the correct height for the radio buttons to avoid clipping
> 
> 2. makes room for both the "Outline" and "Settings" tab names to
> show, so there is no clipping and the arrows are not needed.
> 
> The second issue above is solved partly by luck, and that is good.
> That is to say, the vertical size is not determined based on the tab
> names. Thus the bad news is that the little arrows could come back
> when we make future changes to this ui file (i.e. this change is not
> robust). The good news is that we do not have to be worried that
> there are translations with long names for the tab names that would
> make the vertical size of the widget extremely large.
> 
> The disadvantage of this patch is that the minimum size required by
> the messages pane is now larger than before. Perhaps some people not
> as bothered as I was by the two issues I mention above prefer to
> have the smaller vertical size. I attempted to make it so that the
> widget containing the list of debug levels (named "outTE") was not
> important in determining the size (there is a scrollbar anyway), but
> I failed to figure this out.
> ---
>  src/frontends/qt4/ui/ProgressViewUi.ui | 54 
> --
>  1 file changed, 54 deletions(-)
> 
> diff --git a/src/frontends/qt4/ui/ProgressViewUi.ui 
> b/src/frontends/qt4/ui/ProgressViewUi.ui
> index 1ae1c6d..356d2ad 100644
> --- a/src/frontends/qt4/ui/ProgressViewUi.ui
> +++ b/src/frontends/qt4/ui/ProgressViewUi.ui
> @@ -4,40 +4,6 @@
>   
>   ProgressViewUi
>   
> -  
> -   
> -0
> -0
> -543
> -298
> -   
> -  
> -  
> -   
> -7
> -13
> -0
> -0
> -   
> -  
> -  
> -   
> -0
> -0
> -   
> -  
> -  

Re: scrunched radio buttons on message pane

[Scott Kostyshak]

On Thu, Jun 16, 2016 at 07:07:07PM +, Paul A. Rubin wrote:
> Scott Kostyshak  lyx.org> writes:
> 
> 
> > > Ah,yes. I have to scrunch the window to its absolute minimum height, at
> > > which point the tops and bottoms of the radio button circles are clipped.
> > > Even one mouse fart bigger than minimum and the circles are intact.
> > 
> > OK so it is the same then.
> > 
> > Scott
> > 
> > P.S. I just googled "mouse fart" to see if that is an original creation
> > of yours. I like it.
> > 
> 
> Couldn't find the definition on Wikiipedia, though. It's the average
> distance traveled by an average size mouse propelled by an average burst of
> digestive gas. Statisticians, of course, argue endlessly whether it should
> be based on arithmetic mean, median or geometric mean.

Decades later when "mouse fart" has made it into the Oxford dictionary
and has been translated into 50 different languages, the source will
point back to lyx-devel. You heard it here first, folks.

Scott


signature.asc
Description: PGP signature

Re: scrunched radio buttons on message pane

[Paul A . Rubin]

Scott Kostyshak  lyx.org> writes:


> > Ah,yes. I have to scrunch the window to its absolute minimum height, at
> > which point the tops and bottoms of the radio button circles are clipped.
> > Even one mouse fart bigger than minimum and the circles are intact.
> 
> OK so it is the same then.
> 
> Scott
> 
> P.S. I just googled "mouse fart" to see if that is an original creation
> of yours. I like it.
> 

Couldn't find the definition on Wikiipedia, though. It's the average
distance traveled by an average size mouse propelled by an average burst of
digestive gas. Statisticians, of course, argue endlessly whether it should
be based on arithmetic mean, median or geometric mean.

Re: scrunched radio buttons on message pane

[Scott Kostyshak]

On Wed, Jun 15, 2016 at 08:13:54PM +, Paul A. Rubin wrote:
> Scott Kostyshak  lyx.org> writes:
> 
> > 
> > On Tue, Jun 14, 2016 at 06:19:27PM +, Paul A. Rubin wrote:
> > > Scott Kostyshak  lyx.org> writes:
> > > 
> > > > 
> > > > Does anyone else see that the radio buttons are cut-off on the message
> > > > pane?
> > > > 
> > > 
> > > FWIW, they're find with LyX 2.2.0 /Qt 4.8.6 on Linux Mint Rebecca.
> > > 
> > > Paul
> > 
> > I forgot to mention: when testing you should try to make the height of
> > the messages pane as small as possible. Does it allow you to go "too"
> > small?
> > 
> 
> Ah,yes. I have to scrunch the window to its absolute minimum height, at
> which point the tops and bottoms of the radio button circles are clipped.
> Even one mouse fart bigger than minimum and the circles are intact.

OK so it is the same then.

Scott

P.S. I just googled "mouse fart" to see if that is an original creation
of yours. I like it.


signature.asc
Description: PGP signature

Re: scrunched radio buttons on message pane

[Paul A . Rubin]

Scott Kostyshak  lyx.org> writes:

> 
> On Tue, Jun 14, 2016 at 06:19:27PM +, Paul A. Rubin wrote:
> > Scott Kostyshak  lyx.org> writes:
> > 
> > > 
> > > Does anyone else see that the radio buttons are cut-off on the message
> > > pane?
> > > 
> > 
> > FWIW, they're find with LyX 2.2.0 /Qt 4.8.6 on Linux Mint Rebecca.
> > 
> > Paul
> 
> I forgot to mention: when testing you should try to make the height of
> the messages pane as small as possible. Does it allow you to go "too"
> small?
> 

Ah,yes. I have to scrunch the window to its absolute minimum height, at
which point the tops and bottoms of the radio button circles are clipped.
Even one mouse fart bigger than minimum and the circles are intact.

Paul

Re: Basic module reloaded (Was: scrunched radio buttons on message pane)

[Scott Kostyshak]

On Wed, Jun 15, 2016 at 01:39:01PM +0100, Jean-Pierre Chrétien wrote:
> Le 15/06/2016 09:13, Scott Kostyshak a écrit :
> > On Wed, Jun 15, 2016 at 09:48:03AM +0100, Jean-Pierre Chrétien wrote:
> 
> > > I've seen this once with 2.2.0, but I can't reproduce, maybe I left open 
> > > an
> > > instance of 2.1.5, I see now
> > > 
> > > ../TextClass.cpp (317): Reading module file: [layouts/basic.module]
> > > ../TextClass.cpp (330): Finished reading module file: 
> > > [layouts/basic.module]
> > > 
> > > when I select LyX initialisation tracking.
> > 
> > I'm not sure about the above. If you can find a way to reproduce it, it
> > would be good to know.
> 
> Can't reproduce now even with 2.1.5.
> But I get these lines
> 
> BufferParams.cpp (2220): setBaseClass: article
> ../TextClass.cpp (317): Reading module file: [layouts/basic.module]
> ../TextClass.cpp (330): Finished reading module file: [layouts/basic.module]
> 
> evety time I open the Document->Settings menu, and apparently, every time
> there is an automatic backup, both with 2.1.5 ans 2.2.0.
> 
> What is specific to this module ?
> 
> Recipe:
> * open LyX
> * select "Texclass file reading" in the message pane parameters
> * Open a new file
> * Select Document->Settings
> 
> Messages are both in the terminal and in the Output window of the message 
> pane.

I see. I can reproduce when checking the "Texclass file reading". I
think these messages are normal, but I don't know much about this stuff.
I'm guessing basic.module is loaded because it is the only one that is
being used. Maybe it is a special module that doesn't appear it the
modules in document settings.

Scott


signature.asc
Description: PGP signature

Re: Basic module reloaded (Was: scrunched radio buttons on message pane)

[Richard Heck]

On 06/15/2016 01:39 PM, Jean-Pierre Chrétien wrote:

Le 15/06/2016 09:13, Scott Kostyshak a écrit :

On Wed, Jun 15, 2016 at 09:48:03AM +0100, Jean-Pierre Chrétien wrote:


I've seen this once with 2.2.0, but I can't reproduce, maybe I left 
open an

instance of 2.1.5, I see now

../TextClass.cpp (317): Reading module file: [layouts/basic.module]
../TextClass.cpp (330): Finished reading module file: 
[layouts/basic.module]


when I select LyX initialisation tracking.


I'm not sure about the above. If you can find a way to reproduce it, it
would be good to know.


Can't reproduce now even with 2.1.5.
But I get these lines

BufferParams.cpp (2220): setBaseClass: article
../TextClass.cpp (317): Reading module file: [layouts/basic.module]
../TextClass.cpp (330): Finished reading module file: 
[layouts/basic.module]


evety time I open the Document->Settings menu, and apparently, every 
time there is an automatic backup, both with 2.1.5 ans 2.2.0.


What is specific to this module ?


This is the module for the "basic" citation styles. It's normal for it 
to be read when the Document> Settings dialog is created. A copy of the 
BufferParams is created at that time.


Richard

Re: Basic module reloaded (Was: scrunched radio buttons on message pane)

[Jean-Pierre Chrétien]

Le 15/06/2016 09:13, Scott Kostyshak a écrit :

On Wed, Jun 15, 2016 at 09:48:03AM +0100, Jean-Pierre Chrétien wrote:



I've seen this once with 2.2.0, but I can't reproduce, maybe I left open an
instance of 2.1.5, I see now

../TextClass.cpp (317): Reading module file: [layouts/basic.module]
../TextClass.cpp (330): Finished reading module file: [layouts/basic.module]

when I select LyX initialisation tracking.


I'm not sure about the above. If you can find a way to reproduce it, it
would be good to know.


Can't reproduce now even with 2.1.5.
But I get these lines

BufferParams.cpp (2220): setBaseClass: article
../TextClass.cpp (317): Reading module file: [layouts/basic.module]
../TextClass.cpp (330): Finished reading module file: [layouts/basic.module]

evety time I open the Document->Settings menu, and apparently, every time there 
is an automatic backup, both with 2.1.5 ans 2.2.0.


What is specific to this module ?

Recipe:
* open LyX
* select "Texclass file reading" in the message pane parameters
* Open a new file
* Select Document->Settings

Messages are both in the terminal and in the Output window of the message pane.

--
Jean-Pierre

Re: scrunched radio buttons on message pane

[Scott Kostyshak]

On Wed, Jun 15, 2016 at 09:48:03AM +0100, Jean-Pierre Chrétien wrote:
> Le 14/06/2016 07:52, Scott Kostyshak a écrit :
> > Does anyone else see that the radio buttons are cut-off on the message
> > pane?
> > 
> > Attached is a screenshot.
> 
> I do not undertand what you mean by "cut-off".
> Here both on 2.2.0 and 2.2.1dev, they seem to be ok

Thanks for checking.

> (but the initial
> vertical size of the pane is to small, I have to enjlatge it to see the
> buttons).

Sorry for being unclear. This is exactly the problem I'm trying to fix.
It is a minor issue because as you found out you can enlarge it
manually, and in fact it stays enlarged across sessions I think. But
nonetheless I find it annoying and it is nice to try to provide a
polished experience. Ideally, it should not be possible to reduce the
size of a widget too much.

> But while fiddling with the message pane with lyx-2.1.5 I see this in the 
> terminal :
> 
> 
> tex2lyx/../TextClass.cpp (317): Reading module file: [layouts/basic.module]
> tex2lyx/../Lexer.cpp (257): lyxlex: UNcompressed
> tex2lyx/../Lexer.cpp (336): Comment read: `35 \DeclareLyXModule{Default 
> (basic)}'
> tex2lyx/../Lexer.cpp (336): Comment read: `35 DescriptionBegin'
> tex2lyx/../Lexer.cpp (336): Comment read: `35   Use the basic citation
> capabilities provided by plain LaTeX.'
> tex2lyx/../Lexer.cpp (336): Comment read: `35 DescriptionEnd'
> tex2lyx/../Lexer.cpp (336): Comment read: `35 Excludes: jurabib | natbib'
> tex2lyx/../Lexer.cpp (336): Comment read: `35 Category: Citation engine'
> tex2lyx/../Lexer.cpp (336): Comment read: `35 Author: Julien Rioux 
> '
> tex2lyx/../Lexer.cpp (336): Comment read: `35 translatable bits'
> tex2lyx/../Lexer.cpp (336): Comment read: `35 macros'
> tex2lyx/../Lexer.cpp (336): Comment read: `35 cite styles'
> tex2lyx/../TextClass.cpp (330): Finished reading module file: 
> [layouts/basic.module]
> 
> 
> and a popup confirms a problem with the basic module (attached).
> 
> I've seen this once with 2.2.0, but I can't reproduce, maybe I left open an
> instance of 2.1.5, I see now
> 
> ../TextClass.cpp (317): Reading module file: [layouts/basic.module]
> ../TextClass.cpp (330): Finished reading module file: [layouts/basic.module]
> 
> when I select LyX initialisation tracking.

I'm not sure about the above. If you can find a way to reproduce it, it
would be good to know.

Scott


signature.asc
Description: PGP signature

Re: scrunched radio buttons on message pane

[Jean-Pierre Chrétien]

Le 14/06/2016 07:52, Scott Kostyshak a écrit :

Does anyone else see that the radio buttons are cut-off on the message
pane?

Attached is a screenshot.


I do not undertand what you mean by "cut-off".
Here both on 2.2.0 and 2.2.1dev, they seem to be ok (but the initial vertical 
size of the pane is to small, I have to enjlatge it to see the buttons).


But while fiddling with the message pane with lyx-2.1.5 I see this in the 
terminal :


tex2lyx/../TextClass.cpp (317): Reading module file: [layouts/basic.module]
tex2lyx/../Lexer.cpp (257): lyxlex: UNcompressed
tex2lyx/../Lexer.cpp (336): Comment read: `35 \DeclareLyXModule{Default 
(basic)}'
tex2lyx/../Lexer.cpp (336): Comment read: `35 DescriptionBegin'
tex2lyx/../Lexer.cpp (336): Comment read: `35   Use the basic citation 
capabilities provided by plain LaTeX.'

tex2lyx/../Lexer.cpp (336): Comment read: `35 DescriptionEnd'
tex2lyx/../Lexer.cpp (336): Comment read: `35 Excludes: jurabib | natbib'
tex2lyx/../Lexer.cpp (336): Comment read: `35 Category: Citation engine'
tex2lyx/../Lexer.cpp (336): Comment read: `35 Author: Julien Rioux 
'
tex2lyx/../Lexer.cpp (336): Comment read: `35 translatable bits'
tex2lyx/../Lexer.cpp (336): Comment read: `35 macros'
tex2lyx/../Lexer.cpp (336): Comment read: `35 cite styles'
tex2lyx/../TextClass.cpp (330): Finished reading module file: 
[layouts/basic.module]


and a popup confirms a problem with the basic module (attached).

I've seen this once with 2.2.0, but I can't reproduce, maybe I left open an 
instance of 2.1.5, I see now


../TextClass.cpp (317): Reading module file: [layouts/basic.module]
../TextClass.cpp (330): Finished reading module file: [layouts/basic.module]

when I select LyX initialisation tracking.

--
Jean-Pierre

Re: scrunched radio buttons on message pane

[Scott Kostyshak]

On Tue, Jun 14, 2016 at 06:19:27PM +, Paul A. Rubin wrote:
> Scott Kostyshak  lyx.org> writes:
> 
> > 
> > Does anyone else see that the radio buttons are cut-off on the message
> > pane?
> > 
> 
> FWIW, they're find with LyX 2.2.0 /Qt 4.8.6 on Linux Mint Rebecca.
> 
> Paul

I forgot to mention: when testing you should try to make the height of
the messages pane as small as possible. Does it allow you to go "too"
small?

Attached is a patch. I've tested docking it, undocking it, and resizing
it in weird ways. I link below to before/after screenshots with Qt 4 and
Qt 5 and two different systems (both Ubuntu though):

https://www.dropbox.com/s/rysu6whqg8h87z5/qt4_15_after.png?dl=0
https://www.dropbox.com/s/bambj1hlkxwdhrm/qt4_15_before.png?dl=0
https://www.dropbox.com/s/xtiryrxhoq7ht02/qt5_13_after.png?dl=0
https://www.dropbox.com/s/sxjwrno7xe347a5/qt5_13_before.png?dl=0
https://www.dropbox.com/s/o85jugavc62fk7l/qt5_15_after.png?dl=0
https://www.dropbox.com/s/7zfbgfatvvssh55/qt5_15_before.png?dl=0

I've tested with Arabic, French, and German.

The patch solves two issues:

1. gets rid of the issue with the radio buttons that I posted about.

2. makes room for both the "Outline" and "Settings" tab names to show,
so there is no clipping and the arrows are not needed (did other people
see this issue as well or just me?).

The second issue that is solved is partly by luck, and that is good.
That is to say, the vertical size is not determined based on the tab
names. Thus the bad news is that the little arrows that annoy me could
come back (i.e. this change is not robust). The good news is that we do
not have to be worried that there are translations with long names for
the tab names that would make the vertical size extremely large.

The disadvantage of the patch is that the minimum size required is now
larger than before. Perhaps some people not as bothered as I was by the
two issues I mention above prefer to have the smaller vertical size. I
attempted to make it so that the widget containing the list of debug
levels (named "outTE") was not important in determining the size (there
is a scrollbar anyway), but I failed to figure this out. I did my
testing on a 13-inch screen and the increase did not bother me at all so
I don't expect others to mind it, but I bring this up just in case.
 
As for the patch itself, I don't know much about ui files so I am
proposing it mostly based on the "it works for me" principle. From what
I understand, many editors of the ui files before me have used the same
principle. My approach was to remove some numbers that seemed arbitrary
to me.

Any objection?

Scott
From 3c19a922d384b6544434bfdd74a4f44538853326 Mon Sep 17 00:00:00 2001
From: Scott Kostyshak 
Date: Tue, 14 Jun 2016 16:42:25 -0400
Subject: [PATCH] Fix two UI issues in the messages pane

1. sets the correct height for the radio buttons to avoid clipping

2. makes room for both the "Outline" and "Settings" tab names to
show, so there is no clipping and the arrows are not needed.

The second issue above is solved partly by luck, and that is good.
That is to say, the vertical size is not determined based on the tab
names. Thus the bad news is that the little arrows could come back
when we make future changes to this ui file (i.e. this change is not
robust). The good news is that we do not have to be worried that
there are translations with long names for the tab names that would
make the vertical size of the widget extremely large.

The disadvantage of this patch is that the minimum size required by
the messages pane is now larger than before. Perhaps some people not
as bothered as I was by the two issues I mention above prefer to
have the smaller vertical size. I attempted to make it so that the
widget containing the list of debug levels (named "outTE") was not
important in determining the size (there is a scrollbar anyway), but
I failed to figure this out.
---
 src/frontends/qt4/ui/ProgressViewUi.ui | 54 --
 1 file changed, 54 deletions(-)

diff --git a/src/frontends/qt4/ui/ProgressViewUi.ui 
b/src/frontends/qt4/ui/ProgressViewUi.ui
index 1ae1c6d..356d2ad 100644
--- a/src/frontends/qt4/ui/ProgressViewUi.ui
+++ b/src/frontends/qt4/ui/ProgressViewUi.ui
@@ -4,40 +4,6 @@
  
  ProgressViewUi
  
-  
-   
-0
-0
-543
-298
-   
-  
-  
-   
-7
-13
-0
-0
-   
-  
-  
-   
-0
-0
-   
-  
-  
-   
-0
-0
-   
-  
-  
-   
-0
-0
-   
-  
   

   
@@ -53,20 +19,6 @@
  
   true
  
- 
-  
-   7
-   13
-   0
-   0
-  
- 
- 
-  
-   0
-   0
-  
- 
  
   false
  
@@ -106,12 +58,6 @@
0
   
  
- 
-  
-   16777215
-   16777215
-  
- 
  
   QFrame::StyledPanel
  
-- 
2.1.4



signature.asc
Description: PGP signature

Re: scrunched radio buttons on message pane

[Paul A . Rubin]

Scott Kostyshak  lyx.org> writes:

> 
> Does anyone else see that the radio buttons are cut-off on the message
> pane?
> 

FWIW, they're find with LyX 2.2.0 /Qt 4.8.6 on Linux Mint Rebecca.

Paul

Re: scrunched radio buttons on message pane

[Andrew Parsloe]

On 14/06/2016 6:52 p.m., Scott Kostyshak wrote:

Does anyone else see that the radio buttons are cut-off on the message
pane?

Attached is a screenshot.

Scott

Attached is 2.2.0 on windows 7. No scrunching, but no colour.

Andrew


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

Re: scrunched radio buttons on message pane

[Jean-Marc Lasgouttes]

Le 14/06/2016 à 10:05, Kornel Benko a écrit :

Am Dienstag, 14. Juni 2016 um 02:52:58, schrieb Scott Kostyshak 


Does anyone else see that the radio buttons are cut-off on the message
pane?

Attached is a screenshot.

Scott


I see the same. QT5.6.


Same here with Qt 4.8.1, LyX 2.2.2dev.

JMarc

Re: scrunched radio buttons on message pane

[Kornel Benko]

Am Dienstag, 14. Juni 2016 um 02:52:58, schrieb Scott Kostyshak 

> Does anyone else see that the radio buttons are cut-off on the message
> pane?
> 
> Attached is a screenshot.
> 
> Scott

I see the same. QT5.6.

Kornel

signature.asc
Description: This is a digitally signed message part.

scrunched radio buttons on message pane

[Scott Kostyshak]

Does anyone else see that the radio buttons are cut-off on the message
pane?

Attached is a screenshot.

Scott


signature.asc
Description: PGP signature