Re: [153574] trunk/dports/sysutils/skey

2016-10-04 Thread Lawrence Velázquez
> On Oct 4, 2016, at 7:45 PM, Ryan Schmidt  wrote:
> 
>> On Oct 4, 2016, at 3:58 PM, Rainer Müller  wrote:
>> 
>> Patches should follow the patch-*.diff naming scheme, so this should be
>> named patch-skeyprune-man8.diff or similar.
> 
> Popular opinion seems to be that we should relax that restriction.
> 
> I think it's reasonable if we change it to "patch-*.diff or *.patch".

"patch-" and ".diff" are effectively synonymous, so I don't see any reason to 
include both in a single patch name, as it's redundant and makes every patch 
name longer. Plain "*.{patch,diff}" should be sufficient.

vq
Sent from my iPhone

___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: [153574] trunk/dports/sysutils/skey

2016-10-04 Thread Ryan Schmidt

> On Oct 4, 2016, at 3:58 PM, Rainer Müller  wrote:
> 
> On 2016-10-04 22:03, lar...@macports.org wrote:
>> Revision: 153574
>>  https://trac.macports.org/changeset/153574
>> Author:   lar...@macports.org
>> Date: 2016-10-04 13:03:08 -0700 (Tue, 04 Oct 2016)
>> Log Message:
>> ---
>> skey: Rename patch
>> 
>> Modified Paths:
>> --
>>trunk/dports/sysutils/skey/Portfile
>> 
>> Added Paths:
>> ---
>>trunk/dports/sysutils/skey/files/install-skeyprune.8.patch
>> 
>> Removed Paths:
>> -
>>trunk/dports/sysutils/skey/files/patch-Makefile.in.diff
>> 
>> Modified: trunk/dports/sysutils/skey/Portfile
>> ===
>> --- trunk/dports/sysutils/skey/Portfile  2016-10-04 20:00:00 UTC (rev 
>> 153573)
>> +++ trunk/dports/sysutils/skey/Portfile  2016-10-04 20:03:08 UTC (rev 
>> 153574)
>> @@ -25,6 +25,6 @@
>> sha1d55fb286098900cdf3eb6b174a720a06c722312a \
>> rmd160  33d97cbcd6dbc91bdca5b27056d51d1f5d06b68d
>> 
>> -patchfiles  patch-Makefile.in.diff
>> +patchfiles  install-skeyprune.8.patch
>> 
>> configure.args  --mandir=${prefix}/share/man
> 
> Patches should follow the patch-*.diff naming scheme, so this should be
> named patch-skeyprune-man8.diff or similar.
> 
> https://guide.macports.org/#development.patches.source

Popular opinion seems to be that we should relax that restriction.

I think it's reasonable if we change it to "patch-*.diff or *.patch".

My primary gripe was with the way patches used to be named "patch-foo" or 
"patch-foo.c" which caused editors to use incorrect syntax highlighting. As 
long as we use a .diff or .patch extension, to indicate to a syntax highlighter 
that this is a diff or patch file, that should be fine.



___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: [153574] trunk/dports/sysutils/skey

2016-10-04 Thread Lawrence Velázquez
> On Oct 4, 2016, at 7:05 PM, Lawrence Velázquez  wrote:
> 
> But that day is not today. https://trac.macports.org/changeset/153579

I meant this, obviously.
https://trac.macports.org/changeset/153576

vq
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: [153574] trunk/dports/sysutils/skey

2016-10-04 Thread Lawrence Velázquez
> On Oct 4, 2016, at 4:58 PM, Rainer Müller  wrote:
> 
> Patches should follow the patch-*.diff naming scheme, so this should be
> named patch-skeyprune-man8.diff or similar.
> 
> https://guide.macports.org/#development.patches.source

One day I'll get this naming guideline changed, if it's the last thing I do.*

But that day is not today. https://trac.macports.org/changeset/153579

vq







* figuratively speaking
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: [153488] trunk/dports/python/py-dnspython/Portfile

2016-10-04 Thread Ryan Schmidt

> On Oct 4, 2016, at 8:37 AM, Adam Mercer  wrote:
> 
> On Tue, Oct 4, 2016 at 3:08 AM, Ryan Schmidt  wrote:
> 
>> Since this changes the complement of files installed by the port, its 
>> revision must be increased.
> 
> The README.md file was removed from 1.15.0, therefore trying to update
> to this version resulted in a failed build. This change made the port
> installable again therefore I saw no need to bump the revision.

Oh ok, yes that's true then.

___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: [153574] trunk/dports/sysutils/skey

2016-10-04 Thread Rainer Müller
On 2016-10-04 22:03, lar...@macports.org wrote:
> Revision: 153574
>   https://trac.macports.org/changeset/153574
> Author:   lar...@macports.org
> Date: 2016-10-04 13:03:08 -0700 (Tue, 04 Oct 2016)
> Log Message:
> ---
> skey: Rename patch
> 
> Modified Paths:
> --
> trunk/dports/sysutils/skey/Portfile
> 
> Added Paths:
> ---
> trunk/dports/sysutils/skey/files/install-skeyprune.8.patch
> 
> Removed Paths:
> -
> trunk/dports/sysutils/skey/files/patch-Makefile.in.diff
> 
> Modified: trunk/dports/sysutils/skey/Portfile
> ===
> --- trunk/dports/sysutils/skey/Portfile   2016-10-04 20:00:00 UTC (rev 
> 153573)
> +++ trunk/dports/sysutils/skey/Portfile   2016-10-04 20:03:08 UTC (rev 
> 153574)
> @@ -25,6 +25,6 @@
>  sha1d55fb286098900cdf3eb6b174a720a06c722312a \
>  rmd160  33d97cbcd6dbc91bdca5b27056d51d1f5d06b68d
>  
> -patchfiles  patch-Makefile.in.diff
> +patchfiles  install-skeyprune.8.patch
>  
>  configure.args  --mandir=${prefix}/share/man

Patches should follow the patch-*.diff naming scheme, so this should be
named patch-skeyprune-man8.diff or similar.

https://guide.macports.org/#development.patches.source

Rainer
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Looking for help with MinGW-w64 cross-compiler

2016-10-04 Thread Mojca Miklavec
Hi,

I would like to ask for some help with finalizing the packages for
MinGW-w64. I have a working cross-compiler in my user tree
https://trac.macports.org/browser/users/mojca/ports/cross
but it's not yet in a state where I would be happy to move it to trunk.

The ticket is here:
https://trac.macports.org/ticket/40174


What is still missing?

- clean up the paths (most files need relocation to a saner path,
potentially create and/or fix symlinks)

- clean up the slightly messy part about i686 vs. x86_64
  (wherther to enable or --disable-multilib)

- clean up the "bootstrapping dependency mess"

- potentially add support for multiple versions of GCC (it would be
nice to support, say, GCC 4.9, 5 and 6 at the same time), even though
that's very low on the priority list

- clang: I've heard that clang can already create windows binaries,
but I'm not yet sure how to do that

- add optional parts
  * ada, fortran, ...
  * cloog, ppl, libgomp, pthreads-win32, ...

- write instructions for cross-compilation with MinGW-w64 using
MacPorts (including instructions for static builds against libstdc++)

- get rid of wxmsw or at least port it properly

I know that I could ask any question I want on this list, but I would
be grateful if there was some someone else willing to help a bit more
and look into the current mess of packages as I'm not only lacking the
full expertise, but also more time to dive deeper into this and to get
a more intimate understanding of the complete build process. It also
doesn't help that recompilation of gcc usually takes forever on my old
laptop.

Thanks in advance,
Mojca
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: [153488] trunk/dports/python/py-dnspython/Portfile

2016-10-04 Thread Adam Mercer
On Tue, Oct 4, 2016 at 3:08 AM, Ryan Schmidt  wrote:

> Since this changes the complement of files installed by the port, its 
> revision must be increased.

The README.md file was removed from 1.15.0, therefore trying to update
to this version resulted in a failed build. This change made the port
installable again therefore I saw no need to bump the revision.

Cheers

Adam
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: request review #52453

2016-10-04 Thread Aljaž Srebrnič
> On 02 ott 2016, at 19:38, Björn Ketelaars  
> wrote:
> 
> Would someone be so kind to review (and commit)
> https://trac.macports.org/ticket/52453 ?
> 
> Thank you!

Commited in r153557. Thanks for your contribution!

--
Aljaž Srebrnič a.k.a g5pw
My public key:  https://g5pw.me/key
Key fingerprint = 2109 8131 60CA 01AF 75EC  01BF E140 E1EE A54E E677

___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: [153488] trunk/dports/python/py-dnspython/Portfile

2016-10-04 Thread Ryan Schmidt

> On Oct 2, 2016, at 11:09 AM, r...@macports.org wrote:
> 
> Revision
> 153488
> Author
> r...@macports.org
> Date
> 2016-10-02 09:09:21 -0700 (Sun, 02 Oct 2016)
> Log Message
> 
> python/py-dnspython: remove README.md installation
> Modified Paths
> 
>   • trunk/dports/python/py-dnspython/Portfile
> Diff
> 
> Modified: trunk/dports/python/py-dnspython/Portfile (153487 => 153488)
> 
> --- trunk/dports/python/py-dnspython/Portfile 2016-10-02 15:07:44 UTC (rev 
> 153487)
> +++ trunk/dports/python/py-dnspython/Portfile 2016-10-02 16:09:21 UTC (rev 
> 153488)
> 
> @@ -33,7 +33,7 @@
> 
>  post-destroot {
> 
>if {${name} ne ${subport}} {
> 
>xinstall -d -m 755 ${destroot}${prefix}/share/doc/${subport}/examples
> 
> -  xinstall -m 644 -W ${worksrcpath} ChangeLog LICENSE README.md \
> 
> +  xinstall -m 644 -W ${worksrcpath} ChangeLog LICENSE \

Since this changes the complement of files installed by the port, its revision 
must be increased.


___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: [153501] trunk/dports

2016-10-04 Thread Ryan Schmidt

> On Oct 3, 2016, at 4:20 AM, easie...@macports.org wrote:
> 
> Revision
> 153501
> Author
> easie...@macports.org
> Date
> 2016-10-03 02:20:11 -0700 (Mon, 03 Oct 2016)
> Log Message
> 
> Update to sbcl-1.3.10
> 
> Removed the  for compilation on
> macOS 10.12 Sierra.  Unknown if this is needed for older macOS
> platforms due to lack of testing resources of committer.

This patch wasn't fixing an OS-specific matter. If the patch is no longer 
needed (and it looks like the upstream source no longer has the line this patch 
was removing), remove the patch.


___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: [153526] trunk/dports/math/octave-database/Portfile

2016-10-04 Thread Ryan Schmidt

> On Oct 3, 2016, at 8:16 PM, m...@macports.org wrote:
> 
> Revision
> 153526
> Author
> m...@macports.org
> Date
> 2016-10-03 18:16:08 -0700 (Mon, 03 Oct 2016)
> Log Message
> 
> octave-database: use mysql56, rather than mysql5, and add postgresql96 
> variant.
> Modified Paths
> 
>   • trunk/dports/math/octave-database/Portfile
> Diff
> 
> Modified: trunk/dports/math/octave-database/Portfile (153525 => 153526)
> 
> --- trunk/dports/math/octave-database/Portfile2016-10-04 01:00:43 UTC 
> (rev 153525)
> +++ trunk/dports/math/octave-database/Portfile2016-10-04 01:16:08 UTC 
> (rev 153526)
> 
> @@ -17,14 +17,14 @@
> 
>  
> 
>  depends_lib-append  port:octave-struct \
> 
>  port:swig-octave \
> 
> -path:bin/mysql_config:mysql5 \
> 
> +path:bin/mysql_config:mysql56 \


The mysql56 port does not provide a file /opt/local/bin/mysql_config.

This should be written "port:mysql56".

You might even consider offering variants to let the user choose which 
MySQL-compatible port to use. (MariaDB and Percona are also MySQL-compatible.)

___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev