Re: [27155] trunk/dports/python/py-psyco/Portfile
On Jul 21, 2007, at 23:00, [EMAIL PROTECTED] wrote:
Revision: 27155
http://trac.macosforge.org/projects/macports/changeset/27155
Author: [EMAIL PROTECTED]
Date: 2007-07-21 21:00:51 -0700 (Sat, 21 Jul 2007)
Log Message:
---
make sure we set that the platform only works on intel macs
Modified Paths:
--
trunk/dports/python/py-psyco/Portfile
Modified: trunk/dports/python/py-psyco/Portfile
===
--- trunk/dports/python/py-psyco/Portfile 2007-07-21 20:37:30 UTC
(rev 27154)
+++ trunk/dports/python/py-psyco/Portfile 2007-07-22 04:00:51 UTC
(rev 27155)
@@ -5,7 +5,7 @@
namepy-psyco
version 1.5.2
-revision1
+revision2
categories python
platforms darwin
maintainers [EMAIL PROTECTED]
@@ -34,3 +34,5 @@
${destroot}${prefix}/share/doc/${name}
file copy ${worksrcpath}/doc ${destroot}${prefix}/share/
doc/${name}/
}
+
+platform darwin i386 {}
There was no need to upgrade the revision: if somebody already had it
installed, they were obviously already on a compatible architecture.
Nothing is gained from forcing them to rebuild it.
You may also wish to check for compatible architecture in a different
way. Your way currently handles only on Intel Mac OS X, but according
to the project's web site, it works on any OS so long as it's the _86
architecture. Consider doing it the way I've done it in the wine port:
http://trac.macosforge.org/projects/macports/browser/trunk/dports/x11/
wine/Portfile
___
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo/macports-dev
Re: [27155] trunk/dports/python/py-psyco/Portfile
Ryan Schmidt wrote: You may also wish to check for compatible architecture in a different way. Your way currently handles only on Intel Mac OS X, but according to the project's web site, it works on any OS so long as it's the _86 architecture. Consider doing it the way I've done it in the wine port: http://trac.macosforge.org/projects/macports/browser/trunk/dports/x11/wine/Portfile I see no reason why checking for darwin i386 could be wrong. Do we really need to take care of other Operating Systems than Mac OS X? I mean, it's called MacPorts now and is targeted on users of Mac OS X. Who is using it on another system? And also see the wine port again, LDFLAGS like -framework won't work on other platforms... As platform is set to darwin, I think this is okay, but contrary to your statement above. Rainer ___ macports-dev mailing list macports-dev@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo/macports-dev
Re: [27155] trunk/dports/python/py-psyco/Portfile
On Jul 22, 2007, at 2:10 PM, Rainer Müller wrote: Do we really need to take care of other Operating Systems than Mac OS X? I mean, it's called MacPorts now and is targeted on users of Mac OS X. Who is using it on another system? We use MacPorts for a large software system that is Mac and Linux at the moment, and our group is considering using MacPorts for managing our Linux dependencies, as well. So we'd perhaps port MacPorts to Linux. And also see the wine port again, LDFLAGS like -framework won't work on other platforms... As platform is set to darwin, I think this is okay, but contrary to your statement above. Exactly what the platform tag is designed to do: we'd add platform linux stanzas to our ports, that would (of course) not have settings like -framework in them. Many (if not most) open-source packages already target linux successfully, so in most cases autoconf would determine the correct settings. I think. We haven't started a Linux port in earnest yet. Of course, I'm one of those nut jobs who tried to bring gentoo portage to Mac OS X about five years ago. Oy. - boyd Boyd Waters Scientific Programmer (no, really, that's what they call me) National Radio Astronomy Observatory Socorro, New Mexico ___ macports-dev mailing list macports-dev@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo/macports-dev
Re: [27155] trunk/dports/python/py-psyco/Portfile
[from the correct e-mail address, this time] On Jul 22, 2007, at 1:10 PM, Rainer Müller wrote: Ryan Schmidt wrote: You may also wish to check for compatible architecture in a different way. Your way currently handles only on Intel Mac OS X, but according to the project's web site, it works on any OS so long as it's the _86 architecture. Consider doing it the way I've done it in the wine port: http://trac.macosforge.org/projects/macports/browser/trunk/dports/ x11/wine/Portfile I see no reason why checking for darwin i386 could be wrong. Do we really need to take care of other Operating Systems than Mac OS X? I mean, it's called MacPorts now and is targeted on users of Mac OS X. Who is using it on another system? That's no reason to -intentionally- box yourself (or others) into a corner. The requirement is for 'x86', not for darwin, and as such, expressing a much broader dependency is incorrect. -landonf PGP.sig Description: This is a digitally signed message part ___ macports-dev mailing list macports-dev@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo/macports-dev
