Re: [Mageia-dev] [1555] Use /root/.MgaOnline for consistency
On 27 May 2011 12:03, wrote:
> Revision 1555 Author dmorgan Date 2011-05-27 12:03:00 +0200 (Fri, 27 May
> 2011)
>
> Log Message
>
> Use /root/.MgaOnline for consistency
Please revert, that's only used to read older configs
so obviously we cannot rename those
> Modified: mgaonline/trunk/mgaonline.pm
> ===
> --- mgaonline/trunk/mgaonline.pm 2011-05-27 09:01:31 UTC (rev 1554)
> +++ mgaonline/trunk/mgaonline.pm 2011-05-27 10:03:00 UTC (rev 1555)
> @@ -162,7 +162,7 @@
>
>
> sub clean_confdir() {
> -my $confdir = '/root/.MdkOnline';
> +my $confdir = '/root/.MgaOnline';
> system "/bin/rm", "-f", "$confdir/*log.bz2", "$confdir/*log.bz2.uue",
> "$confdir/*.dif $confdir/rpm_qa_installed_before",
> "$confdir/rpm_qa_installed_after";
> }
Re: [Mageia-dev] [1555] Use /root/.MgaOnline for consistency
Le vendredi 27 mai 2011 à 13:28 +0200, Thierry Vignaud a écrit :
> > Modified: mgaonline/trunk/mgaonline.pm
> > ===
> > --- mgaonline/trunk/mgaonline.pm2011-05-27 09:01:31 UTC (rev 1554)
> > +++ mgaonline/trunk/mgaonline.pm2011-05-27 10:03:00 UTC (rev 1555)
> > @@ -162,7 +162,7 @@
> >
> >
> > sub clean_confdir() {
> > -my $confdir = '/root/.MdkOnline';
> > +my $confdir = '/root/.MgaOnline';
> > system "/bin/rm", "-f", "$confdir/*log.bz2", "$confdir/*log.bz2.uue",
> > "$confdir/*.dif $confdir/rpm_qa_installed_before",
> > "$confdir/rpm_qa_installed_after";
> > }
system rm -f, am I the only one to find that's ugly ?
--
Michael Scherer
Re: [Mageia-dev] [1555] Use /root/.MgaOnline for consistency
On 27 May 2011 13:35, Michael Scherer wrote:
>> > Modified: mgaonline/trunk/mgaonline.pm
>> > ===
>> > --- mgaonline/trunk/mgaonline.pm 2011-05-27 09:01:31 UTC (rev 1554)
>> > +++ mgaonline/trunk/mgaonline.pm 2011-05-27 10:03:00 UTC (rev 1555)
>> > @@ -162,7 +162,7 @@
>> >
>> >
>> > sub clean_confdir() {
>> > - my $confdir = '/root/.MdkOnline';
>> > + my $confdir = '/root/.MgaOnline';
>> > system "/bin/rm", "-f", "$confdir/*log.bz2", "$confdir/*log.bz2.uue",
>> > "$confdir/*.dif $confdir/rpm_qa_installed_before",
>> > "$confdir/rpm_qa_installed_after";
>> > }
>
> system rm -f, am I the only one to find that's ugly ?
That's code bound to be removed anyway, it's obsolete for quite
a couple releases but it's not the moment for doing
cleaning-that-have-no-impact-I-assure-upi.
Though I wonder why the initial coder didn't reuse MDK::Common
It's basically obsolete since march 2007 when I switch mdkonline
from poor server side update computations to locally using
urpmi core to compute updates which is both more scalable and
quite a lot more accurate (taking into account provides, obsoletes,
skip.list, actual packages avaibility on used mirrors and the like...).
the server was using its own basic algorithm based only on packages list
Re: [Mageia-dev] [1555] Use /root/.MgaOnline for consistency
Le 27/05/2011 14:43, Thierry Vignaud a écrit :
> On 27 May 2011 13:35, Michael Scherer wrote:
>> > Modified: mgaonline/trunk/mgaonline.pm
>> > ===
>> > --- mgaonline/trunk/mgaonline.pm2011-05-27 09:01:31 UTC (rev 1554)
>> > +++ mgaonline/trunk/mgaonline.pm2011-05-27 10:03:00 UTC (rev 1555)
>> > @@ -162,7 +162,7 @@
>> >
>> >
>> > sub clean_confdir() {
>> > -my $confdir = '/root/.MdkOnline';
>> > +my $confdir = '/root/.MgaOnline';
>> > system "/bin/rm", "-f", "$confdir/*log.bz2",
>> > "$confdir/*log.bz2.uue",
>> > "$confdir/*.dif $confdir/rpm_qa_installed_before",
>> > "$confdir/rpm_qa_installed_after";
>> > }
>> >
>> > system rm -f, am I the only one to find that's ugly ?
Maybe we can write an unlink() function?
--
Sandro Cazzaniga - https://lederniercoupdarchet.wordpress.com
IRC: Kharec (irc.freenode.net)
Software/Hardware geek
Conceptor
Magnum's Coordinator/editor (http://wiki.mandriva.com/fr/Magnum)
Mageia and Mandriva contributor
Re: [Mageia-dev] [1555] Use /root/.MgaOnline for consistency
Le vendredi 27 mai 2011 à 14:43 +0200, Thierry Vignaud a écrit : > It's basically obsolete since march 2007 when I switch mdkonline > from poor server side update computations to locally using > urpmi core to compute updates which is both more scalable and > quite a lot more accurate (taking into account provides, obsoletes, > skip.list, actual packages avaibility on used mirrors and the like...). > the server was using its own basic algorithm based only on packages list Pushing computation on the edge ( and on the client ) is IMHO something we should keep in mind for various tools : - less resources on our side - more privacy for user -- Michael Scherer
