[Mahara-contributors] [Bug 1603294] Re: Licenses: Once you've selected a license, you can't go back to "None"

[Aaron Wells]

I think you're right, making "All rights reserved" and "None selected"
into distinct license types is the best way to go. I'll update the
patch.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1603294

Title:
  Licenses: Once you've selected a license, you can't go back to "None"

Status in Mahara:
  In Progress

Bug description:
  While testing out Bug 1279526, I noticed that you can't change an
  uploaded file from a particular license to "No License". This may have
  been by design, with the idea that "No License" was a temporary thing
  until you pick a license. But with Bug 1279526 we're changing the
  wording of "No License" to make it clear that if you're not choosing a
  particular license, then the default copyright rules apply, so it
  becomes more necessary to be able to switch to that.

  To replicate:

  1. Go to "Administration -> Configure Site -> General Settings", and
  enable "License metadata"

  2. Go to "Content -> Files" and upload a file.

  3. Once the file is uploaded, click the pencil "edit" button to open
  its editing form. It should be at "No license" or the equivalent.
  Change it to "Creative Commons Attribution 4.0"

  4. Click "Save changes"

  5. Now click the pencil "edit" button again. Change the License back
  to "No license" or the equivalent.

  6. Again click "Save changes"

  7. Again click the pencil "edit" button.

  Expected result: You see "No license" or the equivalent as the license
  selection.

  Actual result: You see "Creative Commons Attribution 4.0" as the
  license selection.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1603294/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1605071] Re: Display something more error-like when an AJAX block errors out

[Aaron Wells]

Aborting the backport to 15.04_STABLE, because it caused a regression.

** Changed in: mahara/15.04
   Status: In Progress => Won't Fix

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1605071

Title:
  Display something more error-like when an AJAX block errors out

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Won't Fix
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Spinning this bug off from Bug 1544424 (Endless JS loop if there's an
  uncaught exception in an ajax block) since patch
  https://reviews.mahara.org/6055 has taken much longer than
  https://reviews.mahara.org/6054 to get merged.

  We no longer get an endless loop when an Ajax block errors out, but it
  still looks pretty bad. See the attached screenshot. Because the file
  "blocktype.ajax.php" doesn't have the "JSON" header at its top, when
  it errors out, Mahara tries to print the full error page with the
  navigation headers and the message "Mahara: Site unavailable", and
  then ajaxblocks.js tries to display it in the little iframe reserved
  for that block.

  This looks confusing to the user, and it can spill over out of that
  block's space and cover up adjacent blocks. It would be better if we
  printed something that more obviously indicates that just this one
  block is broken, and that doesn't break the display of other blocks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1605071/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1609112] A patch has been submitted for review

[Mahara Bot]

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/6802

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1609112

Title:
  The is_plugin_active() function can give false positives

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  This is due to the fact that we have different plugin types with the
  same name, eg:

  Artefact   | Blocktype
  ---+
  blog   | blog
  comment| comment
  annotation | annotation

  And that we check the type 'artefact' first so in the case of the
  Artefact 'annotation' being active but the blocktype 'annotation' not
  being active we will get 'true' from is_plugin_active()

  We need to alter the function and pass it a 'type' so we can indicate
  which of the types we are interested in.

  I'll mark this as 'high' as this could lead to confusion in the use of
  the function.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1609112/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1609112] A patch has been submitted for review

[Mahara Bot]

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6801

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1609112

Title:
  The is_plugin_active() function can give false positives

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  This is due to the fact that we have different plugin types with the
  same name, eg:

  Artefact   | Blocktype
  ---+
  blog   | blog
  comment| comment
  annotation | annotation

  And that we check the type 'artefact' first so in the case of the
  Artefact 'annotation' being active but the blocktype 'annotation' not
  being active we will get 'true' from is_plugin_active()

  We need to alter the function and pass it a 'type' so we can indicate
  which of the types we are interested in.

  I'll mark this as 'high' as this could lead to confusion in the use of
  the function.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1609112/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1609112] Re: The is_plugin_active() function can give false positives

[Aaron Wells]

** Changed in: mahara/16.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1609112

Title:
  The is_plugin_active() function can give false positives

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  This is due to the fact that we have different plugin types with the
  same name, eg:

  Artefact   | Blocktype
  ---+
  blog   | blog
  comment| comment
  annotation | annotation

  And that we check the type 'artefact' first so in the case of the
  Artefact 'annotation' being active but the blocktype 'annotation' not
  being active we will get 'true' from is_plugin_active()

  We need to alter the function and pass it a 'type' so we can indicate
  which of the types we are interested in.

  I'll mark this as 'high' as this could lead to confusion in the use of
  the function.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1609112/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1609112] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6786
Committed: 
https://git.mahara.org/mahara/mahara/commit/f30bcd1215f1ef697aa2d463b423596b47a3cbc6
Submitter: Aaron Wells (aar...@catalyst.net.nz)
Branch:master

commit f30bcd1215f1ef697aa2d463b423596b47a3cbc6
Author: Robert Lyon 
Date:   Wed Aug 3 08:25:09 2016 +1200

Bug 1609112: Pass the plugin type to is_plugin_active()

So that we can differentiate between plugin types that have the same
plugin name, eg comment artefact vs comment blocktype

behatnotneeded

Change-Id: I0f7ffe6da3f7a4ff88cf625a1010c6d2012932d0
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1609112

Title:
  The is_plugin_active() function can give false positives

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  This is due to the fact that we have different plugin types with the
  same name, eg:

  Artefact   | Blocktype
  ---+
  blog   | blog
  comment| comment
  annotation | annotation

  And that we check the type 'artefact' first so in the case of the
  Artefact 'annotation' being active but the blocktype 'annotation' not
  being active we will get 'true' from is_plugin_active()

  We need to alter the function and pass it a 'type' so we can indicate
  which of the types we are interested in.

  I'll mark this as 'high' as this could lead to confusion in the use of
  the function.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1609112/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1609112] A patch has been submitted for review

[Mahara Bot]

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6800

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1609112

Title:
  The is_plugin_active() function can give false positives

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  This is due to the fact that we have different plugin types with the
  same name, eg:

  Artefact   | Blocktype
  ---+
  blog   | blog
  comment| comment
  annotation | annotation

  And that we check the type 'artefact' first so in the case of the
  Artefact 'annotation' being active but the blocktype 'annotation' not
  being active we will get 'true' from is_plugin_active()

  We need to alter the function and pass it a 'type' so we can indicate
  which of the types we are interested in.

  I'll mark this as 'high' as this could lead to confusion in the use of
  the function.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1609112/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1610009] Re: "make ssphp" isn't working

[Aaron Wells]

** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1610009

Title:
  "make ssphp" isn't working

Status in Mahara:
  Fix Committed

Bug description:
  It looks like SimpleSamlPHP changed where they store their downloads,
  so our "make ssphp" script no longer works.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1610009/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1610009] [NEW] "make ssphp" isn't working

[Aaron Wells]

Public bug reported:

It looks like SimpleSamlPHP changed where they store their downloads, so
our "make ssphp" script no longer works.

** Affects: mahara
 Importance: High
 Assignee: Aaron Wells (u-aaronw)
 Status: In Progress

** Changed in: mahara
Milestone: None => 16.10.0

** Changed in: mahara
 Assignee: (unassigned) => Aaron Wells (u-aaronw)

** Changed in: mahara
   Importance: Undecided => High

** Changed in: mahara
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1610009

Title:
  "make ssphp" isn't working

Status in Mahara:
  In Progress

Bug description:
  It looks like SimpleSamlPHP changed where they store their downloads,
  so our "make ssphp" script no longer works.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1610009/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1610006] [NEW] Remove mochikit from textarea.js

[Aaron Wells]

Public bug reported:

Spun off from Bug 1323920

** Affects: mahara
 Importance: High
 Assignee: Jono Mingard (mingard)
 Status: Fix Committed

** Changed in: mahara
   Status: New => Fix Committed

** Changed in: mahara
   Importance: Undecided => High

** Changed in: mahara
 Assignee: (unassigned) => Jono Mingard (mingard)

** Changed in: mahara
Milestone: None => 16.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1610006

Title:
  Remove mochikit from textarea.js

Status in Mahara:
  Fix Committed

Bug description:
  Spun off from Bug 1323920

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1610006/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1610009] A patch has been submitted for review

[Mahara Bot]

Patch for "master" branch: https://reviews.mahara.org/6797

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1610009

Title:
  "make ssphp" isn't working

Status in Mahara:
  In Progress

Bug description:
  It looks like SimpleSamlPHP changed where they store their downloads,
  so our "make ssphp" script no longer works.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1610009/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1610006] Re: Remove mochikit from textarea.js

[Aaron Wells]

Patch: https://reviews.mahara.org/#/c/5922/

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1610006

Title:
  Remove mochikit from textarea.js

Status in Mahara:
  Fix Committed

Bug description:
  Spun off from Bug 1323920

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1610006/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1610006] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/5922
Committed: 
https://git.mahara.org/mahara/mahara/commit/801c70cc63d08d4663b9f94127f53ace41ec46bd
Submitter: Aaron Wells (aar...@catalyst.net.nz)
Branch:master

commit 801c70cc63d08d4663b9f94127f53ace41ec46bd
Author: Jono Mingard 
Date:   Sat Jan 16 12:17:05 2016 +1300

Bug #1610006: Remove Pieforms textarea JS

This just set up a grippie to resize the textarea, which is
done by default in modern browsers anyway.

behatnotneeded: should be functionally identical

Change-Id: Ie27dfa36cccfb0b846939d35cd345a824af9f0f4

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1610006

Title:
  Remove mochikit from textarea.js

Status in Mahara:
  Fix Committed

Bug description:
  Spun off from Bug 1323920

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1610006/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1609731] [NEW] Error in theme/Readme.md - 'template' should be 'templates'

[Howard Miller]

Public bug reported:

Version 16.04

In the help file theme/Readme.md you are advised to create a new
'template' folder for customised templates (line 51). This is wrong. The
new folder should be called 'templates'.

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1609731

Title:
  Error in theme/Readme.md - 'template' should be 'templates'

Status in Mahara:
  New

Bug description:
  Version 16.04

  In the help file theme/Readme.md you are advised to create a new
  'template' folder for customised templates (line 51). This is wrong.
  The new folder should be called 'templates'.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1609731/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1605071] Re: Display something more error-like when an AJAX block errors out

[Robert Lyon]

** Changed in: mahara/15.10
   Status: In Progress => Fix Committed

** Changed in: mahara/16.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1605071

Title:
  Display something more error-like when an AJAX block errors out

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Spinning this bug off from Bug 1544424 (Endless JS loop if there's an
  uncaught exception in an ajax block) since patch
  https://reviews.mahara.org/6055 has taken much longer than
  https://reviews.mahara.org/6054 to get merged.

  We no longer get an endless loop when an Ajax block errors out, but it
  still looks pretty bad. See the attached screenshot. Because the file
  "blocktype.ajax.php" doesn't have the "JSON" header at its top, when
  it errors out, Mahara tries to print the full error page with the
  navigation headers and the message "Mahara: Site unavailable", and
  then ajaxblocks.js tries to display it in the little iframe reserved
  for that block.

  This looks confusing to the user, and it can spill over out of that
  block's space and cover up adjacent blocks. It would be better if we
  printed something that more obviously indicates that just this one
  block is broken, and that doesn't break the display of other blocks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1605071/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1605071] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6794
Committed: 
https://git.mahara.org/mahara/mahara/commit/cc4e3cf5150747dd8e692a7db4d71215630a7955
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.04_STABLE

commit cc4e3cf5150747dd8e692a7db4d71215630a7955
Author: Aaron Wells 
Date:   Thu Feb 11 18:34:17 2016 +1300

Bug 1605071: Display JSON-style errors for ajax blocks

If an Ajax block errors out, it will looks less broken
to display the JSON code there than to display error.tpl
(which tries to wedge a whole copy of the Mahara header and
footer and everything, into the space for a block.)

It would be even better to change block.js so that it actually
expects a JSON response.

behatnotneeded: Can't test error state via Behat

Change-Id: If5cc9ed2bbb3ce453a5cb413cbecdab0205fb3b5
(cherry picked from commit 0e7c6ff5d291ea5f8427c4380b3646be4d1b49cc)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1605071

Title:
  Display something more error-like when an AJAX block errors out

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Spinning this bug off from Bug 1544424 (Endless JS loop if there's an
  uncaught exception in an ajax block) since patch
  https://reviews.mahara.org/6055 has taken much longer than
  https://reviews.mahara.org/6054 to get merged.

  We no longer get an endless loop when an Ajax block errors out, but it
  still looks pretty bad. See the attached screenshot. Because the file
  "blocktype.ajax.php" doesn't have the "JSON" header at its top, when
  it errors out, Mahara tries to print the full error page with the
  navigation headers and the message "Mahara: Site unavailable", and
  then ajaxblocks.js tries to display it in the little iframe reserved
  for that block.

  This looks confusing to the user, and it can spill over out of that
  block's space and cover up adjacent blocks. It would be better if we
  printed something that more obviously indicates that just this one
  block is broken, and that doesn't break the display of other blocks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1605071/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1605071] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6795
Committed: 
https://git.mahara.org/mahara/mahara/commit/be39b7a42eedd7f6c7a48b370761e1d8617e2d83
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.10_STABLE

commit be39b7a42eedd7f6c7a48b370761e1d8617e2d83
Author: Aaron Wells 
Date:   Thu Feb 11 18:34:17 2016 +1300

Bug 1605071: Display JSON-style errors for ajax blocks

If an Ajax block errors out, it will looks less broken
to display the JSON code there than to display error.tpl
(which tries to wedge a whole copy of the Mahara header and
footer and everything, into the space for a block.)

It would be even better to change block.js so that it actually
expects a JSON response.

behatnotneeded: Can't test error state via Behat

Change-Id: If5cc9ed2bbb3ce453a5cb413cbecdab0205fb3b5
(cherry picked from commit 0e7c6ff5d291ea5f8427c4380b3646be4d1b49cc)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1605071

Title:
  Display something more error-like when an AJAX block errors out

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Spinning this bug off from Bug 1544424 (Endless JS loop if there's an
  uncaught exception in an ajax block) since patch
  https://reviews.mahara.org/6055 has taken much longer than
  https://reviews.mahara.org/6054 to get merged.

  We no longer get an endless loop when an Ajax block errors out, but it
  still looks pretty bad. See the attached screenshot. Because the file
  "blocktype.ajax.php" doesn't have the "JSON" header at its top, when
  it errors out, Mahara tries to print the full error page with the
  navigation headers and the message "Mahara: Site unavailable", and
  then ajaxblocks.js tries to display it in the little iframe reserved
  for that block.

  This looks confusing to the user, and it can spill over out of that
  block's space and cover up adjacent blocks. It would be better if we
  printed something that more obviously indicates that just this one
  block is broken, and that doesn't break the display of other blocks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1605071/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1606094] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6773
Committed: 
https://git.mahara.org/mahara/mahara/commit/d2c729330e0f7842445d92f489366b2174c6b2d5
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.10_STABLE

commit d2c729330e0f7842445d92f489366b2174c6b2d5
Author: Aaron Wells 
Date:   Mon Jul 25 13:46:14 2016 +1200

Bug 1606094: Stop sending quota notifications to everyone

This patch changes that bad left (outer) join to an inner
join, so that we only check for notifications for users
who are in the affected institution.

As a further safeguard, it also removes the line that
compared each user's file usage to the institution's
new quota. Now, we'll instead compare each user's
file usage to that user's current quota (which, for
members of the institution, will be the institution's
new quota.)

Change-Id: I4db6068221d1238c8a755434e78e6cc006a84aa8
behatnotneeded: Test to come later
(cherry picked from commit 2c262cdf8d3ddb8c9c66565c084b67e2f24825e6)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606094

Title:
  Changing the file quota for users in an institution, can send
  notifications to users in other institutions

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  On the institution config screen, there's a setting called "Update
  user quotas" that will do a one-time application of the institution's
  current "default quota" value to all existing users of the
  institution. At the same time, if you're using the "quota almost
  exceeded" notification emails, it will check each user whose quota has
  just been changed and send them a notification if they're near the
  threshold.

  The first part of this works fine. It does indeed update the quota for
  members of the changed institution, and nobody else. But there's a bug
  in the second part, that sends out the notifications. Instead of only
  checking the users in the institution, it checks *every* user in the
  site, and sends a notification to any of them who are near the
  threshold for the changed institution. This is not only annoying to
  users who aren't in the institution, but also confusing, because the
  email will tell them that their quota is the size of the changed
  institution's quota, when in fact their quota has not changed.

  To replicate:

  1. Clean Mahara install
  2. Log in as admin
  3. Upload a 1MB file into your File -> Contents area
  4. Create an institution. Save the institution.
  5. Click the "edit" link for the institution.
  6. Set "Default quota" to 100 Kilobytes.
  7. Set "Update user quotas" to "On"
  8. Click "Submit"

  Expected result: The admin user should not receive a notification,
  because they're not in that institution and their quota has not
  changed.

  Actual result: The admin user receives a notification about being over
  their quota, but their quota has not actually changed from the default
  50MB.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606094/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1606094] Re: Changing the file quota for users in an institution, can send notifications to users in other institutions

[Robert Lyon]

** Changed in: mahara/15.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606094

Title:
  Changing the file quota for users in an institution, can send
  notifications to users in other institutions

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  On the institution config screen, there's a setting called "Update
  user quotas" that will do a one-time application of the institution's
  current "default quota" value to all existing users of the
  institution. At the same time, if you're using the "quota almost
  exceeded" notification emails, it will check each user whose quota has
  just been changed and send them a notification if they're near the
  threshold.

  The first part of this works fine. It does indeed update the quota for
  members of the changed institution, and nobody else. But there's a bug
  in the second part, that sends out the notifications. Instead of only
  checking the users in the institution, it checks *every* user in the
  site, and sends a notification to any of them who are near the
  threshold for the changed institution. This is not only annoying to
  users who aren't in the institution, but also confusing, because the
  email will tell them that their quota is the size of the changed
  institution's quota, when in fact their quota has not changed.

  To replicate:

  1. Clean Mahara install
  2. Log in as admin
  3. Upload a 1MB file into your File -> Contents area
  4. Create an institution. Save the institution.
  5. Click the "edit" link for the institution.
  6. Set "Default quota" to 100 Kilobytes.
  7. Set "Update user quotas" to "On"
  8. Click "Submit"

  Expected result: The admin user should not receive a notification,
  because they're not in that institution and their quota has not
  changed.

  Actual result: The admin user receives a notification about being over
  their quota, but their quota has not actually changed from the default
  50MB.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606094/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp