[Mahara-contributors] [Bug 1533377] Re: Remove Persona (browserid) auth plugin by Nov 2016, because Mozilla is ending Persona support
Okay, it's coming up on the 16.10 release, and it looks like no particular service is taking over for Mozilla Persona, so we'll need to go ahead with our plans to decommission the plugin. I think probably the best use of our current resources is to do a minimal implementation that moves all the users over to Internal auth. It would look something like this: 1. On the Browserid extension config page, we add a button that initiates the migration 2. It deletes any browserid auth instances that have no users. 3. For the other browserid auth instances, it sets the "no current password" flag on their user record (which is '*' in the usr.password and usr.salt fields), and reassigns them to their institution's internal auth instance. If their institution doesn't have an internal auth instance, it creates one. These users can then use the "Forgot password" page to request a new internal auth password. The site admin can instruct them to do this by manually sending out an email or updating the logged-out homepage. Or I guess an even more minimal implementation would be to just tell affected site admins to migrate the users to a different auth instance manually. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1533377 Title: Remove Persona (browserid) auth plugin by Nov 2016, because Mozilla is ending Persona support Status in Mahara: Confirmed Bug description: Mozilla has recently announced that they're ending support for the Persona authentication service, in November 2016.: https://wiki.mozilla.org/Identity/Persona_Shutdown_Guidelines_for_Reliers Mahara has long shipped with a Persona (formerly "Browserid") auth plugin. We'll need to remove this plugin from the 16.10 release, and come up with a way to help existing sites migrate their users away from Persona. We should also consider how to help out the stable release sites in migrating users away from Persona. The Nov 2016 shutdown will be very close to the 16.10 release date, so asking sites to upgrade to 16.10 to use any migration tool will be fairly demanding, particularly since 15.04 will still be covered by its extended support lifetime. So for 15.04, 15.10, and 16.04 sites, an optional Persona migration plugin is probably the best option. That way the functionality will be available to sites that need it, without shipping new features in minor upgrades. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1533377/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1570221] A change has been merged
Reviewed: https://reviews.mahara.org/6811 Committed: https://git.mahara.org/mahara/mahara/commit/cadbbf5c0c771ecfe489229e68f1fa2154ff157c Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:16.04_STABLE commit cadbbf5c0c771ecfe489229e68f1fa2154ff157c Author: Aaron Wells Date: Thu Apr 14 19:52:42 2016 +1200 Bug 1570221 Don't print parameter values to logs when in production mode The best way to prevent sensitive data from being printed to the logs is to avoid printing the value of *any* parameter. For instance, a password parameter may have an unusual name, or it may be passed through a general-purpose function like "strlen()". Since parameter values are useful for debugging, we can still print them when not in production mode (although with known password params still scrubbed out). Note this patch both scrubs likely password params, and hides their scrubbed value. That's mostly because I'm lazy, but it also obscures the password's actual length. Change-Id: I4a1ab4c89a169c6b29a7b63384c2412cee761ab7 behatnotneeded: Can't test with behat (cherry picked from commit 9a2972495d55c55633f1fa10522cd567933ecf6f) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1570221 Title: Don't print parameter values in logs, in productionmode Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Bug description: Following on from Bug 1567186, even scrubbing out parameters that we know to be passwords, is not a fool-proof way to keep passwords and sensitive data out of the logs. Params might be misnamed, or sensitive data might be passed through general-purpose functions. The only surefire way to prevent secure data from being printed to the logs, is to avoid printing parameter values in stacktraces at all. However, parameter values are useful for debugging, so I think we should show them productionmode=false, and hide them when productionmode=true. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1570221/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1570221] A change has been merged
Reviewed: https://reviews.mahara.org/6813 Committed: https://git.mahara.org/mahara/mahara/commit/b984a1b40700e37f120019cae7fc5a681c9c092a Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:15.04_STABLE commit b984a1b40700e37f120019cae7fc5a681c9c092a Author: Aaron Wells Date: Thu Apr 14 19:52:42 2016 +1200 Bug 1570221 Don't print parameter values to logs when in production mode The best way to prevent sensitive data from being printed to the logs is to avoid printing the value of *any* parameter. For instance, a password parameter may have an unusual name, or it may be passed through a general-purpose function like "strlen()". Since parameter values are useful for debugging, we can still print them when not in production mode (although with known password params still scrubbed out). Note this patch both scrubs likely password params, and hides their scrubbed value. That's mostly because I'm lazy, but it also obscures the password's actual length. Change-Id: I4a1ab4c89a169c6b29a7b63384c2412cee761ab7 behatnotneeded: Can't test with behat (cherry picked from commit 9a2972495d55c55633f1fa10522cd567933ecf6f) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1570221 Title: Don't print parameter values in logs, in productionmode Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Bug description: Following on from Bug 1567186, even scrubbing out parameters that we know to be passwords, is not a fool-proof way to keep passwords and sensitive data out of the logs. Params might be misnamed, or sensitive data might be passed through general-purpose functions. The only surefire way to prevent secure data from being printed to the logs, is to avoid printing parameter values in stacktraces at all. However, parameter values are useful for debugging, so I think we should show them productionmode=false, and hide them when productionmode=true. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1570221/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1609200] A change has been merged
Reviewed: https://reviews.mahara.org/6810 Committed: https://git.mahara.org/mahara/mahara/commit/3e6b80bc736b8c0b74dc3cfe315d1ee7d023ee26 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:15.04_STABLE commit 3e6b80bc736b8c0b74dc3cfe315d1ee7d023ee26 Author: Aaron Wells Date: Wed Aug 3 14:23:08 2016 +1200 Bug 1609200: Limit group config to group's admins behatnotneeded: Test to come later Change-Id: Ibbb574c67d80e3fd6a139752590bdd602e822f88 (cherry picked from commit 47905d70a15798ef7cad3ed1b5c63bf530e1ef3c) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1609200 Title: Non-admin role users can edit group settings Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Bug description: Only the admin of a group should be able to change the group's settings (via group/edit.php). But any member of a group can view and edit the settings if they go to the URL directly: * http://my.mahara/group/edit.php?id=3 There is no check to make sure the user has admin role. To replicate: 1. Create a group as User 1. Note the group's id 2. Add User 2 to the group as a "member" (not an "admin") 3. Log in as User 2 4. Type in e.g. http://my.mahara/group/edit.php?id=X , where X is the group's ID Expected result: You get an error message saying "You can't edit this group" Actual result: You see the group config page, and you can make changes and they will be saved. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1609200/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1609200] Re: Non-admin role users can edit group settings
** Changed in: mahara/15.04 Status: In Progress => Fix Committed ** Changed in: mahara/15.10 Status: In Progress => Fix Committed ** Changed in: mahara/16.04 Status: In Progress => Fix Committed ** Changed in: mahara/16.10 Status: In Progress => Fix Committed ** Information type changed from Private Security to Public Security -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1609200 Title: Non-admin role users can edit group settings Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Bug description: Only the admin of a group should be able to change the group's settings (via group/edit.php). But any member of a group can view and edit the settings if they go to the URL directly: * http://my.mahara/group/edit.php?id=3 There is no check to make sure the user has admin role. To replicate: 1. Create a group as User 1. Note the group's id 2. Add User 2 to the group as a "member" (not an "admin") 3. Log in as User 2 4. Type in e.g. http://my.mahara/group/edit.php?id=X , where X is the group's ID Expected result: You get an error message saying "You can't edit this group" Actual result: You see the group config page, and you can make changes and they will be saved. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1609200/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1570221] Re: Don't print parameter values in logs, in productionmode
** Changed in: mahara/15.04 Status: In Progress => Fix Committed ** Changed in: mahara/15.10 Status: In Progress => Fix Committed ** Changed in: mahara/16.04 Status: In Progress => Fix Committed ** Changed in: mahara/16.10 Status: In Progress => Fix Committed ** Information type changed from Private Security to Public Security -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1570221 Title: Don't print parameter values in logs, in productionmode Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Bug description: Following on from Bug 1567186, even scrubbing out parameters that we know to be passwords, is not a fool-proof way to keep passwords and sensitive data out of the logs. Params might be misnamed, or sensitive data might be passed through general-purpose functions. The only surefire way to prevent secure data from being printed to the logs, is to avoid printing parameter values in stacktraces at all. However, parameter values are useful for debugging, so I think we should show them productionmode=false, and hide them when productionmode=true. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1570221/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1570221] A change has been merged
Reviewed: https://reviews.mahara.org/6812 Committed: https://git.mahara.org/mahara/mahara/commit/b3840bbb3e67bb733c0f862d9b01c2d575591831 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:15.10_STABLE commit b3840bbb3e67bb733c0f862d9b01c2d575591831 Author: Aaron Wells Date: Thu Apr 14 19:52:42 2016 +1200 Bug 1570221 Don't print parameter values to logs when in production mode The best way to prevent sensitive data from being printed to the logs is to avoid printing the value of *any* parameter. For instance, a password parameter may have an unusual name, or it may be passed through a general-purpose function like "strlen()". Since parameter values are useful for debugging, we can still print them when not in production mode (although with known password params still scrubbed out). Note this patch both scrubs likely password params, and hides their scrubbed value. That's mostly because I'm lazy, but it also obscures the password's actual length. Change-Id: I4a1ab4c89a169c6b29a7b63384c2412cee761ab7 behatnotneeded: Can't test with behat (cherry picked from commit 9a2972495d55c55633f1fa10522cd567933ecf6f) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1570221 Title: Don't print parameter values in logs, in productionmode Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Bug description: Following on from Bug 1567186, even scrubbing out parameters that we know to be passwords, is not a fool-proof way to keep passwords and sensitive data out of the logs. Params might be misnamed, or sensitive data might be passed through general-purpose functions. The only surefire way to prevent secure data from being printed to the logs, is to avoid printing parameter values in stacktraces at all. However, parameter values are useful for debugging, so I think we should show them productionmode=false, and hide them when productionmode=true. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1570221/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1606744] Re: Accessibility - Select 'other' text field label incorrect
** Changed in: mahara/15.04 Status: New => Confirmed ** Changed in: mahara/15.10 Status: New => Confirmed ** Changed in: mahara/16.04 Status: New => Confirmed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1606744 Title: Accessibility - Select 'other' text field label incorrect Status in Mahara: In Progress Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: In Progress Bug description: Mahara: master Input text fields should have a label and/or use the 'aria-labelled by' property to bind multiple inputs to a label. Please refer to: http://webaim.org/techniques/forms/controls#input An example where it is needed is in the screen (artefact/internal/socialprofile.php): * Social media > New social media account The input box (id=editprofileform_profiletype_other) next to "Other" is not linked to a label. Screen readers refer to it as "edit". To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1606744/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1609200] A change has been merged
Reviewed: https://reviews.mahara.org/6808 Committed: https://git.mahara.org/mahara/mahara/commit/230e0bcf0d19f7489a85305d33ac88b39dbf19e1 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:16.04_STABLE commit 230e0bcf0d19f7489a85305d33ac88b39dbf19e1 Author: Aaron Wells Date: Wed Aug 3 14:23:08 2016 +1200 Bug 1609200: Limit group config to group's admins behatnotneeded: Test to come later Change-Id: Ibbb574c67d80e3fd6a139752590bdd602e822f88 (cherry picked from commit 47905d70a15798ef7cad3ed1b5c63bf530e1ef3c) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1609200 Title: Non-admin role users can edit group settings Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Bug description: Only the admin of a group should be able to change the group's settings (via group/edit.php). But any member of a group can view and edit the settings if they go to the URL directly: * http://my.mahara/group/edit.php?id=3 There is no check to make sure the user has admin role. To replicate: 1. Create a group as User 1. Note the group's id 2. Add User 2 to the group as a "member" (not an "admin") 3. Log in as User 2 4. Type in e.g. http://my.mahara/group/edit.php?id=X , where X is the group's ID Expected result: You get an error message saying "You can't edit this group" Actual result: You see the group config page, and you can make changes and they will be saved. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1609200/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1609200] A change has been merged
Reviewed: https://reviews.mahara.org/6809 Committed: https://git.mahara.org/mahara/mahara/commit/7cd868125963731ecda8d2323984e6aea5430b22 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:15.10_STABLE commit 7cd868125963731ecda8d2323984e6aea5430b22 Author: Aaron Wells Date: Wed Aug 3 14:23:08 2016 +1200 Bug 1609200: Limit group config to group's admins behatnotneeded: Test to come later Change-Id: Ibbb574c67d80e3fd6a139752590bdd602e822f88 (cherry picked from commit 47905d70a15798ef7cad3ed1b5c63bf530e1ef3c) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1609200 Title: Non-admin role users can edit group settings Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Bug description: Only the admin of a group should be able to change the group's settings (via group/edit.php). But any member of a group can view and edit the settings if they go to the URL directly: * http://my.mahara/group/edit.php?id=3 There is no check to make sure the user has admin role. To replicate: 1. Create a group as User 1. Note the group's id 2. Add User 2 to the group as a "member" (not an "admin") 3. Log in as User 2 4. Type in e.g. http://my.mahara/group/edit.php?id=X , where X is the group's ID Expected result: You get an error message saying "You can't edit this group" Actual result: You see the group config page, and you can make changes and they will be saved. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1609200/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1431659] Re: Problems importing Annotations via Leap2a
** Changed in: mahara/15.04 Status: Confirmed => In Progress ** Changed in: mahara/15.10 Status: Confirmed => In Progress ** Changed in: mahara/16.04 Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1431659 Title: Problems importing Annotations via Leap2a Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: As reported on https://reviews.mahara.org/#/c/4123/: "When I import a Leap2A (a collection with two pages; one with a text and 2 annotation blocks and the other with an image block and an annotation block), I get "[INF] 83 (import/index.php:301) Leap2A import failed: Cannot find reflection entry for annotation." The text block does not have an embedded image. Just plain text." To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1431659/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1431659] A patch has been submitted for review
Patch for "15.04_STABLE" branch: https://reviews.mahara.org/6816 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1431659 Title: Problems importing Annotations via Leap2a Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: As reported on https://reviews.mahara.org/#/c/4123/: "When I import a Leap2A (a collection with two pages; one with a text and 2 annotation blocks and the other with an image block and an annotation block), I get "[INF] 83 (import/index.php:301) Leap2A import failed: Cannot find reflection entry for annotation." The text block does not have an embedded image. Just plain text." To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1431659/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1431659] A patch has been submitted for review
Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6814 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1431659 Title: Problems importing Annotations via Leap2a Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: As reported on https://reviews.mahara.org/#/c/4123/: "When I import a Leap2A (a collection with two pages; one with a text and 2 annotation blocks and the other with an image block and an annotation block), I get "[INF] 83 (import/index.php:301) Leap2A import failed: Cannot find reflection entry for annotation." The text block does not have an embedded image. Just plain text." To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1431659/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1431659] A patch has been submitted for review
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6815 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1431659 Title: Problems importing Annotations via Leap2a Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: As reported on https://reviews.mahara.org/#/c/4123/: "When I import a Leap2A (a collection with two pages; one with a text and 2 annotation blocks and the other with an image block and an annotation block), I get "[INF] 83 (import/index.php:301) Leap2A import failed: Cannot find reflection entry for annotation." The text block does not have an embedded image. Just plain text." To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1431659/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1431659] Re: Problems importing Annotations via Leap2a
** Changed in: mahara/15.04 Status: In Progress => Fix Committed ** Changed in: mahara/15.10 Status: In Progress => Fix Committed ** Changed in: mahara/16.04 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1431659 Title: Problems importing Annotations via Leap2a Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: As reported on https://reviews.mahara.org/#/c/4123/: "When I import a Leap2A (a collection with two pages; one with a text and 2 annotation blocks and the other with an image block and an annotation block), I get "[INF] 83 (import/index.php:301) Leap2A import failed: Cannot find reflection entry for annotation." The text block does not have an embedded image. Just plain text." To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1431659/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1431659] A change has been merged
Reviewed: https://reviews.mahara.org/6815 Committed: https://git.mahara.org/mahara/mahara/commit/11e4da5fab167941bfc92b148eae152950d65e4d Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:15.10_STABLE commit 11e4da5fab167941bfc92b148eae152950d65e4d Author: Robert Lyon Date: Fri Jul 8 18:08:45 2016 +1200 Bug 1431659: Allowing import of annotation leap2a When creating a new user in admin -> create user screen behatnotneeded Change-Id: Ie2fdffa0da9e087f38ab9a458850625872fbf534 Signed-off-by: Robert Lyon (cherry picked from commit f378b34796e7d143cf553d70af5878f924492623) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1431659 Title: Problems importing Annotations via Leap2a Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: As reported on https://reviews.mahara.org/#/c/4123/: "When I import a Leap2A (a collection with two pages; one with a text and 2 annotation blocks and the other with an image block and an annotation block), I get "[INF] 83 (import/index.php:301) Leap2A import failed: Cannot find reflection entry for annotation." The text block does not have an embedded image. Just plain text." To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1431659/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1431659] A change has been merged
Reviewed: https://reviews.mahara.org/6816 Committed: https://git.mahara.org/mahara/mahara/commit/90420c7a68c48568b67c9e9bbae58e746568f9aa Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:15.04_STABLE commit 90420c7a68c48568b67c9e9bbae58e746568f9aa Author: Robert Lyon Date: Fri Jul 8 18:08:45 2016 +1200 Bug 1431659: Allowing import of annotation leap2a When creating a new user in admin -> create user screen behatnotneeded Change-Id: Ie2fdffa0da9e087f38ab9a458850625872fbf534 Signed-off-by: Robert Lyon (cherry picked from commit f378b34796e7d143cf553d70af5878f924492623) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1431659 Title: Problems importing Annotations via Leap2a Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: As reported on https://reviews.mahara.org/#/c/4123/: "When I import a Leap2A (a collection with two pages; one with a text and 2 annotation blocks and the other with an image block and an annotation block), I get "[INF] 83 (import/index.php:301) Leap2A import failed: Cannot find reflection entry for annotation." The text block does not have an embedded image. Just plain text." To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1431659/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1431659] A change has been merged
Reviewed: https://reviews.mahara.org/6814 Committed: https://git.mahara.org/mahara/mahara/commit/f6e00791538a61f6e02d3ee407258ee469973dbf Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:16.04_STABLE commit f6e00791538a61f6e02d3ee407258ee469973dbf Author: Robert Lyon Date: Fri Jul 8 18:08:45 2016 +1200 Bug 1431659: Allowing import of annotation leap2a When creating a new user in admin -> create user screen behatnotneeded Change-Id: Ie2fdffa0da9e087f38ab9a458850625872fbf534 Signed-off-by: Robert Lyon (cherry picked from commit f378b34796e7d143cf553d70af5878f924492623) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1431659 Title: Problems importing Annotations via Leap2a Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: As reported on https://reviews.mahara.org/#/c/4123/: "When I import a Leap2A (a collection with two pages; one with a text and 2 annotation blocks and the other with an image block and an annotation block), I get "[INF] 83 (import/index.php:301) Leap2A import failed: Cannot find reflection entry for annotation." The text block does not have an embedded image. Just plain text." To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1431659/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1602447] A change has been merged
Reviewed: https://reviews.mahara.org/6716
Committed:
https://git.mahara.org/mahara/mahara/commit/08facc98eca2c8c5c9171099bc717278a45b4518
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master
commit 08facc98eca2c8c5c9171099bc717278a45b4518
Author: Aaron Wells
Date: Wed Jul 13 11:35:34 2016 +1200
Bug 1602447: Allow ">" in CSS stylesheets
(Also removing the HTMLPurifier custom filters while I'm at it,
because they don't actually do anything in this context.)
behatnotneeded: Behat test to come later (due to current
Firefox/Selenium incompatibility issues.)
Change-Id: I47d3fba1962ff03b74e2b721ead81f1530886f04
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1602447
Title:
Can't use ">" CSS selector in skins
Status in Mahara:
Fix Committed
Status in Mahara 15.04 series:
Fix Committed
Status in Mahara 15.10 series:
Fix Committed
Status in Mahara 16.04 series:
Fix Committed
Status in Mahara 16.10 series:
Fix Committed
Bug description:
See https://mahara.org/interaction/forum/topic.php?id=7659
The ">" character is a basic selector in CSS, which allows you to
specify an element contained within another element. For example,
"div.class1 > span.class2" would match the span in
Don't style me. But style
me!
If you try to use a ">" in the "Custom CSS" section of a Mahara skin,
it gets turned into "\3E". Probably it's being accidentally over-
escaped at some point, because ">" is a syntactically important
character in HTML.
To replicate:
1. Create a Mahara skin
2. On the skin editor go to the "Advanced" tab
3. In "Custom CSS" enter this:
body > .main-content > .row {
background-color: red;
}
4. Click "Save" (this closes the skin editor)
5. Edit the skin again, and navigate back to the Advanced tab.
Expected result: The "Custom CSS" field shows what you entered before
Actual result: The ">" in the Custom CSS field has been turned into "\3E".
Further test:
1. Apply the skin you selected in the previous test, to a Mahara page.
2. View the page in display mode.
Expected result: The page background is red.
Actual result: No change in the the appearance of the page.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1602447/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1602447] A patch has been submitted for review
Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6817
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1602447
Title:
Can't use ">" CSS selector in skins
Status in Mahara:
Fix Committed
Status in Mahara 15.04 series:
Fix Committed
Status in Mahara 15.10 series:
Fix Committed
Status in Mahara 16.04 series:
Fix Committed
Status in Mahara 16.10 series:
Fix Committed
Bug description:
See https://mahara.org/interaction/forum/topic.php?id=7659
The ">" character is a basic selector in CSS, which allows you to
specify an element contained within another element. For example,
"div.class1 > span.class2" would match the span in
Don't style me. But style
me!
If you try to use a ">" in the "Custom CSS" section of a Mahara skin,
it gets turned into "\3E". Probably it's being accidentally over-
escaped at some point, because ">" is a syntactically important
character in HTML.
To replicate:
1. Create a Mahara skin
2. On the skin editor go to the "Advanced" tab
3. In "Custom CSS" enter this:
body > .main-content > .row {
background-color: red;
}
4. Click "Save" (this closes the skin editor)
5. Edit the skin again, and navigate back to the Advanced tab.
Expected result: The "Custom CSS" field shows what you entered before
Actual result: The ">" in the Custom CSS field has been turned into "\3E".
Further test:
1. Apply the skin you selected in the previous test, to a Mahara page.
2. View the page in display mode.
Expected result: The page background is red.
Actual result: No change in the the appearance of the page.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1602447/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1602447] A patch has been submitted for review
Patch for "15.04_STABLE" branch: https://reviews.mahara.org/6819
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1602447
Title:
Can't use ">" CSS selector in skins
Status in Mahara:
Fix Committed
Status in Mahara 15.04 series:
Fix Committed
Status in Mahara 15.10 series:
Fix Committed
Status in Mahara 16.04 series:
Fix Committed
Status in Mahara 16.10 series:
Fix Committed
Bug description:
See https://mahara.org/interaction/forum/topic.php?id=7659
The ">" character is a basic selector in CSS, which allows you to
specify an element contained within another element. For example,
"div.class1 > span.class2" would match the span in
Don't style me. But style
me!
If you try to use a ">" in the "Custom CSS" section of a Mahara skin,
it gets turned into "\3E". Probably it's being accidentally over-
escaped at some point, because ">" is a syntactically important
character in HTML.
To replicate:
1. Create a Mahara skin
2. On the skin editor go to the "Advanced" tab
3. In "Custom CSS" enter this:
body > .main-content > .row {
background-color: red;
}
4. Click "Save" (this closes the skin editor)
5. Edit the skin again, and navigate back to the Advanced tab.
Expected result: The "Custom CSS" field shows what you entered before
Actual result: The ">" in the Custom CSS field has been turned into "\3E".
Further test:
1. Apply the skin you selected in the previous test, to a Mahara page.
2. View the page in display mode.
Expected result: The page background is red.
Actual result: No change in the the appearance of the page.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1602447/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1602447] A change has been merged
Reviewed: https://reviews.mahara.org/6818
Committed:
https://git.mahara.org/mahara/mahara/commit/5c727f0852d0df7a904753e47a11ab84ee6344ef
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.10_STABLE
commit 5c727f0852d0df7a904753e47a11ab84ee6344ef
Author: Aaron Wells
Date: Wed Jul 13 11:35:34 2016 +1200
Bug 1602447: Allow ">" in CSS stylesheets
(Also removing the HTMLPurifier custom filters while I'm at it,
because they don't actually do anything in this context.)
behatnotneeded: Behat test to come later (due to current
Firefox/Selenium incompatibility issues.)
Change-Id: I47d3fba1962ff03b74e2b721ead81f1530886f04
(cherry picked from commit 08facc98eca2c8c5c9171099bc717278a45b4518)
(cherry picked from commit 1826f3c1e2251b91430e772f10b075f98278583c)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1602447
Title:
Can't use ">" CSS selector in skins
Status in Mahara:
Fix Committed
Status in Mahara 15.04 series:
Fix Committed
Status in Mahara 15.10 series:
Fix Committed
Status in Mahara 16.04 series:
Fix Committed
Status in Mahara 16.10 series:
Fix Committed
Bug description:
See https://mahara.org/interaction/forum/topic.php?id=7659
The ">" character is a basic selector in CSS, which allows you to
specify an element contained within another element. For example,
"div.class1 > span.class2" would match the span in
Don't style me. But style
me!
If you try to use a ">" in the "Custom CSS" section of a Mahara skin,
it gets turned into "\3E". Probably it's being accidentally over-
escaped at some point, because ">" is a syntactically important
character in HTML.
To replicate:
1. Create a Mahara skin
2. On the skin editor go to the "Advanced" tab
3. In "Custom CSS" enter this:
body > .main-content > .row {
background-color: red;
}
4. Click "Save" (this closes the skin editor)
5. Edit the skin again, and navigate back to the Advanced tab.
Expected result: The "Custom CSS" field shows what you entered before
Actual result: The ">" in the Custom CSS field has been turned into "\3E".
Further test:
1. Apply the skin you selected in the previous test, to a Mahara page.
2. View the page in display mode.
Expected result: The page background is red.
Actual result: No change in the the appearance of the page.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1602447/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1602447] A change has been merged
Reviewed: https://reviews.mahara.org/6817
Committed:
https://git.mahara.org/mahara/mahara/commit/1826f3c1e2251b91430e772f10b075f98278583c
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.04_STABLE
commit 1826f3c1e2251b91430e772f10b075f98278583c
Author: Aaron Wells
Date: Wed Jul 13 11:35:34 2016 +1200
Bug 1602447: Allow ">" in CSS stylesheets
(Also removing the HTMLPurifier custom filters while I'm at it,
because they don't actually do anything in this context.)
behatnotneeded: Behat test to come later (due to current
Firefox/Selenium incompatibility issues.)
Change-Id: I47d3fba1962ff03b74e2b721ead81f1530886f04
(cherry picked from commit 08facc98eca2c8c5c9171099bc717278a45b4518)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1602447
Title:
Can't use ">" CSS selector in skins
Status in Mahara:
Fix Committed
Status in Mahara 15.04 series:
Fix Committed
Status in Mahara 15.10 series:
Fix Committed
Status in Mahara 16.04 series:
Fix Committed
Status in Mahara 16.10 series:
Fix Committed
Bug description:
See https://mahara.org/interaction/forum/topic.php?id=7659
The ">" character is a basic selector in CSS, which allows you to
specify an element contained within another element. For example,
"div.class1 > span.class2" would match the span in
Don't style me. But style
me!
If you try to use a ">" in the "Custom CSS" section of a Mahara skin,
it gets turned into "\3E". Probably it's being accidentally over-
escaped at some point, because ">" is a syntactically important
character in HTML.
To replicate:
1. Create a Mahara skin
2. On the skin editor go to the "Advanced" tab
3. In "Custom CSS" enter this:
body > .main-content > .row {
background-color: red;
}
4. Click "Save" (this closes the skin editor)
5. Edit the skin again, and navigate back to the Advanced tab.
Expected result: The "Custom CSS" field shows what you entered before
Actual result: The ">" in the Custom CSS field has been turned into "\3E".
Further test:
1. Apply the skin you selected in the previous test, to a Mahara page.
2. View the page in display mode.
Expected result: The page background is red.
Actual result: No change in the the appearance of the page.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1602447/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1602447] A patch has been submitted for review
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6818
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1602447
Title:
Can't use ">" CSS selector in skins
Status in Mahara:
Fix Committed
Status in Mahara 15.04 series:
Fix Committed
Status in Mahara 15.10 series:
Fix Committed
Status in Mahara 16.04 series:
Fix Committed
Status in Mahara 16.10 series:
Fix Committed
Bug description:
See https://mahara.org/interaction/forum/topic.php?id=7659
The ">" character is a basic selector in CSS, which allows you to
specify an element contained within another element. For example,
"div.class1 > span.class2" would match the span in
Don't style me. But style
me!
If you try to use a ">" in the "Custom CSS" section of a Mahara skin,
it gets turned into "\3E". Probably it's being accidentally over-
escaped at some point, because ">" is a syntactically important
character in HTML.
To replicate:
1. Create a Mahara skin
2. On the skin editor go to the "Advanced" tab
3. In "Custom CSS" enter this:
body > .main-content > .row {
background-color: red;
}
4. Click "Save" (this closes the skin editor)
5. Edit the skin again, and navigate back to the Advanced tab.
Expected result: The "Custom CSS" field shows what you entered before
Actual result: The ">" in the Custom CSS field has been turned into "\3E".
Further test:
1. Apply the skin you selected in the previous test, to a Mahara page.
2. View the page in display mode.
Expected result: The page background is red.
Actual result: No change in the the appearance of the page.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1602447/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1602447] Re: Can't use ">" CSS selector in skins
** Changed in: mahara/16.10
Status: In Progress => Fix Committed
** Changed in: mahara/16.04
Status: In Progress => Fix Committed
** Changed in: mahara/15.10
Status: In Progress => Fix Committed
** Changed in: mahara/15.04
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1602447
Title:
Can't use ">" CSS selector in skins
Status in Mahara:
Fix Committed
Status in Mahara 15.04 series:
Fix Committed
Status in Mahara 15.10 series:
Fix Committed
Status in Mahara 16.04 series:
Fix Committed
Status in Mahara 16.10 series:
Fix Committed
Bug description:
See https://mahara.org/interaction/forum/topic.php?id=7659
The ">" character is a basic selector in CSS, which allows you to
specify an element contained within another element. For example,
"div.class1 > span.class2" would match the span in
Don't style me. But style
me!
If you try to use a ">" in the "Custom CSS" section of a Mahara skin,
it gets turned into "\3E". Probably it's being accidentally over-
escaped at some point, because ">" is a syntactically important
character in HTML.
To replicate:
1. Create a Mahara skin
2. On the skin editor go to the "Advanced" tab
3. In "Custom CSS" enter this:
body > .main-content > .row {
background-color: red;
}
4. Click "Save" (this closes the skin editor)
5. Edit the skin again, and navigate back to the Advanced tab.
Expected result: The "Custom CSS" field shows what you entered before
Actual result: The ">" in the Custom CSS field has been turned into "\3E".
Further test:
1. Apply the skin you selected in the previous test, to a Mahara page.
2. View the page in display mode.
Expected result: The page background is red.
Actual result: No change in the the appearance of the page.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1602447/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1602447] A change has been merged
Reviewed: https://reviews.mahara.org/6819
Committed:
https://git.mahara.org/mahara/mahara/commit/0c6ddd295d586ca8f3365233c48a859af08dcf3d
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.04_STABLE
commit 0c6ddd295d586ca8f3365233c48a859af08dcf3d
Author: Aaron Wells
Date: Wed Jul 13 11:35:34 2016 +1200
Bug 1602447: Allow ">" in CSS stylesheets
(Also removing the HTMLPurifier custom filters while I'm at it,
because they don't actually do anything in this context.)
behatnotneeded: Behat test to come later (due to current
Firefox/Selenium incompatibility issues.)
Change-Id: I47d3fba1962ff03b74e2b721ead81f1530886f04
(cherry picked from commit 08facc98eca2c8c5c9171099bc717278a45b4518)
(cherry picked from commit 1826f3c1e2251b91430e772f10b075f98278583c)
(cherry picked from commit 5c727f0852d0df7a904753e47a11ab84ee6344ef)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1602447
Title:
Can't use ">" CSS selector in skins
Status in Mahara:
Fix Committed
Status in Mahara 15.04 series:
Fix Committed
Status in Mahara 15.10 series:
Fix Committed
Status in Mahara 16.04 series:
Fix Committed
Status in Mahara 16.10 series:
Fix Committed
Bug description:
See https://mahara.org/interaction/forum/topic.php?id=7659
The ">" character is a basic selector in CSS, which allows you to
specify an element contained within another element. For example,
"div.class1 > span.class2" would match the span in
Don't style me. But style
me!
If you try to use a ">" in the "Custom CSS" section of a Mahara skin,
it gets turned into "\3E". Probably it's being accidentally over-
escaped at some point, because ">" is a syntactically important
character in HTML.
To replicate:
1. Create a Mahara skin
2. On the skin editor go to the "Advanced" tab
3. In "Custom CSS" enter this:
body > .main-content > .row {
background-color: red;
}
4. Click "Save" (this closes the skin editor)
5. Edit the skin again, and navigate back to the Advanced tab.
Expected result: The "Custom CSS" field shows what you entered before
Actual result: The ">" in the Custom CSS field has been turned into "\3E".
Further test:
1. Apply the skin you selected in the previous test, to a Mahara page.
2. View the page in display mode.
Expected result: The page background is red.
Actual result: No change in the the appearance of the page.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1602447/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1597536] Re: import_entry_requests table needs a ctime so we can clean up old partial requests
** Changed in: mahara/15.04 Milestone: 15.04.9 => 15.04.10 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1597536 Title: import_entry_requests table needs a ctime so we can clean up old partial requests Status in Mahara: In Progress Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Bug description: A ctime will allow us to clean up the old entries via a new (or possibly existing) cronjob And we need to make the stored path to the files be relative to dataroot rather than full path from '/' on server as we shouldn't be recording that info in the db. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1597536/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1605071] Re: Display something more error-like when an AJAX block errors out
** Changed in: mahara/15.04 Milestone: 15.04.9 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1605071 Title: Display something more error-like when an AJAX block errors out Status in Mahara: Fix Committed Status in Mahara 15.04 series: Won't Fix Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Bug description: Spinning this bug off from Bug 1544424 (Endless JS loop if there's an uncaught exception in an ajax block) since patch https://reviews.mahara.org/6055 has taken much longer than https://reviews.mahara.org/6054 to get merged. We no longer get an endless loop when an Ajax block errors out, but it still looks pretty bad. See the attached screenshot. Because the file "blocktype.ajax.php" doesn't have the "JSON" header at its top, when it errors out, Mahara tries to print the full error page with the navigation headers and the message "Mahara: Site unavailable", and then ajaxblocks.js tries to display it in the little iframe reserved for that block. This looks confusing to the user, and it can spill over out of that block's space and cover up adjacent blocks. It would be better if we printed something that more obviously indicates that just this one block is broken, and that doesn't break the display of other blocks. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1605071/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1560131] Re: Mahara SAML auth broken with Simplesamlphp 1.14.x
** Changed in: mahara/15.04 Milestone: 15.04.9 => None ** Changed in: mahara/15.10 Milestone: 15.10.5 => None ** Changed in: mahara/16.04 Milestone: 16.04.3 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1560131 Title: Mahara SAML auth broken with Simplesamlphp 1.14.x Status in Mahara: Fix Committed Status in Mahara 15.04 series: Won't Fix Status in Mahara 15.10 series: Won't Fix Status in Mahara 16.04 series: Won't Fix Status in Mahara 16.10 series: Fix Committed Bug description: When attempting to use Mahara 15.10.1 on Ubuntu 14.04.4 with Simplesamlphp 1.14.x, I attempt to SSO login and get the error: PHP Fatal error: Call to undefined method SimpleSAML_Session::getInstance() in /cluster/www/sites/secure.smus.ca/www/mahara/auth/saml/index.php on line 56 This appears to be because the Simplesamlphp people removed the function call SimpleSAML_Session::getInstance() in version 1.14.0: https://simplesamlphp.org/docs/stable/simplesamlphp-upgrade-notes-1.14 I looked at auth/saml/index.php and it doesn't look like there are too many times that $saml_session is used. I'll see if I can figure out what to use in place of the $saml_session stuff. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1560131/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1572825] Re: voki externalmedia embed code changed
** Changed in: mahara/15.04 Milestone: 15.04.9 => 15.04.10 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1572825 Title: voki externalmedia embed code changed Status in Mahara: Confirmed Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Confirmed Bug description: A recent support post on the Mahara forums has highlighted that the externalmedia flags the voki URL invalid: https://mahara.org/interaction/forum/topic.php?id=4007&offset=0&limit=10#post30536 It appears that the links have changed and will require an update in Mahara. Previous voki bug: https://bugs.launchpad.net/mahara/+bug/905097 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1572825/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1487274] Re: Elasticsearch choking on non-ASCII characters
** Changed in: mahara/15.04 Milestone: 15.04.9 => 15.04.10 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1487274 Title: Elasticsearch choking on non-ASCII characters Status in Mahara: Confirmed Status in Mahara 1.10 series: Won't Fix Status in Mahara 1.9 series: Won't Fix Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Bug description: In 15.10 I've added code to "quarantine" records that Elasticsearch won't index. That is, if Elasticsearch errors out while processing a batch of records, then I re-try each record individually. And if it errors out while processing one of those individual records, I mark the record as quarantined, and keep it in the search_elasticsearch_queue table. I've backported that to one of our large 15.04 sites, and since then I've taken a look at the data in the records that have caused Elasticsearch to choke. They all contain non-ASCII characters, i.e. Unicode characters. These can be as simple as "e with an accent over it", all the way up to exotic ones like emoji and the Unicode snowman. I was not able to replicate this when testing on my local machine, but it is certainly in place on our production servers, and bugs such as Bug 1408577 make me think it's probably also present on some other servers as well. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1487274/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1500285] Re: Add path and update records slowness
** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 ** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 ** Changed in: mahara/15.04 Milestone: 15.04.9 => 15.04.10 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1500285 Title: Add path and update records slowness Status in Mahara: Confirmed Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Confirmed Bug description: Upgrade Issue 1 - Add path and update records : This adds a field 'path' to artefact table and thereafter runs a update query to add data. We have around 500K rows and this takes around 94 minutes to upgrade! This can be done in one go without the limit of 200 and it works very well taking around 2-3 minutes! Few times the upgrade failed due to "mysqli error: [1205: Lock wait timeout exceeded; try restarting transaction]". This is spun off from Bug #1499568 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1500285/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1533456] Re: (Non-flowplayer) embedded media overlaps over block config in Mahara 15.04
** Changed in: mahara Milestone: 15.04.9 => 15.04.10 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1533456 Title: (Non-flowplayer) embedded media overlaps over block config in Mahara 15.04 Status in Mahara: In Progress Bug description: This bug occurs only in Mahara 15.04. Not 1.10, not 15.10. I noticed it in Firefox. I haven't tried it in other browsers. The problem is that if you place a video file onto a page, and then you go to edit another block on the page, the video is displayed over the block config popup. This appears only to happen with the file types that are *not* handled by Flowplayer (.swf, .mpg, .avi) To replicate: 1. Clean install of Mahara 2. Go to /admin/extensions/pluginconfig.php?plugintype=blocktype&pluginname=file/internalmedia and activate all the media types 3. Create a page 4. On the page, place an "Embedded media" block, with an mpg file in it. 5. Above the embedded media block, place a Text block Expected result: The block config for the Text block comes up and you can see it Actual result: The mpg file from the embedded media block, displays on top of the block config To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1533456/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1606744] Re: Accessibility - Select 'other' text field label incorrect
** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 ** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 ** Changed in: mahara/15.04 Milestone: 15.04.9 => 15.04.10 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1606744 Title: Accessibility - Select 'other' text field label incorrect Status in Mahara: In Progress Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: In Progress Bug description: Mahara: master Input text fields should have a label and/or use the 'aria-labelled by' property to bind multiple inputs to a label. Please refer to: http://webaim.org/techniques/forms/controls#input An example where it is needed is in the screen (artefact/internal/socialprofile.php): * Social media > New social media account The input box (id=editprofileform_profiletype_other) next to "Other" is not linked to a label. Screen readers refer to it as "edit". To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1606744/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1269170] Re: GD Image not being created during cron run
** Changed in: mahara/15.04
Milestone: 15.04.9 => 15.04.10
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1269170
Title:
GD Image not being created during cron run
Status in Mahara:
Invalid
Status in Mahara 15.04 series:
Confirmed
Status in Mahara 15.10 series:
Invalid
Bug description:
I get the following warnings when cron job 'cron_site_data_daily' runs
- I'm not sure if it's specific to my data / machine / php version
(which is 5.4) but I thought I'd mention them here in case others were
having the same problems.
The failure means that the statistic graphics are not generated.
[WAR] 48 (lib/pear/Image/Canvas/GD/PNG.php:125) imagepng(): gd-png: fatal
libpng error: Wrote palette index exceeding num_palette
Call stack (most recent first):
* log_message("imagepng(): gd-png: fatal libpng error: Wrote pal...", 8,
true, true, "/mnt/data/s16/lib/pear/Image/Canvas/GD/PNG.php", 125) at
/mnt/data/s16/lib/errors.php:430
* error(2, "imagepng(): gd-png: fatal libpng error: Wrote pal...",
"/mnt/data/s16/lib/pear/Image/Canvas/GD/PNG.php", 125, array(size 1)) at
Unknown:0
* imagepng(resource(#8087), "/mnt/data/uploaddir/images/grouptypes.png")
at /mnt/data/s16/lib/pear/Image/Canvas/GD/PNG.php:125
* Image_Canvas_GD_PNG->save(array(size 1)) at
/mnt/data/s16/lib/pear/Image/Graph.php:865
* Image_Graph->_done(array(size 1)) at
/mnt/data/s16/lib/pear/Image/Graph.php:787
* Image_Graph->done(array(size 1)) at
/mnt/data/s16/lib/registration.php:1164
* group_type_graph() at /mnt/data/s16/lib/registration.php:2163
* graph_site_data_daily() at /mnt/data/s16/lib/mahara.php:3009
* cron_site_data_daily() at /mnt/data/s16/lib/cron.php:142
[WAR] 48 (lib/pear/Image/Canvas/GD/PNG.php:125) imagepng(): gd-png error:
setjmp returns error condition
Call stack (most recent first):
* log_message("imagepng(): gd-png error: setjmp returns error con...", 8,
true, true, "/mnt/data/s16/lib/pear/Image/Canvas/GD/PNG.php", 125) at
/mnt/data/s16/lib/errors.php:430
* error(2, "imagepng(): gd-png error: setjmp returns error con...",
"/mnt/data/s16/lib/pear/Image/Canvas/GD/PNG.php", 125, array(size 1)) at
Unknown:0
* imagepng(resource(#8087), "/mnt/data/uploaddir/images/grouptypes.png")
at /mnt/data/s16/lib/pear/Image/Canvas/GD/PNG.php:125
* Image_Canvas_GD_PNG->save(array(size 1)) at
/mnt/data/s16/lib/pear/Image/Graph.php:865
* Image_Graph->_done(array(size 1)) at
/mnt/data/s16/lib/pear/Image/Graph.php:787
* Image_Graph->done(array(size 1)) at
/mnt/data/s16/lib/registration.php:1164
* group_type_graph() at /mnt/data/s16/lib/registration.php:2163
* graph_site_data_daily() at /mnt/data/s16/lib/mahara.php:3009
* cron_site_data_daily() at /mnt/data/s16/lib/cron.php:142
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1269170/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1524581] Re: Extra spaces showing as Â
** Changed in: mahara/15.04 Milestone: 15.04.9 => 15.04.10 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1524581 Title: Extra spaces showing as  Status in Mahara: Invalid Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: Invalid Status in Mahara 16.04 series: Invalid Bug description: Sending users messages with extra spaces between words displays weird in the "Message" section, couldn't produce in the subject field. Steps to reproduce: 1) login to 15.04_STABLE 2) create two users 3) send message from one to the other with two or more spaces between words 4) view the message Expected result: spaces within the text should not break and display weird Actual result: more than one space between a word or special char looks like this  To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1524581/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1499287] Re: Safari text box editing
** Changed in: mahara Milestone: 15.04.9 => 15.04.10 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1499287 Title: Safari text box editing Status in Mahara: Triaged Bug description: Hello, I've had several students with Macbooks and iPads raise an issue with being unable to save textboxes when editing pages using Safari. I don't think it's just a recent version issue (we're on Mahara 15.04.2testing) but it came to my attention because I've had so many people ask about editing problems in the past couple of days - guess our newest student cohort are Mac fans! The pages they are specifically having trouble with are templates that they copy from a central location. The pages have multiple blocks of information on them, including several textboxes containing questions the students are asked to edit to provide answers for. Depending on the range of information the page layout can be complex but is usually two rows of 3-4 blocks of media & text. When they try to edit the textboxes at the bottom of the page, the editing box pops up at the bottom of the screen so that the 'Save' button is below the visible interface, and they don't seem to be able to move it to make the button visible on screen. They can scroll within the text editor a limited amount, but the save button is always below the screen. I've attached a screenshot example that a student sent me. Another student posted a workaround into our help forum - using the arrow keys to zoom the browser window to make contents smaller allowed the entire editor box to appear on screen - but I don't have a Mac device to verify that this works. Regards, Gordon. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1499287/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1577251] Re: Should invalidate password reset links when a user changes their primary email address
** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 ** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 ** Changed in: mahara/15.04 Milestone: 15.04.9 => 15.04.10 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1577251 Title: Should invalidate password reset links when a user changes their primary email address Status in Mahara: Confirmed Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Confirmed Bug description: As reported to us through the mahara.org security bug email address, by Sajibe kanti. When a user completes the "Forgot password?" password reset process, we delete any remaining password reset links for that user. However, we do not delete these if a user changes their primary email address. As the initial email points out, that could lead to an attack like this: 1. Attacker compromises victim's Mahara account (without changing victim's password). 2. Attacker changes their account's primary email address to the attacker's email address. 3. Attacker uses "Forgot password" page to request a password reset email. They don't immediately use the link in the password reset email; instead they store it for later. 4. Victim realizes their Mahara account is compromised, and logs in to their account. 5. Victim attempts to secure their account by changing their password (through account settings page), and changing their primary email address back to their own. Expected result: The attacker is locked out of the victim's Mahara account Actual result: The attacker uses their stored password reset email to change the user's password and re-gain access to their account. We could help reduce this attack vector, by deleting any outstanding password reset emails for a user, when the user updates their account's primary email address. We should probably also delete any outstanding password reset emails for a user, when they change their account password through the account settings page. It may be worth considering other situations where password reset emails should be deleted, as well. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1577251/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1264098] Re: Whitelist more CSS3 options in skins
** Changed in: mahara/15.04
Milestone: 15.04.9 => 15.04.10
** Changed in: mahara/15.10
Milestone: 15.10.5 => 15.10.6
** Changed in: mahara/16.04
Milestone: 16.04.3 => 16.04.4
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1264098
Title:
Whitelist more CSS3 options in skins
Status in Mahara:
In Progress
Status in Mahara 15.04 series:
In Progress
Status in Mahara 15.10 series:
In Progress
Status in Mahara 16.04 series:
In Progress
Status in Mahara 16.10 series:
In Progress
Bug description:
I tried to create a new skin with custom CSS code added to the
"Advanced" tab.
collection-nav ul {
columns: 2;
-webkit-columns: 2;
-moz-columns: 2;
}
When I save it, and then try to edit the skin, everything is deleted
except:
ul {
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1264098/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1554862] Re: Move testing infrastructure into a separate git submodule
** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 ** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 ** Changed in: mahara/15.04 Milestone: 15.04.9 => 15.04.10 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1554862 Title: Move testing infrastructure into a separate git submodule Status in Mahara: In Progress Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Bug description: Currently we include all the Mahara testing code in the main Mahara branch. This would work fine, except that rapid changes in Firefox mean that we need to make rapid changes in our Selenium interface, and all of these need to be backported into the testing code for all branches that are still supported. Effectively, this means that *all* testing-related code needs to be synchronized across all supported branches. The easiest way to ensure that is to move the testing code out of the main Mahara branch. For the time being, a git submodule is probably the best approach. Because some of the Behat steps need to be different between the different Mahara versions (for instance, navigation steps need to take into account changes in the menu structure's HTML), the Behat subproject may need to have code that sniffs the Mahara version it's running against and makes changes accordingly. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1554862/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1425392] Re: Behat bug: Behat gets confused by the 2 different Groups in navigation
** Changed in: mahara/15.04 Milestone: 15.04.9 => 15.04.10 ** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 ** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1425392 Title: Behat bug: Behat gets confused by the 2 different Groups in navigation Status in Mahara: Confirmed Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: In Progress Bug description: Hi, I have a attached a broken Behat test. When it clicks on the first "Groups" heading in the navigation it works fine. eg "Find friends" in "Groups" Then it fails when it tries selecting "Archived submissions" in "Groups" . It doesn’t like the fact that there are 2 of them. What way do we have to work around this? Thanks, Jinelle To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1425392/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1534398] Re: Clean URLs created during user account creation, do not respect the "nousernames" setting
** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 ** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 ** Changed in: mahara/15.04 Milestone: 15.04.9 => 15.10.6 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1534398 Title: Clean URLs created during user account creation, do not respect the "nousernames" setting Status in Mahara: Triaged Status in Mahara 1.10 series: Won't Fix Status in Mahara 15.04 series: Triaged Status in Mahara 15.10 series: Triaged Status in Mahara 16.04 series: Triaged Status in Mahara 16.10 series: Triaged Bug description: See: https://mahara.org/interaction/forum/topic.php?id=7479 If you activate the "Never display usernames" site setting, and turn on clean URLs, the clean URL for new users' profile pages will still contain their username. If you do "regerenate clean URLs", however, the newly created clean URLs will *not* have the usernames. This is because the method regenerateurls_submit() in cleanurls.php respects the $CFG->nousernames setting, but the other places that generate clean URLs on account creation do not: - User->create() in auth/user.php - create_user() in lib/user.php To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1534398/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1537861] Re: View layout becomes corrupted when changed
** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 ** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 ** Changed in: mahara/15.04 Milestone: 15.04.9 => 15.04.10 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1537861 Title: View layout becomes corrupted when changed Status in Mahara: Triaged Status in Mahara 15.04 series: Triaged Status in Mahara 15.10 series: Triaged Status in Mahara 16.04 series: Triaged Status in Mahara 16.10 series: Triaged Bug description: Version: Mahara 15.04.5 (only encountered on this version, after upgrading from 15.04.4) We have had 2 users (out of over a thousand) have this problem so far, and I've been unable reproduce it or trace a specific cause but we do know the order of events and the outcome: They copy a page from another user Change content or add some new content Attempt to change the layout (say from 3 columns to 2 columns) Something goes wrong while the layout is being changed and the data in the table view_rows_columns no longer matches what's in the view table, and the page won't load anymore. As more users encounter this problem (and I'm assuming they will) I will update this report. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1537861/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1609538] Re: Block edit screen has empy success (green) messages boxes
** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 ** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1609538 Title: Block edit screen has empy success (green) messages boxes Status in Mahara: In Progress Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: In Progress Bug description: When I add an block (eg an image block) I get a green box at top of page but no message in it. When I add an image and then save and then reload page and then delete the block I get the green box again but still no message in it It looks like the 'message' part of the ajax response is not set Need to get the message set so it can appear It looks like it's a problem in 15.10+ To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1609538/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1608305] Re: Can't delete a block in Safari
** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 ** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1608305 Title: Can't delete a block in Safari Status in Mahara: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Bug description: OS: X El Capitan Browser: Safari 9 Mahara: 16.10 Not able to delete a block/content created from Page editor when delete button is click Test step: 1. Log on as User 2. From Profile>Page 3. Click Edit on existing Page 4. Click on a content from the side panel>Block is added on the page 5. Edit and Delete button is displayed from the block 6. Click Delete Result: Block is not deleted To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1608305/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1587950] Re: Warning message not in a warning color
** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 ** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1587950 Title: Warning message not in a warning color Status in Mahara: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Confirmed Bug description: The warning message, that is intended to prevent users from accidentally editing/deleting a note in more than one place uses a color that does not convey the intent of a warning. This may lead to unintentional consequences, that might be prevented by a more suitable color[1]. Mahara Version: 15.10.3 [1]:https://infinum.co/the-capsized-eight/articles/ux-quick-tip-the- proper-way-of-handling-notifications To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1587950/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1598962] Re: choose template .tpl needs styling
** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 ** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1598962 Title: choose template .tpl needs styling Status in Mahara: Fix Committed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Bug description: To test: 1) On an installed site go to a page's edit screen, and make note if the id in the url eg id=50 2) Via database set that view's theme to something non-existant, eg: UPDATE view SET theme = 'thundercats' WHERE id = 50; 3) Reload the page - you should be taken to a 'choose theme' page To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1598962/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1560329] Re: The block config's "cancel" button breaks after a Pieform validation failure
** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 ** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1560329 Title: The block config's "cancel" button breaks after a Pieform validation failure Status in Mahara: In Progress Status in Mahara 15.10 series: In Progress Status in Mahara 16.04 series: In Progress Status in Mahara 16.10 series: In Progress Bug description: To replicate: 1. Drag a new "external media" block into your page. 2. In the block config modal that opens up, hit "submit" without filling in the required "URL or embed code" field 3. Press "Submit" 4. Wait for the form to reload and display the warning message telling you about the required field 5. Once that loads up, press the "Cancel" or "Remove" button/link next to the "Submit" button. Expected result: The block config modal window closes, and the new external media block is no longer on your page Actual result: The screen reloads, and you now have an empty "external media" block on your page The reason this is happening, is because the Pieforms "cancel" button by default just reloads the form's action URL, or the cancel button's "goto" URL. When we load up the block config modal, we use Javascript code to rewire the cancel button so that it instead closes the modal and, if the block is new, deletes the block. However, when Pieforms fails validation, Pieforms actually removes the current form displayed on the page, and replaces it with a new form that contains the validation errors. Because this is a completely different form object, the "rewiring" that we did when we opened the modal no longer applies. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1560329/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1597117] Re: Can't save share access form on Windows in Edge
** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 ** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1597117 Title: Can't save share access form on Windows in Edge Status in Mahara: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Confirmed Bug description: https://mahara.org/interaction/forum/topic.php?id=7630 I could replicate the issue in Windows 10 using Edge 13. Steps to replicate: 1. Create a couple of user accounts and groups. 2. Create a page as a user. 3. Share the page with another user selecting the "Share -> Search for: Users" option so that you are prompted to search for a user's name. Select a name. 4. Click the "Save" button. Repeat the same for "Groups" and "Friends". Expected result: The form saves properly. Actual result: You stay on the form. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1597117/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1554247] Re: comments with attachments - attachment titles and links display on main portfolio page
** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 ** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1554247 Title: comments with attachments - attachment titles and links display on main portfolio page Status in Mahara: Triaged Status in Mahara 15.10 series: Triaged Status in Mahara 16.04 series: Triaged Status in Mahara 16.10 series: Triaged Bug description: I'm running 15.10.1 and have the following problem: We use the portfolios for a standard process that requires people to attach letters to note blocks on the page. When they do add the attachments, sometimes the attachment filenames (actually, links to the attachments) are visible on the main portfolio page, sometimes in a list and sometimes on top of one another. They "float" above the page, meaning that if I scroll the page up and down, the attachment filenames/links do not move up and down with the page. This display bug is reproducible on multiple browsers (Safari, Chrome). I'd hoped that the 15.10.1 patch would resolve this issue, but it did not. thanks, Fran To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1554247/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1530611] Re: "Recent journal entries" displays group journal in private portfolio area
** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 ** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1530611 Title: "Recent journal entries" displays group journal in private portfolio area Status in Mahara: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Confirmed Bug description: Mahara 15.10+ When you have a journal entry in a group forum and you select the "Recent journal entries" block on a personal portfolio page (not a group portfolio page), you see the group journal listed. This is not the case for the blocks "Journal" and "Journal entry". Th group journal should only be visible for a group page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1530611/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1528991] Re: Indent second line of notification in Inbox
** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 ** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1528991 Title: Indent second line of notification in Inbox Status in Mahara: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Confirmed Bug description: Mahara 15.10+ When the subject line of a notification is very long, the name pops to the second line when on a tablet for example. That second line is not indent, but should only start where the text starts on the first line (see attachment) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1528991/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1487274] Re: Elasticsearch choking on non-ASCII characters
** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 ** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1487274 Title: Elasticsearch choking on non-ASCII characters Status in Mahara: Confirmed Status in Mahara 1.10 series: Won't Fix Status in Mahara 1.9 series: Won't Fix Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Bug description: In 15.10 I've added code to "quarantine" records that Elasticsearch won't index. That is, if Elasticsearch errors out while processing a batch of records, then I re-try each record individually. And if it errors out while processing one of those individual records, I mark the record as quarantined, and keep it in the search_elasticsearch_queue table. I've backported that to one of our large 15.04 sites, and since then I've taken a look at the data in the records that have caused Elasticsearch to choke. They all contain non-ASCII characters, i.e. Unicode characters. These can be as simple as "e with an accent over it", all the way up to exotic ones like emoji and the Unicode snowman. I was not able to replicate this when testing on my local machine, but it is certainly in place on our production servers, and bugs such as Bug 1408577 make me think it's probably also present on some other servers as well. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1487274/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1386000] Re: Don't display submitted pages in "Pages / collections shared with this group"
** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 ** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1386000 Title: Don't display submitted pages in "Pages / collections shared with this group" Status in Mahara: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: New Bug description: When a user submits a page / collection to a group, the group admin sees it both under "Pages / collections shared with this group" and "Submitted pages / collections". This is confusing as the pages / collections show up twice and it's not easy to see that they have actually been submitted only. I think it would be best to show submitted pages that have not been shared with the rest of the group only in "Submitted pages / collections". To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1386000/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1543403] Re: TinyMCE full screen not working in IE10 for 15.10.1
** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 ** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1543403 Title: TinyMCE full screen not working in IE10 for 15.10.1 Status in Mahara: Triaged Status in Mahara 15.10 series: Triaged Status in Mahara 16.04 series: Triaged Status in Mahara 16.10 series: Triaged Bug description: In IE10 (win7), tinyMCE is not going full screen when clicking the expand button from the menu. This problem occurs when editing a text box in the Portfolio - Pages. Assume this happens on all instances of TinyMCE and using the RAW theme (core issue with all themes that inherit RAW). Problem was found by a client using the Primary School theme. TinyMCE works correctly in IE11. May the force be with you for this one. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1543403/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1482470] Re: Position and configure block dialogs no longer have focus management
** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 ** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1482470 Title: Position and configure block dialogs no longer have focus management Status in Mahara: In Progress Status in Mahara 15.10 series: In Progress Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Confirmed Bug description: With the new Bootstrap theme, it is still possible to add blocks using the keyboard (by pressing Enter when focused on a block type in the accordion) but the dialogs that appear no longer have focus management, making it appear to screen reader users as if nothing has happened. The old behaviour (focusing the dialog close button when it opens) needs to be reimplemented or fixed. Affects latest master To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1482470/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1540534] Re: Page comment moderation doesn't affect artefact comments
** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 ** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1540534 Title: Page comment moderation doesn't affect artefact comments Status in Mahara: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Bug description: Seen on mahara.org and tested on latest master (16.04). When you turn on comment moderation for a page, that moderation only goes for page comments but not artefact comments. Artefact comments should be treated the same in that regard as there is no separate moderation possibility. This loophole can be misused by anonymous people to post comments on an artefact that are immediately visible to everyone. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1540534/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1422264] Re: IPv6 Compliance
** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 ** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1422264 Title: IPv6 Compliance Status in Mahara: Confirmed Status in Mahara 15.04 series: Won't Fix Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Confirmed Bug description: Mahara: 15.04 DB: any Browser: any OS: any Currently, Mahara is not compliant with the IPv6 protocol. Some places that need to change (where IP addresses are validated/checked): - SAML auth - validate URL Syntax (preg_match for IPv6 also). - DB: table - host.ipaddress needs to cater for 128 bit address. - Peer bootstrap: 1) preg-match should also include IPv6 format; 2) use of PHP function gethostbyname(). - Zend third part library - current version only supports IPv4. We currently use version 1.10.6. MNET heavily relise on Zend. The latest Zend is on version 3. But there is a release for 1.12.11 - which still doesn't support IPv6 (as far as I can tell). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1422264/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1317354] Re: Flowplayer audio starts muted if there's also a Flowplayer video on the page
** Changed in: mahara Milestone: 15.10.5 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1317354 Title: Flowplayer audio starts muted if there's also a Flowplayer video on the page Status in Mahara: Won't Fix Bug description: To replicate: 1. Create a page 2. Put an embedded media block on the page with an audio file selected 3. Put an embedded media block on the page with a video file selected (with a type of video that's played by flowplayer) 4. View the page in display mode Result: The audio player's volume is set to muted To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1317354/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1572825] Re: voki externalmedia embed code changed
** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 ** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1572825 Title: voki externalmedia embed code changed Status in Mahara: Confirmed Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Confirmed Bug description: A recent support post on the Mahara forums has highlighted that the externalmedia flags the voki URL invalid: https://mahara.org/interaction/forum/topic.php?id=4007&offset=0&limit=10#post30536 It appears that the links have changed and will require an update in Mahara. Previous voki bug: https://bugs.launchpad.net/mahara/+bug/905097 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1572825/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1603658] Re: "Other license (enter URL)" does not work
** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 ** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1603658 Title: "Other license (enter URL)" does not work Status in Mahara: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Bug description: When you choose the option "Other license (enter URL)" in your personal settings, file upload or other places, there is supposed to be a second field that comes up in which you can enter the URL for that new license. This isn't happening in Mahara 15.10+ and probably got lost during the Bootstrap conversion. To test: 1. Go to "Administration -> Configure Site -> General Settings", and enable "License metadata" and "Custom licenses". 2. Change your default license in your account settings /account/index.php to "Other license (enter URL)". Expected result: Another text field opens up where you can enter the URL for this new license. Actual result: Nothing happens. Other places where this happens: Any artefact where you can choose a license. It still works in Mahara 15.04 prior to the move to Bootstrap. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1603658/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1575923] Re: Mathslate/MathJax fails to load on https
** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 ** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1575923 Title: Mathslate/MathJax fails to load on https Status in Mahara: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Confirmed Bug description: On HTTPS-enabled sites, the Mathslate tinymce plugin fails, due to loading http:// resources from yui.yahooapis.com and cdn.mathjax.org. The file htdocs/js/tinymce/plugins/mathslate/mathslate.html is hardcoded to pull http:// versions of these scripts (lines 11-12). Ultimately this is an upstream bug, but it's one that affects https- enabled Mahara sites. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1575923/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1597536] Re: import_entry_requests table needs a ctime so we can clean up old partial requests
** Changed in: mahara/15.10 Milestone: 15.10.5 => 16.04.3 ** Changed in: mahara/15.10 Milestone: 16.04.3 => 15.10.6 ** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1597536 Title: import_entry_requests table needs a ctime so we can clean up old partial requests Status in Mahara: In Progress Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Bug description: A ctime will allow us to clean up the old entries via a new (or possibly existing) cronjob And we need to make the stored path to the files be relative to dataroot rather than full path from '/' on server as we shouldn't be recording that info in the db. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1597536/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1487299] Re: All edit and delete buttons should contain the name of what they manage
** Changed in: mahara/16.04
Milestone: 16.04.3 => 16.04.4
** Changed in: mahara/15.10
Milestone: 15.10.5 => 15.10.6
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1487299
Title:
All edit and delete buttons should contain the name of what they
manage
Status in Mahara:
Confirmed
Status in Mahara 15.10 series:
Confirmed
Status in Mahara 16.04 series:
Confirmed
Status in Mahara 16.10 series:
Confirmed
Bug description:
Reopening Bug #1276397 - in the new Bootstrap theme, all edit and
delete buttons seem to have descriptive text attached to them ("Edit"
and "Delete"), but it is sometimes ambiguous for screen reader users
which list item they refer to. In particular:
- On the My groups page, Settings and Delete buttons should contain the name
of the group (see Bug #1482482)
- In the Resume (Education and employment, Achievements) edit and delete
buttons should contain some information about the row they are on
- Under Journals, all Edit and Delete buttons should include the name of the
journal (or entry) they control
- Same for files in the file browser (eg. Content -> Files)
For an example of how to include this text, see the edit and delete
buttons in the list on Portfolio -> Pages.
There are probably other examples - they should be added here and then
could be spun off into separate bug reports for fixing.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1487299/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1467252] Re: Display problem with Switchbox when label strings aren't the same length as "On" & "Off"
** Changed in: mahara/15.10 Milestone: 15.10.5 => 15.10.6 ** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1467252 Title: Display problem with Switchbox when label strings aren't the same length as "On" & "Off" Status in Mahara: Incomplete Status in Mahara 15.10 series: Incomplete Status in Mahara 16.04 series: Incomplete Status in Mahara 16.10 series: Incomplete Bug description: It was ok in 15.04 but the the new interface of 15.10dev, the translated text for the "switch" options are not displayed correctly. 1/ When "On", the translated text for "on" is displayed, with the text for "off" partially 2/ When "Off", the translated text for "off" is displayed centered below the the red bullet (see inclosed picture) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1467252/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1565199] Re: Journals that you can't add entries to appear in drop-down for "Add new entry" in "Recent journal entries" block
** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1565199 Title: Journals that you can't add entries to appear in drop-down for "Add new entry" in "Recent journal entries" block Status in Mahara: Confirmed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Confirmed Bug description: 16.04.rc1 You can place the "Recent journal entries" block on any page and when you place it on a personal or group page, you also see other journals, e.g. institution and site (on a personal page) and site (on a group page). However, when you include these journals in your block, they also appear in the drop-down menu where you can choose in which journal you want to create a new entry. When you choose an institution or site journal and are not an institution admin or site admin, you only see: Access denied You do not have access to view this page. [[youarenotasiteadmin/artefact.blog]] You should not be able to see the journals in the drop-down menu to which you cannot add an entry. There are other two related bugs that should be fixed at the same time: 1. Bug #1565198: "Recent journal entries" block should mention journal context in config 2. Bug #1565197: Selecting "Site journal" in "Recent journal entries" block in a group just spins To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1565199/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1575717] Re: Help for plugin artefact comment is too far left
** Changed in: mahara Milestone: 16.04.3 => 16.04.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1575717 Title: Help for plugin artefact comment is too far left Status in Mahara: New Bug description: When setting the preference for Admin -> Extention -> Comment and click on the Help icon, the help content is display too far on the left of the screen Latest 16.04 RC Firefox / Safari / Chrome To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1575717/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1602447] Re: Can't use ">" CSS selector in skins
** Changed in: mahara/16.04
Status: Fix Committed => Fix Released
** Changed in: mahara/15.10
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1602447
Title:
Can't use ">" CSS selector in skins
Status in Mahara:
Fix Committed
Status in Mahara 15.04 series:
Fix Released
Status in Mahara 15.10 series:
Fix Released
Status in Mahara 16.04 series:
Fix Released
Status in Mahara 16.10 series:
Fix Committed
Bug description:
See https://mahara.org/interaction/forum/topic.php?id=7659
The ">" character is a basic selector in CSS, which allows you to
specify an element contained within another element. For example,
"div.class1 > span.class2" would match the span in
Don't style me. But style
me!
If you try to use a ">" in the "Custom CSS" section of a Mahara skin,
it gets turned into "\3E". Probably it's being accidentally over-
escaped at some point, because ">" is a syntactically important
character in HTML.
To replicate:
1. Create a Mahara skin
2. On the skin editor go to the "Advanced" tab
3. In "Custom CSS" enter this:
body > .main-content > .row {
background-color: red;
}
4. Click "Save" (this closes the skin editor)
5. Edit the skin again, and navigate back to the Advanced tab.
Expected result: The "Custom CSS" field shows what you entered before
Actual result: The ">" in the Custom CSS field has been turned into "\3E".
Further test:
1. Apply the skin you selected in the previous test, to a Mahara page.
2. View the page in display mode.
Expected result: The page background is red.
Actual result: No change in the the appearance of the page.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1602447/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1568611] Re: Comment ratings are not accessible
** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1568611 Title: Comment ratings are not accessible Status in Mahara: Confirmed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Confirmed Bug description: Mahara 16.04dev The new star ratings are not accessible and would need screen-reader only text. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1568611/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1609200] Re: Non-admin role users can edit group settings
** Changed in: mahara/15.04 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1609200 Title: Non-admin role users can edit group settings Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Released Status in Mahara 16.04 series: Fix Released Status in Mahara 16.10 series: Fix Committed Bug description: Only the admin of a group should be able to change the group's settings (via group/edit.php). But any member of a group can view and edit the settings if they go to the URL directly: * http://my.mahara/group/edit.php?id=3 There is no check to make sure the user has admin role. To replicate: 1. Create a group as User 1. Note the group's id 2. Add User 2 to the group as a "member" (not an "admin") 3. Log in as User 2 4. Type in e.g. http://my.mahara/group/edit.php?id=X , where X is the group's ID Expected result: You get an error message saying "You can't edit this group" Actual result: You see the group config page, and you can make changes and they will be saved. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1609200/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1563143] Re: Breakage around dropzone error hander callbacks
** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1563143 Title: Breakage around dropzone error hander callbacks Status in Mahara: In Progress Status in Mahara 15.10 series: Fix Released Status in Mahara 16.04 series: Triaged Status in Mahara 16.10 series: Triaged Bug description: Catalyst received a bug report from a customer who is using recent Mahara (15.10.1). The initial bug report is that if "Require agreement" is enabled in admin/extensions/pluginconfig.php?plugintype=artefact&pluginname=file&type=file and a user attempts to upload a file without first ticking the agreement box, they get a message saying the box needs to be ticked but the preview of the file also has a green tick (implying it was actually uploaded). In my investigation of the issue, I found multiple issues: 1) Dropzone's internal handling puts the green tick there on the basis of the server status. Setting the http response code to 403 (Forbidden) fixed that. 2) Dropzone's internal handling assumes that any text returned when an error occurs is an HTML (not JSON) description of the error, and therefore puts the raw HTML in 'tooltip' for the red X. The raw HTML also ends up being displayed in the files_filebrowser_upload_messages div because the JSON.parse doesn't get called in the error handler function. I have prepared a patch that addresses both these issues, but I don't think it's the entire solution. I'd also suggest that beginning the upload should be rejected if the box hasn't been ticked. This would avoid the scenario wherein a user attempts to upload a large file on a slow connection, only to be told after the file has been sent that it's not been saved only because they didn't tick the box. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1563143/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1609200] Re: Non-admin role users can edit group settings
** Changed in: mahara/15.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1609200 Title: Non-admin role users can edit group settings Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Released Status in Mahara 16.04 series: Fix Released Status in Mahara 16.10 series: Fix Committed Bug description: Only the admin of a group should be able to change the group's settings (via group/edit.php). But any member of a group can view and edit the settings if they go to the URL directly: * http://my.mahara/group/edit.php?id=3 There is no check to make sure the user has admin role. To replicate: 1. Create a group as User 1. Note the group's id 2. Add User 2 to the group as a "member" (not an "admin") 3. Log in as User 2 4. Type in e.g. http://my.mahara/group/edit.php?id=X , where X is the group's ID Expected result: You get an error message saying "You can't edit this group" Actual result: You see the group config page, and you can make changes and they will be saved. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1609200/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1607133] Re: Quotation marks in a page titled render as "" " if the page is in a collection
** Changed in: mahara/15.10
Status: Fix Committed => Fix Released
** Changed in: mahara/16.04
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1607133
Title:
Quotation marks in a page titled render as """ if the page is in
a collection
Status in Mahara:
Fix Committed
Status in Mahara 15.10 series:
Fix Released
Status in Mahara 16.04 series:
Fix Released
Status in Mahara 16.10 series:
Fix Committed
Bug description:
If a page is in a collection, quotation marks in its title get double-
HTML-escaped when you view the page in display mode. See screenshot.
To replicate:
1. Create a page with one or more quotation marks (") in its title.
2. Create a collection.
3. Add the page to the collection.
4. View the page in display mode.
Expected result: The quotation mark in the page title is rendered as a
quotation mark (")
Actual result: The quotation mark in the page title is rendered as """
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1607133/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1565197] Re: Selecting "Site journal" in "Recent journal entries" block in a group just spins
** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1565197 Title: Selecting "Site journal" in "Recent journal entries" block in a group just spins Status in Mahara: Confirmed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: New Bug description: 16.04.rc1 How to test: 1. Create a site journal as site admin and add 1 entry. 2. Create a group as regular user 3. Set up a group journal in that group and add 1 entry. 4. Create a page. 5. Place the "Recent journal entries" block onto the page and select the group and site journal. 6. Expected result: The config is saved. Actual result: The config modal stays open and the spinning icon is displayed. If you only select the group journal everything is fine. Note: When you are the site admin and a member of the group, you can place the site journal onto the group page. There are other two related bugs that should be fixed at the same time: 1. Bug #1565198: "Recent journal entries" block should mention journal context in config 2. Bug #1565199: Journals that you can't add entries to appear in drop-down for "Add new entry" in "Recent journal entries" block To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1565197/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1568619] Re: Open Badge details aren't accessible with screenreader
** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1568619 Title: Open Badge details aren't accessible with screenreader Status in Mahara: Confirmed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Confirmed Bug description: Mahara 16.04dev When you have an Open Badge in a page and you just use a screenreader and click on the Open Badge image, the modal with the information about the badge does not appear. I suspect the on.click Javascript is the culprit. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1568619/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1606094] Re: Changing the file quota for users in an institution, can send notifications to users in other institutions
** Changed in: mahara/16.04 Status: Fix Committed => Fix Released ** Changed in: mahara/15.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1606094 Title: Changing the file quota for users in an institution, can send notifications to users in other institutions Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Released Status in Mahara 16.04 series: Fix Released Status in Mahara 16.10 series: Fix Committed Bug description: On the institution config screen, there's a setting called "Update user quotas" that will do a one-time application of the institution's current "default quota" value to all existing users of the institution. At the same time, if you're using the "quota almost exceeded" notification emails, it will check each user whose quota has just been changed and send them a notification if they're near the threshold. The first part of this works fine. It does indeed update the quota for members of the changed institution, and nobody else. But there's a bug in the second part, that sends out the notifications. Instead of only checking the users in the institution, it checks *every* user in the site, and sends a notification to any of them who are near the threshold for the changed institution. This is not only annoying to users who aren't in the institution, but also confusing, because the email will tell them that their quota is the size of the changed institution's quota, when in fact their quota has not changed. To replicate: 1. Clean Mahara install 2. Log in as admin 3. Upload a 1MB file into your File -> Contents area 4. Create an institution. Save the institution. 5. Click the "edit" link for the institution. 6. Set "Default quota" to 100 Kilobytes. 7. Set "Update user quotas" to "On" 8. Click "Submit" Expected result: The admin user should not receive a notification, because they're not in that institution and their quota has not changed. Actual result: The admin user receives a notification about being over their quota, but their quota has not actually changed from the default 50MB. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1606094/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1609112] Re: The is_plugin_active() function can give false positives
** Changed in: mahara/15.04 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1609112 Title: The is_plugin_active() function can give false positives Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Released Status in Mahara 16.04 series: Fix Released Status in Mahara 16.10 series: Fix Committed Bug description: This is due to the fact that we have different plugin types with the same name, eg: Artefact | Blocktype ---+ blog | blog comment| comment annotation | annotation And that we check the type 'artefact' first so in the case of the Artefact 'annotation' being active but the blocktype 'annotation' not being active we will get 'true' from is_plugin_active() We need to alter the function and pass it a 'type' so we can indicate which of the types we are interested in. I'll mark this as 'high' as this could lead to confusion in the use of the function. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1609112/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1609112] Re: The is_plugin_active() function can give false positives
** Changed in: mahara/15.10 Status: Fix Committed => Fix Released ** Changed in: mahara/16.04 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1609112 Title: The is_plugin_active() function can give false positives Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Released Status in Mahara 16.04 series: Fix Released Status in Mahara 16.10 series: Fix Committed Bug description: This is due to the fact that we have different plugin types with the same name, eg: Artefact | Blocktype ---+ blog | blog comment| comment annotation | annotation And that we check the type 'artefact' first so in the case of the Artefact 'annotation' being active but the blocktype 'annotation' not being active we will get 'true' from is_plugin_active() We need to alter the function and pass it a 'type' so we can indicate which of the types we are interested in. I'll mark this as 'high' as this could lead to confusion in the use of the function. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1609112/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1602447] Re: Can't use ">" CSS selector in skins
** Changed in: mahara/15.04
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1602447
Title:
Can't use ">" CSS selector in skins
Status in Mahara:
Fix Committed
Status in Mahara 15.04 series:
Fix Released
Status in Mahara 15.10 series:
Fix Released
Status in Mahara 16.04 series:
Fix Released
Status in Mahara 16.10 series:
Fix Committed
Bug description:
See https://mahara.org/interaction/forum/topic.php?id=7659
The ">" character is a basic selector in CSS, which allows you to
specify an element contained within another element. For example,
"div.class1 > span.class2" would match the span in
Don't style me. But style
me!
If you try to use a ">" in the "Custom CSS" section of a Mahara skin,
it gets turned into "\3E". Probably it's being accidentally over-
escaped at some point, because ">" is a syntactically important
character in HTML.
To replicate:
1. Create a Mahara skin
2. On the skin editor go to the "Advanced" tab
3. In "Custom CSS" enter this:
body > .main-content > .row {
background-color: red;
}
4. Click "Save" (this closes the skin editor)
5. Edit the skin again, and navigate back to the Advanced tab.
Expected result: The "Custom CSS" field shows what you entered before
Actual result: The ">" in the Custom CSS field has been turned into "\3E".
Further test:
1. Apply the skin you selected in the previous test, to a Mahara page.
2. View the page in display mode.
Expected result: The page background is red.
Actual result: No change in the the appearance of the page.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1602447/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1568613] Re: The screenreader "Remove" doesn't do anything
** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1568613 Title: The screenreader "Remove" doesn't do anything Status in Mahara: Confirmed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Confirmed Bug description: Mahara 16.04dev When you want to remove a tag (in the new tag search) or a person (when sending a message) just using a screenreader, clicking the "Remove" item doesn't do anything. The tag / user is not removed. Remove "interesting" It's just a screenreader issue and works fine for sighted. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1568613/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1606094] Re: Changing the file quota for users in an institution, can send notifications to users in other institutions
** Changed in: mahara/15.04 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1606094 Title: Changing the file quota for users in an institution, can send notifications to users in other institutions Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Released Status in Mahara 16.04 series: Fix Released Status in Mahara 16.10 series: Fix Committed Bug description: On the institution config screen, there's a setting called "Update user quotas" that will do a one-time application of the institution's current "default quota" value to all existing users of the institution. At the same time, if you're using the "quota almost exceeded" notification emails, it will check each user whose quota has just been changed and send them a notification if they're near the threshold. The first part of this works fine. It does indeed update the quota for members of the changed institution, and nobody else. But there's a bug in the second part, that sends out the notifications. Instead of only checking the users in the institution, it checks *every* user in the site, and sends a notification to any of them who are near the threshold for the changed institution. This is not only annoying to users who aren't in the institution, but also confusing, because the email will tell them that their quota is the size of the changed institution's quota, when in fact their quota has not changed. To replicate: 1. Clean Mahara install 2. Log in as admin 3. Upload a 1MB file into your File -> Contents area 4. Create an institution. Save the institution. 5. Click the "edit" link for the institution. 6. Set "Default quota" to 100 Kilobytes. 7. Set "Update user quotas" to "On" 8. Click "Submit" Expected result: The admin user should not receive a notification, because they're not in that institution and their quota has not changed. Actual result: The admin user receives a notification about being over their quota, but their quota has not actually changed from the default 50MB. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1606094/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1609200] Re: Non-admin role users can edit group settings
** Changed in: mahara/16.04 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1609200 Title: Non-admin role users can edit group settings Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Released Status in Mahara 16.04 series: Fix Released Status in Mahara 16.10 series: Fix Committed Bug description: Only the admin of a group should be able to change the group's settings (via group/edit.php). But any member of a group can view and edit the settings if they go to the URL directly: * http://my.mahara/group/edit.php?id=3 There is no check to make sure the user has admin role. To replicate: 1. Create a group as User 1. Note the group's id 2. Add User 2 to the group as a "member" (not an "admin") 3. Log in as User 2 4. Type in e.g. http://my.mahara/group/edit.php?id=X , where X is the group's ID Expected result: You get an error message saying "You can't edit this group" Actual result: You see the group config page, and you can make changes and they will be saved. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1609200/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1606435] Re: Not sending enough parameters to "useroverquotathreshold" lang string
** Changed in: mahara/15.04
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606435
Title:
Not sending enough parameters to "useroverquotathreshold" lang string
Status in Mahara:
Fix Committed
Status in Mahara 15.04 series:
Fix Released
Status in Mahara 15.10 series:
Fix Released
Status in Mahara 16.04 series:
Fix Released
Status in Mahara 16.10 series:
Fix Committed
Bug description:
The lang string "useroverquotathreshold" in artefact.file.php expects
three sprintf parameters, but in the two places we use it, we only use
one parameter. As a result, it prints a warning message to the error
logs, and the string it should print is replaced with an empty string.
Here's the warning message:
[WAR] 37 (lib/mahara.php:1418) sprintf(): Too few arguments
Call stack (most recent first):
* log_message("sprintf(): Too few arguments", 8, true, true,
"/home/aaronw/www/mahara/htdocs/lib/mahara.php", 1418) at
/home/aaronw/www/mahara/htdocs/lib/errors.php:489
* error(2, "sprintf(): Too few arguments",
"/home/aaronw/www/mahara/htdocs/lib/mahara.php", 1418, array(size 3)) at
Unknown:0
* sprintf("User %s has arrived at %s%% percent of their %s qu...", "user1
user1 (user1)") at Unknown:0
* call_user_func_array("sprintf", array(size 2)) at
/home/aaronw/www/mahara/htdocs/lib/mahara.php:1418
* format_langstring("User %s has arrived at %s%% percent of their %s
qu...", array(size 1), "en.utf8") at
/home/aaronw/www/mahara/htdocs/lib/mahara.php:505
* get_string_location("useroverquotathreshold", "artefact.file",
array(size 1)) at /home/aaronw/www/mahara/htdocs/lib/mahara.php:294
* get_string("useroverquotathreshold", "artefact.file", "user1 user1
(user1)") at /home/aaronw/www/mahara/htdocs/admin/users/edit.php:405
* edituser_site_submit(object(Pieform), array(size 16)) at Unknown:0
* call_user_func_array("edituser_site_submit", array(size 2)) at
/home/aaronw/www/mahara/htdocs/lib/pieforms/pieform.php:540
* Pieform->__construct(array(size 6)) at
/home/aaronw/www/mahara/htdocs/lib/pieforms/pieform.php:161
* Pieform::process(array(size 6)) at
/home/aaronw/www/mahara/htdocs/lib/mahara.php:4730
* pieform(array(size 6)) at
/home/aaronw/www/mahara/htdocs/admin/users/edit.php:265
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606435/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1189823] Re: Pieforms attempts to load renderer plugin even when already loaded
** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1189823 Title: Pieforms attempts to load renderer plugin even when already loaded Status in Mahara: Incomplete Status in Mahara 16.04 series: Incomplete Bug description: This prevents plugins from providing their own form renderers (useful for working around issues like #1181966 -- nested fieldsets are broken). I've attached a patch to the Pieforms library which changes the behaviour a little bit; if the renderer function already exists, we'll skip the loading process. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1189823/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514275] Re: Add a minaccept to look for the "empty()" function called with a non-variable argument
** Changed in: mahara
Milestone: 16.04.3 => 16.04.4
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1514275
Title:
Add a minaccept to look for the "empty()" function called with a non-
variable argument
Status in Mahara:
Confirmed
Bug description:
We've had a few bugs now caused by people calling the PHP empty()
function with a parameter that is not a single variable. (And at least
one caused by putting empty() into a Dwoo template, where its argument
was parsed by Dwoo into an expression.)
This causes a problem because we support PHP 5.3+, and prior to PHP
5.5 it causes a fatal exception if you try to call empty() with an
argument that is not a single variable.
I think this should actually be a pretty easy one to check for,
fortunately. We just need to check for "empty(" followed by a
character that isn't "$", so a regex like this: /\bempty\(\s*[^$]/i
And in Dwoo templates, where empty() can't be used at all because
there's no guarantee of what Dwoo will parse it into, we'd check for
it in the form "empty()" or in the Dwoo tag pipe syntax "|empty":
/(\bempty\(|\|empty\b)/i
Note that any regex to check for this would need to be case-
insensitive, because PHP function calls are not case sensitive.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1514275/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1606432] Re: Fatal error trying to manually update a user's quota
** Changed in: mahara/15.04
Status: Fix Committed => Fix Released
** Changed in: mahara/15.10
Status: Fix Committed => Fix Released
** Changed in: mahara/16.04
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606432
Title:
Fatal error trying to manually update a user's quota
Status in Mahara:
Fix Committed
Status in Mahara 15.04 series:
Fix Released
Status in Mahara 15.10 series:
Fix Released
Status in Mahara 16.04 series:
Fix Released
Status in Mahara 16.10 series:
Fix Committed
Bug description:
If you try to manually update a user's file quota setting, and you
change it to a low enough value that it will send that user an "over
the threshold" notification, Mahara crashes with this message:
Fatal error: Class 'PluginArtefact' not found in
/home/aaronw/www/mahara/htdocs/artefact/file/lib.php on line 14
Stack trace:, referer:
http://vegas.wgtn.cat-it.co.nz/mahara/htdocs/admin/users/edit.php?id=2
1. {main}() /home/aaronw/www/mahara/htdocs/admin/users/edit.php:0
2. pieform() /home/aaronw/www/mahara/htdocs/admin/users/edit.php:265
3. Pieform::process() /home/aaronw/www/mahara/htdocs/lib/mahara.php:4730
4. Pieform->__construct()
/home/aaronw/www/mahara/htdocs/lib/pieforms/pieform.php:161
5. call_user_func_array()
/home/aaronw/www/mahara/htdocs/lib/pieforms/pieform.php:540
6. edituser_site_submit()
/home/aaronw/www/mahara/htdocs/lib/pieforms/pieform.php:540
7. require_once() /home/aaronw/www/mahara/htdocs/admin/users/edit.php:402
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606432/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1605071] Re: Display something more error-like when an AJAX block errors out
** Changed in: mahara/15.10 Status: Fix Committed => Fix Released ** Changed in: mahara/16.04 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1605071 Title: Display something more error-like when an AJAX block errors out Status in Mahara: Fix Committed Status in Mahara 15.04 series: Won't Fix Status in Mahara 15.10 series: Fix Released Status in Mahara 16.04 series: Fix Released Status in Mahara 16.10 series: Fix Committed Bug description: Spinning this bug off from Bug 1544424 (Endless JS loop if there's an uncaught exception in an ajax block) since patch https://reviews.mahara.org/6055 has taken much longer than https://reviews.mahara.org/6054 to get merged. We no longer get an endless loop when an Ajax block errors out, but it still looks pretty bad. See the attached screenshot. Because the file "blocktype.ajax.php" doesn't have the "JSON" header at its top, when it errors out, Mahara tries to print the full error page with the navigation headers and the message "Mahara: Site unavailable", and then ajaxblocks.js tries to display it in the little iframe reserved for that block. This looks confusing to the user, and it can spill over out of that block's space and cover up adjacent blocks. It would be better if we printed something that more obviously indicates that just this one block is broken, and that doesn't break the display of other blocks. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1605071/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1431659] Re: Problems importing Annotations via Leap2a
** Changed in: mahara/16.04 Status: Fix Committed => Fix Released ** Changed in: mahara/15.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1431659 Title: Problems importing Annotations via Leap2a Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Released Status in Mahara 16.04 series: Fix Released Bug description: As reported on https://reviews.mahara.org/#/c/4123/: "When I import a Leap2A (a collection with two pages; one with a text and 2 annotation blocks and the other with an image block and an annotation block), I get "[INF] 83 (import/index.php:301) Leap2A import failed: Cannot find reflection entry for annotation." The text block does not have an embedded image. Just plain text." To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1431659/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1607669] Re: LDAP user sync incorrectly proceeds when LDAP list or search fails
** Changed in: mahara/15.04
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1607669
Title:
LDAP user sync incorrectly proceeds when LDAP list or search fails
Status in Mahara:
Fix Committed
Status in Mahara 15.04 series:
Fix Released
Status in Mahara 15.10 series:
Fix Released
Status in Mahara 16.04 series:
Fix Released
Status in Mahara 16.10 series:
Fix Committed
Bug description:
Mahara: 16.04
DB: Postgres
OS: Linux
The LDAP user sync is incorrectly continuing when the search in the
context fails to contact the server.
The following error is generated in the cron.log file:
Jul 29 00:01:05 server mahara-site: [WAR] 29 (auth/ldap/lib.php:937)
ldap_list(): Search: Can't contact LDAP server
Jul 29 00:01:05 server mahara-site: Call stack (most recent first):
Jul 29 00:01:05 server mahara-site: * log_message("ldap_list(): Search:
Can't contact LDAP server", 8, true, true,
"/var/www/mahara-site/auth/ldap/lib.php", 937)
at /var/www/mahara-site/lib/errors.php:489
Jul 29 00:01:05 server mahara-site: * error(2, "ldap_list(): Search: Can't
contact LDAP server", "/var/www/mahara-site/auth/ldap/lib.php", 937, array(size
11)) a
t Unknown:0
Jul 29 00:01:05 server mahara-site: * ldap_list(resource(#87),
"ou=people,o=ldapserver.xxx", "(uid=*)", array(size 5)) at
/var/www/mahara-site/auth/ldap/lib.php:937
Jul 29 00:01:05 server mahara-site: *
AuthLdap->ldap_get_users_scalable("auth_ldap_extusers_temp", "extusername", "")
at /var/www/mahara-site/auth/ldap/lib.php:1
121
Jul 29 00:01:05 server mahara-site: * AuthLdap->sync_users() at
/var/www/mahara-site/auth/ldap/lib.php:1614
Jul 29 00:01:05 server mahara-site: * PluginAuthLdap::auth_ldap_sync_cron()
at Unknown:0
Jul 29 00:01:05 server mahara-site: * call_user_func_array(array(size 2),
array(size 0)) at /var/www/mahara-site/lib/mahara.php:1714
Jul 29 00:01:05 server mahara-site: * call_static_method("PluginAuthLdap",
"auth_ldap_sync_cron") at /var/www/mahara-site/lib/cron.php:89
It then proceeds to sync the users:
Jul 29 00:01:05 server mahara-site: [WAR] 29 (auth/ldap/lib.php:940)
ldap_first_entry() expects parameter 2 to be resource, boolean given
Jul 29 00:01:05 server mahara-site: Call stack (most recent first):
Jul 29 00:01:05 server mahara-site: * log_message("ldap_first_entry()
expects parameter 2 to be resou...", 8, true, true,
"/var/www/mahara-site/auth/ldap/lib.php
", 940) at /var/www/mahara-site/lib/errors.php:489
Jul 29 00:01:05 server mahara-site: * error(2, "ldap_first_entry() expects
parameter 2 to be resou...", "/var/www/mahara-site/auth/ldap/lib.php", 940,
array(size
12)) at Unknown:0
Jul 29 00:01:05 server mahara-site: * ldap_first_entry(resource(#87),
false) at /var/www/mahara-site/auth/ldap/lib.php:940
Jul 29 00:01:05 server mahara-site: *
AuthLdap->ldap_get_users_scalable("auth_ldap_extusers_temp", "extusername", "")
at /var/www/mahara-site/auth/ldap/lib.php:1121
Jul 29 00:01:05 server mahara-site: * AuthLdap->sync_users() at
/var/www/mahara-site/auth/ldap/lib.php:1614
Jul 29 00:01:05 server mahara-site: * PluginAuthLdap::auth_ldap_sync_cron()
at Unknown:0
Jul 29 00:01:05 server mahara-site: * call_user_func_array(array(size 2),
array(size 0)) at /var/www/mahara-site/lib/mahara.php:1714
Jul 29 00:01:05 server mahara-site: * call_static_method("PluginAuthLdap",
"auth_ldap_sync_cron") at /var/www/mahara-site/lib/cron.php:89
Jul 29 00:01:05 server mahara-site:
Jul 29 00:01:05 server mahara-site: [WAR] 29 (auth/ldap/lib.php:971)
ldap_free_result() expects parameter 1 to be resource, boolean given
Jul 29 00:01:05 server mahara-site: Call stack (most recent first):
Jul 29 00:01:05 server mahara-site: * log_message("ldap_free_result()
expects parameter 1 to be resou...", 8, true, true,
"/var/www/mahara-site/auth/ldap/lib.php", 971) at
/var/www/mahara-site/lib/errors.php:489
Jul 29 00:01:05 server mahara-site: * error(2, "ldap_free_result() expects
parameter 1 to be resou...", "/var/www/mahara-site/auth/ldap/lib.php", 971,
array(size 13)) at Unknown:0
Jul 29 00:01:05 server mahara-site: * ldap_free_result(false) at
/var/www/mahara-site/auth/ldap/lib.php:971
Jul 29 00:01:05 server mahara-site: *
AuthLdap->ldap_get_users_scalable("auth_ldap_extusers_temp", "extusername", "")
at /var/www/mahara-site/auth/ldap/lib.php:1121
Jul 29 00:01:05 server mahara-site: * AuthLdap->sync_users() at
/var/www/mahara-site/auth/ldap/lib.php:1614
Jul 29 00:01:05 server mahara-site: * PluginAuthLdap::auth_ldap_sync_cron()
at Unknown:0
Jul 29 00:01:05 server mahara-site: * call_user_func_array(array(size 2
[Mahara-contributors] [Bug 1606435] Re: Not sending enough parameters to "useroverquotathreshold" lang string
** Changed in: mahara/15.10
Status: Fix Committed => Fix Released
** Changed in: mahara/16.04
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606435
Title:
Not sending enough parameters to "useroverquotathreshold" lang string
Status in Mahara:
Fix Committed
Status in Mahara 15.04 series:
Fix Released
Status in Mahara 15.10 series:
Fix Released
Status in Mahara 16.04 series:
Fix Released
Status in Mahara 16.10 series:
Fix Committed
Bug description:
The lang string "useroverquotathreshold" in artefact.file.php expects
three sprintf parameters, but in the two places we use it, we only use
one parameter. As a result, it prints a warning message to the error
logs, and the string it should print is replaced with an empty string.
Here's the warning message:
[WAR] 37 (lib/mahara.php:1418) sprintf(): Too few arguments
Call stack (most recent first):
* log_message("sprintf(): Too few arguments", 8, true, true,
"/home/aaronw/www/mahara/htdocs/lib/mahara.php", 1418) at
/home/aaronw/www/mahara/htdocs/lib/errors.php:489
* error(2, "sprintf(): Too few arguments",
"/home/aaronw/www/mahara/htdocs/lib/mahara.php", 1418, array(size 3)) at
Unknown:0
* sprintf("User %s has arrived at %s%% percent of their %s qu...", "user1
user1 (user1)") at Unknown:0
* call_user_func_array("sprintf", array(size 2)) at
/home/aaronw/www/mahara/htdocs/lib/mahara.php:1418
* format_langstring("User %s has arrived at %s%% percent of their %s
qu...", array(size 1), "en.utf8") at
/home/aaronw/www/mahara/htdocs/lib/mahara.php:505
* get_string_location("useroverquotathreshold", "artefact.file",
array(size 1)) at /home/aaronw/www/mahara/htdocs/lib/mahara.php:294
* get_string("useroverquotathreshold", "artefact.file", "user1 user1
(user1)") at /home/aaronw/www/mahara/htdocs/admin/users/edit.php:405
* edituser_site_submit(object(Pieform), array(size 16)) at Unknown:0
* call_user_func_array("edituser_site_submit", array(size 2)) at
/home/aaronw/www/mahara/htdocs/lib/pieforms/pieform.php:540
* Pieform->__construct(array(size 6)) at
/home/aaronw/www/mahara/htdocs/lib/pieforms/pieform.php:161
* Pieform::process(array(size 6)) at
/home/aaronw/www/mahara/htdocs/lib/mahara.php:4730
* pieform(array(size 6)) at
/home/aaronw/www/mahara/htdocs/admin/users/edit.php:265
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606435/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1570221] Re: Don't print parameter values in logs, in productionmode
** Changed in: mahara/15.04 Status: Fix Committed => Fix Released ** Changed in: mahara/15.10 Status: Fix Committed => Fix Released ** Changed in: mahara/16.04 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1570221 Title: Don't print parameter values in logs, in productionmode Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Released Status in Mahara 16.04 series: Fix Released Status in Mahara 16.10 series: Fix Committed Bug description: Following on from Bug 1567186, even scrubbing out parameters that we know to be passwords, is not a fool-proof way to keep passwords and sensitive data out of the logs. Params might be misnamed, or sensitive data might be passed through general-purpose functions. The only surefire way to prevent secure data from being printed to the logs, is to avoid printing parameter values in stacktraces at all. However, parameter values are useful for debugging, so I think we should show them productionmode=false, and hide them when productionmode=true. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1570221/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1607669] Re: LDAP user sync incorrectly proceeds when LDAP list or search fails
** Changed in: mahara/16.04
Status: Fix Committed => Fix Released
** Changed in: mahara/15.10
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1607669
Title:
LDAP user sync incorrectly proceeds when LDAP list or search fails
Status in Mahara:
Fix Committed
Status in Mahara 15.04 series:
Fix Released
Status in Mahara 15.10 series:
Fix Released
Status in Mahara 16.04 series:
Fix Released
Status in Mahara 16.10 series:
Fix Committed
Bug description:
Mahara: 16.04
DB: Postgres
OS: Linux
The LDAP user sync is incorrectly continuing when the search in the
context fails to contact the server.
The following error is generated in the cron.log file:
Jul 29 00:01:05 server mahara-site: [WAR] 29 (auth/ldap/lib.php:937)
ldap_list(): Search: Can't contact LDAP server
Jul 29 00:01:05 server mahara-site: Call stack (most recent first):
Jul 29 00:01:05 server mahara-site: * log_message("ldap_list(): Search:
Can't contact LDAP server", 8, true, true,
"/var/www/mahara-site/auth/ldap/lib.php", 937)
at /var/www/mahara-site/lib/errors.php:489
Jul 29 00:01:05 server mahara-site: * error(2, "ldap_list(): Search: Can't
contact LDAP server", "/var/www/mahara-site/auth/ldap/lib.php", 937, array(size
11)) a
t Unknown:0
Jul 29 00:01:05 server mahara-site: * ldap_list(resource(#87),
"ou=people,o=ldapserver.xxx", "(uid=*)", array(size 5)) at
/var/www/mahara-site/auth/ldap/lib.php:937
Jul 29 00:01:05 server mahara-site: *
AuthLdap->ldap_get_users_scalable("auth_ldap_extusers_temp", "extusername", "")
at /var/www/mahara-site/auth/ldap/lib.php:1
121
Jul 29 00:01:05 server mahara-site: * AuthLdap->sync_users() at
/var/www/mahara-site/auth/ldap/lib.php:1614
Jul 29 00:01:05 server mahara-site: * PluginAuthLdap::auth_ldap_sync_cron()
at Unknown:0
Jul 29 00:01:05 server mahara-site: * call_user_func_array(array(size 2),
array(size 0)) at /var/www/mahara-site/lib/mahara.php:1714
Jul 29 00:01:05 server mahara-site: * call_static_method("PluginAuthLdap",
"auth_ldap_sync_cron") at /var/www/mahara-site/lib/cron.php:89
It then proceeds to sync the users:
Jul 29 00:01:05 server mahara-site: [WAR] 29 (auth/ldap/lib.php:940)
ldap_first_entry() expects parameter 2 to be resource, boolean given
Jul 29 00:01:05 server mahara-site: Call stack (most recent first):
Jul 29 00:01:05 server mahara-site: * log_message("ldap_first_entry()
expects parameter 2 to be resou...", 8, true, true,
"/var/www/mahara-site/auth/ldap/lib.php
", 940) at /var/www/mahara-site/lib/errors.php:489
Jul 29 00:01:05 server mahara-site: * error(2, "ldap_first_entry() expects
parameter 2 to be resou...", "/var/www/mahara-site/auth/ldap/lib.php", 940,
array(size
12)) at Unknown:0
Jul 29 00:01:05 server mahara-site: * ldap_first_entry(resource(#87),
false) at /var/www/mahara-site/auth/ldap/lib.php:940
Jul 29 00:01:05 server mahara-site: *
AuthLdap->ldap_get_users_scalable("auth_ldap_extusers_temp", "extusername", "")
at /var/www/mahara-site/auth/ldap/lib.php:1121
Jul 29 00:01:05 server mahara-site: * AuthLdap->sync_users() at
/var/www/mahara-site/auth/ldap/lib.php:1614
Jul 29 00:01:05 server mahara-site: * PluginAuthLdap::auth_ldap_sync_cron()
at Unknown:0
Jul 29 00:01:05 server mahara-site: * call_user_func_array(array(size 2),
array(size 0)) at /var/www/mahara-site/lib/mahara.php:1714
Jul 29 00:01:05 server mahara-site: * call_static_method("PluginAuthLdap",
"auth_ldap_sync_cron") at /var/www/mahara-site/lib/cron.php:89
Jul 29 00:01:05 server mahara-site:
Jul 29 00:01:05 server mahara-site: [WAR] 29 (auth/ldap/lib.php:971)
ldap_free_result() expects parameter 1 to be resource, boolean given
Jul 29 00:01:05 server mahara-site: Call stack (most recent first):
Jul 29 00:01:05 server mahara-site: * log_message("ldap_free_result()
expects parameter 1 to be resou...", 8, true, true,
"/var/www/mahara-site/auth/ldap/lib.php", 971) at
/var/www/mahara-site/lib/errors.php:489
Jul 29 00:01:05 server mahara-site: * error(2, "ldap_free_result() expects
parameter 1 to be resou...", "/var/www/mahara-site/auth/ldap/lib.php", 971,
array(size 13)) at Unknown:0
Jul 29 00:01:05 server mahara-site: * ldap_free_result(false) at
/var/www/mahara-site/auth/ldap/lib.php:971
Jul 29 00:01:05 server mahara-site: *
AuthLdap->ldap_get_users_scalable("auth_ldap_extusers_temp", "extusername", "")
at /var/www/mahara-site/auth/ldap/lib.php:1121
Jul 29 00:01:05 server mahara-site: * AuthLdap->sync_users() at
/var/www/mahara-site/auth/ldap/lib.php:1614
Jul 29 00:01:05 server mahara-site: * PluginAuthLdap::auth_ldap_sync_cron()
at Unknown:0
[Mahara-contributors] [Bug 1600665] Re: Google calendar URLs no longer work in Google Apps block
** Changed in: mahara/15.04 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1600665 Title: Google calendar URLs no longer work in Google Apps block Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Released Status in Mahara 16.04 series: Fix Released Status in Mahara 16.10 series: Fix Committed Bug description: See https://mahara.org/interaction/forum/topic.php?id=7649 I'm guessing that Google has changed the URLs for their embed strings again, because the iframe embed snippet from Google Calendars no longer works in the Google Apps block. To replicate: 1. Get the "Embed this calendar" iframe snippet for a Google Calendar. (See http://manual.mahara.org/en/16.04/blocks/external.html#google- apps for details on how to do that) 2. Create a Mahara page with a Google Apps block 3. Past the embed code into the Google Apps block Expected result: The calendar is displayed, embedded into the page. Actual result: You see this error message in the block: "Unable to parse embedded code or URL: https://calendar.google.com/calendar/embed?src=example%40gmail.com&ctz=Pacific/Auckland"; style="border: 0" width="800" height="600" frameborder="0" scrolling="no">" To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1600665/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1513710] Re: Destructor methods that access global variables can cause crashes
** Changed in: mahara/16.04 Milestone: 16.04.3 => 16.04.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1513710 Title: Destructor methods that access global variables can cause crashes Status in Mahara: Confirmed Status in Mahara 16.04 series: Confirmed Bug description: See : https://mahara.org/interaction/forum/topic.php?id=7397 Here's the problem (which appears to be intermittent): 1. ArtefactType has a destructor method, which gets called when an artefact object is garbage-collected by PHP. 2. PHP runs destructor methods and garbage collects variables in no guaranteed order when exit() is called. 3. Sometimes the ArtefactType destructor method tries to call DML methods, which use the global variable $db 4. Apparently sometimes the $db global variable has already been garbage collected by the time the destructor runs 5. This causes a fatal "method on a non-object" crash. It's unclear why this error has only started happening recently. It might be due to a change in the behavior of PHP's garbage collector, or it might be from new Mahara code leaving some artefacts with their $dirty flag set (which triggers that artefact commit). In either case, both global variables and implicit destructor methods are considered harmful design practices, in part because of this particular thing. So it's high time we got rid of these __destruct() methods. Alternatively, as a workaround for older Mahara versions, we could add some code to the top of each __destruct() method that re-creates the global $db if it's not set. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1513710/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1443239] Re: Warning in Mahara logs when a MaharaDroid user has no tags in their Mahara account
** Changed in: mahara/16.04
Milestone: 16.04.3 => 16.04.4
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1443239
Title:
Warning in Mahara logs when a MaharaDroid user has no tags in their
Mahara account
Status in Mahara:
Confirmed
Status in Mahara 15.10 series:
Won't Fix
Status in Mahara 16.04 series:
Confirmed
Status in Mahara 16.10 series:
Confirmed
Bug description:
This is a bug in the Mahara PHP code which interfaces with the
MaharaDroid android app. See
https://github.com/MaharaProject/maharadroid/issues/6 for the
MaharaDroid side of this bug.
To replicate:
1. Create a new Mahara account
2. Connect it to MaharaDroid
3. Try to upload a file via MaharaDroid
Result: You see this warning in the Apache logs:
[Tue Jan 14 11:07:18 2014] [error] [client 10.22.33.88] [WAR] 88
(api/mobile/sync.php:77) Invalid argument supplied for foreach()
[Tue Jan 14 11:07:18 2014] [error] [client 10.22.33.88] Call stack (most
recent first):
[Tue Jan 14 11:07:18 2014] [error] [client 10.22.33.88] *
log_message("Invalid argument supplied for foreach()", 8, true, true,
"/home/demo/code/mahara/htdocs/api/mobile/sync.php", 77) at
/home/demo/code/mahara/htdocs/lib/errors.php:430
[Tue Jan 14 11:07:18 2014] [error] [client 10.22.33.88] * error(2, "Invalid
argument supplied for foreach()",
"/home/demo/code/mahara/htdocs/api/mobile/sync.php", 77, array(size 59)) at
/home/demo/code/mahara/htdocs/api/mobile/sync.php:77
[Tue Jan 14 11:07:18 2014] [error] [client 10.22.33.88]
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1443239/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1591760] Re: The link "Move to undefined" should not be displayed
** Changed in: mahara/15.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1591760 Title: The link "Move to undefined" should not be displayed Status in Mahara: Fix Committed Status in Mahara 15.10 series: Fix Released Status in Mahara 16.04 series: Fix Released Status in Mahara 16.10 series: Fix Committed Bug description: Version: master (16.10) Reported in https://mahara.org/interaction/forum/topic.php?id=7624 When I clicked an icon of a file in a sub folder, I saw the link "Move to undefined". This link is redundant. See the screenshot in the attached file To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1591760/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1489274] Re: Full copy of blog block with embedded images still causing problems
** Changed in: mahara/15.04 Status: Fix Committed => Fix Released ** Changed in: mahara/15.10 Status: Fix Committed => Fix Released ** Changed in: mahara/16.04 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1489274 Title: Full copy of blog block with embedded images still causing problems Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Released Status in Mahara 16.04 series: Fix Released Status in Mahara 16.10 series: Fix Committed Bug description: Bug 1476059 fixed some problems with copies of blogs that have embedded images. But, it didn't do a database update, so blog entries created before that bug fix will still cause problems. Here's how to replicate: 1. Install Mahara 15.04.2 2. Create a blog entry. 3. Use the TinyMCE "image" button to embed an image in the blog entry 4. Create a page 5. Put a blog entry block on the page. 6. Select the blog entry you created 7. Set the block's copy permission to "Others will get their own copy of your journal" 8. Share the page with registered users 9. Set the page to allow copying 10. Upgrade site to Mahara 15.04.3 11. Log in as a second user 12. Copy the page Expected result: You should see the image from the blog entry, on your copy of the page Actual result: The blog entry shows "undefined" where the image should be To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1489274/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1605127] Re: Mismatched function declaration, update_url() in lib/activity.php
** Changed in: mahara/15.04 Status: Fix Committed => Fix Released ** Changed in: mahara/15.10 Status: Fix Committed => Fix Released ** Changed in: mahara/16.04 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1605127 Title: Mismatched function declaration, update_url() in lib/activity.php Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Released Status in Mahara 16.04 series: Fix Released Status in Mahara 16.10 series: Fix Committed Bug description: Branch 16.04 In lib/activity.php at approx line 710 the function update_url() is declared. It has no parameters. However, at approx line 750 it is called and a parameter ($userdata->internalid) is used. One of them must be wrong, surely? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1605127/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1606101] Re: LDAP user sync using root ID to suspend users
** Changed in: mahara/15.04 Status: Fix Committed => Fix Released ** Changed in: mahara/15.10 Status: Fix Committed => Fix Released ** Changed in: mahara/16.04 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1606101 Title: LDAP user sync using root ID to suspend users Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Released Status in Mahara 16.04 series: Fix Released Status in Mahara 16.10 series: Fix Committed Bug description: Mahara: 16.04.2 DB: Postgres OS: Linux There is a bug with the LDAP sync when it is suspending users: htdocs/auth/ldap/cli/sync_users.php The user that is running the cron LDAP sync job is 'root' - has an ID of 0. Mahara updates the suspended user record with the userid that is doing the suspending (i.e. suspendedcusr = 0). When validating if a user record is suspended, we check if the suspending user id is empty. Because the suspending user ID is '0', it thinks that to the suspended user is not suspended - when they should be suspended. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1606101/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1605067] Re: Accessibility: Search text Placeholder goes away after tabbing into field
** Changed in: mahara/15.04 Status: Fix Committed => Fix Released ** Changed in: mahara/15.10 Status: Fix Committed => Fix Released ** Changed in: mahara/16.04 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1605067 Title: Accessibility: Search text Placeholder goes away after tabbing into field Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Released Status in Mahara 16.04 series: Fix Released Status in Mahara 16.10 series: Fix Committed Bug description: Mahara: 16.04.2 DB: Postgres Browser: Firefox OS: Linux The place holder text 'Search' in the site search field is removed after the user first tabs into the field. It is left empty thereafter. For accessibility, the 'Search' text should be replaced again after the user tabs out of the field and they have not entered any text. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1605067/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
