[Mahara-contributors] [Bug 1694874] Re: Quotation marks not escaped in name in group members block and when masquerading
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1694874 Title: Quotation marks not escaped in name in group members block and when masquerading Status in Mahara: Confirmed Bug description: When a user's name (first or last or display name) contains double quotation marks, they are not escaped and shown as " in the "Members" block on the group homepage. It's not a problem on the "Members" page, but just in the "Members" block on the group homepage. To replicate: 1. Set up a group and make sure that the group members block is displayed on the group homepage. 2. Add double quotation marks to your a) first name b) last name c) display name (in a separate test) 3. Go to the group homepage and check your name. Expected result: The double quotation marks are shown. Actual result: Instead they are displayed as " To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1694874/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1714082] Re: The user's primary email address is not checked in a case insensitive way
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1714082 Title: The user's primary email address is not checked in a case insensitive way Status in Mahara: Confirmed Bug description: Currently you can create 2 users, via the Admin -> Users -> Add user screen, with this: username: Test one email: us...@example.com username: Test two email: us...@example.com but not another user with username: Test three email: us...@example.com As it complains the email address 'us...@example.com' is used However, with email addresses the domain part is case insensitive and only the username part is case sensitive - yet saying that most email servers treat the username part also as case insensitive to avoid email delivery confusion - see https://www.lifewire.com/are-email- addresses-case-sensitive-117 To also avoid confusion within Mahara we should limit the primary email address to be case insensitive unique. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1714082/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1702748] Re: View ID appended at download URL from another Mahara site
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1702748 Title: View ID appended at download URL from another Mahara site Status in Mahara: Confirmed Bug description: Checked in 16.10 -> 17.04 When you have a public file on one Mahara site, link that for example in a journal entry on another Mahara site and make the page public, the file gets the viewID of that page appended even though there is no reason for it. It seems that Mahara only checks that /artefact/file/download.php?file= is present no matter the domain and then simply appends the viewID. To replicate: 1. Log into Mahara instance 1. 2. Upload a file into Admin menu -> Configure site -> Files -> Public. 3. Add the file to the public menu (to ensure that you are copying the correct download link that is available to people when not logged in): Admin menu -> Configure site -> Menus -> Public... 4. Copy the file's location. It should look something like http://domain.tld/artefact/file/download.php?file= 5. Log out of Mahara instance 1. 6. Log into Mahara instance 2. 7. Write a journal entry and link some text to the file. Save the entry. 8. Add your journal to a page and make it public. 9. View the page and hover over the link. Expected result: The link looks exactly the same as before and you can reach the file as it is a public one. Actual result: The link has a viewID appended, e.g. http://domain.tld/artefact/file/download.php?file=&view=YYY and if you are not logged into Mahara instance 1, you can't view it. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1702748/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1698255] Re: Update fontawesome
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1698255 Title: Update fontawesome Status in Mahara: In Progress Bug description: Currently we are on Font Awesome 4.4.0. The latest avaliable version on Fontawesome site is Version 4.7.0. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1698255/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1703262] Re: Deleting group journal entry for non-admin users
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1703262 Title: Deleting group journal entry for non-admin users Status in Mahara: Confirmed Bug description: Mahara: 16.10.4 DB: Postgres OS: Linux Browser: any Related to bug #1666102 (group member can delete journal). When a non-admin group member tries to delete a group journal's entries (i.e. not the whole journal), the page displays delete buttons next to the entry. But, in actual fact, the entries cannot be deleted (which is correct behaviour). This could make users confused. Please see attached screen shot. Perhaps don't display the delete button for users who cannot perform this action. Or, display page "Access denied... You do not have access" (as currently happens when trying to delete the whole journal). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1703262/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1698257] Re: Ensure that the header display correctly with or without site message
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1698257 Title: Ensure that the header display correctly with or without site message Status in Mahara: Confirmed Bug description: When the custom theme has taller logo it causes the header to be larger, sometimes this makes the secondary menu appear to be hidden or cutoff when there is no site message. Ensure that Raw and Old raw theme header display correctly with or without site message(s) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1698257/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1717136] Re: Hardcoded items for SAML config
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1717136 Title: Hardcoded items for SAML config Status in Mahara: In Progress Bug description: Some values in SP config for SAML is hardcoded. E.g.technicalcontact_email To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1717136/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1703261] Re: Help for tags does not display on Page->Edit->Settings form
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1703261 Title: Help for tags does not display on Page->Edit->Settings form Status in Mahara: In Progress Bug description: If you follow an existing page, click Edit, then settings, there's a help 'i' to the right of Tags. This doesn't display help text. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1703261/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1599414] Re: New composer-managed SimpleSAML breaks PHPUnit tests.
** No longer affects: mahara/17.10 ** No longer affects: mahara/17.04 ** Changed in: mahara Milestone: 17.04.1 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1599414 Title: New composer-managed SimpleSAML breaks PHPUnit tests. Status in Mahara: Confirmed Bug description: While writing a PHPUnit test for one of my patches, I noticed that the new composer-managed SimpleSAML, if present, breaks "make phpunit", because it contains some phpunit tests that get detected but are lacking the proper stuff to make them run correctly. To replicate: 1. Install the SimpleSAMLPHP library by doing "make ssphp" 2. Run phpunit tests by doing "make phpunit" Expected result: tests run with no failures Actual result: Tests fail out with this error message PHP Fatal error: Class 'SimpleSAML_Auth_ProcessingFilter' not found in /home/aaronw/www/mahara/htdocs/auth/saml/extlib/simplesamlphp/modules/exampleauth/lib/Auth/Process/RedirectTest.php on line 7 PHP Stack trace: PHP 1. {main}() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/composer/bin/phpunit:0 PHP 2. PHPUnit_TextUI_Command::main() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/composer/bin/phpunit:63 PHP 3. PHPUnit_TextUI_Command->run() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:129 PHP 4. PHPUnit_Runner_BaseTestRunner->getTest() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:150 PHP 5. PHPUnit_Framework_TestSuite->addTestFiles() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Runner/BaseTestRunner.php:96 PHP 6. PHPUnit_Framework_TestSuite->addTestFile() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:416 PHP 7. PHPUnit_Util_Fileloader::checkAndLoad() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:355 PHP 8. PHPUnit_Util_Fileloader::load() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Util/Fileloader.php:76 PHP 9. include_once() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Util/Fileloader.php:92 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1599414/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1622771] Re: Bulk delete doesnt work on safari
** Changed in: mahara/17.10 Milestone: 17.10.0 => 18.04.0 ** No longer affects: mahara/17.04 ** Also affects: mahara/18.04 Importance: Undecided Status: New ** Changed in: mahara/18.04 Milestone: None => 18.04.0 ** No longer affects: mahara/17.10 ** No longer affects: mahara/18.04 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1622771 Title: Bulk delete doesnt work on safari Status in Mahara: Confirmed Bug description: Version 16.04 and 16.10 Browser : safari Steps to reproduce: 1) Add few users as site administrators 2) Login as site administrator 3) Try to self-delete(site-administrator) the along with another users Expected Result: An error message should be displayed. Related to https://bugs.launchpad.net/mahara/+bug/1574941 Actual result: When trying to delete the users it stays on the page and does nothing Note: This also happens when an institution admin logs in and tries to self-delete with other users To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1622771/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1672930] Re: When you aren't allowed to edit / delete a page or collection you still see the icons
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1672930 Title: When you aren't allowed to edit / delete a page or collection you still see the icons Status in Mahara: Confirmed Bug description: Tested in Mahara 16.10 and a patch in review for 17.04: Test case: 1. A group admin sets up the group so that regular group members cannot edit pages. 2. Group admin creates a page. 3. Regular group member sees the "Edit" and "Delete" buttons. 4. When regular group member clicks on the buttons, they get "Access denied". Expected result: Group member doesn't see the "Edit" and "Delete" buttons. This may have snug in with the Bootstrap update as I don't remember having seen the buttons in earlier versions of Mahara. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1672930/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1680633] Re: Cron job metadata
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1680633 Title: Cron job metadata Status in Mahara: Confirmed Bug description: Hello, Currently the meta data stored for cron jobs is fairly limited having only the following fields: We are implementing a plugin for Mahara that will mirror the cron check functionality present in this Moodle plugin: https://github.com/brendanheywood/moodle-tool_heartbeat. It would be beneficial if Mahara included two new fields in the cron and the plugintype_cron tables: 1. lastruntime - the last runtime of the cron job. Currently on /admin/statistics.php the following sql is used to determine if cron has run. record_exists_select('cron', 'nextrun IS NULL OR nextrun < CURRENT_DATE') - from a monitoring standpoint this is not acceptable as it will give false positives/negatives depending on the situation. With this change, the max lastruntime could be used to determine if cron had run recently. 2. faildelay - An Exponentially increasing fail delay that is updated when the cron job fails (if it throws an exception). This way if there is a consistently failing cron job its execution is throttled and its failure is being tracked in some way aside from just logging an error. The heartbeat plugin above uses this to help us to identify and fix issues that would otherwise go undetected. Aside from the benefits from a monitoring perspective, these fields provide useful information when it comes to debugging anything cron related. I'm happy to discuss at any time and more than happy to do the dev on this. Ill be floating around the Mahara IRC under the kenH handle if you would like to talk at any time. Thanks, Kenneth To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1680633/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1692761] Re: Label combo boxes correctly on "External apps"
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1692761 Title: Label combo boxes correctly on "External apps" Status in Mahara: Confirmed Bug description: Mahara 17.04+ on /webservice/admin/oauthv1sregister.php In the Add application form, ensure the 2 combo boxes are properly labeled and that their labels are programmatically associated with the combo boxes. The first combo box contains "school, aut, etc" and the second contains "user provisioning, user query, etc. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1692761/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1689312] Re: New username isn't checked for spaces when added to LDAP
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1689312 Title: New username isn't checked for spaces when added to LDAP Status in Mahara: Confirmed Bug description: Mahara version: 16.10.3 When adding a new user, if you select an institution/authentication method with LDAP, the usersame is not being checked for leading/trailing spaces, and it isn't trimmed before being added to the database. Users can be created with usernames like " newuser ". If you try to do this with a non LDAP authentication method, it thows an error and will not continue (although the error message does not highlight the username field as the source of the error in this case). I've fixed it locally with trim() around the username value before it's put into the databse. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1689312/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1649433] Re: Consolidate "Add file" buttons
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1649433 Title: Consolidate "Add file" buttons Status in Mahara: Confirmed Bug description: We use two different ways of adding files to a text box / resume sections etc.: One, which allows you to add files from both your Mahara storage and computer and another one only from the computer. The latter one is the older one and can still be found in certain places. We should consolidate the occurances to always use the new way of adding files to be more consistent. Best case in point: When you add a file to your education history, you get the old button. However, when you edit that entry, you get the new button (see attachment). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1649433/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1692756] Re: Note that menu has been expanded
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1692756 Title: Note that menu has been expanded Status in Mahara: Confirmed Bug description: Mahara 17.04+ The "collapsed" state of the Show Main Menu / User Menu / Admin Menu button should become "Expanded" as the main menu has been expanded. When a screen reader focuses on the "Show main menu" button for the first time, the screen reader speaks "Show main menu, collapsed" as it is collapsed. But when the user presses Enter and the menu expands, the screen reader still says "Show main menu, collapsed", instead of saying "Show main menu, expanded". It is important to note that on the menu items e.g. Show menu for content, show menu for portfolio, show menu for groups, the screen reader is correctly able to speak the collapsed or expanded state of the menu items. The issue is present only in the main menu, administration menu, and user menu buttons. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1692756/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1675233] Re: Youtube fullscreen not working in 'automatically retract' mode
** Also affects: mahara/18.04 Importance: Undecided Status: New ** No longer affects: mahara/17.10 ** Changed in: mahara Milestone: 17.10.0 => 18.04.0 ** No longer affects: mahara/18.04 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1675233 Title: Youtube fullscreen not working in 'automatically retract' mode Status in Mahara: Confirmed Bug description: Embedded Youtube videos with allowfullscreen etc. in the embed code work fine in fullscreen when retractable is set to 'No' or 'Yes', however, fullstreen is not available (allowed) if option 'Automatically Retract' is chosen. I assume that this feature changes the wrapping code around the embedded content and disallows fullscreen somehow. Mahara version: 16.10 Tested on Windows and Linux laptops with Firefox and Chrome. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1675233/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1679699] Re: Upgrading 1.9.7 => 16.04.4 causes fatal DB error
** No longer affects: mahara/17.10 ** Changed in: mahara Milestone: 17.04.1 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1679699 Title: Upgrading 1.9.7 => 16.04.4 causes fatal DB error Status in Mahara: Confirmed Bug description: Error: [WAR] 75 (lib/dml.php:514) Failed to get a recordset: mysqli error: [1146: Table 'mahara_new.artefact_file_embedded' doesn't exist] in EXECUTE("SELECT "id" FROM "artefact_file_embedded" WHERE "fileid" = '11498' AND "resourcetype" = 'blogpost' AND "resourceid" = '11534' ") [WAR] 75 (lib/dml.php:514) Command was: SELECT "id" FROM "artefact_file_embedded" WHERE "fileid" = ? AND "resourcetype" = ? AND "resourceid" = ? and values was (0:11498,1:blogpost,2:11534) Call stack (most recent first): * get_recordset_sql(string(size 108), array(size 3)) at /var/www/html/mahara/lib/dml.php:825 * get_field_sql(string(size 108), array(size 3)) at /var/www/html/mahara/lib/dml.php:813 * get_field(string(size 22), string(size 2), string(size 6), string(size 5), string(size 12), string(size 8), string(size 10), string(size 5)) at /var/www/html/mahara/lib/embeddedimage.php:94 * EmbeddedImage::prepare_embedded_images(string(size 624), string(size 8), string(size 5), null, string(size 3)) at /var/www/html/mahara/artefact/blog/db/upgrade.php:76 * xmldb_artefact_blog_upgrade(string(size 10)) at /var/www/html/mahara/lib/upgrade.php:418 * upgrade_plugin(object(stdClass)) at /var/www/html/mahara/lib/mahara.php:266 * upgrade_mahara(array(size 1)) at /var/www/html/mahara/admin/cli/upgrade.php:53 The reason is that the artefact.blog upgrade for version 2015011501 assumes that the artefact.file upgrade for 2015111200 has already taken place and, hence, that the table 'artefact_file_embedded' has been created. This is not the case for an upgrade from 1.9.7 to 16.04.4. To work around this I've forced artefact.file to be the first artefact to be upgraded, by adding the following code to 'sort_upgrades': if ($weight1 == $weight2) { if ($k1 == 'artefact.file') { return -1; } else if ($k2 == 'artefact.file') { return 1; } } This is a temporary change to make sure that the upgrade can be completed (which it has now done), but reporting here in the hope that this will save anyone else having similar problems. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1679699/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1680644] Re: unable to drop files to upload
** No longer affects: mahara/17.04 ** No longer affects: mahara/17.10 ** Changed in: mahara Milestone: 17.04.1 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1680644 Title: unable to drop files to upload Status in Mahara: Confirmed Bug description: Tested on Site: https://master-mahara.catalystdemo.net.nz Browser: Safari 10.0.3 Device: MacBook Pro Steps to Reproduce: 1) Navigate to Groups> Select a group>Journals 2) Create a journal 3) Add a new entry to the jounal 4) While giving the details to add the entry for the journal try to attach a file by clicking on "Add a file" Expected Result: A pop up should be displayed with an option to upload a file and an option to drop files to upload ( see screenshot 1) Actual Result: Drop files here to upload doesnt show up on safari ( see screenshot 2) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1680644/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1692757] Re: Collapse main menu by pressing Esc key
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1692757 Title: Collapse main menu by pressing Esc key Status in Mahara: Confirmed Bug description: Mahara 17.04+ User should be able to collapse the main navigation menus (user menu, admin menu, main menu) by pressing the Escape key. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1692757/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1603302] Re: Convert mixed-case group shortnames
The upgrade in https://reviews.mahara.org/#/c/7128/5 will have made them all lowercase as group_generate_shortname() returns a lowercase value ** Changed in: mahara Milestone: 17.10.0 => None ** Changed in: mahara Status: Confirmed => Won't Fix -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1603302 Title: Convert mixed-case group shortnames Status in Mahara: Won't Fix Bug description: Mahara: master With the new functionality added to allow admins to update the group shortname, an interesting paradigm now exists. Currently, we allow mixed case alphanumeric characters for the shortname. A variable was introduced 'retainshortname' to make sure the shortname entered (via the webservice and / or CSV upload ) is valid and follows the shortname naming conventions. In the group_create() function (htdocs/lib/group.php), we then validate to make sure the shortname they've used (i.e. for newly created groups), matches what we would have generated automatically. 1. If the user specifies a mixed case shortname in the CSV upload, the generated shortname will not match as it always converts everything to lowercase. 2. If the user specifies a shortname completely unrelated to the display name, the shortname will also not match. i.e. shortname = 'abc' displayname = 'My Group'. The generated shortname will be 'mygroup'. I'm of the opinion that the following needs to be modified: 1. The shortname should be alphanumeric lower case characters. 2. A common validation function needs to be created so the edit group, upload csv, and webservice group creation are using the same rules. Therefore, we won't have multiple validation functions for the same thing throughout the code. 3. We can eliminate the 'retainshortname' flag as we would have already validated the shortname if it got to the group_create() function. 4. An upgrade script to convert mixed case shortnames to lower case. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1603302/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1606738] Re: Accessibility - Information icon and navigation to content in information overlay
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1606738 Title: Accessibility - Information icon and navigation to content in information overlay Status in Mahara: Confirmed Bug description: Mahara: master Information icons are appearing as h1 headers. Also, screen readers can't get to the content in the pop up dialog. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1606738/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1599414] Re: New composer-managed SimpleSAML breaks PHPUnit tests.
So just need to update the mahara Makefile to delete the tests parts of SimpleSamlPhp -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1599414 Title: New composer-managed SimpleSAML breaks PHPUnit tests. Status in Mahara: Confirmed Status in Mahara 17.04 series: Confirmed Status in Mahara 17.10 series: Confirmed Bug description: While writing a PHPUnit test for one of my patches, I noticed that the new composer-managed SimpleSAML, if present, breaks "make phpunit", because it contains some phpunit tests that get detected but are lacking the proper stuff to make them run correctly. To replicate: 1. Install the SimpleSAMLPHP library by doing "make ssphp" 2. Run phpunit tests by doing "make phpunit" Expected result: tests run with no failures Actual result: Tests fail out with this error message PHP Fatal error: Class 'SimpleSAML_Auth_ProcessingFilter' not found in /home/aaronw/www/mahara/htdocs/auth/saml/extlib/simplesamlphp/modules/exampleauth/lib/Auth/Process/RedirectTest.php on line 7 PHP Stack trace: PHP 1. {main}() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/composer/bin/phpunit:0 PHP 2. PHPUnit_TextUI_Command::main() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/composer/bin/phpunit:63 PHP 3. PHPUnit_TextUI_Command->run() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:129 PHP 4. PHPUnit_Runner_BaseTestRunner->getTest() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:150 PHP 5. PHPUnit_Framework_TestSuite->addTestFiles() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Runner/BaseTestRunner.php:96 PHP 6. PHPUnit_Framework_TestSuite->addTestFile() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:416 PHP 7. PHPUnit_Util_Fileloader::checkAndLoad() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:355 PHP 8. PHPUnit_Util_Fileloader::load() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Util/Fileloader.php:76 PHP 9. include_once() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Util/Fileloader.php:92 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1599414/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1603294] Re: Licenses: Once you've selected a license, you can't go back to "None"
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1603294 Title: Licenses: Once you've selected a license, you can't go back to "None" Status in Mahara: Confirmed Bug description: While testing out Bug 1279526, I noticed that you can't change an uploaded file from a particular license to "No License". This may have been by design, with the idea that "No License" was a temporary thing until you pick a license. But with Bug 1279526 we're changing the wording of "No License" to make it clear that if you're not choosing a particular license, then the default copyright rules apply, so it becomes more necessary to be able to switch to that. To replicate: 1. Go to "Administration -> Configure Site -> General Settings", and enable "License metadata" 2. Go to "Content -> Files" and upload a file. 3. Once the file is uploaded, click the pencil "edit" button to open its editing form. It should be at "No license" or the equivalent. Change it to "Creative Commons Attribution 4.0" 4. Click "Save changes" 5. Now click the pencil "edit" button again. Change the License back to "No license" or the equivalent. 6. Again click "Save changes" 7. Again click the pencil "edit" button. Expected result: You see "No license" or the equivalent as the license selection. Actual result: You see "Creative Commons Attribution 4.0" as the license selection. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1603294/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1575923] Re: Mathslate/MathJax fails to load on https
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1575923 Title: Mathslate/MathJax fails to load on https Status in Mahara: Confirmed Bug description: On HTTPS-enabled sites, the Mathslate tinymce plugin fails, due to loading http:// resources from yui.yahooapis.com and cdn.mathjax.org. The file htdocs/js/tinymce/plugins/mathslate/mathslate.html is hardcoded to pull http:// versions of these scripts (lines 11-12). Ultimately this is an upstream bug, but it's one that affects https- enabled Mahara sites. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1575923/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1594192] Re: Leap2a: Importing a file artefact has failed
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1594192 Title: Leap2a: Importing a file artefact has failed Status in Mahara: Confirmed Bug description: Version: master (16.10), 16.04, 15.10 For some reasons, the attribute mtime of a file artefact in a leap2a file is empty. This cause the following error when import it. [WAR] fc (lib/errors.php:796) Failed to get a recordset: postgres8 error: [-1: ERROR: invalid input syntax for type timestamp: ""] in adodb_throw(UPDATE "artefact" SET "artefacttype" = ? , "container" = ? , "parent" = ? , "owner" = ? , "institution" = ? , "group" = ? , "ctime" = ? , "mtime" = ? , "atime" = ? , "locked" = ? , "title" = ? , "description" = ? , "note" = ? , "author" = ? , "authorname" = ? , "allowcomments" = ? , "approvecomments" = ? , "license" = ? , "licensor" = ? , "licensorurl" = ? , "path" = ? WHERE "id" = ? , file,0,60,1,,,2016-06-2010:17:24,,2016-06-2010:17:24,0,MasterofEducationtranscript,,,1,,0,0/60/61,61), referer: http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1 [Mon Jun 20 10:17:24.948612 2016] [:error] [pid 11881] [client 192.168.2.47:33369] [WAR] fc (lib/errors.php:796) Command was: UPDATE "artefact" SET "artefacttype" = ? , "container" = ? , "parent" = ? , "owner" = ? , "institution" = ? , "group" = ? , "ctime" = ? , "mtime" = ? , "atime" = ? , "locked" = ? , "title" = ? , "description" = ? , "note" = ? , "author" = ? , "authorname" = ? , "allowcomments" = ? , "approvecomments" = ? , "license" = ? , "licensor" = ? , "licensorurl" = ? , "path" = ? WHERE "id" = ? and values was (0:file,1:0,2:60,3:1,4:,5:,6:2016-06-2010:17:24,7:,8:2016-06-2010:17:24,9:0,10:MasterofEducationtranscript,11:,12:,13:1,14:,15:0,16:0,17:,18:,19:,20:/60/61,21:61), referer: http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1 [Mon Jun 20 10:17:24.948629 2016] [:error] [pid 11881] [client 192.168.2.47:33369] Call stack (most recent first):, referer: http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1 [Mon Jun 20 10:17:24.948633 2016] [:error] [pid 11881] [client 192.168.2.47:33369] * log_message("Failed to get a recordset: postgres8 error: [-1: E...", 8, true, true) at /var/www/html/mahara/master/htdocs/lib/errors.php:95, referer: http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1 [Mon Jun 20 10:17:24.948638 2016] [:error] [pid 11881] [client 192.168.2.47:33369] * log_warn("Failed to get a recordset: postgres8 error: [-1: E...") at /var/www/html/mahara/master/htdocs/lib/errors.php:796, referer: http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1 [Mon Jun 20 10:17:24.948642 2016] [:error] [pid 11881] [client 192.168.2.47:33369] * SQLException->__construct("Failed to get a recordset: postgres8 error: [-1: E...") at /var/www/html/mahara/master/htdocs/lib/dml.php:1302, referer: http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1 [Mon Jun 20 10:17:24.948646 2016] [:error] [pid 11881] [client 192.168.2.47:33369] * update_record("artefact", object(stdClass), "id") at /var/www/html/mahara/master/htdocs/artefact/lib.php:628, referer: http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1 [Mon Jun 20 10:17:24.948649 2016] [:error] [pid 11881] [client 192.168.2.47:33369] * ArtefactType->commit() at /var/www/html/mahara/master/htdocs/artefact/file/lib.php:1062, referer: http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1 [Mon Jun 20 10:17:24.948653 2016] [:error] [pid 11881] [client 192.168.2.47:33369] * ArtefactTypeFile->commit() at /var/www/html/mahara/master/htdocs/artefact/file/import/leap/lib.php:499, referer: http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1 [Mon Jun 20 10:17:24.948657 2016] [:error] [pid 11881] [client 192.168.2.47:33369] * LeapImportFile::create_file_from_entry_data(object(stdClass), object(PluginImportLeap), "portfolio:artefact148") at /var/www/html/mahara/master/htdocs/artefact/file/import/leap/lib.php:421, referer: http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1 [Mon Jun 20 10:17:24.948661 2016] [:error] [pid 11881] [client 192.168.2.47:33369] * LeapImportFile::create_file_from_request(object(PluginImportLeap), object(stdClass), 60) at /var/www/html/mahara/master/htdocs/artefact/file/import/leap/lib.php:94, referer: http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1 [Mon Jun 20 10:17:24.948667 2016] [:error] [pid 11881] [client 192.168.2.47:33369] * LeapImportFile::import_from_requests(object(PluginImportLeap)) at Unknown:0, refere
[Mahara-contributors] [Bug 1576075] Re: Namespaces and Autoloader
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1576075 Title: Namespaces and Autoloader Status in Mahara: Confirmed Bug description: Discussed at the 52nd developer meeting: https://wiki.mahara.org/wiki/Developer_Area/Developer_Meetings/52 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1576075/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1599414] Re: New composer-managed SimpleSAML breaks PHPUnit tests.
As we are not maintaining SimpleSamlPhp/nor changing core code we should just clear out the PHPUnit Tests from the install -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1599414 Title: New composer-managed SimpleSAML breaks PHPUnit tests. Status in Mahara: Confirmed Status in Mahara 17.04 series: Confirmed Status in Mahara 17.10 series: Confirmed Bug description: While writing a PHPUnit test for one of my patches, I noticed that the new composer-managed SimpleSAML, if present, breaks "make phpunit", because it contains some phpunit tests that get detected but are lacking the proper stuff to make them run correctly. To replicate: 1. Install the SimpleSAMLPHP library by doing "make ssphp" 2. Run phpunit tests by doing "make phpunit" Expected result: tests run with no failures Actual result: Tests fail out with this error message PHP Fatal error: Class 'SimpleSAML_Auth_ProcessingFilter' not found in /home/aaronw/www/mahara/htdocs/auth/saml/extlib/simplesamlphp/modules/exampleauth/lib/Auth/Process/RedirectTest.php on line 7 PHP Stack trace: PHP 1. {main}() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/composer/bin/phpunit:0 PHP 2. PHPUnit_TextUI_Command::main() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/composer/bin/phpunit:63 PHP 3. PHPUnit_TextUI_Command->run() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:129 PHP 4. PHPUnit_Runner_BaseTestRunner->getTest() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:150 PHP 5. PHPUnit_Framework_TestSuite->addTestFiles() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Runner/BaseTestRunner.php:96 PHP 6. PHPUnit_Framework_TestSuite->addTestFile() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:416 PHP 7. PHPUnit_Util_Fileloader::checkAndLoad() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:355 PHP 8. PHPUnit_Util_Fileloader::load() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Util/Fileloader.php:76 PHP 9. include_once() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Util/Fileloader.php:92 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1599414/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1574952] Re: Error with LEAP2A import
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1574952 Title: Error with LEAP2A import Status in Mahara: Confirmed Bug description: I have a Mahara 15.10.1 installation running on php-5.3.5 and mysql-5.5.9 on a windows system (its a demonstration/experimental system, not a production system) Creation of a user works OK. I have had success with importing LEAP2A into an existing user. But I have another (larger) LEAP2A file which DOES NOT work, though the same LEAP2A file works find on a (Linux) production system. Partial error log of two scenarios are as follows ... suggestions welcome. Attempting to add user via LEAP2A import [Mon Apr 25 21:29:06 2016] [error] [client 127.0.0.1] [WAR] 2a (theme\\raw\\pieforms\\adduser.php:19) Undefined index: error, referer: http://localhost/mahara/admin/users/search.php [Mon Apr 25 21:29:06 2016] [error] [client 127.0.0.1] Call stack (most recent first):, referer: http://localhost/mahara/admin/users/search.php [Mon Apr 25 21:29:06 2016] [error] [client 127.0.0.1] * log_message("Undefined index: error", 8, true, true, "C:\\ePortfolio\\www\\mahara\\theme\\raw\\pieforms\\adduse...", 19) at C:\\ePortfolio\\www\\mahara\\lib\\errors.php:441, referer: http://localhost/mahara/admin/users/search.php [Mon Apr 25 21:29:06 2016] [error] [client 127.0.0.1] * error(8, "Undefined index: error", "C:\\ePortfolio\\www\\mahara\\theme\\raw\\pieforms\\adduse...", 19, array(size 10)) at C:\\ePortfolio\\www\\mahara\\theme\\raw\\pieforms\\adduser.php:19, referer: http://localhost/mahara/admin/users/search.php [Mon Apr 25 21:29:06 2016] [error] [client 127.0.0.1] * require("C:\\ePortfolio\\www\\mahara\\theme\\raw\\pieforms\\adduse...") at C:\\ePortfolio\\www\\mahara\\lib\\pieforms\\pieform.php:756, referer: http://localhost/mahara/admin/users/search.php [Mon Apr 25 21:29:06 2016] [error] [client 127.0.0.1] * Pieform->build() at C:\\ePortfolio\\www\\mahara\\lib\\pieforms\\pieform.php:169, referer: http://localhost/mahara/admin/users/search.php [Mon Apr 25 21:29:06 2016] [error] [client 127.0.0.1] * Pieform::process(array(size 8)) at C:\\ePortfolio\\www\\mahara\\lib\\pieforms\\pieform.php:71, referer: http://localhost/mahara/admin/users/search.php [Mon Apr 25 21:29:06 2016] [error] [client 127.0.0.1] * pieform(array(size 8)) at C:\\ePortfolio\\www\\mahara\\admin\\users\\add.php:156, referer: http://localhost/mahara/admin/users/search.php [Mon Apr 25 21:29:06 2016] [error] [client 127.0.0.1] , referer: http://localhost/mahara/admin/users/search.php User added manually, LEAP2A then attempted to be imported [Mon Apr 25 21:35:14 2016] [error] [client 127.0.0.1] [WAR] 70 (theme\\raw\\pieforms\\adduser.php:19) Undefined index: error, referer: http://localhost/mahara/admin/users/search.php [Mon Apr 25 21:35:14 2016] [error] [client 127.0.0.1] Call stack (most recent first):, referer: http://localhost/mahara/admin/users/search.php [Mon Apr 25 21:35:14 2016] [error] [client 127.0.0.1] * log_message("Undefined index: error", 8, true, true, "C:\\ePortfolio\\www\\mahara\\theme\\raw\\pieforms\\adduse...", 19) at C:\\ePortfolio\\www\\mahara\\lib\\errors.php:441, referer: http://localhost/mahara/admin/users/search.php [Mon Apr 25 21:35:14 2016] [error] [client 127.0.0.1] * error(8, "Undefined index: error", "C:\\ePortfolio\\www\\mahara\\theme\\raw\\pieforms\\adduse...", 19, array(size 10)) at C:\\ePortfolio\\www\\mahara\\theme\\raw\\pieforms\\adduser.php:19, referer: http://localhost/mahara/admin/users/search.php [Mon Apr 25 21:35:14 2016] [error] [client 127.0.0.1] * require("C:\\ePortfolio\\www\\mahara\\theme\\raw\\pieforms\\adduse...") at C:\\ePortfolio\\www\\mahara\\lib\\pieforms\\pieform.php:756, referer: http://localhost/mahara/admin/users/search.php [Mon Apr 25 21:35:14 2016] [error] [client 127.0.0.1] * Pieform->build() at C:\\ePortfolio\\www\\mahara\\lib\\pieforms\\pieform.php:169, referer: http://localhost/mahara/admin/users/search.php [Mon Apr 25 21:35:14 2016] [error] [client 127.0.0.1] * Pieform::process(array(size 8)) at C:\\ePortfolio\\www\\mahara\\lib\\pieforms\\pieform.php:71, referer: http://localhost/mahara/admin/users/search.php [Mon Apr 25 21:35:14 2016] [error] [client 127.0.0.1] * pieform(array(size 8)) at C:\\ePortfolio\\www\\mahara\\admin\\users\\add.php:156, referer: http://localhost/mahara/admin/users/search.php [Mon Apr 25 21:35:14 2016] [error] [client 127.0.0.1] , referer: http://localhost/mahara/admin/users/search.php To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1574952/+subscriptions
[Mahara-contributors] [Bug 1566122] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/8039 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1566122 Title: Select institution with web service auth immediately for token Status in Mahara: In Progress Bug description: When a user gets a service access token associated, the institution needs to be selected instead of being chosen per default. This means that "No institution" can show up when the user is actually a member of a different institution. This behavior is inconsistent to what you see in "Manage service users". There, you can't select your institution, but it is only displayed. So it might be an easy fix. :-) How to test: 1) Go to Admin -> Extenstions -> Webservices test client and make sure web services is switched on 2) Go to Institutions and create an institution 3) Edit institution and for the 'Authentication plugin' dropdown pick 'Webservices ...' and click 'Add' button then hit submit at bottom of form 4) Go to Admin -> Users and click on a username of a user add them to the new institution (bottom of form) 5) Now change their 'Authentication method' field to the one that is the institution name + 'webservice' - click the 'save changes' button 6) Go back to Admin -> Extenstions -> Webservices and expand the 'Manage service access tokens' part and search for the user and click 'Generate token' 7) On the next form click the 'Back' link at base of form - as we don't need to change anything thereat the moment 8) You should see the user now listed with a 'Token' set. Expected result: The institution should be the one to which you added them earlier Actual result: "No institution" is displayed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1566122/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1566122] Re: Select institution with web service auth immediately for token
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1566122 Title: Select institution with web service auth immediately for token Status in Mahara: In Progress Bug description: When a user gets a service access token associated, the institution needs to be selected instead of being chosen per default. This means that "No institution" can show up when the user is actually a member of a different institution. This behavior is inconsistent to what you see in "Manage service users". There, you can't select your institution, but it is only displayed. So it might be an easy fix. :-) How to test: 1) Go to Admin -> Extenstions -> Webservices test client and make sure web services is switched on 2) Go to Institutions and create an institution 3) Edit institution and for the 'Authentication plugin' dropdown pick 'Webservices ...' and click 'Add' button then hit submit at bottom of form 4) Go to Admin -> Users and click on a username of a user add them to the new institution (bottom of form) 5) Now change their 'Authentication method' field to the one that is the institution name + 'webservice' - click the 'save changes' button 6) Go back to Admin -> Extenstions -> Webservices and expand the 'Manage service access tokens' part and search for the user and click 'Generate token' 7) On the next form click the 'Back' link at base of form - as we don't need to change anything thereat the moment 8) You should see the user now listed with a 'Token' set. Expected result: The institution should be the one to which you added them earlier Actual result: "No institution" is displayed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1566122/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1563641] Re: Rewrite "mixed content" URLs via an HTMLPurifier custom filter
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1563641 Title: Rewrite "mixed content" URLs via an HTMLPurifier custom filter Status in Mahara: Confirmed Bug description: "Mixed content" refers to the scenario where a web page is served via HTTPS, but it includes assets that are served via an HTTP URL. See https://developer.mozilla.org/en-US/docs/Security/Mixed_content for some discussion of this. In Bug 1463629 we fixed this issue for embedded iframes, by patching the HTMLPurifier core class HTMLPurifier_URIFilter_SafeIframe so that, in addition to filtering iframes for an allowed set of URLs, it also transformed them from HTTPS to HTTP if needed. After having recently done some work on HTMLPurifier for other bugs, and becoming more familiar with their API, it now becomes apparent to me that this was a bit of a hack (patching core code should have told me this anyway). What we should have done is, instead, write up a new custom URIFilter specifically for rewriting URI's from HTTP to HTTPS in this way, and used that instead. Doing it that way will make future HTMLPurifier upgrades easier, by eliminating the need to patch that file. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1563641/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1564117] Re: Refactor blocktype JS methods
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1564117 Title: Refactor blocktype JS methods Status in Mahara: Confirmed Bug description: Currently the PluginBlocktype abstract class has three methods for loading Javascript libraries, and invoking Javascript code to run when a block is loaded: 1. PluginBlocktype::get_instance_javascript(BlockInstance $instance): Called when a block instance is displayed (either on the page in view mode, or the page in edit mode). Expects to return an array of sub- arrays where each sub-array has a "file" item, which is the relative path to a JS file (relative to the blocktype's root), and an optional "init" item, which is a snippet of code that gets executed once the "file" library has loaded. (It currently uses jQuery.getScript() to do this). 2. PluginBlocktype::get_instance_inline_javascript(BlockInstance $instance): Called when a block instance is displayed (either on the page in view mode, or the page in edit mode). The code here is inserted into a
[Mahara-contributors] [Bug 1564715] Re: Change Mahara's content-sniffing to match the WHATWG standard
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1564715 Title: Change Mahara's content-sniffing to match the WHATWG standard Status in Mahara: Confirmed Bug description: WHATWG (Web Hypertext Application Technology Working Group) is basically the official specification organization for HTML5. They've written up some specifications about the correct & secure way that HTTP clients & servers ought to deal with file content types aka MIME types: https://mimesniff.spec.whatwg.org To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1564715/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1563582] Re: Improve performance of queries against "artefact.path" by also querying against artefact owner
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1563582 Title: Improve performance of queries against "artefact.path" by also querying against artefact owner Status in Mahara: Confirmed Bug description: A while back we added a "path" column to the "artefact" table to try to improve performance when looking up artefact descendants. This replaced an older system where we only had a "parent" column, and when we needed to query against artefact hierarchies we had to use repeated SQL queries. Unfortunately, though, the "path" column is a varchar, and it turns out that varchar queries are not very performant even when indexed, particularly when you're searching substrings of them as we do with such queries. This causes big performance problems on sites with many artefacts. One easy way to drastically improve this performance, is that whenever we have a query that primarily searches against "path", we also search against the arteafct.owner, artefact.institution, or artefact.group column as well. These columns are all indexed, and all integers, which means they will perform very quickly. Also, with Mahara's current architecture, there are no current situations where an artefact will have a parent that is *not* owned by the same entity. So, instead of doing "select * from artefact where path like '/' || ? || '/%'" to find all the children of a particular artefact, you can do "select * from artefact where path like '/' || ? || '/%' AND owner=?" (Though note that the actual query will need to check whether the artefact is owned by an owner, group, or institution, and will need to alter the query accordingly.) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1563582/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1542154] Re: upgrade pdfjs to 1.8.188
The instructions in the README file in Mahara look to be out of date - try following the info there - https://github.com/mozilla/pdf.js/tree/master ** Summary changed: - upgrade pdfjs to 1.3.91 + upgrade pdfjs to 1.8.188 ** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1542154 Title: upgrade pdfjs to 1.8.188 Status in Mahara: Confirmed Bug description: Need to keep this current To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1542154/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1558830] Re: Set "URI.DefinitionID" and "URI.DefinitionRev" in HTMLPurifier
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1558830 Title: Set "URI.DefinitionID" and "URI.DefinitionRev" in HTMLPurifier Status in Mahara: Confirmed Bug description: While working on https://bugs.launchpad.net/mahara/+bug/1558387, Robert pointed out to me that we don't set URI.DefinitionRev. We also don't set URI.DefinitionID. Although the HTMLPurifier docs say that URI.DefinitionID is required if you have custom URIFilters (and our allowed iframe list is a custom URIFilter), it looks like the fallback behavior is that it generates a URI.DefinitionID based on a hash of the config. This has the effect that a new "Revision 1" URI config file is generated each time the allowed iframes list changes. It also results in an accumulation of old URI cache files in the dataroot/htmlpurifier directory, since they're all Revision 1, and all have different IDs. I think the best approach here is to give the URI.DefinitionRev its own revision number, stored in the database, and increment it every time we change the allowed iframe list. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1558830/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514275] Re: Add a minaccept to look for the "empty()" function called with a non-variable argument
Now that the empty() function from PHP 5.5+ can handle a non-variable we don't need to make a minaccept check! ** Changed in: mahara Milestone: 17.10.0 => None ** Changed in: mahara Status: Confirmed => Won't Fix -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514275 Title: Add a minaccept to look for the "empty()" function called with a non- variable argument Status in Mahara: Won't Fix Bug description: We've had a few bugs now caused by people calling the PHP empty() function with a parameter that is not a single variable. (And at least one caused by putting empty() into a Dwoo template, where its argument was parsed by Dwoo into an expression.) This causes a problem because we support PHP 5.3+, and prior to PHP 5.5 it causes a fatal exception if you try to call empty() with an argument that is not a single variable. I think this should actually be a pretty easy one to check for, fortunately. We just need to check for "empty(" followed by a character that isn't "$", so a regex like this: /\bempty\(\s*[^$]/i And in Dwoo templates, where empty() can't be used at all because there's no guarantee of what Dwoo will parse it into, we'd check for it in the form "empty()" or in the Dwoo tag pipe syntax "|empty": /(\bempty\(|\|empty\b)/i Note that any regex to check for this would need to be case- insensitive, because PHP function calls are not case sensitive. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514275/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1517732] Re: Upgrade Elastica to the latest stable version
We have gone with elasticsearch-php plugin as it is maintained by the people that make elasticsearch itself - see Bug 1694171 ** Changed in: mahara Milestone: 17.10.0 => None ** Changed in: mahara Status: Confirmed => Won't Fix -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1517732 Title: Upgrade Elastica to the latest stable version Status in Mahara: Won't Fix Bug description: Mahara 15.10 is using Elastica 2.0, which is only compatible with Elasticsearch versions up to 1.5.2. Elasticsearch is now up to version 2.3, which supports up to Elasticsearch 1.73: http://elastica.io/2015/10/18/release-2-dot-3-1/ We should upgrade. It is worth noting, however, that Elasticsearch's latest version is 2.0.0, and the current version of Elastica does not support that yet. Apparently ES 2.0.0 breaks a lot of backwards compatibility. An upgrade to support ES 2.0.0 is in progress, however: https://github.com/ruflin/Elastica/issues/900 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1517732/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1528122] Re: Be able to decide whether to include or not feedback in Leap2A
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1528122 Title: Be able to decide whether to include or not feedback in Leap2A Status in Mahara: Confirmed Bug description: When you create an HTML export, you can decide whether to include feedback or not. However, when you create a Leap2A export, you do not have that option and feedback is now always included. Users should be able to have the choice like for HTML. At some point, feedback was added to the Leap2A export but without providing the option. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1528122/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1513710] Re: Destructor methods that access global variables can cause crashes
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1513710 Title: Destructor methods that access global variables can cause crashes Status in Mahara: Confirmed Bug description: See : https://mahara.org/interaction/forum/topic.php?id=7397 Here's the problem (which appears to be intermittent): 1. ArtefactType has a destructor method, which gets called when an artefact object is garbage-collected by PHP. 2. PHP runs destructor methods and garbage collects variables in no guaranteed order when exit() is called. 3. Sometimes the ArtefactType destructor method tries to call DML methods, which use the global variable $db 4. Apparently sometimes the $db global variable has already been garbage collected by the time the destructor runs 5. This causes a fatal "method on a non-object" crash. It's unclear why this error has only started happening recently. It might be due to a change in the behavior of PHP's garbage collector, or it might be from new Mahara code leaving some artefacts with their $dirty flag set (which triggers that artefact commit). In either case, both global variables and implicit destructor methods are considered harmful design practices, in part because of this particular thing. So it's high time we got rid of these __destruct() methods. Alternatively, as a workaround for older Mahara versions, we could add some code to the top of each __destruct() method that re-creates the global $db if it's not set. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1513710/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1513665] Re: Get an HTML5 "click-to-copy" widget
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 ** Changed in: mahara Assignee: (unassigned) => Cecilia Vela Gurovic (ceciliavg) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1513665 Title: Get an HTML5 "click-to-copy" widget Status in Mahara: Confirmed Bug description: In Bug 1314890, on the Secret URLs page we added the zeroclipboard library to allow users to click a clipboard icon and have the URL copied to their clipboard. Unfortunately, since then Flash has started dying in a bad way, and now this sort of Flash-based clipboard widget is on the way out, and can cause browsers to pop up warning messages and such. Now, there is no way to accomplish exactly this same functionality (copy to clipboard) without Flash currently. But, there are some useable alternatives. The one that seems to be poised to replace the click-to-copy pattern, is that you click and it automatically selects the full text, so that you then just have to hit "control-C" instead of first dragging to select it all. Jen recently added this little clipboard library to the styleguide.php script. It works pretty good, so we may as well adopt it for the Secret URL screen as well. http://zenorocha.github.io/clipboard.js/ To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1513665/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1513276] Re: Consolidate the iframe sources code
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1513276 Title: Consolidate the iframe sources code Status in Mahara: In Progress Bug description: Currently we do a bunch of different things to add allowed iframe sources code to the system when we install/upgrade a site We need to make it one way only Notes: lib/upgrade.php, core_postinst(), has a hard-coded list of allowed iframe sources if you add the youtube-no-iframes one there, can you also move the prezi one there, and take it out from blocktype/externalvideo::postinst() ? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1513276/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1513276] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/8037 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1513276 Title: Consolidate the iframe sources code Status in Mahara: In Progress Bug description: Currently we do a bunch of different things to add allowed iframe sources code to the system when we install/upgrade a site We need to make it one way only Notes: lib/upgrade.php, core_postinst(), has a hard-coded list of allowed iframe sources if you add the youtube-no-iframes one there, can you also move the prezi one there, and take it out from blocktype/externalvideo::postinst() ? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1513276/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1471103] Re: Make the password reset CLI script log out the user
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1471103 Title: Make the password reset CLI script log out the user Status in Mahara: Confirmed Bug description: In Bug 1396564 we added a command-line script for resetting Mahara passwords. Robert pointed out that this script should end any current sessions for the user. The idea is that, if their password needs to be reset because their account has been hacked, then we should kick out any remaining sessions that are logged-in, because the attacker could use those to re-reset their password. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1471103/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1482470] Re: Position and configure block dialogs no longer have focus management
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1482470 Title: Position and configure block dialogs no longer have focus management Status in Mahara: Confirmed Bug description: With the new Bootstrap theme, it is still possible to add blocks using the keyboard (by pressing Enter when focused on a block type in the accordion) but the dialogs that appear no longer have focus management, making it appear to screen reader users as if nothing has happened. The old behaviour (focusing the dialog close button when it opens) needs to be reimplemented or fixed. Affects latest master To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1482470/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1444182] Re: Leaving feedback on own page generates notification to self
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1444182 Title: Leaving feedback on own page generates notification to self Status in Mahara: In Progress Bug description: We don't need to receive a notification when we comment on our own page as we already know we have done that. To test: 1) Install fresh mahara 2) Add a user: UserA 3) Login as UserA and create a page 4) Leave feedback on page (doesn't matter if first feeback or replying to other's feedback) 5) Check inbox - there is a message both 'to' and 'from' UserA Will mark this as a low bug as it's more of an annoyance than the system being broken. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1444182/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1444182] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/8036 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1444182 Title: Leaving feedback on own page generates notification to self Status in Mahara: In Progress Bug description: We don't need to receive a notification when we comment on our own page as we already know we have done that. To test: 1) Install fresh mahara 2) Add a user: UserA 3) Login as UserA and create a page 4) Leave feedback on page (doesn't matter if first feeback or replying to other's feedback) 5) Check inbox - there is a message both 'to' and 'from' UserA Will mark this as a low bug as it's more of an annoyance than the system being broken. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1444182/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1443284] Re: "Unsubscribe" link for feedback notifications due to watchlist
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1443284 Title: "Unsubscribe" link for feedback notifications due to watchlist Status in Mahara: Confirmed Bug description: As described on Bug 1374674: https://bugs.launchpad.net/mahara/+bug/1374674/comments/9 Users receive notifications when there are comments on pages that are on their watchlist. If they receive this notification by email, we should add a link to the bottom of the email explaining that they received the email because the page is on their watchlist, and telling them to unwatch the page if they want to unsubscribe. For that matter, it would also be good if the inbox notification for feedback on watched pages could also indicate this in some way. But with the current inbox design, it would not be easy to add that. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1443284/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1718289] A patch has been submitted for review
Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8033 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1718289 Title: A string for the auth plugins is stored in core admin.php lang file rather than in the plugins Status in Mahara: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: Fix Committed Bug description: This causes problems for third party plugins as they have a broken lang string unless the user hacks the core file. To test: 1) Install the CAS plugin from https://github.com/robertlyon777/mahara_plugin_auth_cas 2) Add CAS auth to an institution - The title of the edit screen will be institution | [[casconfig/admin]] This string should come from the plugin and not core Will need to fix up To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1718289/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1718289] A change has been merged
Reviewed: https://reviews.mahara.org/8033 Committed: https://git.mahara.org/mahara/mahara/commit/c544f506664629a032ac27271bd9a4e86d87d7ff Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:17.04_STABLE commit c544f506664629a032ac27271bd9a4e86d87d7ff Author: Robert Lyon Date: Wed Sep 20 08:58:21 2017 +1200 Bug 1718289: Placing auth related title string in auth plugin Rather than in core lang file to allow thirdparty lang strings to work behatnotneeded Change-Id: I5b23c471d246f6901695d7fdf102525e9ef8a666 Signed-off-by: Robert Lyon (cherry picked from commit 457d11d15fc66f6b7bd11053ea5fceb89f60ef0e) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1718289 Title: A string for the auth plugins is stored in core admin.php lang file rather than in the plugins Status in Mahara: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: Fix Committed Bug description: This causes problems for third party plugins as they have a broken lang string unless the user hacks the core file. To test: 1) Install the CAS plugin from https://github.com/robertlyon777/mahara_plugin_auth_cas 2) Add CAS auth to an institution - The title of the edit screen will be institution | [[casconfig/admin]] This string should come from the plugin and not core Will need to fix up To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1718289/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1718289] A patch has been submitted for review
Patch for "16.10_STABLE" branch: https://reviews.mahara.org/8034 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1718289 Title: A string for the auth plugins is stored in core admin.php lang file rather than in the plugins Status in Mahara: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: Fix Committed Bug description: This causes problems for third party plugins as they have a broken lang string unless the user hacks the core file. To test: 1) Install the CAS plugin from https://github.com/robertlyon777/mahara_plugin_auth_cas 2) Add CAS auth to an institution - The title of the edit screen will be institution | [[casconfig/admin]] This string should come from the plugin and not core Will need to fix up To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1718289/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1718289] A patch has been submitted for review
Patch for "16.04_STABLE" branch: https://reviews.mahara.org/8035 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1718289 Title: A string for the auth plugins is stored in core admin.php lang file rather than in the plugins Status in Mahara: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: Fix Committed Bug description: This causes problems for third party plugins as they have a broken lang string unless the user hacks the core file. To test: 1) Install the CAS plugin from https://github.com/robertlyon777/mahara_plugin_auth_cas 2) Add CAS auth to an institution - The title of the edit screen will be institution | [[casconfig/admin]] This string should come from the plugin and not core Will need to fix up To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1718289/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1718289] A change has been merged
Reviewed: https://reviews.mahara.org/8034 Committed: https://git.mahara.org/mahara/mahara/commit/5cf4454699716ea76b0539edbbc4cdeed4691dbc Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:16.10_STABLE commit 5cf4454699716ea76b0539edbbc4cdeed4691dbc Author: Robert Lyon Date: Wed Sep 20 08:58:21 2017 +1200 Bug 1718289: Placing auth related title string in auth plugin Rather than in core lang file to allow thirdparty lang strings to work behatnotneeded Change-Id: I5b23c471d246f6901695d7fdf102525e9ef8a666 Signed-off-by: Robert Lyon (cherry picked from commit 457d11d15fc66f6b7bd11053ea5fceb89f60ef0e) (cherry picked from commit c544f506664629a032ac27271bd9a4e86d87d7ff) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1718289 Title: A string for the auth plugins is stored in core admin.php lang file rather than in the plugins Status in Mahara: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: Fix Committed Bug description: This causes problems for third party plugins as they have a broken lang string unless the user hacks the core file. To test: 1) Install the CAS plugin from https://github.com/robertlyon777/mahara_plugin_auth_cas 2) Add CAS auth to an institution - The title of the edit screen will be institution | [[casconfig/admin]] This string should come from the plugin and not core Will need to fix up To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1718289/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1718289] A change has been merged
Reviewed: https://reviews.mahara.org/8035 Committed: https://git.mahara.org/mahara/mahara/commit/ec73dec8cc748612f15556f1fd550c3f3c4fdcfb Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:16.04_STABLE commit ec73dec8cc748612f15556f1fd550c3f3c4fdcfb Author: Robert Lyon Date: Wed Sep 20 08:58:21 2017 +1200 Bug 1718289: Placing auth related title string in auth plugin Rather than in core lang file to allow thirdparty lang strings to work behatnotneeded Change-Id: I5b23c471d246f6901695d7fdf102525e9ef8a666 Signed-off-by: Robert Lyon (cherry picked from commit 457d11d15fc66f6b7bd11053ea5fceb89f60ef0e) (cherry picked from commit c544f506664629a032ac27271bd9a4e86d87d7ff) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1718289 Title: A string for the auth plugins is stored in core admin.php lang file rather than in the plugins Status in Mahara: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: Fix Committed Bug description: This causes problems for third party plugins as they have a broken lang string unless the user hacks the core file. To test: 1) Install the CAS plugin from https://github.com/robertlyon777/mahara_plugin_auth_cas 2) Add CAS auth to an institution - The title of the edit screen will be institution | [[casconfig/admin]] This string should come from the plugin and not core Will need to fix up To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1718289/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1718289] Re: A string for the auth plugins is stored in core admin.php lang file rather than in the plugins
** Changed in: mahara/17.10 Status: In Progress => Fix Committed ** Changed in: mahara/17.04 Status: New => Fix Committed ** Changed in: mahara/16.10 Status: New => Fix Committed ** Changed in: mahara/17.04 Importance: Undecided => High ** Changed in: mahara/16.10 Importance: Undecided => High ** Changed in: mahara/16.04 Status: New => In Progress ** Changed in: mahara/16.04 Importance: Undecided => High ** Changed in: mahara/17.04 Milestone: None => 17.04.4 ** Changed in: mahara/16.10 Milestone: None => 16.10.6 ** Changed in: mahara/16.04 Milestone: None => 16.04.9 ** Changed in: mahara/16.04 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1718289 Title: A string for the auth plugins is stored in core admin.php lang file rather than in the plugins Status in Mahara: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: Fix Committed Bug description: This causes problems for third party plugins as they have a broken lang string unless the user hacks the core file. To test: 1) Install the CAS plugin from https://github.com/robertlyon777/mahara_plugin_auth_cas 2) Add CAS auth to an institution - The title of the edit screen will be institution | [[casconfig/admin]] This string should come from the plugin and not core Will need to fix up To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1718289/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1718289] A change has been merged
Reviewed: https://reviews.mahara.org/8032 Committed: https://git.mahara.org/mahara/mahara/commit/457d11d15fc66f6b7bd11053ea5fceb89f60ef0e Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 457d11d15fc66f6b7bd11053ea5fceb89f60ef0e Author: Robert Lyon Date: Wed Sep 20 08:58:21 2017 +1200 Bug 1718289: Placing auth related title string in auth plugin Rather than in core lang file to allow thirdparty lang strings to work behatnotneeded Change-Id: I5b23c471d246f6901695d7fdf102525e9ef8a666 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1718289 Title: A string for the auth plugins is stored in core admin.php lang file rather than in the plugins Status in Mahara: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: Fix Committed Bug description: This causes problems for third party plugins as they have a broken lang string unless the user hacks the core file. To test: 1) Install the CAS plugin from https://github.com/robertlyon777/mahara_plugin_auth_cas 2) Add CAS auth to an institution - The title of the edit screen will be institution | [[casconfig/admin]] This string should come from the plugin and not core Will need to fix up To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1718289/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1718289] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/8032 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1718289 Title: A string for the auth plugins is stored in core admin.php lang file rather than in the plugins Status in Mahara: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: Fix Committed Bug description: This causes problems for third party plugins as they have a broken lang string unless the user hacks the core file. To test: 1) Install the CAS plugin from https://github.com/robertlyon777/mahara_plugin_auth_cas 2) Add CAS auth to an institution - The title of the edit screen will be institution | [[casconfig/admin]] This string should come from the plugin and not core Will need to fix up To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1718289/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1718289] [NEW] A string for the auth plugins is stored in core admin.php lang file rather than in the plugins
Public bug reported: This causes problems for third party plugins as they have a broken lang string unless the user hacks the core file. To test: 1) Install the CAS plugin from https://github.com/robertlyon777/mahara_plugin_auth_cas 2) Add CAS auth to an institution - The title of the edit screen will be institution | [[casconfig/admin]] This string should come from the plugin and not core Will need to fix up ** Affects: mahara Importance: High Status: In Progress ** Affects: mahara/16.04 Importance: Undecided Status: New ** Affects: mahara/16.10 Importance: Undecided Status: New ** Affects: mahara/17.04 Importance: Undecided Status: New ** Affects: mahara/17.10 Importance: High Status: In Progress ** Also affects: mahara/17.04 Importance: Undecided Status: New ** Also affects: mahara/17.10 Importance: High Status: In Progress ** Also affects: mahara/16.04 Importance: Undecided Status: New ** Also affects: mahara/16.10 Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1718289 Title: A string for the auth plugins is stored in core admin.php lang file rather than in the plugins Status in Mahara: In Progress Status in Mahara 16.04 series: New Status in Mahara 16.10 series: New Status in Mahara 17.04 series: New Status in Mahara 17.10 series: In Progress Bug description: This causes problems for third party plugins as they have a broken lang string unless the user hacks the core file. To test: 1) Install the CAS plugin from https://github.com/robertlyon777/mahara_plugin_auth_cas 2) Add CAS auth to an institution - The title of the edit screen will be institution | [[casconfig/admin]] This string should come from the plugin and not core Will need to fix up To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1718289/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1717822] A change has been merged
Reviewed: https://reviews.mahara.org/8031 Committed: https://git.mahara.org/mahara/mahara/commit/316812be7f54455f81dcf667547321e5ecc51349 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:17.04_STABLE commit 316812be7f54455f81dcf667547321e5ecc51349 Author: Robert Lyon Date: Wed Sep 20 07:45:46 2017 +1200 Bug 1717822: Fixing spelling mistake in expired institution code behatnotneeded Change-Id: Id08ec6a7c8ed62e42235e5eaa28012165c2fa4f7 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1717822 Title: Spelling mistake in code for denying user login to expired institution Status in Mahara: Fix Committed Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: Fix Committed Bug description: To test: 1) Set up a new institution and set the expiry of institution in the past 2) Add 1 user to the institution - making sure the user is using the auth method 'internal' for that institution 3) Logout and login as that user You should see error: [WAR] a0 (auth/lib.php:1716) Undefined variable: authinstane To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1717822/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1717822] Re: Spelling mistake in code for denying user login to expired institution
** No longer affects: mahara/15.04 ** No longer affects: mahara/16.04 ** No longer affects: mahara/16.10 ** Changed in: mahara/17.04 Status: New => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1717822 Title: Spelling mistake in code for denying user login to expired institution Status in Mahara: Fix Committed Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: Fix Committed Bug description: To test: 1) Set up a new institution and set the expiry of institution in the past 2) Add 1 user to the institution - making sure the user is using the auth method 'internal' for that institution 3) Logout and login as that user You should see error: [WAR] a0 (auth/lib.php:1716) Undefined variable: authinstane To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1717822/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1717822] A patch has been submitted for review
Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8031 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1717822 Title: Spelling mistake in code for denying user login to expired institution Status in Mahara: Fix Committed Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: Fix Committed Bug description: To test: 1) Set up a new institution and set the expiry of institution in the past 2) Add 1 user to the institution - making sure the user is using the auth method 'internal' for that institution 3) Logout and login as that user You should see error: [WAR] a0 (auth/lib.php:1716) Undefined variable: authinstane To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1717822/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1697248] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/8030 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1697248 Title: Change navigation through reports / statistics Status in Mahara: In Progress Bug description: In bug #1691910 the site and institution statistics pages were combined to be shown in one area. This wishlist item extends that functionality to introduce a new reports navigation bar in order to allow selecting the type of report that is to be displayed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1697248/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp