Re: [Mailman-Developers] adding to REST

2016-03-14 Thread Stephen J. Turnbull
treal tv writes:

 > I hadn't considered this yet. I had planned to help with patches so
 > yeah, I think i'll be rebuilding from the repo! Thanks, I hadn't
 > even thought about that yet.

I think the way to think about it is that bundler is a system for
distributing a "turnkey" Mailman installation (I guess the more modern
term is "app" but we're way far from getting there!)  If you are
interested in contributing to the distribution methods themselves (and
that is *very* important, at this point distribution and upgrade from
Mailman 2 are probably more important *to our users*[1] than code
improvement), install bundler (probably alongside a repo installation,
or including a repo installation).  Otherwise, bundler itself is still
unstable, and will distract you from working on Mailman, Postorius,
and/or HyperKitty code.

Of course if you just want a working Mailman installation that you can
start up, configure, and then ignore, try bundler.  It does work for a
lot of people at some instants of time. ;-)


Footnotes: 
[1]  Remember, we're all volunteers.  Users are important to most core
contributors "just because we care", but you are a volunteer[2] too.
Over time we'll train you to be more user-oriented, but for now, have
fun!

[2]  That's mostly remains true if you are a GSoC intern.

___
Mailman-Developers mailing list
Mailman-Developers@python.org
https://mail.python.org/mailman/listinfo/mailman-developers
Mailman FAQ: http://wiki.list.org/x/AgA3
Searchable Archives: 
http://www.mail-archive.com/mailman-developers%40python.org/
Unsubscribe: 
https://mail.python.org/mailman/options/mailman-developers/archive%40jab.org

Security Policy: http://wiki.list.org/x/QIA9


Re: [Mailman-Developers] adding to REST

2016-03-14 Thread treal tv
I hadn't considered this yet. I had planned to help with patches so 
yeah, I think i'll be rebuilding from the repo! Thanks, I hadn't even 
thought about that yet.


On 03/14/2016 06:24 PM, Simon Hanna wrote:

In case you want to turn in patches (merge requests) then having a repo is a 
must. And if you don't
plan to turn in patches it's still useful.


___
Mailman-Developers mailing list
Mailman-Developers@python.org
https://mail.python.org/mailman/listinfo/mailman-developers
Mailman FAQ: http://wiki.list.org/x/AgA3
Searchable Archives: 
http://www.mail-archive.com/mailman-developers%40python.org/
Unsubscribe: 
https://mail.python.org/mailman/options/mailman-developers/archive%40jab.org

Security Policy: http://wiki.list.org/x/QIA9


Re: [Mailman-Developers] adding to REST

2016-03-14 Thread treal tv
I might be misunderstanding you, Simon, but should I not be using 
Mailman 3 built with the bundler if I intend to modify/further build on 
the code?


I've been working off one built with the bundler for the last couple 
months and it's tolerated the mods I made without issue but I'd rather 
switch to source built sooner rather than later if it's going to matter 
in the future.


On 03/14/2016 03:31 PM, Simon Hanna wrote:

On 03/14/2016 07:25 PM, Dominic Dambrogia wrote:

Hi, My name is Dominic.
I contacted this mailing list last week about list moderation and post
approval. My problem was not being able to set a list password via the REST
api. I need this for nonmember approval of posting to a mailing list via
email in the "Approved: *list password*" style in the first line of the
email like the default request for moderation email suggests.

I'd like to go ahead and tackle this problem personally. I would appreciate
some insight on where to start looking in the project itself. I've only
installed the bundler and used REST so far, so my knowledge of how the
python code works so far is minimal.

Any insight is greatly appreciated, thanks.
- Dominic

If you want to actually develop mailman, you shouldn't use bundler for that. 
Check out the following
two pages that help you with some git knowledge and setting up your dev 
environment.
http://wiki.list.org/DEV/HowToContributeGit
http://wiki.list.org/DEV/SetupDevEnvironment

You should create an issue on gitlab https://gitlab.com/mailman/mailman/issues 
if there isn't one
already. This issue can be used to discuss specifics about the implementation.

You could try the irc channel #mailman on freenode for help in case you need 
something. You can of
course also post to this list.

All the code regarding the rest interface lives in src/mailman/rest

I hope this get's you started,
Simon
___
Mailman-Developers mailing list
Mailman-Developers@python.org
https://mail.python.org/mailman/listinfo/mailman-developers
Mailman FAQ: http://wiki.list.org/x/AgA3
Searchable Archives: 
http://www.mail-archive.com/mailman-developers%40python.org/
Unsubscribe: 
https://mail.python.org/mailman/options/mailman-developers/trealtv%40yandex.com

Security Policy: http://wiki.list.org/x/QIA9


___
Mailman-Developers mailing list
Mailman-Developers@python.org
https://mail.python.org/mailman/listinfo/mailman-developers
Mailman FAQ: http://wiki.list.org/x/AgA3
Searchable Archives: 
http://www.mail-archive.com/mailman-developers%40python.org/
Unsubscribe: 
https://mail.python.org/mailman/options/mailman-developers/archive%40jab.org

Security Policy: http://wiki.list.org/x/QIA9


Re: [Mailman-Developers] adding to REST

2016-03-14 Thread Simon Hanna
On 03/14/2016 10:34 PM, treal tv wrote:
> I might be misunderstanding you, Simon, but should I not be using Mailman 3 
> built with the bundler
> if I intend to modify/further build on the code?
> 
> I've been working off one built with the bundler for the last couple months 
> and it's tolerated the
> mods I made without issue but I'd rather switch to source built sooner rather 
> than later if it's
> going to matter in the future.
I'm unaware of any real downside to using the repo (unless you are a security 
fanatic and want stuff
tested for a couple of years ^^)
You can also use bundler with git repos. You'll just have to do run "python 
setup.py develop" for
mailman in the python3 virtualenv that bundler installs. Note you will want to 
use the other repos
as well, as there might be some incompatibilities.

Now to why you should be using it:
In case you want to turn in patches (merge requests) then having a repo is a 
must. And if you don't
plan to turn in patches it's still useful. You can work on another branch than 
master and whenever
upstream has new commits you can rebase them into your branch. That way you 
stay up to date without
too much maintenance

___
Mailman-Developers mailing list
Mailman-Developers@python.org
https://mail.python.org/mailman/listinfo/mailman-developers
Mailman FAQ: http://wiki.list.org/x/AgA3
Searchable Archives: 
http://www.mail-archive.com/mailman-developers%40python.org/
Unsubscribe: 
https://mail.python.org/mailman/options/mailman-developers/archive%40jab.org

Security Policy: http://wiki.list.org/x/QIA9


Re: [Mailman-Developers] adding to REST

2016-03-14 Thread Simon Hanna
On 03/14/2016 07:25 PM, Dominic Dambrogia wrote:
> Hi, My name is Dominic.
> I contacted this mailing list last week about list moderation and post
> approval. My problem was not being able to set a list password via the REST
> api. I need this for nonmember approval of posting to a mailing list via
> email in the "Approved: *list password*" style in the first line of the
> email like the default request for moderation email suggests.
> 
> I'd like to go ahead and tackle this problem personally. I would appreciate
> some insight on where to start looking in the project itself. I've only
> installed the bundler and used REST so far, so my knowledge of how the
> python code works so far is minimal.
> 
> Any insight is greatly appreciated, thanks.
> - Dominic

If you want to actually develop mailman, you shouldn't use bundler for that. 
Check out the following
two pages that help you with some git knowledge and setting up your dev 
environment.
http://wiki.list.org/DEV/HowToContributeGit
http://wiki.list.org/DEV/SetupDevEnvironment

You should create an issue on gitlab https://gitlab.com/mailman/mailman/issues 
if there isn't one
already. This issue can be used to discuss specifics about the implementation.

You could try the irc channel #mailman on freenode for help in case you need 
something. You can of
course also post to this list.

All the code regarding the rest interface lives in src/mailman/rest

I hope this get's you started,
Simon
___
Mailman-Developers mailing list
Mailman-Developers@python.org
https://mail.python.org/mailman/listinfo/mailman-developers
Mailman FAQ: http://wiki.list.org/x/AgA3
Searchable Archives: 
http://www.mail-archive.com/mailman-developers%40python.org/
Unsubscribe: 
https://mail.python.org/mailman/options/mailman-developers/archive%40jab.org

Security Policy: http://wiki.list.org/x/QIA9


[Mailman-Developers] adding to REST

2016-03-14 Thread Dominic Dambrogia
Hi, My name is Dominic.
I contacted this mailing list last week about list moderation and post
approval. My problem was not being able to set a list password via the REST
api. I need this for nonmember approval of posting to a mailing list via
email in the "Approved: *list password*" style in the first line of the
email like the default request for moderation email suggests.

I'd like to go ahead and tackle this problem personally. I would appreciate
some insight on where to start looking in the project itself. I've only
installed the bundler and used REST so far, so my knowledge of how the
python code works so far is minimal.

Any insight is greatly appreciated, thanks.
- Dominic
___
Mailman-Developers mailing list
Mailman-Developers@python.org
https://mail.python.org/mailman/listinfo/mailman-developers
Mailman FAQ: http://wiki.list.org/x/AgA3
Searchable Archives: 
http://www.mail-archive.com/mailman-developers%40python.org/
Unsubscribe: 
https://mail.python.org/mailman/options/mailman-developers/archive%40jab.org

Security Policy: http://wiki.list.org/x/QIA9