[jira] [Commented] (MAPREDUCE-4275) Plugable process tree
[ https://issues.apache.org/jira/browse/MAPREDUCE-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13434109#comment-13434109 ] Radim Kolar commented on MAPREDUCE-4275: can be this commited? Plugable process tree - Key: MAPREDUCE-4275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4275 Project: Hadoop Map/Reduce Issue Type: Improvement Components: nodemanager Affects Versions: 3.0.0 Environment: FreeBSD 64 bit Reporter: Radim Kolar Attachments: plugable-pstree-1.txt, plugable-pstree-2.txt, plugable-pstree-3.txt, plugable-pstree-4.txt, plugable-pstree-4-with-whitespace.txt, plugable-pstree-5-with-whitespace.txt, plugable-pstree-6-typofix.txt, plugable-pstree.txt Trunk version of Pluggable process tree. Work based on MAPREDUCE-4204 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4275) Plugable process tree
[ https://issues.apache.org/jira/browse/MAPREDUCE-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13427979#comment-13427979 ] Hadoop QA commented on MAPREDUCE-4275: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12539020/plugable-pstree-3.txt against trunk revision . -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2702//console This message is automatically generated. Plugable process tree - Key: MAPREDUCE-4275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4275 Project: Hadoop Map/Reduce Issue Type: Improvement Components: nodemanager Affects Versions: 3.0.0 Environment: FreeBSD 64 bit Reporter: Radim Kolar Attachments: plugable-pstree-1.txt, plugable-pstree-2.txt, plugable-pstree-3.txt, plugable-pstree.txt Trunk version of Pluggable process tree. Work based on MAPREDUCE-4204 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4275) Plugable process tree
[ https://issues.apache.org/jira/browse/MAPREDUCE-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13427998#comment-13427998 ] Hadoop QA commented on MAPREDUCE-4275: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12539022/plugable-pstree-4.txt against trunk revision . -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2703//console This message is automatically generated. Plugable process tree - Key: MAPREDUCE-4275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4275 Project: Hadoop Map/Reduce Issue Type: Improvement Components: nodemanager Affects Versions: 3.0.0 Environment: FreeBSD 64 bit Reporter: Radim Kolar Attachments: plugable-pstree-1.txt, plugable-pstree-2.txt, plugable-pstree-3.txt, plugable-pstree-4.txt, plugable-pstree.txt Trunk version of Pluggable process tree. Work based on MAPREDUCE-4204 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4275) Plugable process tree
[ https://issues.apache.org/jira/browse/MAPREDUCE-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428037#comment-13428037 ] Hadoop QA commented on MAPREDUCE-4275: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12539036/plugable-pstree-4-with-whitespace.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.TestContainersMonitor org.apache.hadoop.yarn.server.nodemanager.TestEventFlow org.apache.hadoop.yarn.server.nodemanager.containermanager.TestContainerManager org.apache.hadoop.yarn.server.nodemanager.TestNodeStatusUpdater org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2704//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2704//console This message is automatically generated. Plugable process tree - Key: MAPREDUCE-4275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4275 Project: Hadoop Map/Reduce Issue Type: Improvement Components: nodemanager Affects Versions: 3.0.0 Environment: FreeBSD 64 bit Reporter: Radim Kolar Attachments: plugable-pstree-1.txt, plugable-pstree-2.txt, plugable-pstree-3.txt, plugable-pstree-4-with-whitespace.txt, plugable-pstree-4.txt, plugable-pstree.txt Trunk version of Pluggable process tree. Work based on MAPREDUCE-4204 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4275) Plugable process tree
[ https://issues.apache.org/jira/browse/MAPREDUCE-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428094#comment-13428094 ] Hadoop QA commented on MAPREDUCE-4275: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12539050/plugable-pstree-5-with-whitespace.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2705//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2705//console This message is automatically generated. Plugable process tree - Key: MAPREDUCE-4275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4275 Project: Hadoop Map/Reduce Issue Type: Improvement Components: nodemanager Affects Versions: 3.0.0 Environment: FreeBSD 64 bit Reporter: Radim Kolar Attachments: plugable-pstree-1.txt, plugable-pstree-2.txt, plugable-pstree-3.txt, plugable-pstree-4-with-whitespace.txt, plugable-pstree-4.txt, plugable-pstree-5-with-whitespace.txt, plugable-pstree.txt Trunk version of Pluggable process tree. Work based on MAPREDUCE-4204 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4275) Plugable process tree
[
https://issues.apache.org/jira/browse/MAPREDUCE-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428279#comment-13428279
]
Bikas Saha commented on MAPREDUCE-4275:
---
Thanks for incorporating my comments. +1.
Minor typo in unavailable
{code}
+if (resourceCalculatorPlugin == null) {
+LOG.info(ResourceCalculatorPlugin is unavaiable on this system.
++ this.getClass().getName() + is disabled.);
+return false;
+}
+if (ResourceCalculatorProcessTree.getResourceCalculatorProcessTree(0,
processTreeClass, conf) == null) {
+LOG.info(ResourceCalculatorProcessTree is unavaiable on this system.
++ this.getClass().getName() + is disabled.);
{code}
Plugable process tree
-
Key: MAPREDUCE-4275
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4275
Project: Hadoop Map/Reduce
Issue Type: Improvement
Components: nodemanager
Affects Versions: 3.0.0
Environment: FreeBSD 64 bit
Reporter: Radim Kolar
Attachments: plugable-pstree-1.txt, plugable-pstree-2.txt,
plugable-pstree-3.txt, plugable-pstree-4-with-whitespace.txt,
plugable-pstree-4.txt, plugable-pstree-5-with-whitespace.txt,
plugable-pstree.txt
Trunk version of Pluggable process tree. Work based on MAPREDUCE-4204
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4275) Plugable process tree
[ https://issues.apache.org/jira/browse/MAPREDUCE-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428526#comment-13428526 ] Hadoop QA commented on MAPREDUCE-4275: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12539110/plugable-pstree-6-typofix.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2708//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2708//console This message is automatically generated. Plugable process tree - Key: MAPREDUCE-4275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4275 Project: Hadoop Map/Reduce Issue Type: Improvement Components: nodemanager Affects Versions: 3.0.0 Environment: FreeBSD 64 bit Reporter: Radim Kolar Attachments: plugable-pstree-1.txt, plugable-pstree-2.txt, plugable-pstree-3.txt, plugable-pstree-4-with-whitespace.txt, plugable-pstree-4.txt, plugable-pstree-5-with-whitespace.txt, plugable-pstree-6-typofix.txt, plugable-pstree.txt Trunk version of Pluggable process tree. Work based on MAPREDUCE-4204 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4275) Plugable process tree
[ https://issues.apache.org/jira/browse/MAPREDUCE-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13427483#comment-13427483 ] Bikas Saha commented on MAPREDUCE-4275: --- I am ok with the null pointer check. You are right that there should be a single factory getting OS specific resource objects. How about moving the procfsbasedprocesstree factory to resourcecalculatorprocesstree for now so that the code flow stays similar to what it currently is. Looks like you have some ideas for re-organizing this part of the code better. we could handle the factory creation and other refactorings etc as part of that change. sounds like a plan? Plugable process tree - Key: MAPREDUCE-4275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4275 Project: Hadoop Map/Reduce Issue Type: Improvement Components: nodemanager Affects Versions: 3.0.0 Environment: FreeBSD 64 bit Reporter: Radim Kolar Attachments: plugable-pstree-1.txt, plugable-pstree-2.txt, plugable-pstree.txt Trunk version of Pluggable process tree. Work based on MAPREDUCE-4204 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4275) Plugable process tree
[
https://issues.apache.org/jira/browse/MAPREDUCE-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13425571#comment-13425571
]
Bikas Saha commented on MAPREDUCE-4275:
---
1) This code is mainly used to control the monitoring thread. The monitoring
thread relies on availability of ResourceCalculatorProcessTree and not on
resourceCalculatorPlugin. Hence, I would tend to replace
ProcfsBasedProcessTree.isAvailable() with
ResourceCalculatorProcessTree.isAvailable(). That is the approach taken in
MAPREDUCE-4204.
ResourceCalculatorPlugin is more of a system resource calculator for the
machine resources. Getting ResourceCalculatorProcessTree impl from
ResourceCalculatorPlugin formally connects them in the object model. Also, it
does not sound like a standard pattern to have Class B become the factory of
Class A.
{code}
private boolean isEnabled() {
-if (!ProcfsBasedProcessTree.isAvailable()) {
- LOG.info(ProcessTree implementation is missing on this system.
- + this.getClass().getName() + is disabled.);
- return false;
+if (resourceCalculatorPlugin == null) {
+LOG.info(ResourceCalculatorPlugin is unavaiable on this system.
++ this.getClass().getName() + is disabled.);
+return false;
}
{code}
2. There are a bunch of diff's like the following that are adding noise to the
patch and making it larger than it should be. Mind checking and cleaning up?
{code}
/**
* Checks if the ProcfsBasedProcessTree is available on this system.
- *
+ *
* @return true if ProcfsBasedProcessTree is available. False otherwise.
*/
{code}
Plugable process tree
-
Key: MAPREDUCE-4275
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4275
Project: Hadoop Map/Reduce
Issue Type: Improvement
Components: nodemanager
Affects Versions: 3.0.0
Environment: FreeBSD 64 bit
Reporter: Radim Kolar
Attachments: plugable-pstree-1.txt, plugable-pstree-2.txt,
plugable-pstree.txt
Trunk version of Pluggable process tree. Work based on MAPREDUCE-4204
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4275) Plugable process tree
[ https://issues.apache.org/jira/browse/MAPREDUCE-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13425831#comment-13425831 ] Radim Kolar commented on MAPREDUCE-4275: static isAvailable() is worst possible design, because 1. its static and 2. its heavyweight compared to not null pointer check. Best design would be to have one factory per operation system supported which will create different OS specific objects - currently there are two: ResourceCalculatorProcessTree and ResourceCalculatorPlugin. ContainersMonitorImpl is using both ResourceCalculatorProcessTree and ResourceCalculatorProcessTree. these space issues are caused by editor killing trailing whitespace, which is good thing. Probably --ignore-whitespace in patch will strip it. But because i am really in hurry and this issue takes MONTHS to resolve for no apparent reason, i will code whatever design you want. If you want static isAvailable(), i will deliver it. Just state clearly what you want. I will throw out this code after few months, it will be replaced by pluggable resources, which are way better design. Plugable process tree - Key: MAPREDUCE-4275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4275 Project: Hadoop Map/Reduce Issue Type: Improvement Components: nodemanager Affects Versions: 3.0.0 Environment: FreeBSD 64 bit Reporter: Radim Kolar Attachments: plugable-pstree-1.txt, plugable-pstree-2.txt, plugable-pstree.txt Trunk version of Pluggable process tree. Work based on MAPREDUCE-4204 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4275) Plugable process tree
[ https://issues.apache.org/jira/browse/MAPREDUCE-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422275#comment-13422275 ] Radim Kolar commented on MAPREDUCE-4275: check for ContainerExecutor.isSetSidAvailable has nothing to do with pstree. ContainerExecutor needs to be redesigned to make it abstract with almost no code inside and then create UnixContainerExecuter which will do setsid check and other unix specific stuff moved there. If linux still needs some special features then it can subclass unixcontainerexecutor. Plugable process tree - Key: MAPREDUCE-4275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4275 Project: Hadoop Map/Reduce Issue Type: Improvement Components: nodemanager Affects Versions: 3.0.0 Environment: FreeBSD 64 bit Reporter: Radim Kolar Attachments: plugable-pstree-1.txt, plugable-pstree-2.txt, plugable-pstree.txt Trunk version of Pluggable process tree. Work based on MAPREDUCE-4204 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4275) Plugable process tree
[ https://issues.apache.org/jira/browse/MAPREDUCE-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422290#comment-13422290 ] Hadoop QA commented on MAPREDUCE-4275: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12537833/plugable-pstree-2.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2657//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2657//console This message is automatically generated. Plugable process tree - Key: MAPREDUCE-4275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4275 Project: Hadoop Map/Reduce Issue Type: Improvement Components: nodemanager Affects Versions: 3.0.0 Environment: FreeBSD 64 bit Reporter: Radim Kolar Attachments: plugable-pstree-1.txt, plugable-pstree-2.txt, plugable-pstree.txt Trunk version of Pluggable process tree. Work based on MAPREDUCE-4204 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4275) Plugable process tree
[
https://issues.apache.org/jira/browse/MAPREDUCE-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420889#comment-13420889
]
Bikas Saha commented on MAPREDUCE-4275:
---
Thanks for the patch and sorry for not getting to it earlier.
In future, could you please use the --no-prefix tag so that the diff does not
have a/hadoop-mapreduce/.. and is easier to apply.
1) In general there are a bunch of extra spaces all over the place that would
be good to remove.
2) The comment looks like it has a typo in ResourceCalculatorPlugin.java
{code}
/**
* Get the ResourceCalculatorProcessTree configure it. This method will try
* and return a ResourceCalculatorProcessTree available for this system.
{code}
3. ContainerMonitorImpl.java
There is an indentation issue in the first if. The second if statement is
leaking Linux semantics into the code by trying to get process tree for pid 1.
IMO, the fact that resourceCalculatorPlugin exists should be enough to ensure
that underlying interfaces have been correctly implemented.
{code}
if (resourceCalculatorPlugin == null) {
LOG.info(ResourceCalculatorPlugin is unavaiable on this
system.
+ this.getClass().getName() + is disabled.);
return false;
}
if (resourceCalculatorPlugin.getResourceCalculatorProcessTree(1) == null
) {
LOG.info(ProcessTree implementation is missing on this system.
+ this.getClass().getName() + is disabled.);
return false;
}
{code}
After removal of the following code can ContainerExecutor.isSetSidAvailable be
removed too? Any more cleanup possible?
{code}
ProcfsBasedProcessTree pt =
new ProcfsBasedProcessTree(pId,
ContainerExecutor.isSetsidAvailable);
{code}
Other than these, it look good.
Plugable process tree
-
Key: MAPREDUCE-4275
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4275
Project: Hadoop Map/Reduce
Issue Type: Improvement
Components: nodemanager
Affects Versions: 3.0.0
Environment: FreeBSD 64 bit
Reporter: Radim Kolar
Attachments: plugable-pstree-1.txt, plugable-pstree.txt
Trunk version of Pluggable process tree. Work based on MAPREDUCE-4204
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4275) Plugable process tree
[ https://issues.apache.org/jira/browse/MAPREDUCE-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13292557#comment-13292557 ] Radim Kolar commented on MAPREDUCE-4275: I really need this to get commited. Plugable process tree - Key: MAPREDUCE-4275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4275 Project: Hadoop Map/Reduce Issue Type: Improvement Components: nodemanager Affects Versions: 3.0.0 Environment: FreeBSD 64 bit Reporter: Radim Kolar Attachments: plugable-pstree-1.txt, plugable-pstree.txt Trunk version of Pluggable process tree. Work based on MAPREDUCE-4204 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4275) Plugable process tree
[ https://issues.apache.org/jira/browse/MAPREDUCE-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279995#comment-13279995 ] Hadoop QA commented on MAPREDUCE-4275: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12528392/plugable-pstree.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.TestContainersMonitor +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2404//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2404//artifact/trunk/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2404//console This message is automatically generated. Plugable process tree - Key: MAPREDUCE-4275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4275 Project: Hadoop Map/Reduce Issue Type: Improvement Components: nodemanager Affects Versions: 3.0.0 Environment: FreeBSD 64 bit Reporter: Radim Kolar Fix For: 0.23.0, 2.0.0, 3.0.0 Attachments: plugable-pstree.txt Trunk version of Pluggable process tree. Work based on MAPREDUCE-4204 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4275) Plugable process tree
[ https://issues.apache.org/jira/browse/MAPREDUCE-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13280078#comment-13280078 ] Hadoop QA commented on MAPREDUCE-4275: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12528407/plugable-pstree-1.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2405//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2405//console This message is automatically generated. Plugable process tree - Key: MAPREDUCE-4275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4275 Project: Hadoop Map/Reduce Issue Type: Improvement Components: nodemanager Affects Versions: 3.0.0 Environment: FreeBSD 64 bit Reporter: Radim Kolar Fix For: 0.23.0, 2.0.0, 3.0.0 Attachments: plugable-pstree-1.txt, plugable-pstree.txt Trunk version of Pluggable process tree. Work based on MAPREDUCE-4204 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
