[jira] [Commented] (MAPREDUCE-4431) killing already completed job gives ambiguous message as Killed job job id
[ https://issues.apache.org/jira/browse/MAPREDUCE-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14318015#comment-14318015 ] Tsuyoshi OZAWA commented on MAPREDUCE-4431: --- +1, committing this shortly. killing already completed job gives ambiguous message as Killed job job id -- Key: MAPREDUCE-4431 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4431 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Reporter: Nishan Shetty Assignee: Devaraj K Priority: Minor Attachments: MAPREDUCE-4431-1.patch, MAPREDUCE-4431-2.patch, MAPREDUCE-4431.patch If we try to kill the already completed job by the following command it gives ambiguous message as Killed job job id ./mapred job -kill already completed job id -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-4431) killing already completed job gives ambiguous message as Killed job job id
[
https://issues.apache.org/jira/browse/MAPREDUCE-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14316285#comment-14316285
]
Devaraj K commented on MAPREDUCE-4431:
--
{code:xml}
-1 findbugs. The patch appears to introduce 13 new Findbugs (version 2.0.3)
warnings.
{code}
These are not related to the patch, and MAPREDUCE-6225 exists to track these
warnings.
killing already completed job gives ambiguous message as Killed job job id
--
Key: MAPREDUCE-4431
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4431
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: mrv2
Reporter: Nishan Shetty
Assignee: Devaraj K
Priority: Minor
Attachments: MAPREDUCE-4431-1.patch, MAPREDUCE-4431-2.patch,
MAPREDUCE-4431.patch
If we try to kill the already completed job by the following command it gives
ambiguous message as Killed job job id
./mapred job -kill already completed job id
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-4431) killing already completed job gives ambiguous message as Killed job job id
[
https://issues.apache.org/jira/browse/MAPREDUCE-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14316149#comment-14316149
]
Hadoop QA commented on MAPREDUCE-4431:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12698067/MAPREDUCE-4431-2.patch
against trunk revision c541a37.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 13 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5186//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5186//artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5186//console
This message is automatically generated.
killing already completed job gives ambiguous message as Killed job job id
--
Key: MAPREDUCE-4431
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4431
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: mrv2
Reporter: Nishan Shetty
Assignee: Devaraj K
Priority: Minor
Attachments: MAPREDUCE-4431-1.patch, MAPREDUCE-4431-2.patch,
MAPREDUCE-4431.patch
If we try to kill the already completed job by the following command it gives
ambiguous message as Killed job job id
./mapred job -kill already completed job id
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-4431) killing already completed job gives ambiguous message as Killed job job id
[ https://issues.apache.org/jira/browse/MAPREDUCE-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428590#comment-13428590 ] Harsh J commented on MAPREDUCE-4431: bq. In case the job was already killed, should we perhaps return 0 exitCode (since the kill was (already) successful? On second thought, lets not do this, as it would be in violation of what a command's run means. Only if the command were truly successful for that very instance we should return 0. So +1 and committing shortly. killing already completed job gives ambiguous message as Killed job job id -- Key: MAPREDUCE-4431 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4431 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 2.0.0-alpha, 3.0.0 Reporter: Nishan Shetty Assignee: Devaraj K Priority: Minor Attachments: MAPREDUCE-4431-1.patch, MAPREDUCE-4431.patch If we try to kill the already completed job by the following command it gives ambiguous message as Killed job job id ./mapred job -kill already completed job id -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4431) killing already completed job gives ambiguous message as Killed job job id
[ https://issues.apache.org/jira/browse/MAPREDUCE-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13427989#comment-13427989 ] Devaraj K commented on MAPREDUCE-4431: -- Hi Harsh, can you have a look into the updated patch when you find some time? killing already completed job gives ambiguous message as Killed job job id -- Key: MAPREDUCE-4431 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4431 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 2.0.0-alpha, 3.0.0 Reporter: Nishan Shetty Assignee: Devaraj K Priority: Minor Attachments: MAPREDUCE-4431-1.patch, MAPREDUCE-4431.patch If we try to kill the already completed job by the following command it gives ambiguous message as Killed job job id ./mapred job -kill already completed job id -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4431) killing already completed job gives ambiguous message as Killed job job id
[ https://issues.apache.org/jira/browse/MAPREDUCE-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428273#comment-13428273 ] Mayank Bansal commented on MAPREDUCE-4431: -- +1 Looks good. Thanks, Mayank killing already completed job gives ambiguous message as Killed job job id -- Key: MAPREDUCE-4431 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4431 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 2.0.0-alpha, 3.0.0 Reporter: Nishan Shetty Assignee: Devaraj K Priority: Minor Attachments: MAPREDUCE-4431-1.patch, MAPREDUCE-4431.patch If we try to kill the already completed job by the following command it gives ambiguous message as Killed job job id ./mapred job -kill already completed job id -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4431) killing already completed job gives ambiguous message as Killed job job id
[
https://issues.apache.org/jira/browse/MAPREDUCE-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428541#comment-13428541
]
Harsh J commented on MAPREDUCE-4431:
+1, looks good to me too.
One comment though (just want your thought):
{code}
+System.out.println(The job + jobid + has already been
killed.);
+exitCode = -1;
{code}
In case the job was already killed, should we perhaps return 0 exitCode (since
the kill was (already) successful?
killing already completed job gives ambiguous message as Killed job job id
--
Key: MAPREDUCE-4431
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4431
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: mrv2
Affects Versions: 2.0.0-alpha, 3.0.0
Reporter: Nishan Shetty
Assignee: Devaraj K
Priority: Minor
Attachments: MAPREDUCE-4431-1.patch, MAPREDUCE-4431.patch
If we try to kill the already completed job by the following command it gives
ambiguous message as Killed job job id
./mapred job -kill already completed job id
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4431) killing already completed job gives ambiguous message as Killed job job id
[ https://issues.apache.org/jira/browse/MAPREDUCE-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13417029#comment-13417029 ] Hadoop QA commented on MAPREDUCE-4431: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12536978/MAPREDUCE-4431.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2621//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2621//console This message is automatically generated. killing already completed job gives ambiguous message as Killed job job id -- Key: MAPREDUCE-4431 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4431 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 2.0.0-alpha, 3.0.0 Reporter: Nishan Shetty Assignee: Devaraj K Priority: Minor Attachments: MAPREDUCE-4431.patch If we try to kill the already completed job by the following command it gives ambiguous message as Killed job job id ./mapred job -kill already completed job id -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4431) killing already completed job gives ambiguous message as Killed job job id
[
https://issues.apache.org/jira/browse/MAPREDUCE-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13417185#comment-13417185
]
Harsh J commented on MAPREDUCE-4431:
Thanks Devaraj. Couple of points:
* In case of a job -kill on killed, failed or succeeded jobs, given your patch,
we'll get a very ambiguous: Could not kill the Job since the Job State is
{KILLED,FAILED,SUCCEEDED}..
** Perhaps we can instead check for state better and say things in each case
thats more apt/intelligible.
*** Could not kill the job job ID, as it has already succeeded.
*** Could not mark the job job ID as killed, as it has already failed.
*** The job job ID has already been killed.
* Can we have a test for this? That is, if we're trying to prevent a double
killJob() calls to the AM/cluster.
killing already completed job gives ambiguous message as Killed job job id
--
Key: MAPREDUCE-4431
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4431
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: mrv2
Affects Versions: 2.0.0-alpha, 3.0.0
Reporter: Nishan Shetty
Assignee: Devaraj K
Priority: Minor
Attachments: MAPREDUCE-4431.patch
If we try to kill the already completed job by the following command it gives
ambiguous message as Killed job job id
./mapred job -kill already completed job id
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4431) killing already completed job gives ambiguous message as Killed job job id
[
https://issues.apache.org/jira/browse/MAPREDUCE-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13412635#comment-13412635
]
Nishan Shetty commented on MAPREDUCE-4431:
--
{noformat}
12/07/12 14:27:35 INFO mapred.ClientServiceDelegate: Application state is
completed. FinalApplicationStatus=SUCCEEDED. Redirecting to job history server
12/07/12 14:27:35 INFO mapred.ResourceMgrDelegate: Killing application
application_1342080430464_0001
Killed job job_1342080430464_0001
{noformat}
killing already completed job gives ambiguous message as Killed job job id
--
Key: MAPREDUCE-4431
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4431
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: mrv2
Reporter: Nishan Shetty
Priority: Minor
If we try to kill the already completed job by the following command it gives
ambiguous message as Killed job job id
./mapred job -kill already completed job id
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
