[jira] [Commented] (MAPREDUCE-5977) Fix or suppress native-task gcc warnings
[ https://issues.apache.org/jira/browse/MAPREDUCE-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132763#comment-14132763 ] Hudson commented on MAPREDUCE-5977: --- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1870 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1870/]) MAPREDUCE-5977. Fix or suppress native-task gcc warnings. Contributed by Manu Zhang. (todd: rev fad4524c85848b8efe27dcf4a3e3a9ac1725bd2a) * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestIterator.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/PartitionBucket.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/handler/BatchHandler.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/MapOutputCollector.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/commons.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestByteBuffer.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/IFile.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/CMakeLists.txt * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/Buffers.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/util/TestHash.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/MapOutputCollector.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/codec/BlockCodec.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestMemoryBlock.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestMemBlockIterator.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/NativeTask.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/Merge.cc * hadoop-mapreduce-project/CHANGES.MAPREDUCE-2841.txt * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/handler/CombineHandler.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/include/gtest/gtest.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestFixSizeContainer.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/TestIFile.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/TestCompressions.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/util/StringUtil.cc > Fix or suppress native-task gcc warnings > > > Key: MAPREDUCE-5977 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5977 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Todd Lipcon >Assignee: Manu Zhang > Attachments: gcc_compile.log, mapreduce-5977-v2.txt, > mapreduce-5977-v3.txt, mapreduce-5977.txt, mapreduce-6056-v3.txt > > > Currently, building the native task code on gcc 4.8 has a fair number of > warnings. We should fix or suppress them so that new warnings are easier to > see. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-5977) Fix or suppress native-task gcc warnings
[ https://issues.apache.org/jira/browse/MAPREDUCE-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132724#comment-14132724 ] Hudson commented on MAPREDUCE-5977: --- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1895 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1895/]) MAPREDUCE-5977. Fix or suppress native-task gcc warnings. Contributed by Manu Zhang. (todd: rev fad4524c85848b8efe27dcf4a3e3a9ac1725bd2a) * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestMemBlockIterator.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestIterator.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/handler/CombineHandler.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/CMakeLists.txt * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/handler/BatchHandler.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestByteBuffer.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/commons.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestFixSizeContainer.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/include/gtest/gtest.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/Buffers.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/util/TestHash.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/TestIFile.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/PartitionBucket.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestMemoryBlock.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/IFile.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/TestCompressions.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/MapOutputCollector.h * hadoop-mapreduce-project/CHANGES.MAPREDUCE-2841.txt * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/MapOutputCollector.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/codec/BlockCodec.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/util/StringUtil.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/NativeTask.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/Merge.cc > Fix or suppress native-task gcc warnings > > > Key: MAPREDUCE-5977 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5977 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Todd Lipcon >Assignee: Manu Zhang > Attachments: gcc_compile.log, mapreduce-5977-v2.txt, > mapreduce-5977-v3.txt, mapreduce-5977.txt, mapreduce-6056-v3.txt > > > Currently, building the native task code on gcc 4.8 has a fair number of > warnings. We should fix or suppress them so that new warnings are easier to > see. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-5977) Fix or suppress native-task gcc warnings
[ https://issues.apache.org/jira/browse/MAPREDUCE-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132666#comment-14132666 ] Hudson commented on MAPREDUCE-5977: --- SUCCESS: Integrated in Hadoop-Yarn-trunk #679 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/679/]) MAPREDUCE-5977. Fix or suppress native-task gcc warnings. Contributed by Manu Zhang. (todd: rev fad4524c85848b8efe27dcf4a3e3a9ac1725bd2a) * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/util/TestHash.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestMemoryBlock.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/MapOutputCollector.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/Buffers.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestMemBlockIterator.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestIterator.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/handler/BatchHandler.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/CMakeLists.txt * hadoop-mapreduce-project/CHANGES.MAPREDUCE-2841.txt * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/handler/CombineHandler.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/TestIFile.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/util/StringUtil.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/codec/BlockCodec.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/MapOutputCollector.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/commons.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/Merge.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestFixSizeContainer.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestByteBuffer.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/PartitionBucket.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/IFile.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/TestCompressions.cc * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/include/gtest/gtest.h * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/NativeTask.h > Fix or suppress native-task gcc warnings > > > Key: MAPREDUCE-5977 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5977 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Todd Lipcon >Assignee: Manu Zhang > Attachments: gcc_compile.log, mapreduce-5977-v2.txt, > mapreduce-5977-v3.txt, mapreduce-5977.txt, mapreduce-6056-v3.txt > > > Currently, building the native task code on gcc 4.8 has a fair number of > warnings. We should fix or suppress them so that new warnings are easier to > see. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-5977) Fix or suppress native-task gcc warnings
[ https://issues.apache.org/jira/browse/MAPREDUCE-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14116627#comment-14116627 ] Manu Zhang commented on MAPREDUCE-5977: --- sorry, submitted patch at wrong place. Just ignore it > Fix or suppress native-task gcc warnings > > > Key: MAPREDUCE-5977 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5977 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Todd Lipcon >Assignee: Manu Zhang > Attachments: gcc_compile.log, mapreduce-5977-v2.txt, > mapreduce-5977-v3.txt, mapreduce-5977.txt, mapreduce-6056-v3.txt > > > Currently, building the native task code on gcc 4.8 has a fair number of > warnings. We should fix or suppress them so that new warnings are easier to > see. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MAPREDUCE-5977) Fix or suppress native-task gcc warnings
[ https://issues.apache.org/jira/browse/MAPREDUCE-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14116605#comment-14116605 ] Manu Zhang commented on MAPREDUCE-5977: --- If you checkout the github page (https://github.com/apache/hadoop-common/tree/MR-2841) , the last commit is MAPREDUCE-6025 and I can't pull in the changed made in above two jiras. > Fix or suppress native-task gcc warnings > > > Key: MAPREDUCE-5977 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5977 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Todd Lipcon >Assignee: Manu Zhang > Attachments: gcc_compile.log, mapreduce-5977-v2.txt, > mapreduce-5977-v3.txt, mapreduce-5977.txt > > > Currently, building the native task code on gcc 4.8 has a fair number of > warnings. We should fix or suppress them so that new warnings are easier to > see. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MAPREDUCE-5977) Fix or suppress native-task gcc warnings
[ https://issues.apache.org/jira/browse/MAPREDUCE-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14115166#comment-14115166 ] Binglin Chang commented on MAPREDUCE-5977: -- decster:~/projects/hadoop-trunk> git la 2014-08-27 bfd1d75 (Todd Lipcon): MAPREDUCE-6054. native-task: Speed up tests. Contributed by Todd Lipcon. 2014-08-27 fad4524 (Todd Lipcon): MAPREDUCE-5977. Fix or suppress native-task gcc warnings. Contributed by Manu Zhang. > Fix or suppress native-task gcc warnings > > > Key: MAPREDUCE-5977 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5977 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Todd Lipcon >Assignee: Manu Zhang > Attachments: gcc_compile.log, mapreduce-5977-v2.txt, > mapreduce-5977-v3.txt, mapreduce-5977.txt > > > Currently, building the native task code on gcc 4.8 has a fair number of > warnings. We should fix or suppress them so that new warnings are easier to > see. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MAPREDUCE-5977) Fix or suppress native-task gcc warnings
[ https://issues.apache.org/jira/browse/MAPREDUCE-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14115162#comment-14115162 ] Binglin Chang commented on MAPREDUCE-5977: -- Haodop has moved to git, see https://wiki.apache.org/hadoop/HowToCommitWithGit > Fix or suppress native-task gcc warnings > > > Key: MAPREDUCE-5977 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5977 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Todd Lipcon >Assignee: Manu Zhang > Attachments: gcc_compile.log, mapreduce-5977-v2.txt, > mapreduce-5977-v3.txt, mapreduce-5977.txt > > > Currently, building the native task code on gcc 4.8 has a fair number of > warnings. We should fix or suppress them so that new warnings are easier to > see. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MAPREDUCE-5977) Fix or suppress native-task gcc warnings
[ https://issues.apache.org/jira/browse/MAPREDUCE-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14115154#comment-14115154 ] Manu Zhang commented on MAPREDUCE-5977: --- Hi Todd. Haven't seen this committed in. Anything wrong with git ? > Fix or suppress native-task gcc warnings > > > Key: MAPREDUCE-5977 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5977 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Todd Lipcon >Assignee: Manu Zhang > Attachments: gcc_compile.log, mapreduce-5977-v2.txt, > mapreduce-5977-v3.txt, mapreduce-5977.txt > > > Currently, building the native task code on gcc 4.8 has a fair number of > warnings. We should fix or suppress them so that new warnings are easier to > see. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MAPREDUCE-5977) Fix or suppress native-task gcc warnings
[ https://issues.apache.org/jira/browse/MAPREDUCE-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14108729#comment-14108729 ] Allen Wittenauer commented on MAPREDUCE-5977: - svn is read-only as we are switching to git. See related posts in *-dev. > Fix or suppress native-task gcc warnings > > > Key: MAPREDUCE-5977 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5977 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Todd Lipcon >Assignee: Manu Zhang > Attachments: gcc_compile.log, mapreduce-5977-v2.txt, > mapreduce-5977-v3.txt, mapreduce-5977.txt > > > Currently, building the native task code on gcc 4.8 has a fair number of > warnings. We should fix or suppress them so that new warnings are easier to > see. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MAPREDUCE-5977) Fix or suppress native-task gcc warnings
[ https://issues.apache.org/jira/browse/MAPREDUCE-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14108675#comment-14108675 ] Sean Zhong commented on MAPREDUCE-5977: --- Hi Todd, I encounter errors when trying to commit, can you try this in your side? Commit failed (details follow): Changing file 'C:\myData\MR-28412\hadoop-mapreduce-project\hadoop-mapreduce-client\hadoop-mapreduce-client-nativetask\src\main\native\gtest\gtest.h' is forbidden by the server Access to '/repos/asf/!svn/txr/1620252-ziae/hadoop/common/branches/MR-2841/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest.h' forbidden Additional errors: DELETE of '/repos/asf/!svn/txr/1620252-ziae/hadoop/common/branches/MR-2841/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest.h': 403 Forbidden > Fix or suppress native-task gcc warnings > > > Key: MAPREDUCE-5977 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5977 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Todd Lipcon >Assignee: Manu Zhang > Attachments: gcc_compile.log, mapreduce-5977-v2.txt, > mapreduce-5977-v3.txt, mapreduce-5977.txt > > > Currently, building the native task code on gcc 4.8 has a fair number of > warnings. We should fix or suppress them so that new warnings are easier to > see. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MAPREDUCE-5977) Fix or suppress native-task gcc warnings
[ https://issues.apache.org/jira/browse/MAPREDUCE-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107564#comment-14107564 ] Todd Lipcon commented on MAPREDUCE-5977: Patch looks good to me. +1. Sean, you want to commit this? > Fix or suppress native-task gcc warnings > > > Key: MAPREDUCE-5977 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5977 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Todd Lipcon >Assignee: Manu Zhang > Attachments: gcc_compile.log, mapreduce-5977-v2.txt, > mapreduce-5977-v3.txt, mapreduce-5977.txt > > > Currently, building the native task code on gcc 4.8 has a fair number of > warnings. We should fix or suppress them so that new warnings are easier to > see. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MAPREDUCE-5977) Fix or suppress native-task gcc warnings
[ https://issues.apache.org/jira/browse/MAPREDUCE-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100247#comment-14100247 ] Manu Zhang commented on MAPREDUCE-5977: --- bq. is this because that it is more easy to treat it as system header, and removing compilation warnings? Yes, the directory structure also conforms to that of the original google test project. > Fix or suppress native-task gcc warnings > > > Key: MAPREDUCE-5977 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5977 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Todd Lipcon >Assignee: Manu Zhang > Attachments: gcc_compile.log, mapreduce-5977-v2.txt, > mapreduce-5977-v3.txt, mapreduce-5977.txt > > > Currently, building the native task code on gcc 4.8 has a fair number of > warnings. We should fix or suppress them so that new warnings are easier to > see. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MAPREDUCE-5977) Fix or suppress native-task gcc warnings
[ https://issues.apache.org/jira/browse/MAPREDUCE-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100235#comment-14100235 ] Sean Zhong commented on MAPREDUCE-5977: --- gtest.h is moved to folder gtest/include/gtest/, is this because that it is more easy to treat it as system header, and removing compilation warnings? New patch looks good > Fix or suppress native-task gcc warnings > > > Key: MAPREDUCE-5977 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5977 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Todd Lipcon >Assignee: Manu Zhang > Attachments: gcc_compile.log, mapreduce-5977-v2.txt, > mapreduce-5977-v3.txt, mapreduce-5977.txt > > > Currently, building the native task code on gcc 4.8 has a fair number of > warnings. We should fix or suppress them so that new warnings are easier to > see. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MAPREDUCE-5977) Fix or suppress native-task gcc warnings
[ https://issues.apache.org/jira/browse/MAPREDUCE-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098037#comment-14098037 ] Manu Zhang commented on MAPREDUCE-5977: --- Hi Todd, patch updated as per your comments. > Fix or suppress native-task gcc warnings > > > Key: MAPREDUCE-5977 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5977 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Todd Lipcon >Assignee: Manu Zhang > Attachments: gcc_compile.log, mapreduce-5977-v2.txt, > mapreduce-5977-v3.txt, mapreduce-5977.txt > > > Currently, building the native task code on gcc 4.8 has a fair number of > warnings. We should fix or suppress them so that new warnings are easier to > see. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MAPREDUCE-5977) Fix or suppress native-task gcc warnings
[ https://issues.apache.org/jira/browse/MAPREDUCE-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096748#comment-14096748 ] Manu Zhang commented on MAPREDUCE-5977: --- Thanks for the comment. 1. Just wrote a performance test on WritableUtils:writeFloat, where I wrote out a float for 10M times. I didn't find any difference w/ and w/o strict-aliasing flag. Also checked about other native perf tests and no impact of -fno-strict-aliasing was found. 2. oh, I was too happy removing unused codes. I will use assertion. 3. your trick looks fine. will upload a new patch soon > Fix or suppress native-task gcc warnings > > > Key: MAPREDUCE-5977 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5977 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Todd Lipcon >Assignee: Manu Zhang > Attachments: gcc_compile.log, mapreduce-5977-v2.txt, > mapreduce-5977.txt > > > Currently, building the native task code on gcc 4.8 has a fair number of > warnings. We should fix or suppress them so that new warnings are easier to > see. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MAPREDUCE-5977) Fix or suppress native-task gcc warnings
[
https://issues.apache.org/jira/browse/MAPREDUCE-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096582#comment-14096582
]
Todd Lipcon commented on MAPREDUCE-5977:
Have you done any simple before/after performance check of the impact of
-fno-strict-aliasing? I generally support the flag, but would be good to have
some assurance that it's not hurting any hot path. If it is we can manually add
'restrict' keywords where necessary. Another option is to fix the warnings
where they show up by changing type punning to memcpy (which generally gets
optimized to simple loads/stores if it has a fixed length)
{code}
}
@@ -196,7 +194,6 @@ void MeasureSingleFileLz4(const string & path,
CompressResult & total, size_t bl
startTime = t.now();
for (int i = 0; i < times; i++) {
// memset(dest, 0, currentblocksize+8);
- int osize = LZ4_uncompress(outputBuffer, dest, currentblocksize);
// printf("%016llx blocksize: %lu\n",
bswap64(*(uint64_t*)(dest+currentblocksize)), currentblocksize);
}
{code}
Removing this call seems problematic, given this is purporting to benchmark LZO
decompression and you just removed the call to decompress :)
Maybe you want to either cast the call to void (to get rid of the warning), or
perform some kind of assertion on 'osize' so it's not unused?
{code}
while (ir->nextPartition()) {
-const char * key, *value;
+const char * key;
uint32_t keyLen, valueLen;
while (NULL != (key = ir->nextKey(keyLen))) {
- value = ir->value(valueLen);
+ ir->value(valueLen);
}
}
{code}
Again, for a benchmark, this seem suspicious. The compiler might well elide the
ir->value() call if it figures out there is no side effect. One trick I usually
use here is to do something like:
{code}
int sum = 0;
while (ir->nextPartition()) {
const char * key, *value;
uint32_t keyLen, valueLen;
while (NULL != (key = ir->nextKey(keyLen))) {
value = ir->value(valueLen);
sum += value[0];
}
}
// Use the result so that the value() calls don't get optimized out.
ASSERT_NE(0xdeadbeef, sum);
{code}
(or if you don't like assert, another option is to log the result -- anything
so that gcc knows that it can't elide the actual memory accesses in the loop)
> Fix or suppress native-task gcc warnings
>
>
> Key: MAPREDUCE-5977
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5977
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: task
>Reporter: Todd Lipcon
>Assignee: Manu Zhang
> Attachments: gcc_compile.log, mapreduce-5977-v2.txt,
> mapreduce-5977.txt
>
>
> Currently, building the native task code on gcc 4.8 has a fair number of
> warnings. We should fix or suppress them so that new warnings are easier to
> see.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (MAPREDUCE-5977) Fix or suppress native-task gcc warnings
[ https://issues.apache.org/jira/browse/MAPREDUCE-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093686#comment-14093686 ] Manu Zhang commented on MAPREDUCE-5977: --- forget to mention I'm also using gcc 4.8 and all warnings disappear after the current patch is applied. > Fix or suppress native-task gcc warnings > > > Key: MAPREDUCE-5977 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5977 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Todd Lipcon >Assignee: Manu Zhang > Attachments: gcc_compile.log, mapreduce-5977-v2.txt, > mapreduce-5977.txt > > > Currently, building the native task code on gcc 4.8 has a fair number of > warnings. We should fix or suppress them so that new warnings are easier to > see. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MAPREDUCE-5977) Fix or suppress native-task gcc warnings
[ https://issues.apache.org/jira/browse/MAPREDUCE-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14092369#comment-14092369 ] Sean Zhong commented on MAPREDUCE-5977: --- HI, Manu, Can you attach a file of GCC compie logs? IMHO, static_cast from int to uint32_t change doesn't sound necessary and clean, maybe we should supress this kind of warnings. +1 for PRIu64 and PRId64, we need to test tihs in multiple platforms to make sure it is safe. For gtest warnings, we can suppress the warning mesage like this http://stackoverflow.com/questions/1867065/how-to-suppress-gcc-warnings-from-library-headers > Fix or suppress native-task gcc warnings > > > Key: MAPREDUCE-5977 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5977 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: task >Reporter: Todd Lipcon >Assignee: Manu Zhang > Attachments: mapreduce-5977.txt > > > Currently, building the native task code on gcc 4.8 has a fair number of > warnings. We should fix or suppress them so that new warnings are easier to > see. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MAPREDUCE-5977) Fix or suppress native-task gcc warnings
[
https://issues.apache.org/jira/browse/MAPREDUCE-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14092041#comment-14092041
]
Manu Zhang commented on MAPREDUCE-5977:
---
Hi Todd, I'd like to have a try with this jira.
Please note that *the attached patch doesn't handle all the issues*. I post it
here for your opinion over those I'm not sure or feel uncomfortable.
Here are they:
1. I used static_cast when it's safe to cast a int to unsigned int. (should we
use c-style cast instead ?)
2. I included and replaced "llu" with the macro PRIu64 which could
resolve to long long unsigned int or long unsigned int dependant on platforms .
Same for "lld" and PRId64. The only exception is
{code:c++}
string StringUtil::ToString(int64_t v, char pad, int64_t len) {
char tmp[32];
snprintf(tmp, 32, "%%%c%lldlld", pad, static_cast(len));
return Format(tmp, static_cast(v));
}
{code}
where it looks impossible to do so.
3. I've left out warnings like
{code}
warning: dereferencing type-punned pointer will break strict-aliasing rules
[-Wstrict-aliasing]
[exec]return *(float*)&ret;
{code}
where I have not found a safe way to cast.
4. I've left out unused-result warnings.
5. I've left out warnings generated by gtest.
> Fix or suppress native-task gcc warnings
>
>
> Key: MAPREDUCE-5977
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5977
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: task
>Reporter: Todd Lipcon
>Assignee: Todd Lipcon
> Attachments: mapreduce-5977.txt
>
>
> Currently, building the native task code on gcc 4.8 has a fair number of
> warnings. We should fix or suppress them so that new warnings are easier to
> see.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
