Re: [Marble-devel] Review Request 124666: Added stacking to Marble Maps

2015-08-25 Thread Gábor Péterffy 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124666/
---

(Updated Aug. 25, 2015, 4:19 p.m.)


Status
--

This change has been marked as submitted.


Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.


Changes
---

Submitted with commit 368d3144ca51d2cdd62ad5b10e2e39d3d100d3e2 by Gábor 
Péterffy to branch master.


Repository: marble


Description
---

- Working back button
- Reworked navigation setup


Diffs
-

  data/android/drawable-xxxhdpi/circular_menu_backdrop.png PRE-CREATION 
  data/android/drawable-xxxhdpi/delete_white.png PRE-CREATION 
  data/android/drawable-xxxhdpi/ic_place_arrival.png PRE-CREATION 
  data/android/drawable-xxxhdpi/ic_place_departure.png PRE-CREATION 
  data/android/drawable-xxxhdpi/ic_place_unknown.png PRE-CREATION 
  data/android/drawable-xxxhdpi/ic_place_via.png PRE-CREATION 
  src/apps/marble-maps/CircularMenu.qml PRE-CREATION 
  src/apps/marble-maps/MainScreen.qml cb88a0c 
  src/apps/marble-maps/MarbleMaps.qrc 1cba58d 
  src/apps/marble-maps/RoutePlanViewer.qml 4ca794e 
  src/apps/marble-maps/RoutingManager.qml 6434bff 
  src/apps/marble-maps/Search.qml 69ecc0a 
  src/apps/marble-maps/Waypoint.qml PRE-CREATION 
  src/apps/marble-maps/WaypointImage.qml 9b0aa01 
  src/apps/marble-maps/WaypointOrderManager.qml c77a460 
  src/lib/marble/declarative/Routing.h a1e93c5 
  src/lib/marble/declarative/Routing.cpp 38e0d66 

Diff: https://git.reviewboard.kde.org/r/124666/diff/


Testing
---


File Attachments


delete_white.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png
ic_place_via.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/52e58fcd-8c98-4a20-bc80-42f6e7f2fb20__ic_place_via.png
ic_place_unknown.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/305b1f56-ccc5-46a7-8c07-883b51f18f64__ic_place_unknown.png
ic_place_departure.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/9c01956d-6b25-42f8-96fb-e97e9fe15752__ic_place_departure.png
ic_place_arrival.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/e19d6f8c-0c96-4b76-9b85-610891d3b41b__ic_place_arrival.png
circular_menu_backdrop.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/2a1fd02c-940a-4aee-b8b4-afb66370a70d__circular_menu_backdrop.png


Thanks,

Gábor Péterffy

___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124666: Added stacking to Marble Maps

2015-08-25 Thread Gábor Péterffy 


> On Aug. 21, 2015, 9:11 p.m., Dennis Nienhüser wrote:
> > src/apps/marble-maps/CircularMenu.qml, line 38
> > 
> >
> > what about calling `root.selected(type)` in each WaypointImage?

I have changed it, I like your approach.


- Gábor


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124666/#review84155
---


On Aug. 25, 2015, 5:59 p.m., Gábor Péterffy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124666/
> ---
> 
> (Updated Aug. 25, 2015, 5:59 p.m.)
> 
> 
> Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.
> 
> 
> Repository: marble
> 
> 
> Description
> ---
> 
> - Working back button
> - Reworked navigation setup
> 
> 
> Diffs
> -
> 
>   data/android/drawable-xxxhdpi/circular_menu_backdrop.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/delete_white.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/ic_place_arrival.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/ic_place_departure.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/ic_place_unknown.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/ic_place_via.png PRE-CREATION 
>   src/apps/marble-maps/CircularMenu.qml PRE-CREATION 
>   src/apps/marble-maps/MainScreen.qml cb88a0c 
>   src/apps/marble-maps/MarbleMaps.qrc 1cba58d 
>   src/apps/marble-maps/RoutePlanViewer.qml 4ca794e 
>   src/apps/marble-maps/RoutingManager.qml 6434bff 
>   src/apps/marble-maps/Search.qml 69ecc0a 
>   src/apps/marble-maps/Waypoint.qml PRE-CREATION 
>   src/apps/marble-maps/WaypointImage.qml 9b0aa01 
>   src/apps/marble-maps/WaypointOrderManager.qml c77a460 
>   src/lib/marble/declarative/Routing.h a1e93c5 
>   src/lib/marble/declarative/Routing.cpp 38e0d66 
> 
> Diff: https://git.reviewboard.kde.org/r/124666/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> delete_white.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png
> ic_place_via.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/52e58fcd-8c98-4a20-bc80-42f6e7f2fb20__ic_place_via.png
> ic_place_unknown.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/305b1f56-ccc5-46a7-8c07-883b51f18f64__ic_place_unknown.png
> ic_place_departure.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/9c01956d-6b25-42f8-96fb-e97e9fe15752__ic_place_departure.png
> ic_place_arrival.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/e19d6f8c-0c96-4b76-9b85-610891d3b41b__ic_place_arrival.png
> circular_menu_backdrop.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/2a1fd02c-940a-4aee-b8b4-afb66370a70d__circular_menu_backdrop.png
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124666: Added stacking to Marble Maps

2015-08-25 Thread Gábor Péterffy 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124666/
---

(Updated Aug. 25, 2015, 5:59 p.m.)


Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.


Changes
---

Fixing issues


Repository: marble


Description
---

- Working back button
- Reworked navigation setup


Diffs (updated)
-

  data/android/drawable-xxxhdpi/circular_menu_backdrop.png PRE-CREATION 
  data/android/drawable-xxxhdpi/delete_white.png PRE-CREATION 
  data/android/drawable-xxxhdpi/ic_place_arrival.png PRE-CREATION 
  data/android/drawable-xxxhdpi/ic_place_departure.png PRE-CREATION 
  data/android/drawable-xxxhdpi/ic_place_unknown.png PRE-CREATION 
  data/android/drawable-xxxhdpi/ic_place_via.png PRE-CREATION 
  src/apps/marble-maps/CircularMenu.qml PRE-CREATION 
  src/apps/marble-maps/MainScreen.qml cb88a0c 
  src/apps/marble-maps/MarbleMaps.qrc 1cba58d 
  src/apps/marble-maps/RoutePlanViewer.qml 4ca794e 
  src/apps/marble-maps/RoutingManager.qml 6434bff 
  src/apps/marble-maps/Search.qml 69ecc0a 
  src/apps/marble-maps/Waypoint.qml PRE-CREATION 
  src/apps/marble-maps/WaypointImage.qml 9b0aa01 
  src/apps/marble-maps/WaypointOrderManager.qml c77a460 
  src/lib/marble/declarative/Routing.h a1e93c5 
  src/lib/marble/declarative/Routing.cpp 38e0d66 

Diff: https://git.reviewboard.kde.org/r/124666/diff/


Testing
---


File Attachments


delete_white.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png
ic_place_via.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/52e58fcd-8c98-4a20-bc80-42f6e7f2fb20__ic_place_via.png
ic_place_unknown.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/305b1f56-ccc5-46a7-8c07-883b51f18f64__ic_place_unknown.png
ic_place_departure.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/9c01956d-6b25-42f8-96fb-e97e9fe15752__ic_place_departure.png
ic_place_arrival.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/e19d6f8c-0c96-4b76-9b85-610891d3b41b__ic_place_arrival.png
circular_menu_backdrop.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/2a1fd02c-940a-4aee-b8b4-afb66370a70d__circular_menu_backdrop.png


Thanks,

Gábor Péterffy

___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124666: Added stacking to Marble Maps

2015-08-24 Thread Dennis Nienhüser 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124666/#review84298
---


I think we can push this one and continue working on it in master.

- Dennis Nienhüser


On Aug. 21, 2015, 8:47 a.m., Gábor Péterffy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124666/
> ---
> 
> (Updated Aug. 21, 2015, 8:47 a.m.)
> 
> 
> Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.
> 
> 
> Repository: marble
> 
> 
> Description
> ---
> 
> - Working back button
> - Reworked navigation setup
> 
> 
> Diffs
> -
> 
>   data/android/drawable-xxxhdpi/ic_place_via.png PRE-CREATION 
>   src/apps/marble-maps/CircularMenu.qml PRE-CREATION 
>   src/apps/marble-maps/MainScreen.qml cb88a0c 
>   src/apps/marble-maps/MarbleMaps.qrc 1cba58d 
>   src/apps/marble-maps/RoutePlanViewer.qml 4ca794e 
>   src/apps/marble-maps/RoutingManager.qml 6434bff 
>   src/apps/marble-maps/Search.qml 69ecc0a 
>   src/apps/marble-maps/Waypoint.qml PRE-CREATION 
>   src/apps/marble-maps/WaypointImage.qml 9b0aa01 
>   src/apps/marble-maps/WaypointOrderManager.qml c77a460 
>   src/lib/marble/declarative/Routing.h a1e93c5 
>   src/lib/marble/declarative/Routing.cpp 38e0d66 
>   data/android/drawable-xxxhdpi/ic_place_unknown.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/ic_place_departure.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/ic_place_arrival.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/circular_menu_backdrop.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/delete_white.png PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124666/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> delete_white.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png
> ic_place_via.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/52e58fcd-8c98-4a20-bc80-42f6e7f2fb20__ic_place_via.png
> ic_place_unknown.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/305b1f56-ccc5-46a7-8c07-883b51f18f64__ic_place_unknown.png
> ic_place_departure.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/9c01956d-6b25-42f8-96fb-e97e9fe15752__ic_place_departure.png
> ic_place_arrival.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/e19d6f8c-0c96-4b76-9b85-610891d3b41b__ic_place_arrival.png
> circular_menu_backdrop.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/2a1fd02c-940a-4aee-b8b4-afb66370a70d__circular_menu_backdrop.png
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124666: Added stacking to Marble Maps

2015-08-21 Thread Dennis Nienhüser 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124666/#review84155
---



src/apps/marble-maps/CircularMenu.qml (line 38)


what about calling `root.selected(type)` in each WaypointImage?



src/apps/marble-maps/MainScreen.qml (line 35)


startRoutingButton does not exist


- Dennis Nienhüser


On Aug. 21, 2015, 8:47 a.m., Gábor Péterffy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124666/
> ---
> 
> (Updated Aug. 21, 2015, 8:47 a.m.)
> 
> 
> Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.
> 
> 
> Repository: marble
> 
> 
> Description
> ---
> 
> - Working back button
> - Reworked navigation setup
> 
> 
> Diffs
> -
> 
>   data/android/drawable-xxxhdpi/ic_place_via.png PRE-CREATION 
>   src/apps/marble-maps/CircularMenu.qml PRE-CREATION 
>   src/apps/marble-maps/MainScreen.qml cb88a0c 
>   src/apps/marble-maps/MarbleMaps.qrc 1cba58d 
>   src/apps/marble-maps/RoutePlanViewer.qml 4ca794e 
>   src/apps/marble-maps/RoutingManager.qml 6434bff 
>   src/apps/marble-maps/Search.qml 69ecc0a 
>   src/apps/marble-maps/Waypoint.qml PRE-CREATION 
>   src/apps/marble-maps/WaypointImage.qml 9b0aa01 
>   src/apps/marble-maps/WaypointOrderManager.qml c77a460 
>   src/lib/marble/declarative/Routing.h a1e93c5 
>   src/lib/marble/declarative/Routing.cpp 38e0d66 
>   data/android/drawable-xxxhdpi/ic_place_unknown.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/ic_place_departure.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/ic_place_arrival.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/circular_menu_backdrop.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/delete_white.png PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124666/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> delete_white.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png
> ic_place_via.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/52e58fcd-8c98-4a20-bc80-42f6e7f2fb20__ic_place_via.png
> ic_place_unknown.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/305b1f56-ccc5-46a7-8c07-883b51f18f64__ic_place_unknown.png
> ic_place_departure.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/9c01956d-6b25-42f8-96fb-e97e9fe15752__ic_place_departure.png
> ic_place_arrival.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/e19d6f8c-0c96-4b76-9b85-610891d3b41b__ic_place_arrival.png
> circular_menu_backdrop.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/2a1fd02c-940a-4aee-b8b4-afb66370a70d__circular_menu_backdrop.png
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124666: Added stacking to Marble Maps

2015-08-21 Thread Gábor Péterffy 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124666/
---

(Updated Aug. 21, 2015, 10:47 a.m.)


Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.


Changes
---

Fixing crash.


Repository: marble


Description
---

- Working back button
- Reworked navigation setup


Diffs (updated)
-

  data/android/drawable-xxxhdpi/ic_place_via.png PRE-CREATION 
  src/apps/marble-maps/CircularMenu.qml PRE-CREATION 
  src/apps/marble-maps/MainScreen.qml cb88a0c 
  src/apps/marble-maps/MarbleMaps.qrc 1cba58d 
  src/apps/marble-maps/RoutePlanViewer.qml 4ca794e 
  src/apps/marble-maps/RoutingManager.qml 6434bff 
  src/apps/marble-maps/Search.qml 69ecc0a 
  src/apps/marble-maps/Waypoint.qml PRE-CREATION 
  src/apps/marble-maps/WaypointImage.qml 9b0aa01 
  src/apps/marble-maps/WaypointOrderManager.qml c77a460 
  src/lib/marble/declarative/Routing.h a1e93c5 
  src/lib/marble/declarative/Routing.cpp 38e0d66 
  data/android/drawable-xxxhdpi/ic_place_unknown.png PRE-CREATION 
  data/android/drawable-xxxhdpi/ic_place_departure.png PRE-CREATION 
  data/android/drawable-xxxhdpi/ic_place_arrival.png PRE-CREATION 
  data/android/drawable-xxxhdpi/circular_menu_backdrop.png PRE-CREATION 
  data/android/drawable-xxxhdpi/delete_white.png PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124666/diff/


Testing
---


File Attachments


delete_white.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png
ic_place_via.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/52e58fcd-8c98-4a20-bc80-42f6e7f2fb20__ic_place_via.png
ic_place_unknown.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/305b1f56-ccc5-46a7-8c07-883b51f18f64__ic_place_unknown.png
ic_place_departure.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/9c01956d-6b25-42f8-96fb-e97e9fe15752__ic_place_departure.png
ic_place_arrival.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/e19d6f8c-0c96-4b76-9b85-610891d3b41b__ic_place_arrival.png
circular_menu_backdrop.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/2a1fd02c-940a-4aee-b8b4-afb66370a70d__circular_menu_backdrop.png


Thanks,

Gábor Péterffy

___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124666: Added stacking to Marble Maps

2015-08-17 Thread Gábor Péterffy 


> On Aug. 16, 2015, 6:20 p.m., Dennis Nienhüser wrote:
> > I like the interaction with waypoints directly in the map. We need some 
> > bugfixes and tweaks still:
> > - when the search result is selected and appears on the map, its menu 
> > should be opened
> > - if you change existing waypoints from departure or destination to a via 
> > point, they are sometimes excluded from the route
> > - the waypoint icons in 'Modify Route' are sometimes incorrect
> > - if you change all waypoints to search results (why is that an option at 
> > all?), the app crashes

I think it is a cool thing that you can set everything into an undecided state 
and after it you can recreate the route as you want without the waypoint 
editor, so this is a more visual approach.

Can you give me some instructions how to reproduce the incorrect icon bug? I 
have no luck to produce it.


> On Aug. 16, 2015, 6:20 p.m., Dennis Nienhüser wrote:
> > src/apps/marble-maps/Waypoint.qml, line 65
> > 
> >
> > syntax error, isn't it?

You are right, but apparently it worked without an error message.


> On Aug. 16, 2015, 6:20 p.m., Dennis Nienhüser wrote:
> > src/lib/marble/declarative/Routing.h, line 107
> > 
> >
> > const QVariant &
> > 
> > In general, method parameters that are not going to be modified by the 
> > function are passed
> > - by value for simple pod types (bool, int, float, double, enums)
> > - by const reference for everything else, including smart pointers and 
> > data types with copy-on-write semantics

Thank you for the explanation.


> On Aug. 16, 2015, 6:20 p.m., Dennis Nienhüser wrote:
> > src/lib/marble/declarative/Routing.cpp, line 25
> > 
> >
> > seems unrelated to me?

It is used when we calculate the route from the current location.


> On Aug. 16, 2015, 6:20 p.m., Dennis Nienhüser wrote:
> > src/lib/marble/declarative/Routing.cpp, line 261
> > 
> >
> > The tight coupling between QML and C++ in Routing::prepareMenu and 
> > Routing::handleSelectedMenuOption is quite awkward. Can't we handle all 
> > that directly in QML?

We can, I have fixed this.


- Gábor


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124666/#review83886
---


On Aug. 18, 2015, 1:06 a.m., Gábor Péterffy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124666/
> ---
> 
> (Updated Aug. 18, 2015, 1:06 a.m.)
> 
> 
> Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.
> 
> 
> Repository: marble
> 
> 
> Description
> ---
> 
> - Working back button
> - Reworked navigation setup
> 
> 
> Diffs
> -
> 
>   data/android/drawable-xxxhdpi/circular_menu_backdrop.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/delete_white.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/ic_place_arrival.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/ic_place_departure.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/ic_place_unknown.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/ic_place_via.png PRE-CREATION 
>   src/apps/marble-maps/CircularMenu.qml PRE-CREATION 
>   src/apps/marble-maps/MainScreen.qml cb88a0c 
>   src/apps/marble-maps/MarbleMaps.qrc 1cba58d 
>   src/apps/marble-maps/RoutePlanViewer.qml 4ca794e 
>   src/apps/marble-maps/RoutingManager.qml 6434bff 
>   src/apps/marble-maps/Search.qml 69ecc0a 
>   src/apps/marble-maps/Waypoint.qml PRE-CREATION 
>   src/apps/marble-maps/WaypointImage.qml 9b0aa01 
>   src/apps/marble-maps/WaypointOrderManager.qml c77a460 
>   src/lib/marble/declarative/Routing.h a1e93c5 
>   src/lib/marble/declarative/Routing.cpp 38e0d66 
> 
> Diff: https://git.reviewboard.kde.org/r/124666/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> delete_white.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png
> ic_place_via.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/52e58fcd-8c98-4a20-bc80-42f6e7f2fb20__ic_place_via.png
> ic_place_unknown.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/305b1f56-ccc5-46a7-8c07-883b51f18f64__ic_place_unknown.png
> ic_place_departure.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/9c01956d-6b25-42f8-96fb-e97e9fe15752__ic_place_departure.png
> ic_place_arrival.png
>   
> https://git.reviewboard.kde.org/media/up

Re: [Marble-devel] Review Request 124666: Added stacking to Marble Maps

2015-08-17 Thread Gábor Péterffy 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124666/
---

(Updated Aug. 18, 2015, 1:06 a.m.)


Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.


Changes
---

Fixing issues. The crash still happens, so this is not a final version. I am 
still looking for the bug. It seems that one of the elements of 
d->m_searchResultItems becoming invalid because the app crashes when something 
uses it. (The indexes are okay.)


Repository: marble


Description
---

- Working back button
- Reworked navigation setup


Diffs (updated)
-

  data/android/drawable-xxxhdpi/circular_menu_backdrop.png PRE-CREATION 
  data/android/drawable-xxxhdpi/delete_white.png PRE-CREATION 
  data/android/drawable-xxxhdpi/ic_place_arrival.png PRE-CREATION 
  data/android/drawable-xxxhdpi/ic_place_departure.png PRE-CREATION 
  data/android/drawable-xxxhdpi/ic_place_unknown.png PRE-CREATION 
  data/android/drawable-xxxhdpi/ic_place_via.png PRE-CREATION 
  src/apps/marble-maps/CircularMenu.qml PRE-CREATION 
  src/apps/marble-maps/MainScreen.qml cb88a0c 
  src/apps/marble-maps/MarbleMaps.qrc 1cba58d 
  src/apps/marble-maps/RoutePlanViewer.qml 4ca794e 
  src/apps/marble-maps/RoutingManager.qml 6434bff 
  src/apps/marble-maps/Search.qml 69ecc0a 
  src/apps/marble-maps/Waypoint.qml PRE-CREATION 
  src/apps/marble-maps/WaypointImage.qml 9b0aa01 
  src/apps/marble-maps/WaypointOrderManager.qml c77a460 
  src/lib/marble/declarative/Routing.h a1e93c5 
  src/lib/marble/declarative/Routing.cpp 38e0d66 

Diff: https://git.reviewboard.kde.org/r/124666/diff/


Testing
---


File Attachments


delete_white.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png
ic_place_via.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/52e58fcd-8c98-4a20-bc80-42f6e7f2fb20__ic_place_via.png
ic_place_unknown.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/305b1f56-ccc5-46a7-8c07-883b51f18f64__ic_place_unknown.png
ic_place_departure.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/9c01956d-6b25-42f8-96fb-e97e9fe15752__ic_place_departure.png
ic_place_arrival.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/e19d6f8c-0c96-4b76-9b85-610891d3b41b__ic_place_arrival.png
circular_menu_backdrop.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/2a1fd02c-940a-4aee-b8b4-afb66370a70d__circular_menu_backdrop.png


Thanks,

Gábor Péterffy

___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124666: Added stacking to Marble Maps

2015-08-16 Thread Dennis Nienhüser 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124666/#review83886
---


I like the interaction with waypoints directly in the map. We need some 
bugfixes and tweaks still:
- when the search result is selected and appears on the map, its menu should be 
opened
- if you change existing waypoints from departure or destination to a via 
point, they are sometimes excluded from the route
- the waypoint icons in 'Modify Route' are sometimes incorrect
- if you change all waypoints to search results (why is that an option at 
all?), the app crashes


src/apps/marble-maps/Waypoint.qml (line 52)


We already know the geo position. This property recalculates it on every 
map pan and similar. Let's avoid that.



src/apps/marble-maps/Waypoint.qml (line 65)


syntax error, isn't it?



src/lib/marble/declarative/Routing.h (line 105)


this one and also updateWaypointItems above and prepareMenu and 
handleSelectedMenuOption below should be private.



src/lib/marble/declarative/Routing.h (line 107)


const QVariant &

In general, method parameters that are not going to be modified by the 
function are passed
- by value for simple pod types (bool, int, float, double, enums)
- by const reference for everything else, including smart pointers and data 
types with copy-on-write semantics



src/lib/marble/declarative/Routing.h (line 109)


const QVariant &



src/lib/marble/declarative/Routing.cpp (line 25)


seems unrelated to me?



src/lib/marble/declarative/Routing.cpp (line 157)


shouldn't this be `i` instead of `d->m_routeRequestModel->rowCount()-1`?



src/lib/marble/declarative/Routing.cpp (line 222)


how is that different from the context property above? And could the 
context property visible above be set on the item instead to set its visibility?



src/lib/marble/declarative/Routing.cpp (line 260)


The tight coupling between QML and C++ in Routing::prepareMenu and 
Routing::handleSelectedMenuOption is quite awkward. Can't we handle all that 
directly in QML?


- Dennis Nienhüser


On Aug. 16, 2015, 2:12 p.m., Gábor Péterffy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124666/
> ---
> 
> (Updated Aug. 16, 2015, 2:12 p.m.)
> 
> 
> Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.
> 
> 
> Repository: marble
> 
> 
> Description
> ---
> 
> - Working back button
> - Reworked navigation setup
> 
> 
> Diffs
> -
> 
>   data/android/drawable-xxxhdpi/circular_menu_backdrop.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/delete_white.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/ic_place_arrival.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/ic_place_departure.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/ic_place_unknown.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/ic_place_via.png PRE-CREATION 
>   src/apps/marble-maps/CircularMenu.qml PRE-CREATION 
>   src/apps/marble-maps/MainScreen.qml cb88a0c 
>   src/apps/marble-maps/MarbleMaps.qrc 1cba58d 
>   src/apps/marble-maps/RoutePlanViewer.qml 4ca794e 
>   src/apps/marble-maps/RoutingManager.qml 6434bff 
>   src/apps/marble-maps/Search.qml 69ecc0a 
>   src/apps/marble-maps/Waypoint.qml PRE-CREATION 
>   src/apps/marble-maps/WaypointImage.qml 9b0aa01 
>   src/apps/marble-maps/WaypointOrderManager.qml c77a460 
>   src/lib/marble/declarative/Routing.h a1e93c5 
>   src/lib/marble/declarative/Routing.cpp 38e0d66 
> 
> Diff: https://git.reviewboard.kde.org/r/124666/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> delete_white.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png
> ic_place_via.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/52e58fcd-8c98-4a20-bc80-42f6e7f2fb20__ic_place_via.png
> ic_place_unknown.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/305b1f56-ccc5-46a7-8c07-883b51f18f64__ic_place_unknown.png
> ic_place_departure.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/9c01956d-6b25-42f8-96fb-e97e9fe15752__ic_place_departure.png
> ic_place_arri

Re: [Marble-devel] Review Request 124666: Added stacking to Marble Maps

2015-08-16 Thread Gábor Péterffy 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124666/
---

(Updated Aug. 16, 2015, 4:12 p.m.)


Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.


Changes
---

Fixing issues and uploading Torsten's artwork for waypoints.


Repository: marble


Description
---

- Working back button
- Reworked navigation setup


Diffs (updated)
-

  data/android/drawable-xxxhdpi/circular_menu_backdrop.png PRE-CREATION 
  data/android/drawable-xxxhdpi/delete_white.png PRE-CREATION 
  data/android/drawable-xxxhdpi/ic_place_arrival.png PRE-CREATION 
  data/android/drawable-xxxhdpi/ic_place_departure.png PRE-CREATION 
  data/android/drawable-xxxhdpi/ic_place_unknown.png PRE-CREATION 
  data/android/drawable-xxxhdpi/ic_place_via.png PRE-CREATION 
  src/apps/marble-maps/CircularMenu.qml PRE-CREATION 
  src/apps/marble-maps/MainScreen.qml cb88a0c 
  src/apps/marble-maps/MarbleMaps.qrc 1cba58d 
  src/apps/marble-maps/RoutePlanViewer.qml 4ca794e 
  src/apps/marble-maps/RoutingManager.qml 6434bff 
  src/apps/marble-maps/Search.qml 69ecc0a 
  src/apps/marble-maps/Waypoint.qml PRE-CREATION 
  src/apps/marble-maps/WaypointImage.qml 9b0aa01 
  src/apps/marble-maps/WaypointOrderManager.qml c77a460 
  src/lib/marble/declarative/Routing.h a1e93c5 
  src/lib/marble/declarative/Routing.cpp 38e0d66 

Diff: https://git.reviewboard.kde.org/r/124666/diff/


Testing
---


File Attachments (updated)


delete_white.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png
ic_place_via.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/52e58fcd-8c98-4a20-bc80-42f6e7f2fb20__ic_place_via.png
ic_place_unknown.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/305b1f56-ccc5-46a7-8c07-883b51f18f64__ic_place_unknown.png
ic_place_departure.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/9c01956d-6b25-42f8-96fb-e97e9fe15752__ic_place_departure.png
ic_place_arrival.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/e19d6f8c-0c96-4b76-9b85-610891d3b41b__ic_place_arrival.png
circular_menu_backdrop.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/2a1fd02c-940a-4aee-b8b4-afb66370a70d__circular_menu_backdrop.png


Thanks,

Gábor Péterffy

___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124666: Added stacking to Marble Maps

2015-08-15 Thread Torsten Rahn 
Sure - I have some ideas already :-)

Von meinem iPhone 5s gesendet

> Am 15.08.2015 um 16:36 schrieb Dennis Nienhüser :
> 
> Hi Torsten,
> 
> waypoints that indicate their type by a different icon variant each sound 
> like a good idea. Can you do a mockup for that, maybe even using an 
> appropriate color palette?
> 
> Regards,
> Dennis
> 
> Am 15.08.2015 15:53, schrieb Torsten Rahn:
>> Sorry, these toy-colored balloons looks just like awful geeky stuff -
>> and not professional at all. If we'd go with this approach we need
>> 1. balloons with departure/arrival-type indicator icons integrated
>> into the balloons
>> 2. better colors which aren't aggressively spectral.
>> (I would go with different shades of the same kind of blue)
>> 3. supporting departure/arrival text
>> Von meinem iPhone 5s gesendet
>> Am 15.08.2015 um 13:41 schrieb Dennis Nienhüser
>> :
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://git.reviewboard.kde.org/r/124666/ [1]
>>> On August 10th, 2015, 6:17 p.m. UTC, DENNIS NIENHÜSER wrote:
>>> Yes, I like the idea of having interactive waypoint items.
>>> Design-wise I wonder if we get the message across by just using
>>> different colors for markers. Also the circular popup menu looks
>>> stylish, but might be annoying to extend/change (think of including
>>> the placemark's name, its distance or address in there). Code-wise
>>> it should be easier not to do the menu in C++, but in QML as a child
>>> item of the existing waypoint delegate (WaypointImage).
>>> On August 15th, 2015, 10:05 a.m. UTC, GÁBOR PÉTERFFY wrote:
>>> Can you explain why would you get through the message with the
>>> colors? I think it is much more readable if we see the purpose.
>> My concern is that it is not immediately clear to a new user of the
>> application that the start of the route is green, a waypoint orange,
>> the destination red and a waypoint not yet part of the route blue.
>> - Dennis
>> On August 15th, 2015, 10:06 a.m. UTC, Gábor Péterffy wrote:
>> Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.
>> By Gábor Péterffy.
>> _Updated Aug. 15, 2015, 10:06 a.m._
>> REPOSITORY: marble
>> DESCRIPTION
>>* Working back button
>>* Reworked navigation setup
>> DIFFS
>>* src/lib/marble/declarative/Routing.cpp (38e0d66)
>>* src/lib/marble/declarative/Routing.h (a1e93c5)
>>* src/apps/marble-maps/WaypointImage.qml (9b0aa01)
>>* data/android/drawable-xxxhdpi/circular_menu_backdrop.png
>> (PRE-CREATION)
>>* data/android/drawable-xxxhdpi/delete_white.png (PRE-CREATION)
>>* data/android/drawable-xxxhdpi/place_blue.png (PRE-CREATION)
>>* src/apps/marble-maps/CircularMenu.qml (PRE-CREATION)
>>* src/apps/marble-maps/MainScreen.qml (cb88a0c)
>>* src/apps/marble-maps/MarbleMaps.qrc (1cba58d)
>>* src/apps/marble-maps/NavigationSetup.qml (e552efe)
>>* src/apps/marble-maps/ProfileSelectorMenu.qml (fc80991)
>>* src/apps/marble-maps/RoutePlanViewer.qml (4ca794e)
>>* src/apps/marble-maps/RoutingManager.qml (6434bff)
>>* src/apps/marble-maps/Search.qml (69ecc0a)
>>* src/apps/marble-maps/Waypoint.qml (PRE-CREATION)
>> View Diff [3]
>> FILE ATTACHMENTS
>>* circular_menu_backdrop.png [4]
>>* place_blue.png [5]
>>* delete_white.png [6]
>>* Screenshot [7]
>>> ___
>>> Marble-devel mailing list
>>> Marble-devel@kde.org
>>> https://mail.kde.org/mailman/listinfo/marble-devel [2]
>> Links:
>> --
>> [1] https://git.reviewboard.kde.org/r/124666/
>> [2] https://mail.kde.org/mailman/listinfo/marble-devel
>> [3] https://git.reviewboard.kde.org/r/124666/diff/
>> [4]
>> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/090dd9dc-3208-4df3-95fd-9d3b59d3ecd0__circular_menu_backdrop.png
>> [5]
>> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/eb461d5e-79c7-410d-8fb6-c99ecc10180d__place_blue.png
>> [6]
>> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png
>> [7]
>> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/68490e9b-18d6-465a-8f51-ce95ca571608__Screenshot_2015-08-10-13-20-49.png
> ___
> Marble-devel mailing list
> Marble-devel@kde.org
> https://mail.kde.org/mailman/listinfo/marble-devel
___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124666: Added stacking to Marble Maps

2015-08-15 Thread Dennis Nienhüser 

Hi Torsten,

waypoints that indicate their type by a different icon variant each 
sound like a good idea. Can you do a mockup for that, maybe even using 
an appropriate color palette?


Regards,
Dennis

Am 15.08.2015 15:53, schrieb Torsten Rahn:

Sorry, these toy-colored balloons looks just like awful geeky stuff -
and not professional at all. If we'd go with this approach we need
1. balloons with departure/arrival-type indicator icons integrated
into the balloons
2. better colors which aren't aggressively spectral.
(I would go with different shades of the same kind of blue)
3. supporting departure/arrival text

Von meinem iPhone 5s gesendet

Am 15.08.2015 um 13:41 schrieb Dennis Nienhüser
:


This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124666/ [1]

On August 10th, 2015, 6:17 p.m. UTC, DENNIS NIENHÜSER wrote:

Yes, I like the idea of having interactive waypoint items.
Design-wise I wonder if we get the message across by just using
different colors for markers. Also the circular popup menu looks
stylish, but might be annoying to extend/change (think of including
the placemark's name, its distance or address in there). Code-wise
it should be easier not to do the menu in C++, but in QML as a child
item of the existing waypoint delegate (WaypointImage).

On August 15th, 2015, 10:05 a.m. UTC, GÁBOR PÉTERFFY wrote:

Can you explain why would you get through the message with the
colors? I think it is much more readable if we see the purpose.


My concern is that it is not immediately clear to a new user of the
application that the start of the route is green, a waypoint orange,
the destination red and a waypoint not yet part of the route blue.

- Dennis

On August 15th, 2015, 10:06 a.m. UTC, Gábor Péterffy wrote:

Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.
By Gábor Péterffy.

_Updated Aug. 15, 2015, 10:06 a.m._
 REPOSITORY: marble

DESCRIPTION

* Working back button

* Reworked navigation setup

DIFFS

* src/lib/marble/declarative/Routing.cpp (38e0d66)
* src/lib/marble/declarative/Routing.h (a1e93c5)
* src/apps/marble-maps/WaypointImage.qml (9b0aa01)
* data/android/drawable-xxxhdpi/circular_menu_backdrop.png
(PRE-CREATION)
* data/android/drawable-xxxhdpi/delete_white.png (PRE-CREATION)
* data/android/drawable-xxxhdpi/place_blue.png (PRE-CREATION)
* src/apps/marble-maps/CircularMenu.qml (PRE-CREATION)
* src/apps/marble-maps/MainScreen.qml (cb88a0c)
* src/apps/marble-maps/MarbleMaps.qrc (1cba58d)
* src/apps/marble-maps/NavigationSetup.qml (e552efe)
* src/apps/marble-maps/ProfileSelectorMenu.qml (fc80991)
* src/apps/marble-maps/RoutePlanViewer.qml (4ca794e)
* src/apps/marble-maps/RoutingManager.qml (6434bff)
* src/apps/marble-maps/Search.qml (69ecc0a)
* src/apps/marble-maps/Waypoint.qml (PRE-CREATION)

View Diff [3]

FILE ATTACHMENTS

* circular_menu_backdrop.png [4]
* place_blue.png [5]
* delete_white.png [6]
* Screenshot [7]


___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel [2]



Links:
--
[1] https://git.reviewboard.kde.org/r/124666/
[2] https://mail.kde.org/mailman/listinfo/marble-devel
[3] https://git.reviewboard.kde.org/r/124666/diff/
[4]
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/090dd9dc-3208-4df3-95fd-9d3b59d3ecd0__circular_menu_backdrop.png
[5]
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/eb461d5e-79c7-410d-8fb6-c99ecc10180d__place_blue.png
[6]
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png
[7]
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/68490e9b-18d6-465a-8f51-ce95ca571608__Screenshot_2015-08-10-13-20-49.png

___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124666: Added stacking to Marble Maps

2015-08-15 Thread Torsten Rahn 
Sorry, these toy-colored balloons looks just like awful geeky stuff - and not 
professional at all. If we'd go with this approach we need 
1. balloons with departure/arrival-type indicator icons integrated into the 
balloons
2. better colors which aren't aggressively spectral.
(I would go with different shades of the same kind of blue)
3. supporting departure/arrival text 




Von meinem iPhone 5s gesendet

> Am 15.08.2015 um 13:41 schrieb Dennis Nienhüser :
> 
> 
> This is an automatically generated e-mail. To reply, visit: 
> https://git.reviewboard.kde.org/r/124666/
> 
> On August 10th, 2015, 6:17 p.m. UTC, Dennis Nienhüser wrote:
> 
> Yes, I like the idea of having interactive waypoint items. Design-wise I 
> wonder if we get the message across by just using different colors for 
> markers. Also the circular popup menu looks stylish, but might be annoying to 
> extend/change (think of including the placemark's name, its distance or 
> address in there). Code-wise it should be easier not to do the menu in C++, 
> but in QML as a child item of the existing waypoint delegate (WaypointImage).
> On August 15th, 2015, 10:05 a.m. UTC, Gábor Péterffy wrote:
> 
> Can you explain why would you get through the message with the colors? I 
> think it is much more readable if we see the purpose.
> My concern is that it is not immediately clear to a new user of the 
> application that the start of the route is green, a waypoint orange, the 
> destination red and a waypoint not yet part of the route blue.
> 
> - Dennis
> 
> 
> On August 15th, 2015, 10:06 a.m. UTC, Gábor Péterffy wrote:
> 
> Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.
> By Gábor Péterffy.
> Updated Aug. 15, 2015, 10:06 a.m.
> 
> Repository: marble
> Description
> 
> Working back button
> Reworked navigation setup
> Diffs
> 
> src/lib/marble/declarative/Routing.cpp (38e0d66)
> src/lib/marble/declarative/Routing.h (a1e93c5)
> src/apps/marble-maps/WaypointImage.qml (9b0aa01)
> data/android/drawable-xxxhdpi/circular_menu_backdrop.png (PRE-CREATION)
> data/android/drawable-xxxhdpi/delete_white.png (PRE-CREATION)
> data/android/drawable-xxxhdpi/place_blue.png (PRE-CREATION)
> src/apps/marble-maps/CircularMenu.qml (PRE-CREATION)
> src/apps/marble-maps/MainScreen.qml (cb88a0c)
> src/apps/marble-maps/MarbleMaps.qrc (1cba58d)
> src/apps/marble-maps/NavigationSetup.qml (e552efe)
> src/apps/marble-maps/ProfileSelectorMenu.qml (fc80991)
> src/apps/marble-maps/RoutePlanViewer.qml (4ca794e)
> src/apps/marble-maps/RoutingManager.qml (6434bff)
> src/apps/marble-maps/Search.qml (69ecc0a)
> src/apps/marble-maps/Waypoint.qml (PRE-CREATION)
> View Diff
> 
> File Attachments
> 
> circular_menu_backdrop.png
> place_blue.png
> delete_white.png
> Screenshot
> ___
> Marble-devel mailing list
> Marble-devel@kde.org
> https://mail.kde.org/mailman/listinfo/marble-devel
___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124666: Added stacking to Marble Maps

2015-08-15 Thread Dennis Nienhüser 


> On Aug. 10, 2015, 6:17 p.m., Dennis Nienhüser wrote:
> > Yes, I like the idea of having interactive waypoint items. Design-wise I 
> > wonder if we get the message across by just using different colors for 
> > markers. Also the circular popup menu looks stylish, but might be annoying 
> > to extend/change (think of including the placemark's name, its distance or 
> > address in there). Code-wise it should be easier not to do the menu in C++, 
> > but in QML as a child item of the existing waypoint delegate 
> > (WaypointImage).
> 
> Gábor Péterffy wrote:
> Can you explain why would you get through the message with the colors? I 
> think it is much more readable if we see the purpose.

My concern is that it is not immediately clear to a new user of the application 
that the start of the route is green, a waypoint orange, the destination red 
and a waypoint not yet part of the route blue.


- Dennis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124666/#review83665
---


On Aug. 15, 2015, 10:06 a.m., Gábor Péterffy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124666/
> ---
> 
> (Updated Aug. 15, 2015, 10:06 a.m.)
> 
> 
> Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.
> 
> 
> Repository: marble
> 
> 
> Description
> ---
> 
> - Working back button
> - Reworked navigation setup
> 
> 
> Diffs
> -
> 
>   src/lib/marble/declarative/Routing.cpp 38e0d66 
>   src/lib/marble/declarative/Routing.h a1e93c5 
>   src/apps/marble-maps/WaypointImage.qml 9b0aa01 
>   data/android/drawable-xxxhdpi/circular_menu_backdrop.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/delete_white.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/place_blue.png PRE-CREATION 
>   src/apps/marble-maps/CircularMenu.qml PRE-CREATION 
>   src/apps/marble-maps/MainScreen.qml cb88a0c 
>   src/apps/marble-maps/MarbleMaps.qrc 1cba58d 
>   src/apps/marble-maps/NavigationSetup.qml e552efe 
>   src/apps/marble-maps/ProfileSelectorMenu.qml fc80991 
>   src/apps/marble-maps/RoutePlanViewer.qml 4ca794e 
>   src/apps/marble-maps/RoutingManager.qml 6434bff 
>   src/apps/marble-maps/Search.qml 69ecc0a 
>   src/apps/marble-maps/Waypoint.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124666/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> circular_menu_backdrop.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/090dd9dc-3208-4df3-95fd-9d3b59d3ecd0__circular_menu_backdrop.png
> place_blue.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/eb461d5e-79c7-410d-8fb6-c99ecc10180d__place_blue.png
> delete_white.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/68490e9b-18d6-465a-8f51-ce95ca571608__Screenshot_2015-08-10-13-20-49.png
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124666: Added stacking to Marble Maps

2015-08-15 Thread Gábor Péterffy 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124666/
---

(Updated Aug. 15, 2015, 12:06 p.m.)


Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.


Changes
---

Added missing file


Repository: marble


Description
---

- Working back button
- Reworked navigation setup


Diffs (updated)
-

  src/lib/marble/declarative/Routing.cpp 38e0d66 
  src/lib/marble/declarative/Routing.h a1e93c5 
  src/apps/marble-maps/WaypointImage.qml 9b0aa01 
  data/android/drawable-xxxhdpi/circular_menu_backdrop.png PRE-CREATION 
  data/android/drawable-xxxhdpi/delete_white.png PRE-CREATION 
  data/android/drawable-xxxhdpi/place_blue.png PRE-CREATION 
  src/apps/marble-maps/CircularMenu.qml PRE-CREATION 
  src/apps/marble-maps/MainScreen.qml cb88a0c 
  src/apps/marble-maps/MarbleMaps.qrc 1cba58d 
  src/apps/marble-maps/NavigationSetup.qml e552efe 
  src/apps/marble-maps/ProfileSelectorMenu.qml fc80991 
  src/apps/marble-maps/RoutePlanViewer.qml 4ca794e 
  src/apps/marble-maps/RoutingManager.qml 6434bff 
  src/apps/marble-maps/Search.qml 69ecc0a 
  src/apps/marble-maps/Waypoint.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124666/diff/


Testing
---


File Attachments


circular_menu_backdrop.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/090dd9dc-3208-4df3-95fd-9d3b59d3ecd0__circular_menu_backdrop.png
place_blue.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/eb461d5e-79c7-410d-8fb6-c99ecc10180d__place_blue.png
delete_white.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png
Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/68490e9b-18d6-465a-8f51-ce95ca571608__Screenshot_2015-08-10-13-20-49.png


Thanks,

Gábor Péterffy

___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124666: Added stacking to Marble Maps

2015-08-15 Thread Gábor Péterffy 


> On Aug. 10, 2015, 8:17 p.m., Dennis Nienhüser wrote:
> > Yes, I like the idea of having interactive waypoint items. Design-wise I 
> > wonder if we get the message across by just using different colors for 
> > markers. Also the circular popup menu looks stylish, but might be annoying 
> > to extend/change (think of including the placemark's name, its distance or 
> > address in there). Code-wise it should be easier not to do the menu in C++, 
> > but in QML as a child item of the existing waypoint delegate 
> > (WaypointImage).

Can you explain why would you get through the message with the colors? I think 
it is much more readable if we see the purpose.


- Gábor


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124666/#review83665
---


On Aug. 15, 2015, 12:03 p.m., Gábor Péterffy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124666/
> ---
> 
> (Updated Aug. 15, 2015, 12:03 p.m.)
> 
> 
> Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.
> 
> 
> Repository: marble
> 
> 
> Description
> ---
> 
> - Working back button
> - Reworked navigation setup
> 
> 
> Diffs
> -
> 
>   data/android/drawable-xxxhdpi/circular_menu_backdrop.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/delete_white.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/place_blue.png PRE-CREATION 
>   src/apps/marble-maps/CircularMenu.qml PRE-CREATION 
>   src/apps/marble-maps/MainScreen.qml cb88a0c 
>   src/apps/marble-maps/MarbleMaps.qrc 1cba58d 
>   src/apps/marble-maps/NavigationSetup.qml e552efe 
>   src/apps/marble-maps/ProfileSelectorMenu.qml fc80991 
>   src/apps/marble-maps/RoutePlanViewer.qml 4ca794e 
>   src/apps/marble-maps/RoutingManager.qml 6434bff 
>   src/apps/marble-maps/Search.qml 69ecc0a 
>   src/apps/marble-maps/WaypointImage.qml 9b0aa01 
>   src/lib/marble/declarative/Routing.h a1e93c5 
>   src/lib/marble/declarative/Routing.cpp 38e0d66 
> 
> Diff: https://git.reviewboard.kde.org/r/124666/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> circular_menu_backdrop.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/090dd9dc-3208-4df3-95fd-9d3b59d3ecd0__circular_menu_backdrop.png
> place_blue.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/eb461d5e-79c7-410d-8fb6-c99ecc10180d__place_blue.png
> delete_white.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/68490e9b-18d6-465a-8f51-ce95ca571608__Screenshot_2015-08-10-13-20-49.png
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124666: Added stacking to Marble Maps

2015-08-15 Thread Gábor Péterffy 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124666/
---

(Updated Aug. 15, 2015, 12:03 p.m.)


Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.


Changes
---

Fixing issues


Repository: marble


Description
---

- Working back button
- Reworked navigation setup


Diffs (updated)
-

  data/android/drawable-xxxhdpi/circular_menu_backdrop.png PRE-CREATION 
  data/android/drawable-xxxhdpi/delete_white.png PRE-CREATION 
  data/android/drawable-xxxhdpi/place_blue.png PRE-CREATION 
  src/apps/marble-maps/CircularMenu.qml PRE-CREATION 
  src/apps/marble-maps/MainScreen.qml cb88a0c 
  src/apps/marble-maps/MarbleMaps.qrc 1cba58d 
  src/apps/marble-maps/NavigationSetup.qml e552efe 
  src/apps/marble-maps/ProfileSelectorMenu.qml fc80991 
  src/apps/marble-maps/RoutePlanViewer.qml 4ca794e 
  src/apps/marble-maps/RoutingManager.qml 6434bff 
  src/apps/marble-maps/Search.qml 69ecc0a 
  src/apps/marble-maps/WaypointImage.qml 9b0aa01 
  src/lib/marble/declarative/Routing.h a1e93c5 
  src/lib/marble/declarative/Routing.cpp 38e0d66 

Diff: https://git.reviewboard.kde.org/r/124666/diff/


Testing
---


File Attachments


circular_menu_backdrop.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/090dd9dc-3208-4df3-95fd-9d3b59d3ecd0__circular_menu_backdrop.png
place_blue.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/eb461d5e-79c7-410d-8fb6-c99ecc10180d__place_blue.png
delete_white.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png
Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/68490e9b-18d6-465a-8f51-ce95ca571608__Screenshot_2015-08-10-13-20-49.png


Thanks,

Gábor Péterffy

___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124666: Added stacking to Marble Maps

2015-08-10 Thread Dennis Nienhüser 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124666/#review83665
---


Yes, I like the idea of having interactive waypoint items. Design-wise I wonder 
if we get the message across by just using different colors for markers. Also 
the circular popup menu looks stylish, but might be annoying to extend/change 
(think of including the placemark's name, its distance or address in there). 
Code-wise it should be easier not to do the menu in C++, but in QML as a child 
item of the existing waypoint delegate (WaypointImage).


src/lib/marble/declarative/Routing.cpp (line 33)


typo, missing a 't'


- Dennis Nienhüser


On Aug. 10, 2015, 11:37 a.m., Gábor Péterffy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124666/
> ---
> 
> (Updated Aug. 10, 2015, 11:37 a.m.)
> 
> 
> Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.
> 
> 
> Repository: marble
> 
> 
> Description
> ---
> 
> - Working back button
> - Reworked navigation setup
> 
> 
> Diffs
> -
> 
>   data/android/drawable-xxxhdpi/circular_menu_backdrop.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/delete_white.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/place_blue.png PRE-CREATION 
>   src/apps/marble-maps/CircularMenu.qml PRE-CREATION 
>   src/apps/marble-maps/MainScreen.qml fafd183 
>   src/apps/marble-maps/MarbleMaps.qrc 713e414 
>   src/apps/marble-maps/NavigationSetup.qml eb7c1dd 
>   src/apps/marble-maps/RoutePlanViewer.qml 28b4c34 
>   src/apps/marble-maps/RoutingManager.qml PRE-CREATION 
>   src/apps/marble-maps/Search.qml 14088b8 
>   src/apps/marble-maps/WaypointImage.qml PRE-CREATION 
>   src/lib/marble/declarative/Routing.h 51a1be7 
>   src/lib/marble/declarative/Routing.cpp 7a0d8aa 
> 
> Diff: https://git.reviewboard.kde.org/r/124666/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> circular_menu_backdrop.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/090dd9dc-3208-4df3-95fd-9d3b59d3ecd0__circular_menu_backdrop.png
> place_blue.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/eb461d5e-79c7-410d-8fb6-c99ecc10180d__place_blue.png
> delete_white.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/68490e9b-18d6-465a-8f51-ce95ca571608__Screenshot_2015-08-10-13-20-49.png
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124666: Added stacking to Marble Maps

2015-08-10 Thread Gábor Péterffy 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124666/
---

(Updated Aug. 10, 2015, 1:37 p.m.)


Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.


Changes
---

I have removed the NavigationMenu, and I have introduced a new way to set up a 
route. When you select a search result it will appear on the map. When you 
touch it, a menu will pop up where you can select how do you want to use it. 
With this, I not feel necessary to merge the profile selector into the 
WaypointOrderEditor. What do you think about it? Also do you like this approach 
instead the previous one?


Repository: marble


Description (updated)
---

- Working back button
- Reworked navigation setup


Diffs (updated)
-

  data/android/drawable-xxxhdpi/circular_menu_backdrop.png PRE-CREATION 
  data/android/drawable-xxxhdpi/delete_white.png PRE-CREATION 
  data/android/drawable-xxxhdpi/place_blue.png PRE-CREATION 
  src/apps/marble-maps/CircularMenu.qml PRE-CREATION 
  src/apps/marble-maps/MainScreen.qml fafd183 
  src/apps/marble-maps/MarbleMaps.qrc 713e414 
  src/apps/marble-maps/NavigationSetup.qml eb7c1dd 
  src/apps/marble-maps/RoutePlanViewer.qml 28b4c34 
  src/apps/marble-maps/RoutingManager.qml PRE-CREATION 
  src/apps/marble-maps/Search.qml 14088b8 
  src/apps/marble-maps/WaypointImage.qml PRE-CREATION 
  src/lib/marble/declarative/Routing.h 51a1be7 
  src/lib/marble/declarative/Routing.cpp 7a0d8aa 

Diff: https://git.reviewboard.kde.org/r/124666/diff/


Testing
---


File Attachments (updated)


circular_menu_backdrop.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/090dd9dc-3208-4df3-95fd-9d3b59d3ecd0__circular_menu_backdrop.png
place_blue.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/eb461d5e-79c7-410d-8fb6-c99ecc10180d__place_blue.png
delete_white.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png
Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/68490e9b-18d6-465a-8f51-ce95ca571608__Screenshot_2015-08-10-13-20-49.png


Thanks,

Gábor Péterffy

___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel

Re: [Marble-devel] Review Request 124666: Added stacking to Marble Maps

2015-08-09 Thread Dennis Nienhüser 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124666/#review83596
---


I agree that we need this kind of stacked user interaction and react in a 
sensible way to the back button. We need to be careful though which things are 
a "stack element" and which not. Generally it's better to avoid full-screen 
elements and deep stacking. In particular I perceive dialog-like elements not 
as stack elements. Therefore I wouldn't put the search field into the stack. 
Instead I'd really remove its toggle possibility at all and just show it always 
on top of the map. The search result list in turn (which is shown full-screen) 
might be a stack element though that gets popped upon pressing the back button, 
returning you to the map.

For the route related elements I agree with the stacking behavior when using 
https://git.reviewboard.kde.org/r/124627/ as a base. I'm also fine with getting 
this ready for pushing to master this way. Allow me to bring up a comment from 
RR 124627 again though: "I wonder if we can reduce things also by merging the 
route editor and the profile selection buttons into one dialog that is not 
shown full-screen, but only on the lower ~half of the screen. It could be 
triggered by a button similar to the current profile selection button. This 
dialog could also hold the "delete route" button and similar actions." Using 
the main application menu for routing related actions is not very convenient in 
my opinion. From a user's point of view I'd prefer to have elements/actions 
from the same context close together. I also wonder whether having the list of 
directions as a fullscreen-element is a useful thing at all. It might be better 
to reduce them to a small element that is shown in turn-by-turn nav
 igation mode only and allows to jump forward and backward as some kind of 
route-preview (e.g. the current instruction is shown, and some forward and 
backward button allow jumping to the next and previous instruction on the way).

For the implementation I'd prefer using the QML StackView 
http://doc.qt.io/qt-5/qml-qtquick-controls-stackview.html instead of providing 
our own implementation. I'll attach a patch below. The interesting parts of the 
patch are:
- removes search field toggle possibility as discussed above
- replaces custom ItemStack with QtQuick Controls StackView
  - changes its transition to keep items below visible. This is needed for the 
dialog-like navigationSettings (buttons to set search results as departure, 
waypoint or destination)
  - removes anchors from stack elements as StackView wants to maintain them on 
its own

```
diff --git a/src/apps/marble-maps/MainScreen.qml 
b/src/apps/marble-maps/MainScreen.qml
index d54b94e..c06ba33 100644
--- a/src/apps/marble-maps/MainScreen.qml
+++ b/src/apps/marble-maps/MainScreen.qml
@@ -26,26 +26,12 @@ ApplicationWindow {
 id: menuBar
 Menu {
 title: qsTr("Marble Maps")
-MenuItem{
-text: qsTr("Search")
-onTriggered: {
-if (itemStack.isOnTop(search)) {
-itemStack.removeObject(search);
-}
-else {
-itemStack.addObject(search);
-itemStack.removeObject(instructions);
-itemStack.removeObject(waypointOrderEditor)
-}
-}
-}
 
 MenuItem {
 text: qsTr("Delete Route")
 onTriggered: {
 routing.clearRoute();
-itemStack.removeObject(instructions);
-itemStack.removeObject(waypointOrderEditor);
+itemStack.pop(mapItem)
 startRoutingButton.show = false;
 }
 visible: routing.hasRoute
@@ -54,8 +40,8 @@ ApplicationWindow {
 MenuItem {
 text: qsTr("Modify Route")
 onTriggered: {
-if (!itemStack.isOnTop(waypointOrderEditor)) {
-itemStack.addObject(waypointOrderEditor);
+if (itemStack.currentItem !== waypointOrderEditor) {
+itemStack.push(waypointOrderEditor);
 }
 }
 visible: routing.hasRoute
@@ -64,8 +50,8 @@ ApplicationWindow {
 MenuItem {
 text: qsTr("Navigation Instructions")
 onTriggered: {
-if (!itemStack.isOnTop(instructions)) {
-itemStack.addObject(instructions)
+if (itemStack.currentItem !== instructions) {
+itemStack.push(instructions)
 }
 }
 visible: routing.hasRoute && !instructions.