Re: Patch for 3 virtual file systems
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jacques Pelletier wrote: I submitted a patch last year for supporting 3 files systems. Since there is some activity now and possibly a release soon, should I resubmit my patch? Or any other procedure? Yes, please. Add your patch in trac, if this not dificult for you... WBR, Slavaz. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.7 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org iD8DBQFJZcTPb3oGR6aVLpoRArfnAJ0c1QkLz5q2XyKIxHT8FBjQWNnF0gCfcxl1 cBmlZevKlLzJxl9IOZbtEk4= =Y8AT -END PGP SIGNATURE- ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #143: Updated sh syntax file
#143: Updated sh syntax file ---+ Reporter: Patrick Winnertz win...@debian.org | Owner: winnie Type: enhancement | Status: accepted Priority: major | Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution:|Keywords: Blocking:| Blockedby: ---+ Comment(by Enrico Weigelt): * Ticket System tick...@midnight-commander.org schrieb: There's a similar change in the rhclub-fans tree, but I didn't check if that one was commited yet. cu -- Ticket URL: www.midnight-commander.org/ticket/143#comment: Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #135: [PATCH] Drop bundled libintl
#135: [PATCH] Drop bundled libintl
--+-
Reporter: metux| Owner: metux
Type: enhancement | Status: accepted
Priority: minor| Milestone: 4.6.2
Component: mc-core | Version: 4.6.1
Resolution: |Keywords:
Blocking: | Blockedby:
--+-
Comment(by slavazanko):
it's reverted patch. I applyed it only with:
{{{
git-apply -p1 -R external-intl.001.diff
}}}
and I have error:
{{{
$ ./autogen.sh
...
lot of warnings related to ticket:133
...
Makefile.am:5: AM_GNU_GETTEXT used but `intl' not in SUBDIRS
configure.ac:106: required file `./ABOUT-NLS' not found
automake failed to generate Makefile.in
$lsb_release -a
LSB Version:
:core-3.1-ia32:core-3.1-noarch:core-3.2-ia32:core-3.2-noarch:desktop-3.1-ia32:desktop-3.1-noarch:desktop-3.2-ia32:desktop-3.2-noarch
Distributor ID: Fedora
Description:Fedora release 10 (Cambridge)
Release:10
Codename: Cambridge
$ rpm -q autoconf
autoconf-2.63-1.fc10.noarch
$ rpm -q automake
automake-1.10.1-2.noarch
$ rpm -q gettext
gettext-0.17-8.fc10.i386
}}}
next:
{{{
$ touch ABOUT-NLS
$ ./autogen
...
config.status: creating doc/sr/mcserv.8
config.status: creating doc/sr/Makefile
config.status: error: cannot find input file: po/Makefile.in.in
}}}
--
Ticket URL: www.midnight-commander.org/ticket/135#comment:7
Midnight Commander www.midnight-commander.org
Midnight Development Center
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #125: allocate and free memory via mc-wrappers
#125: allocate and free memory via mc-wrappers --+- Reporter: slavazanko | Owner: slavazanko Type: enhancement | Status: accepted Priority: major| Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: memory Blocking: | Blockedby: --+- Changes (by slavazanko): * owner: = slavazanko * status: new = accepted Comment: Is we need to make these changes in this patch or in later refactoring process? P.S. branch '125-allocate-and-free-memory-via-wrapper' was created. -- Ticket URL: www.midnight-commander.org/ticket/125#comment:3 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #139: compatibility_move_mc_files() still needed ?
#139: compatibility_move_mc_files() still needed ? --+- Reporter: metux| Owner: slavazanko Type: task | Status: testing Priority: minor| Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution: fixed|Keywords: Blocking: | Blockedby: --+- Changes (by slavazanko): * status: accepted = testing * resolution: = fixed Comment: Patch applyed to 'master', branch 'compatibility_move_mc_files' deleted. -- Ticket URL: www.midnight-commander.org/ticket/139#comment:8 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[Midnight Commander] #145: update m4/* files
#145: update m4/* files ---+ Reporter: Enrico Weigelt weig...@metux.de | Owner: Type: defect | Status: new Priority: major | Milestone: Component: mc-core| Version: 4.6.1 Keywords: |Blocking: Blockedby: | ---+ The files in m4/* seem to be a bit outdated, at least they get changed by the autogen process. -- Ticket URL: www.midnight-commander.org/ticket/145 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #145: update m4/* files
#145: update m4/* files +--- Reporter: Enrico Weigelt weig...@metux.de | Owner: Type: defect | Status: new Priority: major | Milestone: Component: mc-core| Version: 4.6.1 Resolution: |Keywords: Blocking: | Blockedby: +--- Old description: The files in m4/* seem to be a bit outdated, at least they get changed by the autogen process. New description: The files in m4/* seem to be a bit outdated, at least they get changed by the autogen process. -- Comment(by slavazanko): Is we need to ignore these files (via .gitignore)? -- Ticket URL: www.midnight-commander.org/ticket/145#comment:2 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #125: allocate and free memory via mc-wrappers
#125: allocate and free memory via mc-wrappers --+- Reporter: slavazanko | Owner: slavazanko Type: enhancement | Status: accepted Priority: major| Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: memory Blocking: | Blockedby: --+- Changes (by winnie): * milestone: 4.6.2 = 4.7 Comment: Move this to a later milestone as this is really a restructurement of mc atm and the 4.6 series should be only a pure bugfix release. This should go only to master not to mc-4.6 branch. -- Ticket URL: www.midnight-commander.org/ticket/125#comment:4 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #126: Merge ./lib/ChangeLog with ./ChangeLog
#126: Merge ./lib/ChangeLog with ./ChangeLog --+- Reporter: metux| Owner: Type: defect | Status: new Priority: trivial | Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: Blocking: | Blockedby: --+- Changes (by winnie): * milestone: 4.6.2 = 4.7 Comment: Oswald Buddenhagen is correct.. this is a restructurement and belongs not into a bugfix release. Change Milestone from 4.6.2 to 4.7. -- Ticket URL: www.midnight-commander.org/ticket/126#comment:2 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #144: Add procmail syntax highlighting
#144: Add procmail syntax highlighting ---+ Reporter: Patrick Winnertz win...@debian.org | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution:|Keywords: Blocking:| Blockedby: ---+ Comment(by slavazanko): I think, syntax highlight it's a not important enhancements and full discuss not needed... Is I'm mistaken? -- Ticket URL: www.midnight-commander.org/ticket/144#comment:6 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #135: [PATCH] Drop bundled libintl
#135: [PATCH] Drop bundled libintl --+- Reporter: metux| Owner: metux Type: enhancement | Status: accepted Priority: minor| Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: Blocking: | Blockedby: --+- Changes (by winnie): * milestone: 4.6.2 = 4.7 Comment: Enrico? As far as I see this: Is this (at least) partly a bugfix? Or only some kind of restructurement in your eyes? As far as I see it we should move it to 4.7 and not to 4.6.2 (apply it only on master branch and not on mc-4.6.2) branch. -- Ticket URL: www.midnight-commander.org/ticket/135#comment:8 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #96: segfault-on-invalid-mtime fix
#96: segfault-on-invalid-mtime fix -+-- Reporter: slavazanko | Owner: Type: defect | Status: new Priority: critical| Milestone: 4.6.2 Component: mc-core | Version: Resolution: |Keywords: Blocking: | Blockedby: -+-- Changes (by winnie): * milestone: Bug Fixing = 4.6.2 Comment: Reassign to 4.6.2 as this should be the bugfix release. -- Ticket URL: www.midnight-commander.org/ticket/96#comment:2 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #125: allocate and free memory via mc-wrappers
#125: allocate and free memory via mc-wrappers --+- Reporter: slavazanko | Owner: slavazanko Type: enhancement | Status: accepted Priority: major| Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: memory Blocking: | Blockedby: --+- Comment(by slavazanko): What should this mcglib actually contain ? It's only for example ;) This should go only to master not to mc-4.6 branch. agree. -- Ticket URL: www.midnight-commander.org/ticket/125#comment:5 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #140: [PATCH] moving doc files
#140: [PATCH] moving doc files ---+ Reporter: enrico.weig...@zaphod.local, metux IT service weig...@metux.de | Owner: Type: defect | Status: new Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: Blocking: | Blockedby: ---+ Comment(by slavazanko): well, where patch? -- Ticket URL: www.midnight-commander.org/ticket/140#comment:4 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #139: compatibility_move_mc_files() still needed ?
#139: compatibility_move_mc_files() still needed ? --+- Reporter: metux| Owner: slavazanko Type: task | Status: testing Priority: minor| Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: fixed|Keywords: Blocking: | Blockedby: --+- Changes (by andrew_b): * milestone: 4.6.2 = 4.7 Comment: What about [http://standards.freedesktop.org/basedir-spec/basedir- spec-0.6.html XDG Base Directory Specification]? Maybe we need move $HOME./mc to $XDG_CONFIG_HOME/mc (or to $HOME/.config/mc)? If yes, the compatibility_move_mc_files() function can be rewritten for this action. -- Ticket URL: www.midnight-commander.org/ticket/139#comment:9 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #139: compatibility_move_mc_files() still needed ?
#139: compatibility_move_mc_files() still needed ? --+- Reporter: metux| Owner: slavazanko Type: task | Status: testing Priority: minor| Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: fixed|Keywords: Blocking: | Blockedby: --+- Comment(by Enrico Weigelt): * MC Ticket System tick...@midnight-commander.org schrieb: No, please let it where it is. -- Ticket URL: www.midnight-commander.org/ticket/139#comment: Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #10: savannah: copy from fish vfs stalls on symlinks
#10: savannah: copy from fish vfs stalls on symlinks -+-- Reporter: slavazanko | Owner: winnie Type: defect | Status: accepted Priority: major | Milestone: 4.6.2 Component: mc-core | Version: Resolution: |Keywords: Blocking: | Blockedby: -+-- Changes (by winnie): * owner: = winnie * status: new = accepted * milestone: = 4.6.2 Comment: NACK from me.. S_ISLINK(ST.st_mode) exists... why don't use it. BTW, this is a bugfix which is suitable for 4.6.2.. therefore Milestone 4.6.2 -- Ticket URL: www.midnight-commander.org/ticket/10#comment:2 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #139: compatibility_move_mc_files() still needed ?
#139: compatibility_move_mc_files() still needed ? --+- Reporter: metux| Owner: slavazanko Type: task | Status: reopened Priority: minor| Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: Blocking: | Blockedby: --+- Changes (by slavazanko): * status: testing = reopened * resolution: fixed = -- Ticket URL: www.midnight-commander.org/ticket/139#comment:12 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #10: savannah: copy from fish vfs stalls on symlinks
#10: savannah: copy from fish vfs stalls on symlinks -+-- Reporter: slavazanko | Owner: winnie Type: defect | Status: accepted Priority: major | Milestone: 4.6.2 Component: mc-core | Version: Resolution: |Keywords: Blocking: | Blockedby: -+-- Comment(by Patrick Winnertz): Updated patch now in order to use S_ISLNK and to do not fail on files or links which are called: foo - bar. Attached a rev2 of the patch (this is also viewable in d65198e9f286acae8a9d9a9a7b499fe3328c3bcd ). Please comment on this fix. -- Ticket URL: www.midnight-commander.org/ticket/10#comment: Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #10: savannah: copy from fish vfs stalls on symlinks
#10: savannah: copy from fish vfs stalls on symlinks -+-- Reporter: slavazanko | Owner: winnie Type: defect | Status: accepted Priority: major | Milestone: 4.6.2 Component: mc-core | Version: Resolution: |Keywords: Blocking: | Blockedby: -+-- Comment(by Patrick Winnertz): I've made a small update to this patch, as someone tries this in the past without completing it. There was a case 'L': ent-ino-linkname = g_strdup(buffer+1); but the ls command executed on the server never set a Lsomeinfo, so this code will never be executed. Instead of setting a Lsomeinfo line on the remote site via shell hacking, i think it is more relyable to do this locally in c as we can't know which commands are avialable on the remote site. Please comment on this (rev3). -- Ticket URL: www.midnight-commander.org/ticket/10#comment: Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[Midnight Commander] #146: bashisms in several extfs scripts
#146: bashisms in several extfs scripts --+- Reporter: Patrick Winnertz win...@debian.org | Owner: Type: defect| Status: new Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.1 Keywords:|Blocking: Blockedby:| --+- Hey, There are some bashisms in extfs scripts which made these scripts useless on another shell then the bash (e.g. zsh or dash). The attached patch will fix this issue. Greetings Winnie -- Ticket URL: www.midnight-commander.org/ticket/146 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[Midnight Commander] #147: Fix escaping for completion on cmdline (spaces, backslashes, etc).
#147: Fix escaping for completion on cmdline (spaces, backslashes, etc). --+- Reporter: Patrick Winnertz win...@debian.org | Owner: Type: defect| Status: new Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.1 Keywords:|Blocking: Blockedby:| --+- Hey, This patch will fix problems with escaping on cmdline basically. The patch is not perfect and should, at least, partially reworked. Greetings Winnie -- Ticket URL: www.midnight-commander.org/ticket/147 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #147: Fix escaping for completion on cmdline (spaces, backslashes, etc).
#147: Fix escaping for completion on cmdline (spaces, backslashes, etc). ---+ Reporter: Patrick Winnertz win...@debian.org | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution:|Keywords: review Blocking:| Blockedby: ---+ -- Ticket URL: www.midnight-commander.org/ticket/147 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[Midnight Commander] #148: Re: mcedit - fancy tab handling
#148: Re: mcedit - fancy tab handling --+- Reporter: Patrick Winnertz win...@debian.org | Owner: Type: defect| Status: new Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.1 Keywords:|Blocking: Blockedby:| --+- Am Montag 05 Januar 2009 21:40:43 schrieb Janek Kozicki: I'm attaching here the patch which is in use inside debian for a long time to add a shortcut in order to turn this behaviour off and on. Please comment on this patch. Should this also applied against mc-4.6 (which should only hold bugfixes) or should this go only into a coming 4.7 release? Greetings Winnie -- Ticket URL: www.midnight-commander.org/ticket/148 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #146: bashisms in several extfs scripts
#146: bashisms in several extfs scripts ---+ Reporter: Patrick Winnertz win...@debian.org | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution:|Keywords: review Blocking:| Blockedby: ---+ Changes (by Patrick Winnertz): * keywords: = review * owner: = winnie * status: new = accepted * milestone: 4.7 = 4.6.2 Comment: I'll work on this. Please review the patch, which is attached. -- Ticket URL: www.midnight-commander.org/ticket/146#comment: Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #147: Fix escaping for completion on cmdline (spaces, backslashes, etc).
#147: Fix escaping for completion on cmdline (spaces, backslashes, etc). ---+ Reporter: Patrick Winnertz win...@debian.org | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution:|Keywords: review Blocking:| Blockedby: ---+ Changes (by Patrick Winnertz): * keywords: = review * owner: = winnie * status: new = accepted Comment: I'll work on this.. please review the patch which is attached to this ticket -- Ticket URL: www.midnight-commander.org/ticket/147#comment: Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #149: files with whitespaces as start won't work via fish
#149: files with whitespaces as start won't work via fish ---+ Reporter: Patrick Winnertz win...@debian.org | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.6.2 Component: vfs | Version: 4.6.1 Resolution:|Keywords: Blocking:| Blockedby: 147 ---+ Changes (by Patrick Winnertz): * owner: = winnie * status: new = accepted * component: mc-core = vfs * blockedby: = 147 * milestone: 4.7 = 4.6.2 Comment: Sadly it's not possible to set the stuff without writing a bit or in the first mail: I'll work on this and this should be fixe in 4.6.2. -- Ticket URL: www.midnight-commander.org/ticket/149#comment: Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #91: [trac] new components: locale, adm,
#91: [trac] new components: locale, adm, ---+ Reporter: metux | Owner: winnie Type: task | Status: closed Priority: critical | Milestone: Component: mc-core | Version: Resolution: fixed |Keywords: Blocking:| Blockedby: ---+ Changes (by winnie): * status: testing = closed -- Ticket URL: www.midnight-commander.org/ticket/91#comment:3 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #16: savannah: c is _not_ c++
#16: savannah: c is _not_ c++ -+-- Reporter: slavazanko | Owner: winnie Type: defect | Status: testing Priority: trivial | Milestone: 4.6.2 Component: mcedit | Version: 4.6.1 Resolution: fixed |Keywords: review Blocking: | Blockedby: -+-- Changes (by winnie): * keywords: = review * status: accepted = testing * resolution: = fixed -- Ticket URL: www.midnight-commander.org/ticket/16#comment:6 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #65: savannah: Pascal syntax highlighting update
#65: savannah: Pascal syntax highlighting update --+- Reporter: slavazanko | Owner: winnie Type: enhancement | Status: testing Priority: minor| Milestone: 4.6.2 Component: mc-core | Version: Resolution: fixed|Keywords: preview Blocking: | Blockedby: --+- Changes (by winnie): * keywords: = preview * status: accepted = testing * resolution: = fixed -- Ticket URL: www.midnight-commander.org/ticket/65#comment:9 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #143: Updated sh syntax file
#143: Updated sh syntax file ---+ Reporter: Patrick Winnertz win...@debian.org | Owner: winnie Type: enhancement | Status: testing Priority: major | Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution: fixed |Keywords: review Blocking:| Blockedby: ---+ Changes (by winnie): * keywords: = review * status: accepted = testing * resolution: = fixed -- Ticket URL: www.midnight-commander.org/ticket/143#comment:7 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #124: Test ticker foo
#124: Test ticker foo +--- Reporter: Enrico Weigelt weig...@metux.de | Owner: metux Type: defect | Status: closed Priority: major | Milestone: Component: mc-core| Version: 4.6.1 Resolution: invalid|Keywords: Blocking: | Blockedby: +--- Changes (by winnie): * status: testing = closed -- Ticket URL: www.midnight-commander.org/ticket/124#comment:4 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #96: segfault-on-invalid-mtime fix
#96: segfault-on-invalid-mtime fix -+-- Reporter: slavazanko | Owner: Type: defect | Status: new Priority: critical| Milestone: 4.6.2 Component: mc-core | Version: Resolution: |Keywords: Blocking: | Blockedby: -+-- Comment(by metux): Ups, obviously I uploaded the wrong patch ;-o -- Ticket URL: www.midnight-commander.org/ticket/96#comment:4 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #96: segfault-on-invalid-mtime fix
#96: segfault-on-invalid-mtime fix -+-- Reporter: slavazanko | Owner: Type: defect | Status: new Priority: critical| Milestone: 4.6.2 Component: mc-core | Version: Resolution: |Keywords: review Blocking: | Blockedby: -+-- Changes (by metux): * keywords: = review -- Ticket URL: www.midnight-commander.org/ticket/96#comment:5 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #138: [PATCH] (4.6.1) Fixup homepage url
#138: [PATCH] (4.6.1) Fixup homepage url ---+ Reporter: enrico.weig...@zaphod.local, metux IT service weig...@metux.de | Owner: Type: defect | Status: new Priority: critical | Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: review Blocking: | Blockedby: ---+ Changes (by metux): * keywords: = review -- Ticket URL: www.midnight-commander.org/ticket/138#comment:3 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #139: compatibility_move_mc_files() still needed ?
#139: compatibility_move_mc_files() still needed ? --+- Reporter: metux| Owner: slavazanko Type: task | Status: reopened Priority: minor| Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: approved-metux, approved-winnie, approve_count=2 Blocking: | Blockedby: --+- Changes (by metux): * keywords: = approved-metux, approved-winnie, approve_count=2 Comment: Why reopened ? -- Ticket URL: www.midnight-commander.org/ticket/139#comment:13 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #135: [PATCH] Drop bundled libintl
#135: [PATCH] Drop bundled libintl --+- Reporter: metux| Owner: metux Type: enhancement | Status: accepted Priority: minor| Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: rework Blocking: | Blockedby: --+- Changes (by metux): * keywords: = rework Comment: @winnie: it's more an cleanup which should not change any functionality or interface. Can we add an cleanup ticket type ? -- Ticket URL: www.midnight-commander.org/ticket/135#comment:9 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #134: [PATCH] some time formatting fixes
#134: [PATCH] some time formatting fixes +--- Reporter: Enrico Weigelt weig...@metux.de | Owner: Type: defect | Status: new Priority: major | Milestone: 4.6.2 Component: mc-core| Version: 4.6.1 Resolution: |Keywords: review Blocking: | Blockedby: +--- Changes (by metux): * keywords: = review Old description: this patch goes a bit deeper into the strftime()+localtime() issue. a) introduce some new shortcut macros and use them in some places b) adds additional checks (where the macros dont fit) New description: this patch goes a bit deeper into the strftime()+localtime() issue. a) introduce some new shortcut macros and use them in some places b) adds additional checks (where the macros dont fit) -- -- Ticket URL: www.midnight-commander.org/ticket/134#comment:3 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #133: [PATCH] fix use of obsolete autoconf macros
#133: [PATCH] fix use of obsolete autoconf macros --+- Reporter: metux| Owner: Type: defect | Status: new Priority: minor| Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: review Blocking: | Blockedby: --+- Changes (by metux): * keywords: = review -- Ticket URL: www.midnight-commander.org/ticket/133#comment:2 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #148: Re: mcedit - fancy tab handling
#148: Re: mcedit - fancy tab handling ---+ Reporter: Patrick Winnertz win...@debian.org | Owner: Type: defect| Status: new Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution:|Keywords: review Blocking:| Blockedby: ---+ Changes (by metux): * keywords: = review Old description: Am Montag 05 Januar 2009 21:40:43 schrieb Janek Kozicki: I'm attaching here the patch which is in use inside debian for a long time to add a shortcut in order to turn this behaviour off and on. Please comment on this patch. Should this also applied against mc-4.6 (which should only hold bugfixes) or should this go only into a coming 4.7 release? Greetings Winnie New description: Am Montag 05 Januar 2009 21:40:43 schrieb Janek Kozicki: I'm attaching here the patch which is in use inside debian for a long time to add a shortcut in order to turn this behaviour off and on. Please comment on this patch. Should this also applied against mc-4.6 (which should only hold bugfixes) or should this go only into a coming 4.7 release? Greetings Winnie -- -- Ticket URL: www.midnight-commander.org/ticket/148#comment:2 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #141: ***TRASH*** (was: [PATCH] Moving doc files (001))
#141: ***TRASH*** ---+ Reporter: enrico.weig...@zaphod.local, metux IT service weig...@metux.de | Owner: slavazanko Type: defect | Status: testing Priority: major | Milestone: Component: mc-core | Version: 4.6.1 Resolution: duplicate |Keywords: Blocking: | Blockedby: ---+ Description changed by metux: Old description: This patch moves documentation files from toplevel to doc/ and manpages from doc/ to doc/man New description: -- -- Ticket URL: www.midnight-commander.org/ticket/141#comment:4 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #137: [PATCH] (git) Fixup homepage url
#137: [PATCH] (git) Fixup homepage url ---+ Reporter: enrico.weig...@zaphod.local, metux IT service weig...@metux.de | Owner: metux Type: task | Status: assigned Priority: critical | Milestone: 4.6.2 Component: mc-core | Version: Resolution: |Keywords: review Blocking: | Blockedby: ---+ Changes (by metux): * keywords: = review -- Ticket URL: www.midnight-commander.org/ticket/137#comment:7 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #141: ***TRASH***
#141: ***TRASH*** ---+ Reporter: enrico.weig...@zaphod.local, metux IT service weig...@metux.de | Owner: slavazanko Type: defect | Status: closed Priority: major | Milestone: Component: mc-core | Version: 4.6.1 Resolution: duplicate |Keywords: Blocking: | Blockedby: ---+ Changes (by winnie): * status: testing = closed -- Ticket URL: www.midnight-commander.org/ticket/141#comment:5 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #142: Syntax highlighting for debian specific files
#142: Syntax highlighting for debian specific files ---+ Reporter: Patrick Winnertz win...@debian.org | Owner: winnie Type: enhancement | Status: accepted Priority: major | Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution:|Keywords: review Blocking:| Blockedby: ---+ Changes (by winnie): * keywords: = review -- Ticket URL: www.midnight-commander.org/ticket/142#comment:4 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #144: Add procmail syntax highlighting
#144: Add procmail syntax highlighting ---+ Reporter: Patrick Winnertz win...@debian.org | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution:|Keywords: review Blocking:| Blockedby: ---+ Changes (by winnie): * keywords: = review * milestone: 4.6.2 = 4.7 Comment: This is not a bugfix but a enhancment therefore this should go to 4.7 and not to 4.6.2 -- Ticket URL: www.midnight-commander.org/ticket/144#comment:7 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[Midnight Commander] #150: [PATCH] More FHS-compliant install directories
#150: [PATCH] More FHS-compliant install directories --+ Reporter: enrico.weig...@zaphod.local, metux IT service weig...@metux.de | Owner: Type: defect| Status: new Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.1 Keywords:| Blocking: Blockedby:| --+ Rewrite of the config file lookup, moving all global configs to /etc/mc, removed unnecessary repeated fn rendering, ... -- Ticket URL: www.midnight-commander.org/ticket/150 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #140: [PATCH] moving doc files
#140: [PATCH] moving doc files ---+ Reporter: enrico.weig...@zaphod.local, metux IT service weig...@metux.de | Owner: Type: defect | Status: new Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: Blocking: | Blockedby: ---+ Comment(by ): now here it is :) -- Ticket URL: www.midnight-commander.org/ticket/140#comment: Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #147: Fix escaping for completion on cmdline (spaces, backslashes, etc).
#147: Fix escaping for completion on cmdline (spaces, backslashes, etc). ---+ Reporter: Patrick Winnertz win...@debian.org | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution:|Keywords: review Blocking: 149 | Blockedby: ---+ Changes (by winnie): * milestone: 4.7 = 4.6.2 Old description: Hey, This patch will fix problems with escaping on cmdline basically. The patch is not perfect and should, at least, partially reworked. Greetings Winnie New description: Hey, This patch will fix problems with escaping on cmdline basically. The patch is not perfect and should, at least, partially reworked. Greetings Winnie -- -- Ticket URL: www.midnight-commander.org/ticket/147#comment:4 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #147: Fix escaping for completion on cmdline (spaces, backslashes, etc).
#147: Fix escaping for completion on cmdline (spaces, backslashes, etc). ---+ Reporter: Patrick Winnertz win...@debian.org | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution:|Keywords: rework Blocking: 149 | Blockedby: ---+ Changes (by winnie): * keywords: review = rework Comment: Maybe it's a good idea to try to use g_strescape and g_strcompress instead of home-made functions... -- Ticket URL: www.midnight-commander.org/ticket/147#comment:5 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #147: Fix escaping for completion on cmdline (spaces, backslashes, etc).
#147: Fix escaping for completion on cmdline (spaces, backslashes, etc). ---+ Reporter: Patrick Winnertz win...@debian.org | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution:|Keywords: review Blocking: 149 | Blockedby: ---+ Changes (by Patrick Winnertz): * keywords: rework = review Comment: Hey, Maybe it's a good idea to try to use g_strescape and g_strcompress instead of home-made functions... I tried it with these functions.. unfortunatly g_strescape doesn't escape the whitespace .. therefore this function is useless for us. I rewrote the patch a little bit to escape everything even if it's the leading char. -- Ticket URL: www.midnight-commander.org/ticket/147#comment: Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #150: [PATCH] More FHS-compliant install directories
#150: [PATCH] More FHS-compliant install directories ---+ Reporter: enrico.weig...@zaphod.local, metux IT service weig...@metux.de | Owner: Type: defect | Status: new Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: Blocking: | Blockedby: ---+ Old description: Rewrite of the config file lookup, moving all global configs to /etc/mc, removed unnecessary repeated fn rendering, ... New description: Rewrite of the config file lookup, moving all global configs to /etc/mc, removed unnecessary repeated fn rendering, ... -- Comment(by slavazanko): Is this ticket duplicate for #130? -- Ticket URL: www.midnight-commander.org/ticket/150#comment:2 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #10: savannah: copy from fish vfs stalls on symlinks
#10: savannah: copy from fish vfs stalls on symlinks -+-- Reporter: slavazanko | Owner: winnie Type: defect | Status: accepted Priority: major | Milestone: 4.6.2 Component: mc-core | Version: Resolution: |Keywords: Blocking: | Blockedby: -+-- Comment(by slavazanko): see test-fish-ls.sh Script like this attach used for retrieve listing if remote directory. I will change script for run independ from mc and add some thinks... eg. check if ls support option '-Q' -- Ticket URL: www.midnight-commander.org/ticket/10#comment:5 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #147: Fix escaping for completion on cmdline (spaces, backslashes, etc).
#147: Fix escaping for completion on cmdline (spaces, backslashes, etc).
---+
Reporter: Patrick Winnertz win...@debian.org | Owner: winnie
Type: defect| Status: accepted
Priority: major | Milestone: 4.6.2
Component: mc-core | Version: 4.6.1
Resolution:|Keywords: review
Blocking: 149 | Blockedby:
---+
Comment(by Patrick Winnertz):
Hey Roland,
See the branch this commit belongs too, and you'll see that this belongs
to a
patch where some rework is needed. :) See ticket:147.
In order to get your remark not only onto this list but also into the
ticket
'm replying not the the list but to the ticketsystem which will then
forward
the mail back to the list.
I don't get why there has to be a variable k in the functions. Its
completely unnecessary. A much simpler, faster, and more reliable way is
the following (untested):
I'll test it and merge it into the bugfix branch.
char *
unescape_string(const char *in) {
GString *str;
const char * src;
char *result;
str = g_string_new();
for (src = in; *src != '\0'; src++) {
if (src[0] == '\\' strchr( \t*|;~#()?[]{}, src[1])) {
g_string_append_c(str, src[1]);
src++;
} else {
g_string_append_c(str, src[0]);
}
}
result = str-str;
g_string_free(str, FALSE);
return result;
}
It's much simpler that way. It doesn't call strlen() unnecessarily. It
doesn't have unneeded variables. And it doesn't crash if in[-1] is an
illegal address.
Well It is indeed much simpler.. but do you tested this patch once? mc
won't
crash...(tested).
Greetings
Winnie
--
Ticket URL: www.midnight-commander.org/ticket/147#comment:
Midnight Commander www.midnight-commander.org
Midnight Development Center
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #139: compatibility_move_mc_files() still needed ?
#139: compatibility_move_mc_files() still needed ? --+- Reporter: metux| Owner: slavazanko Type: task | Status: reopened Priority: minor| Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: approved-metux, approved-winnie, approve_count=2 Blocking: | Blockedby: --+- Comment(by slavazanko): What about XDG Base Directory Specification? I think, need to create new ticket. No, please let it where it is. '''status changed from testing to reopened''' Why reopened ? Because 'testing' state for new request by andrew_b is a not valid state, 'closed' state non-valid too... -- Ticket URL: www.midnight-commander.org/ticket/139#comment:14 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #147: Fix escaping for completion on cmdline (spaces, backslashes, etc).
#147: Fix escaping for completion on cmdline (spaces, backslashes, etc). ---+ Reporter: Patrick Winnertz win...@debian.org | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution:|Keywords: review Blocking: 149 | Blockedby: ---+ Comment(by rillig): In the unescape_string function, there is no need to check for (i == 0). Otherwise the first character of the string may be skipped, which I think is not intended. Why do the following characters do not need escaping:? $ ` and why aren't the characters sorted according to their ASCII values? Roland -- Ticket URL: www.midnight-commander.org/ticket/147#comment:8 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #150: [PATCH] More FHS-compliant install directories
#150: [PATCH] More FHS-compliant install directories ---+ Reporter: enrico.weig...@zaphod.local, metux IT service weig...@metux.de | Owner: Type: defect | Status: new Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: Blocking: | Blockedby: ---+ Comment(by andrew_b): Why the _strcatdup() function is used instead of g_strconcat() one? -- Ticket URL: www.midnight-commander.org/ticket/150#comment:3 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[Midnight Commander] #151: Unitialized use of variable in edit.c
#151: Unitialized use of variable in edit.c -+-- Reporter: metux| Owner: Type: defect | Status: new Priority: major| Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Keywords: |Blocking: Blockedby: | -+-- gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -g -O2 -Wall -MT edit.o -MD -MP -MF .deps/edit.Tpo -c -o edit.o edit.c edit.c: In function 'edit_cursor_move': edit.c:1102: warning: 'c' may be used uninitialized in this function mv -f .deps/edit.Tpo .deps/edit.Po -- Ticket URL: www.midnight-commander.org/ticket/151 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #147: Fix escaping for completion on cmdline (spaces, backslashes, etc).
#147: Fix escaping for completion on cmdline (spaces, backslashes, etc). ---+ Reporter: Patrick Winnertz win...@debian.org | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution:|Keywords: review Blocking: 149 | Blockedby: ---+ Comment(by Patrick Winnertz): Hey, Why do the following characters do not need escaping:? $ ` Added. and why aren't the characters sorted according to their ASCII values? This is done now. Please note that I had not much time to rewrite the escape_string function in order to use g_str_append_c. It uses atm a negative index for a check (src[-1]). It looks ugly but it doesn't fail. Please send a patch if you have a better idea for this ifclause. Greetings Winnie -- Ticket URL: www.midnight-commander.org/ticket/147#comment: Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #10: savannah: copy from fish vfs stalls on symlinks
#10: savannah: copy from fish vfs stalls on symlinks -+-- Reporter: slavazanko | Owner: winnie Type: defect | Status: accepted Priority: major | Milestone: 4.6.2 Component: mc-core | Version: Resolution: |Keywords: Blocking: | Blockedby: 147, 149 -+-- Changes (by winnie): * blockedby: = 147, 149 Comment: There is a fix in the 10_fish_stalls_on_symlink branch.. however this fix is uncomplete as it will fail in this scenario: echo ALL OK this - file ln -s this - file this - link The link will point to - file instead of this - file. To fix this issue we need quoted output. (This means ls -Q). As this is no standard option but only used in gnu ls we have to check prior using it if this option is available. However this is related to ticket:149. -- Ticket URL: www.midnight-commander.org/ticket/10#comment:6 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #151: Unitialized use of variable in edit.c
#151: Unitialized use of variable in edit.c --+- Reporter: metux| Owner: Type: defect | Status: new Priority: minor| Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: Blocking: | Blockedby: --+- Changes (by winnie): * priority: major = minor Comment: I think this is uncritical as c will get in every case initialised. However if you would like to get rid of this warning initialise c to -3. As this is the default return value for this function. If you do this you could rewrite it partly in order to replace the four return calls with only one. (After the if clause). -- Ticket URL: www.midnight-commander.org/ticket/151#comment:1 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #10: savannah: copy from fish vfs stalls on symlinks
#10: savannah: copy from fish vfs stalls on symlinks -+-- Reporter: slavazanko | Owner: winnie Type: defect | Status: accepted Priority: major | Milestone: 4.6.2 Component: mc-core | Version: Resolution: |Keywords: review,vote-metux Blocking: | Blockedby: 147, 149 -+-- Changes (by metux): * keywords: = review,vote-metux -- Ticket URL: www.midnight-commander.org/ticket/10#comment:7 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[Midnight Commander] #152: [PATCH] helper func: shell escaping (1st take)
#152: [PATCH] helper func: shell escaping (1st take) --+ Reporter: enrico.weig...@zaphod.local, metux IT service weig...@metux.de | Owner: Type: defect| Status: new Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.1 Keywords:| Blocking: Blockedby:| --+ adds an little helper function which shell-escapes an given string and returns it strdup()ed -- Ticket URL: www.midnight-commander.org/ticket/152 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[Midnight Commander] #153: syntax file format needs doc
#153: syntax file format needs doc --+- Reporter: slyfox| Owner: Type: enhancement | Status: new Priority: major | Milestone: 4.6.2 Component: mcedit| Version: 4.6.1 Keywords: syntax, doc, feature |Blocking: Blockedby:| --+- I'd like /usr/share/mc/syntax/ would have README file. I think this README must contain: * syntax file format description * something, like BNF would be great (at least i will know where i can use regular expression and where i can't :]) * explain every keyword a little * complete regular expressions format (and/or link to it's description if it's not special) * notes on performance of constructs (maybe, list and describe some common inefficient regexp patterns) -- Ticket URL: www.midnight-commander.org/ticket/153 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #120: savannah: compare files command would be nice to have in mc
#120: savannah: compare files command would be nice to have in mc --+- Reporter: slavazanko | Owner: Type: enhancement | Status: new Priority: minor| Milestone: Component: mcedit | Version: 4.6.1 Resolution: |Keywords: Blocking: | Blockedby: --+- Changes (by metux): * priority: major = minor * type: defect = enhancement -- Ticket URL: www.midnight-commander.org/ticket/120#comment:1 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #119: savannah: Change default copy configuration wanted
#119: savannah: Change default copy configuration wanted --+- Reporter: slavazanko | Owner: Type: enhancement | Status: new Priority: minor| Milestone: Component: vfs | Version: 4.6.1 Resolution: |Keywords: Blocking: | Blockedby: --+- Changes (by metux): * priority: major = minor * type: defect = enhancement -- Ticket URL: www.midnight-commander.org/ticket/119#comment:1 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #147: Fix escaping for completion on cmdline (spaces, backslashes, etc).
#147: Fix escaping for completion on cmdline (spaces, backslashes, etc). ---+ Reporter: Patrick Winnertz win...@debian.org | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution:|Keywords: review Blocking: 10, 149 | Blockedby: ---+ Comment(by slavazanko): 1. run mc with patch 2. type cd ~ and press twice ESC,TAB 3. select from list your homedir (\~slavaz/ in my case) 4. press twice ESC,TAB no any reaction (only bells). Without patch continued to navigate: 5. select from list subdir in your homedir 6. press twice ESC,TAB 7. ... After remove line src/complete.c:947 (see escaping-patch-rev3.patch) navigate to subdirs worked. -- Ticket URL: www.midnight-commander.org/ticket/147#comment:11 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #147: Fix escaping for completion on cmdline (spaces, backslashes, etc).
#147: Fix escaping for completion on cmdline (spaces, backslashes, etc).
---+
Reporter: Patrick Winnertz win...@debian.org | Owner: winnie
Type: defect| Status: accepted
Priority: major | Milestone: 4.6.2
Component: mc-core | Version: 4.6.1
Resolution:|Keywords: review
Blocking: 10, 149 | Blockedby:
---+
Comment(by slavazanko):
BTW:
{{{
diff --git a/src/complete.c b/src/complete.c
index a11b9c9..cb18f42 100644
--- a/src/complete.c
+++ b/src/complete.c
@@ -944,7 +944,9 @@ complete_engine (WInput *in, int what_to_do)
WListbox *query_list;
for (p=in-completions + 1; *p; count++, p++) {
- *p = escape_string(*p);
+ q = escape_string(*p);
+ g_free(*p);
+ *p = q;
if ((i = strlen (*p)) maxlen)
maxlen = i;
}
}}}
I think, this remove some memory leaks...
And need to review some other parts in patch. For example src/file.c:1876
{{{
source_with_path = unescape_string(source_with_path);
}}}
I think, in any case need to free memory by old pointer. Example:
{{{
char *old_pnt;
...
old_pnt = source_with_path;
source_with_path = unescape_string(source_with_path);
g_free(old_pnt);
}}}
and others like this...
--
Ticket URL: www.midnight-commander.org/ticket/147#comment:12
Midnight Commander www.midnight-commander.org
Midnight Development Center
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #147: Fix escaping for completion on cmdline (spaces, backslashes, etc).
#147: Fix escaping for completion on cmdline (spaces, backslashes, etc).
---+
Reporter: Patrick Winnertz win...@debian.org | Owner: winnie
Type: defect| Status: accepted
Priority: major | Milestone: 4.6.2
Component: mc-core | Version: 4.6.1
Resolution:|Keywords: review
Blocking: 10, 149 | Blockedby:
---+
Comment(by slavazanko):
fix for attachment comment:
{{{
- allyped
+ applyed
}}}
:)
Next testing stuff:
1. press F7 (make dir)
2. type: this dir
3. press SHIFT+F6 (rename)
4. change 'this dir' to 'this \ dir'
Got error.
5. press SHIFT+F6 (rename) again
6. change 'this dir' to 'this \\ dir'
Got error.
--
Ticket URL: www.midnight-commander.org/ticket/147#comment:13
Midnight Commander www.midnight-commander.org
Midnight Development Center
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #152: [PATCH] helper func: shell escaping (1st take)
#152: [PATCH] helper func: shell escaping (1st take) ---+ Reporter: enrico.weig...@zaphod.local, metux IT service weig...@metux.de | Owner: Type: defect | Status: new Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: Blocking: | Blockedby: ---+ Old description: adds an little helper function which shell-escapes an given string and returns it strdup()ed New description: adds an little helper function which shell-escapes an given string and returns it strdup()ed -- Comment(by slavazanko): duplicate #147 -- Ticket URL: www.midnight-commander.org/ticket/152#comment:2 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #147: Fix escaping for completion on cmdline (spaces, backslashes, etc).
#147: Fix escaping for completion on cmdline (spaces, backslashes, etc). ---+ Reporter: Patrick Winnertz win...@debian.org | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.6.2 Component: mc-core | Version: 4.6.1 Resolution:|Keywords: review Blocking: 10, 149 | Blockedby: ---+ Comment(by slavazanko): duplicate #152 -- Ticket URL: www.midnight-commander.org/ticket/147#comment:14 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #152: [PATCH] helper func: shell escaping (1st take)
#152: [PATCH] helper func: shell escaping (1st take) ---+ Reporter: enrico.weig...@zaphod.local, metux IT service weig...@metux.de | Owner: slavazanko Type: defect | Status: testing Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: duplicate |Keywords: Blocking: | Blockedby: ---+ Changes (by slavazanko): * status: accepted = testing * resolution: = duplicate -- Ticket URL: www.midnight-commander.org/ticket/152#comment:4 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[Midnight Commander] #154: [ru-trac] Haskell language syntax highlighting
#154: [ru-trac] Haskell language syntax highlighting -+-- Reporter: slavazanko | Owner: Type: enhancement | Status: new Priority: trivial | Milestone: 4.7 Component: mcedit | Version: 4.6.1 Keywords: |Blocking: Blockedby: | -+-- Original: http://mc.redhat-club.org/trac/ticket/284 Patch for colorize Haskell syntah -- Ticket URL: www.midnight-commander.org/ticket/154 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
