Re: How to apply snapshot patches?
On Sun, 29 Jun 2003, Pavel Roskin wrote:
On Sun, 29 Jun 2003, Dmitry Semyonov wrote:
The patch is applied with my commands ('patch' does not report it
can't find some files). So, I think, I'm in the right tree.
But a lot of warnings(?) mentioned in my previous message are printed to
stdout. This is the problem.
The warnings are the result of -p4. You strip too much from the
filenames.
Shame on me. Now going to read `man patch` once again...
Thank you all.
...Bye..Dmitry.
___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Repository transfer complete
On Sun, 29 Jun 2003, Pavel Roskin wrote: The repository of GNU Midnight Commander has been moved to Savannah. If you need anonymous access, the new CVSROOT is :pserver:[EMAIL PROTECTED]:/cvsroot/ ~~ :pserver:[EMAIL PROTECTED]:/cvsroot/mc ...Bye..Dmitry. ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
Re: BUG: viewing compressed files
On Mon, 30 Jun 2003, Adam Byrtek / alpha wrote: On Sun, Jun 29, 2003 at 07:06:20PM -0400, Pavel Roskin wrote: Check if mc.ext from 4.6.0 makes the difference. No, it has been tested on (the same) fres config files from 4.6.0 in both cases. It might be helpful - the filename is shown as: archive-2002.gz (for 4.6.0) archive-2002.gz#ugz (for 4.6.0a) In 4.6.0a if I enter the Raw mode then press F10, then F3 again filename changes into archive-2002.gz, but it changes back into archive-2002.gz#ugz if I press F8 to enter Parse mode again... Does anybody have similiar problems? I have exactly the same problem, at least with gz files. $ mc -V GNU Midnight Commander 2003-06-25-17 Virtual File System: tarfs, extfs, cpiofs, ftpfs, fish With builtin Editor Using system-installed S-Lang library with terminfo database With subshell support as default With support for background operations With mouse support on xterm and Linux console With support for X11 events With multiple codepages support $ uname -a Linux bor 2.4.21 #3 Fri Jun 13 22:40:05 MSD 2003 i686 unknown ...Bye..Dmitry. ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
Re: How to apply snapshot patches?
On Sat, 28 Jun 2003, David Sterba wrote:
Could anybody tell me a way to cleanly apply snapshot patches to
the reference (4.6.0) tree?
I'm doing
$ cd mc-4.6.0
$ patch -p4 ../mc-4.6.0-2003-06-25-17.diff
I think the problem is in '-p4'. If you cd into right mc tree,
there should go '-p1' which means 'strip one directory from left'.
see 'man patch' for details (e.g. the parameter '-p').
The patch is applied with my commands ('patch' does not report it
can't find some files). So, I think, I'm in the right tree.
But a lot of warnings(?) mentioned in my previous message are printed to
stdout. This is the problem.
...Bye..Dmitry.
___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: mcedit (allmost)dead-loop and memory leak
On Mon, 23 Jun 2003, GoTaR wrote: On Mon, Jun 23, 2003 at 20:36:15 +0400, Dmitry Semyonov wrote: Source of problem is in ... lines. I don't see any ... lines in the file. I mean everything between quotations. In this file every line is between them. You have forgotten to mention the version of mc. Default version - the newest one. Search string not found dialog is displayed almost immediately in mc-4.6.0. No dead-loops, etc. I've tried my mc-4.6.0 and these two ones: http://www.ibiblio.org/pub/Linux/utils/file/managers/mc/binaries/RedHat/8.0/mc-4.6.0-2.i386.rpm http://www.ibiblio.org/pub/Linux/utils/file/managers/mc/snapshots/mc-2003062221-1.i386.rpm It takes them a really long time to finish (a few minutes) and memory usage grows up (up to a few MB for this file) and doesn't shrink after exiting mcedit. Well, now I see what did you mean. Very unpleasant problem. I am able to reproduce it with mc-4.6.0-4 rpm (RedHat's one?) on another machine: Red Hat Linux release 9 (Shrike) (Linux 2.4.20-18.9) $ mc -V GNU Midnight Commander 4.6.0 Virtual File System: tarfs, extfs, cpiofs, ftpfs, fish, undelfs With builtin Editor Using system-installed S-Lang library with terminfo database With subshell support as default With support for background operations With mouse support on xterm and Linux console With support for X11 events With internationalization support On the other hand mc-4.6.0 that I compiled from official sources some time ago is working fine. Options for configure were the following: --disable-dependency-tracking --disable-nls --enable-charset --with-x Red Hat Linux release 7.3 (Valhalla) (Linux 2.4.21) $ mc -V GNU Midnight Commander 4.6.0 Virtual File System: tarfs, extfs, cpiofs, ftpfs, fish With builtin Editor Using system-installed S-Lang library with terminfo database With subshell support as default With support for background operations With mouse support on xterm and Linux console With support for X11 events With multiple codepages support ...Bye..Dmitry. ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
Re: mcedit (allmost)dead-loop and memory leak
On Mon, 23 Jun 2003, GoTaR wrote: http://student.uci.agh.edu.pl/~gotar/license.h choose replace (f4) or search (f7), type $ as search string and mark it as regular expression, press enter. Voila. Source of problem is in ... lines. I don't see any ... lines in the file. You have forgotten to mention the version of mc. Search string not found dialog is displayed almost immediately in mc-4.6.0. No dead-loops, etc. ...Bye..Dmitry. ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
Error message window size bug
Hi! - run mc (4.6.0, 4.5.55) - create dummy folder, sub-folder, sub-sub-folder, etc. so that full name is more than width of your console (80 normally) - on _another_ console remove your dummy tree completely - press TAB, TAB on the first console Window with error message displayed does not fit screen width. ...Bye..Dmitry. ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
Re: File find: open viewer does not jump to line?
Hello David. On Fri, 7 Feb 2003, David Sterba wrote: [in mc 4.6.0] opening editor/viewer in file find dialog does not go to the line. I think, it worked in the past versions. Strange. It works for me. ...Bye..Dmitry. ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [PATCH] dotdot in the root directory
Jaroslaw, On Thu, 30 Jan 2003, Jaroslaw Swierczynski wrote: On Wed, Jan 29, 2003 at 04:40:57PM -0500, Pavel Roskin wrote: I don't think we need an option that affects only one entry in one directory. If you think that .. in the root directory is useful, then please explain, and it will be restored if your arguments are reasonable. Adam said he didn't mind restoring .. in the root directory. Here is why I think .. there is useful. Please decide. I have a habit that when I'm navigating through directories I often use Home-Enter sequence many times to get to the root directory. If there is .. in the root directory, then it stops me and I know I reached the root directory. You know, if we got into something, it's not easy to change this habit. Two solutions to your problem: 1. Switch on 'Lynx like motion' in Options--Configuration menu. Now you can use only one [LEFT ARROW] key instead of [Home, Enter] combination. And this will stop you in root dir as you got used to. 2. Type 'cd /' command. This will get you to root dir even faster from any subdirectory. That is why I believe those dots in root dir are completely useless. Let's not pollute mc code with useless options. ...Bye..Dmitry. ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
Find file dialog in mc-4.6.0-pre3
Hello! I've scanned a TODO list and found the item - Make find dialog more responsive - inside After 4.6.1 on 4.6.x branch section. But I think the responsiveness of the dialog is unacceptable for the 4.6.0 release. I missed the moment when it became so bad, (may be 1-3 releases ago (?)). But I remember mc-4.5.55 responsiveness was _much_ better. In fact 'Find file' in mc-4.6.0-pre3 is unusable on large (~100Mb) directory trees. I can't quickly stop it, I can't quickly suspend it, and so on. The response time is about 40(!) seconds. I've checked it on Linux console and xterm terminals. mc was compiled with the following configure options: --disable-dependency-tracking --disable-nls --enable-charset --with-x $ mc -V GNU Midnight Commander 4.6.0-pre3 Virtual File System: tarfs, extfs, cpiofs, ftpfs, fish With builtin Editor Using system-installed S-Lang library with terminfo database With subshell support as default With support for background operations With mouse support on xterm and Linux console With support for X11 events With multiple codepages support $ uname -a Linux bor 2.4.19 #3 Tue Oct 22 17:44:32 MSD 2002 i686 unknown ...Bye..Dmitry. ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
[BUG] urar extfs in mc-4.6.0-pre2
Hi. I'm unable to enter *.rar archives. I have 'UNRAR 2.71 freeware Copyright (c) 1993-2000 Eugene Roshal' installed in /usr/bin. /usr/local/share/mc/extfs/urar: 16-18 lines do not recognize the unrar. So rar is tried instead, but I have no one installed. ...Bye..Dmitry. ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
[BUG] Move operation Compute Totals option
Hi. I'm moving several directories. 'Compute Totals' option is enabled. Bug: 'Count' progress bar is not updated during MOVE operation. To see this bug more comfortably, move directories with large number of files between different partitions of your drive. --- mc-4.6.0-pre2 Red Hat Linux release 7.2 (Enigma) Kernel 2.4.19 on an i686 ...Bye..Dmitry. ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [BUG] urar extfs in mc-4.6.0-pre2
On Sun, 29 Dec 2002, Tomas Styblo wrote: * Dmitry Semyonov [EMAIL PROTECTED] [Sun, 29 Dec 2002]: I'm unable to enter *.rar archives. I have 'UNRAR 2.71 freeware Copyright (c) 1993-2000 Eugene Roshal' installed in /usr/bin. Support for rar archives in pre2 works for me with rar/unrar: RAR 3.00 beta 6Copyright (c) 1993-2002 Eugene Roshal19 Apr 2002 I have only unrar installed. This shall be enough to brouse rar archives and to extract files from them. I'll try to upgrade to unrar 3.x (after Jan,9), and see how it works. But even if it will work, do you think it is OK to use such unrar detection code that can't properly detect old versions of unrar inside urar extfs script? ...Bye..Dmitry. ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
[BUG] Hintbar switch off in 4.6.0-pre2
Hello! When I'm switching off the hintbar via Options-Layout, the hintbar text starts to appear at the upper left corner of Linux console. --- Linux 2.4.19 GNU Midnight Commander 4.6.0-pre2 Virtual File System: tarfs, extfs, cpiofs, ftpfs, fish With builtin Editor Using system-installed S-Lang library with terminfo database With subshell support as default With support for background operations With mouse support on xterm and Linux console With support for X11 events With multiple codepages support ...Bye..Dmitry. ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [BUG] Hintbar switch off in 4.6.0-pre2
On Fri, 27 Dec 2002, Dmitry Semyonov wrote: When I'm switching off the hintbar via Options-Layout, the hintbar text starts to appear at the upper left corner of Linux console. This bug may appear occasionally, but I've seen it twice (for root, and for conventional user) justs after clean installation of mc. ...Bye..Dmitry. ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [BUG] Hintbar switch off in 4.6.0-pre2
On Fri, 27 Dec 2002, Pavel Roskin wrote: On Fri, 27 Dec 2002, Dmitry Semyonov wrote: When I'm switching off the hintbar via Options-Layout, the hintbar text starts to appear at the upper left corner of Linux console. I cannot reproduce it. Please describe your terminal and the exact sequence of events. The terminal is Linux console. Remove .mc/ from your home directory. Run mc. F9, Options--Layout, uncheck 'Hintbar visible', Options--Save. ...Bye..Dmitry. ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [BUG(?)] Cannot learn keypad symbols in mc-4.6.0-pre2
On Fri, 27 Dec 2002, Pavel Roskin wrote: I am unable to learn keypad's '+', '-', and '*' in Linux console via 'Options--Learn keys' menu, while working under conventional user account. (Although the keys work as expected). I think the keys work as expected if the command line is empty. Run this command and type keypad plus, minus and asterisk. echo -ne '\e[?1h\e='; dd Either you get the keys as is or you get escape sequences. Try it both as root and as the normal user. I have no idea why it happens, but at least we'll know on which side it happens. Well, we're late a bit... Between the e-mail messages I've rebooted my machine, plus played a bit with Learn keys dialog. So, now I see that the problem is somehow disappeared. Presently, the output of dd command is the same for root and normal user: --- cut --- ^[Ol ^[OS ^[OR l S R 0+3 records in 0+1 records out --- cut --- If I'll encounter the same problem again, I'll immediately capture an output of the dd command. By the way, could you explain what does this echo -ne '\e[?1h\e=' mean? mc stops understanding of arrow keys after the command. Note that you can always use Alt with the key to force the group operation. Sorry, With what key? And what is group operation? May be I'm asking a silly questions, then just point me to documentation. Quick search in Google has not showed me any meaningful results. P.S. Just found how to reproduce the described problem: mc, Ctrl-O, mc, F9, 'Options-Learn keys', keypad's +-*. May be this was the source of my issue. I should be more accurate before rporting bugs. The type of user account is of no importance here, and may be this not a bug. Anyway, it looks confusing when second (inner) mc reacts on keypad's +-* as usual, but can't learn the keys via Learn keys dialog. ...Bye..Dmitry. ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [BUG] Disappearing of first line after Ctrl-Y
Hello, Andrew.
On Wed, 6 Nov 2002, Andrew V. Samoilov wrote:
Dmitry Semyonov wrote:
The patch for edit.c that fixes all the discribed problems is attached.
At the same time I think that 'Ctrl-Y F3' related bug was just shaded
out but not fixed.
At first your patch cannot be applied clearly because it is in DOS
format (carriage return before newline).
Strange, I don't see any 0x0D codes in the attached patch.
Also I cannot understand, why
you replace tabulation with spaces. It will be fine if you will use
indent -kr -i4 -psl -pcs for each function you change.
I don't use TAB's, and don't like TABbed sources since different people
may have different settings for the length of TAB character. I've seen
some source code (not mc) which was unreadable due to the fact, it was
written by different programmers who used 2, 4, and 8 spaces for TAB
length. Also, it is unhandy to resetup an editor for different sources.
But if mc sources have strictly defined coding style, I would like to
read it, and will follow it for possible mc contributions. I've just
read doc/DEVEL, and I guess a note about using of 'indent' utility is
only a recommendation, not the MUST USE rule.
BTW, why default script for external formatter uses different indent
arguments than defined in docs/DEVEL?
And your patch changes current behaviour of mcedit. ASCII zero is equal
to newline now. I cannot say I like this, but you should be consistent.
Now 0 is checked in the right part of the line, but this check is
ommited at the left.
Thanks for the comment.
I'm not familiar with mc sources, and by some reason I misleadingly
thought only EOF was checked on the right part.
BTW, edit_delete() returns 0 in the case of EOF, while edit_get_byte()
returns '\n' in the same case. Misleading code, isn't it?
New version of the patch, consistent and indented :-)
-
--- edit.c Wed Nov 6 19:27:17 2002
+++ edit.c.new Wed Nov 6 19:31:49 2002
@@ -1767,17 +1767,32 @@
}
}
-void edit_delete_line (WEdit * edit)
+void
+edit_delete_line (WEdit * edit)
{
-int c;
-do {
- c = edit_delete (edit);
-} while (c != '\n' c);
-do {
- c = edit_backspace (edit);
-} while (c != '\n' c);
-if (c)
- edit_insert (edit, '\n');
+/*
+ * Delete right part of the line.
+ * Note that edit_get_byte() returns '\n' when byte position is
+ * beyond EOF.
+ */
+while (edit_get_byte (edit, edit-curs1) != '\n') {
+ (void) edit_delete (edit);
+}
+
+/*
+ * Delete '\n' char.
+ * Note that edit_delete() will not corrupt anything if called while
+ * cursor position is EOF.
+ */
+(void) edit_delete (edit);
+
+/*
+ * Delete left part of the line.
+ * Note, that edit_get_byte() returns '\n' when byte position is 0.
+ */
+while (edit_get_byte (edit, edit-curs1 - 1) != '\n') {
+ (void) edit_backspace (edit);
+};
}
static void insert_spaces_tab (WEdit * edit, int half)
___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [BUG] Disappearing of first line after Ctrl-Y
Hello, Pavel. Thanks for the detailed description of possible ways to fix the bugs. I'll try to prepare simple patch at least for one of them later this week. ...Bye..Dmitry. ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
[BUG] Disappearing of first line after Ctrl-Y
Hello! Sometimes 1st (on the screen, not in file) line of edited text disappears after pressing Ctrl-Y (or Ctrl-Del) on it. (Cursor moves down in this case, and topmost line is to be updated with a line just before erased one, but it isn't sometimes.) I experienced the bug after making M-? search, and trying to edit found files. (BTW, it is not handy that found line is displayed at the topmost line of the screen. It would be better to have it somewhere after 1/3 part of the screen.) Actually I am not able to reproduce the bug every time exactly the same way as described (i.e. just pressing Ctrl-Y), but the first line is also cleared after Ctrl-Y F3 (and Ctrl-Y Ctrl-O Ctrl-O), and I think this is related to the original bug. (Note that Ctrl-Y is to be pressed on the first displayed line.) Configuration: Red Hat Linux release 7.2 (Enigma) Kernel 2.4.19 on an i686 $ mc --version bash: cd: GNU Midnight Commander 2002-10-25-22 Virtual File System: tarfs, extfs, cpiofs, ftpfs, fish With builtin Editor Using system-installed S-Lang library with terminfo database With subshell support as default With support for background operations With mouse support on xterm and Linux console With support for X11 events With multiple codepages support .: File name too long $ ...Bye..Dmitry. ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
File copy related bugs
Hello! I've just discovered some more bugs... 1. * 'Options-Configuration-Compute totals' and 'Options-Configuration-Verbose operation' are enabled. * BUG: totals are not computed when copying _single directory_ (if _two ore more dirs_ are copied, then all is ok). 2. * start copying of many files (actually, two dirs with many files) * press 'Skip' button during copying * choose some some answer for 'Incomplete file was retrieved. Keep it?' question. The copying continues after that. * BUG: press left/right arrows to highlight one or another button. You likely to see the same question again, although you have not activated the buttons. 3. Why copy dialog buttons are different for different 'Verbose operation' modes? I mean, 'Abort' button is not presented if 'Verbose operation' is disabled. Well, just found, that it is here actually, but not displayed, untill you press right arrow... Config: $ mc -V bash: cd: GNU Midnight Commander 2002-10-15-16 Virtual File System: tarfs, extfs, cpiofs, ftpfs, fish, undelfs With builtin Editor Using system-installed S-Lang library with terminfo database With subshell support as default With support for background operations With mouse support on xterm and Linux console With support for X11 events With multiple codepages support .: File name too long $ Red Hat Linux release 7.2 (Enigma) Kernel 2.4.19 on an i686 Linux console. ...Bye..Dmitry. ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
mc 4.6.0-pre1 documentation issues
Hi! 1. INSTALL and INSTALL.FAST refer to 'make mcfninstall' command for installing mc() function, but there is no such rule inside Makefile. I guess it is caled mcfn_install there. 2. INSTALL.FAST claims that Note that syntax highlighting in the editor is currently unavailable with ncurses.. On the other hand NEWS says Syntax highlighting now works with ncurses. ...Bye..Dmitry. ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
Re: DOS syntax script
Hello! On Tue, 25 Jun 2002, Petr Kozelka wrote: The tradition is that unknown words are not highlighted, the keywords are yellow, not white, and the comments are be brown. Applied with those changes. ok, np (however, brown on blue is not very easy to read - and comments are usually the most often read part of code) I agree with Petr. I've also changed some frequently used default syntax files. E.g. comments in C files are displayed in cyan. I know that this could be unimportant topic but: wouldn't it make sense to introduce some sort of categories that would be used instead of explicit colors ? This could make the higlighting better customizable. I appreciate this too. ...Bye..Dmitry. ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
