[PATCH] Proper names
Hello, Here is the patch that changes names to it proper version, like Red Hat, GNOME, GTK+. -- Best Regards Marcin Garski diff -ur mc-cvs-orig/ChangeLog mc-cvs/ChangeLog --- mc-cvs-orig/ChangeLog 2005-11-16 00:12:48.0 +0100 +++ mc-cvs/ChangeLog2005-12-20 20:38:04.0 +0100 @@ -365,7 +365,7 @@ 2004-10-20 Pavel S. Shirshov [EMAIL PROTECTED] - * lib/mc.ext.in: Use xmms for audio files in XWindows mode. + * lib/mc.ext.in: Use xmms for audio files in X Window mode. Add support for *.wma files. Add support for playlists. Partially based on patch from q# [EMAIL PROTECTED] @@ -1109,7 +1109,7 @@ 2002-10-08 Pavel Roskin [EMAIL PROTECTED] * configure.in: Rename RH_VERSION to RPM_VERSION - not every - rpm-based system is Red Hat. Replace all dashes, not just one. + rpm-based system is Red Hat Linux. Replace all dashes, not just one. * acinclude.m4 (MC_WITH_MCSLANG): Check for terminfo and use termcap if terminfo is missing in the known locations. @@ -1408,7 +1408,7 @@ now, otherwise Automake 1.5 breaks. Remove version number from AC_INIT, the version from AM_INIT_AUTOMAKE takes preference. Substitute RH_VERSION, which is VERSION without dashes, needed - for RedHat specfile. + for Red Hat Linux specfile. * configure.in: Bump version to 4.6.0-pre1a. Don't use arguments in AM_INIT_AUTOMAKE to avoid defining the version in @@ -2573,7 +2573,7 @@ * acconfig.h: Move constant parts ... * extraconf.h: ... here. - [HAVE_X]: Disable subshell, s-lang and curses. + [HAVE_X]: Disable subshell, S-Lang and curses. * Makefile.am: Add extraconf.h. 2001-05-28 Pavel Roskin [EMAIL PROTECTED] @@ -2858,7 +2858,7 @@ Uninstall them. * macros/gnome-gettext.m4: Propagated change by Owen Taylor - from acinclude.m4 in gtk+: + from acinclude.m4 in GTK+: Don't define ENABLE_NLS unless we have a working NLS. (This should keep libintl.h from being included when it doesn't exist). @@ -3171,7 +3171,7 @@ in the distclean target * doc-gnome/Makefile.in: Fixed some abuses of $(srcdir) - Removed all XVIEW-related stuff + Removed all XView-related stuff Fixed placement of png files on make dist * doc/mc.1.in: Updated info about the internal editor @@ -3499,7 +3499,7 @@ editwidget.c: bring editor stuff up to date with cooledit 3.11.5 This adds some new syntax rules, and spell check on the fly which if someone bugs me for, will actually get enabled in - both the text and gnome versions. Bookmark stuff also needs + both the text and GNOME versions. Bookmark stuff also needs some keys bound to it, I suppose: any takers? 1999-07-19 Elliot Lee [EMAIL PROTECTED] @@ -3894,7 +3894,7 @@ 1998-12-02 Miguel de Icaza [EMAIL PROTECTED] - * Makefile.in (codedirs): Dropped xv and tk ports from the + * Makefile.in (codedirs): Dropped xv and Tk ports from the distribution. include idl directory. 1998-12-01 Miguel de Icaza [EMAIL PROTECTED] diff -ur mc-cvs-orig/configure.ac mc-cvs/configure.ac --- mc-cvs-orig/configure.ac2005-11-11 03:03:55.0 +0100 +++ mc-cvs/configure.ac 2005-12-20 18:36:27.0 +0100 @@ -557,7 +557,7 @@ dnl Libraries used only when building the mc binary AC_SUBST(MCLIBS) -dnl Version for the RedHat package, without dashes +dnl Version for the Red Hat package, without dashes RPM_VERSION=`echo $VERSION | sed 's/-//g'` AC_SUBST(RPM_VERSION) diff -ur mc-cvs-orig/doc/pl/mc.1.in mc-cvs/doc/pl/mc.1.in --- mc-cvs-orig/doc/pl/mc.1.in 2004-08-17 10:41:53.0 +0200 +++ mc-cvs/doc/pl/mc.1.in 2005-12-20 18:33:06.0 +0100 @@ -2461,8 +2461,8 @@ i .IR loadkeys pl . [Zwróæ uwagê na to, ¿e te pliki s± charakterystyczne dla dystrybucji -RedHat, je¶li masz inn± i wiesz jak to ustawiæ, to napisz do mnie, a ja to -tu dopiszê [ patrz t³umacz na dole ;)) ]]. +Red Hat Linux, je¶li masz inn± i wiesz jak to ustawiæ, to napisz do +mnie, a ja to tu dopiszê [ patrz t³umacz na dole ;)) ]]. .PP Teraz wystarczy ju¿ tylko w³±czyæ odpowiednie opcje w menu opcji (klawisz F9). W menu opcji wybieramy diff -ur mc-cvs-orig/edit/ChangeLog mc-cvs/edit/ChangeLog --- mc-cvs-orig/edit/ChangeLog 2005-11-22 23:05:44.0 +0100 +++ mc-cvs/edit/ChangeLog 2005-12-20 18:44:24.0 +0100 @@ -1358,9 +1358,9 @@ * editcmd.c [!MIDNIGHT]: Undefine B_ENTER and B_CANCEL before redefining them. - * edit.h: Include sys/param.h if present. Include Gtk+ + * edit.h: Include sys/param.h if present. Include GTK+ headers as system headers. - * gtkedit.c: Include Gtk+ headers as system headers. + * gtkedit.c: Include GTK+ headers as system headers. 2001-08-18 Pavel Roskin [EMAIL PROTECTED] @@ -1527,7 +1527,7
Bug when copying/move file to deleted directory
1. cd /tmp mkdir dir mkdir dir/subdir touch dir/file.txt 2. cd dir mc 3. press Alt+o and in right panel cd into subdir 4. on left you should be in /tmp/dir on right in /tmp/dir/subdir 5. open second MC in new console, delete /tmp/dir/subdir 6. go back to first MC, in left panel selcet file.txt and copy or move it to directory in right panel (/tmp/dir/subdir) that don't exist 7. see what will happen (filename of file.txt will be changed to subdir) MC should report that /tmp/dir/subdir don't exist and it's immposible to copy/move file to it. Software: Fedora Core 4, mc-4.6.1a-0.13.FC4 -- Marcin Garski ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Memory leak in create_menu() (menu.c)
Hello I start playing with valgrind (so please don't bite me if this is my error (-: ), and I've found this leak (just run mc and press F10): ==7377== 13 bytes in 1 blocks are definitely lost in loss record 18 of 60 ==7377==at 0x1B909222: malloc (vg_replace_malloc.c:130) ==7377==by 0x1B954ADF: g_malloc (in /usr/lib/libglib-2.0.so.0.600.6) ==7377==by 0x1B966DAD: g_strdup (in /usr/lib/libglib-2.0.so.0.600.6) ==7377==by 0x807D2E1: create_menu (menu.c:62) ==7377==by 0x807ABE9: init_menu (main.c:939) ==7377==by 0x807B253: ??? (main.c:1391) ==7377==by 0x807C432: main (main.c:1762) As I see in create_menu() there is line (62) : menu-name = g_strdup (name); and then in line (145) you do: menu-name = g_strdup (name); But first name isn't free anywhere. So memory allocated by first g_strdup() is lost. Am I right? mc-4.6.1a-0.12.FC4 -- Marcin Garski ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Memory leak in create_menu() (menu.c)
As I see this bug is introduced by UTF-8 patch, so I'll file a bug in Red Hat's Bugzilla. Sorry for confusion. :| Just for note, patch adds two redundant lines: +menu-name = g_strdup (name); +menu_scan_hotkey (menu); -- Marcin Garski ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Memory leak in create_menu() (menu.c)
Marcin Garski wrote: As I see this bug is introduced by UTF-8 patch, so I'll file a bug in Red Hat's Bugzilla. Done. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169549 -- Marcin Garski ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Memory leaks
Hello, Maybe this time I'll properly report memory leaks :) ---1--- ==8620== 96 bytes in 8 blocks are definitely lost in loss record 80 of 108 ==8620==at 0x1B909222: malloc (vg_replace_malloc.c:130) ==8620==by 0x1B954ADF: g_malloc (in /usr/lib/libglib-2.0.so.0.600.6) ==8620==by 0x80B9A38: ??? (vfs.c:74) ==8620==by 0x80BA6A1: mc_open (vfs.c:345) ==8620==by 0x806A9A5: copy_file_file (file.c:624) ==8620==by 0x806CE77: panel_operate (file.c:1992) ==8620==by 0x805F6C9: copy_cmd (cmd.c:312) ==8620==by 0x8098185: ??? (widget.c:2473) ==8620==by 0x80657A8: dlg_process_event (dialog.c:606) ==8620==by 0x8065B90: run_dlg (dialog.c:777) ==8620==by 0x807C611: main (main.c:1692) --- ---2--- ==8620== 12 bytes in 1 blocks are definitely lost in loss record 46 of 108 ==8620==at 0x1B909222: malloc (vg_replace_malloc.c:130) ==8620==by 0x1BB162A8: re_search_stub (in /lib/libc-2.3.5.so) ==8620==by 0x1BB16558: re_match (in /lib/libc-2.3.5.so) ==8620==by 0x8069ED3: ??? (file.c:178) ==8620==by 0x806CD1D: panel_operate (file.c:1975) ==8620==by 0x805F6C9: copy_cmd (cmd.c:312) ==8620==by 0x8098185: ??? (widget.c:2473) ==8620==by 0x80657A8: dlg_process_event (dialog.c:606) ==8620==by 0x8065B90: run_dlg (dialog.c:777) ==8620==by 0x807C611: main (main.c:1692) --- mc-4.6.1a-0.12.FC4 (source can be downloaded form http://download.fedora.redhat.com/pub/fedora/linux/core/updates/4/SRPMS/mc-4.6.1a-0.12.FC4.src.rpm) This time I don't know what is wrong with code, maybe there aren't any bugs or I just don't know how to find them :) If you don't want to download source I could replace '???' by function name, but IMHO I could do something wrong (I don't know valgrind so good)?. -- Marcin Garski ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Memory leaks
Pavel Tsekov wrote: Maybe its about time stop playing valgrind and other tools you do not understand. In case you want to file a real bug report take your time and analyse the suspected code properly. Once you are sure that there is a real bug involved post your analisys to the general mailing list - mc at gnome dot org. Do you think that the only real bug reports that should be filed is the one with analisys of the suspected code? If I just spot the bug (not the exact source code line) I shouldn't write about it? See: http://bugzilla.gnome.org/show_bug.cgi?id=308546 Only report from valgrind and somehow it's a bug that has been fixed. Also see: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169549 This was a trivial bug where I could point bad source line, but a bug. There are also two guys on Red Hat's bugzilla that has reported a lot of bugs, that mostly the only text in bug report was a copypaste warning from gcc about probably uninitialized varibles. And a lot of this warnings where real bug that has been fixed. So if someone don't have enough time or knowledge to analyse bug he shouldn't mention about it? Back to my bug report :) Second leak COULD be caused by not freeing temp in panel_operate() (file.c), but I'm not shure if it's help because I've added g_free (temp) and valgrind still reports leak. -- Marcin Garski ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [BUG] Segmentation fault when copy symlink with checked Stable Symlinks
Jindrich Novy wrote: Marcin, could you please file a bug in bugzilla.redhat.com? The patch is comming soon. As you wish :) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=168184 Thanks for fixing the bug! -- Marcin Garski ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[BUG] Segmentation fault when copy symlink with checked Stable Symlinks
Hi, mc-4.6.1a-0.11.FC4 from Fedora Core 4 on x86_64. 1. Create mc directory 2. Change directory to mc 3. Create .eDonkey2000 directory 4. Create .overnet symlink pointing to .eDonkey2000 5. Copy .overnet symlink to /tmp BUT check Stable Symlinks in copy dialog. 6. Watch mc crash If you want more info, just write :) -- Best Regards Marcin Garski ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
MC bug?
Hello, 1. Open konsole (I'm using KDE so I've tried this only in konsole). 2. Start new session (in new tab) 3. Run 'mc' (in new tab) 4. Switch to previous session (i.e using Shift-left arrow) 5. Switch to session with mc (i.e using Shift-right arrow) 6. Look at command prompt Normaly prompt look like '[EMAIL PROTECTED] dir]$', when you do above steps prompt is different '[EMAIL PROTECTED] dir]$ [EMAIL PROTECTED] dir]$'. I don't know is this a MC bug, maybe ncurses, or something else. I'm using MC rpm (4.6.1a-20041215) from Fedora Core Devel tree under FC2. -- Marcin Garski ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
