Re: [PATCH] do not abort on broken .cpio file
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 02.11.2009 05:32, Enrico Weigelt wrote: * Denys Vlasenko vda.li...@googlemail.com schrieb: For example, you can have a rule that committer is responsible for that. If you have a few people in your team whom you trust that they are organized enough to always do a compile test and a basic run test before committing, then they may be entrusted in fast-forwarding trivial stuff. Right, we sometimes have things that are trivial enough, eg. #1692. I think, better way: agregate all these tickets into one simmary, like: http://www.midnight-commander.org/ticket/1674 Enrico, I think, for all 'Remove obsolete checks ...' stuff need to create summary ticket too. This will so easy to review and vote. *If* we have really blocking things, there will be discussions here, triggering faster reviews, IMHO. Yes, right. But no need to create ticket for any 'code cleanup'-like think ;) WBR, Slavaz. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkrvPrcACgkQb3oGR6aVLpob0QCeK+jW0GJUO2S8bLPbbsOoM7bn 5k0An2ELRYIrx0kiJvmsWABXEIq+ay7Y =xgIp -END PGP SIGNATURE- ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [PATCH] do not abort on broken .cpio file
On Sun, 2009-11-01 at 03:02 +0100, Denys Vlasenko wrote: This wastes your time. Maybe it makes sense to allow trivial fixes to be applied without going through this process? What are your suggestions on how would you track what, from where and WHY gets into master, who reviewed the code before submission and checked that it builds / does not introduce regressions then? I agree that it takes time, but it does not *waste* time, because afterward it makes much easier to figure out how and when a particular regression or bug was introduced. You think that your patch is trivial, but we have a record of one-liners introducing very weird and hard to find regressions. Sometimes it takes hours of bisecting to figure out what broke a particular feature... Therefore, if you want to spare us some time, you are asked to create a ticket in the tracker and attach your patches there, so that we won't have to do it for you. -- Sincerely yours, Yury V. Zaytsev ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [PATCH] do not abort on broken .cpio file
On Sunday 01 November 2009 11:59, Yury V. Zaytsev wrote: On Sun, 2009-11-01 at 03:02 +0100, Denys Vlasenko wrote: This wastes your time. Maybe it makes sense to allow trivial fixes to be applied without going through this process? What are your suggestions on how would you track what, from where and WHY gets into master, who reviewed the code before submission and checked that it builds / does not introduce regressions then? For example, you can have a rule that committer is responsible for that. If you have a few people in your team whom you trust that they are organized enough to always do a compile test and a basic run test before committing, then they may be entrusted in fast-forwarding trivial stuff. I agree that it takes time, but it does not *waste* time, because afterward it makes much easier to figure out how and when a particular regression or bug was introduced. You think that your patch is trivial, but we have a record of one-liners introducing very weird and hard to find regressions. Sometimes it takes hours of bisecting to figure out what broke a particular feature... Yep, happens all the time. Therefore, if you want to spare us some time, you are asked to create a ticket in the tracker and attach your patches there, so that we won't have to do it for you. Noted. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [PATCH] do not abort on broken .cpio file
* Denys Vlasenko vda.li...@googlemail.com schrieb: For example, you can have a rule that committer is responsible for that. If you have a few people in your team whom you trust that they are organized enough to always do a compile test and a basic run test before committing, then they may be entrusted in fast-forwarding trivial stuff. Right, we sometimes have things that are trivial enough, eg. #1692. BUT: those things tend to be not important enough to get merged ASAP, so it doesnt hurt to wait until others had a look at them. And: there still may be better solutions, so it's always a good idea to have more eyes looking over it first. *If* we have really blocking things, there will be discussions here, triggering faster reviews, IMHO. cu -- - Enrico Weigelt== metux IT service - http://www.metux.de/ - Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ - ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [PATCH] do not abort on broken .cpio file
On Thursday 15 October 2009 16:21, Denys Vlasenko wrote: For some reason, mc aborts if .cpio magic as wrong. This trivial patch makes mc handle it gracefully. Please apply. This is now fixed, thanks! I am a bit surprised that for such a trivial fix, you guys went to the trouble of creating a bug: http://www.midnight-commander.org/ticket/1725 and went through 7 changes in that bug. This wastes your time. Maybe it makes sense to allow trivial fixes to be applied without going through this process? Just a sugeestion, feel free to disregard. -- vda ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [PATCH] do not abort on broken .cpio file
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 15.10.2009 17:21, Denys Vlasenko wrote: For some reason, mc aborts if .cpio magic as wrong. This trivial patch makes mc handle it gracefully. Please apply. Patch now in tracker: http://www.midnight-commander.org/ticket/1725 Thank for contribute. WBR, Slavaz. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkrYsZgACgkQb3oGR6aVLpoy0gCfSfEwtBntn0AbmT17vUxPeXCj LnUAmwdKDM/ERERYTZ4RvMN5NIrhtwhN =SvYd -END PGP SIGNATURE- ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[PATCH] do not abort on broken .cpio file
For some reason, mc aborts if .cpio magic as wrong. This trivial patch makes mc handle it gracefully. Please apply. -- vda fix_abort_on_cpio.patch Description: Binary data ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
