[MediaWiki-commits] [Gerrit] Fix loading subtitles via ForeignDBViaLBRepo - change (mediawiki...TimedMediaHandler[master])
J has uploaded a new change for review. Change subject: Fix loading subtitles via ForeignDBViaLBRepo .. Fix loading subtitles via ForeignDBViaLBRepo Change-Id: Ifc0c1be0210875a72e5ce8aec3199eb7100b518c --- M handlers/TextHandler/TextHandler.php 1 file changed, 37 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler refs/changes/85/16885/1 -- To view, visit https://gerrit.wikimedia.org/r/16885 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifc0c1be0210875a72e5ce8aec3199eb7100b518c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: J ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add autonumbering to #subobjects - change (mediawiki...SemanticMediaWiki[master])
Mwjames has uploaded a new change for review. Change subject: Add autonumbering to #subobjects .. Add autonumbering to #subobjects This change will add an autonumbering feature for all subobjects that don't come with there own idenifier/name. Right now it is for all cases of $subobjectName === '' but one could force the user to $subobjectName === '#' to state explicitly to use autonumbering in either case this takes away huge burden with larger data sets where up til now each had to be assigned his own identifier. Change-Id: I076c323159c38d622dd15d1dc970a5bfea584906 --- M includes/parserhooks/SMW_Subobject.php 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/84/16884/1 -- To view, visit https://gerrit.wikimedia.org/r/16884 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I076c323159c38d622dd15d1dc970a5bfea584906 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Mwjames ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] change api provider default name to wikimediacommons - change (mediawiki...TimedMediaHandler[master])
J has submitted this change and it was merged. Change subject: change api provider default name to wikimediacommons .. change api provider default name to wikimediacommons Change-Id: I0eae3e3ac3e6b8b7937bd482d3b18aa89354d0f6 --- M TimedMediaTransformOutput.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: J: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16882 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0eae3e3ac3e6b8b7937bd482d3b18aa89354d0f6 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: Mdale Gerrit-Reviewer: J Gerrit-Reviewer: Mdale ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] change api provider default name to wikimediacommons - change (mediawiki...TimedMediaHandler[master])
Mdale has uploaded a new change for review. Change subject: change api provider default name to wikimediacommons .. change api provider default name to wikimediacommons Change-Id: I0eae3e3ac3e6b8b7937bd482d3b18aa89354d0f6 --- M TimedMediaTransformOutput.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler refs/changes/82/16882/1 -- To view, visit https://gerrit.wikimedia.org/r/16882 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0eae3e3ac3e6b8b7937bd482d3b18aa89354d0f6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: Mdale ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] fixed timed text redirect page for external files - change (mediawiki...TimedMediaHandler[master])
J has submitted this change and it was merged. Change subject: fixed timed text redirect page for external files .. fixed timed text redirect page for external files Change-Id: I229df7a98872c8e4708fcc7dd0c16e1a3fd0a047 --- M TimedTextPage.php 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: J: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16881 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I229df7a98872c8e4708fcc7dd0c16e1a3fd0a047 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: Mdale Gerrit-Reviewer: J ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] fixed timed text redirect page for external files - change (mediawiki...TimedMediaHandler[master])
Mdale has uploaded a new change for review. Change subject: fixed timed text redirect page for external files .. fixed timed text redirect page for external files Change-Id: I229df7a98872c8e4708fcc7dd0c16e1a3fd0a047 --- M TimedTextPage.php 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler refs/changes/81/16881/1 -- To view, visit https://gerrit.wikimedia.org/r/16881 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I229df7a98872c8e4708fcc7dd0c16e1a3fd0a047 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: Mdale ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] fixed commons default provider name, fixed local vs remote a... - change (mediawiki...MwEmbedSupport[master])
J has submitted this change and it was merged. Change subject: fixed commons default provider name, fixed local vs remote api query .. fixed commons default provider name, fixed local vs remote api query Change-Id: I8a4166e746de22dea57a404d02cc6fd8ba7aeeef --- M MwEmbedModules/MediaWikiSupport/MediaWikiSupport.config.php M MwEmbedModules/MediaWikiSupport/resources/mw.Api.js 2 files changed, 13 insertions(+), 10 deletions(-) Approvals: J: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16880 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a4166e746de22dea57a404d02cc6fd8ba7aeeef Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/MwEmbedSupport Gerrit-Branch: master Gerrit-Owner: Mdale Gerrit-Reviewer: J Gerrit-Reviewer: Mdale ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixes remote timed text support for cross wiki embedding - change (mediawiki...TimedMediaHandler[master])
J has submitted this change and it was merged. Change subject: Fixes remote timed text support for cross wiki embedding .. Fixes remote timed text support for cross wiki embedding Change-Id: If380b63ff32d39fb533405277dfde33497dc2303 --- M ApiQueryVideoInfo.php M MwEmbedModules/EmbedPlayer/resources/mw.MediaSource.js M MwEmbedModules/TimedText/resources/mw.TextSource.js M MwEmbedModules/TimedText/resources/mw.TimedText.js M TimedMediaTransformOutput.php M WebVideoTranscode/WebVideoTranscode.php M handlers/TextHandler/TextHandler.php M resources/mw.MediaWikiPlayerSupport.js 8 files changed, 145 insertions(+), 52 deletions(-) Approvals: J: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16879 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If380b63ff32d39fb533405277dfde33497dc2303 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: Mdale Gerrit-Reviewer: J Gerrit-Reviewer: Mdale ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixes remote timed text support for cross wiki embedding - change (mediawiki...TimedMediaHandler[master])
Mdale has uploaded a new change for review. Change subject: Fixes remote timed text support for cross wiki embedding .. Fixes remote timed text support for cross wiki embedding Change-Id: If380b63ff32d39fb533405277dfde33497dc2303 --- M ApiQueryVideoInfo.php M MwEmbedModules/EmbedPlayer/resources/mw.MediaSource.js M MwEmbedModules/TimedText/resources/mw.TextSource.js M MwEmbedModules/TimedText/resources/mw.TimedText.js M TimedMediaTransformOutput.php M WebVideoTranscode/WebVideoTranscode.php M handlers/TextHandler/TextHandler.php M resources/mw.MediaWikiPlayerSupport.js 8 files changed, 146 insertions(+), 53 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler refs/changes/79/16879/1 -- To view, visit https://gerrit.wikimedia.org/r/16879 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If380b63ff32d39fb533405277dfde33497dc2303 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: Mdale ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] fix syntax - change (mediawiki...TimedMediaHandler[master])
J has submitted this change and it was merged. Change subject: fix syntax .. fix syntax Change-Id: I3ff87855bfd8e93aedb459953383acd4db8dd562 --- M maintenance/cleanupUnusedTranscodes.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: J: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16878 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ff87855bfd8e93aedb459953383acd4db8dd562 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: J Gerrit-Reviewer: J ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use 360p WebM for small version - change (mediawiki...TimedMediaHandler[master])
J has submitted this change and it was merged. Change subject: Use 360p WebM for small version .. Use 360p WebM for small version There are many videos on commons that would otherwise default to 160p Change-Id: Ia0442beab5070267ea1a6c32601e55e8e18dbea5 --- M TimedMediaHandler.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mdale: Looks good to me, but someone else must approve J: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16876 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0442beab5070267ea1a6c32601e55e8e18dbea5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: J Gerrit-Reviewer: J Gerrit-Reviewer: Mdale ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] add option to remove all encodes with one key - change (mediawiki...TimedMediaHandler[master])
J has submitted this change and it was merged. Change subject: add option to remove all encodes with one key .. add option to remove all encodes with one key Change-Id: I00da4bc61d9ad59f006ff6ce6362372a5c2f6405 --- M maintenance/cleanupUnusedTranscodes.php 1 file changed, 11 insertions(+), 6 deletions(-) Approvals: Mdale: Looks good to me, but someone else must approve J: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16877 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00da4bc61d9ad59f006ff6ce6362372a5c2f6405 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: J Gerrit-Reviewer: J Gerrit-Reviewer: Mdale ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] add option to remove all encodes with one key - change (mediawiki...TimedMediaHandler[master])
J has uploaded a new change for review. Change subject: add option to remove all encodes with one key .. add option to remove all encodes with one key Change-Id: I00da4bc61d9ad59f006ff6ce6362372a5c2f6405 --- M maintenance/cleanupUnusedTranscodes.php 1 file changed, 11 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler refs/changes/77/16877/1 -- To view, visit https://gerrit.wikimedia.org/r/16877 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I00da4bc61d9ad59f006ff6ce6362372a5c2f6405 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: J ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use 360p WebM for small version - change (mediawiki...TimedMediaHandler[master])
J has uploaded a new change for review. Change subject: Use 360p WebM for small version .. Use 360p WebM for small version There are many videos on commons that would otherwise default to 160p Change-Id: Ia0442beab5070267ea1a6c32601e55e8e18dbea5 --- M TimedMediaHandler.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler refs/changes/76/16876/1 -- To view, visit https://gerrit.wikimedia.org/r/16876 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia0442beab5070267ea1a6c32601e55e8e18dbea5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: J ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fatal error at http://test.wikipedia.beta.wmflabs.org/ There... - change (operations/mediawiki-config[master])
Platonides has uploaded a new change for review. Change subject: Fatal error at http://test.wikipedia.beta.wmflabs.org/ There's no extensions/E3Experiments/Experiments.php .. Fatal error at http://test.wikipedia.beta.wmflabs.org/ There's no extensions/E3Experiments/Experiments.php Change-Id: Ib23399f35c623a264113ef6c018ffd5ad3ef3b4b --- M wmf-config/InitialiseSettings-wmflabs.php 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/75/16875/1 -- To view, visit https://gerrit.wikimedia.org/r/16875 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib23399f35c623a264113ef6c018ffd5ad3ef3b4b Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Platonides ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add Special:TimedMediaHandler - change (mediawiki...TimedMediaHandler[master])
J has submitted this change and it was merged. Change subject: Add Special:TimedMediaHandler .. Add Special:TimedMediaHandler special page with some statistics and currently running jobs Change-Id: Ifafa486efdcd06113923e7789e67a49ce4573106 --- A SpecialTimedMediaHandler.php M TimedMediaHandler.i18n.php M TimedMediaHandler.php 3 files changed, 209 insertions(+), 0 deletions(-) Approvals: Mdale: Looks good to me, but someone else must approve J: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16868 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifafa486efdcd06113923e7789e67a49ce4573106 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: J Gerrit-Reviewer: J Gerrit-Reviewer: Mdale ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] fix cleanup after moving files - change (mediawiki...TimedMediaHandler[master])
J has submitted this change and it was merged. Change subject: fix cleanup after moving files .. fix cleanup after moving files Change-Id: Ifd257ed8b64abe5d5f4b6519944630b23facd920 --- M TimedMediaHandler.hooks.php 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Mdale: Looks good to me, but someone else must approve J: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16861 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd257ed8b64abe5d5f4b6519944630b23facd920 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: J Gerrit-Reviewer: J Gerrit-Reviewer: Mdale ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update jquery.qunit from upstream v1.8.0 to v1.9.0 - change (mediawiki/core[master])
Catrope has submitted this change and it was merged. Change subject: Update jquery.qunit from upstream v1.8.0 to v1.9.0 .. Update jquery.qunit from upstream v1.8.0 to v1.9.0 * Upstream https://github.com/jquery/qunit.git - tag: v1.9.0 - tree: https://github.com/jquery/qunit/tree/v1.9.0 - commit: https://github.com/jquery/qunit/commit/e36f17de98b2813df25ef8d3a504139f488971d2 * Also update our testrunner.js since the format of QUnit.config.urlConfig has changed (it is still backwards compatible, but we might as well use the new format right away, as it makes the checkboxes look better). Change-Id: Ia5a9eb7a40a438c126879497ec0dbecbb72e0edb --- M resources/jquery/jquery.qunit.css M resources/jquery/jquery.qunit.js M tests/qunit/data/testrunner.js 3 files changed, 119 insertions(+), 47 deletions(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/16864 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5a9eb7a40a438c126879497ec0dbecbb72e0edb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Krinkle Gerrit-Reviewer: Catrope Gerrit-Reviewer: Trevor Parscal Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add maintenance script to cleanup unused transcodes - change (mediawiki...TimedMediaHandler[master])
J has submitted this change and it was merged. Change subject: Add maintenance script to cleanup unused transcodes .. Add maintenance script to cleanup unused transcodes add script to remove transcodes no longer used Change-Id: I781e09a1e589caf723ad1d11ef443fd5e4db0302 --- A maintenance/cleanupUnusedTranscodes.php 1 file changed, 37 insertions(+), 0 deletions(-) Approvals: Mdale: Looks good to me, but someone else must approve J: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16870 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I781e09a1e589caf723ad1d11ef443fd5e4db0302 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: J Gerrit-Reviewer: J Gerrit-Reviewer: Mdale ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Switching priorities to text labels - change (mediawiki...CentralNotice[master])
Kaldari has uploaded a new change for review. Change subject: Switching priorities to text labels .. Switching priorities to text labels Change-Id: Ia46e62c8fa6e34d91b74e5c0722714fdc25dc5df --- M CentralNotice.db.php M CentralNotice.i18n.php M CentralNotice.sql M centralnotice.css A patches/patch-notice_preferred2.sql M special/SpecialBannerAllocation.php M special/SpecialBannerController.php M special/SpecialBannerListLoader.php M special/SpecialCentralNotice.php 9 files changed, 94 insertions(+), 60 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice refs/changes/71/16871/1 -- To view, visit https://gerrit.wikimedia.org/r/16871 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia46e62c8fa6e34d91b74e5c0722714fdc25dc5df Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Kaldari ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add maintenance script to cleanup unused transcodes - change (mediawiki...TimedMediaHandler[master])
J has uploaded a new change for review. Change subject: Add maintenance script to cleanup unused transcodes .. Add maintenance script to cleanup unused transcodes add script to remove transcodes no longer used Change-Id: I781e09a1e589caf723ad1d11ef443fd5e4db0302 --- A maintenance/cleanupUnusedTranscodes.php 1 file changed, 37 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler refs/changes/70/16870/1 -- To view, visit https://gerrit.wikimedia.org/r/16870 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I781e09a1e589caf723ad1d11ef443fd5e4db0302 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: J ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Provide parameters for setting the min/max length of the cap... - change (mediawiki...ConfirmEdit[master])
Platonides has uploaded a new change for review. Change subject: Provide parameters for setting the min/max length of the captcha "word" (challenge). .. Provide parameters for setting the min/max length of the captcha "word" (challenge). Change-Id: Ic2968cec884534dfa8ae7479589a1622a4db7de0 --- M captcha.py 1 file changed, 19 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ConfirmEdit refs/changes/69/16869/1 -- To view, visit https://gerrit.wikimedia.org/r/16869 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic2968cec884534dfa8ae7479589a1622a4db7de0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ConfirmEdit Gerrit-Branch: master Gerrit-Owner: Platonides ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add Special:TimedMediaHandler - change (mediawiki...TimedMediaHandler[master])
J has uploaded a new change for review. Change subject: Add Special:TimedMediaHandler .. Add Special:TimedMediaHandler special page with some statistics and currently running jobs Change-Id: Ifafa486efdcd06113923e7789e67a49ce4573106 --- A SpecialTimedMediaHandler.php M TimedMediaHandler.i18n.php M TimedMediaHandler.php 3 files changed, 208 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler refs/changes/68/16868/1 -- To view, visit https://gerrit.wikimedia.org/r/16868 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifafa486efdcd06113923e7789e67a49ce4573106 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: J ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Register QUnit tests suites in MediaWiki to run from Special... - change (mediawiki...VisualEditor[master])
Krinkle has uploaded a new change for review. Change subject: Register QUnit tests suites in MediaWiki to run from Special:JavaScriptTest .. Register QUnit tests suites in MediaWiki to run from Special:JavaScriptTest * Also update test/index.html with latest minimalistic format * Update test suite hardcoded paths to match the definition in VisualEditor.php for ResourceLoader * Issues: - 'jquery/jquery.json.js' should not be loaded directly, using a dependency instead. - Load scripts from the in test/index.html so that code that depends on document being ready is catches instead of silently being ignored. Change-Id: I5ad7390137f4d17c153a1bf69f19c4869c08e323 --- M VisualEditor.php M modules/ve/test/index.html 2 files changed, 37 insertions(+), 38 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/67/16867/1 -- To view, visit https://gerrit.wikimedia.org/r/16867 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5ad7390137f4d17c153a1bf69f19c4869c08e323 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Krinkle ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add hints to comment of ApiBase::needsToken/getTokenSalt - change (mediawiki/core[master])
Aaron Schulz has submitted this change and it was merged. Change subject: Add hints to comment of ApiBase::needsToken/getTokenSalt .. Add hints to comment of ApiBase::needsToken/getTokenSalt Change-Id: I7141256527aaff5496ac4e163199c947fb27fed0 --- M includes/api/ApiBase.php 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Aaron Schulz: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/16815 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7141256527aaff5496ac4e163199c947fb27fed0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender Gerrit-Reviewer: Aaron Schulz Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Replace hard coded parentheses - change (mediawiki/core[master])
Aaron Schulz has submitted this change and it was merged. Change subject: Replace hard coded parentheses .. Replace hard coded parentheses Change-Id: I8ca697a3bdae4f693b626f2d2da15ad28dce937d --- M includes/diff/DifferenceEngine.php 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Aaron Schulz: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/16823 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ca697a3bdae4f693b626f2d2da15ad28dce937d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Liangent Gerrit-Reviewer: Aaron Schulz Gerrit-Reviewer: Nikerabbit Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Refactor out LinkBatch related query building - change (mediawiki/core[master])
Aaron Schulz has submitted this change and it was merged. Change subject: Refactor out LinkBatch related query building .. Refactor out LinkBatch related query building Some minor refactoring of SpecialDisambiguations to reduce the amount of copy pasted code in ProofreadPage extensions special page SpecialPagesWithoutScans Change-Id: I41c8613b6f8c235809b51a5e00cdfa0775e5d733 --- M includes/specials/SpecialDisambiguations.php 1 file changed, 44 insertions(+), 19 deletions(-) Approvals: Aaron Schulz: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/15895 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41c8613b6f8c235809b51a5e00cdfa0775e5d733 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Reedy Gerrit-Reviewer: Aaron Schulz Gerrit-Reviewer: Hashar Gerrit-Reviewer: Jeroen De Dauw Gerrit-Reviewer: Reedy Gerrit-Reviewer: Tpt Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove the skipcaptcha rifht from autoconfirmed users in lab... - change (operations/mediawiki-config[master])
Platonides has uploaded a new change for review. Change subject: Remove the skipcaptcha rifht from autoconfirmed users in labs, for easy captcha testing. .. Remove the skipcaptcha rifht from autoconfirmed users in labs, for easy captcha testing. Change-Id: I269482f714a99645cfcad8d8dba7eeb9c38c03f8 --- M wmf-config/CommonSettings-wmflabs.php 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/66/16866/1 -- To view, visit https://gerrit.wikimedia.org/r/16866 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I269482f714a99645cfcad8d8dba7eeb9c38c03f8 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Platonides ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Move ve.init and ve.init.Platform to the base module, where ... - change (mediawiki...VisualEditor[master])
Krinkle has submitted this change and it was merged. Change subject: Move ve.init and ve.init.Platform to the base module, where they belong .. Move ve.init and ve.init.Platform to the base module, where they belong Change-Id: I4547bbaa784401a6ca158daac787af23b50715c7 --- M VisualEditor.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Krinkle: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16863 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4547bbaa784401a6ca158daac787af23b50715c7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Catrope Gerrit-Reviewer: Krinkle ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update jquery.qunit from upstream v1.8.0 to v1.9.0 - change (mediawiki/core[master])
Krinkle has uploaded a new change for review. Change subject: Update jquery.qunit from upstream v1.8.0 to v1.9.0 .. Update jquery.qunit from upstream v1.8.0 to v1.9.0 * Upstream https://github.com/jquery/qunit.git - tag: v1.9.0 - tree: https://github.com/jquery/qunit/tree/v1.9.0 - commit: https://github.com/jquery/qunit/commit/e36f17de98b2813df25ef8d3a504139f488971d2 * Also update our testrunner.js since the format of QUnit.config.urlConfig has changed (it is still backwards compatible, but we might as well use the new format right away, as it makes the checkboxes look better). Change-Id: Ia5a9eb7a40a438c126879497ec0dbecbb72e0edb --- M resources/jquery/jquery.qunit.css M resources/jquery/jquery.qunit.js M tests/qunit/data/testrunner.js 3 files changed, 119 insertions(+), 47 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/64/16864/1 -- To view, visit https://gerrit.wikimedia.org/r/16864 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia5a9eb7a40a438c126879497ec0dbecbb72e0edb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Krinkle ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added point in release notes about added ORM stuffs - change (mediawiki/core[master])
Aaron Schulz has submitted this change and it was merged. Change subject: Added point in release notes about added ORM stuffs .. Added point in release notes about added ORM stuffs Change-Id: I8ca78ecf93092b62564675c4183a635265ae8f38 --- M RELEASE-NOTES-1.20 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Aaron Schulz: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/16231 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ca78ecf93092b62564675c4183a635265ae8f38 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: Aaron Schulz Gerrit-Reviewer: Reedy Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Switching priorities to text labels. - change (mediawiki...CentralNotice[master])
Kaldari has uploaded a new change for review. Change subject: Switching priorities to text labels. .. Switching priorities to text labels. Change-Id: I130722de980c5a2b7e1d0d124f8fe6f70eeefa3a --- M CentralNotice.db.php M CentralNotice.i18n.php M CentralNotice.sql M centralnotice.css A patches/patch-notice_preferred2.sql M special/SpecialBannerAllocation.php M special/SpecialBannerController.php M special/SpecialBannerListLoader.php M special/SpecialCentralNotice.php 9 files changed, 93 insertions(+), 59 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice refs/changes/62/16862/1 -- To view, visit https://gerrit.wikimedia.org/r/16862 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I130722de980c5a2b7e1d0d124f8fe6f70eeefa3a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Kaldari ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mark WikitextContent tests as requiring database - change (mediawiki/core[Wikidata])
Aaron Schulz has submitted this change and it was merged. Change subject: mark WikitextContent tests as requiring database .. mark WikitextContent tests as requiring database Some of the WikitextContent tests require a database connection which breaks the databaseless PHPUnit test job. Change-Id: Ia78d22763bffc11a7f66a50ae67bc340939366b9 --- M tests/phpunit/includes/WikitextContentTest.php 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Aaron Schulz: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/16854 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia78d22763bffc11a7f66a50ae67bc340939366b9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: Wikidata Gerrit-Owner: Hashar Gerrit-Reviewer: Aaron Schulz Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Escaping WikiLove recipient names in the inputs. - change (mediawiki...PageTriage[master])
Bsitu has submitted this change and it was merged. Change subject: Escaping WikiLove recipient names in the inputs. .. Escaping WikiLove recipient names in the inputs. Change-Id: I8637695eef9b92f5118410f5d289bfebf507a195 --- M modules/ext.pageTriage.views.toolbar/ext.pageTriage.wikilove.js 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Bsitu: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16860 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8637695eef9b92f5118410f5d289bfebf507a195 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/PageTriage Gerrit-Branch: master Gerrit-Owner: Kaldari Gerrit-Reviewer: Bsitu ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Escaping WikiLove recipient names in the inputs. - change (mediawiki...PageTriage[master])
Kaldari has uploaded a new change for review. Change subject: Escaping WikiLove recipient names in the inputs. .. Escaping WikiLove recipient names in the inputs. Change-Id: I8637695eef9b92f5118410f5d289bfebf507a195 --- M modules/ext.pageTriage.views.toolbar/ext.pageTriage.wikilove.js 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageTriage refs/changes/60/16860/1 -- To view, visit https://gerrit.wikimedia.org/r/16860 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8637695eef9b92f5118410f5d289bfebf507a195 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/PageTriage Gerrit-Branch: master Gerrit-Owner: Kaldari ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Echo: Implement advanced notifications for vanilla talk page... - change (mediawiki...Echo[master])
Werdna has uploaded a new change for review. Change subject: Echo: Implement advanced notifications for vanilla talk pages. .. Echo: Implement advanced notifications for vanilla talk pages. Uses the class EchoDiscussionParser to understand actions taken on vanilla MediaWiki discussion pages. Currently notifies on these occasions: * A new comment is added to a discussion on your talk page or that you have participated in. * A new topic is added to your talk page. There are vague plans to expand to these classes of events: * Your comment is edited or removed. * A large section is moved to your talk page. and these classes of users: * Users watching discussion pages. Change-Id: Ie6cae76ed2e0ecf607059e39ac1aa480a275ec89 --- M Echo.i18n.php M Echo.php M Hooks.php A db_patches/patch-event_extra-size.sql M echo.sql A formatters/CommentFormatter.php M formatters/NotificationFormatter.php A includes/DiscussionParser.php A testDiscussionParser.php 9 files changed, 896 insertions(+), 20 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo refs/changes/59/16859/1 -- To view, visit https://gerrit.wikimedia.org/r/16859 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie6cae76ed2e0ecf607059e39ac1aa480a275ec89 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Echo Gerrit-Branch: master Gerrit-Owner: Werdna ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Flag MW-specific code in LinkInspector - change (mediawiki...VisualEditor[master])
Trevor Parscal has submitted this change and it was merged. Change subject: Flag MW-specific code in LinkInspector .. Flag MW-specific code in LinkInspector Change-Id: I1a85c4c9f5ca0522c2d5491993fad7f05d3a1203 --- M modules/ve/ui/inspectors/ve.ui.LinkInspector.js 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Trevor Parscal: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16597 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a85c4c9f5ca0522c2d5491993fad7f05d3a1203 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Catrope Gerrit-Reviewer: Catrope Gerrit-Reviewer: Trevor Parscal ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding wlm.wikimedia.org to site.pp - change (operations/puppet[production])
awjrichards has uploaded a new change for review. Change subject: Adding wlm.wikimedia.org to site.pp .. Adding wlm.wikimedia.org to site.pp Change-Id: Ib17ee22f6667402ccd0e115c294fa18696ccbfa8 --- M manifests/site.pp 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/58/16858/1 -- To view, visit https://gerrit.wikimedia.org/r/16858 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib17ee22f6667402ccd0e115c294fa18696ccbfa8 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: awjrichards ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bug 36200 - VisualEditor: Sticky selection popup - change (mediawiki...VisualEditor[master])
Trevor Parscal has submitted this change and it was merged. Change subject: Bug 36200 - VisualEditor: Sticky selection popup .. Bug 36200 - VisualEditor: Sticky selection popup Clearing context icon when editor loses focus. -Reproduce problem by selecting text, then click outside of the editor. Selection is lost, and context icon is stuck. Change-Id: I4b321f16cea73ec0e51540c0e71f265ab47514e9 --- M modules/ve/ce/ve.ce.Surface.js 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Trevor Parscal: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16794 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b321f16cea73ec0e51540c0e71f265ab47514e9 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Robmoen Gerrit-Reviewer: Robmoen Gerrit-Reviewer: Trevor Parscal ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed the following bugs with save dialog. - change (mediawiki...VisualEditor[master])
Trevor Parscal has submitted this change and it was merged. Change subject: Fixed the following bugs with save dialog. .. Fixed the following bugs with save dialog. -Bug 38042 Save dialog description field doesn't respond to 'Enter' or 'Return' keys -Bug 38621 Pressing 'Esc' in Save-dialog should exit saving, return to editor Change-Id: I9c43c6c9f2f2b538becc4fbbce1eda6e918d4879 --- M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js 1 file changed, 23 insertions(+), 0 deletions(-) Approvals: Trevor Parscal: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16782 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c43c6c9f2f2b538becc4fbbce1eda6e918d4879 Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Robmoen Gerrit-Reviewer: Catrope Gerrit-Reviewer: Robmoen Gerrit-Reviewer: Trevor Parscal ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Kranitor #1: On-boarding - change (mediawiki...VisualEditor[master])
Trevor Parscal has submitted this change and it was merged. Change subject: Kranitor #1: On-boarding .. Kranitor #1: On-boarding '''Kranitor commits''' are commits by Krinkle with his janitor hat on. Must never contain functional changes mixed with miscellaneous changes. .gitignore: * Add .DS_Store to the ignore list so that browsing the directories on Mac OS X, will not add these files to the list of untracked files. * Fix missing newline at end of file .jshintrc * raises -> throws * +module (QUnit.module) * remove 'Node' (as of node-jshint 1.7.2 this is now part of 'browser:true', as it should be) Authors: * Adding myself MWExtension/VisualEditor.php * Fix default value of wgVisualEditorParsoidURL to not point to the experimental instance in WMF Labs. Issues: * ve.ce.TextNode: - Fix TODO: Don't perform a useless clone of an already-jQuerified object. - Use .html() to set html content instead of encapsulating between two strings. This is slightly faster but more importantly safer, and prevents situations where the resulting jQuery collection actually contains 2 elements instead of 1, thus messing up what .contents() is iterating over. * ve.ce.Document.test.js - Fix: ReferenceError: assert is not defined * ve.dm.Document.test.js - Fix: ReferenceError: assert is not defined * ve.dm.Transaction.test.js - Fix: ReferenceError: assert is not defined * ve.dm.TransactionProcessor.test.js - Fix: ReferenceError: assert is not defined * ext.visualEditor.viewPageTarget - Missing dependency on 'mediawiki.Title' Code conventions / Misc cleanup * Various JSHint warnings. * Whitespace * jQuery(): Use '' for element creation, use '' for parsing * Use the default operator instead of ternary when the condition and first value are the same. x = foo ? foo : bar; -> x = foo || bar; Because contrary to some programming language (PHP...), in JS the default operator does not enforce a boolean result but returns the original value, hence it being called the 'default' operator, as opposed to the 'or' operator. * No need to call addClass() twice, it takes a space-separated list (jQuery splits by space and adds if needed) * Use .on( event[, selector], fn ) instead of the deprecated routers to it such as .bind(), .delegate() and .live(). All these three are now built-in and fully compatible with .on() * Add 'XXX:' comments for suspicious code that I don't want to change as part of a clean up commit. * Remove unused variables (several var x = this; where x was not used anywhere, possibly from boilerplate copy/paste) * Follows-up Trevor's commit that converts test suites to the new QUnit format. Also removed the globals since we no longer use those any more. Change-Id: I7e37c9bff812e371c7f65a6fd85d9e2af3e0a22f --- M .gitignore M .jshintrc M AUTHORS.txt M VisualEditor.php M modules/ve/ce/nodes/ve.ce.TextNode.js M modules/ve/ce/ve.ce.Surface.js M modules/ve/dm/ve.dm.BranchNode.js M modules/ve/dm/ve.dm.DocumentSynchronizer.js M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js M modules/ve/test/ce/nodes/ve.ce.TextNode.test.js M modules/ve/test/ce/ve.ce.BranchNode.test.js M modules/ve/test/ce/ve.ce.Document.test.js M modules/ve/test/ce/ve.ce.LeafNode.test.js M modules/ve/test/ce/ve.ce.Node.test.js M modules/ve/test/ce/ve.ce.NodeFactory.test.js M modules/ve/test/ce/ve.ce.test.js M modules/ve/test/dm/nodes/ve.dm.TextNode.test.js M modules/ve/test/dm/ve.dm.BranchNode.test.js M modules/ve/test/dm/ve.dm.Converter.test.js M modules/ve/test/dm/ve.dm.Document.test.js M modules/ve/test/dm/ve.dm.DocumentSynchronizer.test.js M modules/ve/test/dm/ve.dm.LeafNode.test.js M modules/ve/test/dm/ve.dm.Node.test.js M modules/ve/test/dm/ve.dm.NodeFactory.test.js M modules/ve/test/dm/ve.dm.Surface.test.js M modules/ve/test/dm/ve.dm.Transaction.test.js M modules/ve/test/dm/ve.dm.TransactionProcessor.test.js M modules/ve/test/ve.BranchNode.test.js M modules/ve/test/ve.Document.test.js M modules/ve/test/ve.Factory.test.js M modules/ve/test/ve.Node.test.js M modules/ve/test/ve.qunit.js M modules/ve/ui/inspectors/ve.ui.LinkInspector.js M modules/ve/ui/tools/ve.ui.ButtonTool.js M modules/ve/ui/tools/ve.ui.ClearButtonTool.js M modules/ve/ui/tools/ve.ui.DropdownTool.js M modules/ve/ui/tools/ve.ui.IndentationButtonTool.js M modules/ve/ui/tools/ve.ui.ListButtonTool.js M modules/ve/ui/ve.ui.Context.js M modules/ve/ui/ve.ui.Inspector.js M modules/ve/ui/ve.ui.Menu.js M modules/ve/ui/ve.ui.Toolbar.js M modules/ve/ve.Node.js M modules/ve/ve.Surface.js 44 files changed, 802 insertions(+), 712 deletions(-) Approvals: Trevor Parscal: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16836 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e37c9bff812e371c7f65a6fd85d9e2af3e0a22f Gerrit-PatchSet
[MediaWiki-commits] [Gerrit] The tests will no longer break periodically - change (mediawiki...EtherEditor[master])
MarkTraceur has uploaded a new change for review. Change subject: The tests will no longer break periodically .. The tests will no longer break periodically For some reason, the call to assertUserHasAuth was failing every once in a while, as was another test. This patch fixes both, though I wish I knew why assertUser wasn't working. Ah well. Change-Id: I9db3eb008c1080ee4e83f4ba6e1e22a6c74a5db4 --- M tests/phpunit/api/EtherEditorApiTestCase.php M tests/phpunit/api/EtherPadAuthTest.php M tests/phpunit/api/ForkEtherPadTest.php M tests/phpunit/api/GetEtherPadTextTest.php 4 files changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EtherEditor refs/changes/57/16857/1 -- To view, visit https://gerrit.wikimedia.org/r/16857 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9db3eb008c1080ee4e83f4ba6e1e22a6c74a5db4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/EtherEditor Gerrit-Branch: master Gerrit-Owner: MarkTraceur ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Get link title from href by stripping article path - change (mediawiki...VisualEditor[master])
Trevor Parscal has submitted this change and it was merged. Change subject: Get link title from href by stripping article path .. Get link title from href by stripping article path This means we don't have to rely on data-rt.sHref. It also means that we'll now be showing the canonical link target in the link inspector rather than the link target as entered by the user, but that's fine. Also change test to have href differ from sHref to show that we use href. Change-Id: Idabdbf2579663ef1efb47d6a73f39743c9f64f3b --- M modules/ve/dm/annotations/ve.dm.LinkAnnotation.js M modules/ve/test/dm/ve.dm.example.js 2 files changed, 14 insertions(+), 16 deletions(-) Approvals: Trevor Parscal: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16801 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idabdbf2579663ef1efb47d6a73f39743c9f64f3b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Catrope Gerrit-Reviewer: Trevor Parscal ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Do underscore/space conversion in internal link targets - change (mediawiki...VisualEditor[master])
Trevor Parscal has submitted this change and it was merged. Change subject: Do underscore/space conversion in internal link targets .. Do underscore/space conversion in internal link targets Convert underscores in the href attribute to spaces in the linear model, and back to underscores when going back to HTML. This ensures the link targets displayed to and edited by the user look nice Change-Id: I4855fce28ad8b724284c53881abc7b99b59b9079 --- M modules/ve/dm/annotations/ve.dm.LinkAnnotation.js M modules/ve/test/dm/ve.dm.example.js 2 files changed, 17 insertions(+), 15 deletions(-) Approvals: Trevor Parscal: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16802 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4855fce28ad8b724284c53881abc7b99b59b9079 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Catrope Gerrit-Reviewer: Trevor Parscal ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Make VE work again with the link RDFa changes in Parsoid - change (mediawiki...VisualEditor[master])
Trevor Parscal has submitted this change and it was merged. Change subject: Make VE work again with the link RDFa changes in Parsoid .. Make VE work again with the link RDFa changes in Parsoid This is ugly but makes things work again. I intend to clean this up once we have a better attribute API * Recognize mw:WikiLink, mw:SimpleWikiLink, mw:ExtLink, mw:NumberedExtLink and mw:UrlLink * Support is incomplete because we can't get to the annotation text with the current API * Preserve all unhandled attributes rather than special-casing data-mw * Update remaining code using data-mw (sHref and stx extraction) to account for the data-mw -> data-rt rename * Update tests accordingly Change-Id: Ia13d3008a6d4cdc8828f9acda5aa797566bc597f --- M modules/ve/ce/nodes/ve.ce.TextNode.js M modules/ve/dm/annotations/ve.dm.LinkAnnotation.js M modules/ve/dm/ve.dm.Converter.js M modules/ve/test/dm/ve.dm.example.js 4 files changed, 78 insertions(+), 30 deletions(-) Approvals: Trevor Parscal: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16717 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia13d3008a6d4cdc8828f9acda5aa797566bc597f Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Catrope Gerrit-Reviewer: Catrope Gerrit-Reviewer: Trevor Parscal ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 36776) Changing User::getNewtalk to use $wgDisableAnonT... - change (mediawiki/core[master])
Parent5446 has uploaded a new change for review. Change subject: (bug 36776) Changing User::getNewtalk to use $wgDisableAnonTalk. .. (bug 36776) Changing User::getNewtalk to use $wgDisableAnonTalk. Previously, $wgDisableAnonTalk was only used as a visual hack in includes/Linker.php. Now, if the variable is set, no queries will be made to user_newtalk at all. Change-Id: Id5521abbec7f05f2de7230f9f0316176abc7f215 Signed-off-by: parent5446 --- M includes/User.php 1 file changed, 15 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/55/16855/1 -- To view, visit https://gerrit.wikimedia.org/r/16855 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id5521abbec7f05f2de7230f9f0316176abc7f215 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Parent5446 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mark WikitextContent tests as requiring database - change (mediawiki/core[Wikidata])
Hashar has uploaded a new change for review. Change subject: mark WikitextContent tests as requiring database .. mark WikitextContent tests as requiring database Some of the WikitextContent tests require a database connection which breaks the databaseless PHPUnit test job. Change-Id: Ia78d22763bffc11a7f66a50ae67bc340939366b9 --- M tests/phpunit/includes/WikitextContentTest.php 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/54/16854/1 -- To view, visit https://gerrit.wikimedia.org/r/16854 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia78d22763bffc11a7f66a50ae67bc340939366b9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: Wikidata Gerrit-Owner: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added ve.init.platform with MediaWiki and stand-alone implem... - change (mediawiki...VisualEditor[master])
Catrope has submitted this change and it was merged. Change subject: Added ve.init.platform with MediaWiki and stand-alone implementations .. Added ve.init.platform with MediaWiki and stand-alone implementations This should make it much simpler to keep MediaWiki specifics out of VisualEditor, which will in turn make it easier to integrate VisualEditor into another platform. Change-Id: I073e9737b37c28af889f2457d10b082cefd0d63b --- M VisualEditor.php M VisualEditorMessagesModule.php M demos/ve/index.php R modules/ve/init/mw/styles/images/loading.gif R modules/ve/init/mw/styles/images/saving.gif R modules/ve/init/mw/styles/ve.init.mw.ViewPageTarget-hd.css R modules/ve/init/mw/styles/ve.init.mw.ViewPageTarget.css R modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js A modules/ve/init/mw/ve.init.mw.Platform.js R modules/ve/init/mw/ve.init.mw.Target.js A modules/ve/init/mw/ve.init.mw.js A modules/ve/init/sa/ve.init.sa.Platform.js A modules/ve/init/sa/ve.init.sa.js A modules/ve/init/ve.init.Platform.js M modules/ve/init/ve.init.js M modules/ve/ui/ve.ui.Context.js M modules/ve/ui/ve.ui.js M modules/ve/ve.js 18 files changed, 490 insertions(+), 260 deletions(-) Approvals: Catrope: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16202 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I073e9737b37c28af889f2457d10b082cefd0d63b Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Trevor Parscal Gerrit-Reviewer: Catrope Gerrit-Reviewer: Trevor Parscal ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] center the loading spiner while loading credits page - change (mediawiki...TimedMediaHandler[master])
J has submitted this change and it was merged. Change subject: center the loading spiner while loading credits page .. center the loading spiner while loading credits page Change-Id: I3a14ef596d21757e4c01ad9248123a6423b6697f --- M MwEmbedModules/EmbedPlayer/resources/skins/kskin/mw.PlayerSkinKskin.js 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: J: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16853 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a14ef596d21757e4c01ad9248123a6423b6697f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: Mdale Gerrit-Reviewer: J Gerrit-Reviewer: Mdale ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] center the loading spiner while loading credits page - change (mediawiki...TimedMediaHandler[master])
Mdale has uploaded a new change for review. Change subject: center the loading spiner while loading credits page .. center the loading spiner while loading credits page Change-Id: I3a14ef596d21757e4c01ad9248123a6423b6697f --- M MwEmbedModules/EmbedPlayer/resources/skins/kskin/mw.PlayerSkinKskin.js 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler refs/changes/53/16853/1 -- To view, visit https://gerrit.wikimedia.org/r/16853 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3a14ef596d21757e4c01ad9248123a6423b6697f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: Mdale ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Improves timed text menu, adds top level subtitle page - change (mediawiki...TimedMediaHandler[master])
J has submitted this change and it was merged. Change subject: Improves timed text menu, adds top level subtitle page .. Improves timed text menu, adds top level subtitle page -- top level subtitle page enables redirects to language specific pages -- in video subtitle menu now directly lists available languages Change-Id: I12161134b7a2472472360056fecd5a7c3841529a --- M MwEmbedModules/TimedText/TimedText.i18n.php M MwEmbedModules/TimedText/resources/mw.TextSource.js M MwEmbedModules/TimedText/resources/mw.TimedText.js M TimedMediaHandler.i18n.php M TimedMediaHandler.php M TimedTextPage.php M handlers/TextHandler/TextHandler.php M resources/mw.MediaWikiPlayerSupport.js 8 files changed, 107 insertions(+), 94 deletions(-) Approvals: J: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16838 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12161134b7a2472472360056fecd5a7c3841529a Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: Mdale Gerrit-Reviewer: J Gerrit-Reviewer: Mdale ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] add Diff extension to Wikidata build - change (integration/jenkins[master])
Hashar has submitted this change and it was merged. Change subject: add Diff extension to Wikidata build .. add Diff extension to Wikidata build Jeroen wrote: We moved some code into it's own extension which is now in it's own repository. We need a checkout of this extension for the Wikibase stuff to work. So this will require some config change on the jenkins setup. * https://gerrit.wikimedia.org/r/#/c/16839/ * https://gerrit.wikimedia.org/r/#/c/16840/ Change-Id: I56db3ace90c44f6012634df14c3158dd74753717 --- M jobs/_shared/build.xml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Hashar: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16852 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56db3ace90c44f6012634df14c3158dd74753717 Gerrit-PatchSet: 1 Gerrit-Project: integration/jenkins Gerrit-Branch: master Gerrit-Owner: Hashar Gerrit-Reviewer: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] add Diff extension to Wikidata build - change (integration/jenkins[master])
Hashar has uploaded a new change for review. Change subject: add Diff extension to Wikidata build .. add Diff extension to Wikidata build Jeroen wrote: We moved some code into it's own extension which is now in it's own repository. We need a checkout of this extension for the Wikibase stuff to work. So this will require some config change on the jenkins setup. * https://gerrit.wikimedia.org/r/#/c/16839/ * https://gerrit.wikimedia.org/r/#/c/16840/ Change-Id: I56db3ace90c44f6012634df14c3158dd74753717 --- M jobs/_shared/build.xml 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/integration/jenkins refs/changes/52/16852/1 -- To view, visit https://gerrit.wikimedia.org/r/16852 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I56db3ace90c44f6012634df14c3158dd74753717 Gerrit-PatchSet: 1 Gerrit-Project: integration/jenkins Gerrit-Branch: master Gerrit-Owner: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] SVN: [115628] trunk/extensions/StyleGuideDemo/
https://www.mediawiki.org/wiki/Special:Code/MediaWiki/115628 Revision: 115628 Author: krinkle Date: 2012-07-27 20:16:31 + (Fri, 27 Jul 2012) Log Message: --- Removing old work-in-progress extension * Too soon for implementation like this, it hasn't been tested at all afaik, and needs improvement to be usable to the level where we want it - which is the level of appliance from central skins-css (e.g. like Twitter Bootstrap; drop-in css that cascades to interface elements automatically - NOT inside an extension since that would duplicate and decentralize implementation details and by definition not match the skin the wiki is using). Removed Paths: - trunk/extensions/StyleGuideDemo/ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding opera_mini to the xff list, and moving the acl - change (operations/puppet[production])
Ryan Lane has submitted this change and it was merged. Change subject: Adding opera_mini to the xff list, and moving the acl .. Adding opera_mini to the xff list, and moving the acl Change-Id: If5c3ec819794be4c4b7753ad6881e5e5b1b9d012 --- M templates/varnish/mobile-frontend.inc.vcl.erb M templates/varnish/wikimedia.vcl.erb 2 files changed, 29 insertions(+), 27 deletions(-) Approvals: Ryan Lane: Looks good to me, approved preilly: Looks good to me, but someone else must approve gerrit2: Verified -- To view, visit https://gerrit.wikimedia.org/r/16851 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5c3ec819794be4c4b7753ad6881e5e5b1b9d012 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Ryan Lane Gerrit-Reviewer: Ryan Lane Gerrit-Reviewer: gerrit2 Gerrit-Reviewer: preilly ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding opera_mini to the xff list, and moving the acl - change (operations/puppet[production])
Ryan Lane has uploaded a new change for review. Change subject: Adding opera_mini to the xff list, and moving the acl .. Adding opera_mini to the xff list, and moving the acl Change-Id: If5c3ec819794be4c4b7753ad6881e5e5b1b9d012 --- M templates/varnish/mobile-frontend.inc.vcl.erb M templates/varnish/wikimedia.vcl.erb 2 files changed, 29 insertions(+), 27 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/51/16851/1 -- To view, visit https://gerrit.wikimedia.org/r/16851 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If5c3ec819794be4c4b7753ad6881e5e5b1b9d012 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Ryan Lane ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] add traslation keys for new format - change (mediawiki...TimedMediaHandler[master])
J has submitted this change and it was merged. Change subject: add traslation keys for new format .. add traslation keys for new format also add i18n strings Change-Id: Ib04b2691ca030350686b2cfd8a112d07b3db4f0b --- M TimedMediaHandler.i18n.php M TimedMediaHandler.php 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: J: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16850 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib04b2691ca030350686b2cfd8a112d07b3db4f0b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: J Gerrit-Reviewer: J ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] add traslation keys for new format - change (mediawiki...TimedMediaHandler[master])
J has uploaded a new change for review. Change subject: add traslation keys for new format .. add traslation keys for new format also add i18n strings Change-Id: Ib04b2691ca030350686b2cfd8a112d07b3db4f0b --- M TimedMediaHandler.i18n.php M TimedMediaHandler.php 2 files changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler refs/changes/50/16850/1 -- To view, visit https://gerrit.wikimedia.org/r/16850 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib04b2691ca030350686b2cfd8a112d07b3db4f0b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: J ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add mw.Time - change (mediawiki/core[master])
MarkTraceur has uploaded a new change for review. Change subject: Add mw.Time .. Add mw.Time I realized that having an easy library for creating Date objects that can be easily converted to/from MediaWiki-style timestamps, and which can be used to output messages like "5 days ago", might be very useful. So, here it is. I made sure to add in tests, the code conventions are (should be) followed, and it all appears to run. Change-Id: I9f9ca62f0744f0abc8f0fb5a994aba22b6b08597 --- M languages/messages/MessagesEn.php M languages/messages/MessagesQqq.php M resources/Resources.php A resources/mediawiki/mediawiki.Time.js M tests/qunit/QUnitTestResources.php A tests/qunit/suites/resources/mediawiki/mediawiki.Time.test.js 6 files changed, 264 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/48/16848/1 -- To view, visit https://gerrit.wikimedia.org/r/16848 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9f9ca62f0744f0abc8f0fb5a994aba22b6b08597 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: MarkTraceur ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Sanitize html tags not on a whitelist. - change (mediawiki...VisualEditor[master])
Subramanya Sastry has uploaded a new change for review. Change subject: Sanitize html tags not on a whitelist. .. Sanitize html tags not on a whitelist. * Need auditing to see if the whitelist is complete. * Added and to the whiltelist since they seem to come from some extensions and parser tests depend on them. May need to use parsoid config or parser hooks/extension info to extend sanitizer whitelist. For now, probably okay. * Does not contain and in the whitelist -- do they need to be? Change-Id: Id9ecdd96843e8f6ca65e8666807dec1015443d49 --- M modules/parser/ext.core.Sanitizer.js 1 file changed, 97 insertions(+), 55 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/47/16847/1 -- To view, visit https://gerrit.wikimedia.org/r/16847 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id9ecdd96843e8f6ca65e8666807dec1015443d49 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add missing constant - change (mediawiki...TimedMediaHandler[master])
J has submitted this change and it was merged. Change subject: Add missing constant .. Add missing constant new profile also needs a name Change-Id: Idaedaaf2d8a30d3e907a8ee684f718f57ae3499e --- M WebVideoTranscode/WebVideoTranscode.php 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: J: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16846 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idaedaaf2d8a30d3e907a8ee684f718f57ae3499e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: J Gerrit-Reviewer: J ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add small WebM version since to transcodes - change (mediawiki...TimedMediaHandler[master])
J has submitted this change and it was merged. Change subject: Add small WebM version since to transcodes .. Add small WebM version since to transcodes add small WebM version to be used in default thumb embeds Change-Id: I0886fa91fff3ffbdb936ad2ac1524216fba76e66 --- M TimedMediaHandler.php M WebVideoTranscode/WebVideoTranscode.php 2 files changed, 17 insertions(+), 4 deletions(-) Approvals: J: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16845 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0886fa91fff3ffbdb936ad2ac1524216fba76e66 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: J Gerrit-Reviewer: J ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add small WebM version since to transcodes - change (mediawiki...TimedMediaHandler[master])
J has uploaded a new change for review. Change subject: Add small WebM version since to transcodes .. Add small WebM version since to transcodes add small WebM version to be used in default thumb embeds Change-Id: I0886fa91fff3ffbdb936ad2ac1524216fba76e66 --- M TimedMediaHandler.php M WebVideoTranscode/WebVideoTranscode.php 2 files changed, 17 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler refs/changes/45/16845/1 -- To view, visit https://gerrit.wikimedia.org/r/16845 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0886fa91fff3ffbdb936ad2ac1524216fba76e66 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: J ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Various thumb.php fixes. - change (mediawiki/core[wmf/1.20wmf7])
Aaron Schulz has submitted this change and it was merged. Change subject: Various thumb.php fixes. .. Various thumb.php fixes. * Made wfThumbHandle404() handle full REQUEST_URI urls. * Made wfExtractThumbParams() handle protocal relative zone urls. * Added FileRepo::getZoneHandlerUrl() and site zone configuration to simplify wmf rewrite rules. * Renamed some variables to be less misleading. Conflicts: includes/DefaultSettings.php Change-Id: Ic3e23c2a623c1241ee22a9811aee073fb07aa68c --- M includes/DefaultSettings.php M includes/filerepo/FileRepo.php M thumb.php 3 files changed, 55 insertions(+), 27 deletions(-) Approvals: Aaron Schulz: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16843 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3e23c2a623c1241ee22a9811aee073fb07aa68c Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.20wmf7 Gerrit-Owner: Aaron Schulz Gerrit-Reviewer: Aaron Schulz Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Various thumb.php fixes. - change (mediawiki/core[wmf/1.20wmf8])
Aaron Schulz has submitted this change and it was merged. Change subject: Various thumb.php fixes. .. Various thumb.php fixes. * Made wfThumbHandle404() handle full REQUEST_URI urls. * Made wfExtractThumbParams() handle protocal relative zone urls. * Added FileRepo::getZoneHandlerUrl() and site zone configuration to simplify wmf rewrite rules. * Renamed some variables to be less misleading. Change-Id: Ic3e23c2a623c1241ee22a9811aee073fb07aa68c --- M includes/DefaultSettings.php M includes/filerepo/FileRepo.php M thumb.php 3 files changed, 54 insertions(+), 26 deletions(-) Approvals: Aaron Schulz: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/16844 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3e23c2a623c1241ee22a9811aee073fb07aa68c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.20wmf8 Gerrit-Owner: Aaron Schulz Gerrit-Reviewer: Aaron Schulz Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Various thumb.php fixes. - change (mediawiki/core[wmf/1.20wmf8])
Aaron Schulz has uploaded a new change for review. Change subject: Various thumb.php fixes. .. Various thumb.php fixes. * Made wfThumbHandle404() handle full REQUEST_URI urls. * Made wfExtractThumbParams() handle protocal relative zone urls. * Added FileRepo::getZoneHandlerUrl() and site zone configuration to simplify wmf rewrite rules. * Renamed some variables to be less misleading. Change-Id: Ic3e23c2a623c1241ee22a9811aee073fb07aa68c --- M includes/DefaultSettings.php M includes/filerepo/FileRepo.php M thumb.php 3 files changed, 54 insertions(+), 26 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/44/16844/1 -- To view, visit https://gerrit.wikimedia.org/r/16844 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic3e23c2a623c1241ee22a9811aee073fb07aa68c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.20wmf8 Gerrit-Owner: Aaron Schulz ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Various thumb.php fixes. - change (mediawiki/core[wmf/1.20wmf7])
Aaron Schulz has uploaded a new change for review. Change subject: Various thumb.php fixes. .. Various thumb.php fixes. * Made wfThumbHandle404() handle full REQUEST_URI urls. * Made wfExtractThumbParams() handle protocal relative zone urls. * Added FileRepo::getZoneHandlerUrl() and site zone configuration to simplify wmf rewrite rules. * Renamed some variables to be less misleading. Conflicts: includes/DefaultSettings.php Change-Id: Ic3e23c2a623c1241ee22a9811aee073fb07aa68c --- M extensions/AbuseFilter M extensions/ArticleFeedback M extensions/ArticleFeedbackv5 M extensions/CentralNotice M extensions/LastModified M extensions/MobileFrontend M extensions/MoodBar M extensions/Narayam M extensions/PageTriage M extensions/WikiLove M includes/DefaultSettings.php M includes/filerepo/FileRepo.php M thumb.php 13 files changed, 55 insertions(+), 27 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/43/16843/1 -- To view, visit https://gerrit.wikimedia.org/r/16843 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic3e23c2a623c1241ee22a9811aee073fb07aa68c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.20wmf7 Gerrit-Owner: Aaron Schulz ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] swapping potassium and zirconium to internal vlan & adding t... - change (operations/puppet[production])
RobH has submitted this change and it was merged. Change subject: swapping potassium and zirconium to internal vlan & adding to decom to remove invalid data from nagios .. swapping potassium and zirconium to internal vlan & adding to decom to remove invalid data from nagios Change-Id: I365f77f04228843c4bf7a1c5c83d95d48ae357fd --- M files/dhcpd/linux-host-entries.ttyS1-115200 M manifests/decommissioning.pp M manifests/site.pp 3 files changed, 4 insertions(+), 10 deletions(-) Approvals: RobH: Verified; Looks good to me, approved gerrit2: Verified -- To view, visit https://gerrit.wikimedia.org/r/16842 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I365f77f04228843c4bf7a1c5c83d95d48ae357fd Gerrit-PatchSet: 2 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: RobH Gerrit-Reviewer: RobH Gerrit-Reviewer: gerrit2 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] swapping potassium and zirconium to internal vlan & adding t... - change (operations/puppet[production])
RobH has uploaded a new change for review. Change subject: swapping potassium and zirconium to internal vlan & adding to decom to remove invalid data from nagios .. swapping potassium and zirconium to internal vlan & adding to decom to remove invalid data from nagios Change-Id: I365f77f04228843c4bf7a1c5c83d95d48ae357fd --- M files/dhcpd/linux-host-entries.ttyS1-115200 M manifests/decommissioning.pp M manifests/site.pp 3 files changed, 4 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/42/16842/1 -- To view, visit https://gerrit.wikimedia.org/r/16842 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I365f77f04228843c4bf7a1c5c83d95d48ae357fd Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: RobH ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] adding tmh1 and tmh2 to dhcpd - change (operations/puppet[production])
RobH has submitted this change and it was merged. Change subject: adding tmh1 and tmh2 to dhcpd .. adding tmh1 and tmh2 to dhcpd Change-Id: Ic2b5da13900551e998edf19d6358a3f45f209753 --- M files/dhcpd/linux-host-entries.ttyS1-115200 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: RobH: Verified; Looks good to me, approved gerrit2: Verified -- To view, visit https://gerrit.wikimedia.org/r/16837 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2b5da13900551e998edf19d6358a3f45f209753 Gerrit-PatchSet: 2 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Cmjohnson Gerrit-Reviewer: Cmjohnson Gerrit-Reviewer: RobH Gerrit-Reviewer: gerrit2 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Move towards calling "pads" "sessions" - change (mediawiki...EtherEditor[master])
MarkTraceur has submitted this change and it was merged. Change subject: Move towards calling "pads" "sessions" .. Move towards calling "pads" "sessions" Erik thinks "sessions" would be a better way to think about it, so this is the first step towards that. Rebased to only depend on one other commit, but will need to be rebased when other things are merged. Changes: * Pad list is now session list * Now list it as "a session created by $1 $2 time ago" * Now show number of users connected, could be useful * Make pad list look EVEN BETTER. Great stuff. * Update a bunch of i18n messages to be closer to intended use Change-Id: If0c9f353f663f86ee426cd4bd2b66dd17226fae6 --- M EtherEditor.i18n.php M EtherEditor.php M EtherEditorHooks.php M includes/EtherEditorPad.php M modules/ext.etherEditor.js M sql/EtherEditor.sql A sql/UpdateForSessions.patch.sql 7 files changed, 84 insertions(+), 6 deletions(-) Approvals: MarkTraceur: Verified; Looks good to me, approved Nikerabbit: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16780 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0c9f353f663f86ee426cd4bd2b66dd17226fae6 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/EtherEditor Gerrit-Branch: master Gerrit-Owner: MarkTraceur Gerrit-Reviewer: MarkTraceur Gerrit-Reviewer: Nikerabbit ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add in a better session menu, and various other changes - change (mediawiki...EtherEditor[master])
MarkTraceur has submitted this change and it was merged. Change subject: Add in a better session menu, and various other changes .. Add in a better session menu, and various other changes This patch will make the session menu a little nicer. It will also slighly improve the user list, and remove the ethereditor-warn module from the project, since it is no longer used. It is now working beautifully, though it will depend on another patch for now, because that patch has some big bugfixes that were necessary for this one to work. Also, I've fixed a bug or two along the way. Change-Id: Ic8ddc344d9974556b38ef8d59b4a6f0e09817da3 --- M EtherEditor.i18n.php M EtherEditor.php M EtherEditorHooks.php M modules/ext.etherEditor.css M modules/ext.etherEditor.js D modules/ext.etherEditorWarn.js 6 files changed, 197 insertions(+), 133 deletions(-) Approvals: MarkTraceur: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16455 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8ddc344d9974556b38ef8d59b4a6f0e09817da3 Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/extensions/EtherEditor Gerrit-Branch: master Gerrit-Owner: MarkTraceur Gerrit-Reviewer: MarkTraceur ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Move Diff extension to its own repository - change (mediawiki...Wikibase[master])
Jeroen De Dauw has submitted this change and it was merged. Change subject: Move Diff extension to its own repository .. Move Diff extension to its own repository Change-Id: Ib80df9c4b70474c0cbbce762a690d69f37895ffa --- D Diff/COPYING D Diff/Diff.classes.php D Diff/Diff.credits.php D Diff/Diff.i18n.php D Diff/Diff.php D Diff/Diff.standalone.php D Diff/INSTALL D Diff/README D Diff/RELEASE-NOTES D Diff/includes/Diff.php D Diff/includes/DiffOp.php D Diff/includes/DiffOpAdd.php D Diff/includes/DiffOpChange.php D Diff/includes/DiffOpRemove.php D Diff/includes/GenericArrayObject.php D Diff/includes/IDiff.php D Diff/includes/IDiffOp.php D Diff/includes/ListDiff.php D Diff/includes/MapDiff.php D Diff/tests/AbstractTestCase.php D Diff/tests/DiffOpAddTest.php D Diff/tests/DiffOpChangeTest.php D Diff/tests/DiffOpRemoveTest.php D Diff/tests/DiffOpTest.php D Diff/tests/DiffTest.php D Diff/tests/GenericArrayObjectTest.php D Diff/tests/ListDiffTest.php D Diff/tests/MapDiffTest.php M lib/WikibaseLib.php 29 files changed, 1 insertion(+), 2,771 deletions(-) Approvals: Jeroen De Dauw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16839 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib80df9c4b70474c0cbbce762a690d69f37895ffa Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Initial import, code comming from https://gerrit.wikimedia.o... - change (mediawiki...Diff[master])
Jeroen De Dauw has submitted this change and it was merged. Change subject: Initial import, code comming from https://gerrit.wikimedia.org/r/#/c/16839/ .. Initial import, code comming from https://gerrit.wikimedia.org/r/#/c/16839/ Change-Id: Iddd060bd9eeaa0e5fc9b0b86a31f1e90d5a87c74 --- A COPYING A Diff.classes.php A Diff.credits.php A Diff.i18n.php A Diff.php A Diff.standalone.php A INSTALL A README A RELEASE-NOTES A includes/Diff.php A includes/DiffOp.php A includes/DiffOpAdd.php A includes/DiffOpChange.php A includes/DiffOpRemove.php A includes/GenericArrayObject.php A includes/IDiff.php A includes/IDiffOp.php A includes/ListDiff.php A includes/MapDiff.php A tests/AbstractTestCase.php A tests/DiffOpAddTest.php A tests/DiffOpChangeTest.php A tests/DiffOpRemoveTest.php A tests/DiffOpTest.php A tests/DiffTest.php A tests/GenericArrayObjectTest.php A tests/ListDiffTest.php A tests/MapDiffTest.php 28 files changed, 2,770 insertions(+), 0 deletions(-) Approvals: Jeroen De Dauw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16840 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iddd060bd9eeaa0e5fc9b0b86a31f1e90d5a87c74 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Diff Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update CSS class for Gerrit upgrade - change (operations/puppet[production])
Catrope has uploaded a new change for review. Change subject: Update CSS class for Gerrit upgrade .. Update CSS class for Gerrit upgrade CSS class names change in every Gerrit version *stab* Change-Id: I90fc1c4594b17b4957af7c3ac5f8200e6868ee40 --- M files/gerrit/skin/GerritSite.css 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/41/16841/1 -- To view, visit https://gerrit.wikimedia.org/r/16841 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I90fc1c4594b17b4957af7c3ac5f8200e6868ee40 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Catrope ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Initial import, code comming from https://gerrit.wikimedia.o... - change (mediawiki...Diff[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Initial import, code comming from https://gerrit.wikimedia.org/r/#/c/16839/ .. Initial import, code comming from https://gerrit.wikimedia.org/r/#/c/16839/ Change-Id: Iddd060bd9eeaa0e5fc9b0b86a31f1e90d5a87c74 --- A COPYING A Diff.classes.php A Diff.credits.php A Diff.i18n.php A Diff.php A Diff.standalone.php A INSTALL A README A RELEASE-NOTES A includes/Diff.php A includes/DiffOp.php A includes/DiffOpAdd.php A includes/DiffOpChange.php A includes/DiffOpRemove.php A includes/GenericArrayObject.php A includes/IDiff.php A includes/IDiffOp.php A includes/ListDiff.php A includes/MapDiff.php A tests/AbstractTestCase.php A tests/DiffOpAddTest.php A tests/DiffOpChangeTest.php A tests/DiffOpRemoveTest.php A tests/DiffOpTest.php A tests/DiffTest.php A tests/GenericArrayObjectTest.php A tests/ListDiffTest.php A tests/MapDiffTest.php 28 files changed, 2,770 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Diff refs/changes/40/16840/1 -- To view, visit https://gerrit.wikimedia.org/r/16840 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iddd060bd9eeaa0e5fc9b0b86a31f1e90d5a87c74 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Diff Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Move Diff extension to its own repository - change (mediawiki...Wikibase[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Move Diff extension to its own repository .. Move Diff extension to its own repository Change-Id: Ib80df9c4b70474c0cbbce762a690d69f37895ffa --- D Diff/COPYING D Diff/Diff.classes.php D Diff/Diff.credits.php D Diff/Diff.i18n.php D Diff/Diff.php D Diff/Diff.standalone.php D Diff/INSTALL D Diff/README D Diff/RELEASE-NOTES D Diff/includes/Diff.php D Diff/includes/DiffOp.php D Diff/includes/DiffOpAdd.php D Diff/includes/DiffOpChange.php D Diff/includes/DiffOpRemove.php D Diff/includes/GenericArrayObject.php D Diff/includes/IDiff.php D Diff/includes/IDiffOp.php D Diff/includes/ListDiff.php D Diff/includes/MapDiff.php D Diff/tests/AbstractTestCase.php D Diff/tests/DiffOpAddTest.php D Diff/tests/DiffOpChangeTest.php D Diff/tests/DiffOpRemoveTest.php D Diff/tests/DiffOpTest.php D Diff/tests/DiffTest.php D Diff/tests/GenericArrayObjectTest.php D Diff/tests/ListDiffTest.php D Diff/tests/MapDiffTest.php M lib/WikibaseLib.php 29 files changed, 1 insertion(+), 2,771 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/39/16839/1 -- To view, visit https://gerrit.wikimedia.org/r/16839 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib80df9c4b70474c0cbbce762a690d69f37895ffa Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Improves timed text menu, adds top level subtitle page - change (mediawiki...TimedMediaHandler[master])
Mdale has uploaded a new change for review. Change subject: Improves timed text menu, adds top level subtitle page .. Improves timed text menu, adds top level subtitle page -- top level subtitle page enables redirects to language specific pages -- in video subtitle menu now directly lists available languages Change-Id: I12161134b7a2472472360056fecd5a7c3841529a --- M MwEmbedModules/TimedText/TimedText.i18n.php M MwEmbedModules/TimedText/resources/mw.TimedText.js M TimedMediaHandler.i18n.php M TimedMediaHandler.php M TimedTextPage.php M resources/mw.MediaWikiPlayerSupport.js 6 files changed, 99 insertions(+), 88 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler refs/changes/38/16838/1 -- To view, visit https://gerrit.wikimedia.org/r/16838 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I12161134b7a2472472360056fecd5a7c3841529a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: Mdale ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] adding tmh1 and tmh2 to dhcpd - change (operations/puppet[production])
Cmjohnson has uploaded a new change for review. Change subject: adding tmh1 and tmh2 to dhcpd .. adding tmh1 and tmh2 to dhcpd Change-Id: Ic2b5da13900551e998edf19d6358a3f45f209753 --- M files/dhcpd/linux-host-entries.ttyS1-115200 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/37/16837/1 -- To view, visit https://gerrit.wikimedia.org/r/16837 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic2b5da13900551e998edf19d6358a3f45f209753 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Cmjohnson ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Kranitor #1: On-boarding - change (mediawiki...VisualEditor[master])
Krinkle has uploaded a new change for review. Change subject: Kranitor #1: On-boarding .. Kranitor #1: On-boarding '''Kranitor commits''' are commits by Krinkle with his janitor hat on. Must never contain functional changes mixed with miscellaneous changes. .gitignore: * Add .DS_Store to the ignore list so that browsing the directories on Mac OS X, will not add these files to the list of untracked files. * Fix missing newline at end of file .jshintrc * raises -> throws * +module (QUnit.module) * remove 'Node' (as of node-jshint 1.7.2 this is now part of 'browser:true', as it should be) Authors: * Adding myself MWExtension/VisualEditor.php * Fix default value of wgVisualEditorParsoidURL to not point to the experimental instance in WMF Labs. Issues: * ve.ce.TextNode: - Fix TODO: Don't perform a useless clone of an already-jQuerified object. - Use .html() to set html content instead of encapsulating between two strings. This is slightly faster but more importantly safer, and prevents situations where the resulting jQuery collection actually contains 2 elements instead of 1, thus messing up what .contents() is iterating over. * ve.ce.Document.test.js - Fix: ReferenceError: assert is not defined * ve.dm.Document.test.js - Fix: ReferenceError: assert is not defined * ve.dm.Transaction.test.js - Fix: ReferenceError: assert is not defined * ve.dm.TransactionProcessor.test.js Code conventions / Misc cleanup * Various JSHint warnings. * Whitespace * jQuery(): Use '' for element creation, use '' for parsing * Use the default operator instead of ternary when the condition and first value are the same. x = foo ? foo : bar; -> x = foo || bar; Because contrary to some programming language (PHP...), in JS the default operator does not enforce a boolean result but returns the original value, hence it being called the 'default' operator, as opposed to the 'or' operator. * No need to call addClass() twice, it takes a space-separated list (jQuery splits by space and adds if needed) * Use .on( event[, selector], fn ) instead of the deprecated routers to it such as .bind(), .delegate() and .live(). All these three are now built-in and fully compatible with .on() * Add 'XXX:' comments for suspicious code that I don't want to change as part of a clean up commit. * Remove unused variables (several var x = this; where x was not used anywhere, possibly from boilerplate copy/paste) Change-Id: I7e37c9bff812e371c7f65a6fd85d9e2af3e0a22f --- M .gitignore M .jshintrc M AUTHORS.txt M VisualEditor.php M modules/ve/ce/nodes/ve.ce.TextNode.js M modules/ve/ce/ve.ce.Surface.js M modules/ve/dm/ve.dm.BranchNode.js M modules/ve/dm/ve.dm.DocumentSynchronizer.js M modules/ve/init/targets/ve.init.ViewPageTarget.js M modules/ve/test/ce/ve.ce.Document.test.js M modules/ve/test/dm/ve.dm.Document.test.js M modules/ve/test/dm/ve.dm.Transaction.test.js M modules/ve/test/dm/ve.dm.TransactionProcessor.test.js M modules/ve/test/ve.BranchNode.test.js M modules/ve/test/ve.Document.test.js M modules/ve/test/ve.qunit.js M modules/ve/ui/inspectors/ve.ui.LinkInspector.js M modules/ve/ui/tools/ve.ui.ButtonTool.js M modules/ve/ui/tools/ve.ui.ClearButtonTool.js M modules/ve/ui/tools/ve.ui.DropdownTool.js M modules/ve/ui/tools/ve.ui.IndentationButtonTool.js M modules/ve/ui/tools/ve.ui.ListButtonTool.js M modules/ve/ui/ve.ui.Context.js M modules/ve/ui/ve.ui.Inspector.js M modules/ve/ui/ve.ui.Menu.js M modules/ve/ui/ve.ui.Toolbar.js M modules/ve/ve.Node.js M modules/ve/ve.Surface.js 28 files changed, 562 insertions(+), 506 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/36/16836/1 -- To view, visit https://gerrit.wikimedia.org/r/16836 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7e37c9bff812e371c7f65a6fd85d9e2af3e0a22f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Krinkle ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add helpful data-grouptype to the settings fieldset - change (mediawiki...Translate[translatesvg])
Nikerabbit has submitted this change and it was merged. Change subject: Add helpful data-grouptype to the settings fieldset .. Add helpful data-grouptype to the settings fieldset Allows JavaScript to know what kind of message group is present. [Required for TranslateSvg phase 2.] Change-Id: I4a91e5d988788b2d4dd070ddd87efd4d283c3f81 --- M specials/SpecialTranslate.php 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Nikerabbit: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/14927 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a91e5d988788b2d4dd070ddd87efd4d283c3f81 Gerrit-PatchSet: 6 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: translatesvg Gerrit-Owner: Jarry1250 Gerrit-Reviewer: Jarry1250 Gerrit-Reviewer: Nikerabbit ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added GenericArrayObject class and associated test base - change (mediawiki/core[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Added GenericArrayObject class and associated test base .. Added GenericArrayObject class and associated test base Change-Id: Id7e9b59c7ed4a9338744db58935307ecb4bc441f --- M includes/AutoLoader.php A includes/GenericArrayObject.php A tests/phpunit/includes/GenericArrayObjectTest.php 3 files changed, 488 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/34/16834/1 -- To view, visit https://gerrit.wikimedia.org/r/16834 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id7e9b59c7ed4a9338744db58935307ecb4bc441f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added base class for base test classes :) - change (mediawiki/core[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Added base class for base test classes :) .. Added base class for base test classes :) Change-Id: I34cc85958034ec257e056661cc3987661899eac9 --- M includes/AutoLoader.php A tests/phpunit/AbstractTestCase.php 2 files changed, 116 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/33/16833/1 -- To view, visit https://gerrit.wikimedia.org/r/16833 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I34cc85958034ec257e056661cc3987661899eac9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added tests for DiffOp classes - change (mediawiki...Wikibase[master])
Aude has submitted this change and it was merged. Change subject: Added tests for DiffOp classes .. Added tests for DiffOp classes Change-Id: I37b949bf1afbbb1735023212729111f02833621e --- M Diff/Diff.classes.php M Diff/Diff.php M Diff/INSTALL A Diff/tests/AbstractTestCase.php A Diff/tests/DiffOpAddTest.php A Diff/tests/DiffOpChangeTest.php A Diff/tests/DiffOpRemoveTest.php A Diff/tests/DiffOpTest.php M Diff/tests/DiffTest.php M Diff/tests/GenericArrayObjectTest.php M Diff/tests/ListDiffTest.php M Diff/tests/MapDiffTest.php 12 files changed, 421 insertions(+), 2 deletions(-) Approvals: Aude: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16830 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37b949bf1afbbb1735023212729111f02833621e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: Aude Gerrit-Reviewer: Daniel Kinzler ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixing bug 37606 - flip flyouts when necessary - change (mediawiki...PageTriage[master])
Bsitu has submitted this change and it was merged. Change subject: Fixing bug 37606 - flip flyouts when necessary .. Fixing bug 37606 - flip flyouts when necessary patch set 2: remove trailing whitespace Change-Id: Idf5a05a288df52f2ce9ce05042ff217fdc877ee3 --- M modules/ext.pageTriage.views.toolbar/ext.pageTriage.toolView.css M modules/ext.pageTriage.views.toolbar/ext.pageTriage.toolView.js M modules/ext.pageTriage.views.toolbar/images/flyout_pokey.png A modules/ext.pageTriage.views.toolbar/images/flyout_pokey_flipped.png 4 files changed, 31 insertions(+), 3 deletions(-) Approvals: Bsitu: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16795 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf5a05a288df52f2ce9ce05042ff217fdc877ee3 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/PageTriage Gerrit-Branch: master Gerrit-Owner: Kaldari Gerrit-Reviewer: Bsitu Gerrit-Reviewer: Kaldari ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Removed links to helper forms in Special:Forms and Special:T... - change (mediawiki...SemanticForms[master])
Yaron Koren has submitted this change and it was merged. Change subject: Removed links to helper forms in Special:Forms and Special:Templates - not really necessary, and potentially confusing .. Removed links to helper forms in Special:Forms and Special:Templates - not really necessary, and potentially confusing Change-Id: I1493dd330a2a84b6b14cfafce181c60fd48c80b6 --- M specials/SF_Forms.php M specials/SF_Templates.php 2 files changed, 2 insertions(+), 7 deletions(-) Approvals: Yaron Koren: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16832 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1493dd330a2a84b6b14cfafce181c60fd48c80b6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticForms Gerrit-Branch: master Gerrit-Owner: Yaron Koren Gerrit-Reviewer: Yaron Koren ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Removed links to helper forms in Special:Forms and Special:T... - change (mediawiki...SemanticForms[master])
Yaron Koren has uploaded a new change for review. Change subject: Removed links to helper forms in Special:Forms and Special:Templates - not really necessary, and potentially confusing .. Removed links to helper forms in Special:Forms and Special:Templates - not really necessary, and potentially confusing Change-Id: I1493dd330a2a84b6b14cfafce181c60fd48c80b6 --- M specials/SF_Forms.php M specials/SF_Templates.php 2 files changed, 2 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticForms refs/changes/32/16832/1 -- To view, visit https://gerrit.wikimedia.org/r/16832 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1493dd330a2a84b6b14cfafce181c60fd48c80b6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticForms Gerrit-Branch: master Gerrit-Owner: Yaron Koren ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding wikilove.html to cached templates. - change (mediawiki...PageTriage[master])
Bsitu has submitted this change and it was merged. Change subject: Adding wikilove.html to cached templates. .. Adding wikilove.html to cached templates. Change-Id: I4ced9b1908e3ae8c7f9a8a7dfe6e8b8f1e9a4d53 --- M modules/ext.pageTriage.util/ext.pageTriage.viewUtil.js 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Bsitu: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16796 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ced9b1908e3ae8c7f9a8a7dfe6e8b8f1e9a4d53 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/PageTriage Gerrit-Branch: master Gerrit-Owner: Kaldari Gerrit-Reviewer: Bsitu ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Improve detection of php binary. - change (mediawiki/core[master])
Platonides has uploaded a new change for review. Change subject: Improve detection of php binary. .. Improve detection of php binary. - Add php binary and a program which might be set as $PHP. - Check for the correct php version. The break shell builtin is not too commonly used, but should beperfectly safe to use, since it's specified by POSIX http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#break Change-Id: Iefbe991426f0e9a7178363a30b613f57110e1953 --- M maintenance/dev/includes/php.sh 1 file changed, 12 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/31/16831/1 -- To view, visit https://gerrit.wikimedia.org/r/16831 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iefbe991426f0e9a7178363a30b613f57110e1953 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Platonides ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Getting rid of squishing animation since it doesn't work wel... - change (mediawiki...PageTriage[master])
Bsitu has submitted this change and it was merged. Change subject: Getting rid of squishing animation since it doesn't work well for the new 'All' list (which is extremely long) and also causes a bug on iPads. .. Getting rid of squishing animation since it doesn't work well for the new 'All' list (which is extremely long) and also causes a bug on iPads. Change-Id: If4096baebc0ca91324dfc600d9979707e7cb8aae --- M modules/ext.pageTriage.views.toolbar/ext.pageTriage.tags.js 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Bsitu: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16800 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4096baebc0ca91324dfc600d9979707e7cb8aae Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/PageTriage Gerrit-Branch: master Gerrit-Owner: Kaldari Gerrit-Reviewer: Bsitu ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Moved formats into formats directory for great organization - change (mediawiki...SemanticResultFormats[master])
Jeroen De Dauw has submitted this change and it was merged. Change subject: Moved formats into formats directory for great organization .. Moved formats into formats directory for great organization Change-Id: Ice1d4cd8a0885b164624eee791e15c308deacc1a --- M SRF_Resources.php R formats/Exhibit/SRF_Exhibit.css R formats/Exhibit/SRF_Exhibit.js R formats/Exhibit/SRF_Exhibit.php R formats/Exhibit/ajax/LICENSE.txt R formats/Exhibit/ajax/compile-epilog.js R formats/Exhibit/ajax/compile-prolog.js R formats/Exhibit/ajax/content/history.html R formats/Exhibit/ajax/images/bubble-arrow-point-down.png R formats/Exhibit/ajax/images/bubble-arrow-point-left.png R formats/Exhibit/ajax/images/bubble-arrow-point-right.png R formats/Exhibit/ajax/images/bubble-arrow-point-up.png R formats/Exhibit/ajax/images/bubble-bottom-left.png R formats/Exhibit/ajax/images/bubble-bottom-right.png R formats/Exhibit/ajax/images/bubble-bottom.png R formats/Exhibit/ajax/images/bubble-left.png R formats/Exhibit/ajax/images/bubble-right.png R formats/Exhibit/ajax/images/bubble-top-left.png R formats/Exhibit/ajax/images/bubble-top-right.png R formats/Exhibit/ajax/images/bubble-top.png R formats/Exhibit/ajax/images/close-button.png R formats/Exhibit/ajax/images/copy.png R formats/Exhibit/ajax/images/message-bottom-left.png R formats/Exhibit/ajax/images/message-bottom-right.png R formats/Exhibit/ajax/images/message-left.png R formats/Exhibit/ajax/images/message-right.png R formats/Exhibit/ajax/images/message-top-left.png R formats/Exhibit/ajax/images/message-top-right.png R formats/Exhibit/ajax/loader.js R formats/Exhibit/ajax/scripts/ajax.js R formats/Exhibit/ajax/scripts/data-structure.js R formats/Exhibit/ajax/scripts/date-time.js R formats/Exhibit/ajax/scripts/debug.js R formats/Exhibit/ajax/scripts/dom.js R formats/Exhibit/ajax/scripts/graphics.js R formats/Exhibit/ajax/scripts/history.js R formats/Exhibit/ajax/scripts/html.js R formats/Exhibit/ajax/scripts/jquery-1.3.2.min.js R formats/Exhibit/ajax/scripts/json.js R formats/Exhibit/ajax/scripts/platform.js R formats/Exhibit/ajax/scripts/signal.js R formats/Exhibit/ajax/scripts/string.js R formats/Exhibit/ajax/scripts/units.js R formats/Exhibit/ajax/scripts/window-manager.js R formats/Exhibit/ajax/scripts/xmlhttp.js R formats/Exhibit/ajax/simile-ajax-api.js R formats/Exhibit/ajax/simile-ajax-bundle-debug.js R formats/Exhibit/ajax/simile-ajax-bundle.js R formats/Exhibit/exhibit/LICENSE.txt R formats/Exhibit/exhibit/compile-epilog.js R formats/Exhibit/exhibit/compile-prolog.js R formats/Exhibit/exhibit/exhibit-api.js R formats/Exhibit/exhibit/exhibit-bundle-debug.css R formats/Exhibit/exhibit/exhibit-bundle-debug.js R formats/Exhibit/exhibit/exhibit-bundle.css R formats/Exhibit/exhibit/exhibit-bundle.js R formats/Exhibit/exhibit/extensions/calendar/calendar-extension-bundle-debug.js R formats/Exhibit/exhibit/extensions/calendar/calendar-extension-bundle.css R formats/Exhibit/exhibit/extensions/calendar/calendar-extension-bundle.js R formats/Exhibit/exhibit/extensions/calendar/calendar-extension.js R formats/Exhibit/exhibit/extensions/calendar/compile-prolog.js R formats/Exhibit/exhibit/extensions/calendar/scripts/calendar-view.js R formats/Exhibit/exhibit/extensions/calendar/scripts/date-picker-facet.js R formats/Exhibit/exhibit/extensions/calendar/scripts/date-picker.js R formats/Exhibit/exhibit/extensions/calendar/scripts/date-util.js R formats/Exhibit/exhibit/extensions/calendar/styles/calendar-view.css R formats/Exhibit/exhibit/extensions/calendar/styles/date-picker-facet.css R formats/Exhibit/exhibit/extensions/chart/chart-extension-bundle-debug.js R formats/Exhibit/exhibit/extensions/chart/chart-extension-bundle.css R formats/Exhibit/exhibit/extensions/chart/chart-extension-bundle.js R formats/Exhibit/exhibit/extensions/chart/chart-extension.js R formats/Exhibit/exhibit/extensions/chart/compile-prolog.js R formats/Exhibit/exhibit/extensions/chart/locales/de/chart-locale.js R formats/Exhibit/exhibit/extensions/chart/locales/en/chart-locale.js R formats/Exhibit/exhibit/extensions/chart/locales/fr/chart-locale.js R formats/Exhibit/exhibit/extensions/chart/locales/nl/chart-locale.js R formats/Exhibit/exhibit/extensions/chart/scripts/bar-chart-view.js R formats/Exhibit/exhibit/extensions/chart/scripts/pivot-table-view.js R formats/Exhibit/exhibit/extensions/chart/scripts/scatter-plot-view.js R formats/Exhibit/exhibit/extensions/chart/styles/bar-chart-view.css R formats/Exhibit/exhibit/extensions/chart/styles/pivot-table-view.css R formats/Exhibit/exhibit/extensions/chart/styles/scatter-plot-view.css R formats/Exhibit/exhibit/extensions/curate/compile-prolog.js R formats/Exhibit/exhibit/extensions/curate/curate-extension-bundle-debug.js R formats/Exhibit/exhibit/extensions/curate/curate-extension-bundle.css R formats/Exhibit/exhibit/extensions/curate/curate-extension-bundle.js R formats/Exhibit/exhibit/extensions/curate/cura
[MediaWiki-commits] [Gerrit] Added tests for DiffOp classes - change (mediawiki...Wikibase[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Added tests for DiffOp classes .. Added tests for DiffOp classes Change-Id: I37b949bf1afbbb1735023212729111f02833621e --- M Diff/Diff.classes.php M Diff/Diff.php M Diff/INSTALL A Diff/tests/AbstractTestCase.php A Diff/tests/DiffOpAddTest.php A Diff/tests/DiffOpChangeTest.php A Diff/tests/DiffOpRemoveTest.php A Diff/tests/DiffOpTest.php M Diff/tests/DiffTest.php M Diff/tests/GenericArrayObjectTest.php M Diff/tests/ListDiffTest.php M Diff/tests/MapDiffTest.php 12 files changed, 421 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/30/16830/1 -- To view, visit https://gerrit.wikimedia.org/r/16830 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I37b949bf1afbbb1735023212729111f02833621e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Darft for Statement/Snak/Type/Value. DO NOT MERGE. - change (mediawiki...Wikibase[master])
Daniel Kinzler has uploaded a new change for review. Change subject: Darft for Statement/Snak/Type/Value. DO NOT MERGE. .. Darft for Statement/Snak/Type/Value. DO NOT MERGE. This is a quick draft of the interfaces used with Statements and Properties. This is submitted for comments and not yet operational, so don't merge it in - though merging should not have any adverse effects. Change-Id: Ia328f6edabdaaa45c33abb3f8cbd2bf1fbc97d66 --- A lib/includes/snak/NoValueSnak.php A lib/includes/snak/SimpleValueSnak.php A lib/includes/snak/Snak.php A lib/includes/statement/Statement.php A lib/includes/type/ItemReferenceType.php A lib/includes/type/SimpleStringType.php A lib/includes/type/Type.php A lib/includes/value/ItemReferenceValue.php A lib/includes/value/SimpleStringValue.php A lib/includes/value/Value.php 10 files changed, 294 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/29/16829/1 -- To view, visit https://gerrit.wikimedia.org/r/16829 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia328f6edabdaaa45c33abb3f8cbd2bf1fbc97d66 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Truncate also the sites table, it will be recreated after up... - change (mediawiki...Wikibase[master])
John Erling Blad has uploaded a new change for review. Change subject: Truncate also the sites table, it will be recreated after update .. Truncate also the sites table, it will be recreated after update Change-Id: I7a2a89ea788f5d846a631390759c1fc3dee02d05 --- M lib/maintenance/deleteAllData.php 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/28/16828/1 -- To view, visit https://gerrit.wikimedia.org/r/16828 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7a2a89ea788f5d846a631390759c1fc3dee02d05 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: John Erling Blad ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Per request on translatewiki, fix description of $wgResource... - change (mediawiki...Configure[master])
IAlex has submitted this change and it was merged. Change subject: Per request on translatewiki, fix description of $wgResourceLoaderDebug. .. Per request on translatewiki, fix description of $wgResourceLoaderDebug. Change-Id: I13744f5b353c358bad454aa5d496c74de49cfc50 --- M CHANGELOG M Configure.php M settings/Settings.i18n.php 3 files changed, 7 insertions(+), 4 deletions(-) Approvals: IAlex: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16827 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13744f5b353c358bad454aa5d496c74de49cfc50 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Configure Gerrit-Branch: master Gerrit-Owner: IAlex Gerrit-Reviewer: IAlex ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] SVN: [115627] trunk/tools/bugzilla/client
https://www.mediawiki.org/wiki/Special:Code/MediaWiki/115627
Revision: 115627
Author: mah
Date: 2012-07-27 16:12:46 + (Fri, 27 Jul 2012)
Log Message:
---
make the search iterator easier to subclass. Move infantile patch iterator
code to patch-finder.php
Modified Paths:
--
trunk/tools/bugzilla/client/bugzilla.php
trunk/tools/bugzilla/client/patch-finder.php
Modified: trunk/tools/bugzilla/client/bugzilla.php
===
--- trunk/tools/bugzilla/client/bugzilla.php2012-07-27 15:38:21 UTC (rev
115626)
+++ trunk/tools/bugzilla/client/bugzilla.php2012-07-27 16:12:46 UTC (rev
115627)
@@ -42,7 +42,7 @@
}
public function getPatches() {
- var_dump( $this->id );exit;
+ var_dump( $this->getAttachments() );exit;
}
public function getAttachments() {
@@ -248,12 +248,12 @@
}
class BugzillaSearchIterator implements Iterator {
- private $conditions;
- private $bz;
- private $data = array();
- private $limit = 20;
- private $offset = 0;
- private $eol = false;
+ protected $conditions;
+ protected $bz;
+ protected $data = array();
+ protected $limit = 20;
+ protected $offset = 0;
+ protected $eol = false;
public function __construct( $bz, $conditions ) {
$this->bz = $bz;
@@ -263,7 +263,12 @@
if( !isset( $this->conditions['offset'] ) )
$this->conditions['offset'] = $this->offset;
}
- private function fetchNext( ) {
+ /* Override this for other iterators */
+ public function getItem( $bug ) {
+ return BugzillaBug::newFromQuery($this->bz, $bug);
+ }
+
+ protected function fetchNext( ) {
if( $this->offset == count( $this->data ) && !$this->eol &&
$this->offset % $this->limit === 0 ) {
$results = $this->bz->search( $this->conditions );
@@ -274,7 +279,10 @@
}
foreach($results['bugs'] as $bug) {
- $this->data[] = BugzillaBug::newFromQuery(
$this->bz, $bug );
+ $val = $this->getItem( $bug );
+ if( $val ) {
+ $this->data[] = $val;
+ }
}
}
}
@@ -302,27 +310,6 @@
}
}
-class BugzillaPatchIterator extends BugzillaSearchIterator {
- private function fetchNext( ) {
- if( $this->offset == count( $this->data ) && !$this->eol &&
$this->offset % $this->limit === 0 ) {
- $results = $this->bz->search( $this->conditions );
-
- $this->conditions['offset'] += $this->limit;
-
- if( count( $results['bugs'] ) < $this->limit ) {
- $this->eol = true;
- }
-
- foreach($results['bugs'] as $bug) {
- $check = BugzillaBug::newFromQuery($this->bz,
$bug);
- foreach( $check->getPatches( $this->conditions[
'last_change_time' ] ) as $patch) {
- $this->data[] = $patch;
- }
- }
- }
- }
-}
-
class BugzillaWebClient {
private $bz = null;
private $lists = array( "blocks", "depends_on", "cc", "groups",
"keywords", "see_also" );
Modified: trunk/tools/bugzilla/client/patch-finder.php
===
--- trunk/tools/bugzilla/client/patch-finder.php2012-07-27 15:38:21 UTC
(rev 115626)
+++ trunk/tools/bugzilla/client/patch-finder.php2012-07-27 16:12:46 UTC
(rev 115627)
@@ -10,17 +10,32 @@
$terms = array(
"resolution" => array( "" ),
"product" => array( "MediaWiki", "MediaWiki extensions" ),
+ "last_change_time" => "2012-07-01T00:00:00Z"
);
+class BugzillaPatchIterator extends BugzillaSearchIterator {
+ public function getItem( $bug ) {
+ $check = BugzillaBug::newFromQuery($this->bz, $bug);
+ foreach( $check->getPatches( $this->conditions[
'last_change_time' ] ) as $patch) {
+ $this->data[] = $patch;
+ }
+ if( count( $this->data ) ) {
+ return $check;
+ }
+ return false;
+ }
+}
+
$bugList = array();
-$iter = new BugzillaSearchIterator( $bz, $terms );
+$iter = new BugzillaPatchIterator( $bz, $terms );
$message = "";
$count = 0 ;
foreach($iter as $bug) {
+ var_dump($bug);
$message .= "http://bugzilla.wikimedia.org/{$bug->getID()} --
{$bug->getAssignee()}\n";
$message .= "{$bug->getSummary()}\n";
- $count+
[MediaWiki-commits] [Gerrit] See changelog for Version 0.2-pre for list. - change (operations/dumps[ariel])
ArielGlenn has submitted this change and it was merged. Change subject: See changelog for Version 0.2-pre for list. .. See changelog for Version 0.2-pre for list. Lots of refactoring, finishing up some features, fixing broken things. Probably a couple more rouns of this to go before things get stable-ish. Change-Id: I144a0b1d1152adb0c4496be641af9cb58674abd2 --- M tools/yas3lib/CHANGELOG M tools/yas3lib/README.txt M tools/yas3lib/TODO.txt M tools/yas3lib/utils.py M tools/yas3lib/wmfarchive.py M tools/yas3lib/wmfmw.py M tools/yas3lib/yas3.py M tools/yas3lib/yas3archive.py M tools/yas3lib/yas3http.py M tools/yas3lib/yas3lib.py 10 files changed, 1,330 insertions(+), 913 deletions(-) Approvals: ArielGlenn: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16826 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I144a0b1d1152adb0c4496be641af9cb58674abd2 Gerrit-PatchSet: 1 Gerrit-Project: operations/dumps Gerrit-Branch: ariel Gerrit-Owner: ArielGlenn Gerrit-Reviewer: ArielGlenn ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Make Special:ShortUrl subclass UnlistedSpecialPage - change (mediawiki...ShortUrl[master])
Hashar has submitted this change and it was merged. Change subject: Make Special:ShortUrl subclass UnlistedSpecialPage .. Make Special:ShortUrl subclass UnlistedSpecialPage Just viewing the special page (in it's current state at least), doesn't actually do anything rather than give a warning 'shorturl-not-found-title', so little point having it listed in Special:SpecialPages at this time Change-Id: I88a3c625dd3f63b246700b4d135feed091c2cef1 --- M SpecialShortUrl.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Hashar: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16825 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88a3c625dd3f63b246700b4d135feed091c2cef1 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ShortUrl Gerrit-Branch: master Gerrit-Owner: Reedy Gerrit-Reviewer: Hashar Gerrit-Reviewer: Yuvipanda ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] See changelog for Version 0.2-pre for list. - change (operations/dumps[ariel])
ArielGlenn has uploaded a new change for review. Change subject: See changelog for Version 0.2-pre for list. .. See changelog for Version 0.2-pre for list. Lots of refactoring, finishing up some features, fixing broken things. Probably a couple more rouns of this to go before things get stable-ish. Change-Id: I144a0b1d1152adb0c4496be641af9cb58674abd2 --- M tools/yas3lib/CHANGELOG M tools/yas3lib/README.txt M tools/yas3lib/TODO.txt M tools/yas3lib/utils.py M tools/yas3lib/wmfarchive.py M tools/yas3lib/wmfmw.py M tools/yas3lib/yas3.py M tools/yas3lib/yas3archive.py M tools/yas3lib/yas3http.py M tools/yas3lib/yas3lib.py 10 files changed, 1,330 insertions(+), 913 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/dumps refs/changes/26/16826/1 -- To view, visit https://gerrit.wikimedia.org/r/16826 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I144a0b1d1152adb0c4496be641af9cb58674abd2 Gerrit-PatchSet: 1 Gerrit-Project: operations/dumps Gerrit-Branch: ariel Gerrit-Owner: ArielGlenn ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] SVN: [115626] trunk/tools/bugzilla/client/bugzilla.php
https://www.mediawiki.org/wiki/Special:Code/MediaWiki/115626
Revision: 115626
Author: mah
Date: 2012-07-27 15:38:21 + (Fri, 27 Jul 2012)
Log Message:
---
don't override limit and offset if the user provides them.
Modified Paths:
--
trunk/tools/bugzilla/client/bugzilla.php
Modified: trunk/tools/bugzilla/client/bugzilla.php
===
--- trunk/tools/bugzilla/client/bugzilla.php2012-07-27 15:25:34 UTC (rev
115625)
+++ trunk/tools/bugzilla/client/bugzilla.php2012-07-27 15:38:21 UTC (rev
115626)
@@ -259,8 +259,8 @@
$this->bz = $bz;
$this->conditions = $conditions;
- $this->conditions['limit'] = $this->limit;
- $this->conditions['offset'] = $this->offset;
+ if( !isset( $this->conditions['limit'] ) )
$this->conditions['limit'] = $this->limit;
+ if( !isset( $this->conditions['offset'] ) )
$this->conditions['offset'] = $this->offset;
}
private function fetchNext( ) {
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
