[MediaWiki-commits] [Gerrit] Replace the expand button with label - change (mediawiki...Translate[master])

2012-12-05 Thread Siebrand (Code Review)
Siebrand has submitted this change and it was merged.

Change subject: Replace the expand button with label
..


Replace the expand button with label

And keep the selector open across selections

Change-Id: Ic23c4fca2e6ccb81d8687f79e00022fb1a796d54
---
M resources/css/ext.translate.groupselector.css
M resources/js/ext.translate.groupselector.js
2 files changed, 26 insertions(+), 20 deletions(-)

Approvals:
  Siebrand: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36736
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic23c4fca2e6ccb81d8687f79e00022fb1a796d54
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Santhosh 
Gerrit-Reviewer: Santhosh 
Gerrit-Reviewer: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Use WikiPage::factory() instead of new Article - change (mediawiki...Translate[master])

2012-12-05 Thread Nikerabbit (Code Review)
Nikerabbit has submitted this change and it was merged.

Change subject: Use WikiPage::factory() instead of new Article
..


Use WikiPage::factory() instead of new Article

Change-Id: Ib0349d19640db1adc5598384905f2c4a75de89b0
---
M utils/MessageUpdateJob.php
M utils/MessageWebImporter.php
2 files changed, 4 insertions(+), 6 deletions(-)

Approvals:
  Nikerabbit: Looks good to me, approved
  jenkins-bot: Verified; Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/36924
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0349d19640db1adc5598384905f2c4a75de89b0
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Siebrand 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 42699) Undefined variable $id in ApiAggregateGroups - change (mediawiki...Translate[master])

2012-12-05 Thread Nikerabbit (Code Review)
Nikerabbit has uploaded a new change for review.

Change subject: (bug 42699) Undefined variable $id in ApiAggregateGroups
..

(bug 42699) Undefined variable $id in ApiAggregateGroups

Change-Id: I6193bc15a0a068a52eeb13d50754eb3abe86707c
---
M api/ApiAggregateGroups.php
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/56/36956/1
--
To view, visit https://gerrit.wikimedia.org/r/36956
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6193bc15a0a068a52eeb13d50754eb3abe86707c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix docs - change (mediawiki...Translate[master])

2012-12-05 Thread Nikerabbit (Code Review)
Nikerabbit has uploaded a new change for review.

Change subject: Fix docs
..

Fix docs

* Author info belongs to file comment
* Use Traversable etc.
* Typehints

Change-Id: Ie7b9f1e34ca04c31e1328ff32cf1607153cd679b
---
M MessageChecks.php
1 file changed, 31 insertions(+), 32 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/57/36957/1
--
To view, visit https://gerrit.wikimedia.org/r/36957
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie7b9f1e34ca04c31e1328ff32cf1607153cd679b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Demos: Fix for I53b041f8 fixing Idbff4c51 fixing I840f7242 - change (mediawiki...VisualEditor[master])

2012-12-05 Thread Christian (Code Review)
Christian has submitted this change and it was merged.

Change subject: Demos: Fix for I53b041f8 fixing Idbff4c51 fixing I840f7242
..


Demos: Fix for I53b041f8 fixing Idbff4c51 fixing I840f7242

Change-Id: I860b0441c055cb1f4c04dff7ffdb4f9fafd42cc1
---
M demos/ve/index.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Krinkle: Verified
  Christian: Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36953
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I860b0441c055cb1f4c04dff7ffdb4f9fafd42cc1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Krinkle 
Gerrit-Reviewer: Christian 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Trevor Parscal 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (Bug 42561) On CodeEditorGetPageLanguage, set 'json' as sche... - change (mediawiki...EventLogging[master])

2012-12-05 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged.

Change subject: (Bug 42561) On CodeEditorGetPageLanguage, set 'json' as schema 
lang
..


(Bug 42561) On CodeEditorGetPageLanguage, set 'json' as schema lang

This will trigger Extension:CodeEditor to replace the edit UI with a
JSON-aware code editor. If the extension is not installed, it just
sits there harmlessly.

Change-Id: I710d226f1e6ad5a58b9ad8669b8a7ff9f0e8891c
---
M content/JsonSchemaHooks.php
1 file changed, 17 insertions(+), 0 deletions(-)

Approvals:
  Ori.livneh: Verified; Looks good to me, approved
  Mattflaschen: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/36344
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I710d226f1e6ad5a58b9ad8669b8a7ff9f0e8891c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: MZMcBride 
Gerrit-Reviewer: Mattflaschen 
Gerrit-Reviewer: Ori.livneh 
Gerrit-Reviewer: Spage 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Small doc fixes - change (mediawiki...Translate[master])

2012-12-05 Thread Nikerabbit (Code Review)
Nikerabbit has uploaded a new change for review.

Change subject: Small doc fixes
..

Small doc fixes

Change-Id: I285c0bd9e8cc60a22b31dc27223aadb11626ba03
---
M TranslateUtils.php
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/58/36958/1
--
To view, visit https://gerrit.wikimedia.org/r/36958
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I285c0bd9e8cc60a22b31dc27223aadb11626ba03
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Use $wgNamespaceContentModels to register content model - change (mediawiki...EventLogging[master])

2012-12-05 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged.

Change subject: Use $wgNamespaceContentModels to register content model
..


Use $wgNamespaceContentModels to register content model

Use $wgNamespaceContentModels to register JsonSchema content model for
the entirety of NS_SCHEMA, rather than rely on a hook. Load CSS
syncronously so that Schema pages look right even when JS is disabled.

Change-Id: Iaf97dde8d9e57bf9c62a46e931c7b1db5991c23b
---
M content/JsonSchemaHooks.php
1 file changed, 10 insertions(+), 16 deletions(-)

Approvals:
  Ori.livneh: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36380
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf97dde8d9e57bf9c62a46e931c7b1db5991c23b
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 
Gerrit-Reviewer: Mattflaschen 
Gerrit-Reviewer: Ori.livneh 
Gerrit-Reviewer: Spage 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Report correct MIME type ("application/json") for JSON schem... - change (mediawiki...EventLogging[master])

2012-12-05 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged.

Change subject: Report correct MIME type ("application/json") for JSON schema
..


Report correct MIME type ("application/json") for JSON schema

Change-Id: I256a87ce912ff8492cb5fd9c55bd27a5b34a3ce2
---
M content/JsonSchemaContentHandler.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Ori.livneh: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36502
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I256a87ce912ff8492cb5fd9c55bd27a5b34a3ce2
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 
Gerrit-Reviewer: Mattflaschen 
Gerrit-Reviewer: Ori.livneh 
Gerrit-Reviewer: Spage 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Allow modules to specify schema revision - change (mediawiki...EventLogging[master])

2012-12-05 Thread Gerrit Code Review
Anonymous Coward has submitted this change and it was merged.

Change subject: Allow modules to specify schema revision
..


Allow modules to specify schema revision

Change-Id: I3f7f7bd844b125ee35537e8c0fccdc2a84a10e64
---
M EventLogging.module.php
M EventLogging.php
2 files changed, 42 insertions(+), 16 deletions(-)


--
To view, visit https://gerrit.wikimedia.org/r/36503
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3f7f7bd844b125ee35537e8c0fccdc2a84a10e64
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 
Gerrit-Reviewer: Mattflaschen 
Gerrit-Reviewer: Ori.livneh 
Gerrit-Reviewer: Spage 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add S Page to authors - change (mediawiki...EventLogging[master])

2012-12-05 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged.

Change subject: Add S Page to authors
..


Add S Page to authors

Change-Id: Ib822d931eb4bcdbb5a48c0a2e5db21304e47e6e3
---
M EventLogging.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Ori.livneh: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36598
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib822d931eb4bcdbb5a48c0a2e5db21304e47e6e3
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 
Gerrit-Reviewer: Ori.livneh 
Gerrit-Reviewer: Spage 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mwext-VisualEditor-jslint now voting - change (integration/zuul-config[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has uploaded a new change for review.

Change subject: mwext-VisualEditor-jslint now voting
..

mwext-VisualEditor-jslint now voting

The VisualEditor extension is passing JShint and the team would like it
to be a blocker whenever it fails.

Change-Id: If1ad005380021afb6332d61518c0cda49e025b28
---
M layout.yaml
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/zuul-config 
refs/changes/59/36959/1
--
To view, visit https://gerrit.wikimedia.org/r/36959
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If1ad005380021afb6332d61518c0cda49e025b28
Gerrit-PatchSet: 1
Gerrit-Project: integration/zuul-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mwext-VisualEditor-jslint now voting - change (integration/zuul-config[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has submitted this change and it was merged.

Change subject: mwext-VisualEditor-jslint now voting
..


mwext-VisualEditor-jslint now voting

The VisualEditor extension is passing JShint and the team would like it
to be a blocker whenever it fails.

Change-Id: If1ad005380021afb6332d61518c0cda49e025b28
---
M layout.yaml
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Hashar: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36959
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If1ad005380021afb6332d61518c0cda49e025b28
Gerrit-PatchSet: 1
Gerrit-Project: integration/zuul-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 
Gerrit-Reviewer: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 42677) - Status bar rendering slow in Firefox - change (mediawiki...Translate[master])

2012-12-05 Thread Santhosh (Code Review)
Santhosh has uploaded a new change for review.

Change subject: (bug 42677) - Status bar rendering slow in Firefox
..

(bug 42677) - Status bar rendering slow in Firefox

Avoid multiple api hits by getting the data ready on page load

Change-Id: If2bd7f9a2d62910f7067801c9e26ddcf33402aba
---
M resources/ext.translate.special.translate.js
M resources/js/ext.translate.statsbar.js
2 files changed, 26 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/60/36960/1
--
To view, visit https://gerrit.wikimedia.org/r/36960
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If2bd7f9a2d62910f7067801c9e26ddcf33402aba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Santhosh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Improve documentation for "pipe trick" - change (mediawiki/core[master])

2012-12-05 Thread Nikerabbit (Code Review)
Nikerabbit has submitted this change and it was merged.

Change subject: Improve documentation for "pipe trick"
..


Improve documentation for "pipe trick"

- Actually mention "pipe trick" so the code is searchable
- Use spaces rather than tabs for vertical alignment
- Clarify comment for double-width brackets and mention revision it was added

Change-Id: Iaf365e313144e378133fb16c64efa5b7e47d4a6a
---
M includes/parser/Parser.php
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Hydriz: Looks good to me, but someone else must approve
  Nikerabbit: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/32209
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf365e313144e378133fb16c64efa5b7e47d4a6a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Waldir 
Gerrit-Reviewer: Hydriz 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Waldir 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 42619) Adjust comment for log_params database field - change (mediawiki/core[master])

2012-12-05 Thread Nikerabbit (Code Review)
Nikerabbit has submitted this change and it was merged.

Change subject: (bug 42619) Adjust comment for log_params database field
..


(bug 42619) Adjust comment for log_params database field

Change-Id: Ib78fd5ad7bef78b07460200d5d8b143e5a9a8802
---
M maintenance/tables.sql
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Nikerabbit: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/36388
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib78fd5ad7bef78b07460200d5d8b143e5a9a8802
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: IAlex 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 36211) add cursor:pointer to .mw-enhancedchanges-arrow - change (mediawiki/core[master])

2012-12-05 Thread Nikerabbit (Code Review)
Nikerabbit has submitted this change and it was merged.

Change subject: (bug 36211) add cursor:pointer to .mw-enhancedchanges-arrow
..


(bug 36211) add cursor:pointer to .mw-enhancedchanges-arrow

With this, the arrow is shown with a pointer and looks like clicking on
a link. Without this, the user has no feedback, that he can click the
arrow.

Change-Id: I8bee6e51b1786785128d56931dc1ff9a09ba1d78
---
M resources/mediawiki.special/mediawiki.special.changeslist.css
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Nikerabbit: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/36361
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8bee6e51b1786785128d56931dc1ff9a09ba1d78
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Matmarex 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 37263) better handling of minor/bot in enhanced changel... - change (mediawiki/core[master])

2012-12-05 Thread Nikerabbit (Code Review)
Nikerabbit has submitted this change and it was merged.

Change subject: (bug 37263) better handling of minor/bot in enhanced changelist
..


(bug 37263) better handling of minor/bot in enhanced changelist

It makes more sense, to have the whole group as minor/bot, when all of
the group are minor or bot edits, not when only one of the group is
minor/bot.

Change-Id: I62bf1099f2e3fb73e9b50374cbb7ba8bfd8a009e
---
M includes/ChangesList.php
1 file changed, 13 insertions(+), 5 deletions(-)

Approvals:
  Nikerabbit: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/36360
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I62bf1099f2e3fb73e9b50374cbb7ba8bfd8a009e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fixed bug in wb.ui.Toolbar when adding same element multiple... - change (mediawiki...Wikibase[master])

2012-12-05 Thread Henning Snater (Code Review)
Henning Snater has submitted this change and it was merged.

Change subject: Fixed bug in wb.ui.Toolbar when adding same element multiple 
times
..


Fixed bug in wb.ui.Toolbar when adding same element multiple times

Adding the same element multiple times is no longer possible. When adding an 
element already in the toolbar, it will be moved set to the given index. Also 
added a getLength() function and updated tests.

Change-Id: Ia1912219c50b76310ff58267149f60a924e16787
---
M lib/resources/wikibase.ui.Toolbar.js
M lib/tests/qunit/wikibase.ui.Toolbar.tests.js
2 files changed, 56 insertions(+), 0 deletions(-)

Approvals:
  Henning Snater: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36590
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1912219c50b76310ff58267149f60a924e16787
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner 
Gerrit-Reviewer: Henning Snater 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update logging to latest standards, including pretty formatt... - change (mediawiki...Renameuser[master])

2012-12-05 Thread Nikerabbit (Code Review)
Nikerabbit has submitted this change and it was merged.

Change subject: Update logging to latest standards, including pretty formatting.
..


Update logging to latest standards, including pretty formatting.

Compatible with MediaWiki 1.19 and later.

Change-Id: I4be1fdb79d1c1008b033feb58ee20c6b059c0c46
---
M Renameuser.i18n.php
M Renameuser.php
M Renameuser_body.php
3 files changed, 103 insertions(+), 45 deletions(-)

Approvals:
  Nikerabbit: Verified; Looks good to me, approved
  Siebrand: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/5288
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4be1fdb79d1c1008b033feb58ee20c6b059c0c46
Gerrit-PatchSet: 21
Gerrit-Project: mediawiki/extensions/Renameuser
Gerrit-Branch: master
Gerrit-Owner: GKarunakar 
Gerrit-Reviewer: Liangent 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Santhosh 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: Toniher 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Added classes 'wb-edit' to claim widget and claim section wh... - change (mediawiki...Wikibase[master])

2012-12-05 Thread Henning Snater (Code Review)
Henning Snater has submitted this change and it was merged.

Change subject: Added classes 'wb-edit' to claim widget and claim section when 
editing
..


Added classes 'wb-edit' to claim widget and claim section when editing

Change-Id: I0ca0a52d6c09a51edc5d3ed1063dafa48b6cd9f6
---
M lib/resources/jquery.wikibase/jquery.wikibase.claimlistview.js
M lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
2 files changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Henning Snater: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36788
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0ca0a52d6c09a51edc5d3ed1063dafa48b6cd9f6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner 
Gerrit-Reviewer: Henning Snater 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] revert UIDGenerator work in progress - change (mediawiki/core[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has uploaded a new change for review.

Change subject: revert UIDGenerator work in progress
..

revert UIDGenerator work in progress

Several commits have been made in master which introduced the
UIDGenerator class. They got merged a bit too fast without proper review
so this commit revert the commits so the Authors can move the code back
in Gerrit review queue.

Following commit / change are reverted:

 - 7ac3edd https://gerrit.wikimedia.org/r/36803
 - 036d03b https://gerrit.wikimedia.org/r/36813
 - 2b168e3 https://gerrit.wikimedia.org/r/36812
 - 6030d92 https://gerrit.wikimedia.org/r/36801

See wikitech-l thread
http://lists.wikimedia.org/pipermail/wikitech-l/2012-December/064801.html

Change-Id: Ie39fde2ee4121372b6d790943f306e56fbacc2b5
---
M includes/AutoLoader.php
D includes/UIDGenerator.php
2 files changed, 0 insertions(+), 311 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/61/36961/1
--
To view, visit https://gerrit.wikimedia.org/r/36961
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie39fde2ee4121372b6d790943f306e56fbacc2b5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 42677) - Status bar rendering slow in Firefox - change (mediawiki...Translate[master])

2012-12-05 Thread Santhosh (Code Review)
Santhosh has submitted this change and it was merged.

Change subject: (bug 42677) - Status bar rendering slow in Firefox
..


(bug 42677) - Status bar rendering slow in Firefox

Avoid multiple api hits by getting the data ready on page load

Change-Id: If2bd7f9a2d62910f7067801c9e26ddcf33402aba
---
M resources/ext.translate.special.translate.js
M resources/js/ext.translate.statsbar.js
2 files changed, 54 insertions(+), 45 deletions(-)

Approvals:
  Santhosh: Verified; Looks good to me, approved
  Nikerabbit: Looks good to me, approved
  jenkins-bot: Verified; Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/36960
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If2bd7f9a2d62910f7067801c9e26ddcf33402aba
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Santhosh 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Santhosh 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Improving entity selector widget style - change (mediawiki...Wikibase[master])

2012-12-05 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged.

Change subject: Improving entity selector widget style
..


Improving entity selector widget style

Removing the blank frame around each suggestion list item when hovering over an 
item.

- patch set 2: adjusted QUnit tests
- patch set 4: rebase
- patch set 5: adjusted selenium tests

Change-Id: Ic22e3ad7c5663f1ee53b2041a923a79aca100bdd
---
M lib/resources/jquery.ui/jquery.ui.entityselector.js
M lib/resources/jquery.ui/themes/default/jquery.ui.entityselector.css
M lib/tests/qunit/jquery.ui/jquery.ui.entityselector.tests.js
M repo/tests/selenium/statements/statements_spec.rb
M selenium/lib/modules/entity_selector_module.rb
5 files changed, 17 insertions(+), 14 deletions(-)

Approvals:
  Tobias Gritschacher: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36555
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic22e3ad7c5663f1ee53b2041a923a79aca100bdd
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater 
Gerrit-Reviewer: Daniel Werner 
Gerrit-Reviewer: Henning Snater 
Gerrit-Reviewer: Tobias Gritschacher 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (no bug) add template engine qunit tests to selenium - change (mediawiki...Wikibase[master])

2012-12-05 Thread Jens Ohlig (Code Review)
Jens Ohlig has submitted this change and it was merged.

Change subject: (no bug) add template engine qunit tests to selenium
..


(no bug) add template engine qunit tests to selenium

Change-Id: I27e0a76683a7792f761b532fd8d1ecca222629e2
---
M repo/tests/selenium/qunit/qunit_spec.rb
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Jens Ohlig: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36565
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I27e0a76683a7792f761b532fd8d1ecca222629e2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher 
Gerrit-Reviewer: Anja Jentzsch 
Gerrit-Reviewer: Aude 
Gerrit-Reviewer: Henning Snater 
Gerrit-Reviewer: Jens Ohlig 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (no bug) make selenium tests independent from ULS - change (mediawiki...Wikibase[master])

2012-12-05 Thread Jens Ohlig (Code Review)
Jens Ohlig has submitted this change and it was merged.

Change subject: (no bug) make selenium tests independent from ULS
..


(no bug) make selenium tests independent from ULS

- selenium tests now use the uselang-parameter as fallback for switching
  language when ULS is not activated

Change-Id: I4db33b13eeb6139f49b1e7d2ac13ae711be109a2
---
M repo/tests/selenium/language_selector/language_selector_spec.rb
M repo/tests/selenium/special/create_item_spec.rb
M repo/tests/selenium/special/create_property_spec.rb
M repo/tests/selenium/special/entities_without_label_spec.rb
M repo/tests/selenium/special/item_disambiguation_spec.rb
M repo/tests/selenium/special/set_label_spec.rb
M selenium/lib/modules/uls_module.rb
7 files changed, 37 insertions(+), 21 deletions(-)

Approvals:
  Jens Ohlig: Verified; Looks good to me, approved
  Anja Jentzsch: Verified; Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/36562
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4db33b13eeb6139f49b1e7d2ac13ae711be109a2
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher 
Gerrit-Reviewer: Anja Jentzsch 
Gerrit-Reviewer: Henning Snater 
Gerrit-Reviewer: Jens Ohlig 
Gerrit-Reviewer: Tobias Gritschacher 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 42683) new option withoutTermSearchKey - change (mediawiki...Wikibase[mw1.21-wmf5])

2012-12-05 Thread Daniel Kinzler (Code Review)
Daniel Kinzler has uploaded a new change for review.

Change subject: (bug 42683) new option withoutTermSearchKey
..

(bug 42683) new option withoutTermSearchKey

withoutTermSearchKey disables the use of wb_terms.term_search_key, so sites
that don't have this column and can't easily add it can still use the latest
Wikibase code.

Change-Id: I729393f28680401cc5fa289d0542db8a688076bd
---
M repo/Wikibase.hooks.php
M repo/includes/store/sql/SqlStore.php
M repo/includes/store/sql/TermSqlCache.php
M repo/tests/phpunit/includes/store/TermCacheTest.php
M repo/tests/phpunit/includes/store/sql/TermSqlCacheTest.php
5 files changed, 35 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/62/36962/1
--
To view, visit https://gerrit.wikimedia.org/r/36962
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I729393f28680401cc5fa289d0542db8a688076bd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.21-wmf5
Gerrit-Owner: Daniel Kinzler 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 42681) check if the site table exists and site code is ... - change (mediawiki...Wikibase[master])

2012-12-05 Thread Jens Ohlig (Code Review)
Jens Ohlig has submitted this change and it was merged.

Change subject: (bug 42681) check if the site table exists and site code is 
valid
..


(bug 42681) check if the site table exists and site code is valid

Change-Id: I6324dc1f6448bba7f7ee6eb1b046f5d0018c9c92
---
M client/WikibaseClient.hooks.php
M client/includes/ClientChangeHandler.php
2 files changed, 14 insertions(+), 0 deletions(-)

Approvals:
  Tobias Gritschacher: Looks good to me, but someone else must approve
  Jens Ohlig: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36756
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6324dc1f6448bba7f7ee6eb1b046f5d0018c9c92
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude 
Gerrit-Reviewer: Aude 
Gerrit-Reviewer: Jens Ohlig 
Gerrit-Reviewer: Tobias Gritschacher 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 42683) new option withoutTermSearchKey - change (mediawiki...Wikibase[mw1.21-wmf5])

2012-12-05 Thread Daniel Kinzler (Code Review)
Daniel Kinzler has submitted this change and it was merged.

Change subject: (bug 42683) new option withoutTermSearchKey
..


(bug 42683) new option withoutTermSearchKey

withoutTermSearchKey disables the use of wb_terms.term_search_key, so sites
that don't have this column and can't easily add it can still use the latest
Wikibase code.

Change-Id: I729393f28680401cc5fa289d0542db8a688076bd
---
M repo/Wikibase.hooks.php
M repo/includes/store/sql/SqlStore.php
M repo/includes/store/sql/TermSqlCache.php
M repo/tests/phpunit/includes/store/TermCacheTest.php
M repo/tests/phpunit/includes/store/sql/TermSqlCacheTest.php
5 files changed, 35 insertions(+), 12 deletions(-)

Approvals:
  Daniel Kinzler: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36962
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I729393f28680401cc5fa289d0542db8a688076bd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.21-wmf5
Gerrit-Owner: Daniel Kinzler 
Gerrit-Reviewer: Daniel Kinzler 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] clear wikibase client recent changes when using deleteAllDat... - change (mediawiki...Wikibase[master])

2012-12-05 Thread Jens Ohlig (Code Review)
Jens Ohlig has submitted this change and it was merged.

Change subject: clear wikibase client recent changes when using deleteAllData
..


clear wikibase client recent changes when using deleteAllData

Change-Id: I3fd7cbe2bfa69b61a736e57abac116c49aebc95e
---
M client/WikibaseClient.hooks.php
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Jens Ohlig: Verified; Looks good to me, approved

Objections:
  Jeroen De Dauw: There's a problem with this change, please improve


--
To view, visit https://gerrit.wikimedia.org/r/33558
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3fd7cbe2bfa69b61a736e57abac116c49aebc95e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude 
Gerrit-Reviewer: Aude 
Gerrit-Reviewer: Jens Ohlig 
Gerrit-Reviewer: Jeroen De Dauw 
Gerrit-Reviewer: John Erling Blad 
Gerrit-Reviewer: Tobias Gritschacher 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Bug 42050 - improve timedmedia-subtitle-new-desc - change (mediawiki...TimedMediaHandler[master])

2012-12-05 Thread J (Code Review)
J has submitted this change and it was merged.

Change subject: Bug 42050 -  improve timedmedia-subtitle-new-desc
..


Bug 42050 -  improve timedmedia-subtitle-new-desc

Change-Id: Iab29f071cd3df2145b29bd1db8bb48990fefc48c
---
M TimedMediaHandler.i18n.php
M TimedTextPage.php
2 files changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Siebrand: Looks good to me, but someone else must approve
  J: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36766
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iab29f071cd3df2145b29bd1db8bb48990fefc48c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: J 
Gerrit-Reviewer: J 
Gerrit-Reviewer: Mdale 
Gerrit-Reviewer: Raimond Spekking 
Gerrit-Reviewer: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Dont show credits at end for audio clips - change (mediawiki...TimedMediaHandler[master])

2012-12-05 Thread J (Code Review)
J has submitted this change and it was merged.

Change subject: Dont show credits at end for audio clips
..


Dont show credits at end for audio clips

dont show credits at end of audio clips, audio samples are used in many
places where showing the menu is a bit strang, i.e. Wiktionary's audio
samples.

Change-Id: I46e03dc1957d65184b77e05d6fb8d8008389979f
---
M resources/mw.MediaWikiPlayerSupport.js
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Mdale: Verified; Looks good to me, approved
  J: 


--
To view, visit https://gerrit.wikimedia.org/r/36767
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I46e03dc1957d65184b77e05d6fb8d8008389979f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: J 
Gerrit-Reviewer: J 
Gerrit-Reviewer: Mdale 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (no bug) Correct singular form in output of pollForChanges.p... - change (mediawiki...Wikibase[master])

2012-12-05 Thread Aude (Code Review)
Aude has submitted this change and it was merged.

Change subject: (no bug) Correct singular form in output of pollForChanges.php
..


(no bug) Correct singular form in output of pollForChanges.php

Change-Id: I295e2d599951e069db30fed24e024c3fdbbf2150
---
M lib/maintenance/pollForChanges.php
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Aude: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36783
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I295e2d599951e069db30fed24e024c3fdbbf2150
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jens Ohlig 
Gerrit-Reviewer: Anja Jentzsch 
Gerrit-Reviewer: Aude 
Gerrit-Reviewer: Daniel Kinzler 
Gerrit-Reviewer: Denny Vrandecic 
Gerrit-Reviewer: Jens Ohlig 
Gerrit-Reviewer: Jeroen De Dauw 
Gerrit-Reviewer: John Erling Blad 
Gerrit-Reviewer: Tobias Gritschacher 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Small doc fixes - change (mediawiki...Translate[master])

2012-12-05 Thread Siebrand (Code Review)
Siebrand has submitted this change and it was merged.

Change subject: Small doc fixes
..


Small doc fixes

Change-Id: I285c0bd9e8cc60a22b31dc27223aadb11626ba03
---
M TranslateUtils.php
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Siebrand: Looks good to me, approved
  jenkins-bot: Verified; Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/36958
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I285c0bd9e8cc60a22b31dc27223aadb11626ba03
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (minor) Improving documentation of profiling settings. - change (mediawiki...Wikibase[master])

2012-12-05 Thread Daniel Kinzler (Code Review)
Daniel Kinzler has uploaded a new change for review.

Change subject: (minor) Improving documentation of profiling settings.
..

(minor) Improving documentation of profiling settings.

Change-Id: I1d57ca84a55cfec6e6979ac0eebeffe72f866722
---
M lib/ProfilingSettings.php
1 file changed, 12 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/63/36963/1
--
To view, visit https://gerrit.wikimedia.org/r/36963
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d57ca84a55cfec6e6979ac0eebeffe72f866722
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (minor) Improving documentation of profiling settings. - change (mediawiki...Wikibase[master])

2012-12-05 Thread Aude (Code Review)
Aude has submitted this change and it was merged.

Change subject: (minor) Improving documentation of profiling settings.
..


(minor) Improving documentation of profiling settings.

Change-Id: I1d57ca84a55cfec6e6979ac0eebeffe72f866722
---
M lib/ProfilingSettings.php
1 file changed, 12 insertions(+), 12 deletions(-)

Approvals:
  Aude: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36963
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1d57ca84a55cfec6e6979ac0eebeffe72f866722
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler 
Gerrit-Reviewer: Aude 
Gerrit-Reviewer: Silke Meyer 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 42475) Hide anons and logged in users filters with Wiki... - change (mediawiki...Wikibase[master])

2012-12-05 Thread Aude (Code Review)
Aude has submitted this change and it was merged.

Change subject: (bug 42475) Hide anons and logged in users filters with 
Wikidata changes
..


(bug 42475) Hide anons and logged in users filters with Wikidata changes

Change-Id: I4b49a0c2c717d803170735f89204fec0253adf07
---
M client/WikibaseClient.hooks.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Aude: Verified; Looks good to me, approved
  Anja Jentzsch: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/36770
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4b49a0c2c717d803170735f89204fec0253adf07
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jens Ohlig 
Gerrit-Reviewer: Anja Jentzsch 
Gerrit-Reviewer: Aude 
Gerrit-Reviewer: Daniel Kinzler 
Gerrit-Reviewer: Jens Ohlig 
Gerrit-Reviewer: John Erling Blad 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Generate some more extensions - change (integration/jenkins-job-builder-config[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has uploaded a new change for review.

Change subject: Generate some more extensions
..

Generate some more extensions

Echo
EventLogging
GeoData
RenameUser
Score
TimedMediaHandler

Change-Id: I7dc18b9789fcb196c4237eef7cbb6805e90c5432
---
M mediawiki-extensions.yaml
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/integration/jenkins-job-builder-config 
refs/changes/64/36964/1
--
To view, visit https://gerrit.wikimedia.org/r/36964
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7dc18b9789fcb196c4237eef7cbb6805e90c5432
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins-job-builder-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Generate some more extensions - change (integration/jenkins-job-builder-config[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has submitted this change and it was merged.

Change subject: Generate some more extensions
..


Generate some more extensions

Echo
EventLogging
GeoData
RenameUser
Score
TimedMediaHandler

Change-Id: I7dc18b9789fcb196c4237eef7cbb6805e90c5432
---
M mediawiki-extensions.yaml
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Hashar: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36964
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7dc18b9789fcb196c4237eef7cbb6805e90c5432
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins-job-builder-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 
Gerrit-Reviewer: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Make the load all messages button in group selector work. - change (mediawiki...Translate[master])

2012-12-05 Thread Santhosh (Code Review)
Santhosh has uploaded a new change for review.

Change subject: Make the load all messages button in group selector work.
..

Make the load all messages button in group selector work.

Change-Id: I0684819ee1a1c564d8a2cf9674c53cfa9fa33b12
---
M resources/ext.translate.special.translate.js
M resources/js/ext.translate.groupselector.js
2 files changed, 26 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/65/36965/1
--
To view, visit https://gerrit.wikimedia.org/r/36965
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0684819ee1a1c564d8a2cf9674c53cfa9fa33b12
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Santhosh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] add more extensions - change (integration/zuul-config[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has uploaded a new change for review.

Change subject: add more extensions
..

add more extensions

Echo
EventLogging
GeoData
RenameUser (no PHPUnit tests yet)
Score (no PHPUnit tests yet)
TimedMediaHandler

Change-Id: Ia25ff32d85641db46142801a4edc3aa03f0bd9ab
---
M layout.yaml
1 file changed, 76 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/zuul-config 
refs/changes/66/36966/1
--
To view, visit https://gerrit.wikimedia.org/r/36966
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia25ff32d85641db46142801a4edc3aa03f0bd9ab
Gerrit-PatchSet: 1
Gerrit-Project: integration/zuul-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] add more extensions - change (integration/zuul-config[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has submitted this change and it was merged.

Change subject: add more extensions
..


add more extensions

Echo
EventLogging
GeoData
RenameUser (no PHPUnit tests yet)
Score (no PHPUnit tests yet)
TimedMediaHandler

Change-Id: Ia25ff32d85641db46142801a4edc3aa03f0bd9ab
---
M layout.yaml
1 file changed, 76 insertions(+), 0 deletions(-)

Approvals:
  Hashar: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36966
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia25ff32d85641db46142801a4edc3aa03f0bd9ab
Gerrit-PatchSet: 1
Gerrit-Project: integration/zuul-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 
Gerrit-Reviewer: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] validate jenkins job - change (mediawiki...Echo[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has uploaded a new change for review.

Change subject: validate jenkins job
..

validate jenkins job

Change-Id: I704b1fa9aad19073e816ed577d8fcf748083450d
---
A JENKINS
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/67/36967/1
--
To view, visit https://gerrit.wikimedia.org/r/36967
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I704b1fa9aad19073e816ed577d8fcf748083450d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] validate jenkins job - change (mediawiki...EventLogging[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has uploaded a new change for review.

Change subject: validate jenkins job
..

validate jenkins job

Change-Id: I869b878c97f987f042a0f5f59cbf4c3661aea5eb
---
A JENKINS
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging 
refs/changes/68/36968/1
--
To view, visit https://gerrit.wikimedia.org/r/36968
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I869b878c97f987f042a0f5f59cbf4c3661aea5eb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] validate jenkins job - change (mediawiki...GeoData[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has uploaded a new change for review.

Change subject: validate jenkins job
..

validate jenkins job

Change-Id: I1fd364ad49902be0c099557351228db0227b5e77
---
A JENKINS
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GeoData 
refs/changes/69/36969/1
--
To view, visit https://gerrit.wikimedia.org/r/36969
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1fd364ad49902be0c099557351228db0227b5e77
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GeoData
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 42720) Add ipblock-exempt right to bot group on cs.wiki... - change (operations/mediawiki-config[master])

2012-12-05 Thread Dereckson (Code Review)
Dereckson has uploaded a new change for review.

Change subject: (bug 42720) Add ipblock-exempt right to bot group on 
cs.wikipedia
..

(bug 42720) Add ipblock-exempt right to bot group on cs.wikipedia

Change-Id: Ia8f4cfa5dc8f2d0ff0e3ee286a18eaba4bc3c818
---
M wmf-config/InitialiseSettings.php
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/70/36970/1
--
To view, visit https://gerrit.wikimedia.org/r/36970
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8f4cfa5dc8f2d0ff0e3ee286a18eaba4bc3c818
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Dereckson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix two fatals - change (mediawiki...Renameuser[master])

2012-12-05 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review.

Change subject: Fix two fatals
..

Fix two fatals

Change-Id: I0a78f35d9d0e809fdcbc7338c3b24fe28c6e17c7
---
M Renameuser_body.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Renameuser 
refs/changes/71/36971/1
--
To view, visit https://gerrit.wikimedia.org/r/36971
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a78f35d9d0e809fdcbc7338c3b24fe28c6e17c7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Renameuser
Gerrit-Branch: master
Gerrit-Owner: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] validating jenkins jobs - change (mediawiki...Renameuser[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has uploaded a new change for review.

Change subject: validating jenkins jobs
..

validating jenkins jobs

Change-Id: Ief8c50e5384e5ff859b17ed11dd2005b581446b4
---
A JENKINS
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Renameuser 
refs/changes/72/36972/1
--
To view, visit https://gerrit.wikimedia.org/r/36972
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief8c50e5384e5ff859b17ed11dd2005b581446b4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Renameuser
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] validate jenkins job - change (mediawiki...Score[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has uploaded a new change for review.

Change subject: validate jenkins job
..

validate jenkins job

Change-Id: Ie0ccd5a999a064fc7e7b3a14a204dde0c5130935
---
A JENKINS
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Score 
refs/changes/73/36973/1
--
To view, visit https://gerrit.wikimedia.org/r/36973
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0ccd5a999a064fc7e7b3a14a204dde0c5130935
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Score
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix two fatals - change (mediawiki...Renameuser[master])

2012-12-05 Thread Nikerabbit (Code Review)
Nikerabbit has submitted this change and it was merged.

Change subject: Fix two fatals
..


Fix two fatals

Change-Id: I0a78f35d9d0e809fdcbc7338c3b24fe28c6e17c7
---
M Renameuser_body.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Nikerabbit: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36971
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0a78f35d9d0e809fdcbc7338c3b24fe28c6e17c7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Renameuser
Gerrit-Branch: master
Gerrit-Owner: Siebrand 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] validate jenkins jobs - change (mediawiki...TimedMediaHandler[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has uploaded a new change for review.

Change subject: validate jenkins jobs
..

validate jenkins jobs

Change-Id: I07962f8887350df40ef4b3bb50953098432bc3f2
---
A JENKINS
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/74/36974/1
--
To view, visit https://gerrit.wikimedia.org/r/36974
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I07962f8887350df40ef4b3bb50953098432bc3f2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix-up: typo in config var name - change (mediawiki...EventLogging[master])

2012-12-05 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review.

Change subject: Fix-up: typo in config var name
..

Fix-up: typo in config var name

Change-Id: Iad57eed865ea8b103270cfff5fdaf9fe1cd0f45b
---
M EventLogging.hooks.php
M EventLogging.module.php
M EventLogging.php
3 files changed, 11 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging 
refs/changes/75/36975/1
--
To view, visit https://gerrit.wikimedia.org/r/36975
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad57eed865ea8b103270cfff5fdaf9fe1cd0f45b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 42699) Undefined variable $id in ApiAggregateGroups - change (mediawiki...Translate[master])

2012-12-05 Thread Nikerabbit (Code Review)
Nikerabbit has submitted this change and it was merged.

Change subject: (bug 42699) Undefined variable $id in ApiAggregateGroups
..


(bug 42699) Undefined variable $id in ApiAggregateGroups

Change-Id: I6193bc15a0a068a52eeb13d50754eb3abe86707c
---
M api/ApiAggregateGroups.php
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Nikerabbit: 
  Siebrand: Looks good to me, approved
  jenkins-bot: Verified; Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/36956
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6193bc15a0a068a52eeb13d50754eb3abe86707c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] tweak non passing job so they dont block for now - change (integration/zuul-config[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has uploaded a new change for review.

Change subject: tweak non passing job so they dont block for now
..

tweak non passing job so they dont block for now

* Echo does not support SQLite backend so we do not bother running the
  installer nor running the unit tests.
* EventLogging does not have any Unit tests
* TimedMediaHandler depends on MwEmbedSupport extension but we do not
  support extension dependencies for now. Disable installer and Unit
  tests for now.

Change-Id: Ib4755c2483d8f43ca63d7243bed29ae34983da5c
---
M layout.yaml
1 file changed, 21 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/zuul-config 
refs/changes/76/36976/1
--
To view, visit https://gerrit.wikimedia.org/r/36976
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4755c2483d8f43ca63d7243bed29ae34983da5c
Gerrit-PatchSet: 1
Gerrit-Project: integration/zuul-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] tweak non passing job so they dont block for now - change (integration/zuul-config[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has submitted this change and it was merged.

Change subject: tweak non passing job so they dont block for now
..


tweak non passing job so they dont block for now

* Echo does not support SQLite backend so we do not bother running the
  installer nor running the unit tests.
* EventLogging does not have any Unit tests
* TimedMediaHandler depends on MwEmbedSupport extension but we do not
  support extension dependencies for now. Disable installer and Unit
  tests for now.

Change-Id: Ib4755c2483d8f43ca63d7243bed29ae34983da5c
---
M layout.yaml
1 file changed, 21 insertions(+), 5 deletions(-)

Approvals:
  Hashar: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36976
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4755c2483d8f43ca63d7243bed29ae34983da5c
Gerrit-PatchSet: 1
Gerrit-Project: integration/zuul-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 
Gerrit-Reviewer: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Re-think error-handling and revisions in JS module - change (mediawiki...EventLogging[master])

2012-12-05 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged.

Change subject: Re-think error-handling and revisions in JS module
..


Re-think error-handling and revisions in JS module

- Rename SchemaModule->schema to SchemaModule->title
- Rename SchemaModule->rev to SchemaModule->revision (consistency)
- If no revision specified, set SchemaModule->revision to 'HEAD'
- Separate module retrieval from JS code generation
- Alias mw.eventLog as 'self' in JS module closure
- setSchemas -> setSchema; accepts a 'meta' object containing schema +
  information.
- Change throw new Error()s to self.warn.
- Capture all logged events in metadata object

Change-Id: Ie17d92f449a722a9963fc6d2124e86c82576130f
---
M EventLogging.module.php
M modules/ext.eventLogging.core.js
M tests/ext.eventLogging.tests.js
3 files changed, 126 insertions(+), 91 deletions(-)

Approvals:
  Ori.livneh: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36690
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie17d92f449a722a9963fc6d2124e86c82576130f
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 
Gerrit-Reviewer: Ori.livneh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix-up: typo in config var name - change (mediawiki...EventLogging[master])

2012-12-05 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged.

Change subject: Fix-up: typo in config var name
..


Fix-up: typo in config var name

Change-Id: Iad57eed865ea8b103270cfff5fdaf9fe1cd0f45b
---
M EventLogging.hooks.php
M EventLogging.module.php
M EventLogging.php
3 files changed, 11 insertions(+), 8 deletions(-)

Approvals:
  Ori.livneh: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36975
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iad57eed865ea8b103270cfff5fdaf9fe1cd0f45b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 
Gerrit-Reviewer: Ori.livneh 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] typo on non vote for mwext-GeoData-testextensions - change (integration/zuul-config[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has uploaded a new change for review.

Change subject: typo on non vote for mwext-GeoData-testextensions
..

typo on non vote for mwext-GeoData-testextensions

Change-Id: I079b0fca103de42d137095c67f756546e63dbc1f
---
M layout.yaml
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/zuul-config 
refs/changes/77/36977/1
--
To view, visit https://gerrit.wikimedia.org/r/36977
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I079b0fca103de42d137095c67f756546e63dbc1f
Gerrit-PatchSet: 1
Gerrit-Project: integration/zuul-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] typo on non vote for mwext-GeoData-testextensions - change (integration/zuul-config[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has submitted this change and it was merged.

Change subject: typo on non vote for mwext-GeoData-testextensions
..


typo on non vote for mwext-GeoData-testextensions

Change-Id: I079b0fca103de42d137095c67f756546e63dbc1f
---
M layout.yaml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Hashar: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36977
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I079b0fca103de42d137095c67f756546e63dbc1f
Gerrit-PatchSet: 1
Gerrit-Project: integration/zuul-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 
Gerrit-Reviewer: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] use write connection for recent changes save hook - change (mediawiki...Wikibase[mw1.21-wmf5])

2012-12-05 Thread Daniel Kinzler (Code Review)
Daniel Kinzler has uploaded a new change for review.

Change subject: use write connection for recent changes save hook
..

use write connection for recent changes save hook

Change-Id: I9e1dcdd81fdbed4cbdf03249964837d93eb303b3
---
M repo/Wikibase.hooks.php
1 file changed, 8 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/79/36979/1
--
To view, visit https://gerrit.wikimedia.org/r/36979
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e1dcdd81fdbed4cbdf03249964837d93eb303b3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.21-wmf5
Gerrit-Owner: Daniel Kinzler 
Gerrit-Reviewer: Aude 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 42534) make repo link work with protocol relative - change (mediawiki...Wikibase[mw1.21-wmf5])

2012-12-05 Thread Daniel Kinzler (Code Review)
Daniel Kinzler has uploaded a new change for review.

Change subject: (bug 42534) make repo link work with protocol relative
..

(bug 42534) make repo link work with protocol relative

Change-Id: I08c021f5010f5bbc2a59bab82cde0be30e2f0894
---
M client/ExampleSettings.php
M client/WikibaseClient.hooks.php
M client/includes/ClientUtils.php
3 files changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/78/36978/1
--
To view, visit https://gerrit.wikimedia.org/r/36978
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I08c021f5010f5bbc2a59bab82cde0be30e2f0894
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.21-wmf5
Gerrit-Owner: Daniel Kinzler 
Gerrit-Reviewer: Aude 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 42325) Avoid race condition in SiteLinkTable. - change (mediawiki...Wikibase[mw1.21-wmf5])

2012-12-05 Thread Daniel Kinzler (Code Review)
Daniel Kinzler has uploaded a new change for review.

Change subject: (bug 42325) Avoid race condition in SiteLinkTable.
..

(bug 42325) Avoid race condition in SiteLinkTable.

This makes sure the master database is used when checking for conflicting
sitelinks when saving an item. A similar issue with the TermCache remains
unsolved.

This is not very elegant, but seems to be the cleanest way without much
refactoring.

Change-Id: I4972bd7b3a486651b1a682967596b57dce72d217
---
M lib/includes/store/SiteLinkLookup.php
M lib/includes/store/SiteLinkTable.php
M repo/includes/content/ItemContent.php
3 files changed, 41 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/80/36980/1
--
To view, visit https://gerrit.wikimedia.org/r/36980
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4972bd7b3a486651b1a682967596b57dce72d217
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.21-wmf5
Gerrit-Owner: Daniel Kinzler 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 42534) make repo link work with protocol relative - change (mediawiki...Wikibase[mw1.21-wmf5])

2012-12-05 Thread Daniel Kinzler (Code Review)
Daniel Kinzler has submitted this change and it was merged.

Change subject: (bug 42534) make repo link work with protocol relative
..


(bug 42534) make repo link work with protocol relative

Change-Id: I08c021f5010f5bbc2a59bab82cde0be30e2f0894
---
M client/ExampleSettings.php
M client/WikibaseClient.hooks.php
M client/includes/ClientUtils.php
3 files changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Daniel Kinzler: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36978
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I08c021f5010f5bbc2a59bab82cde0be30e2f0894
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.21-wmf5
Gerrit-Owner: Daniel Kinzler 
Gerrit-Reviewer: Aude 
Gerrit-Reviewer: Daniel Kinzler 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] use write connection for recent changes save hook - change (mediawiki...Wikibase[mw1.21-wmf5])

2012-12-05 Thread Daniel Kinzler (Code Review)
Daniel Kinzler has submitted this change and it was merged.

Change subject: use write connection for recent changes save hook
..


use write connection for recent changes save hook

Change-Id: I9e1dcdd81fdbed4cbdf03249964837d93eb303b3
---
M repo/Wikibase.hooks.php
1 file changed, 8 insertions(+), 1 deletion(-)

Approvals:
  Daniel Kinzler: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36979
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9e1dcdd81fdbed4cbdf03249964837d93eb303b3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.21-wmf5
Gerrit-Owner: Daniel Kinzler 
Gerrit-Reviewer: Aude 
Gerrit-Reviewer: Daniel Kinzler 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 42325) Avoid race condition in SiteLinkTable. - change (mediawiki...Wikibase[mw1.21-wmf5])

2012-12-05 Thread Daniel Kinzler (Code Review)
Daniel Kinzler has submitted this change and it was merged.

Change subject: (bug 42325) Avoid race condition in SiteLinkTable.
..


(bug 42325) Avoid race condition in SiteLinkTable.

This makes sure the master database is used when checking for conflicting
sitelinks when saving an item. A similar issue with the TermCache remains
unsolved.

This is not very elegant, but seems to be the cleanest way without much
refactoring.

Change-Id: I4972bd7b3a486651b1a682967596b57dce72d217
---
M lib/includes/store/SiteLinkLookup.php
M lib/includes/store/SiteLinkTable.php
M repo/includes/content/ItemContent.php
3 files changed, 41 insertions(+), 11 deletions(-)

Approvals:
  Daniel Kinzler: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36980
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4972bd7b3a486651b1a682967596b57dce72d217
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.21-wmf5
Gerrit-Owner: Daniel Kinzler 
Gerrit-Reviewer: Daniel Kinzler 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] enable non voting mwext-EventLogging-testextensions - change (integration/zuul-config[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has uploaded a new change for review.

Change subject: enable non voting mwext-EventLogging-testextensions
..

enable non voting mwext-EventLogging-testextensions

Change-Id: I559f5b7b1bb2b405c2ffd5c238eeb152f5fcf644
---
M layout.yaml
1 file changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/zuul-config 
refs/changes/81/36981/1
--
To view, visit https://gerrit.wikimedia.org/r/36981
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I559f5b7b1bb2b405c2ffd5c238eeb152f5fcf644
Gerrit-PatchSet: 1
Gerrit-Project: integration/zuul-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Updated Ruby gems - change (qa/browsertests[master])

2012-12-05 Thread Zfilipin (Code Review)
Zfilipin has uploaded a new change for review.

Change subject: Updated Ruby gems
..

Updated Ruby gems

Change-Id: I566b036bd976151947dbf1e48087c7ad7cb7a373
---
M Gemfile.lock
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests 
refs/changes/82/36982/1
--
To view, visit https://gerrit.wikimedia.org/r/36982
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I566b036bd976151947dbf1e48087c7ad7cb7a373
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] enable non voting mwext-EventLogging-testextensions - change (integration/zuul-config[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has submitted this change and it was merged.

Change subject: enable non voting mwext-EventLogging-testextensions
..


enable non voting mwext-EventLogging-testextensions

Change-Id: I559f5b7b1bb2b405c2ffd5c238eeb152f5fcf644
---
M layout.yaml
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Hashar: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36981
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I559f5b7b1bb2b405c2ffd5c238eeb152f5fcf644
Gerrit-PatchSet: 1
Gerrit-Project: integration/zuul-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 
Gerrit-Reviewer: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix docs - change (mediawiki...Translate[master])

2012-12-05 Thread Siebrand (Code Review)
Siebrand has submitted this change and it was merged.

Change subject: Fix docs
..


Fix docs

* Author info belongs to file comment
* Use Traversable etc.
* Typehints

Change-Id: Ie7b9f1e34ca04c31e1328ff32cf1607153cd679b
---
M MessageChecks.php
1 file changed, 31 insertions(+), 32 deletions(-)

Approvals:
  Siebrand: Looks good to me, approved
  jenkins-bot: Verified; Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/36957
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7b9f1e34ca04c31e1328ff32cf1607153cd679b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] gate-and-submit, like clone but auto submit change - change (integration/zuul-config[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has uploaded a new change for review.

Change subject: gate-and-submit, like clone but auto submit change
..

gate-and-submit, like clone but auto submit change

Whenever someone has reviewed the change (CR+2) and the unit tests are
successful, we might as well submit the change in Jenkins. A job using
the new 'gate-and-submit' will have its change autosubmitted.

Change-Id: I7db62a7eee6d1cb503fb3bdc7313e4c5aa26e943
---
M layout.yaml
1 file changed, 26 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/zuul-config 
refs/changes/83/36983/1
--
To view, visit https://gerrit.wikimedia.org/r/36983
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7db62a7eee6d1cb503fb3bdc7313e4c5aa26e943
Gerrit-PatchSet: 1
Gerrit-Project: integration/zuul-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] enable auto submit for Translate - change (integration/zuul-config[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has uploaded a new change for review.

Change subject: enable auto submit for Translate
..

enable auto submit for Translate

Change-Id: I0acd56963e9373478f68ab3c39e5baab5cbf181c
---
M layout.yaml
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/zuul-config 
refs/changes/84/36984/1
--
To view, visit https://gerrit.wikimedia.org/r/36984
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0acd56963e9373478f68ab3c39e5baab5cbf181c
Gerrit-PatchSet: 1
Gerrit-Project: integration/zuul-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] gate-and-submit, like clone but auto submit change - change (integration/zuul-config[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has submitted this change and it was merged.

Change subject: gate-and-submit, like clone but auto submit change
..


gate-and-submit, like clone but auto submit change

Whenever someone has reviewed the change (CR+2) and the unit tests are
successful, we might as well submit the change in Jenkins. A job using
the new 'gate-and-submit' will have its change autosubmitted.

Change-Id: I7db62a7eee6d1cb503fb3bdc7313e4c5aa26e943
---
M layout.yaml
1 file changed, 26 insertions(+), 0 deletions(-)

Approvals:
  Hashar: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36983
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7db62a7eee6d1cb503fb3bdc7313e4c5aa26e943
Gerrit-PatchSet: 1
Gerrit-Project: integration/zuul-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 
Gerrit-Reviewer: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] enable auto submit for Translate - change (integration/zuul-config[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has submitted this change and it was merged.

Change subject: enable auto submit for Translate
..


enable auto submit for Translate

Change-Id: I0acd56963e9373478f68ab3c39e5baab5cbf181c
---
M layout.yaml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Siebrand: Looks good to me, approved
  Hashar: Verified


--
To view, visit https://gerrit.wikimedia.org/r/36984
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0acd56963e9373478f68ab3c39e5baab5cbf181c
Gerrit-PatchSet: 1
Gerrit-Project: integration/zuul-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add type hint - change (mediawiki/core[master])

2012-12-05 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Add type hint
..


Add type hint

Change-Id: If529cfbf568a10e8cea184fa229959701268ebcb
---
M includes/diff/DifferenceEngine.php
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/36920
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If529cfbf568a10e8cea184fa229959701268ebcb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add 1.20 RELEASE-NOTES to HISTORY - change (mediawiki/core[master])

2012-12-05 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Add 1.20 RELEASE-NOTES to HISTORY
..


Add 1.20 RELEASE-NOTES to HISTORY

Change-Id: I2f5062c518017bdb26688df3278132befeb80826
---
M HISTORY
D RELEASE-NOTES-1.20
2 files changed, 361 insertions(+), 427 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  MarkAHershberger: Looks good to me, but someone else must approve
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/36733
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2f5062c518017bdb26688df3278132befeb80826
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand 
Gerrit-Reviewer: MarkAHershberger 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Removing suggester's "selected" event - change (mediawiki...Wikibase[master])

2012-12-05 Thread Henning Snater (Code Review)
Henning Snater has uploaded a new change for review.

Change subject: Removing suggester's "selected" event
..

Removing suggester's "selected" event

Suggester's is redundant to jquery.ui.autocomplete's select event and obsolete.

Change-Id: I2ee8591617b05657aad236a8ad4d23eef61284a2
---
M lib/resources/jquery.ui/jquery.ui.suggester.js
1 file changed, 1 insertion(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/85/36985/1
--
To view, visit https://gerrit.wikimedia.org/r/36985
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ee8591617b05657aad236a8ad4d23eef61284a2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Optimizing entityselector widget's input validation - change (mediawiki...Wikibase[master])

2012-12-05 Thread Henning Snater (Code Review)
Henning Snater has uploaded a new change for review.

Change subject: Optimizing entityselector widget's input validation
..

Optimizing entityselector widget's input validation

Fixes/improves detecting valid input and improves management of hidden input 
element.

Change-Id: Ic41dd1786641544a01a46f663a543a15d8a55c2c
---
M lib/resources/jquery.ui/jquery.ui.entityselector.js
1 file changed, 35 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/86/36986/1
--
To view, visit https://gerrit.wikimedia.org/r/36986
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic41dd1786641544a01a46f663a543a15d8a55c2c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] jobs for mw/ext/LiquidThreads - change (integration/jenkins-job-builder-config[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has uploaded a new change for review.

Change subject: jobs for mw/ext/LiquidThreads
..

jobs for mw/ext/LiquidThreads

Change-Id: I6a35774ae7799a237866cfa6ef43b14f7c2c7b6a
---
M mediawiki-extensions.yaml
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/integration/jenkins-job-builder-config 
refs/changes/87/36987/1
--
To view, visit https://gerrit.wikimedia.org/r/36987
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a35774ae7799a237866cfa6ef43b14f7c2c7b6a
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins-job-builder-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] jobs for mw/ext/LiquidThreads - change (integration/jenkins-job-builder-config[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has submitted this change and it was merged.

Change subject: jobs for mw/ext/LiquidThreads
..


jobs for mw/ext/LiquidThreads

Change-Id: I6a35774ae7799a237866cfa6ef43b14f7c2c7b6a
---
M mediawiki-extensions.yaml
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Hashar: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36987
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6a35774ae7799a237866cfa6ef43b14f7c2c7b6a
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins-job-builder-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 
Gerrit-Reviewer: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] enable reporting for LiquidThreads - change (integration/zuul-config[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has uploaded a new change for review.

Change subject: enable reporting for LiquidThreads
..

enable reporting for LiquidThreads

There is no PHPUnit tests yet, so do not bother triggering them.

Change-Id: I0ceaef3ce936626ba5b60b537649225e77cc7f5b
---
M layout.yaml
1 file changed, 11 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/zuul-config 
refs/changes/88/36988/1
--
To view, visit https://gerrit.wikimedia.org/r/36988
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ceaef3ce936626ba5b60b537649225e77cc7f5b
Gerrit-PatchSet: 1
Gerrit-Project: integration/zuul-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] enable reporting for LiquidThreads - change (integration/zuul-config[master])

2012-12-05 Thread Hashar (Code Review)
Hashar has submitted this change and it was merged.

Change subject: enable reporting for LiquidThreads
..


enable reporting for LiquidThreads

There is no PHPUnit tests yet, so do not bother triggering them.

Change-Id: I0ceaef3ce936626ba5b60b537649225e77cc7f5b
---
M layout.yaml
1 file changed, 11 insertions(+), 0 deletions(-)

Approvals:
  Hashar: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36988
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0ceaef3ce936626ba5b60b537649225e77cc7f5b
Gerrit-PatchSet: 1
Gerrit-Project: integration/zuul-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 
Gerrit-Reviewer: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Base class for objects accessign databases. - change (mediawiki/core[wmf/1.21wmf5])

2012-12-05 Thread Aude (Code Review)
Aude has uploaded a new change for review.

Change subject: Base class for objects accessign databases.
..

Base class for objects accessign databases.

DBAccessBase provides utility methods for DB access, including
access to other wiki's databases.

Change-Id: I3c23a5c6e49e4921d48fddd72f2cf28ad1d13a58
---
M includes/AutoLoader.php
A includes/dao/DBAccessBase.php
M includes/db/ORMTable.php
3 files changed, 90 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/89/36989/1
--
To view, visit https://gerrit.wikimedia.org/r/36989
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c23a5c6e49e4921d48fddd72f2cf28ad1d13a58
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf5
Gerrit-Owner: Aude 
Gerrit-Reviewer: Daniel Kinzler 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix per-connection database name in DBAccessBase. - change (mediawiki/core[wmf/1.21wmf5])

2012-12-05 Thread Aude (Code Review)
Aude has uploaded a new change for review.

Change subject: Fix per-connection database name in DBAccessBase.
..

Fix per-connection database name in DBAccessBase.

Change-Id: I5ac4bfb93f2dfee1e6822f7afd75ff81c0864e43
---
M includes/dao/DBAccessBase.php
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/90/36990/1
--
To view, visit https://gerrit.wikimedia.org/r/36990
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ac4bfb93f2dfee1e6822f7afd75ff81c0864e43
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf5
Gerrit-Owner: Aude 
Gerrit-Reviewer: Daniel Kinzler 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] $.valueview.widget() can register valueviews per DataType no... - change (mediawiki...DataValues[master])

2012-12-05 Thread Daniel Werner (Code Review)
Daniel Werner has uploaded a new change for review.

Change subject: $.valueview.widget() can register valueviews per DataType now
..

$.valueview.widget() can register valueviews per DataType now

Before only valueview views per DataValue type could be registered, now a view 
for values of a specific DataType can be registered.
Did some minor cleanup in DataValue.js as well.

Change-Id: I65d7b4aa4c7fa796f338ac5191475004b52c042f
---
M DataTypes/resources/dataTypes.js
M DataTypes/resources/jquery.valueview.Widget.js
M DataTypes/resources/jquery.valueview.js
M DataValues/resources/DataValue.js
4 files changed, 82 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues 
refs/changes/91/36991/1
--
To view, visit https://gerrit.wikimedia.org/r/36991
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I65d7b4aa4c7fa796f338ac5191475004b52c042f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Introduces a LinkedSingleInputWidget - change (mediawiki...DataValues[master])

2012-12-05 Thread Daniel Werner (Code Review)
Daniel Werner has uploaded a new change for review.

Change subject: Introduces a LinkedSingleInputWidget
..

Introduces a LinkedSingleInputWidget

This can be used to create a valueview view which holds a single input element 
which is lined in non-edit mode.

Change-Id: I65921934961204d1cdf5a64ecbb6d6f129ec9ef2
---
M DataTypes/Resources.php
A DataTypes/resources/jquery.valueview.LinkedSingleInputWidget.js
M DataTypes/resources/jquery.valueview.SingleInputWidget.js
3 files changed, 158 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues 
refs/changes/92/36992/1
--
To view, visit https://gerrit.wikimedia.org/r/36992
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I65921934961204d1cdf5a64ecbb6d6f129ec9ef2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Removing suggester's "selected" event - change (mediawiki...Wikibase[master])

2012-12-05 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged.

Change subject: Removing suggester's "selected" event
..


Removing suggester's "selected" event

Suggester's is redundant to jquery.ui.autocomplete's select event and obsolete.

Change-Id: I2ee8591617b05657aad236a8ad4d23eef61284a2
---
M lib/resources/jquery.ui/jquery.ui.suggester.js
1 file changed, 1 insertion(+), 10 deletions(-)

Approvals:
  Tobias Gritschacher: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36985
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2ee8591617b05657aad236a8ad4d23eef61284a2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater 
Gerrit-Reviewer: Tobias Gritschacher 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Optimizing entityselector widget's input validation - change (mediawiki...Wikibase[master])

2012-12-05 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged.

Change subject: Optimizing entityselector widget's input validation
..


Optimizing entityselector widget's input validation

Fixes/improves detecting valid input and improves management of hidden input 
element.

Change-Id: Ic41dd1786641544a01a46f663a543a15d8a55c2c
---
M lib/resources/jquery.ui/jquery.ui.entityselector.js
1 file changed, 35 insertions(+), 23 deletions(-)

Approvals:
  Tobias Gritschacher: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36986
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic41dd1786641544a01a46f663a543a15d8a55c2c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater 
Gerrit-Reviewer: Tobias Gritschacher 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] More or less different PHPDoc - change (mediawiki...Translate[master])

2012-12-05 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review.

Change subject: More or less different PHPDoc
..

More or less different PHPDoc

Change-Id: I6964eee3eb885411cc2bf4d5e3b60d3f081ca311
---
M TranslateEditAddons.php
M tag/PageTranslationHooks.php
2 files changed, 19 insertions(+), 58 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/93/36993/1
--
To view, visit https://gerrit.wikimedia.org/r/36993
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6964eee3eb885411cc2bf4d5e3b60d3f081ca311
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Changed used data value type of wikibase-item data type to '... - change (mediawiki...Wikibase[master])

2012-12-05 Thread Daniel Werner (Code Review)
Daniel Werner has uploaded a new change for review.

Change subject: Changed used data value type of wikibase-item data type to 
'string'
..

Changed used data value type of wikibase-item data type to 'string'

Change-Id: I8ddd1508b57e985a33607a06a036b29c19f26856
---
M lib/WikibaseLib.php
M lib/tests/phpunit/property/PropertyTest.php
M lib/tests/phpunit/snak/PropertyValueSnakTest.php
3 files changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/94/36994/1
--
To view, visit https://gerrit.wikimedia.org/r/36994
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8ddd1508b57e985a33607a06a036b29c19f26856
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 42571) view for editing values of type item - change (mediawiki...Wikibase[master])

2012-12-05 Thread Daniel Werner (Code Review)
Daniel Werner has uploaded a new change for review.

Change subject: (bug 42571) view for editing values of type item
..

(bug 42571) view for editing values of type item

Change-Id: I177bd0ec9938892f110074a40b0c99d9fcc381f8
---
M lib/resources/Resources.php
A lib/resources/jquery.valueview.views/wikibaseItem.js
2 files changed, 80 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/95/36995/1
--
To view, visit https://gerrit.wikimedia.org/r/36995
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I177bd0ec9938892f110074a40b0c99d9fcc381f8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] $.valueview.widget() can register valueviews per DataType no... - change (mediawiki...DataValues[master])

2012-12-05 Thread Henning Snater (Code Review)
Henning Snater has submitted this change and it was merged.

Change subject: $.valueview.widget() can register valueviews per DataType now
..


$.valueview.widget() can register valueviews per DataType now

Before only valueview views per DataValue type could be registered, now a view 
for values of a specific DataType can be registered.
Did some minor cleanup in DataValue.js as well.

Change-Id: I65d7b4aa4c7fa796f338ac5191475004b52c042f
---
M DataTypes/resources/dataTypes.js
M DataTypes/resources/jquery.valueview.Widget.js
M DataTypes/resources/jquery.valueview.js
M DataValues/resources/DataValue.js
4 files changed, 82 insertions(+), 29 deletions(-)

Approvals:
  Henning Snater: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36991
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I65d7b4aa4c7fa796f338ac5191475004b52c042f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner 
Gerrit-Reviewer: Henning Snater 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Introduces a LinkedSingleInputWidget - change (mediawiki...DataValues[master])

2012-12-05 Thread Henning Snater (Code Review)
Henning Snater has submitted this change and it was merged.

Change subject: Introduces a LinkedSingleInputWidget
..


Introduces a LinkedSingleInputWidget

This can be used to create a valueview view which holds a single input element 
which is lined in non-edit mode.

Change-Id: I65921934961204d1cdf5a64ecbb6d6f129ec9ef2
---
M DataTypes/Resources.php
A DataTypes/resources/jquery.valueview.LinkedSingleInputWidget.js
M DataTypes/resources/jquery.valueview.SingleInputWidget.js
3 files changed, 158 insertions(+), 7 deletions(-)

Approvals:
  Henning Snater: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36992
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I65921934961204d1cdf5a64ecbb6d6f129ec9ef2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner 
Gerrit-Reviewer: Henning Snater 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix per-connection database name in DBAccessBase. - change (mediawiki/core[wmf/1.21wmf5])

2012-12-05 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Fix per-connection database name in DBAccessBase.
..


Fix per-connection database name in DBAccessBase.

Change-Id: I5ac4bfb93f2dfee1e6822f7afd75ff81c0864e43
---
M includes/dao/DBAccessBase.php
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/36990
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5ac4bfb93f2dfee1e6822f7afd75ff81c0864e43
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf5
Gerrit-Owner: Aude 
Gerrit-Reviewer: Daniel Kinzler 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Base class for objects accessign databases. - change (mediawiki/core[wmf/1.21wmf5])

2012-12-05 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Base class for objects accessign databases.
..


Base class for objects accessign databases.

DBAccessBase provides utility methods for DB access, including
access to other wiki's databases.

Change-Id: I3c23a5c6e49e4921d48fddd72f2cf28ad1d13a58
---
M includes/AutoLoader.php
A includes/dao/DBAccessBase.php
M includes/db/ORMTable.php
3 files changed, 90 insertions(+), 27 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/36989
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3c23a5c6e49e4921d48fddd72f2cf28ad1d13a58
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf5
Gerrit-Owner: Aude 
Gerrit-Reviewer: Daniel Kinzler 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Thinner progress bars - change (mediawiki...Translate[master])

2012-12-05 Thread Pginer (Code Review)
Pginer has uploaded a new change for review.

Change subject: Thinner progress bars
..

Thinner progress bars

Making progress bars a bit thinner.

CSS spacing and color adjustments

This patchset fixes alignment and color of several UI elements.
JS code has been modified to add containers and CSS classes.
It also adds CSS code to use a SVG version for the Search icon.

Added SVG version for search icon

Change-Id: I9582ec947c84b51e93fe33876cf16cfaeea82b8b
---
M resources/css/ext.translate.groupselector.css
M resources/css/ext.translate.statsbar.css
A resources/images/search.svg
M resources/js/ext.translate.groupselector.js
4 files changed, 139 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/96/36996/1
--
To view, visit https://gerrit.wikimedia.org/r/36996
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9582ec947c84b51e93fe33876cf16cfaeea82b8b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Pginer 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Make the load all messages button in group selector work. - change (mediawiki...Translate[master])

2012-12-05 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Make the load all messages button in group selector work.
..


Make the load all messages button in group selector work.

Change-Id: I0684819ee1a1c564d8a2cf9674c53cfa9fa33b12
---
M resources/ext.translate.special.translate.js
M resources/js/ext.translate.groupselector.js
2 files changed, 26 insertions(+), 12 deletions(-)

Approvals:
  Nikerabbit: Verified; Looks good to me, approved
  jenkins-bot: Verified; Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/36965
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0684819ee1a1c564d8a2cf9674c53cfa9fa33b12
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Santhosh 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Santhosh 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add wfDeprecated to wfMsg* methods from 1.21 on - change (mediawiki/core[master])

2012-12-05 Thread Nikerabbit (Code Review)
Nikerabbit has submitted this change and it was merged.

Change subject: Add wfDeprecated to wfMsg* methods from 1.21 on
..


Add wfDeprecated to wfMsg* methods from 1.21 on

These were marked soft deprecated in 1.18.

Change-Id: Ifa82da981c69b2ea9d5b298e9dfb04fc29483206
---
M RELEASE-NOTES-1.21
M includes/GlobalFunctions.php
2 files changed, 24 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Looks good to me, but someone else must approve
  Nikerabbit: Looks good to me, approved
  Jeroen De Dauw: Looks good to me, but someone else must approve
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/36735
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa82da981c69b2ea9d5b298e9dfb04fc29483206
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand 
Gerrit-Reviewer: Jeroen De Dauw 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] More or less different PHPDoc - change (mediawiki...Translate[master])

2012-12-05 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: More or less different PHPDoc
..


More or less different PHPDoc

Change-Id: I6964eee3eb885411cc2bf4d5e3b60d3f081ca311
---
M TranslateEditAddons.php
M tag/PageTranslationHooks.php
2 files changed, 19 insertions(+), 58 deletions(-)

Approvals:
  Nikerabbit: Looks good to me, approved
  jenkins-bot: Verified; Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/36993
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6964eee3eb885411cc2bf4d5e3b60d3f081ca311
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Siebrand 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Changed used data value type of wikibase-item data type to '... - change (mediawiki...Wikibase[master])

2012-12-05 Thread Henning Snater (Code Review)
Henning Snater has submitted this change and it was merged.

Change subject: Changed used data value type of wikibase-item data type to 
'string'
..


Changed used data value type of wikibase-item data type to 'string'

Change-Id: I8ddd1508b57e985a33607a06a036b29c19f26856
---
M lib/WikibaseLib.php
M lib/tests/phpunit/property/PropertyTest.php
M lib/tests/phpunit/snak/PropertyValueSnakTest.php
3 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Tobias Gritschacher: Verified
  Henning Snater: Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36994
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8ddd1508b57e985a33607a06a036b29c19f26856
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner 
Gerrit-Reviewer: Henning Snater 
Gerrit-Reviewer: Tobias Gritschacher 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 42571) view for editing values of type item - change (mediawiki...Wikibase[master])

2012-12-05 Thread Henning Snater (Code Review)
Henning Snater has submitted this change and it was merged.

Change subject: (bug 42571) view for editing values of type item
..


(bug 42571) view for editing values of type item

Change-Id: I177bd0ec9938892f110074a40b0c99d9fcc381f8
---
M lib/resources/Resources.php
A lib/resources/jquery.valueview.views/wikibaseItem.js
2 files changed, 79 insertions(+), 1 deletion(-)

Approvals:
  Henning Snater: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36995
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I177bd0ec9938892f110074a40b0c99d9fcc381f8
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner 
Gerrit-Reviewer: Daniel Werner 
Gerrit-Reviewer: Henning Snater 
Gerrit-Reviewer: Tobias Gritschacher 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


  1   2   3   4   >