[MediaWiki-commits] [Gerrit] Various fixes for i18n, messages, and aliases. Partial fix ... - change (mediawiki...Onboarding[master])

2012-12-08 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review.

Change subject: Various fixes for i18n, messages, and aliases.  Partial fix of 
bugzilla 42849.
..

Various fixes for i18n, messages, and aliases.  Partial fix of bugzilla 42849.

* Lower-case started on special page
* Remove aliases
* Use prefix for everything except gettingstarted itself.  I can't because 
apparently it needs to match the class/specila page name.

Change-Id: I07275a0bebc708dcb615bdbaac289660bcad8942
---
M Onboarding.alias.php
M Onboarding.i18n.php
M Onboarding.php
M SpecialGettingStarted.php
4 files changed, 11 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Onboarding 
refs/changes/10/37610/1
--
To view, visit https://gerrit.wikimedia.org/r/37610
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I07275a0bebc708dcb615bdbaac289660bcad8942
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Onboarding
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] [OpenStackManager] Add optional message key - change (translatewiki[master])

2012-12-08 Thread Raimond Spekking (Code Review)
Raimond Spekking has uploaded a new change for review.

Change subject: [OpenStackManager] Add optional message key
..

[OpenStackManager] Add optional message key

https://gerrit.wikimedia.org/r/#/c/37250/2/OpenStackManager.i18n.php,unified

Change-Id: I790d16a7218105f00fc92c0bbe4726a04a0b50a8
---
M groups/MediaWiki/mediawiki-defines.txt
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/translatewiki 
refs/changes/11/37611/1
--
To view, visit https://gerrit.wikimedia.org/r/37611
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I790d16a7218105f00fc92c0bbe4726a04a0b50a8
Gerrit-PatchSet: 1
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] [OpenStackManager] Add optional message key - change (translatewiki[master])

2012-12-08 Thread Raimond Spekking (Code Review)
Raimond Spekking has submitted this change and it was merged.

Change subject: [OpenStackManager] Add optional message key
..


[OpenStackManager] Add optional message key

https://gerrit.wikimedia.org/r/#/c/37250/2/OpenStackManager.i18n.php,unified

Change-Id: I790d16a7218105f00fc92c0bbe4726a04a0b50a8
---
M groups/MediaWiki/mediawiki-defines.txt
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Raimond Spekking: Verified; Looks good to me, approved
  jenkins-bot: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37611
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I790d16a7218105f00fc92c0bbe4726a04a0b50a8
Gerrit-PatchSet: 1
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking 
Gerrit-Reviewer: Raimond Spekking 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Rephrase description message a bit - change (mediawiki...MagicNoCache[master])

2012-12-08 Thread Raimond Spekking (Code Review)
Raimond Spekking has uploaded a new change for review.

Change subject: Rephrase description message a bit
..

Rephrase description message a bit

Change-Id: I4a4559e431d301d2190e83ce1ca1f9643ae717db
---
M MagicNoCache.i18n.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MagicNoCache 
refs/changes/12/37612/1
--
To view, visit https://gerrit.wikimedia.org/r/37612
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a4559e431d301d2190e83ce1ca1f9643ae717db
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MagicNoCache
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Rephrase description message a bit - change (mediawiki...MagicNoCache[master])

2012-12-08 Thread Raimond Spekking (Code Review)
Raimond Spekking has submitted this change and it was merged.

Change subject: Rephrase description message a bit
..


Rephrase description message a bit

Change-Id: I4a4559e431d301d2190e83ce1ca1f9643ae717db
---
M MagicNoCache.i18n.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Raimond Spekking: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/37612
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4a4559e431d301d2190e83ce1ca1f9643ae717db
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MagicNoCache
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking 
Gerrit-Reviewer: Raimond Spekking 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] [MagicNoCache] Register extension - change (translatewiki[master])

2012-12-08 Thread Raimond Spekking (Code Review)
Raimond Spekking has uploaded a new change for review.

Change subject: [MagicNoCache] Register extension
..

[MagicNoCache] Register extension

Change-Id: If87f9aa3dc3b644718d0847db8cd2a756d77ad16
---
M groups/MediaWiki/mediawiki-defines.txt
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/translatewiki 
refs/changes/13/37613/1
--
To view, visit https://gerrit.wikimedia.org/r/37613
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If87f9aa3dc3b644718d0847db8cd2a756d77ad16
Gerrit-PatchSet: 1
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] [MagicNoCache] Register extension - change (translatewiki[master])

2012-12-08 Thread Raimond Spekking (Code Review)
Raimond Spekking has submitted this change and it was merged.

Change subject: [MagicNoCache] Register extension
..


[MagicNoCache] Register extension

Change-Id: If87f9aa3dc3b644718d0847db8cd2a756d77ad16
---
M groups/MediaWiki/mediawiki-defines.txt
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Raimond Spekking: Verified; Looks good to me, approved
  jenkins-bot: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37613
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If87f9aa3dc3b644718d0847db8cd2a756d77ad16
Gerrit-PatchSet: 1
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking 
Gerrit-Reviewer: Raimond Spekking 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] 1 sentence per line - change (mediawiki...OpenStackManager[master])

2012-12-08 Thread Raimond Spekking (Code Review)
Raimond Spekking has uploaded a new change for review.

Change subject: 1 sentence per line
..

1 sentence per line

Main issue for this commit were 2 spaces
Spotted by Siebrand
https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Openstackmanager-shellaccountnamehelp/en

Change-Id: I813d244b407fced58c95805d3504a1169226cd86
---
M OpenStackManager.i18n.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OpenStackManager 
refs/changes/14/37614/1
--
To view, visit https://gerrit.wikimedia.org/r/37614
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I813d244b407fced58c95805d3504a1169226cd86
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OpenStackManager
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] 1 sentence per line - change (mediawiki...OpenStackManager[master])

2012-12-08 Thread Raimond Spekking (Code Review)
Raimond Spekking has submitted this change and it was merged.

Change subject: 1 sentence per line
..


1 sentence per line

Main issue for this commit were 2 spaces
Spotted by Siebrand
https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Openstackmanager-shellaccountnamehelp/en

Change-Id: I813d244b407fced58c95805d3504a1169226cd86
---
M OpenStackManager.i18n.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Raimond Spekking: Verified; Looks good to me, approved
  jenkins-bot: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37614
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I813d244b407fced58c95805d3504a1169226cd86
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OpenStackManager
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking 
Gerrit-Reviewer: Raimond Spekking 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Improve consistency in page translation terminology - change (mediawiki...Translate[master])

2012-12-08 Thread Nemo bis (Code Review)
Nemo bis has uploaded a new change for review.

Change subject: Improve consistency in page translation terminology
..

Improve consistency in page translation terminology

Fix some things found while adding message documentation and
reviewing some completely wrong translations.
Add a link to the extension glossary from the description.
Add a todo for the logging system.

Change-Id: Iea639bd5bad93c79fd545a68a2fd12f5d4085f0a
---
M PageTranslation.i18n.php
M TranslateGroupDescriptions.i18n.php
2 files changed, 12 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/15/37615/1
--
To view, visit https://gerrit.wikimedia.org/r/37615
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea639bd5bad93c79fd545a68a2fd12f5d4085f0a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nemo bis 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Use MWNamespace method instead of binary arithmetic - change (mediawiki/core[master])

2012-12-08 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review.

Change subject: Use MWNamespace method instead of binary arithmetic
..

Use MWNamespace method instead of binary arithmetic

"& ~1" or "| 1" are not easy to read

Change-Id: I08ff92669d32f3663ea58e98d8c49f0a54dfeca4
---
M includes/Title.php
M includes/specials/SpecialEditWatchlist.php
2 files changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/16/37616/1
--
To view, visit https://gerrit.wikimedia.org/r/37616
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I08ff92669d32f3663ea58e98d8c49f0a54dfeca4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix silly mistake, unit tests use @group - change (mediawiki...Translate[master])

2012-12-08 Thread Nikerabbit (Code Review)
Nikerabbit has uploaded a new change for review.

Change subject: Fix silly mistake, unit tests use @group
..

Fix silly mistake, unit tests use @group

Change-Id: I3a5fbf2b02207cbd5cf58f9e3a1c3fa7b0c66128
---
M tests/PageTranslationParserTest.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/17/37617/1
--
To view, visit https://gerrit.wikimedia.org/r/37617
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a5fbf2b02207cbd5cf58f9e3a1c3fa7b0c66128
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Extend meta=messagegroups API function + better tests - change (mediawiki...Translate[master])

2012-12-08 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Extend meta=messagegroups API function + better tests
..


Extend meta=messagegroups API function + better tests

Add mgfilter parameter, hooks, and basic unit test coverage

[Required for TranslateSvg phase 3.]

Change-Id: I43e86abc6e7ae746a1ed134729f68bca620d6f63
---
M api/ApiQueryMessageGroups.php
M hooks.txt
A tests/ApiQueryMessageGroupsTest.php
3 files changed, 233 insertions(+), 13 deletions(-)

Approvals:
  Nikerabbit: Verified; Looks good to me, approved
  jenkins-bot: Verified; Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/19457
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I43e86abc6e7ae746a1ed134729f68bca620d6f63
Gerrit-PatchSet: 24
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Jarry1250 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Allow SQL queries with long field list to wrap - change (mediawiki/core[master])

2012-12-08 Thread Nikerabbit (Code Review)
Nikerabbit has uploaded a new change for review.

Change subject: Allow SQL queries with long field list to wrap
..

Allow SQL queries with long field list to wrap

Change-Id: I7ed64a246455a7f2c48e7e120d45d1ebeb929584
---
M profileinfo.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/18/37618/1
--
To view, visit https://gerrit.wikimedia.org/r/37618
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ed64a246455a7f2c48e7e120d45d1ebeb929584
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add link description and make right message consistent - change (mediawiki...TimedMediaHandler[master])

2012-12-08 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review.

Change subject: Add link description and make right message consistent
..

Add link description and make right message consistent

Inconsistencies and uglyness spotted by Der Umherirrende on
translatewiki.net.

Change-Id: I18081a2793c271af3ebef7b6d0584c33af67a716
---
M TimedMediaHandler.i18n.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/19/37619/1
--
To view, visit https://gerrit.wikimedia.org/r/37619
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I18081a2793c271af3ebef7b6d0584c33af67a716
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Remove support for WikisourceMobile - change (translatewiki[master])

2012-12-08 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review.

Change subject: Remove support for WikisourceMobile
..

Remove support for WikisourceMobile

Don't have push access. Needs to be resolved for before re-enabling.

Change-Id: I7a587b78f3d73513eba92a81b733bac88a9cd420
---
M groups/Wikimedia/WikimediaMobile.yaml
1 file changed, 0 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/translatewiki 
refs/changes/20/37620/1
--
To view, visit https://gerrit.wikimedia.org/r/37620
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a587b78f3d73513eba92a81b733bac88a9cd420
Gerrit-PatchSet: 1
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Remove support for WikisourceMobile - change (translatewiki[master])

2012-12-08 Thread Siebrand (Code Review)
Siebrand has submitted this change and it was merged.

Change subject: Remove support for WikisourceMobile
..


Remove support for WikisourceMobile

Don't have push access. Needs to be resolved for before re-enabling.

Change-Id: I7a587b78f3d73513eba92a81b733bac88a9cd420
---
M groups/Wikimedia/WikimediaMobile.yaml
1 file changed, 0 insertions(+), 20 deletions(-)

Approvals:
  Siebrand: Verified; Looks good to me, approved
  jenkins-bot: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37620
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7a587b78f3d73513eba92a81b733bac88a9cd420
Gerrit-PatchSet: 1
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: Siebrand 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 40585) Don't drop 'step="any"' in HTML input fields. - change (mediawiki/core[master])

2012-12-08 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: (bug 40585) Don't drop 'step="any"' in HTML input fields.
..


(bug 40585) Don't drop 'step="any"' in HTML input fields.

The default value for "step" is "1" which effectively bans any decimal
number from being entered into an 'type="number"' field and makes
HTMLFloatField unusable.

Change-Id: I103fd4047814a7fb0dfdc174f36badd5b660b7a4
---
M includes/Html.php
M tests/phpunit/includes/HtmlTest.php
2 files changed, 19 insertions(+), 1 deletion(-)

Approvals:
  SPQRobin: Looks good to me, but someone else must approve
  Nikerabbit: Looks good to me, approved
  jenkins-bot: Verified; Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/35884
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I103fd4047814a7fb0dfdc174f36badd5b660b7a4
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Tim Landscheidt 
Gerrit-Reviewer: Daniel Friesen 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: SPQRobin 
Gerrit-Reviewer: Tim Landscheidt 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add action message - change (mediawiki...ReplaceText[master])

2012-12-08 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review.

Change subject: Add action message
..

Add action message

Needed on Special:ReplaceText for those that do not have the right to
replace text.

Change-Id: I522b8d599c8c18ef8066725aa5b1390a5bfe75c8
---
M ReplaceText.i18n.php
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ReplaceText 
refs/changes/21/37621/1
--
To view, visit https://gerrit.wikimedia.org/r/37621
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I522b8d599c8c18ef8066725aa5b1390a5bfe75c8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ReplaceText
Gerrit-Branch: master
Gerrit-Owner: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix incorrect variable for plural - change (mediawiki...Renameuser[master])

2012-12-08 Thread Nikerabbit (Code Review)
Nikerabbit has uploaded a new change for review.

Change subject: Fix incorrect variable for plural
..

Fix incorrect variable for plural

https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Logentry-renameuser-renameuser/vi

Change-Id: I002ef664483459161a02216bb12084426a066900
---
M Renameuser.i18n.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Renameuser 
refs/changes/22/37622/1
--
To view, visit https://gerrit.wikimedia.org/r/37622
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I002ef664483459161a02216bb12084426a066900
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Renameuser
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add action message - change (mediawiki...ReplaceText[master])

2012-12-08 Thread Siebrand (Code Review)
Siebrand has submitted this change and it was merged.

Change subject: Add action message
..


Add action message

Needed on Special:ReplaceText for those that do not have the right to
replace text.

Change-Id: I522b8d599c8c18ef8066725aa5b1390a5bfe75c8
---
M ReplaceText.i18n.php
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Siebrand: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/37621
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I522b8d599c8c18ef8066725aa5b1390a5bfe75c8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ReplaceText
Gerrit-Branch: master
Gerrit-Owner: Siebrand 
Gerrit-Reviewer: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix incorrect variable for plural - change (mediawiki...Renameuser[master])

2012-12-08 Thread Siebrand (Code Review)
Siebrand has submitted this change and it was merged.

Change subject: Fix incorrect variable for plural
..


Fix incorrect variable for plural

https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Logentry-renameuser-renameuser/vi

Change-Id: I002ef664483459161a02216bb12084426a066900
---
M Renameuser.i18n.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Siebrand: Looks good to me, approved
  jenkins-bot: Verified; Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37622
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I002ef664483459161a02216bb12084426a066900
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Renameuser
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki.Uri.test: Clean up - change (mediawiki/core[master])

2012-12-08 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: mediawiki.Uri.test: Clean up
..


mediawiki.Uri.test: Clean up

* Grouped assertions together by logical test unit (method names).
* Re-ordered (constructor, properties, methods, special cases).

Change-Id: Ia8de947278cdf469859062af47e1333c7a9f827b
---
M tests/qunit/suites/resources/mediawiki/mediawiki.Uri.test.js
1 file changed, 163 insertions(+), 157 deletions(-)

Approvals:
  Nikerabbit: Verified; Looks good to me, approved
  jenkins-bot: Verified; Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/36373
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8de947278cdf469859062af47e1333c7a9f827b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Robmoen 
Gerrit-Reviewer: Trevor Parscal 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Put "Help desk" page in Project namespace - change (mediawiki...UploadWizard[master])

2012-12-08 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review.

Change subject: Put "Help desk" page in Project namespace
..

Put "Help desk" page in Project namespace

These types of pages are usually in {{ns:project}}, not in the main
namespace.

Change-Id: Ied0b3b9d9a67dede145dfb27b34f1a241b10a975
---
M UploadWizard.i18n.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard 
refs/changes/23/37623/1
--
To view, visit https://gerrit.wikimedia.org/r/37623
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied0b3b9d9a67dede145dfb27b34f1a241b10a975
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Put "Help desk" page in Project namespace - change (mediawiki...UploadWizard[master])

2012-12-08 Thread Siebrand (Code Review)
Siebrand has submitted this change and it was merged.

Change subject: Put "Help desk" page in Project namespace
..


Put "Help desk" page in Project namespace

These types of pages are usually in {{ns:project}}, not in the main
namespace.

Change-Id: Ied0b3b9d9a67dede145dfb27b34f1a241b10a975
---
M UploadWizard.i18n.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Siebrand: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/37623
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ied0b3b9d9a67dede145dfb27b34f1a241b10a975
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Siebrand 
Gerrit-Reviewer: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add some braces, some profiling calls - change (mediawiki...ReplaceText[master])

2012-12-08 Thread Siebrand (Code Review)
Siebrand has submitted this change and it was merged.

Change subject: Add some braces, some profiling calls
..


Add some braces, some profiling calls

Add hook documentation block

Change-Id: I8e8e22b3193f1cdad590dd9bcdccfc785c140321
---
M ReplaceText.php
M ReplaceTextJob.php
M SpecialReplaceText.php
3 files changed, 30 insertions(+), 15 deletions(-)

Approvals:
  Siebrand: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/32009
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8e8e22b3193f1cdad590dd9bcdccfc785c140321
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/ReplaceText
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: Jack Phoenix 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: Yaron Koren 
Gerrit-Reviewer: preilly 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add link description and make right message consistent - change (mediawiki...TimedMediaHandler[master])

2012-12-08 Thread Siebrand (Code Review)
Siebrand has submitted this change and it was merged.

Change subject: Add link description and make right message consistent
..


Add link description and make right message consistent

Inconsistencies and uglyness spotted by Der Umherirrende on
translatewiki.net.

Change-Id: I18081a2793c271af3ebef7b6d0584c33af67a716
---
M TimedMediaHandler.i18n.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Siebrand: Verified; Looks good to me, approved
  jenkins-bot: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37619
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I18081a2793c271af3ebef7b6d0584c33af67a716
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Siebrand 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] GettextFFS: Empty msgctxt must be different from no msgctxt - change (mediawiki...Translate[master])

2012-12-08 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: GettextFFS: Empty msgctxt must be different from no msgctxt
..


GettextFFS: Empty msgctxt must be different from no msgctxt

Tests included

Change-Id: I63e179ca7194ba4e4c8944bbd3040c0cf0db68df
---
M ffs/GettextFFS.php
M tests/GettextFFSTest.php
2 files changed, 49 insertions(+), 5 deletions(-)

Approvals:
  Siebrand: Looks good to me, approved
  jenkins-bot: Verified; Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37001
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I63e179ca7194ba4e4c8944bbd3040c0cf0db68df
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Allow SQL queries with long field list to wrap - change (mediawiki/core[master])

2012-12-08 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Allow SQL queries with long field list to wrap
..


Allow SQL queries with long field list to wrap

Change-Id: I7ed64a246455a7f2c48e7e120d45d1ebeb929584
---
M profileinfo.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Martineznovo: Looks good to me, but someone else must approve
  Siebrand: Looks good to me, approved
  jenkins-bot: Verified; Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37618
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7ed64a246455a7f2c48e7e120d45d1ebeb929584
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 
Gerrit-Reviewer: Martineznovo 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] support smaller audio player - change (mediawiki...TimedMediaHandler[master])

2012-12-08 Thread J (Code Review)
J has submitted this change and it was merged.

Change subject: support smaller audio player
..


support smaller audio player

allow smaller audio embeds, minium width 35px.
reorder controls so that small players get
play/pause button and volume first.

Patch-Set 2: fixed medium sized players ( were only showing menu )

Change-Id: I74272d9c0a65db66e7d546fc4bb4cbbfb37a2a43
---
M MwEmbedModules/EmbedPlayer/resources/skins/kskin/mw.PlayerSkinKskin.js
M MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js
M TimedMediaTransformOutput.php
3 files changed, 75 insertions(+), 73 deletions(-)

Approvals:
  Mdale: Verified; Looks good to me, but someone else must approve
  J: Verified; Looks good to me, approved
  jenkins-bot: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37410
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I74272d9c0a65db66e7d546fc4bb4cbbfb37a2a43
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: J 
Gerrit-Reviewer: J 
Gerrit-Reviewer: Mdale 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Bug 42367 fix edit link for old revisions - change (mediawiki...TimedMediaHandler[master])

2012-12-08 Thread J (Code Review)
J has submitted this change and it was merged.

Change subject: Bug 42367 fix edit link for old revisions
..


Bug 42367 fix edit link for old revisions

Change-Id: I539bf3373b505e4f0cca0d0c41756eb70482a194
---
M TimedTextPage.php
1 file changed, 14 insertions(+), 1 deletion(-)

Approvals:
  Mdale: Verified; Looks good to me, approved
  J: 
  jenkins-bot: Verified; Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/35175
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I539bf3373b505e4f0cca0d0c41756eb70482a194
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: J 
Gerrit-Reviewer: J 
Gerrit-Reviewer: Mdale 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix silly mistake, unit tests use @group - change (mediawiki...Translate[master])

2012-12-08 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Fix silly mistake, unit tests use @group
..


Fix silly mistake, unit tests use @group

Change-Id: I3a5fbf2b02207cbd5cf58f9e3a1c3fa7b0c66128
---
M tests/PageTranslationParserTest.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Siebrand: Looks good to me, approved
  jenkins-bot: Verified; Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37617
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3a5fbf2b02207cbd5cf58f9e3a1c3fa7b0c66128
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Remove duplicate message keys in aggregate groups - change (mediawiki...Translate[master])

2012-12-08 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Remove duplicate message keys in aggregate groups
..


Remove duplicate message keys in aggregate groups

For translate messages for example, ext-0-all for listed
three times for each message.

Performance impacts are neglible, CDB message index size was
reduced by 106810 bytes which is 1.4% reduction in size.

Change-Id: Ibf705f2023bb91603672add146579c82e7789d9a
---
M messagegroups/AggregateMessageGroup.php
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Siebrand: Looks good to me, approved
  jenkins-bot: Verified; Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37416
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf705f2023bb91603672add146579c82e7789d9a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fixup method parameter documentation - change (mediawiki...LabeledSectionTransclusion[master])

2012-12-08 Thread Tpt (Code Review)
Tpt has submitted this change and it was merged.

Change subject: Fixup method parameter documentation
..


Fixup method parameter documentation

Add type hints to some variables in methods

Replace extract() calls

Remove some un-needed comments

Change-Id: Iebb8d861c0ea6e1c075e8d012700f99d0fff788d
---
M LabeledSectionTransclusion.class.php
M lst.php
2 files changed, 52 insertions(+), 26 deletions(-)

Approvals:
  Tpt: Verified; Looks good to me, approved
  jenkins-bot: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/35295
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iebb8d861c0ea6e1c075e8d012700f99d0fff788d
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/extensions/LabeledSectionTransclusion
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Merlijn van Deen 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: Tpt 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Use MWNamespace method instead of binary arithmetic - change (mediawiki/core[master])

2012-12-08 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged.

Change subject: Use MWNamespace method instead of binary arithmetic
..


Use MWNamespace method instead of binary arithmetic

"& ~1" or "| 1" are not easy to read

Change-Id: I08ff92669d32f3663ea58e98d8c49f0a54dfeca4
---
M includes/Title.php
M includes/specials/SpecialEditWatchlist.php
2 files changed, 6 insertions(+), 6 deletions(-)

Approvals:
  IAlex: Verified; Looks good to me, approved
  jenkins-bot: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37616
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I08ff92669d32f3663ea58e98d8c49f0a54dfeca4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: IAlex 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Memory setting for djvutext is now a constant - change (mediawiki/core[master])

2012-12-08 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged.

Change subject: Memory setting for djvutext is now a constant
..


Memory setting for djvutext is now a constant

This is a follow-up for change Ia735e1b7.
See also bug 42466.

Change-Id: I67d8ae9000713c349c7506e9a77d350c89992400
---
M includes/media/DjVuImage.php
1 file changed, 11 insertions(+), 1 deletion(-)

Approvals:
  IAlex: Verified; Looks good to me, approved
  Tpt: Looks good to me, but someone else must approve
  jenkins-bot: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37495
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I67d8ae9000713c349c7506e9a77d350c89992400
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Dereckson 
Gerrit-Reviewer: Dereckson 
Gerrit-Reviewer: IAlex 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: Tpt 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] worthwhile tests in testTitleObjectStringConversion - change (mediawiki/core[master])

2012-12-08 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged.

Change subject: worthwhile tests in testTitleObjectStringConversion
..


worthwhile tests in testTitleObjectStringConversion

The previous tests were not reflecting their comment, I have tweaked the
assertions a bit to actually test something that reflect the comments.

Change-Id: Ie1764ee1a218ead0169958704ba8625ab8d56445
---
M tests/phpunit/includes/SampleTest.php
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  IAlex: Verified; Looks good to me, approved
  Hashar: Looks good to me, but someone else must approve
  Umherirrender: Looks good to me, but someone else must approve
  jenkins-bot: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37440
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1764ee1a218ead0169958704ba8625ab8d56445
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Hashar 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: IAlex 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Replace deprecated Title::userIsWatching() - change (mediawiki/core[master])

2012-12-08 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged.

Change subject: Replace deprecated Title::userIsWatching()
..


Replace deprecated Title::userIsWatching()

Change-Id: I74203e4ed51be6fe72414d1a0b95b8370aaf0720
---
M includes/ProtectionForm.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  IAlex: Verified; Looks good to me, approved
  jenkins-bot: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37466
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I74203e4ed51be6fe72414d1a0b95b8370aaf0720
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Platonides 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: IAlex 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 38897) Fix unhandled exception when visiting e.g. Media... - change (mediawiki/core[master])

2012-12-08 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged.

Change subject: (bug 38897) Fix unhandled exception when visiting e.g. 
MediaWiki:Somemessage/0
..


(bug 38897) Fix unhandled exception when visiting e.g. MediaWiki:Somemessage/0

Change-Id: I9876e4fb21c2a1a3a0a14bff05633c7aef6a3fd3
---
M includes/LocalisationCache.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  IAlex: Verified; Looks good to me, approved
  jenkins-bot: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/34682
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9876e4fb21c2a1a3a0a14bff05633c7aef6a3fd3
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: MaxSem 
Gerrit-Reviewer: IAlex 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] prefix debug log when they end up in the main log - change (mediawiki/core[master])

2012-12-08 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged.

Change subject: prefix debug log when they end up in the main log
..


prefix debug log when they end up in the main log

Whenever we use wfDebugLog( "group", "message" ); and "group" is not
also set in $wfDebugLogGroups, the group information is lost. By
prefixing the message with the group name, it makes it obvious where the
message comes from.

Example output:

...
[EventLogging] wgEventLoggingSchemaIndexUri has not been configured.
[EventLogging] EventLogging requires memcached, and no memcached[...]
Fully initialised
Profiler::instance called without $wgProfiler['class'] set[...]
Connected to database 0 at
MessageGroups::init-nocache
SQL ERROR (ignored): no such table: revtag_type
MessageGroups::loadGroupDefinitions-end
[ContentHandler] Created handler for wikitext: WikitextContentHandler
[ContentHandler] Created handler for javascript: JavaScriptContentHandler
...

Change-Id: Id75401bec516b5111cd1e3d4a9b29843953ce12b
---
M RELEASE-NOTES-1.21
M includes/GlobalFunctions.php
2 files changed, 4 insertions(+), 1 deletion(-)

Approvals:
  IAlex: Verified; Looks good to me, approved
  jenkins-bot: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37442
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id75401bec516b5111cd1e3d4a9b29843953ce12b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Hashar 
Gerrit-Reviewer: IAlex 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Removed $wgTranslateAC and $wgTranslateEC - change (mediawiki...Translate[master])

2012-12-08 Thread Nikerabbit (Code Review)
Nikerabbit has uploaded a new change for review.

Change subject: Removed $wgTranslateAC and $wgTranslateEC
..

Removed $wgTranslateAC and $wgTranslateEC

Left $wgTranslateCC for now, but everyone is recommended
to start using the TranslatePostInitGroups hook or yaml
based message group configuration.

Change-Id: I5a9f1c830af44c88e0333b2e79a2a15f8c528904
---
M MessageGroups.php
M Translate.php
M tests/ApiQueryMessageGroupsTest.php
M tests/ApiTranslationReviewTest.php
M tests/MessageGroupStatesUpdaterJobTest.php
M tests/PageTranslationTaggingTest.php
M tests/TranslationFuzzyUpdaterTest.php
7 files changed, 3 insertions(+), 44 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/24/37624/1
--
To view, visit https://gerrit.wikimedia.org/r/37624
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a9f1c830af44c88e0333b2e79a2a15f8c528904
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Missing parent::setUp to JsonFFSTest - change (mediawiki...Translate[master])

2012-12-08 Thread Nikerabbit (Code Review)
Nikerabbit has uploaded a new change for review.

Change subject: Missing parent::setUp to JsonFFSTest
..

Missing parent::setUp to JsonFFSTest

Change-Id: Ia0f2f81c3cfeb04e94a191e1806c1fdfd377b90e
---
M tests/JsonFFSTest.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/25/37625/1
--
To view, visit https://gerrit.wikimedia.org/r/37625
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0f2f81c3cfeb04e94a191e1806c1fdfd377b90e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] WikiMessageGroup: check that message definition message exis... - change (mediawiki...Translate[master])

2012-12-08 Thread Nikerabbit (Code Review)
Nikerabbit has uploaded a new change for review.

Change subject: WikiMessageGroup: check that message definition message exists
..

WikiMessageGroup: check that message definition message exists

Gave me test failures because  is not a valid title.

Change-Id: I426b272d89426d90b29d099a28e70fa77e9a15b6
---
M messagegroups/WikiMessageGroup.php
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/26/37626/1
--
To view, visit https://gerrit.wikimedia.org/r/37626
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I426b272d89426d90b29d099a28e70fa77e9a15b6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Rectify missing dependency on mediawiki.Uri - change (mediawiki...Translate[master])

2012-12-08 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review.

Change subject: Rectify missing dependency on mediawiki.Uri
..

Rectify missing dependency on mediawiki.Uri

Change-Id: Ib39f8ed59e0626bb4c2a549338a018b080e89d4c
---
M Translate.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/27/37627/1
--
To view, visit https://gerrit.wikimedia.org/r/37627
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib39f8ed59e0626bb4c2a549338a018b080e89d4c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Jarry1250 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Rectify missing dependency on mediawiki.Uri - change (mediawiki...Translate[master])

2012-12-08 Thread Santhosh (Code Review)
Santhosh has submitted this change and it was merged.

Change subject: Rectify missing dependency on mediawiki.Uri
..


Rectify missing dependency on mediawiki.Uri

Change-Id: Ib39f8ed59e0626bb4c2a549338a018b080e89d4c
---
M Translate.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Santhosh: Verified; Looks good to me, approved
  jenkins-bot: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37627
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib39f8ed59e0626bb4c2a549338a018b080e89d4c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Jarry1250 
Gerrit-Reviewer: Santhosh 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Present the exports as downloadable files - change (mediawiki...Translate[master])

2012-12-08 Thread Nikerabbit (Code Review)
Nikerabbit has uploaded a new change for review.

Change subject: Present the exports as downloadable files
..

Present the exports as downloadable files

Change-Id: I6472b55d2fdfef6378337fb93a884f94db334fc8
---
M TranslateTasks.php
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/28/37628/1
--
To view, visit https://gerrit.wikimedia.org/r/37628
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6472b55d2fdfef6378337fb93a884f94db334fc8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix simple but deadly logic error - change (mediawiki...TranslateSvg[master])

2012-12-08 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review.

Change subject: Fix simple but deadly logic error
..

Fix simple but deadly logic error

Change-Id: I586bc8995f4016765991aa53ccd40f330aabd313
---
M TranslateSvgHooks.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TranslateSvg 
refs/changes/29/37629/1
--
To view, visit https://gerrit.wikimedia.org/r/37629
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I586bc8995f4016765991aa53ccd40f330aabd313
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TranslateSvg
Gerrit-Branch: master
Gerrit-Owner: Jarry1250 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix simple but deadly logic error - change (mediawiki...TranslateSvg[master])

2012-12-08 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged.

Change subject: Fix simple but deadly logic error
..


Fix simple but deadly logic error

Change-Id: I586bc8995f4016765991aa53ccd40f330aabd313
---
M TranslateSvgHooks.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jarry1250: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/37629
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I586bc8995f4016765991aa53ccd40f330aabd313
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/TranslateSvg
Gerrit-Branch: master
Gerrit-Owner: Jarry1250 
Gerrit-Reviewer: Jarry1250 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Hook TranslateSupportedLanguages - change (mediawiki...Translate[master])

2012-12-08 Thread Nikerabbit (Code Review)
Nikerabbit has uploaded a new change for review.

Change subject: Hook TranslateSupportedLanguages
..

Hook TranslateSupportedLanguages

Change-Id: Id4abbe5dba5623036872a362345acbfb7f585adb
---
M TranslateUtils.php
M hooks.txt
2 files changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/30/37630/1
--
To view, visit https://gerrit.wikimedia.org/r/37630
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4abbe5dba5623036872a362345acbfb7f585adb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix [[Category:Foo]] wt2wt regression. - change (mediawiki...Parsoid[master])

2012-12-08 Thread Subramanya Sastry (Code Review)
Subramanya Sastry has uploaded a new change for review.

Change subject: Fix [[Category:Foo]] wt2wt regression.
..

Fix [[Category:Foo]] wt2wt regression.

+1 wt2wt tests green.

Change-Id: Ieeabd4c125c1e85d47b1936fc1594238b97bb476
---
M js/lib/mediawiki.WikitextSerializer.js
1 file changed, 4 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid 
refs/changes/31/37631/1
--
To view, visit https://gerrit.wikimedia.org/r/37631
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieeabd4c125c1e85d47b1936fc1594238b97bb476
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 40585) Don't drop 'step="any"' in HTML input fields. - change (mediawiki/core[REL1_19])

2012-12-08 Thread Tim Landscheidt (Code Review)
Tim Landscheidt has uploaded a new change for review.

Change subject: (bug 40585) Don't drop 'step="any"' in HTML input fields.
..

(bug 40585) Don't drop 'step="any"' in HTML input fields.

The default value for "step" is "1" which effectively bans any decimal
number from being entered into an 'type="number"' field and makes
HTMLFloatField unusable.

This is a backport of 6dc4039270af99413cc7c3bf85b136d9a79e7497.

Change-Id: I869f0fa3935b8ff9e22bbf69ddc46ef79674ed2b
---
M includes/Html.php
M tests/phpunit/includes/HtmlTest.php
2 files changed, 19 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/32/37632/1
--
To view, visit https://gerrit.wikimedia.org/r/37632
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I869f0fa3935b8ff9e22bbf69ddc46ef79674ed2b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_19
Gerrit-Owner: Tim Landscheidt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (Bug 42225) Don't format numbers twice - change (mediawiki...LiquidThreads[master])

2012-12-08 Thread Nikerabbit (Code Review)
Nikerabbit has uploaded a new change for review.

Change subject: (Bug 42225) Don't format numbers twice
..

(Bug 42225) Don't format numbers twice

Causes: PHP Notice: Undefined offset: 0 in
./languages/Language.php on line 2965

Change-Id: Ibbcf21f70c08746164de5a46c7949c64b60d8c13
---
M classes/View.php
1 file changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LiquidThreads 
refs/changes/33/37633/1
--
To view, visit https://gerrit.wikimedia.org/r/37633
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibbcf21f70c08746164de5a46c7949c64b60d8c13
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LiquidThreads
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Some cleanups to getShowReplies - change (mediawiki...LiquidThreads[master])

2012-12-08 Thread Nikerabbit (Code Review)
Nikerabbit has uploaded a new change for review.

Change subject: Some cleanups to getShowReplies
..

Some cleanups to getShowReplies

Change-Id: Ice223cd8668e1273b7fccd920049a76a4b3fb329
---
M classes/View.php
1 file changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LiquidThreads 
refs/changes/34/37634/1
--
To view, visit https://gerrit.wikimedia.org/r/37634
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice223cd8668e1273b7fccd920049a76a4b3fb329
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LiquidThreads
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 40585) Don't drop 'step="any"' in HTML input fields. - change (mediawiki/core[REL1_20])

2012-12-08 Thread Tim Landscheidt (Code Review)
Tim Landscheidt has uploaded a new change for review.

Change subject: (bug 40585) Don't drop 'step="any"' in HTML input fields.
..

(bug 40585) Don't drop 'step="any"' in HTML input fields.

The default value for "step" is "1" which effectively bans any decimal
number from being entered into an 'type="number"' field and makes
HTMLFloatField unusable.

This is a backport of 6dc4039270af99413cc7c3bf85b136d9a79e7497.

Change-Id: Ibda2b49395705c5902c751525b75213653b0ea5d
---
M includes/Html.php
M tests/phpunit/includes/HtmlTest.php
2 files changed, 19 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/35/37635/1
--
To view, visit https://gerrit.wikimedia.org/r/37635
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibda2b49395705c5902c751525b75213653b0ea5d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_20
Gerrit-Owner: Tim Landscheidt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Once more: Fix tsr for tags -- this time correctly! - change (mediawiki...Parsoid[master])

2012-12-08 Thread GWicke (Code Review)
GWicke has submitted this change and it was merged.

Change subject: Once more: Fix tsr for  tags -- this time correctly!
..


Once more: Fix tsr for  tags -- this time correctly!

Change-Id: I4c4adc3c1663b96004d1a4fa483e7ea16699f10f
---
M js/lib/pegTokenizer.pegjs.txt
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  GWicke: Verified; Looks good to me, approved
  jenkins-bot: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37608
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4c4adc3c1663b96004d1a4fa483e7ea16699f10f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry 
Gerrit-Reviewer: GWicke 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix [[Category:Foo]] wt2wt regression. - change (mediawiki...Parsoid[master])

2012-12-08 Thread Subramanya Sastry (Code Review)
Subramanya Sastry has submitted this change and it was merged.

Change subject: Fix [[Category:Foo]] wt2wt regression.
..


Fix [[Category:Foo]] wt2wt regression.

+3 wt2wt tests green.

Change-Id: Ieeabd4c125c1e85d47b1936fc1594238b97bb476
---
M js/lib/mediawiki.WikitextSerializer.js
1 file changed, 8 insertions(+), 12 deletions(-)

Approvals:
  Subramanya Sastry: Verified; Looks good to me, approved
  jenkins-bot: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37631
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieeabd4c125c1e85d47b1936fc1594238b97bb476
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry 
Gerrit-Reviewer: GWicke 
Gerrit-Reviewer: Subramanya Sastry 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fixed to work with Git - change (mediawiki...SemanticBundle[master])

2012-12-08 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged.

Change subject: Fixed to work with Git
..


Fixed to work with Git

Change-Id: Ib622f322ec80662574298f9fe912d9dbca6e51cb
---
M Makefile
M externals
2 files changed, 27 insertions(+), 33 deletions(-)

Approvals:
  Jeroen De Dauw: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36582
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib622f322ec80662574298f9fe912d9dbca6e51cb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticBundle
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 
Gerrit-Reviewer: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Improve help messages of the index form - change (mediawiki...ProofreadPage[master])

2012-12-08 Thread Tpt (Code Review)
Tpt has uploaded a new change for review.

Change subject: Improve help messages of the index form
..

Improve help messages of the index form

Change-Id: I2e6f95346cb290c35d7ba03d801acdf429edf545
---
M includes/index/EditProofreadIndexPage.php
M modules/ext.proofreadpage.index/ext.proofreadpage.index.css
M modules/ext.proofreadpage.index/ext.proofreadpage.index.js
A modules/ext.proofreadpage.index/images/help-question.gif
4 files changed, 13 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage 
refs/changes/36/37636/1
--
To view, visit https://gerrit.wikimedia.org/r/37636
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e6f95346cb290c35d7ba03d801acdf429edf545
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Tpt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix check to see if element is there already. - change (mediawiki/core[master])

2012-12-08 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

Change subject: Fix check to see if element is there already.
..

Fix check to see if element is there already.

PHP docs disagree with reality when it comes to return type of offsetGet, so 
switching to offsetExists.

Issue spotted by Brad Jorsch

Change-Id: I4ce1651d4ed681ab55cf297090ee963b64584bbf
---
M includes/site/SiteArray.php
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/37/37637/1
--
To view, visit https://gerrit.wikimedia.org/r/37637
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ce1651d4ed681ab55cf297090ee963b64584bbf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix check to see if element is there already. - change (mediawiki...Wikibase[master])

2012-12-08 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

Change subject: Fix check to see if element is there already.
..

Fix check to see if element is there already.

PHP docs disagree with reality when it comes to return type of offsetGet, so 
switching to offsetExists.

Issue spotted by Brad Jorsch

Change-Id: Ia9fe49c71473c4eb7975d2acd3d01a800c516618
---
M lib/includes/HashArray.php
M lib/includes/claim/ClaimList.php
2 files changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/38/37638/1
--
To view, visit https://gerrit.wikimedia.org/r/37638
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9fe49c71473c4eb7975d2acd3d01a800c516618
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Remove broken test. - change (mediawiki/core[master])

2012-12-08 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Remove broken test.
..


Remove broken test.

Calling the method does not raise an exception but a notice (depending on 
settings).
PHPUnit just happens to turn this into an exception. The test thus breaks if 
PHPUnit
does not do this, which apparently happens in some cases and caused bug 41491

Change-Id: I9d14fd875c70c8b3d164c0b8a4fa2667c5769682
---
M tests/phpunit/includes/libs/GenericArrayObjectTest.php
1 file changed, 4 insertions(+), 5 deletions(-)

Approvals:
  Nikerabbit: Verified; Looks good to me, approved
  jenkins-bot: Verified; Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37470
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9d14fd875c70c8b3d164c0b8a4fa2667c5769682
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 
Gerrit-Reviewer: Daniel Kinzler 
Gerrit-Reviewer: Jeroen De Dauw 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Remove unused para $db for getMarkedTag and getReadyTag - change (mediawiki...Translate[master])

2012-12-08 Thread Gerrit Code Review
Anonymous Coward has submitted this change and it was merged.

Change subject: Remove unused para $db for getMarkedTag and getReadyTag
..


Remove unused para $db for getMarkedTag and getReadyTag

Most probably a leftover from an earlier refactoring.

Change-Id: I0b8390949e0e10834485687a4e7e282ec11c70c3
---
M tag/PageTranslationHooks.php
M tag/TranslatablePage.php
M tests/PageTranslationTaggingTest.php
3 files changed, 11 insertions(+), 13 deletions(-)

Approvals:
  jenkins-bot: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37018
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0b8390949e0e10834485687a4e7e282ec11c70c3
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Siebrand 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 42853) Namespaces configuration for en.wikisource - change (operations/mediawiki-config[master])

2012-12-08 Thread Dereckson (Code Review)
Dereckson has uploaded a new change for review.

Change subject: (bug 42853) Namespaces configuration for en.wikisource
..

(bug 42853) Namespaces configuration for en.wikisource

New aliases:
- WS: NS_PROJECT
- WT: NS_PROJECT_TALK

Change-Id: Ic3f0bdde057f2e5aac8b98f344456b5915ebd80c
---
M wmf-config/InitialiseSettings.php
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/39/37639/1
--
To view, visit https://gerrit.wikimedia.org/r/37639
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic3f0bdde057f2e5aac8b98f344456b5915ebd80c
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Dereckson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 42491) Get rid of wikimedia-editpage-tos-summary - change (mediawiki...WikimediaMessages[master])

2012-12-08 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged.

Change subject: (bug 42491) Get rid of wikimedia-editpage-tos-summary
..


(bug 42491) Get rid of wikimedia-editpage-tos-summary

It is overly verbose and repeats contents of wikimedia-copyrightwarning message.

Such change was already approved by the Legal team on the English Wikipedia,
where wikimedia-editpage-tos-summary is blanked.

Change-Id: I7b14c8a6c36758f190a95d0a6be6a6f0c8c4ecbb
---
M WikimediaMessages.i18n.php
M WikimediaMessages.php
2 files changed, 0 insertions(+), 8 deletions(-)

Approvals:
  Krinkle: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/35609
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7b14c8a6c36758f190a95d0a6be6a6f0c8c4ecbb
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/WikimediaMessages
Gerrit-Branch: master
Gerrit-Owner: Matmarex 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Matmarex 
Gerrit-Reviewer: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update/correct/add docs - change (mediawiki...Translate[master])

2012-12-08 Thread Siebrand (Code Review)
Siebrand has submitted this change and it was merged.

Change subject: Update/correct/add docs
..


Update/correct/add docs

Change-Id: I9af413f96bbc7ff64b2e526d4ec938c530d30fc4
---
M tag/TranslatablePage.php
M utils/RevTag.php
2 files changed, 45 insertions(+), 38 deletions(-)

Approvals:
  Nikerabbit: Looks good to me, approved
  Siebrand: 
  jenkins-bot: Verified; Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37017
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9af413f96bbc7ff64b2e526d4ec938c530d30fc4
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Siebrand 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Protect piped links and empty category sort keys from PST - change (mediawiki...Parsoid[master])

2012-12-08 Thread GWicke (Code Review)
GWicke has uploaded a new change for review.

Change subject: Protect piped links and empty category sort keys from PST
..

Protect piped links and empty category sort keys from PST

* Protect new / modified wiki and category links with empty link text from the
  PST pipe trick expansion with . This fixes html2html tests and
  closely resembles the original (invisible) rendering. For category links, it
  preserves the empty string as a sort key.

  This issue is not covered by parser tests since those don't include the PST
  in the html2wt and html2html tests.

* Fix a bug in pipe trick round-tripping. The pipetrick data-parsoid flag was
  never set because of a bug in the tokenizer, which made it impossible to
  distinguish between newly created links with empty content and pre-existing
  pipetrick content (which is pretty rare). This information is needed to
  selectively apply the  escaping only to new links.

No changes in parser tests as we don't apply PST transforms in our round-trip
tests.

TODO: Add the capability to run PST transforms in html2html and html2wt test
modes.

Change-Id: I9e1347045d29bc95c692dfe80e4f47fbc09bb86d
---
M js/lib/mediawiki.WikitextSerializer.js
M js/lib/pegTokenizer.pegjs.txt
2 files changed, 15 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid 
refs/changes/40/37640/1
--
To view, visit https://gerrit.wikimedia.org/r/37640
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e1347045d29bc95c692dfe80e4f47fbc09bb86d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 42800) Make MoodBar log entries make sense - change (mediawiki...MoodBar[master])

2012-12-08 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review.

Change subject: (bug 42800) Make MoodBar log entries make sense
..

(bug 42800) Make MoodBar log entries make sense

Change-Id: If920df0fb478056f505979da8aa2e62b645a8868
---
M MoodBar.i18n.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MoodBar 
refs/changes/41/37641/1
--
To view, visit https://gerrit.wikimedia.org/r/37641
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If920df0fb478056f505979da8aa2e62b645a8868
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MoodBar
Gerrit-Branch: master
Gerrit-Owner: Alex Monk 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (no bug) A minor fix of ItemDisambiguation - change (mediawiki...Wikibase[master])

2012-12-08 Thread John Erling Blad (Code Review)
John Erling Blad has uploaded a new change for review.

Change subject: (no bug) A minor fix of ItemDisambiguation
..

(no bug) A minor fix of ItemDisambiguation

Change-Id: I161c1fd768687f850df474b437617b240c30bbb6
---
M repo/Wikibase.i18n.php
M repo/includes/ItemDisambiguation.php
2 files changed, 20 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/42/37642/1
--
To view, visit https://gerrit.wikimedia.org/r/37642
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I161c1fd768687f850df474b437617b240c30bbb6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: John Erling Blad 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 41818) Only call ApiResult::setContent once - change (mediawiki...MoodBar[master])

2012-12-08 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review.

Change subject: (bug 41818) Only call ApiResult::setContent once
..

(bug 41818) Only call ApiResult::setContent once

Change-Id: I92ca27070d64f2c912793f2f75e7f90c2e66a457
---
M ApiQueryMoodBarComments.php
1 file changed, 7 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MoodBar 
refs/changes/43/37643/1
--
To view, visit https://gerrit.wikimedia.org/r/37643
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I92ca27070d64f2c912793f2f75e7f90c2e66a457
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MoodBar
Gerrit-Branch: master
Gerrit-Owner: Alex Monk 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] The error message should refer to $wgContentHandlerUseDB - change (mediawiki/core[master])

2012-12-08 Thread Platonides (Code Review)
Platonides has uploaded a new change for review.

Change subject: The error message should refer to $wgContentHandlerUseDB
..

The error message should refer to $wgContentHandlerUseDB

Change-Id: I81bc50e6949cecdc7f3d7e0b89f54464b4a146c7
---
M tests/phpunit/includes/WikiPageTest.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/44/37644/1
--
To view, visit https://gerrit.wikimedia.org/r/37644
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I81bc50e6949cecdc7f3d7e0b89f54464b4a146c7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Platonides 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (minor) Fix bad check and wrong message in test - change (mediawiki/core[master])

2012-12-08 Thread Daniel Kinzler (Code Review)
Daniel Kinzler has uploaded a new change for review.

Change subject: (minor) Fix bad check and wrong message in test
..

(minor) Fix bad check and wrong message in test

Change-Id: I13b0b4f3c622f4c726e4939de74d902cefcf0757
---
M tests/phpunit/includes/WikiPageTest.php
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/45/37645/1
--
To view, visit https://gerrit.wikimedia.org/r/37645
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I13b0b4f3c622f4c726e4939de74d902cefcf0757
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix condition for the entries with a null model. - change (mediawiki/core[master])

2012-12-08 Thread Platonides (Code Review)
Platonides has uploaded a new change for review.

Change subject: Fix condition for the entries with a null model.
..

Fix condition for the entries with a null model.

A null model means ‘guess from page name’.

Change-Id: I63e80761e46cc7707e9c862e2e50a950c1766aa4
---
M tests/phpunit/includes/WikiPageTest.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/46/37646/1
--
To view, visit https://gerrit.wikimedia.org/r/37646
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I63e80761e46cc7707e9c862e2e50a950c1766aa4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Platonides 
Gerrit-Reviewer: Daniel Kinzler 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (minor) check content's model, not page's - change (mediawiki...Wikibase[master])

2012-12-08 Thread Daniel Kinzler (Code Review)
Daniel Kinzler has uploaded a new change for review.

Change subject: (minor) check content's model, not page's
..

(minor) check content's model, not page's

Change-Id: Iea360013b648da8377e1120e76c90181b6d86e7e
---
M repo/Wikibase.hooks.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/47/37647/1
--
To view, visit https://gerrit.wikimedia.org/r/37647
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea360013b648da8377e1120e76c90181b6d86e7e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Move a part of the index pages related code to ProofreadInde... - change (mediawiki...ProofreadPage[master])

2012-12-08 Thread Tpt (Code Review)
Tpt has uploaded a new change for review.

Change subject: Move a part of the index pages related code to 
ProofreadIndexPage
..

Move a part of the index pages related code to ProofreadIndexPage

Clean also a lot of old code

The move of the management of the pr_index table in a specific class will
be done in an other commit

Change-Id: Ibf19db7b691056d9e211e2cab7750086f4ae8abd
---
M ProofreadPage.body.php
M ProofreadPage.php
M includes/index/EditProofreadIndexPage.php
M includes/index/ProofreadIndexEntry.php
M includes/index/ProofreadIndexPage.php
5 files changed, 265 insertions(+), 195 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage 
refs/changes/48/37648/1
--
To view, visit https://gerrit.wikimedia.org/r/37648
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf19db7b691056d9e211e2cab7750086f4ae8abd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Tpt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] The error message should refer to $wgContentHandlerUseDB - change (mediawiki/core[master])

2012-12-08 Thread Daniel Kinzler (Code Review)
Daniel Kinzler has submitted this change and it was merged.

Change subject: The error message should refer to $wgContentHandlerUseDB
..


The error message should refer to $wgContentHandlerUseDB

Change-Id: I81bc50e6949cecdc7f3d7e0b89f54464b4a146c7
---
M tests/phpunit/includes/WikiPageTest.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Daniel Kinzler: Verified; Looks good to me, approved
  jenkins-bot: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37644
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I81bc50e6949cecdc7f3d7e0b89f54464b4a146c7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Platonides 
Gerrit-Reviewer: Daniel Kinzler 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix condition for the entries with a null model. - change (mediawiki/core[master])

2012-12-08 Thread Daniel Kinzler (Code Review)
Daniel Kinzler has submitted this change and it was merged.

Change subject: Fix condition for the entries with a null model.
..


Fix condition for the entries with a null model.

A null model means ‘guess from page name’.

Change-Id: I63e80761e46cc7707e9c862e2e50a950c1766aa4
---
M tests/phpunit/includes/WikiPageTest.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Daniel Kinzler: Verified; Looks good to me, approved
  jenkins-bot: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37646
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I63e80761e46cc7707e9c862e2e50a950c1766aa4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Platonides 
Gerrit-Reviewer: Daniel Kinzler 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 41173) Don't hardcode enwiki URLs for MoodBar config - change (operations/mediawiki-config[master])

2012-12-08 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review.

Change subject: (bug 41173) Don't hardcode enwiki URLs for MoodBar config
..

(bug 41173) Don't hardcode enwiki URLs for MoodBar config

Change-Id: I39e532ce8f0b544d01733c58958cd97f03240d31
---
M wmf-config/CommonSettings.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/49/37649/1
--
To view, visit https://gerrit.wikimedia.org/r/37649
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I39e532ce8f0b544d01733c58958cd97f03240d31
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Alex Monk 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (Bug 41173) Do not redirect Moodbar to enwiki from nlwiki - change (operations/mediawiki-config[master])

2012-12-08 Thread Platonides (Code Review)
Platonides has uploaded a new change for review.

Change subject: (Bug 41173) Do not redirect Moodbar to enwiki from nlwiki
..

(Bug 41173) Do not redirect Moodbar to enwiki from nlwiki

Change-Id: I8d26e8bca739073564374a84d2c433594f9574b4
---
M wmf-config/CommonSettings.php
M wmf-config/InitialiseSettings.php
2 files changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/50/37650/1
--
To view, visit https://gerrit.wikimedia.org/r/37650
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d26e8bca739073564374a84d2c433594f9574b4
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Platonides 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (minor) check content's model, not page's - change (mediawiki...Wikibase[master])

2012-12-08 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged.

Change subject: (minor) check content's model, not page's
..


(minor) check content's model, not page's

Change-Id: Iea360013b648da8377e1120e76c90181b6d86e7e
---
M repo/Wikibase.hooks.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jeroen De Dauw: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/37647
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iea360013b648da8377e1120e76c90181b6d86e7e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler 
Gerrit-Reviewer: Jeroen De Dauw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fixed name of externals file - change (mediawiki...SemanticBundle[master])

2012-12-08 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

Change subject: fixed name of externals file
..

fixed name of externals file

Change-Id: I1ac8ae9cf5cfced7e2a7abd58c1a598f4cd05074
---
M Makefile
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticBundle 
refs/changes/51/37651/1
--
To view, visit https://gerrit.wikimedia.org/r/37651
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ac8ae9cf5cfced7e2a7abd58c1a598f4cd05074
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticBundle
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Remove .git and other hidden files - change (mediawiki...SemanticBundle[master])

2012-12-08 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

Change subject: Remove .git and other hidden files
..

Remove .git and other hidden files

Change-Id: I1fff97b6be7c7fc2c830c036ac375a50d8e9e768
---
M Makefile
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticBundle 
refs/changes/52/37652/1
--
To view, visit https://gerrit.wikimedia.org/r/37652
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1fff97b6be7c7fc2c830c036ac375a50d8e9e768
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticBundle
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Remove .git and other hidden files - change (mediawiki...SemanticBundle[master])

2012-12-08 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged.

Change subject: Remove .git and other hidden files
..


Remove .git and other hidden files

Change-Id: I1fff97b6be7c7fc2c830c036ac375a50d8e9e768
---
M Makefile
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jeroen De Dauw: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/37652
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1fff97b6be7c7fc2c830c036ac375a50d8e9e768
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticBundle
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 
Gerrit-Reviewer: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fixed name of externals file - change (mediawiki...SemanticBundle[master])

2012-12-08 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged.

Change subject: fixed name of externals file
..


fixed name of externals file

Change-Id: I1ac8ae9cf5cfced7e2a7abd58c1a598f4cd05074
---
M Makefile
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jeroen De Dauw: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/37651
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1ac8ae9cf5cfced7e2a7abd58c1a598f4cd05074
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticBundle
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 
Gerrit-Reviewer: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix check to see if element is there already. - change (mediawiki...Wikibase[master])

2012-12-08 Thread John Erling Blad (Code Review)
John Erling Blad has submitted this change and it was merged.

Change subject: Fix check to see if element is there already.
..


Fix check to see if element is there already.

PHP docs disagree with reality when it comes to return type of offsetGet, so 
switching to offsetExists.

Issue spotted by Brad Jorsch

Change-Id: Ia9fe49c71473c4eb7975d2acd3d01a800c516618
---
M lib/includes/HashArray.php
M lib/includes/claim/ClaimList.php
2 files changed, 8 insertions(+), 8 deletions(-)

Approvals:
  John Erling Blad: Verified; Looks good to me, approved
  Nikerabbit: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37638
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9fe49c71473c4eb7975d2acd3d01a800c516618
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 
Gerrit-Reviewer: Aude 
Gerrit-Reviewer: John Erling Blad 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (Bug 42844) Added print stylesheet to CologneBlue, and hid n... - change (mediawiki/core[master])

2012-12-08 Thread Matthewrbowker (Code Review)
Matthewrbowker has uploaded a new change for review.

Change subject: (Bug 42844) Added print stylesheet to CologneBlue, and hid 
navigation in commonPrint.css
..

(Bug 42844) Added print stylesheet to CologneBlue, and hid navigation in 
commonPrint.css

Change-Id: I672c52426a4e8821606b1b3a0baf224cd0e9d140
---
M skins/CologneBlue.php
M skins/common/commonPrint.css
2 files changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/53/37653/1
--
To view, visit https://gerrit.wikimedia.org/r/37653
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I672c52426a4e8821606b1b3a0baf224cd0e9d140
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Matthewrbowker 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 37692) Enforce one-based page numbers - change (mediawiki...PagedTiffHandler[master])

2012-12-08 Thread Lupo (Code Review)
Lupo has uploaded a new change for review.

Change subject: (bug 37692) Enforce one-based page numbers
..

(bug 37692) Enforce one-based page numbers

ImageMagick identify >= 6.6.8-10 returns zero-based page numbers, which
breaks this extension and leads to an error "The uploaded file contains
errors: inconsistent page numbering in TIFF directory".

This change maps the page numbers as returned by identify to a one-based
sequence.

Change-Id: I25052af7adb6f116c3f6a06652b5c0ce92c9d3a5
---
M PagedTiffHandler.image.php
1 file changed, 20 insertions(+), 4 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PagedTiffHandler 
refs/changes/54/37654/1
--
To view, visit https://gerrit.wikimedia.org/r/37654
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I25052af7adb6f116c3f6a06652b5c0ce92c9d3a5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PagedTiffHandler
Gerrit-Branch: master
Gerrit-Owner: Lupo 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Added test for ClaimList::removeDuplicates - change (mediawiki...Wikibase[master])

2012-12-08 Thread John Erling Blad (Code Review)
John Erling Blad has submitted this change and it was merged.

Change subject: Added test for ClaimList::removeDuplicates
..


Added test for ClaimList::removeDuplicates

Change-Id: I3e59e54ba2c5ae861188a218c32e44cf3f35d6c9
---
M lib/tests/phpunit/claim/ClaimListTest.php
1 file changed, 8 insertions(+), 2 deletions(-)

Approvals:
  John Erling Blad: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/37443
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3e59e54ba2c5ae861188a218c32e44cf3f35d6c9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 
Gerrit-Reviewer: Aude 
Gerrit-Reviewer: John Erling Blad 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] follow up to 62bd22646f94ab954927b78c5adb5804037ecb6b - remo... - change (mediawiki...Wikibase[master])

2012-12-08 Thread John Erling Blad (Code Review)
John Erling Blad has submitted this change and it was merged.

Change subject: follow up to 62bd22646f94ab954927b78c5adb5804037ecb6b - removed 
a code I missed
..


follow up to 62bd22646f94ab954927b78c5adb5804037ecb6b - removed a code I missed

Change-Id: I98eb60d3d83eb1d4887eb848262add0904ea2caf
---
M repo/includes/api/ApiCreateClaim.php
1 file changed, 0 insertions(+), 8 deletions(-)

Approvals:
  John Erling Blad: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/37444
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I98eb60d3d83eb1d4887eb848262add0904ea2caf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 
Gerrit-Reviewer: John Erling Blad 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] jshint ignore file - change (mediawiki...Parsoid[master])

2012-12-08 Thread GWicke (Code Review)
GWicke has submitted this change and it was merged.

Change subject: jshint ignore file
..


jshint ignore file

Instruct jshint to ignore third party libraries code:

 - js/lib/html5  (misc 3rd parties)
 - js/node_modules  (node.js modules)
 - js/api/scripts/jquery.js  (upstream JQuery)

Also removed some old paths from the ignore file.

Change-Id: I2e75ca19501b4d1ffabdd8b459810971264bb36d
---
M .jshintignore
1 file changed, 3 insertions(+), 6 deletions(-)

Approvals:
  GWicke: Verified; Looks good to me, approved
  jenkins-bot: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37066
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2e75ca19501b4d1ffabdd8b459810971264bb36d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Hashar 
Gerrit-Reviewer: GWicke 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Remove denies from config - it's an incorrect rule - change (operations/puppet[production])

2012-12-08 Thread Ryan Lane (Code Review)
Ryan Lane has uploaded a new change for review.

Change subject: Remove denies from config - it's an incorrect rule
..

Remove denies from config - it's an incorrect rule

Change-Id: I66e2d62f27678d3639086fbf4ac7aa4a8fae9af3
---
M manifests/role/deployment.pp
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/55/37655/1
--
To view, visit https://gerrit.wikimedia.org/r/37655
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I66e2d62f27678d3639086fbf4ac7aa4a8fae9af3
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ryan Lane 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Cleanup of DataTypeFactory and got rid of pointless interfac... - change (mediawiki...DataValues[master])

2012-12-08 Thread John Erling Blad (Code Review)
John Erling Blad has submitted this change and it was merged.

Change subject: Cleanup of DataTypeFactory and got rid of pointless interface
..


Cleanup of DataTypeFactory and got rid of pointless interface

Change-Id: I82f5e731ba9df1c2d63f49ebcb0ab8fff07d5960
---
M DataTypes/DataTypes.classes.php
M DataTypes/includes/DataType.php
M DataTypes/includes/DataTypeFactory.php
D DataTypes/includes/DataTypeObject.php
M DataTypes/includes/modules/DataTypesModule.php
M DataTypes/tests/includes/DataTypeFactoryTest.php
M DataTypes/tests/includes/DataTypeTest.php
7 files changed, 135 insertions(+), 251 deletions(-)

Approvals:
  John Erling Blad: Verified; Looks good to me, approved
  jenkins-bot: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37464
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I82f5e731ba9df1c2d63f49ebcb0ab8fff07d5960
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 
Gerrit-Reviewer: Jeroen De Dauw 
Gerrit-Reviewer: John Erling Blad 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Match DataTypeFactory changes in DataTypes - change (mediawiki...Wikibase[master])

2012-12-08 Thread John Erling Blad (Code Review)
John Erling Blad has submitted this change and it was merged.

Change subject: Match DataTypeFactory changes in DataTypes
..


Match DataTypeFactory changes in DataTypes

Change-Id: I5d79c33c68834f7f14a7f92a9e7bc976ab9e6979
---
M lib/WikibaseLib.php
A lib/includes/LibRegistry.php
M lib/includes/property/Property.php
M lib/tests/phpunit/property/PropertyTest.php
M lib/tests/phpunit/serializers/PropertySerializerTest.php
M lib/tests/phpunit/snak/PropertyValueSnakTest.php
M repo/includes/specials/SpecialNewProperty.php
M repo/maintenance/importProperties.php
M repo/tests/phpunit/includes/api/ApiGetClaimsTest.php
M repo/tests/phpunit/includes/api/ApiRemoveClaimsTest.php
M repo/tests/phpunit/includes/api/ApiSetClaimValueTest.php
M repo/tests/phpunit/includes/content/PropertyContentTest.php
12 files changed, 131 insertions(+), 64 deletions(-)

Approvals:
  John Erling Blad: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/37465
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5d79c33c68834f7f14a7f92a9e7bc976ab9e6979
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 
Gerrit-Reviewer: Jeroen De Dauw 
Gerrit-Reviewer: John Erling Blad 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 41818) Only call ApiResult::setContent once - change (mediawiki...MoodBar[master])

2012-12-08 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged.

Change subject: (bug 41818) Only call ApiResult::setContent once
..


(bug 41818) Only call ApiResult::setContent once

Change-Id: I92ca27070d64f2c912793f2f75e7f90c2e66a457
---
M ApiQueryMoodBarComments.php
1 file changed, 7 insertions(+), 5 deletions(-)

Approvals:
  Ori.livneh: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/37643
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I92ca27070d64f2c912793f2f75e7f90c2e66a457
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MoodBar
Gerrit-Branch: master
Gerrit-Owner: Alex Monk 
Gerrit-Reviewer: Ori.livneh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Remove denies from config - it's an incorrect rule - change (operations/puppet[production])

2012-12-08 Thread Ryan Lane (Code Review)
Ryan Lane has submitted this change and it was merged.

Change subject: Remove denies from config - it's an incorrect rule
..


Remove denies from config - it's an incorrect rule

Change-Id: I66e2d62f27678d3639086fbf4ac7aa4a8fae9af3
---
M manifests/role/deployment.pp
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Ryan Lane: Looks good to me, approved
  jenkins-bot: Verified; Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/37655
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I66e2d62f27678d3639086fbf4ac7aa4a8fae9af3
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ryan Lane 
Gerrit-Reviewer: Ryan Lane 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 42849) Rename extension to GettingStarted. Fixes for i1... - change (mediawiki...Onboarding[master])

2012-12-08 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged.

Change subject: (bug 42849) Rename extension to GettingStarted. Fixes for i18n 
* All messages and modules are now consistently prefixed * Remove obsolete 
aliases.
..


(bug 42849) Rename extension to GettingStarted. Fixes for i18n
* All messages and modules are now consistently prefixed
* Remove obsolete aliases.

* Lower-case started on special page
* Remove aliases
* Use prefix for everything except gettingstarted itself.  I can't because 
apparently it needs to match the class/special page name.

Change-Id: I07275a0bebc708dcb615bdbaac289660bcad8942
---
A GettingStarted.alias.php
A GettingStarted.i18n.php
A GettingStarted.php
D Onboarding.alias.php
D Onboarding.i18n.php
D Onboarding.php
M SpecialGettingStarted.php
R resources/ext.gettingstarted.css
8 files changed, 86 insertions(+), 85 deletions(-)

Approvals:
  Ori.livneh: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/37610
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I07275a0bebc708dcb615bdbaac289660bcad8942
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Onboarding
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen 
Gerrit-Reviewer: Mattflaschen 
Gerrit-Reviewer: Ori.livneh 
Gerrit-Reviewer: Spage 
Gerrit-Reviewer: Swalling 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Some cleanup of the property statistics code [DO NOT MERGE] - change (mediawiki...SemanticMediaWiki[master])

2012-12-08 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

Change subject: Some cleanup of the property statistics code [DO NOT MERGE]
..

Some cleanup of the property statistics code [DO NOT MERGE]

Not done yet

Change-Id: I2e509e08663186afe116ab5db4f110ace4295b4b
---
A includes/storage/PropertyStatisticsRebuilder.php
A includes/storage/PropertyStatisticsStore.php
A includes/storage/PropertyStatisticsTable.php
M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php
M includes/storage/SQLStore/SMW_SQLStore3_SpecialPageHandlers.php
M includes/storage/SQLStore/SMW_SQLStore3_Writers.php
M includes/storage/SQLStore/SMW_Sql3SmwIds.php
7 files changed, 512 insertions(+), 96 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki 
refs/changes/56/37656/1
--
To view, visit https://gerrit.wikimedia.org/r/37656
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e509e08663186afe116ab5db4f110ace4295b4b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Re-factor: add RemoteSchema class, require revision - change (mediawiki...EventLogging[master])

2012-12-08 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review.

Change subject: Re-factor: add RemoteSchema class, require revision
..

Re-factor: add RemoteSchema class, require revision

Requiring a revision ID dramatically simplfies the work done by this
extension, and it prompted me to do a pretty comprehensive refactor.

-- Remove SchemaModuleTest.php. I'll have to completely rewrite those
   tests. Saving that for another change.
-- Require revision ID for all schema modules.
-- Change modification time behavior accordingly (explained in
   comments).
-- Drop PageContentSave hook handler from JsonSchemaHooks (revisions are
   immutable and don't need to be updated.)
-- Parcel off schema fetching logic to RemoteSchema class.
-- Drop wfSchemaKey function (no longer needed).
-- Rename wfLogServerSideEvent to efLogServerSideEvent, following
   conventions on global funcs declared in extensions.
-- i18nize invalid JSON error message.

Change-Id: I081f98978ca85fefe85a5e746160895a8951c73f
---
M EventLogging.hooks.php
M EventLogging.i18n.php
M EventLogging.module.php
M EventLogging.php
A RemoteSchema.php
M content/JsonSchemaContent.php
M content/JsonSchemaHooks.php
D tests/SchemaModuleTest.php
8 files changed, 156 insertions(+), 328 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging 
refs/changes/57/37657/1
--
To view, visit https://gerrit.wikimedia.org/r/37657
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I081f98978ca85fefe85a5e746160895a8951c73f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Move insertUpdateRow call before return applyPatch to make i... - change (mediawiki/core[master])

2012-12-08 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: Move insertUpdateRow call before return applyPatch to make it 
reachable
..

Move insertUpdateRow call before return applyPatch to make it reachable

This might not be quite right... We might want to cache the result of apply 
patch, insert the row and then return the result...

Change-Id: Ie6a1bb16d2912ad43aa8fd45b2bf10a8bf8652ae
---
M includes/installer/DatabaseUpdater.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/58/37658/1
--
To view, visit https://gerrit.wikimedia.org/r/37658
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6a1bb16d2912ad43aa8fd45b2bf10a8bf8652ae
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Remove unreachable lines - change (mediawiki/core[master])

2012-12-08 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: Remove unreachable lines
..

Remove unreachable lines

Change-Id: Ie7ec14f4ce65bc87b0cd49ec9266c394770ee7c4
---
M tests/phpunit/includes/parser/PreprocessorTest.php
1 file changed, 1 insertion(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/59/37659/1
--
To view, visit https://gerrit.wikimedia.org/r/37659
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie7ec14f4ce65bc87b0cd49ec9266c394770ee7c4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Make doEmpty return bool in all cases - change (mediawiki/core[master])

2012-12-08 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: Make doEmpty return bool in all cases
..

Make doEmpty return bool in all cases

Change-Id: Ic42f426ef3d13bd0726955fe29b7e7c3d0cae152
---
M includes/job/JobQueueDB.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/60/37660/1
--
To view, visit https://gerrit.wikimedia.org/r/37660
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic42f426ef3d13bd0726955fe29b7e7c3d0cae152
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


  1   2   >