[MediaWiki-commits] [Gerrit] Allow limit on number of workers - change (mediawiki...cxserver)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Allow limit on number of workers
..


Allow limit on number of workers

If n is not specified, number of workers will be cpu core + 3 as
default. Else, workers = n.

Example: node Server.js -n 2

Change-Id: I6ef6ff1d6c9db24e69c8af37af2f2fd7e4c40783
---
M Server.js
M package.json
2 files changed, 27 insertions(+), 8 deletions(-)

Approvals:
  Santhosh: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Server.js b/Server.js
index 40a9cb5..3f40b82 100755
--- a/Server.js
+++ b/Server.js
@@ -8,15 +8,33 @@
 
 var cluster = require( 'cluster' ),
logger = require( __dirname + '/utils/Logger.js' ),
-   numCPUs, i;
+   i, opts, argv;
 
-if ( cluster.isMaster ) {
-   // Start a few more workers than there are cpus visible to the OS, so 
that we
-   // get some degree of parallelism even on single-core systems. A single
-   // long-running request would otherwise hold up all concurrent short 
requests.
-   numCPUs = require( 'os' ).cpus().length + 3;
+opts = require( 'yargs' )
+   .usage( 'Usage: $0 [-h] [-n[=val]]' )
+   .default( {
+   // Start a few more workers than there are cpus visible to the 
OS, so
+   // that we get some degree of parallelism even on single-core 
systems.
+   // A single long-running request would otherwise hold up all 
concurrent
+   // short requests.
+   n: require( 'os' ).cpus().length + 3,
+   h: false
+   } )
+   .alias( 'n', 'num-workers' )
+   .describe( 'n', 'Number of workers' )
+   .alias( 'h', 'help' )
+   .describe( 'h', 'Show help' );
+argv = opts.argv;
+
+if ( argv.h ) {
+   opts.showHelp();
+   process.exit( 0 );
+}
+
+if ( cluster.isMaster && argv.n > 0 ) {
// Fork workers.
-   for ( i = 0; i < numCPUs; i++ ) {
+   logger.info( 'initializing %s workers', argv.n );
+   for ( i = 0; i < argv.n; i++ ) {
cluster.fork();
}
 
diff --git a/package.json b/package.json
index a385fca..2016f6a 100644
--- a/package.json
+++ b/package.json
@@ -21,7 +21,8 @@
"request": "*",
"sax": "0.6.0",
"winston": "*",
-   "html-entities": "1.0.10"
+   "html-entities": "1.0.10",
+   "yargs": "~1.3.1"
},
"devDependencies": {
"assert": "1.1.1",

-- 
To view, visit https://gerrit.wikimedia.org/r/193052
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6ef6ff1d6c9db24e69c8af37af2f2fd7e4c40783
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/services/cxserver
Gerrit-Branch: master
Gerrit-Owner: KartikMistry 
Gerrit-Reviewer: Jsahleen 
Gerrit-Reviewer: Santhosh 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] tools: Monitor toollabs home page - change (operations/puppet)

[Yuvipanda (Code Review)]

Yuvipanda has submitted this change and it was merged.

Change subject: tools: Monitor toollabs home page
..


tools: Monitor toollabs home page

Bug: T90847
Change-Id: I35e58709f2f7a9381898ee8034480f387d448264
---
M manifests/role/labsshinken.pp
A modules/toollabs/files/shinken.cfg
A modules/toollabs/manifests/monitoring.pp
3 files changed, 23 insertions(+), 0 deletions(-)

Approvals:
  Yuvipanda: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/manifests/role/labsshinken.pp b/manifests/role/labsshinken.pp
index 3e240e2..e7f5267 100644
--- a/manifests/role/labsshinken.pp
+++ b/manifests/role/labsshinken.pp
@@ -26,4 +26,5 @@
 }
 
 include beta::monitoring::shinken
+include toollabs::monitoring
 }
diff --git a/modules/toollabs/files/shinken.cfg 
b/modules/toollabs/files/shinken.cfg
new file mode 100644
index 000..6941512
--- /dev/null
+++ b/modules/toollabs/files/shinken.cfg
@@ -0,0 +1,14 @@
+define host{
+host_name   toollabs
+alias   ToolLabs
+address tools.wmflabs.org
+contact_groups  tools
+use generic-host
+}
+
+define service {
+service_description ToolLabs Home Page
+host_name   toollabs
+check_command   
check_http_url_at_address_for_string!tools.wmflabs.org!/!Magnus
+use generic-service
+}
diff --git a/modules/toollabs/manifests/monitoring.pp 
b/modules/toollabs/manifests/monitoring.pp
new file mode 100644
index 000..52fb35d
--- /dev/null
+++ b/modules/toollabs/manifests/monitoring.pp
@@ -0,0 +1,8 @@
+# == Class: toollabs::monitoring
+#
+# Sets up shinken alerts for toollabs
+class toollabs::monitoring {
+shinken::config { 'toollabs':
+source => 'puppet:///modules/toollabs/shinken.cfg',
+}
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/193061
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I35e58709f2f7a9381898ee8034480f387d448264
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Yuvipanda 
Gerrit-Reviewer: Yuvipanda 
Gerrit-Reviewer: coren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] tools: Monitor toollabs home page - change (operations/puppet)

[Yuvipanda (Code Review)]

Yuvipanda has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193061

Change subject: tools: Monitor toollabs home page
..

tools: Monitor toollabs home page

Bug: T90847
Change-Id: I35e58709f2f7a9381898ee8034480f387d448264
---
M manifests/role/labsshinken.pp
A modules/toollabs/files/shinken.cfg
A modules/toollabs/manifests/monitoring.pp
3 files changed, 23 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/61/193061/1

diff --git a/manifests/role/labsshinken.pp b/manifests/role/labsshinken.pp
index 3e240e2..e7f5267 100644
--- a/manifests/role/labsshinken.pp
+++ b/manifests/role/labsshinken.pp
@@ -26,4 +26,5 @@
 }
 
 include beta::monitoring::shinken
+include toollabs::monitoring
 }
diff --git a/modules/toollabs/files/shinken.cfg 
b/modules/toollabs/files/shinken.cfg
new file mode 100644
index 000..6941512
--- /dev/null
+++ b/modules/toollabs/files/shinken.cfg
@@ -0,0 +1,14 @@
+define host{
+host_name   toollabs
+alias   ToolLabs
+address tools.wmflabs.org
+contact_groups  tools
+use generic-host
+}
+
+define service {
+service_description ToolLabs Home Page
+host_name   toollabs
+check_command   
check_http_url_at_address_for_string!tools.wmflabs.org!/!Magnus
+use generic-service
+}
diff --git a/modules/toollabs/manifests/monitoring.pp 
b/modules/toollabs/manifests/monitoring.pp
new file mode 100644
index 000..52fb35d
--- /dev/null
+++ b/modules/toollabs/manifests/monitoring.pp
@@ -0,0 +1,8 @@
+# == Class: toollabs::monitoring
+#
+# Sets up shinken alerts for toollabs
+class toollabs::monitoring {
+shinken::config { 'toollabs':
+source => 'puppet:///modules/toollabs/shinken.cfg',
+}
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/193061
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I35e58709f2f7a9381898ee8034480f387d448264
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Yuvipanda 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Tools: Fix syntax error in bigbrother - change (operations/puppet)

[Yuvipanda (Code Review)]

Yuvipanda has submitted this change and it was merged.

Change subject: Tools: Fix syntax error in bigbrother
..


Tools: Fix syntax error in bigbrother

This follows up change Id57caa80e552f4ae3471337cf1e0223cb0a6aca5.

Change-Id: I8bc67a50d6947c93ceeb36255a701bf23dbda9e2
---
M modules/toollabs/files/bigbrother
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Yuvipanda: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/toollabs/files/bigbrother 
b/modules/toollabs/files/bigbrother
index fe505fe..fe42316 100755
--- a/modules/toollabs/files/bigbrother
+++ b/modules/toollabs/files/bigbrother
@@ -86,7 +86,7 @@
 }
 $expect = "$name-$1";
 $start = "/usr/bin/webservice -$name start";
-} elseif(m/^webservice2(:?\s+-([a-z]+))?$/) {
+} elsif(m/^webservice2(:?\s+-([a-z]+))?$/) {
 my $name = $2 // "lighttpd";
 unless($username =~ m/^tools\.(.*)$/) {
 ulog $username, 'error', "$rcfile:$line: unable to figure 
out webgrid name! (not possible)";

-- 
To view, visit https://gerrit.wikimedia.org/r/193056
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8bc67a50d6947c93ceeb36255a701bf23dbda9e2
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Tim Landscheidt 
Gerrit-Reviewer: Yuvipanda 
Gerrit-Reviewer: coren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Tools: Restart bigbrother when source changes - change (operations/puppet)

[Yuvipanda (Code Review)]

Yuvipanda has submitted this change and it was merged.

Change subject: Tools: Restart bigbrother when source changes
..


Tools: Restart bigbrother when source changes

Change-Id: I3eac8c671248953861d825ac805ac34f09134129
---
M modules/toollabs/manifests/submit.pp
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Yuvipanda: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/toollabs/manifests/submit.pp 
b/modules/toollabs/manifests/submit.pp
index c48c882..c9bb9c6 100644
--- a/modules/toollabs/manifests/submit.pp
+++ b/modules/toollabs/manifests/submit.pp
@@ -61,8 +61,8 @@
 }
 
 service { 'bigbrother':
-ensure  => running,
-require => File['/usr/local/sbin/bigbrother', 
'/etc/init/bigbrother.conf'],
+ensure=> running,
+subscribe => File['/usr/local/sbin/bigbrother', 
'/etc/init/bigbrother.conf'],
 }
 
 file { '/usr/local/bin/webservice2':

-- 
To view, visit https://gerrit.wikimedia.org/r/193055
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3eac8c671248953861d825ac805ac34f09134129
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Tim Landscheidt 
Gerrit-Reviewer: Yuvipanda 
Gerrit-Reviewer: coren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Made MessageGroupStatesUpdaterJob jobs be de-duplicated - change (mediawiki...Translate)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Made MessageGroupStatesUpdaterJob jobs be de-duplicated
..


Made MessageGroupStatesUpdaterJob jobs be de-duplicated

Bug: T53410
Change-Id: Ibf8f8d1413b30328bbd6300cee58f311e294888f
---
M utils/MessageGroupStatesUpdaterJob.php
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Nikerabbit: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/utils/MessageGroupStatesUpdaterJob.php 
b/utils/MessageGroupStatesUpdaterJob.php
index 18b3434..78b4496 100644
--- a/utils/MessageGroupStatesUpdaterJob.php
+++ b/utils/MessageGroupStatesUpdaterJob.php
@@ -14,6 +14,10 @@
  * @ingroup JobQueue
  */
 class MessageGroupStatesUpdaterJob extends Job {
+   public function __construct( $title, $params = array() ) {
+   parent::__construct( __CLASS__, $title, $params );
+   $this->removeDuplicates = true;
+   }
 
/**
 * Hook: TranslateEventTranslationEdit
@@ -34,10 +38,6 @@
$job = new self( $title );
 
return $job;
-   }
-
-   public function __construct( $title, $params = array(), $id = 0 ) {
-   parent::__construct( __CLASS__, $title, $params, $id );
}
 
public function run() {

-- 
To view, visit https://gerrit.wikimedia.org/r/192963
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf8f8d1413b30328bbd6300cee58f311e294888f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Next step on the road to understanding JVM GC dynamics - change (operations...cassandra)

[GWicke (Code Review)]

GWicke has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193060

Change subject: Next step on the road to understanding JVM GC dynamics
..

Next step on the road to understanding JVM GC dynamics

The changes in https://gerrit.wikimedia.org/r/#/c/192760/ turned out to be
less helpful than hoped. The new cassandra heap dashboard at
http://grafana.wikimedia.org/#/dashboard/db/cassandra-heap actually provides
evidence that the new settings causeda slightly more, and not less, time to be
spent in GC. This is true for both CMS and ParNew.

The initial trigger for this change was warnings like these in the logs:

GCInspector.java:142 - ConcurrentMarkSweep GC in 7993ms.
  CMS Old Gen: 3312323744 -> 1640237320;
  CMS Perm Gen: 32140352 -> 32137768;
  Code Cache: 14301120 -> 14369664;
  Par Eden Space: 9454776 -> 115950544;
  Par Survivor Space: 79890744 -> 56639504

Reinforced by some notwork disconnects I had observed earlier I took this to
mean that this had actually been a long stop-the-world collection. It looks
like these CMS collections are mostly incremental and concurrent though, with
execution only stopped for a very small fraction of those 8 seconds. The
typical GC behavior to shoot for in the JVM seems to be purely
CMSInitiatingOccupancyFraction-driven, with a collection magnitude of ideally
> 50% old space size. The original settings of 75% are actually pretty close
to this while keeping some headroom to avoid CMS failure or OOM.

This patch changes the settings back to a moderate mainstream setting, very
close to the defaults:

- 70% CMSInitiatingOccupancyFraction (default 75): Provides slightly more
  headroom against CMS failures on high memory pressure.
- MaxTenuringThreshold=5 (default 1): Reduces the pressure on the old space
  without increasing the time spent in ParNew unduly.

Change-Id: I8db561810290ad18dab9549ce2aec92b39b1c1de
---
M templates/cassandra-env.sh.erb
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet/cassandra 
refs/changes/60/193060/1

diff --git a/templates/cassandra-env.sh.erb b/templates/cassandra-env.sh.erb
index 5a778b8..6ca09b6 100644
--- a/templates/cassandra-env.sh.erb
+++ b/templates/cassandra-env.sh.erb
@@ -218,8 +218,8 @@
 JVM_OPTS="$JVM_OPTS -XX:+UseConcMarkSweepGC"
 JVM_OPTS="$JVM_OPTS -XX:+CMSParallelRemarkEnabled"
 JVM_OPTS="$JVM_OPTS -XX:SurvivorRatio=8"
-JVM_OPTS="$JVM_OPTS -XX:MaxTenuringThreshold=10"
-JVM_OPTS="$JVM_OPTS -XX:CMSInitiatingOccupancyFraction=45"
+JVM_OPTS="$JVM_OPTS -XX:MaxTenuringThreshold=5"
+JVM_OPTS="$JVM_OPTS -XX:CMSInitiatingOccupancyFraction=70"
 JVM_OPTS="$JVM_OPTS -XX:+UseCMSInitiatingOccupancyOnly"
 JVM_OPTS="$JVM_OPTS -XX:+UseTLAB"
 JVM_OPTS="$JVM_OPTS -XX:CompileCommandFile=$CASSANDRA_CONF/hotspot_compiler"

-- 
To view, visit https://gerrit.wikimedia.org/r/193060
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8db561810290ad18dab9549ce2aec92b39b1c1de
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet/cassandra
Gerrit-Branch: master
Gerrit-Owner: GWicke 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Hygiene: Follow coding conventions - change (mediawiki...MobileFrontend)

[Florianschmidtwelzow (Code Review)]

Florianschmidtwelzow has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193059

Change subject: Hygiene: Follow coding conventions
..

Hygiene: Follow coding conventions

Follow up on Ie8b823be8c316bf07cb19b29cb3e9b2be2407367

Change-Id: I9e819ebb8cd97a65aa9ce18608b425977f04fe96
---
M includes/specials/SpecialMobileOptions.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/59/193059/1

diff --git a/includes/specials/SpecialMobileOptions.php 
b/includes/specials/SpecialMobileOptions.php
index 454ed22..d060aa1 100644
--- a/includes/specials/SpecialMobileOptions.php
+++ b/includes/specials/SpecialMobileOptions.php
@@ -136,7 +136,7 @@
}
}
 
-   $templateParser = new TemplateParser( __DIR__ 
.'/../../templates/specials' );
+   $templateParser = new TemplateParser( __DIR__ . 
'/../../templates/specials' );
// @codingStandardsIgnoreStart Long line
foreach( $options as $key => $data ) {
if ( isset( $data['type'] ) && $data['type'] === 
'hidden' ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/193059
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e819ebb8cd97a65aa9ce18608b425977f04fe96
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Special:OAuthManageMyGrants: don't escape button labels twice - change (mediawiki...OAuth)

[Ricordisamoa (Code Review)]

Ricordisamoa has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193058

Change subject: Special:OAuthManageMyGrants: don't escape button labels twice
..

Special:OAuthManageMyGrants: don't escape button labels twice

'mwoauthmanagemygrants-renounce' and 'mwoauthmanagemygrants-update'
were being ->escaped() before being passed to HTMLForm->addButton(),
causing them to contain HTML entities sometimes.

Call stack:
HTMLForm->show()
-> HTMLForm->displayForm()
--> HTMLForm->getHTML()
---> HTMLForm->getButtons()
> Html::element()
-> Html::rawElement()
--> Html::openElement()
---> Html::expandAttributes()
The latter escapes attribute values.

Change-Id: Iae4397e5aad1e12677417ae66dbf4bacc80599ad
---
M frontend/specialpages/SpecialMWOAuthManageMyGrants.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OAuth 
refs/changes/58/193058/1

diff --git a/frontend/specialpages/SpecialMWOAuthManageMyGrants.php 
b/frontend/specialpages/SpecialMWOAuthManageMyGrants.php
index 49690f4..b4a44fd 100644
--- a/frontend/specialpages/SpecialMWOAuthManageMyGrants.php
+++ b/frontend/specialpages/SpecialMWOAuthManageMyGrants.php
@@ -219,13 +219,13 @@
$form->suppressDefaultSubmit();
if ( $type === 'revoke' ) {
$form->addButton( 'renounce',
-   $this->msg( 'mwoauthmanagemygrants-renounce' 
)->escaped(),
+   $this->msg( 'mwoauthmanagemygrants-renounce' 
)->text(),
null,
array( 'class' => 'mw-ui-button 
mw-ui-destructive' )
);
} else {
$form->addButton( 'update',
-   $this->msg( 'mwoauthmanagemygrants-update' 
)->escaped(),
+   $this->msg( 'mwoauthmanagemygrants-update' 
)->text(),
null,
array( 'class' => 'mw-ui-button mw-ui-primary' )
);

-- 
To view, visit https://gerrit.wikimedia.org/r/193058
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae4397e5aad1e12677417ae66dbf4bacc80599ad
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OAuth
Gerrit-Branch: master
Gerrit-Owner: Ricordisamoa 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Mark checkboxes checked - change (mediawiki...MobileFrontend)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Mark checkboxes checked
..


Mark checkboxes checked

Follow up on Ie8b823be8c316bf07cb19b29cb3e9b2be2407367

Change-Id: Id3b8b0ccc6bb851cd9b3d7bc93f9437b1c9bef84
---
M templates/specials/checkbox.mustache
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Florianschmidtwelzow: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/templates/specials/checkbox.mustache 
b/templates/specials/checkbox.mustache
index 3595493..4de95b9 100644
--- a/templates/specials/checkbox.mustache
+++ b/templates/specials/checkbox.mustache
@@ -1,6 +1,6 @@
 

-   
+   

{{label}}


-- 
To view, visit https://gerrit.wikimedia.org/r/193022
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id3b8b0ccc6bb851cd9b3d7bc93f9437b1c9bef84
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov 
Gerrit-Reviewer: Bmansurov 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Regularly run mediawiki-vendor-composer-security, add to tes... - change (integration/config)

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193057

Change subject: Regularly run mediawiki-vendor-composer-security, add to 
test/gate pipelines
..

Regularly run mediawiki-vendor-composer-security, add to test/gate pipelines

Change-Id: I7f34697085e0e2092f28945a65c434f338f727ae
---
M jjb/job-templates.yaml
M jjb/mediawiki-misc.yaml
M zuul/layout.yaml
3 files changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/57/193057/1

diff --git a/jjb/job-templates.yaml b/jjb/job-templates.yaml
index 2459922..3c8ba19 100644
--- a/jjb/job-templates.yaml
+++ b/jjb/job-templates.yaml
@@ -93,7 +93,11 @@
  - shell: |
  curl -i -H "Accept: text/plain" 
https://security.sensiolabs.org/check_lock -F lock=@composer.lock -o 
sensiolabs.check
  cat sensiolabs.check && grep -F "X-Alerts: 0" sensiolabs.check
-
+publishers:
+ - email:
+recipients: '{notify}'
+triggers:
+- timed: "H 20 * * *"
 
 - job-template:
 name: '{name}-puppetlint-lenient'
diff --git a/jjb/mediawiki-misc.yaml b/jjb/mediawiki-misc.yaml
index 865350f..f9c5e9f 100644
--- a/jjb/mediawiki-misc.yaml
+++ b/jjb/mediawiki-misc.yaml
@@ -83,3 +83,4 @@
 name: 'mediawiki-vendor'
 jobs:
  - '{name}-composer-security'
+notify: cste...@wikimedia.org
diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 5ba4671..c7ba001 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -1991,6 +1991,7 @@
   - mediawiki-phpunit-zend
   - mediawiki-extensions-hhvm
   - mediawiki-extensions-zend
+  - mediawiki-vendor-composer-security
 gate-and-submit:
   - mediawiki-phpunit-hhvm
   - mediawiki-phpunit-zend
@@ -1998,7 +1999,6 @@
   - mediawiki-extensions-zend
   - mediawiki-core-qunit
   - php-composer-validate
-experimental:
   - mediawiki-vendor-composer-security
 
   - name: analytics/asana-stats

-- 
To view, visit https://gerrit.wikimedia.org/r/193057
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f34697085e0e2092f28945a65c434f338f727ae
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Tools: Fix syntax error in bigbrother - change (operations/puppet)

[Tim Landscheidt (Code Review)]

Tim Landscheidt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193056

Change subject: Tools: Fix syntax error in bigbrother
..

Tools: Fix syntax error in bigbrother

This follows up change Id57caa80e552f4ae3471337cf1e0223cb0a6aca5.

Change-Id: I8bc67a50d6947c93ceeb36255a701bf23dbda9e2
---
M modules/toollabs/files/bigbrother
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/56/193056/1

diff --git a/modules/toollabs/files/bigbrother 
b/modules/toollabs/files/bigbrother
index fe505fe..fe42316 100755
--- a/modules/toollabs/files/bigbrother
+++ b/modules/toollabs/files/bigbrother
@@ -86,7 +86,7 @@
 }
 $expect = "$name-$1";
 $start = "/usr/bin/webservice -$name start";
-} elseif(m/^webservice2(:?\s+-([a-z]+))?$/) {
+} elsif(m/^webservice2(:?\s+-([a-z]+))?$/) {
 my $name = $2 // "lighttpd";
 unless($username =~ m/^tools\.(.*)$/) {
 ulog $username, 'error', "$rcfile:$line: unable to figure 
out webgrid name! (not possible)";

-- 
To view, visit https://gerrit.wikimedia.org/r/193056
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8bc67a50d6947c93ceeb36255a701bf23dbda9e2
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Tim Landscheidt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Tools: Restart bigbrother when source changes - change (operations/puppet)

[Tim Landscheidt (Code Review)]

Tim Landscheidt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193055

Change subject: Tools: Restart bigbrother when source changes
..

Tools: Restart bigbrother when source changes

Change-Id: I3eac8c671248953861d825ac805ac34f09134129
---
M modules/toollabs/manifests/submit.pp
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/55/193055/1

diff --git a/modules/toollabs/manifests/submit.pp 
b/modules/toollabs/manifests/submit.pp
index c48c882..c9bb9c6 100644
--- a/modules/toollabs/manifests/submit.pp
+++ b/modules/toollabs/manifests/submit.pp
@@ -61,8 +61,8 @@
 }
 
 service { 'bigbrother':
-ensure  => running,
-require => File['/usr/local/sbin/bigbrother', 
'/etc/init/bigbrother.conf'],
+ensure=> running,
+subscribe => File['/usr/local/sbin/bigbrother', 
'/etc/init/bigbrother.conf'],
 }
 
 file { '/usr/local/bin/webservice2':

-- 
To view, visit https://gerrit.wikimedia.org/r/193055
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3eac8c671248953861d825ac805ac34f09134129
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Tim Landscheidt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] UserMerge: duplicate array keys in makeList. - change (mediawiki...UserMerge)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: UserMerge: duplicate array keys in makeList.
..


UserMerge: duplicate array keys in makeList.

Bug: T68463
Change-Id: I50dce645cb6d7fe801c0b2eac65dc6f90b049576
---
M MergeUser.php
1 file changed, 4 insertions(+), 7 deletions(-)

Approvals:
  Umherirrender: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/MergeUser.php b/MergeUser.php
index dc8b879..4a6141a 100644
--- a/MergeUser.php
+++ b/MergeUser.php
@@ -350,16 +350,13 @@
 
# select all user pages and sub-pages
$dbr = wfGetDB( DB_SLAVE );
-   $pages = $dbr->select( 'page',
+   $pages = $dbr->select(
+   'page',
array( 'page_namespace', 'page_title' ),
array(
'page_namespace' => array( NS_USER, 
NS_USER_TALK ),
-   $dbr->makeList( array(
-   'page_title' => 
$dbr->buildLike( $oldusername->getDBkey() . '/', $dbr->anyString() ),
-   'page_title' => 
$oldusername->getDBkey()
-   ),
-   LIST_OR
-   )
+   'page_title' . $dbr->buildLike( 
$oldusername->getDBkey() . '/', $dbr->anyString() )
+   . ' OR page_title = ' . 
$dbr->addQuotes( $oldusername->getDBkey() ),
)
);
 

-- 
To view, visit https://gerrit.wikimedia.org/r/190724
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I50dce645cb6d7fe801c0b2eac65dc6f90b049576
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/UserMerge
Gerrit-Branch: master
Gerrit-Owner: AYUSH GARG 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Tpt 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Generate handlebars Makefile programatically - change (mediawiki...Flow)

[EBernhardson (Code Review)]

EBernhardson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193053

Change subject: Generate handlebars Makefile programatically
..

Generate handlebars Makefile programatically

This extends LightnCandy for its own purposes to extract
the list of partials used from the compilation context.

To facilitate not including all the partials within the
generated Makefile a new convention was created.  All
partial templates must have:

{{! partial~}}

as their first line.  This is a handlebars comment and
has no effect on the output of the template.

Change-Id: Ib919b0b53e5f610663c3a13d08a88b74679f9053
---
M handlebars/Makefile
M handlebars/compiled/flow_block_topic.handlebars.php
M handlebars/compiled/flow_block_topic_moderate_post.handlebars.php
M handlebars/compiled/flow_block_topic_moderate_topic.handlebars.php
M handlebars/compiled/flow_block_topiclist.handlebars.php
M handlebars/compiled/flow_block_topiclist_newtopic.handlebars.php
M handlebars/compiled/flow_post.handlebars.php
M handlebars/flow_anon_warning.handlebars
M handlebars/flow_board_navigation.handlebars
M handlebars/flow_board_toc_loop.handlebars
M handlebars/flow_edit_post.handlebars
M handlebars/flow_edit_post_ajax.handlebars
M handlebars/flow_edit_topic_title.handlebars
M handlebars/flow_errors.handlebars
M handlebars/flow_header_detail.handlebars
M handlebars/flow_load_more.handlebars
M handlebars/flow_moderate_post.handlebars
M handlebars/flow_moderate_post_confirmation.handlebars
M handlebars/flow_moderate_topic.handlebars
M handlebars/flow_moderate_topic_confirmation.handlebars
M handlebars/flow_moderation_actions_list.handlebars
M handlebars/flow_newtopic_form.handlebars
M handlebars/flow_post_actions.handlebars
M handlebars/flow_post_author.handlebars
M handlebars/flow_post_inner.handlebars
M handlebars/flow_post_meta_actions.handlebars
M handlebars/flow_post_moderation_state.handlebars
M handlebars/flow_post_replies.handlebars
M handlebars/flow_preview.handlebars
M handlebars/flow_preview_warning.handlebars
M handlebars/flow_reply_form.handlebars
M handlebars/flow_subscribed.handlebars
M handlebars/flow_tooltip_subscribed.handlebars
M handlebars/flow_topic.handlebars
M handlebars/flow_topic_moderation_flag.handlebars
M handlebars/flow_topic_titlebar.handlebars
M handlebars/flow_topic_titlebar_content.handlebars
M handlebars/flow_topic_titlebar_lock.handlebars
M handlebars/flow_topic_titlebar_summary.handlebars
M handlebars/flow_topic_titlebar_watch.handlebars
M handlebars/flow_topiclist_loop.handlebars
M handlebars/form_element.handlebars
A handlebars/makefile_template.handlebars
A scripts/gen-handlebars-makefile.php
44 files changed, 301 insertions(+), 140 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/53/193053/1

diff --git a/handlebars/Makefile b/handlebars/Makefile
index 5536e92..dd2478e 100644
--- a/handlebars/Makefile
+++ b/handlebars/Makefile
@@ -1,89 +1,178 @@
 #
-# @todo it should be possible to run the templates through lightncandy and 
auto-generate
-# this Makefile with the metadata it calculates.
+# This Makefile is autogenerated by running the following
+# from the root of the Flow repository:
+#
+# php scripts/gen-handlebars-makefile.php > handlebars/Makefile
 #
 
 PHP=`command -v php5 || command -v php`
 COMPILE=@${PHP} ../maintenance/compileLightncandy.php
 
-POST_SUBTEMPLATES=flow_post.handlebars \
-   flow_post_inner.handlebars \
-   flow_edit_post.handlebars \
-   flow_post_actions.handlebars \
-   flow_post_author.handlebars \
-   flow_post_meta_actions.handlebars \
-   flow_post_replies.handlebars \
-   flow_reply_form.handlebars \
-   flow_moderation_actions_list.handlebars \
-   flow_post_moderation_state.handlebars
-
-TOPIC_SUBTEMPLATES=flow_topic.handlebars \
-   flow_topic_titlebar.handlebars \
-   flow_topic_titlebar_content.handlebars \
-   flow_topic_moderation_flag.handlebars \
-   flow_topic_titlebar_lock.handlebars \
-   flow_topic_titlebar_summary.handlebars \
-   flow_topic_titlebar_watch.handlebars \
-   flow_reply_form.handlebars \
-   flow_topiclist_loop.handlebars \
-   flow_load_more.handlebars \
-   flow_errors.handlebars \
-   flow_form_buttons.handlebars \
-   flow_moderation_actions_list.handlebars \
-   flow_post_moderation_state.handlebars
-
-all: compiled/flow_block_loop.handlebars.php \
+all:  \
+   compiled/flow_block_board-history.handlebars.php \
compiled/flow_block_header.handlebars.php \
+   compiled/flow_block_header_diff_view.handlebars.php \
compiled/flow_block_header_edit.handlebars.php \
compiled/fl

[MediaWiki-commits] [Gerrit] Split flow_block_topic_history template into two - change (mediawiki...Flow)

[EBernhardson (Code Review)]

EBernhardson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193054

Change subject: Split flow_block_topic_history template into two
..

Split flow_block_topic_history template into two

Change-Id: Idda66491c065bdd85457cbe77c5652f47f390843
---
M handlebars/Makefile
M handlebars/flow_block_topic_history.handlebars
A handlebars/flow_topic_history_line.handlebars
3 files changed, 65 insertions(+), 64 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/54/193054/1

diff --git a/handlebars/Makefile b/handlebars/Makefile
index dd2478e..55ded6f 100644
--- a/handlebars/Makefile
+++ b/handlebars/Makefile
@@ -92,7 +92,8 @@
$(COMPILE) flow_block_topic_edit_title
 
 compiled/flow_block_topic_history.handlebars.php: \
-   flow_block_topic_history.handlebars
+   flow_block_topic_history.handlebars \
+   flow_topic_history_line.handlebars
$(COMPILE) flow_block_topic_history
 
 compiled/flow_block_topic_lock.handlebars.php: \
diff --git a/handlebars/flow_block_topic_history.handlebars 
b/handlebars/flow_block_topic_history.handlebars
index 17afb79..0528ab9 100644
--- a/handlebars/flow_block_topic_history.handlebars
+++ b/handlebars/flow_block_topic_history.handlebars
@@ -4,69 +4,7 @@
 

{{#each revisions}}
-   
-   
-   (
-   {{~noop~}}
-   
-   {{~#if links.diff-cur~}}
-   
-   
{{~links.diff-cur.title~}}
-   
-   {{~else~}}
-   {{~l10n "cur"~}}
-   {{/if}}
-   
-   
-   {{#if links.diff-prev}}
-   
-   
{{~links.diff-prev.title~}}
-   
-   {{~else~}}
-   {{~l10n 
"last"~}}
-   {{~/if~}}
-   
-   {{~#if links.topic}}
-   
-   
{{~links.topic.title~}}
-   
-   {{~/if~}}
-   )
-   
-
-   {{historyTimestamp this}}
-
-   . .
-   {{historyDescription this}}
-
-   {{#if size}}
-   . .
-   {{showCharacterDifference 
size.old size.new}}
-   {{/if}}
-
-   
-   {{#if actions.hide}}
-   (
-   {{~l10n 
"flow-post-action-hide-post"~}}
-   )
-   {{/if}}
-   {{#if actions.unhide}}
-   (
-   {{~l10n 
"flow-post-action-restore-post"~}}
-   )
-   {{/if}}
-   
-   
+   {{> flow_topic_history_line}}
{{/each}}

 
diff --git a/handlebars/flow_topic_history_line.handlebars 
b/handlebars/flow_topic_history_line.handlebars
new file mode 100644
index 000..8d123ec
--- /dev/null
+++ b/handlebars/flow_topic_history_line.handlebars
@@ -0,0 +1,62 @@
+{{! partial}}
+
+   (
+   {{~noop~}}
+   
+   {{~#if links.diff-cur~}}
+  

[MediaWiki-commits] [Gerrit] Allow limit on number of workers - change (mediawiki...cxserver)

[KartikMistry (Code Review)]

KartikMistry has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193052

Change subject: Allow limit on number of workers
..

Allow limit on number of workers

If n is not specified, number of workers will be cpu core + 3 as
default. Else, workers = n.

Code from Parsoid :)

Change-Id: I6ef6ff1d6c9db24e69c8af37af2f2fd7e4c40783
---
M Server.js
M package.json
2 files changed, 21 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/cxserver 
refs/changes/52/193052/1

diff --git a/Server.js b/Server.js
index 40a9cb5..76c5fd3 100755
--- a/Server.js
+++ b/Server.js
@@ -8,15 +8,27 @@
 
 var cluster = require( 'cluster' ),
logger = require( __dirname + '/utils/Logger.js' ),
-   numCPUs, i;
+   i;
 
-if ( cluster.isMaster ) {
-   // Start a few more workers than there are cpus visible to the OS, so 
that we
-   // get some degree of parallelism even on single-core systems. A single
-   // long-running request would otherwise hold up all concurrent short 
requests.
-   numCPUs = require( 'os' ).cpus().length + 3;
+// arguments
+var opts = require( 'yargs' )
+   .usage( 'Usage: $0 [--param[=val]]' )
+   .default({
+   // Start a few more workers than there are cpus visible to the 
OS, so
+   // that we get some degree of parallelism even on single-core 
systems.
+   // A single long-running request would otherwise hold up all 
concurrent
+   // short requests.
+   n: require( 'os' ).cpus().length + 3,
+   h: false
+   })
+   .alias( 'n', 'num-workers' );
+
+var argv = opts.argv;
+
+if ( cluster.isMaster  && argv.n > 0 ) {
// Fork workers.
-   for ( i = 0; i < numCPUs; i++ ) {
+   logger.info( 'initializing %s workers', argv.n );
+   for ( i = 0; i < argv.n; i++ ) {
cluster.fork();
}
 
diff --git a/package.json b/package.json
index a385fca..2016f6a 100644
--- a/package.json
+++ b/package.json
@@ -21,7 +21,8 @@
"request": "*",
"sax": "0.6.0",
"winston": "*",
-   "html-entities": "1.0.10"
+   "html-entities": "1.0.10",
+   "yargs": "~1.3.1"
},
"devDependencies": {
"assert": "1.1.1",

-- 
To view, visit https://gerrit.wikimedia.org/r/193052
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ef6ff1d6c9db24e69c8af37af2f2fd7e4c40783
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/cxserver
Gerrit-Branch: master
Gerrit-Owner: KartikMistry 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] jenkins job validation, do not submit - change (mediawiki...Buggy)

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193051

Change subject: jenkins job validation, do not submit
..

jenkins job validation, do not submit

Change-Id: I2b6d2581cc26d27e515ec71ec5ee0fb6150ec926
---
A test.php
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Buggy 
refs/changes/51/193051/1

diff --git a/test.php b/test.php
new file mode 100644
index 000..71625a4
--- /dev/null
+++ b/test.php
@@ -0,0 +1,2 @@
+https://gerrit.wikimedia.org/r/193051
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b6d2581cc26d27e515ec71ec5ee0fb6150ec926
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Buggy
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add Buggy to CI config - change (integration/config)

[Legoktm (Code Review)]

Legoktm has submitted this change and it was merged.

Change subject: Add Buggy to CI config
..


Add Buggy to CI config

This extension is intended to generate JS errors, so there should
be no JS validation whatsoever, just linting the PHP setup file
and merging on +2.

Change-Id: I28e59bf6e5905307b088cc6bb562682dda6244c5
---
M jjb/mediawiki-extensions.yaml
M zuul/layout.yaml
2 files changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Verified; Looks good to me, approved



diff --git a/jjb/mediawiki-extensions.yaml b/jjb/mediawiki-extensions.yaml
index 0f02b11..793b24b 100644
--- a/jjb/mediawiki-extensions.yaml
+++ b/jjb/mediawiki-extensions.yaml
@@ -442,6 +442,7 @@
  - BounceHandler
  - BreadCrumbs
  - BreadCrumbs2
+ - Buggy
  - Calendar
  - Campaigns
  - Capiunto:
diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 1f22833..5ba4671 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -514,6 +514,8 @@
 voting: false
   - name: mwext-ArticleFeedbackv5-jslint # bug 61588
 voting: false
+  - name: mwext-Buggy-jslint # contains intentionally invalid scripts
+voting: false
   - name: mwext-CheckUser-jslint # bug 61589
 voting: false
   - name: mwext-ClickTracking-jslint # bug 61591
@@ -2893,6 +2895,10 @@
 template:
   - name: extension-unittests
 
+  - name: mediawiki/extensions/Buggy
+template:
+  - name: extension-unittests
+
   - name: mediawiki/extensions/Calendar
 template:
   - name: extension-unittests

-- 
To view, visit https://gerrit.wikimedia.org/r/192699
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I28e59bf6e5905307b088cc6bb562682dda6244c5
Gerrit-PatchSet: 4
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Update bd808/monolog-udp2log-handler to v1.0.1 - change (wikimedia/iegreview)

[BryanDavis (Code Review)]

BryanDavis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193050

Change subject: Update bd808/monolog-udp2log-handler to v1.0.1
..

Update bd808/monolog-udp2log-handler to v1.0.1

* Update bd808/monolog-udp2log-handler to v1.0.1
* Fix preferred-install config setting
* Add config settings to optimize autoloader

Change-Id: I574e11728a83de67f3c7b67bc06842079d8f303a
---
M composer.json
M composer.lock
M vendor/autoload.php
D vendor/bd808/monolog-udp2log-handler/.gitignore
D vendor/bd808/monolog-udp2log-handler/.travis.yml
D vendor/bd808/monolog-udp2log-handler/phpunit.xml.dist
M vendor/bd808/monolog-udp2log-handler/src/Udp2log/StreamWriter.php
D vendor/bd808/monolog-udp2log-handler/tests/TestCase.php
D vendor/bd808/monolog-udp2log-handler/tests/Udp2log/UdpWriterTest.php
D vendor/bd808/monolog-udp2log-handler/tests/Udp2logHandlerTest.php
D vendor/bd808/monolog-udp2log-handler/tests/bootstrap.php
M vendor/composer/ClassLoader.php
M vendor/composer/autoload_classmap.php
M vendor/composer/autoload_real.php
M vendor/composer/installed.json
15 files changed, 415 insertions(+), 445 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/iegreview 
refs/changes/50/193050/1

diff --git a/composer.json b/composer.json
index 1bbfea0..1fc11dc 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
   "name": "mediawiki/iegreview",
   "require": {
 "php": ">=5.3.7",
-"bd808/monolog-udp2log-handler": "1.0.0",
+"bd808/monolog-udp2log-handler": "1.0.1",
 "monolog/monolog": "1.10.0",
 "phpmailer/phpmailer": "v5.2.8",
 "slim/slim": "2.4.3",
@@ -10,10 +10,15 @@
 "twig/twig": "1.16.0",
 "wikimedia/simplei18n": "1.0.0"
   },
-  "preferred-install": "dist",
   "autoload": {
 "psr-4": {
   "Wikimedia\\IEGReview\\": "src/"
 }
+  },
+  "config": {
+"autoloader-suffix": "_iegreview",
+"classmap-authoritative": true,
+"optimize-autoloader": true,
+"preferred-install": "dist"
   }
 }
diff --git a/composer.lock b/composer.lock
index 5230f99..8bf4a01 100644
--- a/composer.lock
+++ b/composer.lock
@@ -4,20 +4,20 @@
 "Read more about it at 
http://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file";,
 "This file is @generated automatically"
 ],
-"hash": "9121275399ec6b37ad93e4675fae223b",
+"hash": "43c00330afc9b9d76d39258470e9dd1c",
 "packages": [
 {
 "name": "bd808/monolog-udp2log-handler",
-"version": "v1.0.0",
+"version": "v1.0.1",
 "source": {
 "type": "git",
 "url": "https://github.com/bd808/udp2log-monolog-handler.git";,
-"reference": "9cef81fda240a651c3b934fb24b9ea48a4824e1b"
+"reference": "b45bc0d31e194694538ce3e7181bc6d7f54e881c"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/bd808/udp2log-monolog-handler/zipball/9cef81fda240a651c3b934fb24b9ea48a4824e1b";,
-"reference": "9cef81fda240a651c3b934fb24b9ea48a4824e1b",
+"url": 
"https://api.github.com/repos/bd808/udp2log-monolog-handler/zipball/b45bc0d31e194694538ce3e7181bc6d7f54e881c";,
+"reference": "b45bc0d31e194694538ce3e7181bc6d7f54e881c",
 "shasum": ""
 },
 "require": {
@@ -52,7 +52,7 @@
 "monolog",
 "udp2log"
 ],
-"time": "2014-09-14 17:15:23"
+"time": "2015-02-26 05:01:15"
 },
 {
 "name": "monolog/monolog",
@@ -424,21 +424,14 @@
 "time": "2014-09-29 00:38:51"
 }
 ],
-"packages-dev": [
-
-],
-"aliases": [
-
-],
+"packages-dev": [],
+"aliases": [],
 "minimum-stability": "stable",
-"stability-flags": [
-
-],
+"stability-flags": [],
 "prefer-stable": false,
+"prefer-lowest": false,
 "platform": {
 "php": ">=5.3.7"
 },
-"platform-dev": [
-
-]
+"platform-dev": []
 }
diff --git a/vendor/autoload.php b/vendor/autoload.php
index b6c946b..69a4a7d 100644
--- a/vendor/autoload.php
+++ b/vendor/autoload.php
@@ -4,4 +4,4 @@
 
 require_once __DIR__ . '/composer' . '/autoload_real.php';
 
-return ComposerAutoloaderInitb1648a8afef914d44ac1f683996dedfa::getLoader();
+return ComposerAutoloaderInit_iegreview::getLoader();
diff --git a/vendor/bd808/monolog-udp2log-handler/.gitignore 
b/vendor/bd808/monolog-udp2log-handler/.gitignore
deleted file mode 100644
index 18b7007..000
--- a/vendor/bd808/monolog-udp2log-handler/.gitignore
+++ /dev/null
@@ -1,4 +0,0 @@
-.php-version
-composer.lock
-vendor
-report
diff --git a/vendor/bd808/monolog-udp2log-handler/.travis.yml 
b/vendor/bd808/monolog-udp2log-handler/.travis.yml
deleted file mode 100644
index 32ae5c3..000
--- a/vendor/bd808/monolog-udp2log-handler/.

[MediaWiki-commits] [Gerrit] Focus the source title input when opening the selector - change (mediawiki...ContentTranslation)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Focus the source title input when opening the selector
..


Focus the source title input when opening the selector

Bug: T90727
Change-Id: Idd1aba74e9a4c07660138a332b443ac7ead2815d
---
M modules/source/ext.cx.source.selector.js
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Santhosh: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/source/ext.cx.source.selector.js 
b/modules/source/ext.cx.source.selector.js
index 0a808ef..6515729 100644
--- a/modules/source/ext.cx.source.selector.js
+++ b/modules/source/ext.cx.source.selector.js
@@ -584,6 +584,8 @@
sourceUls.left = this.$sourceLanguage.offset().left;
targetUls = this.$targetLanguage.data( 'uls' );
targetUls.left = this.$targetLanguage.offset().left;
+
+   this.$sourceTitleInput.focus();
};
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/192989
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idd1aba74e9a4c07660138a332b443ac7ead2815d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Amire80 
Gerrit-Reviewer: Amire80 
Gerrit-Reviewer: Pginer 
Gerrit-Reviewer: Santhosh 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] jenkins job validation, do not submit - change (cdb)

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193048

Change subject: jenkins job validation, do not submit
..

jenkins job validation, do not submit

Change-Id: I5d8a342a03675aa53efe0c721463443d9c849712
---
A test.php
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/cdb refs/changes/48/193048/1

diff --git a/test.php b/test.php
new file mode 100644
index 000..71625a4
--- /dev/null
+++ b/test.php
@@ -0,0 +1,2 @@
+https://gerrit.wikimedia.org/r/193048
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d8a342a03675aa53efe0c721463443d9c849712
Gerrit-PatchSet: 1
Gerrit-Project: cdb
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] jenkins job validation, do not submit - change (mediawiki...codesniffer)

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193049

Change subject: jenkins job validation, do not submit
..

jenkins job validation, do not submit

Change-Id: I1e66796dd406fa1dd5c80942d17236dfb05ef883
---
A test.php
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer 
refs/changes/49/193049/1

diff --git a/test.php b/test.php
new file mode 100644
index 000..71625a4
--- /dev/null
+++ b/test.php
@@ -0,0 +1,2 @@
+https://gerrit.wikimedia.org/r/193049
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e66796dd406fa1dd5c80942d17236dfb05ef883
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] jenkins job validation, do not submit - change (utfnormal)

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193047

Change subject: jenkins job validation, do not submit
..

jenkins job validation, do not submit

Change-Id: I60de05c0c729e990edd510eea46d4aa76f335fad
---
A test.php
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/utfnormal refs/changes/47/193047/1

diff --git a/test.php b/test.php
new file mode 100644
index 000..71625a4
--- /dev/null
+++ b/test.php
@@ -0,0 +1,2 @@
+https://gerrit.wikimedia.org/r/193047
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I60de05c0c729e990edd510eea46d4aa76f335fad
Gerrit-PatchSet: 1
Gerrit-Project: utfnormal
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] jenkins job validation, do not submit - change (oojs/ui)

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193046

Change subject: jenkins job validation, do not submit
..

jenkins job validation, do not submit

Change-Id: Iad7cbf31a6f80c1a5cc77c1fa61abcdb7b8ee3ff
---
A test.php
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/46/193046/1

diff --git a/test.php b/test.php
new file mode 100644
index 000..71625a4
--- /dev/null
+++ b/test.php
@@ -0,0 +1,2 @@
+https://gerrit.wikimedia.org/r/193046
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad7cbf31a6f80c1a5cc77c1fa61abcdb7b8ee3ff
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Run {name}-composer jobs on HHVM too - change (integration/config)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Run {name}-composer jobs on HHVM too
..


Run {name}-composer jobs on HHVM too

Change-Id: I72dcce253c80416f2c42e2f186e48faee455b13c
---
M jjb/job-templates.yaml
M jjb/mediawiki-tools.yaml
M jjb/misc.yaml
M jjb/operations-mw-config.yaml
M zuul/layout.yaml
5 files changed, 40 insertions(+), 18 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/jjb/job-templates.yaml b/jjb/job-templates.yaml
index ee625e1..2459922 100644
--- a/jjb/job-templates.yaml
+++ b/jjb/job-templates.yaml
@@ -67,8 +67,8 @@
 # Run composer update and composer test
 #
 - job-template:
-name: '{name}-composer'
-node: contintLabsSlave && UbuntuPrecise
+name: '{name}-composer-{phpflavor}'
+node: 'contintLabsSlave && (UbuntuPrecise && phpflavor-zend && 
phpflavor-{phpflavor}) || (UbuntuTrusty && phpflavor-hhvm && 
phpflavor-{phpflavor})'
 defaults: use-remoteonly-zuul
 concurrent: true
 triggers:
diff --git a/jjb/mediawiki-tools.yaml b/jjb/mediawiki-tools.yaml
index 2f1bd8f..999ad30 100644
--- a/jjb/mediawiki-tools.yaml
+++ b/jjb/mediawiki-tools.yaml
@@ -7,10 +7,12 @@
 
 - project:
 name: 'mw-tools-codesniffer'
-
+phpflavor:
+- zend
+- hhvm
 jobs:
  - '{name}-phplint'
- - '{name}-composer'
+ - '{name}-composer-{phpflavor}'
 
 - project:
 name: 'mw-tools-dippybird'
diff --git a/jjb/misc.yaml b/jjb/misc.yaml
index 1fc6be8..e252042 100644
--- a/jjb/misc.yaml
+++ b/jjb/misc.yaml
@@ -74,11 +74,14 @@
 
 - project:
 name: 'oojs-ui'
+phpflavor:
+- zend
+- hhvm
 jobs:
  - '{name}-jslint'
  - '{name}-npm'
  - '{name}-phplint'
- - '{name}-composer'
+ - '{name}-composer-{phpflavor}'
  - '{name}-bundle-{bundlecommand}':
  bundlecommand:
   - rubocop
@@ -103,8 +106,11 @@
 
 - project:
 name: 'cdb'
+phpflavor:
+- zend
+- hhvm
 jobs:
- - '{name}-composer'
+ - '{name}-composer-{phpflavor}'
  - '{name}-phplint'
 
 - project:
@@ -114,6 +120,9 @@
 
 - project:
 name: 'utfnormal'
+phpflavor:
+- zend
+- hhvm
 jobs:
- - '{name}-composer'
+ - '{name}-composer-{phpflavor}'
  - '{name}-phplint'
diff --git a/jjb/operations-mw-config.yaml b/jjb/operations-mw-config.yaml
index 373b0e0..77f585d 100644
--- a/jjb/operations-mw-config.yaml
+++ b/jjb/operations-mw-config.yaml
@@ -16,8 +16,10 @@
 
 - project:
 name: 'operations-mw-config'
-
+phpflavor:
+- zend
+- hhvm
 jobs:
  - '{name}-phplint'
- - '{name}-composer'
+ - '{name}-composer-{phpflavor}'
  - operations-mw-config-tests
diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index a654055..1f22833 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -2377,9 +2377,11 @@
  - mw-tools-codesniffer-phplint
  - php-composer-validate
 test:
- - mw-tools-codesniffer-composer
+ - mw-tools-codesniffer-composer-zend
+ - mw-tools-codesniffer-composer-hhvm
 gate-and-submit:
- - mw-tools-codesniffer-composer
+ - mw-tools-codesniffer-composer-zend
+ - mw-tools-codesniffer-composer-hhvm
 
   - name: mediawiki/tools/dippybird
 check-voter:
@@ -2554,7 +2556,8 @@
   - operations-mw-config-tests
   - php-composer-validate
 experimental:
-  - operations-mw-config-composer
+  - operations-mw-config-composer-zend
+  - operations-mw-config-composer-hhvm
 postmerge:
   - beta-mediawiki-config-update-eqiad
 
@@ -6139,18 +6142,22 @@
  - cdb-phplint
  - php-composer-validate
 test:
- - cdb-composer
+ - cdb-composer-hhvm
+ - cdb-composer-zend
 gate-and-submit:
- - cdb-composer
+ - cdb-composer-hhvm
+ - cdb-composer-zend
 
   - name: utfnormal
 check:
  - utfnormal-phplint
  - php-composer-validate
 test:
- - utfnormal-composer
+ - utfnormal-composer-hhvm
+ # Zend is pretty slow so only test it on gate
 gate-and-submit:
- - utfnormal-composer
+ - utfnormal-composer-zend
+ - utfnormal-composer-hhvm
 
   - name: sartoris
 template:
@@ -6200,13 +6207,15 @@
 test:
   - oojs-ui-bundle-rubocop
   - oojs-ui-npm
-  - oojs-ui-composer
+  - oojs-ui-composer-zend
+  - oojs-ui-composer-hhvm
   - oojs-ui-jsduck
   - oojs-ui-ruby2.0lint
 gate-and-submit:
   - oojs-ui-bundle-rubocop
   - oojs-ui-npm
-  - oojs-ui-composer
+  - oojs-ui-composer-zend
+  - oojs-ui-composer-hhvm
   - oojs-ui-jsduck
   - oojs-ui-ruby2.0lint
 postmerge:

-- 
To view, visit https://gerrit.wikimedia.org/r/192980
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I72dcce253c80416f2c42e2f186e48faee455b13c
Gerrit-PatchSet: 3
Gerrit-Project: integration/config

[MediaWiki-commits] [Gerrit] Unregister clipboard listener in onDestroy instead of onStop. - change (apps...wikipedia)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Unregister clipboard listener in onDestroy instead of onStop.
..


Unregister clipboard listener in onDestroy instead of onStop.

The onStop event is too "early" for unregistering the clipboard listener.
It's possible to go to another activity (e.g. gallery), then come back,
and suddenly be unable to share highlighted text. This is because the
activity was stopped (onStop) and then resumed.

The onDestroy event is called when the activity will definitely not be
resumed. Dismissing the sharing dialogs inside this event is OK, too.

Change-Id: I89d2e0ded02929434dc3d55cb34afbaccb77c901
---
M wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
M wikipedia/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
M 
wikipedia/src/main/java/org/wikipedia/page/snippet/TextSelectedShareAdapter.java
3 files changed, 12 insertions(+), 8 deletions(-)

Approvals:
  BearND: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java 
b/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
index 4eb076a..7a5f093 100644
--- a/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
@@ -815,11 +815,6 @@
 if (themeChooser != null && themeChooser.isShowing()) {
 themeChooser.dismiss();
 }
-if (textSelectedShareAdapter != null) {
-textSelectedShareAdapter.onStop();
-}
-noTextSelectedShareAdapter.onStop();
-
 app.getSessionFunnel().persistSession();
 
 super.onStop();
@@ -828,6 +823,15 @@
 Log.d("Wikipedia", "Deregistering bus");
 }
 
+@Override
+protected void onDestroy() {
+if (textSelectedShareAdapter != null) {
+textSelectedShareAdapter.onDestroy();
+}
+noTextSelectedShareAdapter.onDestroy();
+super.onDestroy();
+}
+
 /**
  * ActionMode that is invoked when the user long-presses inside the 
WebView.
  * Since API <11 doesn't provide a long-press context for the WebView 
anyway, and we're
diff --git 
a/wikipedia/src/main/java/org/wikipedia/page/snippet/ShareHandler.java 
b/wikipedia/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
index e96f519..51f564b 100644
--- a/wikipedia/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
@@ -37,7 +37,7 @@
 this.activity = activity;
 }
 
-public void onStop() {
+public void onDestroy() {
 if (shareDialog != null) {
 shareDialog.dismiss();
 shareDialog = null;
diff --git 
a/wikipedia/src/main/java/org/wikipedia/page/snippet/TextSelectedShareAdapter.java
 
b/wikipedia/src/main/java/org/wikipedia/page/snippet/TextSelectedShareAdapter.java
index 927966b..317b067 100644
--- 
a/wikipedia/src/main/java/org/wikipedia/page/snippet/TextSelectedShareAdapter.java
+++ 
b/wikipedia/src/main/java/org/wikipedia/page/snippet/TextSelectedShareAdapter.java
@@ -53,9 +53,9 @@
 
 @Override
 @TargetApi(11)
-public void onStop() {
+public void onDestroy() {
 clipboard.removePrimaryClipChangedListener(clipChangedListener);
-super.onStop();
+super.onDestroy();
 }
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/193039
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I89d2e0ded02929434dc3d55cb34afbaccb77c901
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Regression fix for TOC root level sections titles not being ... - change (apps...wikipedia)

[Mhurd (Code Review)]

Mhurd has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193045

Change subject: Regression fix for TOC root level sections titles not being 
bold.
..

Regression fix for TOC root level sections titles not being bold.

Change-Id: I22d2fd706e70a17f40fe47b455fde89d43ebce64
---
M wikipedia/View Controllers/TableOfContents/TOCViewController.m
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia 
refs/changes/45/193045/1

diff --git a/wikipedia/View Controllers/TableOfContents/TOCViewController.m 
b/wikipedia/View Controllers/TableOfContents/TOCViewController.m
index 2d2f4ca..0bb873c 100644
--- a/wikipedia/View Controllers/TableOfContents/TOCViewController.m
+++ b/wikipedia/View Controllers/TableOfContents/TOCViewController.m
@@ -602,7 +602,7 @@
 @{
   @"id": @(section.sectionId),
   @"isLead": @([section isLeadSection]),
-  @"level": section.level ? section.level : @0,
+  @"level": section.toclevel ? section.toclevel : @0,
   @"title": title
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/193045
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I22d2fd706e70a17f40fe47b455fde89d43ebce64
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mhurd 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Tweak the size of gallery license icon. - change (apps...wikipedia)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Tweak the size of gallery license icon.
..


Tweak the size of gallery license icon.

Per Vibha's request.
The click area remains the same, and also added drawable for highlight on
press.

Change-Id: I433b2fcc9b48379d2ff2a5beb6f9d533ff71fb0c
---
M wikipedia/res/layout/activity_gallery.xml
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  BearND: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wikipedia/res/layout/activity_gallery.xml 
b/wikipedia/res/layout/activity_gallery.xml
index 92a5d87..867ae1e 100644
--- a/wikipedia/res/layout/activity_gallery.xml
+++ b/wikipedia/res/layout/activity_gallery.xml
@@ -59,15 +59,17 @@
 android:gravity="center_vertical">
 
 https://gerrit.wikimedia.org/r/193037
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I433b2fcc9b48379d2ff2a5beb6f9d533ff71fb0c
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Disallow XoviBot in robots.txt - change (labs/toollabs)

[Tim Landscheidt (Code Review)]

Tim Landscheidt has submitted this change and it was merged.

Change subject: Disallow XoviBot in robots.txt
..


Disallow XoviBot in robots.txt

Bug: T90636
Change-Id: If1460e3c116c70d6fb702796d7037ccb5fde9622
---
M www/robots.txt
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Tim Landscheidt: Looks good to me, approved



diff --git a/www/robots.txt b/www/robots.txt
index 7c532a3..74663c5 100644
--- a/www/robots.txt
+++ b/www/robots.txt
@@ -1,3 +1,7 @@
 User-agent: *
 Disallow: /betacommand-dev/
 Disallow: /fiwiki-tools/
+
+# Disallow XoviBot.
+User-agent: XoviBot
+Disallow: /

-- 
To view, visit https://gerrit.wikimedia.org/r/193043
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If1460e3c116c70d6fb702796d7037ccb5fde9622
Gerrit-PatchSet: 1
Gerrit-Project: labs/toollabs
Gerrit-Branch: master
Gerrit-Owner: Tim Landscheidt 
Gerrit-Reviewer: Tim Landscheidt 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Disallow XoviBot in robots.txt - change (labs/toollabs)

[Tim Landscheidt (Code Review)]

Tim Landscheidt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193043

Change subject: Disallow XoviBot in robots.txt
..

Disallow XoviBot in robots.txt

Bug: T90636
Change-Id: If1460e3c116c70d6fb702796d7037ccb5fde9622
---
M www/robots.txt
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/labs/toollabs 
refs/changes/43/193043/1

diff --git a/www/robots.txt b/www/robots.txt
index 7c532a3..74663c5 100644
--- a/www/robots.txt
+++ b/www/robots.txt
@@ -1,3 +1,7 @@
 User-agent: *
 Disallow: /betacommand-dev/
 Disallow: /fiwiki-tools/
+
+# Disallow XoviBot.
+User-agent: XoviBot
+Disallow: /

-- 
To view, visit https://gerrit.wikimedia.org/r/193043
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If1460e3c116c70d6fb702796d7037ccb5fde9622
Gerrit-PatchSet: 1
Gerrit-Project: labs/toollabs
Gerrit-Branch: master
Gerrit-Owner: Tim Landscheidt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove obsolete language folders - change (apps...wikipedia)

[BearND (Code Review)]

BearND has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193041

Change subject: Remove obsolete language folders
..

Remove obsolete language folders

This is a follow-up to https://gerrit.wikimedia.org/r/#/c/191497/.

Change-Id: I669384022d6db99834290c35db1effc92970f73f
---
D wikipedia/res/values-id/strings.xml
D wikipedia/res/values-iw
R wikipedia/res/values-iw/strings.xml
D wikipedia/res/values-yi/strings.xml
4 files changed, 0 insertions(+), 431 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/41/193041/1

diff --git a/wikipedia/res/values-id/strings.xml 
b/wikipedia/res/values-id/strings.xml
deleted file mode 100644
index cdb817e..000
--- a/wikipedia/res/values-id/strings.xml
+++ /dev/null
@@ -1,284 +0,0 @@
-
-
-  Wikipedia
-  Wikipedia Beta
-  Wikipedia Alpha
-  Ya
-  Tidak
-  Terjadi kesalahan di Wikipedia 
:(
-  Kirimkan laporan kesalahan
-  Apa yang Anda lakukan ketika 
terjadi kesalahan?
-  Telusuri Wikipedia
-  Riwayat
-  Riwayat
-  Tidak ada sambungan jaringan :(
-  Kesalahan jaringan. Ketuk untuk mencoba 
lagi.
-  Coba lagi
-  Hapus riwayat
-  Hapus penanda buku
-  Hapus semua halaman 
tersimpan
-  Halaman ini tidak ada.
-  Hari ini
-  Hapus riwayat perambanan?
-  Halaman tersimpan
-  Halaman tersimpan
-  Halaman terbaru yang 
disimpan
-  Halaman terbaru yang 
disimpan
-  Perbarui semua halaman 
tersimpan?
-  Halaman tersimpan telah 
diperbarui
-  Simpan halaman
-  Bagikan
-  Berbagi melalui
-  Hapus semua halaman 
tersimpan?
-  Apakah Anda yakin ingin 
menghapus semua riwayat?
-  Menyimpan halaman...
-  Penyimpanan halaman berhasil
-  Tidak dapat menyelamatkan 
semua gambar
-  Gagal menyimpan halaman :(
-  Menyegarkan halaman 
disimpan...
-  Hapus
-  Halaman yang disimpan 
terhapus
-  Cari
-  Tidak ada halaman yang cocok 
dengan \'%s\'
-  Sekitar
-  Sekitar
-  Perbarui dekat
-  Tidak ada halaman terdekat di 
sini!
-  Bila Anda pindah ke lokasi baru, coba 
menyegarkan halaman ini untuk mempelajari lebih lanjut tentang apa yang ada di 
sekitar Anda.
-  %d m
-  %.2f km
-  %d kaki
-  %.2f mil
-  Tidak ada sambungan jaringan
-  Tidak bisa mendapatkan daftar tempat 
terdekat.
-  Tidak dapat menentukan lokasi
-  Pemutakhiran lokasi tidak 
diaktifkan pada perangkat Anda. Apakah Anda ingin pergi ke pengaturan perangkat 
Anda untuk mengaktifkan pemutakhiran Lokasi?
-  Tampilkan dalam meter/km
-  Tampilkan dalam kaki/mil
-  Terakhir diperbarui %1$s
-  Konten tersedia di bawah CC BY-SA 3.0 
kecuali dinyatakan lain
-  Dengan menyimpan, Anda 
setuju terhadap Ketentuan 
Penggunaan, dan melepas kontribusi Anda di bawah lisensi CC BY-SA 
3.0.
-  Dengan menyimpan, Anda setuju 
terhadap Ketentuan 
Penggunaan, dan melepas kontribusi Anda di bawah lisensi CC BY-SA 
3.0. Suntingan akan dihubungkan ke alamat IP perangkat. Jika Anda 
masuk log, Anda akan memiliki lebih 
privasi.
-  Bahasa Wikipedia
-  Bahasa isi
-  Cari
-  Cari
-  Baca dalam bahasa lain
-  Coba lagi
-  Halaman ini tidak tersedia dalam bahasa 
lain
-  Tidak ada bahasa yang ditemukan yang cocok 
dengan permintaan Anda.
-  Pengaturan
-  Bahasa lain
-  Simpan perubahan
-  Coba lagi
-  Sedang menyimpan...
-  Suntingan telah disimpan!
-  Penyuntingan gagal!
-  Coba lagi
-  Batal
-  Perubahan anda belum disimpan. 
Anda yakin ingin meninggalkan halaman ini?
-  Tinggalkan
-  Tetap
-  Daftar isi
-  Tidak ada hasil yang 
ditemukan
-  Untuk membantu melindungi 
terhadap spam otomatis, masukkan kata-kata yang muncul di bawah ini
-  Ulangi kata-kata dari atas
-  Masukkan CAPTCHA
-  Ketuk CAPTCHA untuk memuat 
ulang
-  Halaman tersimpan ini mungkin 
kedaluwarsa, dan harus disegarkan untuk penyuntingan harus diaktifkan. Apakah 
Anda ingin memperbarui halaman?
-  Masuk log
-  Nama pengguna
-  Kata sandi
-  Tampilkan kata sandi
-  Masuk log
-  Masuk ke Wikipedia
-  Sedang masuk log...
-  Kata sandi salah
-  Nama pengguna salah
-  Berhasil masuk log!
-  Pengguna ini telah diblokir
-  Terlalu banyak upaya masuk log. Tunggu 
beberapa menit dan coba lagi.
-  Masuk log gagal :(
-  Tidak ada sambungan jaringan
-  Keluar log
-  Keluar log
-  Keluar log dari akun 
Wikipedia
-  Belum masuk log
-  Telah keluar log
-  Tidak ada halaman yang disimpan di 
sini!
-  Halaman yang disimpan cukup 
mengagumkan. Menganggap mereka sebagai penanda yang dapat Anda baca bahkan 
ketika Anda sedang luring.
-  Tidak ada halaman terbaru di 
sini.
-  Anda mungkin menghapus mereka semua. 
Lain kali Anda pergi ke halaman Anda dapat kembali ke sana dari sini.
-  Hapus
-  WIKIPEDIA
-  Ensikl

[MediaWiki-commits] [Gerrit] Remove translations below the completion threshold - change (apps...wikipedia)

[BearND (Code Review)]

BearND has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193042

Change subject: Remove translations below the completion threshold
..

Remove translations below the completion threshold

TWN does not export translations once they drop below the threshold of 35% 
completion.
Once those languages that got remove will get above that threshold they will be
added back automatically.

Change-Id: I3da915485ed9102de151ae3a643c93def9fc7b84
---
D wikipedia/res/values-be/strings.xml
D wikipedia/res/values-gu/strings.xml
D wikipedia/res/values-kn/strings.xml
D wikipedia/res/values-lv/strings.xml
D wikipedia/res/values-mn/strings.xml
D wikipedia/res/values-or/strings.xml
D wikipedia/res/values-sq/strings.xml
D wikipedia/res/values-te/strings.xml
8 files changed, 0 insertions(+), 690 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/42/193042/1

diff --git a/wikipedia/res/values-be/strings.xml 
b/wikipedia/res/values-be/strings.xml
deleted file mode 100644
index 18a9568..000
--- a/wikipedia/res/values-be/strings.xml
+++ /dev/null
@@ -1,90 +0,0 @@
-
-
-  Вікіпедыя
-  Так
-  Не
-  Адпраўце нам справаздачу пра 
памылку
-  Што вы рабілі, калі адбыўся 
збой?
-  Пошук у Вікіпэдыі
-  Гісторыя
-  Гісторыя
-  Памылка сеткі. Націсніце, каб 
паспрабаваць зноў.
-  Паўтарыць
-  Ачысціць гісторыю
-  Ачысціць закладкі
-  Гэтая старонка не існуе.
-  Ачысціць 
гісторыю?
-  Закладкі
-  Закладкі
-  Закладка
-  Апублікаваць
-  Апублікаваць праз
-  Ачысціць 
закладкі?
-  Вы ўпэўнены, 
што хочаце выдаліць усе закладкі?
-  Выдаліць
-  Закладкі 
выдалены
-  Апошняе абнаўленне %1$s
-  Змесціва даступна ў 
адпаведнасці з CC-BY-SA 3.0, 
калі не пазначана іншае
-  Мова Вікіпедыі
-  Мова змесціва
-  Пошук
-  Пошук
-  Іншыя мовы
-  Паўтарыць
-  Гэты артыкул не даступны на 
іншых мовах
-  Настройкі
-  Іншыя мовы
-  Паўтарыць
-  Захаванне...
-  Рэдагаванне захавана!
-  Паўтарыць
-  Адмяніць
-  Змест
-  Нічога не знойдзена
-  Для абароны ад аўтаматычнага 
спаму, калі ласка, увядзіце словы, якія з\'яўляюцца ніжэй
-  Увайсці
-  Імя карыстальніка
-  Пароль
-  Паказаць пароль
-  Увайсці
-  Няправільны пароль
-  Няправільнае імя 
карыстальніка
-  Паспяховы ўваход у сістэму!
-  Гэты карыстальнік заблакаваны
-  Занадта шмат спробаў уваходу ў сыстэму. 
Пачакайце некалькі хвілінаў і паспрабуйце зноў.
-  Памылка ўваходу :(
-  Няма падлучэння да сеткі
-  Выйсці
-  Няма закладак
-  Ваша гісторыя 
пустая.
-  Імя карыстальніка
-  Пароль
-  Стварыць рахунак
-  Стварыць 
рахунак
-  Стварыць рахунак
-  Рэдагаваць раздзел
-  Праверка
-  Адрас электроннай пошты (не 
абавязкова)
-  Паўтарыце пароль
-  Паролі не 
супадаюць
-  Няслушны адрас электроннай 
пошты
-  Імя карыстальніка ўжо 
выкарыстоўваецца
-  Занадта шмат рахункаў, 
створаных з гэтага IP-адрасу. Паспрабуйце яшчэ раз пазней.
-  Немагчыма стварыць 
рахунак
-  Няма падлучэння да сеткі
-  Агульныя
-  Працягнуць
-  Адмяніць
-  Даведацца 
больш
-  Настройкі
-  Атрыманне папярэдняга 
прагляду...
-  Уваходжу...
-  Рэдагаваць рэзюмэ
-  Выпадковы
-  Рахунак 
створаны!
-  Загрузіць больш
-  Мой унёсак
-  Мае ўнёскі
-  Захаваць ананімна
-  Адпраўляць справаздачы 
аб выкарыстанні
-
diff --git a/wikipedia/res/values-gu/strings.xml 
b/wikipedia/res/values-gu/strings.xml
deleted file mode 100644
index e74564e..000
--- a/wikipedia/res/values-gu/strings.xml
+++ /dev/null
@@ -1,45 +0,0 @@
-
-
-  વિકિપીડિયા
-  હા
-  ના
-  ઇતિહાસ
-  ઇતિહાસ
-  નેટવર્ક ક્ષતિ. ફરી પ્રયત્ન કરવા ટૅપ 
કરો.
-  ફરી પ્રયત્ન કરો
-  ઇતિહાસ હટાવો
-  ઇતિહાસ હટાવશો?
-  પાનું સાચવો
-  વહેંચો
-  પાનું સંગ્રહવાનું નિષ્ફળ :(
-  દૂર કરો
-  ભાષા
-  શોધ
-  શોધ
-  અન્ય ભાષાઓ
-  ફરી પ્રયત્ન કરો
-  ગોઠવણીઓ
-  અન્ય ભાષાઓ
-  ફરી પ્રયત્ન કરો
-  ફરી પ્રયત્ન કરો
-  રદ્ કરો
-  કોઈ પરિણામો ન મળ્યા
-  સભ્યનામ
-  પાસવર્ડ
-  પ્રવેશ કરો
-  અયોગ્ય પાસવર્ડ
-  અયોગ્ય સભ્યનામ
-  પ્રવેશ સફળ!
-  પ્રવેશ નિષ્ફળ :(
-  કોઇ નેટવર્ક જોડાણ નથી
-  બહાર નીકળો
-  સભ્યનામ
-  પાસવર્ડ
-  ખાતું બનાવો
-  અયોગ્ય ઇમેલ સરનામું
-  સામાન્ય
-  ચાલુ રાખો
-  રદ્ કરો
-  વધુ જાણો
-  ગોઠવણીઓ
-
diff --git a/wikipedia/res/values-kn/strings.xml 
b/wikipedia/res/values-kn/strings.xml
deleted file mode 100644
index 88707db..000
--- a/wikipedia/res/values-kn/strings.xml
+++ /dev/null
@@ -1,88 +0,0 @@
-
-
-  ವಿಕಿಪೀಡಿಯ
-  ಹೌದು
-  ಇಲ್ಲ
-  ವಿಕಿಪೀಡಿಯ ಹುಡುಕು
-  ಇತಿಹಾಸ
-  ಇತಿಹಾಸ
-  ಪುನಃ ಪ್ರಯತ್ನಿಸಿ
-  ಇತಿಹಾಸವನ್ನು ಅಳಿಸಿ
-  ಓದುಗುರುತುಗಳನ್ನು  ಅಳಿಸು
-  ಈ ಪುಟವು ಆಸ್ಥಿತ್ವದಲ್ಲಿ ಇಲ್ಲ.
-  ಇತಿಹಾಸವನ್ನು 
ಅಳಿಸಬೇಕೆ?
-  ಓದುಗುರುತುಗಳು
-  ಓದುಗುರುತುಗಳು
-  ಓದುಗುರುತು
-  ಹಂಚು
-  ಮೂಲಕ ಹಂಚು
-  ಓದುಗುರುತುಗಳನ್ನು 
ಅಳಿಸಬೇಕೆ?
-  ಎಲ್ಲಾ 
ಓದುಗುರುತುಗಳನ್ನು ಅಳಿಸುವಬಗ್ಗೆ ನೀವು ಖಾತ್ರಿಯಾಗಿದ್ದೀರಾ?
-  ಪುಟವನ್ನು ಓದುಗುರುತಾಗಿ 
ಉಳಿಸಲಾಗುತ್ತಿದೆ...
-  ಪುಟವನ್ನು ಓದುಗುರುತು 
ಮಾಡಲಾಗಿದೆ
-  ಪುಟವನ್ನು ಓದುಗುರುತು ಮಾಡಲು 
ಸಾದ್ಯವಾಗಿಲ್ಲ:
-  ಅಳಿಸು
-  ಓದುಗುರುತುಗಳನ್ನು 
ಅಳಿಸಲಾಗಿದೆ
-  ಕೊನೆಯ ಪರಿಷ್ಕರಣೆ %1$s
-  ವಿಕಿಪೀಡಿಯಾ ಭಾಷೆ
-  ವಿಷಯದ ಭಾಷೆ
-  ಹುಡುಕು
-  ಹುಡುಕು
- 

[MediaWiki-commits] [Gerrit] [WIP] Add support for optionally activated tags - change (mediawiki/core)

[Cenarium (Code Review)]

Cenarium has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193040

Change subject: [WIP] Add support for optionally activated tags
..

[WIP] Add support for optionally activated tags

This is a proof of concept for tags applied in core or by extensions that
are not active by default but can be activated by admins at Special:Tags.
The list of available optional tags is defined in a config variable, to which
extensions can append. These tags are defined, so are visible at Special:Tags,
and admins can activate them when needed. If a wiki does not want a particular
optional tag defined by default in core or extension settings to appear at
Special:Tags, it can be altogether removed from the config variable.
A config variable is used instead of a hook since these should be generic,
fixed, built-in tags as opposed to dynamic, user-defined tags added by abuse
filter for example. These tags can be deleted by admins (but they would still
be defined).
As an example, this includes a tag for "cross namespace moves". This allows
to filter pages moved into a namespace of interest, typically mainspace. See
T90310. A next step would be handling (un)redirects as requested in T73236.
This could be combined with patrolling of tagged changes (T89553).
Potential uses by extensions include for example in visual editor adding an
image, adding a template, and so on.
I'm not sure on the naming convention for those yet, for now I've just used a
"Core :" prefix. Note that the interface to (de)activate tags already exists,
so we just need to describe their source differently at Special:Tags, and also
to prevent their creation. I haven't included the defaults for the two new
messages. There should also be default appearance and description for the tags.

Change-Id: Ib4443a728d50f4ea84ec766471cf98d9fc4b34f6
---
M docs/hooks.txt
M includes/ChangeTags.php
M includes/DefaultSettings.php
M includes/MovePage.php
M includes/specials/SpecialTags.php
5 files changed, 77 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/40/193040/1

diff --git a/docs/hooks.txt b/docs/hooks.txt
index cf2e3dd..1ef6063 100644
--- a/docs/hooks.txt
+++ b/docs/hooks.txt
@@ -1740,7 +1740,11 @@
 'LinksUpdateConstructed': At the end of LinksUpdate() is construction.
 &$linksUpdate: the LinksUpdate object
 
-'ListDefinedTags': When trying to find all defined tags.
+'ListDefinedTags': When trying to find all extension defined tags.
+These tags cannot be deactivated by admins at Special:Tags. To define
+optional tags that admins can active and deactivate at Special:Tags,
+append to the array $wgOptionalTags instead and use the $optional
+param of the ChangeTags::addTags function.
 &$tags: The list of tags.
 
 'LoadExtensionSchemaUpdates': Called during database installation and updates.
diff --git a/includes/ChangeTags.php b/includes/ChangeTags.php
index d597d6d..5e1dafd 100644
--- a/includes/ChangeTags.php
+++ b/includes/ChangeTags.php
@@ -92,6 +92,8 @@
 * @param int|null $rev_id The rev_id of the change to add the tags to
 * @param int|null $log_id The log_id of the change to add the tags to
 * @param string $params Params to put in the ct_params field of table 
'change_tag'
+* @param bool $optional Whether the added tags should be treated as 
optional, this
+* should be set to true when adding optionally activated tags
 *
 * @throws MWException
 * @return bool False if no changes are made, otherwise true
@@ -99,8 +101,9 @@
 * @exception MWException When $rc_id, $rev_id and $log_id are all null
 */
public static function addTags( $tags, $rc_id = null, $rev_id = null,
-   $log_id = null, $params = null
+   $log_id = null, $params = null, $optional = false
) {
+   global $wgOptionalTags;
if ( !is_array( $tags ) ) {
$tags = array( $tags );
}
@@ -110,6 +113,22 @@
if ( !$rc_id && !$rev_id && !$log_id ) {
throw new MWException( 'At least one of: RCID, revision 
ID, and log ID MUST be ' .
'specified when adding a tag to a change!' );
+   }
+
+   if ( $optional ) {
+   // Making sure these are defined as optional in config
+   $tags = array_intersect( $tags, $wgOptionalTags );
+   // Abort if no tag remains
+   if ( !$tags ) {
+   return false;
+   }
+
+   // Keeping only manually activated tags
+   $tags = array_intersect( $tags, 
$self::listExplicitlyDefinedTags ) ;
+   // Abort if no tag remains
+   if ( !$tags ) {
+   retu

[MediaWiki-commits] [Gerrit] Localisation updates from https://translatewiki.net. - change (apps...wikipedia)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Localisation updates from https://translatewiki.net.
..


Localisation updates from https://translatewiki.net.

Change-Id: I4a734b29fc70dc90c3dce0eafa8862d16891b68c
---
M wikipedia/res/values-ak/strings.xml
M wikipedia/res/values-ar/strings.xml
M wikipedia/res/values-av/strings.xml
M wikipedia/res/values-bn/strings.xml
M wikipedia/res/values-br/strings.xml
M wikipedia/res/values-ca/strings.xml
M wikipedia/res/values-ce/strings.xml
M wikipedia/res/values-cs/strings.xml
M wikipedia/res/values-cy/strings.xml
M wikipedia/res/values-da/strings.xml
M wikipedia/res/values-de/strings.xml
M wikipedia/res/values-el/strings.xml
M wikipedia/res/values-eo/strings.xml
M wikipedia/res/values-es/strings.xml
M wikipedia/res/values-et/strings.xml
M wikipedia/res/values-eu/strings.xml
M wikipedia/res/values-fa/strings.xml
M wikipedia/res/values-fi/strings.xml
M wikipedia/res/values-fo/strings.xml
M wikipedia/res/values-fr/strings.xml
M wikipedia/res/values-gl/strings.xml
M wikipedia/res/values-he/strings.xml
M wikipedia/res/values-hi/strings.xml
M wikipedia/res/values-hu/strings.xml
A wikipedia/res/values-in/strings.xml
M wikipedia/res/values-it/strings.xml
M wikipedia/res/values-ja/strings.xml
A wikipedia/res/values-ji/strings.xml
M wikipedia/res/values-ka/strings.xml
M wikipedia/res/values-km/strings.xml
M wikipedia/res/values-ko/strings.xml
M wikipedia/res/values-kw/strings.xml
M wikipedia/res/values-ky/strings.xml
M wikipedia/res/values-lb/strings.xml
M wikipedia/res/values-lt/strings.xml
M wikipedia/res/values-mk/strings.xml
M wikipedia/res/values-ml/strings.xml
M wikipedia/res/values-mn/strings.xml
M wikipedia/res/values-mr/strings.xml
M wikipedia/res/values-ms/strings.xml
M wikipedia/res/values-my/strings.xml
M wikipedia/res/values-nb/strings.xml
M wikipedia/res/values-nl/strings.xml
M wikipedia/res/values-oc/strings.xml
M wikipedia/res/values-pa/strings.xml
M wikipedia/res/values-pl/strings.xml
M wikipedia/res/values-pt-rBR/strings.xml
M wikipedia/res/values-pt/strings.xml
M wikipedia/res/values-qq/strings.xml
M wikipedia/res/values-ro/strings.xml
M wikipedia/res/values-ru/strings.xml
M wikipedia/res/values-sk/strings.xml
M wikipedia/res/values-sr/strings.xml
M wikipedia/res/values-sv/strings.xml
M wikipedia/res/values-ta/strings.xml
M wikipedia/res/values-tr/strings.xml
M wikipedia/res/values-uk/strings.xml
M wikipedia/res/values-uz/strings.xml
M wikipedia/res/values-vi/strings.xml
M wikipedia/res/values-zh-rTW/strings.xml
M wikipedia/res/values-zh/strings.xml
M wikipedia/res/values/strings.xml
62 files changed, 800 insertions(+), 1,854 deletions(-)

Approvals:
  BearND: Looks good to me, approved
  jenkins-bot: Verified




-- 
To view, visit https://gerrit.wikimedia.org/r/193020
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4a734b29fc70dc90c3dce0eafa8862d16891b68c
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: BearND 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Unregister clipboard listener in onDestroy instead of onStop. - change (apps...wikipedia)

[Dbrant (Code Review)]

Dbrant has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193039

Change subject: Unregister clipboard listener in onDestroy instead of onStop.
..

Unregister clipboard listener in onDestroy instead of onStop.

The onStop event is too "early" for unregistering the clipboard listener.
It's possible to go to another activity (e.g. gallery), then come back,
and suddenly be unable to share highlighted text. This is because the
activity was stopped (onStop) and then resumed.

The onDestroy event is called when the activity will definitely not be
resumed. Dismissing the sharing dialogs inside this event is OK, too.

Change-Id: I89d2e0ded02929434dc3d55cb34afbaccb77c901
---
M wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
M wikipedia/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
M 
wikipedia/src/main/java/org/wikipedia/page/snippet/TextSelectedShareAdapter.java
3 files changed, 12 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/39/193039/1

diff --git a/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java 
b/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
index 4eb076a..7a5f093 100644
--- a/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
@@ -815,11 +815,6 @@
 if (themeChooser != null && themeChooser.isShowing()) {
 themeChooser.dismiss();
 }
-if (textSelectedShareAdapter != null) {
-textSelectedShareAdapter.onStop();
-}
-noTextSelectedShareAdapter.onStop();
-
 app.getSessionFunnel().persistSession();
 
 super.onStop();
@@ -828,6 +823,15 @@
 Log.d("Wikipedia", "Deregistering bus");
 }
 
+@Override
+protected void onDestroy() {
+if (textSelectedShareAdapter != null) {
+textSelectedShareAdapter.onDestroy();
+}
+noTextSelectedShareAdapter.onDestroy();
+super.onDestroy();
+}
+
 /**
  * ActionMode that is invoked when the user long-presses inside the 
WebView.
  * Since API <11 doesn't provide a long-press context for the WebView 
anyway, and we're
diff --git 
a/wikipedia/src/main/java/org/wikipedia/page/snippet/ShareHandler.java 
b/wikipedia/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
index e96f519..51f564b 100644
--- a/wikipedia/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
@@ -37,7 +37,7 @@
 this.activity = activity;
 }
 
-public void onStop() {
+public void onDestroy() {
 if (shareDialog != null) {
 shareDialog.dismiss();
 shareDialog = null;
diff --git 
a/wikipedia/src/main/java/org/wikipedia/page/snippet/TextSelectedShareAdapter.java
 
b/wikipedia/src/main/java/org/wikipedia/page/snippet/TextSelectedShareAdapter.java
index 927966b..317b067 100644
--- 
a/wikipedia/src/main/java/org/wikipedia/page/snippet/TextSelectedShareAdapter.java
+++ 
b/wikipedia/src/main/java/org/wikipedia/page/snippet/TextSelectedShareAdapter.java
@@ -53,9 +53,9 @@
 
 @Override
 @TargetApi(11)
-public void onStop() {
+public void onDestroy() {
 clipboard.removePrimaryClipChangedListener(clipChangedListener);
-super.onStop();
+super.onDestroy();
 }
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/193039
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I89d2e0ded02929434dc3d55cb34afbaccb77c901
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Dbtree link hosts to tendril - change (operations/software)

[Springle (Code Review)]

Springle has submitted this change and it was merged.

Change subject: Dbtree link hosts to tendril
..


Dbtree link hosts to tendril

Change-Id: I82b14bb462fbaa2846c725de53710fbe104592ab
---
M dbtree/inc/tree.php
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Springle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/dbtree/inc/tree.php b/dbtree/inc/tree.php
index 63894f5..02a916f 100644
--- a/dbtree/inc/tree.php
+++ b/dbtree/inc/tree.php
@@ -37,7 +37,10 @@
 $lag = expect($this->replag, $host_id, 'int', 0);
 $qps = expect($this->qps,$host_id, 'int', 0);
 
-$html = tag('div', array(
+$link_host = sprintf('https://tendril.wikimedia.org/host/view/%s/%d', 
$host['host'], $host['port']);
+
+$html = tag('a', array(
+'href'  => $link_host,
 'html'  => $this->node_describe($host_id),
 'title' => $this->node_instance($host_id),
 ))

-- 
To view, visit https://gerrit.wikimedia.org/r/193038
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I82b14bb462fbaa2846c725de53710fbe104592ab
Gerrit-PatchSet: 1
Gerrit-Project: operations/software
Gerrit-Branch: master
Gerrit-Owner: Springle 
Gerrit-Reviewer: Springle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Dbtree link hosts to tendril - change (operations/software)

[Springle (Code Review)]

Springle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193038

Change subject: Dbtree link hosts to tendril
..

Dbtree link hosts to tendril

Change-Id: I82b14bb462fbaa2846c725de53710fbe104592ab
---
M dbtree/inc/tree.php
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/software 
refs/changes/38/193038/1

diff --git a/dbtree/inc/tree.php b/dbtree/inc/tree.php
index 63894f5..02a916f 100644
--- a/dbtree/inc/tree.php
+++ b/dbtree/inc/tree.php
@@ -37,7 +37,10 @@
 $lag = expect($this->replag, $host_id, 'int', 0);
 $qps = expect($this->qps,$host_id, 'int', 0);
 
-$html = tag('div', array(
+$link_host = sprintf('https://tendril.wikimedia.org/host/view/%s/%d', 
$host['host'], $host['port']);
+
+$html = tag('a', array(
+'href'  => $link_host,
 'html'  => $this->node_describe($host_id),
 'title' => $this->node_instance($host_id),
 ))

-- 
To view, visit https://gerrit.wikimedia.org/r/193038
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I82b14bb462fbaa2846c725de53710fbe104592ab
Gerrit-PatchSet: 1
Gerrit-Project: operations/software
Gerrit-Branch: master
Gerrit-Owner: Springle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Tweak the size of gallery license icon. - change (apps...wikipedia)

[Dbrant (Code Review)]

Dbrant has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193037

Change subject: Tweak the size of gallery license icon.
..

Tweak the size of gallery license icon.

Per Vibha's request.
The click area remains the same, and also added drawable for highlight on
press.

Change-Id: I433b2fcc9b48379d2ff2a5beb6f9d533ff71fb0c
---
M wikipedia/res/layout/activity_gallery.xml
1 file changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/37/193037/1

diff --git a/wikipedia/res/layout/activity_gallery.xml 
b/wikipedia/res/layout/activity_gallery.xml
index 92a5d87..867ae1e 100644
--- a/wikipedia/res/layout/activity_gallery.xml
+++ b/wikipedia/res/layout/activity_gallery.xml
@@ -59,15 +59,17 @@
 android:gravity="center_vertical">
 
 https://gerrit.wikimedia.org/r/193037
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I433b2fcc9b48379d2ff2a5beb6f9d533ff71fb0c
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Hygiene: Split RevisionDiffViewFormatter to one class per file - change (mediawiki...Flow)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Hygiene: Split RevisionDiffViewFormatter to one class per file
..


Hygiene: Split RevisionDiffViewFormatter to one class per file

Change-Id: I4af741169983b46df6f6210d864b63d7cfe9b752
---
M autoload.php
A includes/Formatter/RevisionDiffViewFormatter.php
M includes/Formatter/RevisionViewFormatter.php
3 files changed, 35 insertions(+), 30 deletions(-)

Approvals:
  Mattflaschen: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/autoload.php b/autoload.php
index 593efa1..98827ca 100644
--- a/autoload.php
+++ b/autoload.php
@@ -159,7 +159,7 @@
'Flow\\Formatter\\RecentChanges' => __DIR__ . 
'/includes/Formatter/RecentChanges.php',
'Flow\\Formatter\\RecentChangesQuery' => __DIR__ . 
'/includes/Formatter/RecentChangesQuery.php',
'Flow\\Formatter\\RecentChangesRow' => __DIR__ . 
'/includes/Formatter/RecentChangesQuery.php',
-   'Flow\\Formatter\\RevisionDiffViewFormatter' => __DIR__ . 
'/includes/Formatter/RevisionViewFormatter.php',
+   'Flow\\Formatter\\RevisionDiffViewFormatter' => __DIR__ . 
'/includes/Formatter/RevisionDiffViewFormatter.php',
'Flow\\Formatter\\RevisionFormatter' => __DIR__ . 
'/includes/Formatter/RevisionFormatter.php',
'Flow\\Formatter\\RevisionViewFormatter' => __DIR__ . 
'/includes/Formatter/RevisionViewFormatter.php',
'Flow\\Formatter\\RevisionViewQuery' => __DIR__ . 
'/includes/Formatter/RevisionViewQuery.php',
diff --git a/includes/Formatter/RevisionDiffViewFormatter.php 
b/includes/Formatter/RevisionDiffViewFormatter.php
new file mode 100644
index 000..8e22000
--- /dev/null
+++ b/includes/Formatter/RevisionDiffViewFormatter.php
@@ -0,0 +1,34 @@
+revisionViewFormatter = $revisionViewFormatter;
+   }
+
+   /**
+* Diff would format against two revisions
+*/
+   public function formatApi( FormatterRow $newRow, FormatterRow $oldRow, 
IContextSource $ctx ) {
+   $oldRes = $this->revisionViewFormatter->formatApi( $oldRow, 
$ctx );
+   $newRes = $this->revisionViewFormatter->formatApi( $newRow, 
$ctx );
+
+   $oldContent = $oldRow->revision->getContent( 'wikitext' );
+   $newContent = $newRow->revision->getContent( 'wikitext' );
+
+   $differenceEngine = new \DifferenceEngine();
+
+   $differenceEngine->setContent(
+   new \TextContent( $oldContent ),
+   new \TextContent( $newContent )
+   );
+
+   return array( 'new' => $newRes, 'old' => $oldRes, 
'diff_content' => $differenceEngine->getDiffBody() );
+   }
+}
diff --git a/includes/Formatter/RevisionViewFormatter.php 
b/includes/Formatter/RevisionViewFormatter.php
index 8a722a0..1a1c148 100644
--- a/includes/Formatter/RevisionViewFormatter.php
+++ b/includes/Formatter/RevisionViewFormatter.php
@@ -118,32 +118,3 @@
}
 
 }
-
-class RevisionDiffViewFormatter {
-
-   protected $revisionViewFormatter;
-
-   public function __construct( RevisionViewFormatter 
$revisionViewFormatter ) {
-   $this->revisionViewFormatter = $revisionViewFormatter;
-   }
-
-   /**
-* Diff would format against two revisions
-*/
-   public function formatApi( FormatterRow $newRow, FormatterRow $oldRow, 
IContextSource $ctx ) {
-   $oldRes = $this->revisionViewFormatter->formatApi( $oldRow, 
$ctx );
-   $newRes = $this->revisionViewFormatter->formatApi( $newRow, 
$ctx );
-
-   $oldContent = $oldRow->revision->getContent( 'wikitext' );
-   $newContent = $newRow->revision->getContent( 'wikitext' );
-
-   $differenceEngine = new \DifferenceEngine();
-
-   $differenceEngine->setContent(
-   new \TextContent( $oldContent ),
-   new \TextContent( $newContent )
-   );
-
-   return array( 'new' => $newRes, 'old' => $oldRes, 
'diff_content' => $differenceEngine->getDiffBody() );
-   }
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/192719
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4af741169983b46df6f6210d864b63d7cfe9b752
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson 
Gerrit-Reviewer: Mattflaschen 
Gerrit-Reviewer: SG 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Dbtree connects to the tendril database, so drop the ganglia... - change (operations/puppet)

[Springle (Code Review)]

Springle has submitted this change and it was merged.

Change subject: Dbtree connects to the tendril database, so drop the ganglia 
job.
..


Dbtree connects to the tendril database, so drop the ganglia job.

Change-Id: I13612b10e02add2168c968224e93ec988a0c9f7d
---
M modules/noc/manifests/init.pp
1 file changed, 1 insertion(+), 8 deletions(-)

Approvals:
  Springle: Looks good to me, approved
  jenkins-bot: Verified
  Dzahn: Looks good to me, but someone else must approve



diff --git a/modules/noc/manifests/init.pp b/modules/noc/manifests/init.pp
index dc6614e..e5c290f 100644
--- a/modules/noc/manifests/init.pp
+++ b/modules/noc/manifests/init.pp
@@ -19,11 +19,4 @@
 monitoring::service { 'http-noc':
 description   => 'HTTP-noc',
 check_command => 
'check_http_url!noc.wikimedia.org!http://noc.wikimedia.org' }
-
-# caches the ganglia xml data from gmetric used by dbtree every minute
-cron { 'dbtree_cache_cron':
-command => "/usr/bin/curl -s 
'http://noc.wikimedia.org/dbtree/?recache=true' >/dev/null",
-user=> 'www-data',
-minute  => '*',
-}
-}
+}
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/193036
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I13612b10e02add2168c968224e93ec988a0c9f7d
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Springle 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Springle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Update OOjs UI to v0.8.1 - change (mediawiki/core)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Update OOjs UI to v0.8.1
..


Update OOjs UI to v0.8.1

Release notes:
 https://git.wikimedia.org/blob/oojs%2Fui.git/v0.8.1/History.md

Change-Id: I5ad8d6aac0fb4ef146ef4f36459e4b0e398a66e8
---
M composer.json
M resources/lib/oojs-ui/oojs-ui-mediawiki.css
M resources/lib/oojs-ui/oojs-ui-mediawiki.js
M resources/lib/oojs-ui/oojs-ui.js
4 files changed, 716 insertions(+), 204 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 7f8c661..d409025 100644
--- a/composer.json
+++ b/composer.json
@@ -19,7 +19,7 @@
"cssjanus/cssjanus": "1.1.1",
"ext-iconv": "*",
"leafo/lessphp": "0.5.0",
-   "oojs/oojs-ui": "0.8.0",
+   "oojs/oojs-ui": "0.8.1",
"php": ">=5.3.3",
"psr/log": "1.0.0",
"wikimedia/cdb": "1.0.1",
diff --git a/resources/lib/oojs-ui/oojs-ui-mediawiki.css 
b/resources/lib/oojs-ui/oojs-ui-mediawiki.css
index cc8fdf5..b70f20a 100644
--- a/resources/lib/oojs-ui/oojs-ui-mediawiki.css
+++ b/resources/lib/oojs-ui/oojs-ui-mediawiki.css
@@ -1,12 +1,12 @@
 /*!
- * OOjs UI v0.8.0
+ * OOjs UI v0.8.1
  * https://www.mediawiki.org/wiki/OOjs_UI
  *
  * Copyright 2011–2015 OOjs Team and other contributors.
  * Released under the MIT license
  * http://oojs.mit-license.org
  *
- * Date: 2015-02-19T01:33:21Z
+ * Date: 2015-02-26T02:10:42Z
  */
 .oo-ui-progressBarWidget-slide-frames from {
margin-left: -40%;
@@ -505,6 +505,7 @@
 }
 .oo-ui-fieldLayout.oo-ui-fieldLayout-align-inline.oo-ui-labelElement > 
.oo-ui-fieldLayout-body > .oo-ui-labelElement-label {
padding: 0.5em;
+   padding-left: 1em;
 }
 .oo-ui-fieldLayout.oo-ui-fieldLayout-align-inline > .oo-ui-fieldLayout-body > 
.oo-ui-fieldLayout-field {
padding: 0.5em 0;
@@ -564,7 +565,8 @@
padding: 0.5em 0.75em;
line-height: 1.5em;
 }
-.oo-ui-fieldsetLayout + .oo-ui-fieldsetLayout {
+.oo-ui-fieldsetLayout + .oo-ui-fieldsetLayout,
+.oo-ui-fieldsetLayout + .oo-ui-formLayout {
margin-top: 2em;
 }
 .oo-ui-fieldsetLayout > .oo-ui-labelElement-label {
@@ -588,6 +590,10 @@
 }
 .oo-ui-fieldsetLayout > .oo-ui-popupButtonWidget:last-child {
margin-right: 0;
+}
+.oo-ui-formLayout + .oo-ui-fieldsetLayout,
+.oo-ui-formLayout + .oo-ui-formLayout {
+   margin-top: 2em;
 }
 .oo-ui-gridLayout {
position: absolute;
@@ -1132,7 +1138,7 @@
 }
 .oo-ui-radioOptionWidget {
cursor: default;
-   padding: 0.25em 0;
+   padding: 0;
background-color: transparent;
 }
 .oo-ui-radioOptionWidget .oo-ui-radioInputWidget,
@@ -1144,6 +1150,13 @@
 .oo-ui-radioOptionWidget.oo-ui-optionWidget-pressed,
 .oo-ui-radioOptionWidget.oo-ui-optionWidget-highlighted {
background-color: transparent;
+}
+.oo-ui-radioOptionWidget.oo-ui-labelElement .oo-ui-labelElement-label {
+   padding: 0.25em;
+   padding-left: 1em;
+}
+.oo-ui-radioOptionWidget .oo-ui-radioInputWidget {
+   margin-right: 0;
 }
 .oo-ui-labelWidget {
display: inline-block;
@@ -1462,8 +1475,8 @@
 }
 .oo-ui-checkboxInputWidget input[type="checkbox"] {
opacity: 0;
-   position: relative;
z-index: 1;
+   position: relative;
margin: 0;
width: 1.6em;
height: 1.6em;
@@ -1471,15 +1484,11 @@
 }
 .oo-ui-checkboxInputWidget input[type="checkbox"] + span {
cursor: pointer;
-   margin: 0 0.2em;
-}
-.oo-ui-checkboxInputWidget input[type="checkbox"] + span::before {
-webkit-transition: background-size 0.2s cubic-bezier(0.175, 0.885, 
0.32, 1.275);
   -moz-transition: background-size 0.2s cubic-bezier(0.175, 0.885, 
0.32, 1.275);
-ms-transition: background-size 0.2s cubic-bezier(0.175, 0.885, 
0.32, 1.275);
 -o-transition: background-size 0.2s cubic-bezier(0.175, 0.885, 
0.32, 1.275);
transition: background-size 0.2s cubic-bezier(0.175, 0.885, 
0.32, 1.275);
-   content: "";
-webkit-box-sizing: border-box;
   -moz-box-sizing: border-box;
box-sizing: border-box;
@@ -1499,26 +1508,26 @@
background-origin: border-box;
background-size: 0 0;
 }
-.oo-ui-checkboxInputWidget input[type="checkbox"]:checked + span::before {
+.oo-ui-checkboxInputWidget input[type="checkbox"]:checked + span {
background-size: 100% 100%;
 }
-.oo-ui-checkboxInputWidget input[type="checkbox"]:active + span::before {
+.oo-ui-checkboxInputWidget input[type="checkbox"]:active + span {
background-color: #dd;
border-color: #dd;
 }
-.oo-ui-checkboxInputWidget input[type="checkbox"]:focus + span::before {
+.oo-ui-checkboxInputWidget input[type="checkbox"]:focus + span {
border-width: 2px;
 }
-.oo-ui-checkboxInputWidget input[type="checkbox"]:focus

[MediaWiki-commits] [Gerrit] Remove obvious function-level profiling - change (mediawiki...Wikibase)

[Hoo man (Code Review)]

Hoo man has submitted this change and it was merged.

Change subject: Remove obvious function-level profiling
..


Remove obvious function-level profiling

There's a few sub-functional wfProfile* calls left, those should
be assessed for removal or conversion into 1.25+ profiling calls

Change-Id: If8874b17a00ff1d61bc74dcbc4c8d62419ba914e
---
M client/WikibaseClient.hooks.php
M client/includes/Changes/ChangeHandler.php
M client/includes/Changes/ChangeRunCoalescer.php
M client/includes/Changes/WikiPageUpdater.php
M client/includes/DataAccess/PropertyParserFunction/Runner.php
M client/includes/Hooks/ParserAfterParseHookHandler.php
M client/includes/Hooks/SidebarHookHandlers.php
M client/includes/Hooks/UpdateRepoHookHandlers.php
M client/includes/InterwikiSorter.php
M client/includes/LangLinkHandler.php
M client/includes/UpdateRepo/UpdateRepo.php
M lib/includes/ChangeNotificationJob.php
M lib/includes/ChangesTable.php
M lib/includes/LanguageFallbackChainFactory.php
M lib/includes/store/CachingEntityRevisionLookup.php
M lib/includes/store/TermPropertyLabelResolver.php
M lib/includes/store/sql/PropertyInfoTable.php
M lib/includes/store/sql/SiteLinkTable.php
M lib/includes/store/sql/SqlEntityInfoBuilder.php
M lib/includes/store/sql/TermSqlIndex.php
M lib/includes/store/sql/WikiPageEntityRevisionLookup.php
M lib/maintenance/dispatchChanges.php
M repo/Wikibase.hooks.php
M repo/includes/BabelUserLanguageLookup.php
M repo/includes/EditEntity.php
M repo/includes/EntityParserOutputGenerator.php
M repo/includes/Hooks/LinkBeginHookHandler.php
M repo/includes/Interactors/RedirectCreationInteractor.php
M repo/includes/LinkedData/EntityDataSerializationService.php
M repo/includes/Notifications/ChangeNotifier.php
M repo/includes/UpdateRepo/UpdateRepoJob.php
M repo/includes/UpdateRepo/UpdateRepoOnDeleteJob.php
M repo/includes/UpdateRepo/UpdateRepoOnMoveJob.php
M repo/includes/Validators/SiteLinkUniquenessValidator.php
M repo/includes/View/ClaimHtmlGenerator.php
M repo/includes/View/EntityTermsView.php
M repo/includes/View/EntityView.php
M repo/includes/View/PropertyView.php
M repo/includes/View/SectionEditLinkGenerator.php
M repo/includes/actions/SubmitEntityAction.php
M repo/includes/api/ApiWikibase.php
M repo/includes/api/CreateClaim.php
M repo/includes/api/CreateRedirectModule.php
M repo/includes/api/EditEntity.php
M repo/includes/api/GetClaims.php
M repo/includes/api/GetEntities.php
M repo/includes/api/LinkTitles.php
M repo/includes/api/MergeItems.php
M repo/includes/api/ModifyEntity.php
M repo/includes/api/RemoveClaims.php
M repo/includes/api/RemoveQualifiers.php
M repo/includes/api/RemoveReferences.php
M repo/includes/api/SearchEntities.php
M repo/includes/api/SetAliases.php
M repo/includes/api/SetClaimValue.php
M repo/includes/api/SetDescription.php
M repo/includes/api/SetLabel.php
M repo/includes/api/SetQualifier.php
M repo/includes/api/SetReference.php
M repo/includes/api/SetSiteLink.php
M repo/includes/content/EntityContent.php
M repo/includes/content/EntityContentFactory.php
M repo/includes/content/ItemContent.php
M repo/includes/store/sql/WikiPageEntityStore.php
64 files changed, 23 insertions(+), 655 deletions(-)

Approvals:
  Hoo man: Verified; Looks good to me, approved



diff --git a/client/WikibaseClient.hooks.php b/client/WikibaseClient.hooks.php
index 1df92f4..9c332c6 100644
--- a/client/WikibaseClient.hooks.php
+++ b/client/WikibaseClient.hooks.php
@@ -89,8 +89,6 @@
 * @return bool
 */
public static function onWikibaseDeleteData( $reportMessage ) {
-   wfProfileIn( __METHOD__ );
-
$store = WikibaseClient::getDefaultInstance()->getStore();
 
$reportMessage( "Deleting data from the " . get_class( $store ) 
. " store..." );
@@ -107,7 +105,6 @@
 
$reportMessage( "done!\n" );
 
-   wfProfileOut( __METHOD__ );
return true;
}
 
@@ -123,8 +120,6 @@
 * @return bool
 */
public static function onWikibaseRebuildData( $reportMessage ) {
-   wfProfileIn( __METHOD__ );
-
$store = WikibaseClient::getDefaultInstance()->getStore();
$reportMessage( "Rebuilding all data in the " . get_class( 
$store )
. " store on the client..." );
@@ -141,7 +136,6 @@
ChangeHandler::singleton()->handleChanges( iterator_to_array( 
$changes ) );
$reportMessage( "done!\n" );
 
-   wfProfileOut( __METHOD__ );
return true;
}
 
@@ -218,15 +212,12 @@
public static function onSpecialRecentChangesQuery( array &$conds, 
array &$tables,
array &$join_conds, FormOptions $opts, array &$query_options, 
array &$fields
) {
-   wfProfileIn( __METHOD__ );
-
$rcFilterOpts = new RecentChangesFilterOptions( $opts );
 
if ( $rcFilterOpts->showWikib

[MediaWiki-commits] [Gerrit] Dbtree connects to the tendril database, so drop the ganglia... - change (operations/puppet)

[Springle (Code Review)]

Springle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193036

Change subject: Dbtree connects to the tendril database, so drop the ganglia 
job.
..

Dbtree connects to the tendril database, so drop the ganglia job.

Change-Id: I13612b10e02add2168c968224e93ec988a0c9f7d
---
M modules/noc/manifests/init.pp
1 file changed, 1 insertion(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/36/193036/1

diff --git a/modules/noc/manifests/init.pp b/modules/noc/manifests/init.pp
index dc6614e..e5c290f 100644
--- a/modules/noc/manifests/init.pp
+++ b/modules/noc/manifests/init.pp
@@ -19,11 +19,4 @@
 monitoring::service { 'http-noc':
 description   => 'HTTP-noc',
 check_command => 
'check_http_url!noc.wikimedia.org!http://noc.wikimedia.org' }
-
-# caches the ganglia xml data from gmetric used by dbtree every minute
-cron { 'dbtree_cache_cron':
-command => "/usr/bin/curl -s 
'http://noc.wikimedia.org/dbtree/?recache=true' >/dev/null",
-user=> 'www-data',
-minute  => '*',
-}
-}
+}
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/193036
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I13612b10e02add2168c968224e93ec988a0c9f7d
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Springle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Update OOjs to v1.1.5 - change (mediawiki/core)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Update OOjs to v1.1.5
..


Update OOjs to v1.1.5

Release notes:
 https://git.wikimedia.org/blob/oojs%2Fcore.git/v1.1.5/History.md

Change-Id: If43d0b4704f95abe4a0438a0d5b0756eb77cc95f
---
M resources/lib/oojs/oojs.jquery.js
1 file changed, 12 insertions(+), 8 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/lib/oojs/oojs.jquery.js 
b/resources/lib/oojs/oojs.jquery.js
index 0b61721..cf5a616 100644
--- a/resources/lib/oojs/oojs.jquery.js
+++ b/resources/lib/oojs/oojs.jquery.js
@@ -1,12 +1,12 @@
 /*!
- * OOjs v1.1.4 optimised for jQuery
+ * OOjs v1.1.5 optimised for jQuery
  * https://www.mediawiki.org/wiki/OOjs
  *
  * Copyright 2011-2015 OOjs Team and other contributors.
  * Released under the MIT license
  * http://oojs.mit-license.org
  *
- * Date: 2015-01-23T20:11:25Z
+ * Date: 2015-02-26T01:51:06Z
  */
 ( function ( global ) {
 
@@ -301,8 +301,12 @@
a = a || {};
b = b || {};
 
+   if ( typeof a.nodeType === 'number' && typeof a.isEqualNode === 
'function' ) {
+   return a.isEqualNode( b );
+   }
+
for ( k in a ) {
-   if ( !hasOwn.call( a, k ) || a[k] === undefined ) {
+   if ( !hasOwn.call( a, k ) || a[k] === undefined || a[k] === 
b[k] ) {
// Support es3-shim: Without the hasOwn filter, 
comparing [] to {} will be false in ES3
// because the shimmed "forEach" is enumerable and 
shows up in Array but not Object.
// Also ignore undefined values, because there is no 
conceptual difference between
@@ -319,7 +323,7 @@
( aType === 'string' || aType === 'number' || 
aType === 'boolean' ) &&
aValue !== bValue
) ||
-   ( aValue === Object( aValue ) && !oo.compare( aValue, 
bValue, asymmetrical ) ) ) {
+   ( aValue === Object( aValue ) && !oo.compare( aValue, 
bValue, true ) ) ) {
return false;
}
}
@@ -622,11 +626,11 @@
 */
oo.EventEmitter.prototype.once = function ( event, listener ) {
var eventEmitter = this,
-   listenerWrapper = function () {
-   eventEmitter.off( event, listenerWrapper );
-   listener.apply( eventEmitter, 
Array.prototype.slice.call( arguments, 0 ) );
+   wrapper = function () {
+   eventEmitter.off( event, wrapper );
+   return listener.apply( this, arguments );
};
-   return this.on( event, listenerWrapper );
+   return this.on( event, wrapper );
};
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/193031
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If43d0b4704f95abe4a0438a0d5b0756eb77cc95f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Jack Phoenix 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Update OOjs UI to v0.8.1 - change (mediawiki/core)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193034

Change subject: Update OOjs UI to v0.8.1
..

Update OOjs UI to v0.8.1

Release notes:
 https://git.wikimedia.org/blob/oojs%2Fui.git/v0.8.1/History.md

Change-Id: I5ad8d6aac0fb4ef146ef4f36459e4b0e398a66e8
---
M composer.json
M resources/lib/oojs-ui/oojs-ui-mediawiki.css
M resources/lib/oojs-ui/oojs-ui-mediawiki.js
M resources/lib/oojs-ui/oojs-ui.js
4 files changed, 716 insertions(+), 204 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/34/193034/1

diff --git a/composer.json b/composer.json
index 7f8c661..d409025 100644
--- a/composer.json
+++ b/composer.json
@@ -19,7 +19,7 @@
"cssjanus/cssjanus": "1.1.1",
"ext-iconv": "*",
"leafo/lessphp": "0.5.0",
-   "oojs/oojs-ui": "0.8.0",
+   "oojs/oojs-ui": "0.8.1",
"php": ">=5.3.3",
"psr/log": "1.0.0",
"wikimedia/cdb": "1.0.1",
diff --git a/resources/lib/oojs-ui/oojs-ui-mediawiki.css 
b/resources/lib/oojs-ui/oojs-ui-mediawiki.css
index cc8fdf5..b70f20a 100644
--- a/resources/lib/oojs-ui/oojs-ui-mediawiki.css
+++ b/resources/lib/oojs-ui/oojs-ui-mediawiki.css
@@ -1,12 +1,12 @@
 /*!
- * OOjs UI v0.8.0
+ * OOjs UI v0.8.1
  * https://www.mediawiki.org/wiki/OOjs_UI
  *
  * Copyright 2011–2015 OOjs Team and other contributors.
  * Released under the MIT license
  * http://oojs.mit-license.org
  *
- * Date: 2015-02-19T01:33:21Z
+ * Date: 2015-02-26T02:10:42Z
  */
 .oo-ui-progressBarWidget-slide-frames from {
margin-left: -40%;
@@ -505,6 +505,7 @@
 }
 .oo-ui-fieldLayout.oo-ui-fieldLayout-align-inline.oo-ui-labelElement > 
.oo-ui-fieldLayout-body > .oo-ui-labelElement-label {
padding: 0.5em;
+   padding-left: 1em;
 }
 .oo-ui-fieldLayout.oo-ui-fieldLayout-align-inline > .oo-ui-fieldLayout-body > 
.oo-ui-fieldLayout-field {
padding: 0.5em 0;
@@ -564,7 +565,8 @@
padding: 0.5em 0.75em;
line-height: 1.5em;
 }
-.oo-ui-fieldsetLayout + .oo-ui-fieldsetLayout {
+.oo-ui-fieldsetLayout + .oo-ui-fieldsetLayout,
+.oo-ui-fieldsetLayout + .oo-ui-formLayout {
margin-top: 2em;
 }
 .oo-ui-fieldsetLayout > .oo-ui-labelElement-label {
@@ -588,6 +590,10 @@
 }
 .oo-ui-fieldsetLayout > .oo-ui-popupButtonWidget:last-child {
margin-right: 0;
+}
+.oo-ui-formLayout + .oo-ui-fieldsetLayout,
+.oo-ui-formLayout + .oo-ui-formLayout {
+   margin-top: 2em;
 }
 .oo-ui-gridLayout {
position: absolute;
@@ -1132,7 +1138,7 @@
 }
 .oo-ui-radioOptionWidget {
cursor: default;
-   padding: 0.25em 0;
+   padding: 0;
background-color: transparent;
 }
 .oo-ui-radioOptionWidget .oo-ui-radioInputWidget,
@@ -1144,6 +1150,13 @@
 .oo-ui-radioOptionWidget.oo-ui-optionWidget-pressed,
 .oo-ui-radioOptionWidget.oo-ui-optionWidget-highlighted {
background-color: transparent;
+}
+.oo-ui-radioOptionWidget.oo-ui-labelElement .oo-ui-labelElement-label {
+   padding: 0.25em;
+   padding-left: 1em;
+}
+.oo-ui-radioOptionWidget .oo-ui-radioInputWidget {
+   margin-right: 0;
 }
 .oo-ui-labelWidget {
display: inline-block;
@@ -1462,8 +1475,8 @@
 }
 .oo-ui-checkboxInputWidget input[type="checkbox"] {
opacity: 0;
-   position: relative;
z-index: 1;
+   position: relative;
margin: 0;
width: 1.6em;
height: 1.6em;
@@ -1471,15 +1484,11 @@
 }
 .oo-ui-checkboxInputWidget input[type="checkbox"] + span {
cursor: pointer;
-   margin: 0 0.2em;
-}
-.oo-ui-checkboxInputWidget input[type="checkbox"] + span::before {
-webkit-transition: background-size 0.2s cubic-bezier(0.175, 0.885, 
0.32, 1.275);
   -moz-transition: background-size 0.2s cubic-bezier(0.175, 0.885, 
0.32, 1.275);
-ms-transition: background-size 0.2s cubic-bezier(0.175, 0.885, 
0.32, 1.275);
 -o-transition: background-size 0.2s cubic-bezier(0.175, 0.885, 
0.32, 1.275);
transition: background-size 0.2s cubic-bezier(0.175, 0.885, 
0.32, 1.275);
-   content: "";
-webkit-box-sizing: border-box;
   -moz-box-sizing: border-box;
box-sizing: border-box;
@@ -1499,26 +1508,26 @@
background-origin: border-box;
background-size: 0 0;
 }
-.oo-ui-checkboxInputWidget input[type="checkbox"]:checked + span::before {
+.oo-ui-checkboxInputWidget input[type="checkbox"]:checked + span {
background-size: 100% 100%;
 }
-.oo-ui-checkboxInputWidget input[type="checkbox"]:active + span::before {
+.oo-ui-checkboxInputWidget input[type="checkbox"]:active + span {
background-color: #dd;
border-color: #dd;
 }
-.oo-ui-checkboxInputWidget input[type="checkbox"]:focus + span::before {
+.oo-ui-checkboxInputWidget input[type="checkbox"]:focus + span {
border-width: 2px;
 }
-.oo-ui-check

[MediaWiki-commits] [Gerrit] Tag v0.8.1 - change (oojs/ui)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Tag v0.8.1
..


Tag v0.8.1

Change-Id: Iac67c6fd9cd335638c6817c824baee2eee0e072d
---
M History.md
M package.json
2 files changed, 62 insertions(+), 4 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/History.md b/History.md
index dba6a53..7ee09ea 100644
--- a/History.md
+++ b/History.md
@@ -1,9 +1,67 @@
 # OOjs UI Release History
 
+## v0.8.1 / 2015-02-25
+* [DEPRECATING CHANGE] Rename setPosition to setLabelPosition (Ed Sanders)
+
+* Element.php: Add "data" property (C. Scott Ananian)
+* Element.php: Add "text" configuration option (C. Scott Ananian)
+* Work around Safari 8 misrendering checkboxes in SVG-only distribution 
(Bartosz Dziewoński)
+* TextInputWidget: Fix appearance of icons and labels when disabled (Ed 
Sanders)
+* Remove '$: this.$' from code examples (Bartosz Dziewoński)
+* Prefer OO.isPlainObject to $.isPlainObject (Bartosz Dziewoński)
+* Error: Fix function name (Bartosz Dziewoński)
+* build: Use grunt-contrib-copy instead of custom 'copy' task (Timo Tijhof)
+* Element.php: Tweak docs (Bartosz Dziewoński)
+* docparser.rb: Ruby 1.9.3 compatibility (Bartosz Dziewoński)
+* Move toggle() from Widget to Element (Moriel Schottlender)
+* build: Include 'lib' and 'dist' in jsduck output (Timo Tijhof)
+* Fix typo: contian → contain (Bartosz Dziewoński)
+* MediaWiki Theme: Drop unnecessary pseudo-element of CheckboxInputWidget 
(Timo Tijhof)
+* MediaWiki Theme: Drop unnecessary pseudo-element of RadioInputWidget (Timo 
Tijhof)
+* MediaWiki theme: Simplify spacing of checkboxes/radios in FieldLayouts 
(Bartosz Dziewoński)
+* Add disabled RadioInputWidget to demo (Bartosz Dziewoński)
+* RadioOptionWidget: Make disabling single options work (Bartosz Dziewoński)
+* composer.json: Add description field (Kunal Mehta)
+* IconElement: Add description for config options (Kirsten Menger-Anderson)
+* IndicatorElement: Add description for configs and static properties (Kirsten 
Menger-Anderson)
+* DraggableElement: Mark private methods and add description to events 
(Kirsten Menger-Anderson)
+* Element: Add description for configs and static property (Kirsten 
Menger-Anderson)
+* LabelElement: Add description, config description, static property 
description (Kirsten Menger-Anderson)
+* TitledElement: Add description and config and static descriptions (Kirsten 
Menger-Anderson)
+* ComboBox: Use combobox role (Derk-Jan Hartman)
+* IconElement: Add description of methods (Kirsten Menger-Anderson)
+* Follow-up bade83bfdfc: actually remove ../ (Roan Kattouw)
+* Remove loop length check (Ed Sanders)
+* PopupButtonWidget: Add description and example and mark private method 
(Kirsten Menger-Anderson)
+* FlaggedElement: Add description of event and config option (Kirsten 
Menger-Anderson)
+* Unbreak docparser.rb (Bartosz Dziewoński)
+* Allow passing positional parameters inside the config object (Bartosz 
Dziewoński)
+* Run JS/PHP comparison tests using karma (Bartosz Dziewoński)
+* test: Reduce timeout in Process test from 100 to 10 (Timo Tijhof)
+* OptionWidget: Add description and descriptions of methods (Kirsten 
Menger-Anderson)
+* FormLayout: Allow adding child layouts via config (Bartosz Dziewoński)
+* Teach docparser about @member, @see, and PHP pass-by-reference (&$foo). (C. 
Scott Ananian)
+* Element: Add `content` config option, matching PHP side. (C. Scott Ananian)
+* SelectWidget: Add description for config, methods, events (Kirsten 
Menger-Anderson)
+* Serialize PHP widget state into data-ooui attribute (C. Scott Ananian)
+* Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS (C. 
Scott Ananian)
+* ButtonSelectWidget: Add description and example (Kirsten Menger-Anderson)
+* RadioOptionWidget: Add description (Kirsten Menger-Anderson)
+* ButtonOptionWidget: Add description (Kirsten Menger-Anderson)
+* RadioSelectWidget: Add description and example (Kirsten Menger-Anderson)
+* Set proper spacing between interleaved FieldsetLayouts and FormLayouts 
(Bartosz Dziewoński)
+* MenuOptionWidget: Add description (Kirsten Menger-Anderson)
+* Unbreak form submission in JavaScript (Bartosz Dziewoński)
+* MenuSelectWidget: Add description and mark protected method (Kirsten 
Menger-Anderson)
+* TabIndexelement: Add description, example, and mark private method (Kirsten 
Menger-Anderson)
+* Add "composer test" command to lint PHP files and run phpcs (Kunal Mehta)
+* Update OOjs to v1.1.5 (James D. Forrester)
+
+
 ## v0.8.0 / 2015-02-18
 * [BREAKING CHANGE] Make default distribution provide SVG with PNG fallback 
(Bartosz Dziewoński)
 
-* DEPRECATION: TextInputWidget: Deprecate 'icon' and 'indicator' events 
(Bartosz Dziewoński)
+* [DEPRECATING CHANGE] TextInputWidget: Deprecate 'icon' and 'indicator' 
events (Bartosz Dziewoński)
 
 * ButtonElement: add protected to event handlers (Kirsten Menger-Anderson)
 * doc

[MediaWiki-commits] [Gerrit] Tag v0.8.1 - change (oojs/ui)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193032

Change subject: Tag v0.8.1
..

Tag v0.8.1

Change-Id: Iac67c6fd9cd335638c6817c824baee2eee0e072d
---
M History.md
M package.json
2 files changed, 62 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/32/193032/1

diff --git a/History.md b/History.md
index dba6a53..7ee09ea 100644
--- a/History.md
+++ b/History.md
@@ -1,9 +1,67 @@
 # OOjs UI Release History
 
+## v0.8.1 / 2015-02-25
+* [DEPRECATING CHANGE] Rename setPosition to setLabelPosition (Ed Sanders)
+
+* Element.php: Add "data" property (C. Scott Ananian)
+* Element.php: Add "text" configuration option (C. Scott Ananian)
+* Work around Safari 8 misrendering checkboxes in SVG-only distribution 
(Bartosz Dziewoński)
+* TextInputWidget: Fix appearance of icons and labels when disabled (Ed 
Sanders)
+* Remove '$: this.$' from code examples (Bartosz Dziewoński)
+* Prefer OO.isPlainObject to $.isPlainObject (Bartosz Dziewoński)
+* Error: Fix function name (Bartosz Dziewoński)
+* build: Use grunt-contrib-copy instead of custom 'copy' task (Timo Tijhof)
+* Element.php: Tweak docs (Bartosz Dziewoński)
+* docparser.rb: Ruby 1.9.3 compatibility (Bartosz Dziewoński)
+* Move toggle() from Widget to Element (Moriel Schottlender)
+* build: Include 'lib' and 'dist' in jsduck output (Timo Tijhof)
+* Fix typo: contian → contain (Bartosz Dziewoński)
+* MediaWiki Theme: Drop unnecessary pseudo-element of CheckboxInputWidget 
(Timo Tijhof)
+* MediaWiki Theme: Drop unnecessary pseudo-element of RadioInputWidget (Timo 
Tijhof)
+* MediaWiki theme: Simplify spacing of checkboxes/radios in FieldLayouts 
(Bartosz Dziewoński)
+* Add disabled RadioInputWidget to demo (Bartosz Dziewoński)
+* RadioOptionWidget: Make disabling single options work (Bartosz Dziewoński)
+* composer.json: Add description field (Kunal Mehta)
+* IconElement: Add description for config options (Kirsten Menger-Anderson)
+* IndicatorElement: Add description for configs and static properties (Kirsten 
Menger-Anderson)
+* DraggableElement: Mark private methods and add description to events 
(Kirsten Menger-Anderson)
+* Element: Add description for configs and static property (Kirsten 
Menger-Anderson)
+* LabelElement: Add description, config description, static property 
description (Kirsten Menger-Anderson)
+* TitledElement: Add description and config and static descriptions (Kirsten 
Menger-Anderson)
+* ComboBox: Use combobox role (Derk-Jan Hartman)
+* IconElement: Add description of methods (Kirsten Menger-Anderson)
+* Follow-up bade83bfdfc: actually remove ../ (Roan Kattouw)
+* Remove loop length check (Ed Sanders)
+* PopupButtonWidget: Add description and example and mark private method 
(Kirsten Menger-Anderson)
+* FlaggedElement: Add description of event and config option (Kirsten 
Menger-Anderson)
+* Unbreak docparser.rb (Bartosz Dziewoński)
+* Allow passing positional parameters inside the config object (Bartosz 
Dziewoński)
+* Run JS/PHP comparison tests using karma (Bartosz Dziewoński)
+* test: Reduce timeout in Process test from 100 to 10 (Timo Tijhof)
+* OptionWidget: Add description and descriptions of methods (Kirsten 
Menger-Anderson)
+* FormLayout: Allow adding child layouts via config (Bartosz Dziewoński)
+* Teach docparser about @member, @see, and PHP pass-by-reference (&$foo). (C. 
Scott Ananian)
+* Element: Add `content` config option, matching PHP side. (C. Scott Ananian)
+* SelectWidget: Add description for config, methods, events (Kirsten 
Menger-Anderson)
+* Serialize PHP widget state into data-ooui attribute (C. Scott Ananian)
+* Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS (C. 
Scott Ananian)
+* ButtonSelectWidget: Add description and example (Kirsten Menger-Anderson)
+* RadioOptionWidget: Add description (Kirsten Menger-Anderson)
+* ButtonOptionWidget: Add description (Kirsten Menger-Anderson)
+* RadioSelectWidget: Add description and example (Kirsten Menger-Anderson)
+* Set proper spacing between interleaved FieldsetLayouts and FormLayouts 
(Bartosz Dziewoński)
+* MenuOptionWidget: Add description (Kirsten Menger-Anderson)
+* Unbreak form submission in JavaScript (Bartosz Dziewoński)
+* MenuSelectWidget: Add description and mark protected method (Kirsten 
Menger-Anderson)
+* TabIndexelement: Add description, example, and mark private method (Kirsten 
Menger-Anderson)
+* Add "composer test" command to lint PHP files and run phpcs (Kunal Mehta)
+* Update OOjs to v1.1.5 (James D. Forrester)
+
+
 ## v0.8.0 / 2015-02-18
 * [BREAKING CHANGE] Make default distribution provide SVG with PNG fallback 
(Bartosz Dziewoński)
 
-* DEPRECATION: TextInputWidget: Deprecate 'icon' and 'indicator' events 
(Bartosz Dziewoński)
+* [DEPRECATING CHANGE] TextInputWidget: Deprecate 'icon' and 'indicator' 
events (Bartosz Dziewoński)
 
 * ButtonElement: add protected to event handle

[MediaWiki-commits] [Gerrit] Update OOjs to v1.1.5 - change (VisualEditor/VisualEditor)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Update OOjs to v1.1.5
..


Update OOjs to v1.1.5

Release notes:
 https://git.wikimedia.org/blob/oojs%2Fcore.git/v1.1.5/History.md

Change-Id: If43d0b4704f95abe4a0438a0d5b0756eb77cc95f
---
M lib/oojs/oojs.jquery.js
1 file changed, 12 insertions(+), 8 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/oojs/oojs.jquery.js b/lib/oojs/oojs.jquery.js
index 0b61721..cf5a616 100644
--- a/lib/oojs/oojs.jquery.js
+++ b/lib/oojs/oojs.jquery.js
@@ -1,12 +1,12 @@
 /*!
- * OOjs v1.1.4 optimised for jQuery
+ * OOjs v1.1.5 optimised for jQuery
  * https://www.mediawiki.org/wiki/OOjs
  *
  * Copyright 2011-2015 OOjs Team and other contributors.
  * Released under the MIT license
  * http://oojs.mit-license.org
  *
- * Date: 2015-01-23T20:11:25Z
+ * Date: 2015-02-26T01:51:06Z
  */
 ( function ( global ) {
 
@@ -301,8 +301,12 @@
a = a || {};
b = b || {};
 
+   if ( typeof a.nodeType === 'number' && typeof a.isEqualNode === 
'function' ) {
+   return a.isEqualNode( b );
+   }
+
for ( k in a ) {
-   if ( !hasOwn.call( a, k ) || a[k] === undefined ) {
+   if ( !hasOwn.call( a, k ) || a[k] === undefined || a[k] === 
b[k] ) {
// Support es3-shim: Without the hasOwn filter, 
comparing [] to {} will be false in ES3
// because the shimmed "forEach" is enumerable and 
shows up in Array but not Object.
// Also ignore undefined values, because there is no 
conceptual difference between
@@ -319,7 +323,7 @@
( aType === 'string' || aType === 'number' || 
aType === 'boolean' ) &&
aValue !== bValue
) ||
-   ( aValue === Object( aValue ) && !oo.compare( aValue, 
bValue, asymmetrical ) ) ) {
+   ( aValue === Object( aValue ) && !oo.compare( aValue, 
bValue, true ) ) ) {
return false;
}
}
@@ -622,11 +626,11 @@
 */
oo.EventEmitter.prototype.once = function ( event, listener ) {
var eventEmitter = this,
-   listenerWrapper = function () {
-   eventEmitter.off( event, listenerWrapper );
-   listener.apply( eventEmitter, 
Array.prototype.slice.call( arguments, 0 ) );
+   wrapper = function () {
+   eventEmitter.off( event, wrapper );
+   return listener.apply( this, arguments );
};
-   return this.on( event, listenerWrapper );
+   return this.on( event, wrapper );
};
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/193030
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If43d0b4704f95abe4a0438a0d5b0756eb77cc95f
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Update OOjs to v1.1.5 - change (oojs/ui)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Update OOjs to v1.1.5
..


Update OOjs to v1.1.5

Release notes:
 https://git.wikimedia.org/blob/oojs%2Fcore.git/v1.1.5/History.md

Change-Id: If43d0b4704f95abe4a0438a0d5b0756eb77cc95f
---
M lib/oojs.jquery.js
1 file changed, 12 insertions(+), 8 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/oojs.jquery.js b/lib/oojs.jquery.js
index 0b61721..cf5a616 100644
--- a/lib/oojs.jquery.js
+++ b/lib/oojs.jquery.js
@@ -1,12 +1,12 @@
 /*!
- * OOjs v1.1.4 optimised for jQuery
+ * OOjs v1.1.5 optimised for jQuery
  * https://www.mediawiki.org/wiki/OOjs
  *
  * Copyright 2011-2015 OOjs Team and other contributors.
  * Released under the MIT license
  * http://oojs.mit-license.org
  *
- * Date: 2015-01-23T20:11:25Z
+ * Date: 2015-02-26T01:51:06Z
  */
 ( function ( global ) {
 
@@ -301,8 +301,12 @@
a = a || {};
b = b || {};
 
+   if ( typeof a.nodeType === 'number' && typeof a.isEqualNode === 
'function' ) {
+   return a.isEqualNode( b );
+   }
+
for ( k in a ) {
-   if ( !hasOwn.call( a, k ) || a[k] === undefined ) {
+   if ( !hasOwn.call( a, k ) || a[k] === undefined || a[k] === 
b[k] ) {
// Support es3-shim: Without the hasOwn filter, 
comparing [] to {} will be false in ES3
// because the shimmed "forEach" is enumerable and 
shows up in Array but not Object.
// Also ignore undefined values, because there is no 
conceptual difference between
@@ -319,7 +323,7 @@
( aType === 'string' || aType === 'number' || 
aType === 'boolean' ) &&
aValue !== bValue
) ||
-   ( aValue === Object( aValue ) && !oo.compare( aValue, 
bValue, asymmetrical ) ) ) {
+   ( aValue === Object( aValue ) && !oo.compare( aValue, 
bValue, true ) ) ) {
return false;
}
}
@@ -622,11 +626,11 @@
 */
oo.EventEmitter.prototype.once = function ( event, listener ) {
var eventEmitter = this,
-   listenerWrapper = function () {
-   eventEmitter.off( event, listenerWrapper );
-   listener.apply( eventEmitter, 
Array.prototype.slice.call( arguments, 0 ) );
+   wrapper = function () {
+   eventEmitter.off( event, wrapper );
+   return listener.apply( this, arguments );
};
-   return this.on( event, listenerWrapper );
+   return this.on( event, wrapper );
};
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/193029
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If43d0b4704f95abe4a0438a0d5b0756eb77cc95f
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Update OOjs to v1.1.5 - change (mediawiki/core)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193031

Change subject: Update OOjs to v1.1.5
..

Update OOjs to v1.1.5

Release notes:
 https://git.wikimedia.org/blob/oojs%2Fcore.git/v1.1.5/History.md

Change-Id: If43d0b4704f95abe4a0438a0d5b0756eb77cc95f
---
M resources/lib/oojs/oojs.jquery.js
1 file changed, 12 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/31/193031/1

diff --git a/resources/lib/oojs/oojs.jquery.js 
b/resources/lib/oojs/oojs.jquery.js
index 0b61721..cf5a616 100644
--- a/resources/lib/oojs/oojs.jquery.js
+++ b/resources/lib/oojs/oojs.jquery.js
@@ -1,12 +1,12 @@
 /*!
- * OOjs v1.1.4 optimised for jQuery
+ * OOjs v1.1.5 optimised for jQuery
  * https://www.mediawiki.org/wiki/OOjs
  *
  * Copyright 2011-2015 OOjs Team and other contributors.
  * Released under the MIT license
  * http://oojs.mit-license.org
  *
- * Date: 2015-01-23T20:11:25Z
+ * Date: 2015-02-26T01:51:06Z
  */
 ( function ( global ) {
 
@@ -301,8 +301,12 @@
a = a || {};
b = b || {};
 
+   if ( typeof a.nodeType === 'number' && typeof a.isEqualNode === 
'function' ) {
+   return a.isEqualNode( b );
+   }
+
for ( k in a ) {
-   if ( !hasOwn.call( a, k ) || a[k] === undefined ) {
+   if ( !hasOwn.call( a, k ) || a[k] === undefined || a[k] === 
b[k] ) {
// Support es3-shim: Without the hasOwn filter, 
comparing [] to {} will be false in ES3
// because the shimmed "forEach" is enumerable and 
shows up in Array but not Object.
// Also ignore undefined values, because there is no 
conceptual difference between
@@ -319,7 +323,7 @@
( aType === 'string' || aType === 'number' || 
aType === 'boolean' ) &&
aValue !== bValue
) ||
-   ( aValue === Object( aValue ) && !oo.compare( aValue, 
bValue, asymmetrical ) ) ) {
+   ( aValue === Object( aValue ) && !oo.compare( aValue, 
bValue, true ) ) ) {
return false;
}
}
@@ -622,11 +626,11 @@
 */
oo.EventEmitter.prototype.once = function ( event, listener ) {
var eventEmitter = this,
-   listenerWrapper = function () {
-   eventEmitter.off( event, listenerWrapper );
-   listener.apply( eventEmitter, 
Array.prototype.slice.call( arguments, 0 ) );
+   wrapper = function () {
+   eventEmitter.off( event, wrapper );
+   return listener.apply( this, arguments );
};
-   return this.on( event, listenerWrapper );
+   return this.on( event, wrapper );
};
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/193031
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If43d0b4704f95abe4a0438a0d5b0756eb77cc95f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Update OOjs to v1.1.5 - change (VisualEditor/VisualEditor)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193030

Change subject: Update OOjs to v1.1.5
..

Update OOjs to v1.1.5

Release notes:
 https://git.wikimedia.org/blob/oojs%2Fcore.git/v1.1.5/History.md

Change-Id: If43d0b4704f95abe4a0438a0d5b0756eb77cc95f
---
M lib/oojs/oojs.jquery.js
1 file changed, 12 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/30/193030/1

diff --git a/lib/oojs/oojs.jquery.js b/lib/oojs/oojs.jquery.js
index 0b61721..cf5a616 100644
--- a/lib/oojs/oojs.jquery.js
+++ b/lib/oojs/oojs.jquery.js
@@ -1,12 +1,12 @@
 /*!
- * OOjs v1.1.4 optimised for jQuery
+ * OOjs v1.1.5 optimised for jQuery
  * https://www.mediawiki.org/wiki/OOjs
  *
  * Copyright 2011-2015 OOjs Team and other contributors.
  * Released under the MIT license
  * http://oojs.mit-license.org
  *
- * Date: 2015-01-23T20:11:25Z
+ * Date: 2015-02-26T01:51:06Z
  */
 ( function ( global ) {
 
@@ -301,8 +301,12 @@
a = a || {};
b = b || {};
 
+   if ( typeof a.nodeType === 'number' && typeof a.isEqualNode === 
'function' ) {
+   return a.isEqualNode( b );
+   }
+
for ( k in a ) {
-   if ( !hasOwn.call( a, k ) || a[k] === undefined ) {
+   if ( !hasOwn.call( a, k ) || a[k] === undefined || a[k] === 
b[k] ) {
// Support es3-shim: Without the hasOwn filter, 
comparing [] to {} will be false in ES3
// because the shimmed "forEach" is enumerable and 
shows up in Array but not Object.
// Also ignore undefined values, because there is no 
conceptual difference between
@@ -319,7 +323,7 @@
( aType === 'string' || aType === 'number' || 
aType === 'boolean' ) &&
aValue !== bValue
) ||
-   ( aValue === Object( aValue ) && !oo.compare( aValue, 
bValue, asymmetrical ) ) ) {
+   ( aValue === Object( aValue ) && !oo.compare( aValue, 
bValue, true ) ) ) {
return false;
}
}
@@ -622,11 +626,11 @@
 */
oo.EventEmitter.prototype.once = function ( event, listener ) {
var eventEmitter = this,
-   listenerWrapper = function () {
-   eventEmitter.off( event, listenerWrapper );
-   listener.apply( eventEmitter, 
Array.prototype.slice.call( arguments, 0 ) );
+   wrapper = function () {
+   eventEmitter.off( event, wrapper );
+   return listener.apply( this, arguments );
};
-   return this.on( event, listenerWrapper );
+   return this.on( event, wrapper );
};
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/193030
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If43d0b4704f95abe4a0438a0d5b0756eb77cc95f
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Update OOjs to v1.1.5 - change (oojs/ui)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193029

Change subject: Update OOjs to v1.1.5
..

Update OOjs to v1.1.5

Release notes:
 https://git.wikimedia.org/blob/oojs%2Fcore.git/v1.1.5/History.md

Change-Id: If43d0b4704f95abe4a0438a0d5b0756eb77cc95f
---
M lib/oojs.jquery.js
1 file changed, 12 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/29/193029/1

diff --git a/lib/oojs.jquery.js b/lib/oojs.jquery.js
index 0b61721..cf5a616 100644
--- a/lib/oojs.jquery.js
+++ b/lib/oojs.jquery.js
@@ -1,12 +1,12 @@
 /*!
- * OOjs v1.1.4 optimised for jQuery
+ * OOjs v1.1.5 optimised for jQuery
  * https://www.mediawiki.org/wiki/OOjs
  *
  * Copyright 2011-2015 OOjs Team and other contributors.
  * Released under the MIT license
  * http://oojs.mit-license.org
  *
- * Date: 2015-01-23T20:11:25Z
+ * Date: 2015-02-26T01:51:06Z
  */
 ( function ( global ) {
 
@@ -301,8 +301,12 @@
a = a || {};
b = b || {};
 
+   if ( typeof a.nodeType === 'number' && typeof a.isEqualNode === 
'function' ) {
+   return a.isEqualNode( b );
+   }
+
for ( k in a ) {
-   if ( !hasOwn.call( a, k ) || a[k] === undefined ) {
+   if ( !hasOwn.call( a, k ) || a[k] === undefined || a[k] === 
b[k] ) {
// Support es3-shim: Without the hasOwn filter, 
comparing [] to {} will be false in ES3
// because the shimmed "forEach" is enumerable and 
shows up in Array but not Object.
// Also ignore undefined values, because there is no 
conceptual difference between
@@ -319,7 +323,7 @@
( aType === 'string' || aType === 'number' || 
aType === 'boolean' ) &&
aValue !== bValue
) ||
-   ( aValue === Object( aValue ) && !oo.compare( aValue, 
bValue, asymmetrical ) ) ) {
+   ( aValue === Object( aValue ) && !oo.compare( aValue, 
bValue, true ) ) ) {
return false;
}
}
@@ -622,11 +626,11 @@
 */
oo.EventEmitter.prototype.once = function ( event, listener ) {
var eventEmitter = this,
-   listenerWrapper = function () {
-   eventEmitter.off( event, listenerWrapper );
-   listener.apply( eventEmitter, 
Array.prototype.slice.call( arguments, 0 ) );
+   wrapper = function () {
+   eventEmitter.off( event, wrapper );
+   return listener.apply( this, arguments );
};
-   return this.on( event, listenerWrapper );
+   return this.on( event, wrapper );
};
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/193029
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If43d0b4704f95abe4a0438a0d5b0756eb77cc95f
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Identifying which extension is complaining about dependency - change (mediawiki...WikiGrok)

[Kaldari (Code Review)]

Kaldari has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193028

Change subject: Identifying which extension is complaining about dependency
..

Identifying which extension is complaining about dependency

Change-Id: Ib5f300c926dfe65ce9ccb6b13d50f4f8dd43ec30
---
M WikiGrok.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiGrok 
refs/changes/28/193028/1

diff --git a/WikiGrok.php b/WikiGrok.php
index bd1917a..bcea139 100644
--- a/WikiGrok.php
+++ b/WikiGrok.php
@@ -27,7 +27,7 @@
 }
 
 if ( !defined( 'MOBILEFRONTEND' ) ) {
-   echo "This MediaWiki extension depends on the MobileFrontend extension. 
Please install it.\n";
+   echo "This MediaWiki extension, WikiGrok, depends on the MobileFrontend 
extension. Please install it.\n";
die( -1 );
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/193028
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5f300c926dfe65ce9ccb6b13d50f4f8dd43ec30
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiGrok
Gerrit-Branch: master
Gerrit-Owner: Kaldari 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Follow-up I18162f04: Send uselang parameter with paction=par... - change (mediawiki...VisualEditor)

[Alex Monk (Code Review)]

Alex Monk has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193027

Change subject: Follow-up I18162f04: Send uselang parameter with paction=parse 
request
..

Follow-up I18162f04: Send uselang parameter with paction=parse request

Change-Id: I70c2e6c448c175ebe9d46c2003499e22a79b28b1
---
M modules/ve-mw/init/ve.init.mw.Target.js
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/27/193027/1

diff --git a/modules/ve-mw/init/ve.init.mw.Target.js 
b/modules/ve-mw/init/ve.init.mw.Target.js
index 0516b1a..78a7cc2 100644
--- a/modules/ve-mw/init/ve.init.mw.Target.js
+++ b/modules/ve-mw/init/ve.init.mw.Target.js
@@ -978,7 +978,8 @@
data = {
action: 'visualeditor',
paction: 'parse',
-   page: this.pageName
+   page: this.pageName,
+   uselang: mw.config.get( 'wgUserLanguage' )
};
 
// Only request the API to explicitly load the currently visible 
revision if we're restoring

-- 
To view, visit https://gerrit.wikimedia.org/r/193027
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I70c2e6c448c175ebe9d46c2003499e22a79b28b1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [WIP] Factor out loading code into TargetLoader - change (mediawiki...VisualEditor)

[Catrope (Code Review)]

Catrope has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193026

Change subject: [WIP] Factor out loading code into TargetLoader
..

[WIP] Factor out loading code into TargetLoader

TODO:
* Write commit summary
* Refactor activate concept into something sensible
* Deal with errors
* Merge onLoad/onReady/onNoticesReady
* Keep CSS transitions etc working
* Find a place to call generateCitationFeatures() from

Change-Id: Ibfa6abbeaf872ae2aadc6ed9d5beba7473ea441a
---
M VisualEditor.hooks.php
M VisualEditor.php
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
M modules/ve-mw/init/ve.init.mw.Target.js
A modules/ve-mw/init/ve.init.mw.TargetLoader.js
6 files changed, 234 insertions(+), 193 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/26/193026/1

diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php
index 13c09ab..2c4b69b 100644
--- a/VisualEditor.hooks.php
+++ b/VisualEditor.hooks.php
@@ -46,7 +46,7 @@
 * @return boolean
 */
public static function onBeforePageDisplay( OutputPage &$output, Skin 
&$skin ) {
-   $output->addModules( array( 
'ext.visualEditor.viewPageTarget.init' ) );
+   $output->addModules( array( 
'ext.visualEditor.viewPageTarget.init', 'ext.visualEditor.targetLoader' ) );
$output->addModuleStyles( array( 
'ext.visualEditor.viewPageTarget.noscript' ) );
return true;
}
diff --git a/VisualEditor.php b/VisualEditor.php
index f2ce216..25b25c4 100644
--- a/VisualEditor.php
+++ b/VisualEditor.php
@@ -183,6 +183,17 @@
'styles' => 
'modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget.noscript.css',
),
 
+   'ext.visualEditor.targetLoader' => $wgVisualEditorResourceTemplate + 
array(
+   'scripts' => 'modules/ve-mw/init/ve.init.mw.TargetLoader.js',
+   'dependencies' => array(
+   'mediawiki.util',
+   'mediawiki.api',
+   'ext.visualEditor.track',
+   'ext.visualEditor.veinitmw',
+   ),
+   'targets' => array( 'desktop', 'mobile' ),
+   ),
+
'ext.visualEditor.viewPageTarget' => $wgVisualEditorResourceTemplate + 
array(
'scripts' => array(

'modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js',
@@ -257,6 +268,18 @@
'targets' => array( 'desktop', 'mobile' ),
),
 
+   'ext.visualEditor.veinit' => $wgVisualEditorResourceTemplate + array(
+   'scripts' => 'lib/ve/src/init/ve.init.js',
+   'dependencies' => 'ext.visualEditor.ve',
+   'targets' => array( 'desktop', 'mobile' ),
+   ),
+
+   'ext.visualEditor.veinitmw' => $wgVisualEditorResourceTemplate + array(
+   'scripts' => 'modules/ve-mw/init/ve.init.mw.js',
+   'dependencies' => 'ext.visualEditor.veinit',
+   'targets' => array( 'desktop', 'mobile' ),
+   ),
+
'ext.visualEditor.base' => $wgVisualEditorResourceTemplate + array(
'scripts' => array(
// ve
@@ -264,7 +287,6 @@
'lib/ve/src/ve.TriggerListener.js',
 
// init
-   'lib/ve/src/init/ve.init.js',
'lib/ve/src/init/ve.init.Platform.js',
'lib/ve/src/init/ve.init.Target.js',
),
@@ -275,7 +297,7 @@
'oojs',
'oojs-ui',
'unicodejs',
-   'ext.visualEditor.ve',
+   'ext.visualEditor.veinit',
),
'targets' => array( 'desktop', 'mobile' ),
),
@@ -283,7 +305,6 @@
'ext.visualEditor.mediawiki' => $wgVisualEditorResourceTemplate + array(
'scripts' => array(
// init
-   'modules/ve-mw/init/ve.init.mw.js',
'modules/ve-mw/init/ve.init.mw.ApiResponseCache.js',
'modules/ve-mw/init/ve.init.mw.LinkCache.js',
'modules/ve-mw/init/ve.init.mw.ImageInfoCache.js',
@@ -296,6 +317,7 @@
'modules/ve-mw/init/styles/ve.init.mw.Target.css',
),
'dependencies' => array(
+   'ext.visualEditor.veinitmw',
'jquery.visibleText',
'jquery.byteLength',
'jquery.client',
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js 
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
index 262cdbc..f298030 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
+++ b/modu

[MediaWiki-commits] [Gerrit] MenuSelectWidget: Add description and mark protected method - change (oojs/ui)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: MenuSelectWidget: Add description and mark protected method
..


MenuSelectWidget: Add description and mark protected method

Change-Id: I9f9b7d6475500329adaa08ea8aa320aae355380b
---
M src/widgets/MenuSelectWidget.js
1 file changed, 17 insertions(+), 4 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/widgets/MenuSelectWidget.js b/src/widgets/MenuSelectWidget.js
index 2ec1f00..24d7e97 100644
--- a/src/widgets/MenuSelectWidget.js
+++ b/src/widgets/MenuSelectWidget.js
@@ -1,10 +1,22 @@
 /**
- * Overlaid menu of options.
+ * MenuSelectWidget is a {@link OO.ui.SelectWidget select widget} that 
contains options and
+ * is used together with OO.ui.MenuOptionWidget. See {@link 
OO.ui.DropdownWidget DropdownWidget} and
+ * {@link OO.ui.ComboBoxWidget ComboBoxWidget} for examples of interfaces that 
contain menus.
+ * MenuSelectWidgets themselves are not designed to be instantiated directly, 
rather subclassed
+ * and customized to be opened, closed, and displayed as needed.
  *
- * Menus are clipped to the visible viewport. They do not provide a control 
for opening or closing
- * the menu.
+ * By default, menus are clipped to the visible viewport and are not visible 
when a user presses the
+ * mouse outside the menu.
  *
- * Use together with OO.ui.MenuOptionWidget.
+ * Menus also have support for keyboard interaction:
+ *
+ * - Enter/Return key: choose and select a menu option
+ * - Up-arrow key: highlight the previous menu option
+ * - Down-arrow key: highlight the next menu option
+ * - Esc key: hide the menu
+ *
+ * Please see the [OOjs UI documentation on MediaWiki][1] for more information.
+ * [1]: https://www.mediawiki.org/wiki/OOjs_UI/Widgets/Selects_and_Options
  *
  * @class
  * @extends OO.ui.SelectWidget
@@ -55,6 +67,7 @@
 /**
  * Handles document mouse down events.
  *
+ * @protected
  * @param {jQuery.Event} e Key down event
  */
 OO.ui.MenuSelectWidget.prototype.onDocumentMouseDown = function ( e ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/193004
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9f9b7d6475500329adaa08ea8aa320aae355380b
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Kmenger 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] TabIndexelement: Add description, example, and mark private ... - change (oojs/ui)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: TabIndexelement: Add description, example, and mark private 
method
..


TabIndexelement: Add description, example, and mark private method

Change-Id: Ie8e247d71148457531e0cfce9885ec33932d0ba1
---
M src/elements/TabIndexedElement.js
1 file changed, 25 insertions(+), 1 deletion(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/elements/TabIndexedElement.js 
b/src/elements/TabIndexedElement.js
index fa1954f..70b3ef9 100644
--- a/src/elements/TabIndexedElement.js
+++ b/src/elements/TabIndexedElement.js
@@ -1,5 +1,28 @@
 /**
- * Element supporting "sequential focus navigation" using the 'tabindex' 
attribute.
+ * The TabIndexedElement class is an attribute mixin used to add additional 
functionality to an
+ * element created by another class. The mixin provides a ‘tabIndex’ property, 
which specifies the
+ * order in which users will navigate through the focusable elements via the 
"tab" key.
+ *
+ * @example
+ * // TabIndexedElement is mixed into the ButtonWidget class
+ * // to provide a tabIndex property.
+ * var button1 = new OO.ui.ButtonWidget( {
+ * label : 'fourth',
+ * tabIndex : 4
+ * } );
+ * var button2 = new OO.ui.ButtonWidget( {
+ * label : 'second',
+ * tabIndex : 2
+ * } );
+ * var button3 = new OO.ui.ButtonWidget( {
+ * label : 'third',
+ * tabIndex : 3
+ * } );
+ * var button4 = new OO.ui.ButtonWidget( {
+ * label : 'first',
+ * tabIndex : 1
+ * } );
+ * $( 'body' ).append( button1.$element, button2.$element, 
button3.$element, button4.$element );
  *
  * @abstract
  * @class
@@ -92,6 +115,7 @@
 /**
  * Handle disable events.
  *
+ * @private
  * @param {boolean} disabled Element is disabled
  */
 OO.ui.TabIndexedElement.prototype.onDisable = function () {

-- 
To view, visit https://gerrit.wikimedia.org/r/193019
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8e247d71148457531e0cfce9885ec33932d0ba1
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Kmenger 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Tag v1.1.5 - change (oojs/core)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Tag v1.1.5
..


Tag v1.1.5

Change-Id: If06eaeb5bd2e42afd68096f31f905de23125697a
---
M AUTHORS.txt
M History.md
M package.json
3 files changed, 15 insertions(+), 3 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  Trevor Parscal: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/AUTHORS.txt b/AUTHORS.txt
index 071b8e9..f5bce10 100644
--- a/AUTHORS.txt
+++ b/AUTHORS.txt
@@ -1,4 +1,8 @@
+Bartosz Dziewoński 
+David Chan 
+Ed Sanders 
+James D. Forrester 
+Ori Livneh 
+Roan Kattouw 
 Timo Tijhof 
 Trevor Parscal 
-Roan Kattouw 
-Ed Sanders 
diff --git a/History.md b/History.md
index a69e9f4..5f2f23c 100644
--- a/History.md
+++ b/History.md
@@ -1,5 +1,13 @@
 # OOjs Release History
 
+## v1.1.5 / 2015-02-25
+* EventEmitter: Remove unneeded Array.prototype.slice call (Timo Tijhof)
+* build: Bump various devDependencies (James D. Forrester)
+* build: Remove unused generateDocs.sh script (Timo Tijhof)
+* Build: Use jquery from npm instead of embedded in the repo (Timo Tijhof)
+* Use Node#isEqualNode to compare node objects (Ori Livneh)
+* Recurse more frugally in oo.compare (David Chan)
+
 ## v1.1.4 / 2015-01-23
 * build: Update devDependencies (James D. Forrester)
 * Consistently use @return annotation (Bartosz Dziewoński)
diff --git a/package.json b/package.json
index 050015b..1104a88 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "oojs",
-  "version": "1.1.4",
+  "version": "1.1.5",
   "description": "Power for object oriented JavaScript libraries.",
   "keywords": [
 "oo",

-- 
To view, visit https://gerrit.wikimedia.org/r/192982
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If06eaeb5bd2e42afd68096f31f905de23125697a
Gerrit-PatchSet: 1
Gerrit-Project: oojs/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Trevor Parscal 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Start walking up before tpl when serializing lists - change (mediawiki...parsoid)

[Arlolra (Code Review)]

Arlolra has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193025

Change subject: Start walking up before tpl when serializing lists
..

Start walking up before tpl when serializing lists

 * If we wait until finding the first child that's not a list before
   getting the list bullets we may reach a list element that has
   template info, in which case we'll fall to template handler and that
   chain will never be walked.

 * This is what's happening on the epitaph in,
 /hewiki/יעקב_משה_חרל"פ?oldid=16519643
   The template only knows about the one colon it has subsumed.

 * Still need to come up with a suitable test case.

Change-Id: Ib1766827237e2a827ec3d40b550450040431a7b3
---
M lib/wts.TagHandlers.js
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid 
refs/changes/25/193025/1

diff --git a/lib/wts.TagHandlers.js b/lib/wts.TagHandlers.js
index bfd7536..d684cd2 100644
--- a/lib/wts.TagHandlers.js
+++ b/lib/wts.TagHandlers.js
@@ -238,7 +238,7 @@
firstChildElt = 
DU.firstNonSepChildNode(firstChildElt);
}
 
-   if (!firstChildElt || ! (firstChildElt.nodeName in 
firstChildNames)) {
+   if (!firstChildElt || !(firstChildElt.nodeName in 
firstChildNames) || DU.isTplOrExtToplevelNode(firstChildElt)) {
cb(getListBullets(node), node);
}
var liHandler = 
state.serializer.wteHandlers.liHandler.bind(state.serializer.wteHandlers, node);
@@ -417,7 +417,7 @@
li: {
handle: function (node, state, cb) {
var firstChildElement = DU.firstNonSepChildNode(node);
-   if (!DU.isList(firstChildElement)) {
+   if (!DU.isList(firstChildElement) || 
DU.isTplOrExtToplevelNode(firstChildElement)) {
cb(getListBullets(node), node);
}
var liHandler = 
state.serializer.wteHandlers.liHandler.bind(state.serializer.wteHandlers, node);
@@ -447,7 +447,7 @@
dt: {
handle: function (node, state, cb) {
var firstChildElement = DU.firstNonSepChildNode(node);
-   if (!DU.isList(firstChildElement)) {
+   if (!DU.isList(firstChildElement) || 
DU.isTplOrExtToplevelNode(firstChildElement)) {
cb(getListBullets(node), node);
}
var liHandler = 
state.serializer.wteHandlers.liHandler.bind(state.serializer.wteHandlers, node);
@@ -475,7 +475,7 @@
dd: {
handle: function (node, state, cb) {
var firstChildElement = DU.firstNonSepChildNode(node);
-   if (!DU.isList(firstChildElement)) {
+   if (!DU.isList(firstChildElement) || 
DU.isTplOrExtToplevelNode(firstChildElement)) {
// XXX: handle stx: row
if ( DU.getDataParsoid( node ).stx === 'row' ) {
cb(':', node);

-- 
To view, visit https://gerrit.wikimedia.org/r/193025
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1766827237e2a827ec3d40b550450040431a7b3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Arlolra 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Follow-up I18162f04: Set contentType: 'multipart/form-data' ... - change (mediawiki...VisualEditor)

[Alex Monk (Code Review)]

Alex Monk has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193024

Change subject: Follow-up I18162f04: Set contentType: 'multipart/form-data' on 
some requests again
..

Follow-up I18162f04: Set contentType: 'multipart/form-data' on some requests 
again

But not all

Change-Id: If9d88bb8d6c532992e8118e504f2fae45c0ca96a
---
M modules/ve-mw/init/ve.init.mw.Target.js
1 file changed, 11 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/24/193024/1

diff --git a/modules/ve-mw/init/ve.init.mw.Target.js 
b/modules/ve-mw/init/ve.init.mw.Target.js
index c96cea9..0516b1a 100644
--- a/modules/ve-mw/init/ve.init.mw.Target.js
+++ b/modules/ve-mw/init/ve.init.mw.Target.js
@@ -1052,13 +1052,16 @@
 
html = EasyDeflate.deflate( this.getHtml( doc ) );
 
-   xhr = new mw.Api().post( {
-   action: 'visualeditor',
-   paction: 'serializeforcache',
-   html: html,
-   page: this.pageName,
-   oldid: this.revid
-   } )
+   xhr = new mw.Api().post(
+   {
+   action: 'visualeditor',
+   paction: 'serializeforcache',
+   html: html,
+   page: this.pageName,
+   oldid: this.revid
+   },
+   { contentType: 'multipart/form-data' }
+   )
.done( function ( response ) {
var trackData = { duration: ve.now() - start };
if ( response.visualeditor && typeof 
response.visualeditor.cachekey === 'string' ) {
@@ -1140,7 +1143,7 @@
// If using the cache key fails, we'll come back here 
with cachekey still set
delete data.cachekey;
}
-   return new mw.Api().post( data )
+   return new mw.Api().post( data, { contentType: 
'multipart/form-data' } )
.then(
function ( response, jqxhr ) {
var eventData = {

-- 
To view, visit https://gerrit.wikimedia.org/r/193024
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If9d88bb8d6c532992e8118e504f2fae45c0ca96a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Allow configuring the transaction locking mode for SQLite - change (mediawiki/core)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Allow configuring the transaction locking mode for SQLite
..


Allow configuring the transaction locking mode for SQLite

Bug: T89180
Change-Id: Ib18347299ea78f9b31e56313b2acf749f693cddb
---
M includes/db/DatabaseSqlite.php
1 file changed, 23 insertions(+), 0 deletions(-)

Approvals:
  Tim Starling: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/db/DatabaseSqlite.php b/includes/db/DatabaseSqlite.php
index 7b04716..0b51972 100644
--- a/includes/db/DatabaseSqlite.php
+++ b/includes/db/DatabaseSqlite.php
@@ -32,6 +32,9 @@
/** @var string File name for SQLite database file */
public $mDatabaseFile;
 
+   /** @var string Transaction mode */
+   protected $trxMode;
+
/** @var int The number of rows affected as an integer */
protected $mAffectedRows;
 
@@ -44,6 +47,11 @@
/** @var FSLockManager (hopefully on the same server as the DB) */
protected $lockMgr;
 
+   /**
+* Additional params include:
+*   - trxMode : one of (deferred, immediate, exclusive)
+* @param array $p
+*/
function __construct( array $p ) {
global $wgSharedDB, $wgSQLiteDataDir;
 
@@ -56,6 +64,12 @@
$this->attachDatabase( $wgSharedDB );
}
}
+   }
+
+   $this->trxMode = isset( $p['trxMode'] ) ? strtoupper( 
$p['trxMode'] ) : null;
+   if ( $this->trxMode && !in_array( $this->trxMode, array( 
'IMMEDIATE', 'EXCLUSIVE' ) ) ) {
+   $this->trxMode = null;
+   wfWarn( "Invalid SQLite transaction mode provided." );
}
 
$this->lockMgr = new FSLockManager( array( 'lockDirectory' => 
"$wgSQLiteDataDir/locks" ) );
@@ -697,6 +711,15 @@
return false;
}
 
+   protected function doBegin( $fname = '' ) {
+   if ( $this->trxMode ) {
+   $this->query( "BEGIN {$this->trxMode}", $fname );
+   } else {
+   $this->query( 'BEGIN', $fname );
+   }
+   $this->mTrxLevel = 1;
+   }
+
/**
 * @param string $s
 * @return string

-- 
To view, visit https://gerrit.wikimedia.org/r/192480
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib18347299ea78f9b31e56313b2acf749f693cddb
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Parent5446 
Gerrit-Reviewer: Tim Starling 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Pull in a cassandra module paging fix - change (mediawiki...deploy)

[GWicke (Code Review)]

GWicke has submitted this change and it was merged.

Change subject: Pull in a cassandra module paging fix
..


Pull in a cassandra module paging fix

Change-Id: Ie163f30dc8dc3cbd2f7dd136790bac7df58e2917
---
M node_modules/istanbul/node_modules/mkdirp/package.json
M node_modules/mocha/node_modules/mkdirp/package.json
M node_modules/restbase-mod-table-cassandra/lib/db.js
M node_modules/restbase-mod-table-cassandra/package.json
4 files changed, 11 insertions(+), 8 deletions(-)

Approvals:
  GWicke: Verified; Looks good to me, approved



diff --git a/node_modules/istanbul/node_modules/mkdirp/package.json 
b/node_modules/istanbul/node_modules/mkdirp/package.json
index a915c51..b7fe466 100644
--- a/node_modules/istanbul/node_modules/mkdirp/package.json
+++ b/node_modules/istanbul/node_modules/mkdirp/package.json
@@ -39,7 +39,7 @@
 "shasum": "1d73076a6df986cd9344e15e71fcc05a4c9abf12",
 "tarball": "http://registry.npmjs.org/mkdirp/-/mkdirp-0.5.0.tgz";
   },
-  "_from": "mkdirp@0.5.0",
+  "_from": "mkdirp@0.5.x",
   "_npmVersion": "1.4.3",
   "_npmUser": {
 "name": "substack",
diff --git a/node_modules/mocha/node_modules/mkdirp/package.json 
b/node_modules/mocha/node_modules/mkdirp/package.json
index a915c51..b7fe466 100644
--- a/node_modules/mocha/node_modules/mkdirp/package.json
+++ b/node_modules/mocha/node_modules/mkdirp/package.json
@@ -39,7 +39,7 @@
 "shasum": "1d73076a6df986cd9344e15e71fcc05a4c9abf12",
 "tarball": "http://registry.npmjs.org/mkdirp/-/mkdirp-0.5.0.tgz";
   },
-  "_from": "mkdirp@0.5.0",
+  "_from": "mkdirp@0.5.x",
   "_npmVersion": "1.4.3",
   "_npmUser": {
 "name": "substack",
diff --git a/node_modules/restbase-mod-table-cassandra/lib/db.js 
b/node_modules/restbase-mod-table-cassandra/lib/db.js
index 11fcdc2..ac9f51d 100644
--- a/node_modules/restbase-mod-table-cassandra/lib/db.js
+++ b/node_modules/restbase-mod-table-cassandra/lib/db.js
@@ -147,9 +147,12 @@
 if (result.meta.pageState) {
 token = 
result.meta.pageState.toString('base64')
 .replace(/\//g,'_').replace(/\+/g,'-')
-// FIXME: use proper hashing
+// FIXME: use proper hashing - this is
+// nonsense.
 // See  
https://phabricator.wikimedia.org/T85640
-+ 
dbu.hashKey(self.conf.salt_key.toString() || 'deadbeef');
++ dbu.hashKey(self.conf.salt_key
+&& self.conf.salt_key.toString()
+|| 'deadbeef');
 }
 resolve({
 items: rows,
diff --git a/node_modules/restbase-mod-table-cassandra/package.json 
b/node_modules/restbase-mod-table-cassandra/package.json
index 724e4a3..524f8ad 100644
--- a/node_modules/restbase-mod-table-cassandra/package.json
+++ b/node_modules/restbase-mod-table-cassandra/package.json
@@ -1,7 +1,7 @@
 {
   "name": "restbase-mod-table-cassandra",
   "description": "RESTBase table storage on Cassandra",
-  "version": "0.4.8",
+  "version": "0.4.9",
   "dependencies": {
 "async": "0.x.x",
 "bluebird": "~2.3.10",
@@ -30,11 +30,11 @@
   },
   "readme": "# [RESTBase](https://github.com/gwicke/restbase) table storage on 
Cassandra\n\nProvides a high-level table storage service abstraction similar to 
Amazon\nDynamoDB or Google DataStore, with a Cassandra backend. See [the 
design\ndocs](https://github.com/gwicke/restbase-cassandra/tree/master/doc) 
for\ndetails and background.\n\nThis is the default table storage backend 
for\n[RESTBase](https://github.com/gwicke/restbase), and automatically 
installed as\nan npm module dependency (`restbase-cassandra`). See the install 
instructions\nthere.\n  \n## Issue tracking\n\nWe use [Phabricator to 
track\nissues](https://phabricator.wikimedia.org/maniphest/task/create/?projects=PHID-PROJ-xdgck5inpvozg2uwmj3f).
 See the [list of current issues in 
RESTBase-cassandra](https://phabricator.wikimedia.org/tag/restbase-cassandra/).\n\n##
 Status\n\nPreparing for production.\n\n[![Build 
Status](https://travis-ci.org/wikimedia/restbase-cassandra.svg?branch=master)](https://travis-ci.org/wikimedia/restbase-cassandra)\n[![coverage
 
status](https://coveralls.io/repos/wikimedia/restbase-cassandra/badge.png)](https://coveralls.io/r/wikimedia/restbase-cassandra)\n\nFeatures:\n-
 basic table storage service with REST interface, backed by Cassandra\n- 
multi-tenant design: domain creation, prepared for per-domain ACLs\n- table 
creation with declarative JSON schemas\n- secondary index creation and basic 
maintenance\n- data insertion and retrieval by primary key, including range 
queries\n\n### Next steps\n- More refined [se

[MediaWiki-commits] [Gerrit] Pull in a cassandra module paging fix - change (mediawiki...deploy)

[GWicke (Code Review)]

GWicke has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193023

Change subject: Pull in a cassandra module paging fix
..

Pull in a cassandra module paging fix

Change-Id: Ie163f30dc8dc3cbd2f7dd136790bac7df58e2917
---
M node_modules/istanbul/node_modules/mkdirp/package.json
M node_modules/mocha/node_modules/mkdirp/package.json
M node_modules/restbase-mod-table-cassandra/lib/db.js
M node_modules/restbase-mod-table-cassandra/package.json
4 files changed, 11 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/restbase/deploy 
refs/changes/23/193023/1

diff --git a/node_modules/istanbul/node_modules/mkdirp/package.json 
b/node_modules/istanbul/node_modules/mkdirp/package.json
index a915c51..b7fe466 100644
--- a/node_modules/istanbul/node_modules/mkdirp/package.json
+++ b/node_modules/istanbul/node_modules/mkdirp/package.json
@@ -39,7 +39,7 @@
 "shasum": "1d73076a6df986cd9344e15e71fcc05a4c9abf12",
 "tarball": "http://registry.npmjs.org/mkdirp/-/mkdirp-0.5.0.tgz";
   },
-  "_from": "mkdirp@0.5.0",
+  "_from": "mkdirp@0.5.x",
   "_npmVersion": "1.4.3",
   "_npmUser": {
 "name": "substack",
diff --git a/node_modules/mocha/node_modules/mkdirp/package.json 
b/node_modules/mocha/node_modules/mkdirp/package.json
index a915c51..b7fe466 100644
--- a/node_modules/mocha/node_modules/mkdirp/package.json
+++ b/node_modules/mocha/node_modules/mkdirp/package.json
@@ -39,7 +39,7 @@
 "shasum": "1d73076a6df986cd9344e15e71fcc05a4c9abf12",
 "tarball": "http://registry.npmjs.org/mkdirp/-/mkdirp-0.5.0.tgz";
   },
-  "_from": "mkdirp@0.5.0",
+  "_from": "mkdirp@0.5.x",
   "_npmVersion": "1.4.3",
   "_npmUser": {
 "name": "substack",
diff --git a/node_modules/restbase-mod-table-cassandra/lib/db.js 
b/node_modules/restbase-mod-table-cassandra/lib/db.js
index 11fcdc2..ac9f51d 100644
--- a/node_modules/restbase-mod-table-cassandra/lib/db.js
+++ b/node_modules/restbase-mod-table-cassandra/lib/db.js
@@ -147,9 +147,12 @@
 if (result.meta.pageState) {
 token = 
result.meta.pageState.toString('base64')
 .replace(/\//g,'_').replace(/\+/g,'-')
-// FIXME: use proper hashing
+// FIXME: use proper hashing - this is
+// nonsense.
 // See  
https://phabricator.wikimedia.org/T85640
-+ 
dbu.hashKey(self.conf.salt_key.toString() || 'deadbeef');
++ dbu.hashKey(self.conf.salt_key
+&& self.conf.salt_key.toString()
+|| 'deadbeef');
 }
 resolve({
 items: rows,
diff --git a/node_modules/restbase-mod-table-cassandra/package.json 
b/node_modules/restbase-mod-table-cassandra/package.json
index 724e4a3..524f8ad 100644
--- a/node_modules/restbase-mod-table-cassandra/package.json
+++ b/node_modules/restbase-mod-table-cassandra/package.json
@@ -1,7 +1,7 @@
 {
   "name": "restbase-mod-table-cassandra",
   "description": "RESTBase table storage on Cassandra",
-  "version": "0.4.8",
+  "version": "0.4.9",
   "dependencies": {
 "async": "0.x.x",
 "bluebird": "~2.3.10",
@@ -30,11 +30,11 @@
   },
   "readme": "# [RESTBase](https://github.com/gwicke/restbase) table storage on 
Cassandra\n\nProvides a high-level table storage service abstraction similar to 
Amazon\nDynamoDB or Google DataStore, with a Cassandra backend. See [the 
design\ndocs](https://github.com/gwicke/restbase-cassandra/tree/master/doc) 
for\ndetails and background.\n\nThis is the default table storage backend 
for\n[RESTBase](https://github.com/gwicke/restbase), and automatically 
installed as\nan npm module dependency (`restbase-cassandra`). See the install 
instructions\nthere.\n  \n## Issue tracking\n\nWe use [Phabricator to 
track\nissues](https://phabricator.wikimedia.org/maniphest/task/create/?projects=PHID-PROJ-xdgck5inpvozg2uwmj3f).
 See the [list of current issues in 
RESTBase-cassandra](https://phabricator.wikimedia.org/tag/restbase-cassandra/).\n\n##
 Status\n\nPreparing for production.\n\n[![Build 
Status](https://travis-ci.org/wikimedia/restbase-cassandra.svg?branch=master)](https://travis-ci.org/wikimedia/restbase-cassandra)\n[![coverage
 
status](https://coveralls.io/repos/wikimedia/restbase-cassandra/badge.png)](https://coveralls.io/r/wikimedia/restbase-cassandra)\n\nFeatures:\n-
 basic table storage service with REST interface, backed by Cassandra\n- 
multi-tenant design: domain creation, prepared for per-domain ACLs\n- table 
creation with declarative JSON schemas\n- secondary index creation and basic 
maintenance\n- data insertion and retrieval

[MediaWiki-commits] [Gerrit] Add "composer test" command to lint PHP files and run phpcs - change (oojs/ui)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Add "composer test" command to lint PHP files and run phpcs
..


Add "composer test" command to lint PHP files and run phpcs

See .

Also add composer.lock to the .gitignore while we're at it.

Change-Id: I950e9981b39fefa57f913ee07061d6985a374681
---
M .gitignore
M composer.json
2 files changed, 12 insertions(+), 0 deletions(-)

Approvals:
  Krinkle: Looks good to me, but someone else must approve
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/.gitignore b/.gitignore
index 1876d1b..2bb2c0a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -6,3 +6,4 @@
 tests/JSPHP-suite.json
 tests/JSPHP.test.js
 vendor
+composer.lock
diff --git a/composer.json b/composer.json
index f7e53fc..0907de1 100644
--- a/composer.json
+++ b/composer.json
@@ -6,8 +6,19 @@
"require": {
"php": ">=5.3.3"
},
+   "require-dev": {
+   "jakub-onderka/php-parallel-lint": "0.8.*",
+   "mediawiki/mediawiki-codesniffer": "0.1.0",
+   "squizlabs/php_codesniffer": "2.1.*"
+   },
"autoload": {
"classmap": ["php/"]
+   },
+   "scripts": {
+   "test": [
+   "parallel-lint . --exclude vendor",
+   "phpcs $PHPCS_ARGS 
--standard=vendor/mediawiki/mediawiki-codesniffer/MediaWiki --ignore=vendor 
--extensions=php,php5,inc -v ."
+   ]
}
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/192272
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I950e9981b39fefa57f913ee07061d6985a374681
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Trevor Parscal 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Made the SQLite installer make a separate objectcache DB - change (mediawiki/core)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Made the SQLite installer make a separate objectcache DB
..


Made the SQLite installer make a separate objectcache DB

* This avoids severe lock contention if CACHE_DB is used and also makes
  cache sharing between wikis simple (keys are always prefixed as needed).

Bug: T89180
Change-Id: I864272af099a9ebe2b3648e2714d2ccdee20305d
---
M includes/installer/SqliteInstaller.php
1 file changed, 55 insertions(+), 7 deletions(-)

Approvals:
  Krinkle: Looks good to me, but someone else must approve
  Tim Starling: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/installer/SqliteInstaller.php 
b/includes/installer/SqliteInstaller.php
index 37fba15..1e7e969 100644
--- a/includes/installer/SqliteInstaller.php
+++ b/includes/installer/SqliteInstaller.php
@@ -226,6 +226,49 @@
}
 
$db = $this->getVar( 'wgDBname' );
+
+   # Make the main and cache stub DB files
+   $status = Status::newGood();
+   $status->merge( $this->makeStubDBFile( $dir, $db ) );
+   $status->merge( $this->makeStubDBFile( $dir, "wikicache" ) );
+   if ( !$status->isOK() ) {
+   return $status;
+   }
+
+   # Nuke the unused settings for clarity
+   $this->setVar( 'wgDBserver', '' );
+   $this->setVar( 'wgDBuser', '' );
+   $this->setVar( 'wgDBpassword', '' );
+   $this->setupSchemaVars();
+
+   # Create the global cache DB
+   try {
+   global $wgSQLiteDataDir;
+   # @todo FIXME: setting globals kind of sucks
+   $wgSQLiteDataDir = $dir;
+   $conn = DatabaseBase::factory( 'sqlite', array( 
'dbname' => "wikicache" ) );
+   # @todo: don't duplicate objectcache definition, though 
it's very simple
+   $sql =
+<query( "CREATE INDEX IF NOT EXISTS exptime ON 
objectcache (exptime)" );
+   $conn->query( "PRAGMA journal_mode=WAL" ); // this is 
permanent
+   $conn->close();
+   } catch ( DBConnectionError $e ) {
+   return Status::newFatal( 
'config-sqlite-connection-error', $e->getMessage() );
+   }
+
+   # Open the main DB
+   return $this->getConnection();
+   }
+
+   protected function makeStubDBFile( $dir, $db ) {
$file = DatabaseSqlite::generateFileName( $dir, $db );
if ( file_exists( $file ) ) {
if ( !is_writable( $file ) ) {
@@ -236,13 +279,8 @@
return Status::newFatal( 
'config-sqlite-cant-create-db', $file );
}
}
-   // nuke the unused settings for clarity
-   $this->setVar( 'wgDBserver', '' );
-   $this->setVar( 'wgDBuser', '' );
-   $this->setVar( 'wgDBpassword', '' );
-   $this->setupSchemaVars();
 
-   return $this->getConnection();
+   return Status::newGood();
}
 
/**
@@ -280,6 +318,16 @@
$dir = LocalSettingsGenerator::escapePhpString( $this->getVar( 
'wgSQLiteDataDir' ) );
 
return "# SQLite-specific settings
-\$wgSQLiteDataDir = \"{$dir}\";";
+\$wgSQLiteDataDir = \"{$dir}\";
+\$wgObjectCaches[CACHE_DB] = array(
+   'class' => 'SqlBagOStuff',
+   'loggroup' => 'SQLBagOStuff',
+   'server' => array(
+   'type' => 'sqlite',
+   'dbname' => 'wikicache',
+   'tablePrefix' => '',
+   'flags' => 0
+   )
+);";
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/192476
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I864272af099a9ebe2b3648e2714d2ccdee20305d
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 
Gerrit-Reviewer: BryanDavis 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Tim Starling 
Gerrit-Reviewer: Waldir 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Mark checkboxes checked - change (mediawiki...MobileFrontend)

[Bmansurov (Code Review)]

Bmansurov has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193022

Change subject: Mark checkboxes checked
..

Mark checkboxes checked

Follow up on Ie8b823be8c316bf07cb19b29cb3e9b2be2407367

Change-Id: Id3b8b0ccc6bb851cd9b3d7bc93f9437b1c9bef84
---
M templates/specials/checkbox.mustache
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/22/193022/1

diff --git a/templates/specials/checkbox.mustache 
b/templates/specials/checkbox.mustache
index 3595493..8baf0ac 100644
--- a/templates/specials/checkbox.mustache
+++ b/templates/specials/checkbox.mustache
@@ -1,6 +1,6 @@
 

-   
+   

{{label}}


-- 
To view, visit https://gerrit.wikimedia.org/r/193022
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3b8b0ccc6bb851cd9b3d7bc93f9437b1c9bef84
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Update dependencies - change (mediawiki...deploy)

[GWicke (Code Review)]

GWicke has submitted this change and it was merged.

Change subject: Update dependencies
..


Update dependencies

Change-Id: I4266db5c571579c49116ac5aff071741041efafd
---
M node_modules/istanbul/node_modules/mkdirp/package.json
M node_modules/mocha/node_modules/mkdirp/package.json
M node_modules/restbase-mod-table-cassandra/lib/db.js
D node_modules/restbase-mod-table-cassandra/node_modules/.bin/report-latency
D node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/LICENSE
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/README.md
D node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/index.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/LICENSE
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/README.md
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/deps/encoding/encoding-indexes.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/deps/encoding/encoding.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/lib/main.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/lib/types/multipart.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/lib/types/urlencoded.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/lib/utils.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/LICENSE
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/README.md
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/bench/dicer-bench-multipart-parser.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/bench/formidable-bench-multipart-parser.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/bench/multipartser-bench-multipart-parser.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/bench/multiparty-bench-multipart-parser.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/bench/parted-bench-multipart-parser.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/bench/parted-multipart.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/lib/Dicer.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/lib/HeaderParser.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/lib/PartStream.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/node_modules/streamsearch/LICENSE
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/node_modules/streamsearch/README.md
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/node_modules/streamsearch/lib/sbmh.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/node_modules/streamsearch/package.json
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/package.json
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/test/fixtures/many/original
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/test/fixtures/many/part1
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/test/fixtures/many/part1.header
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/test/fixtures/many/part2
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/test/fixtures/many/part2.header
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/test/fixtures/many/part3
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/test/fixtures/many/part3.header
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/test/fixtures/many/part4
D 
n

[MediaWiki-commits] [Gerrit] Update dependencies - change (mediawiki...deploy)

[GWicke (Code Review)]

GWicke has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193021

Change subject: Update dependencies
..

Update dependencies

Change-Id: I4266db5c571579c49116ac5aff071741041efafd
---
M node_modules/istanbul/node_modules/mkdirp/package.json
M node_modules/mocha/node_modules/mkdirp/package.json
M node_modules/restbase-mod-table-cassandra/lib/db.js
D node_modules/restbase-mod-table-cassandra/node_modules/.bin/report-latency
D node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/LICENSE
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/README.md
D node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/index.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/LICENSE
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/README.md
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/deps/encoding/encoding-indexes.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/deps/encoding/encoding.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/lib/main.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/lib/types/multipart.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/lib/types/urlencoded.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/lib/utils.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/LICENSE
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/README.md
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/bench/dicer-bench-multipart-parser.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/bench/formidable-bench-multipart-parser.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/bench/multipartser-bench-multipart-parser.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/bench/multiparty-bench-multipart-parser.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/bench/parted-bench-multipart-parser.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/bench/parted-multipart.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/lib/Dicer.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/lib/HeaderParser.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/lib/PartStream.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/node_modules/streamsearch/LICENSE
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/node_modules/streamsearch/README.md
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/node_modules/streamsearch/lib/sbmh.js
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/node_modules/streamsearch/package.json
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/package.json
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/test/fixtures/many/original
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/test/fixtures/many/part1
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/test/fixtures/many/part1.header
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/test/fixtures/many/part2
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/test/fixtures/many/part2.header
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/test/fixtures/many/part3
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/dicer/test/fixtures/many/part3.header
D 
node_modules/restbase-mod-table-cassandra/node_modules/connect-busboy/node_modules/busboy/node_modules/di

[MediaWiki-commits] [Gerrit] Localisation updates from https://translatewiki.net. - change (apps...wikipedia)

[BearND (Code Review)]

BearND has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193020

Change subject: Localisation updates from https://translatewiki.net.
..

Localisation updates from https://translatewiki.net.

Change-Id: I4a734b29fc70dc90c3dce0eafa8862d16891b68c
---
M wikipedia/res/values-ak/strings.xml
M wikipedia/res/values-ar/strings.xml
M wikipedia/res/values-av/strings.xml
M wikipedia/res/values-bn/strings.xml
M wikipedia/res/values-br/strings.xml
M wikipedia/res/values-ca/strings.xml
M wikipedia/res/values-ce/strings.xml
M wikipedia/res/values-cs/strings.xml
M wikipedia/res/values-cy/strings.xml
M wikipedia/res/values-da/strings.xml
M wikipedia/res/values-de/strings.xml
M wikipedia/res/values-el/strings.xml
M wikipedia/res/values-eo/strings.xml
M wikipedia/res/values-es/strings.xml
M wikipedia/res/values-et/strings.xml
M wikipedia/res/values-eu/strings.xml
M wikipedia/res/values-fa/strings.xml
M wikipedia/res/values-fi/strings.xml
M wikipedia/res/values-fo/strings.xml
M wikipedia/res/values-fr/strings.xml
M wikipedia/res/values-gl/strings.xml
M wikipedia/res/values-he/strings.xml
M wikipedia/res/values-hi/strings.xml
M wikipedia/res/values-hu/strings.xml
A wikipedia/res/values-in/strings.xml
M wikipedia/res/values-it/strings.xml
M wikipedia/res/values-ja/strings.xml
A wikipedia/res/values-ji/strings.xml
M wikipedia/res/values-ka/strings.xml
M wikipedia/res/values-km/strings.xml
M wikipedia/res/values-ko/strings.xml
M wikipedia/res/values-kw/strings.xml
M wikipedia/res/values-ky/strings.xml
M wikipedia/res/values-lb/strings.xml
M wikipedia/res/values-lt/strings.xml
M wikipedia/res/values-mk/strings.xml
M wikipedia/res/values-ml/strings.xml
M wikipedia/res/values-mn/strings.xml
M wikipedia/res/values-mr/strings.xml
M wikipedia/res/values-ms/strings.xml
M wikipedia/res/values-my/strings.xml
M wikipedia/res/values-nb/strings.xml
M wikipedia/res/values-nl/strings.xml
M wikipedia/res/values-oc/strings.xml
M wikipedia/res/values-pa/strings.xml
M wikipedia/res/values-pl/strings.xml
M wikipedia/res/values-pt-rBR/strings.xml
M wikipedia/res/values-pt/strings.xml
M wikipedia/res/values-qq/strings.xml
M wikipedia/res/values-ro/strings.xml
M wikipedia/res/values-ru/strings.xml
M wikipedia/res/values-sk/strings.xml
M wikipedia/res/values-sr/strings.xml
M wikipedia/res/values-sv/strings.xml
M wikipedia/res/values-ta/strings.xml
M wikipedia/res/values-tr/strings.xml
M wikipedia/res/values-uk/strings.xml
M wikipedia/res/values-uz/strings.xml
M wikipedia/res/values-vi/strings.xml
M wikipedia/res/values-zh-rTW/strings.xml
M wikipedia/res/values-zh/strings.xml
61 files changed, 799 insertions(+), 1,853 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/20/193020/1


-- 
To view, visit https://gerrit.wikimedia.org/r/193020
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a734b29fc70dc90c3dce0eafa8862d16891b68c
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: BearND 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Enable WikiGrok on wikidatawiki - change (operations/mediawiki-config)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Enable WikiGrok on wikidatawiki
..


Enable WikiGrok on wikidatawiki

Change-Id: Iee79d967426af9539525dd73b0cd5c5a553444e5
---
M wmf-config/InitialiseSettings.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 9de85d9..92b80df 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -12633,6 +12633,7 @@
'test2wiki' => true,
'testwiki' => true,
'enwiki' => true,
+   'wikidatawiki' => true,
'testwikidatawiki' => true,
 ),
 'wmgWikiGrokRepoMode' => array(

-- 
To view, visit https://gerrit.wikimedia.org/r/193018
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iee79d967426af9539525dd73b0cd5c5a553444e5
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: MaxSem 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Create oojs-ui-composer job, get rid of legacy oojs-ui-phpcs... - change (integration/config)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Create oojs-ui-composer job, get rid of legacy 
oojs-ui-phpcs-HEAD
..


Create oojs-ui-composer job, get rid of legacy oojs-ui-phpcs-HEAD

Change-Id: If1e8eab864ec2726afd36ac4565a9c30193a32f0
---
M jjb/misc.yaml
M zuul/layout.yaml
2 files changed, 4 insertions(+), 5 deletions(-)

Approvals:
  Krinkle: Looks good to me, but someone else must approve
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/jjb/misc.yaml b/jjb/misc.yaml
index 8443231..1fc6be8 100644
--- a/jjb/misc.yaml
+++ b/jjb/misc.yaml
@@ -78,7 +78,7 @@
  - '{name}-jslint'
  - '{name}-npm'
  - '{name}-phplint'
- - '{name}-phpcs-HEAD'
+ - '{name}-composer'
  - '{name}-bundle-{bundlecommand}':
  bundlecommand:
   - rubocop
diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 7ffb33d..a654055 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -6196,18 +6196,17 @@
   - oojs-ui-jslint
   - oojs-ui-phplint
   - oojs-ui-ruby2.0lint
+  - php-composer-validate
 test:
   - oojs-ui-bundle-rubocop
   - oojs-ui-npm
-  - oojs-ui-phplint
-  - oojs-ui-phpcs-HEAD
+  - oojs-ui-composer
   - oojs-ui-jsduck
   - oojs-ui-ruby2.0lint
 gate-and-submit:
   - oojs-ui-bundle-rubocop
   - oojs-ui-npm
-  - oojs-ui-phplint
-  - oojs-ui-phpcs-HEAD
+  - oojs-ui-composer
   - oojs-ui-jsduck
   - oojs-ui-ruby2.0lint
 postmerge:

-- 
To view, visit https://gerrit.wikimedia.org/r/192772
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If1e8eab864ec2726afd36ac4565a9c30193a32f0
Gerrit-PatchSet: 2
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Hygiene: Use server side templating for checkbox generation - change (mediawiki...MobileFrontend)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Hygiene: Use server side templating for checkbox generation
..


Hygiene: Use server side templating for checkbox generation

Hogan templates render perfectly fine in Mustache so lets use the same
template on both server side and client side.

Changes:
* Standardise template variable names.
* Correct template issue with $ in process.
Change-Id: Ie8b823be8c316bf07cb19b29cb3e9b2be2407367
---
M includes/Resources.php
M includes/specials/SpecialMobileOptions.php
M javascripts/specials/mobileoptions.js
D templates/specials/checkbox.hogan
A templates/specials/checkbox.mustache
5 files changed, 16 insertions(+), 18 deletions(-)

Approvals:
  Bmansurov: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Resources.php b/includes/Resources.php
index 6215f80..77ce766 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -1354,7 +1354,7 @@
'javascripts/specials/mobileoptions.js',
),
'templates' => array(
-   'Checkbox.hogan' => 'templates/specials/checkbox.hogan',
+   'Checkbox.hogan' => 
'templates/specials/checkbox.mustache',
),
'messages' => array(
'mobile-frontend-expand-sections-description',
diff --git a/includes/specials/SpecialMobileOptions.php 
b/includes/specials/SpecialMobileOptions.php
index 7f4f14c..454ed22 100644
--- a/includes/specials/SpecialMobileOptions.php
+++ b/includes/specials/SpecialMobileOptions.php
@@ -136,6 +136,7 @@
}
}
 
+   $templateParser = new TemplateParser( __DIR__ 
.'/../../templates/specials' );
// @codingStandardsIgnoreStart Long line
foreach( $options as $key => $data ) {
if ( isset( $data['type'] ) && $data['type'] === 
'hidden' ) {
@@ -147,10 +148,7 @@
)
);
} else {
-   $html .= Html::openElement( 'div', array( 
'class' => 'mobileoption' ) ) .
-   Xml::checkLabel( $data['label'], 
$data['name'], $data['id'], $data['checked'] ) .
-   Html::element( 'div', array( 'class' => 
'option-description' ), $data['description'] ) .
-   Html::closeElement( 'div' );
+   $html .= $templateParser->processTemplate( 
'checkbox', $data );
}
}
$className = MobileUI::buttonClass( 'constructive' );
diff --git a/javascripts/specials/mobileoptions.js 
b/javascripts/specials/mobileoptions.js
index 6fac00a..2e3b43b 100644
--- a/javascripts/specials/mobileoptions.js
+++ b/javascripts/specials/mobileoptions.js
@@ -39,8 +39,8 @@
if ( context.isAlphaGroupMember() ) {
cb = new Checkbox( {
name: 'expandSections',
-   enableMsg: mw.msg( 
'mobile-frontend-expand-sections-status' ),
-   descriptionMsg: mw.msg( 
'mobile-frontend-expand-sections-description' )
+   label: mw.msg( 
'mobile-frontend-expand-sections-status' ),
+   description: mw.msg( 
'mobile-frontend-expand-sections-description' )
} );
cb.insertBefore( saveLI );
}
diff --git a/templates/specials/checkbox.hogan 
b/templates/specials/checkbox.hogan
deleted file mode 100644
index 8899c78..000
--- a/templates/specials/checkbox.hogan
+++ /dev/null
@@ -1,11 +0,0 @@
-
-   
-   
-   
-   {{enableMsg}}
-   
-   
-   
-   {{descriptionMsg}}
-   
-
diff --git a/templates/specials/checkbox.mustache 
b/templates/specials/checkbox.mustache
new file mode 100644
index 000..3595493
--- /dev/null
+++ b/templates/specials/checkbox.mustache
@@ -0,0 +1,11 @@
+
+   
+   
+   
+   {{label}}
+   
+   
+   
+   {{description}}
+   
+

-- 
To view, visit https://gerrit.wikimedia.org/r/192961
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8b823be8c316bf07cb19b29cb3e9b2be2407367
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 
Gerrit-Reviewer: Bmansurov 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Update Wikidata to fix EntityViewPlaceholderExpander - change (mediawiki/core)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Update Wikidata to fix EntityViewPlaceholderExpander
..


Update Wikidata to fix EntityViewPlaceholderExpander

42c8abc6dc5673ee4051dd2c0d38989a24982130

Change-Id: I532f45064b73df216fa026a8bb65d367895e80cd
---
M extensions/Wikidata
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Hoo man: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/extensions/Wikidata b/extensions/Wikidata
index c6f8383..42c8abc 16
--- a/extensions/Wikidata
+++ b/extensions/Wikidata
-Subproject commit c6f838385a0f8d8740384fe9fdea4fe3f9c508ed
+Subproject commit 42c8abc6dc5673ee4051dd2c0d38989a24982130

-- 
To view, visit https://gerrit.wikimedia.org/r/192994
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I532f45064b73df216fa026a8bb65d367895e80cd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.25wmf19
Gerrit-Owner: Hoo man 
Gerrit-Reviewer: Hoo man 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] TabIndexelement: Add description, example, and mark private ... - change (oojs/ui)

[Kmenger (Code Review)]

Kmenger has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193019

Change subject: TabIndexelement: Add description, example, and mark private 
method
..

TabIndexelement: Add description, example, and mark private method

Change-Id: Ie8e247d71148457531e0cfce9885ec33932d0ba1
---
M src/elements/TabIndexedElement.js
1 file changed, 25 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/19/193019/1

diff --git a/src/elements/TabIndexedElement.js 
b/src/elements/TabIndexedElement.js
index fa1954f..70b3ef9 100644
--- a/src/elements/TabIndexedElement.js
+++ b/src/elements/TabIndexedElement.js
@@ -1,5 +1,28 @@
 /**
- * Element supporting "sequential focus navigation" using the 'tabindex' 
attribute.
+ * The TabIndexedElement class is an attribute mixin used to add additional 
functionality to an
+ * element created by another class. The mixin provides a ‘tabIndex’ property, 
which specifies the
+ * order in which users will navigate through the focusable elements via the 
"tab" key.
+ *
+ * @example
+ * // TabIndexedElement is mixed into the ButtonWidget class
+ * // to provide a tabIndex property.
+ * var button1 = new OO.ui.ButtonWidget( {
+ * label : 'fourth',
+ * tabIndex : 4
+ * } );
+ * var button2 = new OO.ui.ButtonWidget( {
+ * label : 'second',
+ * tabIndex : 2
+ * } );
+ * var button3 = new OO.ui.ButtonWidget( {
+ * label : 'third',
+ * tabIndex : 3
+ * } );
+ * var button4 = new OO.ui.ButtonWidget( {
+ * label : 'first',
+ * tabIndex : 1
+ * } );
+ * $( 'body' ).append( button1.$element, button2.$element, 
button3.$element, button4.$element );
  *
  * @abstract
  * @class
@@ -92,6 +115,7 @@
 /**
  * Handle disable events.
  *
+ * @private
  * @param {boolean} disabled Element is disabled
  */
 OO.ui.TabIndexedElement.prototype.onDisable = function () {

-- 
To view, visit https://gerrit.wikimedia.org/r/193019
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8e247d71148457531e0cfce9885ec33932d0ba1
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Kmenger 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Enable WikiGrok on wikidatawiki - change (operations/mediawiki-config)

[MaxSem (Code Review)]

MaxSem has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193018

Change subject: Enable WikiGrok on wikidatawiki
..

Enable WikiGrok on wikidatawiki

Change-Id: Iee79d967426af9539525dd73b0cd5c5a553444e5
---
M wmf-config/InitialiseSettings.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/18/193018/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 9de85d9..92b80df 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -12633,6 +12633,7 @@
'test2wiki' => true,
'testwiki' => true,
'enwiki' => true,
+   'wikidatawiki' => true,
'testwikidatawiki' => true,
 ),
 'wmgWikiGrokRepoMode' => array(

-- 
To view, visit https://gerrit.wikimedia.org/r/193018
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee79d967426af9539525dd73b0cd5c5a553444e5
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: MaxSem 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove all images and recent uploads from UserProfile - change (mediawiki...MobileFrontend)

[Deskana (Code Review)]

Deskana has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193017

Change subject: Remove all images and recent uploads from UserProfile
..

Remove all images and recent uploads from UserProfile

This patch removes all images and recent uploads from UserProfile. They're
more trouble than they're worth.

Bug: T90801
Change-Id: Ic6800431a382c022d92a79043c76bbe441528ae6
---
M includes/specials/SpecialUserProfile.php
1 file changed, 1 insertion(+), 41 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/17/193017/1

diff --git a/includes/specials/SpecialUserProfile.php 
b/includes/specials/SpecialUserProfile.php
index 6779513..fc4a730 100644
--- a/includes/specials/SpecialUserProfile.php
+++ b/includes/specials/SpecialUserProfile.php
@@ -39,39 +39,6 @@
}
 
/**
-* Returns HTML to show the last upload or an empty string when there 
has been no last upload
-*
-* @return String HTML string representing the last upload by the user
-*/
-   protected function getLastUploadHtml() {
-   $file = $this->userInfo->getLastUpload();
-   if ( !$file ) {
-   return '';
-   }
-
-   $title = $file->getTitle();
-   $ts = new MWTimestamp( $file->getTimestamp() );
-   $daysAgo = $this->getDaysAgo( $ts );
-   $page = new MobilePage( $title, $file );
-   $img = Html::openElement( 'div', array( 'class' => 'card' ) ) .
-   Html::openElement( 'a', array(
-   'class' => 'container image',
-   'href' => $title->getLocalUrl() )
-   ) .
-   $page->getMediumThumbnailHtml() .
-   Html::openElement( 'div', array( 'class' => 'caption' ) 
) .
-   $this->msg( 
'mobile-frontend-profile-last-upload-caption' )
-   ->numParams( $daysAgo ) // $1
-   ->params( $this->targetUser->getName() ) // $2
-   ->parse() .
-   Html::closeElement( 'div' ) .
-   Html::closeElement( 'a' ) .
-   Html::closeElement( 'div' );
-
-   return $img;
-   }
-
-   /**
 * Returns HTML to show the last thanking or an empty string if the 
user has never been thanked
 *
 * @return String HTML string representing the last thank by the user
@@ -107,14 +74,8 @@
if ( $rev ) {
$daysAgo = $this->getDaysAgo( new MWTimestamp( 
wfTimestamp( TS_UNIX, $rev->getTimestamp() ) ) );
$page = new MobilePage( $rev->getTitle() );
-   if ( $page->hasThumbnail() ) {
-   $thumbnail = $page->getMediumThumbnailHtml();
-   } else {
-   $thumbnail = 
$page->getPlaceHolderThumbnailHtml( 'list-thumb-edit' );
-   }
$html = Html::openElement( 'div', array( 'class' => 
'card' ) )
. Html::openElement( 'div', array( 'class' => 
'container image' ) )
-   . $thumbnail
. Html::openElement( 'div', array( 'class' => 
'caption' ) )
. $this->msg( 
'mobile-frontend-profile-last-edit',
$rev->getTitle(),
@@ -233,8 +194,7 @@
 
// Prepare content
$this->userInfo = new MobileUserInfo( 
$this->targetUser );
-   $activityHtml = $this->getLastEditHtml() . 
$this->getLastUploadHtml()
-   . $this->getLastThanksHtml();
+   $activityHtml = $this->getLastEditHtml() . 
$this->getLastThanksHtml();
 
$html = Html::openElement( 'div', array( 
'class' => 'profile content' ) );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/193017
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6800431a382c022d92a79043c76bbe441528ae6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Deskana 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Enable NewUserMessage extension with for fawiktionary - change (operations/mediawiki-config)

[Mjbmr (Code Review)]

Mjbmr has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193016

Change subject: Enable NewUserMessage extension with for fawiktionary
..

Enable NewUserMessage extension with for fawiktionary

Bug: T90831
Change-Id: Iec863d0ea1f9dfcb1f913f2176fd6dbb18dce332
---
M wmf-config/InitialiseSettings.php
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/16/193016/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 9de85d9..5d81d1a 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -10863,6 +10863,7 @@
'fawiki' => true, // Bug 53981
'fawikinews' => true,
'fawikivoyage' => true, // T76716
+   'fawiktionary' => true, // T90831
'guwiki' => true, // Bug 40872
'guwikisource' => true, // Bug 40872
'hiwiki' => true,
@@ -10899,6 +10900,7 @@
'enwikinews' => true,
'fawikinews' => true,
'fawikivoyage' => true, // T76716
+   'fawiktionary' => true, // T90831
'guwiki' => true, // Bug 40872
'guwikisource' => true, // Bug 40872
'hiwiki' => true,

-- 
To view, visit https://gerrit.wikimedia.org/r/193016
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec863d0ea1f9dfcb1f913f2176fd6dbb18dce332
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Mjbmr 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Hijack watchstar behaviour in alpha - change (mediawiki...Gather)

[Jdlrobson (Code Review)]

Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193015

Change subject: Hijack watchstar behaviour in alpha
..

Hijack watchstar behaviour in alpha

Note: This doesn't override search watchstar. Not sure how best
to do that.

Dependency: I00d83f28f88cd3ae63a0858b7b48c5765fe35c20
Change-Id: Iac6df0166e12a19acbce44aa23f201ce4e050ce8
---
M Gather.php
M includes/Gather.hooks.php
M includes/Resources.php
A resources/ext.gather.watchstar/init.js
4 files changed, 14 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gather 
refs/changes/15/193015/1

diff --git a/Gather.php b/Gather.php
index 87bd2eb..a0fd271 100644
--- a/Gather.php
+++ b/Gather.php
@@ -72,6 +72,7 @@
 $wgHooks['MobilePersonalTools'][] = 'Gather\Hooks::onMobilePersonalTools';
 $wgHooks['UnitTestsList'][] = 'Gather\Hooks::onUnitTestsList';
 $wgHooks['getUserPermissionsErrors'][] = 
'Gather\Hooks::onGetUserPermissionsErrors';
+$wgHooks['SkinMinervaDefaultModules'][] = 
'Gather\Hooks::onSkinMinervaDefaultModules';
 
 // ResourceLoader modules
 require_once __DIR__ . "/includes/Resources.php";
diff --git a/includes/Gather.hooks.php b/includes/Gather.hooks.php
index 143b023..b7e15eb 100644
--- a/includes/Gather.hooks.php
+++ b/includes/Gather.hooks.php
@@ -26,6 +26,13 @@
die( -1 );
}
}
+
+   public static function onSkinMinervaDefaultModules( $skin, &$modules ) {
+   if ( MobileContext::singleton()->isAlphaGroupMember() ) {
+   $modules['watch'] = array( 'ext.gather.watchstar' );
+   }
+   return true;
+   }
/**
 * Add collections link in personal tools menu
 * @param array &$items Items array to be added to menu
diff --git a/includes/Resources.php b/includes/Resources.php
index 07c419a..d240a2f 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -76,4 +76,9 @@
'group' => 'other',
),
 
+   'ext.gather.watchstar' => $wgGatherResourceFileModuleBoilerplate + 
array(
+   'scripts' => array(
+   'ext.gather.watchstar/init.js',
+   ),
+   ),
 ) );
diff --git a/resources/ext.gather.watchstar/init.js 
b/resources/ext.gather.watchstar/init.js
new file mode 100644
index 000..ba036e5
--- /dev/null
+++ b/resources/ext.gather.watchstar/init.js
@@ -0,0 +1 @@
+alert('HAHA!');

-- 
To view, visit https://gerrit.wikimedia.org/r/193015
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac6df0166e12a19acbce44aa23f201ce4e050ce8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix dependencies of the sentry module - change (mediawiki/vagrant)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Fix dependencies of the sentry module
..


Fix dependencies of the sentry module

Bug: T90701
Change-Id: I40fa5f1ae57a48a3a28ffaed1010090b4590155e
---
M puppet/modules/sentry/manifests/init.pp
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Ori.livneh: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/puppet/modules/sentry/manifests/init.pp 
b/puppet/modules/sentry/manifests/init.pp
index 7ec9e68..04d7ace 100644
--- a/puppet/modules/sentry/manifests/init.pp
+++ b/puppet/modules/sentry/manifests/init.pp
@@ -78,6 +78,8 @@
 require_package('libmysqlclient-dev')
 # needed for building the python package lxml
 require_package('libxml2-dev', 'libxslt1-dev')
+# needed for building the python package cffi
+require_package('libffi-dev')
 
 $sentry_cli = "${deploy_dir}/bin/sentry --config='${cfg_file}'"
 $sentry_create_project_script = 
"${deploy_dir}/bin/sentry_create_project.py"

-- 
To view, visit https://gerrit.wikimedia.org/r/192995
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I40fa5f1ae57a48a3a28ffaed1010090b4590155e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza 
Gerrit-Reviewer: Ori.livneh 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Hygiene: Rename/reorganise modules - change (mediawiki...Gather)

[Jdlrobson (Code Review)]

Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193014

Change subject: Hygiene: Rename/reorganise modules
..

Hygiene: Rename/reorganise modules

The folders in resources should correspond to RL modules (this allows us to 
automagically generate them in
future). The icons.less file should be unnecessary - this is generated by 
ResourceLoaderImageModule so we are
getting duplicate rules.

Use ext.gather rather than ext.collections to avoid confusion.

Change-Id: I7fcb0455e7c0bc66f78734485132463238362343
---
M includes/Resources.php
D resources/ext.collections.styles/icons.less
R resources/ext.gather.icons/next.svg
R resources/ext.gather.icons/user.svg
R resources/ext.gather.styles/collections.less
5 files changed, 6 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gather 
refs/changes/14/193014/1

diff --git a/includes/Resources.php b/includes/Resources.php
index 8a2da78..07c419a 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -51,27 +51,26 @@
 
 $wgResourceModules = array_merge( $wgResourceModules, array(
 
-   'ext.collections.icons' => $wgGatherResourceFileModuleBoilerplate + 
array(
+   'ext.gather.icons' => $wgGatherResourceFileModuleBoilerplate + array(
'class' => 'ResourceLoaderImageModule',
'prefix' => 'mw-ui',
'images' => array(
// FIXME: ':before' suffix should be configurable in 
image module.
'icon' => array(
-   'collections-read-more:before' => 
'ext.collections.styles/images/icons/next.svg',
-   'collection-owner:before' => 
'ext.collections.styles/images/icons/user.svg',
+   'collections-read-more:before' => 
'ext.gather.icons/next.svg',
+   'collection-owner:before' => 
'ext.gather.icons/user.svg',
),
),
),
 
-   'ext.collections.styles' => $wgGatherResourceFileModuleBoilerplate + 
array(
+   'ext.gather.styles' => $wgGatherResourceFileModuleBoilerplate + array(
'styles' => array(
-   'ext.collections.styles/icons.less',
-   'ext.collections.styles/collections.less',
+   'ext.gather.styles/collections.less',
),
'dependencies' => array(
'mediawiki.ui.anchor',
'mediawiki.ui.icon',
-   'ext.collections.icons',
+   'ext.gather.icons',
),
'position' => 'top',
'group' => 'other',
diff --git a/resources/ext.collections.styles/icons.less 
b/resources/ext.collections.styles/icons.less
deleted file mode 100644
index edb4def..000
--- a/resources/ext.collections.styles/icons.less
+++ /dev/null
@@ -1,18 +0,0 @@
-// FIXME: This file should be shared across repositories
-@import "minerva.variables";
-@import "minerva.mixins";
-@import "mediawiki.mixins";
-
-span.mw-ui-icon {
-  display: inline-block;
-}
-
-.mw-ui-icon-collections-read-more {
-   .m-background-image-svg-quick( 'images/icons/next' );
-}
-
-.mw-ui-icon-collection-owner {
-   .m-background-image-svg-quick( 'images/icons/user' );
-}
-
-
diff --git a/resources/ext.collections.styles/images/icons/next.svg 
b/resources/ext.gather.icons/next.svg
similarity index 100%
rename from resources/ext.collections.styles/images/icons/next.svg
rename to resources/ext.gather.icons/next.svg
diff --git a/resources/ext.collections.styles/images/icons/user.svg 
b/resources/ext.gather.icons/user.svg
similarity index 100%
rename from resources/ext.collections.styles/images/icons/user.svg
rename to resources/ext.gather.icons/user.svg
diff --git a/resources/ext.collections.styles/collections.less 
b/resources/ext.gather.styles/collections.less
similarity index 100%
rename from resources/ext.collections.styles/collections.less
rename to resources/ext.gather.styles/collections.less

-- 
To view, visit https://gerrit.wikimedia.org/r/193014
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7fcb0455e7c0bc66f78734485132463238362343
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Enable WikiGrok in repo mode on testwikidata - change (operations/mediawiki-config)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Enable WikiGrok in repo mode on testwikidata
..


Enable WikiGrok in repo mode on testwikidata

Change-Id: Ie7da27e2e082202578ed06e2bd8ed4bc25c82d4c
---
M wmf-config/InitialiseSettings.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index de3004d..9de85d9 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -12633,11 +12633,12 @@
'test2wiki' => true,
'testwiki' => true,
'enwiki' => true,
-   'wikidatawiki' => false,
+   'testwikidatawiki' => true,
 ),
 'wmgWikiGrokRepoMode' => array(
'default' => false,
'wikidatawiki' => true,
+   'testwikidatawiki' => true,
 ),
 'wmgEnableTextExtracts' => array(
'default' => true,

-- 
To view, visit https://gerrit.wikimedia.org/r/192987
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7da27e2e082202578ed06e2bd8ed4bc25c82d4c
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: MaxSem 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] WikiGrok: grab https://gerrit.wikimedia.org/r/#/c/192966/ - change (mediawiki/core)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: WikiGrok: grab https://gerrit.wikimedia.org/r/#/c/192966/
..


WikiGrok: grab https://gerrit.wikimedia.org/r/#/c/192966/

Change-Id: Ia6d0e9843cf27f00c6466536f9495dea12284ff2
---
M extensions/WikiGrok
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/extensions/WikiGrok b/extensions/WikiGrok
index 66585ec..b94bd32 16
--- a/extensions/WikiGrok
+++ b/extensions/WikiGrok
-Subproject commit 66585ecd66ad138512f9925fe5ca30b99abc523a
+Subproject commit b94bd32a79408be5edd2d0d0dda594bf4e9fd0a9

-- 
To view, visit https://gerrit.wikimedia.org/r/192999
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6d0e9843cf27f00c6466536f9495dea12284ff2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.25wmf19
Gerrit-Owner: MaxSem 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Don't put serialized uuid's into the logging table - change (mediawiki...Flow)

[EBernhardson (Code Review)]

EBernhardson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193013

Change subject: Don't put serialized uuid's into the logging table
..

Don't put serialized uuid's into the logging table

Bug: T90745
Change-Id: I800ec8cf044e514b6b5d466343c54bfd1269a8f7
---
M includes/Log/PostModerationLogger.php
M tests/phpunit/api/ApiFlowModerateTopicTest.php
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/13/193013/1

diff --git a/includes/Log/PostModerationLogger.php 
b/includes/Log/PostModerationLogger.php
index d096424..eed003e 100644
--- a/includes/Log/PostModerationLogger.php
+++ b/includes/Log/PostModerationLogger.php
@@ -52,9 +52,9 @@
$logParams = array();
 
if ( $post->isTopicTitle() ) {
-   $logParams['topicId'] = $workflowId;
+   $logParams['topicId'] = 
$workflowId->getAlphadecimal();
} else {
-   $logParams['postId'] = $post->getRevisionId();
+   $logParams['postId'] = 
$post->getRevisionId()->getAlphadecimal();
}
 
$this->logger->log(
diff --git a/tests/phpunit/api/ApiFlowModerateTopicTest.php 
b/tests/phpunit/api/ApiFlowModerateTopicTest.php
index 7604e41..74779b9 100644
--- a/tests/phpunit/api/ApiFlowModerateTopicTest.php
+++ b/tests/phpunit/api/ApiFlowModerateTopicTest.php
@@ -56,6 +56,6 @@
$debug = json_encode( $data );
$logEntry = $data[0]['query']['logevents'][0];
$this->assertArrayHasKey( 'topicId', $logEntry, $debug );
-   $this->assertEquals( $workflowId, 
$logEntry['topicId']->getAlphadecimal(), $debug );
+   $this->assertEquals( $workflowId, $logEntry['topicId'], $debug 
);
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/193013
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I800ec8cf044e514b6b5d466343c54bfd1269a8f7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] WikiGrok: grab https://gerrit.wikimedia.org/r/#/c/192966/ - change (mediawiki/core)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: WikiGrok: grab https://gerrit.wikimedia.org/r/#/c/192966/
..


WikiGrok: grab https://gerrit.wikimedia.org/r/#/c/192966/

Change-Id: I922747a179f975d5e25c6781e65c157b37d35fa3
---
M extensions/WikiGrok
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/extensions/WikiGrok b/extensions/WikiGrok
index 08cc356..d1d28eb 16
--- a/extensions/WikiGrok
+++ b/extensions/WikiGrok
-Subproject commit 08cc3567d18fb088cbe603d071a6ad60116b89bd
+Subproject commit d1d28ebe2bb855aef009c5eb22fc036d2c9ecb4f

-- 
To view, visit https://gerrit.wikimedia.org/r/193008
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I922747a179f975d5e25c6781e65c157b37d35fa3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.25wmf18
Gerrit-Owner: MaxSem 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Conditionally enable stuff depending on repo mode - change (mediawiki...WikiGrok)

[MaxSem (Code Review)]

MaxSem has submitted this change and it was merged.

Change subject: Conditionally enable stuff depending on repo mode
..


Conditionally enable stuff depending on repo mode

Change-Id: If6a64d9416f02bc783f73a2fbdcc2c8eb93566b0
---
M WikiGrok.php
1 file changed, 24 insertions(+), 13 deletions(-)

Approvals:
  Kaldari: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/WikiGrok.php b/WikiGrok.php
index e0f5453..bd1917a 100644
--- a/WikiGrok.php
+++ b/WikiGrok.php
@@ -61,24 +61,35 @@
$wgAutoloadClasses["WikiGrok\\$className"] = __DIR__ . 
"/includes/$classFilename.php";
 }
 
-$wgAPIModules['wikigrokresponse'] = 'WikiGrok\Api\ApiResponse';
-$wgAPIListModules['wikigrokrandom'] =
-   $wgAPIGeneratorModules['wikigrokrandom'] =
-   'WikiGrok\Api\QueryRandom';
-
-$wgHooks['OutputPageParserOutput'][] = 
'WikiGrok\Hooks::onOutputPageParserOutput';
-$wgHooks['LinksUpdate'][] = 'WikiGrok\Hooks::onLinksUpdate';
 $wgHooks['LoadExtensionSchemaUpdates'][] = 
'WikiGrok\Hooks::onLoadExtensionSchemaUpdates';
-$wgHooks['ArticleDeleteComplete'][] = 
'WikiGrok\Hooks::onArticleDeleteComplete';
-$wgHooks['BeforePageDisplay'][] = 'WikiGrok\Hooks::onBeforePageDisplay';
-$wgHooks['ResourceLoaderGetConfigVars'][] = 
'WikiGrok\Hooks::onResourceLoaderGetConfigVars';
-$wgHooks['EventLoggingRegisterSchemas'][] = 
'WikiGrok\Hooks::onEventLoggingRegisterSchemas';
-$wgHooks['MinervaDiscoveryTools'][] = 
'WikiGrok\Hooks::onMinervaDiscoveryTools';
-$wgHooks['ResourceLoaderTestModules'][] = 
'WikiGrok\Hooks::onResourceLoaderTestModules';
 $wgHooks['UnitTestsList'][] = function ( &$files ) {
$files[] = __DIR__ . '/tests/phpunit/api/ApiResponseTest.php';
 };
 
+/**
+ * Enable API modules and certain hooks only on client wikis
+ */
+$wgExtensionFunctions[] = function() {
+   global $wgWikiGrokRepoMode, $wgAPIModules, $wgAPIListModules, 
$wgAPIGeneratorModules,
+   $wgHooks;
+
+   if ( $wgWikiGrokRepoMode ) {
+   $wgAPIModules['wikigrokresponse'] = 'WikiGrok\Api\ApiResponse';
+   } else {
+   $wgAPIListModules['wikigrokrandom'] =
+   $wgAPIGeneratorModules['wikigrokrandom'] = 
'WikiGrok\Api\QueryRandom';
+
+   $wgHooks['OutputPageParserOutput'][]  = 
'WikiGrok\Hooks::onOutputPageParserOutput';
+   $wgHooks['LinksUpdate'][] = 
'WikiGrok\Hooks::onLinksUpdate';
+   $wgHooks['ArticleDeleteComplete'][]   = 
'WikiGrok\Hooks::onArticleDeleteComplete';
+   $wgHooks['BeforePageDisplay'][]   = 
'WikiGrok\Hooks::onBeforePageDisplay';
+   $wgHooks['ResourceLoaderGetConfigVars'][] = 
'WikiGrok\Hooks::onResourceLoaderGetConfigVars';
+   $wgHooks['EventLoggingRegisterSchemas'][] = 
'WikiGrok\Hooks::onEventLoggingRegisterSchemas';
+   $wgHooks['MinervaDiscoveryTools'][]   = 
'WikiGrok\Hooks::onMinervaDiscoveryTools';
+   $wgHooks['ResourceLoaderTestModules'][]   = 
'WikiGrok\Hooks::onResourceLoaderTestModules';
+   }
+};
+
 $wgConfigRegistry['wikigrok'] = 'GlobalVarConfig::newInstance';
 
 // Flood protection: no more than 2 responses per minute per user

-- 
To view, visit https://gerrit.wikimedia.org/r/192966
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If6a64d9416f02bc783f73a2fbdcc2c8eb93566b0
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/WikiGrok
Gerrit-Branch: master
Gerrit-Owner: MaxSem 
Gerrit-Reviewer: Kaldari 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Update dependencies - change (mediawiki...deploy)

[GWicke (Code Review)]

GWicke has submitted this change and it was merged.

Change subject: Update dependencies
..


Update dependencies

Change-Id: I5baec227c25e8feb61b1f564b60867da14e84c72
---
M 
node_modules/busboy/node_modules/readable-stream/node_modules/inherits/package.json
M node_modules/istanbul/node_modules/async/package.json
M node_modules/istanbul/node_modules/mkdirp/node_modules/minimist/package.json
M node_modules/istanbul/node_modules/which/package.json
M node_modules/mocha/node_modules/commander/package.json
M node_modules/mocha/node_modules/debug/package.json
M node_modules/mocha/node_modules/mkdirp/node_modules/minimist/package.json
M node_modules/mocha/node_modules/mkdirp/package.json
M node_modules/preq/node_modules/bluebird/package.json
M 
node_modules/restbase-mod-table-cassandra/node_modules/restify/node_modules/csv/node_modules/csv-parse/package.json
M 
node_modules/restbase-mod-table-cassandra/node_modules/restify/node_modules/lru-cache/package.json
M 
node_modules/restbase-mod-table-cassandra/node_modules/restify/node_modules/spdy/package.json
M node_modules/service-runner/README.md
M node_modules/service-runner/config.yaml
M node_modules/service-runner/lib/heapwatch.js
M node_modules/service-runner/package.json
M node_modules/service-runner/service-runner.js
M node_modules/service-runner/test/httpserver.js
M node_modules/swagger-ui/node_modules/swagger-client/package.json
19 files changed, 96 insertions(+), 55 deletions(-)

Approvals:
  GWicke: Verified; Looks good to me, approved



diff --git 
a/node_modules/busboy/node_modules/readable-stream/node_modules/inherits/package.json
 
b/node_modules/busboy/node_modules/readable-stream/node_modules/inherits/package.json
index 754a114..3d69f4f 100644
--- 
a/node_modules/busboy/node_modules/readable-stream/node_modules/inherits/package.json
+++ 
b/node_modules/busboy/node_modules/readable-stream/node_modules/inherits/package.json
@@ -32,7 +32,7 @@
 "shasum": "b17d08d326b4423e568eff719f91b0b1cbdf69f1",
 "tarball": "http://registry.npmjs.org/inherits/-/inherits-2.0.1.tgz";
   },
-  "_from": "inherits@2",
+  "_from": "inherits@~2.0.1",
   "_npmVersion": "1.3.8",
   "_npmUser": {
 "name": "isaacs",
diff --git a/node_modules/istanbul/node_modules/async/package.json 
b/node_modules/istanbul/node_modules/async/package.json
index bdbe740..9d15cd7 100644
--- a/node_modules/istanbul/node_modules/async/package.json
+++ b/node_modules/istanbul/node_modules/async/package.json
@@ -41,7 +41,7 @@
 "shasum": "ac3613b1da9bed1b47510bb4651b8931e47146c7",
 "tarball": "http://registry.npmjs.org/async/-/async-0.9.0.tgz";
   },
-  "_from": "async@~0.9.0",
+  "_from": "async@0.9.x",
   "_npmVersion": "1.4.3",
   "_npmUser": {
 "name": "caolan",
diff --git 
a/node_modules/istanbul/node_modules/mkdirp/node_modules/minimist/package.json 
b/node_modules/istanbul/node_modules/mkdirp/node_modules/minimist/package.json
index 7cd80f4..09e9ec4 100644
--- 
a/node_modules/istanbul/node_modules/mkdirp/node_modules/minimist/package.json
+++ 
b/node_modules/istanbul/node_modules/mkdirp/node_modules/minimist/package.json
@@ -62,5 +62,6 @@
   ],
   "directories": {},
   "_shasum": "857fcabfc3397d2625b8228262e86aa7a011b05d",
-  "_resolved": "https://registry.npmjs.org/minimist/-/minimist-0.0.8.tgz";
+  "_resolved": "https://registry.npmjs.org/minimist/-/minimist-0.0.8.tgz";,
+  "readme": "ERROR: No README data found!"
 }
diff --git a/node_modules/istanbul/node_modules/which/package.json 
b/node_modules/istanbul/node_modules/which/package.json
index ce72dc0..76e41c8 100644
--- a/node_modules/istanbul/node_modules/which/package.json
+++ b/node_modules/istanbul/node_modules/which/package.json
@@ -42,5 +42,6 @@
 "tarball": "http://registry.npmjs.org/which/-/which-1.0.9.tgz";
   },
   "directories": {},
-  "_resolved": "https://registry.npmjs.org/which/-/which-1.0.9.tgz";
+  "_resolved": "https://registry.npmjs.org/which/-/which-1.0.9.tgz";,
+  "readme": "ERROR: No README data found!"
 }
diff --git a/node_modules/mocha/node_modules/commander/package.json 
b/node_modules/mocha/node_modules/commander/package.json
index f2b43dd..de917f5 100644
--- a/node_modules/mocha/node_modules/commander/package.json
+++ b/node_modules/mocha/node_modules/commander/package.json
@@ -66,5 +66,6 @@
 "tarball": "http://registry.npmjs.org/commander/-/commander-2.3.0.tgz";
   },
   "directories": {},
-  "_resolved": "https://registry.npmjs.org/commander/-/commander-2.3.0.tgz";
+  "_resolved": "https://registry.npmjs.org/commander/-/commander-2.3.0.tgz";,
+  "readme": "ERROR: No README data found!"
 }
diff --git a/node_modules/mocha/node_modules/debug/package.json 
b/node_modules/mocha/node_modules/debug/package.json
index e3c906e..f516035 100644
--- a/node_modules/mocha/node_modules/debug/package.json
+++ b/node_modules/mocha/node_modules/debug/package.json
@@ -66,5 +66,6 @@
 "tarball": "http://registry.npmjs.org/debug/-/debu

[MediaWiki-commits] [Gerrit] Update dependencies - change (mediawiki...deploy)

[GWicke (Code Review)]

GWicke has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193012

Change subject: Update dependencies
..

Update dependencies

Change-Id: I5baec227c25e8feb61b1f564b60867da14e84c72
---
M 
node_modules/busboy/node_modules/readable-stream/node_modules/inherits/package.json
M node_modules/istanbul/node_modules/async/package.json
M node_modules/istanbul/node_modules/mkdirp/node_modules/minimist/package.json
M node_modules/istanbul/node_modules/which/package.json
M node_modules/mocha/node_modules/commander/package.json
M node_modules/mocha/node_modules/debug/package.json
M node_modules/mocha/node_modules/mkdirp/node_modules/minimist/package.json
M node_modules/mocha/node_modules/mkdirp/package.json
M node_modules/preq/node_modules/bluebird/package.json
M 
node_modules/restbase-mod-table-cassandra/node_modules/restify/node_modules/csv/node_modules/csv-parse/package.json
M 
node_modules/restbase-mod-table-cassandra/node_modules/restify/node_modules/lru-cache/package.json
M 
node_modules/restbase-mod-table-cassandra/node_modules/restify/node_modules/spdy/package.json
M node_modules/service-runner/README.md
M node_modules/service-runner/config.yaml
M node_modules/service-runner/lib/heapwatch.js
M node_modules/service-runner/package.json
M node_modules/service-runner/service-runner.js
M node_modules/service-runner/test/httpserver.js
M node_modules/swagger-ui/node_modules/swagger-client/package.json
19 files changed, 96 insertions(+), 55 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/restbase/deploy 
refs/changes/12/193012/1

diff --git 
a/node_modules/busboy/node_modules/readable-stream/node_modules/inherits/package.json
 
b/node_modules/busboy/node_modules/readable-stream/node_modules/inherits/package.json
index 754a114..3d69f4f 100644
--- 
a/node_modules/busboy/node_modules/readable-stream/node_modules/inherits/package.json
+++ 
b/node_modules/busboy/node_modules/readable-stream/node_modules/inherits/package.json
@@ -32,7 +32,7 @@
 "shasum": "b17d08d326b4423e568eff719f91b0b1cbdf69f1",
 "tarball": "http://registry.npmjs.org/inherits/-/inherits-2.0.1.tgz";
   },
-  "_from": "inherits@2",
+  "_from": "inherits@~2.0.1",
   "_npmVersion": "1.3.8",
   "_npmUser": {
 "name": "isaacs",
diff --git a/node_modules/istanbul/node_modules/async/package.json 
b/node_modules/istanbul/node_modules/async/package.json
index bdbe740..9d15cd7 100644
--- a/node_modules/istanbul/node_modules/async/package.json
+++ b/node_modules/istanbul/node_modules/async/package.json
@@ -41,7 +41,7 @@
 "shasum": "ac3613b1da9bed1b47510bb4651b8931e47146c7",
 "tarball": "http://registry.npmjs.org/async/-/async-0.9.0.tgz";
   },
-  "_from": "async@~0.9.0",
+  "_from": "async@0.9.x",
   "_npmVersion": "1.4.3",
   "_npmUser": {
 "name": "caolan",
diff --git 
a/node_modules/istanbul/node_modules/mkdirp/node_modules/minimist/package.json 
b/node_modules/istanbul/node_modules/mkdirp/node_modules/minimist/package.json
index 7cd80f4..09e9ec4 100644
--- 
a/node_modules/istanbul/node_modules/mkdirp/node_modules/minimist/package.json
+++ 
b/node_modules/istanbul/node_modules/mkdirp/node_modules/minimist/package.json
@@ -62,5 +62,6 @@
   ],
   "directories": {},
   "_shasum": "857fcabfc3397d2625b8228262e86aa7a011b05d",
-  "_resolved": "https://registry.npmjs.org/minimist/-/minimist-0.0.8.tgz";
+  "_resolved": "https://registry.npmjs.org/minimist/-/minimist-0.0.8.tgz";,
+  "readme": "ERROR: No README data found!"
 }
diff --git a/node_modules/istanbul/node_modules/which/package.json 
b/node_modules/istanbul/node_modules/which/package.json
index ce72dc0..76e41c8 100644
--- a/node_modules/istanbul/node_modules/which/package.json
+++ b/node_modules/istanbul/node_modules/which/package.json
@@ -42,5 +42,6 @@
 "tarball": "http://registry.npmjs.org/which/-/which-1.0.9.tgz";
   },
   "directories": {},
-  "_resolved": "https://registry.npmjs.org/which/-/which-1.0.9.tgz";
+  "_resolved": "https://registry.npmjs.org/which/-/which-1.0.9.tgz";,
+  "readme": "ERROR: No README data found!"
 }
diff --git a/node_modules/mocha/node_modules/commander/package.json 
b/node_modules/mocha/node_modules/commander/package.json
index f2b43dd..de917f5 100644
--- a/node_modules/mocha/node_modules/commander/package.json
+++ b/node_modules/mocha/node_modules/commander/package.json
@@ -66,5 +66,6 @@
 "tarball": "http://registry.npmjs.org/commander/-/commander-2.3.0.tgz";
   },
   "directories": {},
-  "_resolved": "https://registry.npmjs.org/commander/-/commander-2.3.0.tgz";
+  "_resolved": "https://registry.npmjs.org/commander/-/commander-2.3.0.tgz";,
+  "readme": "ERROR: No README data found!"
 }
diff --git a/node_modules/mocha/node_modules/debug/package.json 
b/node_modules/mocha/node_modules/debug/package.json
index e3c906e..f516035 100644
--- a/node_modules/mocha/node_modules/debug/package.json
+++ b/node_modules/mocha/node_modules/debug/package

[MediaWiki-commits] [Gerrit] Support the ApiSerializable interface - change (mediawiki...Flow)

[EBernhardson (Code Review)]

EBernhardson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193011

Change subject: Support the ApiSerializable interface
..

Support the ApiSerializable interface

Adds the 'implements ApiSerializable' to classes that have the
appropritae methods.  Do not implement until I7b37295e88 is merged
to core which contains this new interface.

Bug: T90745
Change-Id: I738772c946c348f4e971998bd94a35ffad838d8a
---
M includes/Model/Anchor.php
M includes/Model/UUID.php
2 files changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/11/193011/1

diff --git a/includes/Model/Anchor.php b/includes/Model/Anchor.php
index dbe0155..203a1f8 100644
--- a/includes/Model/Anchor.php
+++ b/includes/Model/Anchor.php
@@ -2,6 +2,7 @@
 
 namespace Flow\Model;
 
+use ApiSerializable;
 use Html;
 use Message;
 use RawMessage;
@@ -11,7 +12,7 @@
  * Represents a mutable anchor as a Message instance along with
  * a title, query parameters, and a fragment.
  */
-class Anchor {
+class Anchor implements ApiSerializable {
/**
 * @var Message
 */
diff --git a/includes/Model/UUID.php b/includes/Model/UUID.php
index 5d135be..d127f62 100644
--- a/includes/Model/UUID.php
+++ b/includes/Model/UUID.php
@@ -2,6 +2,7 @@
 
 namespace Flow\Model;
 
+use ApiSerializable;
 use Blob;
 use Flow\Data\ObjectManager;
 use Flow\Exception\FlowException;
@@ -17,7 +18,7 @@
  *
  * @todo probably should be UID since these dont match the UUID standard
  */
-class UUID {
+class UUID implements ApiSerializable {
/**
 * @var UUID[][][]
 */

-- 
To view, visit https://gerrit.wikimedia.org/r/193011
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I738772c946c348f4e971998bd94a35ffad838d8a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Pre-support for ApiSerializable interface - change (mediawiki...Flow)

[EBernhardson (Code Review)]

EBernhardson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193010

Change subject: Pre-support for ApiSerializable interface
..

Pre-support for ApiSerializable interface

This adds the methods required by the ApiSerializable interface, but does
not directly implement the class so this can be merged before the dependent
core patch is merged.  That is required because the core patch is currently
failing tests due to this.  That patch is I7b37295e88

Bug: T90745
Change-Id: I2ab697be8e3cab312fe9642de804dc199a8c76f8
---
M includes/Model/Anchor.php
M includes/Model/UUID.php
2 files changed, 14 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/10/193010/1

diff --git a/includes/Model/Anchor.php b/includes/Model/Anchor.php
index b32c4df..dbe0155 100644
--- a/includes/Model/Anchor.php
+++ b/includes/Model/Anchor.php
@@ -46,6 +46,13 @@
}
 
/**
+* @return mixed
+*/
+   public function serializeForApiResult() {
+   return $this->toArray();
+   }
+
+   /**
 * @return string
 */
public function getLinkURL() {
diff --git a/includes/Model/UUID.php b/includes/Model/UUID.php
index b92df50..5d135be 100644
--- a/includes/Model/UUID.php
+++ b/includes/Model/UUID.php
@@ -208,6 +208,13 @@
}
 
/**
+* @return mixed
+*/
+   public function serializeForApiResult() {
+   return $this->getAlphadecimal();
+   }
+
+   /**
 * @return Blob|string UUID encoded in binary format for database 
storage
 * @throws FlowException
 */

-- 
To view, visit https://gerrit.wikimedia.org/r/193010
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ab697be8e3cab312fe9642de804dc199a8c76f8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Import htmlpurifier 4.5.0 - change (labs/toollabs)

[Tim Landscheidt (Code Review)]

Tim Landscheidt has submitted this change and it was merged.

Change subject: Import htmlpurifier 4.5.0
..


Import htmlpurifier 4.5.0

None of the release variants at http://htmlpurifier.org/releases/
fully match the directory structure, but the purpose of this change is
only to reflect the working status quo.  Subsequent updates for
example to 4.6.0 should be more explicit about which source was used
and how.

Change-Id: I6231807e4d698fce8e298668270415389952b1e8
---
A htmlpurifier/.gitattributes
A htmlpurifier/.gitignore
A htmlpurifier/CREDITS
A htmlpurifier/Doxyfile
A htmlpurifier/FOCUS
A htmlpurifier/INSTALL
A htmlpurifier/INSTALL.fr.utf8
A htmlpurifier/LICENSE
A htmlpurifier/NEWS
A htmlpurifier/README
A htmlpurifier/TODO
A htmlpurifier/VERSION
A htmlpurifier/WHATSNEW
A htmlpurifier/WYSIWYG
A htmlpurifier/art/1000passes.png
A htmlpurifier/art/100cases.png
A htmlpurifier/art/favicon.ico
A htmlpurifier/art/icon-16x16.png
A htmlpurifier/art/icon-16x16.svg
A htmlpurifier/art/icon-32x32.png
A htmlpurifier/art/icon-32x32.svg
A htmlpurifier/art/icon-64x64.png
A htmlpurifier/art/logo-large.png
A htmlpurifier/art/logo.png
A htmlpurifier/art/logo.svg
A htmlpurifier/art/powered.png
A htmlpurifier/benchmarks/.htaccess
A htmlpurifier/benchmarks/ConfigSchema.php
A htmlpurifier/benchmarks/Lexer.php
A htmlpurifier/benchmarks/Trace.php
A htmlpurifier/benchmarks/samples/Lexer/1.html
A htmlpurifier/benchmarks/samples/Lexer/2.html
A htmlpurifier/benchmarks/samples/Lexer/3.html
A htmlpurifier/benchmarks/samples/Lexer/4.html
A htmlpurifier/benchmarks/samples/Lexer/DISCLAIMER.txt
A htmlpurifier/composer.json
A htmlpurifier/configdoc/generate.php
A htmlpurifier/configdoc/styles/plain.css
A htmlpurifier/configdoc/styles/plain.xsl
A htmlpurifier/configdoc/types.xml
A htmlpurifier/configdoc/usage.xml
A htmlpurifier/docs/dev-advanced-api.html
A htmlpurifier/docs/dev-code-quality.txt
A htmlpurifier/docs/dev-config-bcbreaks.txt
A htmlpurifier/docs/dev-config-naming.txt
A htmlpurifier/docs/dev-config-schema.html
A htmlpurifier/docs/dev-flush.html
A htmlpurifier/docs/dev-includes.txt
A htmlpurifier/docs/dev-naming.html
A htmlpurifier/docs/dev-optimization.html
A htmlpurifier/docs/dev-progress.html
A htmlpurifier/docs/dtd/xhtml1-transitional.dtd
A htmlpurifier/docs/enduser-customize.html
A htmlpurifier/docs/enduser-id.html
A htmlpurifier/docs/enduser-overview.txt
A htmlpurifier/docs/enduser-security.txt
A htmlpurifier/docs/enduser-slow.html
A htmlpurifier/docs/enduser-tidy.html
A htmlpurifier/docs/enduser-uri-filter.html
A htmlpurifier/docs/enduser-utf8.html
A htmlpurifier/docs/enduser-youtube.html
A htmlpurifier/docs/entities/xhtml-lat1.ent
A htmlpurifier/docs/entities/xhtml-special.ent
A htmlpurifier/docs/entities/xhtml-symbol.ent
A htmlpurifier/docs/examples/basic.php
A htmlpurifier/docs/fixquotes.htc
A htmlpurifier/docs/index.html
A htmlpurifier/docs/proposal-colors.html
A htmlpurifier/docs/proposal-config.txt
A htmlpurifier/docs/proposal-css-extraction.txt
A htmlpurifier/docs/proposal-errors.txt
A htmlpurifier/docs/proposal-filter-levels.txt
A htmlpurifier/docs/proposal-language.txt
A htmlpurifier/docs/proposal-new-directives.txt
A htmlpurifier/docs/proposal-plists.txt
A htmlpurifier/docs/ref-content-models.txt
A htmlpurifier/docs/ref-css-length.txt
A htmlpurifier/docs/ref-devnetwork.html
A htmlpurifier/docs/ref-html-modularization.txt
A htmlpurifier/docs/ref-proprietary-tags.txt
A htmlpurifier/docs/ref-whatwg.txt
A htmlpurifier/docs/specimens/LICENSE
A htmlpurifier/docs/specimens/html-align-to-css.html
A htmlpurifier/docs/specimens/img.png
A htmlpurifier/docs/specimens/jochem-blok-word.html
A htmlpurifier/docs/specimens/windows-live-mail-desktop-beta.html
A htmlpurifier/docs/style.css
A htmlpurifier/extras/ConfigDoc/HTMLXSLTProcessor.php
A htmlpurifier/extras/FSTools.php
A htmlpurifier/extras/FSTools/File.php
A htmlpurifier/extras/HTMLPurifierExtras.auto.php
A htmlpurifier/extras/HTMLPurifierExtras.autoload.php
A htmlpurifier/extras/HTMLPurifierExtras.php
A htmlpurifier/extras/README
A htmlpurifier/library/HTMLPurifier.auto.php
A htmlpurifier/library/HTMLPurifier.autoload.php
A htmlpurifier/library/HTMLPurifier.composer.php
A htmlpurifier/library/HTMLPurifier.func.php
A htmlpurifier/library/HTMLPurifier.includes.php
A htmlpurifier/library/HTMLPurifier.kses.php
A htmlpurifier/library/HTMLPurifier.path.php
A htmlpurifier/library/HTMLPurifier.php
A htmlpurifier/library/HTMLPurifier.safe-includes.php
A htmlpurifier/library/HTMLPurifier/AttrCollections.php
A htmlpurifier/library/HTMLPurifier/AttrDef.php
A htmlpurifier/library/HTMLPurifier/AttrDef/CSS.php
A htmlpurifier/library/HTMLPurifier/AttrDef/CSS/AlphaValue.php
A htmlpurifier/library/HTMLPurifier/AttrDef/CSS/Background.php
A htmlpurifier/library/HTMLPurifier/AttrDef/CSS/BackgroundPosition.php
A htmlpurifier/library/HTMLPurifier/AttrDef/CSS/Border.php
A htmlpurifier/library/HTMLPurifier/AttrDef/CSS/Color.php
A ht

[MediaWiki-commits] [Gerrit] Fix lintian warning for jQuery minified source - change (labs/toollabs)

[Tim Landscheidt (Code Review)]

Tim Landscheidt has submitted this change and it was merged.

Change subject: Fix lintian warning for jQuery minified source
..


Fix lintian warning for jQuery minified source

Bug: T90790
Change-Id: I17f6a8b540b00ffccb837a3c47b96118cb949b06
---
M debian/changelog
A debian/source/lintian-overrides
2 files changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Tim Landscheidt: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/debian/changelog b/debian/changelog
index ef91b3e..137c727 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+toollabs (1.2) unstable; urgency=low
+
+  * Fix lintian warning for jQuery minified source
+
+ -- Tim Landscheidt   Thu, 26 Feb 2015 00:16:09 +
+
 toollabs (1.1) unstable; urgency=low
 
   * Remove webservice2 from package, move to puppet repo [Yuvi Panda]
diff --git a/debian/source/lintian-overrides b/debian/source/lintian-overrides
new file mode 100644
index 000..45ff5c4
--- /dev/null
+++ b/debian/source/lintian-overrides
@@ -0,0 +1 @@
+toollabs source: source-is-missing www/libs/jquery.js

-- 
To view, visit https://gerrit.wikimedia.org/r/193003
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I17f6a8b540b00ffccb837a3c47b96118cb949b06
Gerrit-PatchSet: 1
Gerrit-Project: labs/toollabs
Gerrit-Branch: master
Gerrit-Owner: Tim Landscheidt 
Gerrit-Reviewer: Tim Landscheidt 
Gerrit-Reviewer: coren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Syncronize VisualEditor: bc75cf5..b85b81c - change (mediawiki/extensions)

[Jenkins-mwext-sync (Code Review)]

Jenkins-mwext-sync has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193009

Change subject: Syncronize VisualEditor: bc75cf5..b85b81c
..

Syncronize VisualEditor: bc75cf5..b85b81c

Change-Id: I448f531e214179bfad8c1acbc2b88e0a1462b906
---
M VisualEditor
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions 
refs/changes/09/193009/1

diff --git a/VisualEditor b/VisualEditor
index bc75cf5..b85b81c 16
--- a/VisualEditor
+++ b/VisualEditor
-Subproject commit bc75cf573f793f149d5a06211a24a51439461817
+Subproject commit b85b81c5012b7677b6d29e2e2043bd0595208290

-- 
To view, visit https://gerrit.wikimedia.org/r/193009
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I448f531e214179bfad8c1acbc2b88e0a1462b906
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions
Gerrit-Branch: master
Gerrit-Owner: Jenkins-mwext-sync 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Syncronize VisualEditor: bc75cf5..b85b81c - change (mediawiki/extensions)

[Jenkins-mwext-sync (Code Review)]

Jenkins-mwext-sync has submitted this change and it was merged.

Change subject: Syncronize VisualEditor: bc75cf5..b85b81c
..


Syncronize VisualEditor: bc75cf5..b85b81c

Change-Id: I448f531e214179bfad8c1acbc2b88e0a1462b906
---
M VisualEditor
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Jenkins-mwext-sync: Verified; Looks good to me, approved



diff --git a/VisualEditor b/VisualEditor
index bc75cf5..b85b81c 16
--- a/VisualEditor
+++ b/VisualEditor
-Subproject commit bc75cf573f793f149d5a06211a24a51439461817
+Subproject commit b85b81c5012b7677b6d29e2e2043bd0595208290

-- 
To view, visit https://gerrit.wikimedia.org/r/193009
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I448f531e214179bfad8c1acbc2b88e0a1462b906
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions
Gerrit-Branch: master
Gerrit-Owner: Jenkins-mwext-sync 
Gerrit-Reviewer: Jenkins-mwext-sync 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Correctly validate a provider for local api - change (mediawiki...VisualEditor)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Correctly validate a provider for local api
..


Correctly validate a provider for local api

Make sure that the validation method accounts for local api
vs remote api when checking for valid variables.

Bug: T90795
Change-Id: Ia6877ca6ccc4e65d1db053f107e7702721e2da3c
---
M modules/ve-mw/dm/models/ve.dm.MWMediaResourceProvider.js
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/dm/models/ve.dm.MWMediaResourceProvider.js 
b/modules/ve-mw/dm/models/ve.dm.MWMediaResourceProvider.js
index cb378dd..bef33e3 100644
--- a/modules/ve-mw/dm/models/ve.dm.MWMediaResourceProvider.js
+++ b/modules/ve-mw/dm/models/ve.dm.MWMediaResourceProvider.js
@@ -24,6 +24,7 @@
 
// Fetching configuration
this.scriptDirUrl = config.scriptDirUrl;
+   this.isLocal = config.local;
 
if ( config.local ) {
this.setAjaxSettings( {
@@ -291,8 +292,10 @@
var params = this.getUserParams();
return params.gsrsearch &&
(
+   this.isLocal ||
// If we don't have either 'apiurl' or 'scriptDirUrl'
// the source is invalid, and we will skip it
-   this.apiurl !== undefined || this.scriptDirUrl !== 
undefined
+   this.apiurl !== undefined ||
+   this.scriptDirUrl !== undefined
);
 };

-- 
To view, visit https://gerrit.wikimedia.org/r/192981
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6877ca6ccc4e65d1db053f107e7702721e2da3c
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] WikiGrok: grab https://gerrit.wikimedia.org/r/#/c/192966/ - change (mediawiki/core)

[MaxSem (Code Review)]

MaxSem has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193008

Change subject: WikiGrok: grab https://gerrit.wikimedia.org/r/#/c/192966/
..

WikiGrok: grab https://gerrit.wikimedia.org/r/#/c/192966/

Change-Id: I922747a179f975d5e25c6781e65c157b37d35fa3
---
M extensions/WikiGrok
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/08/193008/1

diff --git a/extensions/WikiGrok b/extensions/WikiGrok
index 08cc356..d1d28eb 16
--- a/extensions/WikiGrok
+++ b/extensions/WikiGrok
-Subproject commit 08cc3567d18fb088cbe603d071a6ad60116b89bd
+Subproject commit d1d28ebe2bb855aef009c5eb22fc036d2c9ecb4f

-- 
To view, visit https://gerrit.wikimedia.org/r/193008
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I922747a179f975d5e25c6781e65c157b37d35fa3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.25wmf18
Gerrit-Owner: MaxSem 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] MERGE no earlier than 6pm PST: Revoked my own key - change (operations/puppet)

[Gage (Code Review)]

Gage has submitted this change and it was merged.

Change subject: MERGE no earlier than 6pm PST: Revoked my own key
..


MERGE no earlier than 6pm PST: Revoked my own key

Please merge between 6pm and 10pm PST tonight 2015-02-25

Change-Id: Ia60ed5d211405ae716fdd2ee7a0cf0c27a83ff34
---
M modules/admin/data/data.yaml
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Gage: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/admin/data/data.yaml b/modules/admin/data/data.yaml
index 627e1f4..8af3a1c 100644
--- a/modules/admin/data/data.yaml
+++ b/modules/admin/data/data.yaml
@@ -788,8 +788,7 @@
 gid: 500
 name: yurik
 realname: Yuri Astrakhan
-ssh_keys: [ssh-rsa 
B3NzaC1yc2EBIwAAAgEA4nAjWgQOlzel8gYe/Hsl3DpT7KF7ygNVl7mZBG7285YUakrr2Hj8fSn0YfYX8b4u+FTywah7adefxTCuG6x9PkEzKAYSnaWXRxz3C2bZclkxXaKcVR+IJUG/9WyqwLxVj/UeATsuydSEljcwoMkTkV0m1p5hFNShTwslOiKA6VIwVQPufMjFaduUMXl3H1MzA0ymO/xzkMsOmsqXLgOIE6GOE1r3kzQHSD7tvb0o9dwtApUEhRiwGPnWxlDaGpWhzNQ9hHXGZG2XvfDvhVZ6HNJ/wR+x0WI1xX6b27fPbDPYkQDxOrts6G3F4WjDqmPLMYJGcsBXwueh99X2LaaDX6rWU1vq37Hj8Q8ROEdsL/RX30t8WdOj7YRGBEMbZliaGJNhTyOK2nFOBLKRcLSYVXtCvjFa9iTSqG8ZHdwho+vYRcs26hxMa1bWdS+Sg/YUJlfCxZk+zi5xryF/pog0IJdyqgNDqPau0w6DZKphlo8/eXcLJB6KkuaJ2xE52iqLokGGHu+EyYyOSrBSCOLsvbHvOwe9ESqDiJs1TAxjXqoOzNfWZKrfeoZb0AqycDwwbvM3oQB4/N590Jsb6frozsDCo+y08AYfjhM+lIFY2SdZHOmEzmNTDwJYf2MQOc7Mi/5wl+tMMnkXU0OPz9Y5ItDyfTwIsyESumVa3FYSE2s=
-yastrak...@wikimedia.org]
+ssh_keys: []
 uid: 1011
   jgonera:
 ensure: absent

-- 
To view, visit https://gerrit.wikimedia.org/r/192888
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia60ed5d211405ae716fdd2ee7a0cf0c27a83ff34
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Yurik 
Gerrit-Reviewer: Gage 
Gerrit-Reviewer: Rush 
Gerrit-Reviewer: Yurik 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Correctly configure human infobox - change (operations/mediawiki-config)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Correctly configure human infobox
..


Correctly configure human infobox

Human item id on beta labs wiki instance is
http://wikidata.beta.wmflabs.org/wiki/Q44076

Change-Id: I4f0c3466a670f19d2c13f591316c419302193535
---
M wmf-config/InitialiseSettings-labs.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Alex Monk: Looks good to me, approved
  jenkins-bot: Verified
  Dzahn: Looks good to me, but someone else must approve



diff --git a/wmf-config/InitialiseSettings-labs.php 
b/wmf-config/InitialiseSettings-labs.php
index a52a714..538b294 100644
--- a/wmf-config/InitialiseSettings-labs.php
+++ b/wmf-config/InitialiseSettings-labs.php
@@ -274,7 +274,7 @@
'wmgMFInfoboxConfig' => array(
'default' => array(
// human
-   5 => array(
+   44076 => array(
'rows' => array(
// Born
array( 'id' => 'P476' ),

-- 
To view, visit https://gerrit.wikimedia.org/r/192709
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4f0c3466a670f19d2c13f591316c419302193535
Gerrit-PatchSet: 2
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 
Gerrit-Reviewer: Alex Monk 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: Yuvipanda 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Conditionally enable stuff depending on repo mode - change (mediawiki...WikiGrok)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Conditionally enable stuff depending on repo mode
..


Conditionally enable stuff depending on repo mode

Change-Id: Ib3203cfa1300b5f1d055a6ef5d7ee573d3477a3b
---
0 files changed, 0 insertions(+), 0 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified




-- 
To view, visit https://gerrit.wikimedia.org/r/193000
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3203cfa1300b5f1d055a6ef5d7ee573d3477a3b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikiGrok
Gerrit-Branch: wmf/1.25wmf18
Gerrit-Owner: MaxSem 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Use logstash1001 instead of logstash1002 for restbase - change (operations/puppet)

[Gage (Code Review)]

Gage has submitted this change and it was merged.

Change subject: Use logstash1001 instead of logstash1002 for restbase
..


Use logstash1001 instead of logstash1002 for restbase

logstash1002 is dropping a large portion of log messages, possibly due to some
bottleneck in its gelf ingestion pipeline & high gelf traffic from OCG.
logstash1001 is currently fairly idle & is confirmed to work reliably, and is
the preferred host to use for restbase per Bryan.

Change-Id: I5cde569872e2d88aef3fd719fac5321867a168ed
---
M hieradata/role/common/restbase.yaml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  BryanDavis: Looks good to me, but someone else must approve
  Gage: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/hieradata/role/common/restbase.yaml 
b/hieradata/role/common/restbase.yaml
index 408dff1..e76112f 100644
--- a/hieradata/role/common/restbase.yaml
+++ b/hieradata/role/common/restbase.yaml
@@ -21,7 +21,7 @@
 - restbase1004.eqiad.wmnet
 - restbase1005.eqiad.wmnet
 - restbase1006.eqiad.wmnet
-restbase::logstash_host: logstash1002.eqiad.wmnet
+restbase::logstash_host: logstash1001.eqiad.wmnet
 restbase::cassandra_defaultConsistency: localQuorum
 restbase::cassandra_localDc: "%{::site}"
 restbase::statsd_host: statsd.eqiad.wmnet

-- 
To view, visit https://gerrit.wikimedia.org/r/193006
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5cde569872e2d88aef3fd719fac5321867a168ed
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: GWicke 
Gerrit-Reviewer: BryanDavis 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Gage 
Gerrit-Reviewer: Rush 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits