date:20160529

[MediaWiki-commits] [Gerrit] [toollabs-images] Add experimental tox-jessie - change (integration/config)

2016-05-29 Thread BryanDavis (Code Review)

BryanDavis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291684

Change subject: [toollabs-images] Add experimental tox-jessie
..

[toollabs-images] Add experimental tox-jessie

Change-Id: I5794463ae92d56bc0efd08ea9122e8dd1d58a69b
---
M zuul/layout.yaml
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/84/291684/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 3989181..efe0263 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -1993,6 +1993,10 @@
   - operations-dns-lint
   - operations-dns-tabs
 
+  - name: operations/docker-images/toollabs-images
+experimental:
+  - tox-jessie
+
   - name: operations/dumps
 test:
   - tox-jessie

-- 
To view, visit https://gerrit.wikimedia.org/r/291684
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5794463ae92d56bc0efd08ea9122e8dd1d58a69b
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: BryanDavis 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [toollabs-images] Make tox-jessie voting - change (integration/config)

2016-05-29 Thread BryanDavis (Code Review)

BryanDavis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291685

Change subject: [toollabs-images] Make tox-jessie voting
..

[toollabs-images] Make tox-jessie voting

Change-Id: I58f878f3fd19dfa21a46a52464575cb06aacbb22
Depends-On: Ifbf155de741dda25636989269bc66c332bc62f6e
---
M zuul/layout.yaml
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/85/291685/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index efe0263..f994c27 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -1994,7 +1994,9 @@
   - operations-dns-tabs
 
   - name: operations/docker-images/toollabs-images
-experimental:
+test:
+  - tox-jessie
+gate-and-submit:
   - tox-jessie
 
   - name: operations/dumps

-- 
To view, visit https://gerrit.wikimedia.org/r/291685
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I58f878f3fd19dfa21a46a52464575cb06aacbb22
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: BryanDavis 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Bump wikimedia/cdb to 1.4.1 - change (mediawiki/vendor)

2016-05-29 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Bump wikimedia/cdb to 1.4.1
..


Bump wikimedia/cdb to 1.4.1

Change-Id: Id8eb51b91058039c4d16b47d241382dcacd7ff41
---
M composer.json
M composer.lock
M composer/installed.json
M wikimedia/cdb/src/Reader/Hash.php
4 files changed, 67 insertions(+), 69 deletions(-)

Approvals:
  BryanDavis: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 7671414..d7e2349 100644
--- a/composer.json
+++ b/composer.json
@@ -34,7 +34,7 @@
"wikimedia/assert": "0.2.2",
"wikimedia/avro": "1.7.7",
"wikimedia/base-convert": "1.0.1",
-   "wikimedia/cdb": "1.4.0",
+   "wikimedia/cdb": "1.4.1",
"wikimedia/cldr-plural-rule-parser": "1.0.0",
"wikimedia/composer-merge-plugin": "1.3.1",
"wikimedia/html-formatter": "1.0.1",
diff --git a/composer.lock b/composer.lock
index eeafbf0..5aab7d2 100644
--- a/composer.lock
+++ b/composer.lock
@@ -4,8 +4,8 @@
 "Read more about it at 
https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file;,
 "This file is @generated automatically"
 ],
-"hash": "7253faa6e78c67e17f3e0ed6b88e2c0c",
-"content-hash": "fa3b66688dd61115f4e93a380b664a6d",
+"hash": "014853eafd992dc582170aaa7e326f59",
+"content-hash": "b57c820fef6a8b03501865f136b2d062",
 "packages": [
 {
 "name": "composer/semver",
@@ -1284,21 +1284,20 @@
 },
 {
 "name": "wikimedia/cdb",
-"version": "1.4.0",
+"version": "1.4.1",
 "source": {
 "type": "git",
 "url": "https://github.com/wikimedia/cdb.git;,
-"reference": "de73728295f8452465dbb5ec2b680427d557e61b"
+"reference": "d49d96232f045311dc1f21bf0d7e40adf82a1f1d"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/cdb/zipball/de73728295f8452465dbb5ec2b680427d557e61b;,
-"reference": "de73728295f8452465dbb5ec2b680427d557e61b",
+"url": 
"https://api.github.com/repos/wikimedia/cdb/zipball/d49d96232f045311dc1f21bf0d7e40adf82a1f1d;,
+"reference": "d49d96232f045311dc1f21bf0d7e40adf82a1f1d",
 "shasum": ""
 },
 "require": {
-"php": ">=5.3.2",
-"wikimedia/assert": "~0.2.2"
+"php": ">=5.3.2"
 },
 "require-dev": {
 "jakub-onderka/php-parallel-lint": "0.9",
@@ -1334,7 +1333,7 @@
 ],
 "description": "Constant Database (CDB) wrapper library for PHP. 
Provides pure-PHP fallback when dba_* functions are absent.",
 "homepage": "https://www.mediawiki.org/wiki/CDB;,
-"time": "2016-05-04 21:47:24"
+"time": "2016-05-29 07:39:26"
 },
 {
 "name": "wikimedia/cldr-plural-rule-parser",
diff --git a/composer/installed.json b/composer/installed.json
index 1196d94..5ab5a72 100644
--- a/composer/installed.json
+++ b/composer/installed.json
@@ -1745,62 +1745,6 @@
 "homepage": "https://github.com/wikimedia/IPSet;
 },
 {
-"name": "wikimedia/cdb",
-"version": "1.4.0",
-"version_normalized": "1.4.0.0",
-"source": {
-"type": "git",
-"url": "https://github.com/wikimedia/cdb.git;,
-"reference": "de73728295f8452465dbb5ec2b680427d557e61b"
-},
-"dist": {
-"type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/cdb/zipball/de73728295f8452465dbb5ec2b680427d557e61b;,
-"reference": "de73728295f8452465dbb5ec2b680427d557e61b",
-"shasum": ""
-},
-"require": {
-"php": ">=5.3.2",
-"wikimedia/assert": "~0.2.2"
-},
-"require-dev": {
-"jakub-onderka/php-parallel-lint": "0.9",
-"mediawiki/mediawiki-codesniffer": "0.5.0",
-"phpunit/phpunit": "4.6.*"
-},
-"time": "2016-05-04 21:47:24",
-"type": "library",
-"installation-source": "dist",
-"autoload": {
-"classmap": [
-"src/"
-]
-},
-"notification-url": "https://packagist.org/downloads/;,
-"license": [
-"GPL-2.0+"
-],
-"authors": [
-{
-"name": "Daniel Kinzler"
-},
-{
-"name": "Tim Starling",
-"email": "tstarl...@wikimedia.org"
-},
-{
-"name": "Chad Horohoe",
-"email": "c...@wikimedia.org"
-},
-{
-"name": "Ori

[MediaWiki-commits] [Gerrit] Remove orphan PHP 5.6+ static file autoload file - change (mediawiki/vendor)

2016-05-29 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Remove orphan PHP 5.6+ static file autoload file
..


Remove orphan PHP 5.6+ static file autoload file

Bug: T135161
Change-Id: I1921b4e21517871e772a213c866db8f5564379d5
---
D composer/autoload_static.php
1 file changed, 0 insertions(+), 795 deletions(-)

Approvals:
  Ori.livneh: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer/autoload_static.php b/composer/autoload_static.php
deleted file mode 100644
index 4d23593..000
--- a/composer/autoload_static.php
+++ /dev/null
@@ -1,795 +0,0 @@
- __DIR__ . '/..' . 
'/mediawiki/at-ease/src/Functions.php',
-'c3f7f0e81464740a933532e81fa26cc7' => __DIR__ . '/..' . 
'/wikimedia/base-convert/src/Functions.php',
-'d55c27a601de788b19a09b7d057d07ae' => __DIR__ . '/..' . 
'/wikimedia/relpath/src/RelPath.php',
-);
-
-public static $prefixLengthsPsr4 = array (
-'W' => 
-array (
-'WrappedString\\' => 14,
-'Wikimedia\\Composer\\' => 19,
-'Wikimedia\\Assert\\Test\\' => 22,
-'Wikimedia\\Assert\\' => 17,
-),
-'S' => 
-array (
-'Symfony\\Component\\Process\\' => 26,
-),
-'M' => 
-array (
-'Monolog\\' => 8,
-),
-'J' => 
-array (
-'JsonSchema\\' => 11,
-),
-'F' => 
-array (
-'Firebase\\JWT\\' => 13,
-),
-'E' => 
-array (
-'Elastica\\' => 9,
-),
-'C' => 
-array (
-'Composer\\Semver\\' => 16,
-'CLDRPluralRuleParser\\' => 21,
-),
-);
-
-public static $prefixDirsPsr4 = array (
-'WrappedString\\' => 
-array (
-0 => __DIR__ . '/..' . '/wikimedia/wrappedstring/src',
-),
-'Wikimedia\\Composer\\' => 
-array (
-0 => __DIR__ . '/..' . '/wikimedia/composer-merge-plugin/src',
-),
-'Wikimedia\\Assert\\Test\\' => 
-array (
-0 => __DIR__ . '/..' . '/wikimedia/assert/tests/phpunit',
-),
-'Wikimedia\\Assert\\' => 
-array (
-0 => __DIR__ . '/..' . '/wikimedia/assert/src',
-),
-'Symfony\\Component\\Process\\' => 
-array (
-0 => __DIR__ . '/..' . '/symfony/process',
-),
-'Monolog\\' => 
-array (
-0 => __DIR__ . '/..' . '/monolog/monolog/src/Monolog',
-),
-'JsonSchema\\' => 
-array (
-0 => __DIR__ . '/..' . '/justinrainbow/json-schema/src/JsonSchema',
-),
-'Firebase\\JWT\\' => 
-array (
-0 => __DIR__ . '/..' . '/firebase/php-jwt/src',
-),
-'Elastica\\' => 
-array (
-0 => __DIR__ . '/..' . '/ruflin/elastica/lib/Elastica',
-),
-'Composer\\Semver\\' => 
-array (
-0 => __DIR__ . '/..' . '/composer/semver/src',
-),
-'CLDRPluralRuleParser\\' => 
-array (
-0 => __DIR__ . '/..' . '/wikimedia/cldr-plural-rule-parser/src',
-),
-);
-
-public static $prefixesPsr0 = array (
-'T' => 
-array (
-'TextCat' => 
-array (
-0 => __DIR__ . '/..' . '/wikimedia/textcat',
-),
-),
-'P' => 
-array (
-'Psr\\Log\\' => 
-array (
-0 => __DIR__ . '/..' . '/psr/log',
-),
-'PEAR' => 
-array (
-0 => __DIR__ . '/..' . '/pear/pear_exception',
-),
-),
-'N' => 
-array (
-'Net' => 
-array (
-0 => __DIR__ . '/..' . '/pear/net_socket',
-1 => __DIR__ . '/..' . '/pear/net_smtp',
-),
-),
-'M' => 
-array (
-'Mail_mimeDecode' => 
-array (
-0 => __DIR__ . '/..' . '/pear/mail_mime-decode',
-),
-'Mail' => 
-array (
-0 => __DIR__ . '/..' . '/pear/mail_mime',
-1 => __DIR__ . '/..' . '/pear/mail',
-),
-),
-'L' => 
-array (
-'Liuggio' => 
-array (
-0 => __DIR__ . '/..' . '/liuggio/statsd-php-client/src',
-),
-'Less' => 
-array (
-0 => __DIR__ . '/..' . '/oyejorge/less.php/lib',
-),
-),
-'K' => 
-array (
-'Kafka\\' => 
-array (
-0 => __DIR__ . '/..' . '/nmred/kafka-php/src',
-),
-),
-'C' => 
-array (
-'Console' => 
-array (
-0 => __DIR__ . '/..' . '/pear/console_getopt',
-

[MediaWiki-commits] [Gerrit] Easify disabled `.oo-ui-tool-link` rules - change (oojs/ui)

2016-05-29 Thread VolkerE (Code Review)

VolkerE has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291683

Change subject: Easify disabled `.oo-ui-tool-link` rules
..

Easify disabled `.oo-ui-tool-link` rules

Concatenating & reducing disabled `.oo-ui-tool-link` rules across ToolGroup
files.

Change-Id: I37e10e8f8cb2e6bf232798b1d13f85d97ffdcf6a
---
M src/styles/ToolGroup.less
M src/styles/toolgroups/BarToolGroup.less
M src/styles/toolgroups/ListToolGroup.less
M src/styles/toolgroups/MenuToolGroup.less
M src/styles/toolgroups/PopupToolGroup.less
5 files changed, 9 insertions(+), 33 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/83/291683/1

diff --git a/src/styles/ToolGroup.less b/src/styles/ToolGroup.less
index f2fe4e7..3f024e5 100644
--- a/src/styles/ToolGroup.less
+++ b/src/styles/ToolGroup.less
@@ -10,6 +10,14 @@
 
.oo-ui-tool-link {
text-decoration: none;
+   cursor: pointer;
+   }
+
+   &.oo-ui-widget-disabled .oo-ui-tool-link,
+   .oo-ui-widget-disabled > .oo-ui-tool-link,
+   .oo-ui-tool-link[aria-disabled="true"] {
+   outline: 0;
+   cursor: default;
}
 
.theme-oo-ui-toolGroup();
diff --git a/src/styles/toolgroups/BarToolGroup.less 
b/src/styles/toolgroups/BarToolGroup.less
index 1611a9d..70a0e1b 100644
--- a/src/styles/toolgroups/BarToolGroup.less
+++ b/src/styles/toolgroups/BarToolGroup.less
@@ -6,12 +6,6 @@
display: none;
}
 
-   &.oo-ui-widget-enabled > .oo-ui-toolGroup-tools > .oo-ui-tool {
-   > .oo-ui-tool-link {
-   cursor: pointer;
-   }
-   }
-
> .oo-ui-toolGroup-tools > .oo-ui-tool {
display: inline-block;
position: relative;
@@ -40,11 +34,6 @@
.oo-ui-tool-title {
display: inline;
}
-   }
-
-   &.oo-ui-widget-disabled > .oo-ui-tool-link {
-   outline: 0;
-   cursor: default;
}
}
 
diff --git a/src/styles/toolgroups/ListToolGroup.less 
b/src/styles/toolgroups/ListToolGroup.less
index 406c230..09bcfd8 100644
--- a/src/styles/toolgroups/ListToolGroup.less
+++ b/src/styles/toolgroups/ListToolGroup.less
@@ -3,18 +3,7 @@
 .oo-ui-listToolGroup {
.oo-ui-tool {
display: block;
-
.oo-ui-box-sizing( border-box );
-
-   &-link {
-   cursor: pointer;
-   }
-
-   &.oo-ui-widget-disabled {
-   .oo-ui-tool-link {
-   cursor: default;
-   }
-   }
}
 
.theme-oo-ui-listToolGroup();
diff --git a/src/styles/toolgroups/MenuToolGroup.less 
b/src/styles/toolgroups/MenuToolGroup.less
index cfbbe0b..08fd99f 100644
--- a/src/styles/toolgroups/MenuToolGroup.less
+++ b/src/styles/toolgroups/MenuToolGroup.less
@@ -3,16 +3,6 @@
 .oo-ui-menuToolGroup {
.oo-ui-tool {
display: block;
-
-   &-link {
-   cursor: pointer;
-   }
-
-   &.oo-ui-widget-disabled {
-   .oo-ui-tool-link {
-   cursor: default;
-   }
-   }
}
 
.theme-oo-ui-menuToolGroup();
diff --git a/src/styles/toolgroups/PopupToolGroup.less 
b/src/styles/toolgroups/PopupToolGroup.less
index 35ae1a3..0cd6563 100644
--- a/src/styles/toolgroups/PopupToolGroup.less
+++ b/src/styles/toolgroups/PopupToolGroup.less
@@ -57,7 +57,7 @@
text-align: right;
}
 
-   .oo-ui-tool-accel:not(:empty) {
+   .oo-ui-tool-accel:not( :empty ) {
// Push away from tool's title
padding-left: 3em;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/291683
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I37e10e8f8cb2e6bf232798b1d13f85d97ffdcf6a
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove orphan PHP 5.6+ static file autoload file - change (mediawiki/vendor)

2016-05-29 Thread BryanDavis (Code Review)

BryanDavis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291682

Change subject: Remove orphan PHP 5.6+ static file autoload file
..

Remove orphan PHP 5.6+ static file autoload file

Bug: T135161
Change-Id: I1921b4e21517871e772a213c866db8f5564379d5
---
D composer/autoload_static.php
1 file changed, 0 insertions(+), 795 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vendor 
refs/changes/82/291682/1

diff --git a/composer/autoload_static.php b/composer/autoload_static.php
deleted file mode 100644
index 4d23593..000
--- a/composer/autoload_static.php
+++ /dev/null
@@ -1,795 +0,0 @@
- __DIR__ . '/..' . 
'/mediawiki/at-ease/src/Functions.php',
-'c3f7f0e81464740a933532e81fa26cc7' => __DIR__ . '/..' . 
'/wikimedia/base-convert/src/Functions.php',
-'d55c27a601de788b19a09b7d057d07ae' => __DIR__ . '/..' . 
'/wikimedia/relpath/src/RelPath.php',
-);
-
-public static $prefixLengthsPsr4 = array (
-'W' => 
-array (
-'WrappedString\\' => 14,
-'Wikimedia\\Composer\\' => 19,
-'Wikimedia\\Assert\\Test\\' => 22,
-'Wikimedia\\Assert\\' => 17,
-),
-'S' => 
-array (
-'Symfony\\Component\\Process\\' => 26,
-),
-'M' => 
-array (
-'Monolog\\' => 8,
-),
-'J' => 
-array (
-'JsonSchema\\' => 11,
-),
-'F' => 
-array (
-'Firebase\\JWT\\' => 13,
-),
-'E' => 
-array (
-'Elastica\\' => 9,
-),
-'C' => 
-array (
-'Composer\\Semver\\' => 16,
-'CLDRPluralRuleParser\\' => 21,
-),
-);
-
-public static $prefixDirsPsr4 = array (
-'WrappedString\\' => 
-array (
-0 => __DIR__ . '/..' . '/wikimedia/wrappedstring/src',
-),
-'Wikimedia\\Composer\\' => 
-array (
-0 => __DIR__ . '/..' . '/wikimedia/composer-merge-plugin/src',
-),
-'Wikimedia\\Assert\\Test\\' => 
-array (
-0 => __DIR__ . '/..' . '/wikimedia/assert/tests/phpunit',
-),
-'Wikimedia\\Assert\\' => 
-array (
-0 => __DIR__ . '/..' . '/wikimedia/assert/src',
-),
-'Symfony\\Component\\Process\\' => 
-array (
-0 => __DIR__ . '/..' . '/symfony/process',
-),
-'Monolog\\' => 
-array (
-0 => __DIR__ . '/..' . '/monolog/monolog/src/Monolog',
-),
-'JsonSchema\\' => 
-array (
-0 => __DIR__ . '/..' . '/justinrainbow/json-schema/src/JsonSchema',
-),
-'Firebase\\JWT\\' => 
-array (
-0 => __DIR__ . '/..' . '/firebase/php-jwt/src',
-),
-'Elastica\\' => 
-array (
-0 => __DIR__ . '/..' . '/ruflin/elastica/lib/Elastica',
-),
-'Composer\\Semver\\' => 
-array (
-0 => __DIR__ . '/..' . '/composer/semver/src',
-),
-'CLDRPluralRuleParser\\' => 
-array (
-0 => __DIR__ . '/..' . '/wikimedia/cldr-plural-rule-parser/src',
-),
-);
-
-public static $prefixesPsr0 = array (
-'T' => 
-array (
-'TextCat' => 
-array (
-0 => __DIR__ . '/..' . '/wikimedia/textcat',
-),
-),
-'P' => 
-array (
-'Psr\\Log\\' => 
-array (
-0 => __DIR__ . '/..' . '/psr/log',
-),
-'PEAR' => 
-array (
-0 => __DIR__ . '/..' . '/pear/pear_exception',
-),
-),
-'N' => 
-array (
-'Net' => 
-array (
-0 => __DIR__ . '/..' . '/pear/net_socket',
-1 => __DIR__ . '/..' . '/pear/net_smtp',
-),
-),
-'M' => 
-array (
-'Mail_mimeDecode' => 
-array (
-0 => __DIR__ . '/..' . '/pear/mail_mime-decode',
-),
-'Mail' => 
-array (
-0 => __DIR__ . '/..' . '/pear/mail_mime',
-1 => __DIR__ . '/..' . '/pear/mail',
-),
-),
-'L' => 
-array (
-'Liuggio' => 
-array (
-0 => __DIR__ . '/..' . '/liuggio/statsd-php-client/src',
-),
-'Less' => 
-array (
-0 => __DIR__ . '/..' . '/oyejorge/less.php/lib',
-),
-),
-'K' => 
-array (
-'Kafka\\' => 
-array (
-0 => __DIR__ . '/..' . '/nmred/kafka-php/src',
-),
-),
-'C' => 
-array (
-'Console' => 
-array (
-0 => __DIR__ .

[MediaWiki-commits] [Gerrit] Drop dependency on wikimedia/cdb - change (operations/mediawiki-config)

2016-05-29 Thread Ori.livneh (Code Review)

Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291681

Change subject: Drop dependency on wikimedia/cdb
..

Drop dependency on wikimedia/cdb

Unused as of Ib5407c560.

Change-Id: I5ac86f190bd35d3c3d2783a4db56ce4c13e3bd4c
---
M composer.json
M composer.lock
M multiversion/vendor/composer/autoload_classmap.php
M multiversion/vendor/composer/installed.json
D multiversion/vendor/wikimedia/cdb/COPYING
D multiversion/vendor/wikimedia/cdb/README.md
D multiversion/vendor/wikimedia/cdb/src/Exception.php
D multiversion/vendor/wikimedia/cdb/src/Reader.php
D multiversion/vendor/wikimedia/cdb/src/Reader/DBA.php
D multiversion/vendor/wikimedia/cdb/src/Reader/PHP.php
D multiversion/vendor/wikimedia/cdb/src/Util.php
D multiversion/vendor/wikimedia/cdb/src/Writer.php
D multiversion/vendor/wikimedia/cdb/src/Writer/DBA.php
D multiversion/vendor/wikimedia/cdb/src/Writer/PHP.php
14 files changed, 3 insertions(+), 1,502 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/81/291681/1

diff --git a/composer.json b/composer.json
index 78bc6c7..23d5667 100644
--- a/composer.json
+++ b/composer.json
@@ -3,8 +3,7 @@
"description": "MediaWiki configuration for the Wikimedia farm",
"require": {
"mongofill/mongofill": "dev-master",
-   "perftools/xhgui": "dev-master",
-   "wikimedia/cdb": "1.3.0"
+   "perftools/xhgui": "dev-master"
},
"config": {
"classmap-authoritative": true,
diff --git a/composer.lock b/composer.lock
index 5278bd8..79b2af6 100644
--- a/composer.lock
+++ b/composer.lock
@@ -4,8 +4,8 @@
 "Read more about it at 
https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file;,
 "This file is @generated automatically"
 ],
-"hash": "02067c53f4e15c62e1e67257dc05133b",
-"content-hash": "db07206335a834c3ec1e3abdbbbe1fb3",
+"hash": "e52113abcd744e080be1709ea3449454",
+"content-hash": "3b28444c4f548c82581db20afa6f4f99",
 "packages": [
 {
 "name": "mongofill/mongofill",
@@ -381,56 +381,6 @@
 "templating"
 ],
 "time": "2016-01-25 21:22:18"
-},
-{
-"name": "wikimedia/cdb",
-"version": "1.3.0",
-"source": {
-"type": "git",
-"url": "https://github.com/wikimedia/cdb.git;,
-"reference": "68f8fd495ca94ca0e965dd511e234893c515bb95"
-},
-"dist": {
-"type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/cdb/zipball/68f8fd495ca94ca0e965dd511e234893c515bb95;,
-"reference": "68f8fd495ca94ca0e965dd511e234893c515bb95",
-"shasum": ""
-},
-"require": {
-"php": ">=5.3.2"
-},
-"require-dev": {
-"jakub-onderka/php-parallel-lint": "0.9",
-"mediawiki/mediawiki-codesniffer": "0.3.0",
-"phpunit/phpunit": "4.6.*"
-},
-"type": "library",
-"autoload": {
-"classmap": [
-"src/"
-]
-},
-"notification-url": "https://packagist.org/downloads/;,
-"license": [
-"GPL-2.0+"
-],
-"authors": [
-{
-"name": "Tim Starling",
-"email": "tstarl...@wikimedia.org"
-},
-{
-"name": "Chad Horohoe",
-"email": "c...@wikimedia.org"
-},
-{
-"name": "Ori Livneh",
-"email": "o...@wikimedia.org"
-}
-],
-"description": "Constant Database (CDB) wrapper library for PHP. 
Provides pure-PHP fallback when dba_* functions are absent.",
-"homepage": "https://www.mediawiki.org/wiki/CDB;,
-"time": "2015-09-08 19:53:04"
 }
 ],
 "packages-dev": [],
diff --git a/multiversion/vendor/composer/autoload_classmap.php 
b/multiversion/vendor/composer/autoload_classmap.php
index 523a6e1..cc6c5a3 100644
--- a/multiversion/vendor/composer/autoload_classmap.php
+++ b/multiversion/vendor/composer/autoload_classmap.php
@@ -6,14 +6,6 @@
 $baseDir = dirname(dirname($vendorDir));
 
 return array(
-'Cdb\\Exception' => $vendorDir . '/wikimedia/cdb/src/Exception.php',
-'Cdb\\Reader' => $vendorDir . '/wikimedia/cdb/src/Reader.php',
-'Cdb\\Reader\\DBA' => $vendorDir . '/wikimedia/cdb/src/Reader/DBA.php',
-'Cdb\\Reader\\PHP' => $vendorDir . '/wikimedia/cdb/src/Reader/PHP.php',
-'Cdb\\Util' => $vendorDir . '/wikimedia/cdb/src/Util.php',
-'Cdb\\Writer' => $vendorDir . '/wikimedia/cdb/src/Writer.php',
-

[MediaWiki-commits] [Gerrit] Bump wikimedia/cdb to 1.4.0 - change (mediawiki/vendor)

2016-05-29 Thread Ori.livneh (Code Review)

Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291680

Change subject: Bump wikimedia/cdb to 1.4.0
..

Bump wikimedia/cdb to 1.4.0

Change-Id: Id8eb51b91058039c4d16b47d241382dcacd7ff41
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vendor 
refs/changes/80/291680/1

diff --git a/composer.json b/composer.json
index 7671414..d7e2349 100644
--- a/composer.json
+++ b/composer.json
@@ -34,7 +34,7 @@
"wikimedia/assert": "0.2.2",
"wikimedia/avro": "1.7.7",
"wikimedia/base-convert": "1.0.1",
-   "wikimedia/cdb": "1.4.0",
+   "wikimedia/cdb": "1.4.1",
"wikimedia/cldr-plural-rule-parser": "1.0.0",
"wikimedia/composer-merge-plugin": "1.3.1",
"wikimedia/html-formatter": "1.0.1",

-- 
To view, visit https://gerrit.wikimedia.org/r/291680
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8eb51b91058039c4d16b47d241382dcacd7ff41
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vendor
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia/cdb: 1.4.0 => 1.4.1 - change (mediawiki/core)

2016-05-29 Thread Ori.livneh (Code Review)

Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291679

Change subject: wikimedia/cdb: 1.4.0 => 1.4.1
..

wikimedia/cdb: 1.4.0 => 1.4.1

Updated for I5a7a9f259: stop using wikimedia/assert

Change-Id: I8c867eeb3e6612b85db1373e5a25565861174f07
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/79/291679/1

diff --git a/composer.json b/composer.json
index 31d8036..eddb5b0 100644
--- a/composer.json
+++ b/composer.json
@@ -31,7 +31,7 @@
"psr/log": "1.0.0",
"wikimedia/assert": "0.2.2",
"wikimedia/base-convert": "1.0.1",
-   "wikimedia/cdb": "1.4.0",
+   "wikimedia/cdb": "1.4.1",
"wikimedia/cldr-plural-rule-parser": "1.0.0",
"wikimedia/composer-merge-plugin": "1.3.1",
"wikimedia/html-formatter": "1.0.1",

-- 
To view, visit https://gerrit.wikimedia.org/r/291679
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c867eeb3e6612b85db1373e5a25565861174f07
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Adjust recent added tests for case-sensitive site - change (pywikibot/core)

2016-05-29 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Adjust recent added tests for case-sensitive site
..


Adjust recent added tests for case-sensitive site

2230213 caused new errors on the Travis wiktionary jobs.

Also fix non-pep8 method names.

Bug: T134676
Change-Id: I4eabed2fb7ebeaf1516bb1f80c00a50050efb51c
---
M tests/textlib_tests.py
1 file changed, 25 insertions(+), 9 deletions(-)

Approvals:
  John Vandenberg: Looks good to me, but someone else must approve
  Xqt: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/textlib_tests.py b/tests/textlib_tests.py
index e4dbc57..e6d67ff 100644
--- a/tests/textlib_tests.py
+++ b/tests/textlib_tests.py
@@ -1353,44 +1353,60 @@
 
 dry = True
 
-def test_noMatch(self):
+@classmethod
+def setUpClass(cls):
+"""Cache namespace 10 (Template) case sensitivity."""
+super(TestMultiTemplateMatchBuilder, cls).setUpClass()
+cls._template_not_case_sensitive = (
+cls.get_site().namespaces.TEMPLATE.case != 'case-sensitive')
+
+def test_no_match(self):
 """Test text without any desired templates."""
 string = 'The quick brown fox'
 builder = _MultiTemplateMatchBuilder(self.site)
 self.assertIsNone(re.search(builder.pattern('quick'), string))
 
-def test_Match(self):
+def test_match(self):
 """Test text with one match without parameters."""
 string = 'The {{quick}} brown fox'
 builder = _MultiTemplateMatchBuilder(self.site)
 self.assertIsNotNone(re.search(builder.pattern('quick'), string))
-self.assertIsNotNone(re.search(builder.pattern('Quick'), string))
+self.assertEqual(bool(re.search(builder.pattern('Quick'), string)),
+ self._template_not_case_sensitive)
 
 def test_match_with_params(self):
 """Test text with one match with parameters."""
-string = 'The {{Quick|brown}} fox'
+string = 'The {{quick|brown}} fox'
 builder = _MultiTemplateMatchBuilder(self.site)
 self.assertIsNotNone(re.search(builder.pattern('quick'), string))
-self.assertIsNotNone(re.search(builder.pattern('Quick'), string))
+self.assertEqual(bool(re.search(builder.pattern('Quick'), string)),
+ self._template_not_case_sensitive)
 
 def test_match_msg(self):
 """Test text with {{msg:..}}."""
 string = 'The {{msg:quick}} brown fox'
 builder = _MultiTemplateMatchBuilder(self.site)
 self.assertIsNotNone(re.search(builder.pattern('quick'), string))
-self.assertIsNotNone(re.search(builder.pattern('Quick'), string))
+self.assertEqual(bool(re.search(builder.pattern('Quick'), string)),
+ self._template_not_case_sensitive)
 
 def test_match_template_prefix(self):
 """Test pages with {{template:..}}."""
 string = 'The {{%s:%s}} brown fox'
 template = 'template'
 builder = _MultiTemplateMatchBuilder(self.site)
+if self._template_not_case_sensitive:
+quick_list = ('quick', 'Quick')
+else:
+quick_list = ('quick', )
+
 for t in (template.upper(), template.lower(), template.title()):
-for q in ('quick', 'Quick'):
+for q in quick_list:
 self.assertIsNotNone(re.search(builder.pattern('quick'),
string % (t, q)))
-self.assertIsNotNone(re.search(builder.pattern('Quick'),
-   string % (t, q)))
+self.assertEqual(bool(re.search(builder.pattern('Quick'),
+string % (t, q))),
+ self._template_not_case_sensitive)
 
 
 class TestGetLanguageLinks(SiteAttributeTestCase):

-- 
To view, visit https://gerrit.wikimedia.org/r/291577
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4eabed2fb7ebeaf1516bb1f80c00a50050efb51c
Gerrit-PatchSet: 3
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg 
Gerrit-Reviewer: John Vandenberg 
Gerrit-Reviewer: Xqt 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] stop using wikimedia/assert - change (cdb)

2016-05-29 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: stop using wikimedia/assert
..


stop using wikimedia/assert

In XHProf profiles of Wikimedia edit requests, Wikimedia\Assert\Assert::hasType
has ranks somewhere between second and fourth place when sorting function calls
by exclusive CPU time. Replace it with a simple is_array() check and stop
verifying the type of each of the array's values.

Change-Id: I5a7a9f25912f4f1d8d2c274237999718bc8e68dd
---
M composer.json
M src/Reader/Hash.php
M tests/Reader/HashTest.php
3 files changed, 6 insertions(+), 18 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index f6c7fb7..bf54635 100644
--- a/composer.json
+++ b/composer.json
@@ -26,8 +26,7 @@
]
},
"require": {
-   "php": ">=5.3.2",
-   "wikimedia/assert": "~0.2.2"
+   "php": ">=5.3.2"
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9",
diff --git a/src/Reader/Hash.php b/src/Reader/Hash.php
index 3010305..36bbc3b 100644
--- a/src/Reader/Hash.php
+++ b/src/Reader/Hash.php
@@ -52,9 +52,9 @@
 * @param string[] $data An associative PHP array.
 */
public function __construct( $data ) {
-   Assert::parameterType( 'array', $data, '$data' );
-   Assert::parameterElementType( 'string', $data, '$data' );
-
+   if ( !is_array( $data ) ) {
+   throw new \InvalidArgumentException( __METHOD__ . ': 
"$data" must be an array.' );
+   }
$this->data = $data;
}
 
diff --git a/tests/Reader/HashTest.php b/tests/Reader/HashTest.php
index bab34e7..70401fa 100644
--- a/tests/Reader/HashTest.php
+++ b/tests/Reader/HashTest.php
@@ -9,20 +9,9 @@
  */
 class HashTest extends \PHPUnit_Framework_TestCase {
 
-   public function provideConstructor_fail() {
-   return array(
-   array( 'Foo' ),
-   array( array( "x" => 1, "y" => 2 ) ),
-   );
-   }
-
-   /**
-* @dataProvider provideConstructor_fail
-*/
-   public function testConstructor_fail( $data ) {
+   public function testConstructor_fail() {
$this->setExpectedException( 'InvalidArgumentException' );
-
-   new Hash( $data );
+   new Hash( 'not an array' );
}
 
public function testClose() {

-- 
To view, visit https://gerrit.wikimedia.org/r/291581
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5a7a9f25912f4f1d8d2c274237999718bc8e68dd
Gerrit-PatchSet: 1
Gerrit-Project: cdb
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: Gilles 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Ori.livneh 
Gerrit-Reviewer: Tim Starling 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Use B/I for English variants - change (oojs/ui)

2016-05-29 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Use B/I for English variants
..


Use B/I for English variants

Change-Id: Ie1a63fbe337d618bc2f20d93b15fb3934bc08dce
---
M src/themes/apex/icons-editing-styling.json
M src/themes/mediawiki/icons-editing-styling.json
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/themes/apex/icons-editing-styling.json 
b/src/themes/apex/icons-editing-styling.json
index bd26399..8ee7449 100644
--- a/src/themes/apex/icons-editing-styling.json
+++ b/src/themes/apex/icons-editing-styling.json
@@ -23,7 +23,7 @@
"lang": {
"ar": "images/icons/bold-arab-ain.svg",
"be": "images/icons/bold-cyrl-te.svg",
-   "cs,en,he,ml,pl,sco": "images/icons/bold-b.svg",
+   "cs,en,en-ca,en-gb,he,ml,pl,sco": 
"images/icons/bold-b.svg",
"da,de,hu,ksh,nn,no,sv": 
"images/icons/bold-f.svg",
"es,gl,pt": "images/icons/bold-n.svg",
"eu,fi": "images/icons/bold-l.svg",
@@ -40,7 +40,7 @@
"default": "images/icons/italic-a.svg",
"lang": {
"ar": 
"images/icons/italic-arab-meem.svg",
-   "cs,en,fr,he,ml,pl,pt,sco": 
"images/icons/italic-i.svg",
+   "cs,en,en-ca,en-gb,fr,he,ml,pl,pt,sco": 
"images/icons/italic-i.svg",
"be,da,de,fi,ky,nn,no,os,sv,ru,uk": 
"images/icons/italic-k.svg",
"es,gl,it,nl": 
"images/icons/italic-c.svg",
"eu": "images/icons/italic-e.svg",
diff --git a/src/themes/mediawiki/icons-editing-styling.json 
b/src/themes/mediawiki/icons-editing-styling.json
index 45c6a64..6158a70 100644
--- a/src/themes/mediawiki/icons-editing-styling.json
+++ b/src/themes/mediawiki/icons-editing-styling.json
@@ -30,7 +30,7 @@
"lang": {
"ar": "images/icons/bold-arab-ain.svg",
"be": "images/icons/bold-cyrl-te.svg",
-   "cs,en,he,ml,pl,sco": "images/icons/bold-b.svg",
+   "cs,en,en-ca,en-gb,he,ml,pl,sco": 
"images/icons/bold-b.svg",
"da,de,hu,ksh,nn,no,sv": 
"images/icons/bold-f.svg",
"es,gl,pt": "images/icons/bold-n.svg",
"eu,fi": "images/icons/bold-l.svg",
@@ -47,7 +47,7 @@
"default": "images/icons/italic-a.svg",
"lang": {
"ar": 
"images/icons/italic-arab-meem.svg",
-   "cs,en,fr,he,ml,pl,pt,sco": 
"images/icons/italic-i.svg",
+   "cs,en,en-ca,en-gb,fr,he,ml,pl,pt,sco": 
"images/icons/italic-i.svg",
"be,da,de,fi,ky,nn,no,os,sv,ru,uk": 
"images/icons/italic-k.svg",
"es,gl,it,nl": 
"images/icons/italic-c.svg",
"eu": "images/icons/italic-e.svg",

-- 
To view, visit https://gerrit.wikimedia.org/r/291677
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1a63fbe337d618bc2f20d93b15fb3934bc08dce
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix required field calculation in AuthenticationRequest - change (mediawiki/core)

2016-05-29 Thread Code Review

Gergő Tisza has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291678

Change subject: Fix required field calculation in AuthenticationRequest
..

Fix required field calculation in AuthenticationRequest

Instead of only flagging fields which are required by a request
needed by all primairy providers, it should be enough if all
requests needed by some primary provider require that field.

Bug: T85853
Change-Id: I9d33bd22295758cc532a260b1848616b41d94f12
---
M includes/auth/AuthenticationRequest.php
M tests/phpunit/includes/auth/AuthenticationRequestTest.php
2 files changed, 33 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/78/291678/1

diff --git a/includes/auth/AuthenticationRequest.php 
b/includes/auth/AuthenticationRequest.php
index 3c19b87..f314849 100644
--- a/includes/auth/AuthenticationRequest.php
+++ b/includes/auth/AuthenticationRequest.php
@@ -281,6 +281,21 @@
public static function mergeFieldInfo( array $reqs ) {
$merged = [];
 
+   // fields that are required by some primary providers but not 
others are not actually required
+   $primaryRequests = array_filter( $reqs, function ( $req ) {
+   return $req->required === 
AuthenticationRequest::PRIMARY_REQUIRED;
+   } );
+   $sharedRequiredPrimaryFields = array_reduce( $primaryRequests, 
function ( $shared, $req ) {
+   $required = array_keys( array_filter( 
$req->getFieldInfo(), function ( $options ) {
+   return empty( $options['optional'] );
+   } ) );
+   if ( $shared === null ) {
+   return $required;
+   } else {
+   return array_intersect( $shared, $required );
+   }
+   }, null );
+
foreach ( $reqs as $req ) {
$info = $req->getFieldInfo();
if ( !$info ) {
@@ -288,8 +303,14 @@
}
 
foreach ( $info as $name => $options ) {
-   if ( $req->required !== self::REQUIRED ) {
+   if (
// If the request isn't required, its 
fields aren't required either.
+   $req->required === self::OPTIONAL
+   // If there is a primary not requiring 
this field, no matter how many others do,
+   // authentication can proceed without 
it.
+   || $req->required === 
self::PRIMARY_REQUIRED
+   && !in_array( $name, 
$sharedRequiredPrimaryFields, true )
+   ) {
$options['optional'] = true;
} else {
$options['optional'] = !empty( 
$options['optional'] );
diff --git a/tests/phpunit/includes/auth/AuthenticationRequestTest.php 
b/tests/phpunit/includes/auth/AuthenticationRequestTest.php
index 84a0ea6..cac031c 100644
--- a/tests/phpunit/includes/auth/AuthenticationRequestTest.php
+++ b/tests/phpunit/includes/auth/AuthenticationRequestTest.php
@@ -243,14 +243,6 @@
 
$req1->required = AuthenticationRequest::PRIMARY_REQUIRED;
 
-   $fields = AuthenticationRequest::mergeFieldInfo( [ $req1 ] );
-   $expect = $req1->getFieldInfo();
-   foreach ( $expect as $name => &$options ) {
-   $options['optional'] = true;
-   }
-   unset( $options );
-   $this->assertEquals( $expect, $fields );
-
$fields = AuthenticationRequest::mergeFieldInfo( [ $req1, $req2 
] );
$expect += $req2->getFieldInfo();
$expect['string1']['optional'] = false;
@@ -258,6 +250,17 @@
$expect['select']['optional'] = false;
$expect['select']['options']['bar'] = $msg;
$this->assertEquals( $expect, $fields );
+
+   $req2->required = AuthenticationRequest::PRIMARY_REQUIRED;
+
+   $fields = AuthenticationRequest::mergeFieldInfo( [ $req1, $req2 
] );
+   $expect = $req1->getFieldInfo() + $req2->getFieldInfo();
+   $expect['string1']['optional'] = false;
+   $expect['string2']['optional'] = true;
+   $expect['string3']['optional'] = true;
+   $expect['select']['optional'] = false;
+   $expect['select']['options']['bar'] = $msg;
+   $this->assertEquals( $expect, $fields );
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/291678
To unsubscribe,

[MediaWiki-commits] [Gerrit] enable instance restbase1008-c.eqiad.wmnet - change (operations/puppet)

2016-05-29 Thread Yuvipanda (Code Review)

Yuvipanda has submitted this change and it was merged.

Change subject: enable instance restbase1008-c.eqiad.wmnet
..


enable instance restbase1008-c.eqiad.wmnet

Bug: T134016
Change-Id: I84b94f87512a6023cef89d9a193e76fa2781a74b
---
M hieradata/hosts/restbase1008.yaml
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Yuvipanda: Verified; Looks good to me, approved



diff --git a/hieradata/hosts/restbase1008.yaml 
b/hieradata/hosts/restbase1008.yaml
index b0630ea..fbf7593 100644
--- a/hieradata/hosts/restbase1008.yaml
+++ b/hieradata/hosts/restbase1008.yaml
@@ -14,8 +14,8 @@
 listen_address: 10.64.32.195
 rpc_address: 10.64.32.195
 rpc_interface: eth0
-#  c:
-#jmx_port: 7191
-#listen_address: 10.64.32.196
-#rpc_address: 10.64.32.196
-#rpc_interface: eth0
+  c:
+jmx_port: 7191
+listen_address: 10.64.32.196
+rpc_address: 10.64.32.196
+rpc_interface: eth0

-- 
To view, visit https://gerrit.wikimedia.org/r/291579
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I84b94f87512a6023cef89d9a193e76fa2781a74b
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Eevans 
Gerrit-Reviewer: Yuvipanda 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] k8s: Expand types of resources accessible to normal users - change (operations/puppet)

2016-05-29 Thread Yuvipanda (Code Review)

Yuvipanda has submitted this change and it was merged.

Change subject: k8s: Expand types of resources accessible to normal users
..


k8s: Expand types of resources accessible to normal users

Add deployments, replicasets & configmaps.

Change-Id: Idb8150952a90287a569b99b11ac35ff78e8a15c6
---
M modules/k8s/manifests/apiserver.pp
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Yuvipanda: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/k8s/manifests/apiserver.pp 
b/modules/k8s/manifests/apiserver.pp
index 32f36a0..c568ab2 100644
--- a/modules/k8s/manifests/apiserver.pp
+++ b/modules/k8s/manifests/apiserver.pp
@@ -34,6 +34,9 @@
 'replicationcontrollers',
 'services',
 'secrets',
+'deployments',
+'replicasets',
+'configmaps',
 ]
 
 file { '/etc/kubernetes/abac':

-- 
To view, visit https://gerrit.wikimedia.org/r/291490
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idb8150952a90287a569b99b11ac35ff78e8a15c6
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Yuvipanda 
Gerrit-Reviewer: Gehel 
Gerrit-Reviewer: Yuvipanda 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Use B/I for English variants - change (oojs/ui)

2016-05-29 Thread Esanders (Code Review)

Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291677

Change subject: Use B/I for English variants
..

Use B/I for English variants

Change-Id: Ie1a63fbe337d618bc2f20d93b15fb3934bc08dce
---
M src/themes/apex/icons-editing-styling.json
M src/themes/mediawiki/icons-editing-styling.json
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/77/291677/1

diff --git a/src/themes/apex/icons-editing-styling.json 
b/src/themes/apex/icons-editing-styling.json
index bd26399..8ee7449 100644
--- a/src/themes/apex/icons-editing-styling.json
+++ b/src/themes/apex/icons-editing-styling.json
@@ -23,7 +23,7 @@
"lang": {
"ar": "images/icons/bold-arab-ain.svg",
"be": "images/icons/bold-cyrl-te.svg",
-   "cs,en,he,ml,pl,sco": "images/icons/bold-b.svg",
+   "cs,en,en-ca,en-gb,he,ml,pl,sco": 
"images/icons/bold-b.svg",
"da,de,hu,ksh,nn,no,sv": 
"images/icons/bold-f.svg",
"es,gl,pt": "images/icons/bold-n.svg",
"eu,fi": "images/icons/bold-l.svg",
@@ -40,7 +40,7 @@
"default": "images/icons/italic-a.svg",
"lang": {
"ar": 
"images/icons/italic-arab-meem.svg",
-   "cs,en,fr,he,ml,pl,pt,sco": 
"images/icons/italic-i.svg",
+   "cs,en,en-ca,en-gb,fr,he,ml,pl,pt,sco": 
"images/icons/italic-i.svg",
"be,da,de,fi,ky,nn,no,os,sv,ru,uk": 
"images/icons/italic-k.svg",
"es,gl,it,nl": 
"images/icons/italic-c.svg",
"eu": "images/icons/italic-e.svg",
diff --git a/src/themes/mediawiki/icons-editing-styling.json 
b/src/themes/mediawiki/icons-editing-styling.json
index 45c6a64..6158a70 100644
--- a/src/themes/mediawiki/icons-editing-styling.json
+++ b/src/themes/mediawiki/icons-editing-styling.json
@@ -30,7 +30,7 @@
"lang": {
"ar": "images/icons/bold-arab-ain.svg",
"be": "images/icons/bold-cyrl-te.svg",
-   "cs,en,he,ml,pl,sco": "images/icons/bold-b.svg",
+   "cs,en,en-ca,en-gb,he,ml,pl,sco": 
"images/icons/bold-b.svg",
"da,de,hu,ksh,nn,no,sv": 
"images/icons/bold-f.svg",
"es,gl,pt": "images/icons/bold-n.svg",
"eu,fi": "images/icons/bold-l.svg",
@@ -47,7 +47,7 @@
"default": "images/icons/italic-a.svg",
"lang": {
"ar": 
"images/icons/italic-arab-meem.svg",
-   "cs,en,fr,he,ml,pl,pt,sco": 
"images/icons/italic-i.svg",
+   "cs,en,en-ca,en-gb,fr,he,ml,pl,pt,sco": 
"images/icons/italic-i.svg",
"be,da,de,fi,ky,nn,no,os,sv,ru,uk": 
"images/icons/italic-k.svg",
"es,gl,it,nl": 
"images/icons/italic-c.svg",
"eu": "images/icons/italic-e.svg",

-- 
To view, visit https://gerrit.wikimedia.org/r/291677
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1a63fbe337d618bc2f20d93b15fb3934bc08dce
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [WIP] Gracefully handle outdated echo_unread_wikis rows - change (mediawiki...Echo)

2016-05-29 Thread Catrope (Code Review)

Catrope has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291676

Change subject: [WIP] Gracefully handle outdated echo_unread_wikis rows
..

[WIP] Gracefully handle outdated echo_unread_wikis rows

Adds $wgEchoUnreadWikisTransition. If this setting is enabled,
we will disbelieve the alert/message counts in the euw table
and obtain them using server-side cross-wiki API queries instead.

TODO:
* Do a full test that involves changing a notification type's
  section and updating the cache version (because cached counts
  will be inaccurate as well)
* This may cause problems with global badge counts, figure out
  if we can get those to be accurate too.

Bug: T132954
Change-Id: Ibcc8ac102dac3cf06916d67427b42457fdb93db6
---
M Echo.php
M includes/ForeignNotifications.php
M includes/api/ApiCrossWikiBase.php
M includes/api/ApiEchoNotifications.php
4 files changed, 101 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/76/291676/1

diff --git a/Echo.php b/Echo.php
index ede0cab..ebe4134 100644
--- a/Echo.php
+++ b/Echo.php
@@ -150,6 +150,12 @@
 // main one. Must be a key defined in $wgExternalServers
 $wgEchoSharedTrackingCluster = false;
 
+// Enable this when you've changed the section (alert vs message) of a 
notification
+// type, but haven't yet finished running backfillUnreadWikis.php. This setting
+// reduces performance but prevents glitchy and inaccurate information from 
being
+// show to users while the unread_wikis table is being rebuilt.
+$wgEchoUnreadWikisTransition = false;
+
 // The max number of notifications allowed for a user to do a live update,
 // this is also the number of max notifications allowed for a user to have
 // @FIXME - the name is not intuitive, probably change it when the deleteJob 
patch
diff --git a/includes/ForeignNotifications.php 
b/includes/ForeignNotifications.php
index 1bddc98..c3d14f8 100644
--- a/includes/ForeignNotifications.php
+++ b/includes/ForeignNotifications.php
@@ -40,6 +40,11 @@
protected $wikiTimestamps = array();
 
/**
+* @var array [(str) wiki => [ (str) section => (int) count, ... ], ... 
]
+*/
+   protected $wikiCounts = array();
+
+   /**
 * @var bool
 */
protected $populated = false;
@@ -137,6 +142,17 @@
return isset( $this->wikiTimestamps[$wiki][$section] ) ? 
$this->wikiTimestamps[$wiki][$section] : false;
}
 
+   public function getWikiCount( $wiki, $section = 
EchoAttributeManager::ALL ) {
+   $this->populate();
+   if ( !isset( $this->wikiCounts[$wiki] ) ) {
+   return false;
+   }
+   if ( $section === EchoAttributeManager::ALL ) {
+   return array_sum( $this->wikiCounts[$wiki] );
+   }
+   return isset( $this->wikiCounts[$wiki][$section] ) ? 
$this->wikiCounts[$wiki][$section] : false;
+   }
+
protected function populate() {
if ( $this->populated ) {
return;
@@ -163,8 +179,9 @@
 
foreach ( $sections as $section => $data ) {
if ( $data['count'] > 0 ) {
-   $this->counts[$section] += 
$data['count'];
$this->wikis[$section][] = $wiki;
+   $this->wikiCounts[$wiki][$section] = 
intval( $data['count'] );
+   $this->counts[$section] += intval( 
$data['count'] );
 
$timestamp = new MWTimestamp( 
$data['ts'] );
$this->wikiTimestamps[$wiki][$section] 
= $timestamp;
diff --git a/includes/api/ApiCrossWikiBase.php 
b/includes/api/ApiCrossWikiBase.php
index d1f96c3..2695d85 100644
--- a/includes/api/ApiCrossWikiBase.php
+++ b/includes/api/ApiCrossWikiBase.php
@@ -23,11 +23,13 @@
 * This will turn the current API call (with all of it's params) and 
execute
 * it on all foreign wikis, returning an array of results per wiki.
 *
+* @param array $wikis List of wikis to query. Defaults to the result 
of getForeignWikis().
+* @param array $paramOverrides Request parameter overrides
 * @return array
 * @throws Exception
 */
-   protected function getFromForeign() {
-   $reqs = $this->getForeignRequestParams( 
$this->getForeignWikis() );
+   protected function getFromForeign( $wikis = null, array $paramOverrides 
= array() ) {
+   $reqs = $this->getForeignRequestParams( $wikis !== null ? 
$wikis : $this->getForeignWikis(), $paramOverrides );
 
return $this->foreignRequests( $reqs );
}
@@ -69,9 +71,10 @@
 
/**
 * @param array $wikis Wiki names
+*

[MediaWiki-commits] [Gerrit] Fix debug bar encapsulation - change (mediawiki...Flow)

2016-05-29 Thread Esanders (Code Review)

Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291675

Change subject: Fix debug bar encapsulation
..

Fix debug bar encapsulation

Change-Id: I01bb87690f7b2426c44240dedc4d21efd1e83bab
Depends-On: I2c5d722278c5f71b59ee2f8849d9babb5aff6af2
---
M modules/editor/editors/visualeditor/mw.flow.ve.Target.js
M modules/editor/editors/visualeditor/mw.flow.ve.Target.less
2 files changed, 1 insertion(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/75/291675/1

diff --git a/modules/editor/editors/visualeditor/mw.flow.ve.Target.js 
b/modules/editor/editors/visualeditor/mw.flow.ve.Target.js
index fede8d7..a587e81 100644
--- a/modules/editor/editors/visualeditor/mw.flow.ve.Target.js
+++ b/modules/editor/editors/visualeditor/mw.flow.ve.Target.js
@@ -73,18 +73,7 @@
mw.flow.ve.Target.prototype.generateCitationFeatures = function () {};
 
mw.flow.ve.Target.prototype.attachToolbar = function ( surface ) {
-   ( surface.debugBar || surface ).$element.after( 
this.getToolbar().$element );
-   };
-
-   mw.flow.ve.Target.prototype.setSurface = function ( surface ) {
-   // HACK ve.ui.Surface appends a debugBar *after* itself instead 
of putting it
-   // inside itself (T106927)
-   // Work around this by appending the toolbar after the debugBar 
if it's there, and
-   // after the surface otherwise.
-   ( surface.debugBar || surface ).$element.after( 
this.getToolbar().$element );
-
-   // Parent method
-   mw.flow.ve.Target.parent.prototype.setSurface.apply( this, 
arguments );
+   this.$element.after( this.getToolbar().$element );
};
 
mw.flow.ve.Target.prototype.setDisabled = function ( disabled ) {
diff --git a/modules/editor/editors/visualeditor/mw.flow.ve.Target.less 
b/modules/editor/editors/visualeditor/mw.flow.ve.Target.less
index 22f67a3..e6b1576 100644
--- a/modules/editor/editors/visualeditor/mw.flow.ve.Target.less
+++ b/modules/editor/editors/visualeditor/mw.flow.ve.Target.less
@@ -27,8 +27,6 @@
}
 
.ve-ui-debugBar {
-   /* Move above bottom toolbar */
-   margin: -@editorToolbarHeight 0 @editorToolbarHeight;
padding: 4px 8px;
/* Make sure the surface doesn't overlay */
position: relative;

-- 
To view, visit https://gerrit.wikimedia.org/r/291675
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I01bb87690f7b2426c44240dedc4d21efd1e83bab
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Don't fetch duplication notifications - change (mediawiki...Echo)

2016-05-29 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Don't fetch duplication notifications
..


Don't fetch duplication notifications

Avoid joining on echo_taget_page to prevent fetching
duplicate notifications.

Change-Id: Ibcda67ce2fa387d8be0ffcb405bd0692965dddcb
---
M includes/mapper/NotificationMapper.php
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/mapper/NotificationMapper.php 
b/includes/mapper/NotificationMapper.php
index 4bd48e9..d941457 100644
--- a/includes/mapper/NotificationMapper.php
+++ b/includes/mapper/NotificationMapper.php
@@ -181,7 +181,7 @@
}
 
$res = $dbr->select(
-   array( 'echo_notification', 'echo_event', 
'echo_target_page' ),
+   array( 'echo_notification', 'echo_event' ),
'*',
$conds,
__METHOD__,
@@ -191,7 +191,6 @@
),
array(
'echo_event' => array( 'LEFT JOIN', 
'notification_event=event_id' ),
-   'echo_target_page' => array( 'LEFT JOIN', 
array( 'notification_event=etp_event', 'notification_user=etp_user' ) ),
)
);
 

-- 
To view, visit https://gerrit.wikimedia.org/r/291486
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibcda67ce2fa387d8be0ffcb405bd0692965dddcb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Sbisson 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [PULL THROUGH] Fix debug bar encapsulation - change (mediawiki...VisualEditor)

2016-05-29 Thread Esanders (Code Review)

Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291674

Change subject: [PULL THROUGH] Fix debug bar encapsulation
..

[PULL THROUGH] Fix debug bar encapsulation

Pull through for Id9b4f0e6bb5b954013ac27efc744cc892d1b6ae8

Change-Id: I2c5d722278c5f71b59ee2f8849d9babb5aff6af2
---
M modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget-monobook.css
M modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget-vector.css
M modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-vector.css
M modules/ve-mw/init/ve.init.mw.Target.js
4 files changed, 18 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/74/291674/1

diff --git 
a/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget-monobook.css 
b/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget-monobook.css
index 3fb1da0..6430f0b 100644
--- a/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget-monobook.css
+++ b/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget-monobook.css
@@ -22,12 +22,17 @@
padding-top: 0.9921875em;
 }
 
-/* Main document debug bar */
-.ve-init-mw-desktopArticleTarget > .ve-ui-debugBar {
+.ve-ui-debugBar {
border-top: 1px solid #ccc;
+}
+
+/* Main document debug bar */
+.ve-init-mw-target-surface > .ve-ui-debugBar {
/* 0.8/0.8 */
padding: 1em;
-   margin: 1em -1em -1em -1em;
+   padding-bottom: 0;
+   margin: 1em -1em 0 -1em;
+   font-size: 1.007874em;
 }
 
 .ve-init-mw-target-surface {
diff --git 
a/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget-vector.css 
b/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget-vector.css
index 63452e8..cc5a705 100644
--- a/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget-vector.css
+++ b/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget-vector.css
@@ -20,8 +20,7 @@
of content editable.
*/
/* 1/0.875 */
-   margin: 0 -1.14286em -1.14286em -1.14286em;
-   padding-bottom: 1.14286em;
+   margin: 0 -1.14286em;
 }
 
 .ve-deactivating .ve-init-mw-desktopArticleTarget-originalContent,
@@ -67,10 +66,11 @@
 }
 
 /* Main document debug bar */
-.ve-init-mw-desktopArticleTarget > .ve-ui-debugBar {
+.ve-init-mw-target-surface > .ve-ui-debugBar {
/* 1/0.8 */
padding: 1.25em;
-   margin: 1.25em -1.25em -1.25em -1.25em;
+   padding-bottom: 0;
+   margin-top: 1.25em;
 }
 
 /* ve.ce.TableCellnode.css's margin replaced by more specific rule in Vector 
(div#content p) */
@@ -82,8 +82,7 @@
 @media screen and ( min-width: 982px ) {
.ve-init-mw-target-surface {
/* 1.5/0.875 */
-   margin: 0 -1.71429em -1.71429em -1.71429em;
-   padding-bottom: 1.71429em;
+   margin: 0 -1.71429em;
}
 
.ve-deactivating .ve-init-mw-desktopArticleTarget-originalContent,
@@ -102,10 +101,11 @@
}
 
/* Main document debug bar */
-   .ve-init-mw-desktopArticleTarget > .ve-ui-debugBar {
+   .ve-init-mw-target-surface > .ve-ui-debugBar {
/* 1/0.8, 1.5/0.8 */
padding: 1.875em;
-   margin: 1.875em -1.875em -1.875em -1.875em;
+   padding-bottom: 0;
+   margin-top: 1.875em;
}
 }
 
diff --git a/modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-vector.css 
b/modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-vector.css
index b1d3584..8a2fe63 100644
--- a/modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-vector.css
+++ b/modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-vector.css
@@ -13,7 +13,8 @@
 }
 
 /* Fix font styles for overlays inside mw-body-content */
-.mw-body-content .ve-ui-overlay {
+.mw-body-content .ve-ui-overlay,
+.mw-body-content .ve-ui-debugBar {
font-size: 0.914286em; /* 0.8/0.875 */
line-height: normal;
 }
diff --git a/modules/ve-mw/init/ve.init.mw.Target.js 
b/modules/ve-mw/init/ve.init.mw.Target.js
index b4a61f6..0f9b174 100644
--- a/modules/ve-mw/init/ve.init.mw.Target.js
+++ b/modules/ve-mw/init/ve.init.mw.Target.js
@@ -315,10 +315,6 @@
// Now that the surface is attached to the 
document and ready,
// let it initialize itself
surface.initialize();
-   if ( surface.debugBar ) {
-   // Move debug bar to end of target if 
the surface is nested
-   target.$element.append( 
surface.debugBar.$element );
-   }
 
target.track( 'trace.initializeSurface.exit' );
setTimeout( callback );

-- 
To view, visit https://gerrit.wikimedia.org/r/291674
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange

[MediaWiki-commits] [Gerrit] [Timeline] Update path to extension - change (operations/mediawiki-config)

2016-05-29 Thread Paladox (Code Review)

Paladox has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291673

Change subject: [Timeline] Update path to extension
..

[Timeline] Update path to extension

Update path from Timeline.php to timeline.php it is to fix jenkins tests.

This requires Ie3a5c32b05bfa05417005e73984240b6112e0add

Change-Id: Iadf71e65f3c348a7e4a0d9121a3266808ba0f97c
---
M wmf-config/CommonSettings.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/73/291673/1

diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index 32df79a..6dd2e84 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -662,7 +662,7 @@
 };
 
 if ( $wmgUseTimeline ) {
-   include( $IP . '/extensions/timeline/Timeline.php' );
+   include( $IP . '/extensions/timeline/timeline.php' );
if ( $wgDBname == 'testwiki' || $wgDBname == 'mlwiki' ) {
// FreeSansWMF has been generated from FreeSans and FreeSerif 
by using this script with fontforge:
// Open("FreeSans.ttf");

-- 
To view, visit https://gerrit.wikimedia.org/r/291673
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iadf71e65f3c348a7e4a0d9121a3266808ba0f97c
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Paladox 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix JS error when API request errors - change (mediawiki...Echo)

2016-05-29 Thread Catrope (Code Review)

Catrope has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291672

Change subject: Fix JS error when API request errors
..

Fix JS error when API request errors

We don't show an error message in this case, just an
empty popup, so that should be fixed regardless.

Change-Id: I06ddd5306bd8d7edeb8c75bdae7abd7215285e3d
---
M modules/ui/mw.echo.ui.NotificationsListWidget.js
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/72/291672/1

diff --git a/modules/ui/mw.echo.ui.NotificationsListWidget.js 
b/modules/ui/mw.echo.ui.NotificationsListWidget.js
index 0da2479..70a3815 100644
--- a/modules/ui/mw.echo.ui.NotificationsListWidget.js
+++ b/modules/ui/mw.echo.ui.NotificationsListWidget.js
@@ -194,7 +194,9 @@
itemWidgets = this.getItems();
 
for ( i = 0; i < itemWidgets.length; i++ ) {
-   itemWidgets[ i ].resetInitiallyUnseen();
+   if ( itemWidgets[ i ].resetInitiallyUnseen ) {
+   itemWidgets[ i ].resetInitiallyUnseen();
+   }
}
};
 } )( mediaWiki );

-- 
To view, visit https://gerrit.wikimedia.org/r/291672
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I06ddd5306bd8d7edeb8c75bdae7abd7215285e3d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Catrope 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Update entry point main php file - change (mediawiki...timeline)

2016-05-29 Thread Paladox (Code Review)

Paladox has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291671

Change subject: Update entry point main php file
..

Update entry point main php file

Rename from Timeline.php to timeline.php to fix jenkins test failures.

Change-Id: Ie3a5c32b05bfa05417005e73984240b6112e0add
---
R timeline.php
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/timeline 
refs/changes/71/291671/1

diff --git a/Timeline.php b/timeline.php
similarity index 100%
rename from Timeline.php
rename to timeline.php

-- 
To view, visit https://gerrit.wikimedia.org/r/291671
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3a5c32b05bfa05417005e73984240b6112e0add
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/timeline
Gerrit-Branch: master
Gerrit-Owner: Paladox 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [timeline] Update Jenkins tests - change (integration/config)

2016-05-29 Thread Paladox (Code Review)

Paladox has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291670

Change subject: [timeline] Update Jenkins tests
..

[timeline] Update Jenkins tests

Adds composer-test.

Remove composer-php53 which we no longer support php53. composer-test will
use php53 only on old branches.

Update test and gate and submit and remove composer-validate which is now
in composer-test and remove php53 since we doint support that but is still
provided if you use a old branch.

Update experimental tests to use php55 instead of php53 once we merge
I8ebf3d0e4d381e632a19c340aaabef863fc1b726 we will be able to remove the
experimental tests.

Change-Id: I920523d68b5e9dd005f1894a4970e770b3d44eeb
---
M zuul/layout.yaml
1 file changed, 3 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/70/291670/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 3989181..88b661a 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -7443,27 +7443,22 @@
 
   - name: mediawiki/extensions/timeline
 template:
+  - name: composer-test
   - name: npm
 check:
   - jsonlint
-  - php53lint
   - perllint
-  - composer-validate
 test:
- - php53lint
  - perllint
- - composer-validate
 gate-and-submit:
- - php53lint
  - perllint
- - composer-validate
 experimental:
  - mediawiki-extensions-hhvm
  - mediawiki-extensions-qunit
+ - mwext-testextension-php55
  - mwext-testextension-hhvm
- - mwext-testextension-php53-composer
+ - mwext-testextension-php55-composer
  - mwext-testextension-hhvm-composer
- - composer-php53
 
   - name: mediawiki/extensions/TitleBlacklist
 template:

-- 
To view, visit https://gerrit.wikimedia.org/r/291670
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I920523d68b5e9dd005f1894a4970e770b3d44eeb
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Paladox 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [BREAKING CHANGE] Fix debug bar encapsulation - change (VisualEditor/VisualEditor)

2016-05-29 Thread Esanders (Code Review)

Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291669

Change subject: [BREAKING CHANGE] Fix debug bar encapsulation
..

[BREAKING CHANGE] Fix debug bar encapsulation

Debug bar lives inside the surface so it should
be inside it in the DOM.

Bug: T106927
Change-Id: Id9b4f0e6bb5b954013ac27efc744cc892d1b6ae8
---
M demos/ve/demo.css
M demos/ve/demo.desktop.css
M demos/ve/demo.mobile.css
M src/ui/styles/ve.ui.DebugBar.css
M src/ui/ve.ui.Surface.js
5 files changed, 6 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/69/291669/1

diff --git a/demos/ve/demo.css b/demos/ve/demo.css
index b5b64af..b6b909a 100644
--- a/demos/ve/demo.css
+++ b/demos/ve/demo.css
@@ -104,6 +104,7 @@
 
 .ve-ui-debugBar {
padding: 1.5em;
+   border-top: 1px solid #ccc;
 }
 
 .ve-ui-debugBar-filibuster {
diff --git a/demos/ve/demo.desktop.css b/demos/ve/demo.desktop.css
index 6c3de88..61584f2 100644
--- a/demos/ve/demo.desktop.css
+++ b/demos/ve/demo.desktop.css
@@ -36,7 +36,3 @@
border-radius: 0.25em;
box-shadow: 0 0.25em 1.5em 0 #ddd;
 }
-
-.ve-init-sa-target-surfaceWrapper > .ve-ui-debugBar {
-   border-top: 1px solid #ccc;
-}
diff --git a/demos/ve/demo.mobile.css b/demos/ve/demo.mobile.css
index d104102..fce3b57 100644
--- a/demos/ve/demo.mobile.css
+++ b/demos/ve/demo.mobile.css
@@ -32,7 +32,3 @@
 .ve-init-sa-target-toolbar.ve-ui-toolbar-floating > .oo-ui-toolbar-bar {
border-top: 0;
 }
-
-.ve-ui-debugBar {
-   border-bottom: 1px solid #ccc;
-}
diff --git a/src/ui/styles/ve.ui.DebugBar.css b/src/ui/styles/ve.ui.DebugBar.css
index 148060a..ebbe0ec 100644
--- a/src/ui/styles/ve.ui.DebugBar.css
+++ b/src/ui/styles/ve.ui.DebugBar.css
@@ -4,6 +4,10 @@
  * @copyright 2011-2016 VisualEditor Team and others; see 
http://ve.mit-license.org
  */
 
+.ve-ui-debugBar {
+   clear: both;
+}
+
 .ve-ui-debugBar-commands {
margin-bottom: -0.5em;
 }
diff --git a/src/ui/ve.ui.Surface.js b/src/ui/ve.ui.Surface.js
index f9728ac..128e8a5 100644
--- a/src/ui/ve.ui.Surface.js
+++ b/src/ui/ve.ui.Surface.js
@@ -246,7 +246,7 @@
  */
 ve.ui.Surface.prototype.setupDebugBar = function () {
this.debugBar = new ve.ui.DebugBar( this );
-   this.debugBar.$element.insertAfter( this.$element );
+   this.$element.append( this.debugBar.$element );
 };
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/291669
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9b4f0e6bb5b954013ac27efc744cc892d1b6ae8
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Syncronize VisualEditor: 51ceeda..3a2838f - change (mediawiki/extensions)

2016-05-29 Thread Jenkins-mwext-sync (Code Review)

Jenkins-mwext-sync has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291667

Change subject: Syncronize VisualEditor: 51ceeda..3a2838f
..

Syncronize VisualEditor: 51ceeda..3a2838f

Change-Id: Id3d44e3d0873bb6ded223f1ba016e782c153d2b9
---
M VisualEditor
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions 
refs/changes/67/291667/1

diff --git a/VisualEditor b/VisualEditor
index 51ceeda..3a2838f 16
--- a/VisualEditor
+++ b/VisualEditor
-Subproject commit 51ceeda189a533e489d6acdc4c27f935ccf5b3aa
+Subproject commit 3a2838f2bab574981f95ad68210497b791ba284b

-- 
To view, visit https://gerrit.wikimedia.org/r/291667
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3d44e3d0873bb6ded223f1ba016e782c153d2b9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions
Gerrit-Branch: master
Gerrit-Owner: Jenkins-mwext-sync 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Syncronize VisualEditor: 51ceeda..3a2838f - change (mediawiki/extensions)

2016-05-29 Thread Jenkins-mwext-sync (Code Review)

Jenkins-mwext-sync has submitted this change and it was merged.

Change subject: Syncronize VisualEditor: 51ceeda..3a2838f
..


Syncronize VisualEditor: 51ceeda..3a2838f

Change-Id: Id3d44e3d0873bb6ded223f1ba016e782c153d2b9
---
M VisualEditor
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Jenkins-mwext-sync: Verified; Looks good to me, approved



diff --git a/VisualEditor b/VisualEditor
index 51ceeda..3a2838f 16
--- a/VisualEditor
+++ b/VisualEditor
-Subproject commit 51ceeda189a533e489d6acdc4c27f935ccf5b3aa
+Subproject commit 3a2838f2bab574981f95ad68210497b791ba284b

-- 
To view, visit https://gerrit.wikimedia.org/r/291667
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id3d44e3d0873bb6ded223f1ba016e782c153d2b9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions
Gerrit-Branch: master
Gerrit-Owner: Jenkins-mwext-sync 
Gerrit-Reviewer: Jenkins-mwext-sync 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add composer entry point with phplint - change (mediawiki...timeline)

2016-05-29 Thread Paladox (Code Review)

Paladox has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291668

Change subject: Add composer entry point with phplint
..

Add composer entry point with phplint

Change-Id: Ibe246d0cc48a0946f4753255dd558cb0e0aa7abc
---
M .gitignore
A composer.json
2 files changed, 11 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/timeline 
refs/changes/68/291668/1

diff --git a/.gitignore b/.gitignore
index 4bf4869..455433b 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,5 +1,5 @@
-.svn
 *~
 *.kate-swp
 .*.swp
 node_modules/
+vendor/
diff --git a/composer.json b/composer.json
new file mode 100644
index 000..1c63f9e
--- /dev/null
+++ b/composer.json
@@ -0,0 +1,10 @@
+{
+   "require-dev": {
+   "jakub-onderka/php-parallel-lint": "0.9.2"
+   },
+   "scripts": {
+   "test": [
+   "parallel-lint . --exclude vendor"
+   ]
+   }
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/291668
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe246d0cc48a0946f4753255dd558cb0e0aa7abc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/timeline
Gerrit-Branch: master
Gerrit-Owner: Paladox 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] k8s: Ensure /etc/kubernetes is present wherever required - change (operations/puppet)

2016-05-29 Thread Yuvipanda (Code Review)

Yuvipanda has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291617

Change subject: k8s: Ensure /etc/kubernetes is present wherever required
..

k8s: Ensure /etc/kubernetes is present wherever required

Change-Id: I932664528562393f0e03e5ad4997ec7007a18d94
---
M modules/k8s/manifests/infrastructure_config.pp
M modules/k8s/manifests/kubelet.pp
2 files changed, 8 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/17/291617/1

diff --git a/modules/k8s/manifests/infrastructure_config.pp 
b/modules/k8s/manifests/infrastructure_config.pp
index 3bab4c1..b628c89 100644
--- a/modules/k8s/manifests/infrastructure_config.pp
+++ b/modules/k8s/manifests/infrastructure_config.pp
@@ -1,4 +1,11 @@
 class k8s::infrastructure_config {
+file { '/etc/kubernetes':
+ensure => directory,
+owner  => 'root',
+group  => 'root',
+mode   => '0755',
+}
+
 $users = hiera('k8s_users')
 # Ugly HACK!
 $client_token = inline_template("<%= @users.select { |u| u['name'] == 
'client-infrastructure' }[0]['token'] %>")
@@ -8,5 +15,6 @@
 owner   => 'root',
 group   => 'root',
 mode=> '0400',
+require => File['/etc/kubernetes'],
 }
 }
diff --git a/modules/k8s/manifests/kubelet.pp b/modules/k8s/manifests/kubelet.pp
index d1e7834..ccc6b67 100644
--- a/modules/k8s/manifests/kubelet.pp
+++ b/modules/k8s/manifests/kubelet.pp
@@ -6,16 +6,6 @@
 include ::k8s::infrastructure_config
 
 file { [
-'/etc/kubernetes/',
-'/etc/kubernetes/manifests',
-]:
-ensure => directory,
-owner  => 'root',
-group  => 'root',
-mode   => '0755',
-}
-
-file { [
 '/var/run/kubernetes',
 '/var/lib/kubelet',
 ] :

-- 
To view, visit https://gerrit.wikimedia.org/r/291617
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I932664528562393f0e03e5ad4997ec7007a18d94
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Yuvipanda 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [IMPR] unpack version history items by index - change (pywikibot...xqbot)

2016-05-29 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: [IMPR] unpack version history items by index
..


[IMPR] unpack version history items by index

getVersionHistory() may have different items length
but we only need the first 3.

Change-Id: If9aec07b6641f66395379f76a115c92f726a9e89
---
M imagereview.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Xqt: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/imagereview.py b/imagereview.py
index 5469b12..2696c18 100644
--- a/imagereview.py
+++ b/imagereview.py
@@ -807,9 +807,9 @@
 imageID = None
 linked = []
 found = False
-vh = image.getVersionHistory()
 # Search for last bot action
-for oldid, time, username, summary in vh:
+for items in image.getVersionHistory():
+oldid, time, username = items[:3]
 if username in [u'Xqbot', u'BLUbot']:
 imageID = oldid
 break

-- 
To view, visit https://gerrit.wikimedia.org/r/291607
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If9aec07b6641f66395379f76a115c92f726a9e89
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/bots/xqbot
Gerrit-Branch: master
Gerrit-Owner: Xqt 
Gerrit-Reviewer: Xqt 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [IMPR] unpack version history items by index - change (pywikibot...xqbot)

2016-05-29 Thread Xqt (Code Review)

Xqt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291607

Change subject: [IMPR] unpack version history items by index
..

[IMPR] unpack version history items by index

getVersionHistory() may have different items length but we only need the first.

Change-Id: If9aec07b6641f66395379f76a115c92f726a9e89
---
M imagereview.py
1 file changed, 2 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/bots/xqbot 
refs/changes/07/291607/1

diff --git a/imagereview.py b/imagereview.py
index 5469b12..210c7c7 100644
--- a/imagereview.py
+++ b/imagereview.py
@@ -807,11 +807,10 @@
 imageID = None
 linked = []
 found = False
-vh = image.getVersionHistory()
 # Search for last bot action
-for oldid, time, username, summary in vh:
+for items in image.getVersionHistory():
 if username in [u'Xqbot', u'BLUbot']:
-imageID = oldid
+imageID = items[0]
 break
 
 if imageID:

-- 
To view, visit https://gerrit.wikimedia.org/r/291607
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If9aec07b6641f66395379f76a115c92f726a9e89
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/bots/xqbot
Gerrit-Branch: master
Gerrit-Owner: Xqt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [compat2core] return compat-like list of tuples from getVers... - change (pywikibot/core)

2016-05-29 Thread Xqt (Code Review)

Xqt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291605

Change subject: [compat2core] return compat-like list of tuples from 
getVersionHistory
..

[compat2core] return compat-like list of tuples from getVersionHistory

- Page.getVersionHistory() gives a list of tuples with 4 items
  but tuple has 6 items in compat.
- getVersionHistory method is deprecated in core but kept for compatibility
  with compat scripts. We could change it for that reason and restore
  compatibility again.
- enable 'size' and 'tags' properties for Revision class (which is
  needed for getVersionHistory).

Bug: T136513
Change-Id: I740ee61aedb95795f294918000f039a4b4db2fca
---
M pywikibot/data/api.py
M pywikibot/page.py
M pywikibot/site.py
3 files changed, 12 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/05/291605/1

diff --git a/pywikibot/data/api.py b/pywikibot/data/api.py
index 62ec818..edf206d 100644
--- a/pywikibot/data/api.py
+++ b/pywikibot/data/api.py
@@ -3163,7 +3163,9 @@
 rollbacktoken=rev.get('rollbacktoken', None),
 parentid=rev.get('parentid'),
 contentmodel=rev.get('contentmodel', None),
-sha1=rev.get('sha1', None)
+sha1=rev.get('sha1', None),
+size=rev['size'],
+tags=rev['tags']
 )
 page._revisions[revision.revid] = revision
 
diff --git a/pywikibot/page.py b/pywikibot/page.py
index a59d379..0a68f55 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -4699,7 +4699,9 @@
 HistEntry = namedtuple('HistEntry', ['revid',
  'timestamp',
  'user',
- 'comment'])
+ 'comment',
+ 'size',
+ 'tags'])
 
 FullHistEntry = namedtuple('FullHistEntry', ['revid',
  'timestamp',
@@ -4709,7 +4711,7 @@
 
 def __init__(self, revid, timestamp, user, anon=False, comment=u"",
  text=None, minor=False, rollbacktoken=None, parentid=None,
- contentmodel=None, sha1=None):
+ contentmodel=None, sha1=None, size=-1, tags=None):
 """
 Constructor.
 
@@ -4750,6 +4752,8 @@
 self._parent_id = parentid
 self._content_model = contentmodel
 self._sha1 = sha1
+self.size = size
+self.tags = tags if tags is not None else []
 
 @property
 def parent_id(self):
@@ -4811,7 +4815,7 @@
 def hist_entry(self):
 """Return a namedtuple with a Page history record."""
 return Revision.HistEntry(self.revid, self.timestamp, self.user,
-  self.comment)
+  self.comment, self.size, self.tags)
 
 def full_hist_entry(self):
 """Return a namedtuple with a Page full history record."""
diff --git a/pywikibot/site.py b/pywikibot/site.py
index ce7f628..a6253b1 100644
--- a/pywikibot/site.py
+++ b/pywikibot/site.py
@@ -3765,7 +3765,8 @@
 
 rvargs = {'type_arg': 'info|revisions'}
 
-rvargs['rvprop'] = ['ids', 'timestamp', 'flags', 'comment', 'user']
+rvargs['rvprop'] = ['ids', 'timestamp', 'flags', 'comment', 'user',
+'size', 'tags']
 if MediaWikiVersion(self.version()) >= MediaWikiVersion('1.21'):
 rvargs['rvprop'].append('contentmodel')
 if MediaWikiVersion(self.version()) >= MediaWikiVersion('1.19'):

-- 
To view, visit https://gerrit.wikimedia.org/r/291605
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I740ee61aedb95795f294918000f039a4b4db2fca
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] build: Bump grunt-karma and related tools to 1.0.x - change (mediawiki/core)

2016-05-29 Thread Paladox (Code Review)

Paladox has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291604

Change subject: build: Bump grunt-karma and related tools to 1.0.x
..

build: Bump grunt-karma and related tools to 1.0.x

Change-Id: Ic982dfc7ccebeecd6082b5476372cbb87fec5f1b
---
M package.json
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/04/291604/1

diff --git a/package.json b/package.json
index 6fde2e0..8bc9ca4 100644
--- a/package.json
+++ b/package.json
@@ -13,12 +13,12 @@
 "grunt-contrib-watch": "1.0.0",
 "grunt-jscs": "2.8.0",
 "grunt-jsonlint": "1.0.7",
-"grunt-karma": "0.12.2",
+"grunt-karma": "1.0.0",
 "grunt-stylelint": "0.3.0",
 "karma": "0.13.22",
-"karma-chrome-launcher": "0.2.2",
-"karma-firefox-launcher": "0.1.7",
-"karma-qunit": "0.1.9",
+"karma-chrome-launcher": "1.0.1",
+"karma-firefox-launcher": "1.0.0",
+"karma-qunit": "1.0.0",
 "qunitjs": "1.22.0",
 "stylelint-config-wikimedia": "0.1.0"
   }

-- 
To view, visit https://gerrit.wikimedia.org/r/291604
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic982dfc7ccebeecd6082b5476372cbb87fec5f1b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Paladox 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Migrate wikimedia/fundraising/dash node-0.10 test to node-4.... - change (integration/config)

2016-05-29 Thread Paladox (Code Review)

Paladox has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291603

Change subject: Migrate wikimedia/fundraising/dash node-0.10 test to node-4.3 
test
..

Migrate wikimedia/fundraising/dash node-0.10 test to node-4.3 test

It passes
https://integration.wikimedia.org/ci/job/npm-node-4.3/14272/console

Also i fixed Depends on node-syslog@1.1.7 which does not work on Node 4.3
in https://gerrit.wikimedia.org/r/#/c/277768/

Change-Id: I26e3fd42a7620cab92330f6eb8aa0f3d7c5718a0
---
M zuul/layout.yaml
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/03/291603/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 3989181..9dd0da2 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -2142,7 +2142,7 @@
   - name: wikimedia/fundraising/dash
 template:
   # Depends on node-syslog@1.1.7 which does not work on Node 4.3
-  - name: npm-node-0.10
+  - name: npm-node-4.3
 check:
   - jshint
   - jsonlint

-- 
To view, visit https://gerrit.wikimedia.org/r/291603
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I26e3fd42a7620cab92330f6eb8aa0f3d7c5718a0
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Paladox 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Set site title for ma.wikiquote - change (operations/mediawiki-config)

2016-05-29 Thread Dereckson (Code Review)

Dereckson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291601

Change subject: Set site title for ma.wikiquote
..

Set site title for ma.wikiquote

Site title: विकीकोट

Bug: T136514
Change-Id: I8bb45aabce1b7a9ac87ac696657ca32196d2d0b7
---
M wmf-config/InitialiseSettings.php
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/01/291601/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 66822d1..193c37e 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -1785,6 +1785,7 @@
'ltwikisource' => 'Vikišaltiniai',
'ltwiktionary' => 'Vikižodynas',
'lvwiki' => 'Vikipēdija',
+   'mawikiquote' => 'विकीकोट', // T136514
'maiwiki' => 'विकिपिडिया', // T74346
'mdfwiki' => 'Википедиесь',
'mediawikiwiki' => 'MediaWiki',
@@ -2274,6 +2275,7 @@
'ltwikisource' => 'Vikišaltiniai',
'ltwiktionary' => 'Vikižodynas',
'lvwiki' => 'Vikipēdija',
+   'mawikiquote' => 'विकीकोट', // T136514
'maiwiki' => 'विकिपिडिया', // T74346
'mdfwiki' => 'Википедиесь',
'mediawikiwiki' => 'Project',

-- 
To view, visit https://gerrit.wikimedia.org/r/291601
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8bb45aabce1b7a9ac87ac696657ca32196d2d0b7
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Dereckson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] WhoIsOnline: Improved tag documentation - change (mediawiki...BlueSpiceExtensions)

2016-05-29 Thread Mglaser (Code Review)

Mglaser has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291600

Change subject: WhoIsOnline: Improved tag documentation
..

WhoIsOnline: Improved tag documentation

New tag description. Thanks to Sabine Gürtler and Anja Ebersbach.

Change-Id: I57f46fd308de705b12f6a8a1c9c7bc31b0b2abac
---
M WhoIsOnline/WhoIsOnline.class.php
M WhoIsOnline/i18n/en.json
2 files changed, 9 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions 
refs/changes/00/291600/1

diff --git a/WhoIsOnline/WhoIsOnline.class.php 
b/WhoIsOnline/WhoIsOnline.class.php
index 82502d4..4277c1b 100644
--- a/WhoIsOnline/WhoIsOnline.class.php
+++ b/WhoIsOnline/WhoIsOnline.class.php
@@ -167,6 +167,7 @@
'name' => 'whoisonlinecount',
'desc' => wfMessage( 
'bs-whoisonline-tag-whoisonlinecount-desc' )->plain(),
'code' => '',
+   'helplink' => 
'https://help.bluespice.com/index.php/WhoIsOnline'
);
 
$oResponse->result[] = array(
@@ -175,6 +176,12 @@
'name' => 'whoisonlinepopup',
'desc' => wfMessage( 
'bs-whoisonline-tag-whoisonlinepopup-desc' )->plain(),
'code' => '',
+   'examples' => array(
+   array(
+   'code' => ''
+   )
+   ),
+   'helplink' => 
'https://help.bluespice.com/index.php/WhoIsOnline'
);
 
return true;
diff --git a/WhoIsOnline/i18n/en.json b/WhoIsOnline/i18n/en.json
index 41b6c37..9cbc9c7 100644
--- a/WhoIsOnline/i18n/en.json
+++ b/WhoIsOnline/i18n/en.json
@@ -14,6 +14,6 @@
"bs-whoisonline-pref-orderby-time": "Uptime",
"bs-whoisonline-pref-orderby-name": "Name",
"bs-whoisonline-pref-interval": "Update interval in seconds:",
-   "bs-whoisonline-tag-whoisonlinecount-desc": "Renders the number of 
currently logged in users.",
-   "bs-whoisonline-tag-whoisonlinepopup-desc": "Renders a little fly-out 
list of currently logged in users.\n\nValid 
attributes:\n;anchortext: The text you want the fly-out to be 
attached to."
+   "bs-whoisonline-tag-whoisonlinecount-desc": "Shows the number of all 
users who have been logged in within the last 10 minutes.",
+   "bs-whoisonline-tag-whoisonlinepopup-desc": "Shows all users who have 
been logged in within the last 10 minutes."
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/291600
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I57f46fd308de705b12f6a8a1c9c7bc31b0b2abac
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Mglaser 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Watchlist: Improved tag documentation - change (mediawiki...BlueSpiceExtensions)

2016-05-29 Thread Mglaser (Code Review)

Mglaser has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291599

Change subject: Watchlist: Improved tag documentation
..

Watchlist: Improved tag documentation

New tag description. Thanks to Sabine Gürtler and Anja Ebersbach.

Change-Id: Ie8b16f73605efce4f1eb7ae5d3d48c6a2ca89bb5
---
M WatchList/WatchList.class.php
M WatchList/i18n/en.json
2 files changed, 2 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions 
refs/changes/99/291599/1

diff --git a/WatchList/WatchList.class.php b/WatchList/WatchList.class.php
index 5ac0aa9..57ee380 100644
--- a/WatchList/WatchList.class.php
+++ b/WatchList/WatchList.class.php
@@ -101,6 +101,7 @@
'name' => 'watchlist',
'desc' => wfMessage( 'bs-watchlist-tag-watchlist-desc' 
)->plain(),
'code' => '',
+   'helplink' => 
'https://help.bluespice.com/index.php/WatchList'
);
 
return true;
diff --git a/WatchList/i18n/en.json b/WatchList/i18n/en.json
index cd4460c..95948d1 100644
--- a/WatchList/i18n/en.json
+++ b/WatchList/i18n/en.json
@@ -10,5 +10,5 @@
"bs-watchlist-pref-widgetsortodr": "Sort by:",
"bs-watchlist-pref-sort-time": "Time",
"bs-watchlist-pref-sort-title": "Title",
-   "bs-watchlist-tag-watchlist-desc": "Creates a list of pages which are 
on your watchlist and have a non-sighted change."
+   "bs-watchlist-tag-watchlist-desc": "Shows the articles which have most 
recent changes and are on your watchlist."
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/291599
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8b16f73605efce4f1eb7ae5d3d48c6a2ca89bb5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Mglaser 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] WantedArticle: Improved tag documentation - change (mediawiki...BlueSpiceExtensions)

2016-05-29 Thread Mglaser (Code Review)

Mglaser has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291598

Change subject: WantedArticle: Improved tag documentation
..

WantedArticle: Improved tag documentation

New tag description. Thanks to Sabine Gürtler and Anja Ebersbach.

Change-Id: I097946de4ee94a7be7068402219eb4bf8de650b7
---
M WantedArticle/WantedArticle.class.php
M WantedArticle/i18n/en.json
M WantedArticle/i18n/qqq.json
3 files changed, 8 insertions(+), 22 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions 
refs/changes/98/291598/1

diff --git a/WantedArticle/WantedArticle.class.php 
b/WantedArticle/WantedArticle.class.php
index 6637b1c..2054029 100644
--- a/WantedArticle/WantedArticle.class.php
+++ b/WantedArticle/WantedArticle.class.php
@@ -342,22 +342,18 @@
public function onBSInsertMagicAjaxGetData( &$oResponse, $type ) {
if ( $type != 'tags' ) return true;
 
-   $aParams = array(
-   wfMessage( 
'bs-wantedarticle-tag-wantedarticle-desc-param-count' )->text(),
-   wfMessage( 
'bs-wantedarticle-tag-wantedarticle-desc-param-title' )->text(),
-   wfMessage( 
'bs-wantedarticle-tag-wantedarticle-desc-param-order' )->text(),
-   wfMessage( 
'bs-wantedarticle-tag-wantedarticle-desc-param-sort' )->text(),
-   wfMessage( 
'bs-wantedarticle-tag-wantedarticle-desc-param-type' )->text()
-   );
-   $sDesc = wfMessage( 'bs-wantedarticle-tag-wantedarticle-desc' 
)->plain().
-   '' . implode( '', $aParams );
-
$oResponse->result[] = array(
'id' => 'bs:wantedarticle',
'type' => 'tag',
'name' => 'wantedarticle',
-   'desc' => $sDesc,
+   'desc' => wfMessage( 
'bs-wantedarticle-tag-wantedarticle-desc' )->plain(),
'code' => '',
+   'examples' => array(
+   array(
+   'code' => ''
+   )
+   ),
+   'helplink' => 
'https://help.bluespice.com/index.php/WantedArticles'
);
 
return true;
diff --git a/WantedArticle/i18n/en.json b/WantedArticle/i18n/en.json
index 2211943..2edbba0 100644
--- a/WantedArticle/i18n/en.json
+++ b/WantedArticle/i18n/en.json
@@ -17,12 +17,7 @@
"bs-wantedarticle-single-textfield-suggestbutton-text": "Suggest",
"bs-wantedarticle-single-textfield-createbutton-text": "Create",
"bs-wantedarticle-single-textfield-defaulttext": "Page title",
-   "bs-wantedarticle-tag-wantedarticle-desc": "Renders a list of wanted 
pages. Available configuration attributes:",
-   "bs-wantedarticle-tag-wantedarticle-desc-param-count": 
"count: Number of pages to display.",
-   "bs-wantedarticle-tag-wantedarticle-desc-param-title": 
"title: Headline.",
-   "bs-wantedarticle-tag-wantedarticle-desc-param-order": 
"order: Sort order ASC 
({{int:bs-wantedarticle-pref-order-asc}}) or DESC 
({{int:bs-wantedarticle-pref-order-desc}})",
-   "bs-wantedarticle-tag-wantedarticle-desc-param-sort": 
"sort: Sort by title or time.",
-   "bs-wantedarticle-tag-wantedarticle-desc-param-type": 
"type: Output format list or quene 
(comma separated).",
+   "bs-wantedarticle-tag-wantedarticle-desc": "Offers the function to 
simply suggest new articles and displays the suggested pages in a list. Various 
parameters configure this list.",
"bs-wantedarticle-tag-more-linktext": "More ...",
"bs-wantedarticle-tag-default-title": "Wanted pages",
"bs-wantedarticle-pref-includelimit": "Number of suggestions:",
diff --git a/WantedArticle/i18n/qqq.json b/WantedArticle/i18n/qqq.json
index 609717e..9642ca4 100644
--- a/WantedArticle/i18n/qqq.json
+++ b/WantedArticle/i18n/qqq.json
@@ -25,11 +25,6 @@
"bs-wantedarticle-single-textfield-createbutton-text": "Button text for 
create\n{{Identical|Create}}",
"bs-wantedarticle-single-textfield-defaulttext": "Default text in input 
field for page title\n{{Identical|Page title}}",
"bs-wantedarticle-tag-wantedarticle-desc": "Text for renders a list of 
wanted pages. Available configuration attributes:\n{{Related|Bs-tag-desc}}",
-   "bs-wantedarticle-tag-wantedarticle-desc-param-count": "Text for 
count: Number of pages to display. \n \"count\" has to be 
lowercase",
-   "bs-wantedarticle-tag-wantedarticle-desc-param-title": "Text for 
title: Headline. \n \"title\" has to be lowercase",
-   "bs-wantedarticle-tag-wantedarticle-desc-param-order": 
"{{doc-important|order has to be lowercase.}}\nText for 
order: Sort order ASC or DESC\n\nRefers 
to:\n* {{msg-mw|Bs-wantedarticle-pref-order-asc}}\n*

[MediaWiki-commits] [Gerrit] Fix z-index of surface for debug bar - change (mediawiki...VisualEditor)

2016-05-29 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Fix z-index of surface for debug bar
..


Fix z-index of surface for debug bar

Change-Id: I938f2d959cd7cb72c43c2efd666838a9cd9d3e39
---
M modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.css
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.css 
b/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.css
index 31f3960..c44e97a 100644
--- a/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.css
+++ b/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.css
@@ -38,3 +38,10 @@
 .ve-init-mw-desktopArticleTarget .redirectMsg a:hover {
text-decoration: none;
 }
+
+/*!
+ * Increase z-index of surface container so it appears above the debug bar
+ */
+.ve-init-mw-desktopArticleTarget #bodyContent { /* stylelint-disable-line 
selector-no-id */
+   z-index: 1;
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/291531
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I938f2d959cd7cb72c43c2efd666838a9cd9d3e39
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix font size in target widget debug bar - change (mediawiki...VisualEditor)

2016-05-29 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Fix font size in target widget debug bar
..


Fix font size in target widget debug bar

Change-Id: Ic5120fd1d2cc4955a502fa57478a19851f9f6b33
---
M modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-monobook.css
M modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-vector.css
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-monobook.css 
b/modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-monobook.css
index f10931c..9e4ec8a 100644
--- a/modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-monobook.css
+++ b/modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-monobook.css
@@ -6,7 +6,7 @@
  */
 
 .ve-init-mw-desktopArticleTarget-toolbar,
-.ve-ui-debugBar,
+.ve-init-mw-desktopArticleTarget > .ve-ui-debugBar,
 .ve-ui-overlay-global {
/* Enforce different font-size for all UI elements of VisualEditor. The 
difference is tiny, but
   enough to make the icon containers 23.813px rather than 24px and 
thus the icons blurry */
diff --git a/modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-vector.css 
b/modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-vector.css
index 7f1f050..b1d3584 100644
--- a/modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-vector.css
+++ b/modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-vector.css
@@ -6,7 +6,7 @@
  */
 
 .ve-init-mw-desktopArticleTarget-toolbar,
-.ve-ui-debugBar,
+.ve-init-mw-desktopArticleTarget > .ve-ui-debugBar,
 .ve-ui-overlay {
/* Enforce different font-size for all UI elements of VisualEditor */
font-size: 0.8em;

-- 
To view, visit https://gerrit.wikimedia.org/r/291596
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5120fd1d2cc4955a502fa57478a19851f9f6b33
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Syncronize VisualEditor: 5f81599..51ceeda - change (mediawiki/extensions)

2016-05-29 Thread Jenkins-mwext-sync (Code Review)

Jenkins-mwext-sync has submitted this change and it was merged.

Change subject: Syncronize VisualEditor: 5f81599..51ceeda
..


Syncronize VisualEditor: 5f81599..51ceeda

Change-Id: I4a7a9ee3ad7937dd567ce2980289838480eea285
---
M VisualEditor
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Jenkins-mwext-sync: Verified; Looks good to me, approved



diff --git a/VisualEditor b/VisualEditor
index 5f81599..51ceeda 16
--- a/VisualEditor
+++ b/VisualEditor
-Subproject commit 5f815996fcb1c8d46e90b9aeda3f640508e747ad
+Subproject commit 51ceeda189a533e489d6acdc4c27f935ccf5b3aa

-- 
To view, visit https://gerrit.wikimedia.org/r/291597
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4a7a9ee3ad7937dd567ce2980289838480eea285
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions
Gerrit-Branch: master
Gerrit-Owner: Jenkins-mwext-sync 
Gerrit-Reviewer: Jenkins-mwext-sync 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Syncronize VisualEditor: 5f81599..51ceeda - change (mediawiki/extensions)

2016-05-29 Thread Jenkins-mwext-sync (Code Review)

Jenkins-mwext-sync has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291597

Change subject: Syncronize VisualEditor: 5f81599..51ceeda
..

Syncronize VisualEditor: 5f81599..51ceeda

Change-Id: I4a7a9ee3ad7937dd567ce2980289838480eea285
---
M VisualEditor
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions 
refs/changes/97/291597/1

diff --git a/VisualEditor b/VisualEditor
index 5f81599..51ceeda 16
--- a/VisualEditor
+++ b/VisualEditor
-Subproject commit 5f815996fcb1c8d46e90b9aeda3f640508e747ad
+Subproject commit 51ceeda189a533e489d6acdc4c27f935ccf5b3aa

-- 
To view, visit https://gerrit.wikimedia.org/r/291597
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a7a9ee3ad7937dd567ce2980289838480eea285
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions
Gerrit-Branch: master
Gerrit-Owner: Jenkins-mwext-sync 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove unused namespace class - change (mediawiki...VisualEditor)

2016-05-29 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Remove unused namespace class
..


Remove unused namespace class

Introduced recently but then abandoned.

Change-Id: Ifa999f0e60fe1b6d68c63813025c9fd48b79ad5f
---
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js 
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
index 18e06f4..e328f98 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
@@ -98,8 +98,6 @@
// Initialization
this.$element
.addClass( 've-init-mw-desktopArticleTarget' )
-   // The following classes can be used here:
-   .addClass( 've-init-mw-desktopArticleTarget-ns-' + ( 
mw.config.get( 'wgCanonicalNamespace' ).toLowerCase() || 'main' ) )
.append( this.$originalContent );
 
if ( history.replaceState ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/291533
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa999f0e60fe1b6d68c63813025c9fd48b79ad5f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add cloneWithData() utility - change (VisualEditor/VisualEditor)

2016-05-29 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Add cloneWithData() utility
..


Add cloneWithData() utility

We should probably use this for creating new documents
for references and captions, so we get similar behavior
to cloneFromRange().

Change-Id: I34662b3c8247298531ba34dfbb789293ddebc4d2
---
M src/dm/ve.dm.Document.js
1 file changed, 32 insertions(+), 10 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  Esanders: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/src/dm/ve.dm.Document.js b/src/dm/ve.dm.Document.js
index 71f5e99..28f0ccb 100644
--- a/src/dm/ve.dm.Document.js
+++ b/src/dm/ve.dm.Document.js
@@ -586,24 +586,46 @@
  * @return {ve.dm.Document} New document
  */
 ve.dm.Document.prototype.cloneFromRange = function ( range ) {
-   var data, newDoc,
-   store = this.getStore().clone(),
-   listRange = 
this.getInternalList().getListNode().getOuterRange();
-
-   data = ve.copy( this.getFullData( range, true ) );
+   var listRange = this.getInternalList().getListNode().getOuterRange(),
+   data = ve.copy( this.getFullData( range, true ) );
if ( range.start > listRange.start || range.end < listRange.end ) {
// The range does not include the entire internal list, so add 
it
data = data.concat( this.getFullData( listRange ) );
}
+   return this.cloneWithData( data, true );
+};
+
+/**
+ * Create a sub-document associated with this document like #cloneFromRange, 
but without cloning
+ * any data from a range in this document: instead, use the specified data.
+ *
+ * @param {Array} data Linear model data
+ * @param {boolean} [copyInternalList] Copy the internal list
+ * @return {ve.dm.Document} New document
+ */
+ve.dm.Document.prototype.cloneWithData = function ( data, copyInternalList ) {
+   var newDoc,
+   store = this.getStore().clone();
+
newDoc = new this.constructor(
new ve.dm.FlatLinearData( store, data ),
-   this.getHtmlDocument(), undefined, this.getInternalList(), 
undefined,
+   // htmlDocument
+   this.getHtmlDocument(),
+   // parentDocument
+   undefined,
+   // internalList
+   copyInternalList ? this.getInternalList() : undefined,
+   // innerWhitespace
+   undefined,
+   // lang+dir
this.getLang(), this.getDir()
);
-   // Record the length of the internal list at the time the slice was 
created so we can
-   // reconcile additions properly
-   newDoc.origDoc = this;
-   newDoc.origInternalListLength = this.internalList.getItemNodeCount();
+   if ( copyInternalList ) {
+   // Record the length of the internal list at the time the slice 
was created so we can
+   // reconcile additions properly
+   newDoc.origDoc = this;
+   newDoc.origInternalListLength = 
this.internalList.getItemNodeCount();
+   }
return newDoc;
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/155655
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I34662b3c8247298531ba34dfbb789293ddebc4d2
Gerrit-PatchSet: 6
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: DLynch 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Mooeypoo 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix font size in target widget debug bar - change (mediawiki...VisualEditor)

2016-05-29 Thread Esanders (Code Review)

Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291596

Change subject: Fix font size in target widget debug bar
..

Fix font size in target widget debug bar

Change-Id: Ic5120fd1d2cc4955a502fa57478a19851f9f6b33
---
M modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-monobook.css
M modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-vector.css
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/96/291596/1

diff --git a/modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-monobook.css 
b/modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-monobook.css
index f10931c..9e4ec8a 100644
--- a/modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-monobook.css
+++ b/modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-monobook.css
@@ -6,7 +6,7 @@
  */
 
 .ve-init-mw-desktopArticleTarget-toolbar,
-.ve-ui-debugBar,
+.ve-init-mw-desktopArticleTarget > .ve-ui-debugBar,
 .ve-ui-overlay-global {
/* Enforce different font-size for all UI elements of VisualEditor. The 
difference is tiny, but
   enough to make the icon containers 23.813px rather than 24px and 
thus the icons blurry */
diff --git a/modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-vector.css 
b/modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-vector.css
index 7f1f050..b1d3584 100644
--- a/modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-vector.css
+++ b/modules/ve-mw/init/styles/ve.init.mw.DesktopTarget-vector.css
@@ -6,7 +6,7 @@
  */
 
 .ve-init-mw-desktopArticleTarget-toolbar,
-.ve-ui-debugBar,
+.ve-init-mw-desktopArticleTarget > .ve-ui-debugBar,
 .ve-ui-overlay {
/* Enforce different font-size for all UI elements of VisualEditor */
font-size: 0.8em;

-- 
To view, visit https://gerrit.wikimedia.org/r/291596
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic5120fd1d2cc4955a502fa57478a19851f9f6b33
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Convert Special:GlobalRenameRequest to OOUI - change (mediawiki...CentralAuth)

2016-05-29 Thread Glaisher (Code Review)

Glaisher has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291595

Change subject: Convert Special:GlobalRenameRequest to OOUI
..

Convert Special:GlobalRenameRequest to OOUI

I also removed the help-message for the current username field
and email address field because it feels pretty self-explanatory
and redundant to me. The CSS has been removed so the field labels
are no longer bold faced because we don't that for other forms either.
The JS module has also been removed and instead of a popup, it now
shows the globalrenamerequest-email-why-explain message as a notice
generated on the PHP side.

Bug: T104299
Bug: T88214
Change-Id: I62a2c2ecab82652dbccb40d5605e429754f136ba
Depends-On: I512f3936bc3335df1bdf76505cfc39da6be99bed
---
M i18n/en.json
M i18n/qqq.json
M includes/CentralAuthHooks.php
M includes/specials/SpecialGlobalRenameRequest.php
D modules/ext.centralauth.globalrenamerequest.css
D modules/ext.centralauth.globalrenamerequest.js
6 files changed, 9 insertions(+), 74 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth 
refs/changes/95/291595/1

diff --git a/i18n/en.json b/i18n/en.json
index b760439..6343d77 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -427,15 +427,12 @@
"globalrenamerequest-forced": "The Wikimedia Foundation is 
[[:mw:SUL_finalisation|unifying usernames across all Wikimedia projects]]. This 
username was identified as being in use in other Wikimedia wikis and must be 
changed in order to finalize this unification. As a result, you must select a 
new username.",
"globalrenamerequest-pretext" : "Request a new username to be known by 
across all projects.\n\nAll of your previous contributions will be connected 
with this new username.\n\nOnce you have requested a new username, a 
notification will be sent to Wikimedia stewards to perform the rename. You will 
be notified by email when this process is completed.",
"globalrenamerequest-username-label": "Current username:",
-   "globalrenamerequest-username-help": "This is your username now.",
"globalrenamerequest-newname-label": "Requested username:",
"globalrenamerequest-newname-help": "Enter the new username you wish to 
use, e.g., \"$1\".",
"globalrenamerequest-newname-err-invalid": "You have not specified a 
valid user name.",
"globalrenamerequest-newname-err-taken": "Username entered already in 
use. Please choose a different name.",
"globalrenamerequest-email-label": "Email address:",
-   "globalrenamerequest-email-help": "Enter your email address.",
-   "globalrenamerequest-email-why-label": "Why?",
-   "globalrenamerequest-email-why-explain": "We need an email address 
during this process to ensure that you do not lose access to this 
account.You can remove the email address after the rename process has 
completed.",
+   "globalrenamerequest-email-why-explain": "We need an email address 
during this process to ensure that you do not lose access to this account.You can remove the email address after the rename process has completed.",
"globalrenamerequest-email2-label": "Confirm email address:",
"globalrenamerequest-email2-help": "Enter the same email address you 
entered above for confirmation.",
"globalrenamerequest-email-mismatch": "Email addresses differ.Please check both and try again.",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 2d2476b..9cd2eae 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -443,15 +443,12 @@
"globalrenamerequest-forced": "Explanation for users that are being 
forced to rename.\n\nFollowed by the message 
{{msg-mw|globalrenamerequest-pretext}}",
"globalrenamerequest-pretext": "Instructions for rename process.",
"globalrenamerequest-username-label": "Form field label.",
-   "globalrenamerequest-username-help": "Form field inline help.",
"globalrenamerequest-newname-label": "Form field label.",
"globalrenamerequest-newname-help": "Form field inline help.\n\n* $1 is 
a randomly generated username suggestion.",
"globalrenamerequest-newname-err-invalid": "Used as error message.",
"globalrenamerequest-newname-err-taken": "Used as error message.",
"globalrenamerequest-email-label": "Form field 
label.\n{{Identical|E-mail address}}",
-   "globalrenamerequest-email-help": "Form field inline help.",
-   "globalrenamerequest-email-why-label": "Label for popup 
dialog.\n{{Identical|Why}}",
-   "globalrenamerequest-email-why-explain": "Message for popup dialog.",
+   "globalrenamerequest-email-why-explain": "Information message for email 
address field shown on Special:GlobalRenameRequest.",
"globalrenamerequest-email2-label": "Form field label.",
"globalrenamerequest-email2-help": "Form field inline help.",
"globalrenamerequest-email-mismatch": "Error message shown

[MediaWiki-commits] [Gerrit] Improve diff algorithm - change (pywikibot/core)

2016-05-29 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Improve diff algorithm
..


Improve diff algorithm

Use format indication for added lines only once.

Bug: T136511
Change-Id: I608f2c97565abe897404af2ccd33dc59e6a4619d
---
M pywikibot/diff.py
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Xqt: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/pywikibot/diff.py b/pywikibot/diff.py
index 5c86c5d..6ea3acd 100644
--- a/pywikibot/diff.py
+++ b/pywikibot/diff.py
@@ -125,6 +125,10 @@
 continue
 if line2.startswith('?'):
 yield self.color_line(line1, line2)
+# do not try to reuse line2 as format at next iteration
+# if already used for an added line.
+if line1.startswith('+'):
+line2 = ''
 continue
 if line1.startswith('-'):
 # Color whole line to be removed.

-- 
To view, visit https://gerrit.wikimedia.org/r/291587
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I608f2c97565abe897404af2ccd33dc59e6a4619d
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Mpaa 
Gerrit-Reviewer: John Vandenberg 
Gerrit-Reviewer: Xqt 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] InnoDB now supports fulltext which we need for searchindex s... - change (mediawiki/core)

2016-05-29 Thread Paladox (Code Review)

Paladox has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291594

Change subject: InnoDB now supports fulltext which we need for searchindex so 
lets use it
..

InnoDB now supports fulltext which we need for searchindex so lets use it

fulltext is now supported in mysql 5.6
https://dev.mysql.com/doc/refman/5.6/en/innodb-fulltext-index.html

Lets use it if we use mysql 5.6

This patch will backup searchindex table and copy it to searchindex_old
then it will drop searchindex and recreate it with fulltext support for
innodb.

Change-Id: I351c8b49fb24d7584120df45da7537c94be777ee
---
M includes/installer/MysqlUpdater.php
A maintenance/archives/patch-mysql-5.6-copy-searchindex.sql
A maintenance/archives/patch-mysql-5.6-searchindex.sql
3 files changed, 38 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/94/291594/1

diff --git a/includes/installer/MysqlUpdater.php 
b/includes/installer/MysqlUpdater.php
index d414d907..509bd54 100644
--- a/includes/installer/MysqlUpdater.php
+++ b/includes/installer/MysqlUpdater.php
@@ -29,6 +29,18 @@
  */
 class MysqlUpdater extends DatabaseUpdater {
protected function getCoreUpdateList() {
+   $dbType = $this->db->getType();
+
+   if ( $dbType === 'mysql' && $this->db->getServerVersion() >= 
5.6 ) {
+   $SearchIndexAddTable1 = [ 'addTable', 
'searchindex_old', 'patch-mysql-5.6-copy-searchindex.sql' ];
+   $SearchIndexDrop = [ 'dropTable', 'searchindex' ];
+   $SearchIndexAddTable2 = [ 'addTable', 'searchindex', 
'patch-mysql-5.6-searchindex.sql' ];
+   } else {
+   $SearchIndexAddTable1 = [ '' ];
+   $SearchIndexDrop = [ '' ];
+   $SearchIndexAddTable2 = [ '' ];
+   }
+
return [
[ 'disableContentHandlerUseDB' ],
 
@@ -283,6 +295,9 @@
[ 'addIndex', 'categorylinks', 'cl_collation_ext',
'patch-add-cl_collation_ext_index.sql' ],
[ 'doCollationUpdate' ],
+   $SearchIndexAddTable1,
+   $SearchIndexDrop,
+   $SearchIndexAddTable2,
];
}
 
diff --git a/maintenance/archives/patch-mysql-5.6-copy-searchindex.sql 
b/maintenance/archives/patch-mysql-5.6-copy-searchindex.sql
new file mode 100644
index 000..acd7241
--- /dev/null
+++ b/maintenance/archives/patch-mysql-5.6-copy-searchindex.sql
@@ -0,0 +1,2 @@
+-- Backups table since we will be dopping and recreating it in MySQL 5.6
+CREATE TABLE searchindex_old SELECT * FROM searchindex
diff --git a/maintenance/archives/patch-mysql-5.6-searchindex.sql 
b/maintenance/archives/patch-mysql-5.6-searchindex.sql
new file mode 100644
index 000..30e7bca
--- /dev/null
+++ b/maintenance/archives/patch-mysql-5.6-searchindex.sql
@@ -0,0 +1,21 @@
+-- This only supports mysql 5.6+
+--
+-- When using the default MySQL search backend, page titles
+-- and text are munged to strip markup, do Unicode case folding,
+-- and prepare the result for MySQL's fulltext index.
+--
+-- This table must be InnoDB;
+--
+CREATE TABLE /*_*/searchindex (
+  -- Key to page_id
+  si_page int unsigned NOT NULL,
+
+  -- Munged version of title
+  si_title varchar(255) NOT NULL default '',
+
+  -- Munged version of body text
+  si_text mediumtext NOT NULL,
+  FULLTEXT KEY si_title (si_title, si_text)
+) /*$wgDBTableOptions*/;
+
+CREATE UNIQUE INDEX /*i*/si_page ON /*_*/searchindex (si_page);

-- 
To view, visit https://gerrit.wikimedia.org/r/291594
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I351c8b49fb24d7584120df45da7537c94be777ee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Paladox 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] raise fe mem size to 37% on text and upload - change (operations/puppet)

2016-05-29 Thread BBlack (Code Review)

BBlack has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291593

Change subject: raise fe mem size to 37% on text and upload
..

raise fe mem size to 37% on text and upload

This gets us halfway further from the current 25% values to the
50% values tested maps and misc (where the cache doesn't often
grow to full size anyways...).  With the new jemalloc tuning, the
virtual overhead shouldn't get unreasonable.

Bug: T135384
Change-Id: I05d0a59a72ea7b05367343e717b7f709fd2903b5
---
M modules/role/manifests/cache/text.pp
M modules/role/manifests/cache/upload.pp
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/93/291593/1

diff --git a/modules/role/manifests/cache/text.pp 
b/modules/role/manifests/cache/text.pp
index 2898553..ac914a5 100644
--- a/modules/role/manifests/cache/text.pp
+++ b/modules/role/manifests/cache/text.pp
@@ -108,7 +108,7 @@
 })
 
 role::cache::instances { 'text':
-fe_mem_gb=> ceiling(0.25 * $::memorysize_mb / 1024.0),
+fe_mem_gb=> ceiling(0.37 * $::memorysize_mb / 1024.0),
 fe_jemalloc_conf => 'lg_dirty_mult:8,lg_chunk_size:16',
 runtime_params   => ['default_ttl=2592000'],
 app_directors=> $app_directors,
diff --git a/modules/role/manifests/cache/upload.pp 
b/modules/role/manifests/cache/upload.pp
index 0953f7b..8a25f95 100644
--- a/modules/role/manifests/cache/upload.pp
+++ b/modules/role/manifests/cache/upload.pp
@@ -89,7 +89,7 @@
 ], ' ')
 
 role::cache::instances { 'upload':
-fe_mem_gb=> ceiling(0.25 * $::memorysize_mb / 1024.0),
+fe_mem_gb=> ceiling(0.37 * $::memorysize_mb / 1024.0),
 fe_jemalloc_conf => 'lg_dirty_mult:8,lg_chunk_size:17',
 runtime_params   => ['default_ttl=2592000'],
 app_directors=> $app_directors,

-- 
To view, visit https://gerrit.wikimedia.org/r/291593
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I05d0a59a72ea7b05367343e717b7f709fd2903b5
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BBlack 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] varnish: jemalloc tuning for frontend caches - change (operations/puppet)

2016-05-29 Thread BBlack (Code Review)

BBlack has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291592

Change subject: varnish: jemalloc tuning for frontend caches
..

varnish: jemalloc tuning for frontend caches

This should reduce the virtual and resident waste/overhead when
configuring frontend malloc storage with large fractions of total
memory.  Note that the chunk size could probably use further
tuning per-cluster, but the values in this patch are reasonable
conservative estimates from some basic experimentation/research.

Bug: T135384
Change-Id: Ie0bdcbf6a0290b76131a6a43c3013d72b653100f
---
M modules/role/manifests/cache/instances.pp
M modules/role/manifests/cache/maps.pp
M modules/role/manifests/cache/misc.pp
M modules/role/manifests/cache/text.pp
M modules/role/manifests/cache/upload.pp
M modules/varnish/manifests/instance.pp
M modules/varnish/templates/initscripts/varnish.systemd.erb
7 files changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/92/291592/1

diff --git a/modules/role/manifests/cache/instances.pp 
b/modules/role/manifests/cache/instances.pp
index 0535d83..2bf7d03 100644
--- a/modules/role/manifests/cache/instances.pp
+++ b/modules/role/manifests/cache/instances.pp
@@ -1,6 +1,7 @@
 # This defines the pair of varnish::instance for a 2layer/2tier cache cluster
 define role::cache::instances (
 $fe_mem_gb,
+$fe_jemalloc_conf,
 $runtime_params,
 $app_directors,
 $app_be_opts,
@@ -101,6 +102,7 @@
 admin_port => 6082,
 runtime_parameters => $runtime_params,
 storage=> "-s malloc,${fe_mem_gb}G",
+jemalloc_conf  => $fe_jemalloc_conf,
 directors  => {
 'cache_local' => {
 'dynamic'  => 'yes',
diff --git a/modules/role/manifests/cache/maps.pp 
b/modules/role/manifests/cache/maps.pp
index adb6889..b6acb58 100644
--- a/modules/role/manifests/cache/maps.pp
+++ b/modules/role/manifests/cache/maps.pp
@@ -53,6 +53,7 @@
 
 role::cache::instances { 'maps':
 fe_mem_gb=> ceiling(0.5 * $::memorysize_mb / 1024.0),
+fe_jemalloc_conf => 'lg_dirty_mult:8,lg_chunk_size:17',
 runtime_params   => ['default_ttl=86400'],
 app_directors=> $app_directors,
 app_be_opts  => [],
diff --git a/modules/role/manifests/cache/misc.pp 
b/modules/role/manifests/cache/misc.pp
index 695dc90..3de3729 100644
--- a/modules/role/manifests/cache/misc.pp
+++ b/modules/role/manifests/cache/misc.pp
@@ -258,6 +258,7 @@
 
 role::cache::instances { 'misc':
 fe_mem_gb=> ceiling(0.5 * $::memorysize_mb / 1024.0),
+fe_jemalloc_conf => 'lg_dirty_mult:8,lg_chunk_size:17',
 runtime_params   => [],
 app_directors=> $app_directors,
 # FIXME - top-scope var without namespace, will break in puppet 2.8
diff --git a/modules/role/manifests/cache/text.pp 
b/modules/role/manifests/cache/text.pp
index 861d14f..2898553 100644
--- a/modules/role/manifests/cache/text.pp
+++ b/modules/role/manifests/cache/text.pp
@@ -109,6 +109,7 @@
 
 role::cache::instances { 'text':
 fe_mem_gb=> ceiling(0.25 * $::memorysize_mb / 1024.0),
+fe_jemalloc_conf => 'lg_dirty_mult:8,lg_chunk_size:16',
 runtime_params   => ['default_ttl=2592000'],
 app_directors=> $app_directors,
 # FIXME - top-scope var without namespace, will break in puppet 2.8
diff --git a/modules/role/manifests/cache/upload.pp 
b/modules/role/manifests/cache/upload.pp
index 962d9bb..0953f7b 100644
--- a/modules/role/manifests/cache/upload.pp
+++ b/modules/role/manifests/cache/upload.pp
@@ -90,6 +90,7 @@
 
 role::cache::instances { 'upload':
 fe_mem_gb=> ceiling(0.25 * $::memorysize_mb / 1024.0),
+fe_jemalloc_conf => 'lg_dirty_mult:8,lg_chunk_size:17',
 runtime_params   => ['default_ttl=2592000'],
 app_directors=> $app_directors,
 app_be_opts  => [],
diff --git a/modules/varnish/manifests/instance.pp 
b/modules/varnish/manifests/instance.pp
index 0081ed2..2ad339e 100644
--- a/modules/varnish/manifests/instance.pp
+++ b/modules/varnish/manifests/instance.pp
@@ -20,6 +20,7 @@
 $name='',
 $vcl = '',
 $storage='-s malloc,1G',
+$jemalloc_conf=undef,
 $runtime_parameters=[],
 $directors={},
 $extra_vcl = []
diff --git a/modules/varnish/templates/initscripts/varnish.systemd.erb 
b/modules/varnish/templates/initscripts/varnish.systemd.erb
index 0efe077..f246f6b 100644
--- a/modules/varnish/templates/initscripts/varnish.systemd.erb
+++ b/modules/varnish/templates/initscripts/varnish.systemd.erb
@@ -11,6 +11,9 @@
 <% if @vcl_config.fetch("enable_geoiplookup", false) -%>
 Environment="CC_COMMAND=exec cc -fpic -shared -Wl,-x -L/usr/local/lib/ -o %%o 
%%s -lGeoIP"
 <% end -%>
+<% if @jemalloc_conf -%>
+Environment=MALLOC_CONF=<%=

[MediaWiki-commits] [Gerrit] Return a master instance from our implementation of AuthPlug... - change (mediawiki...CentralAuth)

2016-05-29 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Return a master instance from our implementation of 
AuthPlugin::getUserInstance()
..


Return a master instance from our implementation of 
AuthPlugin::getUserInstance()

We don't know if the caller is going to call write methods like
AuthPluginUser::resetAuthToken(), so to be safe we need to return a
master instance here.

Bug: T135954
Change-Id: Ic2a6c2a684f4787603ab13310e6b40c6471e3cd6
---
M includes/CentralAuthPlugin.php
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Gergő Tisza: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/CentralAuthPlugin.php b/includes/CentralAuthPlugin.php
index 37dff76..f2a256b 100644
--- a/includes/CentralAuthPlugin.php
+++ b/includes/CentralAuthPlugin.php
@@ -364,7 +364,9 @@
 * @return CentralAuthUser
 */
public function getUserInstance( User &$user ) {
-   return CentralAuthUser::getInstance( $user );
+   // Needs to be a master instance because we don't know if the 
caller is
+   // going to call write methods like 
AuthPluginUser::resetAuthToken().
+   return CentralAuthUser::getMasterInstance( $user );
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/291229
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2a6c2a684f4787603ab13310e6b40c6471e3cd6
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Anomie 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: Gergő Tisza 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Test - change (mediawiki/core)

2016-05-29 Thread Paladox (Code Review)

Paladox has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291591

Change subject: Test
..

Test

Change-Id: Iccbd4bfb42a572249846c649f41be0170e6dc399
---
M includes/installer/MysqlUpdater.php
A maintenance/archives/patch-mysql-5.6-searchindex.sql
2 files changed, 34 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/91/291591/1

diff --git a/includes/installer/MysqlUpdater.php 
b/includes/installer/MysqlUpdater.php
index d414d907..07e717e 100644
--- a/includes/installer/MysqlUpdater.php
+++ b/includes/installer/MysqlUpdater.php
@@ -29,6 +29,17 @@
  */
 class MysqlUpdater extends DatabaseUpdater {
protected function getCoreUpdateList() {
+   $status = $this->getConnection();
+   $conn = $status->value;
+   $version = $conn->getServerVersion();
+
+   if ( version_compare( $version, '5.6' ) < 0 ) {
+   $SearchIndexDrop = [ 'dropTable', 'searchindex' ];
+   $SearchIndexAddTable = [ 'addTable', 'searchindex', 
'patch-mysql-5.6-searchindex.sql' ];
+   } else {
+   $SearchIndexDrop = [ '' ];
+   $SearchIndexAddTable = [ '' ];
+   }
return [
[ 'disableContentHandlerUseDB' ],
 
@@ -283,6 +294,8 @@
[ 'addIndex', 'categorylinks', 'cl_collation_ext',
'patch-add-cl_collation_ext_index.sql' ],
[ 'doCollationUpdate' ],
+   $SearchIndexDrop,
+   $SearchIndexAddTable,
];
}
 
diff --git a/maintenance/archives/patch-mysql-5.6-searchindex.sql 
b/maintenance/archives/patch-mysql-5.6-searchindex.sql
new file mode 100644
index 000..30e7bca
--- /dev/null
+++ b/maintenance/archives/patch-mysql-5.6-searchindex.sql
@@ -0,0 +1,21 @@
+-- This only supports mysql 5.6+
+--
+-- When using the default MySQL search backend, page titles
+-- and text are munged to strip markup, do Unicode case folding,
+-- and prepare the result for MySQL's fulltext index.
+--
+-- This table must be InnoDB;
+--
+CREATE TABLE /*_*/searchindex (
+  -- Key to page_id
+  si_page int unsigned NOT NULL,
+
+  -- Munged version of title
+  si_title varchar(255) NOT NULL default '',
+
+  -- Munged version of body text
+  si_text mediumtext NOT NULL,
+  FULLTEXT KEY si_title (si_title, si_text)
+) /*$wgDBTableOptions*/;
+
+CREATE UNIQUE INDEX /*i*/si_page ON /*_*/searchindex (si_page);

-- 
To view, visit https://gerrit.wikimedia.org/r/291591
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iccbd4bfb42a572249846c649f41be0170e6dc399
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Paladox 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Typo fix for AuthPluginPrimaryAuthenticationProvider::provid... - change (mediawiki/core)

2016-05-29 Thread Code Review

Gergő Tisza has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291590

Change subject: Typo fix for 
AuthPluginPrimaryAuthenticationProvider::providerAllowsAuthenticationDataChange
..

Typo fix for 
AuthPluginPrimaryAuthenticationProvider::providerAllowsAuthenticationDataChange

Change-Id: I7c05ea91009cdf765b06438e055de891e0edd1f4
---
M includes/auth/AuthPluginPrimaryAuthenticationProvider.php
M tests/phpunit/includes/auth/AuthPluginPrimaryAuthenticationProviderTest.php
2 files changed, 25 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/90/291590/1

diff --git a/includes/auth/AuthPluginPrimaryAuthenticationProvider.php 
b/includes/auth/AuthPluginPrimaryAuthenticationProvider.php
index 9746637..b8e36bc 100644
--- a/includes/auth/AuthPluginPrimaryAuthenticationProvider.php
+++ b/includes/auth/AuthPluginPrimaryAuthenticationProvider.php
@@ -329,7 +329,7 @@
if ( $req->domain === null ) {
return \StatusValue::newGood( 'ignored' 
);
}
-   if ( !$this->auth->validDomain( $domain ) ) {
+   if ( !$this->auth->validDomain( $req->domain ) 
) {
return \StatusValue::newFatal( 
'authmanager-authplugin-setpass-bad-domain' );
}
}
diff --git 
a/tests/phpunit/includes/auth/AuthPluginPrimaryAuthenticationProviderTest.php 
b/tests/phpunit/includes/auth/AuthPluginPrimaryAuthenticationProviderTest.php
index b676d69..44f2743 100644
--- 
a/tests/phpunit/includes/auth/AuthPluginPrimaryAuthenticationProviderTest.php
+++ 
b/tests/phpunit/includes/auth/AuthPluginPrimaryAuthenticationProviderTest.php
@@ -461,14 +461,19 @@
 * @param StatusValue $expect
 */
public function testProviderAllowsAuthenticationDataChange( $type, 
$allow, $expect ) {
+   $domains = $type instanceof PasswordDomainAuthenticationRequest 
? [ 'foo', 'bar' ] : [];
$plugin = $this->getMock( 'AuthPlugin' );
-   $plugin->expects( $this->any() )->method( 'domainList' 
)->willReturn( [] );
+   $plugin->expects( $this->any() )->method( 'domainList' 
)->willReturn( $domains );
$plugin->expects( $allow === null ? $this->never() : 
$this->once() )
->method( 'allowPasswordChange' )->will( 
$this->returnValue( $allow ) );
+   $plugin->expects( $this->any() )->method( 'validDomain' )
+   ->willReturnCallback( function ( $d ) use ( $domains ) {
+   return in_array( $d, $domains, true );
+   } );
$provider = new AuthPluginPrimaryAuthenticationProvider( 
$plugin );
 
-   if ( $type === PasswordAuthenticationRequest::class ) {
-   $req = new $type();
+   if ( is_object( $type ) ) {
+   $req = $type;
} else {
$req = $this->getMock( $type );
}
@@ -480,14 +485,28 @@
}
 
public static function provideProviderAllowsAuthenticationDataChange() {
+   $domains = [ 'foo', 'bar' ];
+   $reqNoDomain = new PasswordDomainAuthenticationRequest( 
$domains );
+   $reqValidDomain = new PasswordDomainAuthenticationRequest( 
$domains );
+   $reqValidDomain->domain = 'foo';
+   $reqInvalidDomain = new PasswordDomainAuthenticationRequest( 
$domains );
+   $reqInvalidDomain->domain = 'invalid';
+
return [
[ AuthenticationRequest::class, null, 
\StatusValue::newGood( 'ignored' ) ],
-   [ PasswordAuthenticationRequest::class, true, 
\StatusValue::newGood() ],
+   [ new PasswordAuthenticationRequest, true, 
\StatusValue::newGood() ],
[
-   PasswordAuthenticationRequest::class,
+   new PasswordAuthenticationRequest,
false,
\StatusValue::newFatal( 
'authmanager-authplugin-setpass-denied' )
],
+   [ $reqNoDomain, true, \StatusValue::newGood( 'ignored' 
) ],
+   [ $reqValidDomain, true, \StatusValue::newGood() ],
+   [
+   $reqInvalidDomain,
+   true,
+   \StatusValue::newFatal( 
'authmanager-authplugin-setpass-bad-domain' )
+   ],
];
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/291590
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

[MediaWiki-commits] [Gerrit] Enable ArticlePlaceholder extension in guwiki - change (operations/mediawiki-config)

2016-05-29 Thread KartikMistry (Code Review)

KartikMistry has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291589

Change subject: Enable ArticlePlaceholder extension in guwiki
..

Enable ArticlePlaceholder extension in guwiki

Bug: T136517
Change-Id: I06fbaf51432ff7656a3a7768e7b8d32338c4edda
---
M wmf-config/InitialiseSettings.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/89/291589/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 66822d1..aa67dcb 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -15976,6 +15976,7 @@
 'wmgUseArticlePlaceholder' => [
'default' => false,
'eowiki' => true,
+   'guwiki' => true,
'htwiki' => true,
'napwiki' => true,
'orwiki' => true,

-- 
To view, visit https://gerrit.wikimedia.org/r/291589
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I06fbaf51432ff7656a3a7768e7b8d32338c4edda
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: KartikMistry 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Test - change (mediawiki/core)

2016-05-29 Thread Paladox (Code Review)

Paladox has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291588

Change subject: Test
..

Test

Change-Id: I5dfcd85693e461f0b2f92acb4be3a3d6143f884c
---
M includes/PHPVersionCheck.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/88/291588/1

diff --git a/includes/PHPVersionCheck.php b/includes/PHPVersionCheck.php
index ab8aada..c21e892 100644
--- a/includes/PHPVersionCheck.php
+++ b/includes/PHPVersionCheck.php
@@ -31,7 +31,7 @@
  */
 function wfEntryPointCheck( $entryPoint ) {
$mwVersion = '1.28';
-   $minimumVersionPHP = '5.5.9';
+   $minimumVersionPHP = '5.6.9';
$phpVersion = PHP_VERSION;
 
if ( !function_exists( 'version_compare' )

-- 
To view, visit https://gerrit.wikimedia.org/r/291588
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5dfcd85693e461f0b2f92acb4be3a3d6143f884c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Paladox 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Improve diff algorithm - change (pywikibot/core)

2016-05-29 Thread Mpaa (Code Review)

Mpaa has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291587

Change subject: Improve diff algorithm
..

Improve diff algorithm

Use format indication for added lines only once.

Bug: T136511
Change-Id: I608f2c97565abe897404af2ccd33dc59e6a4619d
---
M pywikibot/diff.py
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/87/291587/1

diff --git a/pywikibot/diff.py b/pywikibot/diff.py
index 5c86c5d..6ea3acd 100644
--- a/pywikibot/diff.py
+++ b/pywikibot/diff.py
@@ -125,6 +125,10 @@
 continue
 if line2.startswith('?'):
 yield self.color_line(line1, line2)
+# do not try to reuse line2 as format at next iteration
+# if already used for an added line.
+if line1.startswith('+'):
+line2 = ''
 continue
 if line1.startswith('-'):
 # Color whole line to be removed.

-- 
To view, visit https://gerrit.wikimedia.org/r/291587
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I608f2c97565abe897404af2ccd33dc59e6a4619d
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Mpaa 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix license header - change (mediawiki...Elastica)

2016-05-29 Thread DCausse (Code Review)

DCausse has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291586

Change subject: Fix license header
..

Fix license header

Change-Id: If60c0de7f1bdabb627c131adce1f3c1e95190513
---
M ElasticaHooks.php
1 file changed, 9 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Elastica 
refs/changes/86/291586/1

diff --git a/ElasticaHooks.php b/ElasticaHooks.php
index 410af53..c8a9ce2 100644
--- a/ElasticaHooks.php
+++ b/ElasticaHooks.php
@@ -2,20 +2,22 @@
 /*
  * This file is part of the MediaWiki extension Elastica.
  *
- * BetaFeatures is free software: you can redistribute it and/or modify
+ * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 2 of the License, or
+ * the Free Software Foundation; either version 2 of the License, or
  * (at your option) any later version.
  *
- * BetaFeatures is distributed in the hope that it will be useful,
+ * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  * GNU General Public License for more details.
  *
- * You should have received a copy of the GNU General Public License
- * along with BetaFeatures.  If not, see .
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ * http://www.gnu.org/copyleft/gpl.html
  *
- * BetaFeatures extension hooks
+ * Elastica extension hooks
  *
  * @file
  * @ingroup Extensions

-- 
To view, visit https://gerrit.wikimedia.org/r/291586
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If60c0de7f1bdabb627c131adce1f3c1e95190513
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Elastica
Gerrit-Branch: master
Gerrit-Owner: DCausse 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [fix] fix docstring - change (pywikibot/core)

2016-05-29 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: [fix] fix docstring
..


[fix] fix docstring

Bug: T136510
Change-Id: I11cae2c4edc816f331f1759e6896d17264abeeda
---
M scripts/delete.py
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  John Vandenberg: Looks good to me, but someone else must approve
  Mpaa: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/scripts/delete.py b/scripts/delete.py
index 52a3bc7..4fbe618 100755
--- a/scripts/delete.py
+++ b/scripts/delete.py
@@ -31,12 +31,12 @@
 -orphansonly: Specified namespaces. Separate multiple namespace
   numbers or names with commas.
   Examples:
-  -ns:0,2,4
-  -ns:Help,MediaWiki
+  -orphansonly:0,2,4
+  -orphansonly:Help,MediaWiki
 
   Note that Main ns can be indicated either with a 0 or a ',':
-  -ns:0,1
-  -ns:,Talk
+  -orphansonly:0,1
+  -orphansonly:,Talk
 
 Usage:
 

-- 
To view, visit https://gerrit.wikimedia.org/r/291580
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I11cae2c4edc816f331f1759e6896d17264abeeda
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt 
Gerrit-Reviewer: John Vandenberg 
Gerrit-Reviewer: Mpaa 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] WatchedItemStore: Use callable type hint instead of Assert l... - change (mediawiki/core)

2016-05-29 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: WatchedItemStore: Use callable type hint instead of Assert 
library
..


WatchedItemStore: Use callable type hint instead of Assert library

And remove an unused use statement.

Change-Id: Idb74a564088744d73f71f5ef17e8f84f6e484c69
---
M includes/WatchedItemStore.php
1 file changed, 2 insertions(+), 7 deletions(-)

Approvals:
  Addshore: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/WatchedItemStore.php b/includes/WatchedItemStore.php
index 6486955..515fbfc 100644
--- a/includes/WatchedItemStore.php
+++ b/includes/WatchedItemStore.php
@@ -1,7 +1,6 @@
 deferredUpdatesAddCallableUpdateCallback;
$this->deferredUpdatesAddCallableUpdateCallback = $callback;
return new ScopedCallback( function() use ( $previousValue ) {
@@ -106,14 +103,12 @@
 * @return ScopedCallback to reset the overridden value
 * @throws MWException
 */
-   public function overrideRevisionGetTimestampFromIdCallback( $callback ) 
{
+   public function overrideRevisionGetTimestampFromIdCallback( callable 
$callback ) {
if ( !defined( 'MW_PHPUNIT_TEST' ) ) {
throw new MWException(
'Cannot override Revision::getTimestampFromId 
callback in operation.'
);
}
-   Assert::parameterType( 'callable', $callback, '$callback' );
-
$previousValue = $this->revisionGetTimestampFromIdCallback;
$this->revisionGetTimestampFromIdCallback = $callback;
return new ScopedCallback( function() use ( $previousValue ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/291482
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idb74a564088744d73f71f5ef17e8f84f6e484c69
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] New Wikidata Build - 2016-05-29T10:00:01+0000 - change (mediawiki...Wikidata)

2016-05-29 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: New Wikidata Build - 2016-05-29T10:00:01+
..


New Wikidata Build - 2016-05-29T10:00:01+

Change-Id: Ic1a6304b3a04b37eca342780ee889f38fc8e7529
---
M composer.lock
M extensions/ArticlePlaceholder/composer.json
M extensions/Wikibase/client/i18n/ko.json
M extensions/Wikibase/repo/i18n/qqq.json
M extensions/Wikibase/repo/i18n/uk.json
M extensions/Wikibase/repo/includes/Actions/EditEntityAction.php
M extensions/Wikibase/repo/includes/Actions/HistoryEntityAction.php
M extensions/Wikibase/repo/includes/Content/ItemHandler.php
M extensions/Wikibase/repo/includes/Content/PropertyHandler.php
M extensions/Wikidata.org/composer.json
M vendor/composer/installed.json
11 files changed, 65 insertions(+), 64 deletions(-)

Approvals:
  Addshore: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.lock b/composer.lock
index c8e3b0b..073aacf 100644
--- a/composer.lock
+++ b/composer.lock
@@ -780,17 +780,17 @@
 "source": {
 "type": "git",
 "url": 
"https://github.com/wikimedia/mediawiki-extensions-ArticlePlaceholder.git;,
-"reference": "3b16a0ed3e89f25ba20804d591349baec1d40e76"
+"reference": "27425cc88a3ecbee15ba6973c9900b4fe90a0dba"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-ArticlePlaceholder/zipball/3b16a0ed3e89f25ba20804d591349baec1d40e76;,
-"reference": "3b16a0ed3e89f25ba20804d591349baec1d40e76",
+"url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-ArticlePlaceholder/zipball/27425cc88a3ecbee15ba6973c9900b4fe90a0dba;,
+"reference": "27425cc88a3ecbee15ba6973c9900b4fe90a0dba",
 "shasum": ""
 },
 "require-dev": {
 "jakub-onderka/php-parallel-lint": "0.9.2",
-"mediawiki/mediawiki-codesniffer": "0.7.1"
+"mediawiki/mediawiki-codesniffer": "0.7.2"
 },
 "type": "mediawiki-extension",
 "autoload": {
@@ -809,7 +809,7 @@
 ],
 "description": "Provides a special page with Wikibase information 
about a certain topic, with invitation to create an article for the topic",
 "homepage": 
"https://www.mediawiki.org/wiki/Extension:ArticlePlaceholder;,
-"time": "2016-05-27 20:18:26"
+"time": "2016-05-28 01:17:29"
 },
 {
 "name": "propertysuggester/property-suggester",
@@ -920,14 +920,14 @@
 "source": {
 "type": "git",
 "url": 
"https://gerrit.wikimedia.org/r/mediawiki/extensions/Wikidata.org;,
-"reference": "6252f0651844e7b58b102a7b3cdec1ed69ee01fb"
+"reference": "723767d5d9fe1eb6dcd383ad188220e7c1519ac6"
 },
 "require": {
 "php": ">=5.3.0"
 },
 "require-dev": {
 "jakub-onderka/php-parallel-lint": "0.9.2",
-"mediawiki/mediawiki-codesniffer": "0.7.1"
+"mediawiki/mediawiki-codesniffer": "0.7.2"
 },
 "type": "mediawiki-extension",
 "autoload": {
@@ -964,7 +964,7 @@
 "support": {
 "irc": "irc://irc.freenode.net/wikidata"
 },
-"time": "2016-05-15 20:33:40"
+"time": "2016-05-28 01:27:03"
 },
 {
 "name": "wikibase/constraints",
@@ -1569,12 +1569,12 @@
 "source": {
 "type": "git",
 "url": 
"https://github.com/wikimedia/mediawiki-extensions-Wikibase.git;,
-"reference": "e9c83ea98f98382d8d1ee16b350948ea07b304a6"
+"reference": "e5718aeded20dbcfbb8334b537533f11503ac944"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/e9c83ea98f98382d8d1ee16b350948ea07b304a6;,
-"reference": "e9c83ea98f98382d8d1ee16b350948ea07b304a6",
+"url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/e5718aeded20dbcfbb8334b537533f11503ac944;,
+"reference": "e5718aeded20dbcfbb8334b537533f11503ac944",
 "shasum": ""
 },
 "require": {
@@ -1646,7 +1646,7 @@
 "wikibaserepo",
 "wikidata"
 ],
-"time": "2016-05-27 20:22:27"
+"time": "2016-05-28 20:21:12"
 },
 {
 "name": "wikibase/wikimedia-badges",
diff --git a/extensions/ArticlePlaceholder/composer.json 
b/extensions/ArticlePlaceholder/composer.json
index c28ea01..1de7800 100644
---

[MediaWiki-commits] [Gerrit] New Wikidata Build - 2016-05-29T10:00:01+0000 - change (mediawiki...Wikidata)

2016-05-29 Thread WikidataBuilder (Code Review)

WikidataBuilder has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291585

Change subject: New Wikidata Build - 2016-05-29T10:00:01+
..

New Wikidata Build - 2016-05-29T10:00:01+

Change-Id: Ic1a6304b3a04b37eca342780ee889f38fc8e7529
---
M composer.lock
M extensions/ArticlePlaceholder/composer.json
M extensions/Wikibase/client/i18n/ko.json
M extensions/Wikibase/repo/i18n/qqq.json
M extensions/Wikibase/repo/i18n/uk.json
M extensions/Wikibase/repo/includes/Actions/EditEntityAction.php
M extensions/Wikibase/repo/includes/Actions/HistoryEntityAction.php
M extensions/Wikibase/repo/includes/Content/ItemHandler.php
M extensions/Wikibase/repo/includes/Content/PropertyHandler.php
M extensions/Wikidata.org/composer.json
M vendor/composer/installed.json
11 files changed, 65 insertions(+), 64 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikidata 
refs/changes/85/291585/1

diff --git a/composer.lock b/composer.lock
index c8e3b0b..073aacf 100644
--- a/composer.lock
+++ b/composer.lock
@@ -780,17 +780,17 @@
 "source": {
 "type": "git",
 "url": 
"https://github.com/wikimedia/mediawiki-extensions-ArticlePlaceholder.git;,
-"reference": "3b16a0ed3e89f25ba20804d591349baec1d40e76"
+"reference": "27425cc88a3ecbee15ba6973c9900b4fe90a0dba"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-ArticlePlaceholder/zipball/3b16a0ed3e89f25ba20804d591349baec1d40e76;,
-"reference": "3b16a0ed3e89f25ba20804d591349baec1d40e76",
+"url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-ArticlePlaceholder/zipball/27425cc88a3ecbee15ba6973c9900b4fe90a0dba;,
+"reference": "27425cc88a3ecbee15ba6973c9900b4fe90a0dba",
 "shasum": ""
 },
 "require-dev": {
 "jakub-onderka/php-parallel-lint": "0.9.2",
-"mediawiki/mediawiki-codesniffer": "0.7.1"
+"mediawiki/mediawiki-codesniffer": "0.7.2"
 },
 "type": "mediawiki-extension",
 "autoload": {
@@ -809,7 +809,7 @@
 ],
 "description": "Provides a special page with Wikibase information 
about a certain topic, with invitation to create an article for the topic",
 "homepage": 
"https://www.mediawiki.org/wiki/Extension:ArticlePlaceholder;,
-"time": "2016-05-27 20:18:26"
+"time": "2016-05-28 01:17:29"
 },
 {
 "name": "propertysuggester/property-suggester",
@@ -920,14 +920,14 @@
 "source": {
 "type": "git",
 "url": 
"https://gerrit.wikimedia.org/r/mediawiki/extensions/Wikidata.org;,
-"reference": "6252f0651844e7b58b102a7b3cdec1ed69ee01fb"
+"reference": "723767d5d9fe1eb6dcd383ad188220e7c1519ac6"
 },
 "require": {
 "php": ">=5.3.0"
 },
 "require-dev": {
 "jakub-onderka/php-parallel-lint": "0.9.2",
-"mediawiki/mediawiki-codesniffer": "0.7.1"
+"mediawiki/mediawiki-codesniffer": "0.7.2"
 },
 "type": "mediawiki-extension",
 "autoload": {
@@ -964,7 +964,7 @@
 "support": {
 "irc": "irc://irc.freenode.net/wikidata"
 },
-"time": "2016-05-15 20:33:40"
+"time": "2016-05-28 01:27:03"
 },
 {
 "name": "wikibase/constraints",
@@ -1569,12 +1569,12 @@
 "source": {
 "type": "git",
 "url": 
"https://github.com/wikimedia/mediawiki-extensions-Wikibase.git;,
-"reference": "e9c83ea98f98382d8d1ee16b350948ea07b304a6"
+"reference": "e5718aeded20dbcfbb8334b537533f11503ac944"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/e9c83ea98f98382d8d1ee16b350948ea07b304a6;,
-"reference": "e9c83ea98f98382d8d1ee16b350948ea07b304a6",
+"url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/e5718aeded20dbcfbb8334b537533f11503ac944;,
+"reference": "e5718aeded20dbcfbb8334b537533f11503ac944",
 "shasum": ""
 },
 "require": {
@@ -1646,7 +1646,7 @@
 "wikibaserepo",
 "wikidata"
 ],
-"time": "2016-05-27 20:22:27"
+"time": "2016-05-28 20:21:12"
 },
 {
 "name": "wikibase/wikimedia-badges",
diff --git a/extensions/ArticlePlaceholder/composer.json

[MediaWiki-commits] [Gerrit] [bugfix] getVersionHistory has only 4 items - change (pywikibot...xqbot)

2016-05-29 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: [bugfix] getVersionHistory has only 4 items
..


[bugfix] getVersionHistory has only 4 items

- Every version history tuple has 4 items only in core
  whereas compat has 6 items.

Change-Id: I7c2225cab1307eecfbd84a86725142f45f5caa6d
---
M imagereview.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Xqt: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/imagereview.py b/imagereview.py
index 8e2d67e..5469b12 100644
--- a/imagereview.py
+++ b/imagereview.py
@@ -809,7 +809,7 @@
 found = False
 vh = image.getVersionHistory()
 # Search for last bot action
-for oldid, time, username, summary, size, tags in vh:
+for oldid, time, username, summary in vh:
 if username in [u'Xqbot', u'BLUbot']:
 imageID = oldid
 break

-- 
To view, visit https://gerrit.wikimedia.org/r/291584
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7c2225cab1307eecfbd84a86725142f45f5caa6d
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/bots/xqbot
Gerrit-Branch: master
Gerrit-Owner: Xqt 
Gerrit-Reviewer: Xqt 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [bugfix] getVersionHistory has only 4 items - change (pywikibot...xqbot)

2016-05-29 Thread Xqt (Code Review)

Xqt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291584

Change subject: [bugfix] getVersionHistory has only 4 items
..

[bugfix] getVersionHistory has only 4 items

- Every version history tuple has 4 items only in core
  whereas compat has 6 items.

Change-Id: I7c2225cab1307eecfbd84a86725142f45f5caa6d
---
M imagereview.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/bots/xqbot 
refs/changes/84/291584/1

diff --git a/imagereview.py b/imagereview.py
index 8e2d67e..5469b12 100644
--- a/imagereview.py
+++ b/imagereview.py
@@ -809,7 +809,7 @@
 found = False
 vh = image.getVersionHistory()
 # Search for last bot action
-for oldid, time, username, summary, size, tags in vh:
+for oldid, time, username, summary in vh:
 if username in [u'Xqbot', u'BLUbot']:
 imageID = oldid
 break

-- 
To view, visit https://gerrit.wikimedia.org/r/291584
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7c2225cab1307eecfbd84a86725142f45f5caa6d
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/bots/xqbot
Gerrit-Branch: master
Gerrit-Owner: Xqt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] rsync::module: Replace obsolete to_a calls - change (operations/puppet)

2016-05-29 Thread Alexandros Kosiaris (Code Review)

Alexandros Kosiaris has submitted this change and it was merged.

Change subject: rsync::module: Replace obsolete to_a calls
..


rsync::module: Replace obsolete to_a calls

ruby 1.9 has removed the deprecated to_a calls that ruby 1.8 had already
deprecated. The way to get this functionality now is to call Array().
Conform to the new standard

Change-Id: I9c2e4ed64b4285e7d31f2511274dad847442ac7d
---
M modules/rsync/templates/module.erb
1 file changed, 3 insertions(+), 5 deletions(-)

Approvals:
  Ori.livneh: Looks good to me, but someone else must approve
  Alexandros Kosiaris: Verified; Looks good to me, approved



diff --git a/modules/rsync/templates/module.erb 
b/modules/rsync/templates/module.erb
index d6418a1..f20b550 100644
--- a/modules/rsync/templates/module.erb
+++ b/modules/rsync/templates/module.erb
@@ -12,8 +12,6 @@
 <% if Integer(@max_connections) > 0 %>lock file = <%= @lock_file %><% end 
%>
 <% if @comment %>comment   = <%= @comment %><% end %>
 <% if @secrets_file %>secrets file = <%= @secrets_file %><% end %>
-<% if @auth_users %>auth users = <%= @auth_users.to_a.join(', ')%><% end %>
-<% if @hosts_allow %>hosts allow = <%= @hosts_allow.to_a.join(' 
').gsub('::/64','::') %><% end %>
-<% if @hosts_deny %>hosts deny = <%= @hosts_deny.to_a.join(' ').gsub('::/64', 
'::') %><% end %>
-
-
+<% if @auth_users %>auth users = <%= Array(@auth_users).join(', ')%><% end %>
+<% if @hosts_allow %>hosts allow = <%= Array(@hosts_allow).join(' 
').gsub('::/64','::') %><% end %>
+<% if @hosts_deny %>hosts deny = <%= Array(@hosts_deny).join(' 
').gsub('::/64', '::') %><% end %>

-- 
To view, visit https://gerrit.wikimedia.org/r/291491
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9c2e4ed64b4285e7d31f2511274dad847442ac7d
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris 
Gerrit-Reviewer: Alexandros Kosiaris 
Gerrit-Reviewer: Ori.livneh 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Introduce GraphResultBrowser - change (wikidata...gui)

2016-05-29 Thread Jonas Kress (WMDE) (Code Review)

Jonas Kress (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291583

Change subject: Introduce GraphResultBrowser
..

Introduce GraphResultBrowser

Change-Id: Ib347ec1ed88f32b1ad67db6c89b397e040f1e706
---
M index.html
D vendor/vis/vis-timeline-graph2d.min.js
A vendor/vis/vis.js
M wikibase/queryService/ui/App.js
A wikibase/queryService/ui/resultBrowser/GraphResultBrowser.js
M wikibase/queryService/ui/resultBrowser/helper/FormatterHelper.js
M wikibase/tests/index.html
7 files changed, 46,418 insertions(+), 41 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui 
refs/changes/83/291583/1


-- 
To view, visit https://gerrit.wikimedia.org/r/291583
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib347ec1ed88f32b1ad67db6c89b397e040f1e706
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [cleanup] code cleanup for interwikidata_tests.py - change (pywikibot/core)

2016-05-29 Thread Xqt (Code Review)

Xqt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291582

Change subject: [cleanup] code cleanup for interwikidata_tests.py
..

[cleanup] code cleanup for interwikidata_tests.py

- when super() is the only call of a inherited method it can be omitted.

Change-Id: I530def17e44d6ba2d781a55c1f581b09a09f58ef
---
M tests/interwikidata_tests.py
1 file changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/82/291582/1

diff --git a/tests/interwikidata_tests.py b/tests/interwikidata_tests.py
index b65134b..df30ded 100644
--- a/tests/interwikidata_tests.py
+++ b/tests/interwikidata_tests.py
@@ -22,10 +22,6 @@
 
 """A dummy bot to prevent editing in production wikis."""
 
-def __init__(self, *args, **kwargs):
-"""Initiate the class."""
-super(DummyBot, self).__init__(*args, **kwargs)
-
 def put_current(self):
 """Prevent editing."""
 return False

-- 
To view, visit https://gerrit.wikimedia.org/r/291582
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I530def17e44d6ba2d781a55c1f581b09a09f58ef
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] stop using wikimedia/assert - change (cdb)

2016-05-29 Thread Ori.livneh (Code Review)

Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291581

Change subject: stop using wikimedia/assert
..

stop using wikimedia/assert

In XHProf profiles of Wikimedia edit requests, Wikimedia\Assert\Assert::hasType
has ranks somewhere between second and fourth place when sorting function calls
by exclusive CPU time. Replace it with a simple is_array() check and stop
verifying the type of each of the array's values.

Change-Id: I5a7a9f25912f4f1d8d2c274237999718bc8e68dd
---
M composer.json
M src/Reader/Hash.php
M tests/Reader/HashTest.php
3 files changed, 6 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/cdb refs/changes/81/291581/1

diff --git a/composer.json b/composer.json
index f6c7fb7..bf54635 100644
--- a/composer.json
+++ b/composer.json
@@ -26,8 +26,7 @@
]
},
"require": {
-   "php": ">=5.3.2",
-   "wikimedia/assert": "~0.2.2"
+   "php": ">=5.3.2"
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9",
diff --git a/src/Reader/Hash.php b/src/Reader/Hash.php
index 3010305..36bbc3b 100644
--- a/src/Reader/Hash.php
+++ b/src/Reader/Hash.php
@@ -52,9 +52,9 @@
 * @param string[] $data An associative PHP array.
 */
public function __construct( $data ) {
-   Assert::parameterType( 'array', $data, '$data' );
-   Assert::parameterElementType( 'string', $data, '$data' );
-
+   if ( !is_array( $data ) ) {
+   throw new \InvalidArgumentException( __METHOD__ . ': 
"$data" must be an array.' );
+   }
$this->data = $data;
}
 
diff --git a/tests/Reader/HashTest.php b/tests/Reader/HashTest.php
index bab34e7..70401fa 100644
--- a/tests/Reader/HashTest.php
+++ b/tests/Reader/HashTest.php
@@ -9,20 +9,9 @@
  */
 class HashTest extends \PHPUnit_Framework_TestCase {
 
-   public function provideConstructor_fail() {
-   return array(
-   array( 'Foo' ),
-   array( array( "x" => 1, "y" => 2 ) ),
-   );
-   }
-
-   /**
-* @dataProvider provideConstructor_fail
-*/
-   public function testConstructor_fail( $data ) {
+   public function testConstructor_fail() {
$this->setExpectedException( 'InvalidArgumentException' );
-
-   new Hash( $data );
+   new Hash( 'not an array' );
}
 
public function testClose() {

-- 
To view, visit https://gerrit.wikimedia.org/r/291581
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a7a9f25912f4f1d8d2c274237999718bc8e68dd
Gerrit-PatchSet: 1
Gerrit-Project: cdb
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [fix] fix docstring - change (pywikibot/core)

2016-05-29 Thread Xqt (Code Review)

Xqt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291580

Change subject: [fix] fix docstring
..

[fix] fix docstring

Bug: T136510
Change-Id: I11cae2c4edc816f331f1759e6896d17264abeeda
---
M scripts/delete.py
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/80/291580/1

diff --git a/scripts/delete.py b/scripts/delete.py
index 52a3bc7..4fbe618 100755
--- a/scripts/delete.py
+++ b/scripts/delete.py
@@ -31,12 +31,12 @@
 -orphansonly: Specified namespaces. Separate multiple namespace
   numbers or names with commas.
   Examples:
-  -ns:0,2,4
-  -ns:Help,MediaWiki
+  -orphansonly:0,2,4
+  -orphansonly:Help,MediaWiki
 
   Note that Main ns can be indicated either with a 0 or a ',':
-  -ns:0,1
-  -ns:,Talk
+  -orphansonly:0,1
+  -orphansonly:,Talk
 
 Usage:
 

-- 
To view, visit https://gerrit.wikimedia.org/r/291580
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I11cae2c4edc816f331f1759e6896d17264abeeda
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] tools: Fixup k8s bastion role - change (operations/puppet)

2016-05-29 Thread Yuvipanda (Code Review)

Yuvipanda has submitted this change and it was merged.

Change subject: tools: Fixup k8s bastion role
..


tools: Fixup k8s bastion role

- Adds a simple script to deploy appropriate binaries
- Adds flannel + kube-proxy for access to pod/svc ips
- Installs kubectl for use by everyone

Bug: T136413
Change-Id: I3b106fe670a1e4f6a0a23a978b50ed211e85f31b
---
D modules/k8s/manifests/client.pp
M modules/k8s/manifests/flannel.pp
M modules/k8s/manifests/proxy.pp
A modules/k8s/templates/initscripts/flannel.upstart.erb
A modules/k8s/templates/initscripts/kube-proxy.upstart.erb
A modules/role/files/toollabs/deploy-bastion.bash
M modules/role/manifests/toollabs/k8s/bastion.pp
7 files changed, 87 insertions(+), 8 deletions(-)

Approvals:
  Yuvipanda: Verified; Looks good to me, approved



diff --git a/modules/k8s/manifests/client.pp b/modules/k8s/manifests/client.pp
deleted file mode 100644
index ef4ff06..000
--- a/modules/k8s/manifests/client.pp
+++ /dev/null
@@ -1,6 +0,0 @@
-class k8s::client {
-
-include k8s::ssl
-
-require_package('kubectl')
-}
diff --git a/modules/k8s/manifests/flannel.pp b/modules/k8s/manifests/flannel.pp
index 1932940..42158a3 100644
--- a/modules/k8s/manifests/flannel.pp
+++ b/modules/k8s/manifests/flannel.pp
@@ -5,5 +5,6 @@
 
 base::service_unit { 'flannel':
 systemd => true,
+upstart => true,
 }
 }
diff --git a/modules/k8s/manifests/proxy.pp b/modules/k8s/manifests/proxy.pp
index 99ec7a6..d79566b 100644
--- a/modules/k8s/manifests/proxy.pp
+++ b/modules/k8s/manifests/proxy.pp
@@ -7,6 +7,7 @@
 
 base::service_unit { 'kube-proxy':
 systemd   => true,
+upstart   => true,
 subscribe => File['/etc/kubernetes/kubeconfig'],
 }
 }
diff --git a/modules/k8s/templates/initscripts/flannel.upstart.erb 
b/modules/k8s/templates/initscripts/flannel.upstart.erb
new file mode 100644
index 000..e7a5eca
--- /dev/null
+++ b/modules/k8s/templates/initscripts/flannel.upstart.erb
@@ -0,0 +1,13 @@
+description "flannel overlay network"
+
+start on started network-services
+
+setuid root
+setgid root
+
+exec /usr/bin/flanneld \
+--etcd-endpoints=<%= @etcd_endpoints %> \
+--etcd-cafile=/var/lib/puppet/ssl/certs/ca.pem \
+--ip-masq=true
+
+respawn
diff --git a/modules/k8s/templates/initscripts/kube-proxy.upstart.erb 
b/modules/k8s/templates/initscripts/kube-proxy.upstart.erb
new file mode 100644
index 000..4609577
--- /dev/null
+++ b/modules/k8s/templates/initscripts/kube-proxy.upstart.erb
@@ -0,0 +1,13 @@
+description "Kubernetes Proxy"
+
+start on started network-services
+
+setuid root
+setgid root
+
+exec /usr/local/bin/kube-proxy \
+--kubeconfig=/etc/kubernetes/kubeconfig \
+--proxy-mode=iptables \
+--masquerade-all=true
+
+respawn
diff --git a/modules/role/files/toollabs/deploy-bastion.bash 
b/modules/role/files/toollabs/deploy-bastion.bash
new file mode 100644
index 000..3543135
--- /dev/null
+++ b/modules/role/files/toollabs/deploy-bastion.bash
@@ -0,0 +1,32 @@
+#!/bin/bash
+# This script does the following:
+#
+# - Stop kube-proxy service
+# - Download new versions of kube-proxy & kubectl
+# - Installs kube-proxy & kubectl in appropriate place
+# - Start kube-proxy
+set -e
+
+# TODO: Add error checking (basssh)
+URL_PREFIX="$1"
+VERSION="$2"
+
+# Stop the running services!
+service kube-proxy stop
+
+# Download the new things!
+wget -O /usr/local/bin/kubectl $URL_PREFIX/$VERSION/kubectl
+wget -O /usr/local/bin/kube-proxy $URL_PREFIX/$VERSION/kube-proxy
+
+# Owned by root!
+chown root /usr/local/bin/kubectl
+chown root /usr/local/bin/kube-proxy
+
+# Make them executable root only
+chmod u+x /usr/local/bin/kube-proxy
+
+# Executable by all!
+chmod +x /usr/local/bin/kubectl
+
+# Start services again, and hope!
+service kube-proxy start
diff --git a/modules/role/manifests/toollabs/k8s/bastion.pp 
b/modules/role/manifests/toollabs/k8s/bastion.pp
index e084d3a..f35f635 100644
--- a/modules/role/manifests/toollabs/k8s/bastion.pp
+++ b/modules/role/manifests/toollabs/k8s/bastion.pp
@@ -1,5 +1,30 @@
 class role::toollabs::k8s::bastion {
 
-# kubectl and things
-include k8s::client
+$master_host = hiera('k8s::master_host')
+$etcd_url = join(prefix(suffix(hiera('flannel::etcd_hosts', 
[$master_host]), ':2379'), 'https://'), ',')
+
+ferm::service { 'flannel-vxlan':
+proto => udp,
+port  => 8472,
+}
+
+class { '::k8s::flannel':
+etcd_endpoints => $etcd_url,
+}
+
+class { '::k8s::ssl':
+notify  => Class['k8s::proxy'],
+}
+
+class { 'k8s::proxy':
+master_host => $master_host,
+}
+
+# Deployment script (for now!)
+file { '/usr/local/bin/deploy-bastion':
+source => 'puppet:///modules/role/toollabs/deploy-bastion.bash',
+mode   => '0555',
+owner  => 'root',
+group  => 'root',
+}
 }

-- 
To view, visit

69 matches

Mail list logo