[MediaWiki-commits] [Gerrit] Account for different font sizes when calculating max-width ... - change (mediawiki...erudite)

2014-02-03 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/110928

Change subject: Account for different font sizes when calculating max-width of 
hearer elements
..

Account for different font sizes when calculating max-width of hearer elements

Change-Id: I6f83b32f759315987dc3c581dc9f3307fa138354
---
M assets/erudite.css
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/28/110928/1

diff --git a/assets/erudite.css b/assets/erudite.css
index e788535..ca8e469 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -153,6 +153,8 @@
text-decoration: none;
font-size: 2.25em;
line-height: 1;
+   /* make max-width roughly the same as 80em at standard font size */
+   max-width: 36em;
 }
 
 #top-wrap a,
@@ -162,6 +164,8 @@
 
 #tagline {
font-size: 0.875em;
+   /* make max-width roughly the same as 80em at standard font size */
+   max-width: 92em;
 }
 
 /* Menu */

-- 
To view, visit https://gerrit.wikimedia.org/r/110928
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f83b32f759315987dc3c581dc9f3307fa138354
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Release v1.8 - change (mediawiki...erudite)

2014-01-29 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Release v1.8
..


Release v1.8

Change-Id: I2b459729dbecc0ef1a48a71990dff2dbb76b8633
---
M erudite.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Njw: Verified; Looks good to me, approved



diff --git a/erudite.php b/erudite.php
index 10adb44..96dcfc3 100644
--- a/erudite.php
+++ b/erudite.php
@@ -17,7 +17,7 @@
'name' => 'Erudite',
'url' => 'https://www.mediawiki.org/wiki/Skin:Erudite',
'author' => array( 'Nick White', 'Matt Wiebe', 'Colin Andrew Ferm' ),
-   'version' => '1.7',
+   'version' => '1.8',
'descriptionmsg' => 'erudite-desc',
 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/110169
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2b459729dbecc0ef1a48a71990dff2dbb76b8633
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Release v1.8 - change (mediawiki...erudite)

2014-01-29 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/110169

Change subject: Release v1.8
..

Release v1.8

Change-Id: I2b459729dbecc0ef1a48a71990dff2dbb76b8633
---
M erudite.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/69/110169/1

diff --git a/erudite.php b/erudite.php
index 10adb44..96dcfc3 100644
--- a/erudite.php
+++ b/erudite.php
@@ -17,7 +17,7 @@
'name' => 'Erudite',
'url' => 'https://www.mediawiki.org/wiki/Skin:Erudite',
'author' => array( 'Nick White', 'Matt Wiebe', 'Colin Andrew Ferm' ),
-   'version' => '1.7',
+   'version' => '1.8',
'descriptionmsg' => 'erudite-desc',
 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/110169
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b459729dbecc0ef1a48a71990dff2dbb76b8633
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Ensure page is valid XML - change (mediawiki...erudite)

2014-01-29 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Ensure page is valid XML
..


Ensure page is valid XML

Change-Id: I05b2ab2cb4bc6c2959e2665a4bbf758f1065cd06
---
M Erudite.skin.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Erudite.skin.php b/Erudite.skin.php
index 5068298..339bd54 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -18,7 +18,7 @@
 * desktop dimensions, so they won't downscale and will instead 
respect
 * things like CSS's @media rules */
$out->addHeadItem( 'viewport',
-   ''
+   ''
);
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/110152
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I05b2ab2cb4bc6c2959e2665a4bbf758f1065cd06
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Ensure page is valid XML - change (mediawiki...erudite)

2014-01-29 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/110152

Change subject: Ensure page is valid XML
..

Ensure page is valid XML

Change-Id: I05b2ab2cb4bc6c2959e2665a4bbf758f1065cd06
---
M Erudite.skin.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/52/110152/1

diff --git a/Erudite.skin.php b/Erudite.skin.php
index 5068298..339bd54 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -18,7 +18,7 @@
 * desktop dimensions, so they won't downscale and will instead 
respect
 * things like CSS's @media rules */
$out->addHeadItem( 'viewport',
-   ''
+   ''
);
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/110152
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I05b2ab2cb4bc6c2959e2665a4bbf758f1065cd06
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove table elements from cssreset so border acts as expected - change (mediawiki...erudite)

2013-12-16 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Remove table elements from cssreset so border acts as expected
..


Remove table elements from cssreset so border acts as expected

Change-Id: I99a9a5ce5e8a28e267377b8c748886e4142d280b
---
M assets/cssreset.css
1 file changed, 1 insertion(+), 13 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/assets/cssreset.css b/assets/cssreset.css
index 375938e..48ad0dc 100644
--- a/assets/cssreset.css
+++ b/assets/cssreset.css
@@ -47,14 +47,7 @@
 form,
 label,
 legend,
-table,
-caption,
-tbody,
-tfoot,
-thead,
-tr,
-th,
-td {
+caption {
margin: 0;
padding: 0;
border: 0;
@@ -62,9 +55,4 @@
font-size: 100%;
vertical-align: baseline;
background: transparent;
-}
-
-table {
-   border-collapse: collapse;
-   border-spacing: 0;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/101897
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I99a9a5ce5e8a28e267377b8c748886e4142d280b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove table elements from cssreset so border acts as expected - change (mediawiki...erudite)

2013-12-16 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/101897


Change subject: Remove table elements from cssreset so border acts as expected
..

Remove table elements from cssreset so border acts as expected

Change-Id: I99a9a5ce5e8a28e267377b8c748886e4142d280b
---
M assets/cssreset.css
1 file changed, 1 insertion(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/97/101897/1

diff --git a/assets/cssreset.css b/assets/cssreset.css
index 375938e..48ad0dc 100644
--- a/assets/cssreset.css
+++ b/assets/cssreset.css
@@ -47,14 +47,7 @@
 form,
 label,
 legend,
-table,
-caption,
-tbody,
-tfoot,
-thead,
-tr,
-th,
-td {
+caption {
margin: 0;
padding: 0;
border: 0;
@@ -62,9 +55,4 @@
font-size: 100%;
vertical-align: baseline;
background: transparent;
-}
-
-table {
-   border-collapse: collapse;
-   border-spacing: 0;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/101897
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I99a9a5ce5e8a28e267377b8c748886e4142d280b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Release v1.7 - change (mediawiki...erudite)

2013-12-12 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Release v1.7
..


Release v1.7

Change-Id: Id7280532f57d709b7e80be840986a8c7f00046f1
---
M erudite.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/erudite.php b/erudite.php
index a0255e4..10adb44 100644
--- a/erudite.php
+++ b/erudite.php
@@ -17,7 +17,7 @@
'name' => 'Erudite',
'url' => 'https://www.mediawiki.org/wiki/Skin:Erudite',
'author' => array( 'Nick White', 'Matt Wiebe', 'Colin Andrew Ferm' ),
-   'version' => '1.6',
+   'version' => '1.7',
'descriptionmsg' => 'erudite-desc',
 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/101007
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id7280532f57d709b7e80be840986a8c7f00046f1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Release v1.7 - change (mediawiki...erudite)

2013-12-12 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/101007


Change subject: Release v1.7
..

Release v1.7

Change-Id: Id7280532f57d709b7e80be840986a8c7f00046f1
---
M erudite.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/07/101007/1

diff --git a/erudite.php b/erudite.php
index a0255e4..10adb44 100644
--- a/erudite.php
+++ b/erudite.php
@@ -17,7 +17,7 @@
'name' => 'Erudite',
'url' => 'https://www.mediawiki.org/wiki/Skin:Erudite',
'author' => array( 'Nick White', 'Matt Wiebe', 'Colin Andrew Ferm' ),
-   'version' => '1.6',
+   'version' => '1.7',
'descriptionmsg' => 'erudite-desc',
 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/101007
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7280532f57d709b7e80be840986a8c7f00046f1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Ensure :visited is taken into account in footer, and remove ... - change (mediawiki...erudite)

2013-12-09 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Ensure :visited is taken into account in footer, and remove 
unneeded !important
..


Ensure :visited is taken into account in footer, and remove unneeded !important

Change-Id: If547b8e1b9f8bb985907d446f2646d16c2024d74
---
M assets/erudite.css
M assets/erudite55em.css
2 files changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/assets/erudite.css b/assets/erudite.css
index 3ba1be4..e788535 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -238,6 +238,7 @@
 }
 
 .footer a,
+.footer a:visited,
 .footer a.new {
color: #ff;
border-bottom: thin solid #99;
@@ -251,6 +252,7 @@
 }
 
 .footer li > a,
+.footer li > a:visited,
 .footer li > a.new {
border-color: #44;
 }
diff --git a/assets/erudite55em.css b/assets/erudite55em.css
index d1947d8..9141b28 100644
--- a/assets/erudite55em.css
+++ b/assets/erudite55em.css
@@ -31,7 +31,7 @@
 
 /* Stack top menu items */
 #menu:target li {
-   float: none !important;
+   float: none;
padding: 0em;
text-align: center;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/100406
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If547b8e1b9f8bb985907d446f2646d16c2024d74
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Ensure :visited is taken into account in footer, and remove ... - change (mediawiki...erudite)

2013-12-09 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/100406


Change subject: Ensure :visited is taken into account in footer, and remove 
unneeded !important
..

Ensure :visited is taken into account in footer, and remove unneeded !important

Change-Id: If547b8e1b9f8bb985907d446f2646d16c2024d74
---
M assets/erudite.css
M assets/erudite55em.css
2 files changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/06/100406/1

diff --git a/assets/erudite.css b/assets/erudite.css
index 3ba1be4..e788535 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -238,6 +238,7 @@
 }
 
 .footer a,
+.footer a:visited,
 .footer a.new {
color: #ff;
border-bottom: thin solid #99;
@@ -251,6 +252,7 @@
 }
 
 .footer li > a,
+.footer li > a:visited,
 .footer li > a.new {
border-color: #44;
 }
diff --git a/assets/erudite55em.css b/assets/erudite55em.css
index d1947d8..9141b28 100644
--- a/assets/erudite55em.css
+++ b/assets/erudite55em.css
@@ -31,7 +31,7 @@
 
 /* Stack top menu items */
 #menu:target li {
-   float: none !important;
+   float: none;
padding: 0em;
text-align: center;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/100406
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If547b8e1b9f8bb985907d446f2646d16c2024d74
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Back out of RTL part of previous commit; turns out it isn't ... - change (mediawiki...erudite)

2013-12-09 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Back out of RTL part of previous commit; turns out it isn't 
needed
..


Back out of RTL part of previous commit; turns out it isn't needed

The CSS reverses everything correctly anyway.

Change-Id: I743e6d6a5d63b123b633514c061959fe3fc39e2b
---
M Erudite.skin.php
1 file changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved



diff --git a/Erudite.skin.php b/Erudite.skin.php
index 0a6de4f..5068298 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -75,10 +75,6 @@
data['sidebar'] ) ) {
echo "\n";
-   /* Reverse horizontally rendered menu 
items if rtl */
-   if( $this->data['rtl'] ) {
-   array_reverse( 
$this->data['sidebar']['navigation'] );
-   }
foreach( 
$this->data['sidebar']['navigation'] as $item ) {
printf( '', Sanitizer::escapeId( $item['id'] ) );
printf( '%s', 
htmlspecialchars( $item['href'] ), htmlspecialchars( $item['text'] ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/100402
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I743e6d6a5d63b123b633514c061959fe3fc39e2b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Back out of RTL part of previous commit; turns out it isn't ... - change (mediawiki...erudite)

2013-12-09 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/100402


Change subject: Back out of RTL part of previous commit; turns out it isn't 
needed
..

Back out of RTL part of previous commit; turns out it isn't needed

The CSS reverses everything correctly anyway.

Change-Id: I743e6d6a5d63b123b633514c061959fe3fc39e2b
---
M Erudite.skin.php
1 file changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/02/100402/1

diff --git a/Erudite.skin.php b/Erudite.skin.php
index 0a6de4f..5068298 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -75,10 +75,6 @@
data['sidebar'] ) ) {
echo "\n";
-   /* Reverse horizontally rendered menu 
items if rtl */
-   if( $this->data['rtl'] ) {
-   array_reverse( 
$this->data['sidebar']['navigation'] );
-   }
foreach( 
$this->data['sidebar']['navigation'] as $item ) {
printf( '', Sanitizer::escapeId( $item['id'] ) );
printf( '%s', 
htmlspecialchars( $item['href'] ), htmlspecialchars( $item['text'] ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/100402
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I743e6d6a5d63b123b633514c061959fe3fc39e2b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Ensure all related padding is reduced together when screen i... - change (mediawiki...erudite)

2013-12-09 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Ensure all related padding is reduced together when screen is 
too small
..


Ensure all related padding is reduced together when screen is too small

Also ensure top menu button doesn't have a bottom border

Change-Id: I791f78d8d16d8cadeb94814a677dc13167e80d56
---
M assets/erudite.css
M assets/erudite40em.css
M assets/erudite60em.css
3 files changed, 29 insertions(+), 7 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved



diff --git a/assets/erudite.css b/assets/erudite.css
index 6e21412..3ba1be4 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -260,7 +260,8 @@
display: block;
clear: both;
text-align: right;
-   padding: 0.75em 3.75em;
+   padding-top: 0.75em;
+   padding-bottom: 0.75em;
font-size: 0.75em;
 }
 
@@ -269,8 +270,16 @@
 }
 
 /* Content */
+#bodyContent,
+.message *,
+#footer {
+   padding-left: 3.75em;
+   padding-right: 3.75em;
+}
+
 #bodyContent {
-   padding: 1.5em 3.75em;
+   padding-top: 1.5em;
+   padding-bottom: 1.5em;
 }
 
 hr {
@@ -360,6 +369,7 @@
 /* Links that are obvious from their design surroundings */
 #catlinks a,
 #footer a,
+a#menubutton,
 #menu a,
 #top-wrap h1 a,
 .gallery a,
@@ -579,8 +589,9 @@
border-width: thin;
 }
 
-.message p, .message div {
-   padding: 0 3.75em;
+.message * {
+   padding-top: 0;
+   padding-bottom: 0;
 }
 
 .message a:link,
diff --git a/assets/erudite40em.css b/assets/erudite40em.css
index 8e39b54..2fd3b83 100644
--- a/assets/erudite40em.css
+++ b/assets/erudite40em.css
@@ -1,6 +1,9 @@
 /* Reduce padding a bit further */
-#bodyContent {
-   padding: 1em 1em 0em;
+#bodyContent,
+.message *,
+#footer {
+   padding-left: 1em;
+   padding-right: 1em;
 }
 
 /* Stack footer columns */
diff --git a/assets/erudite60em.css b/assets/erudite60em.css
index b3a687b..41ec5ac 100644
--- a/assets/erudite60em.css
+++ b/assets/erudite60em.css
@@ -9,6 +9,14 @@
border: 0;
 }
 
+#bodyContent,
+.message *,
+#footer {
+   padding-left: 2em;
+   padding-right: 2em;
+}
+
 #bodyContent {
-   padding: 1em 2em 0em;
+   padding-top: 1em;
+   padding-bottom: 0em;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/100398
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I791f78d8d16d8cadeb94814a677dc13167e80d56
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Ensure all related padding is reduced together when screen i... - change (mediawiki...erudite)

2013-12-09 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/100398


Change subject: Ensure all related padding is reduced together when screen is 
too small
..

Ensure all related padding is reduced together when screen is too small

Also ensure top menu button doesn't have a bottom border

Change-Id: I791f78d8d16d8cadeb94814a677dc13167e80d56
---
M assets/erudite.css
M assets/erudite40em.css
M assets/erudite60em.css
3 files changed, 29 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/98/100398/1

diff --git a/assets/erudite.css b/assets/erudite.css
index 6e21412..3ba1be4 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -260,7 +260,8 @@
display: block;
clear: both;
text-align: right;
-   padding: 0.75em 3.75em;
+   padding-top: 0.75em;
+   padding-bottom: 0.75em;
font-size: 0.75em;
 }
 
@@ -269,8 +270,16 @@
 }
 
 /* Content */
+#bodyContent,
+.message *,
+#footer {
+   padding-left: 3.75em;
+   padding-right: 3.75em;
+}
+
 #bodyContent {
-   padding: 1.5em 3.75em;
+   padding-top: 1.5em;
+   padding-bottom: 1.5em;
 }
 
 hr {
@@ -360,6 +369,7 @@
 /* Links that are obvious from their design surroundings */
 #catlinks a,
 #footer a,
+a#menubutton,
 #menu a,
 #top-wrap h1 a,
 .gallery a,
@@ -579,8 +589,9 @@
border-width: thin;
 }
 
-.message p, .message div {
-   padding: 0 3.75em;
+.message * {
+   padding-top: 0;
+   padding-bottom: 0;
 }
 
 .message a:link,
diff --git a/assets/erudite40em.css b/assets/erudite40em.css
index 8e39b54..2fd3b83 100644
--- a/assets/erudite40em.css
+++ b/assets/erudite40em.css
@@ -1,6 +1,9 @@
 /* Reduce padding a bit further */
-#bodyContent {
-   padding: 1em 1em 0em;
+#bodyContent,
+.message *,
+#footer {
+   padding-left: 1em;
+   padding-right: 1em;
 }
 
 /* Stack footer columns */
diff --git a/assets/erudite60em.css b/assets/erudite60em.css
index b3a687b..41ec5ac 100644
--- a/assets/erudite60em.css
+++ b/assets/erudite60em.css
@@ -9,6 +9,14 @@
border: 0;
 }
 
+#bodyContent,
+.message *,
+#footer {
+   padding-left: 2em;
+   padding-right: 2em;
+}
+
 #bodyContent {
-   padding: 1em 2em 0em;
+   padding-top: 1em;
+   padding-bottom: 0em;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/100398
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I791f78d8d16d8cadeb94814a677dc13167e80d56
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Don't respect showjumplinks, remove unneeded sitename check, ... - change (mediawiki...erudite)

2013-12-09 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Don't respect showjumplinks, remove unneeded sitename check, 
improve rtl
..


Don't respect showjumplinks, remove unneeded sitename check, improve rtl

Reason for not respecting showjumplinks is same as 
https://gerrit.wikimedia.org/r/#/c/25751/
RTL improvement is reversing the horizontal top menu when in rtl mode

Change-Id: Ifd8981172a6e7752b3ca3b5f3c761aec66c71530
---
M Erudite.skin.php
1 file changed, 5 insertions(+), 8 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Erudite.skin.php b/Erudite.skin.php
index 75c5c8a..0a6de4f 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -59,19 +59,12 @@
public function execute() {
$this->html( 'headelement' );
 
-   if ( !isset( $this->data['sitename'] ) ) {
-   global $wgSitename;
-   $this->set( 'sitename', $wgSitename );
-   }
-
?>
 
-   data['showjumplinks'] ) { ?>

msg( 
'erudite-skiptocontent' ) ?>msg( 'comma-separator' ) ?>
msg( 
'erudite-skiptosearch' ) ?>

-   
 

text( 'sitename' ); ?>
@@ -82,6 +75,10 @@
data['sidebar'] ) ) {
echo "\n";
+   /* Reverse horizontally rendered menu 
items if rtl */
+   if( $this->data['rtl'] ) {
+   array_reverse( 
$this->data['sidebar']['navigation'] );
+   }
foreach( 
$this->data['sidebar']['navigation'] as $item ) {
printf( '', Sanitizer::escapeId( $item['id'] ) );
printf( '%s', 
htmlspecialchars( $item['href'] ), htmlspecialchars( $item['text'] ) );
@@ -264,7 +261,7 @@
 


-   
+   
 



-- 
To view, visit https://gerrit.wikimedia.org/r/100396
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd8981172a6e7752b3ca3b5f3c761aec66c71530
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Don't respect showjumplinks, remove unneeded sitename check, ... - change (mediawiki...erudite)

2013-12-09 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/100396


Change subject: Don't respect showjumplinks, remove unneeded sitename check, 
improve rtl
..

Don't respect showjumplinks, remove unneeded sitename check, improve rtl

Reason for not respecting showjumplinks is same as 
https://gerrit.wikimedia.org/r/#/c/25751/
RTL improvement is reversing the horizontal top menu when in rtl mode

Change-Id: Ifd8981172a6e7752b3ca3b5f3c761aec66c71530
---
M Erudite.skin.php
1 file changed, 5 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/96/100396/1

diff --git a/Erudite.skin.php b/Erudite.skin.php
index 75c5c8a..0a6de4f 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -59,19 +59,12 @@
public function execute() {
$this->html( 'headelement' );
 
-   if ( !isset( $this->data['sitename'] ) ) {
-   global $wgSitename;
-   $this->set( 'sitename', $wgSitename );
-   }
-
?>
 
-   data['showjumplinks'] ) { ?>

msg( 
'erudite-skiptocontent' ) ?>msg( 'comma-separator' ) ?>
msg( 
'erudite-skiptosearch' ) ?>

-   
 

text( 'sitename' ); ?>
@@ -82,6 +75,10 @@
data['sidebar'] ) ) {
echo "\n";
+   /* Reverse horizontally rendered menu 
items if rtl */
+   if( $this->data['rtl'] ) {
+   array_reverse( 
$this->data['sidebar']['navigation'] );
+   }
foreach( 
$this->data['sidebar']['navigation'] as $item ) {
printf( '', Sanitizer::escapeId( $item['id'] ) );
printf( '%s', 
htmlspecialchars( $item['href'] ), htmlspecialchars( $item['text'] ) );
@@ -264,7 +261,7 @@
 


-   
+   
 



-- 
To view, visit https://gerrit.wikimedia.org/r/100396
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd8981172a6e7752b3ca3b5f3c761aec66c71530
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Make underlining of links clearer, and make declarations mor... - change (mediawiki...erudite)

2013-12-09 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Make underlining of links clearer, and make declarations more 
sensible
..


Make underlining of links clearer, and make declarations more sensible

Stops using #bodyContent to identify basic elements in the content when
not necessary, as it'll be prioritised over other user CSS that doesn't
explicitly include #bodyContent.

Change-Id: I5707cc73da2acdc7c0efd86df966490008fa0de9
---
M assets/erudite.css
1 file changed, 25 insertions(+), 27 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/assets/erudite.css b/assets/erudite.css
index 7e500f9..6e21412 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -140,20 +140,6 @@
margin-top: 0;
 }
 
-/* Links */
-a {
-   text-decoration: none;
-   color: #bb;
-}
-
-a:visited {
-   color: #330077;
-}
-
-a.new {
-   color: #cc;
-}
-
 /* Header */
 #top-wrap {
background-image: url(images/stripes.svg);
@@ -351,14 +337,34 @@
margin-right: auto;
 }
 
-/* Main Links */
-#bodyContent a {
+/* Links */
+a {
+   color: #bb;
+   text-decoration: none;
border-bottom: thin solid #aa;
 }
 
-#bodyContent a:hover,
-#bodyContent a:focus {
+a:hover,
+a:focus {
border-color: #55;
+}
+
+a:visited {
+   color: #330077;
+}
+
+a.new {
+   color: #cc;
+}
+
+/* Links that are obvious from their design surroundings */
+#catlinks a,
+#footer a,
+#menu a,
+#top-wrap h1 a,
+.gallery a,
+.thumbinner > a {
+   border-bottom: none;
 }
 
 /* Meta (edit links etc.) */
@@ -431,13 +437,9 @@
 }
 
 /* Images */
-#bodyContent img {
+img {
padding: 0.25em;
margin-bottom: 0.5em;
-}
-
-#bodyContent .gallery a {
-   border-width: 0;
 }
 
 div.floatright,
@@ -482,10 +484,6 @@
border: none;
padding: 0;
margin: 0;
-}
-
-.thumbinner > a {
-   border: none;
 }
 
 .thumbcaption {

-- 
To view, visit https://gerrit.wikimedia.org/r/100386
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5707cc73da2acdc7c0efd86df966490008fa0de9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Make underlining of links clearer, and make declarations mor... - change (mediawiki...erudite)

2013-12-09 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/100386


Change subject: Make underlining of links clearer, and make declarations more 
sensible
..

Make underlining of links clearer, and make declarations more sensible

Stops using #bodyContent to identify basic elements in the content when
not necessary, as it'll be prioritised over other user CSS that doesn't
explicitly include #bodyContent.

Change-Id: I5707cc73da2acdc7c0efd86df966490008fa0de9
---
M assets/erudite.css
1 file changed, 25 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/86/100386/1

diff --git a/assets/erudite.css b/assets/erudite.css
index 7e500f9..6e21412 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -140,20 +140,6 @@
margin-top: 0;
 }
 
-/* Links */
-a {
-   text-decoration: none;
-   color: #bb;
-}
-
-a:visited {
-   color: #330077;
-}
-
-a.new {
-   color: #cc;
-}
-
 /* Header */
 #top-wrap {
background-image: url(images/stripes.svg);
@@ -351,14 +337,34 @@
margin-right: auto;
 }
 
-/* Main Links */
-#bodyContent a {
+/* Links */
+a {
+   color: #bb;
+   text-decoration: none;
border-bottom: thin solid #aa;
 }
 
-#bodyContent a:hover,
-#bodyContent a:focus {
+a:hover,
+a:focus {
border-color: #55;
+}
+
+a:visited {
+   color: #330077;
+}
+
+a.new {
+   color: #cc;
+}
+
+/* Links that are obvious from their design surroundings */
+#catlinks a,
+#footer a,
+#menu a,
+#top-wrap h1 a,
+.gallery a,
+.thumbinner > a {
+   border-bottom: none;
 }
 
 /* Meta (edit links etc.) */
@@ -431,13 +437,9 @@
 }
 
 /* Images */
-#bodyContent img {
+img {
padding: 0.25em;
margin-bottom: 0.5em;
-}
-
-#bodyContent .gallery a {
-   border-width: 0;
 }
 
 div.floatright,
@@ -482,10 +484,6 @@
border: none;
padding: 0;
margin: 0;
-}
-
-.thumbinner > a {
-   border: none;
 }
 
 .thumbcaption {

-- 
To view, visit https://gerrit.wikimedia.org/r/100386
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5707cc73da2acdc7c0efd86df966490008fa0de9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Simplify and rename the HTML & CSS - change (mediawiki...erudite)

2013-12-09 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Simplify and rename the HTML & CSS
..


Simplify and rename the HTML & CSS

Change-Id: I829b7e5acdb058253b1a0a683ab09f0a7f30ee90
---
M Erudite.skin.php
M assets/erudite.css
M assets/erudite20em.css
M assets/erudite40em.css
M assets/erudite55em.css
M assets/erudite60em.css
M assets/print.css
7 files changed, 63 insertions(+), 97 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Erudite.skin.php b/Erudite.skin.php
index 718fd8c..75c5c8a 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -68,36 +68,30 @@
 
data['showjumplinks'] ) { ?>

-   msg( 
'erudite-skiptocontent' ) ?>msg( 'comma-separator' ) ?>
+   msg( 
'erudite-skiptocontent' ) ?>msg( 'comma-separator' ) ?>
msg( 
'erudite-skiptosearch' ) ?>


-   
 
-   
-   
-
-   
-   text( 
'sitename' ); ?>
+   
+   text( 'sitename' ); ?>
msg( 'tagline' ) ?>
-   
 
-   Menu
-   
+   Menu
+   
data['sidebar'] ) ) {
-   echo "\n";
+   echo "\n";
foreach( 
$this->data['sidebar']['navigation'] as $item ) {
-   printf( '', Sanitizer::escapeId( $item['id'] ) );
+   printf( '', Sanitizer::escapeId( $item['id'] ) );
printf( '%s', 
htmlspecialchars( $item['href'] ), htmlspecialchars( $item['text'] ) );
echo "\n";
}
-   echo "\n";
+   echo "\n";
}
?>
+   

-   
-   
 


 
-   
-   
-   
-   
-   html( 
'title' ); ?>
+   
+   
+   data['content_actions'] as 
$key => $tab ) {
+   echo $this->makeListItem( $key, $tab, 
array( 'tag' => 'span' ) );
+   echo '|';
+   }
+   ?>
+   
+
+   
+   html( 'title' ); ?>
data['subtitle'] ) { ?>
html( 'subtitle' ) ?>

 
-   
-   data['content_actions'] as $key => $tab ) {
-   echo $this->makeListItem( $key, 
$tab, array( 'tag' => 'span' ) );
-   echo '|';
-   }
-   ?>
-   
-
-   
-
html( 'bodytext' ) ?>
html( 'dataAfterContent' ); ?>
-
-   

 

@@ -159,13 +147,9 @@

 
html( 'catlinks' ); ?>
-

-   
-   
 
-   
-   
+   

 

@@ -284,10 +268,9 @@
 


-   
 
-   
printTrail(); ?>
+


 h1 {
color: #55;
margin: 0 0 0.5em;
 }
@@ -364,35 +352,35 @@
 }
 
 /* Main Links */
-.entry-content a {
+#bodyContent a {
border-bottom: thin solid #aa;
 }
 
-.entry-content a:hover,
-.entry-content a:focus {
+#bodyContent a:hover,
+#bodyContent a:focus {
border-color: #55;
 }
 
 /* Meta (edit links etc.) */
-.entry-meta {
+#nav-meta {
float: right;
+   margin: 1.5em 3.75em 0 1em;
padding-left: 1em;
-   margin-left: 1em;
border-left: thin solid #aa;
 }
 
-.entry-meta span {
+#nav-meta span {
display: block;
font-size: 0.75em;
font-style: italic;
padding: 0.4em 0;
 }
 
-.entry-meta .meta-sep {
+#nav-meta .meta-sep {
display: none;
 }
 
-#content .printfooter {
+.printfooter {
display: none;
 }
 
@@ -443,12 +431,12 @@
 }
 
 /* Images */
-.entry-content img {
+#bodyConte

[MediaWiki-commits] [Gerrit] Simplify and rename the HTML & CSS - change (mediawiki...erudite)

2013-12-05 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/99436


Change subject: Simplify and rename the HTML & CSS
..

Simplify and rename the HTML & CSS

Change-Id: I829b7e5acdb058253b1a0a683ab09f0a7f30ee90
---
M Erudite.skin.php
M assets/erudite.css
M assets/erudite20em.css
M assets/erudite40em.css
M assets/erudite55em.css
M assets/erudite60em.css
M assets/print.css
7 files changed, 63 insertions(+), 97 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/36/99436/1

diff --git a/Erudite.skin.php b/Erudite.skin.php
index 718fd8c..75c5c8a 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -68,36 +68,30 @@
 
data['showjumplinks'] ) { ?>

-   msg( 
'erudite-skiptocontent' ) ?>msg( 'comma-separator' ) ?>
+   msg( 
'erudite-skiptocontent' ) ?>msg( 'comma-separator' ) ?>
msg( 
'erudite-skiptosearch' ) ?>


-   
 
-   
-   
-
-   
-   text( 
'sitename' ); ?>
+   
+   text( 'sitename' ); ?>
msg( 'tagline' ) ?>
-   
 
-   Menu
-   
+   Menu
+   
data['sidebar'] ) ) {
-   echo "\n";
+   echo "\n";
foreach( 
$this->data['sidebar']['navigation'] as $item ) {
-   printf( '', Sanitizer::escapeId( $item['id'] ) );
+   printf( '', Sanitizer::escapeId( $item['id'] ) );
printf( '%s', 
htmlspecialchars( $item['href'] ), htmlspecialchars( $item['text'] ) );
echo "\n";
}
-   echo "\n";
+   echo "\n";
}
?>
+   

-   
-   
 


 
-   
-   
-   
-   
-   html( 
'title' ); ?>
+   
+   
+   data['content_actions'] as 
$key => $tab ) {
+   echo $this->makeListItem( $key, $tab, 
array( 'tag' => 'span' ) );
+   echo '|';
+   }
+   ?>
+   
+
+   
+   html( 'title' ); ?>
data['subtitle'] ) { ?>
html( 'subtitle' ) ?>

 
-   
-   data['content_actions'] as $key => $tab ) {
-   echo $this->makeListItem( $key, 
$tab, array( 'tag' => 'span' ) );
-   echo '|';
-   }
-   ?>
-   
-
-   
-
html( 'bodytext' ) ?>
html( 'dataAfterContent' ); ?>
-
-   

 

@@ -159,13 +147,9 @@

 
html( 'catlinks' ); ?>
-

-   
-   
 
-   
-   
+   

 

@@ -284,10 +268,9 @@
 


-   
 
-   
printTrail(); ?>
+


 h1 {
color: #55;
margin: 0 0 0.5em;
 }
@@ -364,35 +352,35 @@
 }
 
 /* Main Links */
-.entry-content a {
+#bodyContent a {
border-bottom: thin solid #aa;
 }
 
-.entry-content a:hover,
-.entry-content a:focus {
+#bodyContent a:hover,
+#bodyContent a:focus {
border-color: #55;
 }
 
 /* Meta (edit links etc.) */
-.entry-meta {
+#nav-meta {
float: right;
+   margin: 1.5em 3.75em 0 1em;
padding-left: 1em;
-   margin-left: 1em;
border-left: thin solid #aa;
 }
 
-.entry-meta span {
+#nav-meta span {
display: block;
font-size: 0.75em;
font-style: italic;
padding: 0.4em 0;
 }
 
-.entry-meta .meta-sep {
+#nav-meta .meta-sep {
display: none;
 }
 
-#content .printfooter {
+.printfooter {
display: none;
 }
 
@@ -443,12 +431,12 @@
 }

[MediaWiki-commits] [Gerrit] Check that navigation section exists before using it for top... - change (mediawiki...erudite)

2013-12-02 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Check that navigation section exists before using it for top 
menu
..


Check that navigation section exists before using it for top menu

This is needed as it can be removed from Mediawiki:Sidebar (or from
various extensions).

Change-Id: I34c4264ae3dae2e712fce4a153e153451f460342
---
M Erudite.skin.php
1 file changed, 8 insertions(+), 8 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Erudite.skin.php b/Erudite.skin.php
index d872421..718fd8c 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -84,17 +84,17 @@
 
Menu

-   
-   
data['sidebar']['navigation'] 
as $item ) {
-   printf( '', Sanitizer::escapeId( $item['id'] ) );
-   printf( '%s', 
htmlspecialchars( $item['href'] ), htmlspecialchars( $item['text'] ) );
-   echo "\n";
+   if( array_key_exists( 'navigation', 
$this->data['sidebar'] ) ) {
+   echo "\n";
+   foreach( 
$this->data['sidebar']['navigation'] as $item ) {
+   printf( '', Sanitizer::escapeId( $item['id'] ) );
+   printf( '%s', 
htmlspecialchars( $item['href'] ), htmlspecialchars( $item['text'] ) );
+   echo "\n";
+   }
+   echo "\n";
}
?>
-   
-   




-- 
To view, visit https://gerrit.wikimedia.org/r/98603
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I34c4264ae3dae2e712fce4a153e153451f460342
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Check that navigation section exists before using it for top... - change (mediawiki...erudite)

2013-12-02 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/98603


Change subject: Check that navigation section exists before using it for top 
menu
..

Check that navigation section exists before using it for top menu

This is needed as it can be removed from Mediawiki:Sidebar (or from
various extensions).

Change-Id: I34c4264ae3dae2e712fce4a153e153451f460342
---
M Erudite.skin.php
1 file changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/03/98603/1

diff --git a/Erudite.skin.php b/Erudite.skin.php
index d872421..718fd8c 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -84,17 +84,17 @@
 
Menu

-   
-   
data['sidebar']['navigation'] 
as $item ) {
-   printf( '', Sanitizer::escapeId( $item['id'] ) );
-   printf( '%s', 
htmlspecialchars( $item['href'] ), htmlspecialchars( $item['text'] ) );
-   echo "\n";
+   if( array_key_exists( 'navigation', 
$this->data['sidebar'] ) ) {
+   echo "\n";
+   foreach( 
$this->data['sidebar']['navigation'] as $item ) {
+   printf( '', Sanitizer::escapeId( $item['id'] ) );
+   printf( '%s', 
htmlspecialchars( $item['href'] ), htmlspecialchars( $item['text'] ) );
+   echo "\n";
+   }
+   echo "\n";
}
?>
-   
-   




-- 
To view, visit https://gerrit.wikimedia.org/r/98603
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I34c4264ae3dae2e712fce4a153e153451f460342
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add any extra menus added to sidebar to middle column - change (mediawiki...erudite)

2013-12-02 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Add any extra menus added to sidebar to middle column
..


Add any extra menus added to sidebar to middle column

Change-Id: I50991302a79def85fb373747fbcf084a70b09b14
---
M Erudite.skin.php
1 file changed, 27 insertions(+), 3 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Erudite.skin.php b/Erudite.skin.php
index 165fea8..d872421 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -87,9 +87,9 @@


data['sidebar']['navigation'] 
as $key => $val ) {
-   printf( '', Sanitizer::escapeId( $val['id'] ) );
-   printf( '%s', 
htmlspecialchars( $val['href'] ), htmlspecialchars( $val['text'] ) );
+   foreach( $this->data['sidebar']['navigation'] 
as $item ) {
+   printf( '', Sanitizer::escapeId( $item['id'] ) );
+   printf( '%s', 
htmlspecialchars( $item['href'] ), htmlspecialchars( $item['text'] ) );
echo "\n";
}
?>
@@ -236,6 +236,30 @@


 
+   data['sidebar'] as $name => 
$menu ) {
+   /* standard menus are already handled 
elsewhere */
+   if( empty($menu) ||
+   $name == 'navigation' ||
+   $name == 'SEARCH' ||
+   $name == 'LANGUAGES' ||
+   $name == 'TOOLBOX' ) {
+   continue;
+   }
+   echo "";
+   $msgObj = wfMessage( $name );
+   $heading = $msgObj->exists() ? 
$msgObj->text() : $name;
+   printf( '%s', 
htmlspecialchars( $heading ) );
+   echo "\n";
+   foreach( $menu as $item ) {
+   printf( '%s' . "\n",
+   htmlspecialchars( 
$item['href'] ),
+   htmlspecialchars( 
$item['text'] ) );
+   }
+   echo "\n";
+   }
+   ?>
+

msgWikiNoEdit( 
'erudite-extracontent-column2' ); ?>


-- 
To view, visit https://gerrit.wikimedia.org/r/98514
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I50991302a79def85fb373747fbcf084a70b09b14
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add any extra menus added to sidebar to middle column - change (mediawiki...erudite)

2013-12-02 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/98514


Change subject: Add any extra menus added to sidebar to middle column
..

Add any extra menus added to sidebar to middle column

Change-Id: I50991302a79def85fb373747fbcf084a70b09b14
---
M Erudite.skin.php
1 file changed, 22 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/14/98514/1

diff --git a/Erudite.skin.php b/Erudite.skin.php
index 165fea8..3cf878b 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -87,9 +87,9 @@


data['sidebar']['navigation'] 
as $key => $val ) {
-   printf( '', Sanitizer::escapeId( $val['id'] ) );
-   printf( '%s', 
htmlspecialchars( $val['href'] ), htmlspecialchars( $val['text'] ) );
+   foreach( $this->data['sidebar']['navigation'] 
as $item ) {
+   printf( '', Sanitizer::escapeId( $item['id'] ) );
+   printf( '%s', 
htmlspecialchars( $item['href'] ), htmlspecialchars( $item['text'] ) );
echo "\n";
}
?>
@@ -236,6 +236,25 @@


 
+   data['sidebar'] as $name => 
$menu ) {
+   /* navigation is already handled by top 
menu */
+   if($name == 'navigation' || 
empty($menu) ) {
+   continue;
+   }
+   echo "";
+   printf( '%s', $name );
+   echo "\n";
+   foreach( $menu as $item ) {
+   printf( '%s' . "\n", 
+   htmlspecialchars( 
$item['href'] ),
+   htmlspecialchars( 
$item['text'] )
+   );
+   }
+   echo "\n";
+   }
+   ?>
+

msgWikiNoEdit( 
'erudite-extracontent-column2' ); ?>


-- 
To view, visit https://gerrit.wikimedia.org/r/98514
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I50991302a79def85fb373747fbcf084a70b09b14
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Ensure no borders causing horizontal scrollbars with narrow ... - change (mediawiki...erudite)

2013-11-25 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Ensure no borders causing horizontal scrollbars with narrow 
screens
..


Ensure no borders causing horizontal scrollbars with narrow screens

Change-Id: If55effb1e138783c276e44751ce913c12efef509
---
M assets/erudite60em.css
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved



diff --git a/assets/erudite60em.css b/assets/erudite60em.css
index 61d8245..bcb08c7 100644
--- a/assets/erudite60em.css
+++ b/assets/erudite60em.css
@@ -5,6 +5,7 @@
 #footer-wrap-inner,
 .message {
width: 100%;
+   border: 0;
 }
 
 #content {

-- 
To view, visit https://gerrit.wikimedia.org/r/97502
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If55effb1e138783c276e44751ce913c12efef509
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Ensure no borders causing horizontal scrollbars with narrow ... - change (mediawiki...erudite)

2013-11-25 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/97502


Change subject: Ensure no borders causing horizontal scrollbars with narrow 
screens
..

Ensure no borders causing horizontal scrollbars with narrow screens

Change-Id: If55effb1e138783c276e44751ce913c12efef509
---
M assets/erudite60em.css
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/02/97502/1

diff --git a/assets/erudite60em.css b/assets/erudite60em.css
index 61d8245..bcb08c7 100644
--- a/assets/erudite60em.css
+++ b/assets/erudite60em.css
@@ -5,6 +5,7 @@
 #footer-wrap-inner,
 .message {
width: 100%;
+   border: 0;
 }
 
 #content {

-- 
To view, visit https://gerrit.wikimedia.org/r/97502
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If55effb1e138783c276e44751ce913c12efef509
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Have messages line up with the rest of the content - change (mediawiki...erudite)

2013-11-21 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Have messages line up with the rest of the content
..


Have messages line up with the rest of the content

Change-Id: I42c027b9911b5e91c93e406ad6ad1beb211cdb84
---
M assets/erudite.css
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/assets/erudite.css b/assets/erudite.css
index 612769d..4d9aca0 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -590,7 +590,7 @@
 }
 
 .message p, .message div {
-   padding: 0 1em;
+   padding: 0 3.75em;
 }
 
 .message a:link,

-- 
To view, visit https://gerrit.wikimedia.org/r/96772
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I42c027b9911b5e91c93e406ad6ad1beb211cdb84
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Make menu entries narrower and add line separator - change (mediawiki...erudite)

2013-11-21 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Make menu entries narrower and add line separator
..


Make menu entries narrower and add line separator

Change-Id: I6a34b942874b0815b8fdf54d16357b184139bc03
---
M assets/erudite.css
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Njw: Verified; Looks good to me, approved



diff --git a/assets/erudite.css b/assets/erudite.css
index 612769d..d1bfcdf 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -214,7 +214,13 @@
 #menu li {
display: block;
float: left;
-   margin: 0em 2em 0em 0em;
+   margin: 0em 0.6em 0em 0em;
+   padding-right: 0.6em;
+   border-right: thin solid #66;
+}
+
+#menu li:last-child {
+   border-right: none;
 }
 
 /* Footer */

-- 
To view, visit https://gerrit.wikimedia.org/r/96774
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6a34b942874b0815b8fdf54d16357b184139bc03
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Make menu entries narrower and add line separator - change (mediawiki...erudite)

2013-11-21 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/96774


Change subject: Make menu entries narrower and add line separator
..

Make menu entries narrower and add line separator

Change-Id: I6a34b942874b0815b8fdf54d16357b184139bc03
---
M assets/erudite.css
1 file changed, 7 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/74/96774/1

diff --git a/assets/erudite.css b/assets/erudite.css
index 612769d..d1bfcdf 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -214,7 +214,13 @@
 #menu li {
display: block;
float: left;
-   margin: 0em 2em 0em 0em;
+   margin: 0em 0.6em 0em 0em;
+   padding-right: 0.6em;
+   border-right: thin solid #66;
+}
+
+#menu li:last-child {
+   border-right: none;
 }
 
 /* Footer */

-- 
To view, visit https://gerrit.wikimedia.org/r/96774
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a34b942874b0815b8fdf54d16357b184139bc03
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Have messages line up with the rest of the content - change (mediawiki...erudite)

2013-11-21 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/96772


Change subject: Have messages line up with the rest of the content
..

Have messages line up with the rest of the content

Change-Id: I42c027b9911b5e91c93e406ad6ad1beb211cdb84
---
M assets/erudite.css
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/72/96772/1

diff --git a/assets/erudite.css b/assets/erudite.css
index 612769d..4d9aca0 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -590,7 +590,7 @@
 }
 
 .message p, .message div {
-   padding: 0 1em;
+   padding: 0 3.75em;
 }
 
 .message a:link,

-- 
To view, visit https://gerrit.wikimedia.org/r/96772
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I42c027b9911b5e91c93e406ad6ad1beb211cdb84
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Release v1.6 - change (mediawiki...erudite)

2013-11-20 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Release v1.6
..


Release v1.6

Change-Id: I28ef44cc78c11a798f07ebb70b59de57dabf27f8
---
M erudite.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/erudite.php b/erudite.php
index f92e0b9..a0255e4 100644
--- a/erudite.php
+++ b/erudite.php
@@ -17,7 +17,7 @@
'name' => 'Erudite',
'url' => 'https://www.mediawiki.org/wiki/Skin:Erudite',
'author' => array( 'Nick White', 'Matt Wiebe', 'Colin Andrew Ferm' ),
-   'version' => '1.5',
+   'version' => '1.6',
'descriptionmsg' => 'erudite-desc',
 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/96273
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I28ef44cc78c11a798f07ebb70b59de57dabf27f8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove sub and sup from css reset - change (mediawiki...erudite)

2013-11-19 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Remove sub and sup from css reset
..


Remove sub and sup from css reset

This was done as they have consistent (and reasonable) behaviour
over all the major browsers, and the font-size:100% rule was
causing them to appear too large.

Change-Id: I30001b385879ff4c523dfb48043c790e8463a9f3
---
M assets/cssreset.css
1 file changed, 0 insertions(+), 10 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/assets/cssreset.css b/assets/cssreset.css
index a2994b2..375938e 100644
--- a/assets/cssreset.css
+++ b/assets/cssreset.css
@@ -32,8 +32,6 @@
 small,
 strike,
 strong,
-sub,
-sup,
 tt,
 b,
 u,
@@ -69,12 +67,4 @@
 table {
border-collapse: collapse;
border-spacing: 0;
-}
-
-sup {
-   vertical-align: super;
-}
-
-sub {
-   vertical-align: sub;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/96277
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I30001b385879ff4c523dfb48043c790e8463a9f3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Use solid background-color for menu if stacked - change (mediawiki...erudite)

2013-11-19 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Use solid background-color for menu if stacked
..


Use solid background-color for menu if stacked

This is to ensure there is no unexpected tiling of any banner
background-images

Change-Id: I66a9dacf9d70956acc75ee6fd9f59353d424782b
---
M assets/erudite55em.css
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/assets/erudite55em.css b/assets/erudite55em.css
index ce2560f..a182d08 100644
--- a/assets/erudite55em.css
+++ b/assets/erudite55em.css
@@ -6,7 +6,7 @@
top: 0.75em;
padding: 0.25em 0.5em;
background-color: #33;
-background-color: rgba(50, 50, 50, 0.7);
+   background-color: rgba(50, 50, 50, 0.7);
color: white;
font-family: 'Linux Biolinum', corbel, 'gill sans', 'gill sans mt', 
sans-serif;
font-size: large;
@@ -18,13 +18,15 @@
margin-right: 2em;
 }
 
-/* Hide menu unless it's the target */
+/* Hide menu unless it's the target, and set its background-color
+ * solid to avoid unexpected banner image tiling */
 #menu {
display: none;
 }
 
 #menu:target {
display: block;
+   background-color: #33;
 }
 
 /* Stack top menu items */

-- 
To view, visit https://gerrit.wikimedia.org/r/96280
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I66a9dacf9d70956acc75ee6fd9f59353d424782b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Use solid background-color for menu if stacked - change (mediawiki...erudite)

2013-11-19 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/96280


Change subject: Use solid background-color for menu if stacked
..

Use solid background-color for menu if stacked

This is to ensure there is no unexpected tiling of any banner
background-images

Change-Id: I66a9dacf9d70956acc75ee6fd9f59353d424782b
---
M assets/erudite55em.css
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/80/96280/1

diff --git a/assets/erudite55em.css b/assets/erudite55em.css
index ce2560f..a182d08 100644
--- a/assets/erudite55em.css
+++ b/assets/erudite55em.css
@@ -6,7 +6,7 @@
top: 0.75em;
padding: 0.25em 0.5em;
background-color: #33;
-background-color: rgba(50, 50, 50, 0.7);
+   background-color: rgba(50, 50, 50, 0.7);
color: white;
font-family: 'Linux Biolinum', corbel, 'gill sans', 'gill sans mt', 
sans-serif;
font-size: large;
@@ -18,13 +18,15 @@
margin-right: 2em;
 }
 
-/* Hide menu unless it's the target */
+/* Hide menu unless it's the target, and set its background-color
+ * solid to avoid unexpected banner image tiling */
 #menu {
display: none;
 }
 
 #menu:target {
display: block;
+   background-color: #33;
 }
 
 /* Stack top menu items */

-- 
To view, visit https://gerrit.wikimedia.org/r/96280
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I66a9dacf9d70956acc75ee6fd9f59353d424782b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove sub and sup from css reset - change (mediawiki...erudite)

2013-11-19 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/96277


Change subject: Remove sub and sup from css reset
..

Remove sub and sup from css reset

This was done as they have consistent (and reasonable) behaviour
over all the major browsers, and the font-size:100% rule was
causing them to appear too large.

Change-Id: I30001b385879ff4c523dfb48043c790e8463a9f3
---
M assets/cssreset.css
1 file changed, 0 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/77/96277/1

diff --git a/assets/cssreset.css b/assets/cssreset.css
index a2994b2..375938e 100644
--- a/assets/cssreset.css
+++ b/assets/cssreset.css
@@ -32,8 +32,6 @@
 small,
 strike,
 strong,
-sub,
-sup,
 tt,
 b,
 u,
@@ -69,12 +67,4 @@
 table {
border-collapse: collapse;
border-spacing: 0;
-}
-
-sup {
-   vertical-align: super;
-}
-
-sub {
-   vertical-align: sub;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/96277
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I30001b385879ff4c523dfb48043c790e8463a9f3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Release v1.6 - change (mediawiki...erudite)

2013-11-19 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/96273


Change subject: Release v1.6
..

Release v1.6

Change-Id: I28ef44cc78c11a798f07ebb70b59de57dabf27f8
---
M erudite.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/73/96273/1

diff --git a/erudite.php b/erudite.php
index f92e0b9..a0255e4 100644
--- a/erudite.php
+++ b/erudite.php
@@ -17,7 +17,7 @@
'name' => 'Erudite',
'url' => 'https://www.mediawiki.org/wiki/Skin:Erudite',
'author' => array( 'Nick White', 'Matt Wiebe', 'Colin Andrew Ferm' ),
-   'version' => '1.5',
+   'version' => '1.6',
'descriptionmsg' => 'erudite-desc',
 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/96273
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I28ef44cc78c11a798f07ebb70b59de57dabf27f8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Use svg only for decorative background-image graphics - change (mediawiki...erudite)

2013-11-19 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Use svg only for decorative background-image graphics
..


Use svg only for decorative background-image graphics

The stripes aren't a great loss if old browsers can't render them,
so remove the .png versions. The hr would be, so use a fallback to
the .png in that case.

Also slightly improve the hr graphics.

Change-Id: I40879b61d99a00bd6032ff7df8117e16550ae380
---
M assets/erudite.css
D assets/images/Makefile
M assets/images/hr.png
M assets/images/hr.svg
D assets/images/stripes-dark.png
D assets/images/stripes.png
6 files changed, 12 insertions(+), 18 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved



diff --git a/assets/erudite.css b/assets/erudite.css
index 9fd486b..612769d 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -17,8 +17,7 @@
 
 /* Use dark stripes around edge to focus on content */
 #wrapper {
-   /* @embed */
-   background: #fafafa url(images/stripes-dark.png);
+   background: #fafafa url(images/stripes-dark.svg);
 }
 
 #container {
@@ -167,8 +166,7 @@
 
 /* Header */
 #header-wrap {
-   /* @embed */
-   background-image: url(images/stripes.png);
+   background-image: url(images/stripes.svg);
background-color: #33;
background-repeat: repeat;
padding: 0.625em 0;
@@ -296,9 +294,14 @@
 }
 
 hr {
-   /* @embed */
-   background: url(images/hr.png) center no-repeat;
-   height: 1.5em;
+   /* This hack ensures fallback to .png if .svg isn't supported
+* (see http://css-tricks.com/svg-fallbacks/ ) */
+   background-image: url(images/hr.png);
+   background-image: url(images/hr.svg), none;
+   background-position: center;
+   background-repeat: no-repeat;
+   background-size: 80% 10%;
+   height: 1.25em;
display: block;
border: none;
 }
diff --git a/assets/images/Makefile b/assets/images/Makefile
deleted file mode 100644
index 86e4485..000
--- a/assets/images/Makefile
+++ /dev/null
@@ -1,9 +0,0 @@
-# Someday browsers will all handle svg sensibly and we can then just
-# serve it up directly
-
-all: hr.png stripes.png stripes-dark.png
-
-.svg.png:
-   rsvg-convert $< > $@
-
-.SUFFIXES: .svg .png
diff --git a/assets/images/hr.png b/assets/images/hr.png
index 9f39445..18499d4 100644
--- a/assets/images/hr.png
+++ b/assets/images/hr.png
Binary files differ
diff --git a/assets/images/hr.svg b/assets/images/hr.svg
index 71ac0b6..a6edea9 100644
--- a/assets/images/hr.svg
+++ b/assets/images/hr.svg
@@ -1,7 +1,7 @@
 http://www.w3.org/2000/svg"; width="270" height="2">
 
   
-  
+  
 
-
+
 
diff --git a/assets/images/stripes-dark.png b/assets/images/stripes-dark.png
deleted file mode 100644
index 4cf4e3b..000
--- a/assets/images/stripes-dark.png
+++ /dev/null
Binary files differ
diff --git a/assets/images/stripes.png b/assets/images/stripes.png
deleted file mode 100644
index cbd14e5..000
--- a/assets/images/stripes.png
+++ /dev/null
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/96269
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I40879b61d99a00bd6032ff7df8117e16550ae380
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Use svg only for decorative background-image graphics - change (mediawiki...erudite)

2013-11-19 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/96269


Change subject: Use svg only for decorative background-image graphics
..

Use svg only for decorative background-image graphics

The stripes aren't a great loss if old browsers can't render them,
so remove the .png versions. The hr would be, so use a fallback to
the .png in that case.

Also slightly improve the hr graphics.

Change-Id: I40879b61d99a00bd6032ff7df8117e16550ae380
---
M assets/erudite.css
D assets/images/Makefile
M assets/images/hr.png
M assets/images/hr.svg
D assets/images/stripes-dark.png
D assets/images/stripes.png
6 files changed, 10 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/69/96269/1

diff --git a/assets/erudite.css b/assets/erudite.css
index 9fd486b..c08d4f7 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -17,8 +17,7 @@
 
 /* Use dark stripes around edge to focus on content */
 #wrapper {
-   /* @embed */
-   background: #fafafa url(images/stripes-dark.png);
+   background: #fafafa url(images/stripes-dark.svg);
 }
 
 #container {
@@ -167,8 +166,7 @@
 
 /* Header */
 #header-wrap {
-   /* @embed */
-   background-image: url(images/stripes.png);
+   background-image: url(images/stripes.svg);
background-color: #33;
background-repeat: repeat;
padding: 0.625em 0;
@@ -296,8 +294,12 @@
 }
 
 hr {
-   /* @embed */
-   background: url(images/hr.png) center no-repeat;
+   /* This hack ensures fallback to .png if .svg isn't supported 
+* (see http://css-tricks.com/svg-fallbacks/ ) */
+   background-image: url(images/hr.png);
+   background-image: url(images/hr.svg), none;
+   background-position: center;
+   background-repeat: no-repeat;
height: 1.5em;
display: block;
border: none;
diff --git a/assets/images/Makefile b/assets/images/Makefile
deleted file mode 100644
index 86e4485..000
--- a/assets/images/Makefile
+++ /dev/null
@@ -1,9 +0,0 @@
-# Someday browsers will all handle svg sensibly and we can then just
-# serve it up directly
-
-all: hr.png stripes.png stripes-dark.png
-
-.svg.png:
-   rsvg-convert $< > $@
-
-.SUFFIXES: .svg .png
diff --git a/assets/images/hr.png b/assets/images/hr.png
index 9f39445..49b74c0 100644
--- a/assets/images/hr.png
+++ b/assets/images/hr.png
Binary files differ
diff --git a/assets/images/hr.svg b/assets/images/hr.svg
index 71ac0b6..feb4257 100644
--- a/assets/images/hr.svg
+++ b/assets/images/hr.svg
@@ -1,7 +1,7 @@
 http://www.w3.org/2000/svg"; width="270" height="2">
 
   
-  
+  
 
-
+
 
diff --git a/assets/images/stripes-dark.png b/assets/images/stripes-dark.png
deleted file mode 100644
index 4cf4e3b..000
--- a/assets/images/stripes-dark.png
+++ /dev/null
Binary files differ
diff --git a/assets/images/stripes.png b/assets/images/stripes.png
deleted file mode 100644
index cbd14e5..000
--- a/assets/images/stripes.png
+++ /dev/null
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/96269
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I40879b61d99a00bd6032ff7df8117e16550ae380
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add menu button and hide top menu when the screen is too narrow - change (mediawiki...erudite)

2013-11-19 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Add menu button and hide top menu when the screen is too narrow
..


Add menu button and hide top menu when the screen is too narrow

Also simplifies top menu narrowing style rules

Change-Id: I07e7c54522d7eca2fb83b64e855da032937f864a
---
M Erudite.skin.php
M assets/erudite.css
M assets/erudite20em.css
A assets/erudite55em.css
M assets/erudite60em.css
M assets/erudite66em.css
M erudite.php
7 files changed, 44 insertions(+), 29 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Erudite.skin.php b/Erudite.skin.php
index 1698736..165fea8 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -82,6 +82,7 @@
msg( 'tagline' ) ?>

 
+   Menu



diff --git a/assets/erudite.css b/assets/erudite.css
index ef4c8ce..35c60c3 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -197,6 +197,10 @@
 }
 
 /* Menu */
+#menubutton {
+   display: none;
+}
+
 #menu {
margin: 1em 0 -0.625em;
overflow: hidden;
diff --git a/assets/erudite20em.css b/assets/erudite20em.css
index 9cb5953..83a6877 100644
--- a/assets/erudite20em.css
+++ b/assets/erudite20em.css
@@ -1,18 +1,3 @@
-#header h1 {
-   font-size: 1.75em;
-}
-
-#menu {
-   margin-top: 0.5em;
-}
-
-/* Stack top menu items */
-#menu li {
-   float: none !important;
-   border: none;
-   padding: 0em;
-}
-
 /* Disable text justification (user preference) */
 #article, #bodyContent, #mw_content {
text-align: left !important;
diff --git a/assets/erudite55em.css b/assets/erudite55em.css
new file mode 100644
index 000..ce2560f
--- /dev/null
+++ b/assets/erudite55em.css
@@ -0,0 +1,35 @@
+/* Replace menu with a menu button */
+#menubutton {
+   display: block;
+   position: absolute;
+   right: 0.5em;
+   top: 0.75em;
+   padding: 0.25em 0.5em;
+   background-color: #33;
+background-color: rgba(50, 50, 50, 0.7);
+   color: white;
+   font-family: 'Linux Biolinum', corbel, 'gill sans', 'gill sans mt', 
sans-serif;
+   font-size: large;
+   text-transform: uppercase;
+}
+
+/* Ensure header doesn't overlap with menu button */
+#header h1 {
+   margin-right: 2em;
+}
+
+/* Hide menu unless it's the target */
+#menu {
+   display: none;
+}
+
+#menu:target {
+   display: block;
+}
+
+/* Stack top menu items */
+#menu:target li {
+   float: none !important;
+   padding: 0em;
+   text-align: center;
+}
diff --git a/assets/erudite60em.css b/assets/erudite60em.css
index 993b501..61d8245 100644
--- a/assets/erudite60em.css
+++ b/assets/erudite60em.css
@@ -1,6 +1,7 @@
 /* Some of the padding is best dispatched with */
 #container,
 #header,
+#access,
 #footer-wrap-inner,
 .message {
width: 100%;
diff --git a/assets/erudite66em.css b/assets/erudite66em.css
index 3c3bda1..2465920 100644
--- a/assets/erudite66em.css
+++ b/assets/erudite66em.css
@@ -1,21 +1,9 @@
-/* The top menu is likely to start wrapping, so reduce padding
- * and add a separator */
+/* The top menu may want to start wrapping, so reduce padding */
 #menu {
-   padding: 0.7em 1em 0.45em;
-   background: rgba(50, 50, 50, 1.0);
+   padding: 0.5em 0em;
 }
 
 #menu li {
-   border-right: thin solid #66;
padding: 0em 1em;
-   margin-bottom: 0.3em;
margin-right: 0em;
-}
-
-#menu li:last-child {
-   border-right: none;
-}
-
-#access {
-   width: 100%;
 }
diff --git a/erudite.php b/erudite.php
index 2a89be3..f92e0b9 100644
--- a/erudite.php
+++ b/erudite.php
@@ -31,6 +31,7 @@
'erudite/assets/erudite.css' => array( 'media' => 'screen' ),
'erudite/assets/erudite66em.css' => array( 'media' => 'screen 
and (max-width: 66em)' ),
'erudite/assets/erudite60em.css' => array( 'media' => 'screen 
and (max-width: 60em)' ),
+   'erudite/assets/erudite55em.css' => array( 'media' => 'screen 
and (max-width: 55em)' ),
'erudite/assets/erudite40em.css' => array( 'media' => 'screen 
and (max-width: 40em)' ),
'erudite/assets/erudite20em.css' => array( 'media' => 'screen 
and (max-width: 20em)' ),
'erudite/assets/print.css' => array( 'media' => 'print' ),

-- 
To view, visit https://gerrit.wikimedia.org/r/96248
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I07e7c54522d7eca2fb83b64e855da032937f864a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo

[MediaWiki-commits] [Gerrit] Add menu button and hide top menu when the screen is too narrow - change (mediawiki...erudite)

2013-11-19 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/96248


Change subject: Add menu button and hide top menu when the screen is too narrow
..

Add menu button and hide top menu when the screen is too narrow

Also simplifies top menu narrowing style rules

Change-Id: I07e7c54522d7eca2fb83b64e855da032937f864a
---
M Erudite.skin.php
M assets/erudite.css
M assets/erudite20em.css
A assets/erudite55em.css
M assets/erudite60em.css
M assets/erudite66em.css
M erudite.php
7 files changed, 44 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/48/96248/1

diff --git a/Erudite.skin.php b/Erudite.skin.php
index 1698736..165fea8 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -82,6 +82,7 @@
msg( 'tagline' ) ?>

 
+   Menu



diff --git a/assets/erudite.css b/assets/erudite.css
index ef4c8ce..35c60c3 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -197,6 +197,10 @@
 }
 
 /* Menu */
+#menubutton {
+   display: none;
+}
+
 #menu {
margin: 1em 0 -0.625em;
overflow: hidden;
diff --git a/assets/erudite20em.css b/assets/erudite20em.css
index 9cb5953..83a6877 100644
--- a/assets/erudite20em.css
+++ b/assets/erudite20em.css
@@ -1,18 +1,3 @@
-#header h1 {
-   font-size: 1.75em;
-}
-
-#menu {
-   margin-top: 0.5em;
-}
-
-/* Stack top menu items */
-#menu li {
-   float: none !important;
-   border: none;
-   padding: 0em;
-}
-
 /* Disable text justification (user preference) */
 #article, #bodyContent, #mw_content {
text-align: left !important;
diff --git a/assets/erudite55em.css b/assets/erudite55em.css
new file mode 100644
index 000..ce2560f
--- /dev/null
+++ b/assets/erudite55em.css
@@ -0,0 +1,35 @@
+/* Replace menu with a menu button */
+#menubutton {
+   display: block;
+   position: absolute;
+   right: 0.5em;
+   top: 0.75em;
+   padding: 0.25em 0.5em;
+   background-color: #33;
+background-color: rgba(50, 50, 50, 0.7);
+   color: white;
+   font-family: 'Linux Biolinum', corbel, 'gill sans', 'gill sans mt', 
sans-serif;
+   font-size: large;
+   text-transform: uppercase;
+}
+
+/* Ensure header doesn't overlap with menu button */
+#header h1 {
+   margin-right: 2em;
+}
+
+/* Hide menu unless it's the target */
+#menu {
+   display: none;
+}
+
+#menu:target {
+   display: block;
+}
+
+/* Stack top menu items */
+#menu:target li {
+   float: none !important;
+   padding: 0em;
+   text-align: center;
+}
diff --git a/assets/erudite60em.css b/assets/erudite60em.css
index 993b501..61d8245 100644
--- a/assets/erudite60em.css
+++ b/assets/erudite60em.css
@@ -1,6 +1,7 @@
 /* Some of the padding is best dispatched with */
 #container,
 #header,
+#access,
 #footer-wrap-inner,
 .message {
width: 100%;
diff --git a/assets/erudite66em.css b/assets/erudite66em.css
index 3c3bda1..2465920 100644
--- a/assets/erudite66em.css
+++ b/assets/erudite66em.css
@@ -1,21 +1,9 @@
-/* The top menu is likely to start wrapping, so reduce padding
- * and add a separator */
+/* The top menu may want to start wrapping, so reduce padding */
 #menu {
-   padding: 0.7em 1em 0.45em;
-   background: rgba(50, 50, 50, 1.0);
+   padding: 0.5em 0em;
 }
 
 #menu li {
-   border-right: thin solid #66;
padding: 0em 1em;
-   margin-bottom: 0.3em;
margin-right: 0em;
-}
-
-#menu li:last-child {
-   border-right: none;
-}
-
-#access {
-   width: 100%;
 }
diff --git a/erudite.php b/erudite.php
index 2a89be3..f92e0b9 100644
--- a/erudite.php
+++ b/erudite.php
@@ -31,6 +31,7 @@
'erudite/assets/erudite.css' => array( 'media' => 'screen' ),
'erudite/assets/erudite66em.css' => array( 'media' => 'screen 
and (max-width: 66em)' ),
'erudite/assets/erudite60em.css' => array( 'media' => 'screen 
and (max-width: 60em)' ),
+   'erudite/assets/erudite55em.css' => array( 'media' => 'screen 
and (max-width: 55em)' ),
'erudite/assets/erudite40em.css' => array( 'media' => 'screen 
and (max-width: 40em)' ),
'erudite/assets/erudite20em.css' => array( 'media' => 'screen 
and (max-width: 20em)' ),
'erudite/assets/print.css' => array( 'media' => 'print' ),

-- 
To view, visit https://gerrit.wikimedia.org/r/96248
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I07e7c54522d7eca2fb83b64e855da032937f864a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/m

[MediaWiki-commits] [Gerrit] Add SVG master versions for all images - change (mediawiki...erudite)

2013-11-18 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Add SVG master versions for all images
..


Add SVG master versions for all images

Change-Id: Ie5d0866de4476a77cf6a9f49500ef13755cb1661
---
A assets/images/Makefile
M assets/images/hr.png
A assets/images/hr.svg
M assets/images/stripes-dark.png
A assets/images/stripes-dark.svg
M assets/images/stripes.png
A assets/images/stripes.svg
7 files changed, 24 insertions(+), 0 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved



diff --git a/assets/images/Makefile b/assets/images/Makefile
new file mode 100644
index 000..86e4485
--- /dev/null
+++ b/assets/images/Makefile
@@ -0,0 +1,9 @@
+# Someday browsers will all handle svg sensibly and we can then just
+# serve it up directly
+
+all: hr.png stripes.png stripes-dark.png
+
+.svg.png:
+   rsvg-convert $< > $@
+
+.SUFFIXES: .svg .png
diff --git a/assets/images/hr.png b/assets/images/hr.png
index 68195d6..9f39445 100644
--- a/assets/images/hr.png
+++ b/assets/images/hr.png
Binary files differ
diff --git a/assets/images/hr.svg b/assets/images/hr.svg
new file mode 100644
index 000..71ac0b6
--- /dev/null
+++ b/assets/images/hr.svg
@@ -0,0 +1,7 @@
+http://www.w3.org/2000/svg"; width="270" height="2">
+
+  
+  
+
+
+
diff --git a/assets/images/stripes-dark.png b/assets/images/stripes-dark.png
index bd2bc49..4cf4e3b 100644
--- a/assets/images/stripes-dark.png
+++ b/assets/images/stripes-dark.png
Binary files differ
diff --git a/assets/images/stripes-dark.svg b/assets/images/stripes-dark.svg
new file mode 100644
index 000..54bf429
--- /dev/null
+++ b/assets/images/stripes-dark.svg
@@ -0,0 +1,4 @@
+http://www.w3.org/2000/svg"; width="5" height="5">
+
+
+
diff --git a/assets/images/stripes.png b/assets/images/stripes.png
index 2f7cfc3..cbd14e5 100644
--- a/assets/images/stripes.png
+++ b/assets/images/stripes.png
Binary files differ
diff --git a/assets/images/stripes.svg b/assets/images/stripes.svg
new file mode 100644
index 000..77660b5
--- /dev/null
+++ b/assets/images/stripes.svg
@@ -0,0 +1,4 @@
+http://www.w3.org/2000/svg"; width="5" height="5">
+
+
+

-- 
To view, visit https://gerrit.wikimedia.org/r/96053
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie5d0866de4476a77cf6a9f49500ef13755cb1661
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add SVG master versions for all images - change (mediawiki...erudite)

2013-11-18 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/96053


Change subject: Add SVG master versions for all images
..

Add SVG master versions for all images

Change-Id: Ie5d0866de4476a77cf6a9f49500ef13755cb1661
---
A assets/images/Makefile
M assets/images/hr.png
A assets/images/hr.svg
M assets/images/stripes-dark.png
A assets/images/stripes-dark.svg
M assets/images/stripes.png
A assets/images/stripes.svg
7 files changed, 24 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/53/96053/1

diff --git a/assets/images/Makefile b/assets/images/Makefile
new file mode 100644
index 000..86e4485
--- /dev/null
+++ b/assets/images/Makefile
@@ -0,0 +1,9 @@
+# Someday browsers will all handle svg sensibly and we can then just
+# serve it up directly
+
+all: hr.png stripes.png stripes-dark.png
+
+.svg.png:
+   rsvg-convert $< > $@
+
+.SUFFIXES: .svg .png
diff --git a/assets/images/hr.png b/assets/images/hr.png
index 68195d6..9f39445 100644
--- a/assets/images/hr.png
+++ b/assets/images/hr.png
Binary files differ
diff --git a/assets/images/hr.svg b/assets/images/hr.svg
new file mode 100644
index 000..71ac0b6
--- /dev/null
+++ b/assets/images/hr.svg
@@ -0,0 +1,7 @@
+http://www.w3.org/2000/svg"; width="270" height="2">
+
+  
+  
+
+
+
diff --git a/assets/images/stripes-dark.png b/assets/images/stripes-dark.png
index bd2bc49..4cf4e3b 100644
--- a/assets/images/stripes-dark.png
+++ b/assets/images/stripes-dark.png
Binary files differ
diff --git a/assets/images/stripes-dark.svg b/assets/images/stripes-dark.svg
new file mode 100644
index 000..54bf429
--- /dev/null
+++ b/assets/images/stripes-dark.svg
@@ -0,0 +1,4 @@
+http://www.w3.org/2000/svg"; width="5" height="5">
+
+
+
diff --git a/assets/images/stripes.png b/assets/images/stripes.png
index 2f7cfc3..cbd14e5 100644
--- a/assets/images/stripes.png
+++ b/assets/images/stripes.png
Binary files differ
diff --git a/assets/images/stripes.svg b/assets/images/stripes.svg
new file mode 100644
index 000..77660b5
--- /dev/null
+++ b/assets/images/stripes.svg
@@ -0,0 +1,4 @@
+http://www.w3.org/2000/svg"; width="5" height="5">
+
+
+

-- 
To view, visit https://gerrit.wikimedia.org/r/96053
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie5d0866de4476a77cf6a9f49500ef13755cb1661
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Use subsetted versions of the fonts to reduce file sizes. - change (mediawiki...erudite)

2013-11-18 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Use subsetted versions of the fonts to reduce file sizes.
..


Use subsetted versions of the fonts to reduce file sizes.

Also corrected typo in COPYING regarding the name of the fonts.

Change-Id: Ib420cfcd851e3a4a80cf8cb743a1ed10b6295774
---
M COPYING
M assets/erudite.css
D assets/fonts/LinBiolinum_R.woff
A assets/fonts/LinBiolinum_R_subset.woff
D assets/fonts/LinLibertine_R.woff
D assets/fonts/LinLibertine_RB.woff
D assets/fonts/LinLibertine_RBI.woff
A assets/fonts/LinLibertine_RBI_subset.woff
A assets/fonts/LinLibertine_RB_subset.woff
D assets/fonts/LinLibertine_RI.woff
A assets/fonts/LinLibertine_RI_subset.woff
A assets/fonts/LinLibertine_R_subset.woff
A assets/fonts/subset.ff
13 files changed, 71 insertions(+), 7 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/COPYING b/COPYING
index 190dc88..5b8ecb5 100644
--- a/COPYING
+++ b/COPYING
@@ -1,8 +1,10 @@
 This skin is released under the GPLv2 or any later version. See below for the
 full license.
 
-The fonts are from Linux Liberation  and are
-licensed under the GPL and the OFL.
+The fonts are from Linux Libertine  and are
+licensed under the GPL and the OFL. They have been subsetted using the script
+assets/fonts/subset.ff, and as the font names have not been changed the subsets
+are only offered under the GPL (as OFL forbids derivatives without renaming).
 
 Copyright 2009-2013 Matt Wiebe, Nick White, Colin Andrew Ferm, Daniel Friesen
 
diff --git a/assets/erudite.css b/assets/erudite.css
index ef4c8ce..cec8fde 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -41,31 +41,31 @@
 /* Typography base */
 @font-face {
font-family: 'Linux Libertine';
-   src: url('fonts/LinLibertine_R.woff');
+   src: url('fonts/LinLibertine_R_subset.woff');
 }
 
 @font-face {
font-family: 'Linux Libertine';
font-style: italic;
-   src: url('fonts/LinLibertine_RI.woff');
+   src: url('fonts/LinLibertine_RI_subset.woff');
 }
 
 @font-face {
font-family: 'Linux Libertine';
font-weight: bold;
-   src: url('fonts/LinLibertine_RB.woff');
+   src: url('fonts/LinLibertine_RB_subset.woff');
 }
 
 @font-face {
font-family: 'Linux Libertine';
font-style: italic;
font-weight: bold;
-   src: url('fonts/LinLibertine_RBI.woff');
+   src: url('fonts/LinLibertine_RBI_subset.woff');
 }
 
 @font-face {
font-family: 'Linux Biolinum';
-   src: url('fonts/LinBiolinum_R.woff');
+   src: url('fonts/LinBiolinum_R_subset.woff');
 }
 
 body {
diff --git a/assets/fonts/LinBiolinum_R.woff b/assets/fonts/LinBiolinum_R.woff
deleted file mode 100644
index 5c399fd..000
--- a/assets/fonts/LinBiolinum_R.woff
+++ /dev/null
Binary files differ
diff --git a/assets/fonts/LinBiolinum_R_subset.woff 
b/assets/fonts/LinBiolinum_R_subset.woff
new file mode 100644
index 000..313b296
--- /dev/null
+++ b/assets/fonts/LinBiolinum_R_subset.woff
Binary files differ
diff --git a/assets/fonts/LinLibertine_R.woff b/assets/fonts/LinLibertine_R.woff
deleted file mode 100644
index 0357ad4..000
--- a/assets/fonts/LinLibertine_R.woff
+++ /dev/null
Binary files differ
diff --git a/assets/fonts/LinLibertine_RB.woff 
b/assets/fonts/LinLibertine_RB.woff
deleted file mode 100644
index a0dbbbf..000
--- a/assets/fonts/LinLibertine_RB.woff
+++ /dev/null
Binary files differ
diff --git a/assets/fonts/LinLibertine_RBI.woff 
b/assets/fonts/LinLibertine_RBI.woff
deleted file mode 100644
index 402494e..000
--- a/assets/fonts/LinLibertine_RBI.woff
+++ /dev/null
Binary files differ
diff --git a/assets/fonts/LinLibertine_RBI_subset.woff 
b/assets/fonts/LinLibertine_RBI_subset.woff
new file mode 100644
index 000..7154d50
--- /dev/null
+++ b/assets/fonts/LinLibertine_RBI_subset.woff
Binary files differ
diff --git a/assets/fonts/LinLibertine_RB_subset.woff 
b/assets/fonts/LinLibertine_RB_subset.woff
new file mode 100644
index 000..26b0a9a
--- /dev/null
+++ b/assets/fonts/LinLibertine_RB_subset.woff
Binary files differ
diff --git a/assets/fonts/LinLibertine_RI.woff 
b/assets/fonts/LinLibertine_RI.woff
deleted file mode 100644
index e2a0ae4..000
--- a/assets/fonts/LinLibertine_RI.woff
+++ /dev/null
Binary files differ
diff --git a/assets/fonts/LinLibertine_RI_subset.woff 
b/assets/fonts/LinLibertine_RI_subset.woff
new file mode 100644
index 000..cfe3c70
--- /dev/null
+++ b/assets/fonts/LinLibertine_RI_subset.woff
Binary files differ
diff --git a/assets/fonts/LinLibertine_R_subset.woff 
b/assets/fonts/LinLibertine_R_subset.woff
new file mode 100644
index 000..c9be7a8
--- /dev/null
+++ b/assets/fonts/LinLibertine_R_subset.woff
Binary files differ
diff --git a/assets/fonts/subset.ff b/assets/fonts/subset.ff
new file mode 100755
index 000.

[MediaWiki-commits] [Gerrit] Add :focus rules where :hover was, and reorganise css slightly - change (mediawiki...erudite)

2013-11-18 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Add :focus rules where :hover was, and reorganise css slightly
..


Add :focus rules where :hover was, and reorganise css slightly

Change-Id: Ib277635ed9cf00eaa33719c60ed06afd5791433c
---
M assets/erudite.css
1 file changed, 12 insertions(+), 11 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/assets/erudite.css b/assets/erudite.css
index ef4c8ce..19df69b 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -157,10 +157,6 @@
color: #bb;
 }
 
-a:hover {
-   text-decoration: underline;
-}
-
 a:visited {
color: #330077;
 }
@@ -176,10 +172,10 @@
background-color: #33;
background-repeat: repeat;
padding: 0.625em 0;
+   color: #ff;
 }
 
 #header h1 {
-   color: #ff;
text-decoration: none;
font-size: 2.25em;
line-height: 1;
@@ -188,12 +184,10 @@
 
 #header a {
color: #ff;
-   text-decoration: none;
 }
 
 #tagline {
font-size: 0.875em;
-   color: #ff;
 }
 
 /* Menu */
@@ -208,6 +202,11 @@
 #menu a {
text-transform: uppercase;
color: #ff;
+}
+
+#menu a:hover,
+#menu a:focus {
+   text-decoration: underline;
 }
 
 #menu li {
@@ -257,12 +256,13 @@
 .footer a,
 .footer a.new {
color: #ff;
-   text-decoration: none;
border-bottom: thin solid #99;
 }
 
 .footer a:hover,
-.footer a.new:hover {
+.footer a:focus,
+.footer a.new:hover,
+.footer a.new:focus {
border-color: #cc;
 }
 
@@ -355,9 +355,9 @@
border-bottom: thin solid #aa;
 }
 
-.entry-content a:hover {
+.entry-content a:hover,
+.entry-content a:focus {
border-color: #55;
-   text-decoration: none;
 }
 
 /* Meta (edit links etc.) */
@@ -616,6 +616,7 @@
color: #ff;
font-size: 0.75em;
 }
+
 .mw-jump a {
color: #ff;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/96020
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib277635ed9cf00eaa33719c60ed06afd5791433c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Use subsetted versions of the fonts to reduce file sizes. - change (mediawiki...erudite)

2013-11-18 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/96021


Change subject: Use subsetted versions of the fonts to reduce file sizes.
..

Use subsetted versions of the fonts to reduce file sizes.

Also corrected typo in COPYING regarding the name of the fonts.

Change-Id: Ib420cfcd851e3a4a80cf8cb743a1ed10b6295774
---
M COPYING
M assets/erudite.css
D assets/fonts/LinBiolinum_R.woff
A assets/fonts/LinBiolinum_R_subset.woff
D assets/fonts/LinLibertine_R.woff
D assets/fonts/LinLibertine_RB.woff
D assets/fonts/LinLibertine_RBI.woff
A assets/fonts/LinLibertine_RBI_subset.woff
A assets/fonts/LinLibertine_RB_subset.woff
D assets/fonts/LinLibertine_RI.woff
A assets/fonts/LinLibertine_RI_subset.woff
A assets/fonts/LinLibertine_R_subset.woff
A assets/fonts/subset.ff
13 files changed, 71 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/21/96021/1

diff --git a/COPYING b/COPYING
index 190dc88..5b8ecb5 100644
--- a/COPYING
+++ b/COPYING
@@ -1,8 +1,10 @@
 This skin is released under the GPLv2 or any later version. See below for the
 full license.
 
-The fonts are from Linux Liberation  and are
-licensed under the GPL and the OFL.
+The fonts are from Linux Libertine  and are
+licensed under the GPL and the OFL. They have been subsetted using the script
+assets/fonts/subset.ff, and as the font names have not been changed the subsets
+are only offered under the GPL (as OFL forbids derivatives without renaming).
 
 Copyright 2009-2013 Matt Wiebe, Nick White, Colin Andrew Ferm, Daniel Friesen
 
diff --git a/assets/erudite.css b/assets/erudite.css
index ef4c8ce..cec8fde 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -41,31 +41,31 @@
 /* Typography base */
 @font-face {
font-family: 'Linux Libertine';
-   src: url('fonts/LinLibertine_R.woff');
+   src: url('fonts/LinLibertine_R_subset.woff');
 }
 
 @font-face {
font-family: 'Linux Libertine';
font-style: italic;
-   src: url('fonts/LinLibertine_RI.woff');
+   src: url('fonts/LinLibertine_RI_subset.woff');
 }
 
 @font-face {
font-family: 'Linux Libertine';
font-weight: bold;
-   src: url('fonts/LinLibertine_RB.woff');
+   src: url('fonts/LinLibertine_RB_subset.woff');
 }
 
 @font-face {
font-family: 'Linux Libertine';
font-style: italic;
font-weight: bold;
-   src: url('fonts/LinLibertine_RBI.woff');
+   src: url('fonts/LinLibertine_RBI_subset.woff');
 }
 
 @font-face {
font-family: 'Linux Biolinum';
-   src: url('fonts/LinBiolinum_R.woff');
+   src: url('fonts/LinBiolinum_R_subset.woff');
 }
 
 body {
diff --git a/assets/fonts/LinBiolinum_R.woff b/assets/fonts/LinBiolinum_R.woff
deleted file mode 100644
index 5c399fd..000
--- a/assets/fonts/LinBiolinum_R.woff
+++ /dev/null
Binary files differ
diff --git a/assets/fonts/LinBiolinum_R_subset.woff 
b/assets/fonts/LinBiolinum_R_subset.woff
new file mode 100644
index 000..313b296
--- /dev/null
+++ b/assets/fonts/LinBiolinum_R_subset.woff
Binary files differ
diff --git a/assets/fonts/LinLibertine_R.woff b/assets/fonts/LinLibertine_R.woff
deleted file mode 100644
index 0357ad4..000
--- a/assets/fonts/LinLibertine_R.woff
+++ /dev/null
Binary files differ
diff --git a/assets/fonts/LinLibertine_RB.woff 
b/assets/fonts/LinLibertine_RB.woff
deleted file mode 100644
index a0dbbbf..000
--- a/assets/fonts/LinLibertine_RB.woff
+++ /dev/null
Binary files differ
diff --git a/assets/fonts/LinLibertine_RBI.woff 
b/assets/fonts/LinLibertine_RBI.woff
deleted file mode 100644
index 402494e..000
--- a/assets/fonts/LinLibertine_RBI.woff
+++ /dev/null
Binary files differ
diff --git a/assets/fonts/LinLibertine_RBI_subset.woff 
b/assets/fonts/LinLibertine_RBI_subset.woff
new file mode 100644
index 000..7154d50
--- /dev/null
+++ b/assets/fonts/LinLibertine_RBI_subset.woff
Binary files differ
diff --git a/assets/fonts/LinLibertine_RB_subset.woff 
b/assets/fonts/LinLibertine_RB_subset.woff
new file mode 100644
index 000..26b0a9a
--- /dev/null
+++ b/assets/fonts/LinLibertine_RB_subset.woff
Binary files differ
diff --git a/assets/fonts/LinLibertine_RI.woff 
b/assets/fonts/LinLibertine_RI.woff
deleted file mode 100644
index e2a0ae4..000
--- a/assets/fonts/LinLibertine_RI.woff
+++ /dev/null
Binary files differ
diff --git a/assets/fonts/LinLibertine_RI_subset.woff 
b/assets/fonts/LinLibertine_RI_subset.woff
new file mode 100644
index 000..cfe3c70
--- /dev/null
+++ b/assets/fonts/LinLibertine_RI_subset.woff
Binary files differ
diff --git a/assets/fonts/LinLibertine_R_subset.woff 
b/assets/fonts/LinLibertine_R_subset.woff
new file mode 100644
index 000..c9be7a8
--- /dev/null
+++ b/assets/fonts/LinLibertine_R_subset.woff
Binary files differ
diff --git a/assets/fonts/subset.ff b/assets/fonts

[MediaWiki-commits] [Gerrit] Add :focus rules where :hover was, and reorganise css slightly - change (mediawiki...erudite)

2013-11-18 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/96020


Change subject: Add :focus rules where :hover was, and reorganise css slightly
..

Add :focus rules where :hover was, and reorganise css slightly

Change-Id: Ib277635ed9cf00eaa33719c60ed06afd5791433c
---
M assets/erudite.css
1 file changed, 12 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/20/96020/1

diff --git a/assets/erudite.css b/assets/erudite.css
index ef4c8ce..19df69b 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -157,10 +157,6 @@
color: #bb;
 }
 
-a:hover {
-   text-decoration: underline;
-}
-
 a:visited {
color: #330077;
 }
@@ -176,10 +172,10 @@
background-color: #33;
background-repeat: repeat;
padding: 0.625em 0;
+   color: #ff;
 }
 
 #header h1 {
-   color: #ff;
text-decoration: none;
font-size: 2.25em;
line-height: 1;
@@ -188,12 +184,10 @@
 
 #header a {
color: #ff;
-   text-decoration: none;
 }
 
 #tagline {
font-size: 0.875em;
-   color: #ff;
 }
 
 /* Menu */
@@ -208,6 +202,11 @@
 #menu a {
text-transform: uppercase;
color: #ff;
+}
+
+#menu a:hover,
+#menu a:focus {
+   text-decoration: underline;
 }
 
 #menu li {
@@ -257,12 +256,13 @@
 .footer a,
 .footer a.new {
color: #ff;
-   text-decoration: none;
border-bottom: thin solid #99;
 }
 
 .footer a:hover,
-.footer a.new:hover {
+.footer a:focus,
+.footer a.new:hover,
+.footer a.new:focus {
border-color: #cc;
 }
 
@@ -355,9 +355,9 @@
border-bottom: thin solid #aa;
 }
 
-.entry-content a:hover {
+.entry-content a:hover,
+.entry-content a:focus {
border-color: #55;
-   text-decoration: none;
 }
 
 /* Meta (edit links etc.) */
@@ -616,6 +616,7 @@
color: #ff;
font-size: 0.75em;
 }
+
 .mw-jump a {
color: #ff;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/96020
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib277635ed9cf00eaa33719c60ed06afd5791433c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Release v1.5 - change (mediawiki...erudite)

2013-11-05 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Release v1.5
..


Release v1.5

Change-Id: If5edae09f1ba1c62c157b8ca1823dcb174427032
---
M erudite.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/erudite.php b/erudite.php
index 366800c..2a89be3 100644
--- a/erudite.php
+++ b/erudite.php
@@ -17,7 +17,7 @@
'name' => 'Erudite',
'url' => 'https://www.mediawiki.org/wiki/Skin:Erudite',
'author' => array( 'Nick White', 'Matt Wiebe', 'Colin Andrew Ferm' ),
-   'version' => '1.4',
+   'version' => '1.5',
'descriptionmsg' => 'erudite-desc',
 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/93681
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If5edae09f1ba1c62c157b8ca1823dcb174427032
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Release v1.5 - change (mediawiki...erudite)

2013-11-05 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/93681


Change subject: Release v1.5
..

Release v1.5

Change-Id: If5edae09f1ba1c62c157b8ca1823dcb174427032
---
M erudite.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/81/93681/1

diff --git a/erudite.php b/erudite.php
index 366800c..2a89be3 100644
--- a/erudite.php
+++ b/erudite.php
@@ -17,7 +17,7 @@
'name' => 'Erudite',
'url' => 'https://www.mediawiki.org/wiki/Skin:Erudite',
'author' => array( 'Nick White', 'Matt Wiebe', 'Colin Andrew Ferm' ),
-   'version' => '1.4',
+   'version' => '1.5',
'descriptionmsg' => 'erudite-desc',
 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/93681
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If5edae09f1ba1c62c157b8ca1823dcb174427032
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove $wgEruditeBannerImg usage - change (mediawiki...erudite)

2013-11-05 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Remove $wgEruditeBannerImg usage
..


Remove $wgEruditeBannerImg usage

Mediawiki:Common.css should be the place to customise this (as will
be documented on the Skin:Erudite wiki page soon)

Change-Id: I42759d309ce8d2b5f67a23aa1f5c3da0441eff25
---
M Erudite.skin.php
1 file changed, 2 insertions(+), 9 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Erudite.skin.php b/Erudite.skin.php
index e45d58e..1698736 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -57,8 +57,6 @@
 * outputs a formatted page.
 */
public function execute() {
-   global $wgEruditeBannerImg;
-
$this->html( 'headelement' );
 
if ( !isset( $this->data['sitename'] ) ) {
@@ -77,13 +75,8 @@

 

-   ";
-   } else {
-   echo '';
-   }
-   ?>
+   
+

text( 
'sitename' ); ?>
msg( 'tagline' ) ?>

-- 
To view, visit https://gerrit.wikimedia.org/r/93671
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I42759d309ce8d2b5f67a23aa1f5c3da0441eff25
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove $wgEruditeBannerImg usage - change (mediawiki...erudite)

2013-11-05 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/93671


Change subject: Remove $wgEruditeBannerImg usage
..

Remove $wgEruditeBannerImg usage

Mediawiki:Common.css should be the place to customise this (as will
be documented on the Skin:Erudite wiki page soon)

Change-Id: I42759d309ce8d2b5f67a23aa1f5c3da0441eff25
---
M Erudite.skin.php
1 file changed, 2 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/71/93671/1

diff --git a/Erudite.skin.php b/Erudite.skin.php
index e45d58e..1698736 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -57,8 +57,6 @@
 * outputs a formatted page.
 */
public function execute() {
-   global $wgEruditeBannerImg;
-
$this->html( 'headelement' );
 
if ( !isset( $this->data['sitename'] ) ) {
@@ -77,13 +75,8 @@

 

-   ";
-   } else {
-   echo '';
-   }
-   ?>
+   
+

text( 
'sitename' ); ?>
msg( 'tagline' ) ?>

-- 
To view, visit https://gerrit.wikimedia.org/r/93671
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I42759d309ce8d2b5f67a23aa1f5c3da0441eff25
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Switch to Linux Libertine and Linux Biolinum for body and he... - change (mediawiki...erudite)

2013-11-04 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Switch to Linux Libertine and Linux Biolinum for body and 
header fonts
..


Switch to Linux Libertine and Linux Biolinum for body and header fonts

This change is only done with .woff; versions of IE prior to 9
aren't worth the effort.

As the font is somewhat smaller than the standard font on many
systems, the base size is increased 25%, and menu padding is
slightly adjusted to compensate.

Change-Id: I7aa64823ee82cbcc7bf7bcfb2d349d5e5a8166c8
---
M COPYING
M assets/erudite.css
A assets/fonts/LinBiolinum_R.woff
A assets/fonts/LinLibertine_R.woff
A assets/fonts/LinLibertine_RB.woff
A assets/fonts/LinLibertine_RBI.woff
A assets/fonts/LinLibertine_RI.woff
7 files changed, 36 insertions(+), 5 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/COPYING b/COPYING
index 7cf95ae..190dc88 100644
--- a/COPYING
+++ b/COPYING
@@ -1,6 +1,9 @@
 This skin is released under the GPLv2 or any later version. See below for the
 full license.
 
+The fonts are from Linux Liberation  and are
+licensed under the GPL and the OFL.
+
 Copyright 2009-2013 Matt Wiebe, Nick White, Colin Andrew Ferm, Daniel Friesen
 
 
diff --git a/assets/erudite.css b/assets/erudite.css
index da92048..ef4c8ce 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -39,9 +39,39 @@
 }
 
 /* Typography base */
+@font-face {
+   font-family: 'Linux Libertine';
+   src: url('fonts/LinLibertine_R.woff');
+}
+
+@font-face {
+   font-family: 'Linux Libertine';
+   font-style: italic;
+   src: url('fonts/LinLibertine_RI.woff');
+}
+
+@font-face {
+   font-family: 'Linux Libertine';
+   font-weight: bold;
+   src: url('fonts/LinLibertine_RB.woff');
+}
+
+@font-face {
+   font-family: 'Linux Libertine';
+   font-style: italic;
+   font-weight: bold;
+   src: url('fonts/LinLibertine_RBI.woff');
+}
+
+@font-face {
+   font-family: 'Linux Biolinum';
+   src: url('fonts/LinBiolinum_R.woff');
+}
+
 body {
-   font-family: constantia, 'hoefler text', 'palatino linotype', serif;
+   font-family: 'Linux Libertine', constantia, 'hoefler text', 'palatino 
linotype', serif;
line-height: 1.4;
+   font-size: 1.125em;
background: #fafafa;
color: #33;
 }
@@ -56,7 +86,7 @@
 .entry-meta,
 #menu,
 #footer-wrap {
-   font-family: corbel, 'gill sans', 'gill sans mt', sans-serif;
+   font-family: 'Linux Biolinum', corbel, 'gill sans', 'gill sans mt', 
sans-serif;
font-weight: normal;
text-rendering: optimizeLegibility;
 }
@@ -71,7 +101,6 @@
 h1 {
font-size: 1.5em;
text-transform: uppercase;
-   letter-spacing: 0.05em;
margin-top: 1.3em;
 }
 
@@ -171,7 +200,7 @@
 #menu {
margin: 1em 0 -0.625em;
overflow: hidden;
-   padding: 0.75em 2em 0.75em 3.75em;
+   padding: 0.5em 2em 0.5em 3.75em;
background: #33;
background: rgba(50, 50, 50, 0.7);
 }
@@ -223,7 +252,6 @@
margin-bottom: 0.2em;
font-size: 1.25em;
text-transform: uppercase;
-   letter-spacing: 0.05em;
 }
 
 .footer a,
diff --git a/assets/fonts/LinBiolinum_R.woff b/assets/fonts/LinBiolinum_R.woff
new file mode 100644
index 000..5c399fd
--- /dev/null
+++ b/assets/fonts/LinBiolinum_R.woff
Binary files differ
diff --git a/assets/fonts/LinLibertine_R.woff b/assets/fonts/LinLibertine_R.woff
new file mode 100644
index 000..0357ad4
--- /dev/null
+++ b/assets/fonts/LinLibertine_R.woff
Binary files differ
diff --git a/assets/fonts/LinLibertine_RB.woff 
b/assets/fonts/LinLibertine_RB.woff
new file mode 100644
index 000..a0dbbbf
--- /dev/null
+++ b/assets/fonts/LinLibertine_RB.woff
Binary files differ
diff --git a/assets/fonts/LinLibertine_RBI.woff 
b/assets/fonts/LinLibertine_RBI.woff
new file mode 100644
index 000..402494e
--- /dev/null
+++ b/assets/fonts/LinLibertine_RBI.woff
Binary files differ
diff --git a/assets/fonts/LinLibertine_RI.woff 
b/assets/fonts/LinLibertine_RI.woff
new file mode 100644
index 000..e2a0ae4
--- /dev/null
+++ b/assets/fonts/LinLibertine_RI.woff
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/93501
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7aa64823ee82cbcc7bf7bcfb2d349d5e5a8166c8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Switch to Linux Libertine and Linux Biolinum for body and he... - change (mediawiki...erudite)

2013-11-04 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/93501


Change subject: Switch to Linux Libertine and Linux Biolinum for body and 
header fonts
..

Switch to Linux Libertine and Linux Biolinum for body and header fonts

This change is only done with .woff; versions of IE prior to 9
aren't worth the effort.

As the font is somewhat smaller than the standard font on many
systems, the base size is increased 25%, and menu padding is
slightly adjusted to compensate.

Change-Id: I7aa64823ee82cbcc7bf7bcfb2d349d5e5a8166c8
---
M COPYING
M assets/erudite.css
A assets/fonts/LinBiolinum_R.woff
A assets/fonts/LinLibertine_R.woff
A assets/fonts/LinLibertine_RB.woff
A assets/fonts/LinLibertine_RBI.woff
A assets/fonts/LinLibertine_RI.woff
7 files changed, 36 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/01/93501/1

diff --git a/COPYING b/COPYING
index 7cf95ae..190dc88 100644
--- a/COPYING
+++ b/COPYING
@@ -1,6 +1,9 @@
 This skin is released under the GPLv2 or any later version. See below for the
 full license.
 
+The fonts are from Linux Liberation  and are
+licensed under the GPL and the OFL.
+
 Copyright 2009-2013 Matt Wiebe, Nick White, Colin Andrew Ferm, Daniel Friesen
 
 
diff --git a/assets/erudite.css b/assets/erudite.css
index da92048..ef4c8ce 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -39,9 +39,39 @@
 }
 
 /* Typography base */
+@font-face {
+   font-family: 'Linux Libertine';
+   src: url('fonts/LinLibertine_R.woff');
+}
+
+@font-face {
+   font-family: 'Linux Libertine';
+   font-style: italic;
+   src: url('fonts/LinLibertine_RI.woff');
+}
+
+@font-face {
+   font-family: 'Linux Libertine';
+   font-weight: bold;
+   src: url('fonts/LinLibertine_RB.woff');
+}
+
+@font-face {
+   font-family: 'Linux Libertine';
+   font-style: italic;
+   font-weight: bold;
+   src: url('fonts/LinLibertine_RBI.woff');
+}
+
+@font-face {
+   font-family: 'Linux Biolinum';
+   src: url('fonts/LinBiolinum_R.woff');
+}
+
 body {
-   font-family: constantia, 'hoefler text', 'palatino linotype', serif;
+   font-family: 'Linux Libertine', constantia, 'hoefler text', 'palatino 
linotype', serif;
line-height: 1.4;
+   font-size: 1.125em;
background: #fafafa;
color: #33;
 }
@@ -56,7 +86,7 @@
 .entry-meta,
 #menu,
 #footer-wrap {
-   font-family: corbel, 'gill sans', 'gill sans mt', sans-serif;
+   font-family: 'Linux Biolinum', corbel, 'gill sans', 'gill sans mt', 
sans-serif;
font-weight: normal;
text-rendering: optimizeLegibility;
 }
@@ -71,7 +101,6 @@
 h1 {
font-size: 1.5em;
text-transform: uppercase;
-   letter-spacing: 0.05em;
margin-top: 1.3em;
 }
 
@@ -171,7 +200,7 @@
 #menu {
margin: 1em 0 -0.625em;
overflow: hidden;
-   padding: 0.75em 2em 0.75em 3.75em;
+   padding: 0.5em 2em 0.5em 3.75em;
background: #33;
background: rgba(50, 50, 50, 0.7);
 }
@@ -223,7 +252,6 @@
margin-bottom: 0.2em;
font-size: 1.25em;
text-transform: uppercase;
-   letter-spacing: 0.05em;
 }
 
 .footer a,
diff --git a/assets/fonts/LinBiolinum_R.woff b/assets/fonts/LinBiolinum_R.woff
new file mode 100644
index 000..5c399fd
--- /dev/null
+++ b/assets/fonts/LinBiolinum_R.woff
Binary files differ
diff --git a/assets/fonts/LinLibertine_R.woff b/assets/fonts/LinLibertine_R.woff
new file mode 100644
index 000..0357ad4
--- /dev/null
+++ b/assets/fonts/LinLibertine_R.woff
Binary files differ
diff --git a/assets/fonts/LinLibertine_RB.woff 
b/assets/fonts/LinLibertine_RB.woff
new file mode 100644
index 000..a0dbbbf
--- /dev/null
+++ b/assets/fonts/LinLibertine_RB.woff
Binary files differ
diff --git a/assets/fonts/LinLibertine_RBI.woff 
b/assets/fonts/LinLibertine_RBI.woff
new file mode 100644
index 000..402494e
--- /dev/null
+++ b/assets/fonts/LinLibertine_RBI.woff
Binary files differ
diff --git a/assets/fonts/LinLibertine_RI.woff 
b/assets/fonts/LinLibertine_RI.woff
new file mode 100644
index 000..e2a0ae4
--- /dev/null
+++ b/assets/fonts/LinLibertine_RI.woff
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/93501
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7aa64823ee82cbcc7bf7bcfb2d349d5e5a8166c8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Release v1.4 - change (mediawiki...erudite)

2013-10-30 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Release v1.4
..


Release v1.4

Change-Id: Id703ea3de95accaa249c76b3583a288305228be7
---
M erudite.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Njw: Verified; Looks good to me, approved



diff --git a/erudite.php b/erudite.php
index db63d6b..366800c 100644
--- a/erudite.php
+++ b/erudite.php
@@ -17,7 +17,7 @@
'name' => 'Erudite',
'url' => 'https://www.mediawiki.org/wiki/Skin:Erudite',
'author' => array( 'Nick White', 'Matt Wiebe', 'Colin Andrew Ferm' ),
-   'version' => '1.3',
+   'version' => '1.4',
'descriptionmsg' => 'erudite-desc',
 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/92645
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id703ea3de95accaa249c76b3583a288305228be7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Release v1.4 - change (mediawiki...erudite)

2013-10-30 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/92645


Change subject: Release v1.4
..

Release v1.4

Change-Id: Id703ea3de95accaa249c76b3583a288305228be7
---
M erudite.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/45/92645/1

diff --git a/erudite.php b/erudite.php
index db63d6b..366800c 100644
--- a/erudite.php
+++ b/erudite.php
@@ -17,7 +17,7 @@
'name' => 'Erudite',
'url' => 'https://www.mediawiki.org/wiki/Skin:Erudite',
'author' => array( 'Nick White', 'Matt Wiebe', 'Colin Andrew Ferm' ),
-   'version' => '1.3',
+   'version' => '1.4',
'descriptionmsg' => 'erudite-desc',
 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/92645
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id703ea3de95accaa249c76b3583a288305228be7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Don't hide table of contents and format it neatly - change (mediawiki...erudite)

2013-10-28 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Don't hide table of contents and format it neatly
..


Don't hide table of contents and format it neatly

TOC hiding shoudn't be done in a skin, but rather as described
at https://www.mediawiki.org/wiki/Toc

Change-Id: Ieafc8068bccfeee011bb5e95a00d1d322d984bba
---
M assets/erudite.css
1 file changed, 30 insertions(+), 4 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/assets/erudite.css b/assets/erudite.css
index aa2c382..da92048 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -277,12 +277,16 @@
 }
 
 p,
-li,
 dt,
 dd,
 blockquote,
 center {
margin-bottom: 0.75em;
+}
+
+li {
+   margin-bottom: 0.375em;
+   margin-top: 0.375em;
 }
 
 table {
@@ -355,10 +359,32 @@
font-size: 0.75em;
 }
 
-.toc,
-#toc {
-   display: none;
+.toc tbody,
+#toc tbody {
+   border: thin solid #aaa;
 }
+
+.toc li,
+#toc li {
+   list-style: none;
+}
+
+.toc #toctitle,
+#toc #toctitle {
+   text-align: center;
+}
+
+.toc h2,
+#toc h2 {
+   margin-top: 0em;
+   display: inline;
+}
+
+.toc td,
+#toc td {
+   padding: 0.25em 1em;
+}
+
 .subtitle {
margin-bottom: 1em;
font-size: 0.875em;

-- 
To view, visit https://gerrit.wikimedia.org/r/92297
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieafc8068bccfeee011bb5e95a00d1d322d984bba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Don't hide table of contents and format it neatly - change (mediawiki...erudite)

2013-10-28 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/92297


Change subject: Don't hide table of contents and format it neatly
..

Don't hide table of contents and format it neatly

TOC hiding shoudn't be done in a skin, but rather as described
at https://www.mediawiki.org/wiki/Toc

Change-Id: Ieafc8068bccfeee011bb5e95a00d1d322d984bba
---
M assets/erudite.css
1 file changed, 30 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/97/92297/1

diff --git a/assets/erudite.css b/assets/erudite.css
index aa2c382..da92048 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -277,12 +277,16 @@
 }
 
 p,
-li,
 dt,
 dd,
 blockquote,
 center {
margin-bottom: 0.75em;
+}
+
+li {
+   margin-bottom: 0.375em;
+   margin-top: 0.375em;
 }
 
 table {
@@ -355,10 +359,32 @@
font-size: 0.75em;
 }
 
-.toc,
-#toc {
-   display: none;
+.toc tbody,
+#toc tbody {
+   border: thin solid #aaa;
 }
+
+.toc li,
+#toc li {
+   list-style: none;
+}
+
+.toc #toctitle,
+#toc #toctitle {
+   text-align: center;
+}
+
+.toc h2,
+#toc h2 {
+   margin-top: 0em;
+   display: inline;
+}
+
+.toc td,
+#toc td {
+   padding: 0.25em 1em;
+}
+
 .subtitle {
margin-bottom: 1em;
font-size: 0.875em;

-- 
To view, visit https://gerrit.wikimedia.org/r/92297
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieafc8068bccfeee011bb5e95a00d1d322d984bba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Release v1.3 - change (mediawiki...erudite)

2013-10-11 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Release v1.3
..


Release v1.3

Change-Id: I2356c764f41d55fcabab046a3d505724b97f6cca
---
M erudite.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Njw: Verified; Looks good to me, approved



diff --git a/erudite.php b/erudite.php
index d7a2cff..db63d6b 100644
--- a/erudite.php
+++ b/erudite.php
@@ -17,7 +17,7 @@
'name' => 'Erudite',
'url' => 'https://www.mediawiki.org/wiki/Skin:Erudite',
'author' => array( 'Nick White', 'Matt Wiebe', 'Colin Andrew Ferm' ),
-   'version' => '1.2.1',
+   'version' => '1.3',
'descriptionmsg' => 'erudite-desc',
 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/89195
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2356c764f41d55fcabab046a3d505724b97f6cca
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Release v1.3 - change (mediawiki...erudite)

2013-10-11 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/89195


Change subject: Release v1.3
..

Release v1.3

Change-Id: I2356c764f41d55fcabab046a3d505724b97f6cca
---
M erudite.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/95/89195/1

diff --git a/erudite.php b/erudite.php
index d7a2cff..db63d6b 100644
--- a/erudite.php
+++ b/erudite.php
@@ -17,7 +17,7 @@
'name' => 'Erudite',
'url' => 'https://www.mediawiki.org/wiki/Skin:Erudite',
'author' => array( 'Nick White', 'Matt Wiebe', 'Colin Andrew Ferm' ),
-   'version' => '1.2.1',
+   'version' => '1.3',
'descriptionmsg' => 'erudite-desc',
 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/89195
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2356c764f41d55fcabab046a3d505724b97f6cca
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Reduce the global line height from 1.5 to 1.4 - change (mediawiki...erudite)

2013-10-11 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/89171


Change subject: Reduce the global line height from 1.5 to 1.4
..

Reduce the global line height from 1.5 to 1.4

Change-Id: Iba27cc572a8c34ab7ec95b44d40124048471b919
---
M assets/erudite.css
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/71/89171/1

diff --git a/assets/erudite.css b/assets/erudite.css
index 2c793c2..bdaa6c3 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -41,7 +41,7 @@
 /* Typography base */
 body {
font-family: constantia, 'hoefler text', 'palatino linotype', serif;
-   line-height: 1.5;
+   line-height: 1.4;
background: #fafafa;
color: #33;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/89171
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba27cc572a8c34ab7ec95b44d40124048471b919
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add border to message area to ensure it lines up with the bo... - change (mediawiki...erudite)

2013-10-11 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/89167


Change subject: Add border to message area to ensure it lines up with the 
border above and below
..

Add border to message area to ensure it lines up with the border above and below

Change-Id: I849ad01ae93513bb0872e44c13988df315de8887
---
M assets/erudite.css
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/67/89167/1

diff --git a/assets/erudite.css b/assets/erudite.css
index 2c793c2..9d13419 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -523,6 +523,10 @@
color: #ff;
background-color: #66;
padding: 0.75em 0 0.25em;
+   border-left-style: solid;
+   border-right-style: solid;
+   border-color: #66;
+   border-width: thin;
 }
 
 .message p, .message div {

-- 
To view, visit https://gerrit.wikimedia.org/r/89167
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I849ad01ae93513bb0872e44c13988df315de8887
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Don't repeat subtitle, and make very minor style improvement... - change (mediawiki...erudite)

2013-10-11 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/89165


Change subject: Don't repeat subtitle, and make very minor style improvements 
in it
..

Don't repeat subtitle, and make very minor style improvements in it

Change-Id: I542d04e0b528b3135545c8bed5b3c561851ffe7e
---
M Erudite.skin.php
M assets/erudite.css
2 files changed, 6 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/65/89165/1

diff --git a/Erudite.skin.php b/Erudite.skin.php
index 271f812..e45d58e 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -86,7 +86,7 @@
?>

text( 
'sitename' ); ?>
-   msg( 'tagline' ) 
?>
+   msg( 'tagline' ) ?>

 

@@ -107,7 +107,7 @@
 

data[$msg] ) {
echo "";
$this->html( $msg );
@@ -122,7 +122,7 @@

html( 
'title' ); ?>
data['subtitle'] ) { ?>
-   html( 'subtitle' ) ?>
+   html( 'subtitle' ) ?>

 

diff --git a/assets/erudite.css b/assets/erudite.css
index 2c793c2..afc99c9 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -162,7 +162,7 @@
text-decoration: none;
 }
 
-#siteSubtitle {
+#tagline {
font-size: 0.875em;
color: #ff;
 }
@@ -359,9 +359,8 @@
 #toc {
display: none;
 }
-span.entry-sub-title {
-   margin-left: 1em;
-   margin-bottom: 2em;
+.subtitle {
+   margin-bottom: 1em;
font-size: 0.875em;
font-style: italic;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/89165
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I542d04e0b528b3135545c8bed5b3c561851ffe7e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Ensure printfooter isn't affected by floats in content - change (mediawiki...erudite)

2013-10-11 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Ensure printfooter isn't affected by floats in content
..


Ensure printfooter isn't affected by floats in content

Change-Id: I54c11dce0237faf06d7fff12561a15bcc4f20473
---
M assets/print.css
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Njw: Verified; Looks good to me, approved



diff --git a/assets/print.css b/assets/print.css
index 697ef0f..1ecadbe 100644
--- a/assets/print.css
+++ b/assets/print.css
@@ -6,7 +6,8 @@
display:none;
 }
 
-/* Ensure footer text with URL isn't justified */
+/* Ensure footer text with URL isn't justified or affected by floats */
 .printfooter {
text-align: left;
+   clear: both;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/89157
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I54c11dce0237faf06d7fff12561a15bcc4f20473
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Ensure printfooter isn't affected by floats in content - change (mediawiki...erudite)

2013-10-11 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/89157


Change subject: Ensure printfooter isn't affected by floats in content
..

Ensure printfooter isn't affected by floats in content

Change-Id: I54c11dce0237faf06d7fff12561a15bcc4f20473
---
M assets/print.css
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/57/89157/1

diff --git a/assets/print.css b/assets/print.css
index 697ef0f..1ecadbe 100644
--- a/assets/print.css
+++ b/assets/print.css
@@ -6,7 +6,8 @@
display:none;
 }
 
-/* Ensure footer text with URL isn't justified */
+/* Ensure footer text with URL isn't justified or affected by floats */
 .printfooter {
text-align: left;
+   clear: both;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/89157
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I54c11dce0237faf06d7fff12561a15bcc4f20473
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Several style updates - change (mediawiki...erudite)

2013-09-02 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Several style updates
..


Several style updates

- add border to content
- tighten up menu layout
- ensure empty #entry-meta won't take up any space

Change-Id: Ibdefdf5c88184761a01f21f4bb047fb311992cb1
---
M assets/erudite.css
M assets/erudite60em.css
2 files changed, 16 insertions(+), 9 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/assets/erudite.css b/assets/erudite.css
index f639e35..2c793c2 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -16,13 +16,26 @@
 
 
 /* Use dark stripes around edge to focus on content */
-div#wrapper {
+#wrapper {
/* @embed */
background: #fafafa url(images/stripes-dark.png);
 }
 
-div#container {
+#container {
background: white;
+   border-left-style: solid;
+   border-right-style: solid;
+   border-color: #ccc;
+   border-width: thin;
+}
+
+/* Add borders so the sides line up with #container */
+#access {
+   border-left-style: solid;
+   border-right-style: solid;
+   border-color: #333;
+   border-color: rgba(50, 50, 50, 0.7);
+   border-width: thin;
 }
 
 /* Typography base */
@@ -156,10 +169,9 @@
 
 /* Menu */
 #menu {
-   margin: 1.5em 0 -0.625em;
+   margin: 1em 0 -0.625em;
overflow: hidden;
padding: 0.75em 2em 0.75em 3.75em;
-   border-top: thin solid #66;
background: #33;
background: rgba(50, 50, 50, 0.7);
 }
@@ -321,7 +333,6 @@
float: right;
padding-left: 1em;
margin-left: 1em;
-   margin-bottom: 0.625em;
border-left: thin solid #aa;
 }
 
diff --git a/assets/erudite60em.css b/assets/erudite60em.css
index 9ba824c..993b501 100644
--- a/assets/erudite60em.css
+++ b/assets/erudite60em.css
@@ -9,7 +9,3 @@
 #content {
padding: 1em 2em 0em;
 }
-
-#menu {
-   margin-top: 1em;
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/82238
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibdefdf5c88184761a01f21f4bb047fb311992cb1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Several style updates - change (mediawiki...erudite)

2013-09-02 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/82238


Change subject: Several style updates
..

Several style updates

- add border to content
- tighten up menu layout
- ensure empty #entry-meta won't take up any space

Change-Id: Ibdefdf5c88184761a01f21f4bb047fb311992cb1
---
M assets/erudite.css
M assets/erudite60em.css
2 files changed, 16 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/38/82238/1

diff --git a/assets/erudite.css b/assets/erudite.css
index f639e35..2c793c2 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -16,13 +16,26 @@
 
 
 /* Use dark stripes around edge to focus on content */
-div#wrapper {
+#wrapper {
/* @embed */
background: #fafafa url(images/stripes-dark.png);
 }
 
-div#container {
+#container {
background: white;
+   border-left-style: solid;
+   border-right-style: solid;
+   border-color: #ccc;
+   border-width: thin;
+}
+
+/* Add borders so the sides line up with #container */
+#access {
+   border-left-style: solid;
+   border-right-style: solid;
+   border-color: #333;
+   border-color: rgba(50, 50, 50, 0.7);
+   border-width: thin;
 }
 
 /* Typography base */
@@ -156,10 +169,9 @@
 
 /* Menu */
 #menu {
-   margin: 1.5em 0 -0.625em;
+   margin: 1em 0 -0.625em;
overflow: hidden;
padding: 0.75em 2em 0.75em 3.75em;
-   border-top: thin solid #66;
background: #33;
background: rgba(50, 50, 50, 0.7);
 }
@@ -321,7 +333,6 @@
float: right;
padding-left: 1em;
margin-left: 1em;
-   margin-bottom: 0.625em;
border-left: thin solid #aa;
 }
 
diff --git a/assets/erudite60em.css b/assets/erudite60em.css
index 9ba824c..993b501 100644
--- a/assets/erudite60em.css
+++ b/assets/erudite60em.css
@@ -9,7 +9,3 @@
 #content {
padding: 1em 2em 0em;
 }
-
-#menu {
-   margin-top: 1em;
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/82238
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibdefdf5c88184761a01f21f4bb047fb311992cb1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix overlap of headings and table for Special:SpecialPages - change (mediawiki...erudite)

2013-09-02 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Fix overlap of headings and table for Special:SpecialPages
..


Fix overlap of headings and table for Special:SpecialPages

Change-Id: I6e1b27bb10968416d1ada4b5eaa30d954e18f821
---
M assets/erudite.css
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/assets/erudite.css b/assets/erudite.css
index d4edcd5..f639e35 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -470,6 +470,10 @@
border: thin solid #fafafa;
 }
 
+table.mw-specialpages-table {
+   margin-top: 0;
+}
+
 /* Category and Special Page lists */
 #mw-pages ul,
 #mw-subcategories ul,

-- 
To view, visit https://gerrit.wikimedia.org/r/75580
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6e1b27bb10968416d1ada4b5eaa30d954e18f821
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix overlap of headings and table for Special:SpecialPages - change (mediawiki...erudite)

2013-07-24 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/75580


Change subject: Fix overlap of headings and table for Special:SpecialPages
..

Fix overlap of headings and table for Special:SpecialPages

Change-Id: I6e1b27bb10968416d1ada4b5eaa30d954e18f821
---
M assets/erudite.css
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/80/75580/1

diff --git a/assets/erudite.css b/assets/erudite.css
index d4edcd5..f639e35 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -470,6 +470,10 @@
border: thin solid #fafafa;
 }
 
+table.mw-specialpages-table {
+   margin-top: 0;
+}
+
 /* Category and Special Page lists */
 #mw-pages ul,
 #mw-subcategories ul,

-- 
To view, visit https://gerrit.wikimedia.org/r/75580
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e1b27bb10968416d1ada4b5eaa30d954e18f821
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Release 1.2.1 Set initial-scale in the viewport, for iOS bro... - change (mediawiki...erudite)

2013-07-18 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Release 1.2.1 Set initial-scale in the viewport, for iOS 
browsers.
..


Release 1.2.1 Set initial-scale in the viewport, for iOS browsers.

Change-Id: Iaff8c5b6f7f1ab572b68ac72b97d8fd97915a84d
---
M Erudite.skin.php
M erudite.php
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Erudite.skin.php b/Erudite.skin.php
index e536e3d..271f812 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -18,7 +18,7 @@
 * desktop dimensions, so they won't downscale and will instead 
respect
 * things like CSS's @media rules */
$out->addHeadItem( 'viewport',
-   ''
+   ''
);
}
 
diff --git a/erudite.php b/erudite.php
index 93ab4ea..d7a2cff 100644
--- a/erudite.php
+++ b/erudite.php
@@ -17,7 +17,7 @@
'name' => 'Erudite',
'url' => 'https://www.mediawiki.org/wiki/Skin:Erudite',
'author' => array( 'Nick White', 'Matt Wiebe', 'Colin Andrew Ferm' ),
-   'version' => '1.2',
+   'version' => '1.2.1',
'descriptionmsg' => 'erudite-desc',
 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/74348
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaff8c5b6f7f1ab572b68ac72b97d8fd97915a84d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Release 1.2.1 Set initial-scale in the viewport, for iOS bro... - change (mediawiki...erudite)

2013-07-18 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/74348


Change subject: Release 1.2.1 Set initial-scale in the viewport, for iOS 
browsers.
..

Release 1.2.1 Set initial-scale in the viewport, for iOS browsers.

Change-Id: Iaff8c5b6f7f1ab572b68ac72b97d8fd97915a84d
---
M Erudite.skin.php
M erudite.php
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/48/74348/1

diff --git a/Erudite.skin.php b/Erudite.skin.php
index e536e3d..271f812 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -18,7 +18,7 @@
 * desktop dimensions, so they won't downscale and will instead 
respect
 * things like CSS's @media rules */
$out->addHeadItem( 'viewport',
-   ''
+   ''
);
}
 
diff --git a/erudite.php b/erudite.php
index 93ab4ea..d7a2cff 100644
--- a/erudite.php
+++ b/erudite.php
@@ -17,7 +17,7 @@
'name' => 'Erudite',
'url' => 'https://www.mediawiki.org/wiki/Skin:Erudite',
'author' => array( 'Nick White', 'Matt Wiebe', 'Colin Andrew Ferm' ),
-   'version' => '1.2',
+   'version' => '1.2.1',
'descriptionmsg' => 'erudite-desc',
 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/74348
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaff8c5b6f7f1ab572b68ac72b97d8fd97915a84d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Release v1.2 - change (mediawiki...erudite)

2013-07-18 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/74347


Change subject: Release v1.2
..

Release v1.2

Change-Id: I465675e355a3eb62929a1c53a38f2a31404d548e
---
M erudite.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/47/74347/1

diff --git a/erudite.php b/erudite.php
index 2140fc7..93ab4ea 100644
--- a/erudite.php
+++ b/erudite.php
@@ -17,7 +17,7 @@
'name' => 'Erudite',
'url' => 'https://www.mediawiki.org/wiki/Skin:Erudite',
'author' => array( 'Nick White', 'Matt Wiebe', 'Colin Andrew Ferm' ),
-   'version' => '1.1',
+   'version' => '1.2',
'descriptionmsg' => 'erudite-desc',
 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/74347
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I465675e355a3eb62929a1c53a38f2a31404d548e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Use separate files for max-width @media rules - change (mediawiki...erudite)

2013-07-18 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Use separate files for max-width @media rules
..


Use separate files for max-width @media rules

It turns out some browsers don't like nested @media rules, including
the default browsers on Android and iOS. So use separate files for
them instead.

Change-Id: I532a726cb5326937a8a5472b3abb9b9811ba8e7d
---
M assets/erudite.css
A assets/erudite20em.css
A assets/erudite40em.css
A assets/erudite60em.css
A assets/erudite66em.css
M erudite.php
6 files changed, 70 insertions(+), 79 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/assets/erudite.css b/assets/erudite.css
index aedff6d..986e4ac 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -564,82 +564,3 @@
 body.action-edit #wpTextbox1 {
clear: none;
 }
-
-/* Adjustments for smaller browser viewports */
-@media (max-width: 66em) {
-   /* The top menu is likely to start wrapping, so reduce padding
-* and add a separator */
-   #menu {
-   padding: 0.7em 1em 0.45em;
-   background: rgba(50, 50, 50, 1.0);
-   }
-
-   #menu li {
-   border-right: thin solid #66;
-   padding: 0em 1em;
-   margin-bottom: 0.3em;
-   margin-right: 0em;
-   }
-
-   #menu li:last-child {
-   border-right: none;
-   }
-
-   #access {
-   width: 100%;
-   }
-}
-
-@media (max-width: 60em) {
-   /* Some of the padding is best dispatched with */
-   #container,
-   #header,
-   #footer-wrap-inner,
-   .message {
-   width: 100%;
-   }
-
-   #content {
-   padding: 1em 2em 0em;
-   }
-
-   #menu {
-   margin-top: 1em;
-   }
-}
-
-@media (max-width: 40em) {
-   /* Reduce padding a bit further */
-   #content {
-   padding: 1em 1em 0em;
-   }
-
-   /* Stack footer columns */
-   .footer {
-   display: block;
-   float: none;
-   width: 90%;
-   }
-}
-
-@media (max-width: 20em) {
-   #header h1 {
-   font-size: 1.75em;
-   }
-
-   #menu {
-   margin-top: 0.5em;
-   }
-
-   /* Stack top menu items */
-   #menu li {
-   float: none !important;
-   border: none;
-   padding: 0em;
-   }
-
-   /* Disable text justification (user preference) */
-   #article, #bodyContent, #mw_content {
-   text-align: left !important;
-   }
-}
diff --git a/assets/erudite20em.css b/assets/erudite20em.css
new file mode 100644
index 000..9cb5953
--- /dev/null
+++ b/assets/erudite20em.css
@@ -0,0 +1,19 @@
+#header h1 {
+   font-size: 1.75em;
+}
+
+#menu {
+   margin-top: 0.5em;
+}
+
+/* Stack top menu items */
+#menu li {
+   float: none !important;
+   border: none;
+   padding: 0em;
+}
+
+/* Disable text justification (user preference) */
+#article, #bodyContent, #mw_content {
+   text-align: left !important;
+}
diff --git a/assets/erudite40em.css b/assets/erudite40em.css
new file mode 100644
index 000..ffae547
--- /dev/null
+++ b/assets/erudite40em.css
@@ -0,0 +1,11 @@
+/* Reduce padding a bit further */
+#content {
+   padding: 1em 1em 0em;
+}
+
+/* Stack footer columns */
+.footer {
+   display: block;
+   float: none;
+   width: 90%;
+}
diff --git a/assets/erudite60em.css b/assets/erudite60em.css
new file mode 100644
index 000..9ba824c
--- /dev/null
+++ b/assets/erudite60em.css
@@ -0,0 +1,15 @@
+/* Some of the padding is best dispatched with */
+#container,
+#header,
+#footer-wrap-inner,
+.message {
+   width: 100%;
+}
+
+#content {
+   padding: 1em 2em 0em;
+}
+
+#menu {
+   margin-top: 1em;
+}
diff --git a/assets/erudite66em.css b/assets/erudite66em.css
new file mode 100644
index 000..3c3bda1
--- /dev/null
+++ b/assets/erudite66em.css
@@ -0,0 +1,21 @@
+/* The top menu is likely to start wrapping, so reduce padding
+ * and add a separator */
+#menu {
+   padding: 0.7em 1em 0.45em;
+   background: rgba(50, 50, 50, 1.0);
+}
+
+#menu li {
+   border-right: thin solid #66;
+   padding: 0em 1em;
+   margin-bottom: 0.3em;
+   margin-right: 0em;
+}
+
+#menu li:last-child {
+   border-right: none;
+}
+
+#access {
+   width: 100%;
+}
diff --git a/erudite.php b/erudite.php
index 25b6ab2..2140fc7 100644
--- a/erudite.php
+++ b/erudite.php
@@ -29,6 +29,10 @@
'styles' => array(
'erudite/assets/cssreset.css' => array( 'media' => 'screen' ),
'erudite/assets/erudite.css' => array( 'media' => 'screen' ),
+   'erudite/assets/erudite66em.css' => array( 'media' => 'screen 
and (max-width: 66em)' ),
+   'erudite/assets/erudite60em.css' => array( 'media' => 'screen 
and

[MediaWiki-commits] [Gerrit] Improve padding of message area - change (mediawiki...erudite)

2013-07-18 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Improve padding of message area
..


Improve padding of message area

- Reduce bottom padding of message area
- Ensure content directly in divs is padded appropriately

Change-Id: Ifb0ca6b653ed29f69b43b86ab77113840cb69036
---
M assets/erudite.css
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/assets/erudite.css b/assets/erudite.css
index aedff6d..eeadd8b 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -507,10 +507,10 @@
 .message {
color: #ff;
background-color: #66;
-   padding: 0.75em 0;
+   padding: 0.75em 0 0.25em;
 }
 
-.message p {
+.message p, .message div {
padding: 0 1em;
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/72490
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb0ca6b653ed29f69b43b86ab77113840cb69036
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Use separate files for max-width @media rules - change (mediawiki...erudite)

2013-07-18 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/74346


Change subject: Use separate files for max-width @media rules
..

Use separate files for max-width @media rules

It turns out some browsers don't like nested @media rules, including
the default browsers on Android and iOS. So use separate files for
them instead.

Change-Id: I532a726cb5326937a8a5472b3abb9b9811ba8e7d
---
M assets/erudite.css
A assets/erudite20em.css
A assets/erudite40em.css
A assets/erudite60em.css
A assets/erudite66em.css
M erudite.php
6 files changed, 70 insertions(+), 79 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/46/74346/1

diff --git a/assets/erudite.css b/assets/erudite.css
index aedff6d..986e4ac 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -564,82 +564,3 @@
 body.action-edit #wpTextbox1 {
clear: none;
 }
-
-/* Adjustments for smaller browser viewports */
-@media (max-width: 66em) {
-   /* The top menu is likely to start wrapping, so reduce padding
-* and add a separator */
-   #menu {
-   padding: 0.7em 1em 0.45em;
-   background: rgba(50, 50, 50, 1.0);
-   }
-
-   #menu li {
-   border-right: thin solid #66;
-   padding: 0em 1em;
-   margin-bottom: 0.3em;
-   margin-right: 0em;
-   }
-
-   #menu li:last-child {
-   border-right: none;
-   }
-
-   #access {
-   width: 100%;
-   }
-}
-
-@media (max-width: 60em) {
-   /* Some of the padding is best dispatched with */
-   #container,
-   #header,
-   #footer-wrap-inner,
-   .message {
-   width: 100%;
-   }
-
-   #content {
-   padding: 1em 2em 0em;
-   }
-
-   #menu {
-   margin-top: 1em;
-   }
-}
-
-@media (max-width: 40em) {
-   /* Reduce padding a bit further */
-   #content {
-   padding: 1em 1em 0em;
-   }
-
-   /* Stack footer columns */
-   .footer {
-   display: block;
-   float: none;
-   width: 90%;
-   }
-}
-
-@media (max-width: 20em) {
-   #header h1 {
-   font-size: 1.75em;
-   }
-
-   #menu {
-   margin-top: 0.5em;
-   }
-
-   /* Stack top menu items */
-   #menu li {
-   float: none !important;
-   border: none;
-   padding: 0em;
-   }
-
-   /* Disable text justification (user preference) */
-   #article, #bodyContent, #mw_content {
-   text-align: left !important;
-   }
-}
diff --git a/assets/erudite20em.css b/assets/erudite20em.css
new file mode 100644
index 000..9cb5953
--- /dev/null
+++ b/assets/erudite20em.css
@@ -0,0 +1,19 @@
+#header h1 {
+   font-size: 1.75em;
+}
+
+#menu {
+   margin-top: 0.5em;
+}
+
+/* Stack top menu items */
+#menu li {
+   float: none !important;
+   border: none;
+   padding: 0em;
+}
+
+/* Disable text justification (user preference) */
+#article, #bodyContent, #mw_content {
+   text-align: left !important;
+}
diff --git a/assets/erudite40em.css b/assets/erudite40em.css
new file mode 100644
index 000..ffae547
--- /dev/null
+++ b/assets/erudite40em.css
@@ -0,0 +1,11 @@
+/* Reduce padding a bit further */
+#content {
+   padding: 1em 1em 0em;
+}
+
+/* Stack footer columns */
+.footer {
+   display: block;
+   float: none;
+   width: 90%;
+}
diff --git a/assets/erudite60em.css b/assets/erudite60em.css
new file mode 100644
index 000..9ba824c
--- /dev/null
+++ b/assets/erudite60em.css
@@ -0,0 +1,15 @@
+/* Some of the padding is best dispatched with */
+#container,
+#header,
+#footer-wrap-inner,
+.message {
+   width: 100%;
+}
+
+#content {
+   padding: 1em 2em 0em;
+}
+
+#menu {
+   margin-top: 1em;
+}
diff --git a/assets/erudite66em.css b/assets/erudite66em.css
new file mode 100644
index 000..3c3bda1
--- /dev/null
+++ b/assets/erudite66em.css
@@ -0,0 +1,21 @@
+/* The top menu is likely to start wrapping, so reduce padding
+ * and add a separator */
+#menu {
+   padding: 0.7em 1em 0.45em;
+   background: rgba(50, 50, 50, 1.0);
+}
+
+#menu li {
+   border-right: thin solid #66;
+   padding: 0em 1em;
+   margin-bottom: 0.3em;
+   margin-right: 0em;
+}
+
+#menu li:last-child {
+   border-right: none;
+}
+
+#access {
+   width: 100%;
+}
diff --git a/erudite.php b/erudite.php
index 25b6ab2..2140fc7 100644
--- a/erudite.php
+++ b/erudite.php
@@ -29,6 +29,10 @@
'styles' => array(
'erudite/assets/cssreset.css' => array( 'media' => 'screen' ),
'erudite/assets/erudite.css' => array( 'media' => 'screen' ),
+   'erudite/assets/erudite66em.css' => array( 'media' => 'screen 
and (max-width: 66em)' ),
+   'erudite/assets/erud

[MediaWiki-commits] [Gerrit] Reduce bottom padding of message area - change (mediawiki...erudite)

2013-07-08 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/72490


Change subject: Reduce bottom padding of message area
..

Reduce bottom padding of message area

Change-Id: Ifb0ca6b653ed29f69b43b86ab77113840cb69036
---
M assets/erudite.css
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/90/72490/1

diff --git a/assets/erudite.css b/assets/erudite.css
index aedff6d..8e39e3f 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -507,7 +507,7 @@
 .message {
color: #ff;
background-color: #66;
-   padding: 0.75em 0;
+   padding: 0.75em 0 0.25em;
 }
 
 .message p {

-- 
To view, visit https://gerrit.wikimedia.org/r/72490
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb0ca6b653ed29f69b43b86ab77113840cb69036
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Release v1.1 - change (mediawiki...erudite)

2013-07-04 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/71987


Change subject: Release v1.1
..

Release v1.1

Change-Id: I4a2900bd3847335ed22f58a7e8d149e4aec8b4f1
---
M erudite.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/87/71987/1

diff --git a/erudite.php b/erudite.php
index 1b36bc3..25b6ab2 100644
--- a/erudite.php
+++ b/erudite.php
@@ -17,7 +17,7 @@
'name' => 'Erudite',
'url' => 'https://www.mediawiki.org/wiki/Skin:Erudite',
'author' => array( 'Nick White', 'Matt Wiebe', 'Colin Andrew Ferm' ),
-   'version' => '1.0',
+   'version' => '1.1',
'descriptionmsg' => 'erudite-desc',
 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/71987
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a2900bd3847335ed22f58a7e8d149e4aec8b4f1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Release v1.1 - change (mediawiki...erudite)

2013-07-04 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Release v1.1
..


Release v1.1

Change-Id: I4a2900bd3847335ed22f58a7e8d149e4aec8b4f1
---
M erudite.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/erudite.php b/erudite.php
index 1b36bc3..25b6ab2 100644
--- a/erudite.php
+++ b/erudite.php
@@ -17,7 +17,7 @@
'name' => 'Erudite',
'url' => 'https://www.mediawiki.org/wiki/Skin:Erudite',
'author' => array( 'Nick White', 'Matt Wiebe', 'Colin Andrew Ferm' ),
-   'version' => '1.0',
+   'version' => '1.1',
'descriptionmsg' => 'erudite-desc',
 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/71987
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4a2900bd3847335ed22f58a7e8d149e4aec8b4f1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Several CSS improvements - change (mediawiki...erudite)

2013-07-04 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/71984


Change subject: Several CSS improvements
..

Several CSS improvements

- Use thin instead of 1px for border-width
- Ensure site name isn't underlined if hovered
- Use em rather than px even around images
- Hide colon in categories section at the bottom of pages
- Remove unneeded !important entries

Change-Id: Iad9ebed78525e75d4d61bdef0884efdb2c338bcd
---
M assets/erudite.css
1 file changed, 22 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/84/71984/1

diff --git a/assets/erudite.css b/assets/erudite.css
index 9e19a18..aedff6d 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -146,6 +146,7 @@
 
 #header a {
color: #ff;
+   text-decoration: none;
 }
 
 #siteSubtitle {
@@ -158,7 +159,7 @@
margin: 1.5em 0 -0.625em;
overflow: hidden;
padding: 0.75em 2em 0.75em 3.75em;
-   border-top: 1px solid #66;
+   border-top: thin solid #66;
background: #33;
background: rgba(50, 50, 50, 0.7);
 }
@@ -206,7 +207,7 @@
 }
 
 .footer h3 {
-   border-bottom: 1px solid #66;
+   border-bottom: thin solid #66;
margin-bottom: 0.2em;
font-size: 1.25em;
text-transform: uppercase;
@@ -217,7 +218,7 @@
 .footer a.new {
color: #ff;
text-decoration: none;
-   border-bottom: 1px solid #99;
+   border-bottom: thin solid #99;
 }
 
 .footer a:hover,
@@ -253,11 +254,9 @@
 hr {
/* @embed */
background: url(images/hr.png) center no-repeat;
-   height: 24px;
-   margin: 0 0 10px;
+   height: 1.5em;
display: block;
-   border-width: 0px;
-   border-style: none !important;
+   border: none;
 }
 
 .entry-title {
@@ -309,7 +308,7 @@
 
 /* Main Links */
 .entry-content a {
-   border-bottom: 1px solid #aa;
+   border-bottom: thin solid #aa;
 }
 
 .entry-content a:hover {
@@ -323,7 +322,7 @@
padding-left: 1em;
margin-left: 1em;
margin-bottom: 0.625em;
-   border-left: 1px solid #aa;
+   border-left: thin solid #aa;
 }
 
 .entry-meta span {
@@ -368,8 +367,8 @@
 
 /* Images */
 .entry-content img {
-   padding: 4px;
-   margin-bottom: 6px;
+   padding: 0.25em;
+   margin-bottom: 0.5em;
 }
 
 .entry-content .gallery a {
@@ -408,8 +407,8 @@
 }
 
 div.thumbinner {
-   border: 1px solid #cc;
-   padding: 3px !important;
+   border: thin solid #cc;
+   padding: 0.2em;
background-color: #f9f9f9;
font-size: 0.875em;
text-align: center;
@@ -418,8 +417,8 @@
 
 img.thumbimage {
border: none;
-   padding: 0px;
-   margin: 0px;
+   padding: 0;
+   margin: 0;
 }
 
 .thumbinner > a {
@@ -429,20 +428,17 @@
 .thumbcaption {
border: none;
text-align: left;
-   padding: 0.1875em !important;
+   padding: 0.2em;
 }
 
 div.magnify {
float: right;
-   border: none !important;
-   background: none !important;
 }
 
 div.magnify a,
 div.magnify img {
display: block;
-   border: none !important;
-   background: none !important;
+   border: none;
 }
 
 div.tright {
@@ -458,7 +454,7 @@
 }
 
 img.thumbborder {
-   border: 1px solid #aa;
+   border: thin solid #aa;
 }
 
 .hiddenStructure {
@@ -471,7 +467,7 @@
 
 table.gallery td {
background-color: #fafafa;
-   border: 2px solid #fafafa;
+   border: thin solid #fafafa;
 }
 
 /* Category and Special Page lists */
@@ -487,6 +483,8 @@
background: #66;
height: 100%;
overflow: hidden;
+   /* Hide the colon after "Category" */
+   color: #66;
 }
 
 #catlinks a {
@@ -498,7 +496,7 @@
 }
 
 .catlinks li:first-child {
-   border-left: 1px solid #aa;
+   border-left: thin solid #aa;
 }
 
 .catlinks li {
@@ -577,7 +575,7 @@
}
 
#menu li {
-   border-right: 1px solid #66;
+   border-right: thin solid #66;
padding: 0em 1em;
margin-bottom: 0.3em;
margin-right: 0em;

-- 
To view, visit https://gerrit.wikimedia.org/r/71984
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad9ebed78525e75d4d61bdef0884efdb2c338bcd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Simplify CSS a tiny bit - change (mediawiki...erudite)

2013-07-04 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/71975


Change subject: Simplify CSS a tiny bit
..

Simplify CSS a tiny bit

Change-Id: I61cf0e6c0409985f0af4ddbbf53a76615246332d
---
M assets/print.css
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/75/71975/1

diff --git a/assets/print.css b/assets/print.css
index e116de9..697ef0f 100644
--- a/assets/print.css
+++ b/assets/print.css
@@ -8,5 +8,5 @@
 
 /* Ensure footer text with URL isn't justified */
 .printfooter {
-   text-align: left !important;
+   text-align: left;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/71975
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I61cf0e6c0409985f0af4ddbbf53a76615246332d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Improve comments throughout - change (mediawiki...erudite)

2013-07-04 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/71970


Change subject: Improve comments throughout
..

Improve comments throughout

Change-Id: I2c9f2c3d5a59511ba43e4dd75d46da18b185110b
---
M Erudite.skin.php
M assets/erudite.css
M assets/print.css
M erudite.php
4 files changed, 32 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/70/71970/1

diff --git a/Erudite.skin.php b/Erudite.skin.php
index 7486a63..e536e3d 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -1,7 +1,6 @@
 addHeadItem( 'viewport',
''
);
@@ -32,6 +34,10 @@
 class EruditeTemplate extends BaseTemplate {
/**
 * Like msgWiki() but it ensures edit section links are never shown.
+*
+* Needed for Mediawiki 1.19 & 1.20 due to bug 36975:
+* https://bugzilla.wikimedia.org/show_bug.cgi?id=36975
+*
 * @param $message Name of wikitext message to return
 */
function msgWikiNoEdit( $message ) {
diff --git a/assets/erudite.css b/assets/erudite.css
index 61b36fe..9e19a18 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -16,16 +16,16 @@
 
 
 /* Use dark stripes around edge to focus on content */
-div#container {
-   background: white;
-}
-
 div#wrapper {
/* @embed */
background: #fafafa url(images/stripes-dark.png);
 }
 
-/* Typography Base */
+div#container {
+   background: white;
+}
+
+/* Typography base */
 body {
font-family: constantia, 'hoefler text', 'palatino linotype', serif;
line-height: 1.5;
@@ -33,7 +33,7 @@
color: #33;
 }
 
-/* use sans-serif font for headings and navigation */
+/* Use sans-serif font for headings and navigation */
 h1,
 h2,
 h3,
@@ -48,6 +48,13 @@
text-rendering: optimizeLegibility;
 }
 
+/* Set attractive monospace fonts */
+pre,
+code {
+   font-family: consolas, 'deja vu sans mono', 'lucida sans typewriter', 
monaco, monospace;
+}
+
+/* Headings */
 h1 {
font-size: 1.5em;
text-transform: uppercase;
@@ -100,11 +107,6 @@
 td > h5:first-child,
 td > h6:first-child {
margin-top: 0;
-}
-
-pre,
-code {
-   font-family: consolas, 'deja vu sans mono', 'lucida sans typewriter', 
monaco, monospace;
 }
 
 /* Links */
@@ -557,7 +559,7 @@
padding-bottom: 1.5em;
 }
 
-/* ensure edit form doesn't clear the right floated meta
+/* Ensure edit form doesn't clear the right floated meta
  * (.action-edit is selected so that preview content is cleared) */
 body.action-edit #editform,
 body.action-edit #toolbar,
@@ -565,9 +567,9 @@
clear: none;
 }
 
-/* adjustments for smaller browser viewports */
+/* Adjustments for smaller browser viewports */
 @media (max-width: 66em) {
-   /* top menu is likely to start wrapping, so reduce padding
+   /* The top menu is likely to start wrapping, so reduce padding
 * and add a separator */
#menu {
padding: 0.7em 1em 0.45em;
@@ -591,7 +593,7 @@
 }
 
 @media (max-width: 60em) {
-   /* some of the padding is best dispatched with */
+   /* Some of the padding is best dispatched with */
#container,
#header,
#footer-wrap-inner,
@@ -609,12 +611,12 @@
 }
 
 @media (max-width: 40em) {
-   /* shave padding back a bit further */
+   /* Reduce padding a bit further */
#content {
padding: 1em 1em 0em;
}
 
-   /* stack footer columns */
+   /* Stack footer columns */
.footer {
display: block;
float: none;
@@ -631,14 +633,14 @@
margin-top: 0.5em;
}
 
-   /* stack top menu items */
+   /* Stack top menu items */
#menu li {
float: none !important;
border: none;
padding: 0em;
}
 
-   /* disable text justification (user preference) */
+   /* Disable text justification (user preference) */
#article, #bodyContent, #mw_content {
text-align: left !important;
}
diff --git a/assets/print.css b/assets/print.css
index cc1e7a6..e116de9 100644
--- a/assets/print.css
+++ b/assets/print.css
@@ -1,3 +1,4 @@
+/* Hide navigation elements */
 #header-wrap,
 #mw-js-message,
 .entry-meta,
@@ -5,6 +6,7 @@
display:none;
 }
 
+/* Ensure footer text with URL isn't justified */
 .printfooter {
-   text-align: left;
+   text-align: left !important;
 }
diff --git a/erudite.php b/erudite.php
index df7e914..1b36bc3 100644
--- a/erudite.php
+++ b/erudite.php
@@ -4,9 +4,9 @@
  *
  * @file
  * @ingroup Skins
+ * @author Nick White
  * @author Matt Wiebe
  * @author Colin Andrew Ferm
- * @author Nick White
  * @license http://www.gnu.org/copyleft/gpl.html GNU General Public License 
2.0 or later
  */
 

-- 
To view, visit https://gerrit.wikimedia.org/r/71970

[MediaWiki-commits] [Gerrit] Remove unneeded header comment on erudite.css, and update co... - change (mediawiki...erudite)

2013-07-02 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Remove unneeded header comment on erudite.css, and update 
copyright to GPLv2 or later (after email confirmation with Matt Weibe that he 
was happy with that)
..


Remove unneeded header comment on erudite.css, and update copyright to GPLv2 or 
later (after email confirmation with Matt Weibe that he was happy with that)

Change-Id: I1e7e3b789fe0ac569963fbb87112df347e683fdb
---
M COPYING
M assets/erudite.css
2 files changed, 2 insertions(+), 10 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/COPYING b/COPYING
index 4648a48..7cf95ae 100644
--- a/COPYING
+++ b/COPYING
@@ -1,4 +1,5 @@
-This theme is released under the GPLv2. See below for the full license.
+This skin is released under the GPLv2 or any later version. See below for the
+full license.
 
 Copyright 2009-2013 Matt Wiebe, Nick White, Colin Andrew Ferm, Daniel Friesen
 
diff --git a/assets/erudite.css b/assets/erudite.css
index a64b2c5..66fa56d 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -1,12 +1,3 @@
-/*
- * Based on The Erudite WordPress theme by Soma Design
- * http://somadesign.ca/
- *
- * Licensed under the GPL 2.0
- * http://www.gnu.org/licenses/gpl-2.0.html
- *
- */
-
 /* Layout */
 #container,
 #header,

-- 
To view, visit https://gerrit.wikimedia.org/r/71620
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1e7e3b789fe0ac569963fbb87112df347e683fdb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Disable justification at very narrow widths - change (mediawiki...erudite)

2013-07-02 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Disable justification at very narrow widths
..


Disable justification at very narrow widths

Change-Id: I0f01d72a34ef4b5f141ef0e3808a7a2d49f141ef
---
M assets/erudite.css
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/assets/erudite.css b/assets/erudite.css
index a64b2c5..cd22aa5 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -646,4 +646,9 @@
border: none;
padding: 0em;
}
+
+   /* disable text justification (user preference) */
+   #article, #bodyContent, #mw_content {
+   text-align: left !important;
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/71619
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0f01d72a34ef4b5f141ef0e3808a7a2d49f141ef
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove unneeded header comment on erudite.css, and update co... - change (mediawiki...erudite)

2013-07-02 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/71620


Change subject: Remove unneeded header comment on erudite.css, and update 
copyright to GPLv2 or later (after email confirmation with Matt Weibe that he 
was happy with that)
..

Remove unneeded header comment on erudite.css, and update copyright to GPLv2 or 
later (after email confirmation with Matt Weibe that he was happy with that)

Change-Id: I1e7e3b789fe0ac569963fbb87112df347e683fdb
---
M COPYING
M assets/erudite.css
2 files changed, 2 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/20/71620/1

diff --git a/COPYING b/COPYING
index 4648a48..7cf95ae 100644
--- a/COPYING
+++ b/COPYING
@@ -1,4 +1,5 @@
-This theme is released under the GPLv2. See below for the full license.
+This skin is released under the GPLv2 or any later version. See below for the
+full license.
 
 Copyright 2009-2013 Matt Wiebe, Nick White, Colin Andrew Ferm, Daniel Friesen
 
diff --git a/assets/erudite.css b/assets/erudite.css
index a64b2c5..66fa56d 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -1,12 +1,3 @@
-/*
- * Based on The Erudite WordPress theme by Soma Design
- * http://somadesign.ca/
- *
- * Licensed under the GPL 2.0
- * http://www.gnu.org/licenses/gpl-2.0.html
- *
- */
-
 /* Layout */
 #container,
 #header,

-- 
To view, visit https://gerrit.wikimedia.org/r/71620
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e7e3b789fe0ac569963fbb87112df347e683fdb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Disable justification at very narrow widths - change (mediawiki...erudite)

2013-07-02 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/71619


Change subject: Disable justification at very narrow widths
..

Disable justification at very narrow widths

Change-Id: I0f01d72a34ef4b5f141ef0e3808a7a2d49f141ef
---
M assets/erudite.css
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/19/71619/1

diff --git a/assets/erudite.css b/assets/erudite.css
index a64b2c5..e2b3269 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -646,4 +646,9 @@
border: none;
padding: 0em;
}
+
+   /* disable text justification (user preference) */
+   #article, #bodyContent, #mw_content {
+   text-align: left;
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/71619
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f01d72a34ef4b5f141ef0e3808a7a2d49f141ef
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Use default mediawiki list formatting, and correct padding o... - change (mediawiki...erudite)

2013-06-18 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/69319


Change subject: Use default mediawiki list formatting, and correct padding of 
top menu items
..

Use default mediawiki list formatting, and correct padding of top menu items

Change-Id: Ib8ac831ba97f6d89b4a4be57354f9e7056905200
---
M assets/erudite.css
1 file changed, 2 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/19/69319/1

diff --git a/assets/erudite.css b/assets/erudite.css
index 7f8356b..70f9e8a 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -169,8 +169,7 @@
 #menu li {
display: block;
float: left;
-   margin-right: 2em;
-   margin-bottom: 0em;
+   margin: 0em 2em 0em 0em;
 }
 
 /* Footer */
@@ -296,11 +295,6 @@
padding-left: 3em;
 }
 
-li {
-   list-style-position: outside;
-   margin-left: 2em;
-}
-
 .center {
width: 100%;
text-align: center;
@@ -365,11 +359,8 @@
font-size: 0.875em;
 }
 
+sup.reference:target,
 ol.references > li:target {
-   background-color: #ddeeff;
-}
-
-sup.reference:target {
background-color: #ddeeff;
 }
 
@@ -564,12 +555,6 @@
 
 div#bodyContent {
padding-bottom: 1.5em;
-}
-
-/* don't give lists massive margins when in tds */
-.mw-content-ltr ul,
-.mw-content-rtl ul {
-   margin-left: 0em;
 }
 
 /* reduce h3 top margin in a table, so can be used as a table title */

-- 
To view, visit https://gerrit.wikimedia.org/r/69319
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib8ac831ba97f6d89b4a4be57354f9e7056905200
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Simplify CSS, and reduce header space slightly if not much s... - change (mediawiki...erudite)

2013-06-17 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Simplify CSS, and reduce header space slightly if not much space
..


Simplify CSS, and reduce header space slightly if not much space

Change-Id: Ieeb25d3fcdea1c918c47d0750ec01bbf2d819e84
---
M TODO
M assets/cssreset.css
M assets/erudite.css
3 files changed, 33 insertions(+), 37 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/TODO b/TODO
index 8a1f312..864315b 100644
--- a/TODO
+++ b/TODO
@@ -1,2 +1 @@
 Test that it works fine with ULS extension
-Use simpler CSS rules for main content, rather than children of .entry-content
diff --git a/assets/cssreset.css b/assets/cssreset.css
index e0b61b2..a2994b2 100644
--- a/assets/cssreset.css
+++ b/assets/cssreset.css
@@ -71,10 +71,6 @@
border-spacing: 0;
 }
 
-ol,ul {
-   list-style: none;
-}
-
 sup {
vertical-align: super;
 }
diff --git a/assets/erudite.css b/assets/erudite.css
index cfdcd06..7f8356b 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -170,6 +170,7 @@
display: block;
float: left;
margin-right: 2em;
+   margin-bottom: 0em;
 }
 
 /* Footer */
@@ -184,6 +185,15 @@
float: left;
width: 25%;
margin-left: 5%;
+}
+
+.footer li {
+   list-style: none;
+   margin: 0em;
+}
+
+.footer ul {
+   margin: 0em;
 }
 
 .footer .widget li {
@@ -228,6 +238,10 @@
font-size: 0.75em;
 }
 
+#footer p {
+   margin-bottom: 0em;
+}
+
 /* Content */
 #content-container {
position: relative;
@@ -250,49 +264,41 @@
margin: 0 0 0.5em;
 }
 
-.entry-content p,
-.entry-content li,
-.entry-content dt,
-.entry-content dd,
-.entry-content blockquote,
-.entry-content center {
+p,
+li,
+dt,
+dd,
+blockquote,
+center {
margin-bottom: 0.75em;
 }
 
-.entry-content table {
+table {
margin: 1em 0;
 }
 
-.entry-content td,
-.entry-content th {
+td,
+th {
padding: 0.125em 0.5em;
text-align: left;
 }
 
-.entry-content pre {
+pre {
font-size: 0.875em;
 }
 
-.entry-content legend {
+legend {
font-size: 0.875em;
text-align: center;
 }
 
-.entry-content blockquote {
+blockquote {
padding-left: 3em;
 }
 
-.entry-content ul li {
-   list-style: disc outside;
-}
-
-.entry-content ol li {
-   list-style: decimal outside;
-}
-
-.entry-content li ol,
-.entry-content li ul {
-   margin: 0.5em 0 0 0.5em;
+li {
+   list-style-position: outside;
+   margin-left: 2em;
 }
 
 .center {
@@ -347,15 +353,6 @@
 #toc {
display: none;
 }
-
-#bodyContent > ul > li {
-   margin-left: 1em;
-}
-
-div.entry-content li {
-   margin-left: 2em;
-}
-
 span.entry-sub-title {
margin-left: 1em;
margin-bottom: 2em;
@@ -625,6 +622,10 @@
#content {
padding: 1em 2em 0em;
}
+
+   #menu {
+   margin-top: 1em;
+   }
 }
 
 @media (max-width: 40em) {

-- 
To view, visit https://gerrit.wikimedia.org/r/69137
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieeb25d3fcdea1c918c47d0750ec01bbf2d819e84
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Simplify CSS, and reduce header space slightly if not much s... - change (mediawiki...erudite)

2013-06-17 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/69137


Change subject: Simplify CSS, and reduce header space slightly if not much space
..

Simplify CSS, and reduce header space slightly if not much space

Change-Id: Ieeb25d3fcdea1c918c47d0750ec01bbf2d819e84
---
M TODO
M assets/cssreset.css
M assets/erudite.css
3 files changed, 33 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/37/69137/1

diff --git a/TODO b/TODO
index 8a1f312..864315b 100644
--- a/TODO
+++ b/TODO
@@ -1,2 +1 @@
 Test that it works fine with ULS extension
-Use simpler CSS rules for main content, rather than children of .entry-content
diff --git a/assets/cssreset.css b/assets/cssreset.css
index e0b61b2..a2994b2 100644
--- a/assets/cssreset.css
+++ b/assets/cssreset.css
@@ -71,10 +71,6 @@
border-spacing: 0;
 }
 
-ol,ul {
-   list-style: none;
-}
-
 sup {
vertical-align: super;
 }
diff --git a/assets/erudite.css b/assets/erudite.css
index cfdcd06..7f8356b 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -170,6 +170,7 @@
display: block;
float: left;
margin-right: 2em;
+   margin-bottom: 0em;
 }
 
 /* Footer */
@@ -184,6 +185,15 @@
float: left;
width: 25%;
margin-left: 5%;
+}
+
+.footer li {
+   list-style: none;
+   margin: 0em;
+}
+
+.footer ul {
+   margin: 0em;
 }
 
 .footer .widget li {
@@ -228,6 +238,10 @@
font-size: 0.75em;
 }
 
+#footer p {
+   margin-bottom: 0em;
+}
+
 /* Content */
 #content-container {
position: relative;
@@ -250,49 +264,41 @@
margin: 0 0 0.5em;
 }
 
-.entry-content p,
-.entry-content li,
-.entry-content dt,
-.entry-content dd,
-.entry-content blockquote,
-.entry-content center {
+p,
+li,
+dt,
+dd,
+blockquote,
+center {
margin-bottom: 0.75em;
 }
 
-.entry-content table {
+table {
margin: 1em 0;
 }
 
-.entry-content td,
-.entry-content th {
+td,
+th {
padding: 0.125em 0.5em;
text-align: left;
 }
 
-.entry-content pre {
+pre {
font-size: 0.875em;
 }
 
-.entry-content legend {
+legend {
font-size: 0.875em;
text-align: center;
 }
 
-.entry-content blockquote {
+blockquote {
padding-left: 3em;
 }
 
-.entry-content ul li {
-   list-style: disc outside;
-}
-
-.entry-content ol li {
-   list-style: decimal outside;
-}
-
-.entry-content li ol,
-.entry-content li ul {
-   margin: 0.5em 0 0 0.5em;
+li {
+   list-style-position: outside;
+   margin-left: 2em;
 }
 
 .center {
@@ -347,15 +353,6 @@
 #toc {
display: none;
 }
-
-#bodyContent > ul > li {
-   margin-left: 1em;
-}
-
-div.entry-content li {
-   margin-left: 2em;
-}
-
 span.entry-sub-title {
margin-left: 1em;
margin-bottom: 2em;
@@ -625,6 +622,10 @@
#content {
padding: 1em 2em 0em;
}
+
+   #menu {
+   margin-top: 1em;
+   }
 }
 
 @media (max-width: 40em) {

-- 
To view, visit https://gerrit.wikimedia.org/r/69137
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieeb25d3fcdea1c918c47d0750ec01bbf2d819e84
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove unnecessary custom line-heights to simplify the code - change (mediawiki...erudite)

2013-06-17 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Remove unnecessary custom line-heights to simplify the code
..


Remove unnecessary custom line-heights to simplify the code

Change-Id: I54b296062dfa77405def55c68d4a87831c2481e6
---
M TODO
M assets/erudite.css
2 files changed, 6 insertions(+), 13 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved



diff --git a/TODO b/TODO
index 6b024ed..8a1f312 100644
--- a/TODO
+++ b/TODO
@@ -1,3 +1,2 @@
 Test that it works fine with ULS extension
 Use simpler CSS rules for main content, rather than children of .entry-content
-Set line-height consistently throughout (and ensure it isn't used in lieu of 
padding)
diff --git a/assets/erudite.css b/assets/erudite.css
index 6a19d27..cfdcd06 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -60,32 +60,28 @@
 h1 {
font-size: 1.5em;
text-transform: uppercase;
-   line-height: 1;
letter-spacing: 0.05em;
-   margin: 1.3em 0 0.3em;
+   margin-top: 1.3em;
 }
 
 h2 {
font-size: 1.25em;
-   line-height: 1.1;
-   margin: 1em 0 0.25em;
+   margin-top: 1em;
 }
 
 h3 {
font-size: 1.2em;
-   line-height: 1.2;
-   margin: 1.15em 0 0.3em;
+   margin-top: 1.15em;
 }
 
 h4 {
font-size: 1.1em;
-   line-height: 1.3;
-   margin: 1.3em 0 0.3em;
+   margin-top: 1.3em;
 }
 
 h5 {
font-size: 1em;
-   margin-top: 1.5em 0 0.375em;
+   margin-top: 1.5em;
 }
 
 h1 + h2,
@@ -200,6 +196,7 @@
 
 .footer h3 {
border-bottom: 1px solid #66;
+   margin-bottom: 0.2em;
font-size: 1.25em;
text-transform: uppercase;
letter-spacing: 0.05em;
@@ -251,7 +248,6 @@
 .entry-title {
color: #55;
margin: 0 0 0.5em;
-   line-height: 1.5;
 }
 
 .entry-content p,
@@ -426,7 +422,6 @@
padding: 3px !important;
background-color: #f9f9f9;
font-size: 0.875em;
-   line-height: 1.4;
text-align: center;
overflow: hidden;
 }
@@ -507,7 +502,6 @@
 #catlinks a {
color: #ff;
padding: 0 1em;
-   line-height: 2;
height: 100%;
font-size: 0.75em;
display: inline;

-- 
To view, visit https://gerrit.wikimedia.org/r/69134
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I54b296062dfa77405def55c68d4a87831c2481e6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove unnecessary custom line-heights to simplify the code - change (mediawiki...erudite)

2013-06-17 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/69134


Change subject: Remove unnecessary custom line-heights to simplify the code
..

Remove unnecessary custom line-heights to simplify the code

Change-Id: I54b296062dfa77405def55c68d4a87831c2481e6
---
M TODO
M assets/erudite.css
2 files changed, 6 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/34/69134/1

diff --git a/TODO b/TODO
index 6b024ed..8a1f312 100644
--- a/TODO
+++ b/TODO
@@ -1,3 +1,2 @@
 Test that it works fine with ULS extension
 Use simpler CSS rules for main content, rather than children of .entry-content
-Set line-height consistently throughout (and ensure it isn't used in lieu of 
padding)
diff --git a/assets/erudite.css b/assets/erudite.css
index 6a19d27..cfdcd06 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -60,32 +60,28 @@
 h1 {
font-size: 1.5em;
text-transform: uppercase;
-   line-height: 1;
letter-spacing: 0.05em;
-   margin: 1.3em 0 0.3em;
+   margin-top: 1.3em;
 }
 
 h2 {
font-size: 1.25em;
-   line-height: 1.1;
-   margin: 1em 0 0.25em;
+   margin-top: 1em;
 }
 
 h3 {
font-size: 1.2em;
-   line-height: 1.2;
-   margin: 1.15em 0 0.3em;
+   margin-top: 1.15em;
 }
 
 h4 {
font-size: 1.1em;
-   line-height: 1.3;
-   margin: 1.3em 0 0.3em;
+   margin-top: 1.3em;
 }
 
 h5 {
font-size: 1em;
-   margin-top: 1.5em 0 0.375em;
+   margin-top: 1.5em;
 }
 
 h1 + h2,
@@ -200,6 +196,7 @@
 
 .footer h3 {
border-bottom: 1px solid #66;
+   margin-bottom: 0.2em;
font-size: 1.25em;
text-transform: uppercase;
letter-spacing: 0.05em;
@@ -251,7 +248,6 @@
 .entry-title {
color: #55;
margin: 0 0 0.5em;
-   line-height: 1.5;
 }
 
 .entry-content p,
@@ -426,7 +422,6 @@
padding: 3px !important;
background-color: #f9f9f9;
font-size: 0.875em;
-   line-height: 1.4;
text-align: center;
overflow: hidden;
 }
@@ -507,7 +502,6 @@
 #catlinks a {
color: #ff;
padding: 0 1em;
-   line-height: 2;
height: 100%;
font-size: 0.75em;
display: inline;

-- 
To view, visit https://gerrit.wikimedia.org/r/69134
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I54b296062dfa77405def55c68d4a87831c2481e6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add @media rules for small screens - change (mediawiki...erudite)

2013-06-17 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Add @media rules for small screens
..


Add @media rules for small screens

Adds some rules for smaller viewports.

This also brought up an issue with content potentially being hidden if 
overflowing, which was fixed too (the #footer display:block section relates to 
that).

This appears to work nicely, but I don't have one of those fancy phones or 
tablets to test it with.

I used em rather than px measurements for screen width, as that seemed like a 
more sensible thing to test, plus some phones apparently misreport their pixel 
widths for the sake of "compatibility". If there are reasons against doing 
this, do let me know!

Change-Id: I6d3bcbf1538f4ae640709fbba45a4c1b7b2e6739
---
M Erudite.skin.php
M TODO
M assets/erudite.css
3 files changed, 87 insertions(+), 17 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Erudite.skin.php b/Erudite.skin.php
index d937ce0..7486a63 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -12,6 +12,14 @@
var $skinname = 'erudite', $stylename = 'erudite',
$template = 'EruditeTemplate', $useHeadElement = true;
 
+   public function initPage( OutputPage $out ) {
+   parent::initPage( $out );
+
+   $out->addHeadItem( 'viewport',
+   ''
+   );
+   }
+
/**
 * @param $out OutputPage object
 */
diff --git a/TODO b/TODO
index 94f7b3d..6b024ed 100644
--- a/TODO
+++ b/TODO
@@ -1,4 +1,3 @@
 Test that it works fine with ULS extension
 Use simpler CSS rules for main content, rather than children of .entry-content
 Set line-height consistently throughout (and ensure it isn't used in lieu of 
padding)
-Add small screen CSS rules, specifically to have the top menu and footer 
columns stack vertically and to remove the min-width (and width where 
appropriate) settings
diff --git a/assets/erudite.css b/assets/erudite.css
index 60a7098..6a19d27 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -11,9 +11,10 @@
 #container,
 #header,
 #access,
-#footer-wrap-inner {
-   min-width: 960px;
+#footer-wrap-inner,
+.message {
width: 90%;
+   max-width: 80em;
margin: 0 auto;
position: relative;
 }
@@ -22,10 +23,6 @@
padding: 1.5em 3.75em 0em;
 }
 
-#header-wrap,
-#footer-wrap {
-   min-width: 960px;
-}
 
 /* Use dark stripes around edge to focus on content */
 div#container {
@@ -162,7 +159,7 @@
 #menu {
margin: 1.5em 0 -0.625em;
overflow: hidden;
-   padding: 0.75em 3.75em;
+   padding: 0.75em 2em 0.75em 3.75em;
border-top: 1px solid #66;
background: #33;
background: rgba(50, 50, 50, 0.7);
@@ -188,10 +185,9 @@
 }
 
 .footer {
-   min-width: 240px;
-   width: 25%;
float: left;
-   margin-left: 60px;
+   width: 25%;
+   margin-left: 5%;
 }
 
 .footer .widget li {
@@ -228,6 +224,8 @@
 
 /* Footer to content (for FooterLinks) */
 #footer {
+   display: block;
+   clear: both;
text-align: right;
padding: 0.75em 0;
font-size: 0.75em;
@@ -238,7 +236,6 @@
position: relative;
margin: 0;
clear: both;
-   overflow: hidden;
 }
 
 hr {
@@ -526,10 +523,6 @@
 
 /* Messages */
 .message {
-   margin: 0 auto;
-   position: relative;
-   min-width: 960px;
-   width: 90%;
color: #ff;
background-color: #66;
padding: 0.75em 0;
@@ -575,7 +568,7 @@
 
 img#logo {
display: block;
-   margin: 24px auto 0px;
+   margin: 2em auto 0em;
 }
 
 div#bodyContent {
@@ -600,3 +593,73 @@
 body.action-edit #wpTextbox1 {
clear: none;
 }
+
+/* adjustments for smaller browser viewports */
+@media (max-width: 66em) {
+   /* top menu is likely to start wrapping, so reduce padding
+* and add a separator */
+   #menu {
+   padding: 0.7em 1em 0.45em;
+   background: rgba(50, 50, 50, 1.0);
+   }
+
+   #menu li {
+   border-right: 1px solid #66;
+   padding: 0em 1em;
+   margin-bottom: 0.3em;
+   margin-right: 0em;
+   }
+
+   #menu li:last-child {
+   border-right: none;
+   }
+
+   #access {
+   width: 100%;
+   }
+}
+
+@media (max-width: 60em) {
+   /* some of the padding is best dispatched with */
+   #container,
+   #header,
+   #footer-wrap-inner,
+   .message {
+   width: 100%;
+   }
+
+   #content {
+   padding: 1em 2em 0em;
+   }
+}
+
+@media (max-width: 40em) {
+   /* shave padding back a bit further */
+   #content {
+   padding: 1em 1em 0em;
+   }
+
+   /* stack footer columns */
+   .footer {
+   display: block;
+

[MediaWiki-commits] [Gerrit] Remove custom line-height declarations for headings. - change (mediawiki...erudite)

2013-06-13 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/68364


Change subject: Remove custom line-height declarations for headings.
..

Remove custom line-height declarations for headings.

Change-Id: Ibff9f8811742cce12799183c00ab8477782521ed
---
M TODO
M assets/erudite.css
2 files changed, 6 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/64/68364/1

diff --git a/TODO b/TODO
index 6b024ed..8a1f312 100644
--- a/TODO
+++ b/TODO
@@ -1,3 +1,2 @@
 Test that it works fine with ULS extension
 Use simpler CSS rules for main content, rather than children of .entry-content
-Set line-height consistently throughout (and ensure it isn't used in lieu of 
padding)
diff --git a/assets/erudite.css b/assets/erudite.css
index 544b09c..21a18ed 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -60,32 +60,28 @@
 h1 {
font-size: 1.5em;
text-transform: uppercase;
-   line-height: 1;
letter-spacing: 0.05em;
-   margin: 1.3em 0 0.3em;
+   margin-top: 1.3em;
 }
 
 h2 {
font-size: 1.25em;
-   line-height: 1.1;
-   margin: 1em 0 0.25em;
+   margin-top: 1em;
 }
 
 h3 {
font-size: 1.2em;
-   line-height: 1.2;
-   margin: 1.15em 0 0.3em;
+   margin-top: 1.15em;
 }
 
 h4 {
font-size: 1.1em;
-   line-height: 1.3;
-   margin: 1.3em 0 0.3em;
+   margin-top: 1.3em;
 }
 
 h5 {
font-size: 1em;
-   margin-top: 1.5em 0 0.375em;
+   margin-top: 1.5em;
 }
 
 h1 + h2,
@@ -200,6 +196,7 @@
 
 .footer h3 {
border-bottom: 1px solid #66;
+   margin-bottom: 0.2em;
font-size: 1.25em;
text-transform: uppercase;
letter-spacing: 0.05em;
@@ -251,7 +248,6 @@
 .entry-title {
color: #55;
margin: 0 0 0.5em;
-   line-height: 1.5;
 }
 
 .entry-content p,
@@ -426,7 +422,6 @@
padding: 3px !important;
background-color: #f9f9f9;
font-size: 0.875em;
-   line-height: 1.4;
text-align: center;
overflow: hidden;
 }
@@ -507,7 +502,6 @@
 #catlinks a {
color: #ff;
padding: 0 1em;
-   line-height: 2;
height: 100%;
font-size: 0.75em;
display: inline;

-- 
To view, visit https://gerrit.wikimedia.org/r/68364
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibff9f8811742cce12799183c00ab8477782521ed
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add @media rules for small screens - change (mediawiki...erudite)

2013-06-12 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/68212


Change subject: Add @media rules for small screens
..

Add @media rules for small screens

Adds some rules for smaller viewports.

This also brought up an issue with content potentially being hidden if 
overflowing, which was fixed too (the #footer display:block section relates to 
that).

This appears to work nicely, but I don't have one of those fancy phones or 
tablets to test it with.

Change-Id: I6d3bcbf1538f4ae640709fbba45a4c1b7b2e6739
---
M TODO
M assets/erudite.css
2 files changed, 69 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/12/68212/1

diff --git a/TODO b/TODO
index 94f7b3d..6b024ed 100644
--- a/TODO
+++ b/TODO
@@ -1,4 +1,3 @@
 Test that it works fine with ULS extension
 Use simpler CSS rules for main content, rather than children of .entry-content
 Set line-height consistently throughout (and ensure it isn't used in lieu of 
padding)
-Add small screen CSS rules, specifically to have the top menu and footer 
columns stack vertically and to remove the min-width (and width where 
appropriate) settings
diff --git a/assets/erudite.css b/assets/erudite.css
index 60a7098..d5dd248 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -11,9 +11,10 @@
 #container,
 #header,
 #access,
-#footer-wrap-inner {
-   min-width: 960px;
+#footer-wrap-inner,
+.message {
width: 90%;
+   max-width: 80em;
margin: 0 auto;
position: relative;
 }
@@ -22,10 +23,6 @@
padding: 1.5em 3.75em 0em;
 }
 
-#header-wrap,
-#footer-wrap {
-   min-width: 960px;
-}
 
 /* Use dark stripes around edge to focus on content */
 div#container {
@@ -162,7 +159,7 @@
 #menu {
margin: 1.5em 0 -0.625em;
overflow: hidden;
-   padding: 0.75em 3.75em;
+   padding: 0.75em 2em 0.75em 3.75em;
border-top: 1px solid #66;
background: #33;
background: rgba(50, 50, 50, 0.7);
@@ -188,10 +185,9 @@
 }
 
 .footer {
-   min-width: 240px;
-   width: 25%;
float: left;
-   margin-left: 60px;
+   width: 25%;
+   margin-left: 5%;
 }
 
 .footer .widget li {
@@ -228,6 +224,8 @@
 
 /* Footer to content (for FooterLinks) */
 #footer {
+   display: block;
+   clear: both;
text-align: right;
padding: 0.75em 0;
font-size: 0.75em;
@@ -238,7 +236,6 @@
position: relative;
margin: 0;
clear: both;
-   overflow: hidden;
 }
 
 hr {
@@ -526,10 +523,6 @@
 
 /* Messages */
 .message {
-   margin: 0 auto;
-   position: relative;
-   min-width: 960px;
-   width: 90%;
color: #ff;
background-color: #66;
padding: 0.75em 0;
@@ -575,7 +568,7 @@
 
 img#logo {
display: block;
-   margin: 24px auto 0px;
+   margin: 2em auto 0em;
 }
 
 div#bodyContent {
@@ -600,3 +593,63 @@
 body.action-edit #wpTextbox1 {
clear: none;
 }
+
+/* adjustments for smaller browser viewports */
+@media screen and (max-width: 66em) {
+   /* top menu is likely to start wrapping, so reduce padding
+* and add a separator */
+   #menu {
+   padding-left: 1em;
+   padding-right: 1em;
+   }
+
+   #menu li {
+   border-right: 1px solid #66;
+   padding: 0em 1em;
+   margin-bottom: 0.3em;
+   margin-right: 0em;
+   }
+
+   #menu li:last-child {
+   border-right: none;
+   }
+}
+
+@media screen and (max-width: 60em) {
+   /* some of the padding is best dispatched with */
+   #container,
+   #header,
+   #access,
+   #footer-wrap-inner,
+   .message {
+   width: 100%;
+   max-width: none;
+   }
+   
+   #content {
+   padding: 1em 2em 0em;
+   }
+}
+
+@media screen and (max-width: 40em) {
+   /* shave padding back a bit further */
+   #content {
+   padding: 1em 1em 0em;
+   }
+
+   /* stack footer columns */
+   .footer {
+   display: block;
+   float: none;
+   width: 90%;
+   }
+}
+
+@media screen and (max-width: 20em) {
+   /* stack top menu items */
+   #menu li {
+   float: none !important;
+   border: none;
+   padding: 0em;
+   }
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/68212
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6d3bcbf1538f4ae640709fbba45a4c1b7b2e6739
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Use em for all text units, and a few style tweaks - change (mediawiki...erudite)

2013-06-11 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/68019


Change subject: Use em for all text units, and a few style tweaks
..

Use em for all text units, and a few style tweaks

Now things actually scale in a very nice way when people set their
browser font size. Which is good for accessibility, and more
generally just a polite thing to do.

Pixel measurements are also used for minimum width measurements for
the main content and footer section, so that they remain appropriate
even with very large fonts.

Style tweaks:
- Message area has appropriate padding
- Removed top padding on #container so page title starts a bit higher up
- Some unnecessary rules removed / merged
- Minor tweaks of a few sizes when switching to em

Change-Id: I103251a3cc62fdc8a325e6aca79b8b31c7ff5c10
---
M Erudite.skin.php
M TODO
M assets/erudite.css
3 files changed, 81 insertions(+), 112 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/19/68019/1

diff --git a/Erudite.skin.php b/Erudite.skin.php
index e2e453a..d937ce0 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -71,7 +71,7 @@
}
?>

-   text( 
'sitename' ); ?>
+   text( 
'sitename' ); ?>
msg( 'tagline' ) 
?>

 
@@ -95,9 +95,9 @@
data[$msg] ) {
-   echo "";
+   echo "";
$this->html( $msg );
-   echo '';
+   echo '';
}
}
?>
@@ -108,7 +108,7 @@

html( 
'title' ); ?>
data['subtitle'] ) { ?>
-   html( 'subtitle' ) ?>
+   html( 'subtitle' ) ?>

 

diff --git a/TODO b/TODO
index 410be54..94f7b3d 100644
--- a/TODO
+++ b/TODO
@@ -1,4 +1,4 @@
 Test that it works fine with ULS extension
-Use consistent units everywhere; fonts are currently mixed px / pt / % / em
 Use simpler CSS rules for main content, rather than children of .entry-content
+Set line-height consistently throughout (and ensure it isn't used in lieu of 
padding)
 Add small screen CSS rules, specifically to have the top menu and footer 
columns stack vertically and to remove the min-width (and width where 
appropriate) settings
diff --git a/assets/erudite.css b/assets/erudite.css
index f4345c3..60a7098 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -12,14 +12,14 @@
 #header,
 #access,
 #footer-wrap-inner {
-   min-width: 96em;
+   min-width: 960px;
width: 90%;
margin: 0 auto;
position: relative;
 }
 
 #content {
-   padding: 2.4em 6em 0em 6em;
+   padding: 1.5em 3.75em 0em;
 }
 
 #header-wrap,
@@ -30,7 +30,6 @@
 /* Use dark stripes around edge to focus on content */
 div#container {
background: white;
-   padding-top: 2em;
 }
 
 div#wrapper {
@@ -41,63 +40,55 @@
 /* Typography Base */
 body {
font-family: constantia, 'hoefler text', 'palatino linotype', serif;
-   font-size: 10px;
line-height: 1.5;
background: #fafafa;
color: #33;
 }
 
-textarea,
-select,
-input {
-   font-size: 12px;
-}
-
+/* use sans-serif font for headings and navigation */
 h1,
 h2,
 h3,
 h4,
 h5,
-h6 {
+h6,
+.entry-meta,
+#menu,
+#footer-wrap {
font-family: corbel, 'gill sans', 'gill sans mt', sans-serif;
font-weight: normal;
-   letter-spacing: 0.05em;
text-rendering: optimizeLegibility;
 }
 
 h1 {
-   font-size: 2.4em;
+   font-size: 1.5em;
text-transform: uppercase;
line-height: 1;
-   margin: 1.333em 0 0.333em;
+   letter-spacing: 0.05em;
+   margin: 1.3em 0 0.3em;
 }
 
 h2 {
-   font-size: 2.0em;
+   font-size: 1.25em;
line-height: 1.1;
margin: 1em 0 0.25em;
 }
 
 h3 {
-   font-size: 1.9em;
+   font-size: 1.2em;
line-height: 1.2;
-   margin: 1.143em 0 0.286em;
+   margin: 1.15em 0 0.3em;
 }
 
 h4 {
-   font-size: 1.8em;
+   font-size: 1.1em;
line-height: 1.3;
-   margin: 1.333em 0 0.333em;
+   margin: 1.3em 0 0.3em;
 }
 
 h5 {
-   font-size: 1.6em;
+   font-size: 1em;
margin-top: 1.5em 0 0.375em;
-}
-
-h4,
-h5 {
-   letter-spacing: 0.1em;
 }
 
 h1 + h2,
@@ -147,35 +138,37 @@
background-image: url(images/stripes.png);
background-color: #33;
background-repeat: repeat;
-   padding: 1em 0;
+   padding: 0.625em 0;
 }
 
-#header h1,
-#header h1 a {
+#header h1 {
color: #ff;

[MediaWiki-commits] [Gerrit] Use em for all units except image specific, and a few style ... - change (mediawiki...erudite)

2013-06-11 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/67994


Change subject: Use em for all units except image specific, and a few style 
tweaks
..

Use em for all units except image specific, and a few style tweaks

Style tweaks:
- Message area has appropriate padding
- No top padding on #container so page title starts a bit higher up
- Some unnecessary rules removed
- Minor tweaks of a few sizes when switching to em

Change-Id: I880cd050655f11f981a7840d3695091f422a1381
---
M Erudite.skin.php
M TODO
M assets/erudite.css
3 files changed, 37 insertions(+), 64 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/94/67994/1

diff --git a/Erudite.skin.php b/Erudite.skin.php
index e2e453a..6fa3256 100644
--- a/Erudite.skin.php
+++ b/Erudite.skin.php
@@ -71,7 +71,7 @@
}
?>

-   text( 
'sitename' ); ?>
+   text( 
'sitename' ); ?>
msg( 'tagline' ) 
?>

 
@@ -95,9 +95,9 @@
data[$msg] ) {
-   echo "";
+   echo "";
$this->html( $msg );
-   echo '';
+   echo '';
}
}
?>
diff --git a/TODO b/TODO
index 410be54..e3641be 100644
--- a/TODO
+++ b/TODO
@@ -1,4 +1,3 @@
 Test that it works fine with ULS extension
-Use consistent units everywhere; fonts are currently mixed px / pt / % / em
 Use simpler CSS rules for main content, rather than children of .entry-content
 Add small screen CSS rules, specifically to have the top menu and footer 
columns stack vertically and to remove the min-width (and width where 
appropriate) settings
diff --git a/assets/erudite.css b/assets/erudite.css
index f4345c3..706153d 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -12,7 +12,7 @@
 #header,
 #access,
 #footer-wrap-inner {
-   min-width: 96em;
+   min-width: 960px;
width: 90%;
margin: 0 auto;
position: relative;
@@ -30,7 +30,6 @@
 /* Use dark stripes around edge to focus on content */
 div#container {
background: white;
-   padding-top: 2em;
 }
 
 div#wrapper {
@@ -45,12 +44,6 @@
line-height: 1.5;
background: #fafafa;
color: #33;
-}
-
-textarea,
-select,
-input {
-   font-size: 12px;
 }
 
 h1,
@@ -150,13 +143,16 @@
padding: 1em 0;
 }
 
-#header h1,
-#header h1 a {
+#header h1 {
color: #ff;
text-decoration: none;
-   font-size: 36px;
+   font-size: 3.6em;
line-height: 1;
margin: 0;
+}
+
+#header a {
+   color: #ff;
 }
 
 #siteSubtitle {
@@ -321,11 +317,6 @@
margin-right: auto;
 }
 
-/* stop "larger" from .warning multiplying with "1.6em" from p */
-.warning p {
-   font-size: 100%;
-}
-
 /* Main Links */
 .entry-content a {
border-bottom: 1px solid #aa;
@@ -339,9 +330,9 @@
 /* Meta (edit links etc.) */
 .entry-meta {
float: right;
-   padding-left: 15px;
-   margin-left: 15px;
-   margin-bottom: 10px;
+   padding-left: 1.5em;
+   margin-left: 1.5em;
+   margin-bottom: 1em;
border-left: 1px solid #aa;
 }
 
@@ -361,7 +352,7 @@
 }
 
 span.editsection {
-   font-size: 10pt;
+   font-size: 0.65em; /* 2em (h2) * 0.65em = 1.3em */
 }
 
 .toc,
@@ -370,22 +361,22 @@
 }
 
 #bodyContent > ul > li {
-   margin-left: 10pt;
+   margin-left: 1em;
 }
 
 div.entry-content li {
-   margin-left: 30px;
+   margin-left: 2em;
 }
 
 span.entry-sub-title {
-   margin-left: 40px;
-   font-size: 10pt;
+   margin-left: 1em;
+   font-size: 1.3em;
font-style: italic;
 }
 
 /* References */
 .reference {
-   font-size: 8pt;
+   font-size: 0.875em; /* 1.6em * 0.875em = 1.4em */
 }
 
 ol.references > li:target {
@@ -460,7 +451,7 @@
 .thumbcaption {
border: none;
text-align: left;
-   padding: 3px !important;
+   padding: 0.1875em !important; /* 1.6em * 0.1875em = 0.3em */
 }
 
 div.magnify {
@@ -505,36 +496,11 @@
border: 2px solid #fafafa;
 }
 
-/* Category pages */
-div.entry-content div#mw-pages table tbody tr td h3 {
-   font-size: 15pt;
-}
-
-div.entry-content div#mw-subcategories table tbody tr td h3 {
-   font-size: 15pt;
-}
-
-div#content-container div.entry-content div#mw-pages table tbody tr td ul {
-   font-size: 6pt;
-}
-
-div#content-container div.entry-content div#mw-subcategories table tbody tr td 
ul {
-   font-size: 6pt;
-}
-
-
-div.mw-spcontent form {
-   margin-bottom: 10pt;
-}
-
-/* Protect pages */
-form#mw-Protect-Form fieldset table {
-   font-size: 8pt;
-}
-
-/* Special Pages */
+/* Category and S

[MediaWiki-commits] [Gerrit] Release v1.0 - change (mediawiki...erudite)

2013-06-07 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Release v1.0
..


Release v1.0

Change-Id: I0354e9b75ff69c38cd618e5f37355e4273a4cc96
---
R COPYING
A TODO
D assets/CHANGES
D assets/license-addendum.txt
M erudite.php
5 files changed, 9 insertions(+), 20 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved



diff --git a/assets/license.txt b/COPYING
similarity index 98%
rename from assets/license.txt
rename to COPYING
index 468ed1d..4648a48 100644
--- a/assets/license.txt
+++ b/COPYING
@@ -1,7 +1,6 @@
-The Erudite is (c) Matt Wiebe and is licensed under the GPL 2 (below)
-Uses some bits from Scott Wallick's late-great Sandbox theme.
+This theme is released under the GPLv2. See below for the full license.
 
-
+Copyright 2009-2013 Matt Wiebe, Nick White, Colin Andrew Ferm, Daniel Friesen
 
 
 GNU GENERAL PUBLIC LICENSE
@@ -342,4 +341,4 @@
 proprietary programs.  If your program is a subroutine library, you may
 consider it more useful to permit linking proprietary applications with the
 library.  If this is what you want to do, use the GNU Lesser General
-Public License instead of this License.
\ No newline at end of file
+Public License instead of this License.
diff --git a/TODO b/TODO
new file mode 100644
index 000..410be54
--- /dev/null
+++ b/TODO
@@ -0,0 +1,4 @@
+Test that it works fine with ULS extension
+Use consistent units everywhere; fonts are currently mixed px / pt / % / em
+Use simpler CSS rules for main content, rather than children of .entry-content
+Add small screen CSS rules, specifically to have the top menu and footer 
columns stack vertically and to remove the min-width (and width where 
appropriate) settings
diff --git a/assets/CHANGES b/assets/CHANGES
deleted file mode 100644
index 078bd3f..000
--- a/assets/CHANGES
+++ /dev/null
@@ -1,12 +0,0 @@
-0.9.3
-- Fixed Newest Pages widget for different script paths.
-
-0.9.2
-- Added OpenGraph meta fields to the skin.
-
-0.9.1
-- Added more wiki controls to the right nav.
-- Made talk notifications show under toolbar.
-
-0.9.0
-- First packaged from the skin unifiedrepublicofstars.com was based on.
diff --git a/assets/license-addendum.txt b/assets/license-addendum.txt
deleted file mode 100644
index ec9d366..000
--- a/assets/license-addendum.txt
+++ /dev/null
@@ -1,3 +0,0 @@
-Erudite for MediaWiki was created by Colin Andrew Ferm based off the original 
Erudite WP theme.
-
-All terms of the original license remain.
diff --git a/erudite.php b/erudite.php
index ee66a5f..df7e914 100644
--- a/erudite.php
+++ b/erudite.php
@@ -16,7 +16,8 @@
'path' => __FILE__,
'name' => 'Erudite',
'url' => 'https://www.mediawiki.org/wiki/Skin:Erudite',
-   'author' => array( 'Matt Wiebe', 'Colin Andrew Ferm', 'Nick White' ),
+   'author' => array( 'Nick White', 'Matt Wiebe', 'Colin Andrew Ferm' ),
+   'version' => '1.0',
'descriptionmsg' => 'erudite-desc',
 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/67423
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0354e9b75ff69c38cd618e5f37355e4273a4cc96
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Release v1.0 - change (mediawiki...erudite)

2013-06-07 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/67423


Change subject: Release v1.0
..

Release v1.0

Change-Id: I0354e9b75ff69c38cd618e5f37355e4273a4cc96
---
R COPYING
A TODO
D assets/CHANGES
D assets/license-addendum.txt
M erudite.php
5 files changed, 9 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/23/67423/1

diff --git a/assets/license.txt b/COPYING
similarity index 98%
rename from assets/license.txt
rename to COPYING
index 468ed1d..4648a48 100644
--- a/assets/license.txt
+++ b/COPYING
@@ -1,7 +1,6 @@
-The Erudite is (c) Matt Wiebe and is licensed under the GPL 2 (below)
-Uses some bits from Scott Wallick's late-great Sandbox theme.
+This theme is released under the GPLv2. See below for the full license.
 
-
+Copyright 2009-2013 Matt Wiebe, Nick White, Colin Andrew Ferm, Daniel Friesen
 
 
 GNU GENERAL PUBLIC LICENSE
@@ -342,4 +341,4 @@
 proprietary programs.  If your program is a subroutine library, you may
 consider it more useful to permit linking proprietary applications with the
 library.  If this is what you want to do, use the GNU Lesser General
-Public License instead of this License.
\ No newline at end of file
+Public License instead of this License.
diff --git a/TODO b/TODO
new file mode 100644
index 000..410be54
--- /dev/null
+++ b/TODO
@@ -0,0 +1,4 @@
+Test that it works fine with ULS extension
+Use consistent units everywhere; fonts are currently mixed px / pt / % / em
+Use simpler CSS rules for main content, rather than children of .entry-content
+Add small screen CSS rules, specifically to have the top menu and footer 
columns stack vertically and to remove the min-width (and width where 
appropriate) settings
diff --git a/assets/CHANGES b/assets/CHANGES
deleted file mode 100644
index 078bd3f..000
--- a/assets/CHANGES
+++ /dev/null
@@ -1,12 +0,0 @@
-0.9.3
-- Fixed Newest Pages widget for different script paths.
-
-0.9.2
-- Added OpenGraph meta fields to the skin.
-
-0.9.1
-- Added more wiki controls to the right nav.
-- Made talk notifications show under toolbar.
-
-0.9.0
-- First packaged from the skin unifiedrepublicofstars.com was based on.
diff --git a/assets/license-addendum.txt b/assets/license-addendum.txt
deleted file mode 100644
index ec9d366..000
--- a/assets/license-addendum.txt
+++ /dev/null
@@ -1,3 +0,0 @@
-Erudite for MediaWiki was created by Colin Andrew Ferm based off the original 
Erudite WP theme.
-
-All terms of the original license remain.
diff --git a/erudite.php b/erudite.php
index ee66a5f..df7e914 100644
--- a/erudite.php
+++ b/erudite.php
@@ -16,7 +16,8 @@
'path' => __FILE__,
'name' => 'Erudite',
'url' => 'https://www.mediawiki.org/wiki/Skin:Erudite',
-   'author' => array( 'Matt Wiebe', 'Colin Andrew Ferm', 'Nick White' ),
+   'author' => array( 'Nick White', 'Matt Wiebe', 'Colin Andrew Ferm' ),
+   'version' => '1.0',
'descriptionmsg' => 'erudite-desc',
 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/67423
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0354e9b75ff69c38cd618e5f37355e4273a4cc96
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix p in warning being massive - change (mediawiki...erudite)

2013-05-31 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Fix p in warning being massive
..


Fix p in warning being massive

Change-Id: I19d111fc5dba1bf8925d7d95178a508205d6a4ae
---
M assets/erudite.css
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved



diff --git a/assets/erudite.css b/assets/erudite.css
index 479fd8e..19ec6fc 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -310,6 +310,11 @@
margin: 0.5em 0 0 0.5em;
 }
 
+/* stop "larger" from .warning multiplying with "1.6em" from p */
+.warning p {
+   font-size: 100%;
+}
+
 /* Main Links */
 .entry-content a {
border-bottom: 1px solid #aa;

-- 
To view, visit https://gerrit.wikimedia.org/r/66249
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I19d111fc5dba1bf8925d7d95178a508205d6a4ae
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Several image improvements - change (mediawiki...erudite)

2013-05-31 Thread Njw (Code Review) 
Njw has submitted this change and it was merged.

Change subject: Several image improvements
..


Several image improvements

- Respect border
- Make thumb neater
- Work properly in IE 8
- Center works

Change-Id: I94ab36a181df2786e91653073d6a7ca097e1a363
---
M assets/erudite.css
1 file changed, 18 insertions(+), 13 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved



diff --git a/assets/erudite.css b/assets/erudite.css
index 479fd8e..784de06 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -264,7 +264,8 @@
 .entry-content p,
 .entry-content li,
 .entry-content dt,
-.entry-content dd {
+.entry-content dd,
+.entry-content center {
font-size: 1.6em;
margin-bottom: 0.75em;
 }
@@ -308,6 +309,16 @@
 .entry-content li ol,
 .entry-content li ul {
margin: 0.5em 0 0 0.5em;
+}
+
+.center {
+   width: 100%;
+   text-align: center;
+}
+
+.center * {
+   margin-left: auto;
+   margin-right: auto;
 }
 
 /* Main Links */
@@ -382,10 +393,8 @@
 
 /* Images */
 .entry-content img {
-   border: 1px solid #aa;
padding: 4px;
margin-bottom: 6px;
-   max-width: 100%;
 }
 
 .entry-content .gallery a {
@@ -420,17 +429,15 @@
 
 div.thumb {
margin-bottom: 0.5em;
-   border-style: solid;
-   border-color: #fafafa;
width: auto;
-   background-color: transparent;
 }
 
 div.thumbinner {
border: 1px solid #cc;
padding: 3px !important;
background-color: #f9f9f9;
-   font-size: 94%;
+   font-size: 1.4em;
+   line-height: 1.4em;
text-align: center;
overflow: hidden;
 }
@@ -438,6 +445,7 @@
 img.thumbimage {
border: none;
padding: 0px;
+   margin: 0px;
 }
 
 .thumbinner>a {
@@ -447,9 +455,7 @@
 .thumbcaption {
border: none;
text-align: left;
-   line-height: 1.4em;
padding: 3px !important;
-   font-size: 94%;
 }
 
 div.magnify {
@@ -468,18 +474,17 @@
 div.tright {
clear: right;
float: right;
-   border-width: 0.5em 0 0.8em 1.4em;
+   margin-left: 1.4em;
 }
 
 div.tleft {
float: left;
clear: left;
-   margin-right: 0.5em;
-   border-width: 0.5em 1.4em 0.8em 0;
+   margin-right: 1.4em;
 }
 
 img.thumbborder {
-   border: 1px solid #dd;
+   border: 1px solid #aa;
 }
 
 .hiddenStructure {

-- 
To view, visit https://gerrit.wikimedia.org/r/66246
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I94ab36a181df2786e91653073d6a7ca097e1a363
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 
Gerrit-Reviewer: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix p in warning being massive - change (mediawiki...erudite)

2013-05-31 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/66249


Change subject: Fix p in warning being massive
..

Fix p in warning being massive

Change-Id: I19d111fc5dba1bf8925d7d95178a508205d6a4ae
---
M assets/erudite.css
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/49/66249/1

diff --git a/assets/erudite.css b/assets/erudite.css
index 479fd8e..19ec6fc 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -310,6 +310,11 @@
margin: 0.5em 0 0 0.5em;
 }
 
+/* stop "larger" from .warning multiplying with "1.6em" from p */
+.warning p {
+   font-size: 100%;
+}
+
 /* Main Links */
 .entry-content a {
border-bottom: 1px solid #aa;

-- 
To view, visit https://gerrit.wikimedia.org/r/66249
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I19d111fc5dba1bf8925d7d95178a508205d6a4ae
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Several image improvements - change (mediawiki...erudite)

2013-05-31 Thread Njw (Code Review) 
Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/66246


Change subject: Several image improvements
..

Several image improvements

- Respect border
- Make thumb neater
- Work properly in IE 8
- Center works

Change-Id: I94ab36a181df2786e91653073d6a7ca097e1a363
---
M assets/erudite.css
1 file changed, 18 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/46/66246/1

diff --git a/assets/erudite.css b/assets/erudite.css
index 479fd8e..784de06 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -264,7 +264,8 @@
 .entry-content p,
 .entry-content li,
 .entry-content dt,
-.entry-content dd {
+.entry-content dd,
+.entry-content center {
font-size: 1.6em;
margin-bottom: 0.75em;
 }
@@ -308,6 +309,16 @@
 .entry-content li ol,
 .entry-content li ul {
margin: 0.5em 0 0 0.5em;
+}
+
+.center {
+   width: 100%;
+   text-align: center;
+}
+
+.center * {
+   margin-left: auto;
+   margin-right: auto;
 }
 
 /* Main Links */
@@ -382,10 +393,8 @@
 
 /* Images */
 .entry-content img {
-   border: 1px solid #aa;
padding: 4px;
margin-bottom: 6px;
-   max-width: 100%;
 }
 
 .entry-content .gallery a {
@@ -420,17 +429,15 @@
 
 div.thumb {
margin-bottom: 0.5em;
-   border-style: solid;
-   border-color: #fafafa;
width: auto;
-   background-color: transparent;
 }
 
 div.thumbinner {
border: 1px solid #cc;
padding: 3px !important;
background-color: #f9f9f9;
-   font-size: 94%;
+   font-size: 1.4em;
+   line-height: 1.4em;
text-align: center;
overflow: hidden;
 }
@@ -438,6 +445,7 @@
 img.thumbimage {
border: none;
padding: 0px;
+   margin: 0px;
 }
 
 .thumbinner>a {
@@ -447,9 +455,7 @@
 .thumbcaption {
border: none;
text-align: left;
-   line-height: 1.4em;
padding: 3px !important;
-   font-size: 94%;
 }
 
 div.magnify {
@@ -468,18 +474,17 @@
 div.tright {
clear: right;
float: right;
-   border-width: 0.5em 0 0.8em 1.4em;
+   margin-left: 1.4em;
 }
 
 div.tleft {
float: left;
clear: left;
-   margin-right: 0.5em;
-   border-width: 0.5em 1.4em 0.8em 0;
+   margin-right: 1.4em;
 }
 
 img.thumbborder {
-   border: 1px solid #dd;
+   border: 1px solid #aa;
 }
 
 .hiddenStructure {

-- 
To view, visit https://gerrit.wikimedia.org/r/66246
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I94ab36a181df2786e91653073d6a7ca097e1a363
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

  1   2   >