[MediaWiki-commits] [Gerrit] Bug 25886: Serve stylesheets with Access-Control-Allow-Origi... - change (mediawiki/core)
TheDJ has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60200
Change subject: Bug 25886: Serve stylesheets with Access-Control-Allow-Origin: *
..
Bug 25886: Serve stylesheets with Access-Control-Allow-Origin: *
This allows Javascript to access our styling information (cssRules and
related cross domain protected dom information) even if it is hosted
on a different domain.
Change-Id: I8e05c13ae1a1589fd120d5c439b1a7128ce2b659
---
M includes/resourceloader/ResourceLoader.php
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/00/60200/1
diff --git a/includes/resourceloader/ResourceLoader.php
b/includes/resourceloader/ResourceLoader.php
index dd613a7..d57c47e 100644
--- a/includes/resourceloader/ResourceLoader.php
+++ b/includes/resourceloader/ResourceLoader.php
@@ -557,6 +557,7 @@
}
if ( $context->getOnly() === 'styles' ) {
header( 'Content-Type: text/css; charset=utf-8' );
+ header( 'Access-Control-Allow-Origin: *' );
} else {
header( 'Content-Type: text/javascript; charset=utf-8'
);
}
@@ -786,6 +787,7 @@
// custom media type groups
into @media .. {} sections as part of the css string.
// Module returns either an
empty array or a numerical array with css strings.
$out .= isset( $styles['css'] )
? implode( '', $styles['css'] ) : '';
+
break;
case 'messages':
$out .=
self::makeMessageSetScript( new XmlJsCode( $messagesBlob ) );
--
To view, visit https://gerrit.wikimedia.org/r/60200
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e05c13ae1a1589fd120d5c439b1a7128ce2b659
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: TheDJ
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bug 20828: Add rtl/ltr class to offline skin - change (mediawiki...DumpHTML)
TheDJ has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60194
Change subject: Bug 20828: Add rtl/ltr class to offline skin
..
Bug 20828: Add rtl/ltr class to offline skin
Change-Id: I3ca7102d40579b43af56e14b3f4bd8ddd33fb232
---
M SkinOffline.php
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DumpHTML
refs/changes/94/60194/1
diff --git a/SkinOffline.php b/SkinOffline.php
index 730c6d9..89baa49 100644
--- a/SkinOffline.php
+++ b/SkinOffline.php
@@ -142,8 +142,7 @@
data['userjs']) { ?>
data['userjsprev']) { ?>html('userjsprev')
?>
- data['pageclass']) { ?>class="text('pageclass') ?>">
+
--
To view, visit https://gerrit.wikimedia.org/r/60194
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ca7102d40579b43af56e14b3f4bd8ddd33fb232
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DumpHTML
Gerrit-Branch: master
Gerrit-Owner: TheDJ
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Replaced Xml class by Html. The affected pages are the editi... - change (mediawiki...ProofreadPage)
TheDJ has submitted this change and it was merged.
Change subject: Replaced Xml class by Html. The affected pages are the edition
pages of Special:Index pages and Index pages.
..
Replaced Xml class by Html.
The affected pages are the edition pages of Special:Index pages and Index pages.
Change-Id: I64e841469664af41ba96a5a3f865f0272b0fb48a
---
M SpecialProofreadPages.php
M includes/index/EditProofreadIndexPage.php
2 files changed, 27 insertions(+), 23 deletions(-)
Approvals:
TheDJ: Verified; Looks good to me, approved
jenkins-bot: Checked
diff --git a/SpecialProofreadPages.php b/SpecialProofreadPages.php
index a1419c9..4143a06 100644
--- a/SpecialProofreadPages.php
+++ b/SpecialProofreadPages.php
@@ -51,22 +51,22 @@
$orderSelect->addOption( $this->msg(
'proofreadpage_alphabeticalorder' )->text(), 'alpha' );
$output->addHTML(
- Xml::openElement( 'form', array( 'action' =>
$wgScript ) ) .
+ Html::openElement( 'form', array( 'action' =>
$wgScript) ) .
Html::hidden( 'title',
$this->getTitle()->getPrefixedText() ) .
- Xml::input( 'limit', false, $this->limit,
array( 'type' => 'hidden' ) ) .
- Xml::openElement( 'fieldset' ) .
- Xml::element( 'legend', null, $this->msg(
'proofreadpage_specialpage_legend' )->text() ) .
- Xml::element( 'p' ) .
+ Html::input( 'limit', $this->limit, 'hidden',
array() ) .
+ Html::openElement('fieldset', array() ) .
+ Html::element('legend', null, $this->msg(
'proofreadpage_specialpage_legend' )->text() ) .
+ Html::openElement( 'p' ) .
Xml::label( $this->msg(
'proofreadpage_specialpage_label_key' )->text(), 'key' ) . ' ' .
- Xml::input( 'key', 20, $this->searchTerm ) .
- Xml::closeElement( 'p' ) .
- Xml::element( 'p' ) .
+ Html::input( 'key', $this->searchTerm ) .
+ Html::closeElement( 'p' ) .
+ Html::openElement( 'p' ) .
Xml::label( $this->msg(
'proofreadpage_specialpage_label_orderby' )->text(), 'order' ) . ' ' .
$orderSelect->getHtml() . ' ' .
Xml::checkLabel( $this->msg(
'proofreadpage_specialpage_label_sortascending' )->text(), 'sortascending',
'sortascending', $this->sortAscending ) . ' ' .
Xml::submitButton( $this->msg( 'ilsubmit'
)->text() ) .
- Xml::closeElement( 'p' ) .
- Xml::closeElement( 'fieldset' ) .
- Xml::closeElement( 'form' )
+ Html::closeElement( 'p' ) .
+ Html::closeElement( 'fieldset' ) .
+ Html::closeElement( 'form' )
);
if( $this->searchTerm ) {
$indexNamespaceId =
ProofreadPage::getIndexNamespaceId();
diff --git a/includes/index/EditProofreadIndexPage.php
b/includes/index/EditProofreadIndexPage.php
index debaf9a..289e1e2 100644
--- a/includes/index/EditProofreadIndexPage.php
+++ b/includes/index/EditProofreadIndexPage.php
@@ -40,14 +40,14 @@
$index = new ProofreadIndexPage( $this->mTitle, $this->textbox1
);
$entries = $index->getIndexEntries();
- $wgOut->addHTML( Xml::openElement( 'table', array( 'id' =>
'prp-formTable' ) ) );
+ $wgOut->addHTML( Html::openElement( 'table', array( 'id' =>
'prp-formTable' ) ) );
$i = 10;
foreach( $entries as $entry ) {
$inputAttributes['tabindex'] = $i;
$this->addEntry( $entry, $inputAttributes );
$i++;
}
- $wgOut->addHTML( Xml::closeElement( 'table' ) );
+ $wgOut->addHTML( Html::closeElement( 'table' ) );
}
/**
@@ -65,20 +65,20 @@
$val = $this->safeUnicodeOutput( $entry->getStringValue() );
$wgOut->addHTML(
- Xml::openElement( 'tr' ) .
- Xml::openElement( 'th', array( 'scope' => 'row'
) ) .
+ Html::openElement( 'tr' ) .
+ Html::openElement( 'th', array( 'scope' =>
'row' ) ) .
Xml::label( $entry->getLabel(), $key )
);
$help = $entry->getHelp();
if (
[MediaWiki-commits] [Gerrit] Minor CSS cleanup for Vector and Monobook skins - change (mediawiki/core)
TheDJ has submitted this change and it was merged.
Change subject: Minor CSS cleanup for Vector and Monobook skins
..
Minor CSS cleanup for Vector and Monobook skins
Fixing inconsistencies discovered when working
on Ia82312b5 (now abandoned).
Change-Id: Ie2eacf60ddc7f8dd6a00bce1551913b410cd10f1
---
M skins/monobook/main.css
M skins/vector/screen.css
2 files changed, 6 insertions(+), 4 deletions(-)
Approvals:
Waldir: Looks good to me, but someone else must approve
TheDJ: Verified; Looks good to me, approved
diff --git a/skins/monobook/main.css b/skins/monobook/main.css
index 4cbc093..b3a531d 100644
--- a/skins/monobook/main.css
+++ b/skins/monobook/main.css
@@ -381,19 +381,22 @@
#p-personal li.active a:hover {
background-color: transparent;
}
-/* the icon in front of the user name, single quotes
-in bg url to hide it from iemac */
+/* The icon in front of the username / login link */
li#pt-userpage,
li#pt-anonuserpage,
li#pt-login {
/* @embed */
background: url(user.gif) top left no-repeat;
padding-left: 20px;
- text-transform: none;
}
#p-personal ul {
text-transform: lowercase;
}
+/* Don't lowercase username or IP addresses (IPv6) */
+li#pt-userpage,
+li#pt-anonuserpage {
+ text-transform: none;
+}
#p-personal li.active {
font-weight: bold;
}
diff --git a/skins/vector/screen.css b/skins/vector/screen.css
index 2e09ee1..28b8c09 100644
--- a/skins/vector/screen.css
+++ b/skins/vector/screen.css
@@ -784,7 +784,6 @@
/* @embed */
background: url(images/user-icon.png) left top no-repeat;
padding-left: 15px !important;
- text-transform: none;
}
.redirectText {
--
To view, visit https://gerrit.wikimedia.org/r/55461
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2eacf60ddc7f8dd6a00bce1551913b410cd10f1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Matmarex
Gerrit-Reviewer: Anomie
Gerrit-Reviewer: Daniel Friesen
Gerrit-Reviewer: Hoo man
Gerrit-Reviewer: Krinkle
Gerrit-Reviewer: Matmarex
Gerrit-Reviewer: TheDJ
Gerrit-Reviewer: Waldir
Gerrit-Reviewer: jenkins-bot
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 41886) make $.tablesorter support headers with colspan - change (mediawiki/core[master])
TheDJ has submitted this change and it was merged. Change subject: (bug 41886) make $.tablesorter support headers with colspan .. (bug 41886) make $.tablesorter support headers with colspan Previously, if a header had colspan set, all headers after it would sort wrong columns (shifted by the cumulating colspans). This fixes the issue, from now on every header sorts on all columns it spans over (using the multi-column sorting funcitonality already present in $.tablesorter). Change-Id: I89766c9640b83ca38f41d698d1ef052a9e3f68d3 --- M resources/jquery/jquery.tablesorter.js M tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js 2 files changed, 81 insertions(+), 28 deletions(-) Approvals: Anomie: Looks good to me, but someone else must approve TheDJ: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/32576 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89766c9640b83ca38f41d698d1ef052a9e3f68d3 Gerrit-PatchSet: 9 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Matmarex Gerrit-Reviewer: Anomie Gerrit-Reviewer: Hoo man Gerrit-Reviewer: Matmarex Gerrit-Reviewer: TheDJ Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 2865) Add lang attribute to firstHeading of CologneBlue - change (mediawiki/core[master])
TheDJ has uploaded a new change for review. Change subject: (bug 2865) Add lang attribute to firstHeading of CologneBlue .. (bug 2865) Add lang attribute to firstHeading of CologneBlue This is a follow up to I55dd392d Change-Id: I20bd5b6aae6a26f149a4a822aefdea860f148093 --- M skins/CologneBlue.php 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/64/33464/1 -- To view, visit https://gerrit.wikimedia.org/r/33464 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I20bd5b6aae6a26f149a4a822aefdea860f148093 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 2865) Add lang attribute to firstHeading - change (mediawiki/core[master])
TheDJ has submitted this change and it was merged. Change subject: (bug 2865) Add lang attribute to firstHeading .. (bug 2865) Add lang attribute to firstHeading Adds a lang attribute to . Interface language is applied to and content language is applied to . This leaves firstHeading with the interface language, which is wrong in general. It also causes incorrect display of the title for languages that have custom line-height. This patch is based on code written by Munirathnam M at the Bangalore DevCamp (he couldn't submit it because of network issues). It looks OK to me, but it's my first time doing anything with $this->data in a skin, so please correct me if I'm wrong. Change-Id: I55dd392dbf0d4f768344b66e6ceb3a023b1d5c9b --- M RELEASE-NOTES-1.21 M skins/Modern.php M skins/MonoBook.php M skins/Vector.php 4 files changed, 14 insertions(+), 3 deletions(-) Approvals: TheDJ: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33163 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55dd392dbf0d4f768344b66e6ceb3a023b1d5c9b Gerrit-PatchSet: 7 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Amire80 Gerrit-Reviewer: Amire80 Gerrit-Reviewer: Nikerabbit Gerrit-Reviewer: Siebrand Gerrit-Reviewer: TheDJ Gerrit-Reviewer: Waldir Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 41886) jquery.tablesorter should not explode rowspans u... - change (mediawiki/core[master])
TheDJ has submitted this change and it was merged. Change subject: (bug 41886) jquery.tablesorter should not explode rowspans until sorted .. (bug 41886) jquery.tablesorter should not explode rowspans until sorted jquery.tablesorter should not explode rowspans until the table is actually sorted. Also adds a testcase to verify this behavior, and updates another test case that was depending on the broken behavior. Change-Id: Ibe4cc7e92de6cc8e370c5912c9eda062b466c538 --- M RELEASE-NOTES-1.21 M resources/jquery/jquery.tablesorter.js M tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js 3 files changed, 51 insertions(+), 19 deletions(-) Approvals: Matmarex: Looks good to me, but someone else must approve TheDJ: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/32593 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe4cc7e92de6cc8e370c5912c9eda062b466c538 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Anomie Gerrit-Reviewer: Anomie Gerrit-Reviewer: Catrope Gerrit-Reviewer: Hoo man Gerrit-Reviewer: Matmarex Gerrit-Reviewer: Platonides Gerrit-Reviewer: TheDJ Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 35901) Follow redirect of title when retrieving categor... - change (mediawiki/core[master])
TheDJ has uploaded a new change for review. Change subject: (bug 35901) Follow redirect of title when retrieving categories .. (bug 35901) Follow redirect of title when retrieving categories UploadWizard is using getCategories() to retrieve the categories of a title, but this title can be a redirect. Adding redirects to JS api call. Change-Id: I9d1faacddc12e9e11f8c8f2469ff596a9d2ca3f1 --- M resources/mediawiki.api/mediawiki.api.category.js 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/40/33040/1 -- To view, visit https://gerrit.wikimedia.org/r/33040 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9d1faacddc12e9e11f8c8f2469ff596a9d2ca3f1 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Don't wikilink input that is already likely to be wikicode - change (mediawiki...UploadWizard[master])
TheDJ has uploaded a new change for review.
Change subject: Don't wikilink input that is already likely to be wikicode
..
Don't wikilink input that is already likely to be wikicode
The author field is normaly used as text for the wikilink to your
username. Many users however have their own ways to form their
attribution. This will use raw wikicode for the author field if
users add [[ or {{ in the author field. If they don't the field input
will still be used as the text for the wikilink to the username.
Change-Id: I0a6580e953754b290abd0844b2bb95e2f62c0333
---
M resources/mw.UploadWizardDeed.js
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard
refs/changes/39/33039/1
--
To view, visit https://gerrit.wikimedia.org/r/33039
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a6580e953754b290abd0844b2bb95e2f62c0333
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: TheDJ
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix E_STRICT in ForeignAPIRepo - change (mediawiki/core[master])
TheDJ has submitted this change and it was merged. Change subject: Fix E_STRICT in ForeignAPIRepo .. Fix E_STRICT in ForeignAPIRepo The error is "Strict Standards: Declaration of ForeignAPIRepo::getZoneUrl() should be compatible with that of FileRepo::getZoneUrl() in includes/filerepo/ForeignAPIRepo.php on line 426". The second parameter of ForeignAPIRepo::getZoneUrl() was missing. Change-Id: I8f60ff9d6152225ae99c1420d3a80c72c40974eb --- M includes/filerepo/ForeignAPIRepo.php 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: TheDJ: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/32569 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f60ff9d6152225ae99c1420d3a80c72c40974eb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: IAlex Gerrit-Reviewer: TheDJ Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] make addPortletLink work with CologneBlue - change (mediawiki/core[master])
TheDJ has submitted this change and it was merged. Change subject: make addPortletLink work with CologneBlue .. make addPortletLink work with CologneBlue To achieve this: * remove the special-casing in mw.util * use standard portlet ids to make existing scripts work Change-Id: I4ac3bc143fc235f700144244b0ad5b1f681ae5b5 --- M resources/mediawiki/mediawiki.util.js M skins/CologneBlue.php 2 files changed, 19 insertions(+), 12 deletions(-) Approvals: TheDJ: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/31135 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ac3bc143fc235f700144244b0ad5b1f681ae5b5 Gerrit-PatchSet: 6 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Matmarex Gerrit-Reviewer: Matmarex Gerrit-Reviewer: TheDJ Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix case of E_STRICT violation in ForeignAPIRepo - change (mediawiki/core[master])
TheDJ has uploaded a new change for review. Change subject: Fix case of E_STRICT violation in ForeignAPIRepo .. Fix case of E_STRICT violation in ForeignAPIRepo This is a follow up to Ib6473773 Change-Id: I0cd62ffdbc5367edcc1913c883ffaac5846eda3f --- M includes/filerepo/ForeignAPIRepo.php 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/30/32730/1 -- To view, visit https://gerrit.wikimedia.org/r/32730 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0cd62ffdbc5367edcc1913c883ffaac5846eda3f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 35923) tweaks to mediawiki.action.history.diff.css - change (mediawiki/core[master])
TheDJ has submitted this change and it was merged. Change subject: (bug 35923) tweaks to mediawiki.action.history.diff.css .. (bug 35923) tweaks to mediawiki.action.history.diff.css This is a followup from bug 11374. This patch has some fixes and final tweaks for the code currently in trunk. * Reorganized the CSS to specificallity. * Changed table width to 100%, and added zero margin for table, so no horizontal scrollbars. * Changed horizontal padding in table.diff td from 0.66em to 0.5em, making max use of expensive horizontal real estate. * Override default vertical 0.33em padding in td.diff-marker with 0.25em to compensate for increased fontsize of the marker (+ and -), which caused unwanted padding at the bottom in one-line diff rules. * Changed the background for td.diff-context to #f9f9f9, which is the same as the background for wikitables. (BTW, the default background for Vector is #f6f6f6, not the current #f3f3f3 as stated on wikitech-l). * Removed 'overflow: auto' fallback for table.diff td div, as this creates unwanted scrollbars in IE 8 and 9. The fallback targeted a very limited set of older browsers anyway. The NewDiff gadget on enwiki has all these fixes implemented, so you can evaluate this code. Change-Id: Ic9da00bc13ad8c322c19648c7d3ac8abec2eaa07 --- M resources/mediawiki.action/mediawiki.action.history.diff.css 1 file changed, 35 insertions(+), 45 deletions(-) Approvals: Edokter: Looks good to me, but someone else must approve Matmarex: Looks good to me, but someone else must approve TheDJ: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/25743 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9da00bc13ad8c322c19648c7d3ac8abec2eaa07 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Matmarex Gerrit-Reviewer: Catrope Gerrit-Reviewer: Edokter Gerrit-Reviewer: Isarra Gerrit-Reviewer: MarkTraceur Gerrit-Reviewer: Matmarex Gerrit-Reviewer: TheDJ Gerrit-Reviewer: Trevor Parscal Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bug 41894 prefixed table name with mw-filepage - change (mediawiki...TimedMediaHandler[master])
TheDJ has submitted this change and it was merged. Change subject: Bug 41894 prefixed table name with mw-filepage .. Bug 41894 prefixed table name with mw-filepage Change-Id: I1724639254d34018ac934db38f9191cc2248cdb9 --- M TranscodeStatusTable.php M resources/ext.tmh.transcodetable.js M resources/transcodeTable.css 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: TheDJ: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32495 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1724639254d34018ac934db38f9191cc2248cdb9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: Mdale Gerrit-Reviewer: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 41483) Display TIFF size correctly - change (mediawiki...PagedTiffHandler[master])
TheDJ has submitted this change and it was merged. Change subject: (bug 41483) Display TIFF size correctly .. (bug 41483) Display TIFF size correctly Fixes issue introduced in I48e87564. Result of Language::formatSize() is a string, so converting to integer does not make sense. Also remove the loop checking if all message parameters are not an array, as that turned out not to be the problem fixing bug 41305. Change-Id: I3b57c8c3578f3a556ae526a9ddbab43b6d56819d --- M PagedTiffHandler_body.php 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: TheDJ: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/30596 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b57c8c3578f3a556ae526a9ddbab43b6d56819d Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/PagedTiffHandler Gerrit-Branch: master Gerrit-Owner: Siebrand Gerrit-Reviewer: Brian Wolff Gerrit-Reviewer: Nikerabbit Gerrit-Reviewer: Reedy Gerrit-Reviewer: Siebrand Gerrit-Reviewer: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] add margin for nested lists (bug 41543) - change (mediawiki...MobileFrontend[master])
TheDJ has submitted this change and it was merged. Change subject: add margin for nested lists (bug 41543) .. add margin for nested lists (bug 41543) help distinguish lists within lists but do not apply margin to parent node to make most of available screen space for dl elements which are used on talk pages for replies ensure we add the indent to show conversation Change-Id: I22aa3021db551ea742c326e933c6562b07b694e0 --- M stylesheets/common/mf-typography.css M stylesheets/less/common/mf-typography.less 2 files changed, 21 insertions(+), 0 deletions(-) Approvals: Jdlrobson: Looks good to me, but someone else must approve TheDJ: Verified; Looks good to me, approved jenkins-bot: Verified Objections: awjrichards: There's a problem with this change, please improve -- To view, visit https://gerrit.wikimedia.org/r/31313 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22aa3021db551ea742c326e933c6562b07b694e0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson Gerrit-Reviewer: Jdlrobson Gerrit-Reviewer: TheDJ Gerrit-Reviewer: awjrichards Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mw.notification: fix error on notif. close with $.fx.off=tru... - change (mediawiki/core[master])
TheDJ has submitted this change and it was merged. Change subject: mw.notification: fix error on notif. close with $.fx.off=true .. mw.notification: fix error on notif. close with $.fx.off=true I didn't investigate why, but apparently $placeholder being defined lexically after it is first used causes it to be null when it shouldn't be, causing at least Opera to blow up. This only appears when $.fx.off is set to true (to disable all jQuery animations; there's a gadget that does this on pl.wikipedia). Change-Id: If0aa6279515694ef20337ef02a05562c5543b2e2 --- M resources/mediawiki/mediawiki.notification.js 1 file changed, 13 insertions(+), 10 deletions(-) Approvals: Hoo man: Looks good to me, but someone else must approve TheDJ: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/26482 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0aa6279515694ef20337ef02a05562c5543b2e2 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Matmarex Gerrit-Reviewer: Daniel Friesen Gerrit-Reviewer: Hoo man Gerrit-Reviewer: Matmarex Gerrit-Reviewer: TheDJ Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix width of edit page elements after merge of I42f42654. - change (mediawiki...Vector[master])
TheDJ has uploaded a new change for review. Change subject: Fix width of edit page elements after merge of I42f42654. .. Fix width of edit page elements after merge of I42f42654. Change-Id: Ibfefc87f39a1a3059a4c842cb165d89df838552c --- M modules/ext.vector.footerCleanup.css 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Vector refs/changes/78/31378/1 -- To view, visit https://gerrit.wikimedia.org/r/31378 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibfefc87f39a1a3059a4c842cb165d89df838552c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Vector Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 40610) Prevent editing textarea from overflowing out of... - change (mediawiki/core[master])
TheDJ has submitted this change and it was merged. Change subject: (bug 40610) Prevent editing textarea from overflowing out of bodyContent .. (bug 40610) Prevent editing textarea from overflowing out of bodyContent Per suggestion by Daniel Friesen, this change adds a box-sizing specification to prevent the editing textarea from overflowing from the bodyContent in vector, monobook, and modern skins. Change-Id: I42f42654d87e8a14ff478b4670e3642ae083c81d --- M skins/common/commonContent.css M skins/modern/main.css 2 files changed, 15 insertions(+), 0 deletions(-) Approvals: Matmarex: Looks good to me, but someone else must approve TheDJ: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/28665 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42f42654d87e8a14ff478b4670e3642ae083c81d Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Isarra Gerrit-Reviewer: Daniel Friesen Gerrit-Reviewer: Isarra Gerrit-Reviewer: Matmarex Gerrit-Reviewer: TheDJ Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] CologneBlue rewrite: rewrite bottomLinks() - change (mediawiki/core[master])
TheDJ has submitted this change and it was merged. Change subject: CologneBlue rewrite: rewrite bottomLinks() .. CologneBlue rewrite: rewrite bottomLinks() * use links already present in toolbar and navigational menus * remove all the checks that have been thus made redundant * introduce processBottomLink() * remove all the functions that became obsolete * fix up CSS * add action=info link Change-Id: I9486649e7b34f1ee33f5d529f3af5799369b3a11 --- M skins/CologneBlue.php M skins/cologneblue/screen.css 2 files changed, 61 insertions(+), 204 deletions(-) Approvals: TheDJ: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/26898 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9486649e7b34f1ee33f5d529f3af5799369b3a11 Gerrit-PatchSet: 8 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Matmarex Gerrit-Reviewer: Brion VIBBER Gerrit-Reviewer: Daniel Friesen Gerrit-Reviewer: IAlex Gerrit-Reviewer: Matmarex Gerrit-Reviewer: TheDJ Gerrit-Reviewer: jenkins-bot Gerrit-Reviewer: saper ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] CologneBlue rewrite: output the sidebar items as lists - change (mediawiki/core[master])
TheDJ has submitted this change and it was merged. Change subject: CologneBlue rewrite: output the sidebar items as lists .. CologneBlue rewrite: output the sidebar items as lists This fixes the second part of bug 41456. We also wrap each portlet in a with class=portlet and an id like in other skins (p-). These changes should make CologneBlue more compatible with gadgets and user-scripts that expect standard sidebar structure to add new links to it. Change-Id: I51c022bf22b881d4bd33c8d0e36c3e3226ac8b8f --- M skins/CologneBlue.php M skins/cologneblue/screen.css 2 files changed, 23 insertions(+), 12 deletions(-) Approvals: TheDJ: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/30359 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51c022bf22b881d4bd33c8d0e36c3e3226ac8b8f Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Matmarex Gerrit-Reviewer: Matmarex Gerrit-Reviewer: TheDJ Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] CologneBlue rewrite: rework quickbar() once again - change (mediawiki/core[master])
TheDJ has submitted this change and it was merged. Change subject: CologneBlue rewrite: rework quickbar() once again .. CologneBlue rewrite: rework quickbar() once again * three separate phases: * semantic modifications (adding new portlets, removing langlinks, moving search to top) * filling out special items with content (searchbox, toolbox) * generating the HTML * split new portlets data to a separate function, sidebarAdditions() * fix missing headings for items added as HTML strings instead of a links array (bug 41456) * fix double escaping of some headings Change-Id: Id1889591d1ac78f2b78a55ab225df37278c87b2b --- M skins/CologneBlue.php 1 file changed, 98 insertions(+), 100 deletions(-) Approvals: TheDJ: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/30335 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1889591d1ac78f2b78a55ab225df37278c87b2b Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Matmarex Gerrit-Reviewer: Dereckson Gerrit-Reviewer: Martineznovo Gerrit-Reviewer: Matmarex Gerrit-Reviewer: TheDJ Gerrit-Reviewer: jenkins-bot Gerrit-Reviewer: saper ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 41273) Expand license URL for PDF rendering - change (mediawiki...Collection[master])
TheDJ has uploaded a new change for review. Change subject: (bug 41273) Expand license URL for PDF rendering .. (bug 41273) Expand license URL for PDF rendering The URL is included as plain text into the PDF, and //en.wikipedia is not really nice. Expanding URL to always use http://, since there is no different PDF result cache for http vs https requested rendering. Change-Id: I1c246bf2cbe5e009fc08cc611d18a2dbab7d0cca --- M Collection.body.php 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Collection refs/changes/69/31069/1 -- To view, visit https://gerrit.wikimedia.org/r/31069 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1c246bf2cbe5e009fc08cc611d18a2dbab7d0cca Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Collection Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] There is no need to use an expanded URL for this downloadlin... - change (mediawiki...Collection[master])
TheDJ has uploaded a new change for review. Change subject: There is no need to use an expanded URL for this downloadlink. .. There is no need to use an expanded URL for this downloadlink. Change-Id: I069c5f42a14b230dacec54e3598d7ca346bcbe99 --- M Collection.body.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Collection refs/changes/66/31066/1 -- To view, visit https://gerrit.wikimedia.org/r/31066 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I069c5f42a14b230dacec54e3598d7ca346bcbe99 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Collection Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 41554) Add language attributes to "in other languages" - change (mediawiki...MobileFrontend[master])
TheDJ has uploaded a new change for review. Change subject: (bug 41554) Add language attributes to "in other languages" .. (bug 41554) Add language attributes to "in other languages" Change-Id: Ie339b8edf9c3e40f5b66e7300e7d589642098f0e --- M includes/skins/SkinMobile.php 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/59/30959/1 -- To view, visit https://gerrit.wikimedia.org/r/30959 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie339b8edf9c3e40f5b66e7300e7d589642098f0e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add in new checkmark and alert graphics for upload step - change (mediawiki...UploadWizard[master])
TheDJ has submitted this change and it was merged. Change subject: Add in new checkmark and alert graphics for upload step .. Add in new checkmark and alert graphics for upload step Thanks much to Brandon for these graphics, they're very nice! This patch deletes the old graphics and creates the new ones, and of course makes the necessary style changes. Change-Id: I7d6028c68f9f85a2473937b1538ad75843445e37 --- D resources/images/32px-Dialog-apply-009900.svg.png D resources/images/32px-Dialog-apply.svg.png D resources/images/32px-Nuvola_apps_important_orange.svg.png A resources/images/32px-alert.png A resources/images/32px-check.png M resources/uploadWizard.css 6 files changed, 2 insertions(+), 2 deletions(-) Approvals: Foxtrott: Looks good to me, but someone else must approve TheDJ: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/10129 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d6028c68f9f85a2473937b1538ad75843445e37 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: MarkTraceur Gerrit-Reviewer: Foxtrott Gerrit-Reviewer: Kaldari Gerrit-Reviewer: Pastakhov Gerrit-Reviewer: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 41509) Fix styling of galleries on mobile - change (mediawiki...MobileFrontend[master])
TheDJ has uploaded a new change for review. Change subject: (bug 41509) Fix styling of galleries on mobile .. (bug 41509) Fix styling of galleries on mobile The stylesheet still assumed table.gallery, but we switched to a div based solution quite a while ago. This is a straight copy of the style from common/shared.css of core. Change-Id: Ib3a6e258c60ac5f4083dfe72e2e9e834dfa3d112 --- M stylesheets/common/mf-common.css M stylesheets/common/mf-hacks.css M stylesheets/less/common/mf-common.less M stylesheets/less/common/mf-hacks.less 4 files changed, 77 insertions(+), 43 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/15/30915/1 -- To view, visit https://gerrit.wikimedia.org/r/30915 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib3a6e258c60ac5f4083dfe72e2e9e834dfa3d112 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 34878) Don't override columncount with auto, instead se... - change (mediawiki...MobileFrontend[master])
TheDJ has uploaded a new change for review. Change subject: (bug 34878) Don't override columncount with auto, instead set width .. (bug 34878) Don't override columncount with auto, instead set width column-width takes precedence over column-count. So instead of !important'ing column count, just set width instead and the amount of columns will be automatic, depending on the amount of available horizontal space.. Change-Id: Ie543e56998079afee6307dab8c0f8be692ef9ed3 --- M stylesheets/common/mf-enwp.css M stylesheets/common/mf-hacks.css M stylesheets/less/common/mf-enwp.less M stylesheets/less/common/mf-hacks.less 4 files changed, 23 insertions(+), 18 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/82/30782/1 -- To view, visit https://gerrit.wikimedia.org/r/30782 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie543e56998079afee6307dab8c0f8be692ef9ed3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Split off en.wp specific stuff into a separate file. - change (mediawiki...MobileFrontend[master])
TheDJ has uploaded a new change for review. Change subject: Split off en.wp specific stuff into a separate file. .. Split off en.wp specific stuff into a separate file. We can move this into MediaWiki:Mobile.css, but if we remove it too soon, it might break wikipedia's which have not configured their Mobile.css yet. Change-Id: Ibba4b13614f7880e5c1741b9e84599a56a4e9fcd --- M Makefile M MobileFrontend.php M stylesheets/common/mf-common.css A stylesheets/common/mf-enwp.css M stylesheets/common/mf-hacks.css M stylesheets/less/common/mf-common.less A stylesheets/less/common/mf-enwp.less M stylesheets/less/common/mf-hacks.less 8 files changed, 241 insertions(+), 231 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/23/30723/1 -- To view, visit https://gerrit.wikimedia.org/r/30723 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibba4b13614f7880e5c1741b9e84599a56a4e9fcd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove SOPA styling from MF - change (mediawiki...MobileFrontend[master])
TheDJ has uploaded a new change for review. Change subject: Remove SOPA styling from MF .. Remove SOPA styling from MF Change-Id: I6384614f81dffc9ff447f2566a1b347c5297f81c --- M stylesheets/common/mf-common.css M stylesheets/less/common/mf-common.less 2 files changed, 0 insertions(+), 11 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/18/30718/1 -- To view, visit https://gerrit.wikimedia.org/r/30718 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6384614f81dffc9ff447f2566a1b347c5297f81c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 37692) Newer versions of ImageMagick indexes pages from... - change (mediawiki...PagedTiffHandler[master])
TheDJ has uploaded a new change for review. Change subject: (bug 37692) Newer versions of ImageMagick indexes pages from 0 .. (bug 37692) Newer versions of ImageMagick indexes pages from 0 At least IM 6.7.7 and later return page indexes based from 0. Since we kept an initial value starting at 0, the check immediately assumed that the order of the index was no longer correct. Triggering an: "inconsistent page numbering in TIFF directory" Change-Id: Id91102359d910a294c85b467c50bc7fdf2ff5c2f --- M PagedTiffHandler.image.php 1 file changed, 10 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PagedTiffHandler refs/changes/21/30621/1 -- To view, visit https://gerrit.wikimedia.org/r/30621 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id91102359d910a294c85b467c50bc7fdf2ff5c2f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/PagedTiffHandler Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 39559) Add GENDER support to upwiz-deeds-macro-prompt - change (mediawiki...UploadWizard[master])
TheDJ has submitted this change and it was merged. Change subject: (bug 39559) Add GENDER support to upwiz-deeds-macro-prompt .. (bug 39559) Add GENDER support to upwiz-deeds-macro-prompt Pass the user object as $2. Add dummy GENDER to the English message. Add documentation. Change-Id: I7fcb20f3ba6dcea0862c3dd727d18206eb017650 --- M UploadWizard.i18n.php M UploadWizardHooks.php M resources/mw.UploadWizard.js 3 files changed, 5 insertions(+), 2 deletions(-) Approvals: TheDJ: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/30273 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fcb20f3ba6dcea0862c3dd727d18206eb017650 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: Amire80 Gerrit-Reviewer: Amire80 Gerrit-Reviewer: MarkTraceur Gerrit-Reviewer: Nikerabbit Gerrit-Reviewer: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 38022) Check for completeness in confirmCloseWindow - change (mediawiki...UploadWizard[master])
TheDJ has submitted this change and it was merged.
Change subject: (bug 38022) Check for completeness in confirmCloseWindow
..
(bug 38022) Check for completeness in confirmCloseWindow
If you want to close the window, we stop you. We want to protect
your data from being lost by an accidental "Ctrl-W" when you meant
"Ctrl-V" or whatever. But on the last page ("thanks")...there's no
longer any danger. Your data is saved. So let's allow total
anarchy.
This patch fixes the bug and generally makes for a better system.
It should also be modified to work with change I4994d2bf because
it uses a .length === 0 check. We need to account for empty
uploads, which this patch does only partly.
Change-Id: If287818dded49aebfe6b9724856f729a26905c6a
---
M resources/mw.UploadWizard.js
M resources/mw.UploadWizardUpload.js
2 files changed, 17 insertions(+), 2 deletions(-)
Approvals:
TheDJ: Verified; Looks good to me, approved
--
To view, visit https://gerrit.wikimedia.org/r/21829
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If287818dded49aebfe6b9724856f729a26905c6a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: MarkTraceur
Gerrit-Reviewer: Kaldari
Gerrit-Reviewer: TheDJ
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Make sure copyMetadataCrtlDiv exists and correct - change (mediawiki...UploadWizard[master])
TheDJ has uploaded a new change for review. Change subject: Make sure copyMetadataCrtlDiv exists and correct .. Make sure copyMetadataCrtlDiv exists and correct Because it is possible to remove uploads after the details interface has been created, sometimes copyMetadataCrtlDiv was not present anymore. This delays the creation of the interface until it is needed. This fixes a JS exception that caused the Next button not to show up for users. Change-Id: I28fb937e1af1faa072c4452655fe2964af2c21ed --- M resources/mw.UploadWizard.js M resources/mw.UploadWizardDetails.js 2 files changed, 61 insertions(+), 64 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/43/30443/1 -- To view, visit https://gerrit.wikimedia.org/r/30443 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I28fb937e1af1faa072c4452655fe2964af2c21ed Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 1) document Skin::buildSidebar per own experience - change (mediawiki/core[master])
TheDJ has submitted this change and it was merged. Change subject: (bug 1) document Skin::buildSidebar per own experience .. (bug 1) document Skin::buildSidebar per own experience Lessons learned from CologneBlue rewrite and bug 40857. Change-Id: If56df0a7ce20bc8f7a73252d06baf97264793069 --- M includes/Skin.php 1 file changed, 17 insertions(+), 1 deletion(-) Approvals: TheDJ: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/29422 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If56df0a7ce20bc8f7a73252d06baf97264793069 Gerrit-PatchSet: 7 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Matmarex Gerrit-Reviewer: Daniel Friesen Gerrit-Reviewer: IAlex Gerrit-Reviewer: Martineznovo Gerrit-Reviewer: Matmarex Gerrit-Reviewer: Reedy Gerrit-Reviewer: TheDJ Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove printonly and geo classes from MF - change (mediawiki...MobileFrontend[master])
TheDJ has uploaded a new change for review. Change subject: Remove printonly and geo classes from MF .. Remove printonly and geo classes from MF This styling is en.wp specific and have now been set in en.wp's MediaWiki:Mobile.css Change-Id: I1b9d94e340cb2ddea0b933fc6b1b113a05f69f2c --- M stylesheets/common/mf-common.css M stylesheets/less/common/mf-common.less 2 files changed, 0 insertions(+), 11 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/74/29974/1 -- To view, visit https://gerrit.wikimedia.org/r/29974 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1b9d94e340cb2ddea0b933fc6b1b113a05f69f2c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 41174) Make the SVG parser accept SVG files without a n... - change (mediawiki/core[master])
TheDJ has uploaded a new change for review. Change subject: (bug 41174) Make the SVG parser accept SVG files without a namespace .. (bug 41174) Make the SVG parser accept SVG files without a namespace SVG files with missing xmlns namespace are not valid SVG files, but are valid XML files. This patch implicitly assumes the SVG namespace for any SVG file that doesn't declare an explicit namespace, but has as the root element. These files are not 100% valid, and cannot be rendered by Chrome and Firefox. Change-Id: I17c79762e3e9a06f0a515d543d473961580eaea5 --- M includes/media/SVGMetadataExtractor.php 1 file changed, 23 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/68/29968/1 -- To view, visit https://gerrit.wikimedia.org/r/29968 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I17c79762e3e9a06f0a515d543d473961580eaea5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Bug 41298) partial fix: re-apply Id4d5504a - change (mediawiki/core[master])
TheDJ has submitted this change and it was merged. Change subject: (Bug 41298) partial fix: re-apply Id4d5504a .. (Bug 41298) partial fix: re-apply Id4d5504a The changes in EditPage were apparently lost during merge. Change-Id: I2628d73a35eaab45336986959a585c7381b78471 --- M includes/EditPage.php 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Nikerabbit: Looks good to me, but someone else must approve TheDJ: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/29788 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2628d73a35eaab45336986959a585c7381b78471 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler Gerrit-Reviewer: Nikerabbit Gerrit-Reviewer: TheDJ Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Bug 41298) partial fix: re-applying Id7b331e1b - change (mediawiki/core[master])
TheDJ has submitted this change and it was merged. Change subject: (Bug 41298) partial fix: re-applying Id7b331e1b .. (Bug 41298) partial fix: re-applying Id7b331e1b Changes to EditPage.php apparently got lost during merge. Wonder how that happened, there are no conflicts. Change-Id: I5449d0331f5d60ed0296b69888e10272f47f9d42 --- M includes/EditPage.php 1 file changed, 26 insertions(+), 11 deletions(-) Approvals: Hoo man: Looks good to me, but someone else must approve Aude: Looks good to me, but someone else must approve TheDJ: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/29780 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5449d0331f5d60ed0296b69888e10272f47f9d42 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler Gerrit-Reviewer: Aude Gerrit-Reviewer: Daniel Kinzler Gerrit-Reviewer: Hoo man Gerrit-Reviewer: Jeroen De Dauw Gerrit-Reviewer: Siebrand Gerrit-Reviewer: TheDJ Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 40154) On action=info show where this page redirects to... - change (mediawiki/core[master])
TheDJ has submitted this change and it was merged. Change subject: (bug 40154) On action=info show where this page redirects to and whether it's a content page or not. .. (bug 40154) On action=info show where this page redirects to and whether it's a content page or not. Change-Id: I17ab90af902b3b23d5c9bc23f0c71a18d1006cb8 --- M includes/actions/InfoAction.php M languages/messages/MessagesEn.php M languages/messages/MessagesQqq.php M maintenance/language/messages.inc 4 files changed, 34 insertions(+), 0 deletions(-) Approvals: Parent5446: Looks good to me, but someone else must approve TheDJ: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/27125 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17ab90af902b3b23d5c9bc23f0c71a18d1006cb8 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Alex Monk Gerrit-Reviewer: Alex Monk Gerrit-Reviewer: IAlex Gerrit-Reviewer: Parent5446 Gerrit-Reviewer: TheDJ Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] sort method for jquery.tablesorter - change (mediawiki/core[master])
TheDJ has submitted this change and it was merged. Change subject: sort method for jquery.tablesorter .. sort method for jquery.tablesorter the sort method allows programmatic sorting as well as instantly sorting the table when initialising the tablesorter; furthermore, the method can be used to reset sorting (e.g. if rows have been added later via JS); sortEnd event may be used to reapply alternating table row colours or other purposes patch set 2: fixed mentioned issues and added another test patch set 3: addressed all further issues, introduced more obvious way to specify sorting patch set 4: implemented sort method instead of using an event; reprashed whole commit message; introduced 'sortEnd' event patch set 5: fixed white space error patch set 6: Add release notes and rebase Change-Id: Id14862100cd27ebd6980c48dcf497db229c4301f --- M RELEASE-NOTES-1.21 M resources/jquery/jquery.tablesorter.js M tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js 3 files changed, 223 insertions(+), 29 deletions(-) Approvals: TheDJ: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/22562 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id14862100cd27ebd6980c48dcf497db229c4301f Gerrit-PatchSet: 7 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Henning Snater Gerrit-Reviewer: Bergi Gerrit-Reviewer: Chico Venancio Gerrit-Reviewer: Daniel Werner Gerrit-Reviewer: Foxtrott Gerrit-Reviewer: Henning Snater Gerrit-Reviewer: Hoo man Gerrit-Reviewer: John Erling Blad Gerrit-Reviewer: Krinkle Gerrit-Reviewer: Matmarex Gerrit-Reviewer: TheDJ Gerrit-Reviewer: Tobias Gritschacher Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix up various issues leading to bug 40780. - change (mediawiki/core[master])
TheDJ has submitted this change and it was merged. Change subject: Fix up various issues leading to bug 40780. .. Fix up various issues leading to bug 40780. * jquery.autoEllipsis didn't return 'this', which means whenever it was used in a chain, it would return undefined. So in mediawiki.searchSuggest append( ... autoEllipsis() ) would apply it to a detached node that stays detached because it isn't passed to append. * Remove redundant passing of this in jQuery context to $(). On jQuery.prototype, 'this' is obviously a jQuery object. In jquery.highlightText, which is called from jquery.autoEllipsis. * Remove redundant .empty() call before calling .text( .. ), .text() replaces all content and naturally is forced to empty the element first. * Merge use of $el and $container in jquery.autoEllipsis.js. They were both pointing to the same object, having two names was only confusing. * Spaces. Change-Id: I4649ec0c89d38c4d79d1dceec28227902cd48d32 --- M resources/jquery/jquery.autoEllipsis.js M resources/jquery/jquery.highlightText.js M resources/mediawiki/mediawiki.searchSuggest.js 3 files changed, 19 insertions(+), 21 deletions(-) Approvals: Matmarex: Looks good to me, but someone else must approve Nikerabbit: Looks good to me, but someone else must approve TheDJ: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/27386 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4649ec0c89d38c4d79d1dceec28227902cd48d32 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Krinkle Gerrit-Reviewer: Catrope Gerrit-Reviewer: Eloquence Gerrit-Reviewer: Krinkle Gerrit-Reviewer: Matmarex Gerrit-Reviewer: Nikerabbit Gerrit-Reviewer: Reedy Gerrit-Reviewer: TheDJ Gerrit-Reviewer: Trevor Parscal Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix incorrect message in CologneBlue full text button. - change (mediawiki/core[master])
TheDJ has submitted this change and it was merged. Change subject: Fix incorrect message in CologneBlue full text button. .. Fix incorrect message in CologneBlue full text button. 'searchbutton' is the correct message, not 'search'. Change-Id: I81cd3fd86ac09fce49021f34eba7cc4f055167b6 --- M skins/CologneBlue.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: TheDJ: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/27970 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81cd3fd86ac09fce49021f34eba7cc4f055167b6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Daniel Friesen Gerrit-Reviewer: TheDJ Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix an issue with the data-sort-type retrieval. - change (mediawiki/core[master])
TheDJ has uploaded a new change for review. Change subject: Fix an issue with the data-sort-type retrieval. .. Fix an issue with the data-sort-type retrieval. The treatment of attributes with embedded dashes was changed in jQuery 1.6 to conform to the W3C HTML5 specification. Hyphenated names become camel-cased. Change-Id: I4ac2ebdc1ba8350b9696e516f62ba803fa8fb46b --- M resources/jquery/jquery.tablesorter.js 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/27/27127/1 -- To view, visit https://gerrit.wikimedia.org/r/27127 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4ac2ebdc1ba8350b9696e516f62ba803fa8fb46b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 17297) Remove units from line-height - change (mediawiki/core[master])
TheDJ has uploaded a new change for review. Change subject: (bug 17297) Remove units from line-height .. (bug 17297) Remove units from line-height To quote Philippe Verdy: specifiying the line-height in a block element or inline element with an absolute unit (in, pt, cm, mm) or even with a unit relative to the font-size (em, ex, %) has the severe defects that this does not affect the line-height in subelements (it is NOT inherited, notably when the font size is changed). If you have indices or exponents that set their own font-size, these font-sizes will continue to use the same computed line-height, even if they can then be shown partially over the previous or next line (depending on their background and clipping styles, they may be truncated, or could hide parts of these other lines). The same is true when you'll have multiple scripts on the same line, and that use different fonts: when changing font, the line-height will not be adjusted correctly, if those change do not also set again their local line-height. I have tested this on Safari and Firefox and have not observed problematic changes in layouting. Change-Id: I0d3d7d076ba37807cdc33fa470e1bde320d224d6 --- M RELEASE-NOTES-1.21 M skins/chick/main.css M skins/common/commonContent.css M skins/common/commonElements.css M skins/common/commonInterface.css M skins/common/commonPrint.css M skins/common/config-cc.css M skins/common/config.css M skins/common/feed.css M skins/common/oldshared.css M skins/common/shared.css M skins/modern/main.css M skins/monobook/main.css M skins/simple/main.css M skins/vector/screen.css 15 files changed, 55 insertions(+), 53 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/43/27043/1 -- To view, visit https://gerrit.wikimedia.org/r/27043 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0d3d7d076ba37807cdc33fa470e1bde320d224d6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 40329) Disable align attribute sanitizing in HTML5 - change (mediawiki/core[master])
TheDJ has uploaded a new change for review. Change subject: (bug 40329) Disable align attribute sanitizing in HTML5 .. (bug 40329) Disable align attribute sanitizing in HTML5 The chosen implementation was incomplete, because it did not correct the alignment of block elements inside the element carrying align, it only accounted for inline elements (by using text-align). Disabling this for now, because all browsers still support this attribute and it is better to have working HTML that is not HTML5 valid, then broken layouting. Change-Id: Iae6ff48fc8f179a4d6dfbe9ef63a9a2b999145ca --- M includes/Sanitizer.php M tests/phpunit/includes/SanitizerTest.php 2 files changed, 18 insertions(+), 14 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/21/24221/1 -- To view, visit https://gerrit.wikimedia.org/r/24221 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iae6ff48fc8f179a4d6dfbe9ef63a9a2b999145ca Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Check if copyMetadataCtrlDiv actually exists, before calling... - change (mediawiki...UploadWizard[master])
TheDJ has uploaded a new change for review. Change subject: Check if copyMetadataCtrlDiv actually exists, before calling it. .. Check if copyMetadataCtrlDiv actually exists, before calling it. This is a stopgap measure required to deal with the crazy uploads[0] vs uploads[0].index > 0 issue. The latter should be fixed, but since this undefined causes the script to fail quite badly, we should first just make sure people can actually finish their uploads Change-Id: If66ff7da7743785236150f88355ebd2495245635 --- M resources/mw.UploadWizard.js 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/64/23764/1 -- To view, visit https://gerrit.wikimedia.org/r/23764 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If66ff7da7743785236150f88355ebd2495245635 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 32328) Present an error, if the browser does not suppor... - change (mediawiki...UploadWizard[master])
TheDJ has uploaded a new change for review. Change subject: (bug 32328) Present an error, if the browser does not support uploads .. (bug 32328) Present an error, if the browser does not support uploads This happens notably on iOS 4 and iOS 5 Change-Id: I67f82dda60865d22ba37ecf1afebe4c6c5d371d2 --- M UploadWizard.i18n.php M UploadWizardHooks.php M resources/mw.UploadWizardUploadInterface.js 3 files changed, 15 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/63/23763/1 -- To view, visit https://gerrit.wikimedia.org/r/23763 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I67f82dda60865d22ba37ecf1afebe4c6c5d371d2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 40108) Fix language of copied description - change (mediawiki...UploadWizard[master])
TheDJ has uploaded a new change for review. Change subject: (bug 40108) Fix language of copied description .. (bug 40108) Fix language of copied description This is a followup to a394e9787607a83785e5af3be3439c4afdb676d6 Change-Id: I8c2d69e415d8c8d82fb073dd7f805805180eee82 --- M resources/mw.LanguageUpWiz.js M resources/mw.UploadWizardDetails.js 2 files changed, 24 insertions(+), 18 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/74/23474/1 -- To view, visit https://gerrit.wikimedia.org/r/23474 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8c2d69e415d8c8d82fb073dd7f805805180eee82 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove loading of LanguageHandler, which is no longer used - change (mediawiki...UploadWizard[master])
TheDJ has uploaded a new change for review. Change subject: Remove loading of LanguageHandler, which is no longer used .. Remove loading of LanguageHandler, which is no longer used Follow up to a394e9787607a83785e5af3be3439c4afdb676d6 Change-Id: I2d9f84ad67c074d63d055a295c3b93a9277b6bd9 --- M resources/mw.UploadWizard.js 1 file changed, 0 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/68/23468/1 -- To view, visit https://gerrit.wikimedia.org/r/23468 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2d9f84ad67c074d63d055a295c3b93a9277b6bd9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 39538) SVG filepages do not need the file-nohires messa... - change (mediawiki/core[master])
TheDJ has uploaded a new change for review. Change subject: (bug 39538) SVG filepages do not need the file-nohires message. .. (bug 39538) SVG filepages do not need the file-nohires message. Change-Id: I88b75079d09cc3ab1904a0a2d716fe2df57b7be6 --- M includes/ImagePage.php 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/91/23091/1 -- To view, visit https://gerrit.wikimedia.org/r/23091 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I88b75079d09cc3ab1904a0a2d716fe2df57b7be6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 35478) Refactor MathJax loader - change (mediawiki...Math[master])
TheDJ has uploaded a new change for review. Change subject: (bug 35478) Refactor MathJax loader .. (bug 35478) Refactor MathJax loader * apply coding conventions * remove global variable mathJax (not to be mixed up with MathJax), moved this to mediaWiki.mathJax * remove special code for WikEd and AjaxPreview, this did only work when ext.math.mathjax.enabler.js was loaded in edit mode, which only happened when showing a preview with math. * introduce a jQuery method to render all TeX inside a jQuery collection, it hooks into the MathJax system, so will work no matter when you call it. Change-Id: Ic05659eaca35a939289bf49b17084299319d8c4d --- M modules/ext.math.mathjax.enabler.js 1 file changed, 64 insertions(+), 46 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Math refs/changes/73/23073/1 -- To view, visit https://gerrit.wikimedia.org/r/23073 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic05659eaca35a939289bf49b17084299319d8c4d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Math Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 36855) escape literal % in tex input - change (mediawiki...Math[master])
TheDJ has uploaded a new change for review. Change subject: (bug 36855) escape literal % in tex input .. (bug 36855) escape literal % in tex input This removes support for MathML % comments, just as with texvc Change-Id: I0cb026d749733ed3dbba8faacb163be4438fc6bb --- M modules/MathJax/extensions/wiki2jax.js 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Math refs/changes/63/23063/1 -- To view, visit https://gerrit.wikimedia.org/r/23063 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0cb026d749733ed3dbba8faacb163be4438fc6bb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Math Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 37107) Check if the destination title is protected - change (mediawiki...UploadWizard[master])
TheDJ has uploaded a new change for review. Change subject: (bug 37107) Check if the destination title is protected .. (bug 37107) Check if the destination title is protected Change-Id: I3d8e170f90e03a9b49a24ec76c91414b3c8aaab9 --- M resources/mw.DestinationChecker.js M resources/mw.UploadWizardDetails.js 2 files changed, 23 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/07/23007/1 -- To view, visit https://gerrit.wikimedia.org/r/23007 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3d8e170f90e03a9b49a24ec76c91414b3c8aaab9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 39727) Location should be placed after Information temp... - change (mediawiki...UploadWizard[master])
TheDJ has uploaded a new change for review. Change subject: (bug 39727) Location should be placed after Information template. .. (bug 39727) Location should be placed after Information template. Change-Id: Id217810a4a4741a63aca2299149eea31419da91d --- M resources/mw.UploadWizardDetails.js 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/85/22985/1 -- To view, visit https://gerrit.wikimedia.org/r/22985 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id217810a4a4741a63aca2299149eea31419da91d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 33445) Remove default right margin on wikitables. - change (mediawiki/core[master])
TheDJ has uploaded a new change for review. Change subject: (bug 33445) Remove default right margin on wikitables. .. (bug 33445) Remove default right margin on wikitables. This makes sure that wikitables can be full width. When right or left floating a table, use class="wikitable floatleft" or class="wikitable floatright" to explicitly add a proper margin. Change-Id: I107d8d8da0a07055c320767cadb7a691f344a394 --- M skins/common/commonPrint.css M skins/common/shared.css 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/49/22949/1 -- To view, visit https://gerrit.wikimedia.org/r/22949 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I107d8d8da0a07055c320767cadb7a691f344a394 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 32483) Simple English should not use lang="simple" - change (mediawiki/core[master])
TheDJ has uploaded a new change for review. Change subject: (bug 32483) Simple English should not use lang="simple" .. (bug 32483) Simple English should not use lang="simple" * Add a new getBCP47Code() to Language.php that normalizes internal language codes using wgDummyLanguageCodes. * Let getHtmlCode() use this new code, so that inter language and other MediaWiki/Wikimedia specific codes get their proper language codes in the Html. Change-Id: I10b4473c7e53f027812bbccf26bb47aec15fddfd --- M RELEASE-NOTES-1.20 M includes/SkinTemplate.php M languages/Language.php 3 files changed, 41 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/27/22727/1 -- To view, visit https://gerrit.wikimedia.org/r/22727 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I10b4473c7e53f027812bbccf26bb47aec15fddfd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Raise an API error if we encounter X-Frame-Options: DENY - change (mediawiki/core[master])
TheDJ has uploaded a new change for review. Change subject: Raise an API error if we encounter X-Frame-Options: DENY .. Raise an API error if we encounter X-Frame-Options: DENY Change-Id: Ie0f0b2a46db098f246e3d0841be52ac64a293d5e --- M languages/messages/MessagesEn.php M languages/messages/MessagesQqq.php M resources/mediawiki.api/mediawiki.api.js 3 files changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/08/22708/1 -- To view, visit https://gerrit.wikimedia.org/r/22708 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie0f0b2a46db098f246e3d0841be52ac64a293d5e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Raise an API error if we encounter X-Frame-Options: DENY - change (mediawiki...UploadWizard[master])
TheDJ has uploaded a new change for review. Change subject: Raise an API error if we encounter X-Frame-Options: DENY .. Raise an API error if we encounter X-Frame-Options: DENY Change-Id: Icb29aec0f3eda49649590208e93ce54f3bdb57d8 --- M resources/mw.ApiUploadHandler.js 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/07/22707/1 -- To view, visit https://gerrit.wikimedia.org/r/22707 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icb29aec0f3eda49649590208e93ce54f3bdb57d8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove some code that was not in use anymore. - change (mediawiki...UploadWizard[master])
TheDJ has uploaded a new change for review. Change subject: Remove some code that was not in use anymore. .. Remove some code that was not in use anymore. Change-Id: Ibed6534e2b84cb2eaae5367517b93a8c1b1fb2c0 --- M resources/mw.UploadWizardUpload.js 1 file changed, 1 insertion(+), 14 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/86/22586/1 -- To view, visit https://gerrit.wikimedia.org/r/22586 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibed6534e2b84cb2eaae5367517b93a8c1b1fb2c0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 32606) use preventDefault in onclick handler. - change (mediawiki...UploadWizard[master])
TheDJ has uploaded a new change for review. Change subject: (bug 32606) use preventDefault in onclick handler. .. (bug 32606) use preventDefault in onclick handler. Change-Id: I265d6106db6a869a7b4e0522bf117d3f163f222c --- M resources/mw.UploadWizardUpload.js 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/75/21975/1 -- To view, visit https://gerrit.wikimedia.org/r/21975 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I265d6106db6a869a7b4e0522bf117d3f163f222c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 39220) Handle badfilename in UW - change (mediawiki...UploadWizard[master])
TheDJ has uploaded a new change for review. Change subject: (bug 39220) Handle badfilename in UW .. (bug 39220) Handle badfilename in UW * We can ignore initially, like all other title warnings, because we put it into stash anyways. * At the end, we should not receive it, because the title check should have already warned the user before the final upload. But for completeness we add it. Change-Id: I166a3b3e1aaee31cd9b538d12c8e33ac3f9ac2e4 --- M resources/mw.UploadWizardDetails.js M resources/mw.UploadWizardUpload.js 2 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/98/21698/1 -- To view, visit https://gerrit.wikimedia.org/r/21698 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I166a3b3e1aaee31cd9b538d12c8e33ac3f9ac2e4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 39702) Reset the button row when we remove an item. - change (mediawiki...UploadWizard[master])
TheDJ has uploaded a new change for review. Change subject: (bug 39702) Reset the button row when we remove an item. .. (bug 39702) Reset the button row when we remove an item. Change-Id: Icebd98025cd8d8d05d0845c48ef300bc7fdffde5 --- M resources/mw.UploadWizard.js 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/78/21678/1 -- To view, visit https://gerrit.wikimedia.org/r/21678 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icebd98025cd8d8d05d0845c48ef300bc7fdffde5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 26995) Update filename field on Special:Upload after sa... - change (mediawiki/core[master])
TheDJ has uploaded a new change for review. Change subject: (bug 26995) Update filename field on Special:Upload after sanitizing .. (bug 26995) Update filename field on Special:Upload after sanitizing Change-Id: I85656a3647766f8a35a7baae1c656d8dc315fc91 --- M RELEASE-NOTES-1.20 M includes/specials/SpecialUpload.php 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/78/21478/1 -- To view, visit https://gerrit.wikimedia.org/r/21478 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I85656a3647766f8a35a7baae1c656d8dc315fc91 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] UW: Make sure the error handler does not override the warnin... - change (mediawiki...UploadWizard[master])
TheDJ has uploaded a new change for review. Change subject: UW: Make sure the error handler does not override the warning .. UW: Make sure the error handler does not override the warning Change-Id: I2076889243d2d5570040617d9eaddc0f61b2ac69 --- M resources/mw.UploadWizardUpload.js 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/12/21412/1 -- To view, visit https://gerrit.wikimedia.org/r/21412 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2076889243d2d5570040617d9eaddc0f61b2ac69 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Make sure we can't have 'unknown-warning' anymore. - change (mediawiki...UploadWizard[master])
TheDJ has uploaded a new change for review. Change subject: Make sure we can't have 'unknown-warning' anymore. .. Make sure we can't have 'unknown-warning' anymore. Make unknown warnings in the first upload step expand to their raw value, so we at least know what's going on. Change-Id: I1cf3c9eeed5ce1b230da90ee8f2285f405036e9b --- M resources/mw.UploadWizardUploadInterface.js 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/10/21410/1 -- To view, visit https://gerrit.wikimedia.org/r/21410 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1cf3c9eeed5ce1b230da90ee8f2285f405036e9b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Make sure that duplicate-archive warning is recognized - change (mediawiki...UploadWizard[master])
TheDJ has uploaded a new change for review. Change subject: Make sure that duplicate-archive warning is recognized .. Make sure that duplicate-archive warning is recognized Change-Id: I886ba68816636898f2b858aadcb390eb248ab529 --- M resources/mw.UploadWizardDetails.js 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/05/21405/1 -- To view, visit https://gerrit.wikimedia.org/r/21405 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I886ba68816636898f2b858aadcb390eb248ab529 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 39553) Comment all altitude elements from UW for now. - change (mediawiki...UploadWizard[master])
TheDJ has uploaded a new change for review. Change subject: (bug 39553) Comment all altitude elements from UW for now. .. (bug 39553) Comment all altitude elements from UW for now. * The altitude doesn't validate on rational numbers, which occurs quite often. * Altitude is not a supported option of the commons location templates and the geohack service does not support it either https://wiki.toolserver.org/view/GeoHack Change-Id: I3812d9fb99f4b5012e3535fb6dbadde6411faa63 --- M resources/mw.UploadWizardDetails.js 1 file changed, 20 insertions(+), 15 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/04/21404/1 -- To view, visit https://gerrit.wikimedia.org/r/21404 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3812d9fb99f4b5012e3535fb6dbadde6411faa63 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 39284) Improve the tablesorter for currency. - change (mediawiki/core[master])
TheDJ has uploaded a new change for review. Change subject: (bug 39284) Improve the tablesorter for currency. .. (bug 39284) Improve the tablesorter for currency. * Make the detector for currency not trigger on cells starting with ? or . * Make it trigger on values ending with a currency symbol * Add the Yen sign * Add a basic testcase. Change-Id: I3c1fdf41db04ea0726ba7613fa5e1365f8fb8493 --- M RELEASE-NOTES-1.20 M resources/jquery/jquery.tablesorter.js M tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js 3 files changed, 32 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/85/21285/1 -- To view, visit https://gerrit.wikimedia.org/r/21285 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3c1fdf41db04ea0726ba7613fa5e1365f8fb8493 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Make links on Special:MergeAccount protocol relative - change (mediawiki...CentralAuth[master])
TheDJ has uploaded a new change for review. Change subject: Make links on Special:MergeAccount protocol relative .. Make links on Special:MergeAccount protocol relative Change-Id: Iaa83bc1a8317d33c9ff3dd981e7f481fa84403bc --- M specials/SpecialMergeAccount.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth refs/changes/87/19787/1 -- To view, visit https://gerrit.wikimedia.org/r/19787 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaa83bc1a8317d33c9ff3dd981e7f481fa84403bc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CentralAuth Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 39029) Correct the path towards the extension directory... - change (mediawiki...WikiEditor[master])
TheDJ has uploaded a new change for review. Change subject: (bug 39029) Correct the path towards the extension directory by prefixing it with wgScriptPath. .. (bug 39029) Correct the path towards the extension directory by prefixing it with wgScriptPath. Change-Id: I3b816c168af0f5f5dec68fae31b0ca83f23bd871 --- M WikiEditor.i18n.php M modules/jquery.wikiEditor.toolbar.config.js 2 files changed, 113 insertions(+), 113 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor refs/changes/44/17644/1 -- To view, visit https://gerrit.wikimedia.org/r/17644 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3b816c168af0f5f5dec68fae31b0ca83f23bd871 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikiEditor Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 31817) Teach Tidy about the HTML5 inline tag bdi. - change (mediawiki/core[master])
TheDJ has uploaded a new change for review. Change subject: (bug 31817) Teach Tidy about the HTML5 inline tag bdi. .. (bug 31817) Teach Tidy about the HTML5 inline tag bdi. This is a follow up to change Ib7e6553f Change-Id: I4d172e85f103e5fa1f8abbf73ad40cbd7bfbe06e --- M includes/tidy.conf 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/74/17174/1 -- To view, visit https://gerrit.wikimedia.org/r/17174 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4d172e85f103e5fa1f8abbf73ad40cbd7bfbe06e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 31644) [MERGE DEPENDENCY] Let WikiMap url builders retu... - change (mediawiki/core[master])
TheDJ has uploaded a new change for review. Change subject: (bug 31644) [MERGE DEPENDENCY] Let WikiMap url builders return full urls instead of canonical urls .. (bug 31644) [MERGE DEPENDENCY] Let WikiMap url builders return full urls instead of canonical urls * This commit depends on a commit of globalusage https://gerrit.wikimedia.org/r/17117 * This allows GlobalUsage, CentralAuth and AbuseLog extensions to use protocol relative URLs. Change-Id: I7e65bd029f359c36770aa48e6663f26a671b92c0 --- M RELEASE-NOTES-1.20 M includes/WikiMap.php 2 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/18/17118/1 -- To view, visit https://gerrit.wikimedia.org/r/17118 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7e65bd029f359c36770aa48e6663f26a671b92c0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bug 31682: Fix initial focus of edittools on Special:Upload ... - change (mediawiki/core[master])
TheDJ has uploaded a new change for review. Change subject: Bug 31682: Fix initial focus of edittools on Special:Upload page. .. Bug 31682: Fix initial focus of edittools on Special:Upload page. This is a followup to r103074 Change-Id: I8deff7d66b7e0327e86f0bc0457d6359e1c1bad3 --- M RELEASE-NOTES-1.20 M resources/mediawiki.action/mediawiki.action.edit.js 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/28/16928/1 -- To view, visit https://gerrit.wikimedia.org/r/16928 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8deff7d66b7e0327e86f0bc0457d6359e1c1bad3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add lang and hreflang attributes to the language links of th... - change (mediawiki/core[master])
TheDJ has uploaded a new change for review. Change subject: Add lang and hreflang attributes to the language links of the login page. .. Add lang and hreflang attributes to the language links of the login page. - Adding these attribues should make them easier to interpret for VoiceOver and other assitive technologies. - This assumes that people will enter the name of the language in the target language to MediaWiki:loginlanguagelinks, which is a convention but not a requirement of course. However I think making the bet that people actually do that is safe enough. - Switch the name of the old attr variable to query, which better reflects what it is supposed to be used for. Change-Id: I0cdae9f1e539b9b9c2b99ea1db1ba620bdc5 --- M RELEASE-NOTES-1.20 M includes/specials/SpecialUserlogin.php 2 files changed, 11 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/14/16914/1 -- To view, visit https://gerrit.wikimedia.org/r/16914 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0cdae9f1e539b9b9c2b99ea1db1ba620bdc5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] bug 36073 Use mw-imagepage-linkstoimage-ns as a class instea... - change (mediawiki/core[master])
TheDJ has uploaded a new change for review. Change subject: bug 36073 Use mw-imagepage-linkstoimage-ns as a class instead of an ID .. bug 36073 Use mw-imagepage-linkstoimage-ns as a class instead of an ID This avoids multiple defines of the same ID on a File page. Change-Id: I0f8ae37d74f2ec519361b2af164e115f6efa4ac6 --- M RELEASE-NOTES-1.20 M includes/ImagePage.php 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/47/15747/1 -- To view, visit https://gerrit.wikimedia.org/r/15747 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0f8ae37d74f2ec519361b2af164e115f6efa4ac6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Don't use php shorttags, because not everyone has them enabl... - change (mediawiki...Scribunto[master])
TheDJ has uploaded a new change for review. Change subject: Don't use php shorttags, because not everyone has them enabled. .. Don't use php shorttags, because not everyone has them enabled. Change-Id: Ia6c992d32af25932fd3d91c970058849f1766e9e --- M Scribunto.magic.php 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Scribunto refs/changes/36/13936/1 -- To view, visit https://gerrit.wikimedia.org/r/13936 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia6c992d32af25932fd3d91c970058849f1766e9e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Scribunto Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bug 37769 Fix directionaly of floatright/floatleft classes o... - change (mediawiki...MobileFrontend[master])
TheDJ has uploaded a new change for review. Change subject: Bug 37769 Fix directionaly of floatright/floatleft classes on mobile. .. Bug 37769 Fix directionaly of floatright/floatleft classes on mobile. - Added the noflip janus annotation, just as on skins/common/commonContent.css of core - Make the classes have the same scope as our core classes. Change-Id: I11ee6fc50305f4699a5f89f18176396f45d8722d --- M stylesheets/common.css 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/41/13641/1 -- To view, visit https://gerrit.wikimedia.org/r/13641 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I11ee6fc50305f4699a5f89f18176396f45d8722d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: TheDJ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
