[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: CX2: Correct the data value for InstructionsTool

2017-05-31 Thread Nikerabbit (Code Review) 
Nikerabbit has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/356328 )

Change subject: CX2: Correct the data value for InstructionsTool
..


CX2: Correct the data value for InstructionsTool

The InstructionsTool does not have any model associated. So
calling model.getId will throw error. Set the data value
as instructions::1

Change-Id: I6c3b24e0e019afa0b4c518e0e92b4bea342f92ff
---
M modules/tools/mw.cx.tools.InstructionsTool.js
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Nikerabbit: Looks good to me, approved



diff --git a/modules/tools/mw.cx.tools.InstructionsTool.js 
b/modules/tools/mw.cx.tools.InstructionsTool.js
index 361fc98..29b9cf0 100644
--- a/modules/tools/mw.cx.tools.InstructionsTool.js
+++ b/modules/tools/mw.cx.tools.InstructionsTool.js
@@ -91,5 +91,9 @@
return $content;
 };
 
+mw.cx.tools.InstructionsTool.prototype.getData = function () {
+   return this.constructor.static.name + '::' + 1;
+};
+
 /* Register */
 mw.cx.tools.translationToolFactory.register( mw.cx.tools.InstructionsTool );

-- 
To view, visit https://gerrit.wikimedia.org/r/356328
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6c3b24e0e019afa0b4c518e0e92b4bea342f92ff
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: CX2: Correct the data value for InstructionsTool

2017-05-30 Thread Santhosh (Code Review) 
Santhosh has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/356328 )

Change subject: CX2: Correct the data value for InstructionsTool
..

CX2: Correct the data value for InstructionsTool

The InstructionsTool does not have any model associated. So
calling model.getId will throw error. Set the data value
as instructions::1

Change-Id: I6c3b24e0e019afa0b4c518e0e92b4bea342f92ff
---
M modules/tools/mw.cx.tools.InstructionsTool.js
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/28/356328/1

diff --git a/modules/tools/mw.cx.tools.InstructionsTool.js 
b/modules/tools/mw.cx.tools.InstructionsTool.js
index 361fc98..29b9cf0 100644
--- a/modules/tools/mw.cx.tools.InstructionsTool.js
+++ b/modules/tools/mw.cx.tools.InstructionsTool.js
@@ -91,5 +91,9 @@
return $content;
 };
 
+mw.cx.tools.InstructionsTool.prototype.getData = function () {
+   return this.constructor.static.name + '::' + 1;
+};
+
 /* Register */
 mw.cx.tools.translationToolFactory.register( mw.cx.tools.InstructionsTool );

-- 
To view, visit https://gerrit.wikimedia.org/r/356328
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c3b24e0e019afa0b4c518e0e92b4bea342f92ff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits