jenkins-bot has submitted this change and it was merged.
Change subject: Add pages with Cite errors to a tracking category
..
Add pages with Cite errors to a tracking category
Bug: T104792
Change-Id: I6f8b12788a20480bd8880332238d545ee70a8ef9
---
M Cite_body.php
M extension.json
M i18n/en.json
M i18n/qqq.json
4 files changed, 11 insertions(+), 0 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
Siebrand: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/Cite_body.php b/Cite_body.php
index 41021b0..deab839 100644
--- a/Cite_body.php
+++ b/Cite_body.php
@@ -252,6 +252,7 @@
# be equivalent , for compatability with
#tag.
if ( $key == false ) {
$this->mRefCallStack[] = false;
+
return $this->error( 'cite_error_ref_no_input'
);
} else {
$str = null;
@@ -1147,6 +1148,8 @@
->inContentLanguage()
->plain();
+ $this->mParser->addTrackingCategory(
'cite-tracking-category-cite-error' );
+
$ret = '' . $msg .
'';
if ( $parse === 'parse' ) {
diff --git a/extension.json b/extension.json
index e983e36..dfa51d7 100644
--- a/extension.json
+++ b/extension.json
@@ -65,5 +65,8 @@
"ParserTestFiles": [
"citeParserTests.txt"
],
+ "TrackingCategories": [
+ "cite-tracking-category-cite-error"
+ ],
"manifest_version": 1
}
diff --git a/i18n/en.json b/i18n/en.json
index 5c5ad60..4d89e0b 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -11,6 +11,7 @@
"Steve Sanbeg",
"Marius Hoch",
"Brion Vibber",
+ "Amir E. Aharoni",
"Ævar Arnfjörð Bjarmason"
]
},
@@ -32,6 +33,8 @@
"cite_error_references_missing_key": "[ tag with
name \"$1\" defined in is not used in prior
text.",
"cite_error_references_no_key": "][ tag defined
in has no name attribute.",
"cite_error_empty_references_define": "][ tag
defined in with name \"$1\" has no content.",
+ "cite-tracking-category-cite-error": "Pages with reference errors",
+ "cite-tracking-category-cite-error-desc": "Pages in this category have
errors in the usage of references tags.",
"cite_reference_link_key_with_num": "$1_$2",
"cite_reference_link_prefix": "cite_ref-",
"cite_reference_link_suffix": "",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 5798902..4d0f2f2 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -33,6 +33,8 @@
"cite_error_references_missing_key": "Error message shown when using
something like\n\n\n...\n\n\nand the reference
is not used anywhere in
the page text.\n\nParameters:\n* $1 - the name of the unused reference (in the
example above, “refname”)",
"cite_error_references_no_key": "Error message shown when a
inside
does not have a name
attribute.",
"cite_error_empty_references_define": "Error message shown when there
is a inside
, but it does not have any content,
e.g.\n\n\n\n\n\n\nParameters:\n* $1 - the
name of the erroneous
(in the above example, “foo”)",
+ "cite-tracking-category-cite-error": "Tracking category name.",
+ "cite-tracking-category-cite-error-desc": "Tracking category
description.",
"cite_reference_link_key_with_num": "{{optional}}\nParameters:\n* $1 -
the key\n* $2 - the number of the key",
"cite_reference_link_prefix": "{{optional}}",
"cite_reference_link_suffix": "{{optional}}",
--
To view, visit https://gerrit.wikimedia.org/r/222897
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f8b12788a20480bd8880332238d545ee70a8ef9
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/Cite
Gerrit-Branch: master
Gerrit-Owner: Amire80
Gerrit-Reviewer: Alex Monk
Gerrit-Reviewer: Amire80
Gerrit-Reviewer: Bartosz Dziewoński
Gerrit-Reviewer: Brion VIBBER
Gerrit-Reviewer: Eranroz
Gerrit-Reviewer: Jackmcbarn
Gerrit-Reviewer: Jforrester
Gerrit-Reviewer: Legoktm
Gerrit-Reviewer: Se4598
Gerrit-Reviewer: Siebrand
Gerrit-Reviewer: Tim Starling
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
]
