[MediaWiki-commits] [Gerrit] Cleanup global injections - change (mediawiki...Wikibase)

2014-01-20 Thread Adrian Lang (Code Review)
Adrian Lang has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/108505


Change subject: Cleanup global injections
..

Cleanup global injections

Change-Id: I85377bf5f000ba2234f7f357792d287d7b7c21ef
---
M lib/resources/formatters/ApiBasedValueFormatter.js
M lib/resources/formatters/wikibase.formatters.register.js
M lib/resources/jquery.ui/jquery.ui.TemplatedWidget.js
M 
lib/resources/jquery.valueview.experts.wikibase/experts.wikibase.EntityIdInput.js
M 
lib/resources/jquery.valueview.experts.wikibase/experts.wikibase.EntityIdValue.js
M lib/resources/jquery.valueview.experts.wikibase/experts.wikibase.js
M lib/resources/jquery.wikibase/jquery.wikibase.claimlistview.js
M lib/resources/jquery.wikibase/jquery.wikibase.listview.ListItemAdapter.js
M lib/resources/jquery.wikibase/jquery.wikibase.listview.js
M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.ViewState.js
M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
M 
lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Value.js
M 
lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Variation.js
M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.js
M lib/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js
M lib/resources/jquery.wikibase/toolbar/movetoolbar.js
M lib/resources/jquery.wikibase/toolbar/removetoolbar.js
M lib/resources/jquery.wikibase/toolbar/toolbar.js
M lib/resources/jquery.wikibase/toolbar/toolbarbase.js
M lib/resources/jquery.wikibase/toolbar/toolbarbutton.js
M lib/resources/jquery.wikibase/toolbar/toolbarcontroller.js
M lib/resources/jquery.wikibase/toolbar/toolbareditgroup.js
M lib/resources/wikibase.RepoApi/wikibase.AbstractedRepoApi.js
M lib/resources/wikibase.RevisionStore.js
M lib/resources/wikibase.ui.Base.js
M lib/resources/wikibase.utilities/wikibase.utilities.ClaimGuidGenerator.js
M lib/resources/wikibase.utilities/wikibase.utilities.GuidGenerator.js
M lib/resources/wikibase.utilities/wikibase.utilities.jQuery.js
M lib/resources/wikibase.utilities/wikibase.utilities.ui.StatableObject.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.listview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.siteselector.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.snaklistview.tests.js
M 
lib/tests/qunit/jquery.wikibase/jquery.wikibase.statementview.RankSelector.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.wbtooltip.tests.js
M lib/tests/qunit/jquery.wikibase/toolbar/movetoolbar.tests.js
M lib/tests/qunit/jquery.wikibase/toolbar/toolbar.tests.js
M lib/tests/qunit/jquery.wikibase/toolbar/toolbarbutton.tests.js
M lib/tests/qunit/jquery.wikibase/toolbar/toolbareditgroup.tests.js
M lib/tests/qunit/jquery.wikibase/toolbar/toolbarlabel.tests.js
M lib/tests/qunit/wikibase.ui.SiteLinksEditTool.tests.js
41 files changed, 83 insertions(+), 89 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/05/108505/1

diff --git a/lib/resources/formatters/ApiBasedValueFormatter.js 
b/lib/resources/formatters/ApiBasedValueFormatter.js
index 1e018a2..ae4c81d 100644
--- a/lib/resources/formatters/ApiBasedValueFormatter.js
+++ b/lib/resources/formatters/ApiBasedValueFormatter.js
@@ -2,7 +2,7 @@
  * @licence GNU GPL v2+
  * @author H. Snater  mediaw...@snater.com 
  */
-( function( mw, $, wb, vf ) {
+( function( $, wb, vf ) {
'use strict';
 
var PARENT = vf.ValueFormatter;
@@ -38,4 +38,4 @@
 
} );
 
-}( mediaWiki, jQuery, wikibase, valueFormatters ) );
+}( jQuery, wikibase, valueFormatters ) );
diff --git a/lib/resources/formatters/wikibase.formatters.register.js 
b/lib/resources/formatters/wikibase.formatters.register.js
index 6b08e86..9e2efca 100644
--- a/lib/resources/formatters/wikibase.formatters.register.js
+++ b/lib/resources/formatters/wikibase.formatters.register.js
@@ -2,7 +2,7 @@
  * @licence GNU GPL v2+
  * @author H. Snater  mediaw...@snater.com 
  */
-( function( mw, wb, vf, dv ) {
+( function( mw, wb, dv ) {
'use strict';
 
// Register Wikibase specific formatter:
@@ -12,4 +12,4 @@
wb.formatters.QuantityFormatter
);
 
-}( mediaWiki, wikibase, valueFormatters, dataValues ) );
+}( mediaWiki, wikibase, dataValues ) );
diff --git a/lib/resources/jquery.ui/jquery.ui.TemplatedWidget.js 
b/lib/resources/jquery.ui/jquery.ui.TemplatedWidget.js
index 3fe8978..b71d822 100644
--- a/lib/resources/jquery.ui/jquery.ui.TemplatedWidget.js
+++ b/lib/resources/jquery.ui/jquery.ui.TemplatedWidget.js
@@ -3,7 +3,7 @@
  * @licence GNU GPL v2+
  * @author Daniel Werner  daniel.wer...@wikimedia.de 
  */
-( function( mw, wb, $ ) {
+( function( wb, $ ) {
'use strict';
 
var PARENT =  $.Widget;
@@ -134,4 +134,4 @@
}
} );
 
-}( mediaWiki, 

[MediaWiki-commits] [Gerrit] Cleanup global injections - change (mediawiki...Wikibase)

2014-01-20 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Cleanup global injections
..


Cleanup global injections

Change-Id: I85377bf5f000ba2234f7f357792d287d7b7c21ef
---
M lib/resources/formatters/ApiBasedValueFormatter.js
M lib/resources/formatters/wikibase.formatters.register.js
M lib/resources/jquery.ui/jquery.ui.TemplatedWidget.js
M 
lib/resources/jquery.valueview.experts.wikibase/experts.wikibase.EntityIdInput.js
M 
lib/resources/jquery.valueview.experts.wikibase/experts.wikibase.EntityIdValue.js
M lib/resources/jquery.valueview.experts.wikibase/experts.wikibase.js
M lib/resources/jquery.wikibase/jquery.wikibase.claimlistview.js
M lib/resources/jquery.wikibase/jquery.wikibase.listview.ListItemAdapter.js
M lib/resources/jquery.wikibase/jquery.wikibase.listview.js
M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.ViewState.js
M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
M 
lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Value.js
M 
lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Variation.js
M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.js
M lib/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js
M lib/resources/jquery.wikibase/toolbar/movetoolbar.js
M lib/resources/jquery.wikibase/toolbar/removetoolbar.js
M lib/resources/jquery.wikibase/toolbar/toolbar.js
M lib/resources/jquery.wikibase/toolbar/toolbarbase.js
M lib/resources/jquery.wikibase/toolbar/toolbarbutton.js
M lib/resources/jquery.wikibase/toolbar/toolbarcontroller.js
M lib/resources/jquery.wikibase/toolbar/toolbareditgroup.js
M lib/resources/wikibase.RepoApi/wikibase.AbstractedRepoApi.js
M lib/resources/wikibase.RevisionStore.js
M lib/resources/wikibase.ui.Base.js
M lib/resources/wikibase.utilities/wikibase.utilities.ClaimGuidGenerator.js
M lib/resources/wikibase.utilities/wikibase.utilities.GuidGenerator.js
M lib/resources/wikibase.utilities/wikibase.utilities.jQuery.js
M lib/resources/wikibase.utilities/wikibase.utilities.ui.StatableObject.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.listview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.siteselector.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.snaklistview.tests.js
M 
lib/tests/qunit/jquery.wikibase/jquery.wikibase.statementview.RankSelector.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.wbtooltip.tests.js
M lib/tests/qunit/jquery.wikibase/toolbar/movetoolbar.tests.js
M lib/tests/qunit/jquery.wikibase/toolbar/toolbar.tests.js
M lib/tests/qunit/jquery.wikibase/toolbar/toolbarbutton.tests.js
M lib/tests/qunit/jquery.wikibase/toolbar/toolbareditgroup.tests.js
M lib/tests/qunit/jquery.wikibase/toolbar/toolbarlabel.tests.js
M lib/tests/qunit/wikibase.ui.SiteLinksEditTool.tests.js
41 files changed, 83 insertions(+), 89 deletions(-)

Approvals:
  Jeroen De Dauw: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/resources/formatters/ApiBasedValueFormatter.js 
b/lib/resources/formatters/ApiBasedValueFormatter.js
index 1e018a2..ae4c81d 100644
--- a/lib/resources/formatters/ApiBasedValueFormatter.js
+++ b/lib/resources/formatters/ApiBasedValueFormatter.js
@@ -2,7 +2,7 @@
  * @licence GNU GPL v2+
  * @author H. Snater  mediaw...@snater.com 
  */
-( function( mw, $, wb, vf ) {
+( function( $, wb, vf ) {
'use strict';
 
var PARENT = vf.ValueFormatter;
@@ -38,4 +38,4 @@
 
} );
 
-}( mediaWiki, jQuery, wikibase, valueFormatters ) );
+}( jQuery, wikibase, valueFormatters ) );
diff --git a/lib/resources/formatters/wikibase.formatters.register.js 
b/lib/resources/formatters/wikibase.formatters.register.js
index 6b08e86..9e2efca 100644
--- a/lib/resources/formatters/wikibase.formatters.register.js
+++ b/lib/resources/formatters/wikibase.formatters.register.js
@@ -2,7 +2,7 @@
  * @licence GNU GPL v2+
  * @author H. Snater  mediaw...@snater.com 
  */
-( function( mw, wb, vf, dv ) {
+( function( mw, wb, dv ) {
'use strict';
 
// Register Wikibase specific formatter:
@@ -12,4 +12,4 @@
wb.formatters.QuantityFormatter
);
 
-}( mediaWiki, wikibase, valueFormatters, dataValues ) );
+}( mediaWiki, wikibase, dataValues ) );
diff --git a/lib/resources/jquery.ui/jquery.ui.TemplatedWidget.js 
b/lib/resources/jquery.ui/jquery.ui.TemplatedWidget.js
index 3fe8978..b71d822 100644
--- a/lib/resources/jquery.ui/jquery.ui.TemplatedWidget.js
+++ b/lib/resources/jquery.ui/jquery.ui.TemplatedWidget.js
@@ -3,7 +3,7 @@
  * @licence GNU GPL v2+
  * @author Daniel Werner  daniel.wer...@wikimedia.de 
  */
-( function( mw, wb, $ ) {
+( function( wb, $ ) {
'use strict';
 
var PARENT =  $.Widget;
@@ -134,4 +134,4 @@
}
} );
 
-}( mediaWiki, wikibase, jQuery ) );
+}( wikibase, jQuery ) );
diff