[MediaWiki-commits] [Gerrit] Explicitly define module position - change (mediawiki...Modern)

2015-05-06 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Explicitly define module position
..


Explicitly define module position

Style modules currently added through addModuleStyles default
to being in the head (top position). This is an unhealthy default,
since only critical styles that are needed at pageload should be
in the head. In order to be able to switch the default to bottom,
existing module positions have to be defined explicitly.

Bug: T97410
Change-Id: I05048fd3864ec918d365e5c7cbd68dcec78d4ea3
---
M skin.json
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/skin.json b/skin.json
index 98ba815..10e562c 100644
--- a/skin.json
+++ b/skin.json
@@ -19,6 +19,7 @@
},
ResourceModules: {
skins.modern: {
+   position: top,
styles: {
resources/main.css: {
media: screen

-- 
To view, visit https://gerrit.wikimedia.org/r/208984
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I05048fd3864ec918d365e5c7cbd68dcec78d4ea3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Modern
Gerrit-Branch: master
Gerrit-Owner: Gilles gdu...@wikimedia.org
Gerrit-Reviewer: Bartosz Dziewoński matma@gmail.com
Gerrit-Reviewer: Legoktm legoktm.wikipe...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Explicitly define module position - change (mediawiki...Modern)

2015-05-05 Thread Gilles (Code Review) 
Gilles has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/208984

Change subject: Explicitly define module position
..

Explicitly define module position

Style modules currently added through addModuleStyles default
to being in the head (top position). This is an unhealthy default,
since only critical styles that are needed at pageload should be
in the head. In order to be able to switch the default to bottom,
existing module positions have to be defined explicitly.

Bug: T97410
Change-Id: I05048fd3864ec918d365e5c7cbd68dcec78d4ea3
---
M skin.json
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Modern 
refs/changes/84/208984/1

diff --git a/skin.json b/skin.json
index 98ba815..10e562c 100644
--- a/skin.json
+++ b/skin.json
@@ -19,6 +19,7 @@
},
ResourceModules: {
skins.modern: {
+   position: top,
styles: {
resources/main.css: {
media: screen

-- 
To view, visit https://gerrit.wikimedia.org/r/208984
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I05048fd3864ec918d365e5c7cbd68dcec78d4ea3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Modern
Gerrit-Branch: master
Gerrit-Owner: Gilles gdu...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Explicitly define module position - change (mediawiki...Modern)

2015-05-05 Thread Gilles (Code Review) 
Gilles has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/208981

Change subject: Explicitly define module position
..

Explicitly define module position

Style modules currently added through addModuleStyles default
to being in the head (top position). This is an unhealthy default,
since only critical styles that are needed at pageload should be
in the head. In order to be able to switch the default to bottom,
existing module positions have to be defined explicitly.

Bug: T97410
Change-Id: I2e8288edcf0837b855665710eb417f743001fec1
---
M Modern.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Modern 
refs/changes/81/208981/1

diff --git a/Modern.php b/Modern.php
index f5b3013..93eef8c 100644
--- a/Modern.php
+++ b/Modern.php
@@ -41,6 +41,7 @@
 
 // Register modules
 $wgResourceModules['skins.modern'] = array(
+   'position' = 'top',
'styles' = array(
'resources/main.css' = array( 'media' = 'screen' ),
'resources/print.css' = array( 'media' = 'print' ),

-- 
To view, visit https://gerrit.wikimedia.org/r/208981
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e8288edcf0837b855665710eb417f743001fec1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Modern
Gerrit-Branch: master
Gerrit-Owner: Gilles gdu...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits