[MediaWiki-commits] [Gerrit] Hygiene: Remove useless parent layout in featured page widget - change (apps...wikipedia)
jenkins-bot has submitted this change and it was merged. Change subject: Hygiene: Remove useless parent layout in featured page widget .. Hygiene: Remove useless parent layout in featured page widget Lint warning: ../../res/layout/widget_featured_page.xml:25: This LinearLayout layout or its FrameLayout parent is useless; transfer the background attribute to the other view Change-Id: Idc1f5c0864b1340b11735d059d21dfc35923379f --- M wikipedia/res/layout/widget_featured_page.xml 1 file changed, 23 insertions(+), 27 deletions(-) Approvals: Dbrant: Looks good to me, approved jenkins-bot: Verified diff --git a/wikipedia/res/layout/widget_featured_page.xml b/wikipedia/res/layout/widget_featured_page.xml index 10952ce..fc3085f 100644 --- a/wikipedia/res/layout/widget_featured_page.xml +++ b/wikipedia/res/layout/widget_featured_page.xml @@ -16,37 +16,33 @@ android:src=@drawable/about_logo android:contentDescription=@null android:layout_gravity=center_vertical/ -FrameLayout +LinearLayout android:layout_width=match_parent android:layout_height=match_parent android:paddingLeft=16dp android:paddingRight=16dp -android:background=@drawable/widget_shape_inner -LinearLayout +android:gravity=center_vertical +android:background=@drawable/widget_shape_inner +android:orientation=vertical +TextView android:layout_width=match_parent android:layout_height=wrap_content -android:layout_gravity=center_vertical -android:orientation=vertical -TextView -android:layout_width=match_parent -android:layout_height=wrap_content -style=@style/RtlAwareTextView -android:layout_marginBottom=2dp -android:text=@string/widget_title_featured_page -android:ellipsize=end -android:textColor=@color/widget_title_text -/ -TextView -android:id=@+id/widget_content_text -android:layout_width=match_parent -android:layout_height=wrap_content -style=@style/RtlAwareTextView -android:textAppearance=?android:attr/textAppearanceMedium -android:textColor=@color/widget_content_text -android:maxLines=2 -android:ellipsize=end -tools:text=Sample content -/ -/LinearLayout -/FrameLayout +style=@style/RtlAwareTextView +android:layout_marginBottom=2dp +android:text=@string/widget_title_featured_page +android:ellipsize=end +android:textColor=@color/widget_title_text +/ +TextView +android:id=@+id/widget_content_text +android:layout_width=match_parent +android:layout_height=wrap_content +style=@style/RtlAwareTextView +android:textAppearance=?android:attr/textAppearanceMedium +android:textColor=@color/widget_content_text +android:maxLines=2 +android:ellipsize=end +tools:text=Sample content +/ +/LinearLayout /LinearLayout \ No newline at end of file -- To view, visit https://gerrit.wikimedia.org/r/222870 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc1f5c0864b1340b11735d059d21dfc35923379f Gerrit-PatchSet: 2 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: BearND bsitzm...@wikimedia.org Gerrit-Reviewer: Dbrant dbr...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Hygiene: Remove useless parent layout in featured page widget - change (apps...wikipedia)
BearND has uploaded a new change for review. https://gerrit.wikimedia.org/r/223235 Change subject: Hygiene: Remove useless parent layout in featured page widget .. Hygiene: Remove useless parent layout in featured page widget Lint warning: ../../res/layout/widget_featured_page.xml:25: This LinearLayout layout or its FrameLayout parent is useless; transfer the background attribute to the other view Change-Id: Ie3fc706168b8cde9aea21766290ed8aef7aa13b5 --- M wikipedia/res/layout/activity_page.xml M wikipedia/src/main/java/org/wikipedia/page/PageActivity.java M wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java 3 files changed, 32 insertions(+), 28 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/35/223235/1 diff --git a/wikipedia/res/layout/activity_page.xml b/wikipedia/res/layout/activity_page.xml index 7e9f29f..ca4ea9a 100644 --- a/wikipedia/res/layout/activity_page.xml +++ b/wikipedia/res/layout/activity_page.xml @@ -70,30 +70,32 @@ android:id=@+id/main_toolbar_inner_container android:layout_width=match_parent android:layout_height=match_parent -LinearLayout -android:id=@+id/main_search_bar -android:layout_width=match_parent -android:layout_height=36dp -android:orientation=horizontal -android:layout_gravity=center_vertical -android:layout_marginLeft=4dp -android:layout_marginRight=4dp -android:paddingLeft=6dp -android:paddingRight=6dp -ImageView -android:id=@+id/main_search_bar_icon -android:layout_width=24dp -android:layout_height=24dp -android:layout_gravity=center_vertical - android:contentDescription=@string/search_hint -android:src=@drawable/ic_search/ +!--LinearLayout-- +!--android:id=@+id/main_search_bar-- +!--android:layout_width=match_parent-- +!--android:layout_height=36dp-- +!--android:orientation=horizontal-- +!--android:layout_gravity=center_vertical-- +!--android:layout_marginLeft=4dp-- +!--android:layout_marginRight=4dp-- +!--android:paddingLeft=6dp-- +!--android:paddingRight=6dp-- +!--ImageView-- + !--android:id=@+id/main_search_bar_icon-- +!--android:layout_width=24dp-- +!--android:layout_height=24dp-- + !--android:layout_gravity=center_vertical-- + !--android:contentDescription=@string/search_hint-- +!--android:src=@drawable/ic_search/-- TextView android:id=@+id/main_search_bar_text -android:layout_width=wrap_content -android:layout_height=match_parent -android:paddingLeft=4dp -android:paddingRight=4dp -android:gravity=center +android:layout_width=match_parent +android:layout_height=36dp +android:layout_marginLeft=4dp +android:layout_marginRight=4dp +android:paddingLeft=10dp +android:paddingRight=10dp +android:gravity=center_vertical android:text=@string/search_hint android:textColor=@android:color/white android:textSize=@dimen/searchTextSize @@ -103,8 +105,11 @@ android:shadowDx=1 android:shadowDy=1 android:shadowRadius=2 -android:layout_gravity=center_vertical/ -/LinearLayout
[MediaWiki-commits] [Gerrit] Hygiene: Remove useless parent layout in featured page widget - change (apps...wikipedia)
BearND has uploaded a new change for review. https://gerrit.wikimedia.org/r/222870 Change subject: Hygiene: Remove useless parent layout in featured page widget .. Hygiene: Remove useless parent layout in featured page widget Lint warning: ../../res/layout/widget_featured_page.xml:25: This LinearLayout layout or its FrameLayout parent is useless; transfer the background attribute to the other view Change-Id: Idc1f5c0864b1340b11735d059d21dfc35923379f --- M wikipedia/res/layout/widget_featured_page.xml 1 file changed, 5 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/70/222870/1 diff --git a/wikipedia/res/layout/widget_featured_page.xml b/wikipedia/res/layout/widget_featured_page.xml index 10952ce..1d2ad37 100644 --- a/wikipedia/res/layout/widget_featured_page.xml +++ b/wikipedia/res/layout/widget_featured_page.xml @@ -16,16 +16,13 @@ android:src=@drawable/about_logo android:contentDescription=@null android:layout_gravity=center_vertical/ -FrameLayout -android:layout_width=match_parent -android:layout_height=match_parent -android:paddingLeft=16dp -android:paddingRight=16dp -android:background=@drawable/widget_shape_inner LinearLayout android:layout_width=match_parent -android:layout_height=wrap_content -android:layout_gravity=center_vertical +android:layout_height=match_parent +android:paddingLeft=16dp +android:paddingRight=16dp +android:gravity=center_vertical +android:background=@drawable/widget_shape_inner android:orientation=vertical TextView android:layout_width=match_parent @@ -48,5 +45,4 @@ tools:text=Sample content / /LinearLayout -/FrameLayout /LinearLayout \ No newline at end of file -- To view, visit https://gerrit.wikimedia.org/r/222870 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idc1f5c0864b1340b11735d059d21dfc35923379f Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: BearND bsitzm...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
