[MediaWiki-commits] [Gerrit] Improve statsbar updates - change (mediawiki...Translate)
jenkins-bot has submitted this change and it was merged.
Change subject: Improve statsbar updates
..
Improve statsbar updates
Message can be in one of the following status:
* untranslated
* translated
* fuzzy
* proofread (implies translated)
Handle updates accordingly.
Change-Id: Ied2e57bb202e8eb082068069c8a808649bf43c9d
---
M resources/js/ext.translate.statsbar.js
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Glaisher: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/js/ext.translate.statsbar.js
b/resources/js/ext.translate.statsbar.js
index f3e24ec..4535063 100644
--- a/resources/js/ext.translate.statsbar.js
+++ b/resources/js/ext.translate.statsbar.js
@@ -48,7 +48,8 @@
statsbar.$statsBar.on( 'change', function ( event, to,
from ) {
for ( i = 0; i < languageStats.length; i++ ) {
if ( languageStats[ i ].group ===
statsbar.group ) {
- if ( to === 'translated' &&
from === 'untranslated' ) {
+ // Changing a proofread message
does not create a new translation
+ if ( to === 'translated' &&
from !== 'proofread' ) {
languageStats[ i
].translated++;
}
if ( to === 'proofread' ) {
@@ -64,7 +65,8 @@
if ( from === 'proofread' ) {
languageStats[ i
].proofread--;
}
- if ( from === 'translated' ) {
+ // Proofreading a message does
not remove translation
+ if ( from === 'translated' &&
to !== 'proofread' ) {
languageStats[ i
].translated--;
}
break;
--
To view, visit https://gerrit.wikimedia.org/r/294071
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied2e57bb202e8eb082068069c8a808649bf43c9d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit
Gerrit-Reviewer: Glaisher
Gerrit-Reviewer: Santhosh
Gerrit-Reviewer: Siebrand
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Improve statsbar updates - change (mediawiki...Translate)
Nikerabbit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/294071
Change subject: Improve statsbar updates
..
Improve statsbar updates
Message can be in one of the following status:
* untranslated
* translated
* fuzzy
* proofread (implies translated)
Handle updates accordingly.
Change-Id: Ied2e57bb202e8eb082068069c8a808649bf43c9d
---
M resources/js/ext.translate.statsbar.js
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/71/294071/1
diff --git a/resources/js/ext.translate.statsbar.js
b/resources/js/ext.translate.statsbar.js
index f3e24ec..4535063 100644
--- a/resources/js/ext.translate.statsbar.js
+++ b/resources/js/ext.translate.statsbar.js
@@ -48,7 +48,8 @@
statsbar.$statsBar.on( 'change', function ( event, to,
from ) {
for ( i = 0; i < languageStats.length; i++ ) {
if ( languageStats[ i ].group ===
statsbar.group ) {
- if ( to === 'translated' &&
from === 'untranslated' ) {
+ // Changing a proofread message
does not create a new translation
+ if ( to === 'translated' &&
from !== 'proofread' ) {
languageStats[ i
].translated++;
}
if ( to === 'proofread' ) {
@@ -64,7 +65,8 @@
if ( from === 'proofread' ) {
languageStats[ i
].proofread--;
}
- if ( from === 'translated' ) {
+ // Proofreading a message does
not remove translation
+ if ( from === 'translated' &&
to !== 'proofread' ) {
languageStats[ i
].translated--;
}
break;
--
To view, visit https://gerrit.wikimedia.org/r/294071
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied2e57bb202e8eb082068069c8a808649bf43c9d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
