[MediaWiki-commits] [Gerrit] Remove ContentFixers from Parsoid API - change (mediawiki...Flow)
jenkins-bot has submitted this change and it was merged.
Change subject: Remove ContentFixers from Parsoid API
..
Remove ContentFixers from Parsoid API
Those ContentFixers are very Flow-specific. They're workarounds
for the fact that we store static HTML that can't reflect
changes in links (redlinks, bad images), or for the location
we serve them at (we can't wrap in )
None of those fixers apply to VE (which actually is Parsoid's
main consumer, so bare Parsoid should likely work best)
Preview also used to use this API (and that one needed the
content fixes), but that's being removed as we use VE.
Bug: T93814
Change-Id: I915634ca51f330cd80bac749658ba9b19109c68f
---
M includes/Api/ApiParsoidUtilsFlow.php
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
Mattflaschen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Api/ApiParsoidUtilsFlow.php
b/includes/Api/ApiParsoidUtilsFlow.php
index d24dcc4..d16ccc5 100644
--- a/includes/Api/ApiParsoidUtilsFlow.php
+++ b/includes/Api/ApiParsoidUtilsFlow.php
@@ -23,12 +23,6 @@
return; // helps static analysis know execution does
not continue past self::dieUsage
}
- if ( $params['to'] === 'html' ) {
- /** @var ContentFixer $contentFixer */
- $contentFixer = Container::get( 'content_fixer' );
- $content = $contentFixer->apply( $content,
$page->getTitle() );
- }
-
$result = array(
'format' => $params['to'],
'content' => $content,
--
To view, visit https://gerrit.wikimedia.org/r/201158
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I915634ca51f330cd80bac749658ba9b19109c68f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie
Gerrit-Reviewer: Legoktm
Gerrit-Reviewer: Mattflaschen
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove ContentFixers from Parsoid API - change (mediawiki...Flow)
Matthias Mullie has uploaded a new change for review.
https://gerrit.wikimedia.org/r/201158
Change subject: Remove ContentFixers from Parsoid API
..
Remove ContentFixers from Parsoid API
Those ContentFixers are very Flow-specific. They're workarounds
for the fact that we store static HTML that can't reflect
changes in links (redlinks, bad images), or for the location
we serve them at (we can't wrap in )
None of those fixers apply to VE (which actually is Parsoid's
main consumer, so bare Parsoid should likely work best)
Preview also used to use this API (and that one needed the
content fixes), but that's being removed as we use VE.
Bug: T93814
Change-Id: I915634ca51f330cd80bac749658ba9b19109c68f
---
M includes/Api/ApiParsoidUtilsFlow.php
1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/58/201158/1
diff --git a/includes/Api/ApiParsoidUtilsFlow.php
b/includes/Api/ApiParsoidUtilsFlow.php
index d24dcc4..d16ccc5 100644
--- a/includes/Api/ApiParsoidUtilsFlow.php
+++ b/includes/Api/ApiParsoidUtilsFlow.php
@@ -23,12 +23,6 @@
return; // helps static analysis know execution does
not continue past self::dieUsage
}
- if ( $params['to'] === 'html' ) {
- /** @var ContentFixer $contentFixer */
- $contentFixer = Container::get( 'content_fixer' );
- $content = $contentFixer->apply( $content,
$page->getTitle() );
- }
-
$result = array(
'format' => $params['to'],
'content' => $content,
--
To view, visit https://gerrit.wikimedia.org/r/201158
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I915634ca51f330cd80bac749658ba9b19109c68f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
