[MediaWiki-commits] [Gerrit] Revert "Honor system font size setting in WebView" - change (apps...wikipedia)

2014-06-09 Thread BearND (Code Review)
BearND has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/138372

Change subject: Revert "Honor system font size setting in WebView"
..

Revert "Honor system font size setting in WebView"

This reverts commit ad4d74ce79dbfe29eb32b2205c71d5d256c2287c.

Change-Id: Ic7f1c3e9257af1bcd13485c94efbe57cd8a9e8b2
---
M wikipedia/res/values/dimens.xml
M wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
2 files changed, 0 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/72/138372/1

diff --git a/wikipedia/res/values/dimens.xml b/wikipedia/res/values/dimens.xml
index 7bce777..a6dd140 100644
--- a/wikipedia/res/values/dimens.xml
+++ b/wikipedia/res/values/dimens.xml
@@ -4,7 +4,4 @@
 16dp
 16dp
 
-
-8sp
-
 
\ No newline at end of file
diff --git a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java 
b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
index 2bed615..a3df5a3 100644
--- a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
@@ -1,7 +1,6 @@
 package org.wikipedia.page;
 
 import android.content.Intent;
-import android.content.res.Resources;
 import android.os.Build;
 import android.os.Bundle;
 import android.support.v4.app.Fragment;
@@ -271,10 +270,6 @@
 // disable TOC drawer until the page is loaded
 tocDrawer.setSlidingEnabled(false);
 searchArticlesFragment.setTocEnabled(false);
-
-// Adjust font size based on system settings
-float fontSize = getResources().getDimension(R.dimen.textSize);
-webView.getSettings().setDefaultFontSize((int) fontSize);
 
 if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.HONEYCOMB) {
 // Enable Pinch-Zoom

-- 
To view, visit https://gerrit.wikimedia.org/r/138372
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7f1c3e9257af1bcd13485c94efbe57cd8a9e8b2
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: BearND 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Revert "Honor system font size setting in WebView" - change (apps...wikipedia)

2014-06-09 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/138373

Change subject: Revert "Honor system font size setting in WebView"
..

Revert "Honor system font size setting in WebView"

Feature appears to be broken; huge fonts on xxhdpi devices. Needs to get the 
'dp' size of an 'sp' or something, rather than the raw pixel size?

This reverts commit ad4d74ce79dbfe29eb32b2205c71d5d256c2287c.

Change-Id: I0a3a143681884a3ec3639486ac58c26e81d15315
---
M wikipedia/res/values/dimens.xml
M wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
2 files changed, 0 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/73/138373/1

diff --git a/wikipedia/res/values/dimens.xml b/wikipedia/res/values/dimens.xml
index 7bce777..a6dd140 100644
--- a/wikipedia/res/values/dimens.xml
+++ b/wikipedia/res/values/dimens.xml
@@ -4,7 +4,4 @@
 16dp
 16dp
 
-
-8sp
-
 
\ No newline at end of file
diff --git a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java 
b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
index 2bed615..a3df5a3 100644
--- a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
@@ -1,7 +1,6 @@
 package org.wikipedia.page;
 
 import android.content.Intent;
-import android.content.res.Resources;
 import android.os.Build;
 import android.os.Bundle;
 import android.support.v4.app.Fragment;
@@ -271,10 +270,6 @@
 // disable TOC drawer until the page is loaded
 tocDrawer.setSlidingEnabled(false);
 searchArticlesFragment.setTocEnabled(false);
-
-// Adjust font size based on system settings
-float fontSize = getResources().getDimension(R.dimen.textSize);
-webView.getSettings().setDefaultFontSize((int) fontSize);
 
 if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.HONEYCOMB) {
 // Enable Pinch-Zoom

-- 
To view, visit https://gerrit.wikimedia.org/r/138373
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a3a143681884a3ec3639486ac58c26e81d15315
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Revert "Honor system font size setting in WebView" - change (apps...wikipedia)

2014-06-09 Thread Dbrant (Code Review)
Dbrant has submitted this change and it was merged.

Change subject: Revert "Honor system font size setting in WebView"
..


Revert "Honor system font size setting in WebView"

This reverts commit ad4d74ce79dbfe29eb32b2205c71d5d256c2287c.

Change-Id: Ic7f1c3e9257af1bcd13485c94efbe57cd8a9e8b2
---
M wikipedia/res/values/dimens.xml
M wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
2 files changed, 0 insertions(+), 8 deletions(-)

Approvals:
  Dbrant: Looks good to me, approved



diff --git a/wikipedia/res/values/dimens.xml b/wikipedia/res/values/dimens.xml
index 7bce777..a6dd140 100644
--- a/wikipedia/res/values/dimens.xml
+++ b/wikipedia/res/values/dimens.xml
@@ -4,7 +4,4 @@
 16dp
 16dp
 
-
-8sp
-
 
\ No newline at end of file
diff --git a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java 
b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
index 2bed615..a3df5a3 100644
--- a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
@@ -1,7 +1,6 @@
 package org.wikipedia.page;
 
 import android.content.Intent;
-import android.content.res.Resources;
 import android.os.Build;
 import android.os.Bundle;
 import android.support.v4.app.Fragment;
@@ -271,10 +270,6 @@
 // disable TOC drawer until the page is loaded
 tocDrawer.setSlidingEnabled(false);
 searchArticlesFragment.setTocEnabled(false);
-
-// Adjust font size based on system settings
-float fontSize = getResources().getDimension(R.dimen.textSize);
-webView.getSettings().setDefaultFontSize((int) fontSize);
 
 if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.HONEYCOMB) {
 // Enable Pinch-Zoom

-- 
To view, visit https://gerrit.wikimedia.org/r/138372
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7f1c3e9257af1bcd13485c94efbe57cd8a9e8b2
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: BearND 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits