[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: suppress autoMirrored API level warnings
jenkins-bot has submitted this change and it was merged. Change subject: Hygiene: suppress autoMirrored API level warnings .. Hygiene: suppress autoMirrored API level warnings We should commit to ignoring these warnings or fixing them on API 18 and 19. From the docs[0]: On previous versions of Android, if your app includes images that should reverse their horizontal orientation for right-to-left layouts, you must include the mirrored image in a drawables-ldrtl/ resource directory. This patch takes the ignore route because it's easy and uses less space. [0] https://developer.android.com/about/versions/android-4.4.html#DrawableMirroring Change-Id: I09a0d8427bda1b4e4c1d2fa1e0df36d7aca57f09 --- M app/src/main/res/drawable/ic_arrow_forward_black_24dp.xml M app/src/main/res/drawable/ic_collections_bookmark_black_24dp.xml M app/src/main/res/drawable/ic_file_download.xml M app/src/main/res/drawable/ic_find_in_page.xml M app/src/main/res/drawable/ic_flag_black_24dp.xml M app/src/main/res/drawable/ic_image_gray_24dp.xml M app/src/main/res/drawable/ic_list_white_24dp.xml M app/src/main/res/drawable/ic_mode_edit_white_24dp.xml M app/src/main/res/drawable/ic_most_read.xml M app/src/main/res/drawable/ic_restore_black_24dp.xml M app/src/main/res/drawable/ic_share_black_24dp.xml M app/src/main/res/drawable/ic_share_white_24dp.xml M app/src/main/res/drawable/ic_sort_white_24dp.xml M app/src/main/res/drawable/ic_subdirectory_arrow_right_black_24dp.xml M app/src/main/res/drawable/ic_translate_white_24dp.xml M app/src/main/res/drawable/icon_in_the_news.xml 16 files changed, 65 insertions(+), 33 deletions(-) Approvals: Mholloway: Looks good to me, but someone else must approve Dbrant: Looks good to me, approved jenkins-bot: Verified diff --git a/app/src/main/res/drawable/ic_arrow_forward_black_24dp.xml b/app/src/main/res/drawable/ic_arrow_forward_black_24dp.xml index 0d8872d..7cda61b 100644 --- a/app/src/main/res/drawable/ic_arrow_forward_black_24dp.xml +++ b/app/src/main/res/drawable/ic_arrow_forward_black_24dp.xml @@ -1,5 +1,7 @@ -http://schemas.android.com/tools"; +android:autoMirrored="true" android:height="24dp" android:viewportHeight="24.0" android:viewportWidth="24.0" -android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android";> +android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android"; +tools:ignore="UnusedAttribute"> diff --git a/app/src/main/res/drawable/ic_collections_bookmark_black_24dp.xml b/app/src/main/res/drawable/ic_collections_bookmark_black_24dp.xml index c89a4ed..5b78ab9 100644 --- a/app/src/main/res/drawable/ic_collections_bookmark_black_24dp.xml +++ b/app/src/main/res/drawable/ic_collections_bookmark_black_24dp.xml @@ -1,9 +1,11 @@ http://schemas.android.com/apk/res/android"; -android:autoMirrored="true" -android:width="24dp" -android:height="24dp" -android:viewportWidth="24.0" -android:viewportHeight="24.0"> +xmlns:tools="http://schemas.android.com/tools"; +android:autoMirrored="true" +android:width="24dp" +android:height="24dp" +android:viewportWidth="24.0" +android:viewportHeight="24.0" +tools:ignore="UnusedAttribute"> diff --git a/app/src/main/res/drawable/ic_file_download.xml b/app/src/main/res/drawable/ic_file_download.xml index da16642..87dad3f 100644 --- a/app/src/main/res/drawable/ic_file_download.xml +++ b/app/src/main/res/drawable/ic_file_download.xml @@ -1,6 +1,8 @@ -http://schemas.android.com/tools"; +android:autoMirrored="true" android:height="17dp" android:viewportHeight="17.0" android:viewportWidth="14.0" -android:width="14dp" xmlns:android="http://schemas.android.com/apk/res/android";> +android:width="14dp" xmlns:android="http://schemas.android.com/apk/res/android"; +tools:ignore="UnusedAttribute"> diff --git a/app/src/main/res/drawable/ic_find_in_page.xml b/app/src/main/res/drawable/ic_find_in_page.xml index 77acb13..085a2bf 100644 --- a/app/src/main/res/drawable/ic_find_in_page.xml +++ b/app/src/main/res/drawable/ic_find_in_page.xml @@ -1,5 +1,7 @@ -http://schemas.android.com/tools"; +android:autoMirrored="true" android:height="24dp" android:viewportHeight="24.0" android:viewportWidth="24.0" -android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android";> +android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android"; +tools:ignore="UnusedAttribute"> diff --git a/app/src/main/res/drawable/ic_flag_black_24dp.xml b/app/src/main/res/drawable/ic_flag_black_24dp.xml index 4b8a250..15a3a50 100644 --- a/app/src/main/res/drawable/ic_flag_black_24dp.xml +++ b/app/src/main/res/drawable/ic_flag_black_24dp.xml @@ -1,5 +1,7 @@ -http://schemas.android.com/tools"; +android:autoMirrored="true" android:height="24dp" android:viewportHeight="24.0" android:v
[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: suppress autoMirrored API level warnings
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/316986 Change subject: Hygiene: suppress autoMirrored API level warnings .. Hygiene: suppress autoMirrored API level warnings We should commit to ignoring these warnings or fixing them on API 18 and 19. From the docs[0]: On previous versions of Android, if your app includes images that should reverse their horizontal orientation for right-to-left layouts, you must include the mirrored image in a drawables-ldrtl/ resource directory. This patch takes the ignore route because it's easy and uses less space. [0] https://developer.android.com/about/versions/android-4.4.html#DrawableMirroring Change-Id: I09a0d8427bda1b4e4c1d2fa1e0df36d7aca57f09 --- M app/src/main/res/drawable/ic_arrow_forward_black_24dp.xml M app/src/main/res/drawable/ic_collections_bookmark_black_24dp.xml M app/src/main/res/drawable/ic_exit_to_app_black_24dp.xml M app/src/main/res/drawable/ic_file_download.xml M app/src/main/res/drawable/ic_find_in_page.xml M app/src/main/res/drawable/ic_flag_black_24dp.xml M app/src/main/res/drawable/ic_image_gray_24dp.xml M app/src/main/res/drawable/ic_list_white_24dp.xml M app/src/main/res/drawable/ic_mode_edit_white_24dp.xml M app/src/main/res/drawable/ic_most_read.xml M app/src/main/res/drawable/ic_refresh_white_24dp.xml M app/src/main/res/drawable/ic_restore_black_24dp.xml M app/src/main/res/drawable/ic_share_black_24dp.xml M app/src/main/res/drawable/ic_share_white_24dp.xml M app/src/main/res/drawable/ic_sort_white_24dp.xml M app/src/main/res/drawable/ic_subdirectory_arrow_right_black_24dp.xml M app/src/main/res/drawable/ic_translate_white_24dp.xml M app/src/main/res/drawable/icon_in_the_news.xml 18 files changed, 70 insertions(+), 34 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/86/316986/1 diff --git a/app/src/main/res/drawable/ic_arrow_forward_black_24dp.xml b/app/src/main/res/drawable/ic_arrow_forward_black_24dp.xml index 0d8872d..7cda61b 100644 --- a/app/src/main/res/drawable/ic_arrow_forward_black_24dp.xml +++ b/app/src/main/res/drawable/ic_arrow_forward_black_24dp.xml @@ -1,5 +1,7 @@ -http://schemas.android.com/tools"; +android:autoMirrored="true" android:height="24dp" android:viewportHeight="24.0" android:viewportWidth="24.0" -android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android";> +android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android"; +tools:ignore="UnusedAttribute"> diff --git a/app/src/main/res/drawable/ic_collections_bookmark_black_24dp.xml b/app/src/main/res/drawable/ic_collections_bookmark_black_24dp.xml index c89a4ed..ef020fb 100644 --- a/app/src/main/res/drawable/ic_collections_bookmark_black_24dp.xml +++ b/app/src/main/res/drawable/ic_collections_bookmark_black_24dp.xml @@ -1,9 +1,11 @@ http://schemas.android.com/apk/res/android"; -android:autoMirrored="true" +xmlns:tools="http://schemas.android.com/tools"; +android:autoMirrored="true" android:width="24dp" android:height="24dp" android:viewportWidth="24.0" -android:viewportHeight="24.0"> +android:viewportHeight="24.0" +tools:ignore="UnusedAttribute"> diff --git a/app/src/main/res/drawable/ic_exit_to_app_black_24dp.xml b/app/src/main/res/drawable/ic_exit_to_app_black_24dp.xml index 5248d32..e6a09ca 100644 --- a/app/src/main/res/drawable/ic_exit_to_app_black_24dp.xml +++ b/app/src/main/res/drawable/ic_exit_to_app_black_24dp.xml @@ -1,5 +1,7 @@ -http://schemas.android.com/tools"; +android:autoMirrored="true" android:height="24dp" android:viewportHeight="24.0" android:viewportWidth="24.0" -android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android";> +android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android"; +tools:ignore="UnusedAttribute"> diff --git a/app/src/main/res/drawable/ic_file_download.xml b/app/src/main/res/drawable/ic_file_download.xml index da16642..87dad3f 100644 --- a/app/src/main/res/drawable/ic_file_download.xml +++ b/app/src/main/res/drawable/ic_file_download.xml @@ -1,6 +1,8 @@ -http://schemas.android.com/tools"; +android:autoMirrored="true" android:height="17dp" android:viewportHeight="17.0" android:viewportWidth="14.0" -android:width="14dp" xmlns:android="http://schemas.android.com/apk/res/android";> +android:width="14dp" xmlns:android="http://schemas.android.com/apk/res/android"; +tools:ignore="UnusedAttribute"> diff --git a/app/src/main/res/drawable/ic_find_in_page.xml b/app/src/main/res/drawable/ic_find_in_page.xml index 77acb13..085a2bf 100644 --- a/app/src/main/res/drawable/ic_find_in_page.xml +++ b/app/src/main/res/drawable/ic_find_in_page.xml @@ -1,5 +1,7 @@ -http://schemas.android.com/tools"; +android:autoMirrored="true" android:height="2
