[MediaWiki-commits] [Gerrit] mediawiki...CentralNotice[master]: Add FIXME comments in centralnotice.js

2017-04-03 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/345864 )

Change subject: Add FIXME comments in centralnotice.js
..


Add FIXME comments in centralnotice.js

Change-Id: Id5c2b496a36343bc5fad5ee54412313c013ee9d9
Bug: T144453
---
M resources/infrastructure/centralnotice.js
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Awight: Looks good to me, approved



diff --git a/resources/infrastructure/centralnotice.js 
b/resources/infrastructure/centralnotice.js
index f90f4f0..59935b9 100644
--- a/resources/infrastructure/centralnotice.js
+++ b/resources/infrastructure/centralnotice.js
@@ -1,6 +1,10 @@
 /**
  * CentralNotice Administrative UI - Common Functions
  */
+
+// FIXME Encapsulate logic specific to Special:CentralNoticeLogs
+// FIXME Global functions
+
 ( function ( mw, $ ) {
mw.centralNotice = mw.centralNotice || {};
mw.centralNotice.adminUi = {};
@@ -81,8 +85,8 @@
);
 
// Do the fancy multiselector; but we have to wait for some 
arbitrary time until the
-   // CSS has been applied... Yes, this is an egregious hack until 
I rewrite the mutliselector
-   // to NOT suck -- e.g. make it dynamic... whoo...
+   // CSS has been applied.
+   // FIXME This is a hack.
setTimeout( function () {
$( 'select[multiple="multiple"]' ).multiselect(
{ sortable: false, dividerLocation: 0.5 }

-- 
To view, visit https://gerrit.wikimedia.org/r/345864
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id5c2b496a36343bc5fad5ee54412313c013ee9d9
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: AndyRussG 
Gerrit-Reviewer: Awight 
Gerrit-Reviewer: Cdentinger 
Gerrit-Reviewer: Ejegg 
Gerrit-Reviewer: Ssmith 
Gerrit-Reviewer: XenoRyet 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CentralNotice[master]: Add FIXME comments in centralnotice.js

2017-03-31 Thread AndyRussG (Code Review) 
AndyRussG has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/345864 )

Change subject: Add FIXME comments in centralnotice.js
..

Add FIXME comments in centralnotice.js

Change-Id: Id5c2b496a36343bc5fad5ee54412313c013ee9d9
---
M resources/infrastructure/centralnotice.js
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice 
refs/changes/64/345864/1

diff --git a/resources/infrastructure/centralnotice.js 
b/resources/infrastructure/centralnotice.js
index f90f4f0..59935b9 100644
--- a/resources/infrastructure/centralnotice.js
+++ b/resources/infrastructure/centralnotice.js
@@ -1,6 +1,10 @@
 /**
  * CentralNotice Administrative UI - Common Functions
  */
+
+// FIXME Encapsulate logic specific to Special:CentralNoticeLogs
+// FIXME Global functions
+
 ( function ( mw, $ ) {
mw.centralNotice = mw.centralNotice || {};
mw.centralNotice.adminUi = {};
@@ -81,8 +85,8 @@
);
 
// Do the fancy multiselector; but we have to wait for some 
arbitrary time until the
-   // CSS has been applied... Yes, this is an egregious hack until 
I rewrite the mutliselector
-   // to NOT suck -- e.g. make it dynamic... whoo...
+   // CSS has been applied.
+   // FIXME This is a hack.
setTimeout( function () {
$( 'select[multiple="multiple"]' ).multiselect(
{ sortable: false, dividerLocation: 0.5 }

-- 
To view, visit https://gerrit.wikimedia.org/r/345864
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5c2b496a36343bc5fad5ee54412313c013ee9d9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: AndyRussG 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits