[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: Replace deprecated attribute "width" with CSS "width" property

2016-12-31 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/329701 )

Change subject: Replace deprecated attribute "width" with CSS "width" property
..


Replace deprecated attribute "width" with CSS "width" property

The width attribute is deprecated in HTML5. It should use the CSS width 
property instead. For example, width='100%' should be replaced with 
style="width: 100%;".

Bug: T42211
Change-Id: I34f7819b0615e951c0f433cfbbaff5bcc32784b0
---
M frontend/FlaggablePageView.php
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Fomafix: Looks good to me, but someone else must approve
  Florianschmidtwelzow: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/frontend/FlaggablePageView.php b/frontend/FlaggablePageView.php
index 64941ec..610fcaa 100755
--- a/frontend/FlaggablePageView.php
+++ b/frontend/FlaggablePageView.php
@@ -828,15 +828,15 @@
$multiNotice . "";
}
return
-   "" .
+   "" .
"" .
"" .
"" .
"" .
"" .
-   "" .
+   "" .
$leftStatus . "" .
-   "" .
+   "" .
$rightStatus . "" .
"" .
$multiNotice .
@@ -1612,13 +1612,13 @@
if ( $oldRev && $newRev ) {
list( $msg, $class ) = self::getDiffRevMsgAndClass( 
$oldRev, $srev );
$table .= "";
-   $table .= "";
+   $table .= "";
// @todo i18n FIXME: Hard coded brackets
$table .= "[" .
wfMessage( $msg )->escaped() . "]";
 
list( $msg, $class ) = self::getDiffRevMsgAndClass( 
$newRev, $srev );
-   $table .= "";
+   $table .= "";
// @todo i18n FIXME: Hard coded brackets
$table .= "[" .
wfMessage( $msg )->escaped() . "]";

-- 
To view, visit https://gerrit.wikimedia.org/r/329701
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I34f7819b0615e951c0f433cfbbaff5bcc32784b0
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: MtDu 
Gerrit-Reviewer: Aklapper 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: Fomafix 
Gerrit-Reviewer: Jackmcbarn 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: Replace deprecated attribute "width" with CSS "width" property

2016-12-30 Thread MtDu (Code Review) 
MtDu has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/329701 )

Change subject: Replace deprecated attribute "width" with CSS "width" property
..

Replace deprecated attribute "width" with CSS "width" property

The width attribute is deprecated in HTML5. It should use the CSS width 
property instead. For example, width='100%' should be replaced with 
style="width: 100%;"

Bug: T42211
Change-Id: I34f7819b0615e951c0f433cfbbaff5bcc32784b0
---
M frontend/FlaggablePageView.php
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs 
refs/changes/01/329701/1

diff --git a/frontend/FlaggablePageView.php b/frontend/FlaggablePageView.php
index 64941ec..670bfe6 100755
--- a/frontend/FlaggablePageView.php
+++ b/frontend/FlaggablePageView.php
@@ -828,15 +828,15 @@
$multiNotice . "";
}
return
-   "" .
+   "" .
"" .
"" .
"" .
"" .
"" .
-   "" .
+   "" .
$leftStatus . "" .
-   "" .
+   "" .
$rightStatus . "" .
"" .
$multiNotice .
@@ -1612,13 +1612,13 @@
if ( $oldRev && $newRev ) {
list( $msg, $class ) = self::getDiffRevMsgAndClass( 
$oldRev, $srev );
$table .= "";
-   $table .= "";
+   $table .= "";
// @todo i18n FIXME: Hard coded brackets
$table .= "[" .
wfMessage( $msg )->escaped() . "]";
 
list( $msg, $class ) = self::getDiffRevMsgAndClass( 
$newRev, $srev );
-   $table .= "";
+   $table .= "";
// @todo i18n FIXME: Hard coded brackets
$table .= "[" .
wfMessage( $msg )->escaped() . "]";

-- 
To view, visit https://gerrit.wikimedia.org/r/329701
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I34f7819b0615e951c0f433cfbbaff5bcc32784b0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: MtDu 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits