D7501: changectx: use unfiltered changelog to walk ancestors in annotate
Closed by commit rHGc472970339d2: changectx: use unfiltered changelog to walk ancestors in annotate (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7501?vs=19365=19413 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7501/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7501 AFFECTED FILES mercurial/context.py tests/test-repo-filters-tiptoe.t CHANGE DETAILS diff --git a/tests/test-repo-filters-tiptoe.t b/tests/test-repo-filters-tiptoe.t --- a/tests/test-repo-filters-tiptoe.t +++ b/tests/test-repo-filters-tiptoe.t @@ -136,13 +136,11 @@ - file with a single change $ hg annotate a - debug.filters: computing revision filter for "visible" 0: a - file with multiple change $ hg annotate z - debug.filters: computing revision filter for "visible" 0: some line 1: in a 2: file diff --git a/mercurial/context.py b/mercurial/context.py --- a/mercurial/context.py +++ b/mercurial/context.py @@ -1161,7 +1161,9 @@ # use linkrev to find the first changeset where self appeared base = self.introfilectx() if getattr(base, '_ancestrycontext', None) is None: -cl = self._repo.changelog +# it is safe to use an unfiltered repository here because we are +# walking ancestors only. +cl = self._repo.unfiltered().changelog if base.rev() is None: # wctx is not inclusive, but works because _ancestrycontext # is used to test filelog revisions To: marmoute, #hg-reviewers, pulkit Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D7501: changectx: use unfiltered changelog to walk ancestors in annotate
Alphare updated this revision to Diff 19365. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7501?vs=18386=19365 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7501/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7501 AFFECTED FILES mercurial/context.py tests/test-repo-filters-tiptoe.t CHANGE DETAILS diff --git a/tests/test-repo-filters-tiptoe.t b/tests/test-repo-filters-tiptoe.t --- a/tests/test-repo-filters-tiptoe.t +++ b/tests/test-repo-filters-tiptoe.t @@ -136,13 +136,11 @@ - file with a single change $ hg annotate a - debug.filters: computing revision filter for "visible" 0: a - file with multiple change $ hg annotate z - debug.filters: computing revision filter for "visible" 0: some line 1: in a 2: file diff --git a/mercurial/context.py b/mercurial/context.py --- a/mercurial/context.py +++ b/mercurial/context.py @@ -1161,7 +1161,9 @@ # use linkrev to find the first changeset where self appeared base = self.introfilectx() if getattr(base, '_ancestrycontext', None) is None: -cl = self._repo.changelog +# it is safe to use an unfiltered repository here because we are +# walking ancestors only. +cl = self._repo.unfiltered().changelog if base.rev() is None: # wctx is not inclusive, but works because _ancestrycontext # is used to test filelog revisions To: marmoute, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D7501: changectx: use unfiltered changelog to walk ancestors in annotate
marmoute updated this revision to Diff 18386. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7501?vs=18366=18386 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7501/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7501 AFFECTED FILES mercurial/context.py tests/test-repo-filters-tiptoe.t CHANGE DETAILS diff --git a/tests/test-repo-filters-tiptoe.t b/tests/test-repo-filters-tiptoe.t --- a/tests/test-repo-filters-tiptoe.t +++ b/tests/test-repo-filters-tiptoe.t @@ -136,13 +136,11 @@ - file with a single change $ hg annotate a - debug.filters: computing revision filter for "visible" 0: a - file with multiple change $ hg annotate z - debug.filters: computing revision filter for "visible" 0: some line 1: in a 2: file diff --git a/mercurial/context.py b/mercurial/context.py --- a/mercurial/context.py +++ b/mercurial/context.py @@ -1158,7 +1158,9 @@ # use linkrev to find the first changeset where self appeared base = self.introfilectx() if getattr(base, '_ancestrycontext', None) is None: -cl = self._repo.changelog +# it is safe to use an unfiltered repository here because we are +# walking ancestors only. +cl = self._repo.unfiltered().changelog if base.rev() is None: # wctx is not inclusive, but works because _ancestrycontext # is used to test filelog revisions To: marmoute, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D7501: changectx: use unfiltered changelog to walk ancestors in annotate
marmoute updated this revision to Diff 18366. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7501?vs=18308=18366 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7501/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7501 AFFECTED FILES mercurial/context.py tests/test-repo-filters-tiptoe.t CHANGE DETAILS diff --git a/tests/test-repo-filters-tiptoe.t b/tests/test-repo-filters-tiptoe.t --- a/tests/test-repo-filters-tiptoe.t +++ b/tests/test-repo-filters-tiptoe.t @@ -136,13 +136,11 @@ - file with a single change $ hg annotate a - debug.filters: computing revision filter for "visible" 0: a - file with multiple change $ hg annotate z - debug.filters: computing revision filter for "visible" 0: some line 1: in a 2: file diff --git a/mercurial/context.py b/mercurial/context.py --- a/mercurial/context.py +++ b/mercurial/context.py @@ -1158,7 +1158,9 @@ # use linkrev to find the first changeset where self appeared base = self.introfilectx() if getattr(base, '_ancestrycontext', None) is None: -cl = self._repo.changelog +# it is safe to use an unfiltered repository here because we are +# walking ancestors only. +cl = self._repo.unfiltered().changelog if base.rev() is None: # wctx is not inclusive, but works because _ancestrycontext # is used to test filelog revisions To: marmoute, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D7501: changectx: use unfiltered changelog to walk ancestors in annotate
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Since we are only walking ancestors, it is safe to use an unfiltered repository. (Because if the original rev is not filtered, none of its ancestors will be). REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7501 AFFECTED FILES mercurial/context.py tests/test-repo-filters-tiptoe.t CHANGE DETAILS diff --git a/tests/test-repo-filters-tiptoe.t b/tests/test-repo-filters-tiptoe.t --- a/tests/test-repo-filters-tiptoe.t +++ b/tests/test-repo-filters-tiptoe.t @@ -136,13 +136,11 @@ - file with a single change $ hg annotate a - debug.filters: computing revision filter for "visible" 0: a - file with multiple change $ hg annotate z - debug.filters: computing revision filter for "visible" 0: some line 1: in a 2: file diff --git a/mercurial/context.py b/mercurial/context.py --- a/mercurial/context.py +++ b/mercurial/context.py @@ -1152,7 +1152,9 @@ # use linkrev to find the first changeset where self appeared base = self.introfilectx() if getattr(base, '_ancestrycontext', None) is None: -cl = self._repo.changelog +# it is safe to use an unfiltered repository here because we are +# walking ancestors only. +cl = self._repo.unfiltered().changelog if base.rev() is None: # wctx is not inclusive, but works because _ancestrycontext # is used to test filelog revisions To: marmoute, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
